[CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
[WebKit-https.git] / Tools / ChangeLog
index 7afbe31..fa409e7 100644 (file)
+2019-02-20  Don Olmstead  <don.olmstead@sony.com>
+
+        [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
+        https://bugs.webkit.org/show_bug.cgi?id=194884
+
+        Reviewed by Michael Catanzaro.
+
+        * PlatformWin.cmake:
+
+2019-02-20  Chris Dumez  <cdumez@apple.com>
+
+        Add API test for <rdar://problem/47471222>
+        https://bugs.webkit.org/show_bug.cgi?id=194847
+
+        Reviewed by Alex Christensen.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-02-20  Chris Dumez  <cdumez@apple.com>
+
+        Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
+        https://bugs.webkit.org/show_bug.cgi?id=194872
+        <rdar://problem/47924500>
+
+        Reviewed by Alex Christensen.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-02-20  Jer Noble  <jer.noble@apple.com>
+
+        Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
+        https://bugs.webkit.org/show_bug.cgi?id=191332
+
+        Reviewed by Dean Jackson.
+
+        * Scripts/git-is-in-range: Added.
+
+2019-02-20  Andy Estes  <aestes@apple.com>
+
+        [Xcode] Add SDKVariant.xcconfig to various Xcode projects
+        https://bugs.webkit.org/show_bug.cgi?id=194869
+
+        Rubber-stamped by Jer Noble.
+
+        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
+        * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
+        * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
+        * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
+
+2019-02-20  Chris Dumez  <cdumez@apple.com>
+
+        Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
+        https://bugs.webkit.org/show_bug.cgi?id=194857
+        <rdar://problem/47759323>
+
+        Reviewed by Alex Christensen.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-02-20  Chris Dumez  <cdumez@apple.com>
+
+        [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=194829
+        <rdar://problem/47889906>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Every time the TestOptions were changing we were creating both a new Web view and
+        a new WKContext, which would start a new Network process. In most cases, we only
+        need to contruct a new Web view and we do can keep reusing the same WKContext.
+        This patch implements this optimization and thus avoids spinning a lot of new
+        Network processes while running the layout tests.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::generateContextConfiguration const):
+        (WTR::TestController::generatePageConfiguration):
+        (WTR::TestController::createWebViewWithOptions):
+        (WTR::TestController::resetPreferencesToConsistentValues):
+        (WTR::updateTestOptionsFromTestHeader):
+        * WebKitTestRunner/TestController.h:
+        * WebKitTestRunner/TestOptions.h:
+        (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
+        (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
+        (WTR::TestOptions::hasSameInitializationOptions const):
+        (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
+        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
+        (WTR::TestController::platformAddTestOptions const):
+
+2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
+
+        [WPE][GTK] Enable support for CONTENT_EXTENSIONS
+        https://bugs.webkit.org/show_bug.cgi?id=167941
+
+        Reviewed by Carlos Garcia Campos.
+
+        * MiniBrowser/gtk/main.c:
+        (filterSavedCallback): Added.
+        (main): Support loading a JSON rule set file for content filtering.
+        * MiniBrowser/wpe/main.cpp:
+        (filterSavedCallback): Added.
+        (main): Support loading a JSON rule set file for content filtering.
+        * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
+        (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
+        (WTF::derefGPtr): Ditto.
+        (testEmptyStore):
+        (testSaveInvalidFilter):
+        (testSaveLoadFilter):
+        (testSavedFilterIdentifierMatch):
+        (testRemoveFilter):
+        (testSaveMultipleFilters):
+        (testSaveFilterFromFile):
+        (testFilterPersistence):
+        (beforeAll):
+        (afterAll):
+        * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
+        (removeOldInjectedContentAndResetLists): Also reset content filters.
+        (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
+        CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
+        the element affected by the style sheet.
+        (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
+        and returns it to be used by tests.
+        (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
+        from the WebKitUserContentManager results in the a CSS style sheet being blocked.
+        (serverCallback): Add support for serving a CSS style sheet for testing.
+        (beforeAll): Add call to testUserContentManagerContentFilter().
+        * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
+
+2019-02-19  Keith Rollin  <krollin@apple.com>
+
+        Add timing information to build output
+        https://bugs.webkit.org/show_bug.cgi?id=194839
+        <rdar://problem/48219609>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Configure xcodebuild with -ShowBuildOperationDuration, causing it to
+        emit each project's build time to its output. E.g.,
+
+            ** BUILD SUCCEEDED ** [0.132 sec]
+
+        * Scripts/webkitdirs.pm:
+        (XcodeOptions):
+
+2019-02-19  Truitt Savell  <tsavell@apple.com>
+
+        Unreviewed, rolling out r241784.
+
+        Broke all OpenSource builds.
+
+        Reverted changeset:
+
+        "Web Inspector: Improve ES6 Class instances in Heap Snapshot
+        instances view"
+        https://bugs.webkit.org/show_bug.cgi?id=172848
+        https://trac.webkit.org/changeset/241784
+
+2019-02-19  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][Floats] Remove redundant intersecting logic
+        https://bugs.webkit.org/show_bug.cgi?id=194804
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-02-19  Dean Jackson  <dino@apple.com>
+
+        Clean-up output from generate-xcfilelists so it can be filtered
+        https://bugs.webkit.org/show_bug.cgi?id=194795
+
+        Reviewed by Joseph Pecoraro (and Keith Rollin).
+
+        Replace the "..." with "GXCF:" in generate-xcfilelists output, and
+        make a slight tweak to filter-build-webkit so such lines are marked
+        as plain.
+
+        * Scripts/filter-build-webkit:
+        * Scripts/generate-xcfilelists:
+
+2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
+
+        pytest is not correctly auto-installed
+        https://bugs.webkit.org/show_bug.cgi?id=194707
+
+        Reviewed by Carlos Garcia Campos.
+
+        * Scripts/webkitpy/thirdparty/__init__.py:
+        (AutoinstallImportHook._install_pytest):
+
+2019-02-18  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION (PSON): Can't access optumbank.com from myuhc.com
+        https://bugs.webkit.org/show_bug.cgi?id=194797
+        <rdar://problem/48055151>
+
+        Reviewed by Geoffrey Garen.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
+        https://bugs.webkit.org/show_bug.cgi?id=194670
+        <rdar://problem/39066529>
+
+        Reviewed by Tim Horton.
+
+        Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
+        pasted in an editable area as attachment elements.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
+        (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
+        (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
+        * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
+        (TestWebKitAPI::TEST):
+        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+        (WTR::InjectedBundlePage::InjectedBundlePage):
+
+2019-02-18  Alex Christensen  <achristensen@webkit.org>
+
+        Fix API test after r241728
+       ​https://bugs.webkit.org/show_bug.cgi?id=194723
+
+        * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
+        (TEST):
+        The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
+
+2019-02-18  Daniel Bates  <dabates@apple.com>
+
+        [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
+        https://bugs.webkit.org/show_bug.cgi?id=192824
+        <rdar://problem/47100332>
+
+        Reviewed by Wenson Hsieh.
+
+        Fix a bug where the wrong usage code was used for F13 thru F24.
+
+        * WebKitTestRunner/ios/HIDEventGenerator.mm:
+        (keyCodeForDOMFunctionKey):
+
+2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
+
+        Bytecode cache should a have a boot-specific validation
+        https://bugs.webkit.org/show_bug.cgi?id=194769
+        <rdar://problem/48149509>
+
+        Reviewed by Keith Miller.
+
+        Add test for WTF::bootSessionUUIDString()
+
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+        * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
+        (TEST):
+
+2019-02-18  Alex Christensen  <achristensen@webkit.org>
+
+        Disable safe browsing in WKWebView and remove its WKPreferences API
+        https://bugs.webkit.org/show_bug.cgi?id=194723
+        <rdar://problem/48122993>
+
+        Reviewed by Geoffrey Garen.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+        * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
+        (TEST):
+        (safeBrowsingView):
+        Make tests use SPI instead of API.
+
+2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
+        https://bugs.webkit.org/show_bug.cgi?id=194586
+
+        Reviewed by Ross Kirsling.
+
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
+        * Scripts/webkitpy/port/driver.py:
+        (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
+
+2019-02-17  David Kilzer  <ddkilzer@apple.com>
+
+        Unreviewed, rolling out r241620.
+
+        "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
+        (Requested by ddkilzer on #webkit.)
+
+        Reverted changeset:
+
+        "[WTF] Add environment variable helpers"
+        https://bugs.webkit.org/show_bug.cgi?id=192405
+        https://trac.webkit.org/changeset/241620
+
+2019-02-16  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC] RenderImage's default intrinsic size is 0.
+        https://bugs.webkit.org/show_bug.cgi?id=194745
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-02-16  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][BFC] Add support for block replaced intrinsic width.
+        https://bugs.webkit.org/show_bug.cgi?id=194705
+
+        Reviewed by Simon Fraser.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-02-16  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC] Apply min/max width constraints to preferred width computation
+        https://bugs.webkit.org/show_bug.cgi?id=194739
+
+        Reviewed by Simon Fraser.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
+
+        [WTF] Add environment variable helpers
+        https://bugs.webkit.org/show_bug.cgi?id=192405
+
+        Reviewed by Michael Catanzaro.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (libraryPathForDumpRenderTree):
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (libraryPathForDumpRenderTree):
+        * TestRunnerShared/IOSLayoutTestCommunication.cpp:
+        (setUpIOSLayoutTestCommunication):
+        * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
+        (beforeAll):
+        * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
+        (main):
+        * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
+        (WebKitTestBus::run):
+        * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
+        (WTR::getOutputDir):
+        (WTR::initializeFontConfigSetting):
+        * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
+        (WTR::InjectedBundle::platformInitialize):
+        * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
+        (WTR::topLevelPath):
+        * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
+        (WTR::topLevelPath):
+        (WTR::getOutputDir):
+        (WTR::activateFonts):
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::libraryPathForTesting):
+        (WTR::TestController::generateContextConfiguration const):
+        (WTR::TestController::generatePageConfiguration):
+        (WTR::TestController::decideDestinationWithSuggestedFilename):
+        (WTR::TestController::platformAdjustContext):
+        * WebKitTestRunner/TestController.h:
+        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
+        (WTR::TestController::cocoaPlatformInitialize):
+        (WTR::TestController::platformAdjustContext):
+        * WebKitTestRunner/gtk/main.cpp:
+        (main):
+        * WebKitTestRunner/mac/TestControllerMac.mm:
+        (WTR::TestController::configureContentExtensionForTest):
+        * WebKitTestRunner/wpe/main.cpp:
+        (main):
+        Utilize WTF::Environment where possible.
+
+2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iOS] WKWebView callout bar is missing Change Writing Direction item
+        https://bugs.webkit.org/show_bug.cgi?id=190015
+        <rdar://problem/44810366>
+
+        Reviewed by Tim Horton.
+
+        Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
+        macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
+        (TestWebKitAPI::TEST):
+
+2019-02-15  Chris Dumez  <cdumez@apple.com>
+
+        Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
+        https://bugs.webkit.org/show_bug.cgi?id=194717
+        <rdar://problem/47884404>
+
+        Reviewed by Brady Eidson.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-02-15  Youenn Fablet  <youenn@apple.com>
+
+        Make navigator.mediaDevices SecureContext
+        https://bugs.webkit.org/show_bug.cgi?id=194666
+
+        Reviewed by Eric Carlson.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
+        (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
+        (TEST_F):
+
+2019-02-15  Brian Burg  <bburg@apple.com>
+
+        [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
+        https://bugs.webkit.org/show_bug.cgi?id=194411
+        <rdar://problem/47787614>
+
+        Reviewed by Joseph Pecoraro.
+
+        Remove unnecessary soft linking macro usage.
+
+        * DumpRenderTree/mac/TestRunnerMac.mm:
+        (TestRunner::inspectorTestStubURL):
+        (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
+        * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
+        (WTR::TestRunner::inspectorTestStubURL):
+
+2019-02-15  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r241559 and r241566.
+        https://bugs.webkit.org/show_bug.cgi?id=194710
+
+        Causes layout test crashes under GuardMalloc (Requested by
+        ryanhaddad on #webkit).
+
+        Reverted changesets:
+
+        "[WTF] Add environment variable helpers"
+        https://bugs.webkit.org/show_bug.cgi?id=192405
+        https://trac.webkit.org/changeset/241559
+
+        "Unreviewed build fix for WinCairo Debug after r241559."
+        https://trac.webkit.org/changeset/241566
+
+2019-02-15  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC] Out-of-flow box is never a float box
+        https://bugs.webkit.org/show_bug.cgi?id=194704
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-02-10  Darin Adler  <darin@apple.com>
+
+        Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
+        https://bugs.webkit.org/show_bug.cgi?id=194487
+
+        Reviewed by Daniel Bates.
+
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (applicationId): Use makeString instead of String::format.
+        (main): Ditto.
+        * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
+        (TestWebKitAPI::Util::createURLForResource): Ditto.
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
+        (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
+
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+        (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
+        (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
+        (WTR::createStringWithAttributes): Use appendLiteral.
+        (WTR::AccessibilityUIElement::helpText const): Ditto.
+        (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
+        directly instead of using String::format.
+        (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
+        (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
+
+2019-02-15  Truitt Savell  <tsavell@apple.com>
+
+        Unreviewed, rolling out r241564.
+
+        Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
+
+        Reverted changeset:
+
+        "[Mac] WebInspectorUI.framework does not need to be soft-
+        linked anymore"
+        https://bugs.webkit.org/show_bug.cgi?id=194411
+        https://trac.webkit.org/changeset/241564
+
+2019-02-15  Saam barati  <sbarati@apple.com>
+
+        [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
+        https://bugs.webkit.org/show_bug.cgi?id=194036
+
+        Reviewed by Yusuke Suzuki.
+
+        * Scripts/run-jsc-stress-tests:
+
+2019-02-14  Tim Horton  <timothy_horton@apple.com>
+
+        Fix the build.
+
+        * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+        (WTR::UIScriptController::drawSquareInEditableImage):
+        * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
+        (TestWebKitAPI::drawSquareInEditableImage):
+
+2019-02-14  Tim Horton  <timothy_horton@apple.com>
+
+        Fix the build.
+
+        * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+        (WTR::UIScriptController::drawSquareInEditableImage):
+        * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
+        (TestWebKitAPI::drawSquareInEditableImage):
+
+2019-02-14  Brian Burg  <bburg@apple.com>
+
+        [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
+        https://bugs.webkit.org/show_bug.cgi?id=194411
+        <rdar://problem/47787614>
+
+        Reviewed by Joseph Pecoraro.
+
+        Remove unnecessary soft linking macro usage.
+
+        * DumpRenderTree/mac/TestRunnerMac.mm:
+        (TestRunner::inspectorTestStubURL):
+        (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
+        * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
+        (WTR::TestRunner::inspectorTestStubURL):
+
+2019-02-14  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] status bubble should fetch builder name info from BuilderMapping table
+        https://bugs.webkit.org/show_bug.cgi?id=194599
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble._build_bubble):
+
+2019-02-14  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Set Foreign Key in Django build model
+        https://bugs.webkit.org/show_bug.cgi?id=194667
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/models/build.py:
+        (Build):
+
+2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
+
+        [WTF] Add environment variable helpers
+        https://bugs.webkit.org/show_bug.cgi?id=192405
+
+        Reviewed by Michael Catanzaro.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (libraryPathForDumpRenderTree):
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (libraryPathForDumpRenderTree):
+        * TestRunnerShared/IOSLayoutTestCommunication.cpp:
+        (setUpIOSLayoutTestCommunication):
+        * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
+        (TestWebKitAPI::strip):
+        * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
+        (beforeAll):
+        * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
+        (main):
+        * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
+        (WebKitTestBus::run):
+        * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
+        (WTR::getOutputDir):
+        (WTR::initializeFontConfigSetting):
+        * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
+        (WTR::InjectedBundle::platformInitialize):
+        * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
+        (WTR::topLevelPath):
+        * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
+        (WTR::topLevelPath):
+        (WTR::getOutputDir):
+        (WTR::activateFonts):
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::libraryPathForTesting):
+        (WTR::TestController::generateContextConfiguration const):
+        (WTR::TestController::generatePageConfiguration):
+        (WTR::TestController::decideDestinationWithSuggestedFilename):
+        (WTR::TestController::platformAdjustContext):
+        * WebKitTestRunner/TestController.h:
+        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
+        (WTR::TestController::cocoaPlatformInitialize):
+        (WTR::TestController::platformAdjustContext):
+        * WebKitTestRunner/gtk/main.cpp:
+        (main):
+        * WebKitTestRunner/mac/TestControllerMac.mm:
+        (WTR::TestController::configureContentExtensionForTest):
+        * WebKitTestRunner/wpe/main.cpp:
+        (main):
+        Utilize WTF::Environment where possible.
+
+2019-02-14  Chris Dumez  <cdumez@apple.com>
+
+        [PSON] Introduce a WebContent Process cache
+        https://bugs.webkit.org/show_bug.cgi?id=194594
+        <rdar://problem/46793397>
+
+        Reviewed by Geoff Garen.
+
+        Update API tests to turn on the WebContent Process cache.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
+
+        Unreviewed, build fix after r241480
+
+        * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
+        (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
+        (-[DragAndDropSimulator initWithWebView:]):
+
+2019-02-14  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: ARIA Reflection was disabled in error
+        https://bugs.webkit.org/show_bug.cgi?id=194647
+        <rdar://problem/48068336>
+
+        Reviewed by Ryosuke Niwa.
+
+        Remove test override now that this feature should be enabled by default.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::resetPreferencesToConsistentValues):
+
+2019-02-14  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r241486.
+        https://bugs.webkit.org/show_bug.cgi?id=194655
+
+        causing API failures in builds (Requested by ShawnRoberts on
+        #webkit).
+
+        Reverted changeset:
+
+        "[Cocoa] Media elements will restart network buffering just
+        before suspending"
+        https://bugs.webkit.org/show_bug.cgi?id=193691
+        https://trac.webkit.org/changeset/241486
+
+2019-02-14  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
+        https://bugs.webkit.org/show_bug.cgi?id=194622
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-02-14  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC] Shrink-to-fit-width should be constrained by min/max width
+        https://bugs.webkit.org/show_bug.cgi?id=194653
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
+        https://bugs.webkit.org/show_bug.cgi?id=194641
+
+        Reviewed by Geoffrey Garen.
+
+        Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
+        so that the test would fail without this fix.
+
+        * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
+        (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
+
+2019-02-13  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Change log level for a log statement
+
+        Unreviewed minor fix.
+
+        * BuildSlaveSupport/ews-app/ews/models/patch.py:
+        (Patch.save_patch):
+
+2019-02-13  Jer Noble  <jer.noble@apple.com>
+
+        [Cocoa] Media elements will restart network buffering just before suspending
+        https://bugs.webkit.org/show_bug.cgi?id=193691
+
+        Reviewed by Eric Carlson.
+
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
+        (TEST):
+
+2019-02-13  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Fetch builder id to name mapping
+        https://bugs.webkit.org/show_bug.cgi?id=194355
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
+        (Buildbot.get_builder_id_to_name_mapping):
+        (Buildbot._get_display_name_from_builder_name):
+
+2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
+
+        Further restricting webarchive loads
+        https://bugs.webkit.org/show_bug.cgi?id=194567
+        <rdar://problem/47610130>
+
+        Reviewed by Youenn Fablet.
+
+        Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
+        navigations on drop.
+
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+        * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
+        (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
+        (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
+        (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
+        (TestWebKitAPI::TEST):
+        * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
+        * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
+        * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
+        * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
+        * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
+        (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
+        (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
+
+2019-02-13  John Wilander  <wilander@apple.com>
+
+        Store Ad Click Attribution requests in the network process
+        https://bugs.webkit.org/show_bug.cgi?id=194510
+        <rdar://problem/47650118>
+
+        Reviewed by Alex Christensen and Daniel Bates.
+
+        This patch adds two TestRunner functions:
+        - dumpAdClickAttribution()
+        - clearAdClickAttribution()
+
+        They call into the network process to dump and clear Ad Click
+        Attribution state, respectively.
+
+        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
+        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+        (WTR::TestRunner::dumpAdClickAttribution):
+        (WTR::TestRunner::clearAdClickAttribution):
+        * WebKitTestRunner/InjectedBundle/TestRunner.h:
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::resetStateToConsistentValues):
+        (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
+        (WTR::adClickAttributionStringResultCallback):
+        (WTR::TestController::dumpAdClickAttribution):
+        (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
+        (WTR::adClickAttributionVoidCallback):
+        (WTR::TestController::clearAdClickAttribution):
+        * WebKitTestRunner/TestController.h:
+        * WebKitTestRunner/TestInvocation.cpp:
+        (WTR::TestInvocation::dumpResults):
+        (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
+        (WTR::TestInvocation::dumpAdClickAttribution):
+        * WebKitTestRunner/TestInvocation.h:
+
+2019-02-13  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Generate status-bubble
+        https://bugs.webkit.org/show_bug.cgi?id=194572
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble._build_bubble):
+        (StatusBubble._should_show_bubble_for):
+        (StatusBubble._build_bubbles_for_patch):
+
+2019-02-13  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Add status bubble html template
+        https://bugs.webkit.org/show_bug.cgi?id=194571
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/templates: Added.
+        * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
+
+2019-02-12  Chris Dumez  <cdumez@apple.com>
+
+        Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
+        https://bugs.webkit.org/show_bug.cgi?id=194568
+        <rdar://problem/47944490>
+
+        Reviewed by Ryosuke Niwa.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+        (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
+
+2019-02-12  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy: Remove bug_dummy from parsed test expectations
+        https://bugs.webkit.org/show_bug.cgi?id=194562
+        <rdar://problem/47853999>
+
+        Reviewed by Lucas Forschler.
+
+        * Scripts/webkitpy/layout_tests/models/test_expectations.py:
+        (TestExpectationParser):
+        (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
+        skipped tests.
+        * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
+
+2019-02-12  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Add method to fetch patch
+        https://bugs.webkit.org/show_bug.cgi?id=194518
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/models/patch.py:
+        (Patch.get_patch):
+
+2019-02-12  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC] Expand tests coverage (60 new tests -> 860)
+
+        Unreviewed test gardening (run-singly, --child-processes=1).
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Allow pages to trigger programmatic paste from script on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=194271
+        <rdar://problem/47808810>
+
+        Reviewed by Tim Horton.
+
+        Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
+
+        * DumpRenderTree/ios/UIScriptControllerIOS.mm:
+        (WTR::UIScriptController::platformSetDidShowMenuCallback):
+        (WTR::UIScriptController::platformSetDidHideMenuCallback):
+        (WTR::UIScriptController::rectForMenuAction const):
+
+        Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
+        includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
+        for when the menu is shown or hidden.
+
+        * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
+        * TestRunnerShared/UIScriptContext/UIScriptContext.h:
+        * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
+        (WTR::UIScriptController::setDidShowMenuCallback):
+        (WTR::UIScriptController::didShowMenuCallback const):
+        (WTR::UIScriptController::setDidHideMenuCallback):
+        (WTR::UIScriptController::didHideMenuCallback const):
+        (WTR::UIScriptController::platformSetDidShowMenuCallback):
+        (WTR::UIScriptController::platformSetDidHideMenuCallback):
+        (WTR::UIScriptController::rectForMenuAction const):
+        * TestRunnerShared/UIScriptContext/UIScriptController.h:
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::resetPreferencesToConsistentValues):
+        (WTR::updateTestOptionsFromTestHeader):
+        * WebKitTestRunner/TestOptions.h:
+
+        Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
+        default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
+
+        (WTR::TestOptions::hasSameInitializationOptions const):
+        * WebKitTestRunner/UIScriptControllerCocoa.mm:
+        (WTR::UIScriptController::calendarType const):
+        (WTR::UIScriptController::platformUndoManager const):
+        * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
+        * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
+        (-[TestRunnerWKWebView initWithFrame:configuration:]):
+        (-[TestRunnerWKWebView dealloc]):
+        (-[TestRunnerWKWebView _didShowMenu]):
+        (-[TestRunnerWKWebView _didHideMenu]):
+
+        Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
+
+        * WebKitTestRunner/ios/TestControllerIOS.mm:
+        (WTR::handleMenuWillHideNotification):
+        (WTR::handleMenuDidHideNotification):
+        (WTR::TestController::platformInitialize):
+        (WTR::TestController::platformDestroy):
+        (WTR::TestController::platformResetStateToConsistentValues):
+
+        Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
+        next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
+
+        * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+        (WTR::forEachViewInHierarchy):
+        (WTR::findViewInHierarchyOfType):
+
+        Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
+        functions that dig through a given view's hierarchy in search of a view of a given class.
+
+        (WTR::UIScriptController::selectionStartGrabberViewRect const):
+        (WTR::UIScriptController::selectionEndGrabberViewRect const):
+        (WTR::UIScriptController::selectionCaretViewRect const):
+        (WTR::UIScriptController::selectionRangeViewRects const):
+        (WTR::UIScriptController::platformSetDidShowMenuCallback):
+        (WTR::UIScriptController::platformSetDidHideMenuCallback):
+
+        Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
+
+        (WTR::UIScriptController::rectForMenuAction const):
+
+        Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
+        callout bar) whose label matches the given string.
+
+        (WTR::UIScriptController::platformContentView const):
+
+        Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
+        "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
+        of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
+
+        (WTR::UIScriptController::platformUndoManager const): Deleted.
+        * WebKitTestRunner/mac/UIScriptControllerMac.mm:
+        (WTR::UIScriptController::platformContentView const):
+        (WTR::UIScriptController::platformUndoManager const): Deleted.
+
+2019-02-12  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy: No option to only show unexpected failures in results.html for iPad
+        https://bugs.webkit.org/show_bug.cgi?id=194554
+        <rdar://problem/47922442>
+
+        Rubber-stamped by Aakash Jain.
+
+        Just because a TestExpecations file does not exist for a specific platform does not mean that
+        TestExpecations are not being used, given that platforms inherit test expectations.
+
+        * Scripts/webkitpy/port/base.py:
+        (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
+        * Scripts/webkitpy/port/base_unittest.py:
+        (PortTest.test_uses_test_expectations_file):
+
+2019-02-12  Alex Christensen  <achristensen@webkit.org>
+
+        Remove setDefersLoading infrastructure from WebKit2
+        https://bugs.webkit.org/show_bug.cgi?id=194506
+
+        Reviewed by Brady Eidson.
+
+        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
+        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+        (WTR::TestRunner::setDefersLoading): Deleted.
+        * WebKitTestRunner/InjectedBundle/TestRunner.h:
+
+2019-02-12  Alex Christensen  <achristensen@webkit.org>
+
+        WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
+        https://bugs.webkit.org/show_bug.cgi?id=194522
+        <rdar://problem/47789393>
+
+        Reviewed by Chris Dumez.
+
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+        * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
+        (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-02-12  Andy Estes  <aestes@apple.com>
+
+        [iOSMac] Enable Parental Controls Content Filtering
+        https://bugs.webkit.org/show_bug.cgi?id=194521
+        <rdar://39732376>
+
+        Reviewed by Tim Horton.
+
+        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+2019-02-12  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][IFC] Add intrinsic width support for float boxes.
+        https://bugs.webkit.org/show_bug.cgi?id=194528
+
+        Reviewed by Antti Koivisto.
+
+        Expand tests coverage (2 new tests -> 800).
+        (This is the correct test ordering --runs-singly --child-processes=1)
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-02-12  Rob Buis  <rbuis@igalia.com>
+
+        Implement serializing in MIME type parser
+        https://bugs.webkit.org/show_bug.cgi?id=193909
+
+        Reviewed by Darin Adler.
+
+        Add various tests involving upper case, non-ASCII, control/null characters,
+        various HTTP whitespace, single quotes and an unpaired surrogate.
+
+        * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
+        (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
+        (TestWebKitAPI::serializeIfValid):
+        (TestWebKitAPI::TEST):
+
+2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        [Cocoa] Ask platform for generic font family mappings
+        https://bugs.webkit.org/show_bug.cgi?id=187723
+        <rdar://problem/41892438>
+
+        Reviewed by Brent Fulgham.
+
+        Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (allowedFontFamilySet):
+        * WebKitTestRunner/mac/TestControllerMac.mm:
+        (WTR::allowedFontFamilySet):
+
+2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
+
+        [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=193622
+
+        Reviewed by Michael Catanzaro.
+
+        This adds support for loading content extension rule sets from the JSON files which
+        accompany the corresponding layout test, using the C API. The Cocoa specific parts
+        of WKTR for this could be removed, but that is left for a follow-up patch with
+        cleanups.
+
+        * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::testPath): Subtract one from the length when constructing the result std::string to
+        avoid having the null-terminator copied into the result.
+        (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
+        part of the preparations to run a test.
+        (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
+        (WTR::contentExtensionStoreCallback): Added.
+        (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
+        used for content extensions test.
+        (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
+        extensions and compiling the JSON rule set for tests involving content extensions.
+        (WTR::TestController::resetContentExtensions): Removes the content extension built for
+        testing and disables content extensions.
+        (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
+        resetContentExtensions().
+        (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
+        * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
+        configureContentExtensionForTest(), and userContentController().
+
+2019-02-11  Daniel Bates  <dabates@apple.com>
+
+        [iOS] Mouse/Touch/Pointer events are missing modifier keys
+        https://bugs.webkit.org/show_bug.cgi?id=191446
+        <rdar://problem/45929460>
+
+        Reviewed by Tim Horton.
+
+        Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
+
+        * DumpRenderTree/ios/UIScriptControllerIOS.mm:
+        (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
+        (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
+        * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
+        * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
+        (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
+        (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
+        * TestRunnerShared/UIScriptContext/UIScriptController.h:
+        * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+        (WTR::arrayLength):
+        (WTR::parseModifierArray):
+        (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
+        (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
+        (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
+        (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
+
+2019-02-11  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r241272 and r241276.
+        https://bugs.webkit.org/show_bug.cgi?id=194514
+
+        Broke the Apple Internal build and the fix requires human
+        intervention :( (Requested by dydz on #webkit).
+
+        Reverted changesets:
+
+        "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
+        https://bugs.webkit.org/show_bug.cgi?id=191446
+        https://trac.webkit.org/changeset/241272
+
+        "Fix internal iOS build after r241272"
+        https://bugs.webkit.org/show_bug.cgi?id=191446
+        https://trac.webkit.org/changeset/241276
+
+2019-02-11  Truitt Savell  <tsavell@apple.com>
+
+        Unreviewed, rolling out r241269.
+
+        Caused 5 layout tests crashes on Mac WK1
+
+        Reverted changeset:
+
+        "DumpRenderTree should report unknown options"
+        https://bugs.webkit.org/show_bug.cgi?id=191303
+        https://trac.webkit.org/changeset/241269
+
+2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
+        https://bugs.webkit.org/show_bug.cgi?id=194313
+
+        Reviewed by Tim Horton.
+
+        Add a helper to determine whether the web view is presenting modal UI.
+
+        * DumpRenderTree/ios/UIScriptControllerIOS.mm:
+        (WTR::UIScriptController::isPresentingModally const):
+        * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
+        * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
+        (WTR::UIScriptController::isPresentingModally const):
+        * TestRunnerShared/UIScriptContext/UIScriptController.h:
+        * WebKitTestRunner/UIScriptControllerCocoa.mm:
+        (WTR::UIScriptController::calendarType const): Deleted.
+        * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+        (WTR::UIScriptController::isPresentingModally const):
+        (WTR::UIScriptController::calendarType const):
+        * WebKitTestRunner/mac/UIScriptControllerMac.mm:
+        (WTR::UIScriptController::calendarType const):
+
+2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
+
+        GCHeapInspector: Show the retained sizes in more places
+        https://bugs.webkit.org/show_bug.cgi?id=194464
+
+        Reviewed by Simon Fraser.
+
+        * GCHeapInspector/gc-heap-inspector.html:
+        * GCHeapInspector/script/interface.js:
+        (HeapInspectorUtils.humanReadableSize):
+        (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
+        (HeapInspectorUtils.spanForNode.span.span):
+        (HeapSnapshotInspector.prototype.buildAllObjectsByType):
+        (HeapSnapshotInspector.prototype.buildRoots):
+
+2019-02-11  Daniel Bates  <dabates@apple.com>
+
+        [iOS] Mouse/Touch/Pointer events are missing modifier keys
+        https://bugs.webkit.org/show_bug.cgi?id=191446
+        <rdar://problem/45929460>
+
+        Reviewed by Tim Horton.
+
+        Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
+
+        * DumpRenderTree/ios/UIScriptControllerIOS.mm:
+        (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
+        (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
+        * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
+        * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
+        (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
+        (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
+        * TestRunnerShared/UIScriptContext/UIScriptController.h:
+        * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+        (WTR::arrayLength):
+        (WTR::parseModifierArray):
+        (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
+        (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
+        (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
+        (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
+
+2019-02-11  Darshan Kadu  <dkadu@igalia.com>
+
+        DumpRenderTree should report unknown options
+        https://bugs.webkit.org/show_bug.cgi?id=191303
+
+        Reviewed by Frédéric Wang.
+
+        Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
+        to report unknown options.
+        Added and assigned test options which are currently used in tests.
+
+        * DumpRenderTree/TestOptions.cpp:
+        (TestOptions::TestOptions):
+
+2019-02-11  Truitt Savell  <tsavell@apple.com>
+
+        Unreviewed, rolling out r241229.
+
+        Revision broke internal builds for watchOS.
+
+        Reverted changeset:
+
+        "[Cocoa] Ask platform for generic font family mappings"
+        https://bugs.webkit.org/show_bug.cgi?id=187723
+        https://trac.webkit.org/changeset/241229
+
+2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
+
+        [WinCairo][MiniBrowser] Basic authentication always fails.
+        https://bugs.webkit.org/show_bug.cgi?id=194496
+
+        Reviewed by Don Olmstead.
+
+        * MiniBrowser/win/DialogHelper.h:
+        (Dialog::getText):
+
+2019-02-11  Philippe Normand  <pnormand@igalia.com>
+
+        [GStreamer] GstMappedBuffer testsuite build fails
+        https://bugs.webkit.org/show_bug.cgi?id=194495
+
+        Reviewed by Carlos Garcia Campos.
+
+        Fix the build by explicitely adding the gstreamer1.0-audio include
+        directories to the include path.
+
+        * TestWebKitAPI/PlatformGTK.cmake:
+        * TestWebKitAPI/PlatformWPE.cmake:
+
+2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK][WPE] Add enable-javascript-markup setting
+        https://bugs.webkit.org/show_bug.cgi?id=193439
+
+        Reviewed by Michael Catanzaro.
+
+        Add test cases to check the new setting.
+
+        * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
+        (testWebKitSettings):
+        (testWebKitSettingsJavaScriptMarkup):
+        (beforeAll):
+
+2019-02-10  Darin Adler  <darin@apple.com>
+
+        Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
+        https://bugs.webkit.org/show_bug.cgi?id=194485
+
+        Reviewed by Daniel Bates.
+
+        * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
+
+2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
+
+        Add more tests for clampTo<>()
+        https://bugs.webkit.org/show_bug.cgi?id=194462
+
+        Reviewed by Geoffrey Garen.
+
+        Darin suggested to test the very last floating point number
+        at the boundaries when truncating to integer.
+        I added test for max/min and max-1/min-1.
+
+        * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
+        (TestWebKitAPI::TEST):
+
+2019-02-09  Darin Adler  <darin@apple.com>
+
+        Eliminate unnecessary String temporaries by using StringConcatenateNumbers
+        https://bugs.webkit.org/show_bug.cgi?id=194021
+
+        Reviewed by Geoffrey Garen.
+
+        * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
+        (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
+        to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
+
+2019-02-09  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][IFC] Add intrinsic width support for basic inline containers
+        https://bugs.webkit.org/show_bug.cgi?id=194473
+
+        Reviewed by Antti Koivisto.
+
+        Expand tests coverage (11 new tests -> 798)
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
+
+2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
+
+        Fix MiniBrowser's entitlements
+        https://bugs.webkit.org/show_bug.cgi?id=192431
+
+        Reviewed by Joseph Pecoraro.
+
+        MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
+        files, making it impossible to load any extension.
+
+        * MiniBrowser/MiniBrowser.entitlements:
+
+2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        [Cocoa] Ask platform for generic font family mappings
+        https://bugs.webkit.org/show_bug.cgi?id=187723
+        <rdar://problem/41892438>
+
+        Reviewed by Brent Fulgham.
+
+        Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (allowedFontFamilySet):
+        * WebKitTestRunner/mac/TestControllerMac.mm:
+        (WTR::allowedFontFamilySet):
+
+2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
+
+        [GTK] Implement back/forward touchpad gesture
+        https://bugs.webkit.org/show_bug.cgi?id=193919
+
+        Reviewed by Michael Catanzaro.
+
+        * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
+        (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
+
+2019-02-08  Alex Christensen  <achristensen@webkit.org>
+
+        Add SPI to use networking daemon instead of XPC service
+        https://bugs.webkit.org/show_bug.cgi?id=194427
+
+        Reviewed by Geoffrey Garen
+
+        * MiniBrowser/MiniBrowser.entitlements:
+
+2019-02-08  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Ensure that every builder in config.json has short name
+        https://bugs.webkit.org/show_bug.cgi?id=194461
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-build/loadConfig.py:
+        * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
+
+2019-02-08  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Add short name to config.json
+        https://bugs.webkit.org/show_bug.cgi?id=194456
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-build/config.json: Added short name.
+        * BuildSlaveSupport/ews-build/loadConfig.py:
+        (loadBuilderConfig): Set the short name as the builder description.
+
+2019-02-08  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
+        https://bugs.webkit.org/show_bug.cgi?id=194418
+
+        Reviewed by Lucas Forschler.
+
+        Do not include errors trying when finding crashlogs at the end of
+        a run-webkit-tests run since we don't process those errors.
+
+        * Scripts/webkitpy/port/darwin.py:
+        (DarwinPort._look_for_all_crash_logs_in_log_dir):
+        * Scripts/webkitpy/port/ios_device.py:
+        (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
+        * Scripts/webkitpy/port/watch_device.py:
+        (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
+
+2019-02-08  Beth Dakin  <bdakin@apple.com>
+
+        Add afterScreenUpdates to WKSnapshotConfiguration
+        https://bugs.webkit.org/show_bug.cgi?id=194362
+        -and corresponding-
+        <rdar://problem/40655528> Please add an "after screen updates" property to 
+        WKSnapshotConfiguration (to solve blank snapshots)
+
+        Reviewed by Tim Horton.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
+        (TEST):
+
 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
 
         clampTo(): do not convert the input to double when dealing with integers