[CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
[WebKit-https.git] / Tools / ChangeLog
index 2d87ca1..fa409e7 100644 (file)
@@ -1,3 +1,379 @@
+2019-02-20  Don Olmstead  <don.olmstead@sony.com>
+
+        [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
+        https://bugs.webkit.org/show_bug.cgi?id=194884
+
+        Reviewed by Michael Catanzaro.
+
+        * PlatformWin.cmake:
+
+2019-02-20  Chris Dumez  <cdumez@apple.com>
+
+        Add API test for <rdar://problem/47471222>
+        https://bugs.webkit.org/show_bug.cgi?id=194847
+
+        Reviewed by Alex Christensen.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-02-20  Chris Dumez  <cdumez@apple.com>
+
+        Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
+        https://bugs.webkit.org/show_bug.cgi?id=194872
+        <rdar://problem/47924500>
+
+        Reviewed by Alex Christensen.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-02-20  Jer Noble  <jer.noble@apple.com>
+
+        Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
+        https://bugs.webkit.org/show_bug.cgi?id=191332
+
+        Reviewed by Dean Jackson.
+
+        * Scripts/git-is-in-range: Added.
+
+2019-02-20  Andy Estes  <aestes@apple.com>
+
+        [Xcode] Add SDKVariant.xcconfig to various Xcode projects
+        https://bugs.webkit.org/show_bug.cgi?id=194869
+
+        Rubber-stamped by Jer Noble.
+
+        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
+        * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
+        * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
+        * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
+
+2019-02-20  Chris Dumez  <cdumez@apple.com>
+
+        Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
+        https://bugs.webkit.org/show_bug.cgi?id=194857
+        <rdar://problem/47759323>
+
+        Reviewed by Alex Christensen.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-02-20  Chris Dumez  <cdumez@apple.com>
+
+        [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=194829
+        <rdar://problem/47889906>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Every time the TestOptions were changing we were creating both a new Web view and
+        a new WKContext, which would start a new Network process. In most cases, we only
+        need to contruct a new Web view and we do can keep reusing the same WKContext.
+        This patch implements this optimization and thus avoids spinning a lot of new
+        Network processes while running the layout tests.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::generateContextConfiguration const):
+        (WTR::TestController::generatePageConfiguration):
+        (WTR::TestController::createWebViewWithOptions):
+        (WTR::TestController::resetPreferencesToConsistentValues):
+        (WTR::updateTestOptionsFromTestHeader):
+        * WebKitTestRunner/TestController.h:
+        * WebKitTestRunner/TestOptions.h:
+        (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
+        (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
+        (WTR::TestOptions::hasSameInitializationOptions const):
+        (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
+        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
+        (WTR::TestController::platformAddTestOptions const):
+
+2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
+
+        [WPE][GTK] Enable support for CONTENT_EXTENSIONS
+        https://bugs.webkit.org/show_bug.cgi?id=167941
+
+        Reviewed by Carlos Garcia Campos.
+
+        * MiniBrowser/gtk/main.c:
+        (filterSavedCallback): Added.
+        (main): Support loading a JSON rule set file for content filtering.
+        * MiniBrowser/wpe/main.cpp:
+        (filterSavedCallback): Added.
+        (main): Support loading a JSON rule set file for content filtering.
+        * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
+        (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
+        (WTF::derefGPtr): Ditto.
+        (testEmptyStore):
+        (testSaveInvalidFilter):
+        (testSaveLoadFilter):
+        (testSavedFilterIdentifierMatch):
+        (testRemoveFilter):
+        (testSaveMultipleFilters):
+        (testSaveFilterFromFile):
+        (testFilterPersistence):
+        (beforeAll):
+        (afterAll):
+        * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
+        (removeOldInjectedContentAndResetLists): Also reset content filters.
+        (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
+        CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
+        the element affected by the style sheet.
+        (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
+        and returns it to be used by tests.
+        (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
+        from the WebKitUserContentManager results in the a CSS style sheet being blocked.
+        (serverCallback): Add support for serving a CSS style sheet for testing.
+        (beforeAll): Add call to testUserContentManagerContentFilter().
+        * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
+
+2019-02-19  Keith Rollin  <krollin@apple.com>
+
+        Add timing information to build output
+        https://bugs.webkit.org/show_bug.cgi?id=194839
+        <rdar://problem/48219609>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Configure xcodebuild with -ShowBuildOperationDuration, causing it to
+        emit each project's build time to its output. E.g.,
+
+            ** BUILD SUCCEEDED ** [0.132 sec]
+
+        * Scripts/webkitdirs.pm:
+        (XcodeOptions):
+
+2019-02-19  Truitt Savell  <tsavell@apple.com>
+
+        Unreviewed, rolling out r241784.
+
+        Broke all OpenSource builds.
+
+        Reverted changeset:
+
+        "Web Inspector: Improve ES6 Class instances in Heap Snapshot
+        instances view"
+        https://bugs.webkit.org/show_bug.cgi?id=172848
+        https://trac.webkit.org/changeset/241784
+
+2019-02-19  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][Floats] Remove redundant intersecting logic
+        https://bugs.webkit.org/show_bug.cgi?id=194804
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-02-19  Dean Jackson  <dino@apple.com>
+
+        Clean-up output from generate-xcfilelists so it can be filtered
+        https://bugs.webkit.org/show_bug.cgi?id=194795
+
+        Reviewed by Joseph Pecoraro (and Keith Rollin).
+
+        Replace the "..." with "GXCF:" in generate-xcfilelists output, and
+        make a slight tweak to filter-build-webkit so such lines are marked
+        as plain.
+
+        * Scripts/filter-build-webkit:
+        * Scripts/generate-xcfilelists:
+
+2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
+
+        pytest is not correctly auto-installed
+        https://bugs.webkit.org/show_bug.cgi?id=194707
+
+        Reviewed by Carlos Garcia Campos.
+
+        * Scripts/webkitpy/thirdparty/__init__.py:
+        (AutoinstallImportHook._install_pytest):
+
+2019-02-18  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION (PSON): Can't access optumbank.com from myuhc.com
+        https://bugs.webkit.org/show_bug.cgi?id=194797
+        <rdar://problem/48055151>
+
+        Reviewed by Geoffrey Garen.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
+        https://bugs.webkit.org/show_bug.cgi?id=194670
+        <rdar://problem/39066529>
+
+        Reviewed by Tim Horton.
+
+        Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
+        pasted in an editable area as attachment elements.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
+        (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
+        (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
+        * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
+        (TestWebKitAPI::TEST):
+        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+        (WTR::InjectedBundlePage::InjectedBundlePage):
+
+2019-02-18  Alex Christensen  <achristensen@webkit.org>
+
+        Fix API test after r241728
+       â€‹https://bugs.webkit.org/show_bug.cgi?id=194723
+
+        * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
+        (TEST):
+        The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
+
+2019-02-18  Daniel Bates  <dabates@apple.com>
+
+        [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
+        https://bugs.webkit.org/show_bug.cgi?id=192824
+        <rdar://problem/47100332>
+
+        Reviewed by Wenson Hsieh.
+
+        Fix a bug where the wrong usage code was used for F13 thru F24.
+
+        * WebKitTestRunner/ios/HIDEventGenerator.mm:
+        (keyCodeForDOMFunctionKey):
+
+2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
+
+        Bytecode cache should a have a boot-specific validation
+        https://bugs.webkit.org/show_bug.cgi?id=194769
+        <rdar://problem/48149509>
+
+        Reviewed by Keith Miller.
+
+        Add test for WTF::bootSessionUUIDString()
+
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+        * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
+        (TEST):
+
+2019-02-18  Alex Christensen  <achristensen@webkit.org>
+
+        Disable safe browsing in WKWebView and remove its WKPreferences API
+        https://bugs.webkit.org/show_bug.cgi?id=194723
+        <rdar://problem/48122993>
+
+        Reviewed by Geoffrey Garen.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+        * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
+        (TEST):
+        (safeBrowsingView):
+        Make tests use SPI instead of API.
+
+2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
+        https://bugs.webkit.org/show_bug.cgi?id=194586
+
+        Reviewed by Ross Kirsling.
+
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
+        * Scripts/webkitpy/port/driver.py:
+        (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
+
+2019-02-17  David Kilzer  <ddkilzer@apple.com>
+
+        Unreviewed, rolling out r241620.
+
+        "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
+        (Requested by ddkilzer on #webkit.)
+
+        Reverted changeset:
+
+        "[WTF] Add environment variable helpers"
+        https://bugs.webkit.org/show_bug.cgi?id=192405
+        https://trac.webkit.org/changeset/241620
+
+2019-02-16  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC] RenderImage's default intrinsic size is 0.
+        https://bugs.webkit.org/show_bug.cgi?id=194745
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-02-16  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][BFC] Add support for block replaced intrinsic width.
+        https://bugs.webkit.org/show_bug.cgi?id=194705
+
+        Reviewed by Simon Fraser.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-02-16  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC] Apply min/max width constraints to preferred width computation
+        https://bugs.webkit.org/show_bug.cgi?id=194739
+
+        Reviewed by Simon Fraser.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
+
+        [WTF] Add environment variable helpers
+        https://bugs.webkit.org/show_bug.cgi?id=192405
+
+        Reviewed by Michael Catanzaro.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (libraryPathForDumpRenderTree):
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (libraryPathForDumpRenderTree):
+        * TestRunnerShared/IOSLayoutTestCommunication.cpp:
+        (setUpIOSLayoutTestCommunication):
+        * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
+        (beforeAll):
+        * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
+        (main):
+        * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
+        (WebKitTestBus::run):
+        * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
+        (WTR::getOutputDir):
+        (WTR::initializeFontConfigSetting):
+        * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
+        (WTR::InjectedBundle::platformInitialize):
+        * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
+        (WTR::topLevelPath):
+        * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
+        (WTR::topLevelPath):
+        (WTR::getOutputDir):
+        (WTR::activateFonts):
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::libraryPathForTesting):
+        (WTR::TestController::generateContextConfiguration const):
+        (WTR::TestController::generatePageConfiguration):
+        (WTR::TestController::decideDestinationWithSuggestedFilename):
+        (WTR::TestController::platformAdjustContext):
+        * WebKitTestRunner/TestController.h:
+        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
+        (WTR::TestController::cocoaPlatformInitialize):
+        (WTR::TestController::platformAdjustContext):
+        * WebKitTestRunner/gtk/main.cpp:
+        (main):
+        * WebKitTestRunner/mac/TestControllerMac.mm:
+        (WTR::TestController::configureContentExtensionForTest):
+        * WebKitTestRunner/wpe/main.cpp:
+        (main):
+        Utilize WTF::Environment where possible.
+
 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         [iOS] WKWebView callout bar is missing Change Writing Direction item