Unreviewed, update my list of email addresses in contributors.json.
[WebKit-https.git] / Tools / ChangeLog
index 07a58b6..ebdf722 100644 (file)
@@ -1,3 +1,466 @@
+2014-06-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
+
+        Unreviewed, update my list of email addresses in contributors.json.
+
+        * Scripts/webkitpy/common/config/contributors.json:
+
+2014-06-10  Simon Fraser  <simon.fraser@apple.com>
+
+        Always switch to an sRGB screen color profile when running tests
+        https://bugs.webkit.org/show_bug.cgi?id=133712
+
+        Reviewed by Tim Horton.
+        
+        Switch the screen color profile to sRGB when running tests, because even ref
+        tests need the screen to use the correct color profile.
+
+        * DumpRenderTree/mac/LayoutTestHelper.m:
+        (installLayoutTestColorProfile):
+        * Scripts/webkitpy/port/mac.py:
+        (MacPort.start_helper):
+
+2014-06-10  Martin Hodovan  <mhodovan@partner.samsung.com>
+
+        [EFL] Bump EFL libraries to 1.9
+        https://bugs.webkit.org/show_bug.cgi?id=125479
+
+        Reviewed by Gyuyoung Kim.
+
+        Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
+        and László Langó <llango.u-szeged@partner.samsung.com>.
+
+        * ImageDiff/CMakeLists.txt:
+        * MiniBrowser/efl/CMakeLists.txt:
+        * efl/install-dependencies:
+        * efl/jhbuild.modules:
+        * efl/jhbuildrc:
+
+2014-06-10  David Farler  <dfarler@apple.com>
+
+        old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
+        https://bugs.webkit.org/show_bug.cgi?id=133663
+
+        Reviewed by David Kilzer.
+
+        * Scripts/old-run-webkit-tests:
+        (installAndLaunchDumpToolAppUsingNotification):
+        - Remove obsolete notification keys
+        - Key off of mandatory device UDID (a UUID)
+        - Create a device on demand via CoreSimulator if necessary
+        -- Grab the UDID from the created device plist.
+        * Scripts/webkitdirs.pm:
+        (iOSSimulatorDevicesPath): Added
+        (iOSSimulatorDevices): Added
+        (createiOSSimulatorDevice): Added
+        (deleteiOSSimulatorDevice): Added
+
+2014-06-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
+
+        [GTK][gtkdoc] remove -Wcast-align
+        https://bugs.webkit.org/show_bug.cgi?id=133640
+
+        Apparently gcc warns that GParamSpec is not castable to
+        GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
+        though ARM hackers claim that those only need 4byte alignment. As long as gcc
+        behaves that way, this warning is not very useful, also they break the Debian
+        packaging.
+
+        This patch appends the compiler flag -Wno-align-cast for the gtkdoc
+        scanner compilation, thus the compiler ignores the previous
+        -Waling-cast flag.
+
+        Reviewed by Martin Robinson.
+
+        * gtk/generate-gtkdoc:
+        (get_generator_for_config):
+
+2014-06-09  Alexey Proskuryakov  <ap@apple.com>
+
+        Disable button animations in regression tests
+        https://bugs.webkit.org/show_bug.cgi?id=133647
+        <rdar://problem/16677530>
+
+        Reviewed by Tim Horton.
+
+        * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
+        (WTR::InjectedBundle::platformInitialize):
+
+2014-06-09  Simon Fraser  <simon.fraser@apple.com>
+
+        Move scrolling-related tests to tiled-drawing/scrolling subdirectory, and minor cleanup
+        https://bugs.webkit.org/show_bug.cgi?id=133650
+
+        Reviewed by Tim Horton.
+        
+        No point checking for a Windows-style path in Cocoa code.
+
+        * WebKitTestRunner/TestInvocation.cpp:
+        (WTR::shouldUseThreadedScrolling):
+
+2014-06-09  Simon Fraser  <simon.fraser@apple.com>
+
+        Fix more latched scrolling test flakiness and slowness
+        https://bugs.webkit.org/show_bug.cgi?id=133601
+
+        Reviewed by Brent Fulgham.
+        
+        Latched scrolling tests were flakey for two reasons. First, the EventSender
+        wheel events were async from the web to the UI process, and the resulting
+        synthetic events also async from the UI to the web process. Make them sync
+        for testing.
+        
+        Secondly, the timer-based scrolling tree commit could result in the scrolling
+        tree (specifically the frame node's notion of the scrollable area and content
+        size) not being updated before the scrolling thread starts getting wheel events.
+        Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
+        
+        Finally remove all the now-unnecessary timeouts from the tests.
+
+        * WebKitTestRunner/mac/EventSenderProxy.mm:
+        (WTR::EventSenderProxy::mouseMoveTo):
+        (WTR::EventSenderProxy::mouseScrollBy):
+        (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
+
+2014-06-09  Andrzej Badowski  <a.badowski@samsung.com>
+
+        [EFL] Add parameter to MiniBrowser to disable web security
+        https://bugs.webkit.org/show_bug.cgi?id=121095
+
+        Reviewed by Gyuyoung Kim.
+
+        -w (--web-security) commandline allows to disable/enable web security (enabled by default).
+        The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
+        resources from other domains (cross-domain requests) such as access map location on another server.
+        Another possibility is to launch in a webkit browser local file tests that will refer to the links
+        in the http website loaded in an iframe. It will not be possible without deactivation of web security.
+
+        * MiniBrowser/efl/main.c:
+        (window_create):
+        (elm_main):
+
+2014-06-06  Simon Fraser  <simon.fraser@apple.com>
+
+        32-bit build fix.
+
+        * WebKitTestRunner/mac/EventSenderProxy.mm:
+        (WTR::EventSenderProxy::mouseMoveTo):
+        (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
+
+2014-06-06  Simon Fraser  <simon.fraser@apple.com>
+
+        Fix builds on 10.8; -firstObject isn't declared on NSArray there.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (createWebViewAndOffscreenWindow):
+        * DumpRenderTree/mac/EventSendingController.mm:
+        (-[EventSendingController mouseScrollByX:andY:continuously:]):
+        (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
+        * WebKitTestRunner/mac/EventSenderProxy.mm:
+        (WTR::EventSenderProxy::mouseScrollBy):
+        (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
+
+2014-06-06  Simon Fraser  <simon.fraser@apple.com>
+
+        Latched scrolling tests are flakey on Mavericks
+        https://bugs.webkit.org/show_bug.cgi?id=133578
+        <rdar://problem/17180591>
+
+        Reviewed by Brent Fulgham.
+        
+        The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
+        be wrong on machines with more than one screen. This is because we use
+        [NSScreen mainScreen] when computing the global coordinates of the events, but
+        [NSScreen mainScreen] returns the screen with the key window, not the first screen.
+        
+        So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
+        add comments clarifying why the coordinate math works (which is not obvious given
+        the events have no target window).
+        
+        Some scrolling tests also dispatched events outside the 800x600 test window, so
+        fix those tests, and add logging that will appear in test output when this happens.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (createWebViewAndOffscreenWindow):
+        * DumpRenderTree/mac/EventSendingController.mm:
+        (-[EventSendingController mouseScrollByX:andY:continuously:]):
+        (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
+        * WebKitTestRunner/mac/EventSenderProxy.mm:
+        (WTR::EventSenderProxy::mouseMoveTo):
+        (WTR::EventSenderProxy::mouseScrollBy):
+        (WTR::EventSenderProxy::continuousMouseScrollBy):
+        (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
+
+2014-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
+
+        [GTK] run-perf-tests should run the tests inside the jhbuild shell.
+        https://bugs.webkit.org/show_bug.cgi?id=133533
+
+        Reviewed by Carlos Garcia Campos.
+
+        * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
+        (run): Remove the jhbuild-wrapper wrapper from here. It should be
+        on Scripts/webkitpy/port/gtk.py.
+        * Scripts/webkitpy/port/base.py:
+        (Port.set_option): Add a set_option(name, value) function to set
+        the optparse parameter "name" to the value "value", even if the
+        parameter "name" is already initialized.
+        * Scripts/webkitpy/port/gtk.py:
+        (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
+        If another wrapper is specified via the option "-l --wrapper=x",
+        then prepend the jhbuild-wrapper to the one specified.
+
+2014-06-04  David Farler  <dfarler@apple.com>
+
+        Build ASan WebKit for iOS Simulator
+        https://bugs.webkit.org/show_bug.cgi?id=133489
+
+        Reviewed by Darin Adler.
+
+        * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
+        * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
+        - Add missing ASan LDFLAGS.
+        * asan/asan.xcconfig:
+        - Split compiler-rt linker flags for OS X and iOS Simulator
+
+2014-06-03  Yoav Weiss  <yoav@yoav.ws>
+
+        Add myself (yoav@yoav.ws) to contributors.json
+        https://bugs.webkit.org/show_bug.cgi?id=133492
+
+        * Scripts/webkitpy/common/config/contributors.json:
+
+2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
+
+        REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
+        https://bugs.webkit.org/show_bug.cgi?id=133149
+
+        Reviewed by Csaba Osztrogonác.
+
+        * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
+
+2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
+
+        Add a verbose flag to binding tests
+        https://bugs.webkit.org/show_bug.cgi?id=122303
+
+        Reviewed by Csaba Osztrogonác.
+
+        This patch will:
+        - Add a verbose keyword argument to the BindingsTests constructor,
+        - Add --no-verbose option to the run-bindigs-test.
+        Verbose mode, which is on by default, prints positive results to stdout as before.
+        When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
+
+        Original patch from Matthew Hanson <matthew_hanson@apple.com>
+
+        * Scripts/run-bindings-tests:
+        (main):
+        * Scripts/webkitpy/bindings/main.py:
+        (BindingsTests.__init__):
+        (BindingsTests.detect_changes):
+
+2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
+        https://bugs.webkit.org/show_bug.cgi?id=133455
+
+        Reviewed by Timothy Hatcher.
+
+        Since the perf. dashboard doesn't support following renamed benchmarks,
+        keep reporting Speedometer results as DoYouEvenBench results.
+
+        * Scripts/webkitpy/performance_tests/perftestsrunner.py:
+        (_generate_results_dict):
+
+2014-05-31  Darin Adler  <darin@apple.com>
+
+        Viewport percentage tests that resize the viewport are flaky
+        https://bugs.webkit.org/show_bug.cgi?id=133351
+
+        Reviewed by Anders Carlsson.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
+        happens to be stored in the UI delegate object. This is part of resetting the
+        window position.
+
+        * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
+        a frame rectangle. The size is stored in the size of the web view itself.
+        * DumpRenderTree/mac/UIDelegate.mm:
+        (-[UIDelegate resetWindowOrigin]): Added.
+        (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
+        old version would store the frame, but not resize the web view!
+        (-[UIDelegate webViewFrame:]): Get the size from the web view.
+
+        * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
+        (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
+
+        * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
+        (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
+        the window.
+
+        * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
+        (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
+        window gets resized too, not just the web view.
+        (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
+
+        * WebKitTestRunner/mac/PlatformWebViewMac.mm:
+        (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
+        window gets resized too, not just the web view.
+        (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
+
+2014-05-30  Michael Saboff  <msaboff@apple.com>
+
+        Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
+        https://bugs.webkit.org/show_bug.cgi?id=133409
+
+        Reviewed by Filip Pizlo.
+
+        Handle creating a tarball the same way as running remote when processing
+        paths in prepareBundle.
+
+        * Scripts/run-jsc-stress-tests:
+
+2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
+
+        [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=132280
+
+        Reviewed by Chris Fleizach.
+
+        Remove implementation of logAccessibilityEvents() for ATK based
+        ports, as this has proved to be a flaky method of checking that
+        ATK events are being properly emitted. Instead, it's better to use
+        the addNotificationListener() functions and provide a JS callback
+        to check that the right events are being emmitted from the tests.
+
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
+        (WTR::AccessibilityController::logAccessibilityEvents): Replaced
+        with dummy implementation.
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
+        (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
+
+2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
+
+        [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=132280
+
+        Rubber stamped by Carlos Garcia Campos.
+
+        Fix two small issues with previous patch (r169483), that caused some tests to break.
+
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
+        (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
+        duplicated entry.
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+        (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
+
+2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
+
+        [ATK] Added new accessibility signal: text-caret-moved.
+        Make AccessibilityUIElement.setSelectedTextRange work
+        as atk_text_set_caret_offset when given offset == 0.
+        https://bugs.webkit.org/show_bug.cgi?id=132527
+
+        Reviewed by Mario Sanchez Prada.
+
+        text-caret-moved signal in accessibilityController is needed to
+        implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
+        as LayoutTests. Add the signal to the controller.
+
+        * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
+        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
+        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
+        * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
+        * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
+        (setSelectedTextRange): Change return type to bool.
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+        (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
+        (axObjectEventListener): Add notification name AXTextCaretMoved, allow
+        for extra arguments passed to handler and use it for text-caret-moved offset.
+        (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
+        Connect callback to new listener for ATK:AtkText:text-caret-moved.
+        Refactor so that failures be reported.
+        Initialize atk interfaces before trying to connect to them, see
+        https://bugzilla.gnome.org/show_bug.cgi?id=729922
+        (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
+        Simplify code by using a vector in place of dozen variables.
+        * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
+        Comment about not synchronizing with accessibilityController.
+
+2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
+
+        [GTK] Add a WebKit2 Performance bot.
+        https://bugs.webkit.org/show_bug.cgi?id=132862
+
+        Reviewed by Csaba Osztrogonác.
+
+        This adds a GTK WebKit2 perf bot.
+
+        * BuildSlaveSupport/build.webkit.org-config/config.json:
+
+2014-05-29  Dan Bernstein  <mitz@apple.com>
+
+        Fixed the WebKitTestRunner build after r169452.
+
+        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
+        (WTR::InjectedBundle::initialize):
+
+2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
+
+        Unreviewed. Update my email addresses in contributors.json.
+
+        * Scripts/webkitpy/common/config/contributors.json:
+
+2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
+
+        Need an API test for bug #133193 (r169315)
+        <https://bugs.webkit.org/show_bug.cgi?id=133324>
+
+        This adds an API test that ensures that calling "stop loading" during a
+        "did fail provisional load" callback doesn't crash.
+
+        Reviewed by Andy Estes.
+
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+        Add new files to project.
+
+        * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
+        (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
+        If the message is the "test done" message, record that.
+        (TestWebKitAPI::setInjectedBundleClient):
+        Register a function for the "did receive message from injected bundle"
+        callback.
+        (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
+        Assert that we received the message from the injected bundle, and set
+        'done' to finish the test.
+        (TestWebKitAPI::TEST):
+        Create a WebView, register a page loader client for the "did fail
+        provisional load" callback, and load a non-existent resource.
+
+        * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
+        (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
+        (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
+        Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
+        provisional load failed.
+        (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
+        Register a page loader client for the "did fail provisional load"
+        callback.
+        (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
+        Call WKBundlePageStopLoading() during the callback. This not crashing
+        is what we're ensuring with this test.
+
+2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Make it possible to build with FTL enabled
+        https://bugs.webkit.org/show_bug.cgi?id=133219
+
+        Reviewed by Philippe Normand.
+
+        * gtk/jhbuild-optional.modules: Add llvm from svn and build the
+        same revision than mac.
+
 2014-05-27  Michael Saboff  <msaboff@apple.com>
 
         REGRESSION(r169265): sh: line 0: cd: ../.vm