[WHLSL] Implement texture types
[WebKit-https.git] / Tools / ChangeLog
index 3ad6772..dac92aa 100644 (file)
@@ -1,3 +1,602 @@
+2018-09-04  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        [WHLSL] Implement texture types
+        https://bugs.webkit.org/show_bug.cgi?id=188940
+
+        Rubber-stamped by Dean Jackson.
+
+        Implement the texture types and operations. This includes Sample(), Load(), Store(), Gather(), and GetDimensions().
+        These functions were implemented according to section 15 of the Vulkan 1.1.83 spec, which lists each operation
+        and how to compute its results.
+
+        * WebGPUShadingLanguageRI/All.js:
+        * WebGPUShadingLanguageRI/Casts.js: Moved from Intrinsics. The texture operations need to cast too, so these are
+        moved into a common location.
+        (cast):
+        (bitwiseCast):
+        (castToUchar):
+        (castToUshort):
+        (castToUint):
+        (castToChar):
+        (castToShort):
+        (castToInt):
+        (castToHalf):
+        (castToFloat):
+        * WebGPUShadingLanguageRI/Intrinsics.js: Use Casts.js and call into TextureOperations.js.
+        (Intrinsics.):
+        (Intrinsics.checkFalse):
+        (Intrinsics.boxVector):
+        (Intrinsics.unboxVector):
+        (Intrinsics):
+        (Intrinsics.cast): Deleted.
+        (Intrinsics.bitwiseCast): Deleted.
+        (Intrinsics.castToHalf): Deleted.
+        * WebGPUShadingLanguageRI/SPIRV.html:
+        * WebGPUShadingLanguageRI/Sampler.js: Added. Represent the Sampler type. 
+        (Sampler):
+        (Sampler.prototype.get rAddressMode):
+        (Sampler.prototype.get sAddressMode):
+        (Sampler.prototype.get tAddressMode):
+        (Sampler.prototype.get minFilter):
+        (Sampler.prototype.get magFilter):
+        (Sampler.prototype.get mipmapFilter):
+        (Sampler.prototype.get lodMinClamp):
+        (Sampler.prototype.get lodMaxClamp):
+        (Sampler.prototype.get maxAnisotropy):
+        (Sampler.prototype.get compareFunction):
+        (Sampler.prototype.get borderColor):
+        (Sampler.prototype.calculateBorderColor.computeValues):
+        (Sampler.prototype.calculateBorderColor):
+        * WebGPUShadingLanguageRI/StandardLibrary.js: Update the standard library. Some of the functions were
+        either missing or wrong.
+        (let.standardLibrary):
+        * WebGPUShadingLanguageRI/Test.html:
+        * WebGPUShadingLanguageRI/Test.js: Test many, many combinations of the texture operations.
+        (makeSampler):
+        (make1DTexture):
+        (make1DTextureArray):
+        (make2DTexture):
+        (make2DTextureArray):
+        (make3DTexture):
+        (makeTextureCube):
+        (makeRW1DTexture):
+        (makeRW1DTextureArray):
+        (makeRW2DTexture):
+        (makeRW2DTextureArray):
+        (makeRW3DTexture):
+        (make2DDepthTexture):
+        (make2DDepthTextureArray):
+        (makeDepthTextureCube):
+        (makeRW2DDepthTexture):
+        (makeRW2DDepthTextureArray):
+        (checkFloat4):
+        * WebGPUShadingLanguageRI/Texture.js: Added. Represents each of the texture types.
+        (Texture):
+        (Texture.prototype.get dimension):
+        (Texture.prototype.get width):
+        (Texture.prototype.get height):
+        (Texture.prototype.get depth):
+        (Texture.prototype.get levelCount):
+        (Texture.prototype.get layerCount):
+        (Texture.prototype.get innerType):
+        (Texture.prototype.get data):
+        (Texture.prototype.elementChecked):
+        (Texture.prototype.setElementChecked):
+        (Texture1D):
+        (Texture1D.prototype.widthAtLevel):
+        (Texture1D.prototype.heightAtLevel):
+        (Texture1D.prototype.depthAtLevel):
+        (Texture1D.prototype.element):
+        (Texture1D.prototype.setElement):
+        (Texture1DArray):
+        (Texture1DArray.prototype.widthAtLevel):
+        (Texture1DArray.prototype.heightAtLevel):
+        (Texture1DArray.prototype.depthAtLevel):
+        (Texture1DArray.prototype.element):
+        (Texture1DArray.prototype.setElement):
+        (Texture2D):
+        (Texture2D.prototype.widthAtLevel):
+        (Texture2D.prototype.heightAtLevel):
+        (Texture2D.prototype.depthAtLevel):
+        (Texture2D.prototype.element):
+        (Texture2D.prototype.setElement):
+        (Texture2DArray):
+        (Texture2DArray.prototype.widthAtLevel):
+        (Texture2DArray.prototype.heightAtLevel):
+        (Texture2DArray.prototype.depthAtLevel):
+        (Texture2DArray.prototype.element):
+        (Texture2DArray.prototype.setElement):
+        (Texture3D):
+        (Texture3D.prototype.widthAtLevel):
+        (Texture3D.prototype.heightAtLevel):
+        (Texture3D.prototype.depthAtLevel):
+        (Texture3D.prototype.element):
+        (Texture3D.prototype.setElement):
+        (TextureCube):
+        (TextureCube.prototype.widthAtLevel):
+        (TextureCube.prototype.heightAtLevel):
+        (TextureCube.prototype.depthAtLevel):
+        (TextureCube.prototype.element):
+        (TextureCube.prototype.setElement):
+        (Texture1DRW):
+        (Texture1DRW.prototype.widthAtLevel):
+        (Texture1DRW.prototype.heightAtLevel):
+        (Texture1DRW.prototype.depthAtLevel):
+        (Texture1DRW.prototype.element):
+        (Texture1DRW.prototype.setElement):
+        (Texture1DArrayRW):
+        (Texture1DArrayRW.prototype.widthAtLevel):
+        (Texture1DArrayRW.prototype.heightAtLevel):
+        (Texture1DArrayRW.prototype.depthAtLevel):
+        (Texture1DArrayRW.prototype.element):
+        (Texture1DArrayRW.prototype.setElement):
+        (Texture2DRW):
+        (Texture2DRW.prototype.widthAtLevel):
+        (Texture2DRW.prototype.heightAtLevel):
+        (Texture2DRW.prototype.depthAtLevel):
+        (Texture2DRW.prototype.element):
+        (Texture2DRW.prototype.setElement):
+        (Texture2DArrayRW):
+        (Texture2DArrayRW.prototype.widthAtLevel):
+        (Texture2DArrayRW.prototype.heightAtLevel):
+        (Texture2DArrayRW.prototype.depthAtLevel):
+        (Texture2DArrayRW.prototype.element):
+        (Texture2DArrayRW.prototype.setElement):
+        (let.TextureDepth2DArrayRW.Texture2DArrayRW.Texture3DRW):
+        (let.TextureDepth2DArrayRW.Texture2DArrayRW.Texture3DRW.prototype.widthAtLevel):
+        (let.TextureDepth2DArrayRW.Texture2DArrayRW.Texture3DRW.prototype.heightAtLevel):
+        (let.TextureDepth2DArrayRW.Texture2DArrayRW.Texture3DRW.prototype.depthAtLevel):
+        (let.TextureDepth2DArrayRW.Texture2DArrayRW.Texture3DRW.prototype.element):
+        (let.TextureDepth2DArrayRW.Texture2DArrayRW.Texture3DRW.prototype.setElement):
+        * WebGPUShadingLanguageRI/TextureOperations.js: Added. This implements the texture operations
+        as described in section 15 of the Vulkan 1.1.83 spec.
+        (depthCompareOperation):
+        (conversionToRGBA):
+        (projectionOperation):
+        (cubeMapFaceSelection):
+        (cubeMapCoordinateTransformation):
+        (cubeMapDerivativeTransformation):
+        (scaleFactorOperation):
+        (levelOfDetailOperation):
+        (nearest):
+        (imageLevelSelection):
+        (strqaToUVWATransformation):
+        (rne):
+        (uvwaToIJKLNTransformationAndArrayLayerSelection):
+        (integerTexelCoordinateOperations):
+        (mirror):
+        (transform):
+        (wrappingOperation):
+        (calculateLambda):
+        (shouldBeBorder):
+        (accessColor):
+        (computeTau):
+        (reduce):
+        (texelGathering):
+        (computeColorFromLevel):
+        (texelFiltering):
+        (castToInnerTypeForGather):
+        (gatherTexture):
+        (castToInnerType):
+        (sampleTexture):
+        * WebGPUShadingLanguageRI/index.html:
+
+2018-09-04  Alexey Proskuryakov  <ap@apple.com>
+
+        Removing an accidentally committed debugging print.
+
+        * Scripts/run-leaks: (runLeaks)
+
+2018-09-04  Alexey Proskuryakov  <ap@apple.com>
+
+        run-leaks should run leaks with --list (on Mojave)
+        https://bugs.webkit.org/show_bug.cgi?id=187716
+        <rdar://problem/42261676>
+
+        Reviewed by Lucas Forschler.
+
+        Also enabled dumping memgraphs. We'll be pruning these aggressively, as they take
+        significant space.
+
+        * Scripts/run-leaks:
+        (main): Added an option to store memgraphs.
+        (runLeaks): As there is no way to test whether the new format is supported in advance,
+        we have to try with --list first, and retry if that fails. Also, made leaks operate
+        on a memgraph file if we are saving it anyway.
+
+        * Scripts/webkitpy/port/leakdetector.py:
+        (LeakDetector._leaks_args): Pass --memgraph-file to run-leaks.
+        (LeakDetector.leaks_file_name): Removed an incorrect comment.
+        (LeakDetector.memgraph_file_name): Added.
+        (LeakDetector.check_for_leaks): Changed how arguments are passed to _leaks_args.
+        It is a bit ugly that leaks path ends up being computed twice, but this is the least
+        ugly approach that I could find.
+
+        * Scripts/webkitpy/port/leakdetector_unittest.py: Updated for _leaks_args changes.
+
+2018-09-04  Chris Dumez  <cdumez@apple.com>
+
+        Add process pool configuration flag to turn on automatic process pre-warming
+        https://bugs.webkit.org/show_bug.cgi?id=189263
+        <rdar://problem/44101941>
+
+        Reviewed by Antti Koivisto.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm.
+        (TEST):
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+        * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm: Removed.
+
+2018-09-04  Keith Miller  <keith_miller@apple.com>
+
+        Perl doesn't like calling keys on a reference
+        https://bugs.webkit.org/show_bug.cgi?id=189261
+
+        Reviewed by Michael Saboff.
+
+        * Scripts/test262/Runner.pm:
+        (UpdateResults):
+
+2018-09-04  Jer Noble  <jer.noble@apple.com>
+
+        REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=187972
+        <rdar://problem/42667737>
+
+        Reviewed by Darin Adler.
+
+        Ensure that listeners are added in time to catch messages broadcast at them.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
+        (TestWebKitAPI::TEST):
+
+2018-09-04  Ross Kirsling  <ross.kirsling@sony.com>
+
+        Update googletest
+        https://bugs.webkit.org/show_bug.cgi?id=175722
+
+        Reviewed by Brent Fulgham.
+
+        * TestWebKitAPI/config.h:
+        Instead of modifying the gtest source, add the necessary WTF includes here.
+
+        * TestWebKitAPI/Configurations/Base.xcconfig
+        Remove obsoleted definitions GTEST_HAS_TR1_TUPLE=0 and GTEST_HAS_RTTI=0.
+
+2018-09-03  Pablo Saavedra  <psaavedra@igalia.com>
+
+        [WPE] Add more WPE bots to dashboard
+        https://bugs.webkit.org/show_bug.cgi?id=189245
+
+        Reviewed by Daniel Bates.
+
+        There are two missing bots which are not listed in the dashboard for
+        a while: WPE Linux 64-bit Debug (Build) and WPE Linux 64-bit Debug (Tests)
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
+        (WebKitBuildbot):
+
+2018-09-01  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [WPE] 2.21.91 fails to build with ENABLE_MINIBROWSER
+        https://bugs.webkit.org/show_bug.cgi?id=189006
+
+        Reviewed by Darin Adler.
+
+        The MiniBrowser source code is missing from the tarball. Oops! Add it.
+
+        * wpe/manifest.txt.in:
+
+2018-09-01  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
+
+        [WinCairo] Add CryptoDigestOpenSSL
+        https://bugs.webkit.org/show_bug.cgi?id=188978
+
+        Reviewed by Darin Adler.
+
+        Add API tests for the PAL::CryptoDigest class.
+
+        * TestWebKitAPI/PlatformWin.cmake:
+        Add CryptoDigest.cpp to TestWebCoreLib_Sources.
+
+        Define -DSTATICALLY_LINKED_WITH_PAL=1 to avoid warnings since
+        without the definition the functions marked with PAL_EXPORT are supposed to be
+        imported from another shared library, but as it is, TestWebCoreLib
+        links PAL statically.
+
+        * TestWebKitAPI/Tests/WebCore/CryptoDigest.cpp: Added.
+        (TestWebKitAPI::toHex):
+        (TestWebKitAPI::expect):
+        (TestWebKitAPI::expectSHA1):
+        (TestWebKitAPI::expectSHA224):
+        (TestWebKitAPI::expectSHA256):
+        (TestWebKitAPI::expectSHA384):
+        (TestWebKitAPI::expectSHA512):
+        (TestWebKitAPI::TEST):
+
+2018-09-01  Dan Bernstein  <mitz@apple.com>
+
+        [Cocoa] Crash using KVO for 'serverTrust' property of WKWebView - "this class is not key value coding-compliant for the key serverTrust"
+        https://bugs.webkit.org/show_bug.cgi?id=189222
+        <rdar://problem/33283179>
+
+        Reviewed by Sam Weinig.
+
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+        * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewServerTrustKVC.mm: Added.
+        (TEST):
+
+2018-08-31  Aditya Keerthi  <akeerthi@apple.com>
+
+        Unreviewed, add an alternate email for Aditya Keerthi.
+
+        * Scripts/webkitpy/common/config/contributors.json:
+
+2018-08-31  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
+        https://bugs.webkit.org/show_bug.cgi?id=189054
+        <rdar://problem/43819779>
+
+        Reviewed by Tim Horton.
+
+        See WebCore/ChangeLog for more detail.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
+        (createWebViewWithCustomPasteboardDataEnabled):
+
+2018-08-31  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r235565.
+        https://bugs.webkit.org/show_bug.cgi?id=189212
+
+        Broke the WHLSL build (Requested by litherum on #webkit).
+
+        Reverted changeset:
+
+        "[WHLSL] Remove useless code in NameResolver"
+        https://bugs.webkit.org/show_bug.cgi?id=189176
+        https://trac.webkit.org/changeset/235565
+
+2018-08-31  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        [WHLSL] Remove useless code in NameResolver
+        https://bugs.webkit.org/show_bug.cgi?id=189176
+
+        Reviewed by Dean Jackson and Thomas Denney.
+
+        The check will always pass becase the standard library contains at least one function with the correct name.
+
+        * WebGPUShadingLanguageRI/NameResolver.js:
+        (NameResolver.prototype.visitDotExpression):
+        (NameResolver.prototype._handlePropertyAccess): Deleted.
+        (NameResolver.prototype.visitIndexExpression): Deleted.
+
+2018-08-31  Simon Fraser  <simon.fraser@apple.com>
+
+        Make it possible to mark tests as leaks in TestExpectations
+        https://bugs.webkit.org/show_bug.cgi?id=189088
+
+        Reviewed by Jon Lee.
+        
+        Have webkitpy parse out "Leak" expectations in TestExpectations, and do the right
+        thing if the test run did not use --world-leaks. Add unit tests for leaks combined
+        with various other result combinations.
+
+        * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
+        (LayoutTestRunner._update_summary_with_result):
+        (LayoutTestRunner._annotate_results_with_additional_failures):
+        * Scripts/webkitpy/layout_tests/models/test_expectations.py:
+        (TestExpectationParser):
+        (TestExpectations): The 'Leak' line was duplicated here, so remove a copy.
+        (TestExpectations.remove_leak_failures):
+        (TestExpectations.matches_an_expected_result):
+        * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
+        (Base.get_basic_tests):
+        * Scripts/webkitpy/port/test.py:
+        (TestList.add_reftest):
+        (unit_test_list):
+
+2018-08-31  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC] Add margin box verification back now that Display::Box has non-computed horizontal margin.
+        https://bugs.webkit.org/show_bug.cgi?id=189193
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2018-08-31  Antti Koivisto  <antti@apple.com>
+
+        Replace OptionSet |= and -= operators with add() and remove() functions
+        https://bugs.webkit.org/show_bug.cgi?id=189169
+
+        Reviewed by Anders Carlsson.
+
+        * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
+        (TestWebKitAPI::TEST):
+
+2018-08-31  Daniel Bates  <dabates@apple.com>
+
+        lldb-webkit: KeyError thrown for OptionSet with invalid value
+        https://bugs.webkit.org/show_bug.cgi?id=189070
+
+        Update comment to explain that we return early and do not compute the set of enumerators in the
+        OptionSet when the underlying value of the set is an invalid value.
+
+        Additionally, update the change log entry for r235482 to reflect the updated title for the bug
+        and to better describe the change that was made.
+
+        * lldb/lldb_webkit.py:
+        (WTFOptionSetProvider.update):
+
+2018-08-31  David Kilzer  <ddkilzer@apple.com>
+
+        WebKitLauncher: Move WebKitLauncher.entitlements into Configurations directory
+
+        This makes the Configurations folder in the Xcode project match
+        what's in the Configurations directory on disk.  Found by
+        tidy-Xcode-project-file (see Bug 188754).
+
+        * WebKitLauncher/Configurations/WebKitLauncher.entitlements: Rename from Tools/WebKitLauncher/WebKitLauncher.entitlements.
+        * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
+        - Update project for file move.
+
+2018-08-31  David Kilzer  <ddkilzer@apple.com>
+
+        WebKitLauncher: Fix build failures
+
+        * WebKitLauncher/Configurations/Base.xcconfig:
+        (ARCHS): Use $(ARCHS_STANDARD_32_64_BIT).
+        (MACOSX_DEPLOYMENT_TARGET): Update from Snow Leopard to Sierra.
+
+        * WebKitLauncher/WebKitNightlyEnabler.m:
+        (myApplicationWillFinishLaunching):
+        * WebKitLauncher/main.m:
+        (displayErrorAndQuit):
+        (locateSafariBundle):
+        - Use pragma to ignore deprecation warnings.
+
+2018-08-31  David Kilzer  <ddkilzer@apple.com>
+
+        MobileMiniBrowser: Move test2s.mp4 into Resources directory
+
+        This makes the Resources folder in the Xcode project match
+        what's in the Resources directory on disk.  Found by
+        tidy-Xcode-project-file (see Bug 188754).
+
+        * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
+        - Update project for file move.
+        * MobileMiniBrowser/MobileMiniBrowserFramework/Resources/test2s.mp4: Rename from Tools/MobileMiniBrowser/MobileMiniBrowserFramework/test2s.mp4.
+
+2018-08-31  Frederic Wang  <fwang@igalia.com>
+
+        Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
+        https://bugs.webkit.org/show_bug.cgi?id=182053
+
+        Reviewed by Simon Fraser.
+
+        Add FIXMEs comments to add the new developer flag in the future and  disable it for now.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (enableExperimentalFeatures):
+        (resetWebPreferencesToConsistentValues):
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (enableExperimentalFeatures):
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::resetPreferencesToConsistentValues):
+
+2018-08-30  Thomas Denney  <tdenney@apple.com>
+
+        [WHLSL] Fix array indexing behavior
+        https://bugs.webkit.org/show_bug.cgi?id=189175
+
+        Array, pointer, and array ref types are now parsed and then constructed
+        in reverse so that the declaration order matches the indexing order, as
+        in C/C++.
+
+        Reviewed by Myles C. Maxfield.
+
+        * WebGPUShadingLanguageRI/Parse.js:
+        (parseType):
+        * WebGPUShadingLanguageRI/Test.js:
+
+2018-08-30  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Followup to [iOS] TestWebKitAPI.PasteImage tests are flaky failures
+        https://bugs.webkit.org/show_bug.cgi?id=185965
+
+        Reviewed by Andy Estes.
+
+        The first attempt to fix these flaky tests on iOS caused timeouts on macOS while waiting for a "loaded" message
+        from the page. To (hopefully) fix this across both platforms, make sure that we first register our script
+        message handlers in the UI process *before* evaluating script that could propagate the script message.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
+        (-[TestWKWebView waitForMessage:afterEvaluatingScript:]):
+        (TEST):
+
+2018-08-30  Thomas Denney  <tdenney@apple.com>
+
+        [WHLSL] Implement tests to verify array indexing order matches our desires
+        https://bugs.webkit.org/show_bug.cgi?id=189099
+
+        Reviewed by Myles C. Maxfield.
+
+        * WebGPUShadingLanguageRI/Test.js: Add new test for array indexing order
+        and the option to explicitly disable tests (this test is disabled by
+        default).
+        * WebGPUShadingLanguageRI/TypeRef.js:
+        (TypeRef.wrap): Fixes  typo.
+
+2018-08-30  Sihui Liu  <sihui_liu@apple.com>
+
+        WKNavigation.ProcessCrashDuringCallback is failing on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=189148
+
+        Reviewed by Chris Dumez.
+
+        We should not deference WebView or we may get WKErrorWebViewInvalidated error, because 
+        WebView could be destroyed before Web Process termination is noticed.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
+        (TEST):
+
+2018-08-30  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][Floating] Formatting context roots avoid floats.
+        https://bugs.webkit.org/show_bug.cgi?id=189150
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2018-08-30  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iOS] TestWebKitAPI.PasteImage tests are flaky failures
+        https://bugs.webkit.org/show_bug.cgi?id=185965
+
+        Reviewed by Andy Estes.
+
+        These tests pass reliably when run locally, but sometimes fail in automation when checking that the image
+        element with its "src" attribute set to a new blob URL has an empty size. It's possible that this is happening
+        because we're checking the size of the image element prior to image load after setting the blob URL; we can fix
+        this by waiting for the "load" event (which is also done in some of the other tests in this file).
+
+        * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
+        (TEST):
+
+2018-08-30  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Unreviewed, rolling out r235114.
+
+        ostree server deleted our commits?
+
+        Reverted changeset:
+
+        "[Flatpak] Update to GNOME master runtime"
+        https://bugs.webkit.org/show_bug.cgi?id=188731
+        https://trac.webkit.org/changeset/235114
+
+2018-08-29  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        [WHLSL] Test row-majorness of matrices
+        https://bugs.webkit.org/show_bug.cgi?id=189101
+
+        The matrix multiplication functions are temporarily commented out of the standard library,
+        so I've temporarily copy/pasted them into the test. Matrix multiplication is not
+        commutative, so it requires the right indexing order.
+
+        Reviewed by Dean Jackson and Thomas Denney.
+
+        * WebGPUShadingLanguageRI/Intrinsics.js:
+        * WebGPUShadingLanguageRI/StandardLibrary.js:
+        (let.standardLibrary):
+        * WebGPUShadingLanguageRI/Test.js:
+
 2018-08-29  Jer Noble  <jer.noble@apple.com>
 
         Unreviewed test gardening; NowPlayingTest API tests require High Sierra.
 
 2018-08-29  Daniel Bates  <dabates@apple.com>
 
-        lldb-webkit: KeyError thrown for uninitialized OptionSet
+        lldb-webkit: KeyError thrown for OptionSet with invalid value
         https://bugs.webkit.org/show_bug.cgi?id=189070
 
         Reviewed by Simon Fraser.
 
-        Do not compute what enumerators are in an uninitialized OptionSet. A local OptionSet variable
-        is only considered initialized when execution passes over its assignment regardless of whether
-        the variable is in scope.
+        Do not compute what enumerators are in an OptionSet with an invalid value. A local OptionSet
+        variable is only considered valid when execution passes over its assignment/constructor.
 
-        The LLDB Python API does not provide a way to determine whether an variable is initialized.
-        So, we use a simple heuristic: when the value of the OptionSet is greater than the value
-        of the bitmask with all enumerators set then we consider the OptionSet to be garbage (i.e.
-        uninitialized memory). When the variable is finally initialized LLDB will notify us to update
-        our state.
+        The LLDB Python API does not provide a way to determine whether a variable has a valid
+        value (SBValue.IsValid() does not seem to check if the actual bit pattern in memory for
+        a variable represents a valid value). So, we use a simple heuristic: when the value of
+        the OptionSet is greater than the value of the bitmask with all enumerators set then we
+        consider the OptionSet to be invalid. When the variable obtains a valid value then LLDB
+        will notify us to update our state.
 
         * lldb/lldb_webkit.py:
         (WTFOptionSetProvider.update):