Update flakiness dashboard configuration for Mojave queues
[WebKit-https.git] / Tools / ChangeLog
index 60dc9bc..b0af041 100644 (file)
+2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Update flakiness dashboard configuration for Mojave queues
+        https://bugs.webkit.org/show_bug.cgi?id=190068
+
+        Reviewed by Alexey Proskuryakov.
+
+        * TestResultServer/static-dashboards/builders.jsonp:
+
+2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Bring up queues for Mojave
+        https://bugs.webkit.org/show_bug.cgi?id=189935
+
+        Unreviewed infrastructure fix.
+
+        * BuildSlaveSupport/build.webkit.org-config/config.json: Remove trigger, update bot assignment.
+
+2018-09-24  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Bring up queues for Mojave
+        https://bugs.webkit.org/show_bug.cgi?id=189935
+
+        Reviewed by Alexey Proskuryakov.
+
+        * BuildSlaveSupport/build.webkit.org-config/config.json:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
+        (WebKitBuildbot):
+        * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
+
+2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Increase the timeout for iOS Simulator data migration
+        https://bugs.webkit.org/show_bug.cgi?id=190059
+
+        Reviewed by Aakash Jain.
+
+        3 minutes isn't always enough time for the data migrator to complete
+        when booting up multiple iOS Simulators. Change the timeout to 10 minutes.
+
+        * Scripts/webkitpy/xcode/simulated_device.py:
+        (SimulatedDeviceManager): Create a constant for the default timeout.
+        (SimulatedDeviceManager.initialize_devices): Use new constant.
+        (SimulatedDeviceManager.swap): Ditto.
+        (SimulatedDeviceManager.wait_until_data_migration_is_done): Ditto.
+
+2018-09-27  Alex Christensen  <achristensen@webkit.org>
+
+        URLParser should use TextEncoding through an abstract class
+        https://bugs.webkit.org/show_bug.cgi?id=190027
+
+        Reviewed by Andy Estes.
+
+        * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
+        (TestWebKitAPI::checkURL):
+        (TestWebKitAPI::TEST_F):
+
+2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
+
+        iOS Simulator bots should pass '--dedicated-simulators' to run-webkit-tests
+        https://bugs.webkit.org/show_bug.cgi?id=190042
+
+        Reviewed by Aakash Jain.
+
+        To make iOS Simulator bots resilient to issues that can arise from reusing
+        existing simulators, ensure that dedicated simulators are created for each test run.
+
+        * Scripts/webkitpy/common/config/ports.py:
+        (IOSSimulatorWK2Port.run_webkit_tests_command):
+
+2018-09-27  Alex Christensen  <achristensen@webkit.org>
+
+        URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
+        https://bugs.webkit.org/show_bug.cgi?id=189979
+
+        Reviewed by Youenn Fablet.
+
+        * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
+        (TestWebKitAPI::originalDataAsString):
+        (TestWebKitAPI::TEST):
+
+2018-09-27  Basuke Suzuki  <Basuke.Suzuki@sony.com>
+
+        [Win][WebKit] Implement authentication dialog on MiniBrowser.
+        https://bugs.webkit.org/show_bug.cgi?id=189846
+
+        Reviewed by Fujii Hironori.
+
+        It was implemented for WebKitLegacy, but not for WebKit.
+        Also added text field to display Realm information.
+
+        * MiniBrowser/win/Common.cpp:
+        (authDialogProc):
+        (askCredential):
+        (displayAuthDialog): Deleted.
+        * MiniBrowser/win/Common.h:
+        * MiniBrowser/win/MiniBrowserLib.rc:
+        * MiniBrowser/win/MiniBrowserLibResource.h:
+        * MiniBrowser/win/ResourceLoadDelegate.cpp:
+        (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
+        * MiniBrowser/win/WebKitBrowserWindow.cpp:
+        (createString):
+        (createUTF8String):
+        (createWKString):
+        (createWKURL):
+        (WebKitBrowserWindow::WebKitBrowserWindow):
+        (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
+        (toNullTerminatedUTF8): Deleted.
+        * MiniBrowser/win/WebKitBrowserWindow.h:
+
+2018-09-27  Youenn Fablet  <youenn@apple.com>
+
+        Enable getUserMedia in mini browser
+        https://bugs.webkit.org/show_bug.cgi?id=190012
+
+        Reviewed by Eric Carlson.
+
+        Enable MediaDevices and mock capture devices.
+        Grant mock devices access to any getUserMedia call.
+        Covered by manual testing.
+
+        * MiniBrowser/mac/AppDelegate.m:
+        (defaultConfiguration):
+        * MiniBrowser/mac/WK2BrowserWindowController.m:
+        (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
+        (-[WK2BrowserWindowController _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
+
+2018-09-27  Antoine Quint  <graouts@apple.com>
+
+        [Web Animations] Turn Web Animations with CSS integration on
+        https://bugs.webkit.org/show_bug.cgi?id=184819
+        <rdar://problem/39597337>
+
+        Reviewed by Dean Jackson.
+
+        * DumpRenderTree/TestOptions.h:
+
+2018-09-26  Alex Christensen  <achristensen@webkit.org>
+
+        Unreviewed, rolling out r236524.
+
+        Broke API tests
+
+        Reverted changeset:
+
+        "URLWithUserTypedString should return nil for URLs deemed to
+        be invalid by WebCore::URL"
+        https://bugs.webkit.org/show_bug.cgi?id=189979
+        https://trac.webkit.org/changeset/236524
+
+2018-09-26  James Savage  <james.savage@apple.com>
+
+        Allow override of viewport configuration.
+        https://bugs.webkit.org/show_bug.cgi?id=188772.
+        <rdar://problem/43538892>.
+
+        Reviewed by Simon Fraser.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::updateTestOptionsFromTestHeader): Parse new test option key from comments.
+        * WebKitTestRunner/TestOptions.h:
+        * WebKitTestRunner/ios/TestControllerIOS.mm:
+        (WTR::TestController::platformConfigureViewForTest): Handle new test option by
+        modifying the web view's preferences accordingly.
+
+2018-09-26  Alex Christensen  <achristensen@webkit.org>
+
+        URLs with mismatched surrogate pairs in the host should fail to parse
+        https://bugs.webkit.org/show_bug.cgi?id=190005
+
+        Reviewed by Chris Dumez.
+
+        * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
+        (TestWebKitAPI::TEST_F):
+
+2018-09-26  Alex Christensen  <achristensen@webkit.org>
+
+        URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
+        https://bugs.webkit.org/show_bug.cgi?id=189979
+        <rdar://problem/44119696>
+
+        Reviewed by Chris Dumez.
+
+        * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
+        (TestWebKitAPI::TEST):
+
+2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Selection should work across shadow boundary when initiated by a mouse drag
+        https://bugs.webkit.org/show_bug.cgi?id=151380
+        <rdar://problem/24363872>
+
+        Reviewed by Wenson Hsieh.
+
+        Added the support for internal:selectionAcrossShadowBoundariesEnabled test option.
+
+        * DumpRenderTree/TestOptions.cpp:
+        (TestOptions::TestOptions):
+        * DumpRenderTree/TestOptions.h:
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (resetWebPreferencesToConsistentValues):
+        (setWebPreferencesForTestOptions):
+
+2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
+
+        MiniBrowser doesn't respect default enabled-ness of experimental and internal debug features
+        https://bugs.webkit.org/show_bug.cgi?id=189989
+
+        Reviewed by Simon Fraser.
+
+        When the preference isn't found in user defaults, use the default value of each feature's enabledness.
+
+        * MiniBrowser/mac/AppDelegate.m:
+        (defaultConfiguration):
+
+2018-09-26  Philippe Normand  <pnormand@igalia.com>
+
+        [Flatpak] Bump to apr 1.6.5
+
+        Version 1.6.3 is no longer available on Apache's website.
+
+        Rubber-stamped by Michael Catanzaro.
+
+        * flatpak/org.webkit.WebKit.yaml:
+
+2018-09-25  Jiewen Tan  <jiewen_tan@apple.com>
+
+        [WebAuthN] Make AuthenticatorManager
+        https://bugs.webkit.org/show_bug.cgi?id=189279
+        <rdar://problem/44116792>
+
+        Reviewed by Chris Dumez.
+
+        Besides the functionality to set the WebAuthenticationMockConfiguration. Three operations are
+        added to manipulate Keychain: addTestKeyToKeychain, cleanUpKeychain and keyExistedInKeychain.
+
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+        * TestWebKitAPI/Tests/ios/LocalAuthenticator.mm: Removed.
+        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
+        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+        (WTR::TestRunner::setWebAuthenticationMockConfiguration):
+        (WTR::TestRunner::addTestKeyToKeychain):
+        (WTR::TestRunner::cleanUpKeychain):
+        (WTR::TestRunner::isKeyExisted):
+        * WebKitTestRunner/InjectedBundle/TestRunner.h:
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::addTestKeyToKeychain):
+        (WTR::TestController::cleanUpKeychain):
+        (WTR::TestController::isKeyExisted):
+        (WTR::TestController::setWebAuthenticationMockConfiguration):
+        * WebKitTestRunner/TestController.h:
+        * WebKitTestRunner/TestInvocation.cpp:
+        (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
+        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
+        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
+        (WTR::TestController::addTestKeyToKeychain):
+        (WTR::TestController::cleanUpKeychain):
+        (WTR::TestController::keyExistedInKeychain):
+
+2018-09-25  Sihui Liu  <sihui_liu@apple.com>
+
+        Move Service Worker Management from Storage Process to Network Process
+        https://bugs.webkit.org/show_bug.cgi?id=189422
+
+        Reviewed by Youenn Fablet.
+
+        Change a check in ServiceWorkers.HasServiceWorkerRegistrationBit as storage process is not
+        launched during service worker operations now.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
+
+2018-09-25  Eric Carlson  <eric.carlson@apple.com>
+
+        [MediaStream] Update constraints supported by getDisplayMedia
+        https://bugs.webkit.org/show_bug.cgi?id=189930
+        <rdar://problem/44740305>
+
+        Unreviewed, fix test broken by r236465.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
+        (TestWebKitAPI::TEST_F):
+
+2018-09-25  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        [WHSL] Implement semantics
+        https://bugs.webkit.org/show_bug.cgi?id=189134
+
+        Reviewed by Filip Pizlo.
+
+        This patch adds parsing support and adds the checks required to support HLSL-style semantics.
+
+        There are 3 places where semantics are allowed:
+
+        1. In a field in a struct. E.g.
+
+        struct R {
+            float4 position : SV_Position;
+        }
+        vertex R foo() {
+            ...
+        }
+
+        2. In a parameter of a function. If the function is not an entry point, the semantic is ignored.
+
+        compute void foo(device float[] data : buffer(u0)) {
+            ...
+        }
+
+        3. On a function. This is so you don't have to create structs for the return types of simple vertex shaders.
+
+        vertex float4 foo() : SV_Position {
+            ...
+        }
+
+        The semantics are partitioned into 4 types:
+
+        1. Built-in variables. For example, : SV_Position.
+        2. Resources. For example, : register(u0).
+        3. Stage-in / stage-out variables. For example, : attribute(0).
+        4. Specialization constants. For example, : specialized.
+
+        The semantics are validated according to a collection of rules:
+
+        - The same entry point can't list the same semantic twice
+        - Each built-in type has an appropriate type that is listed in the spec. 
+        - Each built-in is appropriate as either an input or an output of a particular shader stage
+        - Resource semantics have to have the appropriate type (e.g. can't use register(s0) on a buffer)
+        - Resources can't be output from entry points
+        - The resource semantic mode must match the address space of the resource
+        - Stage-in and stage-out variables have to be POD
+        - Specialization constants can't be output from entry points, and have to be numbers
+
+        * WebGPUShadingLanguageRI/All.js:
+        * WebGPUShadingLanguageRI/BuiltInSemantic.js: Added.
+        (BuiltInSemantic):
+        (BuiltInSemantic.prototype.get name):
+        (BuiltInSemantic.prototype.get extraArguments):
+        (BuiltInSemantic.prototype.isAcceptableType):
+        (BuiltInSemantic.prototype.isAcceptableForShaderType):
+        (BuiltInSemantic.prototype.toString):
+        * WebGPUShadingLanguageRI/CallExpression.js:
+        (CallExpression.prototype._resolveWithOperatorAnderIndexer):
+        (CallExpression.prototype._resolveWithOperatorLength):
+        * WebGPUShadingLanguageRI/Checker.js:
+        (Checker):
+        (Checker.prototype.visitProgram):
+        (Checker.prototype._checkSemantics.Item):
+        (Checker.prototype._checkSemantics.Item.prototype.get type):
+        (Checker.prototype._checkSemantics.Item.prototype.get semantic):
+        (Checker.prototype._checkSemantics.Gatherer):
+        (Checker.prototype._checkSemantics.Gatherer.prototype.reset):
+        (Checker.prototype._checkSemantics.Gatherer.prototype.set currentSemantic):
+        (Checker.prototype._checkSemantics.Gatherer.prototype.get currentSemantic):
+        (Checker.prototype._checkSemantics.Gatherer.prototype.get result):
+        (Checker.prototype._checkSemantics.Gatherer.prototype.visitEnumType):
+        (Checker.prototype._checkSemantics.Gatherer.prototype.visitVectorType):
+        (Checker.prototype._checkSemantics.Gatherer.prototype.visitMatrixType):
+        (Checker.prototype._checkSemantics.Gatherer.prototype.visitNativeType):
+        (Checker.prototype._checkSemantics.Gatherer.prototype.visitStructType):
+        (Checker.prototype._checkSemantics.Gatherer.prototype.visitTypeRef):
+        (Checker.prototype._checkSemantics.Gatherer.prototype.visitPtrType):
+        (Checker.prototype._checkSemantics.Gatherer.prototype.visitArrayRefType):
+        (Checker.prototype._checkSemantics.Gatherer.prototype.visitArrayType):
+        (Checker.prototype._checkSemantics.Gatherer.prototype.visitFuncParameter):
+        (Checker.prototype._checkSemantics.checkDuplicateSemantics):
+        (Checker.prototype._checkSemantics.checkSemanticTypes):
+        (Checker.prototype._checkSemantics.checkSemanticForShaderType):
+        (Checker.prototype._checkSemantics.PODChecker.prototype.visitEnumType):
+        (Checker.prototype._checkSemantics.PODChecker.prototype.visitArrayType):
+        (Checker.prototype._checkSemantics.PODChecker.prototype.visitVectorType):
+        (Checker.prototype._checkSemantics.PODChecker.prototype.visitMatrixType):
+        (Checker.prototype._checkSemantics.PODChecker.prototype.visitNativeType):
+        (Checker.prototype._checkSemantics.PODChecker.prototype.visitPtrType):
+        (Checker.prototype._checkSemantics.PODChecker.prototype.visitArrayRefType):
+        (Checker.prototype._checkSemantics.PODChecker.prototype.visitStructType):
+        (Checker.prototype._checkSemantics.PODChecker.prototype.visitTypeRef):
+        (Checker.prototype._checkSemantics.PODChecker):
+        (Checker.prototype._checkSemantics.checkPODData):
+        (Checker.prototype._checkSemantics):
+        (Checker.prototype._checkShaderType):
+        (Checker.prototype._checkOperatorOverload):
+        (Checker.prototype.visitFuncDef):
+        (Checker.prototype.visitEnumType):
+        (Checker.prototype.visitArrayType):
+        (Checker.prototype.visitMakePtrExpression):
+        (Checker.prototype.visitMakeArrayRefExpression):
+        (Checker.prototype._finishVisitingPropertyAccess):
+        (Checker.prototype.visitIndexExpression):
+        (Checker.prototype.visitReturn):
+        (Checker.prototype.visitSwitchStatement):
+        (Checker.prototype.visitTernaryExpression):
+        (Checker.prototype.visitCallExpression):
+        * WebGPUShadingLanguageRI/Field.js:
+        (Field):
+        (Field.prototype.get semantic):
+        (Field.prototype.toString):
+        * WebGPUShadingLanguageRI/Func.js:
+        (Func):
+        (Func.prototype.get semantic):
+        (Func.prototype.toDeclString):
+        * WebGPUShadingLanguageRI/FuncDef.js:
+        (FuncDef):
+        * WebGPUShadingLanguageRI/FuncParameter.js:
+        (FuncParameter):
+        (FuncParameter.prototype.get semantic):
+        (FuncParameter.prototype.toString):
+        * WebGPUShadingLanguageRI/Intrinsics.js:
+        * WebGPUShadingLanguageRI/LateChecker.js:
+        (LateChecker.prototype.visitReferenceType):
+        (LateChecker):
+        (LateChecker.prototype._checkShaderType): Deleted.
+        (LateChecker.prototype.visitFuncDef): Deleted.
+        * WebGPUShadingLanguageRI/NativeFunc.js:
+        (NativeFunc):
+        * WebGPUShadingLanguageRI/Parse.js:
+        (parseParameter):
+        (parseFuncDecl):
+        (parseFuncDef):
+        (parseStageInOutSemantic):
+        (parseResourceSemantic):
+        (parseSpecializationConstantSemantic):
+        (parseBuiltInSemantic):
+        (parseField):
+        (parseNativeFunc):
+        * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js:
+        (programWithUnnecessaryThingsRemoved):
+        * WebGPUShadingLanguageRI/ResourceSemantic.js: Added.
+        (ResourceSemantic):
+        (ResourceSemantic.prototype.get resourceMode):
+        (ResourceSemantic.prototype.get index):
+        (ResourceSemantic.prototype.get space):
+        (ResourceSemantic.prototype.isAcceptableType):
+        (ResourceSemantic.prototype.isAcceptableForShaderType):
+        (ResourceSemantic.prototype.toString):
+        * WebGPUShadingLanguageRI/Rewriter.js:
+        (Rewriter.prototype.visitFuncParameter):
+        (Rewriter.prototype.visitField):
+        (Rewriter.prototype.visitBuiltInSemantic):
+        (Rewriter.prototype.visitResourceSemantic):
+        (Rewriter.prototype.visitStageInOutSemantic):
+        (Rewriter.prototype.visitSpecializationConstantSemantic):
+        (Rewriter):
+        * WebGPUShadingLanguageRI/SPIRV.html:
+        * WebGPUShadingLanguageRI/Semantic.js: Added.
+        (Semantic):
+        (Semantic.prototype.get origin):
+        (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitBuiltInSemantic):
+        (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitResourceSemantic):
+        (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitStageInOutSemantic):
+        (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitSpecializationConstantSemantic):
+        (Semantic.prototype.equalToOtherSemantic.Comparer):
+        (Semantic.prototype.equalToOtherSemantic):
+        * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Copied from Tools/WebGPUShadingLanguageRI/Field.js.
+        (SpecializationConstantSemantic):
+        (SpecializationConstantSemantic.prototype.isAcceptableType):
+        (SpecializationConstantSemantic.prototype.isAcceptableForShaderType):
+        (SpecializationConstantSemantic.prototype.toString):
+        * WebGPUShadingLanguageRI/StageInOutSemantic.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
+        (StageInOutSemantic):
+        (StageInOutSemantic.prototype.get index):
+        (StageInOutSemantic.prototype.isAcceptableType):
+        (StageInOutSemantic.prototype.isAcceptableForShaderType):
+        (StageInOutSemantic.prototype.toString):
+        * WebGPUShadingLanguageRI/StatementCloner.js:
+        (StatementCloner.prototype.visitNativeFunc):
+        * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js:
+        (synthesizeArrayOperatorLength):
+        * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js:
+        (synthesizeCopyConstructorOperator):
+        * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js:
+        (synthesizeDefaultConstructorOperator):
+        * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js:
+        (synthesizeEnumFunctions):
+        * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
+        (setupAnder):
+        (synthesizeStructAccessorsForStructType):
+        * WebGPUShadingLanguageRI/Test.html:
+        * WebGPUShadingLanguageRI/Test.js:
+        (tests.shaderTypes):
+        * WebGPUShadingLanguageRI/Visitor.js:
+        (Visitor.prototype.visitFunc):
+        (Visitor.prototype.visitFuncParameter):
+        (Visitor.prototype.visitField):
+        (Visitor.prototype.visitBuiltInSemantic):
+        (Visitor.prototype.visitResourceSemantic):
+        (Visitor.prototype.visitStageInOutSemantic):
+        (Visitor.prototype.visitSpecializationConstantSemantic):
+        (Visitor):
+        * WebGPUShadingLanguageRI/index.html:
+
+2018-09-25  Thomas Denney  <tdenney@apple.com>
+
+        [WHLSL] Test suite for Metal code generation
+        https://bugs.webkit.org/show_bug.cgi?id=187738
+
+        Reviewed by Myles C. Maxfield.
+
+        This patch adds an Xcode project that contains a Cocoa app that can be
+        used for running WHLSL shaders on the GPU. It also contains an Xcode
+        test suite that runs all of the tests in Test.js on the GPU.
+
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Added.
+        * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Added.
+        * WebGPUShadingLanguageRI/Test.js:
+        (tests.lotsOfLocalVariables):
+
+2018-09-25  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Unreviewed build fix after r236455
+        https://bugs.webkit.org/show_bug.cgi?id=189121
+
+        * WebGPUShadingLanguageRI/Test.js:
+        (tests.shaderStages):
+
+2018-09-24  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        [WHLSL] Not all functions should be able to run in all shader stages
+        https://bugs.webkit.org/show_bug.cgi?id=189121
+
+        Reviewed by Filip Pizlo.
+
+        ddx() and ddy() can only run in fragment shaders, and the barrier functions can only run in compute shaders.
+        ddx_coarse() & friends are currently implemented as just calling ddx(), so we only need to modify those functions
+        if/when we make them native.
+
+        The texture sampling functions that use implicit derivatives can run in any shader stage - they just use a LOD of
+        0. Therefore, those functions are unchanged.
+
+        * WebGPUShadingLanguageRI/All.js:
+        * WebGPUShadingLanguageRI/Intrinsics.js:
+        * WebGPUShadingLanguageRI/LateChecker.js:
+        (LateChecker.prototype._checkShaderType):
+        * WebGPUShadingLanguageRI/NativeFunc.js:
+        (NativeFunc):
+        (NativeFunc.prototype.get stage):
+        (NativeFunc.prototype.toDeclString):
+        * WebGPUShadingLanguageRI/Parse.js:
+        (parseFuncDecl):
+        (parseNativeFunc):
+        (parseNative):
+        * WebGPUShadingLanguageRI/Prepare.js:
+        (let.prepare):
+        * WebGPUShadingLanguageRI/SPIRV.html:
+        * WebGPUShadingLanguageRI/StandardLibrary.js:
+        (let.standardLibrary):
+        * WebGPUShadingLanguageRI/StatementCloner.js:
+        (StatementCloner.prototype.visitNativeFunc):
+        * WebGPUShadingLanguageRI/Test.html:
+        * WebGPUShadingLanguageRI/Test.js:
+        (tests.shaderStages):
+        * WebGPUShadingLanguageRI/WSyntaxError.js:
+        (WSyntaxError.prototype.toString):
+        (WSyntaxError):
+        * WebGPUShadingLanguageRI/index.html:
+
+2018-09-24  Thomas Denney  <tdenney@apple.com>
+
+        [WHLSL] Implement trap statements in Metal code generation
+        https://bugs.webkit.org/show_bug.cgi?id=189615
+
+        Reviewed by Myles C. Maxfield.
+
+        Each function called by an entry point now receives an additional
+        boolean pointer parameter, which is set to false if the function traps.
+        After each function call (to a non-native function) this trap parameter
+        is checked. The behavior of the interpreter has also been updated so
+        that a function entry point catches the trap and instead returns zero,
+        matching the behavior of compiled code.
+
+        * WebGPUShadingLanguageRI/Evaluator.js: Adds a new flag to allow the
+        test suite to check for traps and also returns zero from entry points
+        whose invocation trapped.
+        * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Pass program to function
+        declarations.
+        * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Update dependencies.
+        * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Add program
+        property.
+        * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Ditto.
+        * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Added.
+        * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Conforms to the
+        new trapping behavior.
+        * WebGPUShadingLanguageRI/Test.js: Update tests that trap.
+
+2018-09-24  Thomas Denney  <tdenney@apple.com>
+
+        [WHLSL] It shouldn’t be possible to use ternary expressions as l-values
+        https://bugs.webkit.org/show_bug.cgi?id=189290
+
+        Reviewed by Myles C. Maxfield.
+
+        It is no longer possible for a ternary expression to be treated as an
+        l-value. This patch adds several test cases to verify that this is the
+        case.
+
+        * WebGPUShadingLanguageRI/Checker.js:
+        (Checker.prototype.visitTernaryExpression): No longer check isLValue.
+        * WebGPUShadingLanguageRI/NormalUsePropertyResolver:
+        (NormalUsePropertyResolver.visitTernaryExpression): Deleted.
+        * WebGPUShadingLanguageRI/Rewriter.js:
+        (Rewriter.prototype.visitTernaryExpression): No longer copy isLValue.
+        * WebGPUShadingLanguageRI/TernaryExpression.js:
+        (TernaryExpression):
+        (TernaryExpression.prototype.get elseExpression):
+        (TernaryExpression.prototype.get isLValue): Deleted.
+        (TernaryExpression.prototype.set isLValue): Deleted.
+        * WebGPUShadingLanguageRI/Test.js:
+        (tests.ternaryExpression): Add checks for failure if a failure is used
+        as an l-value.
+        (ternaryExpressionIsLValue.node.TernaryExpressionVisitor.prototype.visitTernaryExpression): Deleted.
+        (ternaryExpressionIsLValue.node.TernaryExpressionVisitor): Deleted.
+        (tests.ternaryExpressionIsLValue): Deleted.
+
+2018-09-24  Jer Noble  <jer.noble@apple.com>
+
+        SharedBuffer should have an equality test
+        https://bugs.webkit.org/show_bug.cgi?id=189919
+
+        Reviewed by Alex Christensen.
+
+        * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
+        (TestWebKitAPI::TEST_F):
+
+2018-09-24  Alex Christensen  <achristensen@webkit.org>
+
+        Prepare to replace WKBundleFileHandleCreateWithPath with a version that takes a WKBundlePageRef
+        https://bugs.webkit.org/show_bug.cgi?id=189929
+
+        Reviewed by Andy Estes.
+
+        * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp:
+
+2018-09-24  Thomas Denney  <tdenney@apple.com>
+
+        [WHLSL] Casting user-created types to themselves should always work
+        https://bugs.webkit.org/show_bug.cgi?id=189113
+
+        Reviewed by Myles C. Maxfield.
+
+        Casting user-defined types to themselves worked already, but we didn't
+        test it anywhere.
+
+        * WebGPUShadingLanguageRI/Test.js:
+        (tests.selfCasts):
+
+2018-09-24  Zan Dobersek  <zdobersek@igalia.com>
+
+        Unreviewed build fix for Jhbuild-using ports.
+
+        * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch:
+        Adjust the patch so it applies cleanly on the 1.14.3 version of the
+        gst-plugins-good package.
+
+2018-09-24  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Update flakiness dashboard configuration for iOS 12 queues
+        https://bugs.webkit.org/show_bug.cgi?id=189688
+
+        Reviewed by Alexey Proskuryakov.
+
+        * TestResultServer/static-dashboards/builders.jsonp:
+
+2018-09-24  Alicia Boya García  <aboya@igalia.com>
+
+        [GStreamer] Unreviewed build fix.
+
+        A GStreamer patch was not applying cleanly on 1.14.3.
+
+        * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch:
+
+2018-09-24  Alicia Boya García  <aboya@igalia.com>
+
+        [MSE][GStreamer] Use no-more-pads event for noticing initialization segments
+        https://bugs.webkit.org/show_bug.cgi?id=189868
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Added patch from https://bugzilla.gnome.org/show_bug.cgi?id=797187
+
+        * gstreamer/jhbuild.modules:
+        * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Added.
+
+2018-09-24  Alicia Boya García  <aboya@igalia.com>
+        [MSE][GStreamer] Add patch to jhbuild: matroskademux: Allow Matroska headers to be read more than once
+        https://bugs.webkit.org/show_bug.cgi?id=185731
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Upstream bug in GStreamer: https://bugzilla.gnome.org/show_bug.cgi?id=793333
+
+        This fixes YTTV 35. AppendMultipleInitOpusAudio (and any other use
+        case where two WebM initialization segments are appended on a row).
+
+        * gstreamer/jhbuild.modules:
+        * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Added.
+        * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Added.
+        * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Added.
+
+2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        [WHSL] Need grammar to specify kernel group size
+        https://bugs.webkit.org/show_bug.cgi?id=189108
+
+        Reviewed by Dean Jackson.
+
+        In HLSL, compute functions are annotated with their workgroup size.
+        For example,
+
+        [numthreads(3, 4, 5)] compute void foo(...) { ... }
+
+        * WebGPUShadingLanguageRI/All.js:
+        * WebGPUShadingLanguageRI/Func.js:
+        (Func):
+        (Func.prototype.get attributeBlock):
+        * WebGPUShadingLanguageRI/FuncAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
+        (FuncAttribute):
+        * WebGPUShadingLanguageRI/FuncDef.js:
+        (FuncDef):
+        * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
+        (FuncNumThreadsAttribute):
+        (FuncNumThreadsAttribute.prototype.get x):
+        (FuncNumThreadsAttribute.prototype.get y):
+        (FuncNumThreadsAttribute.prototype.get z):
+        * WebGPUShadingLanguageRI/LateChecker.js:
+        (LateChecker.prototype._checkShaderType):
+        * WebGPUShadingLanguageRI/Parse.js:
+        (parseAttributeBlock):
+        (parseFuncDecl):
+        (parseFuncDef):
+        (parseNativeFunc):
+        * WebGPUShadingLanguageRI/SPIRV.html:
+        * WebGPUShadingLanguageRI/StatementCloner.js:
+        (StatementCloner.prototype.visitFuncDef):
+        (StatementCloner.prototype.visitFuncNumThreadsAttribute):
+        (StatementCloner):
+        * WebGPUShadingLanguageRI/Test.html:
+        * WebGPUShadingLanguageRI/Test.js:
+        (tests.numThreads):
+        * WebGPUShadingLanguageRI/Visitor.js:
+        (Visitor.prototype.visitFunc):
+        (Visitor.prototype.visitFuncNumThreadsAttribute):
+        (Visitor):
+        * WebGPUShadingLanguageRI/index.html:
+
+2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Native functions which accept pointers need to do null checks
+        https://bugs.webkit.org/show_bug.cgi?id=189883
+
+        Reviewed by Dean Jackson.
+
+        Simply guard all the places where we write through an author-provided pointer.
+
+        * WebGPUShadingLanguageRI/Intrinsics.js:
+        (Intrinsics.):
+        * WebGPUShadingLanguageRI/Test.js:
+        (tests.textureDimensionsNull):
+
+2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        [WHLSL] Implement atomic operations and barriers
+        https://bugs.webkit.org/show_bug.cgi?id=189025
+
+        Reviewed by Dean Jackson.
+
+        In the interpreter, atomic operations don't need to be atomic.
+
+        * WebGPUShadingLanguageRI/Intrinsics.js:
+        (Intrinsics.):
+        * WebGPUShadingLanguageRI/StandardLibrary.js:
+        (let.standardLibrary):
+        * WebGPUShadingLanguageRI/Test.js:
+        (tests.atomics):
+
+2018-09-22  Thibault Saunier  <tsaunier@igalia.com>
+
+        [WPE] Be very permissive in the MiniBrowser.
+        https://bugs.webkit.org/show_bug.cgi?id=189800
+
+        This is just a test tool and we should make
+        it just work, security and privacy is not really
+        a primary focus here.
+
+        Reviewed by Žan Doberšek.
+
+        * MiniBrowser/wpe/main.cpp:
+        (decidePermissionRequest):
+        (main):
+
+2018-09-21  Thomas Denney  <tdenney@apple.com>
+
+        [WHLSL] Local variables should be statically allocated
+        https://bugs.webkit.org/show_bug.cgi?id=188402
+
+        Reviewed by Myles C. Maxfield.
+
+        An additional preparation stage is now performed so that all local
+        variables and function parameters are allocated in a single struct at
+        entry points. A pointer to this struct is then passed for function
+        calls.
+
+        * WebGPUShadingLanguageRI/All.js: Update dependencies.
+        * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Added new stage.
+        * WebGPUShadingLanguageRI/CallExpression.js:
+        (CallExpression.prototype.set argumentList): Add setter because
+        allocateAtEntryPoints needs to change this.
+        * WebGPUShadingLanguageRI/EBufferBuilder.js: Remove a redundant
+        constructor that wasn't used anywhere.
+        * WebGPUShadingLanguageRI/Func.js:
+        (Func.prototype.set parameters): Add setter.
+        * WebGPUShadingLanguageRI/FuncDef.js:
+        (FuncDef.prototype.set body): Ditto.
+        * WebGPUShadingLanguageRI/Prepare.js:
+        (let.prepare): Add call to allocateAtEntryPoints. This call cannot
+        happen any earlier because it depends on having types for call
+        arguments.
+        * WebGPUShadingLanguageRI/Rewriter.js:
+        (Rewriter.prototype.visitReturn): Resolve issue where the return
+        statement's function wasn't copied. A null check is required as the
+        Rewriter might be used before this property is set.
+        * WebGPUShadingLanguageRI/SPIRV.html: Update dependencies.
+        * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Abstracted logic
+        into a separate function so that allocateAtEntryPoints can create the
+        accessors for the struct type it introduces.
+        * WebGPUShadingLanguageRI/Test.html: Update dependencies.
+        * WebGPUShadingLanguageRI/Test.js: Add new tests to verify the static
+        allocation transform works safely.
+        * WebGPUShadingLanguageRI/index.html: Update dependencies.
+
+2018-09-21  Jonathan Bedard  <jbedard@apple.com>
+
+        Bring up queues for iOS 12 (Build fix)
+        https://bugs.webkit.org/show_bug.cgi?id=189683
+
+        Unreviewed build fix.
+
+        We should not build ImageDiff as x86 by default since 32 bit projects are
+        deprecated in Xcode. ImageDiff should only be built once.
+
+        * Scripts/build-webkit:
+        * Scripts/webkitdirs.pm:
+        (argumentsForConfiguration):
+
+2018-09-21  Adrian Perez de Castro  <aperez@igalia.com>
+
+        [WPE] Built RPM of WPE webkit fails to install with "nothing provides libWPEToolingBackends.so()"
+        https://bugs.webkit.org/show_bug.cgi?id=189797
+
+        Reviewed by Žan Doberšek.
+
+        * wpe/backends/CMakeLists.txt: Make libWPEToolingBackends a static library to avoid
+        the need for installing it. This works fine because the library only contains utility
+        code intended to be reused from other various components (MiniBrowser, WebKitTestRunner).
+
+2018-09-20  Daniel Bates  <dabates@apple.com>
+
+        Move IOKitSPI.h from TestRunnerShared to PAL
+        https://bugs.webkit.org/show_bug.cgi?id=189804
+
+        Reviewed by Wenson Hsieh.
+
+        Towards fixing <https://bugs.webkit.org/show_bug.cgi?id=189604> move the IOKit SPI forward
+        declarations to PAL so that they can be shared by WebKit, DumpRenderTree and WebKitTestRunner.
+
+        No functionality changed. So, no new tests.
+
+        * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
+        * TestRunnerShared/spi/UIKitTestSPI.h:
+        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
+        * WebKitTestRunner/ios/HIDEventGenerator.mm:
+
+2018-09-20  Thomas Denney  <tdenney@apple.com>
+
+        [WHLSL] Metal code generation
+        https://bugs.webkit.org/show_bug.cgi?id=187735
+
+        Reviewed by Myles C. Maxfield.
+
+        Adds support for generating Metal Shading Language from WHLSL. Clients
+        should include the file MetalCodegenAll.js and then call whlslToMsl
+        with their program source code to compile to Metal.
+
+        * WebGPUShadingLanguageRI/ArrayType.js:
+        (ArrayType.prototype.get arrayRefType): Adds the arrayRefType method to
+        all types to find the type of that expression when it is used in a
+        MakeArrayRefExpression.
+        * WebGPUShadingLanguageRI/MakeArrayRefExpression.js:
+        (MakeArrayRefExpression):
+        (MakeArrayRefExpression.prototype.get type): Uses the new arrayRefType
+        getter on all types to find the type of the expression.
+        * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Added.
+        * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Added.
+        * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Added.
+        * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Added.
+        * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Added.
+        * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Added.
+        * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Added.
+        * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Added.
+        * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Added.
+        * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Added.
+        * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Added.
+        * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Added.
+        * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Added.
+        * WebGPUShadingLanguageRI/Metal/TypeOf.js: Added.
+        * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Added.
+        * WebGPUShadingLanguageRI/PropertyResolver.js:
+        * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
+        * WebGPUShadingLanguageRI/Test.js: Added awkward tests for the compiler
+        to generate code for.
+        (tests.incrementAndDecrement):
+        (tests.returnIntLiteralUint):
+        (tests.returnIntLiteralFloat):
+        (tests.nestedSubscriptWithArraysInStructs):
+        (tests.nestedSubscript):
+        (tests.lotsOfLocalVariables):
+        * WebGPUShadingLanguageRI/Type.js:
+        (Type.prototype.get arrayRefType): See above.
+
+2018-09-20  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Bring up queues for iOS 12
+        https://bugs.webkit.org/show_bug.cgi?id=189683
+
+        Unreviewed infrastructure fix.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/iOS12@2x.png.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
+        (BubbleQueueServer): Move EWS bubbles to the iOS 12 section of the dashboard.
+
+2018-09-20  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Bring up queues for iOS 12
+        https://bugs.webkit.org/show_bug.cgi?id=189683
+
+        Reviewed by Aakash Jain.
+
+        * BuildSlaveSupport/build.webkit.org-config/config.json:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png: Added.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png: Added.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png: Added.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/iOS12@2x.png: Added.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
+        (WebKitBuildbot):
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
+        (table.queue-grid tr.platform.ios-simulator-12 img.logo):
+        (table.queue-grid tr.platform.ios-12 img.logo):
+        (table.queue-grid tr.platform.ios-simulator-11 img.logo): Deleted.
+        (table.queue-grid tr.platform.ios-11 img.logo): Deleted.
+        * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
+        * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
+        (_should_file_trigger_build):
+        * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
+        (ShouldBuildTest):
+        (ShouldBuildTest.test_should_build):
+
+2018-09-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
+
+        [Win] TestRunner::queueLoad() fails to generate correct url for some urls.
+        https://bugs.webkit.org/show_bug.cgi?id=189679
+
+        Reviewed by Fujii Hironori.
+
+        Replace the implementation with correct API call.
+
+        * DumpRenderTree/win/TestRunnerWin.cpp:
+        (TestRunner::queueLoad): Call UrlCombineW.
+
+2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [WPE] fails to build on ARM arches complaining about undefined reference to `epoxy_eglMakeCurrent'
+        https://bugs.webkit.org/show_bug.cgi?id=189556
+
+        Reviewed by Konstantin Tokarev.
+
+        This is only a speculative build fix as I didn't attempt to reproduce. Explicitly link to
+        libepoxy.
+
+        * wpe/backends/CMakeLists.txt:
+
+2018-09-20  Daniel Bates  <dabates@apple.com>
+
+        [iOS] Support testing more hardware special keys
+        https://bugs.webkit.org/show_bug.cgi?id=189793
+
+        Reviewed by Simon Fraser.
+
+        * TestRunnerShared/spi/IOKitSPI.h: Add more SPI constants.
+        * WebKitTestRunner/ios/HIDEventGenerator.mm:
+        (keyCodeForDOMFunctionKey): Extracted out logic from hidUsageCodeForCharacter() to return the
+        key code for the F1, F2, ..., F12 keys and extended the code to compute the key code for the
+        F13, F14, ..., F24 keys.
+        (hidUsageCodeForCharacter): Modified to call keyCodeForDOMFunctionKey().
+
+2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Unreviewed, remove accidentally-committed debugging changes from flatpakutils script
+
+        Aaaaaah maybe this is why changes are supposed to be reviewed.
+
+        * flatpak/flatpakutils.py:
+        (WebkitFlatpak.clean_args):
+
+2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Unreviewed, manually rollout our switch to master runtime
+
+        Phil wants html5-codecs, which aren't available yet here. Let's switch back to 3.28 in the
+        meantime, where we were already building GStreamer ourselves anyway. But use an updated
+        SDK revision.
+
+        * flatpak/files/httpd-autogen.sh: Added.
+        * flatpak/flatpakutils.py:
+        (WebkitFlatpak.clean_args):
+        * flatpak/org.webkit.GTK.yaml:
+        * flatpak/org.webkit.WebKit.yaml:
+        * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
+        * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Added.
+
+2018-09-20  Thibault Saunier  <tsaunier@igalia.com>
+
+        [WPE][GTK] webkit-flatpak intercepts --help for other commands
+        https://bugs.webkit.org/show_bug.cgi?id=189058
+
+        The approach of run_in_sandbox_if_available is that we basically have the
+        same set of arguments to setup the sandbox (ie. port name, build type, etc...)
+        and we can pass those args first to setup the flatpak launcher object
+        and then to the underlying script. That doesn't work well with the `--help` argument
+        as once processed it 1. prints the help (which make no sense to the user of the calling script)
+        2. exits the app - The solution is to just make sure that `--help` is not used when using
+        flatpakutils from any script that is not `webkit-flatpak` itself.
+
+        Reviewed by Michael Catanzaro.
+
+        * flatpak/flatpakutils.py:
+        (WebkitFlatpak.load_from_args):
+        (run_in_sandbox_if_available):
+
+2018-09-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        Unreviewed. Add W3C imported tests to the MSEEME watchlist.
+
+        * Scripts/webkitpy/common/config/watchlist:
+
+2018-09-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        Unreviewed. Fix the Streams API watchlist.
+
+        * Scripts/webkitpy/common/config/watchlist:
+
+2018-09-19  Chris Dumez  <cdumez@apple.com>
+
+        Crash under WebProcessProxy::suspendedPageWasDestroyed(WebKit::SuspendedPageProxy&)
+        https://bugs.webkit.org/show_bug.cgi?id=189721
+        <rdar://problem/44359788>
+
+        Reviewed by Geoffrey Garen.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2018-09-19  Thomas Denney  <tdenney@apple.com>
+
+        [WHLSL] Improve test suite type safety
+        https://bugs.webkit.org/show_bug.cgi?id=189502
+
+        Reviewed by Myles C. Maxfield.
+
+        Each of the 'makeT' functions now call the relevant cast function on the
+        value before hand. The checkNumber function has also been removed and
+        its uses have been replaced with functions that also check the type.
+        Some of the arithmetic checks have been updated to reflect that the
+        casts happen outside of WHLSL evaluation. Other tests have also been
+        updated to reflect that some values cannot be precisely expressed in
+        32-bit floating point.
+
+        * WebGPUShadingLanguageRI/Casts.js:
+        (castToBool): Added.
+        (castAndCheckValue): Added.
+        (isBitwiseEquivalent): Moved from Intrinsics.js.
+        * WebGPUShadingLanguageRI/Intrinsics.js: Ditto.
+        * WebGPUShadingLanguageRI/SPIRV.html: Update depdencies.
+        * WebGPUShadingLanguageRI/Test.html: Ditto.
+        * WebGPUShadingLanguageRI/Test.js: Update makeT functions to do a cast
+        and check the result. Some tests were also updated to reflect the change
+        in the behavior of these functions.
+        * WebGPUShadingLanguageRI/index.html: Update dependencies.
+
+2018-09-19  John Wilander  <wilander@apple.com>
+
+        Resource Load Statistics: Add optional cap on partitioned cache max age
+        https://bugs.webkit.org/show_bug.cgi?id=189711
+        <rdar://problem/39246837>
+
+        Reviewed by Antti Koivisto and Chris Dumez.
+
+        This change adds infrastructure for layout tests of capped cache max age.
+
+        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
+        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+        (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
+        * WebKitTestRunner/InjectedBundle/TestRunner.h:
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::setStatisticsCacheMaxAgeCap):
+        * WebKitTestRunner/TestController.h:
+        * WebKitTestRunner/TestInvocation.cpp:
+        (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
+
+2018-09-19  Dawei Fenton  <realdawei@apple.com>
+
+       Unreviewed. Update my email and alias in list of contributors.
+
+        * Scripts/webkitpy/common/config/contributors.json:
+
+2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [WPE][GTK] Unreviewed, try #3 to fix a typo
+
+        I feel like Charlie Brown, how hard this has been for me....
+
+        * Scripts/run-minibrowser:
+        * Scripts/webkitdirs.pm:
+        (runInFlatpakIfAvailable):
+        (runInFlatpakIfAvailible): Deleted.
+
+2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [WPE][GTK] Unreviewed, fix that typo in more places
+
+        It got copied into webkitdirs.pm!
+
+        * Scripts/webkitdirs.pm:
+        (runInFlatpakIfAvailible):
+        (runInFlatpakIfAvalaible): Deleted.
+
+2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [WPE][GTK] Unreviewed, fix a pervasive typo in the webkit-flatpak script
+
+        * flatpak/flatpakutils.py:
+        (WebkitFlatpak.load_from_args):
+        (WebkitFlatpak.__init__):
+        (WebkitFlatpak.run):
+
+2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [WPE][GTK] Unreviewed, update to latest GNOME SDK
+
+        * flatpak/org.webkit.WebKit.yaml:
+
+2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Unreviewed, rolling out r235500.
+
+        Time to switch back to master runtime
+
+        Reverted changeset:
+
+        "Unreviewed, rolling out r235114."
+        https://bugs.webkit.org/show_bug.cgi?id=188731
+        https://trac.webkit.org/changeset/235500
+
+2018-09-19  Adrian Perez de Castro  <aperez@igalia.com>
+
+        Unreviewed. Add Pablo Saavedra to the list of contributors.
+
+        * Scripts/webkitpy/common/config/contributors.json:
+
+2018-09-19  Philippe Normand  <pnormand@igalia.com>
+
+        [GStreamer] Add support for AV1 decoding
+        https://bugs.webkit.org/show_bug.cgi?id=189647
+
+        Reviewed by Žan Doberšek.
+
+        Add patches required for AV1 decoding support. They're all
+        upstream already and will be shipped in GStreamer 1.16. The aom
+        GStreamer plugin depends on the aom library for which there's no
+        official release yet.
+
+        * gstreamer/jhbuild.modules:
+        * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Added.
+        * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Added.
+        * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Added. This one is unrelated but an implicit dependency of the next one.
+        * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Added.
+        * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Added.
+        * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Added.
+
+2018-09-18  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy: Clobbering and building occurs multiple times for iOS Simulator ports
+        https://bugs.webkit.org/show_bug.cgi?id=189702
+        <rdar://problem/44541704>
+
+        Reviewed by Aakash Jain.
+
+        * Scripts/webkitpy/layout_tests/controllers/manager.py:
+        (Manager._set_up_run): Move build check and clobbering to run, since set up is
+        run multiple times for iOS simulator.
+        (Manager.run):
+
+2018-09-18  Chris Dumez  <cdumez@apple.com>
+
+        "DidFirstVisuallyNonEmptyLayout" callback does not get called when restoring a page from PageCache
+        https://bugs.webkit.org/show_bug.cgi?id=189681
+        <rdar://problem/44526171>
+
+        Reviewed by Alex Christensen and Zalan Bujtas.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
+        (TestWebKitAPI::didFinishNavigation):
+        (TestWebKitAPI::TEST):
+
+2018-09-18  Claudio Saavedra  <csaavedra@igalia.com>
+
+        [WPE] Implement mouse event modifiers
+        https://bugs.webkit.org/show_bug.cgi?id=189697
+
+        Reviewed by Carlos Garcia Campos.
+
+        * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
+        (WTR::wkEventModifiersToWPE):
+        (WTR::EventSenderProxy::mouseDown):
+        (WTR::EventSenderProxy::mouseUp):
+
+2018-09-17  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [WTF] Use Semaphore and BinarySemaphore instead of dispatch_semaphore_t
+        https://bugs.webkit.org/show_bug.cgi?id=185339
+
+        Reviewed by Mark Lam.
+
+        * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
+        (TestWebKitAPI::ToUpperConverter::stopProducing):
+        (TestWebKitAPI::ToUpperConverter::stopConsuming):
+
+2018-09-17  Simon Fraser  <simon.fraser@apple.com>
+
+        Many modern media control tests leak documents in testing
+        https://bugs.webkit.org/show_bug.cgi?id=189437
+
+        Reviewed by Darin Adler.
+        
+        In order to accurately detect leaks in media controls tests which use lots of
+        SVGImages, we have to:
+        - Fire a zero-delay timer after the postTask, in order for ImagesLoader's m_derefElementTimer
+          to clear references to elements.
+        - Have releaseCriticalMemory() call CachedResourceLoader's garbageCollectDocumentResources()
+          to drop the last handle to the CachedResource for an SVGImage.
+        - Call WKBundleReleaseMemory() after the GC and timer, since we need garbageCollectDocumentResources()
+          to run again after that timer has fired.
+        
+        This should fix most of the spurious leak reports involving SVGImage documents.
+
+        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
+        (WTR::InjectedBundle::reportLiveDocuments):
+        (WTR::InjectedBundle::didReceiveMessageToPage):
+
+2018-09-17  Chris Dumez  <cdumez@apple.com>
+
+        PSON: window.open() with 'noopener' should only process-swap cross-site, not cross-origin
+        https://bugs.webkit.org/show_bug.cgi?id=189602
+        <rdar://problem/44430549>
+
+        Reviewed by Geoff Garen.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2018-09-17  Philippe Normand  <pnormand@igalia.com>
+
+        [JHBuild] Update to GStreamer 1.14.3
+        https://bugs.webkit.org/show_bug.cgi?id=189450
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        * gstreamer/jhbuild.modules: Bump GStreamer modules from 1.14.1 to 1.14.3.
+
+2018-09-17  Philippe Normand  <pnormand@igalia.com>
+
+        [JHBuild] Doesn't check sha256 sums
+        https://bugs.webkit.org/show_bug.cgi?id=189646
+
+        Reviewed by Michael Catanzaro.
+
+        * gstreamer/jhbuild.modules: Properly set the sha256: prefix on hashes.
+
+2018-09-17  Sihui Liu  <sihui_liu@apple.com>
+
+        Move IndexedDB to Network Process
+        https://bugs.webkit.org/show_bug.cgi?id=189415
+        <rdar://problem/44396973>
+
+        Reviewed by Chris Dumez.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
+        (TEST):
+        * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
+        (TEST):
+        * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
+        (TEST):
+        * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
+        (TEST):
+        * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
+        (TEST):
+
+2018-09-08  Darin Adler  <darin@apple.com>
+
+        Streamline JSRetainPtr, fix leaks of JSString and JSGlobalContext
+        https://bugs.webkit.org/show_bug.cgi?id=189455
+
+        Reviewed by Keith Miller.
+
+        There is a lot of copied and pasted code for WebKit vs. Legacy WebKit
+        testing and even for macOS vs. iOS vs. Windows platform-specific code.
+        For now, this patch just makes corresponding changes to the copied code.
+        Later we might get better results by merging more code instead of having
+        all these separate copies.
+
+        * DumpRenderTree/AccessibilityController.cpp:
+        (AccessibilityController::makeWindowObject): Use the adopt function
+        instead of the special Adopt constructor of JSRetainPtr.
+
+        * DumpRenderTree/AccessibilityTextMarker.cpp: Removed unneeded include.
+
+        * DumpRenderTree/AccessibilityUIElement.cpp: Ditto.
+        (allAttributesCallback): Don't adopt at this level; changed the
+        underlying function to return a JSRetainPtr so the adopt is right next
+        to the call to the create or copy function.
+        (attributesOfLinkedUIElementsCallback): Ditto.
+        (attributesOfDocumentLinksCallback): Ditto.
+        (attributesOfChildrenCallback): Ditto.
+        (parameterizedAttributeNamesCallback): Ditto.
+        (attributesOfColumnHeadersCallback): Ditto.
+        (attributesOfRowHeadersCallback): Ditto.
+        (attributesOfColumnsCallback): Ditto.
+        (attributesOfRowsCallback): Ditto.
+        (attributesOfVisibleCellsCallback): Ditto.
+        (attributesOfHeaderCallback): Ditto.
+        (rowIndexRangeCallback): Ditto.
+        (columnIndexRangeCallback): Ditto.
+        (rangeForLineCallback): Ditto.
+        (boundsForRangeCallback): Ditto.
+        (rangeForPositionCallback): Ditto.
+        (stringForRangeCallback): Ditto.
+        (attributedStringForRangeCallback): Ditto.
+        (uiElementCountForSearchPredicateCallback): Use the free adopt
+        function instead of the adopt member function.
+        (uiElementForSearchPredicateCallback): Ditto.
+        (selectTextWithCriteriaCallback): Don't adopt at this level.
+        (attributedStringForElementCallback): Ditto.
+        (setValueCallback): Use free adopt.
+        (stringAttributeValueCallback): Don't adopt at this level.
+        (uiElementArrayAttributeValueCallback): Ditto.
+        (uiElementAttributeValueCallback): Ditto.
+        (stringForTextMarkerRangeCallback): Ditto.
+        (attributedStringForTextMarkerRangeCallback): Ditto.
+        (attributedStringForTextMarkerRangeWithOptionsCallback): Ditto.
+        (getARIADropEffectsCallback): Ditto.
+        (getClassListCallback): Ditto.
+        (getRoleCallback): Ditto.
+        (getSubroleCallback): Ditto.
+        (getRoleDescriptionCallback): Ditto.
+        (getComputedRoleStringCallback): Ditto.
+        (getTitleCallback): Ditto.
+        (getDescriptionCallback): Ditto.
+        (getStringValueCallback): Ditto.
+        (getLanguageCallback): Ditto.
+        (getHelpTextCallback): Ditto.
+        (getOrientationCallback): Ditto.
+        (getPathDescriptionCallback): Ditto.
+        (getSelectedTextRangeCallback): Ditto.
+        (speakAsCallback): Ditto.
+        (getValueDescriptionCallback): Ditto.
+        (getAccessibilityValueCallback): Ditto.
+        (getDocumentEncodingCallback): Ditto.
+        (getDocumentURICallback): Ditto.
+        (getURLCallback): Ditto.
+        (characterAtOffsetCallback): Ditto.
+        (wordAtOffsetCallback): Ditto.
+        (lineAtOffsetCallback): Ditto.
+        (sentenceAtOffsetCallback): Ditto.
+        (stringForSelectionCallback): Ditto.
+        (getIdentifierCallback): Ditto.
+        (getTraitsCallback): Ditto.
+        (supportedActionsCallback): Ditto.
+        (mathPostscriptsDescriptionCallback): Ditto.
+        (mathPrescriptsDescriptionCallback): Ditto.
+        (AccessibilityUIElement::rangeForLine): Updated to return JSRetainPtr.
+        (AccessibilityUIElement::rangeForPosition): Ditto.
+        (AccessibilityUIElement::speakAs): Ditto.
+        (AccessibilityUIElement::pathDescription const): Ditto.
+        (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
+        (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
+        (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
+
+        * DumpRenderTree/AccessibilityUIElement.h: Use JSRetainPtr instead of
+        raw pointers for the results of the functions that create strings.
+        The old way was difficult to get right; the functions didn't even follow
+        the create/copy naming rule.
+
+        * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
+        (_platformTypeConstructor): Use the adopt function instead of the
+        JSRetainPtr adopt constructor. Also nullptr instead of 0.
+
+        * DumpRenderTree/GCController.cpp:
+        (GCController::makeWindowObject): Use adopt function instead of constructor.
+
+        * DumpRenderTree/TestRunner.cpp:
+        (pathToLocalResourceCallback): Use adopt function instead of constructor.
+        (addDisallowedURLCallback): Ditto.
+        (addURLToRedirectCallback): Ditto.
+        (clearApplicationCacheForOriginCallback): Ditto.
+        (applicationCacheDiskUsageForOriginCallback): Ditto.
+        (decodeHostNameCallback): Don't adopt at this level.
+        (encodeHostNameCallback): Ditto.
+        (execCommandCallback): Use adopt instead of JSRetainPtr::adopt.
+        (findStringCallback): Use adopt function instead of constructor.
+        (isCommandEnabledCallback): Ditto.
+        (overridePreferenceCallback): Ditto.
+        (queueLoadCallback): Ditto.
+        (queueLoadHTMLStringCallback): Ditto.
+        (queueLoadingScriptCallback): Ditto.
+        (queueNonLoadingScriptCallback): Ditto.
+        (setAuthenticationPasswordCallback): Ditto.
+        (setAuthenticationUsernameCallback): Ditto.
+        (setDomainRelaxationForbiddenForURLSchemeCallback): Ditto.
+        (setMockGeolocationPositionUnavailableErrorCallback): Ditto.
+        (setPOSIXLocaleCallback): Ditto.
+        (setPersistentUserStyleSheetLocationCallback): Ditto.
+        (setUserStyleSheetLocationCallback): Ditto.
+        (setValueForUserCallback): Ditto.
+        (setWillSendRequestClearHeaderCallback): Ditto.
+        (setPageVisibilityCallback): Ditto.
+        (evaluateInWebInspectorCallback): Ditto.
+        (evaluateScriptInIsolatedWorldCallback): Ditto.
+        (evaluateScriptInIsolatedWorldAndReturnValueCallback): Ditto.
+        (addOriginAccessWhitelistEntryCallback): Ditto.
+        (removeOriginAccessWhitelistEntryCallback): Ditto.
+        (setScrollbarPolicyCallback): Ditto.
+        (addUserScriptCallback): Ditto.
+        (addUserStyleSheetCallback): Ditto.
+        (apiTestNewWindowDataLoadBaseURLCallback): Ditto.
+        (authenticateSessionCallback): Ditto.
+        (getTitleTextDirectionCallback): Ditto.
+        (getInspectorTestStubURLCallback): Ditto.
+        (simulateLegacyWebNotificationClickCallback): Ditto.
+        (setTextDirectionCallback): Ditto.
+        (grantWebNotificationPermissionCallback): Ditto.
+        (denyWebNotificationPermissionCallback): Ditto.
+        (accummulateLogsForChannel): Ditto.
+        (runUIScriptCallback): Ditto.
+        (TestRunner::makeWindowObject): Ditto.
+        (TestRunner::uiScriptDidComplete): Ditto.
+        (TestRunner::setOpenPanelFiles): Ditto.
+
+        * DumpRenderTree/TestRunner.h: Use JSRetainPtr instead of
+        raw pointers for the results of the functions that create strings.
+
+        * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
+        (AccessibilityController::platformName const): Use the adopt
+        function instead of the adopt constructor.
+
+        * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
+        (createEmptyJSString): Added. This helper function makes reduces the
+        repetitive code to create empty strings.
+        (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
+        (AccessibilityUIElement::identifier): Ditto.
+        (AccessibilityUIElement::traits): Ditto.
+        (AccessibilityUIElement::url): Ditto.
+        (AccessibilityUIElement::speakAs): Ditto.
+        (AccessibilityUIElement::stringForSelection): Ditto.
+        (AccessibilityUIElement::stringForRange): Ditto.
+        (AccessibilityUIElement::attributedStringForRange): Ditto.
+        (AccessibilityUIElement::attributedStringForElement): Ditto.
+        (AccessibilityUIElement::pathDescription const): Ditto.
+        (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
+        (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
+        (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
+        (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
+        (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
+        (AccessibilityUIElement::attributesOfChildren): Ditto.
+        (AccessibilityUIElement::allAttributes): Ditto.
+        (AccessibilityUIElement::stringAttributeValue): Ditto.
+        (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
+        (AccessibilityUIElement::role): Ditto.
+        (AccessibilityUIElement::subrole): Ditto.
+        (AccessibilityUIElement::roleDescription): Ditto.
+        (AccessibilityUIElement::computedRoleString): Ditto.
+        (AccessibilityUIElement::title): Ditto.
+        (AccessibilityUIElement::description): Ditto.
+        (AccessibilityUIElement::orientation const): Ditto.
+        (AccessibilityUIElement::stringValue): Ditto.
+        (AccessibilityUIElement::language): Ditto.
+        (AccessibilityUIElement::helpText const): Ditto.
+        (AccessibilityUIElement::valueDescription): Ditto.
+        (AccessibilityUIElement::ariaDropEffects const): Ditto.
+        (AccessibilityUIElement::boundsForRange): Ditto.
+        (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
+        (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
+        (AccessibilityUIElement::attributesOfColumns): Ditto.
+        (AccessibilityUIElement::attributesOfRows): Ditto.
+        (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
+        (AccessibilityUIElement::attributesOfHeader): Ditto.
+        (AccessibilityUIElement::rowIndexRange): Ditto.
+        (AccessibilityUIElement::columnIndexRange): Ditto.
+        (AccessibilityUIElement::selectedTextRange): Ditto.
+        (AccessibilityUIElement::accessibilityValue const): Ditto.
+        (AccessibilityUIElement::documentEncoding): Ditto.
+        (AccessibilityUIElement::documentURI): Ditto.
+        (AccessibilityUIElement::selectTextWithCriteria): Ditto.
+        (AccessibilityUIElement::classList const): Ditto.
+
+        * DumpRenderTree/mac/AccessibilityCommonMac.h: Changed the
+        createJSStringRef method to return a JSRetainPtr.
+        * DumpRenderTree/mac/AccessibilityCommonMac.mm:
+        (-[NSString createJSStringRef]): Ditto.
+        (searchPredicateParameterizedAttributeForSearchCriteria): Use the
+        adopt function instead of the adopt constructor.
+        * DumpRenderTree/mac/AccessibilityControllerMac.mm:
+        (AccessibilityController::platformName const): Ditto.
+
+        * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
+        (-[NSString createJSStringRef]): Return a JSRetainPtr.
+        (makeValueRefForValue): Updated for the above, no adopt needed here now.
+        (makeObjectRefForDictionary): Ditto.
+        (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
+
+        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
+        (createEmptyJSString): Added. This helper function makes reduces the
+        repetitive code to create empty strings.
+        (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
+        (descriptionOfElements): Ditto.
+        (selectTextParameterizedAttributeForCriteria): Ditto.
+        (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
+        (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
+        (AccessibilityUIElement::attributesOfChildren): Ditto.
+        (AccessibilityUIElement::allAttributes): Ditto.
+        (AccessibilityUIElement::stringAttributeValue): Ditto.
+        (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
+        (AccessibilityUIElement::role): Ditto.
+        (AccessibilityUIElement::subrole): Ditto.
+        (AccessibilityUIElement::roleDescription): Ditto.
+        (AccessibilityUIElement::computedRoleString): Ditto.
+        (AccessibilityUIElement::title): Ditto.
+        (AccessibilityUIElement::description): Ditto.
+        (AccessibilityUIElement::orientation const): Ditto.
+        (AccessibilityUIElement::stringValue): Ditto.
+        (AccessibilityUIElement::language): Ditto.
+        (AccessibilityUIElement::helpText const): Ditto.
+        (AccessibilityUIElement::valueDescription): Ditto.
+        (AccessibilityUIElement::speakAs): Ditto.
+        (AccessibilityUIElement::classList const): Ditto.
+        (AccessibilityUIElement::ariaDropEffects const): Ditto.
+        (AccessibilityUIElement::rangeForLine): Ditto.
+        (AccessibilityUIElement::rangeForPosition): Ditto.
+        (AccessibilityUIElement::boundsForRange): Ditto.
+        (AccessibilityUIElement::stringForRange): Ditto.
+        (AccessibilityUIElement::attributedStringForRange): Ditto.
+        (AccessibilityUIElement::selectTextWithCriteria): Ditto.
+        (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
+        (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
+        (AccessibilityUIElement::attributesOfColumns): Ditto.
+        (AccessibilityUIElement::attributesOfRows): Ditto.
+        (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
+        (AccessibilityUIElement::attributesOfHeader): Ditto.
+        (AccessibilityUIElement::rowIndexRange): Ditto.
+        (AccessibilityUIElement::columnIndexRange): Ditto.
+        (AccessibilityUIElement::pathDescription const): Ditto.
+        (AccessibilityUIElement::selectedTextRange): Ditto.
+        (AccessibilityUIElement::accessibilityValue const): Ditto.
+        (AccessibilityUIElement::documentEncoding): Ditto.
+        (AccessibilityUIElement::documentURI): Ditto.
+        (AccessibilityUIElement::url): Ditto.
+        (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
+        (createJSStringRef): Ditto.
+        (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
+        (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
+        (AccessibilityUIElement::supportedActions): Ditto.
+        (AccessibilityUIElement::mathPostscriptsDescription const): Ditto.
+        (AccessibilityUIElement::mathPrescriptsDescription const): Ditto.
+
+        * DumpRenderTree/mac/FrameLoadDelegate.mm:
+        (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
+        Use the adopt function instead of the adopt constructor.
+        * DumpRenderTree/mac/TestRunnerMac.mm:
+        (originsArrayToJS): Ditto.
+        (TestRunner::copyDecodedHostName): Return a JSRetainPtr.
+        (TestRunner::copyEncodedHostName): Ditto.
+        (TestRunner::pathToLocalResource): Ditto.
+        (TestRunner::queueLoad): Use adopt function instead of constructor.
+        (TestRunner::findString): Ditto.
+        (TestRunner::inspectorTestStubURL): Return a JSRetainPtr.
+
+        * DumpRenderTree/win/AccessibilityControllerWin.cpp:
+        (AccessibilityController::winNotificationReceived): Use adopt function
+        instead of adopt constructor.
+        (AccessibilityController::platformName const): Ditto.
+
+        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
+        (createEmptyJSString): Added. This helper function makes reduces the
+        repetitive code to create empty strings.
+        (AccessibilityUIElement::allAttributes): Changed to return a JSRetainPtr.
+        (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
+        (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
+        (AccessibilityUIElement::attributesOfChildren): Ditto.
+        (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
+        (AccessibilityUIElement::role): Ditto.
+        (AccessibilityUIElement::subrole): Ditto.
+        (AccessibilityUIElement::roleDescription): Ditto.
+        (AccessibilityUIElement::computedRoleString): Ditto.
+        (AccessibilityUIElement::title): Ditto.
+        (AccessibilityUIElement::description): Ditto.
+        (AccessibilityUIElement::stringValue): Ditto.
+        (AccessibilityUIElement::language): Ditto.
+        (AccessibilityUIElement::helpText const): Ditto.
+        (AccessibilityUIElement::valueDescription): Ditto.
+        (AccessibilityUIElement::ariaDropEffects const): Ditto.
+        (AccessibilityUIElement::orientation const): Ditto.
+        (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
+        (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
+        (AccessibilityUIElement::attributesOfColumns): Ditto.
+        (AccessibilityUIElement::attributesOfRows): Ditto.
+        (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
+        (AccessibilityUIElement::attributesOfHeader): Ditto.
+        (AccessibilityUIElement::rowIndexRange): Ditto.
+        (AccessibilityUIElement::columnIndexRange): Ditto.
+        (AccessibilityUIElement::boundsForRange): Ditto.
+        (AccessibilityUIElement::stringForRange): Ditto.
+        (AccessibilityUIElement::attributedStringForRange): Ditto.
+        (AccessibilityUIElement::selectTextWithCriteria): Ditto.
+        (AccessibilityUIElement::selectedTextRange): Ditto.
+        (AccessibilityUIElement::stringAttributeValue): Ditto.
+        (AccessibilityUIElement::accessibilityValue const): Ditto.
+        (AccessibilityUIElement::documentEncoding): Ditto.
+        (AccessibilityUIElement::documentURI): Ditto.
+        (AccessibilityUIElement::url): Ditto.
+        (AccessibilityUIElement::classList const): Ditto.
+
+        * DumpRenderTree/win/TestRunnerWin.cpp:
+        (TestRunner::copyDecodedHostName): Changed to return a JSRetainPtr.
+        (TestRunner::copyEncodedHostName): Ditto.
+        (TestRunner::pathToLocalResource): Ditto.
+        (TestRunner::queueLoad): Ditto.
+        (TestRunner::findString): Ditto.
+        (TestRunner::inspectorTestStubURL): Ditto.
+
+        * TestRunnerShared/Bindings/JSWrapper.h:
+        (WTR::setProperty): Use adopt function instead of constructor.
+        * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
+        (UIScriptContext::UIScriptContext): Ditto.
+        (UIScriptContext::runUIScript): Ditto.
+        * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
+        (WTR::toDeviceOrientation): Ditto.
+
+        * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
+        (nsTextCheckingType): Changed this function to not take an rvalue
+        reference to a JSRetainPtr since it doesn't take ownership.
+        (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Updated
+        for the above change.
+
+        * TestWebKitAPI/JavaScriptTest.cpp:
+        (TestWebKitAPI::javaScriptCallback): Use adopt function instead of
+        adopt member function.
+
+        * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp: Removed unneeded include.
+        * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm: Ditto.
+        * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Use adopt function instead of
+        adopt constructor.
+        * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm: Ditto.
+
+        * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
+        Removed unneeded includes.
+        * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Ditto.
+        * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Ditto.
+        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Ditto.
+
+        * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
+        (_platformTypeConstructor): Use the adopt function instead of the
+        JSRetainPtr adopt constructor. Also nullptr instead of 0.
+
+        * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
+        (WTR::arrayLength): Use adopt function instead of constructor.
+        (WTR::parseModifierArray): Ditto.
+        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+        (WTR::propertyValue): Ditto.
+        (WTR::dumpPath): Ditto.
+        (WTR::toJS): Ditto.
+        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+        (WTR::TestRunner::findString): Ditto.
+        (WTR::TestRunner::statisticsDidRunTelemetryCallback): Ditto.
+        (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback): Ditto.
+        (WTR::TestRunner::setOpenPanelFiles): Ditto.
+        * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
+        (WTR::AccessibilityController::platformName): Ditto.
+
+        * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
+        (-[NSString createJSStringRef]): Return a JSRetainPtr.
+        This fixes storage leaks in many functions below, which were using
+        the create function and putting the value right into a JSRetainPtr
+        without adoption.
+        (WTR::createEmptyJSString): Added. This helper function reduces the
+        repetitive code to create empty strings.
+        (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
+        (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
+        Use createEmptyJSString, fixing a storage leak due to missing adoption.
+        (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
+        (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
+        (WTR::AccessibilityUIElement::allAttributes): Ditto.
+        (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
+        (WTR::AccessibilityUIElement::parameterizedAttributeNames): Ditto.
+        (WTR::AccessibilityUIElement::role): Ditto.
+        (WTR::AccessibilityUIElement::subrole): Ditto.
+        (WTR::AccessibilityUIElement::roleDescription): Ditto.
+        (WTR::AccessibilityUIElement::computedRoleString): Ditto.
+        (WTR::AccessibilityUIElement::title): Ditto.
+        (WTR::AccessibilityUIElement::orientation const): Ditto.
+        (WTR::AccessibilityUIElement::language): Ditto.
+        (WTR::AccessibilityUIElement::valueDescription): Ditto.
+        (WTR::AccessibilityUIElement::ariaDropEffects const): Ditto.
+        (WTR::AccessibilityUIElement::boundsForRange): Ditto.
+        (WTR::AccessibilityUIElement::stringForRange): Removed unneeded null check.
+        (WTR::AccessibilityUIElement::attributedStringForRange): Ditto.
+        (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
+        Use createEmptyJSString, fixing a storage leak due to missing adoption.
+        (WTR::AccessibilityUIElement::attributesOfRowHeaders): Ditto.
+        (WTR::AccessibilityUIElement::attributesOfColumns): Ditto.
+        (WTR::AccessibilityUIElement::attributesOfRows): Ditto.
+        (WTR::AccessibilityUIElement::attributesOfVisibleCells): Ditto.
+        (WTR::AccessibilityUIElement::attributesOfHeader): Ditto.
+        (WTR::AccessibilityUIElement::selectedTextRange): Ditto.
+        (WTR::AccessibilityUIElement::accessibilityValue const): Ditto.
+        (WTR::AccessibilityUIElement::documentEncoding): Ditto.
+        (WTR::AccessibilityUIElement::documentURI): Ditto.
+        (WTR::AccessibilityUIElement::stringForSelection): Removed unneeded
+        null check.
+        (WTR::AccessibilityUIElement::stringForTextMarkerRange):
+        Use createEmptyJSString, fixing a storage leak due to missing adoption.
+
+        * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
+        Use JSRetainPtr for the return value of createJSStringRef.
+        * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
+        (-[NSString createJSStringRef]): Ditto.
+        (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Use the
+        adopt function instead of the adopt constructor.
+        * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
+        (WTR::AccessibilityController::platformName): Ditto
+
+        * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
+        (-[NSString createJSStringRef]): Return a JSRetainPtr.
+        (makeValueRefForValue): Updated for above by removing adopt.
+        (makeObjectRefForDictionary): Ditto.
+        (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
+
+        * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
+        (WTR::createEmptyJSString): Added. This helper function makes reduces the
+        repetitive code to create empty strings.
+        (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
+        (WTR::descriptionOfElements): Ditto.
+        (WTR::selectTextParameterizedAttributeForCriteria): Ditto.
+        (WTR::AccessibilityUIElement::accessibilityValue const): Use createEmptyJSString,
+        fixing a storage leak due to missing adoption.
+        (WTR::AccessibilityUIElement::documentEncoding): Ditto.
+        (WTR::AccessibilityUIElement::documentURI): Ditto.
+        (WTR::createJSStringRef): Return a JSRetainPtr.
+
+        * WebKitTestRunner/StringFunctions.h:
+        (WTR::toWK): Take a const& to eliminate a little bit of reference count churn.
+        (WTR::toJS): Use the adopt function instead of the constructor.
+
+2018-09-14  Dean Jackson  <dino@grorg.org>
+
+        Add Justin Michaud.
+
+        * Scripts/webkitpy/common/config/contributors.json:
+
+2018-09-14  Ryan Haddad  <ryanhaddad@apple.com>
+
+        bots should pass --clobber-old-results to run-webkit-tests
+        https://bugs.webkit.org/show_bug.cgi?id=189623
+
+        Reviewed by Aakash Jain.
+
+        In order to ensure that bots to not produce confusing results due to transient execptions,
+        or run out of space if they continually hit an exception, old layout test results should be clobbered.
+
+        * BuildSlaveSupport/build.webkit.org-config/steps.py:
+        (RunWebKitTests):
+
 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
 
         Unreviewed, rolling out r235954.