Reuse existing WebPageProxy quota handler for NetworkProcessProxy quota requests
[WebKit-https.git] / Tools / ChangeLog
index 43e1c93..a612a37 100644 (file)
@@ -1,3 +1,567 @@
+2019-05-15  Youenn Fablet  <youenn@apple.com>
+
+        Reuse existing WebPageProxy quota handler for NetworkProcessProxy quota requests
+        https://bugs.webkit.org/show_bug.cgi?id=197463
+        <rdar://problem/47403621>
+
+        Reviewed by Alex Christensen.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm: Added.
+        (-[QuotaDelegate init]):
+        (-[QuotaDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
+        (-[QuotaDelegate quotaDelegateCalled]):
+        (-[QuotaDelegate grantQuota]):
+        (-[StorageSchemes webView:startURLSchemeTask:]):
+        (-[StorageSchemes webView:stopURLSchemeTask:]):
+        (-[QuotaMessageHandler userContentController:didReceiveScriptMessage:]):
+        (doTest):
+
+2019-05-15  Youenn Fablet  <youenn@apple.com>
+
+        Constant crashes under WebPage::isThrottleable() after r245299
+        https://bugs.webkit.org/show_bug.cgi?id=197902
+        <rdar://problem/50793796>
+
+        Reviewed by Alex Christensen.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
+
+2019-05-15  Philippe Normand  <pnormand@igalia.com>
+
+        [GTK][jhbuild] misc cleanups and bumps
+        https://bugs.webkit.org/show_bug.cgi?id=197913
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        * gstreamer/jhbuild.modules: Bump to libva 2.4.1 and switch to Meson.
+        * gtk/jhbuild.modules: Bump to Brotli 1.0.5 and Wayland 1.16.
+
+2019-05-15  Chris Dumez  <cdumez@apple.com>
+
+        Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
+        https://bugs.webkit.org/show_bug.cgi?id=195102
+        <rdar://problem/48456786>
+
+        Reviewed by Alex Christensen.
+
+        Try to wait longer for the number of processes to reach the expected number
+        and before failing.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-05-15  Alex Christensen  <achristensen@webkit.org>
+
+        Allow NSFileCoordinator to be called from WebContent process
+        https://bugs.webkit.org/show_bug.cgi?id=197895
+        <rdar://problem/50107679>
+
+        Reviewed by Brent Fulgham.
+
+        Add a unit test that verifies calling the block succeeds.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
+        (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
+
+2019-05-14  Andy Estes  <aestes@apple.com>
+
+        [Apple Pay] Payment APIs should be completely disabled in web views into which clients have injected user scripts
+        https://bugs.webkit.org/show_bug.cgi?id=197751
+        <rdar://problem/50631563>
+
+        Reviewed by Alex Christensen.
+
+        Added new API tests.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
+        (-[TestApplePayScriptMessageHandler initWithAPIsAvailableExpectation:canMakePaymentsExpectation:]):
+        (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
+        (TestWebKitAPI::TEST):
+        (-[TestApplePayScriptMessageHandler initWithExpectation:]): Deleted.
+        * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
+
+2019-05-14  Youenn Fablet  <youenn@apple.com>
+
+        A service worker process should app nap when all its clients app nap
+        https://bugs.webkit.org/show_bug.cgi?id=185626
+        <rdar://problem/46785908>
+
+        Reviewed by Alex Christensen.
+
+        Allow to enable app nap through test header.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::resetPreferencesToConsistentValues):
+        (WTR::updateTestOptionsFromTestHeader):
+        * WebKitTestRunner/TestOptions.h:
+        (WTR::TestOptions::hasSameInitializationOptions const):
+
+2019-05-14  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r245281.
+        https://bugs.webkit.org/show_bug.cgi?id=197887
+
+        Broke API Test TestWebKitAPI.Challenge.ClientCertificate
+        (Requested by aakashjain on #webkit).
+
+        Reverted changeset:
+
+        "Add a unit test for client certificate authentication"
+        https://bugs.webkit.org/show_bug.cgi?id=197800
+        https://trac.webkit.org/changeset/245281
+
+2019-05-14  Youenn Fablet  <youenn@apple.com>
+
+        Add support for webkit-test-runner options to WPT importer
+        https://bugs.webkit.org/show_bug.cgi?id=197826
+
+        Reviewed by Alex Christensen.
+
+        In case of overwriting an existing test, check if the existing test
+        contains a <!-- webkit-test-runner --> comment and insert it back if
+        needed in the new test.
+
+        For exporter, forbid creating a WPT PR if there are changes containing
+        the webkit-test-runner string.
+
+        * Scripts/webkitpy/w3c/test_converter.py:
+        (convert_for_webkit):
+        (_W3CTestConverter.__init__):
+        (_W3CTestConverter.add_webkit_test_runner_options_if_needed):
+        (_W3CTestConverter.handle_starttag):
+        (_W3CTestConverter.handle_comment):
+        (_W3CTestConverter.handle_decl):
+        (_W3CTestConverter.handle_pi):
+        * Scripts/webkitpy/w3c/test_exporter.py:
+        (WebPlatformTestExporter.write_git_patch_file):
+        (WebPlatformTestExporter.make_pull_request):
+        * Scripts/webkitpy/w3c/test_importer.py:
+        (TestImporter.webkit_test_runner_options):
+        (TestImporter):
+        (TestImporter.add_webkit_test_runner_options_to_content):
+        (TestImporter.copy_html_file):
+        (TestImporter.write_html_template):
+        (TestImporter.write_html_files_for_templated_js_tests):
+        (TestImporter.import_tests):
+        * Scripts/webkitpy/w3c/test_importer_unittest.py:
+        (test_manual_slow_test):
+        (test_webkit_test_runner_options):
+
+2019-05-14  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Status bubble should turn orange when any build step fails
+        https://bugs.webkit.org/show_bug.cgi?id=197812
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
+        (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
+
+2019-05-14  Alex Christensen  <achristensen@webkit.org>
+
+        Add a unit test for client certificate authentication
+        https://bugs.webkit.org/show_bug.cgi?id=197800
+
+        Reviewed by Youenn Fablet.
+
+        Make better abstractions for reading and writing from/to TCPServer.
+        Add a unit test that causes a client certificate authentication challenge to happen.
+
+        * TestWebKitAPI/TCPServer.cpp:
+        (TestWebKitAPI::TCPServer::TCPServer):
+        (TestWebKitAPI::TCPServer::read):
+        (TestWebKitAPI::TCPServer::write):
+        (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
+        (TestWebKitAPI::TCPServer::respondWithOK):
+        * TestWebKitAPI/TCPServer.h:
+        * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
+        (credentialWithIdentity):
+        (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
+        (TEST):
+        (-[ClientCertificateDelegate webView:didFinishNavigation:]):
+        (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
+        (-[ClientCertificateDelegate challengeCount]):
+        (TestWebKitAPI::TEST):
+        (respondWithChallengeThenOK): Deleted.
+        (credentialWithIdentityAndKeychainPath): Deleted.
+        * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
+        (TEST):
+        * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
+        (TestWebKitAPI::TEST):
+        * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
+        (TEST):
+        (readRequest): Deleted.
+        (writeResponse): Deleted.
+        * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
+        (TestWebKitAPI::TEST):
+        (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
+
+2019-05-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        [CG] Adding support for HEIF-sequence ('public.heics') images
+        https://bugs.webkit.org/show_bug.cgi?id=197384
+
+        Reviewed by Simon Fraser.
+
+        * DumpRenderTree/TestOptions.cpp:
+        (TestOptions::TestOptions):
+        * DumpRenderTree/TestOptions.h:
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (resetWebViewToConsistentStateBeforeTesting):
+        Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
+        Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
+        the test.
+
+        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
+        (WTR::InjectedBundle::stringForKey):
+        (WTR::InjectedBundle::beginTesting):
+        * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::resetStateToConsistentValues):
+        (WTR::updateTestOptionsFromTestHeader):
+        * WebKitTestRunner/TestInvocation.cpp:
+        (WTR::TestInvocation::createTestSettingsDictionary):
+        * WebKitTestRunner/TestOptions.h:
+        (WTR::TestOptions::hasSameInitializationOptions const):
+        Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
+        Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
+        the test.
+
+2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
+        https://bugs.webkit.org/show_bug.cgi?id=197730
+
+        Reviewed by Filip Pizlo.
+
+        * TestWebKitAPI/CMakeLists.txt:
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+        * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
+        (TestWebKitAPI::TEST):
+        * TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
+        (TestWebKitAPI::TEST):
+
+2019-05-10  Chris Dumez  <cdumez@apple.com>
+
+        Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
+
+        It became flaky after r245198.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-05-10  Youenn Fablet  <youenn@apple.com>
+
+        A service worker instance should be terminated when its SWServer is destroyed
+        https://bugs.webkit.org/show_bug.cgi?id=197801
+        <rdar://problem/50587270>
+
+        Reviewed by Chris Dumez.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
+
+2019-05-10  Chris Dumez  <cdumez@apple.com>
+
+        Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
+        https://bugs.webkit.org/show_bug.cgi?id=197750
+
+        Reviewed by Geoffrey Garen.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
+        (TEST):
+
+2019-05-10  Keith Miller  <keith_miller@apple.com>
+
+        Remove legacy test262 import script
+        https://bugs.webkit.org/show_bug.cgi?id=197788
+
+        Reviewed by Yusuke Suzuki.
+
+        import-test262-tests doesn't work anymore. We should be using test262-import instead.
+
+        * Scripts/import-test262-tests: Removed.
+
+2019-05-10  Charlie Turner  <cturner@igalia.com>
+
+        [WPE] Forward libepoxy cflags
+        https://bugs.webkit.org/show_bug.cgi?id=197784
+
+        Reviewed by Žan Doberšek.
+
+        Patch by Zan Dobersek.
+
+        * wpe/backends/CMakeLists.txt: This is required to keep
+        -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
+        up trying to include X11 headers even when they're not present in the
+        environment.
+
+2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Fix a bunch of compiler warnings
+        https://bugs.webkit.org/show_bug.cgi?id=197785
+
+        Reviewed by Don Olmstead.
+
+        Add preprocessor guards to avoid -Wunused-function warnings.
+
+        * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
+        * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
+        * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
+
+2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [WPE][GTK] Add webkit_frame_get_id() API
+        https://bugs.webkit.org/show_bug.cgi?id=197270
+
+        Reviewed by Carlos Garcia Campos.
+
+        This was hard, but I added a test to verify that two different WebKitFrames of the same
+        WebKitWebPage return two different frame IDs.
+
+        * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
+        (WebKitFrameTest::willSubmitFormCallback):
+        (WebKitFrameTest::testSubframe):
+        (registerTests):
+        * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
+        (testWebKitFrameSubframe):
+        (beforeAll):
+        * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
+        (willSubmitFormCallback):
+        * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
+        * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
+
+2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
+        https://bugs.webkit.org/show_bug.cgi?id=197271
+
+        Reviewed by Youenn Fablet.
+
+        * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
+        (formControlsAssociatedForFrameCallback):
+        (pageCreatedCallback):
+        (formControlsAssociatedCallback): Deleted.
+
+2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
+
+        [Flatpak] Use the safe PyYAML loader if available
+        https://bugs.webkit.org/show_bug.cgi?id=197771
+
+        Reviewed by Philippe Normand.
+
+        * flatpak/flatpakutils.py:
+        (load_manifest): Use yaml.safe_load() if available, with yaml.load()
+        still used as fallback when the former is not provided by the module.
+
+2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
+        https://bugs.webkit.org/show_bug.cgi?id=197734
+
+        Reviewed by Don Olmstead.
+
+        * Scripts/webkitpy/port/win.py:
+        (WinCairoPort._search_paths): Add 'wk2' and
+        additional_platform_directory to paths as well as other ports do.
+
+2019-05-09  Daniel Bates  <dabates@apple.com>
+
+        [iOS] Numpad comma key has incorrect keyIdentifier property
+        https://bugs.webkit.org/show_bug.cgi?id=197753
+        <rdar://problem/50636274>
+
+        Reviewed by Brent Fulgham.
+
+        Recognize "numpadComma" and return the appropriate HID usage code.
+
+        * WebKitTestRunner/ios/HIDEventGenerator.mm:
+        (hidUsageCodeForCharacter):
+
+2019-05-09  Eric Carlson  <eric.carlson@apple.com>
+
+        Refine AudioSession route sharing policy
+        https://bugs.webkit.org/show_bug.cgi?id=197742
+        <rdar://problem/50590818>
+
+        Reviewed by Darin Adler.
+
+        * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
+        (TestWebKitAPI::TEST):
+
+2019-05-09  Alex Christensen  <achristensen@webkit.org>
+
+        Remove unnecessary test SPI after r244883
+        https://bugs.webkit.org/show_bug.cgi?id=197575
+
+        Reviewed by Tim Horton.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
+        (TEST):
+        * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
+        (TestWebKitAPI::TEST):
+
+2019-05-09  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Add migrations file to repository
+        https://bugs.webkit.org/show_bug.cgi?id=197729
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
+
+2019-05-09  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Fix formatting issues and typos
+        https://bugs.webkit.org/show_bug.cgi?id=197737
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (CompileWebKit.evaluateCommand): Removed extra empty line.
+        * BuildSlaveSupport/ews-build/steps_unittest.py:
+        (TestRunWebKitPerlTests): Fixed typo.
+        * BuildSlaveSupport/ews-app/ews/models/step.py:
+        (Step.save_step): Changed log level to info so that it is logged in production.
+
+2019-05-09  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Production and Development env should configure DEBUG appropriately
+        https://bugs.webkit.org/show_bug.cgi?id=197700
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-app/ews-app/settings.py:
+
+2019-05-09  Xan López  <xan@igalia.com>
+
+        [CMake] Detect SSE2 at compile time
+        https://bugs.webkit.org/show_bug.cgi?id=196488
+
+        Reviewed by Carlos Garcia Campos.
+
+        * Scripts/webkitdirs.pm:
+        (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
+        for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
+
+2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
+
+        [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
+        https://bugs.webkit.org/show_bug.cgi?id=197697
+
+        Reviewed by Žan Doberšek.
+
+        * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
+        * wpe/jhbuild.modules: Ditto.
+
+2019-05-08  Don Olmstead  <don.olmstead@sony.com>
+
+        Update ANGLE
+        https://bugs.webkit.org/show_bug.cgi?id=197676
+
+        Reviewed by Alex Christensen.
+
+        * TestWebKitAPI/PlatformWin.cmake:
+        Remove unnecessary library linkage.
+
+2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win] build-webkit should be ready for Visual Studio 2019
+        https://bugs.webkit.org/show_bug.cgi?id=196622
+
+        Reviewed by Ross Kirsling.
+
+        1. Accommodated to the new msbuild.exe location of VS 2019.
+        2. Removed the hard coded "Visual Studio 15" generator.
+
+        build-webkit is going to choose a Visual Studio generator version
+        matching with the latest installed VS. If you invoke vcvars.bat
+        before build-webkit, it chooses the corresponding Visual Studio
+        generator version by cheking 'VisualStudioVersion' env var which
+        is set by vcvars.bat.
+
+        * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
+        (msBuildPath): When looking for MSBuild, look in
+        "MSBuild\Current\bin" (the new expected location) and fallback
+        to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
+        first location.
+        (msBuildInstallDir): Renamed to msBuildPath.
+        (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
+        Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
+
+2019-05-08  Don Olmstead  <don.olmstead@sony.com>
+
+        [PlayStation] Update port options
+        https://bugs.webkit.org/show_bug.cgi?id=197723
+
+        Reviewed by Ross Kirsling.
+
+        ICU headers were missing from TestWTF.
+
+        * TestWebKitAPI/PlatformPlayStation.cmake:
+
+2019-05-08  Alex Christensen  <achristensen@webkit.org>
+
+        Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
+        https://bugs.webkit.org/show_bug.cgi?id=197712
+        <rdar://problem/50429770>
+
+        Reviewed by Tim Horton.
+
+        * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
+        (TestWebKitAPI::TEST):
+
+2019-05-08  Jonathan Bedard  <jbedard@apple.com>
+
+        Change my status to be a WebKit reviewer.
+
+        * Scripts/webkitpy/common/config/contributors.json:
+
+2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r244952.
+
+        Caused inspector to appear blank.
+
+        Reverted changeset:
+
+        "Web Inspector: Provide UIString descriptions to improve
+        localizations"
+        https://bugs.webkit.org/show_bug.cgi?id=195132
+        https://trac.webkit.org/changeset/244952
+
+2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
+        https://bugs.webkit.org/show_bug.cgi?id=197685
+
+        Reviewed by Alex Christensen.
+
+        Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
+        completion. See LayoutTests/ChangeLog for more details.
+
+        * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+        (WTR::UIScriptController::platformClearAllCallbacks):
+
+2019-05-07  Oriol Brufau  <obrufau@igalia.com>
+
+        Unreviewed. Add myself as a committer.
+
+        * Scripts/webkitpy/common/config/contributors.json:
+
+2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r245038.
+
+        Breaks internal builds.
+
+        Reverted changeset:
+
+        "Add SPI to set a list of hosts to which to send custom header
+        fields cross-origin"
+        https://bugs.webkit.org/show_bug.cgi?id=197397
+        https://trac.webkit.org/changeset/245038
+
 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
 
         Unreviewed. Add myself as a committer.