[Flatpak] Add openjpeg support
[WebKit-https.git] / Tools / ChangeLog
index d9ba94d..6191ba4 100644 (file)
@@ -1,3 +1,836 @@
+2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
+
+        [Flatpak] Add openjpeg support
+        https://bugs.webkit.org/show_bug.cgi?id=194019
+
+        Reviewed by Michael Catanzaro.
+
+        * flatpak/org.webkit.CommonModules.yaml:
+
+2019-01-30  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r240708.
+        https://bugs.webkit.org/show_bug.cgi?id=194022
+
+        It broke WPE build (Requested by KaL on #webkit).
+
+        Reverted changeset:
+
+        "[WPE] Bump font related dependencies to match the GTK+ port"
+        https://bugs.webkit.org/show_bug.cgi?id=194017
+        https://trac.webkit.org/changeset/240708
+
+2019-01-30  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
+        https://bugs.webkit.org/show_bug.cgi?id=194001
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-01-30  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
+        https://bugs.webkit.org/show_bug.cgi?id=194020
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-01-30  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Support color well on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=194010
+
+        Reviewed by Joanmarie Diggs.
+
+        * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
+        (WTR::AccessibilityUIElement::stringAttributeValue):
+
+2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [WPE] Bump font related dependencies to match the GTK+ port
+        https://bugs.webkit.org/show_bug.cgi?id=194017
+
+        Reviewed by Žan Doberšek.
+
+        * wpe/jhbuild.modules:
+        * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
+        * wpe/patches/icudata-stdlibs.patch: Added.
+
+2019-01-29  Alexey Proskuryakov  <ap@apple.com>
+
+        [Mac] Update window scale API usage
+        https://bugs.webkit.org/show_bug.cgi?id=193991
+        rdar://problem/47614795
+
+        Reviewed by Tim Horton.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (changeWindowScaleIfNeeded):
+        * DumpRenderTree/mac/DumpRenderTreeWindow.h:
+        * WebKitTestRunner/mac/PlatformWebViewMac.mm:
+        (WTR::PlatformWebView::changeWindowScaleIfNeeded):
+
+2019-01-29  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=193977
+        <rdar://problem/47643716>
+
+        Reviewed by Geoff Garen.
+
+        Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
+        didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
+        to the previous provisional committing *before* we make the last load. 
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-01-29  Youenn Fablet  <youenn@apple.com>
+
+        Adopt new SPI to evaluate server certificate trust
+        https://bugs.webkit.org/show_bug.cgi?id=193355
+
+        Reviewed by Alex Christensen.
+
+        Add infrastructure to handle HTTPS server trust evaluation testing.
+
+        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
+        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+        (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
+        (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
+        (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
+        * WebKitTestRunner/InjectedBundle/TestRunner.h:
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::resetPreferencesToConsistentValues):
+        (WTR::TestController::didReceiveAuthenticationChallenge):
+        (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
+        * WebKitTestRunner/TestController.h:
+        (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
+        * WebKitTestRunner/TestInvocation.cpp:
+        (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
+        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
+        (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
+
+2019-01-29  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Add build step to print bot Configuration
+        https://bugs.webkit.org/show_bug.cgi?id=193887
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (PrintConfiguration): Build step to print configuration.
+        * BuildSlaveSupport/ews-build/factories.py:
+
+2019-01-29  Chris Dumez  <cdumez@apple.com>
+
+        Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
+        https://bugs.webkit.org/show_bug.cgi?id=193967
+        <rdar://problem/47635348>
+
+        Reviewed by Alex Christensen.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+        (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
+
+2019-01-29  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Handle incoming results data
+        https://bugs.webkit.org/show_bug.cgi?id=193973
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/views/results.py:
+
+2019-01-29  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Make the results url generic
+        https://bugs.webkit.org/show_bug.cgi?id=193928
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/urls.py:
+
+2019-01-29  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Configure buildbot to send events to ews-app
+        https://bugs.webkit.org/show_bug.cgi?id=193968
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-build/events.py: Added.
+        * BuildSlaveSupport/ews-build/master.cfg:
+
+2019-01-29  Keith Rollin  <krollin@apple.com>
+
+        Add .xcfilelists to Run Script build phases
+        https://bugs.webkit.org/show_bug.cgi?id=193792
+        <rdar://problem/47201785>
+
+        Reviewed by Alex Christensen.
+
+        As part of supporting XCBuild, update the necessary Run Script build
+        phases in their Xcode projects to refer to their associated
+        .xcfilelist files.
+
+        Note that the addition of these files bumps the Xcode project version
+        number to something that's Xcode 10 compatible. This change means that
+        older versions of the Xcode IDE can't read these projects. Nor can it
+        fully load workspaces that refer to these projects (the updated
+        projects are shown as non-expandable placeholders). `xcodebuild` can
+        still build these projects; it's just that the IDE can't open them.
+
+        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
+        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
+
+2019-01-29  John Wilander  <wilander@apple.com>
+
+        Add data abstraction and validation for Ad Click Attribution
+        https://bugs.webkit.org/show_bug.cgi?id=193916
+        <rdar://problem/47603481>
+
+        Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
+
+        Ad click attribution has two steps. First, the storage of an ad
+        campaign ID for a click that takes the user to a destination
+        site. Second, a conversion on the destination site that can be
+        attributed to the ad click.
+
+        This patch adds a class that represents a request for ad click
+        attribution. Validation makes sure that the bits of entropy
+        reported through this mechanism is limited.
+
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+        * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
+        (TestWebKitAPI::TEST):
+
+2019-01-29  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
+        https://bugs.webkit.org/show_bug.cgi?id=193932
+        <rdar://problem/47598947>
+
+        Reviewed by Brady Eidson.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-01-29  Zalan Bujtas  <zalan@apple.com>
+
+        Adding new passing LFC tests.
+
+        Unreviewed test gardening.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-01-29  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
+        https://bugs.webkit.org/show_bug.cgi?id=193964
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-01-29  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][BFC] Do not ignore next sibling box while laying out BFC.
+        https://bugs.webkit.org/show_bug.cgi?id=193954
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        WebDriver: add support for running subtests
+        https://bugs.webkit.org/show_bug.cgi?id=193904
+
+        Reviewed by Michael Catanzaro.
+
+        pytest already supports it by passing test.py::subtest, so we can do the same.
+
+        * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
+        (get_item_name): Made this global.
+        (CollectRecorder.__init__): Receive the parameter to ignore.
+        (CollectRecorder.pytest_collectreport): Collect also the subtests.
+        (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
+        (collect): Add parameter to ignore.
+        * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
+        (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
+        * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
+        (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
+        (WebDriverTestRunnerSelenium.run): Ditto.
+        * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
+        (WebDriverTestRunnerW3C.collect_tests): Ditto.
+        (WebDriverTestRunnerW3C.run): Ditto.
+
+2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
+
+        User agent string override for navigator.userAgent should be site specific quirks
+        https://bugs.webkit.org/show_bug.cgi?id=193950
+
+        Reviewed by Brent Fulgham.
+
+        Updated per the _WKWebsitePolicies rename.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
+        (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
+
+2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
+
+        Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
+        https://bugs.webkit.org/show_bug.cgi?id=193941
+
+        Reviewed by Alex Christensen.
+
+        * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
+        * TestWebKitAPI/Tests/WTF/Condition.cpp:
+        * TestWebKitAPI/Tests/WTF/Lock.cpp:
+        * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
+        * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
+        * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
+        * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
+        * TestWebKitAPI/Tests/WTF/Time.cpp:
+        * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
+        * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
+        * TestWebKitAPI/Tests/WebCore/Logging.cpp:
+        * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
+
+2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        Unreviewed, reorder my emails to fix autocomplete in bugzilla
+
+        * Scripts/webkitpy/common/config/contributors.json:
+
+2019-01-28  Andy Estes  <aestes@apple.com>
+
+        [watchOS] Enable Parental Controls content filtering
+        https://bugs.webkit.org/show_bug.cgi?id=193939
+        <rdar://problem/46641912>
+
+        Reviewed by Ryosuke Niwa.
+
+        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+2019-01-28  David Kilzer  <ddkilzer@apple.com>
+
+        REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
+        <https://webkit.org/b/193884>
+
+        Reviewed by Jiewen Tan.
+
+        * Scripts/webkitpy/style/checkers/cpp.py:
+        (check_language): Add LocalAuthentication to
+        `frameworks_with_soft_links`.
+
+2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
+        https://bugs.webkit.org/show_bug.cgi?id=193891
+
+        Reviewed by Ross Kirsling.
+
+        There were three problems in window sizes of WebView and the host window.
+        1. The sizes of pixel image output were incorrect.
+        2. The host window is going to appear after window.resize was invoked.
+        3. window.resize resized only the host window, not WebView.
+
+        This change solves them with a following approach.
+        a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
+        b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
+           as well as DumpRenderTree in order to match the client area and the window area.
+        c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
+        d. PlatformWebView::setWindowFrame changes both window sizes.
+        e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
+
+        * WebKitTestRunner/win/PlatformWebViewWin.cpp:
+        (WTR::PlatformWebView::PlatformWebView): Create the host window
+        and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
+        (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
+        (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
+
+2019-01-28  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Add method to save Step data to database
+        https://bugs.webkit.org/show_bug.cgi?id=193890
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/models/step.py:
+        (Step.save_step): Method to save step data.
+        (Step.update_step): Method to update step data.
+        (Step.get_existing_step): Method to fetch existing step from database.
+        (Step.is_valid_result): Method to validate valid step result.
+
+2019-01-28  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Add method to save Build data to database
+        https://bugs.webkit.org/show_bug.cgi?id=193735
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/models/build.py:
+        (Build.save_build): Method to save build information to database.
+        (Build.get_existing_build): Method to fetch existing build from database.
+        (Build.is_valid_result): Method to validate build result.
+        * BuildSlaveSupport/ews-app/ews/common/util.py:
+        (is_valid_int_id): Method to validate valid id.
+
+2019-01-28  Chris Dumez  <cdumez@apple.com>
+
+        Regression(PSON) Crash under WebPageProxy::didStartProgress()
+        https://bugs.webkit.org/show_bug.cgi?id=193915
+        <rdar://problem/47560907>
+
+        Reviewed by Alex Christensen.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-01-28  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Rename id variables
+        https://bugs.webkit.org/show_bug.cgi?id=193883
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/models/build.py:
+        * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
+        * BuildSlaveSupport/ews-app/ews/models/step.py:
+        * BuildSlaveSupport/ews-app/ews/urls.py:
+        * BuildSlaveSupport/ews-app/ews/views/patch.py:
+        * BuildSlaveSupport/ews-app/ews/views/results.py:
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+
+2019-01-28  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Allow certain fields to be empty
+        https://bugs.webkit.org/show_bug.cgi?id=193892
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/models/build.py:
+        * BuildSlaveSupport/ews-app/ews/models/step.py:
+
+2019-01-28  Rob Buis  <rbuis@igalia.com>
+
+        Update MIME type parser
+        https://bugs.webkit.org/show_bug.cgi?id=180526
+
+        Reviewed by Frédéric Wang.
+
+        * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
+        (TestWebKitAPI::TEST):
+
+2019-01-28  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
+        https://bugs.webkit.org/show_bug.cgi?id=193896
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2018-12-15  Darin Adler  <darin@apple.com>
+
+        Replace many uses of String::format with more type-safe alternatives
+        https://bugs.webkit.org/show_bug.cgi?id=192742
+
+        Reviewed by Mark Lam.
+
+        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+        (WTR::cacheTestRunnerCallback): Use makeString.
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
+        (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
+
+2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
+
+        Use a load optimizer for some sites
+        https://bugs.webkit.org/show_bug.cgi?id=193881
+        <rdar://problem/46325455>
+
+        Reviewed by Brent Fulgham.
+
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+        * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
+
+2019-01-27  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Introduce a static accessibility tree
+        https://bugs.webkit.org/show_bug.cgi?id=193348
+        <rdar://problem/47203295>
+
+        Reviewed by Ryosuke Niwa.
+
+        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+2019-01-26  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
+        https://bugs.webkit.org/show_bug.cgi?id=193867
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-01-26  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
+        https://bugs.webkit.org/show_bug.cgi?id=193865
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Need a mechanism to override navigator.userAgent
+        https://bugs.webkit.org/show_bug.cgi?id=193762
+        <rdar://problem/47504939>
+
+        Reviewed by Brent Fulgham.
+
+        Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
+        (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
+        (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
+
+2019-01-25  Dean Jackson  <dino@apple.com>
+
+        REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
+        https://bugs.webkit.org/show_bug.cgi?id=193831
+        <rdar://problem/47399263>
+
+        Reviewed by Chris Dumez.
+
+        Two new tests that exercise cross-origin and same-origin System
+        Previews.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-01-25  Keith Rollin  <krollin@apple.com>
+
+        Update Xcode projects with "Check .xcfilelists" build phase
+        https://bugs.webkit.org/show_bug.cgi?id=193790
+        <rdar://problem/47201374>
+
+        Reviewed by Alex Christensen.
+
+        Support for XCBuild includes specifying inputs and outputs to various
+        Run Script build phases. These inputs and outputs are specified as
+        .xcfilelist files. Once created, these .xcfilelist files need to be
+        kept up-to-date. In order to check that they are up-to-date or not,
+        add an Xcode build step that invokes an external script that performs
+        the checking. If the .xcfilelists are found to be out-of-date, update
+        them, halt the build, and instruct the developer to restart the build
+        with up-to-date files.
+
+        At this time, the checking and regenerating is performed only if the
+        WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
+        who want to use this facility can set this variable and test out the
+        checking/regenerating. Once it seems like there are no egregious
+        issues that upset a developer's workflow, we'll unconditionally enable
+        this facility.
+
+        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
+        * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
+        * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
+        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
+
+2019-01-25  Keith Rollin  <krollin@apple.com>
+
+        Update Xcode projects with "Apply Configuration to XCFileLists" build target
+        https://bugs.webkit.org/show_bug.cgi?id=193781
+        <rdar://problem/47201153>
+
+        Reviewed by Alex Christensen.
+
+        Part of generating the .xcfilelists used as part of adopting XCBuild
+        includes running `make DerivedSources.make` from a standalone script.
+        It’s important for this invocation to have the same environment as
+        when the actual build invokes `make DerivedSources.make`. If the
+        environments are different, then the two invocations will provide
+        different results. In order to get the same environment in the
+        standalone script, have the script launch xcodebuild targeting the
+        "Apply Configuration to XCFileLists" build target, which will then
+        re-invoke our standalone script. The script is now running again, this
+        time in an environment with all workspace, project, target, xcconfig
+        and other environment variables established.
+
+        The "Apply Configuration to XCFileLists" build target accomplishes
+        this task via a small embedded shell script that consists only of:
+
+            eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
+
+        The process that invokes "Apply Configuration to XCFileLists" first
+        sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
+        evaluated and exports it into the shell environment. When xcodebuild
+        is invoked, it inherits the value of this variable and can `eval` the
+        contents of that variable. Our external standalone script can then set
+        WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
+        of command-line parameters needed to restart itself in the appropriate
+        state.
+
+        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
+        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
+
+2019-01-25  Alex Christensen  <achristensen@webkit.org>
+
+        Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
+        https://bugs.webkit.org/show_bug.cgi?id=193802
+        <rdar://problem/46010580>
+
+        Reviewed by Andy Estes.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
+        (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
+        (TEST):
+
+2019-01-25  Daniel Bates  <dabates@apple.com>
+
+        [iOS] uiController.keyDown() does not translate Control modified key
+        https://bugs.webkit.org/show_bug.cgi?id=192898
+
+        Reviewed by Wenson Hsieh.
+
+        Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
+        key translation, as applicable. Among other cases, key translation occurs when performing
+        a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
+        also makes the behavior of uiController.keyDown() more closely match the behavior of a
+        human pressing down and releasing key(s) using a hardware keyboard.
+
+        * WebKitTestRunner/ios/HIDEventGenerator.h:
+        * WebKitTestRunner/ios/HIDEventGenerator.mm:
+        (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
+
+        (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
+        (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
+        (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
+        (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
+        (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
+        (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
+        (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
+        (-[HIDEventGenerator longPress:completionBlock:]):
+        (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
+        Update code for above renaming.
+
+        (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
+        DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
+
+        (-[HIDEventGenerator keyDown:]): Added.
+        (-[HIDEventGenerator keyUp:]): Added.
+        (-[HIDEventGenerator keyPress:completionBlock:]):
+        (-[HIDEventGenerator eventDispatchThreadEntry:]):
+        (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
+        * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+        (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
+        (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
+        (WTR::parseModifier): Deleted.
+
+2019-01-25  Keith Rollin  <krollin@apple.com>
+
+        Complete the implementation of generate-xcfilelists
+        https://bugs.webkit.org/show_bug.cgi?id=193782
+
+        Reviewed by Alex Christensen.
+
+        A preliminary version of generate-xcfilelists was added in r238008.
+        This patch updates that script in order to:
+
+        - Support checking of .xcfilelists
+        - Perform better execution of `make DerivedSources.make` by
+          relaunching generate-xcfilelists under xcodebuild
+        - Support incremental generation and checking of .xcfilelists
+        - Support supplementary .xcfilelists files from WebKitAdditions
+        - Support being wrapped by parallel version of generate-xcfilelists in
+          Internal that adds support for (re)generating WebKit projects in
+          that repo.
+        - Support builds that have been performed in WebKitBuild as well as
+          ~/Library/Developer/code/DerivedData
+        - Increase robustness and debugging facilities.
+
+        * Scripts/generate-xcfilelists:
+
+2019-01-25  Brent Fulgham  <bfulgham@apple.com>
+
+        Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
+        https://bugs.webkit.org/show_bug.cgi?id=193297
+        <rdar://problem/47158841>
+
+        Unreviewed test case fix.
+
+        These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
+        Previously, the default data store turned the feature on automatically, allowing these tests to pass.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
+        (TEST):
+
+2019-01-25  Keith Rollin  <krollin@apple.com>
+
+        Update existing .xcfilelists
+        https://bugs.webkit.org/show_bug.cgi?id=193791
+        <rdar://problem/47201706>
+
+        Reviewed by Alex Christensen.
+
+        Many .xcfilelist files were added in r238824 in order to support
+        XCBuild. Update these with recent changes to the set of build files
+        and with the current generate-xcfilelist script.
+
+        * DumpRenderTree/DerivedSources-input.xcfilelist:
+        * DumpRenderTree/DerivedSources-output.xcfilelist:
+        * WebKitTestRunner/DerivedSources-input.xcfilelist:
+        * WebKitTestRunner/DerivedSources-output.xcfilelist:
+
+2019-01-25  Keith Rollin  <krollin@apple.com>
+
+        Fix missing dependencies in extract-dependencies-from-makefile
+        https://bugs.webkit.org/show_bug.cgi?id=193783
+        <rdar://problem/47201571>
+
+        Reviewed by Alex Christensen.
+
+        The extract-dependencies-from-makefile script generates .xcfilelists
+        for XCBuild by invoking a makefile in --debug mode, parsing the
+        dependency information in the output, and extracting information
+        regarding targets and dependents. However, the way `make` emits this
+        dependency information is not rigorous, and so we need to determine
+        what lines to look for and parse by trial and error. This approach
+        didn't coriginally atch all the information we needed to collect, so
+        update the script to look for the additional lines we now know to look
+        for.
+
+        * Scripts/extract-dependencies-from-makefile:
+        (Parser):
+        (Parser.addTarget):
+        (Parser.addPrereq):
+        (Parser.doParse):
+
+2019-01-25  Brent Fulgham  <bfulgham@apple.com>
+
+        Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
+        https://bugs.webkit.org/show_bug.cgi?id=193297
+        <rdar://problem/47158841>
+
+        Reviewed by Alex Christensen.
+
+        * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
+            Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
+        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+        (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
+        activating the message used to trigger the callback when it is set.
+
+2019-01-25  Alex Christensen  <achristensen@webkit.org>
+
+        WKWebView.goBack should reload if there is a safe browsing warning
+        https://bugs.webkit.org/show_bug.cgi?id=193805
+        <rdar://problem/46908216>
+
+        Reviewed by Geoff Garen.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
+        (+[Simple3LookupContext sharedLookupContext]):
+        (-[Simple3LookupContext lookUpURL:completionHandler:]):
+        (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
+        (TEST):
+
+2019-01-25  Chris Dumez  <cdumez@apple.com>
+
+        Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
+        https://bugs.webkit.org/show_bug.cgi?id=193788
+        <rdar://problem/47531231>
+
+        Reviewed by Alex Christensen.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+        (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
+
+2019-01-25  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
+        https://bugs.webkit.org/show_bug.cgi?id=193771
+
+        Unreviewed infrastructure fix.
+
+        * Scripts/webkitpy/port/darwin.py:
+        (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
+
+2019-01-25  Alexey Proskuryakov  <ap@apple.com>
+
+        * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
+
+2019-01-25  Alexey Proskuryakov  <ap@apple.com>
+
+        Add contributors.json entries for Ling Ho and for a new bot watchers group.
+
+        * Scripts/webkitpy/common/config/contributors.json:
+
+2019-01-25  Chris Dumez  <cdumez@apple.com>
+
+        Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
+        https://bugs.webkit.org/show_bug.cgi?id=193779
+        <rdar://problem/46170903>
+
+        Reviewed by Antti Koivisto.
+
+        Add API test that quickly navigates forward to a previous process without waiting for it to
+        suspend. I suspect the crash could have been happening due to receiving leftover IPC from
+        the process' previous page when reconnecting the it for the forward navigation.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Need a way for JavaScript (or bundle) code to participate in undo
+        https://bugs.webkit.org/show_bug.cgi?id=190009
+        <rdar://problem/44807048>
+
+        Reviewed by Ryosuke Niwa.
+
+        Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
+        Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
+
+        * DumpRenderTree/ios/UIScriptControllerIOS.mm:
+        (WTR::UIScriptController::lastUndoLabel const):
+        (WTR::UIScriptController::firstRedoLabel const):
+        (WTR::UIScriptController::platformUndoManager const):
+        * DumpRenderTree/mac/UIScriptControllerMac.mm:
+        (WTR::UIScriptController::lastUndoLabel const):
+        (WTR::UIScriptController::firstRedoLabel const):
+        (WTR::UIScriptController::platformUndoManager const):
+        * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
+        * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
+        (WTR::UIScriptController::lastUndoLabel const):
+        (WTR::UIScriptController::firstRedoLabel const):
+        * TestRunnerShared/UIScriptContext/UIScriptController.h:
+        * WebKitTestRunner/UIScriptControllerCocoa.mm:
+        (WTR::UIScriptController::lastUndoLabel const):
+        (WTR::UIScriptController::firstRedoLabel const):
+        * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+        (WTR::UIScriptController::platformUndoManager const):
+        * WebKitTestRunner/mac/UIScriptControllerMac.mm:
+        (WTR::UIScriptController::platformUndoManager const):
+
+2019-01-25  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
+        https://bugs.webkit.org/show_bug.cgi?id=193824
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
 
         Update macOS JSC bot configurations