Reduce use of SessionID::defaultSessionID() in WebKit
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
index f51e044..962fcc8 100644 (file)
@@ -1,3 +1,337 @@
+2019-09-21  Chris Dumez  <cdumez@apple.com>
+
+        Reduce use of SessionID::defaultSessionID() in WebKit
+        https://bugs.webkit.org/show_bug.cgi?id=202080
+
+        Reviewed by Alex Christensen.
+
+        * WebCoreSupport/WebFrameLoaderClient.cpp:
+        (WebFrameLoaderClient::convertMainResourceLoadToDownload):
+        * WebCoreSupport/WebFrameLoaderClient.h:
+
+2019-09-18  Chris Dumez  <cdumez@apple.com>
+
+        BlobRegistry no longer needs SessionIDs
+        https://bugs.webkit.org/show_bug.cgi?id=201936
+
+        Reviewed by Geoffrey Garen.
+
+        BlobRegistry no longer needs SessionIDs, now that we have a single session per WebProcess.
+
+        * WebCoreSupport/WebPlatformStrategies.cpp:
+
+2019-09-16  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [WinCairo][curl] Don't compile unused CertificateCFWin.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=201860
+
+        Reviewed by Alex Christensen.
+
+        * WebMutableURLRequest.cpp: Include <WebCore/CertificateCFWin.h> only if USE(CFURLCONNECTION).
+        (WebMutableURLRequest::setClientCertificate): Don't use PCCERT_CONTEXT for curl port which is defined in WinCrypt.
+
+2019-09-13  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [WinCairo][WK1] Accelerated Compositing can't be disabled by using WebPreferences::setAcceleratedCompositingEnabled
+        https://bugs.webkit.org/show_bug.cgi?id=201749
+
+        Reviewed by Don Olmstead.
+
+        WebPreferences::acceleratedCompositingEnabled always returned TRUE
+        for !USE(CA). It should reflect the pref value set by
+        setAcceleratedCompositingEnabled.
+
+        * WebPreferences.cpp:
+        (WebPreferences::initializeDefaultSettings): Set kCFBooleanTrue to WebKitAcceleratedCompositingEnabledPreferenceKey even for !USE(CG).
+        (WebPreferences::acceleratedCompositingEnabled): Return the pref value for !USE(CA).
+
+2019-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win][WK1] Invert Colors inverts a part of the viewport in high DPI
+        https://bugs.webkit.org/show_bug.cgi?id=201719
+
+        Reviewed by Don Olmstead.
+
+        * WebView.cpp:
+        (WebView::paintWithDirect2D):
+        (WebView::paintIntoBackingStore):
+        Call gc.restore() after inverting the dirty rect.
+
+2019-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]
+        https://bugs.webkit.org/show_bug.cgi?id=192581
+        <rdar://problem/46651605>
+
+        Reviewed by Alex Christensen.
+
+        WebKitLegacy COM interfaces have same name methods within the old
+        and new interfaces. For example, both IWebEditingDelegate and
+        IWebEditingDelegate2 interfaces have 'shouldInsertNode' method.
+        This is a part of public API, can't be renamed.
+
+        * Interfaces/IWebEditingDelegate.idl:
+        * Interfaces/IWebViewPrivate.idl:
+        Added #pragma to ignore the warning.
+
+2019-09-09  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win][WebKitLegacy] WebKitDLL.h(53,37): warning: 'gClassNameCount' has C-linkage specified, but returns user-defined type 'HashCountedSet<WTF::String> &' which is incompatible with C [-Wreturn-type-c-linkage]
+        https://bugs.webkit.org/show_bug.cgi?id=201601
+
+        Reviewed by Ross Kirsling.
+
+        Fixed a clang-cl warning. Names which aren't dllexport-ed don't
+        need to be in a extern "C" scope because they aren't exported to
+        other DLLs.
+
+        * WebKitDLL.h: Moved some variables and gClassNameCount() out of extern "C" scope.
+
+2019-09-06  Alex Christensen  <achristensen@webkit.org>
+
+        When disabling legacy private browsing for testing, change the SessionID back to what it was, not the defaultSessionID
+        https://bugs.webkit.org/show_bug.cgi?id=201480
+
+        Reviewed by Youenn Fablet.
+
+        * WebView.cpp:
+        (WebView::notifyPreferencesChanged):
+
+2019-09-06  Rob Buis  <rbuis@igalia.com>
+
+        Add runtime flag for lazy image loading
+        https://bugs.webkit.org/show_bug.cgi?id=199794
+
+        Reviewed by Frédéric Wang.
+
+        Remove parts of r248409 that were meant for WK1 since
+        lazy image loading is WK2 only.
+
+        * Interfaces/IWebPreferencesPrivate.idl:
+        * WebPreferenceKeysPrivate.h:
+        * WebPreferences.cpp:
+        (WebPreferences::initializeDefaultSettings):
+        (WebPreferences::setResizeObserverEnabled):
+        (WebPreferences::lazyImageLoadingEnabled): Deleted.
+        (WebPreferences::setLazyImageLoadingEnabled): Deleted.
+        * WebPreferences.h:
+        * WebView.cpp:
+        (WebView::notifyPreferencesChanged):
+
+2019-09-05  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [WinCairo][WK1] ASSERTION FAILED: !isAcceleratedCompositing() in WebView::updateBackingStore
+        https://bugs.webkit.org/show_bug.cgi?id=201493
+
+        Reviewed by Don Olmstead.
+
+        WebView::paint switches painting code path by checking accelerated
+        compositing enabled. However, accelerated compositing could be
+        enabled after the checking.
+
+        WebView::paint called WebView::paintCompositedContentToHDC and
+        WebCore::Page::updateRendering.
+        WebView::paintCompositedContentToHDC checks accelerated
+        compositing enabled. Then, WebCore::Page::updateRendering executes
+        JavaScript and accelerated compositing could be enabled.
+
+        * WebView.cpp:
+        (WebView::paint): Call WebCore::Page::updateRendering the
+        beginning of the function.
+
+2019-09-03  Antti Koivisto  <antti@apple.com>
+
+        Remove redundant painting phase arguments from GraphicsLayerClient functions
+        https://bugs.webkit.org/show_bug.cgi?id=201443
+
+        Reviewed by Simon Fraser.
+
+        * WebView.cpp:
+        (WebView::paintContents):
+        * WebView.h:
+
+2019-08-27  Mark Lam  <mark.lam@apple.com>
+
+        Refactor to use VM& instead of VM* at as many places as possible.
+        https://bugs.webkit.org/show_bug.cgi?id=201172
+
+        Reviewed by Yusuke Suzuki.
+
+        * WebFrame.cpp:
+        (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
+
+2019-08-21  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Put keygen element behind a runtime flag and disable it by default
+        https://bugs.webkit.org/show_bug.cgi?id=200850
+
+        Reviewed by Antti Koivisto.
+
+        * Interfaces/IWebPreferencesPrivate.idl:
+        * WebPreferenceKeysPrivate.h:
+        * WebPreferences.cpp:
+        (WebPreferences::keygenElementEnabled):
+        (WebPreferences::setKeygenElementEnabled):
+        * WebPreferences.h:
+        * WebView.cpp:
+        (WebView::notifyPreferencesChanged):
+
+2019-08-19  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [WinCairo][WK1] A browser window starts as an inactive window because AcceleratedCompositingContext::acceleratedCompositingAvailable creates temporary window
+        https://bugs.webkit.org/show_bug.cgi?id=200493
+
+        Reviewed by Ross Kirsling.
+
+        Reverted r179962.
+
+        * WebCoreSupport/AcceleratedCompositingContext.cpp:
+        (AcceleratedCompositingContext::acceleratedCompositingAvailable): Deleted.
+        * WebCoreSupport/AcceleratedCompositingContext.h:
+        * WebView.cpp:
+        (WebView::notifyPreferencesChanged):
+
+2019-08-19  Sihui Liu  <sihui_liu@apple.com>
+
+        Remove IDB-specific quota
+        https://bugs.webkit.org/show_bug.cgi?id=196545
+        <rdar://problem/54201783>
+
+        Reviewed by Youenn Fablet.
+
+        * Interfaces/IWebDatabaseManager.idl:
+        * WebDatabaseManager.cpp:
+        (WebDatabaseManager::setIDBPerOriginQuota): Deleted.
+        * WebDatabaseManager.h:
+
+2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
+        https://bugs.webkit.org/show_bug.cgi?id=200620
+
+        Reviewed by Geoffrey Garen.
+
+        * FullscreenVideoController.cpp:
+        (FullscreenVideoController::FullscreenVideoController):
+        * Plugins/PluginStream.cpp:
+        (WebCore::PluginStream::didReceiveData):
+        * Plugins/PluginView.cpp:
+        (WebCore::PluginView::load):
+        * Plugins/PluginViewWin.cpp:
+        (WebCore::PluginView::wndProc):
+        * WebCoreSupport/WebChromeClient.cpp:
+        (WebChromeClient::WebChromeClient):
+        * WebCoreSupport/WebFrameLoaderClient.cpp:
+        (WebFrameLoaderClient::WebFrameLoaderClient):
+        (WebFrameLoaderClient::savePlatformDataToCachedFrame):
+        * WebCoreSupport/WebInspectorClient.cpp:
+        (WebInspectorClient::openLocalFrontend):
+        (WebInspectorClient::highlight):
+        * WebElementPropertyBag.cpp:
+        (WebElementPropertyBag::WebElementPropertyBag):
+        * WebHistoryItem.cpp:
+        (WebHistoryItem::initFromDictionaryRepresentation):
+        * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
+        (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
+        * WebNotificationCenter.cpp:
+        (WebNotificationCenter::WebNotificationCenter):
+        * WebView.cpp:
+        (WebView::handleMouseEvent):
+        (WebView::registerEmbeddedViewMIMEType):
+        (WebView::enterVideoFullscreenForVideoElement):
+        (WebView::addUserScriptToGroup):
+        (WebView::addUserStyleSheetToGroup):
+        (WebView::setAcceleratedCompositing):
+
+2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
+        https://bugs.webkit.org/show_bug.cgi?id=200620
+
+        Reviewed by Geoffrey Garen.
+
+        * FullscreenVideoController.cpp:
+        * FullscreenVideoController.h:
+        * Plugins/PluginMessageThrottlerWin.h:
+        * WebCachedFramePlatformData.h:
+        * WebCoreSupport/AcceleratedCompositingContext.h:
+        * WebCoreSupport/WebChromeClient.h:
+        * WebCoreSupport/WebContextMenuClient.h:
+        * WebCoreSupport/WebDesktopNotificationsDelegate.h:
+        * WebCoreSupport/WebDragClient.h:
+        * WebCoreSupport/WebEditorClient.h:
+        * WebCoreSupport/WebFrameLoaderClient.cpp:
+        * WebCoreSupport/WebGeolocationClient.h:
+        * WebCoreSupport/WebInspectorClient.h:
+        * WebDatabaseManager.cpp:
+        * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
+        * WebNodeHighlight.h:
+        * WebNotificationCenter.cpp:
+        * WebNotificationCenter.h:
+
+2019-08-15  Brent Fulgham  <bfulgham@apple.com>
+
+        [FTW] Enable CoreFoundation use if building for Apple target
+        https://bugs.webkit.org/show_bug.cgi?id=200799
+
+        Reviewed by Alex Christensen.
+
+        * FullscreenVideoController.cpp:
+        (FullscreenVideoController::FullscreenVideoController):
+        (FullscreenVideoController::enterFullscreen):
+        (FullscreenVideoController::exitFullscreen):
+        (FullscreenVideoController::createHUDWindow):
+        * FullscreenVideoController.h:
+        * WebView.cpp:
+        (WebView::exitFullscreenIfNeeded):
+
+2019-08-15  Youenn Fablet  <youenn@apple.com>
+
+        Always create a Document with a valid SessionID
+        https://bugs.webkit.org/show_bug.cgi?id=200727
+
+        Reviewed by Alex Christensen.
+
+        Implement WebKit1 sessionID getter like done for WebKit2.
+        Either the loader client has a page in which case the page session ID is used
+        or the client has no page, in which case the default session ID is used.
+        This is the same behavior as CachedResourceLoader.
+
+        * WebCoreSupport/WebFrameLoaderClient.cpp:
+        (WebFrameLoaderClient::sessionID const):
+
+2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r248526.
+
+        Caused two IndexedDB perf tests to fail
+
+        Reverted changeset:
+
+        "Remove IDB-specific quota"
+        https://bugs.webkit.org/show_bug.cgi?id=196545
+        https://trac.webkit.org/changeset/248526
+
+2019-08-14  Youenn Fablet  <youenn@apple.com>
+
+        ThreadableBlobRegistry::blobSize should take a SessionID as parameter
+        https://bugs.webkit.org/show_bug.cgi?id=200671
+
+        Reviewed by Alex Christensen.
+
+        * WebCoreSupport/WebPlatformStrategies.cpp:
+
+2019-08-13  Youenn Fablet  <youenn@apple.com>
+
+        Blob registries should be keyed by session IDs
+        https://bugs.webkit.org/show_bug.cgi?id=200567
+        <rdar://problem/54120212>
+
+        Reviewed by Alex Christensen.
+
+        * WebCoreSupport/WebPlatformStrategies.cpp:
+        (WebPlatformStrategies::createBlobRegistry):
+
 2019-08-12  Youenn Fablet  <youenn@apple.com>
 
         Remove IDB-specific quota