WebKit2: Spelling and Grammar Checking: Make sure to remove the markings from the...
[WebKit-https.git] / Source / WebKit2 / ChangeLog
index 75aa59d..dbf20c0 100644 (file)
@@ -1,3 +1,34 @@
+2011-04-12  Jessie Berlin  <jberlin@apple.com>
+
+        Reviewed by Anders Carlsson.
+
+        WebKit2: Spelling and Grammar Checking: Make sure to remove the markings from the document
+        when spelling and/or grammar checking is disabled.
+        https://bugs.webkit.org/show_bug.cgi?id=58350
+
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView toggleContinuousSpellChecking:]):
+        Move the call to unmark the errors to the WebProcess.
+        (-[WKView setGrammarCheckingEnabled:]):
+        Ditto.
+        (-[WKView toggleGrammarChecking:]):
+        Ditto.
+
+        * UIProcess/WebPageProxy.cpp:
+        Remove unused functions.
+        * UIProcess/WebPageProxy.h:
+        Ditto.
+        * WebProcess/WebPage/WebPage.messages.in:
+        Ditto.
+        * WebProcess/WebPage/WebPage.h:
+
+        * WebProcess/WebProcess.cpp:
+        (WebKit::WebProcess::setTextCheckerState):
+        If grammar or spelling checking is disabled, unmark all the pages.
+        Doing it here allows makes it possible to unmark all pages in a cross-platform way that is
+        triggered both by selecting the the context menu items and by any other methods of updating
+        the enabled / disabled state.
+
 2011-04-12  Anders Carlsson  <andersca@apple.com>
 
         Reviewed by Sam Weinig.