Remove Cocoa CFURLConnection loading code
[WebKit-https.git] / Source / WebKit / ChangeLog
index 14fd915..ab3b5db 100644 (file)
@@ -1,3 +1,508 @@
+2017-11-14  Alex Christensen  <achristensen@webkit.org>
+
+        Remove Cocoa CFURLConnection loading code
+        https://bugs.webkit.org/show_bug.cgi?id=179688
+
+        Reviewed by Antti Koivisto.
+
+        * NetworkProcess/Downloads/Download.h:
+
+2017-11-14  Daniel Bates  <dabates@apple.com>
+
+        Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
+        for feature defines
+
+        Following r195498 and r201917 the Visual Studio property files for feature defines have
+        moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
+        Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
+        files.
+
+        * Configurations/FeatureDefines.xcconfig:
+
+2017-11-14  Brent Fulgham  <bfulgham@apple.com>
+
+        Whitelist some IOKIt properties to avoid sandbox violations on YouTube
+        https://bugs.webkit.org/show_bug.cgi?id=179683
+        <rdar://problem/35415368>
+
+        Reviewed by Dean Jackson.
+
+        YouTube video playback on some hardware (and some video encodings) generates sandbox violations. Add
+        whitelist entries for the relevant IOKit properties needed to support these activities.
+
+        * WebProcess/com.apple.WebProcess.sb.in:
+
+2017-11-14  Daniel Bates  <dabates@apple.com>
+
+        Mark WebChromeClient::requestStorageAccess() as final
+        https://bugs.webkit.org/show_bug.cgi?id=179673
+
+        Reviewed by Sam Weinig.
+
+        Mark WebChromeClient::requestStorageAccess() as final so that it overrides the virtual function
+        in ChromeClient with the same name and hence we actually call it through a ChromeClient pointer.
+
+        * WebProcess/WebCoreSupport/WebChromeClient.h:
+
+2017-11-14  Youenn Fablet  <youenn@apple.com>
+
+        WebSWClientConnection should do IPC to StorageProcess if its WebSWOriginTable is not yet initialized
+        https://bugs.webkit.org/show_bug.cgi?id=179668
+
+        Reviewed by Chris Dumez.
+
+        There may be cases where the origin table is not initialized and we would think there is no service worker registration.
+        In such a case, we should go to the StorageProcess.
+        StorageProcess is now sending an IPC message back to each registered SW connection so that WebProcess will know whether its map
+        is correctly initialized or not.
+
+        Renaming hasServiceWorkerRegisteredForOrigin in mayHaveServiceWorkerRegisteredForOrigin.
+
+        * WebProcess/Storage/WebSWClientConnection.cpp:
+        (WebKit::WebSWClientConnection::mayHaveServiceWorkerRegisteredForOrigin const):
+        (WebKit::WebSWClientConnection::matchRegistration):
+        (WebKit::WebSWClientConnection::hasServiceWorkerRegisteredForOrigin const): Deleted.
+        * WebProcess/Storage/WebSWClientConnection.h:
+        * WebProcess/Storage/WebSWOriginTable.h:
+        (WebKit::WebSWOriginTable::isInitialized const):
+        * WebProcess/Storage/WebServiceWorkerProvider.cpp:
+        (WebKit::shouldHandleFetch):
+
+2017-11-14  Brent Fulgham  <bfulgham@apple.com>
+
+        Consolidate sysctl-read rules in WebProcess sandbox
+        https://bugs.webkit.org/show_bug.cgi?id=179674
+        <rdar://problem/35367154>
+
+        Reviewed by Dean Jackson.
+
+        Consolidate the various calls to 'allow sysctl-read' imported during Bug 179548 into
+        the main function in the sandbox profile.
+
+        Remove the statement to grant global sysctl-read permissions that was copied into this
+        sandbox profile in an earlier checkin. We started blocking the blanket read permissions in
+        macOS 10.13, and want to continue to do so.
+        
+        The earlier "grant global read access" in 'system.sb' apparently allowed some sysctl reads
+        to occur before we hit the block declaration in the WebContent sandbox. Now that we are
+        consistently blocking systcl reads from the start, we need to add whitelist entries for a
+        few more entries to avoid creating new sandbox violations.
+
+        * WebProcess/com.apple.WebProcess.sb.in:
+
+2017-11-14  Alex Christensen  <achristensen@webkit.org>
+
+        Remove WebKit CFURLConnection code
+        https://bugs.webkit.org/show_bug.cgi?id=179645
+
+        Reviewed by Alexey Proskuryakov.
+
+        The CFURLConnection code is Windows-specific now. Nobody can use it in modern WebKit.
+
+        * NetworkProcess/Downloads/Download.h:
+        * NetworkProcess/Downloads/mac/DownloadMac.mm:
+        * NetworkProcess/NetworkLoad.h:
+        * NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+        (WebKit::serverTrustCredential):
+        * NetworkProcess/mac/NetworkLoadMac.mm:
+        * Shared/Authentication/AuthenticationManager.cpp:
+        (WebKit::AuthenticationManager::useCredentialForSingleChallenge):
+        (WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge):
+        (WebKit::AuthenticationManager::cancelSingleChallenge):
+        (WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge):
+        (WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge):
+        * Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm:
+        * Shared/Authentication/mac/AuthenticationManager.mac.mm:
+        (WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):
+        * Shared/WebProcessCreationParameters.cpp:
+        (WebKit::WebProcessCreationParameters::encode const):
+        (WebKit::WebProcessCreationParameters::decode):
+        * Shared/WebProcessCreationParameters.h:
+        * Shared/mac/WebCoreArgumentCodersMac.mm:
+        (IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
+        (IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):
+        * config.h:
+
+2017-11-14  Alex Christensen  <achristensen@webkit.org>
+
+        Remove assertions added in r224791
+        https://bugs.webkit.org/show_bug.cgi?id=178751#c10
+
+        * NetworkProcess/mac/RemoteNetworkingContext.mm:
+        (WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
+        * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
+        (WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
+        I had added assertions that sandbox extension handle consumption succeeds.
+        In the API test IndexedDB.StructuredCloneBackwardCompatibility we get a sandbox extension handle
+        to give access to a directory that does not exist and consumption fails.  We want it to fail,
+        so my optimistic addition of a success assertion was incorrect.  The test passes without it
+        and behaves like it used to.
+
+2017-11-14  Tim Horton  <timothy_horton@apple.com>
+
+        Don't use -[NSString stringWithFormat:] to build defaults keys
+        https://bugs.webkit.org/show_bug.cgi?id=179680
+
+        Reviewed by Simon Fraser.
+
+        * UIProcess/mac/WebPreferencesMac.mm:
+        (WebKit::makeKey):
+        (WebKit::debugUserDefaultsValue):
+        Use string concatenation instead of stringWithFormat to build
+        preference keys. This wasn't a huge cost, but it shaves a few milliseconds
+        off process launch.
+
+2017-11-14  Alex Christensen  <achristensen@webkit.org>
+
+        Clean up old URL parser remnants
+        https://bugs.webkit.org/show_bug.cgi?id=179573
+
+        Reviewed by Darin Adler.
+
+        * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
+        (WebKit::WebContextMenuClient::searchWithGoogle):
+        Use https if we do end up searching with google.
+
+2017-11-14  Antti Koivisto  <antti@apple.com>
+
+        Enable display:contents by default
+        https://bugs.webkit.org/show_bug.cgi?id=179655
+
+        Reviewed by Sam Weinig.
+
+        * Shared/WebPreferences.yaml:
+
+        Make non-experimental and enabled.
+
+2017-11-10  Brent Fulgham  <bfulgham@apple.com>
+
+        Consolidate mach-lookup calls in WebProcess sandbox
+        https://bugs.webkit.org/show_bug.cgi?id=179650
+        <rdar://problem/35367154>
+
+        Reviewed by Dean Jackson.
+
+        Consolidate the various calls to 'allow mach-lookup' imported during Bug 179548 into the main
+        function in the sandbox profile. Remove some entries that are not needed by WebKit.
+
+        Remove the statement to grant global permission to perform mach-lookup for any xpc
+        service name that was copied into this sandbox profile in Bug 179548. We started blocking
+        this in macOS 10.13 and want to continue to do so.
+        
+        The earlier "grant global permission" in 'system.sb' apparently allowed some xpc lookups to occur
+        before we hit the block declaration in the WebContent sandbox. Now that we are consistently blocking
+        mach lookups we need to add whitelist entries for a few more services to avoid creating new
+        sandbox violations.
+
+        * WebProcess/com.apple.WebProcess.sb.in:
+
+2017-11-14  Tim Horton  <timothy_horton@apple.com>
+
+        Long pressing a phone number with spaces in it results in a link sheet instead of a data detectors sheet
+        https://bugs.webkit.org/show_bug.cgi?id=179646
+        <rdar://problem/35337288>
+
+        Reviewed by Simon Fraser.
+
+        * UIProcess/ios/WKActionSheetAssistant.mm:
+        (-[WKActionSheetAssistant showImageSheet]):
+        (-[WKActionSheetAssistant showLinkSheet]):
+        (-[WKActionSheetAssistant showDataDetectorsSheet]):
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView _actionForLongPressFromPositionInformation:]):
+        (-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
+        Make use of canBePresentedByDataDetectors with our WebCore URL instead
+        of (sometimes unsucessfully) reparsing the URL with NSURL's parser.
+        Also, avoid a few unnecessary round-trips through String when converting
+        from URL to NSURL.
+
+2017-11-14  Brent Fulgham  <bfulgham@apple.com>
+
+        REGRESSION(r224799): WebKit crashes on Sierra due to sandbox violation
+        https://bugs.webkit.org/show_bug.cgi?id=179656
+        
+        Unreviewed build fix.
+
+        * WebProcess/com.apple.WebProcess.sb.in: Switch to Dan's recommended version check.
+
+2017-11-13  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Give a ServiceWorker WebContentProcess a different display name
+        https://bugs.webkit.org/show_bug.cgi?id=179653
+
+        Reviewed by Brady Eidson.
+
+        * UIProcess/WebProcessProxy.h:
+        * UIProcess/WebProcessProxy.cpp:
+        (WebKit::WebProcessProxy::create):
+        Call connect after construction so virtual methods will use subclass implementations.
+
+        * UIProcess/ServiceWorkerProcessProxy.h:
+        * UIProcess/ServiceWorkerProcessProxy.cpp:
+        (WebKit::ServiceWorkerProcessProxy::create):
+        Copy the pattern from WebProcessProxy to ensure connect() gets called after construction.
+
+        (WebKit::ServiceWorkerProcessProxy::getLaunchOptions):
+        Set a launch option to signal this is a Service Worker process.
+
+        * Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:
+        (WebKit::XPCServiceInitializerDelegate::getExtraInitializationData):
+        * WebProcess/cocoa/WebProcessCocoa.mm:
+        (WebKit::WebProcess::initializeProcessName):
+        Consume the launch option to configuration the process name.
+
+2017-11-13  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION(r224799): WebKit crashes at launch on macOS Sierra due to a sandbox violation
+        https://bugs.webkit.org/show_bug.cgi?id=179656
+
+        Unreviewed. Revert r224799 on macOS Sierra.
+
+        * WebProcess/com.apple.WebProcess.sb.in:
+
+2017-11-13  Chris Dumez  <cdumez@apple.com>
+
+        Send ServiceWorkerData structs to the WebProcesses instead of ServiceWorkerIdentifiers
+        https://bugs.webkit.org/show_bug.cgi?id=179649
+
+        Reviewed by Brady Eidson.
+
+        * Shared/WebCoreArgumentCoders.h:
+        * StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
+        (WebKit::WebSWServerConnection::updateRegistrationStateInClient):
+        (WebKit::WebSWServerConnection::postMessageToServiceWorkerClient):
+        * StorageProcess/ServiceWorker/WebSWServerConnection.h:
+        * WebProcess/Storage/WebSWClientConnection.cpp:
+        (WebKit::WebSWClientConnection::postMessageToServiceWorkerClient):
+        * WebProcess/Storage/WebSWClientConnection.h:
+        * WebProcess/Storage/WebSWClientConnection.messages.in:
+
+2017-11-13  Brady Eidson  <beidson@apple.com>
+
+        Massive "Server-process-to-context-process" connection overhaul.
+        https://bugs.webkit.org/show_bug.cgi?id=179554
+
+        Reviewed by Chris Dumez.
+
+        * DerivedSources.make:
+        * WebKit.xcodeproj/project.pbxproj:
+
+        * Shared/WebCoreArgumentCoders.h:
+
+        * StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
+        (WebKit::WebSWServerConnection::sendToContextProcess):
+        (WebKit::WebSWServerConnection::installServiceWorkerContext): Deleted.
+        (WebKit::WebSWServerConnection::fireInstallEvent): Deleted.
+        (WebKit::WebSWServerConnection::fireActivateEvent): Deleted.
+        (WebKit::WebSWServerConnection::setContextConnection): Deleted.
+        * StorageProcess/ServiceWorker/WebSWServerConnection.h:
+
+        * StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp: Copied from Source/WebCore/workers/service/server/SWServerWorker.cpp.
+        (WebKit::WebSWServerToContextConnection::WebSWServerToContextConnection):
+        (WebKit::WebSWServerToContextConnection::messageSenderConnection):
+        (WebKit::WebSWServerToContextConnection::messageSenderDestinationID):
+        (WebKit::WebSWServerToContextConnection::connectionClosed):
+        (WebKit::WebSWServerToContextConnection::installServiceWorkerContext):
+        (WebKit::WebSWServerToContextConnection::fireInstallEvent):
+        (WebKit::WebSWServerToContextConnection::fireActivateEvent):
+        * StorageProcess/ServiceWorker/WebSWServerToContextConnection.h: Copied from Source/WebCore/workers/service/ServiceWorkerTypes.h.
+        (WebKit::WebSWServerToContextConnection::create):
+        (WebKit::WebSWServerToContextConnection::ipcConnection const):
+        * StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in: Copied from Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in.
+
+        * StorageProcess/StorageProcess.cpp:
+        (WebKit::StorageProcess::didClose):
+        (WebKit::StorageProcess::didReceiveMessage):
+        (WebKit::StorageProcess::globalServerToContextConnection):
+        (WebKit::StorageProcess::createServerToContextConnection):
+        (WebKit::StorageProcess::didGetWorkerContextProcessConnection):
+        (WebKit::StorageProcess::workerContextProcessConnection): Deleted.
+        (WebKit::StorageProcess::createWorkerContextProcessConnection): Deleted.
+        (WebKit::StorageProcess::serviceWorkerContextFailedToStart): Deleted.
+        (WebKit::StorageProcess::serviceWorkerContextStarted): Deleted.
+        (WebKit::StorageProcess::didFinishServiceWorkerInstall): Deleted.
+        (WebKit::StorageProcess::didFinishServiceWorkerActivation): Deleted.
+        (WebKit::StorageProcess::setServiceWorkerHasPendingEvents): Deleted.
+        * StorageProcess/StorageProcess.h:
+        * StorageProcess/StorageProcess.messages.in:
+
+        * StorageProcess/StorageToWebProcessConnection.cpp:
+        (WebKit::StorageToWebProcessConnection::didReceiveMessage):
+        (WebKit::StorageToWebProcessConnection::establishSWServerConnection):
+        (WebKit::StorageToWebProcessConnection::workerContextProcessConnectionCreated):
+
+        * WebProcess/Storage/WebSWContextManagerConnection.cpp:
+        (WebKit::WebSWContextManagerConnection::installServiceWorker):
+        (WebKit::WebSWContextManagerConnection::serviceWorkerStartedWithMessage):
+        (WebKit::WebSWContextManagerConnection::fireInstallEvent):
+        (WebKit::WebSWContextManagerConnection::fireActivateEvent):
+        (WebKit::WebSWContextManagerConnection::didFinishInstall):
+        (WebKit::WebSWContextManagerConnection::didFinishActivation):
+        (WebKit::WebSWContextManagerConnection::setServiceWorkerHasPendingEvents):
+        * WebProcess/Storage/WebSWContextManagerConnection.h:
+        * WebProcess/Storage/WebSWContextManagerConnection.messages.in:
+
+2017-11-13  Brent Fulgham  <bfulgham@apple.com>
+
+        WebContent sandbox should not include 'system.sb'
+        https://bugs.webkit.org/show_bug.cgi?id=179548
+        <rdar://problem/35367154>
+
+        Reviewed by Darin Adler.
+
+        Stop including 'system.sb', and just include the portions of that sandbox that we
+        actually use in WebContent Process. This is the first step in some further sandbox
+        tightening.
+
+        * WebProcess/com.apple.WebProcess.sb.in:
+
+2017-11-13  Simon Fraser  <simon.fraser@apple.com>
+
+        When navigating back to a page, compositing layers may not use accelerated drawing
+        https://bugs.webkit.org/show_bug.cgi?id=178749
+        rdar://problem/35158946
+
+        Reviewed by Dean Jackson.
+
+        Avoid assertions when a test enables accelerated drawing (which we can't support
+        in the iOS simulator).
+
+        * Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
+        (WebKit::RemoteLayerBackingStore::ensureBackingStore):
+
+2017-11-13  Youenn Fablet  <youenn@apple.com>
+
+        matchRegistration does not need to go to StorageProcess if no service worker is registered
+        https://bugs.webkit.org/show_bug.cgi?id=179480
+
+        Reviewed by Chris Dumez.
+
+        Removed origin store handling from StorageProcess since it is now handled within SWServer.
+        Updated clearing of web site data accordingly.
+        Optimized matchRegistration by looking at the origin store before doing any IPC.
+        Do IPC to the StorageProcess if the origin store is not yet initialized on the WebProcess.
+
+        * StorageProcess/ServiceWorker/WebSWOriginStore.h:
+        * StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
+        (WebKit::WebSWServerConnection::resolveRegistrationJobInClient):
+        (WebKit::WebSWServerConnection::resolveUnregistrationJobInClient):
+        * StorageProcess/StorageProcess.cpp:
+        (WebKit::StorageProcess::deleteWebsiteData):
+        (WebKit::StorageProcess::deleteWebsiteDataForOrigins):
+        (WebKit::StorageProcess::swServerForSession):
+        (WebKit::StorageProcess::swOriginStoreForSession):
+        (WebKit::StorageProcess::registerSWServerConnection):
+        (WebKit::StorageProcess::unregisterSWServerConnection):
+        (WebKit::StorageProcess::ensureSWOriginStoreForSession): Deleted.
+        (WebKit::StorageProcess::swOriginStoreForSession const): Deleted.
+        * StorageProcess/StorageProcess.h:
+        * StorageProcess/ServiceWorker/WebSWOriginStore.cpp:
+        (WebKit::WebSWOriginStore::addToStore):
+        (WebKit::WebSWOriginStore::removeFromStore):
+        (WebKit::WebSWOriginStore::clearStore):
+        (WebKit::WebSWOriginStore::add): Deleted.
+        (WebKit::WebSWOriginStore::remove): Deleted.
+        (WebKit::WebSWOriginStore::clear): Deleted.
+        * StorageProcess/ServiceWorker/WebSWOriginStore.h:
+        * WebProcess/Storage/WebSWClientConnection.cpp:
+        (WebKit::WebSWClientConnection::matchRegistration):
+
+2017-11-13  Alex Christensen  <achristensen@webkit.org>
+
+        Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
+        https://bugs.webkit.org/show_bug.cgi?id=178751
+
+        Reviewed by Brady Eidson.
+
+        * NetworkProcess/NetworkConnectionToWebProcess.cpp:
+        (WebKit::NetworkConnectionToWebProcess::ensureLegacyPrivateBrowsingSession):
+        * NetworkProcess/NetworkProcess.cpp:
+        (WebKit::NetworkProcess::initializeNetworkProcess):
+        (WebKit::NetworkProcess::ensurePrivateBrowsingSession): Deleted.
+        * NetworkProcess/NetworkProcess.h:
+        * NetworkProcess/NetworkProcess.messages.in:
+        * NetworkProcess/RemoteNetworkingContext.h:
+        * NetworkProcess/mac/RemoteNetworkingContext.mm:
+        (WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
+        (WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession): Deleted.
+        * Shared/WebsiteDataStoreParameters.cpp:
+        (WebKit::WebsiteDataStoreParameters::legacyPrivateSessionParameters):
+        * Shared/WebsiteDataStoreParameters.h:
+        * UIProcess/WebProcessPool.cpp:
+        (WebKit::WebProcessPool::setAnyPageGroupMightHavePrivateBrowsingEnabled):
+        (WebKit::WebProcessPool::createNewWebProcess):
+        (WebKit::WebProcessPool::pageAddedToProcess):
+        * WebProcess/InjectedBundle/InjectedBundle.cpp:
+        (WebKit::InjectedBundle::setPrivateBrowsingEnabled):
+        * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
+        * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
+        (WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
+        (WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession): Deleted.
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::setSessionID):
+        * WebProcess/WebProcess.cpp:
+        (WebKit::WebProcess::ensurePrivateBrowsingSession): Deleted.
+        * WebProcess/WebProcess.h:
+        * WebProcess/WebProcess.messages.in:
+
+2017-11-13  Alex Christensen  <achristensen@webkit.org>
+
+        Add logs to debug content extension test failures
+        https://bugs.webkit.org/show_bug.cgi?id=179624
+
+        Reviewed by Chris Dumez.
+
+        * UIProcess/API/APIContentRuleListStore.cpp:
+        (API::compiledToFile):
+        Right now I'm seeing this log:
+        "Rule list compilation failed: Unspecified error during compile."
+        I need more information to debug what is failing on the bots.
+
+2017-11-07  Brian Burg  <bburg@apple.com>
+
+        Web Automation: inViewCenterPoint should not include topContentInset when computed in viewport coordinates
+        https://bugs.webkit.org/show_bug.cgi?id=179129
+        <rdar://problem/35297038>
+
+        Reviewed by Simon Fraser.
+
+        When computing the in view center point per W3C specification, the top content inset
+        is inadvertently added back in when converting to the root view coordinate system.
+
+        This patch reworks the protocol command so that it explicitly requests a coordinate
+        system, with options for "Page" (root / contents), "LayoutViewport", and "VisualViewport".
+        The latter is not implemented in this patch, since it is intended for use on iOS someday.
+
+        * UIProcess/Automation/Automation.json:
+        Change usesViewport to CoordinateSystem.
+        Add a new coordinate system enum type and use it.
+        Fix relevant comments for Automation.computElementLayout.
+
+        * UIProcess/Automation/WebAutomationSession.h:
+        * UIProcess/Automation/WebAutomationSession.cpp:
+        (WebKit::protocolStringToCoordinateSystem):
+        (WebKit::WebAutomationSession::computeElementLayout):
+        Parse the requested coordinate system and send it in the message to the web process.
+
+        * WebKit.xcodeproj/project.pbxproj:
+        * WebProcess/Automation/WebAutomationSessionProxy.messages.in:
+        * WebProcess/Automation/WebAutomationSessionProxy.h:
+        * WebProcess/Automation/WebAutomationSessionProxy.cpp:
+        (WebKit::WebAutomationSessionProxy::computeElementLayout):
+        Rework the implementation. Get the element bounds and in-view center point in
+        client coordinates and convert back to root view coordinates for CoordinateSystem::Page.
+
+2017-11-08  Keith Miller  <keith_miller@apple.com>
+
+        Async iteration should only fetch the next method once and add feature flag
+        https://bugs.webkit.org/show_bug.cgi?id=179451
+
+        Reviewed by Geoffrey Garen.
+
+        Add feature flag for Async iteration.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-11-13  Mark Lam  <mark.lam@apple.com>
 
         Add more overflow check book-keeping for MarkedArgumentBuffer.