Have insertDictatedTextAsync() take an InsertTextOptions
[WebKit-https.git] / Source / WebKit / ChangeLog
index 7e9722c..4063d1c 100644 (file)
@@ -1,5 +1,31 @@
 2020-03-20  Daniel Bates  <dabates@apple.com>
 
+        Have insertDictatedTextAsync() take an InsertTextOptions
+        https://bugs.webkit.org/show_bug.cgi?id=209308
+        <rdar://problem/60652838>
+
+        Reviewed by Darin Adler.
+
+        This will provide future extensibility, which I plan to make use of in a subsequent patch,
+        in addition to making the interface for insertDictatedTextAsync() more like insertTextAsync().
+
+        * UIProcess/Cocoa/WebPageProxyCocoa.mm:
+        (WebKit::WebPageProxy::insertDictatedTextAsync): Pass the options through. The caller is now
+        responsible for setting the registerUndoGroup insertion option.
+        * UIProcess/Cocoa/WebViewImpl.mm:
+        (WebKit::WebViewImpl::insertText): Stack-allocate a InsertTextOptions setting its registerUndoGroup
+        field and pass this object through.
+        * UIProcess/WebPageProxy.h:
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView insertText:alternatives:style:]): Pass the default constructed InsertTextOptions,
+        which defaults registerUndoGroup to false to keep the current behavior.
+        * WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
+        (WebKit::WebPage::insertDictatedTextAsync): Write in terms of InsertTextOptions.registerUndoGroup.
+        * WebProcess/WebPage/WebPage.h:
+        * WebProcess/WebPage/WebPage.messages.in:
+
+2020-03-20  Daniel Bates  <dabates@apple.com>
+
         Replace "deferred element focus" functionality with alternative solution
         https://bugs.webkit.org/show_bug.cgi?id=201608