Web Inspector: REGRESSION(r217258): Misspelled variable names
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
index bc3c726..5dff0fb 100644 (file)
@@ -1,3 +1,448 @@
+2017-06-09  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION(r217258): Misspelled variable names
+        https://bugs.webkit.org/show_bug.cgi?id=173189
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Base/Main.js:
+        (WebInspector.tabContentViewClassForRepresentedObject):
+        * UserInterface/Views/ResourceIcons.css:
+        (.large :matches(.resource-icon.resource-type-stylesheet, .stylesheet-icon) .icon):
+        (.large .resource-icon.resource-type-stylesheet .icon): Deleted.
+
+2017-06-09  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Web inspector does not show non-shadow children of an element with a shadow root (e.g. <video>)
+        https://bugs.webkit.org/show_bug.cgi?id=173121
+        <rdar://problem/30948943>
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Models/DOMNode.js:
+        (WebInspector.DOMNode):
+        Only populate _children when we have both the shadowRoots and
+        actual children payloads. Backends always send shadowRoots but
+        only send children when requested. So if we have shadowRoots
+        but expect actual children, don't populate _children until we
+        request the child nodes.
+
+2017-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Remove legacy INSPECTOR_SERVER implementation
+        https://bugs.webkit.org/show_bug.cgi?id=172966
+
+        Reviewed by Žan Doberšek.
+
+        Remove InspectorFrontendHostStub and thr web sockets initialization.
+
+        * UserInterface/Base/InspectorFrontendHostStub.js: Removed.
+        * UserInterface/Base/Main.js:
+        (WebInspector.loaded):
+        * UserInterface/Main.html:
+        * UserInterface/Test.html:
+        * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
+        * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
+
+2017-06-07  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Add ContextMenu item to log WebSocket object to console
+        https://bugs.webkit.org/show_bug.cgi?id=172878
+
+        Reviewed by Joseph Pecoraro.
+
+        * Localizations/en.lproj/localizedStrings.js:
+
+        * UserInterface/Protocol/RemoteObject.js:
+        (WebInspector.RemoteObject.resolveWebSocket):
+
+        * UserInterface/Views/ResourceTreeElement.js:
+        (WebInspector.ResourceTreeElement.prototype.populateContextMenu):
+
+2017-06-07  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Allow user to choose stylesheet when creating new rules
+        https://bugs.webkit.org/show_bug.cgi?id=172487
+
+        Reviewed by Joseph Pecoraro.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Models/DOMNodeStyles.js:
+        (WebInspector.DOMNodeStyles.prototype.addRule.inspectorStyleSheetAvailable):
+        (WebInspector.DOMNodeStyles.prototype.addRule):
+        * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
+        (WebInspector.CSSStyleDetailsSidebarPanel.prototype.initialLayout):
+        (WebInspector.CSSStyleDetailsSidebarPanel.prototype._newRuleButtonContextMenu):
+        * UserInterface/Views/RulesStyleDetailsPanel.js:
+        (WebInspector.RulesStyleDetailsPanel.prototype.newRuleButtonClicked):
+        (WebInspector.RulesStyleDetailsPanel.prototype.newRuleButtonContextMenu):
+        * UserInterface/Views/VisualStyleSelectorSection.js:
+        (WebInspector.VisualStyleSelectorSection):
+        (WebInspector.VisualStyleSelectorSection.prototype._addNewRuleContextMenu):
+        (WebInspector.VisualStyleSelectorSection.prototype._addNewRule): Renamed _addNewRuleClick.
+
+2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Unreviewed rollout r217807. Caused a test to crash.
+
+        * UserInterface/Proxies/HeapSnapshotNodeProxy.js:
+        (WebInspector.HeapSnapshotNodeProxy):
+        (WebInspector.HeapSnapshotNodeProxy.deserialize):
+        * UserInterface/Views/HeapSnapshotClassDataGridNode.js:
+        (WebInspector.HeapSnapshotClassDataGridNode.prototype.createCellContent):
+        * UserInterface/Views/HeapSnapshotClusterContentView.js:
+        (WebInspector.HeapSnapshotClusterContentView.iconStyleClassNameForClassName):
+        * UserInterface/Views/HeapSnapshotDataGridTree.js:
+        (WebInspector.HeapSnapshotInstancesDataGridTree.prototype.populateTopLevel):
+        * UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
+        (WebInspector.HeapSnapshotInstanceDataGridNode.prototype.createCellContent):
+        (WebInspector.HeapSnapshotInstanceDataGridNode.prototype._mouseoverHandler.appendPathRow):
+        * UserInterface/Workers/HeapSnapshot/HeapSnapshot.js:
+        (HeapSnapshot):
+        (HeapSnapshot.updateCategoriesAndMetadata):
+        (HeapSnapshot.prototype.serializeNode):
+        (HeapSnapshot.prototype._gcRootPathes.visitNode):
+        (HeapSnapshot.prototype._gcRootPathes):
+
+2017-06-05  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Improve ES6 Class instances in Heap Snapshot instances view
+        https://bugs.webkit.org/show_bug.cgi?id=172848
+        <rdar://problem/25709212>
+
+        Reviewed by Saam Barati.
+
+        * UserInterface/Workers/HeapSnapshot/HeapSnapshot.js:
+        (HeapSnapshot):
+        Support the new snapshot version. The only thing that changes are the
+        node flags, and its actually completely compatible with version 1.
+
+        (HeapSnapshot.updateCategoriesAndMetadata):
+        List the count of object type instances in each class category.
+
+        (HeapSnapshot.prototype.serializeNode):
+        Include whether or not the node is an object type.
+
+        * UserInterface/Proxies/HeapSnapshotNodeProxy.js:
+        (WebInspector.HeapSnapshotNodeProxy):
+        (WebInspector.HeapSnapshotNodeProxy.deserialize):
+        Add a new Node isObjectType property based on the new data.
+
+        * UserInterface/Views/HeapSnapshotClassDataGridNode.js:
+        (WebInspector.HeapSnapshotClassDataGridNode.prototype.createCellContent):
+        * UserInterface/Views/HeapSnapshotClusterContentView.js:
+        (WebInspector.HeapSnapshotClusterContentView.iconStyleClassNameForClassName):
+        If a class contains 50% or more object type instances then it as such
+        instead of defaulting to native.
+
+        * UserInterface/Views/HeapSnapshotDataGridTree.js:
+        (WebInspector.HeapSnapshotInstancesDataGridTree.prototype.populateTopLevel):
+        * UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
+        (WebInspector.HeapSnapshotInstanceDataGridNode.prototype.createCellContent):
+        We can be more specific than the default if the individual instance is
+        known to be an object type.
+
+2017-06-02  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Don't create NavigationSidebarPanel classes until they are needed by a Tab
+        https://bugs.webkit.org/show_bug.cgi?id=172621
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/ContentBrowserTabContentView.js:
+        (WebInspector.ContentBrowserTabContentView):
+        (WebInspector.ContentBrowserTabContentView.prototype.shown):
+        * UserInterface/Views/TabContentView.js:
+        (WebInspector.TabContentView):
+        (WebInspector.TabContentView.prototype.get navigationSidebarPanel):
+
+        * UserInterface/Views/NetworkTabContentView.js:
+        (WebInspector.NetworkTabContentView.prototype.canShowRepresentedObject):
+        * UserInterface/Views/SearchTabContentView.js:
+        (WebInspector.SearchTabContentView.prototype.canShowRepresentedObject):
+        Use public getter for navigationSidebarPanel.
+
+        * UserInterface/Views/ResourceSidebarPanel.js:
+        (WebInspector.ResourceSidebarPanel):
+        (WebInspector.ResourceSidebarPanel.prototype.initialLayout): Added.
+        Load information about the current frame once the sidebar panel is displayed.
+
+2017-06-02  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Use initialLayout for DetailsSidebarPanel classes
+        https://bugs.webkit.org/show_bug.cgi?id=172381
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
+        (WebInspector.ApplicationCacheDetailsSidebarPanel):
+        (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.initialLayout): Added.
+        (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.layout):
+        * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
+        (WebInspector.DOMNodeDetailsSidebarPanel):
+        (WebInspector.DOMNodeDetailsSidebarPanel.prototype.initialLayout): Added.
+        (WebInspector.DOMNodeDetailsSidebarPanel.prototype.layout):
+        * UserInterface/Views/IndexedDatabaseDetailsSidebarPanel.js:
+        (WebInspector.IndexedDatabaseDetailsSidebarPanel):
+        (WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.initialLayout): Added.
+        (WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.layout):
+        * UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
+        (WebInspector.LayerTreeDetailsSidebarPanel):
+        (WebInspector.LayerTreeDetailsSidebarPanel.prototype.initialLayout): Added.
+        (WebInspector.LayerTreeDetailsSidebarPanel.prototype.layout):
+        * UserInterface/Views/ProbeDetailsSidebarPanel.js:
+        (WebInspector.ProbeDetailsSidebarPanel):
+        (WebInspector.ProbeDetailsSidebarPanel.prototype.initialLayout): Added.
+        * UserInterface/Views/ResourceDetailsSidebarPanel.js:
+        (WebInspector.ResourceDetailsSidebarPanel):
+        (WebInspector.ResourceDetailsSidebarPanel.prototype.set resource):
+        (WebInspector.ResourceDetailsSidebarPanel.prototype.initialLayout): Added.
+        (WebInspector.ResourceDetailsSidebarPanel.prototype.layout):
+        (WebInspector.ResourceDetailsSidebarPanel.prototype._applyResourceEventListeners):
+
+2017-06-02  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: The CodeMirror instance in the ConsolePrompt does't need to be refreshed each time it is shown
+        https://bugs.webkit.org/show_bug.cgi?id=172608
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/ConsolePrompt.js:
+        (WebInspector.ConsolePrompt.prototype.shown): Deleted.
+        * UserInterface/Views/DatabaseContentView.js:
+        (WebInspector.DatabaseContentView.prototype.shown): Deleted.
+        * UserInterface/Views/QuickConsole.js:
+        (WebInspector.QuickConsole):
+
+2017-06-02  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Attributes table in Node Details Sidebar should have editable keys and values
+        https://bugs.webkit.org/show_bug.cgi?id=167076
+        <rdar://problem/30033629>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
+        (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAttributes):
+        (WebInspector.DOMNodeDetailsSidebarPanel.prototype._attributeNodeValueChanged):
+        (WebInspector.DOMNodeDetailsSidebarPanel.prototype._createAttributesDataGrid): Deleted.
+        Rework creation of the attributes DataGrid so that it is only created once and cleared for
+        new content. Nodes in the DataGrid are now EditableDataGridNode instances so that attribute
+        names and values can be changed from within the sidebar. The DataGrid is also sorted based
+        on attribute name, to make finding attributes easier.
+
+        * UserInterface/Views/DataGrid.css:
+        (.data-grid tr.editable .cell-content > input):
+        (body:not(.window-inactive, .window-docked-inactive) .data-grid:matches(:focus, .force-focus) tr.editable.selected .cell-content > input):
+
+        * UserInterface/Views/DetailsSection.css:
+        (.details-section > .content .data-grid tr:not(.editable) td.value-column):
+        (.details-section > .content .data-grid tr:not(.editable) td.value-column > div):
+        (.details-section > .content .data-grid td.value-column): Deleted.
+        (.details-section > .content .data-grid td.value-column > div): Deleted.
+
+        * UserInterface/Main.html:
+        * UserInterface/Views/EditableDataGridNode.js: Added.
+        (WebInspector.EditableDataGridNode):
+        (WebInspector.EditableDataGridNode.prototype.get element):
+        (WebInspector.EditableDataGridNode.prototype.createCellContent):
+        (WebInspector.EditableDataGridNode.prototype._handleKeyPress):
+        (WebInspector.EditableDataGridNode.prototype._handleBlur):
+        (WebInspector.EditableDataGridNode.prototype._notifyInputElementValueChanged):
+        Special type of DataGridNode that wraps the content of each cell in an <input>.
+
+2017-06-02  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Existing query in Search tab doesn't perform search on reload
+        https://bugs.webkit.org/show_bug.cgi?id=172663
+
+        Reviewed by Timothy Hatcher.
+
+        * Localizations/en.lproj/localizedStrings.js:
+
+        * UserInterface/Views/SearchSidebarPanel.css:
+        (.sidebar > .panel.navigation.search.changed > .banner):
+        (.sidebar > .panel.navigation.search.changed > .banner > a):
+        (.sidebar > .panel.navigation.search.changed > :matches(.content, .empty-content-placeholder)):
+
+        * UserInterface/Views/SearchSidebarPanel.js:
+        (WebInspector.SearchSidebarPanel.prototype.performSearch.resourcesCallback):
+        (WebInspector.SearchSidebarPanel.prototype._mainResourceDidChange):
+        (WebInspector.SearchSidebarPanel.prototype._contentChanged):
+        Listen for any "resource added" event, and show the content changed banner when one occurs.
+
+2017-06-02  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Should see active Web Sockets when opening Web Inspector
+        https://bugs.webkit.org/show_bug.cgi?id=172312
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Controllers/FrameResourceManager.js:
+        (WebInspector.FrameResourceManager.prototype.webSocketHandshakeResponseReceived):
+        (WebInspector.FrameResourceManager.prototype.initialize): Removed.
+        Rework order of agent enable calls to ensure that the main frame is initialized before any
+        websocket events are dispatched.
+
+        * UserInterface/Models/WebSocketResource.js:
+        (WebInspector.WebSocketResource.ReadyState):
+        Change symbol strings in enum for better printing in tests.
+
+2017-06-01  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r217691.
+
+        This change broke the Windows build.
+
+        Reverted changeset:
+
+        "Web Inspector: Should see active Web Sockets when opening Web
+        Inspector"
+        https://bugs.webkit.org/show_bug.cgi?id=172312
+        http://trac.webkit.org/changeset/217691
+
+2017-06-01  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Should see active Web Sockets when opening Web Inspector
+        https://bugs.webkit.org/show_bug.cgi?id=172312
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Controllers/FrameResourceManager.js:
+        (WebInspector.FrameResourceManager.prototype.webSocketHandshakeResponseReceived):
+        (WebInspector.FrameResourceManager.prototype.initialize): Removed.
+        Rework order of agent enable calls to ensure that the main frame is initialized before any
+        websocket events are dispatched.
+
+        * UserInterface/Models/WebSocketResource.js:
+        (WebInspector.WebSocketResource.ReadyState):
+        Change symbol strings in enum for better printing in tests.
+
+2017-06-01  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Web Sockets: Unable to inspect a WebSocket that receives >50 messages per second
+        https://bugs.webkit.org/show_bug.cgi?id=171904
+        <rdar://problem/32095863>
+
+        Reviewed by Matt Baker.
+
+        Every size increase of a resource causes a sidebar item to be re-attached to the DOM. Sending or
+        receiving a WebSocket message causes a size increase. When size increase happens too frequently,
+        the go-to arrow starts to flicker and becomes unclickable. This patch makes sure a sidebar item gets
+        re-attached only when its position (index) changes.
+
+        * UserInterface/Views/NetworkSidebarPanel.js:
+        Add the go-to arrow and close buttons when treeElement.status is a spinner element.
+
+        (WebInspector.NetworkSidebarPanel.prototype.treeElementAddedOrChanged):
+        * UserInterface/Views/ResourceTreeElement.js:
+        (WebInspector.ResourceTreeElement.prototype._updateStatus):
+        Setting status to "" removes the go-to arrow and close buttons in the Network tab.
+        Only set status to "" to remove the spinner.
+
+        * UserInterface/Views/TimelineDataGrid.js:
+        (WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
+        * UserInterface/Views/TreeOutline.js:
+        (WebInspector.TreeOutline.prototype.reattachIfIndexChanged): Added.
+
+2017-05-31  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Add Debug view to Settings tab for debug settings and experimental features
+        https://bugs.webkit.org/show_bug.cgi?id=172477
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Base/Setting.js:
+        Add three new settings:
+         - autoLogProtocolMessages
+         - autoLogTimeStats
+         - enableUncaughtExceptionReporter
+
+        * UserInterface/Debug/Bootstrap.js:
+        (WebInspector.runBootstrapOperations):
+        Update toolbar item state when editor in Settings tab is changed.
+
+        * UserInterface/Debug/UncaughtExceptionReporter.js:
+        (handleUncaughtExceptionRecord):
+        Return if the setting controlling the uncaught exception reporter is disabled.
+
+        * UserInterface/Protocol/InspectorBackend.js:
+        (InspectorBackendClass):
+        (InspectorBackendClass.prototype.set dumpInspectorProtocolMessages):
+        (InspectorBackendClass.prototype.get dumpInspectorProtocolMessages):
+        (InspectorBackendClass.prototype.set dumpInspectorTimeStats):
+        (InspectorBackendClass.prototype.get dumpInspectorTimeStats):
+        Replace member variables and private Setting objects with items on WebInspector.settings.
+
+        * UserInterface/Main.html:
+        * UserInterface/Views/GeneralSettingsView.js: Removed.
+        Consolidated into SettingsTabContentView.
+
+        * UserInterface/Views/SettingsTabContentView.js:
+        (WebInspector.SettingsTabContentView):
+        (WebInspector.SettingsTabContentView.prototype.initialLayout):
+        (WebInspector.SettingsTabContentView.prototype._createGeneralSettingsView):
+        (WebInspector.SettingsTabContentView.prototype._createDebugSettingsView):
+        (WebInspector.SettingsTabContentView.prototype._updateDebugSettingsViewVisibility):
+
+        * UserInterface/Views/SettingsView.js:
+        (WebInspector.SettingsView.prototype.addGroupWithCustomSetting):
+
+2017-05-31  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [GTK] Web Inspector: BackForwardArrows.svg is not shown
+        https://bugs.webkit.org/show_bug.cgi?id=172741
+
+        Reviewed by Carlos Garcia Campos.
+
+        * UserInterface/Images/gtk/BackForwardArrows.svg: Renamed id names to match with Apple's images.
+
+2017-05-30  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: images dragged from Inspector to Desktop are named "Unknown.png"
+        https://bugs.webkit.org/show_bug.cgi?id=141515
+        <rdar://problem/9251308>
+
+        Reviewed by Wenson Hsieh.
+
+        * UserInterface/Views/ImageResourceContentView.js:
+        (WebInspector.ImageResourceContentView.prototype.contentAvailable):
+        Set a non-standard "filename" attribute to provide a suggested filename
+        for this <img> containing data: or blob: content.
+
+2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [GTK] Web Inspector: Add DOM breakpoint image for GTK+
+        https://bugs.webkit.org/show_bug.cgi?id=169326
+
+        Reviewed by Carlos Garcia Campos.
+
+        * UserInterface/Images/gtk/DOMBreakpoint.svg: Added.
+
+2017-05-28  Dan Bernstein  <mitz@apple.com>
+
+        [Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES
+        https://bugs.webkit.org/show_bug.cgi?id=172691
+
+        Reviewed by Tim Horton.
+
+        * Configurations/Base.xcconfig: Set ALWAYS_SEARCH_USER_PATHS to NO.
+
+2017-05-26  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Reloading the page after switching from the Resource tab switches back
+        https://bugs.webkit.org/show_bug.cgi?id=172622
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/DebuggerSidebarPanel.js:
+        (WebInspector.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
+        * UserInterface/Views/ResourceSidebarPanel.js:
+        (WebInspector.ResourceSidebarPanel.prototype._treeSelectionDidChange):
+        * UserInterface/Views/SearchSidebarPanel.js:
+        (WebInspector.SearchSidebarPanel.prototype._treeSelectionDidChange):
+        Don't show the newly selected tree element's represented object if the sidebar is not visible.
+
 2017-05-26  Devin Rousso  <drousso@apple.com>
 
         Web Inspector: New Tab contents have extra vertical spacing when wrapped