Clean up the difference between painting focus rings and adding PDF annotations
[WebKit-https.git] / Source / WebCore / ChangeLog
index 3e725cf..e1530fd 100644 (file)
@@ -1,3 +1,26 @@
+2014-05-06  Dean Jackson  <dino@apple.com>
+
+        Clean up the difference between painting focus rings and adding PDF annotations
+        https://bugs.webkit.org/show_bug.cgi?id=132638
+
+        Reviewed by Simon Fraser.
+
+        The code to add a PDF annotation when printing was called from
+        drawFocusRing, which is quite confusing. With just little movement
+        of code, we can detect an annotation and call addPDFURLRect in the
+        paint phase, and drawFocusRing becomes something that only
+        draws focus rings.
+
+        * rendering/RenderInline.cpp:
+        (WebCore::RenderInline::paintOutline): Split calls to drawFocusRing
+        and addPDFURLRect.
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::paintFocusRing): Get rid of call to PDF.
+        (WebCore::RenderObject::addPDFURLRect): Change the signature so it
+        can be called externally, and calculates the rectangle itself.
+        (WebCore::RenderObject::paintOutline): Split the calls.
+        * rendering/RenderObject.h:
+
 2014-05-06  Rik Cabanier  <cabanier@adobe.com>
 
         Calling createPattern with a broken image must throw an invalidstate error