REGRESSION (r170808): Volume slider in built-in media controls only changes volume...

[WebKit-https.git] / Source / WebCore / ChangeLog

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 276a54b..bdcdca4 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,28 @@
+2014-10-21  Jer Noble  <jer.noble@apple.com>
+
+        REGRESSION (r170808): Volume slider in built-in media controls only changes volume when thumb is released, not while dragging
+        https://bugs.webkit.org/show_bug.cgi?id=137805
+
+        Reviewed by Dan Bernstein.
+
+        Test: media/video-volume-slider-drag.html
+
+        Respond to the 'input' event rather than the 'change' event for the volume slider, so that
+        volume changes are continuous during drag operations.
+
+        Also listen for both 'input' and 'change' events for the timeline slider, doing fastSeek()
+        during 'input' and setting an explicit currentTime during 'change'. This is the same behavior
+        as current, but using 'change' instead of 'mouseup' to do the final currentTime change.
+
+        * Modules/mediacontrols/mediaControlsApple.js:
+        (Controller.prototype.createControls):
+        (Controller.prototype.handleTimelineInput):
+        (Controller.prototype.handleTimelineChange):
+        (Controller.prototype.handleTimelineMouseUp):
+        (Controller.prototype.handleVolumeSliderInput):
+        (Controller.prototype.handlePlayButtonClicked): Deleted.
+        (Controller.prototype.handleMaxButtonClicked): Deleted.
+
 2014-10-21  Manuel Rego Casasnovas  <rego@igalia.com>
 
         ASSERTION FAILED: !gridWasPopulated() in WebCore::RenderGrid::placeItemsOnGrid