[LFC] Miscellaneous fixes to fix simple absolute positioning.
[WebKit-https.git] / Source / WebCore / ChangeLog
index 80a4223..b7090e5 100644 (file)
@@ -1,3 +1,26 @@
+2018-06-23  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC] Miscellaneous fixes to fix simple absolute positioning.
+        https://bugs.webkit.org/show_bug.cgi?id=186962
+
+        Reviewed by Antti Koivisto.
+
+        1. Collect out-of-flow formatting root descendants.
+        2. Remove invalid and redundant ASSERTs
+          invalid because the assertion is missing border, padding etc.
+          redundant becasue we assert on geometry correctness in validateGeometryConstraintsAfterLayout.  
+
+        * layout/FormattingContext.cpp:
+        (WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
+        (WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
+        (WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
+        * layout/layouttree/LayoutContainer.cpp:
+        (WebCore::Layout::Container::addOutOfFlowDescendant):
+        (WebCore::Layout::Container::setOutOfFlowDescendants): Deleted.
+        * layout/layouttree/LayoutContainer.h:
+        * layout/layouttree/LayoutTreeBuilder.cpp:
+        (WebCore::Layout::TreeBuilder::createSubTree):
+
 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
 
         [WTF] Add user-defined literal for ASCIILiteral