Remove more unnecessary #if PLATFORM(IOS)s in ApplicationCacheStorage.cpp
[WebKit-https.git] / Source / WebCore / ChangeLog
index 06cab41..aea1015 100644 (file)
@@ -1,3 +1,405 @@
+2014-01-25  Sam Weinig  <sam@webkit.org>
+
+        Remove more unnecessary #if PLATFORM(IOS)s in ApplicationCacheStorage.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=127635
+
+        Reviewed by Antti Koivisto.
+
+        * loader/appcache/ApplicationCacheStorage.cpp:
+        (WebCore::ApplicationCacheStorage::executeSQLCommand):
+        (WebCore::ApplicationCacheStorage::verifySchemaVersion):
+        (WebCore::ApplicationCacheStorage::executeStatement):
+        (WebCore::ApplicationCacheStorage::store):
+        (WebCore::ApplicationCacheStorage::ensureOriginRecord):
+        (WebCore::ApplicationCacheStorage::loadCache):
+
+2014-01-25  Sam Weinig  <sam@webkit.org>
+
+        Remove some iOS #ifdefs by adding SQLiteDatabaseTracker to all the builds
+        https://bugs.webkit.org/show_bug.cgi?id=127632
+
+        Reviewed by Darin Adler.
+
+        Move the SQLiteDatabaseTracker and client from platform/sql/ios to platform/sql,
+        as there is nothing iOS specific about it. Then, un-#ifdef all its uses. For
+        ports that don't setup a client, this has no change in behavior.
+
+        * CMakeLists.txt:
+        * GNUmakefile.list.am:
+        * Modules/webdatabase/DatabaseBackendBase.cpp:
+        * WebCore.vcxproj/WebCore.vcxproj:
+        * WebCore.vcxproj/WebCore.vcxproj.filters:
+        * WebCore.xcodeproj/project.pbxproj:
+        * loader/appcache/ApplicationCacheStorage.cpp:
+        * platform/ScrollableArea.h:
+        (WebCore::ScrollableArea::sendWillRevealEdgeEventsIfNeeded):
+        * platform/sql/SQLiteDatabaseTracker.cpp: Copied from Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.cpp.
+        * platform/sql/SQLiteDatabaseTracker.h: Copied from Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.h.
+        * platform/sql/SQLiteDatabaseTrackerClient.h: Copied from Source/WebCore/platform/sql/ios/SQLiteDatabaseTrackerClient.h.
+        * platform/sql/ios: Removed.
+        * platform/sql/ios/SQLiteDatabaseTracker.cpp: Removed.
+        * platform/sql/ios/SQLiteDatabaseTracker.h: Removed.
+        * platform/sql/ios/SQLiteDatabaseTrackerClient.h: Removed.
+        * storage/StorageAreaSync.cpp:
+        (WebCore::StorageAreaSync::openDatabase):
+        (WebCore::StorageAreaSync::sync):
+        * storage/StorageTracker.cpp:
+
+2014-01-25  Anders Carlsson  <andersca@apple.com>
+
+        Remove an unused FrameLoaderClient function
+        https://bugs.webkit.org/show_bug.cgi?id=127628
+
+        Reviewed by Andreas Kling.
+
+        All implementations of FrameLoaderClient::shouldStopLoadingForHistoryItem return true and this function
+        was only used by Chromium so we can get rid of it.
+
+        * loader/EmptyClients.h:
+        * loader/FrameLoaderClient.h:
+        * loader/HistoryController.cpp:
+        (WebCore::HistoryController::shouldStopLoadingForHistoryItem):
+
+2014-01-25  Darin Adler  <darin@apple.com>
+
+        Call deprecatedCharacters instead of characters at more call sites
+        https://bugs.webkit.org/show_bug.cgi?id=127631
+
+        Reviewed by Sam Weinig.
+
+        * bindings/objc/WebScriptObject.mm:
+        (+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):
+        * editing/CompositeEditCommand.cpp:
+        (WebCore::containsOnlyWhitespace):
+        * editing/TypingCommand.cpp:
+        (WebCore::TypingCommand::insertText):
+        * editing/VisibleUnits.cpp:
+        (WebCore::startOfParagraph):
+        (WebCore::endOfParagraph):
+        * html/parser/HTMLParserIdioms.cpp:
+        (WebCore::stripLeadingAndTrailingHTMLSpaces):
+        (WebCore::parseHTMLNonNegativeInteger):
+        * inspector/InspectorStyleSheet.cpp:
+        (WebCore::InspectorStyle::newLineAndWhitespaceDelimiters):
+        * inspector/InspectorStyleTextEditor.cpp:
+        (WebCore::InspectorStyleTextEditor::insertProperty):
+        (WebCore::InspectorStyleTextEditor::internalReplaceProperty):
+        * platform/Length.cpp:
+        (WebCore::newCoordsArray):
+        * platform/LinkHash.cpp:
+        (WebCore::visitedLinkHash):
+        * platform/graphics/Color.cpp:
+        (WebCore::Color::parseHexColor):
+        (WebCore::Color::Color):
+        * platform/graphics/TextRun.h:
+        (WebCore::TextRun::TextRun):
+        * platform/text/TextEncodingRegistry.cpp:
+        (WebCore::atomicCanonicalTextEncodingName):
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::constructTextRun):
+        * rendering/RenderCombineText.cpp:
+        (WebCore::RenderCombineText::width):
+        * svg/SVGFontElement.cpp:
+        (WebCore::SVGFontElement::registerLigaturesInGlyphCache):
+        * xml/XPathFunctions.cpp:
+        (WebCore::XPath::FunId::evaluate):
+        Use the new name.
+
+2014-01-25  Darin Adler  <darin@apple.com>
+
+        Get rid of ICU_UNICODE and WCHAR_UNICODE remnants
+        https://bugs.webkit.org/show_bug.cgi?id=127623
+
+        Reviewed by Anders Carlsson.
+
+        * CMakeLists.txt: Removed SmartReplaceICU.cpp.
+        * GNUmakefile.list.am: Ditto.
+        * PlatformEfl.cmake: Ditto.
+        * PlatformGTK.cmake: Ditto.
+
+        * editing/FrameSelection.cpp:
+        (WebCore::FrameSelection::modifyMovingRight): Ditto.
+        (WebCore::FrameSelection::modifyMovingLeft): Ditto.
+
+        * editing/SmartReplace.cpp: Moved code here from SmartReplaceICU,
+        since we always support ICU now. Added some FIXME comments about
+        bugs and mistakes I spotted in the code as I was moving it.
+        * editing/SmartReplaceICU.cpp: Removed.
+
+        * editing/TextIterator.cpp: Removed unneeded checks.
+        * platform/ThreadGlobalData.cpp:
+        (WebCore::ThreadGlobalData::ThreadGlobalData): Ditto.
+        (WebCore::ThreadGlobalData::destroy): Ditto.
+        * platform/ThreadGlobalData.h: Ditto.
+        * platform/URL.cpp:
+        (WebCore::appendEncodedHostname): Ditto.
+        * platform/graphics/SurrogatePairAwareTextIterator.cpp: Ditto.
+        Also removed unneeded "using namespace".
+        * platform/text/TextCodecICU.cpp: Ditto.
+        * platform/text/TextEncoding.cpp:
+        (WebCore::TextEncoding::encode): Ditto.
+        * platform/text/TextEncodingRegistry.cpp:
+        (WebCore::extendTextCodecMaps): Ditto.
+
+2014-01-25  Darin Adler  <darin@apple.com>
+
+        Get rid of UnicodeRange.h/cpp, using ICU instead
+        https://bugs.webkit.org/show_bug.cgi?id=127622
+
+        Reviewed by Anders Carlsson.
+
+        * CMakeLists.txt: Remove UnicodeRange.h/cpp.
+        * GNUmakefile.list.am: Ditto.
+        * WebCore.vcxproj/WebCore.vcxproj: Ditto.
+        * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
+        * WebCore.xcodeproj/project.pbxproj: Ditto.
+
+        * platform/graphics/win/FontCacheWin.cpp:
+        (WebCore::FontCache::systemFallbackForCharacters): To check if a character has
+        multiple code pages, use UCHAR_UNIFIED_IDEOGRAPH instead of cRangeSetCJK.
+        * platform/graphics/wince/FontCacheWinCE.cpp:
+        (WebCore::FontCache::systemFallbackForCharacters): Ditto. Also, to check if a
+        character is in the Thai block, use UBLOCK_THAI.
+
+        * platform/graphics/wince/FontPlatformData.cpp: Removed include of UnicodeRange.h.
+
+        * platform/text/UnicodeRange.cpp: Removed.
+        * platform/text/UnicodeRange.h: Removed.
+
+        * rendering/svg/SVGTextLayoutEngineBaseline.cpp:
+        (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphOrientationAngle): To figure
+        out if a character is full width, use UCHAR_EAST_ASIAN_WIDTH, instead of hard-coding
+        "not Latin or Arabic" as the rule.
+
+2014-01-25  Tim Horton  <timothy_horton@apple.com>
+
+        Remove an unnecessary platform #if in BitmapImage(CG)::checkForSolidColor()
+        https://bugs.webkit.org/show_bug.cgi?id=127610
+
+        Reviewed by Simon Fraser.
+
+        * platform/graphics/cg/BitmapImageCG.cpp:
+        (WebCore::BitmapImage::checkForSolidColor):
+        Over time, the two sides of this #if !PLATFORM(IOS) converged. Remove the #if
+        and merge the code. We explicitly use kCGBitmapByteOrder32Big to be correct everywhere.
+
+2014-01-25  Tim Horton  <timothy_horton@apple.com>
+
+        [cg] Look in the PNG dictionary for image duration information
+        https://bugs.webkit.org/show_bug.cgi?id=127611
+        <rdar://problem/15408643>
+
+        Reviewed by Simon Fraser.
+
+        We should look in the PNG properties dictionary for frame duration and loop count data.
+
+        * platform/graphics/cg/ImageSourceCG.cpp:
+        (WebCore::ImageSource::repetitionCount):
+        Mush repetitionCount a bit more to make it easier to read (early returns, etc.)
+        Also, look in the PNG properties dictionary for a loop count.
+
+        (WebCore::ImageSource::frameDurationAtIndex):
+        Look in the PNG properties dictionary for delay time.
+        Get rid of WebCoreCGImagePropertyGIFUnclampedDelayTime; it hasn't
+        been needed since Snow Leopard.
+
+2014-01-25  Anders Carlsson  <andersca@apple.com>
+
+        Remove atomicIncrement/atomicDecrement
+        https://bugs.webkit.org/show_bug.cgi?id=127625
+
+        Reviewed by Andreas Kling.
+
+        Replace atomicIncrement/atomicDecrement with std::atomic.
+
+        * Modules/webaudio/AudioContext.cpp:
+        (WebCore::AudioContext::incrementActiveSourceCount):
+        (WebCore::AudioContext::decrementActiveSourceCount):
+        * Modules/webaudio/AudioContext.h:
+        * Modules/webaudio/AudioNode.cpp:
+        (WebCore::AudioNode::~AudioNode):
+        (WebCore::AudioNode::ref):
+        (WebCore::AudioNode::finishDeref):
+        * Modules/webaudio/AudioNode.h:
+        * Modules/webdatabase/OriginLock.h:
+
+2014-01-25  Alex Christensen  <achristensen@webkit.org>
+
+        Unreviewed build fix for WinCairo.
+
+        * platform/network/curl/CurlDownload.h:
+        Included wtf/Threading.h for ThreadIdentifier definition.
+
+2014-01-25  Anders Carlsson  <andersca@apple.com>
+
+        Modernize HashTable threading code
+        https://bugs.webkit.org/show_bug.cgi?id=127621
+
+        Reviewed by Darin Adler.
+
+        Explicitly include headers that used to be brought in by HashTable.h
+
+        * platform/DragData.h:
+        Change a Windows-specific typedef to avoid having to include WindDef.h from a header.
+
+        * platform/audio/AudioSession.h:
+        * platform/network/cf/SocketStreamHandle.h:
+
+2014-01-25  Zan Dobersek  <zdobersek@igalia.com>
+
+        Move CSSGroupingRule, CSSStyleSheet, ElementRuleCollector to std::unique_ptr
+        https://bugs.webkit.org/show_bug.cgi?id=127575
+
+        Reviewed by Andreas Kling.
+
+        Use std::unique_ptr and std::make_unique in place of OwnPtr and adoptPtr
+        in the CSSGroupingRule, CSSStyleSheet and ElementRuleCollector classes.
+
+        * css/CSSFunctionValue.cpp: Remove the unnecessary PassOwnPtr header inclusion.
+        * css/CSSGroupingRule.cpp:
+        (WebCore::CSSGroupingRule::cssRules):
+        * css/CSSGroupingRule.h:
+        * css/CSSStyleSheet.cpp:
+        (WebCore::CSSStyleSheet::cssRules):
+        * css/CSSStyleSheet.h:
+        * css/ElementRuleCollector.cpp:
+        (WebCore::ElementRuleCollector::addMatchedRule):
+        * css/ElementRuleCollector.h:
+
+2014-01-25  Zan Dobersek  <zdobersek@igalia.com>
+
+        Move MediaQueryMatcher, SelectorFilter to std::unique_ptr
+        https://bugs.webkit.org/show_bug.cgi?id=127574
+
+        Reviewed by Andreas Kling.
+
+        Replace the use of OwnPtr and adoptPtr with std::unique_ptr and std::make_unique
+        in the MediaQueryMatcher and SelectorFilter classes.
+
+        * css/MediaQueryMatcher.cpp:
+        (WebCore::MediaQueryMatcher::prepareEvaluator):
+        (WebCore::MediaQueryMatcher::evaluate):
+        (WebCore::MediaQueryMatcher::addListener):
+        (WebCore::MediaQueryMatcher::styleResolverChanged):
+        * css/MediaQueryMatcher.h:
+        * css/SelectorFilter.cpp:
+        (WebCore::SelectorFilter::popParentStackFrame):
+        (WebCore::SelectorFilter::setupParentStack):
+        * css/SelectorFilter.h:
+
+2014-01-25  Zan Dobersek  <zdobersek@igalia.com>
+
+        Move PropertySetCSSStyleDeclaration, WebKitCSSKeyframesRule to std::unique_ptr
+        https://bugs.webkit.org/show_bug.cgi?id=127572
+
+        Reviewed by Andreas Kling.
+
+        Switch the PropertySetCSSStyleDeclaration and WebKitCSSKeyframesRule classes from using
+        OwnPtr and adoptPtr to using std::unique_ptr and std::make_unique.
+
+        * css/PropertySetCSSStyleDeclaration.cpp:
+        (WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):
+        (WebCore::StyleRuleCSSStyleDeclaration::didMutate):
+        (WebCore::InlineCSSStyleDeclaration::didMutate):
+        * css/PropertySetCSSStyleDeclaration.h:
+        * css/WebKitCSSKeyframesRule.cpp:
+        (WebCore::WebKitCSSKeyframesRule::cssRules):
+        * css/WebKitCSSKeyframesRule.h:
+
+2014-01-25  Zan Dobersek  <zdobersek@igalia.com>
+
+        Move StyleProperties, StyleResolver to std::unique_ptr
+        https://bugs.webkit.org/show_bug.cgi?id=127570
+
+        Reviewed by Andreas Kling.
+
+        Move the StyleProperties and StyleResolver classes from using OwnPtr and adoptPtr
+        to using std::unique_ptr and std::make_unique.
+
+        * css/StyleInvalidationAnalysis.h: Remove the PassOwnPtr.h header inclusion.
+        * css/StyleProperties.cpp:
+        (WebCore::MutableStyleProperties::ensureCSSStyleDeclaration):
+        (WebCore::MutableStyleProperties::ensureInlineCSSStyleDeclaration):
+        * css/StyleProperties.h:
+        * css/StyleResolver.cpp:
+        (WebCore::StyleResolver::StyleResolver):
+        (WebCore::StyleResolver::addViewportDependentMediaQueryResult):
+        * css/StyleResolver.h:
+        * css/StyleScopeResolver.h:
+
+2014-01-25  Zan Dobersek  <zdobersek@igalia.com>
+
+        Move CSSFontFace, CSSFontSelector to std::unique_ptr
+        https://bugs.webkit.org/show_bug.cgi?id=127569
+
+        Reviewed by Andreas Kling.
+
+        Move the CSSFontFace and CSSFontSelector classes from using OwnPtr, PassOwnPtr and adoptPtr
+        to using std::unique_ptr, move semantics and std::make_unique.
+
+        * css/CSSFontFace.cpp:
+        (WebCore::CSSFontFace::addSource):
+        * css/CSSFontFace.h:
+        * css/CSSFontSelector.cpp:
+        (WebCore::CSSFontSelector::addFontFaceRule):
+        (WebCore::CSSFontSelector::getFontFace):
+        * css/CSSFontSelector.h:
+
+2014-01-24  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Move InspectorRuntimeAgent into JavaScriptCore
+        https://bugs.webkit.org/show_bug.cgi?id=127605
+
+        Reviewed by Timothy Hatcher.
+
+        Covered by existing tests. No change in functionality.
+
+        * CMakeLists.txt:
+        * GNUmakefile.list.am:
+        * WebCore.vcxproj/WebCore.vcxproj:
+        * WebCore.vcxproj/WebCore.vcxproj.filters:
+        * WebCore.xcodeproj/project.pbxproj:
+        * inspector/InspectorAllInOne.cpp:
+        Remove WebCore InspectorRuntimeAgent.
+
+        * ForwardingHeaders/inspector/agents/InspectorRuntimeAgent.h: Added.
+        Add JavaScriptCore InspectorRuntimeAgent.
+
+        * inspector/InspectorController.cpp:
+        (WebCore::InspectorController::InspectorController):
+        * inspector/WorkerInspectorController.h:
+        * inspector/WorkerInspectorController.cpp:
+        (WebCore::WorkerInspectorController::WorkerInspectorController):
+        New constructors for the runtime agent.
+
+        * inspector/PageRuntimeAgent.h:
+        * inspector/PageRuntimeAgent.cpp:
+        (WebCore::PageRuntimeAgent::PageRuntimeAgent):
+        (WebCore::PageRuntimeAgent::enable):
+        (WebCore::PageRuntimeAgent::disable):
+        (WebCore::PageRuntimeAgent::didCreateMainWorldContext):
+        (WebCore::PageRuntimeAgent::didCreateIsolatedContext):
+        (WebCore::PageRuntimeAgent::globalVM):
+        Modernize and implement globalVM.
+
+        * inspector/WorkerRuntimeAgent.h:
+        * inspector/WorkerRuntimeAgent.cpp:
+        (WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
+        (WebCore::WorkerRuntimeAgent::injectedScriptForEval):
+        (WebCore::WorkerRuntimeAgent::globalVM):
+        Modernize and implement globalVM.
+
+2014-01-25  Diego Pino Garcia  <dpino@igalia.com>
+
+        [GTK] Add parameters from 'DOM Object Model Core' spec and 'DOM CSS' spec that can be NULL
+
+        https://bugs.webkit.org/show_bug.cgi?id=117536
+
+        Reviewed by Xan Lopez.
+
+        * bindings/scripts/CodeGeneratorGObject.pm:
+        (ParamCanBeNull): Add new pairs (function, parameter) that can be NULL
+
 2014-01-25  Anders Carlsson  <andersca@apple.com>
 
         Get rid of BackForwardController::isActive()