Selection services cannot be invoked when force click is enabled
[WebKit-https.git] / Source / WebCore / ChangeLog
index fbb3f05..a018fd9 100644 (file)
@@ -1,3 +1,39 @@
+2015-06-19  Tim Horton  <timothy_horton@apple.com>
+
+        Selection services cannot be invoked when force click is enabled
+        https://bugs.webkit.org/show_bug.cgi?id=146166
+        <rdar://problem/21468362>
+
+        Reviewed by Darin Adler.
+
+        * page/mac/ServicesOverlayController.h:
+        Turn Highlight::Type into something we can use for dirty flags.
+
+        * page/mac/ServicesOverlayController.mm:
+        (WebCore::ServicesOverlayController::Highlight::createForSelection):
+        (WebCore::ServicesOverlayController::Highlight::createForTelephoneNumber):
+        (WebCore::ServicesOverlayController::ServicesOverlayController):
+        (WebCore::ServicesOverlayController::selectionRectsDidChange):
+        (WebCore::ServicesOverlayController::selectedTelephoneNumberRangesChanged):
+        (WebCore::ServicesOverlayController::invalidateHighlightsOfType):
+        (WebCore::ServicesOverlayController::buildPotentialHighlightsIfNeeded):
+        (WebCore::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown):
+        (WebCore::ServicesOverlayController::buildPhoneNumberHighlights):
+        (WebCore::ServicesOverlayController::buildSelectionHighlight):
+        (WebCore::ServicesOverlayController::findTelephoneNumberHighlightContainingSelectionHighlight):
+        (WebCore::ServicesOverlayController::determineActiveHighlight):
+        (WebCore::ServicesOverlayController::didScrollFrame):
+        (WebCore::ServicesOverlayController::handleClick):
+        Coalesce highlight rebuilding so that things (like TextIndicator creation)
+        that change the selection and then reset it immediately don't cause us
+        to lose the active highlight.
+
+        This also means that if the selection changes multiple times in a runloop
+        (easily possible from script), we won't waste a lot of time rebuilding highlights.
+
+        (WebCore::ServicesOverlayController::didRebuildPotentialHighlights):
+        Merged into buildPotentialHighlightsIfNeeded.
+
 2015-06-19  Matt Baker  <mattbaker@apple.com>
 
         Web Inspector: TimelineAgent needs to handle nested runloops