More cleanup in GIFImageReader
[WebKit-https.git] / Source / WebCore / ChangeLog
index 4c6a43e..924f6bf 100644 (file)
@@ -1,3 +1,36 @@
+2013-03-06  Alpha Lam  <hclam@chromium.org>
+
+        More cleanup in GIFImageReader
+        https://bugs.webkit.org/show_bug.cgi?id=111137
+
+        Reviewed by Stephen White.
+
+        Refactor GIFImageReaderReader with the following changes:
+        + Separate GIFLZWContext for decoding states.
+        + Replace unsigned char* with Vector<unsigned char>
+
+        There is no change in code behavior and just refactoring.
+
+        No new tests. This is covered by existing GIFImageReaderTest.
+        I also did a local testing on a 50k image corpus and showed no regression.
+
+        * platform/image-decoders/gif/GIFImageDecoder.cpp:
+        (WebCore::GIFImageDecoder::haveDecodedRow):
+        * platform/image-decoders/gif/GIFImageDecoder.h:
+        (GIFImageDecoder):
+        * platform/image-decoders/gif/GIFImageReader.cpp:
+        (GIFImageReader::outputRow):
+        (GIFImageReader::doLZW):
+        (GIFImageReader::decodeInternal):
+        (GIFImageReader::prepareLZWContext):
+        * platform/image-decoders/gif/GIFImageReader.h:
+        (GIFFrameContext):
+        (GIFFrameContext::GIFFrameContext):
+        (GIFFrameContext::~GIFFrameContext):
+        (GIFLZWContext):
+        (GIFLZWContext::GIFLZWContext):
+        (GIFImageReader):
+
 2013-03-06  Tim Horton  <timothy_horton@apple.com>
 
         Fix typo'd MainThreadScrollingBecauseOfStyleIndictaion
 2013-03-06  Tim Horton  <timothy_horton@apple.com>
 
         Fix typo'd MainThreadScrollingBecauseOfStyleIndictaion