Implementation for AXIsolatedObject::nextSibling and previousSibling.
[WebKit-https.git] / Source / WebCore / ChangeLog
index ed577aa..7484191 100644 (file)
@@ -1,3 +1,27 @@
+2020-09-19  Andres Gonzalez  <andresg_22@apple.com>
+
+        Implementation for AXIsolatedObject::nextSibling and previousSibling.
+        https://bugs.webkit.org/show_bug.cgi?id=216710
+
+        Reviewed by Chris Fleizach.
+
+        Implementation for AXIsolatedObject::previousSibling and nextSibling which
+        are invoked by VoiceOver in Safari Reader mode.
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::previousSibling const):
+        - Fixed crash caused by dereferencing m_renderer->parent() which can be null.
+        - Added check for the AXObjectCache that can become null.
+        (WebCore::AccessibilityRenderObject::nextSibling const):
+        - Code style cleanup.
+        * accessibility/isolatedtree/AXIsolatedObject.cpp:
+        (WebCore::AXIsolatedObject::initializeAttributeData):
+        - Added caching of next/previousSiblling objects.
+        (WebCore::AXIsolatedObject::previousSibling const): Inlined in header..
+        (WebCore::AXIsolatedObject::nextSibling const): Inlined in header.
+        * accessibility/isolatedtree/AXIsolatedObject.h:
+        * accessibility/isolatedtree/AXIsolatedTree.h:
+
 2020-09-19  Sam Weinig  <weinig@apple.com>
 
         Performance and PerformanceNavigation interfaces are missing toJSON operations