refactor flexbox in preparation for flex-line-pack

[WebKit-https.git] / Source / WebCore / ChangeLog

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index a7a905e..45d7a45 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,32 @@
+2012-03-22  Tony Chang  <tony@chromium.org>
+
+        refactor flexbox in preparation for flex-line-pack
+        https://bugs.webkit.org/show_bug.cgi?id=81843
+
+        Reviewed by Ojan Vafai.
+
+        Replace WrapReverseContext with a vector of LineContexts that contain
+        the same information, plus values needed for flex-align.
+
+        alignChildren has been moved to after all the lines have been
+        positioned. We want to align children after flex-line-pack has changed
+        the size of each line to avoid unnecessary layouts.
+
+        Take 2: Remove the assert. If there are no children, then there are no
+        flex lines. Instead, assert that child is not null.
+
+        No new tests, just refactoring.
+
+        * rendering/RenderFlexibleBox.cpp:
+        (WebCore::RenderFlexibleBox::LineContext::LineContext): New struct,
+        holds information needed for wrap-reverse and aligning children.
+        (RenderFlexibleBox::LineContext):
+        (WebCore::RenderFlexibleBox::layoutFlexItems): alignChildren after layout out all the lines rather than after each line.
+        (WebCore::RenderFlexibleBox::layoutAndPlaceChildren): don't alignChildren
+        (WebCore::RenderFlexibleBox::alignChildren): align all flex items, not just a line at a time.
+        (WebCore::RenderFlexibleBox::flipForWrapReverse): Update to use LineContext
+        * rendering/RenderFlexibleBox.h:
+
 2012-03-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
 
         Event dispatching in XMLHttpRequestProgressEventThrottle should go through XMLHttpRequestProgressEventThrottle::dispatchEvent