[Web Animations] Refactor cancelDeclarativeAnimationsForElement and willDestroyRender...
[WebKit-https.git] / Source / WebCore / ChangeLog
index 9cea0d7..31d4ad5 100644 (file)
@@ -1,3 +1,31 @@
+2020-03-23  Antoine Quint  <graouts@apple.com>
+
+        [Web Animations] Refactor cancelDeclarativeAnimationsForElement and willDestroyRendererForElement on AnimationTimeline
+        https://bugs.webkit.org/show_bug.cgi?id=209423
+
+        Reviewed by Antti Koivisto.
+
+        The methods cancelDeclarativeAnimationsForElement and willDestroyRendererForElement on AnimationTimeline did the same
+        thing save for the argument passed to WebAnimation::cancel(). We now refactor those two methods into a single
+        cancelDeclarativeAnimationsForElement method with an argument to set whether cancelation should be silent.
+        As a result, we also change WebAnimation::cancel() to have a single flavor instead of one without an argument and one
+        with the silent argument.
+
+        No test because there is no change in visible behavior.
+
+        * animation/AnimationTimeline.cpp:
+        (WebCore::AnimationTimeline::elementWasRemoved):
+        (WebCore::AnimationTimeline::cancelDeclarativeAnimationsForElement):
+        (WebCore::AnimationTimeline::willDestroyRendererForElement): Deleted.
+        * animation/AnimationTimeline.h:
+        * animation/DeclarativeAnimation.cpp:
+        (WebCore::DeclarativeAnimation::cancel):
+        * animation/DeclarativeAnimation.h:
+        * animation/WebAnimation.cpp:
+        * animation/WebAnimation.h:
+        * rendering/updating/RenderTreeUpdater.cpp:
+        (WebCore::RenderTreeUpdater::tearDownRenderers):
+
 2020-03-23  Youenn Fablet  <youenn@apple.com>
 
         AudioTrackPrivateMediaStream recovers from a muted track very late