REGRESSION (r225122): fePointLights don't work
[WebKit-https.git] / Source / WebCore / ChangeLog
index cff934f..23ad0dd 100644 (file)
@@ -1,3 +1,29 @@
+2017-12-30  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r225122): fePointLights don't work
+        https://bugs.webkit.org/show_bug.cgi?id=181142
+
+        Reviewed by Dan Bates.
+
+        r225122 refactored the initialLightingData code, but failed to set the lighting
+        color in the return value of PointLightSource::computePixelLightingData, so fePointLights
+        always used black.
+
+        Also fix a spelling error in initialLightingData.
+
+        Tests: svg/filters/fePointLight-color.svg
+
+        * platform/graphics/filters/DistantLightSource.cpp:
+        (WebCore::DistantLightSource::initPaintingData):
+        (WebCore::DistantLightSource::computePixelLightingData const):
+        * platform/graphics/filters/FELighting.cpp:
+        (WebCore::FELighting::drawLighting):
+        * platform/graphics/filters/LightSource.h:
+        * platform/graphics/filters/PointLightSource.cpp:
+        (WebCore::PointLightSource::computePixelLightingData const):
+        * platform/graphics/filters/SpotLightSource.cpp:
+        (WebCore::SpotLightSource::computePixelLightingData const):
+
 2017-12-31  Simon Fraser  <simon.fraser@apple.com>
 
         Bottom right pixel of feDiffuseLighting has the wrong color