2011-01-24 Kenneth Russell <kbr@google.com>
[WebKit-https.git] / Source / WebCore / ChangeLog
index f06ef70..053094c 100644 (file)
@@ -1,3 +1,863 @@
+2011-01-24  Kenneth Russell  <kbr@google.com>
+
+        Reviewed by James Robinson.
+
+        Web Audio API: port FFTFrame to FFTW
+        https://bugs.webkit.org/show_bug.cgi?id=52989
+
+        Ported FFTFrame class to the open-source FFTW library. Tested with
+        unit tests from Chris Rogers. Made preliminary changes to GYP
+        files for conditional compilation of these files; will need to be
+        adjusted once FFTW is integrated as third-party source.
+
+        * WebCore.gyp/WebCore.gyp:
+        * WebCore.gypi:
+        * platform/audio/FFTFrame.h:
+        * platform/audio/fftw: Added.
+        * platform/audio/fftw/FFTFrameFFTW.cpp: Added.
+        (WebCore::FFTFrame::FFTFrame):
+        (WebCore::FFTFrame::~FFTFrame):
+        (WebCore::FFTFrame::multiply):
+        (WebCore::FFTFrame::doFFT):
+        (WebCore::FFTFrame::doInverseFFT):
+        (WebCore::FFTFrame::cleanup):
+        (WebCore::FFTFrame::realData):
+        (WebCore::FFTFrame::imagData):
+        (WebCore::FFTFrame::fftwPlanForSize):
+
+2011-01-24  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Dan Bernstein.
+
+        Reset the page scale factor on standard frame loads
+        https://bugs.webkit.org/show_bug.cgi?id=53058
+        <rdar://problem/8908844>
+
+        Add a symbol needed by WebKit2.
+
+        * WebCore.exp.in:
+
+2011-01-24  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Stop instantiating legacy editing positions in InsertTextCommand, MoveSelectionCommand,
+        ReplaceSelectionCommand, SelectionController, SpellChecker, TypingCommand, and markup.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=52676
+
+        Stop instantiating legacy editing positions in the following files.
+
+        * editing/InsertTextCommand.cpp:
+        (WebCore::InsertTextCommand::prepareForTextInsertion):
+        (WebCore::InsertTextCommand::performTrivialReplace):
+        (WebCore::InsertTextCommand::input):
+        (WebCore::InsertTextCommand::insertTab):
+        * editing/MoveSelectionCommand.cpp:
+        (WebCore::MoveSelectionCommand::doApply):
+        * editing/ReplaceSelectionCommand.cpp:
+        (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
+        (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded):
+        (WebCore::ReplaceSelectionCommand::doApply):
+        (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR):
+        (WebCore::ReplaceSelectionCommand::performTrivialReplace):
+        * editing/SelectionController.cpp:
+        (WebCore::SelectionController::setSelectionFromNone):
+        * editing/SpellChecker.cpp:
+        (WebCore::SpellChecker::didCheck):
+        * editing/TypingCommand.cpp:
+        (WebCore::TypingCommand::makeEditableRootEmpty):
+        (WebCore::TypingCommand::deleteKeyPressed):
+        (WebCore::TypingCommand::forwardDeleteKeyPressed):
+        * editing/markup.cpp:
+        (WebCore::StyledMarkupAccumulator::appendText):
+        (WebCore::StyledMarkupAccumulator::serializeNodes):
+        (WebCore::highestAncestorToWrapMarkup):
+        (WebCore::createMarkup):
+
+2011-01-24  Peter Kasting  <pkasting@google.com>
+
+        Reviewed by Darin Adler.
+
+        Roll back r67261 ("Don't fire onclick on middle clicks") due to
+        regressions.
+        https://bugs.webkit.org/show_bug.cgi?id=46733
+
+        * html/HTMLAnchorElement.cpp:
+        (WebCore::isLinkClick):
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::preDispatchEventHandler):
+        (WebCore::HTMLInputElement::postDispatchEventHandler):
+        (WebCore::HTMLInputElement::defaultEventHandler):
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::handleMouseDoubleClickEvent):
+        (WebCore::EventHandler::handleMouseReleaseEvent):
+
+2011-01-24  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Eric Seidel.
+
+        [GTK] Many DOM XHTML tests time out
+        https://bugs.webkit.org/show_bug.cgi?id=52553
+
+        Properly handle the situation where a synchronous load fails before the inner
+        event loop has started. In this case, we simply do not run the inner event loop,
+        or else it will block indefinitely (since no GIO or libsoup callbacks will fire).
+
+        * platform/network/soup/ResourceHandleSoup.cpp:
+        (WebCore::ResourceHandle::loadResourceSynchronously): Bail out of a synchronous
+        load if it fails up front.
+
+2011-01-24  Zhenyao Mo  <zmo@google.com>
+
+        Reviewed by Darin Adler.
+
+        Remove sizeInBytes from GraphicsContext3D's various implementations
+        https://bugs.webkit.org/show_bug.cgi?id=52339
+
+        * html/canvas/WebGLRenderingContext.cpp:
+        (WebCore::WebGLRenderingContext::sizeInBytes):
+        * platform/graphics/GraphicsContext3D.h:
+        * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
+        * platform/graphics/qt/GraphicsContext3DQt.cpp:
+
+2011-01-24  Adam Roben  <aroben@apple.com>
+
+        Windows Production build fix
+
+        * WebCore.vcproj/WebCore.make: Update for move of WebCore into Source.
+
+2011-01-24  Anton Muhin  <antonm@chromium.org>
+
+        Reviewed by Nate Chapin.
+
+        [v8] Refactoring: extract IntrusiveDOMWrapperMap into a seprate class and files.
+        https://bugs.webkit.org/show_bug.cgi?id=52911
+
+        Plain refactoring, covered by the existing tests.
+
+        * WebCore.gypi: IntrusiveDOMWrapperMap.h added.
+        * bindings/v8/DOMDataStore.cpp: IntrusiveDOMWrapperMap is moved out of DOMDataStore class.
+        * bindings/v8/DOMDataStore.h: IntrusiveDOMWrapperMap is moved out of DOMDataStore class.
+        * bindings/v8/IntrusiveDOMWrapperMap.h: Added.
+        (WebCore::ChunkedTable::ChunkedTable):
+        (WebCore::ChunkedTable::add):
+        (WebCore::ChunkedTable::remove):
+        (WebCore::ChunkedTable::clear):
+        (WebCore::ChunkedTable::visit):
+        (WebCore::ChunkedTable::Chunk::Chunk):
+        (WebCore::ChunkedTable::clearEntries):
+        (WebCore::ChunkedTable::visitEntries):
+        (WebCore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap):
+        (WebCore::IntrusiveDOMWrapperMap::get):
+        (WebCore::IntrusiveDOMWrapperMap::set):
+        (WebCore::IntrusiveDOMWrapperMap::contains):
+        (WebCore::IntrusiveDOMWrapperMap::visit):
+        (WebCore::IntrusiveDOMWrapperMap::removeIfPresent):
+        (WebCore::IntrusiveDOMWrapperMap::clear):
+        (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::move):
+        (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear):
+        (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::visit):
+        * bindings/v8/StaticDOMDataStore.h: include added.
+
+2011-01-24  Shane Stephens  <shanestephens@google.com>
+
+        Reviewed by Chris Marrin.
+
+        TransformationMatrix multiply operations apply operands in wrong order.
+        https://bugs.webkit.org/show_bug.cgi?id=52780
+
+        Rename TranformationMatrix::multLeft into multiply (the method does a multRight,
+        not a multLeft).
+
+        Remove TransformationMatrix::multiply, which was actually doing a multLeft.
+
+        Fix TransformationMatrix::operator* and operator*= such that the operand is
+        applied to the right-hand side of the matrix that the method is called on.
+        i.e., previously "a * b" used to compute "b * a", and "a *= b" used to store
+        "b * a" in "a".  This has now been fixed so "a * b" computes "a * b" and
+        "a *= b" stores "a * b" in "a".
+
+        Convert all call sites for these methods to provide operands in the correct order.
+
+        No new tests as patch adds no new functionality.
+
+        * css/WebKitCSSMatrix.cpp:
+        (WebCore::WebKitCSSMatrix::multiply):
+        * platform/graphics/transforms/Matrix3DTransformOperation.h:
+        (WebCore::Matrix3DTransformOperation::apply):
+        * platform/graphics/transforms/MatrixTransformOperation.h:
+        (WebCore::MatrixTransformOperation::apply):
+        * platform/graphics/transforms/TransformationMatrix.cpp:
+        (WebCore::TransformationMatrix::scaleNonUniform):
+        (WebCore::TransformationMatrix::scale3d):
+        (WebCore::TransformationMatrix::rotate3d):
+        (WebCore::TransformationMatrix::skew):
+        (WebCore::TransformationMatrix::applyPerspective):
+        (WebCore::TransformationMatrix::multiply):
+        (WebCore::TransformationMatrix::recompose):
+        * platform/graphics/transforms/TransformationMatrix.h:
+        (WebCore::TransformationMatrix::operator*=):
+        (WebCore::TransformationMatrix::operator*):
+        * rendering/RenderLayer.cpp:
+        (WebCore::transparencyClipBox):
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::getTransformFromContainer):
+        * rendering/TransformState.cpp:
+        (WebCore::TransformState::applyTransform):
+        (WebCore::HitTestingTransformState::applyTransform):
+
+2011-01-24  Andrei Popescu  <andreip@google.com>
+
+        Reviewed by Nate Chapin.
+
+        IndexedDatabase methods should not take arguments of type OptionsObject
+        https://bugs.webkit.org/show_bug.cgi?id=53012
+
+        This patch reverts all IDB methods, except IDBDatabase::createObjectStore and
+        IDBObjectStore::createIndex, to using a plain list of arguments instead of
+        grouping the various parameters inside a single OptionsObject argument.
+        This decision was made on public-webapps@w3.org mailing list.
+
+        We also add support (v8 only for now) for passing DOMStringList objects as arguments to native
+        methods. The code for obtaining a DOMStringList object from a JS array of strings existed already
+        in OptionsObject.cpp, I just copied it to V8Bindings.cpp and taught the v8 code generator how to
+        use it.
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+        * bindings/v8/V8Binding.cpp:
+        (WebCore::v8ValueToWebCoreDOMStringList):
+        * bindings/v8/V8Binding.h:
+        * storage/IDBDatabase.cpp:
+        (WebCore::IDBDatabase::transaction):
+        * storage/IDBDatabase.h:
+        (WebCore::IDBDatabase::transaction):
+        * storage/IDBDatabase.idl:
+        * storage/IDBIndex.cpp:
+        (WebCore::IDBIndex::openCursor):
+        (WebCore::IDBIndex::openKeyCursor):
+        * storage/IDBIndex.h:
+        (WebCore::IDBIndex::openCursor):
+        (WebCore::IDBIndex::openKeyCursor):
+        * storage/IDBIndex.idl:
+        * storage/IDBObjectStore.cpp:
+        (WebCore::IDBObjectStore::openCursor):
+        * storage/IDBObjectStore.h:
+        (WebCore::IDBObjectStore::openCursor):
+        * storage/IDBObjectStore.idl:
+
+2011-01-24  Pavel Feldman  <pfeldman@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: extract dispatch API from network manager.
+        https://bugs.webkit.org/show_bug.cgi?id=53009
+
+        * WebCore.xcodeproj/project.pbxproj:
+        * inspector/front-end/NetworkManager.js:
+        (WebInspector.NetworkManager):
+        (WebInspector.NetworkManager.prototype.reset):
+        (WebInspector.NetworkManager.prototype.requestContent):
+        (WebInspector.NetworkManager.prototype._processCachedResources):
+        (WebInspector.NetworkDispatcher):
+        (WebInspector.NetworkDispatcher.prototype._updateResourceWithRequest):
+        (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
+        (WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource):
+        (WebInspector.NetworkDispatcher.prototype.identifierForInitialRequest):
+        (WebInspector.NetworkDispatcher.prototype.willSendRequest):
+        (WebInspector.NetworkDispatcher.prototype.didReceiveResponse):
+        (WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache):
+        (WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame):
+        (WebInspector.NetworkDispatcher.prototype.didCreateWebSocket):
+        (WebInspector.NetworkDispatcher.prototype._appendRedirect):
+        (WebInspector.NetworkDispatcher.prototype._startResource):
+        (WebInspector.NetworkDispatcher.prototype._updateResource):
+        (WebInspector.NetworkDispatcher.prototype._finishResource):
+        (WebInspector.NetworkDispatcher.prototype._addFramesRecursively):
+        (WebInspector.NetworkDispatcher.prototype._dispatchEventToListeners):
+        (WebInspector.NetworkDispatcher.prototype._createResource):
+        * inspector/front-end/Resource.js:
+        (WebInspector.Resource.prototype._innerRequestContent):
+        * inspector/front-end/ResourceTreeModel.js:
+        (WebInspector.ResourceTreeModel):
+        (WebInspector.ResourceTreeModel.prototype.reset):
+        (WebInspector.ResourceTreeModel.prototype.unbindResourceURL):
+
+2011-01-24  Yury Semikhatsky  <yurys@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: [JSC] remove ScriptDebugServer::pageCreated
+        https://bugs.webkit.org/show_bug.cgi?id=53007
+
+        It's impossible to create "provisional" inspector for pages which are
+        not yet created so there is no need to listen for page creation in ScriptDebugServer.
+
+        * bindings/js/ScriptDebugServer.cpp:
+        * bindings/js/ScriptDebugServer.h:
+        * page/Page.cpp:
+        (WebCore::Page::Page):
+
+2011-01-24  Pavel Podivilov  <podivilov@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: [REGRESSION] AppCache view on resources panel is broken.
+        https://bugs.webkit.org/show_bug.cgi?id=53002
+
+
+        * inspector/front-end/ApplicationCacheItemsView.js:
+        (WebInspector.ApplicationCacheItemsView.prototype._update):
+        * inspector/front-end/DOMAgent.js:
+        (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
+
+2011-01-24  Andreas Kling  <kling@webkit.org>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Qt] Fix warnings about unregistering an invalid timer
+        https://bugs.webkit.org/show_bug.cgi?id=53006
+
+        The ShadowBuffer's purge timer ID was initialized with 0 which lead
+        to us calling QObject::killTimer(0), causing some qWarnings.
+
+        * platform/graphics/qt/ContextShadowQt.cpp:
+        (WebCore::ShadowBuffer::ShadowBuffer):
+        (WebCore::ShadowBuffer::schedulePurge):
+
+2011-01-21  Mikhail Naganov  <mnaganov@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: [Chromium] Fix heap snapshot table sorting.
+
+        Fix table sorting to avoid qsort instability artefacts.
+
+        https://bugs.webkit.org/show_bug.cgi?id=52914
+
+        * inspector/front-end/HeapSnapshotView.js:
+        (WebInspector.HeapSnapshotView.prototype._sortData):
+        (WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator):
+        (WebInspector.HeapSnapshotDataGridList.propertyComparator):
+
+2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: Find duplicate strings in localizedStrings.js, update it.
+
+        https://bugs.webkit.org/show_bug.cgi?id=53005
+
+        * English.lproj/localizedStrings.js:
+
+2011-01-24  Pavel Podivilov  <podivilov@chromium.org>
+
+        Unreviewed, build fix  for r76509.
+
+        * inspector/InspectorDebuggerAgent.cpp:
+        (WebCore::InspectorDebuggerAgent::setBreakpoint):
+
+2011-01-24  Pavel Podivilov  <podivilov@chromium.org>
+
+        Unreviewed, build fix  for r76509.
+
+        * bindings/js/ScriptDebugServer.h:
+
+2011-01-24  Pavel Podivilov  <podivilov@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: set breakpoints by line:column.
+        https://bugs.webkit.org/show_bug.cgi?id=52615
+
+        * CMakeLists.txt:
+        * GNUmakefile.am:
+        * WebCore.gypi:
+        * WebCore.pro:
+        * WebCore.vcproj/WebCore.vcproj:
+        * WebCore.xcodeproj/project.pbxproj:
+        * bindings/js/ScriptDebugServer.cpp:
+        (WebCore::ScriptDebugServer::setBreakpoint):
+        (WebCore::ScriptDebugServer::removeBreakpoint):
+        (WebCore::ScriptDebugServer::hasBreakpoint):
+        (WebCore::ScriptDebugServer::clearBreakpoints):
+        * bindings/js/ScriptDebugServer.h:
+        * bindings/v8/DebuggerScript.js:
+        ():
+        * bindings/v8/ScriptDebugServer.cpp:
+        (WebCore::ScriptDebugServer::setBreakpoint):
+        * bindings/v8/ScriptDebugServer.h:
+        * inspector/Inspector.idl:
+        * inspector/InspectorBrowserDebuggerAgent.cpp:
+        (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
+        * inspector/InspectorDebuggerAgent.cpp:
+        (WebCore::InspectorDebuggerAgent::setStickyBreakpoint):
+        (WebCore::InspectorDebuggerAgent::setBreakpoint):
+        (WebCore::InspectorDebuggerAgent::restoreBreakpoint):
+        (WebCore::InspectorDebuggerAgent::didParseSource):
+        * inspector/InspectorDebuggerAgent.h:
+        * inspector/ScriptBreakpoint.cpp: Removed.
+        * inspector/ScriptBreakpoint.h:
+        (WebCore::ScriptBreakpoint::ScriptBreakpoint):
+        * inspector/front-end/Breakpoint.js:
+        (WebInspector.Breakpoint):
+        (WebInspector.Breakpoint.prototype.get url):
+        * inspector/front-end/BreakpointManager.js:
+        (WebInspector.JavaScriptBreakpoint.prototype._serializeToJSON):
+        * inspector/front-end/DebuggerModel.js:
+        (WebInspector.DebuggerModel.prototype.continueToLine):
+        (WebInspector.DebuggerModel.prototype.setBreakpoint):
+        (WebInspector.DebuggerModel.prototype._breakpointSetOnBackend):
+        (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
+
+2011-01-24  Peter Beverloo  <peter@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: recognize application/x-font-woff as a valid mime-type.
+        https://bugs.webkit.org/show_bug.cgi?id=52977
+
+        No new tests.
+
+        * inspector/front-end/inspector.js:
+
+2011-01-24  Pavel Podivilov  <podivilov@chromium.org>
+
+        Unreviewed, fix for r76497.
+
+        * inspector/front-end/ResourcesPanel.js:
+        (WebInspector.ResourcesPanel.prototype.show):
+
+2011-01-24  Andreas Kling  <kling@webkit.org>
+
+        Reviewed by Tor Arne Vestbø.
+
+        [Qt] Use rad2deg() from WTF instead of rolling our own.
+        https://bugs.webkit.org/show_bug.cgi?id=52993
+
+        * platform/graphics/qt/GraphicsContextQt.cpp:
+        (WebCore::GraphicsContext::rotate):
+        * platform/graphics/qt/PathQt.cpp:
+        (WebCore::Path::addArc):
+
+2011-01-24  Sergio Villar Senin  <svillar@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [Gtk] ResourceHandleSoup: do not wait for streams to close to issue didFinishLoading
+        https://bugs.webkit.org/show_bug.cgi?id=52885
+
+        No new tests as it does not change functionality. We will not wait for
+        the the input stream to close to issue didFinishLoading to
+        WebCore. We expect a subtle performance improvement with this
+        patch when loading complex web pages, as we wouldn't have to wait
+        for the stream to close (which involves creating a thread among
+        other things).
+
+        * platform/network/soup/ResourceHandleSoup.cpp:
+        (WebCore::closeCallback):
+        (WebCore::readCallback):
+
+2011-01-21  Pavel Podivilov  <podivilov@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: eliminate SourceView and ScriptView classes.
+        https://bugs.webkit.org/show_bug.cgi?id=52896
+
+        SourceView and ScriptView delegate everything to SourceFrame and should be eliminated.
+
+        * WebCore.gypi:
+        * WebCore.vcproj/WebCore.vcproj:
+        * inspector/front-end/GoToLineDialog.js:
+        (WebInspector.GoToLineDialog.prototype._highlightSelectedLine):
+        * inspector/front-end/ResourceView.js:
+        (WebInspector.ResourceView.createResourceView):
+        (WebInspector.ResourceView.resourceViewTypeMatchesResource):
+        (WebInspector.SourceFrameContentProviderForResource):  Moved from SourceView.
+        * inspector/front-end/ResourcesPanel.js:
+        (WebInspector.ResourcesPanel.prototype.show):
+        (WebInspector.ResourcesPanel.prototype._applyDiffMarkup):
+        (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
+        * inspector/front-end/ScriptView.js: Removed.
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
+        (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource):
+        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
+        (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
+        (WebInspector.ScriptsPanel.prototype._formatScript):
+        (WebInspector.SourceFrameContentProviderForScript): Moved from ScriptView.
+        * inspector/front-end/SourceFrame.js:
+        (WebInspector.SourceFrame):
+        (WebInspector.SourceFrame.prototype.show):
+        (WebInspector.SourceFrame.prototype.hide):
+        (WebInspector.SourceFrame.prototype.hasContent):
+        (WebInspector.SourceFrame.prototype._createTextViewer):
+        (WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
+        (WebInspector.SourceFrame.prototype.performSearch):
+        * inspector/front-end/SourceView.js: Removed.
+        * inspector/front-end/WebKit.qrc:
+        * inspector/front-end/inspector.html:
+
+2011-01-24  Andras Becsi  <abecsi@webkit.org>
+
+        Reviewed by Csaba Osztrogonác.
+
+        [Qt] Move project files into Source
+        https://bugs.webkit.org/show_bug.cgi?id=52891
+
+        No new tests needed.
+
+        * WebCore.pri:
+        * WebCore.pro:
+
+2011-01-24  Kent Tamura  <tkent@chromium.org>
+
+        Unreviewed, trivial fix.
+
+        Fix a Chromium-only assertion failure by r76491.
+        https://bugs.webkit.org/show_bug.cgi?id=38982
+
+        Separate icon loading from the FileChooser constructor in order to avoid
+        ref() before adoptRef().
+
+        * platform/FileChooser.cpp:
+        (WebCore::FileChooser::FileChooser):
+        (WebCore::FileChooser::initialize):
+        (WebCore::FileChooser::create):
+        * platform/FileChooser.h:
+
+2011-01-24  MORITA Hajime  <morrita@google.com>
+
+        Reviewed by Kent Tamura.
+
+        TextControlInnerElement::m_shadowParent should be removed.
+        https://bugs.webkit.org/show_bug.cgi?id=52998
+
+        No new tests. No behavioral change.
+
+        * rendering/TextControlInnerElements.cpp:
+        (WebCore::TextControlInnerElement::TextControlInnerElement):
+        * rendering/TextControlInnerElements.h:
+
+2011-01-24  Yury Semikhatsky  <yurys@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        REGRESSION (r72895): console.trace crashes
+        https://bugs.webkit.org/show_bug.cgi?id=52981
+
+        - Use local RefPtr variable for accessing PassRefPtr arguments to make sure the PassRefPtr has
+        non-null value.
+        - Use PassRefPtr for objects whos ownership is passed to the inspector.
+
+        * GNUmakefile.am:
+        * WebCore.gypi:
+        * WebCore.pro:
+        * WebCore.vcproj/WebCore.vcproj:
+        * WebCore.xcodeproj/project.pbxproj:
+        * inspector/InspectorConsoleInstrumentation.h: Added. Extract inline methods called from the console into their
+        own header to reduce compilation time of other classes that depend on the inspector instrumentation.
+        (WebCore::InspectorInstrumentation::addMessageToConsole):
+        (WebCore::InspectorInstrumentation::consoleCount):
+        (WebCore::InspectorInstrumentation::startConsoleTiming):
+        (WebCore::InspectorInstrumentation::stopConsoleTiming):
+        (WebCore::InspectorInstrumentation::consoleMarkTimeline):
+        (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
+        (WebCore::InspectorInstrumentation::addProfile):
+        (WebCore::InspectorInstrumentation::profilerEnabled):
+        (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
+        * inspector/InspectorDatabaseInstrumentation.h: Added. Extract inline methods called from the datanase code into their
+        own header to reduce compilation time of other classes that depend on the inspector instrumentation.
+        (WebCore::InspectorInstrumentation::didOpenDatabase):
+        * inspector/InspectorInstrumentation.cpp:
+        (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
+        (WebCore::InspectorInstrumentation::consoleCountImpl):
+        (WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
+        (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl):
+        (WebCore::InspectorInstrumentation::addProfileImpl):
+        (WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
+        * inspector/InspectorInstrumentation.h:
+        * page/Console.cpp: use RefPtr local variable instead of accessing PassRefPtr argument directly.
+        (WebCore::Console::addMessage):
+        (WebCore::Console::trace):
+        (WebCore::Console::count):
+        (WebCore::Console::markTimeline):
+        (WebCore::Console::profileEnd):
+        (WebCore::Console::timeEnd):
+        (WebCore::Console::group):
+        (WebCore::Console::groupCollapsed):
+        * storage/Database.cpp:
+        (WebCore::Database::openDatabase):
+
+2010-01-24  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        [Chromium] Support icon loading for <input type=file>
+        https://bugs.webkit.org/show_bug.cgi?id=38982
+
+        An icon data in Chromium port is represented as WebCore::Image. We
+        don't need OS-specific code anymore.
+
+        * WebCore.gypi:
+        * platform/graphics/Icon.h:
+        (WebCore::Icon::create): Add Chromium-specific factory.
+        * platform/graphics/chromium/IconChromium.cpp: Added.
+        * platform/graphics/chromium/IconChromiumLinux.cpp: Removed.
+        * platform/graphics/chromium/IconChromiumMac.cpp: Removed.
+        * platform/graphics/chromium/IconChromiumWin.cpp: Removed.
+        * platform/graphics/chromium/PlatformIcon.h:
+
+2011-01-21  Pavel Podivilov  <podivilov@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: move search functions from SourceView to SourceFrame.
+        https://bugs.webkit.org/show_bug.cgi?id=52895
+
+        This is the last step before eliminating SourceView and ScriptView since
+        this classes just delegate everything to SourceFrame.
+
+        * inspector/front-end/SourceFrame.js:
+        (WebInspector.SourceFrame.prototype.set visible):
+        (WebInspector.SourceFrame.prototype._clearLineHighlight):
+        (WebInspector.SourceFrame.prototype._createTextViewer):
+        (WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
+        (WebInspector.SourceFrame.prototype.performSearch):
+        (WebInspector.SourceFrame.prototype.searchCanceled):
+        (WebInspector.SourceFrame.prototype.jumpToFirstSearchResult):
+        (WebInspector.SourceFrame.prototype.jumpToLastSearchResult):
+        (WebInspector.SourceFrame.prototype.jumpToNextSearchResult):
+        (WebInspector.SourceFrame.prototype.jumpToPreviousSearchResult):
+        (WebInspector.SourceFrame.prototype.showingFirstSearchResult):
+        (WebInspector.SourceFrame.prototype.showingLastSearchResult):
+        (WebInspector.SourceFrame.prototype._jumpToSearchResult):
+        * inspector/front-end/SourceView.js:
+        (WebInspector.SourceView.prototype.hide):
+        (WebInspector.SourceView.prototype.searchCanceled):
+        (WebInspector.SourceView.prototype.performSearch):
+        (WebInspector.SourceView.prototype.jumpToFirstSearchResult):
+        (WebInspector.SourceView.prototype.jumpToLastSearchResult):
+        (WebInspector.SourceView.prototype.jumpToNextSearchResult):
+        (WebInspector.SourceView.prototype.jumpToPreviousSearchResult):
+        (WebInspector.SourceView.prototype.showingFirstSearchResult):
+        (WebInspector.SourceView.prototype.showingLastSearchResult):
+        (WebInspector.SourceView.prototype.clearMessages):
+
+2011-01-24  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r76463.
+        http://trac.webkit.org/changeset/76463
+        https://bugs.webkit.org/show_bug.cgi?id=52993
+
+        It broke canvas/philip/tests/2d.path.stroke.skew.html
+        (Requested by Ossy on #webkit).
+
+        * platform/graphics/qt/GraphicsContextQt.cpp:
+        (WebCore::GraphicsContext::rotate):
+        * platform/graphics/qt/PathQt.cpp:
+        (WebCore::Path::addArc):
+
+2011-01-23  Andrey Kosyakov  <caseq@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: summary bar is not resized properly with the rest of network panel
+        https://bugs.webkit.org/show_bug.cgi?id=52881
+
+        * inspector/front-end/NetworkPanel.js:
+        (WebInspector.NetworkPanel.prototype.updateSidebarWidth):
+        (WebInspector.NetworkPanel.prototype._positionSummaryBar):
+        (WebInspector.NetworkPanel.prototype._toggleGridMode):
+
+2011-01-19  MORITA Hajime  <morrita@google.com>
+
+        Reviewed by Ryosuke Niwa.
+
+        Space and tab characters "sent" by an input method give totally different results than typing them directly
+        https://bugs.webkit.org/show_bug.cgi?id=5241
+        
+        * Introduced TextEvent::InputTypeComposition and TypingCommand::TextCompositionType to 
+          distinguish text input which is originated by composition.
+        * Generalized rebalanceWhitespaceAt() to rebalanceWhitespaceOnTextSubstring() to rebalancing 
+          range of string on text node, instead of surrounding part of that.
+
+        Test: editing/inserting/insert-composition-whitespace.html
+
+        * dom/TextEvent.h:
+        (WebCore::TextEvent::isComposition):
+        * dom/TextEventInputType.h: Added TextEventInputComposition as a member of TextEvent::InputType
+        * editing/CompositeEditCommand.cpp:
+        (WebCore::containsOnlyWhitespace):
+        (WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor):
+        (WebCore::CompositeEditCommand::canRebalance):
+        (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
+        (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Added: A generalized version of rebalanceWhitespaceAt(), which takes a range inside Text string.
+        * editing/CompositeEditCommand.h:
+        * editing/Editor.cpp:
+        (WebCore::Editor::insertTextForConfirmedComposition): Added.
+        (WebCore::Editor::insertTextWithoutSendingTextEvent):
+        (WebCore::Editor::confirmComposition): Now uses insertTextForConfirmedComposition().
+        (WebCore::Editor::setComposition):
+        * editing/Editor.h:
+        * editing/InsertTextCommand.cpp:
+        (WebCore::InsertTextCommand::input):
+        * editing/InsertTextCommand.h:
+        * editing/TypingCommand.cpp:
+        (WebCore::TypingCommand::TypingCommand):
+        (WebCore::TypingCommand::insertText):
+        (WebCore::TypingCommand::insertTextRunWithoutNewlines):
+        * editing/TypingCommand.h: Added TypingCommand::m_compositionType and TypingCommand::TextCompositionType
+        (WebCore::TypingCommand::setCompositionType): Added.
+        (WebCore::TypingCommand::create):
+
+2011-01-23  Mark Rowe  <mrowe@apple.com>
+
+        Follow-up to r76477.
+
+        Fix the scripts that detect problematic code such as static initializers
+        and destructors, weak vtables, inappropriate files in the framework wrappers,
+        and public headers including private headers. These had all been broken
+        since the projects were moved in to the Source directory as the paths to the
+        scripts were not updated at that time.
+
+        Stop copying an IDL file in to the framework wrapper. Doing that doesn't even make sense.
+
+        * WebCore.xcodeproj/project.pbxproj:
+
+2011-01-23  Mark Rowe  <mrowe@apple.com>
+
+        Build fix after r76459.
+
+        Static member variables or globals of types that have constructors or destructors are bad as
+        they generate static initializers and destructors. This is code that is run either at link time
+        when the library is loaded in to memory or at application termination time. Both of these are
+        terrible for performance and are thus outlawed in WebKit code.
+
+        The typical solution is to replace the static member or global with a function that allocates
+        the necessary variable on the heap. The variable is leaked to prevent it from being destroyed
+        at application termination time. The DEFINE_STATIC_LOCAL macro wraps this in to a concise little
+        package, but sadly fails to work in this case due to the type containing multiple template
+        parameters.
+        
+        * inspector/InspectorInstrumentation.cpp:
+        (WebCore::InspectorInstrumentation::inspectorAgents):
+        * inspector/InspectorInstrumentation.h:
+        (WebCore::InspectorInstrumentation::bindInspectorAgent):
+        (WebCore::InspectorInstrumentation::unbindInspectorAgent):
+        (WebCore::InspectorInstrumentation::inspectorAgentForPage):
+
+2011-01-21  Vangelis Kokkevis  <vangelis@chromium.org>
+
+        Reviewed by Kenneth Russell.
+
+        [chromium] Add support for -webkit-mask properties to the
+        accelerated compositing path.
+        https://bugs.webkit.org/show_bug.cgi?id=49780
+         
+        Tests: Existing tests in LayoutTests/compositing/masks
+
+        * platform/graphics/chromium/ContentLayerChromium.cpp:
+        (WebCore::ContentLayerChromium::draw):
+        (WebCore::ContentLayerChromium::unreserveContentsTexture):
+        (WebCore::ContentLayerChromium::bindContentsTexture):
+        * platform/graphics/chromium/ContentLayerChromium.h:
+        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
+        (WebCore::GraphicsLayerChromium::setMaskLayer):
+        * platform/graphics/chromium/GraphicsLayerChromium.h:
+        * platform/graphics/chromium/LayerChromium.cpp:
+        (WebCore::LayerChromium::LayerChromium):
+        * platform/graphics/chromium/LayerChromium.h:
+        (WebCore::LayerChromium::setMaskLayer):
+        (WebCore::LayerChromium::maskLayer):
+        (WebCore::LayerChromium::unreserveContentsTexture):
+        (WebCore::LayerChromium::bindContentsTexture):
+        * platform/graphics/chromium/LayerRendererChromium.cpp:
+        (WebCore::LayerRendererChromium::updateLayersRecursive):
+        * platform/graphics/chromium/LayerTexture.cpp:
+        (WebCore::LayerTexture::bindTexture):
+        * platform/graphics/chromium/RenderSurfaceChromium.cpp:
+        (WebCore::RenderSurfaceChromium::SharedValues::SharedValues):
+        (WebCore::RenderSurfaceChromium::SharedValues::~SharedValues):
+        (WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
+        (WebCore::RenderSurfaceChromium::draw):
+        * platform/graphics/chromium/RenderSurfaceChromium.h:
+        (WebCore::RenderSurfaceChromium::SharedValues::maskShaderProgram):
+        (WebCore::RenderSurfaceChromium::SharedValues::maskShaderSamplerLocation):
+        (WebCore::RenderSurfaceChromium::SharedValues::maskShaderMaskSamplerLocation):
+        (WebCore::RenderSurfaceChromium::SharedValues::maskShaderMatrixLocation):
+        (WebCore::RenderSurfaceChromium::SharedValues::maskShaderAlphaLocation):
+
+2011-01-23  Patrick Gansterer  <paroga@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Use WTF::StringHasher in WebCore
+        https://bugs.webkit.org/show_bug.cgi?id=52934
+
+        * loader/appcache/ApplicationCacheStorage.cpp:
+        (WebCore::urlHostHash):
+        * platform/LinkHash.cpp:
+        (WebCore::visitedLinkHashInline):
+        * platform/cf/BinaryPropertyList.cpp:
+        (WebCore::IntegerArrayHash::hash):
+        * platform/graphics/wx/FontPlatformDataWx.cpp:
+        (WebCore::FontPlatformData::computeHash):
+        * platform/network/ProtectionSpaceHash.h:
+        (WebCore::ProtectionSpaceHash::hash):
+
+2011-01-23  Patrick Gansterer  <paroga@webkit.org>
+
+        Reviewed by David Kilzer.
+
+        Add an overload to base64Encode with String output
+        https://bugs.webkit.org/show_bug.cgi?id=50122
+
+        This change removes duplicated code.
+
+        * inspector/InspectorResourceAgent.cpp:
+        (WebCore::InspectorResourceAgent::resourceContentBase64):
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::btoa):
+        * platform/graphics/skia/FontCustomPlatformData.cpp:
+        (WebCore::createUniqueFontName):
+        * platform/graphics/win/FontCustomPlatformData.cpp:
+        (WebCore::createUniqueFontName):
+        * platform/graphics/wince/FontCustomPlatformData.cpp:
+        (WebCore::createUniqueFontName):
+        * platform/network/cf/ResourceHandleCFNet.cpp:
+        (WebCore::encodeBasicAuthorization):
+        * platform/network/mac/ResourceHandleMac.mm:
+        (WebCore::encodeBasicAuthorization):
+        * platform/text/Base64.cpp:
+        (WebCore::base64Encode):
+        * platform/text/Base64.h:
+        (WebCore::base64Encode):
+        * platform/wince/KeygenWinCE.cpp:
+        (WebCore::WebCore::signedPublicKeyAndChallengeString):
+
+2011-01-23  Patrick Gansterer  <paroga@webkit.org>
+
+        Reviewed by David Kilzer.
+
+        Add String::containsOnlyLatin1()
+        https://bugs.webkit.org/show_bug.cgi?id=52979
+
+        Use String::containsOnlyLatin1() instead of isSafeToConvertCharList().
+
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::btoa):
+        (WebCore::DOMWindow::atob):
+
+2011-01-23  Patrick Gansterer  <paroga@webkit.org>
+
+        Reviewed by Andreas Kling.
+
+        [CMake] Add missing CodeGenerator dependencies
+        https://bugs.webkit.org/show_bug.cgi?id=52976
+
+        * CMakeLists.txt:
+
 2011-01-23  Yael Aharon  <yael.aharon@nokia.com>
 
         Reviewed by Kenneth Rohde Christiansen.