Web Inspector: Timelines: can't reliably stop/start a recording
[WebKit-https.git] / LayoutTests / ChangeLog
index 73e7764..4ca18b0 100644 (file)
@@ -1,3 +1,397 @@
+2019-04-11  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Timelines: can't reliably stop/start a recording
+        https://bugs.webkit.org/show_bug.cgi?id=196778
+        <rdar://problem/47606798>
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/timeline/debugger-paused-while-recording.html:
+        * inspector/timeline/exception-in-injected-script-while-recording.html:
+        * inspector/timeline/line-column.html:
+        * inspector/timeline/recording-start-stop-timestamps.html:
+        * inspector/timeline/resources/timeline-event-utilities.js:
+        * inspector/timeline/setInstruments-programmatic-capture.html:
+        * inspector/timeline/setInstruments-programmatic-capture-expected.txt:
+        * inspector/timeline/timeline-recording.html:
+
+2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Layout test accessibility/aria-hidden-false-works-in-subtrees.html fails after r184890
+        https://bugs.webkit.org/show_bug.cgi?id=146718
+        <rdar://problem/21722487>
+
+        Reviewed by Joanmarie Diggs.
+
+        Update test to ATK behavior, rebaseline it and remove the expectations.
+
+        * accessibility/aria-hidden-false-works-in-subtrees.html:
+        * platform/gtk/TestExpectations:
+        * platform/gtk/accessibility/aria-hidden-false-works-in-subtrees-expected.txt:
+
+2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        requestAnimationFrame should execute before the next frame
+        https://bugs.webkit.org/show_bug.cgi?id=177484
+
+        Reviewed by Simon Fraser.
+
+        * TestExpectations:
+        There is a slight difference between the actual DRT and the expected DRT
+        due to animation timing change. But these two tests are not animating
+        correctly if they are opened in Safari with web animation turned on. 
+
+        * accessibility/mac/selection-notification-focus-change-expected.txt:
+        * accessibility/mac/selection-notification-focus-change.html:
+        Remove the debug statements form notificationCallback() since the number
+        of times this function is called back and the order of notifications are
+        not defined. This test has been flaky and some trials were made to make 
+        it more reliable. With this change it became flaky again.
+
+        * animations/animation-multiple-callbacks-timestamp.html:
+        Fix variable names used by an error message.
+
+        * animations/no-style-recalc-during-accelerated-animation-expected.txt:
+        * animations/no-style-recalc-during-accelerated-animation.html:
+        One extra styleReclc was incurred due to the document styleRecalcTimer.
+        I think this timer is not needed anymore. I will look at removing it in
+        a separate patch.
+
+        * animations/resources/animation-test-helpers.js:
+        (waitForAnimationToStart):
+        The expectation that animation will start at the beginning of the next 
+        event loop is not true anymore. The animation will start at the time the
+        requestAnimationFrame fires.
+
+        * compositing/video/video-clip-change-src.html:
+        This test loads a video data and pushes it to the encoder. Originally it
+        used to wait 150 ms after receiving the second canplaythrough. I had to 
+        change this timing to 250 ms.
+
+        * css3/filters/composited-during-animation.html:
+        Ditto. setTimeout({...}, 0) versus requestAnimationFrame.
+
+        * media/media-controls-accessibility.html:
+        Updating the accessibility button happens asynchronously, see 
+        [WebAccessibilityObjectWrapper accessibilityPerformPressAction]. Due to
+        changing the page update timing, this test became flaky. Originally it used
+        to setTimeout({...}, 10) to ensure the stringValue of the mutate button
+        was changed after it was pressed. The fix is to loop using rAF till the
+        stringValue changes.
+
+        * platform/mac-wk2/accessibility/mac/selection-notification-focus-change-expected.txt: Removed.
+        The number of time notificationCallback() is called and the order of
+        notifications are not defined. And this is why we have two expected files:
+        one for WK1 and the other for WK2. Since the test is now simplified, we
+        can get rid of this duplication. We will test the minimum reliable thing
+        we can test.
+
+2019-04-10  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Nullptr crash in CompositeEditCommand::moveParagraphs when root editable element goes away
+        https://bugs.webkit.org/show_bug.cgi?id=193027
+
+        Reviewed by Wenson Hsieh.
+
+        Added a regression test. Note that the test works around debug assertions in moveParagraphs.
+        These assertions are generally correct & useful unless the website does something crazy like
+        removing the contenteditable content attribute during editing operations.
+
+        * editing/deleting/merge-paragraphs-null-root-editable-element-crash-expected.txt: Added.
+        * editing/deleting/merge-paragraphs-null-root-editable-element-crash.html: Added.
+
+2019-04-10  Alicia Boya GarcĂ­a  <aboya@igalia.com>
+
+        [GTK] Unreviewed test gardening
+        https://bugs.webkit.org/show_bug.cgi?id=196800
+
+        * platform/gtk/TestExpectations:
+        * platform/gtk/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt:
+
+2019-04-10  Youenn Fablet  <youenn@apple.com>
+
+        [ Mojave WK2 iOS Sim ] Layout Test http/wpt/cache-storage/quota-third-party.https.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=196358
+        <rdar://problem/49388128>
+
+        Unreviewed.
+
+        * platform/ios-simulator-wk2/TestExpectations:
+        Mark test as slow.
+
+2019-04-10  Youenn Fablet  <youenn@apple.com>
+
+        SWClientConnection should not double hop to fire some events
+        https://bugs.webkit.org/show_bug.cgi?id=196735
+
+        Reviewed by Alex Christensen.
+
+        * platform/mac-wk2/TestExpectations:
+
+2019-04-10  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION (r238602): Elements: deleting the last child of a collapsed parent selects the parent's next sibling
+        https://bugs.webkit.org/show_bug.cgi?id=192711
+        <rdar://problem/46738990>
+
+        Reviewed by Timothy Hatcher.
+
+        Original patch by Matt Baker <mattbaker@apple.com>.
+
+        * inspector/table/table-remove-rows.html:
+        * inspector/table/table-remove-rows-expected.txt:
+
+2019-04-10  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Elements tab: multiple selection lost after navigating to another tab
+        https://bugs.webkit.org/show_bug.cgi?id=192681
+        <rdar://problem/46709392>
+
+        Reviewed by Timothy Hatcher.
+
+        Orginal patch by Matt Baker <mattbaker@apple.com>.
+
+        * inspector/tree-outline/tree-outline-selection.html: Added.
+        * inspector/tree-outline/tree-outline-selection-expected.txt: Added.
+        Add `TreeOutline` tests for single and multiple selection.
+
+        * inspector/unit-tests/set-utilities.html:
+        * inspector/unit-tests/set-utilities-expected.txt:
+        Add tests for `Set.prototype.lastValue`.
+
+2019-04-10  Youenn Fablet  <youenn@apple.com>
+
+        Layout Test http/wpt/fetch/response-opaque-clone.html is sometimes timing out on iOS simulator
+        https://bugs.webkit.org/show_bug.cgi?id=194525
+        <rdar://problem/48012229>
+
+        Reviewed by Alex Christensen.
+
+        Test is no longer flaky on MacOS.
+        As per flakiness dashboard, it sometimes times out on iOS simulator.
+        It sometimes passes after running for 20 seconds.
+        Mark it as Slow and improve the test to output more sub-tests.
+        Removed unnecessary removal of cache since test runner will clear them at the end of the test.
+
+        * http/wpt/fetch/response-opaque-clone-expected.txt:
+        * http/wpt/fetch/response-opaque-clone.html:
+        * platform/ios-simulator-wk2/TestExpectations:
+
+2019-04-10  Justin Fan  <justin_fan@apple.com>
+
+        [Web GPU] Indexed drawing and GPUCommandEncoder crash prevention
+        https://bugs.webkit.org/show_bug.cgi?id=196758
+
+        Reviewed by Dean Jackson.
+
+        Add draw-indexed-triangles to test drawing a green square using GPURenderPassEncoder::setIndexBuffer and drawIndexed.
+
+        * webgpu/draw-indexed-triangles-expected.html: Added.
+        * webgpu/draw-indexed-triangles.html: Added.
+
+2019-04-10  Megan Gardner  <megan_gardner@apple.com>
+
+        Fix text autoscrolling when typing in modern webkit
+        https://bugs.webkit.org/show_bug.cgi?id=196718
+
+        Reviewed by Tim Horton.
+
+        * fast/events/autoscroll-when-input-is-offscreen-expected.txt: Added.
+        * fast/events/autoscroll-when-input-is-offscreen.html: Added.
+        * fast/events/autoscroll-with-software-keyboard-expected.txt: Added.
+        * fast/events/autoscroll-with-software-keyboard.html: Added.
+
+2019-04-10  Youenn Fablet  <youenn@apple.com>
+
+        Delay initialization of quota users until the first quota request
+        https://bugs.webkit.org/show_bug.cgi?id=196467
+
+        Reviewed by Chris Dumez.
+
+        Unflake cache storage tests.
+
+        * TestExpectations:
+        * platform/mac-wk2/TestExpectations:
+
+2019-04-10  Philippe Normand  <pnormand@igalia.com>
+
+        there is no vp8 support in youtube.com/html5 page with libwebkit2gtk 2.24 (MSE enabled)
+        https://bugs.webkit.org/show_bug.cgi?id=196615
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Update WPE baselines and add/unskip the
+        imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType.html test in GTK.
+
+        * platform/gtk/TestExpectations:
+        * platform/gtk/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt: Copied from LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt.
+        * platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt:
+
+2019-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [ATK] Defer the emision of AtkObject::children-changed signal after layout is done
+        https://bugs.webkit.org/show_bug.cgi?id=187948
+
+        Reviewed by Michael Catanzaro.
+
+        Remove expectations of accessibility/children-changed-sends-notification.html that passes now.
+
+        * platform/gtk/TestExpectations:
+
+2019-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [ATK] Test accessibility/insert-children-assert.html is crashing since added in r216980
+        https://bugs.webkit.org/show_bug.cgi?id=172281
+        <rdar://problem/37030990>
+
+        Reviewed by Joanmarie Diggs.
+
+        Update the test to expect the whole content text on atk and remove the test expectations.
+
+        * accessibility/insert-children-assert.html:
+        * platform/gtk/TestExpectations:
+
+2019-04-09  John Wilander  <wilander@apple.com>
+
+        Add Resource Load Statistics test case for Ping
+        https://bugs.webkit.org/show_bug.cgi?id=196748
+
+        Reviewed by Alex Christensen.
+
+        * http/tests/resourceLoadStatistics/ping-to-prevalent-resource-expected.txt: Added.
+        * http/tests/resourceLoadStatistics/ping-to-prevalent-resource.html: Added.
+
+2019-04-09  Megan Gardner  <megan_gardner@apple.com>
+
+        Turn on editing test that should pass now
+        https://bugs.webkit.org/show_bug.cgi?id=196747
+        <rdar://problem/38779179>
+
+        Reviewed by Tim Horton.
+
+        Just turning on a test that needed to be turns off for a while due to compatibility changes
+        with the system.
+
+        * platform/ios-wk2/TestExpectations:
+
+2019-04-09  Zalan Bujtas  <zalan@apple.com>
+
+        [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
+        https://bugs.webkit.org/show_bug.cgi?id=196743
+        <rdar://problem/43897551>
+
+        Reviewed by Tim Horton.
+
+        * css3/viewport-percentage-lengths/vh-auto-size-expected.html:
+        * css3/viewport-percentage-lengths/vh-auto-size.html:
+        * fast/dynamic/crash-subtree-layout-when-auto-size-enabled.html:
+        * fast/dynamic/mail-autosize-viewport-unit.html:
+
+2019-04-09  Daniel Bates  <dabates@apple.com>
+
+        [iPad] Should open popover when the spacebar is pressed
+        https://bugs.webkit.org/show_bug.cgi?id=196360
+        <rdar://problem/49389129>
+
+        Reviewed by Brent Fulgham.
+
+        Add an iPad-specific test to ensure that pressing the spacebar opens the popover and scrolls
+        the form control into view.
+
+        * fast/forms/ios/ipad/open-picker-using-keyboard-expected.txt: Added.
+        * fast/forms/ios/ipad/open-picker-using-keyboard.html: Added.
+        * platform/ios/TestExpectations: Skip tests in fast/forms/ios/ipad. We will unskip for iPad below.
+        * platform/ipad/TestExpectations: Mark tests in fast/forms/ios/ipad as PASS so we run them.
+        * resources/ui-helper.js:
+        (window.UIHelper.waitForPopoverToPresent):
+        (window.UIHelper.waitForPopoverToDismiss):
+
+2019-04-09  Youenn Fablet  <youenn@apple.com>
+
+        Refresh WPT service worker expectations
+        https://bugs.webkit.org/show_bug.cgi?id=196732
+
+        Reviewed by Alex Christensen.
+
+        * TestExpectations:
+
+2019-04-09  Justin Fan  <justin_fan@apple.com>
+
+        [Web GPU] GPURenderPassEncoder updates: setBlendColor, setViewport, setScissorRect
+        https://bugs.webkit.org/show_bug.cgi?id=196719
+
+        Reviewed by Myles C. Maxfield.
+
+        Add blend-color-triangle-strip to set and blend with a custom blend color on the renderpass encoder.
+        Add viewport-scissor-rect-triangle-strip to draw a checkerboard by restricting the drawing viewport or scissor rectangle.
+
+        * webgpu/blend-color-triangle-strip.html: Added.
+        * webgpu/js/webgpu-functions.js:
+        (beginBasicRenderPass):
+        * webgpu/viewport-scissor-rect-triangle-strip-expected.html: Added.
+        * webgpu/viewport-scissor-rect-triangle-strip.html: Added.
+
+2019-04-09  Devin Rousso  <drousso@apple.com>
+
+        Unreviewed, fix test failures after r239698.
+        <rdar://problem/47223615>
+
+        * http/tests/inspector/network/resource-security-connection.html:
+        Security connection information is sent as part of the metrics, not the response.
+
+2019-04-09  John Wilander  <wilander@apple.com>
+
+        Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
+        https://bugs.webkit.org/show_bug.cgi?id=196558
+        <rdar://problem/47650245>
+
+        Reviewed by Youenn Fablet.
+
+        * http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt:
+           Enhanced the use of AdClickAttribution::MaxEntropy.
+        * http/tests/adClickAttribution/attribution-conversion-through-cross-site-image-redirect-expected.txt: Added.
+        * http/tests/adClickAttribution/attribution-conversion-through-cross-site-image-redirect.html: Added.
+        * http/tests/adClickAttribution/attribution-conversion-through-image-redirect-with-priority-expected.txt: Added.
+        * http/tests/adClickAttribution/attribution-conversion-through-image-redirect-with-priority.html: Added.
+        * http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority-expected.txt: Added.
+        * http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority.html: Added.
+        * http/tests/adClickAttribution/resources/redirectToConversion.php: Added.
+        * http/tests/adClickAttribution/resources/redirectToConversionOnIPAddress.php: Added.
+        * platform/ios-wk2/http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt:
+           Enhanced the use of AdClickAttribution::MaxEntropy.
+
+2019-04-09  Shawn Roberts  <sroberts@apple.com>
+
+        inspector/canvas/css-canvas-clients.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=174272
+
+        Unreviewed test gardening
+
+        * platform/mac/TestExpectations: Updating expectations to unskip test and just mark as a flaky failure
+
+2019-04-09  Shawn Roberts  <sroberts@apple.com>
+
+        inspector/console/console-time.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=158006
+
+        Unreviewed test gardening.
+
+        * platform/mac/TestExpectations: Updating expecations for flaky failure
+
+2019-04-09  Antoine Quint  <graouts@apple.com>
+
+        [ Mac ] REGRESSION (r237587) Layout Test compositing/visible-rect/animated-from-none.html is flaky text diff failure
+        https://bugs.webkit.org/show_bug.cgi?id=194798
+        <rdar://problem/48181898>
+
+        Reviewed by Dean Jackson.
+
+        When using the Web Animations engine, the best way to run code as an animation start is to use the "ready" promise, whereas
+        DOM events are dispatched asynchronously and, in the case of this test, might have an animation progress that is greater
+        than 0 and yield an animated transform that isn't quite the identity matrix.
+
+        * compositing/visible-rect/animated-from-none.html:
+
 2019-04-09  Jer Noble  <jer.noble@apple.com>
 
         Add test for fix of #196095