2012-06-25 Simon Hausmann [Qt] Make it possible to build WebKit without QtWidgets https://bugs.webkit.org/show_bug.cgi?id=78109 Reviewed by Tor Arne Vestbø. * Tools.pro: Disable various tools that depend on WK1. * qmake/mkspecs/features/default_post.prf: Add WK1 as supported static lib in WEBKIT * qmake/mkspecs/features/default_pre.prf: Disable WK1 if QtWidgets is not built. * qmake/mkspecs/modules/webkit1.prf: Added. 2012-06-25 Dirk Pranke put vista back for chromium (non-webkit) bots ... https://bugs.webkit.org/show_bug.cgi?id=89929 Unreviewed, build fix. Turns out we've only gotten rid of vista on the webkit tests so far. Put vista back for the other chromium bots ... * TestResultServer/static-dashboards/flakiness_dashboard.js: (chromiumPlatform): * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: (test): 2012-06-25 Dirk Pranke update flakiness dashboard after removing chromium-vista bots https://bugs.webkit.org/show_bug.cgi?id=89925 Unreviewed, build fix. More changes missed in r121194 :(. * TestResultServer/static-dashboards/flakiness_dashboard.js: (chromiumPlatform): * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: (test): 2012-06-25 Dirk Pranke remove support for chromium vista from tools https://bugs.webkit.org/show_bug.cgi?id=89915 Reviewed by Tony Chang. This change is all deleting code and updating tests to handle the configuration being gone. All tests now pass except for a few unittests for the flakiness dashboard which were failing before this patch. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: (BaselineOptimizerTest.test_complex_shadowing): * Scripts/webkitpy/layout_tests/port/builders.py: * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: * Scripts/webkitpy/layout_tests/port/chromium_win.py: (ChromiumWinPort): * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: (ChromiumWinTest.test_versions): (ChromiumWinTest.test_baseline_path): * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: (BuildCoverageExtrapolatorTest.test_extrapolate): 2012-06-25 Scott Graham [Chromium] add empty impl of WebThemeEngine::getSize() for DRT https://bugs.webkit.org/show_bug.cgi?id=89907 Not reviewed. Fix build in Chromium. * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: (WebThemeEngineDRTWin::getSize): * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: (WebThemeEngineDRTWin): 2012-06-25 Gyuyoung Kim [EFL] Implement Network Information API https://bugs.webkit.org/show_bug.cgi?id=87067 Reviewed by Kenneth Rohde Christiansen. * efl/jhbuild.modules: Add eeze library dependency. 2012-06-25 Simon Hausmann [Qt] Fix Win32 debug build Reviewed by Tor Arne Vestbø. Consolidate use_all_in_one_files into mac/unix/win32 default_pre.prf. * qmake/mkspecs/features/unix/default_pre.prf: * qmake/mkspecs/features/win32/default_pre.prf: Added. 2012-06-24 Thiago Marcos P. Santos [Qt] Enable support by default https://bugs.webkit.org/show_bug.cgi?id=89653 Reviewed by Kenneth Rohde Christiansen. This feature is complete for Qt WebKit2. Enabling by default will help to mature the implementation. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: 2012-06-24 Dan Bernstein Made debug-{minibrowser,safari,test-runner} work with LLDB. Reviewed by Sam Weinig. * Scripts/debug-minibrowser: Pass INCLUDE_OPTIONS_FOR_DEBUGGING to printHelpAndExitForRunAndDebugWebKitAppIfNeeded(). * Scripts/debug-safari: Ditto. * Scripts/debug-test-runner: Ditto. * Scripts/webkitdirs.pm: (debugger): Added. Calls determineDebugger() if needed and returns the chosen debugger. (determineDebugger): Added. Sets the debugger to "lldb" if the --use-lldb switch is present, and to "gdb" otherwise. (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Changed to print help for the --target-web-process and --use-lldb switches if passed INCLUDE_OPTIONS_FOR_DEBUGGING. (execMacWebKitAppForDebugging): Changed to use the chosen debugger. 2012-06-24 Adam Barth [Chromium] Release media resources after each LayoutTest on Android https://bugs.webkit.org/show_bug.cgi?id=89720 Reviewed by Eric Carlson. The LayoutTests can hang when run on Android because we sometimes run out of media resources. This patch causes us to release our media resources after each test in order to avoid running out of this resource. In production, there are other mechanisms that manage this resource. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController): 2012-06-23 Zan Dobersek [Gtk] REGRESSION(r120918): Causes flaky DND tests https://bugs.webkit.org/show_bug.cgi?id=89770 Reviewed by Martin Robinson. Connect to the run-file-chooser signal of the WebKitWebView and return TRUE so no file chooser dialog is run. This prevents certain test failures. * DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewRunFileChooser): (createWebView): 2012-06-23 Dan Bernstein debug-{minibrowser,safari,test-runner} fail when gdb is not installed in /usr/bin. Reviewed by Sam Weinig. * Scripts/webkitdirs.pm: (execMacWebKitAppForDebugging): Use xcrun to locate gdb. 2012-06-23 Carlos Garcia Campos Unreviewed. Skip GTK+ unit test /webkit2/WebKitFindController/hide. It fails always when running it in Xvfb. * gtk/run-api-tests: (TestRunner): 2012-06-23 Wajahat Siddiqui [GTK][WK2]Mis-spelt defaultWindowTitle https://bugs.webkit.org/show_bug.cgi?id=89808 Reviewed by Carlos Garcia Campos. * MiniBrowser/gtk/BrowserWindow.c: 2012-06-23 Sergio Villar Senin [GTK] Add a new webkit2 tests slave bot https://bugs.webkit.org/show_bug.cgi?id=89336 Reviewed by Csaba Osztrogonác. Slave configuration for a new GTK 64 bit release bot that will run WebKit2 tests. Also BuildAndTest now accepts the "triggers" parametter, this means that apart from building and testing it can trigger some other build/test sequences in other slaves. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (BuildAndTestFactory.__init__): 2012-06-23 Kwang Yul Seo Unreviewed. Update my email. * Scripts/webkitpy/common/config/committers.py: 2012-06-22 Adam Barth [Chromium] DumpRenderTree on Android needs to configure fonts for testing https://bugs.webkit.org/show_bug.cgi?id=89721 Reviewed by Nate Chapin. This patch teaches DumpRenderTree to configure Skia to use the fallback fonts that the LayoutTests assume. This patch reduces the number result differences between chromium-android and chromium-linux. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: * DumpRenderTree/chromium/TestShellAndroid.cpp: (platformInit): * DumpRenderTree/chromium/android_fallback_fonts.xml: Added. * DumpRenderTree/chromium/android_main_fonts.xml: Added. * Scripts/webkitpy/layout_tests/port/chromium_android.py: 2012-06-22 Alexandru Chiculita [CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac https://bugs.webkit.org/show_bug.cgi?id=89781 Reviewed by Dean Jackson. Added CSS Shaders as enabled by default on Safari for Mac. * Scripts/webkitperl/FeatureList.pm: 2012-06-22 Adam Barth Add support for test_expectations_android.txt for overriding test expecations on the chromium-android branch https://bugs.webkit.org/show_bug.cgi?id=89791 Reviewed by Dirk Pranke. Downstream, the chromium-android port maintains a test expectations file to keep track of which tests pass or fail. That causes them to keep a patch in chromium_android.py in their branch. This patch teaches chromium_android.py to use test_expectations_android.txt. We don't intend to use this file upstream, but having this code patch upstream lets us unfork webkitpy. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidPort.expectations_files): 2012-06-22 Dirk Pranke run_webkit_tests.py failed with AttributeError(''NoneType' object has no attribute 'pid'') https://bugs.webkit.org/show_bug.cgi?id=89734 Reviewed by Ryosuke Niwa. Fix a crash in ServerProcess if you called .pid() after it crashed during a write(). We had a test for this case but the test wasn't calling pid(), just has_crashed(). Fixed the problem and the test. * Scripts/webkitpy/layout_tests/port/server_process.py: (ServerProcess.__init__): (ServerProcess.pid): (ServerProcess._start): (ServerProcess.stop): * Scripts/webkitpy/layout_tests/port/server_process_unittest.py: (FakeServerProcess._start): (TestServerProcess.test_broken_pipe): 2012-06-22 Peter Beverloo [Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android https://bugs.webkit.org/show_bug.cgi?id=88853 Reviewed by Steve Block. The Android exclusions were necessary to fix a gyp generation error, as the gcc_version variable wasn't being defined for Android. Remove these exceptions when Chromium is able to define the gcc_version variable. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 2012-06-22 Mario Sanchez Prada Unreviewed gardening. Unskipping test passing after fixing bug 88419. * gtk/run-api-tests: (TestRunner): Unskip WTF.HashMap. 2012-06-22 Zoltan Horvath [Qt] Allow DumpRenderTree to dump about:blank https://bugs.webkit.org/show_bug.cgi?id=89685 Reviewed by Ryosuke Niwa. We need to allow DumpRenderTree to dump about:blank page, then it will be consistent with other ports, additionaly this behavior is required for running WTR performance tests. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::processLine): 2012-06-21 Adam Barth [Chromium] Reset mediaPlaybackRequiresUserGesture WebSettings after each test https://bugs.webkit.org/show_bug.cgi?id=89718 Reviewed by Kent Tamura. We should reset this WebSetting to its default value so that it behaves consistently across tests. * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo): * DumpRenderTree/chromium/WebPreferences.h: (WebPreferences): 2012-06-21 Zoltan Horvath DRT/WTR python interface handles about:blank incorrectly https://bugs.webkit.org/show_bug.cgi?id=89563 Reviewed by Dirk Pranke. Currently DRT/WTR python interface's _command_from_driver_input function puts the test directory path before about:blank. Remove this incorrect behavior. * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitDriver._command_from_driver_input): 2012-06-21 Dirk Pranke reenable perf tests on win https://bugs.webkit.org/show_bug.cgi?id=89690 Reviewed by Ryosuke Niwa. Only the replay tests don't work, and those are disabled by default. This change also fixes the undefined _log reference that was causing a crash. * Scripts/run-perf-tests: 2012-06-21 Sheriff Bot Unreviewed, rolling out r120937. http://trac.webkit.org/changeset/120937 https://bugs.webkit.org/show_bug.cgi?id=89679 This patch brought buildbot master down (Requested by svillar on #webkit). * BuildSlaveSupport/build.webkit.org-config/config.json: 2012-06-21 Martin Robinson [GTK] Combine WebKit API tests into fewer binaries https://bugs.webkit.org/show_bug.cgi?id=88458 Reviewed by Carlos Garcia Campos. Instead of creating one binary per-test file, create binaries for each category of tests. Right now this includes WTF and the WebKit2 C API, but later tests can be added for the GTK+ platform layer and the WebKit1 and WebKit2 API layers. * TestWebKitAPI/GNUmakefile.am: Compile only two test binaries, one for the WebKit2 C API and one for WTF. Refresh the source list to ensure that new test are active. * gtk/run-api-tests: Change the way that tests are skipped by splitting out the concept of skipping a test and skipping a suite (program) of tests. Test cases are skipped because of legitimate failures, but entire programs are skipped because of problems in the harness. As of right now a test program is only skipped if the accessibility bus cannot be started. (SkippedTest.__init__): Make the test case a required argument and have one skipped test case per SkippedTest instance. (SkippedTest.__str__): Ditto. (TestRunner): Update the directory list. We only have two gtest binaries now and they are in one directory. Reformat the test list to make it slightly easier to read. (TestRunner.__init__): Add the _skipped_test_program member, which handles entire test programs that are skipped. (TestRunner._setup_testing_environment): Use the new member. (TestRunner._test_cases_to_skip): Collect all skipped test cases now instead of just the first SkippedTest that matches. (TestRunner._should_run_test_program): Take a look at the new member to make this decision. (TestRunner._run_test_command): Use the name test_program instead of test to disambiguate between test cases and test suites. (TestRunner._run_test_glib): ditto. (TestRunner._run_test_google): Ditto. (TestRunner._run_test): Ditto. (TestRunner.run_tests): Ditto. 2012-06-21 Yong Li Unreviewed. Moving myself from committer to reviewer. * Scripts/webkitpy/common/config/committers.py: 2012-06-21 Sergio Villar Senin [GTK] Add a new webkit2 tests slave bot https://bugs.webkit.org/show_bug.cgi?id=89336 Reviewed by Philippe Normand. Slave configuration for a new GTK bot that will run WebKit2 tests. * BuildSlaveSupport/build.webkit.org-config/config.json: 2012-06-21 Thiago Marcos P. Santos [Qt] Add a custom Color Chooser widget to MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=87988 Reviewed by Alexis Menard. Added custom color chooser example for the MiniBrowser. * MiniBrowser/qt/MiniBrowser.qrc: * MiniBrowser/qt/qml/BrowserWindow.qml: * MiniBrowser/qt/qml/ColorChooser.qml: Added. 2012-06-21 Vivek Galatage Remove the warning "File not found" in MiniBrowser post-build event https://bugs.webkit.org/show_bug.cgi?id=89601 Reviewed by Adam Roben. * MiniBrowser/MiniBrowserPostBuild.cmd: 2012-06-21 Balazs Kelemen [Qt] DRT in standalone mode hangs after the first test https://bugs.webkit.org/show_bug.cgi?id=89613 Reviewed by Csaba Osztrogonác. Break an inline signal slot chain that ends up in setting LayoutTestController::m_hasDumped too early. In LayoutTestController::maybeDump() we emit done() which starts the chain that finishes in DumpRenderTree::open(). The next line in maybeDump sets m_hasDumped to true. We could simply reorder these two lines but it seems to be wrong in general to start the next load from this call chain. The server mode (when DRT is runned by the test harness) also uses a queued connection to read the next test from stdin. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::processArgsLine): 2012-06-20 Hans Wennborg Speech JavaScript API: SpeechRecognition should hook up with ActiveDOMObject more https://bugs.webkit.org/show_bug.cgi?id=89217 Reviewed by Adam Barth. Add a method for checking whether the mock speech recognition was aborted. Also redo the way the mock posts tasks. Instead of posting them all at once, maintain an internal queue of task objects, and call postTask() for them once at the time. This means that for example when the page is navigated away and abort() is called, that call doesn't end up after a bunch of previously posted events on the event loop. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::wasMockSpeechRecognitionAborted): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: (WebKit::ClientCallTask::ClientCallTask): (WebKit::ResultTask::ResultTask): (WebKit::NoMatchTask::NoMatchTask): (WebKit::ErrorTask::ErrorTask): (MockWebSpeechRecognizer::start): (MockWebSpeechRecognizer::abort): (MockWebSpeechRecognizer::setError): (MockWebSpeechRecognizer::MockWebSpeechRecognizer): (MockWebSpeechRecognizer::startTaskQueue): (MockWebSpeechRecognizer::StepTask::runIfValid): * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: (MockWebSpeechRecognizer::hasBeenAborted): (MockWebSpeechRecognizer): (MockWebSpeechRecognizer::taskList): (Task): (MockWebSpeechRecognizer::Task::Task): (MockWebSpeechRecognizer::Task::~Task): (StepTask): (MockWebSpeechRecognizer::StepTask::StepTask): 2012-06-21 Mario Sanchez Prada [GTK] Add support for window.showModalDialog in WebKit2GTK+ https://bugs.webkit.org/show_bug.cgi?id=79500 Reviewed by Carlos Garcia Campos. Add support for modal dialogs in GTK's MiniBrowser. * MiniBrowser/gtk/BrowserWindow.c: (webViewRunAsModal): (webViewCreate): (webViewDecidePolicy): (browser_window_new): * MiniBrowser/gtk/BrowserWindow.h: * MiniBrowser/gtk/main.c: (createBrowserWindow): 2012-06-20 Brent Fulgham [WinCairo] Unreviewed build fix. The wrapper script that launched new- and old-run-webkit-tests was discarding the --wincairo argument needed to get the proper test infrastructure to build under WinCairo. * Scripts/run-webkit-tests: Emulate the Qt, Wx, Chromium, etc., behavior to chain the --wincairo flag through to the new build and test scripts. 2012-06-20 Mark Rowe Teach run-safari and debug-safari to work with a Safari.app that has entitlements Reviewed by Dan Bernstein. * Scripts/webkitdirs.pm: (executableHasEntitlements): (safariPathFromSafariBundle): 2012-06-20 Sheriff Bot Unreviewed, rolling out r120821. http://trac.webkit.org/changeset/120821 https://bugs.webkit.org/show_bug.cgi?id=89605 It made duplicated reviewer entries (Requested by Ossy on #webkit). * Scripts/webkitpy/common/checkout/changelog.py: (ChangeLog.set_reviewer): * Scripts/webkitpy/common/checkout/changelog_unittest.py: (test_set_reviewer): (test_set_short_description_and_bug_url): 2012-06-20 Dirk Pranke nrwt outputs empty files for wdiff output if wdiff is not installed https://bugs.webkit.org/show_bug.cgi?id=88709 Reviewed by Tony Chang. Reviewed by Tony Chang. Don't write -wdiff or -pretty.html files if wdiff or prettypatch aren't available, and clean up the handling for them in the port code. * Scripts/webkitpy/run_webkit_tests_integrationtest.py: (MainTest.test_output_diffs): * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: (TestResultWriter.create_text_diff_and_write_result): * Scripts/webkitpy/layout_tests/port/base.py: (Port.check_pretty_patch): (Port.check_wdiff): (Port._wdiff_missing_message): * Scripts/webkitpy/layout_tests/port/chromium_linux.py: (ChromiumLinuxPort.check_build): (ChromiumLinuxPort._wdiff_missing_message): * Scripts/webkitpy/layout_tests/port/chromium_mac.py: (ChromiumMacPort.check_build): (ChromiumMacPort): (ChromiumMacPort._wdiff_missing_message): * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: (ChromiumMacPortTest): 2012-06-20 Dirk Pranke nrwt: fix unit tests for ensuring svn revision is correct https://bugs.webkit.org/show_bug.cgi?id=89498 Reviewed by Eric Seidel. Reviewed by Eric Seidel. Fix the unit tests for testing that we are embedding the SVN revision in the results json for NRWT properly; this was broken in r120646 but because the MockHost worked differently than the real one (by always initializing the MockSCM object) we didn't notice. Unfortunately, just changing the default breaks all sorts of unit tests ... * Scripts/webkitpy/common/host_mock.py: (MockHost.__init__): (MockHost._initialize_scm): * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ResultSummaryTest.test_no_svn_revision): (ResultSummaryTest.test_svn_revision): 2012-06-20 Dirk Pranke new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR https://bugs.webkit.org/show_bug.cgi?id=69360 Reviewed by Eric Seidel. Reviewed by Eric Seidel. Propagate the 'port_implementation' part of the platform (i.e., gtk,qt,chromium) to webkit-build-directory so that we can pick up the gtk-specific handling of WEBKITOUTPUTDIR ... I didn't write any additional tests for this; testing it properly is an integration test between the python code and the perl code, which I verified by hand. * Scripts/webkitpy/layout_tests/port/base.py: (Port.__init__): * Scripts/webkitpy/layout_tests/port/config.py: (Config.__init__): (Config.build_directory): * Scripts/webkitpy/layout_tests/port/config_mock.py: (MockConfig.__init__): * Scripts/webkitpy/layout_tests/port/config_unittest.py: (ConfigTest.test_build_directory_passes_port_implementation): 2012-06-20 Dirk Pranke Fix import sorting missed in r120846 Reviewed by Tony Chang. * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: 2012-06-20 Dirk Pranke Fix chromium win http servers after breakage introduced in r120846. Unreviewed, build fix. * Scripts/webkitpy/layout_tests/port/base.py: (Port.to.start_http_server): * Scripts/webkitpy/layout_tests/servers/http_server.py: (Lighttpd.__init__): 2012-06-20 Dirk Pranke tweak output of webkit-patch print-{baselines,expectations} https://bugs.webkit.org/show_bug.cgi?id=89588 Reviewed by Tony Chang. Minor tweaks to the output to make it more readable, including turning off csv by default for print-baselines with multiple ports. * Scripts/webkitpy/layout_tests/port/test.py: (TestPort): * Scripts/webkitpy/tool/commands/queries.py: (PrintExpectations.execute): (PrintBaselines.execute): * Scripts/webkitpy/tool/commands/queries_unittest.py: (PrintExpectationsTest.run_test): (PrintExpectationsTest.test_multiple): (PrintBaselinesTest.setUp): (PrintBaselinesTest.test_multiple): 2012-06-18 Dirk Pranke new-run-webkit-tests should spin-up enough httpd processes to avoid timeouts https://bugs.webkit.org/show_bug.cgi?id=88134 Reviewed by Tony Chang. Change NRWT to spin up 2*min(child_processes, locked_shards) http servers by default so that we are less likely to get a bunch of http timeouts at the beginning of a test run. Note that I had to tweak executive_mock to support mocked stderr because the apache_http_server code reads stderr when starting a process to ensure it started okay. * Scripts/webkitpy/common/system/executive_mock.py: (MockProcess.__init__): * Scripts/webkitpy/common/system/outputcapture.py: * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._run_tests): (Manager.start_servers_with_lock): * Scripts/webkitpy/layout_tests/port/base.py: (Port.to.start_http_server): * Scripts/webkitpy/layout_tests/port/test.py: (TestPort.start_http_server): (TestPort._path_to_apache): (TestPort): (TestPort._path_to_apache_config_file): * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__): * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: Added (LayoutTestApacheHttpd.__init__): * Scripts/webkitpy/layout_tests/servers/http_server.py: (Lighttpd.__init__): * Scripts/webkitpy/layout_tests/servers/http_server_base.py: (HttpServerBase.__init__): 2012-06-20 Tom Zakrajsek Unreviewed: Back out accidentally checked in debug print which broke a test * Scripts/webkitpy/performance_tests/perftest.py: (PerfTest.parse_output): 2012-06-20 Tom Zakrajsek Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests https://bugs.webkit.org/show_bug.cgi?id=78789 Reviewed by Ryosuke Niwa. Updated parser to include fps as a valid unit. * Scripts/webkitpy/performance_tests/perftest.py: (PerfTest): (PerfTest.parse_output): 2012-06-20 Balazs Ankes webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing https://bugs.webkit.org/show_bug.cgi?id=67935 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/common/checkout/changelog.py: (ChangeLog.set_reviewer): * Scripts/webkitpy/common/checkout/changelog_unittest.py: (test_set_reviewer): (test_set_short_description_and_bug_url): 2012-06-20 Simon Hausmann Unreviewed trivial permissions fix. * qmake/mkspecs/features/features.prf: Don't mark this file as executable. 2012-06-19 Ryuan Choi [EFL][Regression] Build break after r120786 https://bugs.webkit.org/show_bug.cgi?id=89549 Unreviewed build fix for Efl port. * DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes. 2012-06-19 Dirk Pranke NRWT spins up and down the WebSocket server when running a single HTTP test from the command line https://bugs.webkit.org/show_bug.cgi?id=64489 Reviewed by Tony Chang. This change changes NRWT so that we don't start the websocket server if we aren't running websocket tests and don't start the HTTP server if we aren't running http tests. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._websocket_tests): (Manager.start_servers_with_lock): (Manager.stop_servers_with_lock): * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ManagerTest.test_servers_started): 2012-06-19 Dirk Pranke test-webkitpy: add a -p flag to pass through captured output to enable debugging https://bugs.webkit.org/show_bug.cgi?id=89158 Reviewed by Eric Seidel. Normally when outputcapture runs it intercepts stdout/stderr, which makes running under the debugger difficult and mostly pointless (since you can't see any output). This change adds a flag to test-webkitpy (-p) that will cause outputcapture to pass through the output as well as capture it. * Scripts/webkitpy/common/system/outputcapture.py: (OutputCapture.stream_wrapper): (OutputCapture._capture_output_with_name): * Scripts/webkitpy/common/system/outputcapture_unittest.py: (OutputCaptureTest.setUp): * Scripts/webkitpy/test/main.py: (Tester._parse_args): (Tester._run_tests): (Tester._log_exception): (_CaptureAndPassThroughStream): (_CaptureAndPassThroughStream.__init__): (_CaptureAndPassThroughStream.write): (_CaptureAndPassThroughStream._message_is_from_pdb): (_CaptureAndPassThroughStream.flush): (_CaptureAndPassThroughStream.getvalue): 2012-06-19 Adam Barth garden-o-matic fails to rebaseline tests with MISSING results https://bugs.webkit.org/show_bug.cgi?id=89521 Reviewed by Kenneth Russell. If the bots report "MISSING", we should try to find PNG and TXT results on the server. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: 2012-06-19 Adam Barth svn.delete_list fails to delete empty parent directories https://bugs.webkit.org/show_bug.cgi?id=89520 Reviewed by Dirk Pranke. These functions were calling scm.delete and scm.add, which already delete the parent directory. We'd get an exception when we tried to delete the parent directory again. * Scripts/webkitpy/common/checkout/scm/svn.py: (SVN._add_parent_directories): (SVN._delete_parent_directories): 2012-06-19 Thiago Marcos P. Santos webkitpy: Simplify fetch_bugs_matching_search() https://bugs.webkit.org/show_bug.cgi?id=89497 Reviewed by Adam Barth. Removed parameter with default value. It's not being used and the handling of the parameter was wrong. Saves a check. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (BugzillaQueries.fetch_bugs_matching_search): * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: (MockBugzillaQueries.fetch_bugs_matching_search): 2012-06-19 Dirk Pranke webkitpy: remove unneeded imports in layout_tests/port/chromium.py https://bugs.webkit.org/show_bug.cgi?id=89522 Reviewed by Eric Seidel. They were no longer being used. No tests necessary. * Scripts/webkitpy/layout_tests/port/chromium.py: 2012-06-19 Adam Barth Missing results aren't shown in garden-o-matic Reviewed by Kenneth Russell. Previously we didn't know to look for text and image results when the bot told us that results were missing. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: 2012-06-19 Dirk Pranke Fix regression introduced in r120646 where the svn revision isn't saved in results.json Unreviewed, build fix. It turns out that we store the svn revision two different ways in the JSON, and I only caught one of them :(. This should fix the other. Also, this part of the code is poorly tested. I will investigate adding at least a basic test for this in a separate fix. * Scripts/webkitpy/layout_tests/controllers/manager.py: (summarize_results): 2012-06-19 Dirk Pranke REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory https://bugs.webkit.org/show_bug.cgi?id=78127 Reviewed by Ryosuke Niwa. Add the --add-platform-exceptions flag from ORWT, and ensure that --new-baseline is equivalent to --reset-results --add-platform-exceptions. Also fix the default logic for where to put PNGs and render tree dumps if --new-test-results is true: if --add-platform-exceptions is False, baselines should go in the least-specific platform directory (e.g., platform/mac) rather than the most-specific (platform/mac-snowleopard). * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner): (SingleTestRunner.run): (SingleTestRunner._run_rebaseline): (SingleTestRunner._add_missing_baselines): (SingleTestRunner._location_for_new_baseline): (SingleTestRunner._overwrite_baselines): (SingleTestRunner._save_baseline_data): * Scripts/webkitpy/layout_tests/port/base.py: (Port.baseline_path): (Port): (Port.baseline_platform_dir): (Port.baseline_version_dir): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options): (parse_args): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RebaselineTest.assertBaselines): (RebaselineTest.test_reset_results): (RebaselineTest.test_missing_results): (RebaselineTest.test_new_baseline): 2012-06-19 Dirk Pranke NRWT should not take memory used as disk cache into account when deciding how many processes to launch https://bugs.webkit.org/show_bug.cgi?id=81379 Reviewed by Eric Seidel. The 'free memory' calculation we were running on the mac seemed to underestimate how many children we can run in parallel, and it was complex. This patch replaces that calculation with a simpler one that reserves 2GB for overhead and assumes 256MB per DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs. Also, there was a bug where we were truncating the memory installed on the machine to 4GB by casting to an int instead of a long; this was probably the source of some of the earlier problems when using total memory. This patch also removes the no-longer-needed restrictions on the number of workers on beefy Lion boxes for both Apple Mac and Chromium Mac; we should now use all of the cores by default. The memory calculations have only been implemented on the mac; having the calculation in base.default_child_processes() was IMO misleading, and so this patch also moves the computation into the MacPort. I have not heard of the # of workers being an issue on any other ports, so this should be fine. * Scripts/webkitpy/common/system/platforminfo.py: (PlatformInfo.total_bytes_memory): * Scripts/webkitpy/common/system/platforminfo_mock.py: (PlatformInfo.total_bytes_memory): (PlatformInfo.total_bytes_memory): (PlatformInfo._win_version_tuple_from_cmd): * Scripts/webkitpy/common/system/platforminfo_unittest.py: (TestPlatformInfo.test_total_bytes_memory): * Scripts/webkitpy/layout_tests/port/base.py: (Port.default_child_processes): * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.test_default_child_processes): * Scripts/webkitpy/layout_tests/port/chromium_mac.py: (ChromiumMacPort.operating_system): * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort.default_child_processes): * Scripts/webkitpy/layout_tests/port/mac_unittest.py: (TestMacPort.test_default_child_processes): 2012-06-19 Dirk Pranke new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled https://bugs.webkit.org/show_bug.cgi?id=85446 Reviewed by Simon Fraser. Embed whether pixel testing was enabled into the results.json. * Scripts/webkitpy/layout_tests/controllers/manager.py: (summarize_results): 2012-06-19 Zoltan Horvath [Qt] Modify HTTPS port to 8443 for performance tests https://bugs.webkit.org/show_bug.cgi?id=89442 Reviewed by Ryosuke Niwa. We should be consistent with the default HTTPS port and with the changelog of r119188. * Scripts/webkitpy/performance_tests/perftest.py: (ReplayServer.__init__): 2012-06-19 Mike West Introduce ENABLE_CSP_NEXT configuration flag. https://bugs.webkit.org/show_bug.cgi?id=89300 Reviewed by Adam Barth. The 1.0 draft of the Content Security Policy spec is just about to move to Last Call. We'll hide work on the upcoming 1.1 spec behind this ENABLE flag, disabled by default. Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: 2012-06-19 Christophe Dumez [EFL] EFL's LayoutTestController does not support setTextDirection https://bugs.webkit.org/show_bug.cgi?id=87481 Reviewed by Hajime Morita. Implement setTextDirection in EFL's LayoutTestController and properly reset its value between test cases to avoid flakiness. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: (DumpRenderTreeChrome::resetDefaultsToConsistentValues): * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: (LayoutTestController::setTextDirection): 2012-06-19 Kristóf Kosztyó [Qt] Temporarily disable xvfb driver in nrwt https://bugs.webkit.org/show_bug.cgi?id=88414 Reviewed by Csaba Osztrogonác. * Scripts/webkitpy/layout_tests/port/qt.py: (QtPort._build_driver): 2012-06-18 Joone Hur [EFL] Fontconfig can't be linked properly https://bugs.webkit.org/show_bug.cgi?id=89418 Unreviewed build fix. Make Fontconfig be linked correctly. * MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES. 2012-06-18 Joone Hur Unreviewed. Updating email for committers.py script. * Scripts/webkitpy/common/config/committers.py: 2012-06-18 Simon Fraser Fix a typo that caused TestFailures to have a syntax error. Sadly TestFailures is broken for another reason now too: https://bugs.webkit.org/show_bug.cgi?id=89419 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: (ViewController.prototype._domForBuildName): 2012-06-18 Simon Fraser Provide bug links for suspicious commits https://bugs.webkit.org/show_bug.cgi?id=89408 Reviewed by Adam Barth. Add links to bugs for the suspicious commits if we have bug data. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: (ol.notifications>li ul.causes>li>div.description>span>span.bugID::before): (ol.notifications>li ul.causes>li>div.description>span>span.bugID>a): 2012-06-18 Amy Ousterhout [Chromium] DeviceOrientation Cleanup https://bugs.webkit.org/show_bug.cgi?id=89354 Reviewed by Kent Tamura. * DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function (WebViewHost): 2012-06-18 James Robinson [chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D https://bugs.webkit.org/show_bug.cgi?id=89254 Reviewed by Adrienne Walker. This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated upstream. * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createGraphicsContext3D): 2012-06-18 Simon Fraser Minor fix suggested by Adam Barth. Use $(this._what).empty(); rather than removing children one at a time. For some reason removeAllChildren() is undefined on this node. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: 2012-06-18 Simon Fraser Show TOT revision in garden-o-matic, and make the revisions into links https://bugs.webkit.org/show_bug.cgi?id=89396 Reviewed by Adam Barth. The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)" where the revisions are links to trac. To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had the knock-on effect of flipping the target and href attributes for anchors in some test output. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: (ViewController.prototype._displayTesters.updateList.list): (ViewController.prototype._displayTesters.updateList): (ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange): (ViewController.prototype._domForRegressionRange): (ViewController.prototype._domForAuxiliaryUIElements): (ViewController.prototype._domForBuildName): (ViewController.prototype): (ViewController.prototype.): * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: 2012-06-18 Csaba Osztrogonác REGRESSION(r100558): NRWT should work without SVN or GIT https://bugs.webkit.org/show_bug.cgi?id=76630 Reviewed by Dirk Pranke. NRWT is not supposed to have a requirement that we have an actual SVN or Git checkout, and we were unnecessarily initializing the checkout. This patch removes that line :). * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (main): 2012-06-18 Zan Dobersek [garden-o-matic] Add support for the GTK builders https://bugs.webkit.org/show_bug.cgi?id=89360 Reviewed by Adam Barth. Add the 'gtk' platform, essentially a copy of the 'apple' platform since both get their data from build.webkit.org. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: (.): 2012-06-18 Nico Weber [chromium/mac] Unbreak smooth scrolling. https://bugs.webkit.org/show_bug.cgi?id=89327 Reviewed by Dimitri Glazkov. Broken by Sam in r115589 / r115591. * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): * TestWebKitAPI/mac/InjectedBundleControllerMac.mm: (TestWebKitAPI::InjectedBundleController::platformInitialize): * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize): 2012-06-18 Sheriff Bot Unreviewed, rolling out r120541, r120547, and r120548. http://trac.webkit.org/changeset/120541 http://trac.webkit.org/changeset/120547 http://trac.webkit.org/changeset/120548 https://bugs.webkit.org/show_bug.cgi?id=89383 This approach doesn't work for WebKit2 (Requested by abarth on #webkit). * DumpRenderTree/LayoutTestController.cpp: (setBackingScaleFactorCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: (LayoutTestController::setBackingScaleFactor): * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: (LayoutTestController::setBackingScaleFactor): * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setBackingScaleFactor): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setBackingScaleFactor): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setBackingScaleFactor): * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setBackingScaleFactor): * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessage): (WTR::InjectedBundle::postSetBackingScaleFactor): (WTR): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: (InjectedBundle): * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setBackingScaleFactor): (WTR): (WTR::LayoutTestController::callSetBackingScaleFactorCallback): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: (LayoutTestController): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 2012-06-18 Zan Dobersek REGRESSION(r120546): It made 3 webkitpy tests fail https://bugs.webkit.org/show_bug.cgi?id=89332 Reviewed by Adam Barth. Update the BaselineOptimizer unittest after r120546. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: (BaselineOptimizerTest.test_no_add_mac_future): (BaselineOptimizerTest.test_mac_future): (BaselineOptimizerTest.test_complex_shadowing): 2012-06-18 Dirk Pranke new-run-webkit-tests output gets confused when logging https://bugs.webkit.org/show_bug.cgi?id=63793 Reviewed by Adam Barth. Ship all of the log messages generated in the worker back to the manager; this allows the messages to be properly serialized to stderr and for the meter to flush its output correctly. Note however that this will likely result in messages to be logged out of order between workers; I'm not sure that there's an easy way to fix this short of buffering a potentially unbounded amount of data. It might be better to just log through stderr unless we're in 'metering' mode, but it's also worth noting that we already get messages out of order through stderr on Windows. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.handle_done): (Manager.handle_finished_test): (Manager._log_messages): * Scripts/webkitpy/layout_tests/controllers/worker.py: (Worker.__init__): (Worker._set_up_logging): (Worker.run): (Worker._run_test): (Worker.cleanup): (Worker.run_single_test): (_WorkerLogHandler): (_WorkerLogHandler.__init__): (_WorkerLogHandler.emit): * Scripts/webkitpy/layout_tests/views/metered_stream.py: (MeteredStream.write): (MeteredStream.writeln): * Scripts/webkitpy/layout_tests/views/printing.py: (Printer.writeln): 2012-06-18 Zan Dobersek [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior https://bugs.webkit.org/show_bug.cgi?id=89362 Reviewed by Simon Fraser. Replace white spaces, braces and dots in the builder name with underscores. This way the JQuery tabs will be properly matched with the according container. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: 2012-06-18 Dirk Pranke nrwt: metered output doesn't handle ^C cleanly https://bugs.webkit.org/show_bug.cgi?id=89249 Reviewed by Tony Chang. If you ctrl-c a running nrwt (w/o --verbose), then all but two characters of the last update are erased, and then we print "interrupted, exiting" as an update, which itself then gets erased. Fix this so that we flush the meter (making the last update persistent, so that we print the ^C for a visual clue), print the interrupt message, and move on ... * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._run_tests): * Scripts/webkitpy/layout_tests/views/metered_stream.py: (MeteredStream.flush): * Scripts/webkitpy/layout_tests/views/printing.py: (Printer._write): (Printer): (Printer.flush): 2012-06-18 Xianzhu Wang [Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android https://bugs.webkit.org/show_bug.cgi?id=89228 Reviewed by Tony Chang. * DumpRenderTree/chromium/LayoutTestController.cpp: * DumpRenderTree/chromium/TestShellAndroid.cpp: 2012-06-18 Mario Sanchez Prada [GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue https://bugs.webkit.org/show_bug.cgi?id=89226 Reviewed by Martin Robinson. Implement increment() and decrement() functions in term of the AtkValue interface, instead of using DumpRenderTreeSupportGtk helper class. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::intValue): (AccessibilityUIElement::minValue): (AccessibilityUIElement::maxValue): (alterCurrentValue): (AccessibilityUIElement::increment): (AccessibilityUIElement::decrement): 2012-06-17 Simon Fraser garden-o-matic 'Results' panel is broken for the Apple platform https://bugs.webkit.org/show_bug.cgi?id=89310 Reviewed by Adam Barth. For platforms that don't use accumulated build directories on the server, carry along buildLocation data with buildInfo, so that we know where to look for the test results files for a given test. Renamed historicalResultsSummaryURLs to historicalResultsLocations because it now returns an array of objects with buildNumber, revision and url info. Fixed results.fetchResultsURLs() to use this data to find results. Fixed the results display to not scroll when you click on a test to see the results. Made the h3s look less ugly Don't try to show the flakiness dashboard for the Apple platform. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: (.results-view .top-panel): (.results-view h3): 2012-06-16 Simon Fraser Make garden-o-matic work for the Apple Mac port https://bugs.webkit.org/show_bug.cgi?id=84642 Reviewed by Adam Barth. Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved educating the scripts in various ways: * Wrap up platform-related differences in config.kPlatforms[] * Add a