2015-09-30 Jason Marcell BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't have an associated trac instance. https://bugs.webkit.org/show_bug.cgi?id=149673 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't have an associated trac instance. 2015-09-30 Daniel Bates Prioritize testing latest build request on iOS test bots https://bugs.webkit.org/show_bug.cgi?id=149669 Reviewed by Darin Adler. We should prioritize testing of the latest build request on the iOS test bots as we do for Mac and Windows test bots. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (loadBuilderConfig): 2015-09-30 Daniel Bates Add buildbot category for iOS builders and testers https://bugs.webkit.org/show_bug.cgi?id=149667 Reviewed by Darin Adler. Group iOS builders and testers under category iOS and add dashboard and console hyperlinks for iOS to the build.webkit.org home page. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (loadBuilderConfig): * BuildSlaveSupport/build.webkit.org-config/templates/root.html: 2015-09-30 Daniel Bates Actually fix the Mac builders build after (https://bugs.webkit.org/show_bug.cgi?id=149539) I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac in . * BuildSlaveSupport/build.webkit.org-config/master.cfg: (CompileWebKit.start): 2015-09-30 Daniel Bates Attempt to fix the Mac builders build after (https://bugs.webkit.org/show_bug.cgi?id=149539) {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32}, respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (CompileWebKit.start): 2015-09-30 Lucas Forschler bot210 was configured for a queue instead of bot126. Unreviewed config.json fix. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-09-30 Lucas Forschler Bring El Capitan buildbot infrastructure online. https://bugs.webkit.org/show_bug.cgi?id=149605 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-09-30 Tomas Popela [GTK] Deprecation warnings in DOMNodeTest https://bugs.webkit.org/show_bug.cgi?id=149663 After the webkit_dom_document_get_elements_by_tag_name deprecation we need to update the tests to use webkit_dom_document_query_selector_all to avoid compilation warnings. Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection (the suggested replacement for the deprecated function). Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: (WebKitDOMNodeTest::testTagNamesNodeList): (WebKitDOMNodeTest::testTagNamesHTMLCollection): (registerTests): (WebKitDOMNodeTest::testTagNames): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: (prepareDOMForTagNamesTests): (testWebKitDOMNodeTagNamesNodeList): (testWebKitDOMNodeTagNamesHTMLCollection): (beforeAll): (testWebKitDOMNodeTagNames): Deleted. 2015-09-29 Simon Fraser WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment https://bugs.webkit.org/show_bug.cgi?id=149650 Reviewed by Tim Horton. TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only looks at the file path, and not the custom options that come from file comments. Fix by computing TestOptions before making the TestInvocation, and setting them as const TestInvocation data. This meant changing various call sites to take the std::string pathOrURL, rather than the TestInvocation itself. Also initialize TestInvocation with a WKURLRef, rather than a std::string. * WebKitTestRunner/CMakeLists.txt: * WebKitTestRunner/TestController.cpp: (WTR::TestController::ensureViewSupportsOptionsForTest): (WTR::testPath): (WTR::createTestURL): (WTR::updateTestOptionsFromTestHeader): (WTR::TestController::testOptionsForTest): (WTR::TestController::updateWebViewSizeForTest): (WTR::TestController::updateWindowScaleForTest): (WTR::TestController::runTest): * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::TestInvocation): (WTR::TestInvocation::invoke): (WTR::createWKURL): Deleted. (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted. (WTR::TestInvocation::shouldUseFixedLayout): Deleted. * WebKitTestRunner/TestInvocation.h: (WTR::TestInvocation::options): * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h. (WTR::pathContains): (WTR::shouldMakeViewportFlexible): (WTR::shouldUseFixedLayout): (WTR::isSVGTestPath): (WTR::isHiDPITestPath): (WTR::TestOptions::TestOptions): * WebKitTestRunner/TestOptions.h: * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * WebKitTestRunner/efl/TestControllerEfl.cpp: (WTR::pathContains): (WTR::shouldUseFixedLayout): (WTR::TestController::updatePlatformSpecificTestOptionsForTest): * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::updatePlatformSpecificTestOptionsForTest): * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::updatePlatformSpecificTestOptionsForTest): * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::updatePlatformSpecificTestOptionsForTest): 2015-09-29 Aakash Jain Flakiness dashboard should support OS X El Capitan https://bugs.webkit.org/show_bug.cgi?id=149648 Reviewed by Alexey Proskuryakov. * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of difference between new appscale and old Google App Engine implementation. * TestResultServer/app.yaml: Same. * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support. 2015-09-29 Daniel Bates configure-xcode-for-ios-development does not work with Xcode 7 https://bugs.webkit.org/show_bug.cgi?id=149640 Reviewed by Alexey Proskuryakov. When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error because it cannot find the Xcode specification files for iOS simulator and device. These files have moved to a new location in Xcode 7 distribution. Moreover we must add the relevant definitions to the Xcode 7 specification files directly as opposed to creating new specification files with the added definitions (as we did in older versions of Xcode) in order for Xcode 7 to honor these definitions. * Scripts/configure-xcode-for-ios-development: Sorted forward declarations. (updateXcodeSpecificationFilesForSDKIfNeeded): Added. (updateXcode7SpecificationFile): Added. (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded. (writeXcodeSpecification): Moved congratulations line to caller so as to write out the appropriate success message. (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId. (createXcodeSpecificationFilesForSDKIfNeeded): Deleted. (createXcodeSpecificationFromSpecificationAndId): Deleted. 2015-09-29 Brent Fulgham [Win] Allow 'prepare-ChangeLog' to be used without Cygwin https://bugs.webkit.org/show_bug.cgi?id=149639 Reviewed by Alex Christensen. * Scripts/VCSUtils.pm: (exitStatus): Use 'isWindows()' method. (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes an error. This method could probably just go away. (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than always changing to Unix style. (unixPath): Added. Needed so Windows can always show a Unix path in the ChangeLog file. (changeLogName): Work around the fact that 'getpwuid' is not available on a pure Windows build of Perl. * Scripts/prepare-ChangeLog: (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix path on Windows. (svnUpdateCommand): Added helper function. Needed because Windows Perl does not support using arrays for 'open' arguments. (resolveChangeLogsPath): Ditto. (resolveConflictedChangeLogs): Use new helper functions. (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output. (diffCommand): Use double-quotes for paths, since Windows doesn't understand single quotes. Unix systems are happy either way. (statusCommand): Ditto. * Scripts/webkitdirs.pm: (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago. 2015-09-29 Brent Fulgham [Win] Unreviewed 64-bit build fix after switch to CMake. * Scripts/webkitdirs.pm: (determineIsWin64FromArchitecture): Added. 2015-09-16 Carlos Garcia Campos printing does not use minimum page zoom factor https://bugs.webkit.org/show_bug.cgi?id=108507 Reviewed by Darin Adler. WebKitTestRunner always takes the snapshots from the UI process (expect for IOS), so in the case of printing, the layout in the web view is not the expected one. When printing, we need to take the snapshot in the web process and ensure it's rendered with a PrintContext. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): When dumping pixels, pass kWKSnapshotOptionsPrinting option to WKBundlePageCreateSnapshotWithOptions() when printing. 2015-09-28 Carlos Garcia Campos [WTR] Pixel tests generate the snapshots twice in Web and UI processes https://bugs.webkit.org/show_bug.cgi?id=149595 Reviewed by Tim Horton. All ports except IOS implement PlatformWebView::windowSnapshotImage() to generate the snapshot for the pixel tests in the UI process. But we are still generating a snapshot for pixel tests in the Web process too, that is passed to the UI process but ignored. Whether a pixel result is needed or not, is only known by the web process depending on whether the test called dumpAsText with dumpPixels == true or not. Since the pixels are now dump in the UI process, we need to pass that information to the UI process when the test is done. For that we set a PixelResultIsPending bool parameter to the Done message, and we only add the PixelResult when UI process doesn't need to generate the pixels dump. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): Set m_pixelResultIsPending to false on reset. (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the Done message, and set the PixelResult if m_pixelResultIsPending is false. * WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false. (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS port. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::dumpResults): Use either the pixel result from the web process or generate a pixel result from the web view if need it. (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum parameter to dumpPixelsAndCompareWithExpected, since the snapshot is created by the caller now, but the CG implementation needs to know if it's a Web or UI process snapshot. * WebKitTestRunner/cairo/TestInvocationCairo.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a cairo surface for the given image. * WebKitTestRunner/cg/TestInvocationCG.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a CGContext for the given image. 2015-09-28 Dean Johnson Fix JS errors on dashboard metrics page https://bugs.webkit.org/show_bug.cgi?id=149608 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings. (initPlatformsByFamily): (updateHiddenPlatforms): (parsePlatformFamily): Deleted. (updateToggleButtons): Deleted. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: (updateHiddenPlatforms): Added to remove errors. (initPlatformsByFamily): Added to remove errors. (unhiddenQueues): Updated to use Settings. (documentReady): Added logic to add toggle buttons to the settings menu. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js: (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and MetricsMain.js to Settings. (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and MetricsMain.js to Settings. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js: (QueueView.prototype._updateHiddenState): Updated to use Settings. 2015-09-28 Aakash Jain Appscale query fails because of missing index https://bugs.webkit.org/show_bug.cgi?id=149609 Reviewed by Darin Adler. * QueueStatusServer/index.yaml: Added the required index. 2015-09-28 Brent Fulgham [Win] Fix the 64-bit build after switch to cmake. Reviewed by Alex Christensen. * Scripts/webkitdirs.pm: (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to run a 64-bit build. 2015-09-28 Brent Fulgham [Win] Allow Windows to run test-webkitpy without Cygwin https://bugs.webkit.org/show_bug.cgi?id=149602 Reviewed by Alex Christensen. These changes mostly shift from hard-coded paths using UNIX-style separators to Python's "os.path.join" syntax that uses the correct path separator for each platform. * Scripts/webkitpy/common/system/path.py: (cygpath): Don't pass paths through Cygpath on native Windows. * Scripts/webkitpy/port/win.py: (WinPort._path_to_apache): Use os.path.join. (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist in 64-bit environments). * Scripts/webkitpy/style/checker.py: Use os.path.join. * Scripts/webkitpy/style/checker_unittest.py: (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join. (GlobalVariablesTest.test_path_rules_specifier): Ditto. (GlobalVariablesTest): Ditto. (GlobalVariablesTest.test_max_reports_per_category): Ditto. (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto. (CheckerDispatcherDispatchTest.test_js_paths): Ditto. (CheckerDispatcherDispatchTest.test_json_paths): Ditto. (CheckerDispatcherDispatchTest.test_python_paths): Ditto. (CheckerDispatcherDispatchTest.test_text_paths): Ditto. (CheckerDispatcherDispatchTest.test_xml_paths): Ditto. (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto. (StyleProcessor_CodeCoverageTest): Ditto. (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto. (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto. (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto. * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than manual string concatenation of paths. 2015-09-28 Csaba Osztrogonác Add bugzilla addresses of committers to contributors.json https://bugs.webkit.org/show_bug.cgi?id=149520 Reviewed by Darin Adler. * Scripts/webkitpy/common/config/contributors.json: 2015-09-28 Csaba Osztrogonác validate-committer-lists -b shouldn't need edituser privileges https://bugs.webkit.org/show_bug.cgi?id=149519 Reviewed by Darin Adler. * Scripts/validate-committer-lists: (CommitterListBugzillaChecker._has_invalid_bugzilla_email): * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (BugzillaQueries.is_invalid_bugzilla_email): (BugzillaQueries): Deleted. (BugzillaQueries.fetch_logins_matching_substring): Deleted. 2015-09-26 Carlos Garcia Campos Unreviewed. Gardening: skip media stream tests failing after r190262. * Scripts/run-gtk-tests: (TestRunner): 2015-09-25 Alexey Proskuryakov [Mac] USE_INTERNAL_SDK is used undefined in tools projects https://bugs.webkit.org/show_bug.cgi?id=149571 Reviewed by Dan Bernstein. Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). * DumpRenderTree/mac/Configurations/Base.xcconfig: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * LayoutTestRelay/Configurations/Base.xcconfig: * MiniBrowser/Configurations/Base.xcconfig: * MiniBrowser/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * WebEditingTester/Configurations/Base.xcconfig: * WebEditingTester/Configurations/DebugRelease.xcconfig: * WebKitTestRunner/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: * WebKitTestRunner/iOS.xcconfig: Removed. 2015-09-25 Eric Carlson Clean up user media request internal API https://bugs.webkit.org/show_bug.cgi?id=149527 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes. * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto. 2015-09-25 Simon Fraser [iOS WK2] Add viewport tests and fix runUIScript() timing issues https://bugs.webkit.org/show_bug.cgi?id=149577 Reviewed by Tim Horton. When calling testRunner.runUIScript() from a page load event, the script could run in the UI process before the current remote layer tree transaction had been handled there. This meant that runUIScript() could query state which was about to change. Fix by delaying the execution of the UI script until a layer tree transaction has been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing(). * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): (WTR::TestInvocation::runUISideScriptAfterUpdateCallback): * WebKitTestRunner/TestInvocation.h: 2015-09-25 Alexey Proskuryakov [Mac] Media tests start to time out after a few days of bot uptime https://bugs.webkit.org/show_bug.cgi?id=149468 Reviewed by Darin Adler. Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache, as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make all temporary and cache files go to a custom location. * Scripts/webkitpy/port/base.py: * Scripts/webkitpy/port/driver.py: * Scripts/webkitpy/port/mac.py: * Scripts/webkitpy/port/win.py: (WinPort._driver_tempdir_for_environment): Deleted unused function. 2015-09-25 Dan Bernstein Removed MiniBrowser.entitlements. Rubber-stamped by Anders Carlsson. The entitlements weren’t used anyway. * MiniBrowser/MiniBrowser.entitlements: Removed. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: 2015-09-24 Daniel Bates Add WebKitSystemInterface for iOS 9.0 https://bugs.webkit.org/show_bug.cgi?id=149550 Rubber-stamped by Alexey Proskuryakov. * Scripts/copy-webkitlibraries-to-product-directory: 2015-09-24 Daniel Bates Support building for arbitrary architectures https://bugs.webkit.org/show_bug.cgi?id=149539 Reviewed by Alexey Proskuryakov. Teach buildbot to pass the architectures associated with the builder to build-webkit when building on OS X and iOS. As a side effect of this change we now support building universal binaries when multiples architectures are specified. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (CompileWebKit.start): 2015-09-24 Daniel Bates Fix the build after (http://trac.webkit.org/changeset/190212) I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct(). * BuildSlaveSupport/built-product-archive: (main): 2015-09-24 Daniel Bates Support running unit tests on iOS Simulator test bot https://bugs.webkit.org/show_bug.cgi?id=149536 Reviewed by Alexey Proskuryakov. Implements support for running unit tests on a iOS test bot. At the time of writing, the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests. (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform. 2015-09-24 Daniel Bates Add support infrastructure for OpenSource iOS builders and testers https://bugs.webkit.org/show_bug.cgi?id=149534 Reviewed by Darin Adler. Towards setting up OpenSource iOS build bots, teach buildbot and its support scripts about iOS. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append --ios-simulator or --device for a builder/tester whose full platform name begins with "ios-simulator" or "ios", respectively. (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags(). * BuildSlaveSupport/built-product-archive: (main): Pass the full platform name to determineWebKitBuildDirectory(). (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate command line flag when building for iOS. (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused parameter fullPlatform. This parameter was originally added in r125066 to support the Chromium Android port, which has since been removed from the OpenSource WebKit Project. (extractBuiltProduct): Use the same logic for iOS as we do for Mac. * BuildSlaveSupport/clean-build: (main): Call script webkit-build-directory with the appropriate command line flag when building for iOS. * BuildSlaveSupport/delete-stale-build-files: (main): Use the same logic for iOS as we do for Mac. (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line flag when building for iOS. * BuildSlaveSupport/test-result-archive: (archiveTestResults): Use the same logic for iOS as we do for Mac. 2015-09-24 Daniel Bates Remove Chromium-specific changes to script built-product-archive https://bugs.webkit.org/show_bug.cgi?id=149530 Rubber-stamped by Csaba Osztrogonác. Reverts changes made in r113074 and r113067 to support Chromium testers. The Chromium code has long since been removed from the OpenSource WebKit Project. * BuildSlaveSupport/built-product-archive: (createZipManually): (createZip): (archiveBuiltProduct): 2015-09-24 Dan Bernstein Build fix. * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: 2015-09-24 Mark Lam Unreviewed. Make Lucas Forschler a WebKit reviewer. * Scripts/webkitpy/common/config/contributors.json: 2015-09-24 Carlos Garcia Campos Unreviewed. Fix GObject DOM API breaks after r190120. Bring back code removed in r169931 to handle documentation of deleted classes. * gtk/webkitdom.py: (WebKitDOMDocGenerator): (WebKitDOMDocGenerator.write_deleted_classes): (WebKitDOMDocGenerator.generate): (write_deleted_classes): (WebKitDOMDocGeneratorSections._deleted_class): (WebKitDOMDocGeneratorSections._deleted_class.in): (WebKitDOMDocGeneratorSections.write_deleted_classes): (WebKitDOMDocGeneratorSections.write_deleted_classes.with): 2015-09-23 Myles C. Maxfield [Cocoa] [Font Features] Implement font-variant-* https://bugs.webkit.org/show_bug.cgi?id=148413 Reviewed by Darin Adler. Update test font to use "lnum" feature. * FontWithFeatures/FontWithFeatures/FontCreator.cpp: (Generator::appendGSUBTable): 2015-09-22 Andy Estes ContentFiltering.AllowDownloadAfterAddData is very flaky https://bugs.webkit.org/show_bug.cgi?id=148885 Reviewed by Alexey Proskuryakov. The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:, but there is no guarantee of this. For tests that should allow a download, spin the runloop until -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures. * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: (downloadTest): 2015-09-22 Alexey Proskuryakov Mavericks: Media tests start to time out after a few days of bot uptime https://bugs.webkit.org/show_bug.cgi?id=149468 Reviewed by Chris Dumez. * Scripts/webkitpy/port/base.py: * Scripts/webkitpy/port/driver.py: * Scripts/webkitpy/port/mac.py: 2015-09-22 Nan Wang Unreviewed, add myself to the committers list. * Scripts/webkitpy/common/config/contributors.json: 2015-09-21 Simon Fraser Remove 'nullable' to fix older iOS builds. * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): 2015-09-21 Brent Fulgham [Win] Show tiled drawing debug overlay on Windows https://bugs.webkit.org/show_bug.cgi?id=149426 Reviewed by Dean Jackson. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto. * MiniBrowser/win/Common.cpp: (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator' flag if needed. * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class. 2015-09-21 Brent Fulgham [Win] Use command-line argument to launch in regular or High DPI mode. https://bugs.webkit.org/show_bug.cgi?id=149417 Reviewed by Dean Jackson. * MiniBrowser/win/Common.cpp: (parseCommandLine): Ignore the '--highDPI' argument. It's used at the very start of execution, before the MiniBrowser.dll is loaded. * win/DLLLauncher/DLLLauncherMain.cpp: (shouldUseHighDPI): Check for '--highDPI', and use this mode if present. On WinCairo, always use High DPI. 2015-09-21 Ryosuke Niwa 32-bit Mac build fix attempt after r190065. * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: 2015-09-21 Alexey Proskuryakov [OS X] Update for Xcode 7.0 on Yosemite https://bugs.webkit.org/show_bug.cgi?id=149389 Reviewed by Dan Bernstein. * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h: Removed unneeded declarations - conforming to a protocol is sufficient. * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Changed the definitions to be compiled whenever the SDK requires it (so we will have dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately). 2015-09-21 Simon Fraser Add the ability for tests to run script in the UI process in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=149356 Reviewed by Tim Horton. This change adds testRunner.runUIScript(script, callback), which allows a test to execute script in a JSContext which runs in the UI process. That context has bindings exposed through the UIScriptController interface; currently one test function, and some iOS-specific functions are included. UIScriptController can be async with a callback, and runUIScript() itself is asynchronous. When the UI script is complete, it calls uiController.uiScriptComplete(result), where 'result' is a string passed back to the web process, and given to the runUIScript() callback function. Thanks to Gyuyoung Kim for help with the Gtk/Efl build. * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript(). * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is complete, call back into TestRunner. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::nextUIScriptCallbackID): (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script. (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function. * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/PlatformWebView.h: * WebKitTestRunner/TestController.cpp: (WTR::updateTestOptionsFromTestHeader): (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument. (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::shouldUseFixedLayout): (WTR::TestInvocation::shouldUseThreadedScrolling): (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): (WTR::TestInvocation::runUISideScript): Run the UI-side script! (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle. * WebKitTestRunner/TestInvocation.h: * WebKitTestRunner/TestOptions.h: * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * WebKitTestRunner/cocoa/TestControllerCocoa.mm: * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h. * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added. (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming. * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS. * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added. (WTR::UIScriptController::doAsyncTask): (WTR::UIScriptController::zoomToScale): (WTR::UIScriptController::zoomScale): (WTR::UIScriptController::minimumZoomScale): (WTR::UIScriptController::maximumZoomScale): (WTR::UIScriptController::contentVisibleRect): * WebKitTestRunner/mac/EventSenderProxy.mm: * WebKitTestRunner/mac/PlatformWebViewMac.mm: (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::updatePlatformSpecificTestOptionsForTest): (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation. * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h: * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process. (UIScriptContext::UIScriptContext): (UIScriptContext::~UIScriptContext): (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything asynchronous, call the callback. (UIScriptContext::nextTaskCallbackID): (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function that has a callback). Has to store the callbackID of the script, so code called from the completion callback knows which UI script invoked it. (UIScriptContext::asyncTaskComplete): Called when one task is finished. (UIScriptContext::uiScriptComplete): (UIScriptContext::objectFromRect): Make a JS object from a rect. * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h. (WTR::UIScriptContext::hasOutstandingAsyncTasks): * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h. (WTR::UIScriptController::UIScriptController): (WTR::UIScriptController::makeWindowObject): (WTR::UIScriptController::wrapperClass): (WTR::UIScriptController::doAsyncTask): (WTR::UIScriptController::zoomToScale): (WTR::UIScriptController::zoomScale): (WTR::UIScriptController::minimumZoomScale): (WTR::UIScriptController::maximumZoomScale): (WTR::UIScriptController::contentVisibleRect): (WTR::UIScriptController::uiScriptComplete): * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h. (WTR::UIScriptController::create): * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h. 2015-09-21 Tim Horton Turn on threaded scrolling by default in the tests https://bugs.webkit.org/show_bug.cgi?id=149377 Reviewed by Simon Fraser. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::updatePlatformSpecificTestOptionsForTest): (WTR::shouldUseThreadedScrolling): Deleted. Turn on threaded scrolling by default. 2015-09-21 Carlos Garcia Campos [GTK] run-gtk-tests doesn't provide feedback about crashing google tests https://bugs.webkit.org/show_bug.cgi?id=149252 Reviewed by Darin Adler. In case of glib tests the test runner notifies about tests crashing, but for google tests we don't get any feedback, which means that in case of a test crashing we get a list of **PASS** messages and at the summary we are notified that the test suite has failed, but it's impossible to know which test cases have failed. * Scripts/run-gtk-tests: (TestRunner._run_google_test): Add a **CRASH** message if test case crashed. 2015-09-20 Alexey Proskuryakov WebKitTestRunner can leak user content script results between tests https://bugs.webkit.org/show_bug.cgi?id=149391 Reviewed by Sam Weinig. Move WKBundlePageRemoveAllUserContent call so that it's executed before loading about:blank, and thus about:blank doesn't have unintended side effects. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::resetAfterTest): 2015-09-20 Alexey Proskuryakov [Mac, iOS] AccessibilityController doesn't uninstall global notification handler https://bugs.webkit.org/show_bug.cgi?id=149384 Reviewed by Chris Fleizach. * DumpRenderTree/ios/AccessibilityControllerIOS.mm: (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code. (AccessibilityController::platformResetToConsistentState): Actually remove the handler, regardless of whether someone else holds a reference (we also call -stopListening in -dealloc). * DumpRenderTree/mac/AccessibilityControllerMac.mm: (AccessibilityController::platformResetToConsistentState): (AccessibilityController::addNotificationListener): Ditto. 2015-09-20 Youenn Fablet Remove XHR_TIMEOUT compilation guard https://bugs.webkit.org/show_bug.cgi?id=149260 Reviewed by Benjamin Poulain. * Scripts/webkitperl/FeatureList.pm: 2015-09-19 Dan Bernstein Attempted build fix. * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: 2015-09-18 Commit Queue Unreviewed, rolling out r189908. https://bugs.webkit.org/show_bug.cgi?id=149368 Broke run-webkit-tests --pixel (Requested by ap on #webkit). Reverted changeset: "printing does not use minimum page zoom factor" https://bugs.webkit.org/show_bug.cgi?id=108507 http://trac.webkit.org/changeset/189908 2015-09-18 Andy Estes [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate https://bugs.webkit.org/show_bug.cgi?id=149360 Reviewed by Tim Horton. Added an API test. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added. (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): (TEST): * TestWebKitAPI/ios/pages.pages: Added. 2015-09-18 Nan Wang AX: Implement ARIA 1.1 @aria-current on iOS https://bugs.webkit.org/show_bug.cgi?id=149297 Reviewed by Chris Fleizach. Added support to test aria-current on iOS. * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::stringAttributeValue): * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::stringAttributeValue): 2015-09-18 Alexey Proskuryakov iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase https://bugs.webkit.org/show_bug.cgi?id=149352 Reviewed by Simon Fraser. * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController): m_context can be null. This may indicate a bug in webkitpy too, but WebKitTestRunner should handle this situation nicely, there is nothing intrinsically wrong with opening and immediately closing it. 2015-09-18 Daniel Bates isGitSVNDirectory() returns true when Git is not installed https://bugs.webkit.org/show_bug.cgi?id=149351 Reviewed by Alexey Proskuryakov. Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if Git is not installed on the machine. * Scripts/VCSUtils.pm: (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with status code 0 (success). 2015-09-18 Alex Christensen Prevent build-webkit from building four times on Windows https://bugs.webkit.org/show_bug.cgi?id=149336 Reviewed by Brent Fulgham. * Scripts/build-webkit: Move the Windows code out of the for loop iterating over each subdirectory to be build. They're built all at once. * Scripts/webkitdirs.pm: (buildVisualStudioProject): (cmakeGeneratedBuildfile): Don't generate the Visual Studio solution if it already exists. It will run CMake again if necessary. 2015-09-17 Simon Fraser [iOS WK2] WTR fails to set the key window in the UIKit sense https://bugs.webkit.org/show_bug.cgi?id=149325 Reviewed by Tim Horton. -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey(). This causes UIKit to bypass code that actually sets the key window, resulting in [UIAppliation sharedApplication].keyWindow always being nil. Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having -[WebKitTestRunnerWindow isKeyWindow] call super. * WebKitTestRunner/PlatformWebView.h: (WTR::PlatformWebView::setWindowIsKey): Deleted. * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: (WTR::PlatformWebView::setWindowIsKey): * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::setWindowIsKey): * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (-[WebKitTestRunnerWindow isKeyWindow]): (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::~PlatformWebView): (WTR::PlatformWebView::setWindowIsKey): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::setWindowIsKey): 2015-09-17 Simon Fraser [iOS WK2] When loading viewport tests, use the normal web page viewport configuration https://bugs.webkit.org/show_bug.cgi?id=149321 Reviewed by Tim Horton. InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally enabled the "testing" viewport configuration, which disables page scaling. If we're running viewport tests, we want the normal web page configuration. Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(), based on whether the test is in a "viewport" directory. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::shouldLogFrameLoadDelegates): (WTR::TestInvocation::shouldLogHistoryClientCallbacks): (WTR::TestInvocation::shouldMakeViewportFlexible): (WTR::TestInvocation::invoke): * WebKitTestRunner/TestInvocation.h: * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::platformConfigureViewForTest): (WTR::shouldMakeViewportFlexible): Deleted. 2015-09-17 Simon Fraser Give iOS WebKitTestRunner a launch storyboard https://bugs.webkit.org/show_bug.cgi?id=149314 Reviewed by Dan Bates. Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes that it's been built for specific device configurations, and puts the window at the top of the screen. This simplifies coordinate conversions in a future patch. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: * WebKitTestRunner/ios/Launch.storyboard: Added. 2015-09-17 Myles C. Maxfield Update licence in r189890 https://bugs.webkit.org/show_bug.cgi?id=149306 Reviewed by Dean Jackson. * FontWithFeatures/FontWithFeatures/FontCreator.cpp: * FontWithFeatures/FontWithFeatures/FontCreator.h: * FontWithFeatures/FontWithFeatures/main.cpp: 2015-09-17 Mark Lam Add the ability to skip JIT stress tests in run-javascriptcore-tests. https://bugs.webkit.org/show_bug.cgi?id=149285 Reviewed by Saam Barati. Just need to add an option to pass --no-jit to run-jsc-stress-test. * Scripts/run-javascriptcore-tests: (runJSCStressTests): 2015-09-17 Alex Christensen Switch AppleWin build to use CMake https://bugs.webkit.org/show_bug.cgi?id=149163 Reviewed by Brent Fulgham. * Scripts/build-webkit: * Scripts/run-api-tests: (runTest): (listAllTests): (prepareEnvironmentForRunningTestTool): (testToolPaths): (testToolPath): Deleted. Run the API tests as separate executables on Windows. It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe. * Scripts/webkitdirs.pm: (checkRequiredSystemConfig): (jhbuildWrapperPrefixIfNeeded): (generateBuildSystemFromCMakeProject): Fix configuration quirks. 2015-09-17 Dean Johnson Added toggle options for hiding and showing certain platform families on the dashboard. https://bugs.webkit.org/show_bug.cgi?id=148403 Reviewed by David Kilzer. This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed individual hide/show buttons for platforms because we've added toggle options to hide/show entire families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed in lieu of an "all" button in the toggle menu. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: (parsePlatformFamily): Helper function to parse out a platform family. (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the page by platformsByFamily[] = . (updateToggleButtons): Updates the status of the toggle buttons. (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms. (documentReady): Added creation of toggle buttons. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: (unhiddenQueues): Updated to search by platform family instead of the individual platform name. (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies. (updateHiddenPlatforms): Deleted. After removing the individual hide button code, this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js: (QueueView): Updated to use hiddenPlatformFamilies. (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js: (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables. (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events. (Settings.prototype.toggleHiddenPlatform): Deleted. (Settings.prototype.clearHiddenPlatforms): Deleted. (Settings.prototype.toggleShowPlatformFamily): Deleted. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton): (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide): (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper): (table.queue-grid tr.headers th): (div.settingsWrapper.hide): (div.settingsWrapper): (div.familyToggleWrapper): (div.platformFamilyToggleButton): (div.platformFamilyShowToggleButton:not(:last-child)): (div.familyShown): (div.accessibilityButton): (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class. (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class. (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added platformFamilyToggleButton and settingsWrapper class. (.accessibilityButton): Deleted. 2015-09-17 Tim Horton Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture https://bugs.webkit.org/show_bug.cgi?id=148904 Reviewed by Myles Maxfield. * WebKitTestRunner/TestController.cpp: (WTR::parseBooleanTestHeaderValue): (WTR::updateViewOptionsFromTestHeader): Check for the key "useThreadedScrolling". Add some code to check for "true" and "false" for boolean options. (WTR::TestController::viewOptionsForTest): Apply the test's overrides last, even after the platform's. 2015-09-16 Carlos Garcia Campos printing does not use minimum page zoom factor https://bugs.webkit.org/show_bug.cgi?id=108507 Reviewed by Darin Adler. WebKitTestRunner always takes the snapshots from the UI process (expect for IOS), so in the case of printing, the layout in the web view is not the expected one. When printing, we need to take the snapshot in the web process and ensure it's rendered with a PrintContext. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): When dumping pixels, pass kWKSnapshotOptionsPrinting option to WKBundlePageCreateSnapshotWithOptions() when printing. When not printing, don't even create the snapshot, since it will be ignored by the UI process that always creates its own from the WebView (expect for IOS platform) * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::dumpResults): Use always the snapshot image received from the web process if any when comparing pixel results. Now we only receive a snapshot from the web process in case of printing, or when platform is IOS. Otherwhise, generate the snapshot from the WebView as usual. * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum parameter to dumpPixelsAndCompareWithExpected, since the snapshot is created by the caller now, but the CG implementation needs to know if it's a Web or UI process snapshot. * WebKitTestRunner/cairo/TestInvocationCairo.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a cairo surface for the given image. * WebKitTestRunner/cg/TestInvocationCG.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a CGContext for the given image. 2015-09-16 Myles C. Maxfield Create a font which can be used for testing font features https://bugs.webkit.org/show_bug.cgi?id=149237 Reviewed by Simon Fraser. This patch adds a new project in the Tools/ directory which generates a font which can be used for testing font features. This is a standalone project consisting of two files: 1. A file which actually generates the byte vector representing the font. This file has a single public function: std::vector generateFont(). This file is not platform specific, and only relies on the C++ STL. 2. A file with a main() which calls generateFont() and writes out the font, as well as uses the font to render some demonstration text into a .png file. This file is platform specific. The font itself only supports the following characters: ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz However, the shape of these letters are either an X or a check mark. The letter "A" always is a check mark. The letter "B" always is an X. Without any font features turned on, the rest of the letters are shown as X. Each font feature has an letter associated with it. When the font feature is enabled, that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown as a check mark. Here are the mappings of font features to letters: liga: C clig: D dlig: E hlig: F calt: G subs: H sups: I smcp: J c2sc: K pcap: L c2pc: M unic: N titl: O onum: P pnum: Q tnum: R frac: S afrc: T ordn: U zero: V hist: W jp78: X jp83: Y jp90: Z jp04: a smpl: b trad: c fwid: d pwid: e ruby: f * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added. * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added. (integralLog2): (roundDownToPowerOfTwo): (isFourByteAligned): (clampTo): (append32): (writeCFFEncodedNumber): (CFFBuilder::CFFBuilder): (CFFBuilder::takeResult): (CFFBuilder::moveTo): (CFFBuilder::lineTo): (CFFBuilder::curveToCubic): (CFFBuilder::closePath): (CFFBuilder::writePoint): (generateBoxCharString): (generateCheckCharString): (generateXCharString): (charStringForGlyph): (Generator::generate): (Generator::Placeholder::Placeholder): (Generator::Placeholder::populate): (Generator::Placeholder::~Placeholder): (Generator::placeholder): (Generator::append16): (Generator::append32): (Generator::append32BitCode): (Generator::overwrite16): (Generator::overwrite32): (Generator::appendCFFTable): (Generator::appendSubstitutionSubtable): (Generator::appendScriptSubtable): (Generator::appendGSUBTable): (Generator::appendOS2Table): (Generator::appendFormat12CMAPTable): (Generator::appendFormat4CMAPTable): (Generator::appendCMAPTable): (Generator::appendHEADTable): (Generator::appendHHEATable): (Generator::appendHMTXTable): (Generator::appendMAXPTable): (Generator::appendNAMETable): (Generator::appendPOSTTable): (Generator::calculateChecksum): (Generator::appendTable): (generateFont): * FontWithFeatures/FontWithFeatures/FontCreator.h: Added. * FontWithFeatures/FontWithFeatures/main.cpp: Added. (drawTextWithFeature): (main): 2015-09-16 Commit Queue Unreviewed, rolling out r189875 and r189878. https://bugs.webkit.org/show_bug.cgi?id=149235 cygwin cmake build not ready yet (Requested by alexchristensen on #webkit). Reverted changesets: "Switch AppleWin build to use CMake" https://bugs.webkit.org/show_bug.cgi?id=149163 http://trac.webkit.org/changeset/189875 "Cygwin build fix after r189875" http://trac.webkit.org/changeset/189878 2015-09-16 Alex Christensen Cygwin build fix after r189875 * Scripts/build-webkit: * Scripts/webkitdirs.pm: (jhbuildWrapperPrefixIfNeeded): (generateBuildSystemFromCMakeProject): Make things work with cygwin and cmake. 2015-09-16 Alex Christensen Switch AppleWin build to use CMake https://bugs.webkit.org/show_bug.cgi?id=149163 Reviewed by Brent Fulgham. * Scripts/build-webkit: Build with CMake. * Scripts/run-api-tests: (runTest): (listAllTests): (prepareEnvironmentForRunningTestTool): (testToolPaths): (testToolPath): Deleted. Run the API tests as separate executables on Windows. It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe. 2015-09-16 Alexey Proskuryakov Add newer build.webkit.org pages to robots.txt https://bugs.webkit.org/show_bug.cgi?id=149219 Reviewed by Darin Adler. Indexing bot watcher's dashboard can't be good. * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt: 2015-09-16 Alex Christensen Rollout r189851 and 189853 because they didn’t actually fix the permissions issue * BuildSlaveSupport/built-product-archive: (unzipArchive): 2015-09-16 Csaba Osztrogonác [EFL] Fix the help message of separated web process option of MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=149212 Reviewed by Gyuyoung Kim. * MiniBrowser/efl/main.c: 2015-09-16 Alex Christensen Fix python syntax after r189851. * BuildSlaveSupport/built-product-archive: (unzipArchive): For loops need a colon. 2015-09-15 Alex Christensen Fix Windows test bots after changing to non-cygwin build https://bugs.webkit.org/show_bug.cgi?id=149196 Reviewed by Daniel Bates. * BuildSlaveSupport/built-product-archive: (unzipArchive): Using different versions of python makes what I think is https://bugs.python.org/issue15795 prevent us from executing files from the archive on the test bots. 2015-09-15 Ryosuke Niwa Add ShadowRoot interface and Element.prototype.attachShadow https://bugs.webkit.org/show_bug.cgi?id=149187 Reviewed by Antti Koivisto. * Scripts/webkitperl/FeatureList.pm: 2015-09-15 Aakash Jain Appscale queue status json output lacks bots https://bugs.webkit.org/show_bug.cgi?id=149194 Reviewed by Alexey Proskuryakov. * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine. * QueueStatusServer/index.yaml: Index according to appscale requirements. 2015-09-15 Brent Fulgham [Win] Provide a means for viewing the layer tree https://bugs.webkit.org/show_bug.cgi?id=149165 Reviewed by Simon Fraser. Update MiniBrowser with a new Debug menu option that will dump the current layer tree to the debug console. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: * MiniBrowser/win/Common.cpp: (WndProc): Add handler for 'Print Layer Tree' menu option. * MiniBrowser/win/MiniBrowser.cpp: (MiniBrowser::printLayerTree): Added Handler. * MiniBrowser/win/MiniBrowser.h: 2015-09-14 Myles C. Maxfield WebKitTestRunner declarative language setting is broken for iOS https://bugs.webkit.org/show_bug.cgi?id=149119 Unreviewed. In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was lost in the final version which got committed. This simply implements the existing OS X behavior on iOS. * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: (WTR::InjectedBundle::platformInitialize): 2015-09-14 Dewei Zhu Unreviewed, add myself to committers list. * Scripts/webkitpy/common/config/contributors.json: 2015-09-12 Myles C. Maxfield [Cocoa] Allow testing with the system language https://bugs.webkit.org/show_bug.cgi?id=148671 Reviewed by Anders Carlsson and Alexey Proskuryakov. React to tests marked with language=lang1,lang2,etc in their header. Once this information is parsed, pass it to WKContextConfigurationSetOverrideLanguages(). * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize): Don't clobber the language list. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createWebViewWithOptions): Call WKContextConfigurationSetOverrideLanguages(). (WTR::updateTestOptionsFromTestHeader): Inspect the language option. * WebKitTestRunner/TestOptions.h: * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language option to restart the web process. * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::viewSupportsOptions): Ditto. 2015-09-12 Myles C. Maxfield [WKTR] Allow changing the WKContextConfiguration between successive tests https://bugs.webkit.org/show_bug.cgi?id=148833 Reviewed by Tim Horton. Previously, we were creating a single WKContext and it lived for the life of the entire test runner. However, there are certain tests which require specifying options in this object. This patch makes our existing code for recreating the test runner web view also recreate the WKContext. As such, our options to the view are now options to the WKContextConfiguration. This patch renames the class. * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h. * WebKitTestRunner/PlatformWebView.h: (WTR::PlatformWebView::options): * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): (WTR::TestController::generateContextConfiguration): (WTR::TestController::generatePageConfiguration): (WTR::TestController::createWebViewWithOptions): (WTR::TestController::ensureViewSupportsOptionsForTest): (WTR::updateContextConfigurationOptionsFromTestHeader): (WTR::TestController::contextConfigurationOptionsForTest): (WTR::TestController::platformCreateWebView): (WTR::TestController::platformCreateOtherPage): (WTR::updateViewOptionsFromTestHeader): Deleted. (WTR::TestController::viewOptionsForTest): Deleted. * WebKitTestRunner/TestController.h: (WTR::TestController::injectedBundlePath): (WTR::TestController::testPluginDirectory): * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateWebView): (WTR::TestController::platformCreateOtherPage): * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::viewSupportsOptions): * WebKitTestRunner/efl/TestControllerEfl.cpp: (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest): (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted. * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::viewSupportsOptions): * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest): (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted. * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::viewSupportsOptions): * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest): (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted. * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::viewSupportsOptions): * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest): (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted. 2015-09-11 Michael Saboff LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor https://bugs.webkit.org/show_bug.cgi?id=149083 Reviewed by Alexey Proskuryakov. Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it. * DumpRenderTree/mac/LayoutTestHelper.m: (colorProfileURLForDisplay): 2015-09-11 Saam barati There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests https://bugs.webkit.org/show_bug.cgi?id=149058 Reviewed by Geoffrey Garen. * Scripts/run-jsc-stress-tests: 2015-09-10 Commit Queue Unreviewed, rolling out r189595. https://bugs.webkit.org/show_bug.cgi?id=149052 The tests still fail (Requested by ap on #webkit). Reverted changeset: "Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1" https://bugs.webkit.org/show_bug.cgi?id=142929 http://trac.webkit.org/changeset/189595 2015-09-10 Alexey Proskuryakov Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1 https://bugs.webkit.org/show_bug.cgi?id=142929 Reviewed by Brent Fulgham. Silence the logging. We'll track fixing the root cause in Radar. * Scripts/webkitpy/port/mac.py: (MacPort.stderr_patterns_to_strip): Added a FIXME. * Scripts/webkitpy/port/win.py: (WinPort.logging_patterns_to_strip): Added. 2015-09-09 Andy Estes [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision https://bugs.webkit.org/show_bug.cgi?id=149022 Reviewed by Daniel Bates. Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes did not account for this. * Scripts/webkitpy/xcode/simulator.py: (Simulator): Optionally matched a revision at the end of a runtime version number. * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test. 2015-09-09 Andy Estes [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed https://bugs.webkit.org/show_bug.cgi?id=149029 Reviewed by Daniel Bates. * Scripts/webkitpy/xcode/simulator.py: (Simulator): Taught to parse tvOS runtimes. * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests. 2015-09-09 Alexey Proskuryakov Fix bit rot on bot watcher's dashboard page https://bugs.webkit.org/show_bug.cgi?id=149012 Reviewed by Tim Horton. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: The code path used by the metrics page was trying to add properties to an undefined. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Silence an expection that would occur when the step has no logs. This should never happen, but it did (perhaps buildbot was misconfigured for a while). 2015-09-09 Alexey Proskuryakov Update LayoutTestRelay xcconfig file. Rubber-stamped by Dan Bernstein. * LayoutTestRelay/Configurations/DebugRelease.xcconfig: 2015-09-09 Saam barati DFG should have a debugging option that runs a phase that flushes all locals https://bugs.webkit.org/show_bug.cgi?id=148916 Reviewed by Filip Pizlo. * Scripts/run-jsc-stress-tests: 2015-09-09 Commit Queue Unreviewed, rolling out r189530 and r189534. https://bugs.webkit.org/show_bug.cgi?id=148996 Caused assertion failures on Yosemite (Requested by litherum on #webkit). Reverted changesets: "[WKTR] Allow changing the WKContextConfiguration between successive tests" https://bugs.webkit.org/show_bug.cgi?id=148833 http://trac.webkit.org/changeset/189530 "[Cocoa] Fix the tests after r189530" http://trac.webkit.org/changeset/189534 2015-09-08 Myles C. Maxfield [Cocoa] Fix the tests after r189530 Unreviewed. * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::initializeWebViewConfiguration): 2015-09-08 Myles C. Maxfield [WKTR] Allow changing the WKContextConfiguration between successive tests https://bugs.webkit.org/show_bug.cgi?id=148833 Reviewed by Tim Horton. Previously, we were creating a single WKContext and it lived for the life of the entire test runner. However, there are certain tests which require specifying options in this object. This patch makes our existing code for recreating the test runner web view also recreate the WKContext. As such, our options to the view are now options to the WKContextConfiguration. This patch renames the class. * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h. * WebKitTestRunner/PlatformWebView.h: (WTR::PlatformWebView::options): * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): (WTR::TestController::generateContextConfiguration): (WTR::TestController::generatePageConfiguration): (WTR::TestController::createWebViewWithOptions): (WTR::TestController::ensureViewSupportsOptionsForTest): (WTR::updateContextConfigurationOptionsFromTestHeader): (WTR::TestController::contextConfigurationOptionsForTest): (WTR::TestController::platformCreateWebView): (WTR::TestController::platformCreateOtherPage): (WTR::updateViewOptionsFromTestHeader): Deleted. (WTR::TestController::viewOptionsForTest): Deleted. * WebKitTestRunner/TestController.h: (WTR::TestController::injectedBundlePath): (WTR::TestController::testPluginDirectory): * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateWebView): (WTR::TestController::platformCreateOtherPage): * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::viewSupportsOptions): * WebKitTestRunner/efl/TestControllerEfl.cpp: (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest): (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted. * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::viewSupportsOptions): * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest): (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted. * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::viewSupportsOptions): * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest): (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted. * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::viewSupportsOptions): * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest): (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted. 2015-09-08 Daniel Bates [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=148980 Reviewed by Alexey Proskuryakov. Add setting to enable/disable accelerated drawing so as to support testing this feature in MiniBrowser on Mac. * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): Add menu item. (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled. (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added. (-[SettingsController acceleratedDrawingEnabled]): Added. * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2. 2015-09-08 Jason Marcell Unreviewed. Added myself as a commiter in contributors.json. * Scripts/webkitpy/common/config/contributors.json: 2015-09-08 Keith Miller Unreviewed, added myself to the list of contributors. * Scripts/webkitpy/common/config/contributors.json: 2015-09-08 Daniel Bates Dashboard: Remove use of z-index for ring overlay; use DOM ordering https://bugs.webkit.org/show_bug.cgi?id=148921 Reviewed by Alexey Proskuryakov. The ring image is positioned above the platform icon in markup and we specify the CSS property z-index for the ring image so that it is painted on top of the platform icon instead of below it (by DOM ordering). Instead we can take advantage of the transparency of the ring image, switch the order of these DOM elements and remove the use of the CSS property z-index to achieve a similar effect. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: (documentReady): Create the platform icon image element before the ring image such that the ring image is painted on top of the platform icon. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: (table.queue-grid td.logo img.ring): Removed property z-index. 2015-09-08 Daniel Bates Dashboard: Remove duplicate gear icon data URLs https://bugs.webkit.org/show_bug.cgi?id=148920 Reviewed by Alexey Proskuryakov. Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property background-image associated with each of the three gear icon states: collapsed (.settings), hover (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon as a mask and make use of the CSS background-color to define the fill color for each of these three states. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: (.settings): Use gear icon as mask and define CSS background-color for collapsed state. (.settings:hover): Override CSS background-color for hover state. (.settings-visible .settings): Override CSS background-color for expanded state. 2015-09-07 Andy Estes [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11 https://bugs.webkit.org/show_bug.cgi?id=148946 Reviewed by Dan Bernstein. * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: 2015-09-07 Hunseop Jeong [EFL] Many of the css3/device-adapt/* tests failed after r188548. https://bugs.webkit.org/show_bug.cgi?id=148927 Reviewed by Csaba Osztrogonác. device-adapt/* tests need the fixedLayout option but useFixedLayout option is overwritten by updatePlatformSpecificViewOptionsForTest after r188548. * WebKitTestRunner/TestController.cpp: (WTR::shouldUseFixedLayout): Removed the unnecessary indentations. * WebKitTestRunner/efl/TestControllerEfl.cpp: (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'. 2015-09-07 Andy Estes Fix the Production build after r189455. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the In-App Purchase template instead of the Aggregate template. Whoops. 2015-09-06 Andy Estes WebKit.xcworkspace should be be able to build iOS platforms https://bugs.webkit.org/show_bug.cgi?id=148881 Reviewed by Daniel Bates. Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build for all supported platforms. * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS. * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac. * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries. 2015-09-06 Andy Estes WebKitTestRunner should build for iOS using the default target https://bugs.webkit.org/show_bug.cgi?id=148918 Reviewed by Daniel Bates. When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants. This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)), and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform. WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and WebKitTestRunner is skipped when installing on iOS. The target dependency graph now looks like this: All WebKitTestRunnerApp WebKitTestRunner (Library) WebKitTestRunnerInjectedBundle Derived Sources WebKitTestRunner WebKitTestRunner (Library) WebKitTestRunnerInjectedBundle Derived Sources * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS. * Scripts/build-webkittestrunner: Ditto. * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator. * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets. * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH. * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here, excluded iOS-only files, and skipped installing on iOS. * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here, excluded Mac-only files, and skipped installing on Mac. * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always. * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added new configuration files. 2015-09-05 Joseph Pecoraro Web Inspector: Improve prepare-ChangeLog for multiple cases https://bugs.webkit.org/show_bug.cgi?id=148875 Reviewed by Timothy Hatcher. * Scripts/prepare-ChangeLog: (get_function_line_ranges_for_javascript): - We were ignoring everything inside of an anonymous function expression, such as (function(){ ... }), which made InjectedScriptSource produce nothing. Better handle this by inserting a few tweaks. - Allow method syntax outside of classes as long as they are at the global level. - Avoid treating "get" and "set" as getter/setter functions in bad contexts. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: (Foo.prototype.method1): (Foo.prototype.method2): (Foo.prototype.method3.innerFunction): (Foo.prototype.method3): (insideGlobalAnonymousFunctionExpression): (foo.insideGlobalFunctionExpression): (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1): (IssueWithMapGetAndSet.prototype.method1): (IssueWithMapGetAndSet.prototype.method2): (IssueWithMapGetAndSet.prototype.method3): (IssueWithMapGetAndSet): 2015-09-05 Yusuke Suzuki [ES6] Enable ES6 Module in JSC shell by default https://bugs.webkit.org/show_bug.cgi?id=148689 Reviewed by Geoffrey Garen. * Scripts/run-javascriptcore-tests: (runJSCStressTests): * Scripts/run-jsc-stress-tests: 2015-09-04 Basile Clement Unreviewed, change my email address. * Scripts/webkitpy/common/config/contributors.json: 2015-09-04 Beth Dakin Should have a test to make sure links don't navigate after a cancelled force click https://bugs.webkit.org/show_bug.cgi?id=148846 Reviewed by Tim Horton. New EventSender function for a started then cancelled force click. * WebKitTestRunner/EventSenderProxy.h: * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::mouseForceClick): (WTR::EventSendingController::startAndCancelMouseForceClick): (WTR::EventSendingController::mouseForceDown): * WebKitTestRunner/InjectedBundle/EventSendingController.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::mouseForceClick): (WTR::EventSenderProxy::startAndCancelMouseForceClick): (WTR::EventSenderProxy::mouseForceDown): (WTR::EventSenderProxy::mouseMoveTo): 2015-09-04 Tim Horton Add a test for r179736 (programmatic navigation during swipe causing a crash) https://bugs.webkit.org/show_bug.cgi?id=148830 Reviewed by Beth Dakin. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): Make sure that TestRunner callbacks don't leak between tests! 2015-09-04 Anders Carlsson It should be possible to pass relative HTTP test paths to DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=148825 Reviewed by Tim Horton. Convert the path to an absolute path if needed. * DumpRenderTree/mac/DumpRenderTree.mm: (computeTestURL): 2015-09-04 Jason Marcell Fix Swift unit tests for prepare-ChangeLog. https://bugs.webkit.org/show_bug.cgi?id=148817 Reviewed by Alexey Proskuryakov. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed Swift unit tests for prepare-ChangeLog. 2015-09-04 Lucas Forschler Modifications to the webkit-nightly logic. * WebKitLauncher/WebKitNightlyEnablerSparkle.m: (updateAlertPanel): * WebKitLauncher/main.m: (displayErrorAndQuit): 2015-09-04 Beth Dakin Speculative build fix. * WebKitTestRunner/mac/EventSenderProxy.mm: 2015-09-04 Brian Burg Web Inspector: InspectorController should support multiple frontend channels https://bugs.webkit.org/show_bug.cgi?id=148538 Reviewed by Joseph Pecoraro. InspectorClients must explicitly disconnect their frontend channel(s) from the inspected page's InspectorController. To make this possible, DumpRenderTree should not destroy non-primary views until it has tried to close any abandoned Web Inspector instances. Performing teardown in the reverse order prevents disconnection of the frontend channel because that prematurely destroys the inspector frontend client. * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): 2015-09-04 Beth Dakin Need to be able to test default behaviors on force click https://bugs.webkit.org/show_bug.cgi?id=148758 Reviewed by Tim Horton. This patch adds a new eventSender method to do a full, completed force click, and it re-works all of the existing force methods to dispatch their events in such a way that they will trigger the NSImmediateAction gesture recognizer. To do this, first we need to send the events to the app rather than straight to the view, and also needed to tweak some state and send the events in a delayed fashion. New public function mouseForceClick() and private helper functions to make NSEvents. * WebKitTestRunner/EventSenderProxy.h: New public function mouseForceClick(). * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::mouseMoveTo): (WTR::EventSendingController::mouseForceClick): (WTR::EventSendingController::mouseForceDown): * WebKitTestRunner/InjectedBundle/EventSendingController.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): initPressureEventAtLocation needs to take a stageTransition and a window. * WebKitTestRunner/mac/EventSenderProxy.mm: (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]): (-[EventSenderSyntheticEvent stageTransition]): (-[EventSenderSyntheticEvent timestamp]): (-[EventSenderSyntheticEvent _cgsEventRecord]): (-[EventSenderSyntheticEvent window]): In order to enter the gesture recognizer, we need to start with a mouse down that has a NSEventMaskPressure modifier. (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents): This ensures that the events queue properly for the force monitor in AppKit. (WTR::spinRunLoopForForce): We need to start the pressure change events with a began. (WTR::EventSenderProxy::beginPressureEvent): These functions can be used to create the NSEvent for a pressure change every time we need one. (WTR::EventSenderProxy::pressureChangeEvent): Send the right series of events to emulate a full, completed force click. (WTR::EventSenderProxy::mouseForceClick): Use all of the new things for these existing functions. (WTR::EventSenderProxy::mouseForceDown): (WTR::EventSenderProxy::mouseForceUp): (WTR::EventSenderProxy::mouseForceChanged): Set NSFakeForceTouchDevice to YES. * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting): 2015-09-04 Jason Marcell prepare-ChangeLog needs to know how to parse Swift files. https://bugs.webkit.org/show_bug.cgi?id=148784 Reviewed by Darin Adler. * Scripts/prepare-ChangeLog: (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift. (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code. (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments. * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto. (freeFunction): Ditto. (MyClass.function): Ditto. (MyClass.functionWithArgument(_:)): Ditto. (MyClass.functionWithMoreArguments(_:arg2:)): Ditto. (MyClass.functionWithNamedFirstArgument(argument:)): Ditto. (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto. (MyClass.classFunction): Ditto. (MyClass.readWriteComputedVariable): Ditto. (MyClass.readOnlyComputedVariable): Ditto. 2015-09-04 Ryosuke Niwa Import css/css-color-3 https://bugs.webkit.org/show_bug.cgi?id=148803 Reviewed by Chris Dumez. Fixed a bug that the imported reference files used the same extention as tests. This would result in parsing errors if the tests were XML and references were HTML and vice versa. * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.find_importable_tests): 2015-09-03 Commit Queue Unreviewed, rolling out r189338. https://bugs.webkit.org/show_bug.cgi?id=148785 Caused tons of crashes (Requested by cdumez on #webkit). Reverted changeset: "Web Inspector: InspectorController should support multiple frontend channels" https://bugs.webkit.org/show_bug.cgi?id=148538 http://trac.webkit.org/changeset/189338 2015-09-03 Brian Burg Web Inspector: InspectorController should support multiple frontend channels https://bugs.webkit.org/show_bug.cgi?id=148538 Reviewed by Joseph Pecoraro. InspectorClients must explicitly disconnect their frontend channel(s) from the inspected page's InspectorController. To make this possible, DumpRenderTree should not destroy non-primary views until it has tried to close any abandoned Web Inspector instances. Performing teardown in the reverse order prevents disconnection of the frontend channel because that prematurely destroys the inspector frontend client. * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): 2015-09-03 Timothy Hatcher Update WebKit nightly icon to be more like Safari https://bugs.webkit.org/show_bug.cgi?id=148768 Reviewed by Joseph Pecoraro. * WebKitLauncher/webkit.icns: 2015-09-03 Geoffrey Garen JavaScriptCore should have some ES6 conformance tests https://bugs.webkit.org/show_bug.cgi?id=148771 Reviewed by Chris Dumez. * Scripts/run-javascriptcore-tests: (runJSCStressTests): Added es6 as a test suite. * Scripts/run-jsc-stress-tests: Added es6 as a test suite. Some of these tests currently fail, so I also added a way to expect failure for now. We'll migrate failing tests to expected passes as we fix them. 2015-09-03 Tim Horton Add a test for swipe-start hysteresis https://bugs.webkit.org/show_bug.cgi?id=148756 Reviewed by Anders Carlsson. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::cacheTestRunnerCallback): (WTR::TestRunner::clearTestRunnerCallbacks): * WebKitTestRunner/InjectedBundle/TestRunner.h: Make sure that we log if a client tries to install a callback twice (since we use .add, the second call would not work). Also, add clearTestRunnerCallbacks so tests can swap out installed callbacks. 2015-09-03 Anders Carlsson DumpRenderTree should automatically compute HTTP URLs for HTTP tests https://bugs.webkit.org/show_bug.cgi?id=148746 rdar://problem/22568073 Reviewed by Tim Horton. * DumpRenderTree/mac/DumpRenderTree.mm: (computeTestURL): Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests. (runTest): Call computeTestURL. (testPathFromURL): Get rid of this; computeTestURL does this for us now. * Scripts/webkitpy/port/driver.py: (Driver._command_from_driver_input): Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now. 2015-09-03 Tim Horton Swipe tests fail on Mavericks https://bugs.webkit.org/show_bug.cgi?id=148752 Reviewed by Beth Dakin. * WebKitTestRunner/mac/EventSenderProxy.mm: 2015-09-03 Tim Horton Fix the 32-bit build * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::setNavigationGesturesEnabled): 2015-09-03 Tim Horton Remove some logging that wasn't meant to be in the tree * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases): 2015-09-03 Tim Horton [Mac] Add support for testing swipes https://bugs.webkit.org/show_bug.cgi?id=148700 Reviewed by Beth Dakin. * WebKitTestRunner/EventSenderProxy.h: * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::cgEventPhaseFromString): (WTR::cgEventMomentumPhaseFromString): (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases): * WebKitTestRunner/InjectedBundle/EventSendingController.h: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::installDidBeginSwipeCallback): (WTR::TestRunner::installWillEndSwipeCallback): (WTR::TestRunner::installDidEndSwipeCallback): (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback): (WTR::TestRunner::callDidBeginSwipeCallback): (WTR::TestRunner::callWillEndSwipeCallback): (WTR::TestRunner::callDidEndSwipeCallback): (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): (WTR::TestController::didReceiveMessageFromInjectedBundle): (WTR::TestController::didBeginNavigationGesture): (WTR::TestController::willEndNavigationGesture): (WTR::TestController::didEndNavigationGesture): (WTR::TestController::didRemoveNavigationGestureSnapshot): * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didBeginSwipe): (WTR::TestInvocation::willEndSwipe): (WTR::TestInvocation::didEndSwipe): (WTR::TestInvocation::didRemoveSwipeSnapshot): * WebKitTestRunner/TestInvocation.h: Add callbacks when navigation gestures didBegin/willEnd/didEnd, and when the snapshot is removed. Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent mouseScrollBy function. * WebKitTestRunner/mac/EventSenderProxy.mm: (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]): (-[EventSenderSyntheticEvent type]): (-[EventSenderSyntheticEvent subtype]): (-[EventSenderSyntheticEvent locationInWindow]): (-[EventSenderSyntheticEvent location]): (-[EventSenderSyntheticEvent momentumPhase]): (-[EventSenderSyntheticEvent _isTouchesEnded]): (-[EventSenderSyntheticEvent _cgsEventRecord]): Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some more adjustable values. (WTR::EventSenderProxy::mouseForceDown): (WTR::EventSenderProxy::mouseForceUp): (WTR::EventSenderProxy::mouseForceChanged): Adopt EventSenderSyntheticEvent. (WTR::nsEventPhaseFromCGEventPhase): (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases): Make use of EventSenderSyntheticEvent to synthesize swipe gesture events. * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::PlatformWebView): Enable swipe. 2015-09-03 Myles C. Maxfield [WK2] Allow tagging tests with metadata which needs to be known at web process creation time https://bugs.webkit.org/show_bug.cgi?id=148723 Reviewed by Anders Carlsson. * WebKitTestRunner/TestController.cpp: (WTR::testPath): (WTR::updateViewOptionsFromTestHeader): (WTR::TestController::viewOptionsForTest): 2015-09-03 Lucas Forschler Test commit. 2015-09-02 Tim Horton Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=148693 Reviewed by Anders Carlsson. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): 2015-09-02 Carlos Garcia Campos REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes https://bugs.webkit.org/show_bug.cgi?id=148529 Reviewed by Darin Adler. When there are pending EventSender messages after a test finishes, they could be processed in the main loop started by the resetStateToConsistentValues(), but the old EventSender has been replaced by a new one at that point. The new Eventsender can crash when processing messages that were sent to the old one. To avoid this, we return early when receiving an EventSender message and the TestController state is not RunningTest. * WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): (WTR::TestController::didReceiveMessageFromInjectedBundle): 2015-09-02 Carlos Garcia Campos REGRESSION(r188548): TestController state is Resseting while tests are running after r188548 https://bugs.webkit.org/show_bug.cgi?id=148528 Reviewed by Darin Adler. Before r188548 resetStateToConsistentValues() was called in TestController::run(), before tests are run, but now it's called for every test in TestInvocation::invoke(), after m_status has changed to RunningTest. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Use TemporaryChange to reset m_state ot its previous value after reset is done. 2015-08-31 Jason Marcell Modify prepare-Changelog to be aware of files that are marked as tests as well as files that are marked as requiring corresponding tests. https://bugs.webkit.org/show_bug.cgi?id=148498 Reviewed by Dan Bernstein and David Kilzer. * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to simulate Git's attribute behevaior. (main): Added "requiresTests" array to contain files that require tests. (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests" section in ChangeLog. (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion, however, we check if the file or any containing folder has the given property set to "1" and return 1 if so; return 0 otherwise. (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also adds files to "addedRegressionTests" array if "test" attribute is set to "1". 2015-08-26 Andy Estes [Content Filtering] Determine navigation and content policy before continuing to filter a load https://bugs.webkit.org/show_bug.cgi?id=148506 Reviewed by Brady Eidson. Added download API tests covering every decision and decision point. Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests. * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path. * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here. * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type. * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter decision and decision point as a bundle parameter. (+[MockContentFilterEnabler supportsSecureCoding]): (-[MockContentFilterEnabler copyWithZone:]): (-[MockContentFilterEnabler initWithCoder:]): (-[MockContentFilterEnabler initWithDecision:decisionPoint:]): (-[MockContentFilterEnabler encodeWithCoder:]): (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings. (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect. (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload. (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true. (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto. (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true. (downloadTest): Added a helper function to test downloads with a given decision and decision point. * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport. (+[MockContentFilterEnabler supportsSecureCoding]): (-[MockContentFilterEnabler copyWithZone:]): (-[MockContentFilterEnabler initWithCoder:]): (-[MockContentFilterEnabler dealloc]): (-[MockContentFilterEnabler encodeWithCoder:]): (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path. (-[ContentFilteringPlugIn dealloc]): Stop observing. (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler. (+[ServerRedirectPlugIn initialize]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted. (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted. (TEST): Deleted. 2015-08-31 Filip Pizlo Skip slow lock tests on Windows/debug https://bugs.webkit.org/show_bug.cgi?id=148643 Reviewed by Alexey Proskuryakov. The lock tests simulate a critical section by doing some floating point math, and then either make those critical sections very long or invoke them many times. This appears to be particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes that kind of computation slow. These tests are almost as useful in release as they are in debug, so it's probably better to just skip the in debug on platforms where this causes timeouts. * TestWebKitAPI/Tests/WTF/Lock.cpp: (TestWebKitAPI::runLockTest): (TestWebKitAPI::skipSlow): (TestWebKitAPI::TEST): 2015-08-29 Chris Fleizach AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change https://bugs.webkit.org/show_bug.cgi?id=125720 Reviewed by Daniel Bates. Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint. * DumpRenderTree/AccessibilityUIElement.cpp: (pressCallback): (scrollToMakeVisibleWithSubFocusCallback): (scrollToGlobalPointCallback): (scrollToMakeVisibleCallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::scrollToMakeVisible): (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): (AccessibilityUIElement::scrollToGlobalPoint): (AccessibilityUIElement::selectedTextRange): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::mathPrescriptsDescription): (AccessibilityUIElement::scrollToMakeVisible): (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): (AccessibilityUIElement::scrollToGlobalPoint): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::isTextMarkerValid): (WTR::AccessibilityUIElement::textMarkerForIndex): (WTR::AccessibilityUIElement::scrollToMakeVisible): (WTR::AccessibilityUIElement::scrollToGlobalPoint): (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): (WTR::AccessibilityUIElement::supportedActions): (WTR::AccessibilityUIElement::mathPostscriptsDescription): (WTR::AccessibilityUIElement::mathPrescriptsDescription): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::scrollToMakeVisible): (WTR::AccessibilityUIElement::scrollToGlobalPoint): (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): (WTR::AccessibilityUIElement::selectedTextRange): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::scrollToMakeVisible): (WTR::AccessibilityUIElement::scrollToGlobalPoint): (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): (WTR::AccessibilityUIElement::selectedTextRange): 2015-08-28 Timothy Horton Add a mysteriously nonproblematic missing comma. * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectationParser._collect_matching_tests): (TestExpectationParser): 2015-08-28 Timothy Horton Remove an old temporary script that has served its purpose * Scripts/convert-test-expectations: Removed. 2015-08-28 Jer Noble [iOS] Add WebKit/WebKit2 settings to control automatic data loading https://bugs.webkit.org/show_bug.cgi?id=148579 Reviewed by Anders Carlsson. In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES. In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property, and also set the existing requiresUserActionForMediaPlayback configuration property to NO. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): (resetWebViewToConsistentStateBeforeTesting): * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::initializeWebViewConfiguration): 2015-08-28 Alexey Proskuryakov Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..." https://bugs.webkit.org/show_bug.cgi?id=148592 Reviewed by Tim Horton. * Scripts/webkitpy/port/base.py: (Port.to.setup_environ_for_server): (Port.to): (Port.to._append_value_colon_separated): (Port.to.show_results_html_file): * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.setup_environ_for_server): * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server): 2015-08-28 Filip Pizlo LICM should be sound even if the CFG has changed https://bugs.webkit.org/show_bug.cgi?id=148259 Reviewed by Benjamin Poulain. Add a utility for creating tests that set some uncommon option. * Scripts/run-jsc-stress-tests: 2015-08-28 Brent Fulgham [Win] Unreviewed EWS correction. * EWSTools/start-queue-win.sh: Update settings to point to VS2015. 2015-08-28 Jer Noble [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2. https://bugs.webkit.org/show_bug.cgi?id=147512 Reviewed by Anders Carlsson. Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline() to a consistent (true) value. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): 2015-08-28 Tim Horton Add navigation gesture callbacks to WKPageNavigationClient https://bugs.webkit.org/show_bug.cgi?id=148568 Reviewed by Anders Carlsson. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): Add some zeroes. 2015-08-28 Alexey Proskuryakov [Mac] kill-old-processes should kill more processes https://bugs.webkit.org/show_bug.cgi?id=148577 Reviewed by Tim Horton. * BuildSlaveSupport/kill-old-processes: 2015-08-28 Jason Marcell The status message for combined builder queues should say "all builds succeeded" if everything built correctly. https://bugs.webkit.org/show_bug.cgi?id=148535 Reviewed by David Kilzer and Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js: (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues say "all builds succeeded" if everything built correctly. 2015-08-28 Carlos Garcia Campos [GTK] Simplify the internal API to create a WebView https://bugs.webkit.org/show_bug.cgi?id=148570 Reviewed by Žan Doberšek. * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too. * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all PlatformWebView constructors that end up calling initialize with a PageConfiguration. (TestWebKitAPI::PlatformWebView::initialize): Create the WebView passing the received PageConfiguration. * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::PlatformWebView): Create the WebView passing the received PageConfiguration. 2015-08-27 Aakash Jain iOS Simulator API tests fails as Simulator is not running https://bugs.webkit.org/show_bug.cgi?id=148501 rdar://problem/22447525 Reviewed by Daniel Bates. This change is a workaround for . * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests and quit it on program termination when running tests on the iOS port. * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable. 2015-08-27 Alex Christensen Make DLLLauncherMain executables dependent on dll https://bugs.webkit.org/show_bug.cgi?id=148548 Reviewed by Brent Fulgham. * DumpRenderTree/CMakeLists.txt: * DumpRenderTree/PlatformWin.cmake: * MiniBrowser/win/CMakeLists.txt: * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/PlatformWin.cmake: 2015-08-27 Lucas Forschler Remove Mac slaves 188/189 after being replaced with 400/401. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-08-27 Lucas Forschler Add two bots to the Mac Yosemite queue. This is to eventually replace bots188/189, which will be removed after 400/401 are vetted. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-08-27 Alex Christensen [Win CMake] Fix incremental build after r188673 https://bugs.webkit.org/show_bug.cgi?id=148539 Reviewed by Brent Fulgham. * TestWebKitAPI/PlatformWin.cmake: Copy forwarding headers from WebCore before building in case that was not yet done. It used to be done when running CMake, but now it's a build step. 2015-08-27 Nan Wang AX: Fix accessibility/select-element-at-index.html test https://bugs.webkit.org/show_bug.cgi?id=148516 Reviewed by Chris Fleizach. Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac. * DumpRenderTree/AccessibilityUIElement.cpp: (setSelectedChildCallback): (setSelectedChildAtIndexCallback): (removeSelectionAtIndexCallback): (elementAtPointCallback): (sentenceAtOffsetCallback): (stringForSelectionCallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::setSelectedChild): (AccessibilityUIElement::setSelectedChildAtIndex): (AccessibilityUIElement::removeSelectionAtIndex): (AccessibilityUIElement::accessibilityValue): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::wordAtOffset): (WTR::AccessibilityUIElement::lineAtOffset): (WTR::AccessibilityUIElement::sentenceAtOffset): (WTR::AccessibilityUIElement::isSelectable): (WTR::AccessibilityUIElement::isMultiSelectable): (WTR::AccessibilityUIElement::setSelectedChild): (WTR::AccessibilityUIElement::setSelectedChildAtIndex): (WTR::AccessibilityUIElement::removeSelectionAtIndex): (WTR::AccessibilityUIElement::selectedChildrenCount): (WTR::AccessibilityUIElement::selectedChildAtIndex): (WTR::AccessibilityUIElement::isExpanded): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::setSelectedChild): (WTR::AccessibilityUIElement::setSelectedChildAtIndex): (WTR::AccessibilityUIElement::removeSelectionAtIndex): (WTR::AccessibilityUIElement::accessibilityValue): 2015-08-27 Alex Christensen Build fix after r188982 * MiniBrowser/win/CMakeLists.txt: The directory structure changed in the move. 2015-08-27 Michael Catanzaro [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead. * gtk/install-dependencies: 2015-08-27 Carlos Garcia Campos Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too. * Scripts/run-gtk-tests: (TestRunner): 2015-08-27 Carlos Garcia Campos Fix GTK+ WTR crashes in initializeMainRunLoop() Rubber-stamped by Žan Doberšek. Initialize threading and main thread before RunLoop::initializeMainRunLoop(), since the GLib implementation of the RunLoop uses isMainThread() to decide whether to create a new GMainContext or use the default one. Also use RunLoop::run() and ::stop() instead of gtk_main/quit. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::notifyDone): (WTR::TestController::platformRunUntil): 2015-08-27 Filip Pizlo Unreviewed, further shorten a test that times out because it's very long running. I've locally run these tests on repeat for 24 hours and found no genuine failures, like deadlocks. So, the timeouts are probably because the test machine is slow and debug is slow. We should just run this test for fewer iterations. * TestWebKitAPI/Tests/WTF/Lock.cpp: (TestWebKitAPI::TEST): 2015-08-26 Ryuan Choi Unreviewed build fix attempt on EFL * WebKitTestRunner/PlatformEfl.cmake: 2015-08-26 Alex Christensen Build fix after r188982 * MiniBrowser/win/CMakeLists.txt: Find .rc files in correct directory. 2015-08-26 Ryuan Choi [EFL] Bump cairo version to 1.14.2 https://bugs.webkit.org/show_bug.cgi?id=148474 Reviewed by Csaba Osztrogonác. * efl/jhbuild.modules: 2015-08-26 Andy Estes Crash when following a Google search link to Twitter with Limit Adult Content enabled https://bugs.webkit.org/show_bug.cgi?id=147651 Rubber-stamped by Brady Eidson. Taught TestRunner how to decide the navigation policy after a delay. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::decidePolicyForNavigationAction): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay): * WebKitTestRunner/InjectedBundle/TestRunner.h: (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay): * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::decidePolicyForNavigationAction): * WebKitTestRunner/TestController.h: (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 2015-08-26 Brent Fulgham [Win] Rename 'WinLauncher' to 'MiniBrowser' https://bugs.webkit.org/show_bug.cgi?id=148485 Reviewed by Alex Christensen Move the WinLauncher project and source files to a subdirectory of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the source code and project files. * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h. * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed. * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed. * MiniBrowser/win: Copied from WinLauncher. * MiniBrowser/win/Common.cpp: * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp. * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h. * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h. * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp. * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h. * MiniBrowser/win/PageLoadTestClient.cpp: * MiniBrowser/win/PageLoadTestClient.h: * MiniBrowser/win/ResourceLoadDelegate.cpp: * MiniBrowser/win/ResourceLoadDelegate.h: * MiniBrowser/win/WinLauncher.cpp: Removed. * MiniBrowser/win/WinLauncher.h: Removed. * MiniBrowser/win/WinLauncher.vcxproj: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed. * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed. * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed. * MiniBrowser/win/WinLauncherReplace.h: Removed. * MiniBrowser/win/WinLauncherWebHost.cpp: Removed. * MiniBrowser/win/WinLauncherWebHost.h: Removed. * MiniBrowser/win/WinMain.cpp: * WinLauncher: Removed. * WinLauncher/AccessibilityDelegate.cpp: Removed. * WinLauncher/AccessibilityDelegate.h: Removed. * WinLauncher/CMakeLists.txt: Removed. * WinLauncher/Common.cpp: Removed. * WinLauncher/DOMDefaultImpl.cpp: Removed. * WinLauncher/DOMDefaultImpl.h: Removed. * WinLauncher/PageLoadTestClient.cpp: Removed. * WinLauncher/PageLoadTestClient.h: Removed. * WinLauncher/PrintWebUIDelegate.cpp: Removed. * WinLauncher/PrintWebUIDelegate.h: Removed. * WinLauncher/ResourceLoadDelegate.cpp: Removed. * WinLauncher/ResourceLoadDelegate.h: Removed. * WinLauncher/WebDownloadDelegate.cpp: Removed. * WinLauncher/WebDownloadDelegate.h: Removed. * WinLauncher/WinLauncher.cpp: Removed. * WinLauncher/WinLauncher.h: Removed. * WinLauncher/WinLauncher.vcxproj: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed. * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed. * WinLauncher/WinLauncher.vcxproj/small.ico: Removed. * WinLauncher/WinLauncherReplace.h: Removed. * WinLauncher/WinLauncherWebHost.cpp: Removed. * WinLauncher/WinLauncherWebHost.h: Removed. * WinLauncher/WinMain.cpp: Removed. * WinLauncher/resource.h: Removed. * WinLauncher/stdafx.cpp: Removed. * WinLauncher/stdafx.h: Removed. * win/AssembleBuildLogs/AssembleLogs.cmd: 2015-08-26 Brent Fulgham [Win] Simplify menu handling code in WinLauncher https://bugs.webkit.org/show_bug.cgi?id=148461 Reviewed by Zalan Bujtas. Revise 'ToggleMenuItem' to return a boolean value indicating if it handled the message. Revise WndProc to use this to decide if it should pass the message on to the default handler, rather than duplicating the logic in both places. * WinLauncher/Common.cpp: (ToggleMenuItem): Return true if the menu item message was handled. (WndProc): If 'ToggleMenuItem' did not handle the message, pass the message tothe default handler. 2015-08-26 Csaba Osztrogonác Remove unused code after r188948 https://bugs.webkit.org/show_bug.cgi?id=148467 Reviewed by Gyuyoung Kim. * WebKitTestRunner/TestController.cpp: (WTR::TestController::platformPreferences): Deleted. 2015-08-26 Gyuyoung Kim [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash https://bugs.webkit.org/show_bug.cgi?id=148377 Reviewed by Carlos Garcia Campos. EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828. It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for EFL and GTK at the moment. * WebKitTestRunner/TestController.cpp: (WTR::TestController::platformWillRunTest): * WebKitTestRunner/efl/TestControllerEfl.cpp: (WTR::TestController::platformPreferences): * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::platformPreferences): 2015-08-25 Nan Wang AX: Enable accessibility/aria-controls.html test for mac https://bugs.webkit.org/show_bug.cgi?id=148458 Reviewed by Chris Fleizach. Implemented ariaControlsElementAtIndex(unsigned index). * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::ariaControlsElementAtIndex): (AccessibilityUIElement::disclosedRowAtIndex): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::ariaControlsElementAtIndex): 2015-08-25 Gyuyoung Kim Remove python tests for PassRefPtr https://bugs.webkit.org/show_bug.cgi?id=148463 Reviewed by Andy Estes. As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (PassPtrTest): Deleted. (PassPtrTest.assert_pass_ptr_check): Deleted. (PassPtrTest.test_pass_ref_ptr_in_function): Deleted. (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted. (PassPtrTest.test_pass_ref_ptr_return_value): Deleted. (PassPtrTest.test_ref_ptr_parameter_value): Deleted. (PassPtrTest.test_ref_ptr_member_variable): Deleted. (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted. 2015-08-25 Andy Estes [iOS] run-webkit-tests fails if watchOS SDK is installed https://bugs.webkit.org/show_bug.cgi?id=148453 Reviewed by David Kilzer. * Scripts/webkitpy/xcode/simulator.py: (Simulator): Taught Simulator how to parse watchOS runtimes and devices. * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests. 2015-08-25 Aakash Jain iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running https://bugs.webkit.org/show_bug.cgi?id=148197 rdar://problem/22334382 Reviewed by Daniel Bates. * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders). * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID. (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator. (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup. (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences(). (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory. 2015-08-25 Gyuyoung Kim Remove PassRefPtr style check rule https://bugs.webkit.org/show_bug.cgi?id=148432 Reviewed by Andreas Kling. PassRefPtr is being removed. Thus style rule needs to be removed as well. * Scripts/webkitpy/style/checkers/cpp.py: (_check_parameter_name_against_text): Deleted. (check_function_definition_and_pass_ptr): Deleted. (check_function_definition): Deleted. (check_pass_ptr_usage): Deleted. (process_line): Deleted. (CppChecker): Deleted. 2015-08-25 Brent Fulgham [Win] Expose "Inverted Colors" option in WinLauncher https://bugs.webkit.org/show_bug.cgi?id=148451 Reviewed by Tim Horton. Add the ability to toggle the "Inverted Colors" preference in WinLauncher. * WinLauncher/Common.cpp: (ToggleMenuItem): Toggle the feature when the menu item is selected. (WndProc): Recognize the new menu option. * WinLauncher/WinLauncher.cpp: (WinLauncher::setToDefaultPreferences): Launch with "Invert Colors" turned off. * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu entry for "Invert Colors". * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: 2015-08-25 Nan Wang [Mac] accessibility/document-attributes.html fails https://bugs.webkit.org/show_bug.cgi?id=116636 Reviewed by Chris Fleizach. Implemented documentURI() and documentEncoding(). * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::documentEncoding): (AccessibilityUIElement::documentURI): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::documentEncoding): (WTR::AccessibilityUIElement::documentURI): 2015-08-24 Brent Fulgham [Win] Unreviewed test gardening. Fix another case where the logging string is constructed using the variable 'frame', but the method argument is not given a name. This causes the global 'frame' value to be used, producing incorrect output. * DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame' argument. 2015-08-24 Tim Horton (Finally...) get rid of WKViewIOS https://bugs.webkit.org/show_bug.cgi?id=148404 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm: * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h: * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm: Mark tests that use WKBrowsingContextController as Mac-only. * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: (WTR::AccessibilityController::addNotificationListener): * WebKitTestRunner/ios/mainIOS.mm: (-[WebKitTestRunnerApp applicationDidEnterBackground:]): Import UIKit instead of depending on WKView.h to do so. 2015-08-24 Jason Marcell Add support to dashboard for displaying Git SHA's as revisions. https://bugs.webkit.org/show_bug.cgi?id=148387 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added "isSVN" property to Dashboard.Repository.(OpenSource|Internal). 2015-08-24 Andy Estes REGRESSION (r188851): WebKit2.BundleParameters fails on iOS * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS. 2015-08-23 Andy Estes Addressed a missed piece of review feedback from r188851. * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: 2015-08-23 Andy Estes [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled https://bugs.webkit.org/show_bug.cgi?id=147872 rdar://problem/22044000 Reviewed by Dan Bernstein. Added an API test. * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added. (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL. (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL. (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]): (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled. * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added. (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter. * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h. * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm. 2015-08-23 Andy Estes Fixed the 32-bit Mac build after r188844. * TestWebKitAPI/WKWebViewConfigurationExtras.h: * TestWebKitAPI/WKWebViewConfigurationExtras.mm: 2015-08-22 Andy Estes [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins https://bugs.webkit.org/show_bug.cgi?id=148317 Reviewed by Dan Bernstein. Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:] when creating WKWebViews. Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also added a new API test for bundle parameters. * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and named its executable TestWebKitAPI.bundle. * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target. * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added. (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle. * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added. (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a bundle parameter and asked for an initial notification. (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter. (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes, mirror its value in the main frame's JSContext. * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added. * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added. (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name. * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter. * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn. * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added. (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance. (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response. (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance. 2015-08-23 Csaba Osztrogonác URTBF after r188828. * WebKitTestRunner/PlatformWebView.h: 2015-08-23 Alexey Proskuryakov build.webkit.org/dashboard: Combined queues don't turn orange on internal failure https://bugs.webkit.org/show_bug.cgi?id=148356 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js: (BuildbotCombinedQueueView.prototype.update): 2015-08-23 Alexey Proskuryakov build.webkit.org/dashboard: Respect step's hidden flag https://bugs.webkit.org/show_bug.cgi?id=148357 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: (BuildbotIteration.prototype._parseData): 2015-08-23 Nan Wang AX: Fix accessibility/deleting-iframe-destroys-axcache.html test https://bugs.webkit.org/show_bug.cgi?id=148328 Reviewed by Darin Adler. We should only expose stringValue() when value attribute is set. * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::stringValue): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::stringValue): 2015-08-23 Gyuyoung Kim Remove style checking rule regarding OwnPtr and PassOwnPtr https://bugs.webkit.org/show_bug.cgi?id=148360 Reviewed by Darin Adler. OwnPtr and PassOwnPtr were totally removed though, style rule is still alive. Removed it. * Scripts/do-webcore-rename: * Scripts/webkitpy/style/checkers/cpp_unittest.py: (PassPtrTest.test_pass_own_ptr_in_function): Deleted. (PassPtrTest.test_pass_ref_ptr_return_value): Deleted. (PassPtrTest.test_own_ptr_parameter_value): Deleted. (WebKitStyleTest.test_names): Deleted. 2015-08-22 Timothy Horton WebKitTestRunner should use WKWebView on OS X and iOS https://bugs.webkit.org/show_bug.cgi?id=143743 Reviewed by Anders Carlsson. Patch by Enrica Casucci and myself. * WebKitTestRunner/PlatformWebView.h: (WTR::PlatformWebView::windowSnapshotEnabled): Deleted. Add a PlatformWebView constructor that takes a WKWebViewConfiguration instead of WKContext and WKPageGroup. Remove the unused, always-true windowSnapshotEnabled(). While technically some platforms don't have window snapshotting, they just return null instead of implementing windowSnapshotEnabled(). * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::initialize): (WTR::TestController::createWebViewWithOptions): Delegate to the various platforms for creating PlatformWebView instances, for creating WKContexts, and for accessing WKPreferences, so that they can do special things (like, use WKWebView instead!). (WTR::TestController::resetPreferencesToConsistentValues): Make explicit WebKitTestRunner's desired default for two preferences which have differing defaults between the antique and modern API, for consistency's sake. (WTR::TestController::resetStateToConsistentValues): Add platformResetStateToConsistentValues. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::dumpResults): Adjust to the aforementioned removal of windowSnapshotEnabled(). * WebKitTestRunner/ios/TestControllerCocoa.mm: (WTR::TestController::platformResetStateToConsistentValues): (WTR::TestController::platformPreferences): (WTR::TestController::platformCreateWebView): (WTR::TestController::platformCreateOtherPage): (WTR::TestController::platformInitializeConfiguration): Implement the new platform functions for the Modern WebKit2 API, in a new TestControllerCocoa file that is shared between iOS and Mac. For platformMaybeCreateContext, use the trick that we know we can cast the WKProcessPool to a WKContextRef to retrieve a WKContextRef from WKWebView's configuration. Ditto for WKPreferencesRef and WKPreferences. Remove user content filters on the WKWebView's userContentController. * WebKitTestRunner/mac/TestControllerMac.mm: * WebKitTestRunner/ios/TestControllerIOS.mm: Move code into TestControllerCocoa. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::addUserScript): (WTR::TestRunner::addUserStyleSheet): Adopt WKBundlePage API for user scripts/sheets. * WebKitTestRunner/ios/PlatformWebViewIOS.mm: * WebKitTestRunner/mac/PlatformWebViewMac.mm: Make and keep a WKWebView instead of a WKView. * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::mouseUp): (WTR::EventSenderProxy::mouseMoveTo): Reach inside the WKWebView to the WKView when dispatching events. This is fairly ugly and we should come up with a better solution. Also, fix some flipping and style errors. 2015-08-22 Michael Catanzaro Unreviewed, attempt to fix GTK build after r188718 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::PlatformWebView): 2015-08-21 Commit Queue Unreviewed, rolling out r188807, r188813, and r188815. https://bugs.webkit.org/show_bug.cgi?id=148349 lots of 32-bit build problems, better to resolve separately and try again (Requested by thorton on #webkit). Reverted changesets: "WebKitTestRunner should use WKWebView on OS X and iOS" https://bugs.webkit.org/show_bug.cgi?id=143743 http://trac.webkit.org/changeset/188807 "Stop building WebKitTestRunner for 32-bit platforms" https://bugs.webkit.org/show_bug.cgi?id=143743 http://trac.webkit.org/changeset/188813 "Stop building WebKitTestRunner for 32-bit platforms" https://bugs.webkit.org/show_bug.cgi?id=143743 http://trac.webkit.org/changeset/188815 2015-08-21 Tim Horton Stop building WebKitTestRunner for 32-bit platforms https://bugs.webkit.org/show_bug.cgi?id=143743 * WebKitTestRunner/Configurations/DebugRelease.xcconfig: This is a restriction on the valid set, not the desired set. 2015-08-21 Jason Marcell Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code to work with these new objects. https://bugs.webkit.org/show_bug.cgi?id=148188 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js: (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a (repository, "branch name")-pair. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch objects which represent a (repository, "branch name")-pair. (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto. (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto. (BuildbotQueueView.prototype._addDividerToPopover): Ditto. (BuildbotQueueView.prototype.revisionContentForIteration): Ditto. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed BuildbotQueue.branch to BuildbotQueue.branches. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format. 2015-08-21 Tim Horton Stop building WebKitTestRunner for 32-bit platforms https://bugs.webkit.org/show_bug.cgi?id=143743 * WebKitTestRunner/Configurations/DebugRelease.xcconfig: WKWebView is not available on 32-bit OS X. 2015-08-21 Brent Fulgham [Win] Unreviewed test correction after r188709. I removed a function argument that happened to be mirrored by a global value with the same name. This prevented a compile error, but testing showed that the wrong value was being used in the function. * DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument back 2015-08-21 Timothy Horton WebKitTestRunner should use WKWebView on OS X and iOS https://bugs.webkit.org/show_bug.cgi?id=143743 Reviewed by Anders Carlsson. Patch by Enrica Casucci and myself. * WebKitTestRunner/PlatformWebView.h: (WTR::PlatformWebView::windowSnapshotEnabled): Deleted. Add a PlatformWebView constructor that takes a WKWebViewConfiguration instead of WKContext and WKPageGroup. Remove the unused, always-true windowSnapshotEnabled(). While technically some platforms don't have window snapshotting, they just return null instead of implementing windowSnapshotEnabled(). * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::initialize): (WTR::TestController::createWebViewWithOptions): Delegate to the various platforms for creating PlatformWebView instances, for creating WKContexts, and for accessing WKPreferences, so that they can do special things (like, use WKWebView instead!). (WTR::TestController::resetPreferencesToConsistentValues): Make explicit WebKitTestRunner's desired default for two preferences which have differing defaults between the antique and modern API, for consistency's sake. (WTR::TestController::resetStateToConsistentValues): Add platformResetStateToConsistentValues. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::dumpResults): Adjust to the aforementioned removal of windowSnapshotEnabled(). * WebKitTestRunner/ios/TestControllerCocoa.mm: (WTR::TestController::platformResetStateToConsistentValues): (WTR::TestController::platformPreferences): (WTR::TestController::platformCreateWebView): (WTR::TestController::platformCreateOtherPage): (WTR::TestController::platformInitializeConfiguration): Implement the new platform functions for the Modern WebKit2 API, in a new TestControllerCocoa file that is shared between iOS and Mac. For platformMaybeCreateContext, use the trick that we know we can cast the WKProcessPool to a WKContextRef to retrieve a WKContextRef from WKWebView's configuration. Ditto for WKPreferencesRef and WKPreferences. Remove user content filters on the WKWebView's userContentController. * WebKitTestRunner/mac/TestControllerMac.mm: * WebKitTestRunner/ios/TestControllerIOS.mm: Move code into TestControllerCocoa. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::addUserScript): (WTR::TestRunner::addUserStyleSheet): Adopt WKBundlePage API for user scripts/sheets. * WebKitTestRunner/ios/PlatformWebViewIOS.mm: * WebKitTestRunner/mac/PlatformWebViewMac.mm: Make and keep a WKWebView instead of a WKView. * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::mouseUp): (WTR::EventSenderProxy::mouseMoveTo): Reach inside the WKWebView to the WKView when dispatching events. This is fairly ugly and we should come up with a better solution. Also, fix some flipping and style errors. 2015-08-21 Alexey Proskuryakov Improve how UI events are dispatched by WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=148326 Reviewed by Anders Carlsson. * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: * WebKitTestRunner/InjectedBundle/EventSendingController.h: Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always asynchronous (and really, it has always been for the most part). * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming. (WTR::EventSendingController::mouseUp): Ditto. (WTR::EventSendingController::mouseMoveTo): Ditto. (WTR::EventSendingController::mouseForceDown): Ditto. (WTR::EventSendingController::mouseForceUp): Ditto. (WTR::EventSendingController::mouseForceChanged): Ditto. (WTR::EventSendingController::leapForward): Ditto. (WTR::EventSendingController::scheduleAsynchronousClick): Ditto. (WTR::EventSendingController::keyDown): Ditto. (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto. (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used to be done in custom WebKit2 code for test wheel event handling. (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version. (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird. (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming. (WTR::EventSendingController::addTouchPoint): Ditto. (WTR::EventSendingController::updateTouchPoint): Ditto. (WTR::EventSendingController::setTouchModifier): Ditto. (WTR::EventSendingController::setTouchPointRadius): Ditto. (WTR::EventSendingController::touchStart): Ditto. (WTR::EventSendingController::touchMove): Ditto. (WTR::EventSendingController::touchEnd): Ditto. (WTR::EventSendingController::touchCancel): Ditto. (WTR::EventSendingController::clearTouchPoints): Ditto. (WTR::EventSendingController::releaseTouchPoint): Ditto. (WTR::EventSendingController::cancelTouchPoint): Ditto. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::postSetWindowIsKey): (WTR::InjectedBundle::postSimulateWebNotificationClick): (WTR::InjectedBundle::isGeolocationProviderActive): (WTR::InjectedBundle::shouldProcessWorkQueue): Updated for WKBundlePagePostSynchronousMessage renaming. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::secureEventInputIsEnabled): Ditto. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Allow handling the new test style messages. (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls to WKPageSetShouldSendEventsSynchronously, which we no longer need. (WTR::TestController::didReceiveMessageFromInjectedBundle): (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously. * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously. (WTR::EventSenderProxy::keyDown): Ditto. (WTR::EventSenderProxy::mouseScrollBy): Ditto. (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto. 2015-08-21 Yusuke Suzuki Skip no-llint tests that fail due to running out of executable memory after r188969 https://bugs.webkit.org/show_bug.cgi?id=148273 Reviewed by Michael Saboff. * Scripts/run-jsc-stress-tests: 2015-08-21 Nan Wang [Mac] accessibility/selection-states.html fails https://bugs.webkit.org/show_bug.cgi?id=116637 Reviewed by Chris Fleizach. Implemented isSelectable() and isMultiSelectable(). * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isSelectable): (AccessibilityUIElement::isMultiSelectable): (AccessibilityUIElement::isSelectedOptionActive): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::isSelectable): (WTR::AccessibilityUIElement::isMultiSelectable): (WTR::AccessibilityUIElement::isVisible): 2015-08-21 Jason Marcell Fix iteration over repositories on bot watcher's dashboard. Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable. 2015-08-20 Joonghun Park [EFL] Revise PlatformWebView ctor according to r188718 https://bugs.webkit.org/show_bug.cgi?id=148282 This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef instead of WKContextRef and WKPageGroupRef respectively. Reviewed by Gyuyoung Kim. * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: (WTR::PlatformWebView::PlatformWebView): 2015-08-20 Devin Rousso Unreviewed, changed Devin Rousso's email. * Scripts/webkitpy/common/config/contributors.json: 2015-08-20 Anders Carlsson Use WKPageConfigurationRef in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=147996 Reviewed by Tim Horton. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::initialize): (WTR::TestController::createWebViewWithOptions): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]): (WTR::PlatformWebView::PlatformWebView): (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted. 2015-08-20 Brent Fulgham [Win] Update Windows tools for revised MIDL interfaces https://bugs.webkit.org/show_bug.cgi?id=148249 Reviewed by Dean Jackson. This is a follow-up to Bug 148001. Revise the testing software to use compatible signatures and implementations to match the requirements of the IDL generated with the SAL annotations. * DumpRenderTree/win/DRTDataObject.cpp: * DumpRenderTree/win/DRTDataObject.h: * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: * DumpRenderTree/win/DRTDesktopNotificationPresenter.h: * DumpRenderTree/win/DRTDropSource.cpp: * DumpRenderTree/win/DRTDropSource.h: * DumpRenderTree/win/DumpRenderTree.cpp: * DumpRenderTree/win/EditingDelegate.cpp: * DumpRenderTree/win/EditingDelegate.h: * DumpRenderTree/win/FrameLoadDelegate.cpp: * DumpRenderTree/win/FrameLoadDelegate.h: * DumpRenderTree/win/HistoryDelegate.cpp: * DumpRenderTree/win/HistoryDelegate.h: * DumpRenderTree/win/PolicyDelegate.cpp: * DumpRenderTree/win/PolicyDelegate.h: * DumpRenderTree/win/ResourceLoadDelegate.cpp: * DumpRenderTree/win/ResourceLoadDelegate.h: * DumpRenderTree/win/TestRunnerWin.cpp: * DumpRenderTree/win/UIDelegate.cpp: * DumpRenderTree/win/UIDelegate.h: * WinLauncher/AccessibilityDelegate.cpp: * WinLauncher/AccessibilityDelegate.h: * WinLauncher/Common.cpp: * WinLauncher/DOMDefaultImpl.cpp: * WinLauncher/DOMDefaultImpl.h: * WinLauncher/PageLoadTestClient.cpp: * WinLauncher/PageLoadTestClient.h: * WinLauncher/PrintWebUIDelegate.cpp: * WinLauncher/PrintWebUIDelegate.h: * WinLauncher/ResourceLoadDelegate.cpp: * WinLauncher/ResourceLoadDelegate.h: * WinLauncher/WebDownloadDelegate.cpp: * WinLauncher/WebDownloadDelegate.h: * WinLauncher/WinLauncherWebHost.cpp: * WinLauncher/WinLauncherWebHost.h: * WinLauncher/WinMain.cpp: * win/DLLLauncher/DLLLauncherMain.cpp: 2015-08-20 Filip Pizlo Unreviewed, shorten a test that runs too long and times out. * TestWebKitAPI/Tests/WTF/Lock.cpp: (TestWebKitAPI::TEST): 2015-08-20 Alex Christensen Clean up CMake build after r188673 https://bugs.webkit.org/show_bug.cgi?id=148234 Reviewed by Tim Horton. * DumpRenderTree/PlatformWin.cmake: * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/PlatformWin.cmake: Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries. gtest needs to be a static library on Windows to not crash. 2015-08-19 Alex Christensen CMake Windows build should not include files directly from other Source directories https://bugs.webkit.org/show_bug.cgi?id=148198 Reviewed by Brent Fulgham. * DumpRenderTree/DumpRenderTreePrefix.h: Include cmakeconfig.h to properly define all enabled features. * DumpRenderTree/PlatformWin.cmake: * TestWebKitAPI/PlatformWin.cmake: 2015-08-19 Alex Christensen Build TestWTF on Mac with CMake. https://bugs.webkit.org/show_bug.cgi?id=147972 Reviewed by Tim Horton. TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit. Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build. * TestWebKitAPI/CMakeLists.txt: Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME. WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work. * TestWebKitAPI/PlatformMac.cmake: Added. * TestWebKitAPI/config.h: Postpone some build fixes until WebKit builds completely on Mac with CMake. 2015-08-19 Brian Burg Unreviewed, add Aleksandr Skachkov to the list of contributors. * Scripts/webkitpy/common/config/contributors.json: 2015-08-18 Carlos Alberto Lopez Perez REGRESSION(r188548): [GTK] Build broken. https://bugs.webkit.org/show_bug.cgi?id=148154 Reviewed by Martin Robinson. * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Even if we don't need to add/override any settings in ViewOptions, we need to define this as an empty function to make it build. 2015-08-18 Gyuyoung Kim Fix conversion-null warning in conversion.cpp of TestWebKitAPI https://bugs.webkit.org/show_bug.cgi?id=148073 Reviewed by Alexey Proskuryakov. * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ. (TestWebKitAPI::TEST): 2015-08-18 Anders Carlsson Fix test failure fallout from r188602 by using a V5 page ui client struct. * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: (TestWebKitAPI::setUpClients): 2015-08-18 Brian Burg Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle https://bugs.webkit.org/show_bug.cgi?id=147955 Reviewed by Timothy Hatcher. To enable sharing of common test code between protocol and model tests, start loading the protocol TestStub.js through the WebInspectorUI bundle. This patch adds the read-only getter TestRunner.inspectorTestStubURL, which protocol-test.js uses to load the inspector frontend stub into its iframe from an arbitrary local file URL. * DumpRenderTree/TestRunner.cpp: (getInspectorTestStubURLCallback): (TestRunner::staticValues): * DumpRenderTree/TestRunner.h: * DumpRenderTree/mac/TestRunnerMac.mm: (SOFT_LINK_STAGED_FRAMEWORK): (TestRunner::inspectorTestStubURL): * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::inspectorTestStubURL): * WebKitTestRunner/Configurations/Base.xcconfig: Since WebKitTestRunner now includes WebCore private headers, also search for the WebCore framework inside the WebKit umbrella framework. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: (WTR::TestRunner::inspectorTestStubURL): * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: (WTR::TestRunner::inspectorTestStubURL): * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: (WTR::TestRunner::inspectorTestStubURL): 2015-08-18 Filip Pizlo Unreviewed, fix GTK build. * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: (TestWebKitAPI::TEST): 2015-08-17 Filip Pizlo Replace all remaining uses of WTF::Mutex with WTF::Lock https://bugs.webkit.org/show_bug.cgi?id=148089 Reviewed by Geoffrey Garen. * DumpRenderTree/JavaScriptThreading.cpp: (javaScriptThreadsMutex): (runJavaScriptThread): (startJavaScriptThreads): (stopJavaScriptThreads): * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark. * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: (TestWebKitAPI::TEST): 2015-08-17 Commit Queue Unreviewed, rolling out r188539, r188544, r188552, and r188564. https://bugs.webkit.org/show_bug.cgi?id=148122 Broke tests and some build styles (Requested by ap on #webkit). Reverted changesets: "Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle" https://bugs.webkit.org/show_bug.cgi?id=147955 http://trac.webkit.org/changeset/188539 "Web Inspector: split TestStub.js into multiple files and modernize it" https://bugs.webkit.org/show_bug.cgi?id=148077 http://trac.webkit.org/changeset/188544 "Web Inspector: InspectorTest should be a subclass of TestHarness" https://bugs.webkit.org/show_bug.cgi?id=148079 http://trac.webkit.org/changeset/188552 "Unreviewed internal build fix attempt after r188539." http://trac.webkit.org/changeset/188564 2015-08-17 Myles C. Maxfield [OS X] Remove support for composite fonts https://bugs.webkit.org/show_bug.cgi?id=147920 Reviewed by Dan Bernstein. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/fonts/SampleFont.sfont: Removed. * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: * DumpRenderTree/mac/DumpRenderTree.mm: (allowedFontFamilySet): Deleted. (activateTestingFonts): Deleted. * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: (WTR::allowedFontFamilySet): Deleted. (WTR::activateFonts): Deleted. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * WebKitTestRunner/fonts/SampleFont.sfont: Removed. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::allowedFontFamilySet): Deleted. 2015-08-17 Jon Honeycutt Unreviewed internal build fix attempt after r188539. * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: 2015-08-17 Myles C. Maxfield Fix the build Unreviewed. * TestWebKitAPI/Tests/WTF/StringHasher.cpp: 2015-08-17 Alex Christensen Build Debug Suffix on Windows with CMake https://bugs.webkit.org/show_bug.cgi?id=148083 Reviewed by Brent Fulgham. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/PlatformWin.cmake: Add DEBUG_SUFFIX 2015-08-17 Anders Carlsson Simplify how PlatformWebViews are created when view options change https://bugs.webkit.org/show_bug.cgi?id=148093 Reviewed by Sam Weinig. Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following: TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest. If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one. Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us. * WebKitTestRunner/TestController.cpp: (WTR::TestController::ensureViewSupportsOptionsForTest): (WTR::shouldUseFixedLayout): (WTR::TestController::viewOptionsForTest): (WTR::TestController::updateWebViewSizeForTest): (WTR::TestController::updateWindowScaleForTest): (WTR::TestController::configureViewForTest): (WTR::TestController::initialize): Deleted. (WTR::TestController::ensureViewSupportsOptions): Deleted. (WTR::TestController::updateLayoutTypeForTest): Deleted. (WTR::TestController::platformConfigureViewForTest): Deleted. (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted. (WTR::TestController::run): Deleted. * WebKitTestRunner/TestController.h: * WebKitTestRunner/efl/TestControllerEfl.cpp: (WTR::shouldUseFixedLayout): (WTR::TestController::updatePlatformSpecificViewOptionsForTest): (WTR::TestController::platformConfigureViewForTest): (WTR::TestController::platformResetPreferencesToConsistentValues): * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::updatePlatformSpecificViewOptionsForTest): * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::updatePlatformSpecificViewOptionsForTest): (WTR::TestController::platformConfigureViewForTest): 2015-08-17 Sam Weinig API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set https://bugs.webkit.org/show_bug.cgi?id=148097 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Add tests for WebsiteDataStores in the WKPageConfiguration. 2015-08-17 Brian Burg Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle https://bugs.webkit.org/show_bug.cgi?id=147955 Reviewed by Timothy Hatcher. To enable sharing of common test code between protocol and model tests, start loading the protocol TestStub.js through the WebInspectorUI bundle. This patch adds the read-only getter TestRunner.inspectorTestStubURL, which protocol-test.js uses to load the inspector frontend stub into its iframe from an arbitrary local file URL. * DumpRenderTree/TestRunner.cpp: (getInspectorTestStubURLCallback): (TestRunner::staticValues): * DumpRenderTree/TestRunner.h: * DumpRenderTree/mac/TestRunnerMac.mm: (SOFT_LINK_STAGED_FRAMEWORK): (TestRunner::inspectorTestStubURL): * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::inspectorTestStubURL): * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: (WTR::TestRunner::inspectorTestStubURL): * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: (WTR::TestRunner::inspectorTestStubURL): * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: (WTR::TestRunner::inspectorTestStubURL): 2015-08-17 Saam barati Change email address from saambarati1@gmail.com to sbarati@apple.com * Scripts/webkitpy/common/config/contributors.json: 2015-08-17 Jason Marcell Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with repositories other than "openSource" and "internal". https://bugs.webkit.org/show_bug.cgi?id=147961 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more generically with repositories other than "openSource" and "internal". 2015-08-17 Alexey Proskuryakov build.webkit.org/dashboard shows yellow when crash-only queues have too many failures https://bugs.webkit.org/show_bug.cgi?id=148081 Reviewed by Tim Horton. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): 2015-08-11 Andy Estes [Cocoa] Add redirect support to CustomProtocolManager https://bugs.webkit.org/show_bug.cgi?id=147871 Reviewed by Dan Bernstein. Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response. * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: (TestWebKitAPI::TEST): Unregesitered TestProtocol. * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http. * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL. (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto. (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL. (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false. (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol. * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: (TestWebKitAPI::TEST): Unregistered TestProtocol. * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http. (+[TestProtocol canInitWithRequest:]): Changed to use property syntax. (-[TestProtocol startLoading]): Taught to handle redirect responses. 2015-08-13 Andy Estes [Cocoa] Downloads do not start if policy decision is made asynchronously https://bugs.webkit.org/show_bug.cgi?id=147985 Reviewed by Brady Eidson. Added a new API test. * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): (-[AsynchronousDownloadDelegate _downloadDidStart:]): (TEST): 2015-08-14 Commit Queue Unreviewed, rolling out r187357. https://bugs.webkit.org/show_bug.cgi?id=148032 webkit-patch generates incorrect patches that cannot be applied (Requested by dydz on #webkit). Reverted changeset: "Call fixChangeLogPatch when generating patches from webkit- patch" https://bugs.webkit.org/show_bug.cgi?id=147248 http://trac.webkit.org/changeset/187357 2015-08-14 Jason Marcell Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories other than "openSource" and "internal". https://bugs.webkit.org/show_bug.cgi?id=147938 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with repositories other than "openSource" and "internal". 2015-08-14 Filip Pizlo Unreviewed, shorten another test that is timing out. * TestWebKitAPI/Tests/WTF/Lock.cpp: (TestWebKitAPI::TEST): 2015-08-13 Aakash Jain AppScale: Assertion hit when hovering a webkit-queue bubble https://bugs.webkit.org/show_bug.cgi?id=147997 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting. 2015-08-13 Lucas Forschler Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library. Unreviewed. * Scripts/copy-webkitlibraries-to-product-directory: 2015-08-13 Dewei Zhu Run benchmark customized Dromaeo should not assume there is an internet connection. https://bugs.webkit.org/show_bug.cgi?id=147995 Reviewed by Ryosuke Niwa. Add several dependency js libs to local. * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: 2015-08-13 Filip Pizlo WTF should have a compact Condition object to use with Lock https://bugs.webkit.org/show_bug.cgi?id=147986 Reviewed by Geoffrey Garen. Add a test for WTF::Condition. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/Condition.cpp: Added. (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/Lock.cpp: (TestWebKitAPI::runLockTest): Change the name of the thread. 2015-08-13 Filip Pizlo Unreviewed, shorten another test. It's timing out in debug on some bot. * TestWebKitAPI/Tests/WTF/Lock.cpp: (TestWebKitAPI::TEST): 2015-08-12 Filip Pizlo WTF::Lock should not suffer from the thundering herd https://bugs.webkit.org/show_bug.cgi?id=147947 Reviewed by Geoffrey Garen. Add testing that checks that locks return to a pristine state after contention is over. * TestWebKitAPI/Tests/WTF/Lock.cpp: (TestWebKitAPI::LockInspector::isFullyReset): (TestWebKitAPI::runLockTest): (TestWebKitAPI::TEST): 2015-08-12 Dewei Zhu Benchmarks supported by run_benchmark script should not assume we have internet access. https://bugs.webkit.org/show_bug.cgi?id=147959 Reviewed by Ryosuke Niwa. For JSBench we should not request jquery.min.js from google through the internet. * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: 2015-08-12 Jason Marcell Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories other than "openSource" and "internal". https://bugs.webkit.org/show_bug.cgi?id=147796 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter is now a repository object instead of the repository name, thus we don't have to pass the "trac" object in separately. Also added an assertion to see if the given repository is in iteration.revision, and another assertion that, if the previousIteration is non-null, the given repository is in previousIteration.revision. (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically with repositories other than "openSource" and "internal". Also added an assertion that the returned fragment has at least one child node. 2015-08-12 Simon Fraser Add a tool that dumps class and struct member layout, showing padding https://bugs.webkit.org/show_bug.cgi?id=147898 Reviewed by Zalan Bujtas. This 'dump-class-layout' script uses the lldb Python bindings to collect data about data member layout, and displays it. Sample output: +0 { 72} WTF::ListHashSet::Node +0 < 56> WebCore::URL m_value; +0 < 8> WTF::String m_string; +0 < 8> WTF::RefPtr m_impl; +0 < 8> WTF::StringImpl * m_ptr; +8 < 1> bool:1 m_isValid; +8 < 1> bool:1 m_protocolIsInHTTPFamily; +9 < 3> +12 < 4> int m_schemeEnd; +16 < 4> int m_userStart; +20 < 4> int m_userEnd; +24 < 4> int m_passwordEnd; +28 < 4> int m_hostEnd; +32 < 4> int m_portEnd; +36 < 4> int m_pathAfterLastSlash; +40 < 4> int m_pathEnd; +44 < 4> int m_queryEnd; +48 < 4> int m_fragmentEnd; +52 < 4> +52 < 4> +56 < 8> WTF::ListHashSetNode * m_prev; +64 < 8> WTF::ListHashSetNode * m_next; Total byte size: 72 Total pad bytes: 11 Padding percentage: 15.28 % * Scripts/dump-class-layout: Added. (webkit_build_dir): (developer_dir): (import_lldb): (find_build_directory): (verify_type): (verify_type_recursive): (dump_class): (main): (main.or): 2015-08-12 Alex Christensen Fix Debug CMake builds on Windows https://bugs.webkit.org/show_bug.cgi?id=147940 Reviewed by Chris Dumez. * DumpRenderTree/PlatformWin.cmake: * TestWebKitAPI/PlatformWin.cmake: The BitmapImage test is not enabled on the AppleWin port. * WinLauncher/CMakeLists.txt: Debug builds need /NODEFAULTLIB:MSVCRTD, too. 2015-08-12 Carlos Garcia Campos Unreviewed. run-gtk-tests: Use a longer timeout for slow tests. In r188125 I added a way to mark tests as slow to use a longer timeout. But it seems it was not enough for WTF_Lock.ContendedShortSection, so let's try again with a longer timeout now. * Scripts/run-gtk-tests: (TestRunner._run_google_test): 2015-08-12 Yusuke Suzuki Allow --debug option in run-jsc https://bugs.webkit.org/show_bug.cgi?id=147923 Reviewed by Csaba Osztrogonác. When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode. * Scripts/run-jsc: 2015-08-11 Alex Christensen Fix test after build fix in r188286. https://bugs.webkit.org/show_bug.cgi?id=147907 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: sleep_for can now be used, but we need to include 2015-08-11 Filip Pizlo Always use a byte-sized lock implementation https://bugs.webkit.org/show_bug.cgi?id=147908 Reviewed by Geoffrey Garen. All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are now tests of Lock. * TestWebKitAPI/Tests/WTF/Lock.cpp: (TestWebKitAPI::runLockTest): (TestWebKitAPI::TEST): 2015-08-11 Alexey Proskuryakov Make ASan build not depend on asan.xcconfig https://bugs.webkit.org/show_bug.cgi?id=147840 rdar://problem/21093702 Reviewed by Daniel Bates. * asan/asan.xcconfig: * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions are now marked in source code. 2015-08-11 Filip Pizlo Unreviewed, shorten another test since it timed out. * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: (TestWebKitAPI::TEST): 2015-08-11 Mark Lam Fix names of Lock tests: should be "Contended", not "Contented". https://bugs.webkit.org/show_bug.cgi?id=147905 Reviewed by Saam Barati. We're testing the behavior of lock contention (i.e. when threads contend), not whether the locks are happy (contented). * Scripts/run-gtk-tests: (TestRunner): (TestRunner.__init__): Deleted. * TestWebKitAPI/Tests/WTF/Lock.cpp: (TestWebKitAPI::runLockTest): (TestWebKitAPI::TEST): 2015-08-11 Alex Christensen Update WinCairoRequirements to VS2015. * Scripts/update-webkit-wincairo-libs: Update WinCairoRequirements location. 2015-08-11 Jason Marcell Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for internalTrac. https://bugs.webkit.org/show_bug.cgi?id=147805 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for internalTrac. (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac, respectively. (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto. (BuildbotQueueView.prototype.revisionContentForIteration): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for internalTrac. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: (Analyzer): Ditto. (Analyzer.prototype.analyze): Ditto. 2015-08-11 Filip Pizlo Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes. * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: (TestWebKitAPI::TEST): 2015-08-11 Brent Fulgham [Win] Switch Windows build to Visual Studio 2015 https://bugs.webkit.org/show_bug.cgi?id=147887 Reviewed by Alex Christensen. Update Visual Studio project file settings to use the current Visual Studio and compiler. Continue targeting binaries to run on our minimum supported configuration of Windows 7. * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj: * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj: * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj: * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to prefer the newer MSBuild included in Visual Studio 2015. (visualStudioInstallDir): (msBuildInstallDir): (visualStudioVersion): * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: * win/record-memory/record-memory.vcxproj: 2015-08-11 Alex Christensen Another speculative build fix after r188280. * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: std::this_thread is too modern c++ for VS2013 and supported GCC versions, so let's go back to usleep and I made something close to usleep, but with much lower resolution. 2015-08-11 Alex Christensen Unreviewed build fix after r188280. * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent. 2015-08-10 Filip Pizlo WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits https://bugs.webkit.org/show_bug.cgi?id=147665 Reviewed by Mark Lam. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/Lock.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added. (TestWebKitAPI::TEST): 2015-08-11 Brian Burg webkit-patch should not explode when $EDITOR is set incorrectly https://bugs.webkit.org/show_bug.cgi?id=147884 Reviewed by Darin Adler. If $EDITOR doesn't exist, log a warning and continue. * Scripts/webkitpy/common/system/user.py: (User.edit): (User.edit_changelog): 2015-08-11 Dan Bernstein Reverted r188255, because it turned out that delegates do nonot need this information. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed. 2015-08-11 Dan Bernstein [Cocoa] The UI delegate can't tell if printing was user-initiated https://bugs.webkit.org/show_bug.cgi?id=147869 Reviewed by Sam Weinig. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added. (-[PrintFrameController webView:didFinishNavigation:]): (-[PrintFrameController _webView:printFrame:userInitiated:]): (TEST): 2015-08-10 Alex Christensen Another build fix after r188239. * TestWebKitAPI/PlatformWin.cmake: Link with more libraries. * WinLauncher/CMakeLists.txt: /NODEFAULTLIB:MSVCRT is not just needed for AppleWin. 2015-08-10 Ryosuke Niwa Build fix after r188237. * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: (BenchmarkBuilder.__enter__): 2015-08-10 Dewei Zhu Update ReadMe and correct the way to use abstract abstract class. https://bugs.webkit.org/show_bug.cgi?id=147860 Reviewed by Ryosuke Niwa. Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver, so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses. * Scripts/webkitpy/benchmark_runner/README.md: * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: (BrowserDriver): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: (OSXBrowserDriver.restore_env): * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: (HTTPServerDriver): (HTTPServerDriver.set_device_id): * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: (SimpleHTTPServerDriver.get_return_code): (SimpleHTTPServerDriver): (SimpleHTTPServerDriver.set_device_id): 2015-08-10 Alex Christensen Build TestWebKitAPI with CMake on Windows https://bugs.webkit.org/show_bug.cgi?id=147851 Reviewed by Chris Dumez. * CMakeLists.txt: * TestWebKitAPI/CMakeLists.txt: Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary. Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks. Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win before we look in Source/WebCore/platform, where another file named HostWindow.h exists. * TestWebKitAPI/PlatformEfl.cmake: * TestWebKitAPI/PlatformGTK.cmake: Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls. I did this without changing the directory structure of the existing EFL and GTK builds. * TestWebKitAPI/PlatformWin.cmake: Added. * TestWebKitAPI/win/main.cpp: (main): (dllLauncherEntryPoint): Added so we can launch TestWebKitAPI executables after finding the AAS directory. * WinLauncher/CMakeLists.txt: AppleWin port needs /NODEFAULTLIB:MSVCRT. 2015-08-10 Dewei Zhu Make cleanup more robust and minor code cleaning in run benchmark script. https://bugs.webkit.org/show_bug.cgi?id=147800 Reviewed by Ryosuke Niwa. Use 'finnaly' block to make sure cleanup code is always executed. * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (built_benchmark): (built_benchmark.__init__): (built_benchmark.__enter__): (built_benchmark.__exit__): (test_environment): (test_environment.__init__): (test_environment.__enter__): (test_environment.__exit__): (BenchmarkRunner.__init__): (BenchmarkRunner.execute): (BenchmarkRunner._dump): (BenchmarkRunner._wrap): (BenchmarkRunner): Deleted. (BenchmarkRunner._cleanup): Deleted. * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: (BrowserDriver.close_browsers): (BrowserDriver): (BrowserDriver.restore_env): * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now. 2015-08-10 Youenn Fablet Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp https://bugs.webkit.org/show_bug.cgi?id=146414 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds. 2015-08-10 Carlos Garcia Campos [GTK] Test /webkit2/WebKitWebView/submit-form is flaky https://bugs.webkit.org/show_bug.cgi?id=147727 Reviewed by Sergio Villar Senin. I think it was not this test in particular, but /webkit2/WebKitWebView/custom-charset that is affecting the others. This is because changing the encoding reloads the page, but we don't wait for the page to be reloaded, so when the test finishes and other test starts the web process is still reloading the page. * Scripts/run-gtk-tests: (TestRunner): Unskip /webkit2/WebKitWebView/submit-form. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewCustomCharset): Wait until page is reloaded after changing the charset. 2015-08-09 Carlos Garcia Campos Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request. It's timing out in the bots. My guess is that there's no installer installed in the bots and gst_install_plugins_supported() returns false, so we don't even get a permission request because no installer will be launched. * Scripts/run-gtk-tests: (TestRunner): 2015-08-07 Alex Christensen [GTK] Another build fix after r188157. * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::viewSupportsOptions): Name all the things correctly! 2015-08-07 Alex Christensen [EFL, GTK] Build fix after r188176. * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: I moved forwarding headers out of a unix subdirectory because I am using them on Windows now. 2015-08-07 Alex Christensen [GTK] Speculative build fix after r188157. * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::PlatformWebView): Update parameter list. 2015-08-07 Alex Christensen Build more testing binaries with CMake on Windows https://bugs.webkit.org/show_bug.cgi?id=147799 Reviewed by Brent Fulgham. * DumpRenderTree/CMakeLists.txt: Build TestNetscapePlugin. * DumpRenderTree/PlatformWin.cmake: Build ImageDiff and add files necessary for TestNetscapePlugin on Windows. * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added. * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added. * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h. * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h. * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h. * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed. * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed. * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed. 2015-08-07 Jason Marcell Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic https://bugs.webkit.org/show_bug.cgi?id=147667 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories other than "openSource" and "internal". (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms. (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms. (sortedPlatforms): Deleted. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms. (sortedPlatforms): Deleted. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property and sorts them by this property returning the new sorted array. 2015-08-07 Filip Pizlo Lightweight locks should be adaptive https://bugs.webkit.org/show_bug.cgi?id=147545 Reviewed by Geoffrey Garen. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/Lock.cpp: Added. (TestWebKitAPI::runLockTest): (TestWebKitAPI::TEST): 2015-08-07 Anders Carlsson Fix a tyop. * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::viewSupportsOptions): 2015-08-07 Alexey Proskuryakov Update AppEngine app version numbers to the latest commit. * QueueStatusServer/app.yaml: * TestResultServer/app.yaml: 2015-08-07 Anders Carlsson Simplify WKTR's view options https://bugs.webkit.org/show_bug.cgi?id=147791 Reviewed by Sam Weinig. Instead of using a WKDictionaryRef, just use a struct for the options. * WebKitTestRunner/PlatformWebView.h: (WTR::PlatformWebView::options): (WTR::PlatformWebView::viewSupportsOptions): Deleted. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): (WTR::TestController::createWebViewWithOptions): (WTR::TestController::ensureViewSupportsOptions): (WTR::TestController::updateLayoutTypeForTest): * WebKitTestRunner/TestController.h: * WebKitTestRunner/ViewOptions.h: Added. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::viewSupportsOptions): * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::viewSupportsOptions): * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::viewSupportsOptions): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::viewSupportsOptions): * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformConfigureViewForTest): 2015-08-07 Joseph Pecoraro Running tests for a long time results in some tests running very slowly (throttling) https://bugs.webkit.org/show_bug.cgi?id=147718 Reviewed by Chris Dumez. Follow-up, make DumpRenderTree consistent with WebKitTestRunner. Although COCOA ports default this setting to be disabled in WebKit1, we should make both test harnesses disable the setting for consistency. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): 2015-08-07 Ryosuke Niwa Use a specific version of Speedometer in run-benchmark https://bugs.webkit.org/show_bug.cgi?id=147769 Reviewed by Chris Dumez. Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer). * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: 2015-08-07 Ryosuke Niwa twisted_http_server.py should support --port https://bugs.webkit.org/show_bug.cgi?id=147771 Reviewed by Chris Dumez. Added the option. This makes the script more useful on its own. * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 2015-08-07 Carlos Garcia Campos [GTK] WTF unit tests are timing out in the bots https://bugs.webkit.org/show_bug.cgi?id=147777 Reviewed by Filip Pizlo. Add a way to mark google unit tests as slow and add WTF_Lock.ContentedShortSection to the list. In case of slow test we use the double of the given timeout for that particular test. * Scripts/run-gtk-tests: (TestRunner): (TestRunner._run_google_test): 2015-08-07 Carlos Garcia Campos [GTK] run-gtk-tests should not stop when a google test case fails https://bugs.webkit.org/show_bug.cgi?id=147778 Reviewed by Philippe Normand. For glib based tests we run the test runner with the -k option, but for google tests we are aborting as soon as we find a failure. * Scripts/run-gtk-tests: (TestRunner._run_google_test_suite): Use a global return code that is set to 1 when any test has failed. 2015-08-07 Carlos Garcia Campos [GStreamer] Do not automatically show PackageKit codec installation notifications https://bugs.webkit.org/show_bug.cgi?id=135973 Reviewed by Philippe Normand. Handle the missing media plugins installation permission request in MiniBrowser and add a test case for the new API. * MiniBrowser/gtk/BrowserWindow.c: (webViewDecidePermissionRequest): * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: (permissionRequestCallback): (testInstallMissingPluginsPermissionRequest): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (methodCallCallback): 2015-08-06 Joseph Pecoraro Running tests for a long time results in some tests running very slowly (throttling) https://bugs.webkit.org/show_bug.cgi?id=147718 Reviewed by Alexey Proskuryakov. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): Ensure throttling settings are disabled for tests for all ports, as COCOA ports default to having these setting enabled. Note, there is still other timer throttling not covered by these setting. 2015-08-06 Ryosuke Niwa http_server_driver and benchmark_builder should not be in run-benchmark's plan files https://bugs.webkit.org/show_bug.cgi?id=147752 Reviewed by Chris Dumez. Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder. Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name. This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS. * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed. * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py. * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed. * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed. * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py. * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by HTTPServerDriverFactory taking the platform name as an argument. (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder. * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder. * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto. * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto. * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto. * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto. * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto. * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto. * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto. * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto. * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names. * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: (HTTPServerDriver): Replaced name by platforms. * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: (SimpleHTTPServerDriver): Ditto. * Scripts/webkitpy/benchmark_runner/run_benchmark.py: (parse_args): Removed --http-server-driver option. (start): Ditto. 2015-08-06 Chris Dumez Toggle GPS state based on page visibility to save battery https://bugs.webkit.org/show_bug.cgi?id=147685 Reviewed by Benjamin Poulain. Add testRunner.isGeolocationProviderActive() test support function. * DumpRenderTree/TestRunner.cpp: (isGeolocationProviderActiveCallback): (TestRunner::staticFunctions): * DumpRenderTree/TestRunner.h: * DumpRenderTree/mac/MockGeolocationProvider.h: * DumpRenderTree/mac/MockGeolocationProvider.mm: (-[MockGeolocationProvider isActive]): * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::isGeolocationProviderActive): * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::isGeolocationProviderActive): * WebKitTestRunner/GeolocationProviderMock.h: (WTR::GeolocationProviderMock::isActive): * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::isGeolocationProviderActive): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::isGeolocationProviderActive): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::isGeolocationProviderActive): * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): 2015-08-06 Ryosuke Niwa Automate JSBench with run-benchmark https://bugs.webkit.org/show_bug.cgi?id=147716 Reviewed by Chris Dumez. Added JSBench plan to run-benchmark. * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive. (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip. * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style. * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added. * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style. * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto. * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto. * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto. * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type. * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type. * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto. * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style. * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added. * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type. * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto. 2015-08-06 Yusuke Suzuki Pass-through the undefined options in run-jsc https://bugs.webkit.org/show_bug.cgi?id=147717 Undefined options in run-jsc is just passed to the actual jsc shell. We can execute `Tools/Scripts/run-jsc -d`. Reviewed by Csaba Osztrogonác. * Scripts/run-jsc: 2015-08-06 Carlos Garcia Campos Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form. It's flaky. * Scripts/run-gtk-tests: (TestRunner): 2015-08-06 Csaba Osztrogonác [EFL] Bump EFL version to 1.15.0 https://bugs.webkit.org/show_bug.cgi?id=147450 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: 2015-08-06 Carlos Garcia Campos Unreviewed. Unksip TestContextMenu GTK+ API test. This has been skipped for a long time, and it's very unconvenient. It has never failed for me locally, so let's try again to see if it works in the bots. I'll skip it again if it keeps failing. * Scripts/run-gtk-tests: (TestRunner): 2015-08-05 Filip Pizlo Unreviewed, roll out http://trac.webkit.org/changeset/187972. * DumpRenderTree/JavaScriptThreading.cpp: (javaScriptThreadsMutex): (runJavaScriptThread): (startJavaScriptThreads): (stopJavaScriptThreads): * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: (TestWebKitAPI::TEST): 2015-08-05 Alex Christensen Build DumpRenderTree with CMake. https://bugs.webkit.org/show_bug.cgi?id=147519 Reviewed by Brent Fulgham. * CMakeLists.txt: Build the DumpRenderTree directory now that it builds successfully. * DumpRenderTree/CMakeLists.txt: Added missing source file and don't link with WebCore.lib. * DumpRenderTree/PlatformWin.cmake: Added sources to DumpRenderTreeLib and made DumpRenderTree only build DLLLauncherMain.cpp. * WinLauncher/CMakeLists.txt: We need libcmt now that we are not linking with WebCore.lib. 2015-08-05 Alexey Proskuryakov AppScale: Use https URLs for subresources and links https://bugs.webkit.org/show_bug.cgi?id=147686 Reviewed by Ryosuke Niwa. * QueueStatusServer/filters/webkit_extras.py: * TestResultServer/static-dashboards/dashboard_base.js: * TestResultServer/static-dashboards/flakiness_dashboard.js: * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: * TestResultServer/static-dashboards/treemap.js: * TestResultServer/static-dashboards/ui.js: 2015-08-04 Filip Pizlo Rename Mutex to DeprecatedMutex https://bugs.webkit.org/show_bug.cgi?id=147675 Reviewed by Geoffrey Garen. * DumpRenderTree/JavaScriptThreading.cpp: (javaScriptThreadsMutex): (runJavaScriptThread): (startJavaScriptThreads): (stopJavaScriptThreads): * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: (TestWebKitAPI::TEST): 2015-08-05 Timothy Hatcher Update the WebKit nightly icon https://bugs.webkit.org/show_bug.cgi?id=147684 Reviewed by Sam Weinig. * WebKitLauncher/webkit.icns: Replaced. 2015-08-05 Daniel Bates REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes https://bugs.webkit.org/show_bug.cgi?id=147678 Reviewed by Brady Eidson. Add a test to ensure that we restore the "should open external URLs" policy on page reload after the web content process crashes. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: (TEST): 2015-08-04 Hunseop Jeong [EFL] Editing tests have been broken since r186694 https://bugs.webkit.org/show_bug.cgi?id=146888 Reviewed by Brent Fulgham. Restored some codes for the context click on GTK+ and EFL port. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard. 2015-08-04 Dewei Zhu Install twisted package for http server when necessary. https://bugs.webkit.org/show_bug.cgi?id=147082 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: * Scripts/webkitpy/thirdparty/__init__.py: (AutoinstallImportHook.find_module): (AutoinstallImportHook._install_twisted): 2015-08-04 Brent Fulgham [Win] Update Apple Windows build for VS2015 https://bugs.webkit.org/show_bug.cgi?id=147653 Reviewed by Dean Jackson. * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/PluginTest.h: If building with something older than VS2015, define snprintf as _snprintf. * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props: Remove unneeded macro definition for snprintf. * Scripts/webkitpy/common/system/platforminfo.py: (PlatformInfo._determine_win_version): Recognize Windows 10. * Scripts/webkitpy/port/win.py: (WinPort): Ditto. * Scripts/webkitpy/port/win_unittest.py: (WinPortTest.test_baseline_search_path): Include Windows 10 in tests. (WinPortTest._assert_version): Ditto. 2015-08-04 Brian Burg Unreviewed, update email addresses in contributors.json and watchlist. * Scripts/webkitpy/common/config/contributors.json: * Scripts/webkitpy/common/config/watchlist: 2015-08-04 Alexey Proskuryakov Implement NPAPI redirect handling https://bugs.webkit.org/show_bug.cgi?id=138675 rdar://problem/15779101 Patch by Jeffrey Pfau, updated and tweaked by me. Reviewed by Anders Carlsson. * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj: * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters: * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::NPP_URLNotify): (PluginTest::NPP_URLRedirectNotify): (PluginTest::NPP_GetValue): (PluginTest::NPN_GetURLNotify): (PluginTest::NPN_PostURLNotify): (PluginTest::NPN_GetValue): (PluginTest::NPN_ReleaseVariantValue): (PluginTest::NPN_URLRedirectResponse): (PluginTest::NPN_ConvertPoint): * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: * DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp: Added. (URLRedirect::URLRedirect): (URLRedirect::ScriptableObject::hasMethod): (URLRedirect::ScriptableObject::get): (URLRedirect::ScriptableObject::serviceAsync): (URLRedirect::ScriptableObject::invoke): (URLRedirect::NPP_GetValue): (URLRedirect::NPP_URLNotify): (URLRedirect::NPP_URLRedirectNotify): * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_GetEntryPoints): (NPP_URLNotify): (NPP_URLRedirectNotify): (NPP_GetValue): 2015-08-04 Tim Horton Move Matt Daiter to committers. * Scripts/webkitpy/common/config/contributors.json: 2015-08-04 Brent Fulgham [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures. https://bugs.webkit.org/show_bug.cgi?id=147636 Reviewed by Alex Christensen. We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly. Stop the build-webkit script from interacting with BuildOutput.htm, thereby preventing a potential build failure (especially on EWS machines) * Scripts/build-webkit: 2015-08-04 Jason Marcell Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions. https://bugs.webkit.org/show_bug.cgi?id=147280 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: (BuildbotIteration): Removed opensourceRevision, internalRevision. Added revision. Refactored _parseData to handle repositories more generically. (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevant. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue.prototype.compareIterations): Using "revision" property instead of "opensourceRevision" and "internalRevision". (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._appendPendingRevisionCount): Ditto. (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto. (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changing "internal" boolean parameter to more generic "repository" string parameter. Added "trac" parameter in order to specify the trac instance to use. Using "revision" property instead of "opensourceRevision" and "internalRevision". (BuildbotQueueView.prototype.revisionContentForIteration): Passing the repository name and trac instance to _revisionContentWithPopoverForIteration(). Using "revision" property instead of "opensourceRevision" and "internalRevision". * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Adding constants for internal and opensource repositories. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: (Analyzer.prototype._findIndexOfLargestIterationAtOrBeforeStart): Using "revision" property instead of "opensourceRevision" and "internalRevision". (Analyzer.prototype._countPercentageOfGreen): Ditto. (Analyzer.prototype.webkitTrac.recordedCommits.forEach): Ditto. (Analyzer.prototype._countTimes): Ditto. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Ditto. 2015-08-04 Mark Lam Removed a local debugging line I accidentally left in from a previous commit. Not Reviewed. * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: 2015-08-04 Mark Lam Unreviewed. Make Saam Barati a WebKit reviewer. * Scripts/webkitpy/common/config/contributors.json: 2015-08-04 Xabier Rodriguez Calvar Unreviewed, updated Streams API watchlist. * Scripts/webkitpy/common/config/watchlist: Matched .*Readable.*Stream.* and .*QueuingStrategy.* in bindings/js. 2015-08-03 Csaba Osztrogonác [CMake] Add an option to build AllInOne files https://bugs.webkit.org/show_bug.cgi?id=102647 Reviewed by Alex Christensen. * Scripts/webkitperl/FeatureList.pm: 2015-08-03 Alexey Proskuryakov AppScale: Add required indices https://bugs.webkit.org/show_bug.cgi?id=147593 Reviewed by Tim Horton. * QueueStatusServer/index.yaml: 2015-08-03 Filip Pizlo Check in LLVM 3.6.2 binary drops for El Capitan https://bugs.webkit.org/show_bug.cgi?id=147582 Reviewed by Alexey Proskuryakov. Recognize 10.11 and use the right drops. * Scripts/copy-webkitlibraries-to-product-directory: 2015-08-03 Alex Christensen [Win] Build fix after r187733. * WinLauncher/PageLoadTestClient.cpp: (PageLoadTestClient::dumpRunStatistics): wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow. 2015-08-02 Benjamin Poulain Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses https://bugs.webkit.org/show_bug.cgi?id=118455 Reviewed by Filip Pizlo. * TestWebKitAPI/Tests/WTF/HashSet.cpp: (TestWebKitAPI::TEST): 2015-07-31 Alex Christensen Prepare for VS2015 https://bugs.webkit.org/show_bug.cgi?id=146579 Reviewed by Jon Honeycutt. * WinLauncher/stdafx.h: Define __STDC_LIMIT_MACROS to have access to INTMAX_MAX. 2015-07-31 Csaba Osztrogonác [EFL] Fix pixman build on ARM with GCC 4.9.3 https://bugs.webkit.org/show_bug.cgi?id=147224 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug. 2015-07-30 Anders Carlsson Add support for window.open to WK1BrowserWindowController https://bugs.webkit.org/show_bug.cgi?id=147474 Reviewed by Dan Bernstein. * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController awakeFromNib]): Set javaScriptCanOpenWindowsAutomatically to YES. If this becomes a nuisance, we can always add a menu item to toggle this. (-[WK1BrowserWindowController webView:createWebViewWithRequest:]): Implement this UI delegate method. 2015-07-30 Anders Carlsson Undo stray commit. * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController awakeFromNib]): (-[WK1BrowserWindowController webView:createWebViewWithRequest:]): 2015-07-29 Dean Jackson Don't use (Details) when exposing SPI https://bugs.webkit.org/show_bug.cgi?id=147426 Reviewed by Dan Bernstein. If we are declaring the interface without any implementation, we should use class extensions. * DumpRenderTree/mac/DumpRenderTree.mm: * DumpRenderTree/mac/EventSendingController.mm: * DumpRenderTree/mac/PixelDumpSupportMac.mm: * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: * WebKitTestRunner/ios/PlatformWebViewIOS.mm: * WebKitTestRunner/mac/PlatformWebViewMac.mm: * WebKitTestRunner/mac/TestControllerMac.mm: 2015-07-30 Aakash Jain Replace Google App Engine with AppScale https://bugs.webkit.org/show_bug.cgi?id=147178 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunWebKitTests): * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: (.): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: (BubbleQueueServer): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: (TestHistory): * BuildSlaveSupport/build.webkit.org-config/templates/root.html: * QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section "Concurrent Requests and WSGI" of . * TestResultServer/app.yaml: Ditto * Scripts/webkitpy/common/config/urls.py: * TestResultServer/main.py: * TestResultServer/static-dashboards/dashboard_base.js: * TestResultServer/static-dashboards/loader.js: 2015-07-30 Joonghun Park [EFL] Enable IndexedDB based on DatabaseProcess https://bugs.webkit.org/show_bug.cgi?id=147221 Reviewed by Csaba Osztrogonác. * Scripts/webkitperl/FeatureList.pm: 2015-07-30 Alex Christensen Build AppleWin port with CMake https://bugs.webkit.org/show_bug.cgi?id=147385 Reviewed by Martin Robinson. * WinLauncher/CMakeLists.txt: Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully. 2015-07-29 Andy VanWagoner Implement basic types for ECMAScript Internationalization API https://bugs.webkit.org/show_bug.cgi?id=146926 Reviewed by Benjamin Poulain. Enable flag now that the basic objects are in place. * Scripts/webkitperl/FeatureList.pm: Enabled INTL 2015-07-28 Carlos Garcia Campos [GTK] Add API to set the maximum number of web processes per WebKitWebContext https://bugs.webkit.org/show_bug.cgi?id=147108 Reviewed by Gustavo Noronha Silva. Add test case to check the web process limit. * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp: (testWebProcessLimit): (beforeAll): 2015-07-28 Michael Catanzaro [GTK] Missing casts in BrowserWindow.c https://bugs.webkit.org/show_bug.cgi?id=147395 Reviewed by Carlos Garcia Campos. * MiniBrowser/gtk/BrowserWindow.c: (browserWindowSetupEditorToolbar): 2015-07-28 Yusuke Suzuki [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value "false" https://bugs.webkit.org/show_bug.cgi?id=147350 Reviewed by Sam Weinig. * Scripts/webkitperl/FeatureList.pm: 2015-07-28 Michael Catanzaro [Freetype] Always allow font matching for strong aliases https://bugs.webkit.org/show_bug.cgi?id=147057 Reviewed by Martin Robinson. Create family aliases needed for the new layout tests. * WebKitTestRunner/gtk/fonts/fonts.conf: 2015-07-28 Alexey Proskuryakov webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com https://bugs.webkit.org/show_bug.cgi?id=147359 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/tool/commands/newcommitbot.py: (NewCommitBot.begin_work_queue): * Scripts/webkitpy/tool/commands/sheriffbot.py: (SheriffBot.begin_work_queue): 2015-07-27 Alex Christensen Use Ninja on Windows. https://bugs.webkit.org/show_bug.cgi?id=147228 Reviewed by Martin Robinson. * WinLauncher/CMakeLists.txt: WinLauncherLib must make WinLauncher.dll, not WinLauncherLib.dll. * Scripts/build-webkit: Use Ninja to build WinCairo by default, but fall back to Visual Studio if Ninja is not on the system. 2015-07-24 Jon Honeycutt Test for bug #147164 "[iOS] Keyboard bold/italic/underline keys don't highlight after being tapped to style a selection" https://bugs.webkit.org/show_bug.cgi?id=147278 Reviewed by Ryosuke Niwa. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm: Added. (-[WordBoundaryTypingAttributesController webView:didFinishLoadForFrame:]): (TestWebKitAPI::TEST): Load a page with the string "Hello, world!", then select "world" and underline it. Test that the typing attributes for the current selection include the underline attribute. 2015-07-24 Hyungwook Lee Unreviewed, updated my nick name in contributors.json * Scripts/webkitpy/common/config/contributors.json: 2015-07-24 Chris Fleizach AX: scrollable elements do not allow 3-finger swipe https://bugs.webkit.org/show_bug.cgi?id=141893 Reviewed by Mario Sanchez Prada. Support global notification listeners for iOS code. Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback. Implement scrollUp/Down/Left/Right. * DumpRenderTree/AccessibilityController.h: * DumpRenderTree/AccessibilityUIElement.cpp: (increaseTextSelectionCallback): (scrollPageUpCallback): (scrollPageDownCallback): (scrollPageLeftCallback): (scrollPageRightCallback): (decreaseTextSelectionCallback): (getElementTextLengthCallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/ios/AccessibilityControllerIOS.mm: (AccessibilityController::~AccessibilityController): (AccessibilityController::elementAtPoint): (AccessibilityController::addNotificationListener): (AccessibilityController::platformResetToConsistentState): (AccessibilityController::removeNotificationListener): * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::subrole): (AccessibilityUIElement::scrollPageUp): (AccessibilityUIElement::scrollPageDown): (AccessibilityUIElement::scrollPageLeft): (AccessibilityUIElement::scrollPageRight): (AccessibilityUIElement::roleDescription): * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: (-[AccessibilityNotificationHandler _notificationReceived:]): * WebKitTestRunner/InjectedBundle/AccessibilityController.h: * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::linkedElement): (WTR::AccessibilityUIElement::headerElementAtIndex): (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus): (WTR::AccessibilityUIElement::scrollPageUp): (WTR::AccessibilityUIElement::scrollPageDown): (WTR::AccessibilityUIElement::scrollPageLeft): (WTR::AccessibilityUIElement::scrollPageRight): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: (WTR::AccessibilityController::addNotificationListener): (WTR::AccessibilityController::removeNotificationListener): * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::AccessibilityUIElement): (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus): (WTR::AccessibilityUIElement::scrollPageUp): (WTR::AccessibilityUIElement::scrollPageDown): (WTR::AccessibilityUIElement::scrollPageLeft): (WTR::AccessibilityUIElement::scrollPageRight): (WTR::AccessibilityUIElement::increaseTextSelection): 2015-07-24 Brent Fulgham [Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView. https://bugs.webkit.org/show_bug.cgi?id=147279 Reviewed by Dean Jackson. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::addUserScript): (TestRunner::addUserStyleSheet): (TestRunner::setDeveloperExtrasEnabled): 2015-07-24 Basile Clement Call fixChangeLogPatch when generating patches from webkit-patch https://bugs.webkit.org/show_bug.cgi?id=147248 Reviewed by Geoffrey Garen. When two consecutive patches are from the same author, diff tools create wrong-looking diffs for ChangeLog files where the apparent added author is actually the previous patch's author line, making it awkward to read - and things only get worse when committing a patch and a followup fix for the same bug shortly after. We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects this, which we use in perl scripts (svn-create-patch et al). But it is not used by webkit-patch, which is a python script, and thus creates "bad" diffs. In the long term, we should probably port fixChangeLogPatch to python - but in the short term, let's make webkit-patch call perl to run fixChangeLogPatch. We are already making various external calls there anyway. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.create_patch): * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.fix_changelog_patch): * Scripts/webkitpy/common/checkout/scm/svn.py: (SVN.create_patch): 2015-07-24 Dean Johnson commit-queue flags in webkit-patch are confusing https://bugs.webkit.org/show_bug.cgi?id=88694 Reviewed by Csaba Osztrogonác. * Scripts/webkitpy/tool/steps/options.py: (Options): Updated help string to be more descriptive. 2015-07-23 Brent Fulgham [Win] Implement proper High DPI support features https://bugs.webkit.org/show_bug.cgi?id=146335 Reviewed by Alex Christensen. Update WinLauncher to take device scaling factor into account. * WinLauncher/Common.cpp: (resizeSubViews): Make sure toolbars and URL bar are properly sized and using a valid font. (computeFullDesktopFrame): Handle high DPI desktops. (WndProc): Make comments more precise. * WinLauncher/WinLauncher.cpp: (WinLauncher::init): Determine device scale factor at launch. (WinLauncher::updateDeviceScaleFactor): Added. * WinLauncher/WinLauncher.h: * WinLauncher/WinLauncherWebHost.h: Use C++11 initialization. * WinLauncher/WinMain.cpp: Size interface based on scaling factor. (wWinMain): Ditto. * win/DLLLauncher/DLLLauncherMain.cpp: (wWinMain): Tell Windows we understand high DPI. 2015-07-23 Alex Christensen [Win] Unreviewed build fix after r187169. * Scripts/build-webkit: Correctly find WebKit.sln. 2015-07-23 Carlos Garcia Campos [GTK] Add API to allow executing editing commands that require an argument https://bugs.webkit.org/show_bug.cgi?id=146781 Reviewed by Gustavo Noronha Silva. Add buttons to insert image/link to the MiniBrowser edit toolbar, and test cases for insert image/link commands too. * MiniBrowser/gtk/BrowserWindow.c: (insertImageCommandCallback): (insertLinkCommandCallback): (browserWindowSetupEditorToolbar): (browserWindowConstructed): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: (testWebViewEditorInsertImage): (testWebViewEditorCreateLink): (beforeAll): 2015-07-23 Carlos Garcia Campos Unregistering and re-registering a user message handler does not work https://bugs.webkit.org/show_bug.cgi?id=138142 Reviewed by Martin Robinson. This has probably been fixed in r184846, enable the test case blocked on it. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: (testUserContentManagerScriptMessageReceived): 2015-07-22 Sukolsak Sakshuwong Add ENABLE_WEBASSEMBLY feature flag for WebAssembly https://bugs.webkit.org/show_bug.cgi?id=147212 Reviewed by Filip Pizlo. * Scripts/webkitperl/FeatureList.pm: 2015-07-22 Jon Honeycutt Add --ios-simulator to run-api-tests --help. Rubber-stamped by Dan Bates. * Scripts/run-api-tests: 2015-07-22 Jason Marcell Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo. https://bugs.webkit.org/show_bug.cgi?id=147043 Reviewed by Daniel Bates and Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: (Buildbot.prototype._normalizeQueueInfo): The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values in cases where the queue.branch property is not set and the queue is not a combined queue. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js: (BuildbotCombinedQueueView): Ensuring uniformity of repository branches within a combined queue. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot.prototype.get defaultBranches): Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a single entry for "openSource" as the default set of branches. Note that we intentionally omitted a base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not implement defaultBranches so that a person can either update the definition of the sub-queue or implement defaultBranches in the derived Buildbot class they are using. 2015-07-22 Alex Christensen Switch WinCairo build to use CMake. https://bugs.webkit.org/show_bug.cgi?id=147169 Reviewed by Brent Fulgham. * Scripts/build-webkit: * Scripts/webkitdirs.pm: (determineConfiguration): (determineArchitecture): (determinePassedConfiguration): (passedConfiguration): (jhbuildWrapperPrefixIfNeeded): (generateBuildSystemFromCMakeProject): It's CMake time! We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that. 2015-07-22 Alex Christensen Fix quirks in CMake build on Mac and Windows https://bugs.webkit.org/show_bug.cgi?id=147174 Reviewed by Gyuyoung Kim. * CMakeLists.txt: Don't build DumpRenderTree with CMake for now (until we get that working). * WinLauncher/CMakeLists.txt: Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build. 2015-07-22 Xabier Rodriguez Calvar [check-webkit-style] .lut.h files shouldn't raise a sorting issue https://bugs.webkit.org/show_bug.cgi?id=147146 Reviewed by Darin Adler. * Scripts/webkitpy/style/checkers/cpp.py: (check_include_line): Avoid checking previous lines if it it is a lut.h include. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (OrderOfIncludesTest.test_check_alphabetical_include_order): Added test. 2015-07-21 Filip Pizlo Fixed VM pool allocation should have a reserve for allocations that cannot fail https://bugs.webkit.org/show_bug.cgi?id=147154 rdar://problem/21847618 Reviewed by Geoffrey Garen. Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM mitigations work, these should all pass. Prior to this patch there were >20 failures. * Scripts/run-jsc-stress-tests: 2015-07-20 Carlos Garcia Campos [GTK] Add API to be notified about editor state changes https://bugs.webkit.org/show_bug.cgi?id=145875 Reviewed by Gustavo Noronha Silva. Update the typing attributes toggle buttons state according to the editor state in MiniBrowser, and add a test case to the WebViewEditor unit tests. * MiniBrowser/gtk/BrowserWindow.c: (browserWindowEditingCommandToggleButtonSetActive): (typingAttributesChanged): (browserWindowSetupEditorToolbar): (browserWindowConstructed): (browser_window_init): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: (testWebViewEditorEditorStateTypingAttributes): (beforeAll): 2015-07-20 Tomas Popela [GTK] Add selection-changed signal to the WebKit2 API https://bugs.webkit.org/show_bug.cgi?id=137116 Reviewed by Carlos Garcia Campos. Add a new WebProcess test TestEditor that is testing the WebKitWebEditor (namely the selection-changed signal). * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added. (WebKitWebEditorTest::create): (WebKitWebEditorTest::selectionChangedCallback): (WebKitWebEditorTest::testSelectionSelectAll): (WebKitWebEditorTest::testSelectionCollapse): (WebKitWebEditorTest::testSelectionModifyMove): (WebKitWebEditorTest::testSelectionModifyExtend): (WebKitWebEditorTest::testSelectionUnselect): (registerTests): * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added. (testWebKitWebEditorSelectionChanged): (beforeAll): (afterAll): 2015-07-20 Alex Christensen Resurrect CMake build on Windows. https://bugs.webkit.org/show_bug.cgi?id=147083 Reviewed by Gyuyoung Kim. * DumpRenderTree/CMakeLists.txt: * DumpRenderTree/PlatformWin.cmake: Added. * WinLauncher/CMakeLists.txt: 2015-07-19 Michael Catanzaro [GTK] Enable seccomp filter API tests https://bugs.webkit.org/show_bug.cgi?id=140071 Reviewed by Žan Doberšek. These tests will now be run by the run-gtk-tests script. * TestWebKitAPI/PlatformGTK.cmake: 2015-07-19 Michael Catanzaro [GTK] Add seccomp filters support https://bugs.webkit.org/show_bug.cgi?id=110014 Reviewed by Žan Doberšek. Add libseccomp to jhbuild modulesets. * gtk/jhbuild.modules: 2015-07-18 Simon Fraser MiniBrowser window title is just "Window" when page has no https://bugs.webkit.org/show_bug.cgi?id=147076 Reviewed by Tim Horton. Make MiniBrowser windows show the filename from the URL if we never get a title changed notification. * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController updateTitle:]): (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]): (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController updateTitle:]): (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): (-[WK2BrowserWindowController webView:didCommitNavigation:]): 2015-07-17 Andy Estes <aestes@apple.com> [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment https://bugs.webkit.org/show_bug.cgi?id=147044 rdar://problem/21567820 Reviewed by Brady Eidson. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled. This matches the behavior of DumpRenderTree. 2015-07-17 Benjamin Poulain <bpoulain@apple.com> [Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets https://bugs.webkit.org/show_bug.cgi?id=147032 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Test that the useless terms are eliminated by counting the number of NFA nodes generated. 2015-07-17 Dan Bernstein <mitz@apple.com> Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows https://bugs.webkit.org/show_bug.cgi?id=147040 Reviewed by Dean Jackson. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added. (-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]): (-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]): (-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): (TEST): 2015-07-16 Dean Johnson <dean_johnson@apple.com> webkit-patch uses incorrect credentials from keychain to login until account lockout https://bugs.webkit.org/show_bug.cgi?id=146923 Reviewed by Daniel Bates. When `webkit-patch upload` asks for login credentials for bugs.webkit.org, if you provide incorrect credentials then ask for them to be saved to the keychain webkit-patch will then use those incorrect credentials until 5 total attempts have been made to log in. This will lock the user out of Bugzilla for a half hour. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla.authenticate): Added argument to read_credentials() that passes in whether or not to use stored credentials. * Scripts/webkitpy/common/net/credentials.py: (Credentials.read_credentials): Added optional argument 'use_stored_credentials' that specifies whether or not to use credentials stored on the system. If it does, we do not auto-fill credentials since either the credentials caused the failure, or they weren't used in the first place so there is no reason to try and use them again if a failure happened. * Scripts/webkitpy/common/net/credentials_unittest.py: Added unit test for newly added use_stored_credentials argument. (test_do_not_use_stored_credentials): Added unit test to make sure functions that retrieve username/password information from the local system (environment, Git, keychain, keyring) are never called. It also tests that we get back our mocked username and password. (test_do_not_use_stored_credentials.MockKeyring): Mock keyring (test_do_not_use_stored_credentials.MockKeyring.get_password): Assert this is never called. (test_do_not_use_stored_credentials.FakeCredentials): Mock credentials (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_keychain): Assert this is never called. (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_environment): Ditto (test_do_not_use_stored_credentials.FakeCredentials._offer_to_store_credentials_in_keyring): Ditto (test_do_not_use_stored_credentials.FakeUser): Mock the User class (test_do_not_use_stored_credentials.FakeUser.prompt): Returns a username to assert against. (test_do_not_use_stored_credentials.FakeUser.prompt_password): Returns a password to assert against. 2015-07-16 Gyuyoung Kim <gyuyoung.kim@webkit.org> Unreviewed, remove my redundant email information. * Scripts/webkitpy/common/config/contributors.json: 2015-07-16 Hyungwook Lee <hyungwook.lee@navercorp.com> Unreviewed. Add Hyungwook Lee as a committer. * Scripts/webkitpy/common/config/contributors.json: 2015-07-16 Wenson Hsieh <wenson_hsieh@apple.com> Added myself to the list of contributors. Reviewed by Brent Fulgham. * Scripts/webkitpy/common/config/contributors.json: 2015-07-16 Alex Christensen <achristensen@webkit.org> [Content Extensions] Cache domain actions https://bugs.webkit.org/show_bug.cgi?id=146817 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): Test if-domain and unless-domain with multiple load types. 2015-07-16 Benjamin Poulain <bpoulain@apple.com> [Content extensions] Combine suffixes when generating NFAs https://bugs.webkit.org/show_bug.cgi?id=146961 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::compareContents): * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp: 2015-07-15 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Input method filter is always enabled when the view is focused https://bugs.webkit.org/show_bug.cgi?id=146965 Reviewed by Martin Robinson. Use setEnabled() instead of notifyFocusedIn() to enable input methods. * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter): 2015-07-15 Michael Catanzaro <mcatanzaro@igalia.com> [EFL] Bump libseccomp version to 2.2.3 https://bugs.webkit.org/show_bug.cgi?id=146980 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: 2015-07-15 Brent Fulgham <bfulgham@apple.com> [Win] Maintain consistent COM Interfaces https://bugs.webkit.org/show_bug.cgi?id=146983 <rdar://problem/21822278> Reviewed by Dean Jackson. Update DumpRenderTree and WinLauncher to use the properly versioned COM interface objects. * DumpRenderTree/win/AccessibilityControllerWin.cpp: (AccessibilityController::rootElement): * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): (resetWebViewToConsistentStateBeforeTesting): (runTest): (createWebViewAndOffscreenWindow): * DumpRenderTree/win/EditingDelegate.cpp: (EditingDelegate::QueryInterface): (EditingDelegate::shouldEndEditingInDOMRange): (EditingDelegate::shouldInsertNode): * DumpRenderTree/win/EditingDelegate.h: * DumpRenderTree/win/EventSender.cpp: (scalePageByCallback): * DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didCommitLoadForFrame): * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::callShouldCloseOnWebView): (TestRunner::applicationCacheDiskUsageForOrigin): (TestRunner::clearApplicationCacheForOrigin): (TestRunner::setDefersLoading): (TestRunner::setDomainRelaxationForbiddenForURLScheme): (TestRunner::setTabKeyCyclesThroughElements): (TestRunner::setValueForUser): (TestRunner::dispatchPendingLoadRequests): (TestRunner::setWindowIsKey): (TestRunner::execCommand): (TestRunner::addOriginAccessWhitelistEntry): (TestRunner::removeOriginAccessWhitelistEntry): (TestRunner::addUserScript): (TestRunner::addUserStyleSheet): (TestRunner::showWebInspector): (TestRunner::closeWebInspector): (TestRunner::evaluateInWebInspector): (TestRunner::setSerializeHTTPLoads): * DumpRenderTree/win/TextInputControllerWin.cpp: (TextInputController::setMarkedText): (TextInputController::hasMarkedText): (TextInputController::unmarkText): (TextInputController::markedRange): (TextInputController::insertText): (TextInputController::firstRectForCharacterRange): (TextInputController::selectedRange): * DumpRenderTree/win/UIDelegate.h: (UIDelegate::unused2): (UIDelegate::unused3): (UIDelegate::webViewScrolled): (UIDelegate::webViewShouldInterruptJavaScript): (UIDelegate::webViewReceivedFocus): (UIDelegate::unused4): Deleted. * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp): * WinLauncher/PageLoadTestClient.cpp: (PageLoadTestClient::didStartProvisionalLoad): * WinLauncher/WinLauncher.cpp: (WinLauncher::init): * WinLauncher/WinLauncher.h: * WinLauncher/WinLauncherWebHost.cpp: (WinLauncherWebHost::didFinishLoadForFrame): (WinLauncherWebHost::didFirstLayoutInFrame): * WinLauncher/WinLauncherWebHost.h: 2015-07-15 Dean Johnson <dean_johnson@apple.com> Many test failures in scm_unittest.py https://bugs.webkit.org/show_bug.cgi?id=143967 Reviewed by Daniel Bates. * Scripts/webkitpy/common/checkout/scm/detection.py: (SCMDetector.detect_scm_system): Paths with symlinks are now resolved to absolute canonical file paths. Two mutually exclusive issues cause this to be a problem. 1) Python's os.path.relpath() function does not return correct relative paths between two filepaths that point to the same file, if symlinks are involved. On Mac, /tmp points to /private/tmp ex. os.path.relpath('/tmp', '/private/tmp') returns '../../tmp' What we want is actually just '.' 2) Git does not allow file paths to trace outside of the Git repository. This means that if you have a repository in /tmp and you refer to that repository when invoking a git command as ../tmp, Git will produce errors about working outside of the repository. * Scripts/webkitpy/common/checkout/scm/git.py: Over time Git has changed its default behavior and such, needed to be updated. (Git.changed_files): '--' was added into the command so that patch_directories were taken as positional arguments. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Changed tests and setup in the GitSVNTest class to more closely emulate the version of Git that the tests assumed a system had. Also fixed a small side-effect from the absolute canonical path fix in SCMDetector.detect_scm_system (SVNTestRepository.setup): A relative filepath was previously passed as the checkout root to SCMDetector.detect_scm_system, but is now cleaned to an absolute canonical path before being passed in. The failing test was a "sanity check" that the svn.checkout_root and scm.checkout_root were the same. (GitSVNTest._setup_git_checkout): 1) Added "--prefix ''" option to `git clone` since Git changed its default behavior in version 2.0. 2) The branch master was renamed to trunk to more closely emulate what tests expected when they were written. (GitSVNTest.test_changed_files_local_plus_working_copy): Two of the three original tests failed because the tests expected the trunk branch to produce its parent's commit, whereas Git merely provides the HEAD commit for a given branch (trunk in this case). Based on other tests written in the same commit, it appears these tests were failing from the point they were written. 2015-07-14 Anders Carlsson <andersca@apple.com> Assertions.h should include ExportMacros.h https://bugs.webkit.org/show_bug.cgi?id=146948 Reviewed by Tim Horton. Remove now unneeded WTF_EXPORT_PRIVATE define. * DumpRenderTree/cg/ImageDiffCG.cpp: 2015-07-14 Carlos Alberto Lopez Perez <clopez@igalia.com> [GTK] [Wayland] Build by default the X11 and Wayland targets. https://bugs.webkit.org/show_bug.cgi?id=146057 Reviewed by Carlos Garcia Campos. * gtk/install-dependencies: 2015-07-10 Brent Fulgham <bfulgham@apple.com> [Mac] Unable to dismiss context menu during test runs https://bugs.webkit.org/show_bug.cgi?id=146836 Reviewed by Tim Horton. Since Context Menus are modal, the test system would block on the displayed context menu, causing tests to fail. Instead, we should do what WK1 was doing, which is to perform the mouse click and generate the menu contents, but not ask AppKit to display it. Drive-by fix: We did not handle 'escape' key presses. This is also fixed. * DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:withLocation:]): Handle the 'escape' character. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::mouseMoveTo): Keep track of the current mouse position. (WTR::EventSendingController::contextClick): Don't emit an actual context menu invocation and then copy the menu items. Instead, use WKBundlePageCopyContentMenuAtPointInWindow to do all the same work without actually calling on AppKit to display the menu. ask WebCore to do all the work EXCEPT displaying the menu. * WebKitTestRunner/InjectedBundle/EventSendingController.h: * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::keyDown): Handle the 'escape' character. 2015-07-09 Filip Pizlo <fpizlo@apple.com> It should be possible to run the OSR exit fuzzer https://bugs.webkit.org/show_bug.cgi?id=146814 Reviewed by Mark Lam. This runs a test command to detect how many static OSR exit sites it had, and then for each exit site, it triggers three exits (earliest opportunity, last opportunity, some middle opportunity), plus a mode where the check always exits. This is an exhaustive search, so in the future it'll be very appropriate for cases where we have a simple test and we want to see what happens when you eventually exit in this test. Right now this isn't hooked into any specific tests, but I've done some spot checks on it and it seems to do the right thing. * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz: Added. (fail): 2015-07-10 Alex Christensen <achristensen@webkit.org> Add tests for r186649 https://bugs.webkit.org/show_bug.cgi?id=146821 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): (TestWebKitAPI::compareContents): (TestWebKitAPI::expectedIndex): Add some larger tests to test large jumps. 2015-07-09 Dewei Zhu <dewei_zhu@apple.com> Quick fix for run_benchmark script that AppKit.NSRunningApplication does not work properly https://bugs.webkit.org/show_bug.cgi?id=146820 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: (OSXBrowserDriver): (OSXBrowserDriver.close_browsers): (OSXBrowserDriver._terminiate_processes): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: (OSXChromeDriver): (OSXChromeCanaryDriver): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: (OSXFirefoxDriver): (OSXFirefoxNightlyDriver): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: (OSXSafariDriver): 2015-07-09 Michael Catanzaro <mcatanzaro@igalia.com> [GTK] pango should be included in the default jhbuild moduleset https://bugs.webkit.org/show_bug.cgi?id=146683 Reviewed by Martin Robinson. Recent releases of pango 1.36 use functions that are only provided by fontconfig 2.12 when compiled against sufficiently-new versions of fontconfig. Since we depend on both pango and fontconfig, and pango depends on fontconfig, we must either add pango to our jhbuild moduleset or else upgrade fontconfig to a recent unstable release (knowing that we will have the same problem again the next time pango wants to use a new fontconfig feature), or remove fontconfig (which would make it hard to keep tests working). On the balance, adding pango is best. * gtk/jhbuild-optional.modules: Remove pango * gtk/jhbuild.modules: Add pango and update to latest 1.36.8 2015-07-09 Devin Rousso <drousso@apple.com> Unreviewed. Added myself as a committer. * Scripts/webkitpy/common/config/contributors.json: 2015-07-09 Timothy Horton <timothy_horton@apple.com> Add a way to set the default URL from Minibrowser UI https://bugs.webkit.org/show_bug.cgi?id=146780 Reviewed by Simon Fraser. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate didChangeSettings]): * MiniBrowser/mac/BrowserWindowController.h: * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController fetch:]): (-[BrowserWindowController reload:]): (-[BrowserWindowController forceRepaint:]): (-[BrowserWindowController goBack:]): (-[BrowserWindowController goForward:]): (-[BrowserWindowController showHideWebView:]): (-[BrowserWindowController removeReinsertWebView:]): (-[BrowserWindowController zoomIn:]): (-[BrowserWindowController zoomOut:]): (-[BrowserWindowController resetZoom:]): (-[BrowserWindowController canZoomIn]): (-[BrowserWindowController canZoomOut]): (-[BrowserWindowController canResetZoom]): (-[BrowserWindowController toggleZoomMode:]): (-[BrowserWindowController setScale:]): (-[BrowserWindowController toggleShrinkToFit:]): (-[BrowserWindowController dumpSourceToConsole:]): (-[BrowserWindowController find:]): (-[BrowserWindowController didChangeSettings]): (-[BrowserWindowController currentURL]): Get rid of the BrowserController protocol. It was a bad idea and confused Interface Builder more than I thought possible. * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController setDefaultURLToCurrentURL:]): If we have a BrowserWindowController, grab its URL and set the relevant default. * MiniBrowser/mac/WK1BrowserWindowController.h: * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController currentURL]): * MiniBrowser/mac/WK2BrowserWindowController.h: * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController currentURL]): Retrieve the current URL from the WKView/WebView. 2015-07-09 Timothy Horton <timothy_horton@apple.com> Increase MiniBrowser location bar maximum width https://bugs.webkit.org/show_bug.cgi?id=146779 Reviewed by Simon Fraser. * MiniBrowser/mac/BrowserWindow.xib: Have an enormous maximum width on the location bar, so that it doesn't stop expanding with the window at 800px. 2015-07-08 Brady Eidson <beidson@apple.com> Crash calling [WebView close] in didFinishLoadForFrame callback. <rdar://problem/21690765> and https://bugs.webkit.org/show_bug.cgi?id=146773 Reviewed by David Kilzer. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/WebViewCloseInsideDidFinishLoadForFrame.mm: Added. (-[WebViewCloseFrameLoadDelegate webView:didFinishLoadForFrame:]): (TestWebKitAPI::TEST): 2015-07-08 Hyungwook Lee <hyungwook.lee@navercorp.com> Fix ASSERTION FAILED: !m_pendingNavigationID in WebPage::reload(). https://bugs.webkit.org/show_bug.cgi?id=146546 Reviewed by Darin Adler. We did't reset pendingNavigationID value when request url is empty. Hence we need to ignore ASSERT check in this case. * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: (TestWebKitAPI::TEST): 2015-07-08 Benjamin Poulain <bpoulain@apple.com> [Content Extensions] Fuse undistinguishable actions as much as possible https://bugs.webkit.org/show_bug.cgi?id=146762 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Test that combinations and flags still work as expected. 2015-07-08 Carlos Alberto Lopez Perez <clopez@igalia.com> [GTK] [Wayland] Allow building and testing the Wayland target with the default JHBuild moduleset. https://bugs.webkit.org/show_bug.cgi?id=146056 Reviewed by Martin Robinson. * gtk/install-dependencies: libepoxy is now required for building GTK+. * gtk/jhbuild-wayland.modules: Removed. Not longer needed. * gtk/jhbuild.modules: Upgrade GTK+ (3.16.4) and required dependencies for building: Cairo (1.14.2), Gdk-Pixbuf (2.30.8) and GLib (2.44.1). * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Removed. Not longer needed. Cairo removed support for LTO on (1.14). Upstream commit: c7ff9bb. * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Removed. Not longer needed. GTK+ merged this patch on GTK+-3.10. Upstream commit: 8d83d98. 2015-07-06 Matt Rajca <mrajca@apple.com> Media Session: propagate metadata changes to UI clients https://bugs.webkit.org/show_bug.cgi?id=146660 Reviewed by Tim Horton. * WebKitTestRunner/TestController.cpp: Build fixes for updated PageUIClient. (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): 2015-07-07 Brady Eidson <beidson@apple.com> HTTP Auth cached after disabling private browsing/reset. <rdar://problem/8293055> and https://bugs.webkit.org/show_bug.cgi?id=146654 Reviewed by Tim Horton. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): Clear in-memory credentials in between test runs. 2015-07-06 Alex Christensen <achristensen@webkit.org> [Content Extensions] Remove memory page reporting https://bugs.webkit.org/show_bug.cgi?id=146659 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): 2015-07-06 Benjamin Poulain <benjamin@webkit.org> [Content Extensions] Make the DFA transitions ranges instead of characters https://bugs.webkit.org/show_bug.cgi?id=146575 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp: Since the minimizer is perfect, we get the minimal solution now, which is really cool! 2015-07-06 Brady Eidson <beidson@apple.com> ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads. <rdar://problem/21640050> and https://bugs.webkit.org/show_bug.cgi?id=146563 Reviewed by Geoff Garen. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): For testing purposes, all pages should start with the ShouldOpenExternalURLsPolicy set to "ShouldNotAllow" 2015-07-06 Daniel Bates <dabates@apple.com> Unreviewed, rolling out r170639. Broke using webkit-patch apply-attachment to apply an attachment from a security bug. The patch incorrectly assumed that Bugzilla returns a non-HTTP 200 status code in its HTTP response when authentication is required. Reverted changeset: "webkit-patch apply-from-bug / apply-attachment should not ask for credentials if none are required" https://bugs.webkit.org/show_bug.cgi?id=40095 http://trac.webkit.org/changeset/170639 2015-07-04 Chris Dumez <cdumez@apple.com> Drop RefPtr::clear() method https://bugs.webkit.org/show_bug.cgi?id=146556 Reviewed by Brady Eidson. Drop RefPtr::clear() method in favor of "= nullptr;" pattern. 2015-07-03 Dan Bernstein <mitz@apple.com> Fixed the iOS build. * DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): 2015-07-03 Dan Bernstein <mitz@apple.com> [Xcode] Update some build settings as recommended by Xcode 7 https://bugs.webkit.org/show_bug.cgi?id=146597 Reviewed by Sam Weinig. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated LastUpgradeCheck. * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS, ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION, CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION, CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE, GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR. * DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController webScriptNameForSelector:]): Removed check for setDragMode:, which was removed in r19101. * DumpRenderTree/mac/TextInputController.m: (-[TextInputController interpretKeyEvents:withSender:]): Suppressed -Wundeclared-selector around used of a selector not that is not declared anywhere. * MiniBrowser/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Updated LastUpgradeCheck. * TestWebKitAPI/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS, ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION, CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION, CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE, GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck. 2015-07-02 Daniel Bates <dabates@apple.com> [iOS] Add WebKitSystemInterface for iOS 8.4 https://bugs.webkit.org/show_bug.cgi?id=146548 Rubber-stamped by Zalan Bujtas. * Scripts/copy-webkitlibraries-to-product-directory: 2015-07-02 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18 https://bugs.webkit.org/show_bug.cgi?id=146234 Reviewed by Sergio Villar Senin. Enable the WebSQL directory test that was disabled because of this bug. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextConfiguration): 2015-07-01 Matthew Daiter <mdaiter@apple.com> Enabled MEDIA_STREAM flag https://bugs.webkit.org/show_bug.cgi?id=145947 <rdar://problem/21365829> Reviewed by Eric Carlson. * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: 2015-06-30 Martin Robinson <mrobinson@igalia.com> [GTK] REGRESSION(r183936): Test /webkit2/WebKitWebContext/spell-checker fails since r183936 https://bugs.webkit.org/show_bug.cgi?id=144828 Reviewed by Carlos Garcia Campos. * WebKitTestRunner/gtk/main.cpp: (main): Use the new WKTextChecker API to set the spell checking languages when the process is starting up. 2015-06-30 Andy VanWagoner <thetalecrafter@gmail.com> Implement ECMAScript Internationalization API https://bugs.webkit.org/show_bug.cgi?id=90906 Reviewed by Benjamin Poulain. * Scripts/webkitperl/FeatureList.pm: add ENABLE_INTL flag 2015-06-30 Jonathan Davis <jond@apple.com> Unreviewed. Added myself as a committer. * Scripts/webkitpy/common/config/contributors.json: 2015-06-30 Brent Fulgham <bfulgham@apple.com> Unreviewed build fix. * Scripts/update-webkit-dependency: Try to build even if we cannot connect to developer.apple.com to get update libraries. 2015-06-29 Jake Nielsen <jacob_nielsen@apple.com> Add timeout in run-webkit-tests for launching the simulator https://bugs.webkit.org/show_bug.cgi?id=146371 Reviewed by Darin Adler. Adds a default 5-minute timeout using the timeout class in webkitpy.benchmark_runner.utils for the otherwise infinitely patient wait_until_device_is_in_state method. * Scripts/webkitpy/xcode/simulator.py: (Simulator.DeviceState): (Simulator): (Simulator.wait_until_device_is_in_state): (Simulator.device_state): 2015-06-29 Benjamin Poulain <benjamin@webkit.org> Make the NFA transitions range-based https://bugs.webkit.org/show_bug.cgi?id=146338 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Test some new interesting cases. 2015-06-28 Dan Bernstein <mitz@apple.com> [Xcode] Use the same environment for command-line and IDE builds https://bugs.webkit.org/show_bug.cgi?id=146401 Reviewed by Anders Carlsson. * Scripts/webkitdirs.pm: (XcodeOptions): Set the UseSanitizedBuildSystemEnvironment user default to YES, which makes xcodebuild use the same environment Xcode uses. 2015-06-28 Dan Bernstein <mitz@apple.com> REGRESSION (r185915): Source-incompatible change in WKPageUIClient https://bugs.webkit.org/show_bug.cgi?id=146396 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: (TestWebKitAPI::runJavaScriptAlert): Removed _deprecatedForUseWithV0 suffix from the name. (TestWebKitAPI::TEST): Updated for renames. * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: (runJavaScriptAlert): Removed suffix. (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView): Updated. * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: (runJavaScriptAlert): Removed suffix. (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView): Updated. 2015-06-27 Carlos Garcia Campos <cgarcia@igalia.com> [GTK][SOUP] Implement WebCore::PublicSuffix for soup and enable PUBLIC_SUFFIX_LIST for GTK+ https://bugs.webkit.org/show_bug.cgi?id=146318 Reviewed by Sergio Villar Senin. Copy mac PublicSuffix test to the common directory and add it to the GTK+ build. * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp: Added. (TestWebKitAPI::TEST_F): 2015-06-26 Per Arne Vollan <peavo@outlook.com> WinLauncher fails to download files. https://bugs.webkit.org/show_bug.cgi?id=146242 Reviewed by Alex Christensen. Added WinLauncher download delegate. * WinLauncher/Common.cpp: * WinLauncher/WebDownloadDelegate.cpp: Added. (WebDownloadDelegate::WebDownloadDelegate): (WebDownloadDelegate::~WebDownloadDelegate): (WebDownloadDelegate::QueryInterface): (WebDownloadDelegate::AddRef): (WebDownloadDelegate::Release): (WebDownloadDelegate::decideDestinationWithSuggestedFilename): (WebDownloadDelegate::didCancelAuthenticationChallenge): (WebDownloadDelegate::didCreateDestination): (WebDownloadDelegate::didFailWithError): (WebDownloadDelegate::didReceiveAuthenticationChallenge): (WebDownloadDelegate::didReceiveDataOfLength): (WebDownloadDelegate::didReceiveResponse): (WebDownloadDelegate::shouldDecodeSourceDataOfMIMEType): (WebDownloadDelegate::willResumeWithResponse): (WebDownloadDelegate::willSendRequest): (WebDownloadDelegate::didBegin): (WebDownloadDelegate::didFinish): * WinLauncher/WebDownloadDelegate.h: Added. * WinLauncher/WinLauncher.cpp: (WinLauncher::setAccessibilityDelegate): (WinLauncher::setResourceLoadDelegate): (WinLauncher::setDownloadDelegate): (WinLauncher::mainFrame): * WinLauncher/WinLauncher.h: (WinLauncher::standardPreferences): (WinLauncher::privatePreferences): * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: * WinLauncher/WinMain.cpp: (wWinMain): 2015-06-26 Csaba Osztrogonác <ossy@webkit.org> [EFL] Bump libseccomp version to 2.2.1 https://bugs.webkit.org/show_bug.cgi?id=146341 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: * efl/jhbuildrc: Enabled libseccomp build on AArch64. * efl/patches/libseccomp-pick-up-CC.patch: Removed, we don't need it anymore. 2015-06-25 Alex Christensen <achristensen@webkit.org> [Content Extensions] Add a way to match a domain but not subdomains https://bugs.webkit.org/show_bug.cgi?id=146241 rdar://problem/21557754 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): Update subdomain test because of changed behavior and add test for new '*' functionality. 2015-06-25 Jaehun Lim <ljaehun.lim@samsung.com> Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes. https://bugs.webkit.org/show_bug.cgi?id=146308 Reviewed by Csaba Osztrogonác. ENABLE_CSS3_CONDITIONAL_RULES guard was removed from r174536. * Scripts/webkitperl/FeatureList.pm: 2015-06-25 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add initial WebKitWebsiteDataManager API for process configuration options https://bugs.webkit.org/show_bug.cgi?id=146149 Reviewed by Sergio Villar Senin. Update unit tests to use WebKitWebsiteDataManager. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextConfiguration): (serverCallback): * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h: (Test::Test): Use WebKitWebsiteDataManager and set all possible values to ensure unit tests don't write outside the temporary directory. (Test::~Test): Explicitly reset the web context to ensure its objects are released before the leaks check. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::wait): Fix the GSource used, since we are receiving a double in seconds, but using g_timeout_add_seconds() that expects an unsigned in seconds. Use GMainLoopSource to correctly handle the value and simplify the code. 2015-06-24 Jason Marcell <jmarcell@apple.com> Work towards: Add status of Safari projects on iOS Dashboard on build-safari https://bugs.webkit.org/show_bug.cgi?id=146126 <rdar://problem/18226291> Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: (documentReady): Using combined queues to display iOS projects 2015-06-24 Doug Russell <d_russell@apple.com> Bug 146177 - AX: AXObjectCache should try to use an unignored accessibilityObject when posting a selection notification when on the border between two accessibilityObjects https://bugs.webkit.org/show_bug.cgi?id=146177 Reviewed by Darin Adler. Add support for mapping WebCore Accessibility types into JSValueRef types so they can be used in tests. * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: (webAccessibilityObjectWrapperClass): (-[AccessibilityNotificationHandler startObserving]): (makeValueRefForValue): (makeArrayRefForArray): (makeObjectRefForDictionary): (-[AccessibilityNotificationHandler _notificationReceived:]): * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: (webAccessibilityObjectWrapperClass): (-[AccessibilityNotificationHandler startObserving]): (makeValueRefForValue): (makeArrayRefForArray): (makeObjectRefForDictionary): (-[AccessibilityNotificationHandler _notificationReceived:]): 2015-06-24 Zalan Bujtas <zalan@apple.com> Subpixel rendering: roundToDevicePixel() snaps to wrong value. https://bugs.webkit.org/show_bug.cgi?id=146273 rdar://problem/18509840 Reviewed by Simon Fraser. Due to the floating point approximate representation, we can't always produce the correct snap value. This patch addresses the issue by removing redundant kFixedPointDenominator multiplication and by changing the rounding in roundToDevicePixel() from float to double. * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: (TestWebKitAPI::TEST): 2015-06-24 Brady Eidson <beidson@apple.com> Update JavaScript dialog delegates to include a WKSecurityOriginRef argument. <rdar://problem/21269187> and https://bugs.webkit.org/show_bug.cgi?id=146249 Reviewed by Alex Christensen. - Update WKTR to the new client structure. - Update existing TestWebKitAPI tests to either use the new client structure or assign the old function signature to the updated variable name. - Include a new test. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: (TestWebKitAPI::runJavaScriptAlert): * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp: (TestWebKitAPI::analyzeDialogArguments): (TestWebKitAPI::runJavaScriptAlert): (TestWebKitAPI::runJavaScriptConfirm): (TestWebKitAPI::runJavaScriptPrompt): (TestWebKitAPI::createNewPage): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView): * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView): * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): 2015-06-23 Dewei Zhu <dewei_zhu@apple.com> Refactoring benchmark runner script to follow pep8 code style. https://bugs.webkit.org/show_bug.cgi?id=146264 Reviewed by Ryosuke Niwa. Refactor benchmark runner script to follow pep8 code style. * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: (GenericBenchmarkBuilder.prepare): (GenericBenchmarkBuilder._run_create_script): (GenericBenchmarkBuilder._copy_benchmark_to_temp_dir): (GenericBenchmarkBuilder._fetch_remote_archive): (GenericBenchmarkBuilder): (GenericBenchmarkBuilder._checkout_with_subversion): (GenericBenchmarkBuilder._apply_patch): (GenericBenchmarkBuilder.clean): (GenericBenchmarkBuilder._runCreateScript): Deleted. (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Deleted. (GenericBenchmarkBuilder._fetchRemoteArchive): Deleted. (GenericBenchmarkBuilder._checkoutWithSubverion): Deleted. (GenericBenchmarkBuilder._applyPatch): Deleted. * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.__init__): (BenchmarkRunner._find_plan_file): (BenchmarkRunner.execute): (BenchmarkRunner._cleanup): (BenchmarkRunner._dump): (BenchmarkRunner._wrap): (BenchmarkRunner._merge): (BenchmarkRunner._show_results): (BenchmarkRunner._findPlanFile): Deleted. (BenchmarkRunner.cleanup): Deleted. (BenchmarkRunner.dump): Deleted. (BenchmarkRunner.wrap): Deleted. (BenchmarkRunner.merge): Deleted. (BenchmarkRunner.show_results): Deleted. * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: (BrowserDriver.prepare_env): (BrowserDriver.launch_url): (BrowserDriver.close_browsers): (BrowserDriver.prepareEnv): Deleted. (BrowserDriver.launchUrl): Deleted. (BrowserDriver.closeBrowser): Deleted. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: (OSXBrowserDriver): (OSXBrowserDriver.prepare_env): (OSXBrowserDriver.close_browsers): (OSXBrowserDriver._launch_process): (OSXBrowserDriver._terminiate_processes): (OSXBrowserDriver._launch_process_with_caffinate): (OSXBrowserDriver._screen_size): (OSXBrowserDriver.prepareEnv): Deleted. (OSXBrowserDriver.closeBrowsers): Deleted. (OSXBrowserDriver.launchProcess): Deleted. (OSXBrowserDriver.terminateProcesses): Deleted. (OSXBrowserDriver.launchProcessWithCaffinate): Deleted. (OSXBrowserDriver.screenSize): Deleted. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: (OSXChromeDriver): (OSXChromeDriver.launch_url): (OSXChromeCanaryDriver): (OSXChromeCanaryDriver.launch_url): (OSXChromeDriver.launchUrl): Deleted. (OSXChromeCanaryDriver.launchUrl): Deleted. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: (OSXFirefoxDriver): (OSXFirefoxDriver.launch_url): (OSXFirefoxNightlyDriver): (OSXFirefoxNightlyDriver.launch_url): (OSXFirefoxDriver.launchUrl): Deleted. (OSXFirefoxNightlyDriver.launchUrl): Deleted. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: (OSXSafariDriver): (OSXSafariDriver.prepare_env): (OSXSafariDriver.launch_url): (OSXSafariDriver.close_browsers): (OSXSafariDriver._maximize_window): (OSXSafariDriver.prepareEnv): Deleted. (OSXSafariDriver.launchUrl): Deleted. (OSXSafariDriver.closeBrowsers): Deleted. (OSXSafariDriver.maximizeWindow): Deleted. * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: (HTTPServerDriver.fetch_result): (HTTPServerDriver.kill_server): (HTTPServerDriver.get_return_code): (HTTPServerDriver.set_device_id): (HTTPServerDriver.fetchResult): Deleted. (HTTPServerDriver.killServer): Deleted. (HTTPServerDriver.getReturnCode): Deleted. (HTTPServerDriver.setDeviceID): Deleted. * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: (SimpleHTTPServerDriver.serve): (SimpleHTTPServerDriver.base_url): (SimpleHTTPServerDriver.fetch_result): (SimpleHTTPServerDriver.kill_server): (SimpleHTTPServerDriver.get_return_code): (SimpleHTTPServerDriver): Deleted. (SimpleHTTPServerDriver.baseUrl): Deleted. (SimpleHTTPServerDriver.fetchResult): Deleted. (SimpleHTTPServerDriver.killServer): Deleted. (SimpleHTTPServerDriver.getReturnCode): Deleted. * Scripts/webkitpy/benchmark_runner/utils.py: (get_path_from_project_root): (force_remove): (getPathFromProjectRoot): Deleted. (forceRemove): Deleted. 2015-06-23 Anders Carlsson <andersca@apple.com> Add operator! and copy/move constructors to WeakObjCPtr https://bugs.webkit.org/show_bug.cgi?id=146255 Reviewed by Andreas Kling. * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: (TEST): 2015-06-23 Simon Fraser <simon.fraser@apple.com> Expose some more rendering progress events, and have MiniBrowser log for each of them https://bugs.webkit.org/show_bug.cgi?id=146227 Reviewed by Darin Adler. Register for layout milestones/rendering progress events in the WK1 and WK2 browser window controllers, and, if logging is turned on, log when they are reached. * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController awakeFromNib]): (-[WK1BrowserWindowController webView:didLayout:]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]): (-[WK2BrowserWindowController _webView:renderingProgressDidChange:]): 2015-06-23 Brady Eidson <beidson@apple.com> WKFrameInfo should have an accessor for the Frame's current security origin. https://bugs.webkit.org/show_bug.cgi?id=146162 Reviewed by Dan Bernstein. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Added. (sawDialog): (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): (-[ModalAlertsUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]): (-[ModalAlertsUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]): (TEST): 2015-06-23 Tanay C <tanay.c@samsung.com> Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn https://bugs.webkit.org/show_bug.cgi?id=146007 Reviewed by Darin Adler. * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Add attribute to functions. (pluginLogWithWindowObject): (pluginLogWithArguments): (pluginLog): * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Add attribute to functions. (PluginTest::executeScript): (PluginTest::log): 2015-06-23 Csaba Osztrogonác <ossy@webkit.org> [EFL] Add libhyphen-dev as dependency after r185862 https://bugs.webkit.org/show_bug.cgi?id=146230 Reviewed by Gyuyoung Kim. * efl/install-dependencies: 2015-06-22 Ryuan Choi <ryuan.choi@navercorp.com> [EFL] Hyphenation is not supported https://bugs.webkit.org/show_bug.cgi?id=89830 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: Added webkitgtk-test-dicts for layout test. 2015-06-22 Dewei Zhu <dewei_zhu@apple.com> Get rid of factory json files in benchmark_runner https://bugs.webkit.org/show_bug.cgi?id=146175 Reviewed by Ryosuke Niwa. Get rid of factory json files in benchmark_runner and refactoring the code. * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: (benchmark_builder_loader): * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: (BenchmarkBuilderFactory): * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Removed. * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: (GenericBenchmarkBuilder): * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.__init__): (BenchmarkRunner.execute): * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: (browser_driver_loader): * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: (BrowserDriver): * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: (BrowserDriverFactory): (BrowserDriverFactory.available_platforms): (BrowserDriverFactory.available_browsers): (BrowserDriverFactory.add_browser_driver): (BrowserDriverFactory.create): * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Removed. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: (OSXBrowserDriver): (OSXBrowserDriver.prepareEnv): (OSXBrowserDriver.terminateProcesses): (OSXBrowserDriver.screenSize): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: (OSXChromeDriver): (OSXChromeCanaryDriver): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: (OSXFirefoxDriver): (OSXFirefoxNightlyDriver): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: (OSXSafariDriver): * Scripts/webkitpy/benchmark_runner/generic_factory.py: (GenericFactory.create): (GenericFactory.add): (GenericFactory.iterateGetItem): Deleted. * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: (http_server_driver_loader): * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: (HTTPServerDriver): * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: (HTTPServerDriverFactory): * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Removed. * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: (SimpleHTTPServerDriver): * Scripts/webkitpy/benchmark_runner/utils.py: (is_subclass): (load_subclasses): (ModuleNotFoundError): Deleted. (loadModule): Deleted. (loadJSONFromFile): Deleted. 2015-06-22 Simon Fraser <simon.fraser@apple.com> Make it possible to enable incremental rendering suppression in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=146223 Reviewed by Tim Horton. Add a menu item to enable incremental rendering suppression to MiniBrowser. For WK1, this just toggles a pref, and takes effect immediately. For WK2, this is a WKConfiguration property, so only affects new web views. Also remove a toolbar item connection to toggleUseMinimumViewSize: that caused logging on launch. * MiniBrowser/mac/AppDelegate.m: (defaultConfiguration): * MiniBrowser/mac/BrowserWindow.xib: * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController toggleIncrementalRenderingSuppressed:]): (-[SettingsController incrementalRenderingSuppressed]): * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController didChangeSettings]): 2015-06-19 Filip Pizlo <fpizlo@apple.com> Run CDjs as part of JSC stress testing https://bugs.webkit.org/show_bug.cgi?id=146174 Reviewed by Geoffrey Garen. * Scripts/run-javascriptcore-tests: (runJSCStressTests): Make this aware of the cdjs-tests.yaml. * Scripts/run-jsc-stress-tests: - Teach this about tests that indicate error by returning an error code while also having lots of output even when they succeed. - Add the ability to have "tests" be a list of tests rather than just one test. This could also be a list of directories that have tests. - Fix a bug with bundle copying: whether the $collection should have the basename appended depends on whether we copy into bundleDir.dirname, not on whether absoluteCollection is a directory. 2015-06-21 Alexey Proskuryakov <ap@apple.com> REGRESSION (r172975): navigator.language unable to tell region for Traditional Chinese users https://bugs.webkit.org/show_bug.cgi?id=146121 rdar://problem/21395180 Reviewed by Darin Adler. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Added. (-[NavigatorLanguageDelegate webView:didFinishLoadForFrame:]): (TestWebKitAPI::overrideAppleLanguages): (TestWebKitAPI::languageForSystemLanguage): (TestWebKitAPI::TEST): 2015-06-21 Michael Catanzaro <mcatanzaro@igalia.com> [CMake] Ignore warnings from system headers when compiling Tools https://bugs.webkit.org/show_bug.cgi?id=146185 Reviewed by Martin Robinson. Use the SYSTEM argument to the include_directories() command to silence compiler warnings from system headers that we don't control. * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: * ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here... * ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs. * ImageDiff/PlatformGTK.cmake: * MiniBrowser/efl/CMakeLists.txt: * MiniBrowser/gtk/CMakeLists.txt: * TestWebKitAPI/PlatformEfl.cmake: * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: * WebKitTestRunner/CMakeLists.txt: * WebKitTestRunner/PlatformEfl.cmake: * WebKitTestRunner/PlatformGTK.cmake: 2015-06-20 Michael Catanzaro <mcatanzaro@igalia.com> [GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=146186 Reviewed by Martin Robinson. Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.) * MiniBrowser/gtk/CMakeLists.txt: 2015-06-19 Ryosuke Niwa <rniwa@webkit.org> Build fix after r146125. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: (OSXSafariDriver): (OSXSafariDriver.prepareEnv): 2015-06-19 Brady Eidson <beidson@apple.com> Rename WKSecurityOrigin.h/cpp to WKSecurityOriginRef.h/cpp. https://bugs.webkit.org/show_bug.cgi?id=146152 Reviewed by Dan Bernstein. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: * WebKitTestRunner/WebNotificationProvider.cpp: 2015-06-19 Mark Lam <mark.lam@apple.com> CheckedArithmetic's operator bool() and operator==() is broken. https://bugs.webkit.org/show_bug.cgi?id=146129 Reviewed by Geoffrey Garen and Oliver Hunt. Added API tests for operator ==, !=, <, <=, >, and >=, and tested for both normal and overflow scenarios in usage of the Checked arithmetic class. * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: (TestWebKitAPI::OverflowCrashLogger::overflowed): (TestWebKitAPI::OverflowCrashLogger::clearOverflow): (TestWebKitAPI::OverflowCrashLogger::crash): (TestWebKitAPI::OverflowCrashLogger::reset): (TestWebKitAPI::OverflowCrashLogger::hasOverflowed): (TestWebKitAPI::OverflowCrashLogger::overflowCount): (TestWebKitAPI::OverflowCrashLogger::didCrash): - crash logger for verifying that a crash occurs when expected. (TestWebKitAPI::resetOverflow): - convenience function for resetting a test value to an initial overflowed state before a crash. We will use this value in the overflow testing. (TestWebKitAPI::CheckedArithmeticTester::run): - Added new tests for all the comparison operators. 2015-06-19 Per Arne Vollan <peavo@outlook.com> Fix the Windows build after r185721 https://bugs.webkit.org/show_bug.cgi?id=146146 Reviewed by Csaba Osztrogonác. Speculative buildfix. * DumpRenderTree/win/UIDelegate.h: (UIDelegate::unused4): Added. (UIDelegate::webViewShouldInterruptJavaScript): Deleted. 2015-06-19 Diego Pino Garcia <dpino@igalia.com> Unreviewed. Add myself as a committer. * Scripts/webkitpy/common/config/contributors.json: 2015-06-19 Csaba Osztrogonác <ossy@webkit.org> Remove unnecessary svn:executable flags https://bugs.webkit.org/show_bug.cgi?id=146107 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Removed property svn:executable. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Removed property svn:executable. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Removed property svn:executable. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Removed property svn:executable. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Removed property svn:executable. * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Removed property svn:executable. * CygwinDownloader/cygwin-downloader.zip: Removed property svn:executable. * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed property svn:executable. * DumpRenderTree/win/TextInputController.cpp: Removed property svn:executable. * DumpRenderTree/win/TextInputController.h: Removed property svn:executable. * DumpRenderTree/win/TextInputControllerWin.cpp: Removed property svn:executable. * Scripts/webkitpy/port/base_unittest.py: Removed property svn:executable. * Scripts/webkitpy/port/driver.py: Removed property svn:executable. * Scripts/webkitpy/w3c/test_parser.py: Removed property svn:executable. 2015-06-19 Csaba Osztrogonác <ossy@webkit.org> Disable tests on the WinCairo buildbot https://bugs.webkit.org/show_bug.cgi?id=146106 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: 2015-06-19 Hunseop Jeong <hs85.jeong@samsung.com> [EFL] Fix the minibrowser after r185725 https://bugs.webkit.org/show_bug.cgi?id=146135 Reviewed by Gyuyoung Kim. Removed the HAVE_ECORE_X guard in MiniBrowser because it is an unnecessary guard for the elm_config_accel_preference_set() to set the config of acceleration preference. * MiniBrowser/efl/main.c: (elm_main): Deleted the HAVE_ECORE_X guard. 2015-06-18 Dewei Zhu <dewei_zhu@apple.com> Extend capability of run-benchmark script to support mobile device https://bugs.webkit.org/show_bug.cgi?id=146125 Reviewed by Ryosuke Niwa. Extend capability of run-benchmark to support mobile device, and move majority of run-benchmark script code to benchmark_runner directory, and make run-benchmark a wrapping script. Also correct a typo. * Scripts/run-benchmark: (main): Deleted. * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.__init__): (BenchmarkRunner.execute): * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: (BrowserDriver.prepareEnv): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: (OSXBrowserDriver.prepareEnv): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: (OSXSafariDriver.prepareEnv): * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: (HTTPServerDriver.getReturnCode): (HTTPServerDriver): (HTTPServerDriver.setDeviceID): * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Copied from Tools/Scripts/run-benchmark. (parse_args): (start): (main): * Scripts/webkitpy/benchmark_runner/utils.py: (getPathFromProjectRoot): 2015-06-18 Jon Lee <jonlee@apple.com> Unreviewed. Add Matt Daiter as a contributor. * Scripts/webkitpy/common/config/contributors.json: 2015-06-18 Mark Lam <mark.lam@apple.com> Refactor CheckedArithmeticOperations.cpp to use templates instead of macros. https://bugs.webkit.org/show_bug.cgi?id=146103 Not reviewed. Follow up to fix some typos not caught before original patch was landed. * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: (TestWebKitAPI::CheckedArithmeticTester::run): (TestWebKitAPI::AllowMixedSignednessTest::run): (TestWebKitAPI::IgnoreMixedSignednessTest::run): 2015-06-18 Daniel Bates <dabates@apple.com> Make webkitdirs::runGitUpdate() work when invoked in more than one Git checkout https://bugs.webkit.org/show_bug.cgi?id=146082 Reviewed by Darin Adler. The function webkitdirs::runGitUpdate may not update the Git checkout in the current working directory after being invoked in a different Git checkout. In particular, calling runGitUpdate() inside a Git SVN checkout and subsequently calling it inside a pure Git checkout g will fail to update g. Currently webkitdirs::runGitUpdate() calls VCSUtils::isGitSVN() to determine whether the current working directory is a Git SVN checkout. And isGitSVN() caches its result to speed up subsequent queries. This prevents runGitUpdate() from being used to update an arbitrary Git checkout (since isGitSVN() may return a cached result for a directory different than the current working directory). Instead runGitUpdate() should check whether the current working directory is a Git SVN checkout on each invocation. * Scripts/VCSUtils.pm: Export function isGitSVNDirectory so that it can be used from webkitdirs::runGitUpdate(). (isGitSVNDirectory): Extracted logic to determine whether a directory is a Git SVN directory from isGitSVN(). (isGitSVN): Implemented in terms of isGitSVNDirectory(). * Scripts/webkitdirs.pm: (runGitUpdate): Modified to use isGitSVNDirectory(). 2015-06-18 Mark Lam <mark.lam@apple.com> Refactor CheckedArithmeticOperations.cpp to use templates instead of macros. https://bugs.webkit.org/show_bug.cgi?id=146103 Reviewed by Anders Carlsson. Presently, the tests in CheckedArithmeticOperations.cpp are all implemented as part of a large macro. This makes them harder to: 1. write: no editor help with indentations, have to add trailing '\'s, inconvenient to add line breaks and comments. 2. read: no chroma coding / syntax highlighting. 3. debug: compile time errors are reported as being on the single line where the macro is used. Refactoring the tests to use C++ templates solves all these issues. * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: (TestWebKitAPI::CheckedArithmeticTester::run): (TestWebKitAPI::AllowMixedSignednessTest::run): (TestWebKitAPI::IgnoreMixedSignednessTest::run): (TestWebKitAPI::CoerceLiteralToUnsigned::coerce): (TestWebKitAPI::CoerceLiteralNop::coerce): 2015-06-18 Christophe Dumez <ch.dumez@sisa.samsung.com> [EFL][WK2] Use Web Browser cache model in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=112273 Reviewed by Laszlo Gombos. Set cache model to EWK_CACHE_MODEL_PRIMARY_WEBBROWSER in EFL's MiniBrowser instead of leaving the default value (EWK_CACHE_MODEL_DOCUMENT_VIEWER). This way we have a decent cache capacity and the page cache actually works. * MiniBrowser/efl/main.c: (elm_main): 2015-06-18 Gyuyoung Kim <gyuyoung.kim@webkit.org> Remove redundant Chromium bug keyword https://bugs.webkit.org/show_bug.cgi?id=146097 Reviewed by Csaba Osztrogonác. * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations. (TestExpectationLine._format_line): Deleted. 2015-06-17 Daniel Bates <dabates@apple.com> Client may receive began editing callback for already focused text field https://bugs.webkit.org/show_bug.cgi?id=146074 <rdar://problem/21293562> Reviewed by Darin Adler. Add a unit test to ensure that a client receives exactly one began editing callback when a text field is newly focused. In particular, dispatching a DOM focus event at an already focused text field does not dispatch a began editing callback to the client. * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: (TestWebKitAPI::TEST_F): 2015-06-17 Hyungwook Lee <hyungwook.lee@navercorp.com> [Win]Implement layoutTestController.dispatchPendingLoadRequests. https://bugs.webkit.org/show_bug.cgi?id=26481 Reviewed by Darin Adler. Implement WebView::dispatchPendingLoadRequests() private API for test runner. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::dispatchPendingLoadRequests): (TestRunner::overridePreference): 2015-06-17 Alex Christensen <achristensen@webkit.org> [Content Extensions] Fail to parse invalid arrays https://bugs.webkit.org/show_bug.cgi?id=146079 rdar://problem/21422649 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): Correct and add parsing tests with invalid arrays. 2015-06-17 Matt Rajca <mrajca@apple.com> Unreviewed. Added myself as a committer. * Scripts/webkitpy/common/config/contributors.json: 2015-06-17 Daniel Bates <dabates@apple.com> Export VCSUtils::gitTreeDirectory() <rdar://problem/21248901> Rubber-stamped by Alexey Proskuryakov. * Scripts/VCSUtils.pm: 2015-06-17 Tim Horton <timothy_horton@apple.com> Safari tabs still have shrunken content after coming out of fullscreen https://bugs.webkit.org/show_bug.cgi?id=146037 <rdar://problem/21105960> Reviewed by Simon Fraser and Darin Adler. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Added. (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]): (TEST): Add a test that ensures that disabling scale-to-fit mode correctly updates the page's layout. 2015-06-17 Dan Bernstein <mitz@apple.com> [Cocoa] Expose UIDelegate::UIClient::close via WKUIDelegate https://bugs.webkit.org/show_bug.cgi?id=145957 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: (-[OpenAndCloseWindowUIDelegate webViewDidClose:]): Renamed from -_webViewClose:. 2015-06-15 Chris Fleizach <cfleizach@apple.com> AX: iOS accessibility tests are not running because we need WKTR support https://bugs.webkit.org/show_bug.cgi?id=145991 Reviewed by Daniel Bates. Add support for WKTR iOS accessibility. Utilize the notification handling mechanisms that Mac already uses. Rename iphone* DRT methods to either use existing methods that are similar, or rename to more generic names. * DumpRenderTree/AccessibilityUIElement.cpp: (stringForSelectionCallback): (getIdentifierCallback): (getTraitsCallback): (getElementTextPositionCallback): (getElementTextLengthCallback): (AccessibilityUIElement::getJSClass): (getIPhoneLabelCallback): Deleted. (getIPhoneHintCallback): Deleted. (getIPhoneValueCallback): Deleted. (getIPhoneIdentifierCallback): Deleted. (getIPhoneTraitsCallback): Deleted. (getIPhoneIsElementCallback): Deleted. (getIPhoneElementTextPositionCallback): Deleted. (getIPhoneElementTextLengthCallback): Deleted. * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::identifier): (AccessibilityUIElement::traits): (AccessibilityUIElement::elementTextPosition): (AccessibilityUIElement::elementTextLength): (AccessibilityUIElement::description): (AccessibilityUIElement::orientation): (AccessibilityUIElement::stringValue): (AccessibilityUIElement::language): (AccessibilityUIElement::helpText): (AccessibilityUIElement::intValue): (AccessibilityUIElement::isSelected): (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::documentURI): (AccessibilityUIElement::addNotificationListener): (AccessibilityUIElement::removeNotificationListener): (AccessibilityUIElement::isFocusable): (AccessibilityUIElement::isIgnored): (AccessibilityUIElement::hasPopup): (AccessibilityUIElement::iphoneLabel): Deleted. (AccessibilityUIElement::iphoneHint): Deleted. (AccessibilityUIElement::iphoneValue): Deleted. (AccessibilityUIElement::iphoneIdentifier): Deleted. (AccessibilityUIElement::iphoneTraits): Deleted. (AccessibilityUIElement::iphoneIsElement): Deleted. (AccessibilityUIElement::iphoneElementTextPosition): Deleted. (AccessibilityUIElement::iphoneElementTextLength): Deleted. (_accessibilityNotificationCallback): Deleted. * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::isValid): (WTR::AccessibilityUIElement::identifier): (WTR::AccessibilityUIElement::traits): (WTR::AccessibilityUIElement::elementTextPosition): (WTR::AccessibilityUIElement::elementTextLength): (WTR::AccessibilityUIElement::stringForSelection): (WTR::AccessibilityUIElement::elementsForRange): (WTR::AccessibilityUIElement::increaseTextSelection): (WTR::AccessibilityUIElement::decreaseTextSelection): (WTR::AccessibilityUIElement::linkedElement): (WTR::AccessibilityUIElement::headerElementAtIndex): (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus): (WTR::AccessibilityUIElement::characterAtOffset): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: (WTR::findAccessibleObjectById): (WTR::AccessibilityController::accessibleElementById): * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (+[NSString stringWithJSStringRef:]): (-[NSString createJSStringRef]): (WTR::convertNSArrayToVector): (WTR::concatenateAttributeAndValue): (WTR::AccessibilityUIElement::AccessibilityUIElement): (WTR::AccessibilityUIElement::isEqual): (WTR::AccessibilityUIElement::headerElementAtIndex): (WTR::AccessibilityUIElement::linkedElement): (WTR::AccessibilityUIElement::getLinkedUIElements): (WTR::AccessibilityUIElement::elementAtPoint): (WTR::convertElementsToObjectArray): (WTR::AccessibilityUIElement::elementsForRange): (WTR::AccessibilityUIElement::indexOfChild): (WTR::AccessibilityUIElement::stringAttributeValue): (WTR::AccessibilityUIElement::description): (WTR::AccessibilityUIElement::orientation): (WTR::AccessibilityUIElement::stringValue): (WTR::AccessibilityUIElement::language): (WTR::AccessibilityUIElement::helpText): (WTR::AccessibilityUIElement::x): (WTR::AccessibilityUIElement::clickPointX): (WTR::AccessibilityUIElement::clickPointY): (WTR::AccessibilityUIElement::intValue): (WTR::AccessibilityUIElement::minValue): (WTR::AccessibilityUIElement::maxValue): (WTR::AccessibilityUIElement::valueDescription): (WTR::AccessibilityUIElement::isSelected): (WTR::AccessibilityUIElement::isSelectedOptionActive): (WTR::AccessibilityUIElement::stringForRange): (WTR::AccessibilityUIElement::attributedStringForRange): (WTR::AccessibilityUIElement::attributesOfHeader): (WTR::AccessibilityUIElement::traits): (WTR::AccessibilityUIElement::identifier): (WTR::AccessibilityUIElement::rowCount): (WTR::AccessibilityUIElement::rowIndexRange): (WTR::AccessibilityUIElement::columnIndexRange): (WTR::AccessibilityUIElement::cellForColumnAndRow): (WTR::AccessibilityUIElement::horizontalScrollbar): (WTR::AccessibilityUIElement::documentURI): (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus): (WTR::AccessibilityUIElement::increaseTextSelection): (WTR::AccessibilityUIElement::decreaseTextSelection): (WTR::AccessibilityUIElement::stringForSelection): (WTR::AccessibilityUIElement::elementTextPosition): (WTR::AccessibilityUIElement::elementTextLength): (WTR::AccessibilityUIElement::url): (WTR::AccessibilityUIElement::addNotificationListener): (WTR::AccessibilityUIElement::removeNotificationListener): (WTR::AccessibilityUIElement::isFocusable): (WTR::AccessibilityUIElement::isIgnored): (WTR::AccessibilityUIElement::hasPopup): (WTR::AccessibilityUIElement::mathPrescriptsDescription): (WTR::_CGPathEnumerationIteration): (WTR::AccessibilityUIElement::pathDescription): (WTR::AccessibilityUIElement::supportedActions): 2015-06-16 Mark Lam <mark.lam@apple.com> Use NakedPtr<Exception>& to return exception results. https://bugs.webkit.org/show_bug.cgi?id=145870 Reviewed by Anders Carlsson and Filip Pizlo. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: Added. (TestWebKitAPI::TEST): (TestWebKitAPI::nakedPtrFoo): 2015-06-16 Tobias Reiss <tobi+webkit@basecode.de> Unreviewed. Adding myself as a committer. * Scripts/webkitpy/common/config/contributors.json: 2015-06-15 Alexey Proskuryakov <ap@apple.com> Add test expectations for El Capitan https://bugs.webkit.org/show_bug.cgi?id=146005 Rubber-stamped by Dan Bernstein. Add appropriate tools code. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added dashboard support. * BuildSlaveSupport/build.webkit.org-config/wkbuild.py: * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: Trigger the right build queues on check-in. * Scripts/webkitpy/common/system/platforminfo.py: * Scripts/webkitpy/common/system/platforminfo_unittest.py: * Scripts/webkitpy/layout_tests/models/test_expectations.py: * Scripts/webkitpy/port/mac.py: * Scripts/webkitpy/port/mac_unittest.py: * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: * TestResultServer/static-dashboards/flakiness_dashboard.js: Added cases for El Capitan, and updated tests for new baseline search paths. 2015-06-15 Alex Christensen <achristensen@webkit.org> [Content Extensions] Make max NFA size and max rule count user defaults. https://bugs.webkit.org/show_bug.cgi?id=145663 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): 2015-06-12 Alexey Proskuryakov <ap@apple.com> -[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized https://bugs.webkit.org/show_bug.cgi?id=145900 Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: (TEST): Added tests. 2015-06-15 Carlos Garcia Campos <cgarcia@igalia.com> [SOUP] Custom URI schemes don't work for requests containing a fragment identifier https://bugs.webkit.org/show_bug.cgi?id=145969 Reviewed by Sergio Villar Senin. Add a test case to the custom URI schemes unit test. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextURIScheme): 2015-06-15 Csaba Osztrogonác <ossy@webkit.org> [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp https://bugs.webkit.org/show_bug.cgi?id=145922 Reviewed by Carlos Garcia Campos. * gtk/jhbuild.modules: * gtk/patches/glib-warning-fix.patch: Added. 2015-06-12 Alexey Proskuryakov <ap@apple.com> Update springLoadingHighlight type https://bugs.webkit.org/show_bug.cgi?id=145939 rdar://problem/20880213 Reviewed by Darin Adler. * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h: * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: 2015-06-12 Dewei Zhu <dewei_zhu@apple.com> Move cursor to (10, 0) instead of (0, 0) and polish the mouse move code https://bugs.webkit.org/show_bug.cgi?id=145945 Reviewed by Stephanie Lewis. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: (OSXBrowserDriver.prepareEnv): (OSXBrowserDriver.moveCursor): Deleted. (OSXBrowserDriver): Deleted. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: (OSXSafariDriver.prepareEnv): 2015-06-12 Brent Fulgham <bfulgham@apple.com> Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https https://bugs.webkit.org/show_bug.cgi?id=145938 Reviewed by Alexey Proskuryakov. * Scripts/update-webkit-dependency: Switch from LWP::Simple to LWP::UserAgent to get access to more robust HTTPS support. 2015-06-12 Csaba Osztrogonác <ossy@webkit.org> [GTK] Fix return type warning in WebViewTest.cpp https://bugs.webkit.org/show_bug.cgi?id=145914 Reviewed by Darin Adler. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::isEditable): 2015-06-12 Zan Dobersek <zdobersek@igalia.com> [GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib https://bugs.webkit.org/show_bug.cgi?id=145799 Reviewed by Carlos Garcia Campos. Update header inclusions for headers that have been moved to Source/WTF/wtf/glib/. Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/ to TestWebKitAPI/Tests/WTF/glib/ and update the build rules. * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp. (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): (TestWebKitAPI::GMainLoopSourceTest::runLoop): (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): (TestWebKitAPI::GMainLoopSourceTest::finish): (TestWebKitAPI::GMainLoopSourceTest::source): (TestWebKitAPI::basicRescheduling): (TestWebKitAPI::TEST): (TestWebKitAPI::reentrantRescheduling): (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): (TestWebKitAPI::basicDestroyCallbacks): (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp. (log): (takeLogStr): (TestWebKitAPI::TEST): (TestWebKitAPI::returnOutChar): * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted. (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted. (TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted. (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted. (TestWebKitAPI::GMainLoopSourceTest::finish): Deleted. (TestWebKitAPI::GMainLoopSourceTest::source): Deleted. (TestWebKitAPI::basicRescheduling): Deleted. (TestWebKitAPI::TEST): Deleted. (TestWebKitAPI::reentrantRescheduling): Deleted. (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted. (TestWebKitAPI::basicDestroyCallbacks): Deleted. (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted. (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted. * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp: (log): Deleted. (takeLogStr): Deleted. (TestWebKitAPI::TEST): Deleted. (TestWebKitAPI::returnOutChar): Deleted. * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp: * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h: * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp: * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h: * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp: * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp: * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: * WebKitTestRunner/PlatformGTK.cmake: * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: * WebKitTestRunner/gtk/TestControllerGtk.cpp: 2015-06-12 Csaba Osztrogonác <ossy@webkit.org> [EFL] Fix deprecated declarations warnings related to WK2 versioned structs https://bugs.webkit.org/show_bug.cgi?id=145913 Reviewed by Gyuyoung Kim. * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: (TestWebKitAPI::setupGeolocationProvider): * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: (TestWebKitAPI::setPageLoaderClient): * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient): * WebKitTestRunner/GeolocationProviderMock.cpp: (WTR::GeolocationProviderMock::GeolocationProviderMock): * WebKitTestRunner/WebNotificationProvider.cpp: (WTR::WebNotificationProvider::provider): 2015-06-12 Csaba Osztrogonác <ossy@webkit.org> Fix the libusrsctp build with clang https://bugs.webkit.org/show_bug.cgi?id=145128 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: * gtk/jhbuild.modules: 2015-06-11 Mark Lam <mark.lam@apple.com> WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects. https://bugs.webkit.org/show_bug.cgi?id=145872 Reviewed by Michael Saboff. * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm: (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]): - Exercises the JSC ObjC API to call a function which throws an exception. That exception will be returned as a JSValue instead of an Exception object. We will use this JSValue to test WebCore::reportException() to confirm that it is able to handle an exception value which is not an Exception object. 2015-06-11 Dewei Zhu <dewei_zhu@apple.com> Move cursor to corner and fix safari window size before running benchmark https://bugs.webkit.org/show_bug.cgi?id=145858 Reviewed by Ryosuke Niwa * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: (OSXBrowserDriver.prepareEnv): (OSXBrowserDriver): (OSXBrowserDriver.moveCursor): (OSXBrowserDriver.getScreenSize): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: (OSXChromeDriver.launchUrl): (OSXChromeCanaryDriver.launchUrl): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: (OSXFirefoxDriver.launchUrl): (OSXFirefoxNightlyDriver.launchUrl): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: (OSXSafariDriver.prepareEnv): (OSXSafariDriver): (OSXSafariDriver.maximizeWindow): 2015-06-11 Daniel Bates <dabates@apple.com> [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build https://bugs.webkit.org/show_bug.cgi?id=145319 Reviewed by David Kilzer. Add SPI wrapper header for CoreSimulator and update the source files to reference it instead of directly referencing the CoreSimulator header. * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj: * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added. * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: * LayoutTestRelay/LayoutTestRelay/main.m: 2015-06-10 KwangHyuk Kim <hyuki.kim@samsung.com> [EFL] dimmed area for popup does not cover the fullscreen mode. https://bugs.webkit.org/show_bug.cgi?id=145133 Reviewed by Gyuyoung Kim. By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win. as a result, popup can cover the fullscreen area when it enters a fullscreen mode. * MiniBrowser/efl/main.c: (on_fullscreen_accept): (on_fullscreen_deny): (on_fullscreen_enter): 2015-06-10 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r185442. https://bugs.webkit.org/show_bug.cgi?id=145871 seems to have broken WTF.StringOperators test (Requested by alexchristensen on #webkit). Reverted changeset: "[Content Extensions] Limit number of rules." https://bugs.webkit.org/show_bug.cgi?id=145663 http://trac.webkit.org/changeset/185442 2015-06-10 Alex Christensen <achristensen@webkit.org> [Content Extensions] Make max NFA size and max rule count user defaults. https://bugs.webkit.org/show_bug.cgi?id=145663 rdar://problem/21242407 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): 2015-06-10 Hyungwook Lee <hyungwook.lee@navercorp.com> [EFL] Execute Javascript method in mini browser address bar. https://bugs.webkit.org/show_bug.cgi?id=145725 Reviewed by Gyuyoung Kim. Support 'javascript:' scheme in WebKit EFL Mini Browser. * MiniBrowser/efl/main.c: (url_from_user_input): (url_load_from_user_input): (on_url_bar_activated): (elm_main): 2015-06-09 Hyungwook Lee <hyungwook.lee@navercorp.com> Implement dumpProgressFinishedCallback() for Win layoutTestController. https://bugs.webkit.org/show_bug.cgi?id=66773 Reviewed by Darin Adler. * DumpRenderTree/win/FrameLoadDelegate.cpp: * DumpRenderTree/win/FrameLoadDelegate.h: 2015-06-09 Ryosuke Niwa <rniwa@webkit.org> run-benchmark should either checkout JetStream 1.0.1 or support running the latest version https://bugs.webkit.org/show_bug.cgi?id=145764 Reviewed by Darin Adler. Added the support for checkout a subversion directory in run-benchmark and used in the plans for JetStream and SunSpider. * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: (GenericBenchmarkBuilder): (GenericBenchmarkBuilder.prepare): Instead of taking each argument from benchmark plan, just accept the whole JSON as the input. (GenericBenchmarkBuilder._checkoutWithSubverion): Added. (GenericBenchmarkBuilder._applyPatch): Check the existence of benchmark_patch in prepare() instead. * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.execute): Removed the check for having either 'local_copy' or 'remote_archive' in a benchmark plan now that it's checkedi in GenericBenchmarkBuilder.prepare. * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: 2015-06-09 Gyuyoung Kim <gyuyoung.kim@webkit.org> Remove ewstool scripts used by chromium port https://bugs.webkit.org/show_bug.cgi?id=145789 Reviewed by Csaba Osztrogonác. * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Removed. * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Removed. * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Removed. * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Removed. * EWSTools/GoogleComputeEngine/findzone.sh: Removed. 2015-06-09 Michał Pakuła vel Rutka <m.pakula@samsung.com> Unreviewed, updated my list of email addresses. * Scripts/webkitpy/common/config/contributors.json: 2015-06-09 Csaba Osztrogonác <ossy@webkit.org> [cmake] Fix the style issues in cmake project files https://bugs.webkit.org/show_bug.cgi?id=145755 Reviewed by Darin Adler. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/PlatformEfl.cmake: 2015-06-08 Ryosuke Niwa <rniwa@webkit.org> Fix a typo in r185345. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: (OSXSafariDriver.closeBrowsers): 2015-06-08 Ryosuke Niwa <rniwa@webkit.org> Yet another unreviewed build fix :( * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: (OSXSafariDriver): (OSXSafariDriver.launchUrl): (OSXSafariDriver.closeBrowsers): 2015-06-08 Ryosuke Niwa <rniwa@webkit.org> Unreviewed build fix. Initialize result in the case things blow up below. * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.execute): 2015-06-08 Ryosuke Niwa <rniwa@webkit.org> Partially revert and fix after r185243. * Scripts/benchmark_runner/benchmark_runner.py: * Scripts/run-benchmark: 2015-06-08 Daniel Bates <dabates@apple.com> Many LayoutTests/http tests time out in DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=145770 <rdar://problem/19593910> Reviewed by Alexey Proskuryakov. * DumpRenderTree/ios/Info.plist: Add ATS key. * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests that make use of testRunner.pathToLocalResource(). 2015-06-08 Csaba Osztrogonác <ossy@webkit.org> [GTK] Fix parentheses warning in TestWebKitWebView.cpp https://bugs.webkit.org/show_bug.cgi?id=145759 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewSave): 2015-06-07 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add editor mode to MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=145595 Reviewed by Sergio Villar Senin. It loads an empty editable web view with an edit toolbar. It makes easier to test the editor, editing commands and input methods. * MiniBrowser/gtk/BrowserWindow.c: (editingCommandCallback): (browserWindowSetupEditorToolbar): (browserWindowConstructed): * MiniBrowser/gtk/main.c: (createBrowserWindow): 2015-06-05 Zalan Bujtas <zalan@apple.com> From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value. Reviewed by Dan Bernstein. * TestWebKitAPI/Tests/WTF/RefCounter.cpp: (TestWebKitAPI::TEST): 2015-06-05 Gyuyoung Kim <gyuyoung.kim@webkit.org> [EFL] API test has been broken since r184357 https://bugs.webkit.org/show_bug.cgi?id=145635 Reviewed by Darin Adler. r184357 suppress cmake build warning using TARGET_FILE property. However many EFL API test cases have been broken after applying it. * TestWebKitAPI/CMakeLists.txt: 2015-06-05 Anders Carlsson <andersca@apple.com> Make the network cache directory part of WKContextConfigurationRef https://bugs.webkit.org/show_bug.cgi?id=145711 Reviewed by Antti Koivisto. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): 2015-06-05 Anders Carlsson <andersca@apple.com> Make the application cache directory part of WKContextConfigurationRef https://bugs.webkit.org/show_bug.cgi?id=145704 Reviewed by Geoffrey Garen. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): 2015-06-04 Carlos Alberto Lopez Perez <clopez@igalia.com> check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code. https://bugs.webkit.org/show_bug.cgi?id=145680 Reviewed by Brent Fulgham. * Scripts/webkitpy/style/checkers/cpp.py: (check_for_null): * Scripts/webkitpy/style/checkers/cpp_unittest.py: (WebKitStyleTest.test_null_false_zero): 2015-06-05 Stephanie Lewis <slewis@apple.com> Make the web server more robust to timing issues.. Reviewed by Ryosuke Niwa. Cleaned up exception handling. Test server is actually serving pages before returning. Clean up some style issues. * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: (SimpleHTTPServerDriver.__init__): (SimpleHTTPServerDriver.serve): check output, wait for pages to serve (SimpleHTTPServerDriver.baseUrl): (SimpleHTTPServerDriver.fetchResult): (SimpleHTTPServerDriver.killServer): (SimpleHTTPServerDriver.getReturnCode): 2015-06-05 Stephanie Lewis <slewis@apple.com> Add errors to run-benchmark exception handling. Reviewed by Ryosuke Niwa. * Scripts/run-benchmark: (main): * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: (GenericBenchmarkBuilder.prepare): (GenericBenchmarkBuilder._runCreateScript): (GenericBenchmarkBuilder._applyPatch): (GenericBenchmarkBuilder.clean): * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.__init__): (BenchmarkRunner.execute): (BenchmarkRunner): (BenchmarkRunner.cleanup): * Scripts/webkitpy/benchmark_runner/generic_factory.py: (GenericFactory.iterateGetItem): (GenericFactory.create): * Scripts/webkitpy/benchmark_runner/utils.py: (loadModule): (loadJSONFromFile): (forceRemove): 2015-06-05 Stephanie Lewis <slewis@apple.com> Streamline run-benchmark browser Reviewed by Ryosuke Niwa. Add Caffeinate so computer won't sleep while running. Remove calls to collect output since we were just dumping to stdout anyway. Add xpc dyld_path. Default to system safari. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: (OSXBrowserDriver.launchProcess): (OSXBrowserDriver.terminateProcesses): (OSXBrowserDriver): (OSXBrowserDriver.launchCaffeinateForProcess): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: (OSXSafariDriver.launchUrl): (OSXSafariDriver.closeBrowsers): 2015-06-04 Benjamin Poulain <bpoulain@apple.com> Combine tiny DFAs into slightly larger ones https://bugs.webkit.org/show_bug.cgi?id=145572 Reviewed by Alex Christensen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added. (TestWebKitAPI::DFACombinerTest::SetUp): (TestWebKitAPI::combine): (TestWebKitAPI::TEST_F): * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h. (TestWebKitAPI::countLiveNodes): (TestWebKitAPI::createNFAs): (TestWebKitAPI::buildDFAFromPatterns): * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp: (TestWebKitAPI::countLiveNodes): Deleted. (TestWebKitAPI::createNFAs): Deleted. (TestWebKitAPI::buildDFAFromPatterns): Deleted. 2015-06-04 Alexey Proskuryakov <ap@apple.com> WebKitTestRunner leaks strings in generateWhitelist() https://bugs.webkit.org/show_bug.cgi?id=145665 Reviewed by Myles C. Maxfield. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::generateWhitelist): 2015-06-03 Yusuke Suzuki <utatane.tea@gmail.com> Fix options in build-jsc for CMake builds https://bugs.webkit.org/show_bug.cgi?id=145636 Reviewed by Gyuyoung Kim. CMake only accepts -DXXX=YYY style options. And ensured that ENABLE_JIT=OFF when specifying `--cloop`. * Scripts/build-jsc: 2015-06-03 Matthew Daiter <mdaiter@apple.com> Added a patch so that the colors displayed on the page could be toggled in case people need accessibility colors displayed in their browser. https://bugs.webkit.org/show_bug.cgi?id=145570 <rdar://problem/20994468> Added in CSS colors and toggle buttons for checkmarks in the page, so that the page could be rendered in a specific way for accessibility needs if needed. Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: (updateHiddenPlatforms): (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary (toggleAccessibilityColors): Toggle colors on and off (documentReady): Needed to make changes to the initialization * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: (a:hover): (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton (div.cellButton.hide, div.accessibilityButton.hide): (div.cellButton.unhide, div.accessibilityButton.unhide): (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): (.popover-tracking:hover): (.accessibilityButton): (div.cellButton): Deleted. (div.cellButton.hide): Deleted. (div.cellButton.unhide): Deleted. (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: (.status-line.neutral .bubble): (.status-line.unauthorized .bubble): (.status-line.danger .bubble.pictogram): (.status-line.bad .bubble.pictogram): (.status-line.no-bubble .message): (.status-line.bad .bubble): (.status-line.good .bubble): (.status-line.good .message): (.status-line.bad .message): (body.accessibility-colors .status-line.good .bubble): (body.accessibility-colors .status-line.bad .bubble): (body.accessibility-colors .status-line.good .message): (body.accessibility-colors .status-line.bad .message): (.status-line.danger .message): (.status-line.unauthorized .message): 2015-06-03 Ryosuke Niwa <rniwa@webkit.org> Unreviewed build fix for Dromaeo. * Scripts/webkitpy/benchmark_runner/benchmark_results.py: (BenchmarkResults._aggregate_results_for_test): 2015-06-03 Anders Carlsson <andersca@apple.com> Fix build. * DumpRenderTree/mac/TestRunnerMac.mm: 2015-06-03 Daniel Bates <dabates@apple.com> WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac https://bugs.webkit.org/show_bug.cgi?id=145616 Skip the test on Mac for now to avoid having the bots turn red due to the flakiness of the test. Further investigation is needed. * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: 2015-06-03 Brady Eidson <beidson@apple.com> REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs https://bugs.webkit.org/show_bug.cgi?id=145580 Reviewed by Mark Lam. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame" 2015-06-03 Alexey Proskuryakov <ap@apple.com> Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147 * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: (TestWebKitAPI::TEST): Update the syntax. 2015-06-02 Mark Lam <mark.lam@apple.com> build-jsc's --cloop option is broken. https://bugs.webkit.org/show_bug.cgi?id=145516 Reviewed by Darin Adler. * Scripts/build-jsc: - Make sure to disable the JIT when --cloop is specified. Did analogous fix for --ftljit. 2015-06-02 Daniel Bates <dabates@apple.com> Update ATS keys used in MiniBrowser and WebKitTestRunnerApp Rubber-stamped by Alexey Proskuryakov. * MiniBrowser/mac/Info.plist: * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: 2015-06-01 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r185066. https://bugs.webkit.org/show_bug.cgi?id=145543 it breaks the FTL JIT builds with a local checkout of llvm (Requested by pizlo on #webkit). Reverted changeset: "build-jsc's --cloop option is broken." https://bugs.webkit.org/show_bug.cgi?id=145516 http://trac.webkit.org/changeset/185066 2015-06-01 Daniel Bates <dabates@apple.com> Notify client that we began editing when text field is focused https://bugs.webkit.org/show_bug.cgi?id=145439 <rdar://problem/21142108> Reviewed by Anders Carlsson. Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when a text field is focused and defocused. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/PlatformEfl.cmake: * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added. (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle): (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame): (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient): (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient): (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback): (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage): (TestWebKitAPI::TEST_F): * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added. (TestWebKitAPI::textFieldDidBeginEditing): (TestWebKitAPI::textFieldDidEndEditing): (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest): (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage): * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added. 2015-06-01 Alex Christensen <achristensen@webkit.org> [Content Extensions] resource-type and load-type should be independent. https://bugs.webkit.org/show_bug.cgi?id=145528 rdar://problem/21190765 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): 2015-06-01 Daniel Bates <dabates@apple.com> Add ATS keys to WebKitTestRunnerApp https://bugs.webkit.org/show_bug.cgi?id=145519 Reviewed by Alexey Proskuryakov. Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141. * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: 2015-06-01 Brady Eidson <beidson@apple.com> Add WKTR support for "should open external URLs". https://bugs.webkit.org/show_bug.cgi?id=145505 Reviewed by Darin Adler. - Add a new option to "queueLoad" to allow javascript to queue a load that has the "should open external URLs" bit set. - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in the policy delegate, including whether or not the bit was set. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::queueLoad): * WebKitTestRunner/InjectedBundle/TestRunner.h: (WTR::TestRunner::dumpPolicyDelegateCallbacks): (WTR::TestRunner::shouldDumpPolicyCallbacks): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::queueLoad): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::decidePolicyForNavigationAction): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): * WebKitTestRunner/WorkQueueManager.cpp: (WTR::WorkQueueManager::queueLoad): * WebKitTestRunner/WorkQueueManager.h: 2015-06-01 Mark Lam <mark.lam@apple.com> build-jsc's --cloop option is broken. https://bugs.webkit.org/show_bug.cgi?id=145516 Reviewed by Darin Adler. * Scripts/build-jsc: - Make sure to disable the JIT when --cloop is specified. Did analogous fix for --ftljit. 2015-06-01 Csaba Osztrogonác <ossy@webkit.org> [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error https://bugs.webkit.org/show_bug.cgi?id=144959 Reviewed by Darin Adler. * Scripts/webkitpy/style/checkers/cmake.py: (CMakeChecker.check): Use enumerate instead of xrange. (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually. * Scripts/webkitpy/style/checkers/cmake_unittest.py: (CMakeCheckerTest.test_check): Update the expected results. 2015-06-01 Csaba Osztrogonác <ossy@webkit.org> Fix the webkitpy scm unittests after r174051 https://bugs.webkit.org/show_bug.cgi?id=145511 Reviewed by Darin Adler. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (GitTestWithMock.make_scm): 2015-06-01 Csaba Osztrogonác <ossy@webkit.org> EWS provides misleading information for not applyable patches https://bugs.webkit.org/show_bug.cgi?id=145307 Reviewed by Alexey Proskuryakov. * Scripts/svn-apply: Die if there is no applyable diff in the patch. 2015-06-01 Alexey Proskuryakov <ap@apple.com> Further tweak results of WebKit1.StringTruncator after r184965. * TestWebKitAPI/Tests/mac/StringTruncator.mm: 2015-06-01 Csaba Osztrogonác <ossy@webkit.org> [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn https://bugs.webkit.org/show_bug.cgi?id=145264 Reviewed by Carlos Garcia Campos. * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings. 2015-05-30 Ryosuke Niwa <rniwa@webkit.org> Unreviewed build fix after r185014. Some tests only have subtests and not metrics. * Scripts/webkitpy/benchmark_runner/benchmark_results.py: (BenchmarkResults._lint_subtest_results): * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: (test_aggregate_nested_results): (test_lint_results): * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: 2015-05-29 Ryosuke Niwa <rniwa@webkit.org> run-benchmark should print out the results https://bugs.webkit.org/show_bug.cgi?id=145398 Reviewed by Antti Koivisto. Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check of the output to catch early errors. * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added. (BenchmarkResults): Added. (BenchmarkResults.__init__): Added. (BenchmarkResults.format): Added. (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format. (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test. Uses the sample standard deviation to compute the significant figures for the value. (BenchmarkResults._unit_from_metric): Added. (BenchmarkResults._aggregate_results): Added. (BenchmarkResults._aggregate_results_for_test): Added. (BenchmarkResults._flatten_list): Added. (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests by the iteration number so that i-th array contains values for all subtests at i-th iteration. (BenchmarkResults._aggregate_values): Added. (BenchmarkResults._lint_results): Added. (BenchmarkResults._lint_subtest_results): Added. (BenchmarkResults._lint_aggregator_list): Added. (BenchmarkResults._lint_configuration): Added. (BenchmarkResults._lint_values): Added. (BenchmarkResults._is_numeric): Added. * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added. (BenchmarkResultsTest): (BenchmarkResultsTest.test_init): (BenchmarkResultsTest.test_format): (test_format_values_with_large_error): (test_format_values_with_small_error): (test_format_values_with_time): (test_format_values_with_no_error): (test_format_values_with_small_difference): (test_aggregate_results): (test_aggregate_results_with_gropus): (test_aggregate_nested_results): (test_lint_results): * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.execute): Added a call to show_results (BenchmarkRunner.wrap): Only dump the merged JSON when debugging. (BenchmarkRunner.show_results): Added. 2015-05-15 Ryosuke Niwa <rniwa@webkit.org> run_benchmark should have an option to specify the number of runs https://bugs.webkit.org/show_bug.cgi?id=145091 Reviewed by Antti Koivisto. Added --count option. * Scripts/run-benchmark: (main): * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.__init__): 2015-05-28 Alexey Proskuryakov <ap@apple.com> Update results of WebKit1.StringTruncator after r184965. I missed one letter. * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST): 2015-05-28 Alexey Proskuryakov <ap@apple.com> Update results of WebKit1.StringTruncator after r184965. * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST): 2015-05-28 Gyuyoung Kim <gyuyoung.kim@webkit.org> Unreviewed, updated my list of email addresses. * Scripts/webkitpy/common/config/contributors.json: 2015-05-27 Dean Jackson <dino@apple.com> img.currentSrc problem in strict mode with old picturefill https://bugs.webkit.org/show_bug.cgi?id=144095 <rdar://problem/21087013> Reviewed by Simon Fraser. Add a PICTURE_SIZES flag. * Scripts/webkitperl/FeatureList.pm: 2015-05-26 Dana Burkart <dburkart@apple.com> Fixes compatibility issues with recent dashboard cleanup. https://bugs.webkit.org/show_bug.cgi?id=144814 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: (BuildbotStaticAnalyzerQueueView): (BuildbotStaticAnalyzerQueueView.prototype.update): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: (documentReady): 2015-05-26 Alexey Proskuryakov <ap@apple.com> Botwatcher's dashboard doesn't show JSC test regressions on Apple bots https://bugs.webkit.org/show_bug.cgi?id=143091 rdar://problem/19330328 Reviewed by Darin Adler and Timothy Hatcher. We have many of these, which are hard to fit on the dashboard. Added a view that collapses to a single green bubble when everything is good, and expands when there are failures (or manually). * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: (Buildbot.prototype.set isAuthenticated): (Buildbot.prototype._normalizeQueueInfo): (Buildbot.prototype._normalizeQueuesInfo): (Buildbot.prototype.updateQueues): Moved queue info normalization here from BuildbitQueue. The latter is a model class that shouldn't have to know about presentation, and this lets us leep the knowledge about combined queues out if it. Later, we can refactor existing code, and move out all knowledge about headings and such. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js: Added the new view. It's not quite universal, and doesn't have as helpful popovers as other views, but we can extend it when/if we use it for more than JSC. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: (documentReady): Added support for combined queues. These are currently always ending up in Other column, but it's easy to customize in the future if we need to. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): Added JSC queus. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css: (.combined-queue-popover): (.combined-queue-popover .revision): Added styles for the combined view. 2015-05-26 Dan Bernstein <mitz@apple.com> Changed a file to use Unix line endings. * LayoutTestRelay/Configurations/DebugRelease.xcconfig: 2015-05-26 Dan Bernstein <mitz@apple.com> <rdar://problem/21104551> Update build settings Reviewed by Anders Carlsson. * ContentExtensionTester/Configurations/DebugRelease.xcconfig: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * MiniBrowser/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * WebEditingTester/Configurations/DebugRelease.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: * asan/asan.xcconfig: 2015-05-26 Anders Carlsson <andersca@apple.com> Fix build. * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::mouseForceDown): (WTR::EventSenderProxy::mouseForceUp): (WTR::EventSenderProxy::mouseForceChanged): 2015-05-26 Alexey Proskuryakov <ap@apple.com> build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice https://bugs.webkit.org/show_bug.cgi?id=145342 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: (BuildbotIteration.prototype._parseData): 2015-05-26 Milan Crha <mcrha@redhat.com> [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py https://bugs.webkit.org/show_bug.cgi?id=138134 Reviewed by Žan Doberšek. * gtk/generate-inspector-gresource-manifest.py: (get_filenames): Command line with expanded resources exceeds 32KB, which is a limit on Windows. It's better to expand wildcards inside the python script. 2015-05-25 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory https://bugs.webkit.org/show_bug.cgi?id=140882 Reviewed by Gustavo Noronha Silva. Make sure unit tests write IndexedDB databases to the temporary directory, and add a test case to check that the directory is correctly created at the expected path. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextConfiguration): (serverCallback): * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h: (Test::Test): 2015-05-25 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Enable IndexedDB https://bugs.webkit.org/show_bug.cgi?id=98932 Reviewed by Žan Doberšek. * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port. 2015-05-24 Sam Weinig <sam@webkit.org> Crash when using a removed ScriptMessageHandler <rdar://problem/20888499> https://bugs.webkit.org/show_bug.cgi?id=145359 Reviewed by Dan Bernstein. * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Add tests for removing script message handlers. 2015-05-23 Dan Bernstein <mitz@apple.com> Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED https://bugs.webkit.org/show_bug.cgi?id=145345 Reviewed by Sam Weinig. * DumpRenderTree/mac/Configurations/Base.xcconfig: * LayoutTestRelay/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/Base.xcconfig: 2015-05-23 Yusuke Suzuki <utatane.tea@gmail.com> Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl https://bugs.webkit.org/show_bug.cgi?id=144848 Reviewed by Darin Adler. Use UniquedStringImpl, SymbolImpl and AtomicStringImpl. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: 2015-05-22 Alexey Proskuryakov <ap@apple.com> Fix one more merge error in static analyzer support. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: (BuildbotStaticAnalyzerQueueView): 2015-05-22 Dana Burkart <dburkart@apple.com> Fix internal dashboard breakage from recent commit. https://bugs.webkit.org/show_bug.cgi?id=144814 Unreviewed build fix. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus): (BuildbotStaticAnalyzerQueueView.prototype.update): 2015-05-22 Alexey Proskuryakov <ap@apple.com> REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails https://bugs.webkit.org/show_bug.cgi?id=130463 rdar://problem/20461342 Reviewed by Tim Horton. This was more of a timing related flakiness than an actual OS version specific bug, we weren't getting window visibility notifications. I will look into adding this function call to DumpRenderTree separately, layout tests might actually rely on the broken behavior. * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: (TestWebKitAPI::TEST_F): * TestWebKitAPI/mac/mainMac.mm: (main): 2015-05-22 Dana Burkart <dburkart@apple.com> Add missing file from r184804 (mis-applied diff). https://bugs.webkit.org/show_bug.cgi?id=144814 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added. (BuildbotStaticAnalyzerQueueView): (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus): (BuildbotStaticAnalyzerQueueView.prototype.update): 2015-05-22 Dana Burkart <dburkart@apple.com> Add support to the botwatchers dashboard for a static analyzer bot. https://bugs.webkit.org/show_bug.cgi?id=144814 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: scan-build should be considered a productive step. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue): Adds support for the staticAnalyzer property * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: (BuildbotTestResults.prototype._parseResults): Get bug count from the scan-build step output * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: (documentReady): Rename the performance column 'Other', and merge the current 'Other' column with it. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): Now that performance bots are part of the 'Other' column, give them better headings. 2015-05-22 Tim Horton <timothy_horton@apple.com> Turn on autosaving of toolbar configuration in MiniBrowser Rubber-stamped by Dan Bernstein. * MiniBrowser/mac/BrowserWindow.xib: 2015-05-22 Alexey Proskuryakov <ap@apple.com> build.webkit.org/dashboard: Simplify BuildbotQueueView creation code https://bugs.webkit.org/show_bug.cgi?id=145297 Reviewed by Tim Horton. This is a refactoring to simplify code, and to make it more logical. It is up to the view to decide how to present the queues, and whether to split them into debug and release, or in some different way. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: (BuildbotBuilderQueueView.filterQueues): (BuildbotBuilderQueueView): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js: (BuildbotLeaksQueueView): (BuildbotLeaksQueueView.prototype.update): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js: (BuildbotPerformanceQueueView): (BuildbotPerformanceQueueView.prototype.update): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView): (BuildbotQueueView.prototype._updateQueues): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: (documentReady): 2015-05-22 Tim Horton <timothy_horton@apple.com> Remove action menu support https://bugs.webkit.org/show_bug.cgi?id=145305 <rdar://problem/21070771> Reviewed by Anders Carlsson. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed. * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed. * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed. * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed. * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed. Remove the tests. 2015-05-22 Dan Bernstein <mitz@apple.com> Removed the Use Shrink To Fit button from the toolbar’s default set. Rubber-stamped by Tim Horton. * MiniBrowser/mac/BrowserWindow.xib: 2015-05-21 Joanmarie Diggs <jdiggs@igalia.com> AX: [GTK] Implement computedRoleString in AccessibilityUIElement https://bugs.webkit.org/show_bug.cgi?id=128420 Reviewed by Chris Fleizach. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::computedRoleString): Implemented. 2015-05-21 Csaba Osztrogonác <ossy@webkit.org> [EFL] Bump libsoup version to 2.50.0 https://bugs.webkit.org/show_bug.cgi?id=145127 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: * efl/patches/soup-clang-warning-fix1.patch: Removed. * efl/patches/soup-clang-warning-fix2.patch: Removed. 2015-05-20 Zan Dobersek <zdobersek@igalia.com> [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/ https://bugs.webkit.org/show_bug.cgi?id=145117 Reviewed by Csaba Osztrogonác. Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under Tools/TestWebKitAPI/Tests/WTF/glib/. * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp. (TestWebKitAPI::TEST): 2015-05-20 KwangHyuk Kim <hyuki.kim@samsung.com> [EFL] fix efreet error https://bugs.webkit.org/show_bug.cgi?id=143670 Reviewed by Gyuyoung Kim. Fix efreet error by using external variable efreet_cache_update. As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache, efreet error for efreet_cache does not occur. * MiniBrowser/efl/main.c: (elm_main): 2015-05-20 Michael Saboff <msaboff@apple.com> Add option to run_jsc_stress_tests to disable JIT testing https://bugs.webkit.org/show_bug.cgi?id=145233 Reviewed by Mark Lam. Added --no-jit option. * Scripts/run-jsc-stress-tests: 2015-05-20 Alex Christensen <achristensen@webkit.org> Use correct String for StringView in WTF API tests https://bugs.webkit.org/show_bug.cgi?id=145226 rdar://problem/20361786 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WTF/StringView.cpp: (TestWebKitAPI::TEST): Use patternHolder for pattern. 2015-05-20 Alex Christensen <achristensen@webkit.org> [Content Extensions] Relax restrictions on triggers that match everything. https://bugs.webkit.org/show_bug.cgi?id=145069 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): Update and add tests for new possibilities with .* 2015-05-20 Rohit Kumar <kumar.rohit@samsung.com> [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser https://bugs.webkit.org/show_bug.cgi?id=144992 Reviewed by Gyuyoung Kim. * MiniBrowser/efl/main.c: (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode. (on_key_down): (on_fullscreen_enter): (on_fullscreen_exit): (window_create): 2015-05-19 Yusuke Suzuki <utatane.tea@gmail.com> Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl https://bugs.webkit.org/show_bug.cgi?id=145109 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: (TestWebKitAPI::TEST): 2015-05-19 Anders Carlsson <andersca@apple.com> Add alternate menu items for performing operations on the default data store https://bugs.webkit.org/show_bug.cgi?id=145184 Reviewed by Sam Weinig. This makes it possible to test WKWebsiteDataStore code paths when there are no live web views associated with a data store. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]): (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]): (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]): * MiniBrowser/mac/MainMenu.xib: 2015-05-19 Csaba Osztrogonác <ossy@webkit.org> Fix tautological-compare warning in AtomicString.cpp https://bugs.webkit.org/show_bug.cgi?id=145120 Reviewed by Alexey Proskuryakov. * TestWebKitAPI/Tests/WTF/AtomicString.cpp: (TestWebKitAPI::TEST): Removed always true assert. 2015-05-18 Csaba Osztrogonác <ossy@webkit.org> [EFL] Fix unsequenced warning in MiniBrowser's main.c https://bugs.webkit.org/show_bug.cgi?id=145123 Reviewed by Gyuyoung Kim. * MiniBrowser/efl/main.c: (on_key_down): 2015-05-18 Daniel Bates <dabates@apple.com> prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning when staged non-empty file for commit https://bugs.webkit.org/show_bug.cgi?id=145082 Reviewed by Darin Adler. Fixes two issues when running prepare-ChangeLog: 1. The function above a deleted function is reported as changed. 2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl, included in this patch). Simplify code by using unified diff parsing logic for both SVN and Git support. Currently prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog. VCSUtil::parseChunkRange() has existing test coverage. * Scripts/prepare-ChangeLog: (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we examine files that only have deletions. Currently this works as a side effect of the behavior of extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]). (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit. (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange(). We return (-1, -1) when the change represents a deletion. (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange(). We return (-1, -1) when the change represents an addition. * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added; unit tests. 2015-05-18 Anders Carlsson <andersca@apple.com> Add ATS keys to MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=145141 Reviewed by Sam Weinig. * MiniBrowser/mac/Info.plist: 2015-05-17 David Kilzer <ddkilzer@apple.com> bisect-builds: Add 'retry' option when prompting whether the bug reproduced <http://webkit.org/b/145100> Reviewed by Darin Adler. * Scripts/bisect-builds: - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt. - Switch to using PROMPT_RESPONSE_* constants when testing the value of $didReproduceBug. - Add do { } while loops to implement 'retry' mode. (promptForTest): - Switch to returning PROMPT_RESPONSE_* constants. - Add support for 'retry' response. 2015-05-16 Tanay C <tanay.c@samsung.com> [EFL][WK2] Minibrowser : Add search icon to search bar https://bugs.webkit.org/show_bug.cgi?id=139773 Reviewed by Gyuyoung Kim. * MiniBrowser/efl/main.c: (search_icon_show): Added. (search_box_show): Modified. 2015-05-15 Ryosuke Niwa <rniwa@webkit.org> run_benchmark should have an option to specify the number of runs https://bugs.webkit.org/show_bug.cgi?id=145091 Reviewed by Stephanie Lewis. Added --count option. * Scripts/run-benchmark: (main): * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.__init__): 2015-05-15 Timothy Horton <timothy_horton@apple.com> Temporarily disable failing API test. * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: (TestWebKitAPI::TEST): 2015-05-15 Ravi Phaneendra Kasibhatla <r.kasibhatla@samsung.com> User interruption while running of run-webkit-tests should also generate results.html https://bugs.webkit.org/show_bug.cgi?id=122154 Reviewed by Csaba Osztrogonác. Generation of results.html on execution of run-webkit-tests happens only on completion of entire layout tests run. It should be created even when the execution has been interrupted - either by user (by pressing Ctrl+C) or because of other interruptions (like exit-after-n-failures option). * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: (LayoutTestRunner.run_tests): * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.run): * Scripts/webkitpy/layout_tests/models/test_run_results.py: (TestRunResults.__init__): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (main): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.test_keyboard_interrupt): (MainTest.test_exception_handling): 2015-05-15 Csaba Osztrogonác <ossy@webkit.org> [buildbot] Fix the URL of the performance bots https://bugs.webkit.org/show_bug.cgi?id=145043 Reviewed by Ryosuke Niwa. * BuildSlaveSupport/build.webkit.org-config/templates/root.html: 2015-05-14 Timothy Horton <timothy_horton@apple.com> Add a layout mode that scales down the view to try to fit the document https://bugs.webkit.org/show_bug.cgi?id=145022 <rdar://problem/19790341> Reviewed by Dean Jackson. * MiniBrowser/mac/BrowserWindow.xib: * MiniBrowser/mac/BrowserWindowController.h: * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController toggleShrinkToFit:]): (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted. Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize. 2015-05-14 Michael Catanzaro <mcatanzaro@igalia.com> [CMake] Don't read the LOCATION property of targets https://bugs.webkit.org/show_bug.cgi?id=145018 Reviewed by Martin Robinson. Use the TARGET_FILE_DIR generator expression to determine the location of the test injected bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will be the same at configure-time as it is at generate-time. * TestWebKitAPI/CMakeLists.txt: 2015-05-14 Myles C. Maxfield <mmaxfield@apple.com> Add String literal overloads to equalIgnoringASCIICase() https://bugs.webkit.org/show_bug.cgi?id=145008 Reviewed by Benjamin Poulain. Test changes to WTF. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*. (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto. * TestWebKitAPI/Tests/WTF/StringView.cpp: (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto. (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto. 2015-05-14 Youenn Fablet <youenn.fablet@crf.canon.fr> SharedBuffer::createWithContentsOfFile should use map file routines https://bugs.webkit.org/show_bug.cgi?id=144192 Reviewed by Darin Adler. Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL. * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added. (TestWebKitAPI::FileSystemTest::tempFilePath): (TestWebKitAPI::FileSystemTest::tempEmptyFilePath): (TestWebKitAPI::TEST_F): * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added. (TestWebKitAPI::SharedBufferTest::tempFilePath): (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath): (TestWebKitAPI::TEST_F): 2015-05-13 Alex Christensen <achristensen@webkit.org> [Content Extensions] Test interactions between multiple extensions and multiple domains. https://bugs.webkit.org/show_bug.cgi?id=144967 Reviewed by Benjamin Poulain. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Xcode wanted to fix an alphabetization issue. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): Test interactions that worked but were not explicitly tested before. 2015-05-12 Ryosuke Niwa <rniwa@webkit.org> Unreviewed build fix. Added the missing metric name and wrapped values in an array as done in SunSpider.patch. * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: 2015-05-12 Ryosuke Niwa <rniwa@webkit.org> Fix the previous commit, which made both bubbles green. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: (.status-line.good .bubble): (.status-line.bad .bubble): (.status-line.good .message): 2015-05-12 Ryosuke Niwa <rniwa@webkit.org> People with Deuteranopia can't tell red and green apart on bot watcher's dashboard https://bugs.webkit.org/show_bug.cgi?id=144929 Reviewed by Eric Carlson. Tweaked colors as I see fit. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: (.status-line.good .bubble): (.status-line.bad .bubble): 2015-05-11 Alexey Proskuryakov <ap@apple.com> [Mac] Share cookie storage between UI process and secondary processes https://bugs.webkit.org/show_bug.cgi?id=144820 rdar://problem/20572830 Reviewed by Darin Adler. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Don't set cookie storage directory, as it's a no-op, we use an ephemeral session for testing. 2015-05-12 Jake Nielsen <jacob_nielsen@apple.com> Fix internal build configuration issues https://bugs.webkit.org/show_bug.cgi?id=144762 Reviewed by David Kilzer. Modifies DumpRenderTree's xcconfig files to use SDK selectors. * DumpRenderTree/mac/Configurations/Base.xcconfig: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: 2015-05-12 David Kilzer <ddkilzer@apple.com> Switch to launching iOS Simulator using bundle ID <rdar://problem/20916096> This is required to fix the layout tests on internal bots. * Scripts/webkitdirs.pm: (relaunchIOSSimulator): Switch to use bundle ID to launch iOS Simulator. Add FIXME. (quitIOSSimulator): Add FIXME. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to launch iOS Simulator. Add FIXME. (IOSSimulatorPort.check_sys_deps): Add FIXME. 2015-05-12 Per Arne Vollan <peavo@outlook.com> Fix run-javascriptcore-tests step on the WinCairo bot https://bugs.webkit.org/show_bug.cgi?id=144866 Reviewed by Csaba Osztrogonác. Catch exception when failing to create soft link, so we can fall back to copy. * Scripts/run-jsc-stress-tests: 2015-05-12 Joanmarie Diggs <jdiggs@igalia.com> [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR https://bugs.webkit.org/show_bug.cgi?id=116971 Reviewed by Chris Fleizach. Implement rowAtIndex for ATK. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::rowAtIndex): 2015-05-11 Dan Bernstein <mitz@apple.com> Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL Reviewed by Alexey Proskuryakov. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header. * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added. (-[ProvisionalURLChangeController webView:didFinishNavigation:]): 2015-05-11 Jake Nielsen <jacob_nielsen@apple.com> Fix internal build configuration issues https://bugs.webkit.org/show_bug.cgi?id=144762 Reviewed by Darin Adler. Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors. * TestWebKitAPI/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: 2015-05-11 Brent Fulgham <bfulgham@apple.com> [Win] Move Windows build target to Windows 7 (or newer) https://bugs.webkit.org/show_bug.cgi?id=144890 <rdar://problem/20707307> Reviewed by Anders Carlsson. Update linked SDK and minimal Windows level to be compatible with Windows 7 or newer. * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj: * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj: * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj: * DumpRenderTree/config.h: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: * WinLauncher/stdafx.h: 2015-05-11 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r184119. https://bugs.webkit.org/show_bug.cgi?id=144888 broke JSC tests on Apple Windows bots (Requested by kling on #webkit). Reverted changeset: "Fix run-javascriptcore-tests step on the WinCairo bot" https://bugs.webkit.org/show_bug.cgi?id=144866 http://trac.webkit.org/changeset/184119 2015-05-11 Ryosuke Niwa <rniwa@webkit.org> run-benchmark should support Dromaeo https://bugs.webkit.org/show_bug.cgi?id=144849 Reviewed by Chris Dumez. Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since they can take as much as 15 minutes to run each. * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added. * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added. * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added. * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added. 2015-05-11 Ryosuke Niwa <rniwa@webkit.org> Build fix. jetstream has a local copy, not remote archive. * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: 2015-05-11 Ryosuke Niwa <rniwa@webkit.org> run-benchmark should support SunSpider, Kraken and Octane https://bugs.webkit.org/show_bug.cgi?id=144840 Reviewed by Darin Adler. Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any. Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans. In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder. * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder now has the ability to run an arbitrary "create script". * Scripts/run-benchmark: (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy. This also overrides the remote archive URL specified in the plan. * Scripts/webkitpy/benchmark_runner/README.md: Updated the description. * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for JetStreamBenchmarkBuilder. * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on _runCreateScript and _applyPatch to clean after themselves. (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since JetStream, SunSpider, Kraken all use this feature. (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of the leaf directory name since the latter is not available when a remote ZIP file is used. (GenericBenchmarkBuilder._fetchRemoteArchive): Added. (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding the benchmark name in the patches. * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed. * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used. (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL the browser opens by planName as the plan file no longer contains that. * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against the top directory of JetStream instead of its parent. * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added. * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added. * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against the top directory of JetStream instead of its parent. * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added. * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies the script to run. The entry point was changed to the relative path from the top directory of JetStream as done in JetStream.patch. * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added. * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added. * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative path from the top directory of JetStream as done in JetStream.patch. * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added. 2015-05-11 Csaba Osztrogonác <ossy@webkit.org> Fix run-javascriptcore-tests step on the WinCairo bot https://bugs.webkit.org/show_bug.cgi?id=144866 Reviewed by Darin Adler. * Scripts/run-jsc-stress-tests: 2015-05-11 Alex Christensen <achristensen@webkit.org> [Content Extensions] Support domain-specific rules and exceptions. https://bugs.webkit.org/show_bug.cgi?id=144833 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter): (TestWebKitAPI::InMemoryCompiledContentExtension::create): (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension): Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing. (TestWebKitAPI::mainDocumentRequest): (TestWebKitAPI::subResourceRequest): (TestWebKitAPI::TEST_F): (TestWebKitAPI::checkCompilerError): Added tests for parsing and functionality of if-domain and unless-domain. 2015-05-11 Ryosuke Niwa <rniwa@webkit.org> run-benchmark should support Chrome Canary and Firefox Nightly https://bugs.webkit.org/show_bug.cgi?id=144850 Reviewed by Darin Adler. Added the support for Chrome Canary, Firefox (release), and Firefox Nightly. This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X. * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added. (OSXBrowserDriver): (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv. (OSXBrowserDriver.closeBrowsers): Ditto. (OSXBrowserDriver.launchProcess): Ditto. (OSXBrowserDriver.terminateProcesses): Ditto. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: (OSXChromeDriver): Removed the unused self.chromePreferences. (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver. (OSXChromeDriver.closeBrowsers): Ditto. (OSXChromeDriver.launchUrl): (OSXChromeCanaryDriver): Added. (OSXChromeCanaryDriver.launchUrl): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added. (OSXFirefoxDriver): Added. (OSXFirefoxDriver.launchUrl): (OSXFirefoxNightlyDriver): Added. (OSXFirefoxNightlyDriver.launchUrl): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: (OSXSafariDriver): (OSXSafariDriver.closeBrowsers): 2015-05-11 Tim Horton <timothy_horton@apple.com> Page overlay action context override should indicate the source of the request https://bugs.webkit.org/show_bug.cgi?id=144832 <rdar://problem/20562594> Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint): 2015-05-10 Martin Robinson <mrobinson@igalia.com> [GTK] fast/events/page-visibility-transition-test.html is timing out https://bugs.webkit.org/show_bug.cgi?id=114789 Reviewed by Darin Adler. * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::setHidden): Map and unmap the WebView when the harness requests visibility changes. 2015-05-10 Csaba Osztrogonác <ossy@webkit.org> [EFL] Fix install-dependencies on Ubuntu 14.10/15.04 https://bugs.webkit.org/show_bug.cgi?id=144798 Reviewed by Darin Adler. * efl/install-dependencies: 2015-05-09 Ryosuke Niwa <rniwa@webkit.org> Make arguments of run-benchmark more user friendly https://bugs.webkit.org/show_bug.cgi?id=144835 Reviewed by Darin Adler. Made --build-directory optional since I don't expect a typical WebKit developer to have a local build of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer" instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed default values from --platform and --browser as they are required arguments. * Scripts/run-benchmark: (main): Made --build-directory optional, and removed default values from --platform and --browser. Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers are not dynamically obtained via BrowserDriverFactory. * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON file instead of suppressing the error here and blowing up later mysteriously since we won't be able to run any benchmark in that case. (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if the specified file isn't a valid relative or an absolute path. * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms and browsers. (BrowserDriverFactory.available_browsers): Ditto. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always calls launchUrl with this argument so removed the default value. Also added a fallback path for when browserBuildPath was None. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari so that we can use locally built WebKit to launch Safari. 2015-05-09 Yoav Weiss <yoav@yoav.ws> Remove the PICTURE_SIZES build flag https://bugs.webkit.org/show_bug.cgi?id=144679 Reviewed by Benjamin Poulain. Removed the PICTURE_SIZES build time flag. * Scripts/webkitperl/FeatureList.pm: 2015-05-09 David Kilzer <ddkilzer@apple.com> Layout tests broke due to unexpected simctl output * Scripts/webkitpy/xcode/simulator.py: (Simulator._parse_devices): Handle new Device Pairs header. * Scripts/webkitpy/xcode/simulator_unittest.py: (test_device_pairs): Add unit test for Device Pairs header. 2015-05-08 Myles C. Maxfield <mmaxfield@apple.com> Remove convenience constructors for TextRun https://bugs.webkit.org/show_bug.cgi?id=144752 Reviewed by Anders Carlsson. Test the StringView which takes a StringImpl*. * TestWebKitAPI/Tests/WTF/StringView.cpp: (StringView8Bit): Testing is8Bit() on StringView 2015-05-07 Sam Weinig <sam@webkit.org> [Content Extensions] Add simple tester that takes an extension and compiles it https://bugs.webkit.org/show_bug.cgi?id=144781 Reviewed by Dan Bates. * ContentExtensionTester: Added. * ContentExtensionTester/Configurations: Added. * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig. * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig. * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig. * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added. * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added. * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile. * ContentExtensionTester/main.m: Added. * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests. 2015-05-08 Alexey Proskuryakov <ap@apple.com> Build fix. Reviewed by Dan Bernstein. * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: (-[DumpRenderTreeDraggingInfo springLoadingHighlight]): (-[DumpRenderTreeDraggingInfo resetSpringLoading]): * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h: * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]): (-[WebKitTestRunnerDraggingInfo resetSpringLoading]): 2015-05-08 Martin Robinson <mrobinson@igalia.com> [GTK] Some tests fail because they do not assume the popup menu captures click events https://bugs.webkit.org/show_bug.cgi?id=40601 Reviewed by Carlos Garcia Campos. Popdown all attached menus when moving between tests and between each new event sent to the WebView. This prevents context and popup menus from eating events. * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown. * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+. * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: (WTR::dispatchEvent): Popdown all menus between dispatching events. (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events. (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events. * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::hideAllPopupMenus): Added this helper. * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no longer in the platform-independent file. (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus. 015-05-08 Michael Catanzaro <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com> [GTK] Checks for DEVELOPMENT_BUILD are all wrong https://bugs.webkit.org/show_bug.cgi?id=144746 Reviewed by Carlos Garcia Campos. Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD. * MiniBrowser/gtk/main.c: (main): 2015-05-08 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r183996. https://bugs.webkit.org/show_bug.cgi?id=144806 ASan detected use-after free (Requested by ap on #webkit). Reverted changeset: "Remove convenience constructors for TextRun" https://bugs.webkit.org/show_bug.cgi?id=144752 http://trac.webkit.org/changeset/183996 2015-05-08 Myles C. Maxfield <mmaxfield@apple.com> Remove convenience constructors for TextRun https://bugs.webkit.org/show_bug.cgi?id=144752 Reviewed by Anders Carlsson. Test the StringView which takes a StringImpl*. * TestWebKitAPI/Tests/WTF/StringView.cpp: (StringView8Bit): Testing is8Bit() on StringView 2015-05-08 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] WTR doesn't correctly handle the Escape key https://bugs.webkit.org/show_bug.cgi?id=144788 Reviewed by Martin Robinson. Correctly handle 0x001B character code in GTK+ event sender to be recognized as Escape key, because gdk_unicode_to_keyval() doesn't handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null); to dismiss popup menus. Fixes editing/selection/5354455-1.html. * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: (WTR::getGDKKeySymForKeyRef): 2015-05-08 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API https://bugs.webkit.org/show_bug.cgi?id=144748 Reviewed by Sergio Villar Senin. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: (testWebKitSettings): Check the new setting is correctly initialized and updated. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextSecurityFileXHR): Check XHR to local files is allowed from file URLs after changing the setting. (beforeAll): Add new test. 2015-05-08 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r183945. https://bugs.webkit.org/show_bug.cgi?id=144789 "It broke all the GTK+ tests" (Requested by KaL on #webkit). Reverted changeset: "[GTK] Checks for DEVELOPMENT_BUILD are all wrong" https://bugs.webkit.org/show_bug.cgi?id=144746 http://trac.webkit.org/changeset/183945 2015-05-07 Anders Carlsson <andersca@apple.com> Build fixes. * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm: (TestWebKitAPI::TEST): Add casts. 2015-05-07 Filip Pizlo <fpizlo@apple.com> GC has trouble with pathologically large array allocations https://bugs.webkit.org/show_bug.cgi?id=144609 Reviewed by Geoffrey Garen. Add a --filter option that restricts the set of tests we run. I needed it to fix this bug and it's a frequently requested feature. Also add the ability to run a test pretending that your system has a particular RAM size. This is useful for GC tests, and the new GC test that I added uses this. * Scripts/run-javascriptcore-tests: (runJSCStressTests): * Scripts/run-jsc-stress-tests: 2015-05-07 Csaba Osztrogonác <ossy@webkit.org> [EFL] Bump EFL version to 1.14.0 https://bugs.webkit.org/show_bug.cgi?id=144743 Reviewed by Darin Adler. Bump EFL and elementary version to 1.14.0 and removed md5sum, because it isn't used at all if hash is present. * efl/jhbuild.modules: 2015-05-07 Saam Barati <saambarati1@gmail.com> exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp https://bugs.webkit.org/show_bug.cgi?id=144753 Reviewed by Mark Lam. * Scripts/jsc-stress-test-helpers/js-exception-fuzz: 2015-05-07 Beth Dakin <bdakin@apple.com> New force-related DOM events should fire in WK1 views https://bugs.webkit.org/show_bug.cgi?id=144663 -and corresponding- rdar://problem/20281886 Reviewed by Sam Weinig. PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event now. Just send nil. * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: (TestWebKitAPI::buildAndPerformTest): 2015-05-07 Michael Catanzaro <mcatanzaro@igalia.com> [GTK] Checks for DEVELOPMENT_BUILD are all wrong https://bugs.webkit.org/show_bug.cgi?id=144746 Reviewed by Martin Robinson. Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD. * MiniBrowser/gtk/main.c: (main): 2015-05-05 Myles C. Maxfield <mmaxfield@apple.com> Revert "Introducing the Platform Abstraction Layer (PAL)" https://bugs.webkit.org/show_bug.cgi?id=144751 Unreviewed. PAL should be a new target inside WebCore, rather than a top-level folder. * Scripts/build-webkit: Add it to build-webkit. 2015-05-07 Ada Chan <adachan@apple.com> Add a test for WKPageCopySessionState() with filtering. https://bugs.webkit.org/show_bug.cgi?id=144666 Reviewed by Darin Adler. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added. (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::setPageLoaderClient): (TestWebKitAPI::filterFirstItemCallback): (TestWebKitAPI::filterAllItemsCallback): (TestWebKitAPI::createSessionStates): (TestWebKitAPI::TEST): 2015-05-06 Alexey Proskuryakov <ap@apple.com> iOS build fix attempt Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 2015-05-06 Matt Baker <mattbaker@apple.com> Unreviewed, updated my list of email addresses. * Scripts/webkitpy/common/config/contributors.json: 2015-05-06 Alexey Proskuryakov <ap@apple.com> Do not link tools to WebKit2.framework https://bugs.webkit.org/show_bug.cgi?id=144699 Unreviewed build fix. * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: These linked to WebKit2 in two ways, eliminating the other one. 2015-05-05 Myles C. Maxfield <mmaxfield@apple.com> Introducing the Platform Abstraction Layer (PAL) https://bugs.webkit.org/show_bug.cgi?id=143358 Reviewed by Simon Fraser. * Scripts/build-webkit: Add it to build-webkit. 2015-05-06 Alex Christensen <achristensen@webkit.org> Fix api tests after r183877. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): Generate all DFAs before compiling them. 2015-05-06 Alexey Proskuryakov <ap@apple.com> Do not link tools to WebKit2.framework https://bugs.webkit.org/show_bug.cgi?id=144699 Reviewed by Tim Horton. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 2015-05-06 Alex Christensen <achristensen@webkit.org> [Content Extensions] Test splitting NFAs by max NFA size. https://bugs.webkit.org/show_bug.cgi?id=144659 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::createNFAs): (TestWebKitAPI::TEST_F): * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp: (TestWebKitAPI::createNFAs): 2015-05-05 daegyu lee <daegyu.lee@navercorp.com> Remove the remaining vestiges of SVG feature define https://bugs.webkit.org/show_bug.cgi?id=144655 Reviewed by Alexey Proskuryakov. * Scripts/webkitperl/FeatureList.pm: 2015-05-05 Timothy Horton <timothy_horton@apple.com> Add a layout mode for computing fixed layout size from a minimum size https://bugs.webkit.org/show_bug.cgi?id=144610 <rdar://problem/19790341> Reviewed by Simon Fraser. * MiniBrowser/mac/BrowserWindow.xib: * MiniBrowser/mac/BrowserWindowController.h: * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController toggleUseMinimumViewSize:]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Add a optional toolbar item to toggle a minimum view size of 1024x0. 2015-05-05 Alex Christensen <achristensen@webkit.org> [Content Extensions] Release input NSString when finished copying it. https://bugs.webkit.org/show_bug.cgi?id=144642 Reviewed by Brian Weinstein. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformConfigureViewForTest): Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object. 2015-05-05 Brent Fulgham <bfulgham@apple.com> Unreviewed test fix after r183798. * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (convertToDRTLabel): Mimic behavior of Mac accessibility output so we can share results. 2015-05-05 Alex Christensen <achristensen@webkit.org> [Content Extensions] Use less memory to store the json input. https://bugs.webkit.org/show_bug.cgi?id=144604 Reviewed by Benjamin Poulain. * MiniBrowser/mac/ExtensionManagerWindowController.m: (-[ExtensionManagerWindowController add:]): * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter): * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformConfigureViewForTest): 2015-05-05 Yusuke Suzuki <utatane.tea@gmail.com> Unreviewed. Make myself a WebKit reviewer. * Scripts/webkitpy/common/config/contributors.json: 2015-05-05 Joanmarie Diggs <jdiggs@igalia.com> [GTK] r183783 breaks build https://bugs.webkit.org/show_bug.cgi?id=144632 Reviewed by Martin Robinson. Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): 2015-05-05 Alex Christensen <achristensen@webkit.org> [Content Extensions] Combine NFAs properly and free memory as we compile. https://bugs.webkit.org/show_bug.cgi?id=144485 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): Added tests for correctly splitting up NFAs with unquantified terms after quantified terms. Added tests for deep NFAs. 2015-05-04 Alex Christensen <achristensen@webkit.org> [Content Extensions] Use less memory when writing byte code to file https://bugs.webkit.org/show_bug.cgi?id=144602 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: 2015-05-05 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp https://bugs.webkit.org/show_bug.cgi?id=144541 Reviewed by Žan Doberšek. Add a test case to WorkQueue unit test, to check that sources of asynchronous IO operations running in the WorkQueue thread are dispatched by the WorkQueue main loop. * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added. (TestWebKitAPI::TEST): 2015-05-04 Brent Fulgham <bfulgham@apple.com> Correct '--show-webview' option for Tiled Drawing tests https://bugs.webkit.org/show_bug.cgi?id=144621 Reviewed by Simon Fraser. The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make sure that the state of the '--show-webview' option was propagated to this additional view creation routine. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the WKMutableDictionary passed to the 'ensureViewSupportsOptions' method. 2015-05-04 Filip Pizlo <fpizlo@apple.com> Large array shouldn't be slow https://bugs.webkit.org/show_bug.cgi?id=144617 Reviewed by Geoffrey Garen. Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of SunSpider. It's not an official benchmark. It contains benchmarks that are relatively long-running. So, hash-map sort of belongs here. * Scripts/run-jsc-benchmarks: 2015-05-04 Doug Russell <d_russell@apple.com> AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent https://bugs.webkit.org/show_bug.cgi?id=144489 Reviewed by Chris Fleizach. Resolves infinite looping when navigating rapidly between controls with the search API and then focusing on the returned control. Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache. Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method. Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus(). Add support for setSelectedVisibleTextRange() in accessibility tests. * DumpRenderTree/AccessibilityUIElement.cpp: (setSelectedVisibleTextRangeCallback): (AccessibilityUIElement::setSelectedVisibleTextRange): (AccessibilityUIElement::getJSClass): (AccessibilityUIElement::textMarkerForIndex): Deleted. * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::setSelectedVisibleTextRange): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted. * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): 2015-05-04 Brent Fulgham <bfulgham@apple.com> [Win] Implement the "--show-webview" option for Windows https://bugs.webkit.org/show_bug.cgi?id=144589 Reviewed by Alex Christensen. Add another runtime flag (--show-webview) that causes DumpRenderTree to draw its view on-screen, rather than the standard offscreen mode. * DumpRenderTree/win/DumpRenderTree.cpp: (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag. (initializeGlobalsFromCommandLineOptions): Recognize the new command-line argument, and set the global 'showWebView' state if appropriate. 2015-05-04 Csaba Osztrogonác <ossy@webkit.org> Remove dead code from TestInvocationCairo.cpp https://bugs.webkit.org/show_bug.cgi?id=144564 Reviewed by Gyuyoung Kim. Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform. * WebKitTestRunner/cairo/TestInvocationCairo.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): 2015-05-04 Joonghun Park <jh718.park@samsung.com> [GTK] Add libnotify in gtk install-dependencies https://bugs.webkit.org/show_bug.cgi?id=144379 Reviewed by Csaba Osztrogonác. * gtk/install-dependencies: 2015-05-01 Dan Bernstein <mitz@apple.com> Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list https://bugs.webkit.org/show_bug.cgi?id=144501 Reviewed by Darin Adler. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added. (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]): (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]): 2015-05-01 Mario Sanchez Prada <mario@endlessm.com> check-webkit-style fails due to system pylint https://bugs.webkit.org/show_bug.cgi?id=144360 Reviewed by Darin Adler. Make sure that the directory containing third party autoinstalled modules is at the beginning of the search path, to avoid conflicts with other versions of the same modules installed in the system (e.g. pylint). * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled modules directory to sys.path, instead of appending it. 2015-05-01 Mario Sanchez Prada <mario@endlessm.com> Unreviewed, updated my list of email addresses. * Scripts/webkitpy/common/config/contributors.json: Updated. 2015-05-01 Martin Robinson <mrobinson@igalia.com> USE(...) macro should expect unprefixed variables https://bugs.webkit.org/show_bug.cgi?id=144454 Reviewed by Daniel Bates. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE. * DumpRenderTree/config.h: Ditto. * TestWebKitAPI/config.h: Ditto. 2015-05-01 Basile Clement <basile_clement@apple.com> Unreviewed. Add myself as a commiter in contributors.json. * Scripts/webkitpy/common/config/contributors.json: 2015-05-01 Dewei Zhu <dewei_zhu@apple.com> Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark. https://bugs.webkit.org/show_bug.cgi?id=144487 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.merge): Fix bug. * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric. 2015-05-01 Brady Eidson <beidson@apple.com> Add API to disable meta refreshes. <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269 Reviewed by Alexey Proskuryakov. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests. 2015-05-01 Brent Fulgham <bfulgham@apple.com> Provide a runtime flag to run-webkit-tests that shows the test view https://bugs.webkit.org/show_bug.cgi?id=144079. Unreviewed correction to r183651. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Make sure the state of the '--show-webview' flag is included in the options dictionary passed to the PlatformWebView. 2015-05-01 Antti Koivisto <antti@apple.com> Remove network process load serialization code https://bugs.webkit.org/show_bug.cgi?id=144448 Reviewed by Alexey Proskuryakov. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setSerializeHTTPLoads): (WTR::TestRunner::dispatchPendingLoadRequests): 2015-05-01 Xabier Rodriguez Calvar <calvaris@igalia.com> [GTK] Add libhyphen-dev to the build dependencies https://bugs.webkit.org/show_bug.cgi?id=144452 Reviewed by Martin Robinson. * gtk/install-dependencies: Added hyphen as Fedora and Arch dependencies. 2015-04-30 Brent Fulgham <bfulgham@apple.com> Provide a runtime flag to run-webkit-tests that shows the test view https://bugs.webkit.org/show_bug.cgi?id=144079. Reviewed by Dean Jackson. Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag" option: --additional-drt-flag="--show-webview" * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the '--show-webview' flag. (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option. * WebKitTestRunner/Options.cpp: (WTR::Options::Options): (WTR::handleOptionShowWebView): (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option. * WebKitTestRunner/Options.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::TestController): (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle. * WebKitTestRunner/TestController.h: (WTR::TestController::shouldShowWebView): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the options dictionary. If it is true, display the web view while running the test. 2015-04-30 Alexey Proskuryakov <ap@apple.com> r183355 didn't trigger Mac tests https://bugs.webkit.org/show_bug.cgi?id=144464 Reviewed by Simon Fraser. Update badly neglected filters and unit tests. * BuildSlaveSupport/build.webkit.org-config/wkbuild.py: (_should_file_trigger_build): * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: (ShouldBuildTest): (ShouldBuildTest.test_should_build): 2015-04-30 Xabier Rodriguez Calvar <calvaris@igalia.com> [GTK] Add libhyphen-dev to the build dependencies https://bugs.webkit.org/show_bug.cgi?id=144452 Reviewed by Martin Robinson. * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+ build dependencies. 2015-04-30 Martin Robinson <mrobinson@igalia.com> [GTK] Testing dictionaries are not installed automatically https://bugs.webkit.org/show_bug.cgi?id=144460 Reviewed by Carlos Garcia Campos. * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset. 2015-04-30 Dewei Zhu <dewei_zhu@apple.com> Fix return code issue, check return code of safari process and dump results to log https://bugs.webkit.org/show_bug.cgi?id=144436 Reviewed by Ryosuke Niwa. * Scripts/run-benchmark: * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.dump): Correct typo. (BenchmarkRunner.wrap): Add results to console. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes. (OSXSafariDriver.prepareEnv): (OSXSafariDriver.launchUrl): (OSXSafariDriver.closeBrowsers): 2015-04-29 Joseph Pecoraro <pecoraro@apple.com> Should no longer need to worry about very old versions of Xcode https://bugs.webkit.org/show_bug.cgi?id=144437 Reviewed by Dan Bernstein. * Scripts/check-for-exit-time-destructors: * Scripts/check-for-global-initializers: * Scripts/check-for-weak-vtables-and-externals: 2015-04-29 Joseph Pecoraro <pecoraro@apple.com> REGRESSION(183583): [Mac] make without SDKROOT has issues https://bugs.webkit.org/show_bug.cgi?id=144431 Reviewed by Dan Bernstein. * Makefile: * WebKitTestRunner/Makefile: Assume an empty SDKROOT means an macosx variant, so only enable settings if the SDKROOT is not empty and does not contain "macosx". 2015-04-29 Brent Fulgham <bfulgham@apple.com> Expand test infrastructure to support scrolling tests https://bugs.webkit.org/show_bug.cgi?id=143684 <rdar://problem/20375516> Reviewed by Simon Fraser. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is reset before the next test run. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Ditto." 2015-04-29 Alex Christensen <achristensen@webkit.org> Run javascriptcore tests on Windows without cygwin https://bugs.webkit.org/show_bug.cgi?id=144419 Reviewed by Brent Fulgham. * Scripts/run-javascriptcore-tests: (runJSCStressTests): Just call ruby, not /usr/bin/env ruby. 2015-04-29 Yusuke Suzuki <utatane.tea@gmail.com> [GTK] Add --enable-shared option to LLVM to build mesa https://bugs.webkit.org/show_bug.cgi?id=144393 Reviewed by Martin Robinson. The updated mesa requires the shared LLVM libraries. To build mesa with LLVM in FTL build, this patch added `--enable-shared` option to LLVM configure script. It will provide shared libraries in addition to static libraries. * gtk/jhbuild-optional.modules: 2015-04-29 Martin Robinson <mrobinson@igalia.com> [GTK] Add support for automatic hyphenation https://bugs.webkit.org/show_bug.cgi?id=44478 Reviewed by Carlos Garcia Campos. * gtk/jhbuild.modules: Add a module for testing dictionaries, so that all systems will use the same dictionaries for testing purposes. 2015-04-29 Jake Nielsen <jacob_nielsen@apple.com> Failure when building WebKit for appletvsimulator. https://bugs.webkit.org/show_bug.cgi?id=144356 Reviewed by Alexey Proskuryakov. Changes Makefile logic to check for "not OS X" rather than "is iOS" to make TVOS and WatchOS behave correctly. * Makefile: * WebKitTestRunner/Makefile: 2015-04-29 Alexey Proskuryakov <ap@apple.com> Use-after-free when invalidating WKPageForceRepaint callback https://bugs.webkit.org/show_bug.cgi?id=144401 rdar://problem/20741111 Reviewed by Tim Horton. * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback): Don't do anything on error, because the context may be a stale pointer now. 2015-04-29 David Kilzer <ddkilzer@apple.com> check-webkit-style: Don't complain about returning value from Objective-C method call in header <http://webkit.org/b/144395> Reviewed by Andy Estes. * Scripts/webkitpy/style/checkers/cpp.py: (check_spacing): Update regex so 'return' is ignored if it precedes the whitespace and bracket. Change category name to 'whitespace/brackets'. Add period to error message. (CppChecker): Add 'whitespace/brackets' as a category. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with 'CppChecker.categories' since that's where the list lives now. (CppStyleTest.test_spacing_before_brackets): Add tests for 'whitespace/brackets' issues and non-issues. 2015-04-29 Alex Christensen <achristensen@webkit.org> Fix WinCairo bot. * Scripts/webkitdirs.pm: (determinePassedConfiguration): WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration. 2015-04-29 Myles C. Maxfield <mmaxfield@apple.com> [OS X] Use CTFontCreateForCSS instead of doing font search ourselves https://bugs.webkit.org/show_bug.cgi?id=132159 Reviewed by Darin Adler. Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP). * DumpRenderTree/mac/DumpRenderTree.mm: (fontWhitelist): (adjustFonts): (createWebViewAndOffscreenWindow): * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: (WTR::activateFonts): * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::allowedFontFamilySet): (WTR::systemHiddenFontFamilySet): (WTR::generateWhitelist): (WTR::TestController::platformInitializeContext): 2015-04-29 Alexey Proskuryakov <ap@apple.com> fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2 https://bugs.webkit.org/show_bug.cgi?id=144155 Reviewed by Andreas Kling. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Make sure that test window is "visible" before each test. While there is no concrete evidence that this is the problem indeed, the behavior is consistent with what would happen for an invisible window. Also, WKTR obviously needs to do this to protect against potential buggy tests that hide the window and don't show it. 2015-04-29 Carlos Garcia Campos <cgarcia@igalia.com> Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session. Latest changes in the inspector UI made this test fail. We were relying that the sidebar was always visible and the first 'li' element of the inspector was the one containing the title. This is no longer true, so better use document title that is not likely to change. * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: (openRemoteDebuggingSession): 2015-04-29 Andres Gomez <agomez@igalia.com> Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one. * Scripts/webkitpy/common/config/contributors.json: 2015-04-29 Andres Gomez <agomez@igalia.com> Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it. * Scripts/webkitpy/common/config/watchlist: 2015-04-29 Hunseop Jeong <hs85.jeong@samsung.com> [EFL] Allow to run the tests on the native X display https://bugs.webkit.org/show_bug.cgi?id=144247 Reviewed by Gyuyoung Kim. Added the USE_NATIVE_XDISPLAY option for the WTR. We can select the Xorg driver if environment variable is set up before running the tests. * Scripts/webkitpy/port/efl.py: (EflPort._driver_class): 2015-04-29 Joonghun Park <jh718.park@samsung.com> [GTK] Add libnotify-dev in gtk install-dependencies https://bugs.webkit.org/show_bug.cgi?id=144379 Reviewed by Žan Doberšek. * gtk/install-dependencies: 2015-04-28 Ryuan Choi <ryuan.choi@navercorp.com> [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS https://bugs.webkit.org/show_bug.cgi?id=143001 Reviewed by Gyuyoung Kim. * WebKitTestRunner/TestController.cpp: (WTR::shouldUseFixedLayout): 2015-04-28 Dewei Zhu <dewei_zhu@apple.com> Increase stablility of run-benchmark script https://bugs.webkit.org/show_bug.cgi?id=144361 Reviewed by Ryosuke Niwa. * Scripts/run-benchmark: (main): * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes. * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: (GenericBenchmarkBuilder.clean): * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop. (BenchmarkRunner.__init__): (BenchmarkRunner.execute): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari. * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'. * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate. * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate. * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout. * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: (HTTPServerDriver.fetchResult): (HTTPServerDriver): (HTTPServerDriver.killServer): Add kill server interface. (HTTPServerDriver.getReturnCode): Add get return code interface. * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces. (SimpleHTTPServerDriver.serve): (SimpleHTTPServerDriver.fetchResult): (SimpleHTTPServerDriver): (SimpleHTTPServerDriver.killServer): (SimpleHTTPServerDriver.getReturnCode): * Scripts/webkitpy/benchmark_runner/utils.py: (forceRemove): Provide python version of 'rm -rf'. 2015-04-28 Sam Weinig <sam@webkit.org> [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time https://bugs.webkit.org/show_bug.cgi?id=144363 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::createNFAs): (TestWebKitAPI::TEST_F): * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp: (TestWebKitAPI::countLiveNodes): (TestWebKitAPI::createNFAs): (TestWebKitAPI::buildDFAFromPatterns): Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs. 2015-04-28 Michael Catanzaro <mcatanzaro@igalia.com> Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT https://bugs.webkit.org/show_bug.cgi?id=144304 Reviewed by Geoffrey Garen. * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value. * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit. 2015-04-28 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r183514. https://bugs.webkit.org/show_bug.cgi?id=144359 It broke cloop test bots (Requested by mcatanzaro on #webkit). Reverted changeset: "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT" https://bugs.webkit.org/show_bug.cgi?id=144304 http://trac.webkit.org/changeset/183514 2015-04-28 Michael Catanzaro <mcatanzaro@igalia.com> Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT https://bugs.webkit.org/show_bug.cgi?id=144304 Reviewed by Geoffrey Garen. * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity- checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value. * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit. 2015-04-28 Gyuyoung Kim <gyuyoung.kim@webkit.org> [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files https://bugs.webkit.org/show_bug.cgi?id=144319 Reviewed by Csaba Osztrogonác. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/PlatformEfl.cmake: 2015-04-28 Joseph Pecoraro <pecoraro@apple.com> Fix common typo "targetting" => "targeting" https://bugs.webkit.org/show_bug.cgi?id=144349 Reviewed by Daniel Bates. * Scripts/webkitdirs.pm: (execMacWebKitAppForDebugging): 2015-04-28 Joanmarie Diggs <jdiggs@igalia.com> [GTK][jhbuild] Mesa build failure with llvm 3.6 https://bugs.webkit.org/show_bug.cgi?id=144250 Reviewed by Žan Doberšek. Bump the version of Mesa to 10.5.4 * gtk/jhbuild.modules: 2015-04-28 Alexey Proskuryakov <ap@apple.com> Disable App Nap in WebKitTestRunner UI process https://bugs.webkit.org/show_bug.cgi?id=144308 Reviewed by Daniel Bates. * WebKitTestRunner/mac/main.mm: (disableAppNapInUIProcess): (main): 2015-04-28 Marcos Chavarría Teijeiro <chavarria1991@gmail.com> [GTK] Update JHBuild Mesa download directory https://bugs.webkit.org/show_bug.cgi?id=144318 Update the download directory of Mesa module since the previous one doesn't exist any more. Reviewed by Žan Doberšek. * gtk/jhbuild.modules: 2015-04-28 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r183477. https://bugs.webkit.org/show_bug.cgi?id=144334 Roll back the Mesa dependency bump in fear of uncaught regressions while the testing bots are no-op. (Requested by zdobersek on #webkit). Reverted changeset: "[GTK][jhbuild] Mesa build failure with llvm 3.6" https://bugs.webkit.org/show_bug.cgi?id=144250 http://trac.webkit.org/changeset/183477 2015-04-28 Joanmarie Diggs <jdiggs@igalia.com> [GTK][jhbuild] Mesa build failure with llvm 3.6 https://bugs.webkit.org/show_bug.cgi?id=144250 Reviewed by Žan Doberšek. Bump the version of Mesa to 10.5.4 * gtk/jhbuild.modules: 2015-04-27 Dewei Zhu <dewei_zhu@apple.com> Add '__init__.py' and fix known bug in benchmark runner. https://bugs.webkit.org/show_bug.cgi?id=144296 Reviewed by Ryosuke Niwa * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module. * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module. * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.__init__): (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug. * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module. * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module. 2015-04-27 Alexey Proskuryakov <ap@apple.com> More build fix. * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: (-[AccessibilityNotificationHandler _notificationReceived:]): Use -objectForKey:, not array subscript. 2015-04-27 Alexey Proskuryakov <ap@apple.com> Catch unexpected exits in DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=144288 Reviewed by Tim Horton. * DumpRenderTree/mac/DumpRenderTree.mm: (atexitFunction): (DumpRenderTreeMain): 2015-04-27 Alexey Proskuryakov <ap@apple.com> Build fix * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: (-[AccessibilityNotificationHandler _notificationReceived:]): Use -objectForKey:, not array subscript. 2015-04-27 Alexey Proskuryakov <ap@apple.com> fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2 https://bugs.webkit.org/show_bug.cgi?id=144155 Reviewed by Tim Horton. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): Disable App Nap. I don't have positive evidence that it's the culprit, but it could be, and we clearly don't want App Nap while testing. 2015-04-22 Martin Robinson <mrobinson@igalia.com> [CMake] Autogenerate cmakeconfig.h.cmake https://bugs.webkit.org/show_bug.cgi?id=143997 Reviewed by Csaba Osztrogonác. * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line definitions since TestNetscapePlugIn does not use cmakeconfig.h. 2015-04-27 Brent Fulgham <bfulgham@apple.com> REGRESSION(r182879): Images and video can no longer be downloaded https://bugs.webkit.org/show_bug.cgi?id=144267 <rdar://problem/20702844> Reviewed by Simon Fraser. Revise tests to check for proper download menu state. 1. Downloading a loal image should be disabled. 2. Downloading a local media file should be disabled. 3. Downloading non-downloadable media should be disabled. * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: (TestWebKitAPI::TEST): 2015-04-27 Csaba Osztrogonác <ossy@webkit.org> Merge run-launcher into run-minibrowser https://bugs.webkit.org/show_bug.cgi?id=141928 Reviewed by Darin Adler. * Scripts/run-iexploder-tests: (runSafariWithIExploder): * Scripts/run-launcher: Removed. * Scripts/run-minibrowser: * Scripts/webkitdirs.pm: (launcherPath): * Scripts/webkitpy/port/efl.py: (EflPort.show_results_html_file): * Scripts/webkitpy/port/efl_unittest.py: (EflPortTest.test_show_results_html_file): * Scripts/webkitpy/port/gtk.py: (GtkPort.print_leaks_summary): (GtkPort.show_results_html_file): (GtkPort): Deleted. * Scripts/webkitpy/port/gtk_unittest.py: (GtkPortTest.test_show_results_html_file): 2015-04-27 Csaba Osztrogonác <ossy@webkit.org> [buildbot] Fix the output of perf-test buildstep on timeout https://bugs.webkit.org/show_bug.cgi?id=144097 Reviewed by Ryosuke Niwa. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunAndUploadPerfTests.getText2): * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: (RunAndUploadPerfTestsTest.test_buildbot_timeout): (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted. 2015-04-27 Csaba Osztrogonác <ossy@webkit.org> [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator https://bugs.webkit.org/show_bug.cgi?id=143874 Reviewed by Gyuyoung Kim. * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency. 2015-04-24 Philippe Normand <pnormand@igalia.com> [JHBuild] Move to upstream OpenWebRTC https://bugs.webkit.org/show_bug.cgi?id=144145 Reviewed by Carlos Garcia Campos. * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository and add a new simple patch to gst-plugins-base, required for OpenWebRTC build. * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added. * gtk/jhbuild.modules: Ditto. * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added. 2015-04-26 Yusuke Suzuki <utatane.tea@gmail.com> [ES6] Implement ES6 template literals https://bugs.webkit.org/show_bug.cgi?id=142691 Reviewed by Darin Adler. Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag. * Scripts/webkitperl/FeatureList.pm: 2015-04-26 Gyuyoung Kim <gyuyoung.kim@webkit.org> [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake https://bugs.webkit.org/show_bug.cgi?id=144217 Reviewed by Darin Adler. * WebKitTestRunner/PlatformEfl.cmake: 2015-04-26 Doug Russell <d_russell@apple.com> AX: richer text change notifications (142719) https://bugs.webkit.org/show_bug.cgi?id=142719 Reviewed by Darin Adler. Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes. Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields. * DumpRenderTree/mac/AccessibilityNotificationHandler.h: * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: (-[AccessibilityNotificationHandler stopObserving]): (-[AccessibilityNotificationHandler _notificationReceived:]): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::removeNotificationListener): * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: (-[AccessibilityNotificationHandler _notificationReceived:]): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::removeNotificationListener): 2015-04-25 Sungmann Cho <sungmann.cho@navercorp.com> Add myself to contributors.json https://bugs.webkit.org/show_bug.cgi?id=144204 Reviewed by Darin Adler. * Scripts/webkitpy/common/config/contributors.json: 2015-04-25 Martin Robinson <mrobinson@igalia.com> Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS https://bugs.webkit.org/show_bug.cgi?id=144182 Reviewed by Simon Fraser. * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS. 2015-04-25 Dewei Zhu <dewei_zhu@apple.com> https://bugs.webkit.org/show_bug.cgi?id=144038 Reviewed by Ryosuke Niwa Add a script to run Speedometer and JetStream on a browser. * Scripts/run-benchmark: Wrapper script to run benchmark. (main): * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script. * Scripts/webkitpy/benchmark_runner/__init__.py: Added. * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added. * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added. (BenchmarkBuilderFactory): * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added. * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added. (GenericBenchmarkBuilder): (GenericBenchmarkBuilder.prepare): (GenericBenchmarkBuilder._copyBenchmarkToTempDir): (GenericBenchmarkBuilder._applyPatch): (GenericBenchmarkBuilder.clean): * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added. (JetStreamBenchmarkBuilder): (JetStreamBenchmarkBuilder.prepare): (JetStreamBenchmarkBuilder._runCreateScript): * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running. (BenchmarkRunner): (BenchmarkRunner.__init__): (BenchmarkRunner.execute): (BenchmarkRunner.dump): (BenchmarkRunner.wrap): (BenchmarkRunner.merge): * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added. * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added. (BrowserDriver): (BrowserDriver.prepareEnv): (BrowserDriver.launchUrl): (BrowserDriver.closeBrowser): * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added. (BrowserDriverFactory): * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added. (OSXChromeDriver): (OSXChromeDriver.prepareEnv): (OSXChromeDriver.launchUrl): (OSXChromeDriver.closeBrowsers): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added. (OSXSafariDriver): (OSXSafariDriver.prepareEnv): (OSXSafariDriver.launchUrl): (OSXSafariDriver.closeBrowsers): * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script. * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp. * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added. * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added. * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose. (GenericFactory): (GenericFactory.iterateGetItem): (GenericFactory.create): * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added. * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added. (ServerControl): (ServerControl.render_GET): (ServerControl.render_POST): * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added. (HTTPServerDriver): (HTTPServerDriver.serve): (HTTPServerDriver.fetchResult): * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added. (HTTPServerDriverFactory): * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added. * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added. (SimpleHTTPServerDriver): (SimpleHTTPServerDriver.depends): (SimpleHTTPServerDriver.__init__): (SimpleHTTPServerDriver.serve): (SimpleHTTPServerDriver.baseUrl): (SimpleHTTPServerDriver.fetchResult): * Scripts/webkitpy/benchmark_runner/utils.py: Utility module. (ModuleNotFoundError): (loadModule): (getPathFromProjectRoot): (loadJSONFromFile): (TimeoutError): (timeout): (timeout.__init__): (timeout.handle_timeout): (timeout.__enter__): (timeout.__exit__): 2015-04-24 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r183303. https://bugs.webkit.org/show_bug.cgi?id=144181 Change was incorrect, broke builds (Requested by smfr on #webkit). Reverted changeset: "Fix the build." http://trac.webkit.org/changeset/183303 2015-04-24 Simon Fraser <simon.fraser@apple.com> Fix the build. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController initWithConfiguration:]): 2015-04-24 Brent Fulgham <bfulgham@apple.com> Disable ActionMenusPDFTest due to timeout on test bot * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: (TestWebKitAPI::TEST): 2015-04-24 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r183266. https://bugs.webkit.org/show_bug.cgi?id=144164 Broke 32-bit build and a test. (Requested by ap on #webkit). Reverted changeset: "AX: richer text change notifications (142719)" https://bugs.webkit.org/show_bug.cgi?id=142719 http://trac.webkit.org/changeset/183266 2015-04-24 Brent Fulgham <bfulgham@apple.com> REGRESSION: WebKit2.ActionMenusTest API test fails https://bugs.webkit.org/show_bug.cgi?id=144149 <rdar://problem/20677770> Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF as the 'ActionMenusPDFTest'. * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output to match the hit test on the 'action-menu-target.pdf' test file. 2015-04-24 Daniel Bates <dabates@apple.com> Cleanup: Use @memoized for property IOSSimulator.testing_device https://bugs.webkit.org/show_bug.cgi?id=141715 Reviewed by Darin Adler. Simplify the caching of the result of IOSSimulator.testing_device and make the code more readable by making use of the @memoized declarator instead of explicitly managing a private instance variable, IOSSimulator._testing_device, for the cached result. * Scripts/webkitpy/port/ios.py: (IOSPort.determine_full_port_name): (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device. (IOSSimulatorPort): (IOSSimulatorPort.testing_device): No need to cache the created device object in IOSSimulatorPort._testing_device since we are marking this function @memoized. (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead of caching in local variable since we only make use of this value exactly once in this function. (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never been used since being added in r178622. So, we can remove this constructor since it's the trivial constructor once we remove the instance variable IOSPort._testing_device. 2015-04-24 Anders Carlsson <andersca@apple.com> Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent] https://bugs.webkit.org/show_bug.cgi?id=144158 Reviewed by Beth Dakin. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController initWithConfiguration:]): 2015-04-24 Doug Russell <d_russell@apple.com> AX: richer text change notifications (142719) https://bugs.webkit.org/show_bug.cgi?id=142719 Reviewed by Darin Adler. Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes. Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields. * DumpRenderTree/mac/AccessibilityNotificationHandler.h: * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: (-[AccessibilityNotificationHandler stopObserving]): (-[AccessibilityNotificationHandler _notificationReceived:]): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::removeNotificationListener): * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: (-[AccessibilityNotificationHandler _notificationReceived:]): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::removeNotificationListener): 2015-04-24 Darin Adler <darin@apple.com> Convert OwnPtr and PassOwnPtr uses to std::unique_ptr https://bugs.webkit.org/show_bug.cgi?id=128007 Reviewed by Anders Carlsson. * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include. * DumpRenderTree/win/UIDelegate.h: Ditto. * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases. * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto. * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include. * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr. (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique. * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto. (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto. * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: (WebKitDOMDOMWindowTest::create): Ditto. * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (documentLoadedCallback): Use a queue of DelayedSignal objects instead of smart pointers to DelayedSIgnal objects. (uriChangedCallback): Ditto. 2015-04-24 Brent Fulgham <bfulgham@apple.com> [Mac] Unreviewed test fix. https://bugs.webkit.org/show_bug.cgi?id=144149 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: (TestWebKitAPI::TEST): Temporarily skip the PDF <embed> test. 2015-04-23 Darin Adler <darin@apple.com> Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr https://bugs.webkit.org/show_bug.cgi?id=144090 Reviewed by Anders Carlsson. * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include. 2015-04-23 Michael Saboff <msaboff@apple.com> lldb macro btjs sometimes can't get a frame description https://bugs.webkit.org/show_bug.cgi?id=144130 Reviewed by Filip Pizlo. We look to execute ExecState::describeFrame(). It appears that in some contexts the debugger can't find ExecState. In those cases, CallFrame works as it is a typedef of ExecState. Therefore we can fallback to using CallFrame::describeFrame(). * lldb/lldb_webkit.py: (btjs): 2015-04-23 Alex Christensen <achristensen@webkit.org> Use less memory when compiling content extensions. https://bugs.webkit.org/show_bug.cgi?id=144051 Reviewed by Darin Adler and Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp: (TestWebKitAPI::countLiveNodes): 2015-04-22 Michael Catanzaro <mcatanzaro@igalia.com> [CMake] Clean up JSC JIT options https://bugs.webkit.org/show_bug.cgi?id=143998 Reviewed by Filip Pizlo. * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports. * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP. 2015-04-21 Brent Fulgham <bfulgham@apple.com> [Mac] Extend action menus to support PDF https://bugs.webkit.org/show_bug.cgi?id=143895 <rdar://problem/19003333> Reviewed by Tim Horton. Reactivate the action menu tests, and add a new PDF-based test to make sure that selection of PDF content works. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle. * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane. * TestWebKitAPI/Tests/WebKit2/test.pdf: Added. * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]): Update to support PDF tests. (TestWebKitAPI::windowPointForTarget): Add new target for PDF test. (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available. 2015-04-22 Carlos Garcia Campos <cgarcia@igalia.com> Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled. * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: (beforeAll): (testWebViewAudioOnlyUserMediaPermissionRequests): 2015-04-22 Michael Catanzaro <mcatanzaro@igalia.com> Add myself to watchlist https://bugs.webkit.org/show_bug.cgi?id=144041 Reviewed by Alex Christensen. Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations. * Scripts/webkitpy/common/config/watchlist: 2015-04-22 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] MiniBrowser should use NetworkProcess by default https://bugs.webkit.org/show_bug.cgi?id=143948 Reviewed by Sergio Villar Senin. Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default unless MINIBROWSER_SINGLEPROCESS environment variable is present. * MiniBrowser/gtk/main.c: (main): 2015-04-21 Matthew Hanson <matthew_hanson@apple.com> Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues. Unreviewed build fix. * Scripts/prepare-ChangeLog: (get_function_line_ranges_for_cpp): Use grep instead of any to determine if a string is an element of an array. 2015-04-21 Anders Carlsson <andersca@apple.com> Fix block signatures https://bugs.webkit.org/show_bug.cgi?id=144002 Reviewed by Andreas Kling. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): 2015-04-21 Philippe Normand <pnormand@igalia.com> [GTK] jhbuild should not use a branch for openwebrtc https://bugs.webkit.org/show_bug.cgi?id=143981 Reviewed by Carlos Garcia Campos. * gtk/jhbuild.modules: 2015-04-20 Matthew Hanson <matthew_hanson@apple.com> Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2. Unreviewed build fix. The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2. However, it has been exposed by List::MoreUtils since its inception. This patch uses the any function exposed by List::MoreUtils for greater compatibility. * Scripts/prepare-ChangeLog: Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes the any function in all of versions of Perl used by our infrastructure. 2015-04-20 Alex Christensen <achristensen@webkit.org> Remove unnecessary logs when resetting tests. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformResetPreferencesToConsistentValues): In r183020 I added some logs when compiling or removing content extensions fails. We often try to remove a content extension that does not exist, and that is not a problem. 2015-04-17 Matthew Hanson <matthew_hanson@apple.com> prepare-ChangeLog should ignore the preceeding function when processing the removal of a function. https://bugs.webkit.org/show_bug.cgi?id=143897 Reviewed by David Kilzer. This is a speculative fix that addresses two issues: 1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete. We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1. So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs: Before: (723, 729) After: (721, 720) Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk. Whether there are zero lines or one line in the hunk, the starting and ending line are the same. This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output. The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former. 2. Creating git diffs from HEAD and not origin/master by default. Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods. * Scripts/prepare-ChangeLog: (originalFile): Use HEAD instead of origin/master in default Git case. (generateFunctionLists): Ensure that the end line is not less than the start line. (extractLineRangeAfterChange): Set the end line to the start line if the end line is less than the start line. (extractLineRangeBeforeChange): Ditto. 2015-04-17 Matthew Hanson <matthew_hanson@apple.com> Suppress warning in prepare-ChangeLog. https://bugs.webkit.org/show_bug.cgi?id=143882 Reviewed by David Kilzer. Prune noisy prepare-ChangeLog output by using the List::Util::any function instead of the deprecated smartmatch operator. * Scripts/prepare-ChangeLog: Import the List::Util::any function. (get_function_line_ranges_for_cpp): Use the any function instead of smartmatch. 2015-04-20 Anders Carlsson <andersca@apple.com> Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask https://bugs.webkit.org/show_bug.cgi?id=143966 Reviewed by Dan Bernstein. * MiniBrowser/mac/WK2BrowserWindowController.m: (dataTypes): (-[WK2BrowserWindowController fetchWebsiteData:]): (-[WK2BrowserWindowController fetchAndClearWebsiteData:]): (-[WK2BrowserWindowController clearWebsiteData:]): 2015-04-20 Alex Christensen <achristensen@webkit.org> Fix content extension test flakiness. https://bugs.webkit.org/show_bug.cgi?id=143950 Reviewed by Brady Eidson. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformResetPreferencesToConsistentValues): Remove the TestContentExtensions if it exists. (WTR::TestController::platformConfigureViewForTest): Log errors in case there are any. 2015-04-20 Alex Christensen <achristensen@webkit.org> Properly report errors from _WKUserContentExtensionStore. https://bugs.webkit.org/show_bug.cgi?id=143808 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: (TEST_F): 2015-04-20 Carlos Garcia Campos <cgarcia@igalia.com> Add a rule for NetworkCache to watchlist file https://bugs.webkit.org/show_bug.cgi?id=143945 Reviewed by Sergio Villar Senin. And add myself to the list of watchers. * Scripts/webkitpy/common/config/watchlist: 2015-04-19 Darin Adler <darin@apple.com> Update RefPtr documentation and deprecation https://bugs.webkit.org/show_bug.cgi?id=143936 Reviewed by Andreas Kling. * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames. 2015-04-19 Yusuke Suzuki <utatane.tea@gmail.com> Introduce bytecode intrinsics https://bugs.webkit.org/show_bug.cgi?id=143926 Reviewed by Filip Pizlo. Change cpplint to accept emit_intrinsic_XXX. * Scripts/webkitpy/style/checkers/cpp.py: (check_identifier_name_in_declaration): 2015-04-18 Simon Fraser <simon.fraser@apple.com> Fix lldb_webkit.py to show StringImpls correctly https://bugs.webkit.org/show_bug.cgi?id=143920 Reviewed by Andreas Kling. Update WTFStringImplProvider's is_8bit to use the correct bitmask. * lldb/lldb_webkit.py: (WTFStringImplProvider.is_8bit): 2015-04-17 Daniel Bates <dabates@apple.com> Not able to build WebKit against iOS Simulator 8.3 SDK https://bugs.webkit.org/show_bug.cgi?id=143883 Reviewed by David Kilzer. Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory so that Xcode uses them. * Scripts/copy-webkitlibraries-to-product-directory: 2015-04-17 Beth Dakin <bdakin@apple.com> Force mouse events should go through normal mouse event handling code paths https://bugs.webkit.org/show_bug.cgi?id=143749 -and corresponding- rdar://problem/20472895 Reviewed by Dean Jackson. Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. Since there is not a way to create an NSEventTypePressure from scratch, we subclass NSEvent and override all of the critical methods. * WebKitTestRunner/EventSenderProxy.h: * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::mouseForceDown): (WTR::EventSendingController::mouseForceUp): (WTR::EventSendingController::mouseForceChanged): * WebKitTestRunner/InjectedBundle/EventSendingController.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): * WebKitTestRunner/mac/EventSenderProxy.mm: (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]): (-[EventSenderPressureEvent timestamp]): (-[EventSenderPressureEvent type]): (-[EventSenderPressureEvent locationInWindow]): (-[EventSenderPressureEvent location]): (-[EventSenderPressureEvent stage]): (-[EventSenderPressureEvent pressure]): (-[EventSenderPressureEvent phase]): (-[EventSenderPressureEvent eventNumber]): (WTR::EventSenderProxy::mouseForceDown): (WTR::EventSenderProxy::mouseForceUp): (WTR::EventSenderProxy::mouseForceChanged): 2015-04-17 Alexey Proskuryakov <ap@apple.com> build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes https://bugs.webkit.org/show_bug.cgi?id=143885 Reviewed by Tim Horton. Fixed a case where we have two builds with the same revision(s). An in order build is one for which the revision is strictly higher. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue.prototype._checkForInOrderResult): (BuildbotQueue.prototype.compareIterationsByRevisions): 2015-04-17 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r182912 and r182920. https://bugs.webkit.org/show_bug.cgi?id=143881 Build breakage in some configurations (Requested by ap on #webkit). Reverted changesets: "Force mouse events should go through normal mouse event handling code paths" https://bugs.webkit.org/show_bug.cgi?id=143749 http://trac.webkit.org/changeset/182912 http://trac.webkit.org/changeset/182920 2015-04-17 Csaba Osztrogonác <ossy@webkit.org> [GTK] One more unreviewed fix after r182882. * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency. 2015-04-17 Csaba Osztrogonác <ossy@webkit.org> [GTK] Unreviewed speculative clean build fix after r182882. TestWebKitAPI's forwarding header generator depended on WeKit2's which generated SOUP related forwarding headers too. This dependency isn't necessary and was removed by r182882 to make forwarding header generators parallelizable. But in this case TestWebKitAPI's and WebKitTestRunner's forwarding header generator should generate SOUP related forwarding headers too similar to EFL. * TestWebKitAPI/PlatformGTK.cmake: * WebKitTestRunner/PlatformGTK.cmake: 2015-04-17 Carlos Garcia Campos <cgarcia@igalia.com> [SOUP] Redirect to non HTTP destination is broken https://bugs.webkit.org/show_bug.cgi?id=143866 Reviewed by Sergio Villar Senin. Add a unit test to check that redirect to a data URI works. * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: (testRedirectToDataURI): (serverCallback): (beforeAll): 2015-04-16 Jake Nielsen <jacob_nielsen@apple.com> Changes method of quitting iOS Simulator to be more correct. https://bugs.webkit.org/show_bug.cgi?id=143847 <rdar://problem/20530344> Reviewed by Darin Adler. Fixes by addressing the app by ID rather than by name. * Scripts/webkitdirs.pm: (quitIOSSimulator): * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.check_sys_deps): 2015-04-16 Anders Carlsson <andersca@apple.com> Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore https://bugs.webkit.org/show_bug.cgi?id=143844 Reviewed by Dan Bernstein. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate newPrivateWindow:]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController initWithConfiguration:]): (-[WK2BrowserWindowController fetchWebsiteData:]): (-[WK2BrowserWindowController fetchAndClearWebsiteData:]): (-[WK2BrowserWindowController clearWebsiteData:]): 2015-04-16 Alex Christensen <achristensen@webkit.org> 32-bit build fix. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformResetPreferencesToConsistentValues): (WTR::TestController::platformConfigureViewForTest): Added WK_API_ENABLED. 2015-04-16 Alex Christensen <achristensen@webkit.org> Removed unused WKUserContentFilterRef. https://bugs.webkit.org/show_bug.cgi?id=143852 Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformResetPreferencesToConsistentValues): (WTR::TestController::platformConfigureViewForTest): 2015-04-16 Jake Nielsen <jacob_nielsen@apple.com> Unreviewed. Adding myself as a commiter in contributers.json. * Scripts/webkitpy/common/config/contributors.json: 2015-04-16 Alexey Proskuryakov <ap@apple.com> It is very hard to attach a debugger to WebProcess to debug tests https://bugs.webkit.org/show_bug.cgi?id=143837 Reviewed by Chris Dumez. --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in WebKitTestRunner, and not pipe reading timeout in run-webkit-tests. Now it disables all timeouts in tools, as is best for debugging tests. * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so that the script doesn't terminate DRT/WKTR when there is no output for a long time. * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout now has the same functionality. 2015-04-16 Beth Dakin <bdakin@apple.com> Force mouse events should go through normal mouse event handling code paths https://bugs.webkit.org/show_bug.cgi?id=143749 -and corresponding- rdar://problem/20472895 Reviewed by Dean Jackson. Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. Since there is not a way to create an NSEventTypePressure from scratch, we subclass NSEvent and override all of the critical methods. * WebKitTestRunner/EventSenderProxy.h: * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::mouseForceDown): (WTR::EventSendingController::mouseForceUp): (WTR::EventSendingController::mouseForceChanged): * WebKitTestRunner/InjectedBundle/EventSendingController.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): * WebKitTestRunner/mac/EventSenderProxy.mm: (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]): (-[EventSenderPressureEvent timestamp]): (-[EventSenderPressureEvent type]): (-[EventSenderPressureEvent locationInWindow]): (-[EventSenderPressureEvent location]): (-[EventSenderPressureEvent stage]): (-[EventSenderPressureEvent pressure]): (-[EventSenderPressureEvent phase]): (-[EventSenderPressureEvent eventNumber]): (WTR::EventSenderProxy::mouseForceDown): (WTR::EventSenderProxy::mouseForceUp): (WTR::EventSenderProxy::mouseForceChanged): 2015-04-16 Csaba Osztrogonác <ossy@webkit.org> [EFL] Bump LLVM to version 3.6.0 on X86_64 https://bugs.webkit.org/show_bug.cgi?id=143604 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch. * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release. * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release. * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64. 2015-04-16 Csaba Osztrogonác <ossy@webkit.org> [EFL] Remove an unnecessary workaround from jhbuildrc https://bugs.webkit.org/show_bug.cgi?id=143823 Reviewed by Gyuyoung Kim. * efl/jhbuildrc: 2015-04-16 Csaba Osztrogonác <ossy@webkit.org> [GTK] Run forwarding headers generator unconditionally https://bugs.webkit.org/show_bug.cgi?id=143819 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/PlatformGTK.cmake: * WebKitTestRunner/PlatformGTK.cmake: 2015-04-15 Gyuyoung Kim <gyuyoung.kim@webkit.org> [EFL] Add gnutls to jhbuild.module https://bugs.webkit.org/show_bug.cgi?id=143777 Reviewed by Csaba Osztrogonác. EFL port has required at least 3.0.0 version of gnutls since r176712. However some old linux distributions don't support 3.0.0 version. Besides other projects sometimes need to use lower version of gnutls. This patch supports to download gnutls through jhbuild, and use it. * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version. 2015-04-15 Mark Lam <mark.lam@apple.com> Remove obsolete VMInspector debugging tool. https://bugs.webkit.org/show_bug.cgi?id=143798 Reviewed by Michael Saboff. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed. 2015-04-15 Jer Noble <jer.noble@apple.com> Unreviewed gardening; Make the previous commit apply only _post_ Yosemite. * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: 2015-04-15 Jer Noble <jer.noble@apple.com> Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite. * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: (TestWebKitAPI::TEST_F): 2015-04-15 Chris Dumez <cdumez@apple.com> [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests https://bugs.webkit.org/show_bug.cgi?id=143779 Reviewed by Brent Fulgham. Reset the 'UsesPageCache' setting to FALSE between tests on Windows, similarly to what is done on Mac / WK1. Without this, PageCache could stay enabled after page cache tests and cause weird behaviors. * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): 2015-04-14 Simon Fraser <simon.fraser@apple.com> Re-enable custom dilation for antialiased fonts https://bugs.webkit.org/show_bug.cgi?id=143738 Reviewed by Tim Horton. Enabling custom dilation for antialised fonts broke layout tests, so re-land it, but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding a private WebKit pref. This pref defaults to YES, enabling the feature by default in WK1 as we do for WK2. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): 2015-04-14 Brent Fulgham <bfulgham@apple.com> Correct layering violation in DumpRenderTree Build https://bugs.webkit.org/show_bug.cgi?id=143732 Reviewed by Simon Fraser. Correct a layering violation in DumpRenderTree by calling functions on the WebCoreTestSupport library, rather than attempting to work with WebCore types directly. * DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather than WebCore itself., (-[EventSendingController callAfterScrollingCompletes:]): Ditto. 2015-04-14 Benjamin Poulain <benjamin@webkit.org> Add a conservative DFA minimizer for the content extension matcher https://bugs.webkit.org/show_bug.cgi?id=143501 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp: 2015-04-14 Daniel Bates <dabates@apple.com> Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS https://bugs.webkit.org/show_bug.cgi?id=143693 <rdar://problem/20530316> Reviewed by Tim Horton. Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan to use the fixed layout code on iOS at this time. * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard. 2015-04-14 Dominik Röttsches <dominik.rottsches@intel.com> Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists https://bugs.webkit.org/show_bug.cgi?id=143705 Unreviewed change to watchlist file. * Scripts/webkitpy/common/config/watchlist: 2015-04-14 KwangHyuk Kim <hyuki.kim@samsung.com> [EFL] favicon wasn't updated for google.com sometimes. https://bugs.webkit.org/show_bug.cgi?id=141940 Reviewed by Gyuyoung Kim. As elm_entry_utf8_to_markup can include additional characters, parameter for the on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get(). * MiniBrowser/efl/main.c: (on_url_changed): 2015-04-13 Tim Horton <timothy_horton@apple.com> Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views https://bugs.webkit.org/show_bug.cgi?id=143560 <rdar://problem/16302047> Reviewed by Darin Adler. * MiniBrowser/mac/BrowserWindowController.h: * MiniBrowser/mac/MainMenu.xib: * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController setScale:]): * MiniBrowser/mac/WK2BrowserWindowController.m: (viewScaleForMenuItemTag): (-[WK2BrowserWindowController setScale:]): (-[WK2BrowserWindowController validateMenuItem:]): Add a submenu with four view scale options: 100%, 75%, 50%, and 25%. When in use, we resize the window so that the view fits correctly, and use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's layout size will not change when scaling down (but will update appropriately when the view is resized). 2015-04-13 Alexey Proskuryakov <ap@apple.com> build.webkit.org/dashboard shows obsolete results when builds are substantially out of order https://bugs.webkit.org/show_bug.cgi?id=138630 Reviewed by Tim Horton. Make sure that we always load at least one in order productive iteration. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue is done loading at least one iteration that wasn't an out of order build. (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load when that's needed to check for out of order builds. (BuildbotQueue.prototype.update): Ditto. (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order result, and if it does not, load more iterations. (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have an in order iteration loaded too. (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and corrected to always sort loaded iterations before unloaded ones. 2015-04-10 Brent Fulgham <bfulgham@apple.com> Expand test infrastructure to support scrolling tests https://bugs.webkit.org/show_bug.cgi?id=143286 <rdar://problem/20375516> Reviewed by Simon Fraser. Extend the WK1 and WK2 test programs to support two new EventSender commands: (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations. (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that relevant rubberband, scroll, and scroll-snap animations are finished. * DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:' and 'monitorWheelEvents'. (+[EventSendingController webScriptNameForSelector:]): Ditto. (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when debugging test failures. (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto. (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback function, then passes it to WebCore to be called once the test deferrals have been cleared. (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the 'callAfterScrollingCompletes' method. * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes' and 'monitorWheelEvents'. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the callback function, then passes it to WebCore to be called once the test deferrals have been cleared (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the 'callAfterScrollingComplates' method. * WebKitTestRunner/InjectedBundle/EventSendingController.h: 2015-04-13 Alexey Proskuryakov <ap@apple.com> build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start https://bugs.webkit.org/show_bug.cgi?id=143656 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): 2015-04-13 Sergio Villar Senin <svillar@igalia.com> REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134 https://bugs.webkit.org/show_bug.cgi?id=142387 Reviewed by Carlos Garcia Campos. Running mixed content is blocked by default since r181134. Updated the test case to reflect the new default settings. * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: (testInsecureContent): 2015-04-13 Gyuyoung Kim <gyuyoung.kim@webkit.org> Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY https://bugs.webkit.org/show_bug.cgi?id=143667 Reviewed by Csaba Osztrogonác. ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable since r169017. Added $hardwareConcurrencySupport for it. Additionally networkInfoSupport is removed because this feature was removed due to spec out. * Scripts/webkitperl/FeatureList.pm: 2015-04-13 Csaba Osztrogonác <ossy@webkit.org> [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system https://bugs.webkit.org/show_bug.cgi?id=143664 Reviewed by Gyuyoung Kim. * Scripts/webkitperl/FeatureList.pm: 2015-04-12 Gyuyoung Kim <gyuyoung.kim@webkit.org> [EFL] Enable Media Source https://bugs.webkit.org/show_bug.cgi?id=143635 Reviewed by Csaba Osztrogonác. * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port. 2015-04-12 Alexey Proskuryakov <ap@apple.com> build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded https://bugs.webkit.org/show_bug.cgi?id=143646 Reviewed by David Kilzer. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): 2015-04-11 Alexey Proskuryakov <ap@apple.com> Use en_US spell checker for tests on Mac instead of Multilingual https://bugs.webkit.org/show_bug.cgi?id=143641 Reviewed by Dan Bernstein. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): While at it, override NSUserDictionaryReplacementItems, so that user replacements cannot affect tests. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize): Made this more like WebKit1 version. 2015-04-10 Tim Horton <timothy_horton@apple.com> Replace setFixedLayoutSizeEnabled: with an enum of layout modes https://bugs.webkit.org/show_bug.cgi?id=143576 Reviewed by Simon Fraser. * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: (TEST): Adopt. 2015-04-09 Gyuyoung Kim <gyuyoung.kim@webkit.org> Update my email address and expertise. https://bugs.webkit.org/show_bug.cgi?id=143586 Unreviewed, just update my info. * Scripts/webkitpy/common/config/contributors.json: 2015-04-09 Joseph Pecoraro <pecoraro@apple.com> Flakiness Dashboard not loading insecure content if loaded with https URL https://bugs.webkit.org/show_bug.cgi?id=143570 Reviewed by Alexey Proskuryakov. * TestResultServer/app.yaml: * TestResultServer/static-dashboards/loader.js: Switch to https scheme. 2015-04-09 Csaba Osztrogonác <ossy@webkit.org> [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times https://bugs.webkit.org/show_bug.cgi?id=142907 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/PlatformEfl.cmake: * TestWebKitAPI/PlatformGTK.cmake: * WebKitTestRunner/PlatformEfl.cmake: * WebKitTestRunner/PlatformGTK.cmake: 2015-04-08 Brent Fulgham <bfulgham@apple.com> [Mac] Unreviewed test fix after r182584 https://bugs.webkit.org/show_bug.cgi?id=143452 Put both of these tests back to their original state now that the underlying problem is fixed. * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: (TestWebKitAPI::TEST): 2015-04-08 Filip Pizlo <fpizlo@apple.com> run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice https://bugs.webkit.org/show_bug.cgi?id=143553 Reviewed by Ryosuke Niwa. Remove the spurious printVMs left over from an earlier change. * Scripts/run-jsc-benchmarks: 2015-04-08 Brent Fulgham <bfulgham@apple.com> [Mac] Unreviewed test fix after r182581 The behavior of control-left-click is controlled by a system preference. Our test bots have this turned off. * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: (TestWebKitAPI::TEST): 2015-04-08 Brent Fulgham <bfulgham@apple.com> [Mac] WebKit is not honoring OS preferences for secondary click behaviors https://bugs.webkit.org/show_bug.cgi?id=143452 <rdar://problem/20437483> Reviewed by Tim Horton. Add a new API test to confirm that Cocoa mouse button press events are properly tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.) The WK2 test dispatches mouse down events to a PlatformWebView, and checks with some registered event handlers that the expected button press and context menu events are received. The WK1 unit test creates an NSEvent with the desired button press state, and then uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event. We check the resulting PlatformMouseEvent for proper state. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files. * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added. (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test. * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added. * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added. (TestWebKitAPI::canCallMenuTypeForEvent): Helper function. (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test. * TestWebKitAPI/mac/PlatformWebViewMac.mm: (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing mouse down events. * TestWebKitAPI/mac/PlatformWebViewMac.h: 2015-04-08 Michael Catanzaro <mcatanzaro@igalia.com> [GTK] Add pango to jhbuild-optional.modules https://bugs.webkit.org/show_bug.cgi?id=143537 Reviewed by Martin Robinson. * gtk/jhbuild-optional.modules: Add pango. 2015-04-08 Carlos Alberto Lopez Perez <clopez@igalia.com> [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22. https://bugs.webkit.org/show_bug.cgi?id=143530 Reviewed by Žan Doberšek. Assume that the default value for display (:0) is reserved and start checking on :1 Adjust webkitpy test and include two new test cases for this bug (display number not specified) and for X server named Xorg.bin (previous bug 1376599) * Scripts/webkitpy/port/xvfbdriver.py: (XvfbDriver._next_free_display) * Scripts/webkitpy/port/xvfbdriver_unittest.py: (XvfbDriverTest.test_start_no_pixel_tests): (XvfbDriverTest.test_start_pixel_tests): (XvfbDriverTest.test_start_arbitrary_worker_number): (XvfbDriverTest.test_next_free_display): (XvfbDriverTest.test_start_next_worker): 2015-04-08 Alex Christensen <achristensen@webkit.org> Block popups from content extensions. https://bugs.webkit.org/show_bug.cgi?id=143497 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): Added popup test. 2015-04-08 Alex Christensen <achristensen@webkit.org> and Patrick Gansterer <paroga@webkit.org> Add CMake build system for WinCairo port. https://bugs.webkit.org/show_bug.cgi?id=115944 Reviewed by Chris Dumez. * CMakeLists.txt: * WinLauncher/CMakeLists.txt: Added. 2015-04-08 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user https://bugs.webkit.org/show_bug.cgi?id=143521 Reviewed by Martin Robinson. Add a way to detect unexpected web process crashes to WebViewTest, and a test case to testDOMCache to trigger the crash. * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: (WebKitDOMNodeTest::testDOMCache): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: (testWebKitWebViewProcessCrashed): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::WebViewTest): (WebViewTest::webProcessCrashed): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: 2015-04-07 Alexey Proskuryakov <ap@apple.com> PageVisibilityStateWithWindowChanges should only be enabled on Yosemite rdar://problem/20461342 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: 2015-04-07 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r182511. https://bugs.webkit.org/show_bug.cgi?id=143507 caused debug test failures (Requested by alexchristensen on #webkit). Reverted changeset: "Block popups from content extensions." https://bugs.webkit.org/show_bug.cgi?id=143497 http://trac.webkit.org/changeset/182511 2015-04-07 Alex Christensen <achristensen@webkit.org> Block popups from content extensions. https://bugs.webkit.org/show_bug.cgi?id=143497 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): Added popup test. 2015-04-07 Benjamin Poulain <benjamin@webkit.org> Get the features.json files ready for open contributions https://bugs.webkit.org/show_bug.cgi?id=143436 Reviewed by Darin Adler. * Scripts/webkitpy/style/checkers/jsonchecker.py: (JSONFeaturesChecker.check): Extend the syntax checking a bit, but leave everything non-mandatory very loose until we figure what fields are important. 2015-04-07 Tim Horton <timothy_horton@apple.com> Expose and test fixedLayoutSize via modern WebKit SPI https://bugs.webkit.org/show_bug.cgi?id=143500 Reviewed by Simon Fraser. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added. (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]): (TEST): Add a test that verifies that fixedLayoutSize works at all, that it persists through a navigation, and that turning it back off reverts to laying out at the size of the view. 2015-04-07 Michael Catanzaro <mcatanzaro@igalia.com> Unreviewed. Add myself as a committer. * Scripts/webkitpy/common/config/contributors.json: 2015-04-07 Brent Fulgham <bfulgham@apple.com> [Win] Bots complain about missing /etc/catalog https://bugs.webkit.org/show_bug.cgi?id=143484 Reviewed by Chris Dumez. The libxml2 build on Mac, iOS, and Windows does not provide the set of default catalog files. We do not actually need these for our purposes, but we get warnings and some bot flakiness because they are not present. We can avoid both problems the same way the Mac and iOS ports do, by setting the XML_CATALOG_FILES environment variable to 'empty string', which avoid the warnings and bot problems. * Scripts/webkitpy/port/win.py: (WinPort.setup_environ_for_server): Added. 2015-04-06 Sam Weinig <sam@webkit.org> Use content extensions in MiniBrowser. https://bugs.webkit.org/show_bug.cgi?id=143446 Reviewed by Alex Christensen. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: * MiniBrowser/mac/AppDelegate.h: * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate init]): (-[BrowserAppDelegate showExtensionsManager:]): (-[BrowserAppDelegate userContentContoller]): * MiniBrowser/mac/ExtensionManagerWindowController.h: Added. * MiniBrowser/mac/ExtensionManagerWindowController.m: Added. (-[ExtensionManagerWindowController init]): (-[ExtensionManagerWindowController windowDidLoad]): (-[ExtensionManagerWindowController add:]): (-[ExtensionManagerWindowController remove:]): * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added. * MiniBrowser/mac/MainMenu.xib: 2015-04-07 Youenn Fablet <youenn.fablet@crf.canon.fr> web-platform-tests server should retrieve the modules file relatively to its docroot path https://bugs.webkit.org/show_bug.cgi?id=142742 Reviewed by Darin Adler. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path. 2015-04-06 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r182445. https://bugs.webkit.org/show_bug.cgi?id=143459 broke 32 bit build (Requested by alexchristensen on #webkit). Reverted changeset: "Use content extensions in MiniBrowser." https://bugs.webkit.org/show_bug.cgi?id=143446 http://trac.webkit.org/changeset/182445 2015-04-06 Sam Weinig <sam@webkit.org> Use content extensions in MiniBrowser. https://bugs.webkit.org/show_bug.cgi?id=143446 Reviewed by Alex Christensen. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: * MiniBrowser/mac/AppDelegate.h: * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate init]): (-[BrowserAppDelegate showExtensionsManager:]): (-[BrowserAppDelegate userContentContoller]): * MiniBrowser/mac/ExtensionManagerWindowController.h: Added. * MiniBrowser/mac/ExtensionManagerWindowController.m: Added. (-[ExtensionManagerWindowController init]): (-[ExtensionManagerWindowController windowDidLoad]): (-[ExtensionManagerWindowController add:]): (-[ExtensionManagerWindowController remove:]): * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added. * MiniBrowser/mac/MainMenu.xib: 2015-04-06 Michael Catanzaro <mcatanzaro@gnome.org> [GTK] install-dependencies should prefer dnf to yum https://bugs.webkit.org/show_bug.cgi?id=143441 Reviewed by Martin Robinson. Test for the existance of dnf before yum, and only try to use yum if dnf does not exist. * gtk/install-dependencies: 2015-04-06 Andy Estes <aestes@apple.com> [iOS] 'make clean' fails in Tools/WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=143455 Reviewed by Dan Bernstein. This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets. * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds. 2015-04-06 Alexey Proskuryakov <ap@apple.com> WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines https://bugs.webkit.org/show_bug.cgi?id=143450 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST): Make sure that the view is actually closed, regardless of anything else that happens beneath. Also, removed unnecessary get() calls. 2015-04-03 Alexey Proskuryakov <ap@apple.com> Reduce the dependency on Flash in regression tests https://bugs.webkit.org/show_bug.cgi?id=143391 Reviewed by Anders Carlsson. * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad): Only allow QuickTime and the test plug-in. 2015-04-06 Youenn Fablet <youenn.fablet@crf.canon.fr> W3C test importer should generate the modules installed dynamically to run wpt tests https://bugs.webkit.org/show_bug.cgi?id=142738 Reviewed by Ryosuke Niwa. The test importer can now generate the submodules description file based on information extracted from the corresponding git repository. The implementation is done within TestDownloader and it is activated for the WPT repository. LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (WebPlatformTestServer._install_modules): Updated to cope with path as array. * Scripts/webkitpy/w3c/test_downloader.py: (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests. (TestDownloader): (TestDownloader._git_submodules_description): Computes submodule description. (TestDownloader.generate_git_submodules_description): Write submodule description in a file. * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.do_import): Added the possibility to post process the tests. (TestImporter): (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file. (TestImporter.should_convert_test_harness_links): Updated according new options format. * Scripts/webkitpy/w3c/test_importer_unittest.py: (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering. (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__): (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status): (TestImporterTest.test_submodules_generation): Added to check that modules description files works. 2015-04-05 Antti Koivisto <antti@apple.com> Bloom filter should support longer hashes https://bugs.webkit.org/show_bug.cgi?id=143419 Reviewed by Dan Bernstein. * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: (TestWebKitAPI::generateRandomDigests): (TestWebKitAPI::TEST): 2015-04-03 Csaba Osztrogonác <ossy@webkit.org> run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux https://bugs.webkit.org/show_bug.cgi?id=143372 Reviewed by Darin Adler. * Scripts/run-jsc-stress-tests: 2015-04-03 Antti Koivisto <antti@apple.com> Add non-counting bloom filter class https://bugs.webkit.org/show_bug.cgi?id=143366 Reviewed by Sam Weinig. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added. (TestWebKitAPI::generateRandomHashes): (TestWebKitAPI::TEST): 2015-04-03 Csaba Osztrogonác <ossy@webkit.org> FTL JIT tests should fail if LLVM library isn't available https://bugs.webkit.org/show_bug.cgi?id=143374 Reviewed by Mark Lam. * Scripts/run-jsc-stress-tests: 2015-04-03 Csaba Osztrogonác <ossy@webkit.org> [EFL] Speedup jhbuild with disable running autogen.sh https://bugs.webkit.org/show_bug.cgi?id=143369 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: 2015-04-01 Alexey Proskuryakov <ap@apple.com> filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines https://bugs.webkit.org/show_bug.cgi?id=143282 Reviewed by Daniel Bates. * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it. 2015-04-01 Alexey Proskuryakov <ap@apple.com> When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures https://bugs.webkit.org/show_bug.cgi?id=143240 rdar://problem/19990425 Reviewed by Tim Horton. * DumpRenderTree/mac/LayoutTestHelper.m: (colorProfileURLForDisplay): (saveDisplayColorProfiles): Gracefully handle it when the current profile cannot be retrieved, fixing at least one case when LayoutTestHelper couldn't start. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._set_up_run): (Manager._force_pixel_tests_if_needed): * Scripts/webkitpy/port/base.py: (Port.to.start_helper): * Scripts/webkitpy/port/mac.py: (MacPort.start_helper): Return and check an error from start_helper(). 2015-04-01 Brent Fulgham <bfulgham@apple.com> [Win] Run test-webkitpy as part of EWS (just like we do on other platforms) https://bugs.webkit.org/show_bug.cgi?id=143321 Reviewed by Alexey Proskuryakov. * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop. 2015-04-01 Enrica Casucci <enrica@apple.com> Injected bundle messages should be at the page level. https://bugs.webkit.org/show_bug.cgi?id=143283 Reviewed by Alexey Proskuryakov. Updating WebKitTestRunner to use the new page level messaging. The author of this patch is Tim Horton, I just finished it. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::mouseDown): (WTR::EventSendingController::mouseUp): (WTR::EventSendingController::mouseMoveTo): (WTR::EventSendingController::leapForward): (WTR::EventSendingController::scheduleAsynchronousClick): (WTR::EventSendingController::keyDown): (WTR::EventSendingController::scheduleAsynchronousKeyDown): (WTR::EventSendingController::mouseScrollBy): (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): (WTR::EventSendingController::continuousMouseScrollBy): (WTR::EventSendingController::addTouchPoint): (WTR::EventSendingController::updateTouchPoint): (WTR::EventSendingController::setTouchModifier): (WTR::EventSendingController::setTouchPointRadius): (WTR::EventSendingController::touchStart): (WTR::EventSendingController::touchMove): (WTR::EventSendingController::touchEnd): (WTR::EventSendingController::touchCancel): (WTR::EventSendingController::clearTouchPoints): (WTR::EventSendingController::releaseTouchPoint): (WTR::EventSendingController::cancelTouchPoint): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessage): (WTR::InjectedBundle::didReceiveMessageToPage): (WTR::InjectedBundle::done): (WTR::InjectedBundle::outputText): (WTR::InjectedBundle::postNewBeforeUnloadReturnValue): (WTR::InjectedBundle::postAddChromeInputField): (WTR::InjectedBundle::postRemoveChromeInputField): (WTR::InjectedBundle::postFocusWebView): (WTR::InjectedBundle::postSetBackingScaleFactor): (WTR::InjectedBundle::postSetWindowIsKey): (WTR::InjectedBundle::postSimulateWebNotificationClick): (WTR::InjectedBundle::postSetAddsVisitedLinks): (WTR::InjectedBundle::setGeolocationPermission): (WTR::InjectedBundle::setMockGeolocationPosition): (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError): (WTR::InjectedBundle::setUserMediaPermission): (WTR::InjectedBundle::setCustomPolicyDelegate): (WTR::InjectedBundle::setHidden): (WTR::InjectedBundle::setCacheModel): (WTR::InjectedBundle::shouldProcessWorkQueue): (WTR::InjectedBundle::processWorkQueue): (WTR::InjectedBundle::queueBackNavigation): (WTR::InjectedBundle::queueForwardNavigation): (WTR::InjectedBundle::queueLoad): (WTR::InjectedBundle::queueLoadHTMLString): (WTR::InjectedBundle::queueReload): (WTR::InjectedBundle::queueLoadingScript): (WTR::InjectedBundle::queueNonLoadingScript): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setHandlesAuthenticationChallenges): (WTR::TestRunner::setAuthenticationUsername): (WTR::TestRunner::setAuthenticationPassword): (WTR::TestRunner::secureEventInputIsEnabled): (WTR::TestRunner::setBlockAllPlugins): * WebKitTestRunner/TestController.cpp: (WTR::TestController::createWebViewWithOptions): (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::didReceivePageMessageFromInjectedBundle): (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 2015-04-01 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r182174 and r182177. https://bugs.webkit.org/show_bug.cgi?id=143314 Try to correct EWS failures (Requested by bfulgham on #webkit). Reverted changesets: "Python SCM should be able to retrieve untracked files" https://bugs.webkit.org/show_bug.cgi?id=143135 http://trac.webkit.org/changeset/182174 "[buildbot] clean-build script should remove untracked files and revert local changes too" https://bugs.webkit.org/show_bug.cgi?id=142400 http://trac.webkit.org/changeset/182177 2015-04-01 Alex Christensen <achristensen@webkit.org> [Content Extensions] Properly handle regexes that match everything. https://bugs.webkit.org/show_bug.cgi?id=143281 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::testRequest): (TestWebKitAPI::makeBackend): (TestWebKitAPI::TEST_F): Removed duplicate code and added test. 2015-03-31 Benjamin Poulain <bpoulain@apple.com> Content Extensions: split the state machines to minimize prefix states https://bugs.webkit.org/show_bug.cgi?id=143253 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): (TestWebKitAPI::testPatternStatus): 2015-03-31 Yusuke Suzuki <utatane.tea@gmail.com> Clean up Identifier factories to clarify the meaning of StringImpl* https://bugs.webkit.org/show_bug.cgi?id=143146 Reviewed by Filip Pizlo. Simple API tests for StringImpl are added. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: (TestWebKitAPI::TEST): 2015-03-31 Csaba Osztrogonác <ossy@webkit.org> [EFL] Add AArch64 builder and tester bot to build.webkit.org https://bugs.webkit.org/show_bug.cgi?id=143092 Reviewed by Gyuyoung Kim. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (Factory.__init__): * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: 2015-03-31 Youenn Fablet <youenn.fablet@crf.canon.fr> [buildbot] clean-build script should remove untracked files and revert local changes too https://bugs.webkit.org/show_bug.cgi?id=142400 Reviewed by Ryosuke Niwa. This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files. A helper routine SCM.discard_untracked_files is added for that purpose. * BuildSlaveSupport/clean-build: (main): Making call to Scripts/clean-webkit * Scripts/clean-webkit: Added. (main): Revert changes and delete untracked files. * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (SCMTest._shared_test_discard_untracked_files): (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly. 2015-03-31 Youenn Fablet <youenn.fablet@crf.canon.fr> Python SCM should be able to retrieve untracked files https://bugs.webkit.org/show_bug.cgi?id=143135 Reviewed by Ryosuke Niwa. This patch introduces SCM.untracked_files to retrieve a list of untracked files. Ignored files may be included or not in this list according boolean passed to the function. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.untracked_files): * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.untracked_files): * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (SCMTest._shared_test_untracked_files): (test_untracked_files): (GitSVNTest.test_untracked_files): * Scripts/webkitpy/common/checkout/scm/svn.py: (SVN.untracked_files): 2015-03-30 Alex Christensen <achristensen@webkit.org> [Content Extensions] Correctly handle regular expressions matching everything https://bugs.webkit.org/show_bug.cgi?id=143235 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::checkCompilerError): (TestWebKitAPI::TEST_F): Test ContentExtensionErrors. 2015-03-30 Alexey Proskuryakov <ap@apple.com> DumpRenderTree should set NSWindowDisplayWithRunLoopObserver https://bugs.webkit.org/show_bug.cgi?id=143241 rdar://problem/20351297 Reviewed by Mark Lam. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): 2015-03-30 Gyuyoung Kim <gyuyoung.kim@samsung.com> [CMake][EFL] Remove redundant library link and include path https://bugs.webkit.org/show_bug.cgi?id=143221 Reviewed by Csaba Osztrogonác. * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path. 2015-03-30 Sam Weinig <sam@webkit.org> [Content Extensions] Flesh out the UserContentExtensionStore https://bugs.webkit.org/show_bug.cgi?id=143123 Reviewed by Benjamin Poulain. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added. Add tests for _WKUserContentExtensionStore. 2015-03-30 Marcos Chavarría Teijeiro <chavarria1991@gmail.com> Update install-dependencies Fedora packages after r181624 https://bugs.webkit.org/show_bug.cgi?id=143215 Add json-glib, libv4l, openssl and pulseaudio development packages to the Fedora list providing we need them to build WebKit dependencies for this distribution. Reviewed by Philippe Normand. * gtk/install-dependencies: 2015-03-30 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r182119. https://bugs.webkit.org/show_bug.cgi?id=143196 problem with syntax (Requested by youenn on #webkit). Reverted changeset: "[buildbot] clean-build script should remove untracked files and revert local changes too" https://bugs.webkit.org/show_bug.cgi?id=142400 http://trac.webkit.org/changeset/182119 2015-03-30 Benjamin Poulain <benjamin@webkit.org> Start the features.json files https://bugs.webkit.org/show_bug.cgi?id=143207 Reviewed by Darin Adler. I kept the style checking light. We'll have to figure what is the best format for each field. * Scripts/webkitpy/style/checker.py: (CheckerDispatcher._create_checker): * Scripts/webkitpy/style/checkers/jsonchecker.py: (JSONContributorsChecker.check): (JSONFeaturesChecker): (JSONFeaturesChecker.check): 2015-03-29 Youenn Fablet <youenn.fablet@crf.canon.fr> [buildbot] clean-build script should remove untracked files and revert local changes too https://bugs.webkit.org/show_bug.cgi?id=142400 Reviewed by Ryosuke Niwa. This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files. * BuildSlaveSupport/clean-build: (main): Adding call to Tools/Scripts/clean-webkit. * Scripts/clean-webkit: Added. (main): Removes untracked and changed files. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.untracked_files): Retrieves GIT untracked files. * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.untracked_files): Retrieves SVN untracked files. (SCM): (SCM.discard_untracked_files): Deletes untracked files/folders. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (SCMTest._shared_test_untracked_files): Unit testing for untracked files. (test_untracked_files): (GitSVNTest.test_untracked_files): * Scripts/webkitpy/common/checkout/scm/svn.py: (SVN.untracked_files): 2015-03-27 Gyuyoung Kim <gyuyoung.kim@samsung.com> [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro https://bugs.webkit.org/show_bug.cgi?id=143138 Reviewed by Csaba Osztrogonác. INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS. * ImageDiff/CMakeLists.txt: Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS. * WebKitTestRunner/CMakeLists.txt: ditto. 2015-03-27 Myles C. Maxfield <mmaxfield@apple.com> Support building WTF on Windows without Cygwin https://bugs.webkit.org/show_bug.cgi?id=143084 Reviewed by Brent Fulgham. Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things. This patch also migrates to using File::Spec->catfile() for directory separators. * Scripts/update-webkit-dependency: (wanted): * Scripts/update-webkit-support-libs: (wanted): (downloadExpectedVersionNumber): (zipFileVersion): (toUnixPath): Deleted. * Scripts/webkitdirs.pm: (determineSourceDir): (windowsSourceSourceDir): (windowsLibrariesDir): (windowsOutputDir): (checkInstalledTools): (buildVisualStudioProject): 2015-03-27 Alex Christensen <achristensen@webkit.org> Fix WinCairo bot. https://bugs.webkit.org/show_bug.cgi?id=143086 Reviewed by Brent Fulgham. * Scripts/webkitdirs.pm: (buildVisualStudioProject): (runSvnUpdateAndResolveChangeLogs): Use ActivePerl-friendly perl. 2015-03-27 Csaba Osztrogonác <ossy@webkit.org> URTBF after r182059 to fix the EFL build. * TestWebKitAPI/CMakeLists.txt: 2015-03-26 Alexey Proskuryakov <ap@apple.com> Layout test results URL loads in WK1 but not WK2 minibrowser https://bugs.webkit.org/show_bug.cgi?id=143117 Reviewed by Tim Horton. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and everything. (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto. 2015-03-26 Jer Noble <jer.noble@apple.com> Add --allowed-host support to run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=142938 Reviewed by Brent Fulgham. Accept --allowed-host arguments from run-webkit-tests and pass them through to DumpRenderTree and WebKitTestRunner. Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results are placed in the wrong location. The argument is compared with each tests's path, and if a relative path or a path with '..' was used, results are placed alongside the test. Take the absolute path of the --layout-test-dir argument, collapsing path components like '..'. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): * Scripts/webkitpy/port/base.py: (Port.__init__): (Port.allowed_hosts): * Scripts/webkitpy/port/driver.py: (Driver.cmd_line): 2015-03-26 Jer Noble <jer.noble@apple.com> [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers https://bugs.webkit.org/show_bug.cgi?id=142931 Reviewed by Brent Fulgham. Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at runtime. To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified hostname to a whitelist; requests to these hosts will allowed to proceed normally. Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the top loading frame, which causes a subsequent crash when further resources are requested. Instead, get the top loading frame from the page, as we do elsewhere in this class. * DumpRenderTree/TestRunner.h: (TestRunner::allowedHosts): (TestRunner::setAllowedHosts): * DumpRenderTree/mac/DumpRenderTree.mm: (initializeGlobalsFromCommandLineOptions): (runTest): * DumpRenderTree/mac/ResourceLoadDelegate.mm: (isAllowedHost): (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessage): (WTR::InjectedBundle::isAllowedHost): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::isAllowedHost): (WTR::InjectedBundlePage::willSendRequestForFrame): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/Options.cpp: (WTR::handleOptionAllowedHost): (WTR::OptionsHandler::OptionsHandler): * WebKitTestRunner/Options.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): (WTR::TestController::resetStateToConsistentValues): * WebKitTestRunner/TestController.h: 2015-03-26 Brady Eidson <beidson@apple.com> Apply ContentExtension actions after redirects. <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055 Reviewed by Alex Christensen. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL which is specifically interesting to a new test. 2015-03-26 Csaba Osztrogonác <ossy@webkit.org> [EFL] Disable building libseccomp on AArch64 https://bugs.webkit.org/show_bug.cgi?id=143094 Reviewed by Gyuyoung Kim. * efl/jhbuildrc: 2015-03-26 Csaba Osztrogonác <ossy@webkit.org> [jhbuild] git should use only 1 thread for cloning jhbuild https://bugs.webkit.org/show_bug.cgi?id=143095 Reviewed by Gyuyoung Kim. * jhbuild/jhbuild-wrapper: (clone_jhbuild): 2015-03-25 Joseph Pecoraro <pecoraro@apple.com> Update prepare-ChangeLog to work with ES6 Class syntax https://bugs.webkit.org/show_bug.cgi?id=143069 Reviewed by Timothy Hatcher. * Scripts/prepare-ChangeLog: (get_function_line_ranges_for_javascript): Better handle ES6 Class syntax. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: (BaseClass): (DerivedClass): (DerivedClass.staticMethod): (DerivedClass.prototype.method.nestedFunctionInsideMethod): (DerivedClass.prototype.method): (DerivedClass.prototype.get getter): (namespace.MyClass): (namespace.MyClass.staticMethod): (namespace.MyClass.prototype.method.nestedFunctionInsideMethod): (namespace.MyClass.prototype.method): (namespace.MyClass.prototype.get getter): Proof! 2015-03-25 Filip Pizlo <fpizlo@apple.com> Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC https://bugs.webkit.org/show_bug.cgi?id=142993 Reviewed by Mark Lam. Bunch of support for testing executable allocation failure. * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added. (fail): * Scripts/run-javascriptcore-tests: (runJSCStressTests): * Scripts/run-jsc-stress-tests: 2015-03-25 Myles C. Maxfield <mmaxfield@apple.com> Fix Windows build from r181977. Unreviewed. * Scripts/update-webkit-dependency: 2015-03-25 Sam Weinig <sam@webkit.org> Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter): 2015-03-25 Myles C. Maxfield <mmaxfield@apple.com> Migrate update-webkit for Windows to not require Cygwin https://bugs.webkit.org/show_bug.cgi?id=143040 Reviewed by Brent Fulgham. * Scripts/update-webkit-dependency: (wanted): (toUnixPath): Deleted. * Scripts/webkitdirs.pm: (fontExists): (checkInstalledTools): (setupAppleWinEnv): 2015-03-25 Sam Weinig <sam@webkit.org> [Content Extensions] Convert content extension compiling to return error codes and write its output using a client https://bugs.webkit.org/show_bug.cgi?id=143059 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter): Update for new interface of compileRuleList(). 2015-03-25 Alex Christensen <achristensen@webkit.org> [Content Extensions] Add multi-DFA compiling and interpreting. https://bugs.webkit.org/show_bug.cgi?id=143010 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::testRequest): (TestWebKitAPI::TEST_F): Add some tests for ignore-previous-rules and large rulesets. 2015-03-25 Alexey Proskuryakov <ap@apple.com> Mavericks WK1 still runs JSC tests https://bugs.webkit.org/show_bug.cgi?id=143035 Reviewed by Csaba Osztrogonác. * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line with other bots. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests accordingly. 2015-03-25 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r181932. https://bugs.webkit.org/show_bug.cgi?id=143041 The test fails most of the time on bots (Requested by ap on #webkit). Reverted changeset: "[Content Extensions] Add multi-DFA compiling and interpreting." https://bugs.webkit.org/show_bug.cgi?id=143010 http://trac.webkit.org/changeset/181932 2015-03-24 Alex Christensen <achristensen@webkit.org> [Content Extensions] Add multi-DFA compiling and interpreting. https://bugs.webkit.org/show_bug.cgi?id=143010 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::testRequest): (TestWebKitAPI::TEST_F): Add some tests for ignore-previous-rules and large rulesets. 2015-03-24 Benjamin Poulain <bpoulain@apple.com> Make URL filter patterns matching consistent and add a simple canonicalization step https://bugs.webkit.org/show_bug.cgi?id=142998 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: 2015-03-24 Csaba Osztrogonác <ossy@webkit.org> [EFL] Add OpenWebRTC in jhbuild https://bugs.webkit.org/show_bug.cgi?id=142778 Reviewed by Gyuyoung Kim. Original patch by Philippe Normand <pnormand@igalia.com> * efl/install-dependencies: Dependencies for OpenWebRTC. * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and the openwebrtc gst plugins. 2015-03-23 Brent Fulgham <bfulgham@apple.com> Regression(r181257): WTF_WorkQueue.Simple is flaky https://bugs.webkit.org/show_bug.cgi?id=142560 Remove the check that the refCount has returned to one after the individual tasks have completed. It's too nondeterministic when the reference count will be reduced. Reviewed by Alexey Proskuryakov * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: (TestWebKitAPI::TEST): Remove test that refCount is back to 1. 2015-03-23 Gyuyoung Kim <gyuyoung.kim@samsung.com> [CMake][EFL] Put failure API test excutables into failure directory https://bugs.webkit.org/show_bug.cgi?id=142965 Reviewed by Csaba Osztrogonác. Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory. * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*. * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test. 2015-03-22 Benjamin Poulain <benjamin@webkit.org> CSS Selectors: fix attribute case-insensitive matching of Contain and List https://bugs.webkit.org/show_bug.cgi?id=142932 Reviewed by Darin Adler. Add tests for the new features and fix some existing tests using the stringFromUTF8() utility recently added by Dhi. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: (TestWebKitAPI::stringFromUTF8): * TestWebKitAPI/Tests/WTF/StringView.cpp: 2015-03-22 Michael Catanzaro <mcatanzaro@igalia.com> [GTK] install-dependencies should install orc https://bugs.webkit.org/show_bug.cgi?id=142955 Reviewed by Martin Robinson. Install orc, needed by openwebrtc * gtk/install-dependencies: 2015-03-22 Benjamin Poulain <bpoulain@apple.com> Detect when url filter pattern with groups match the empty string https://bugs.webkit.org/show_bug.cgi?id=142930 Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: 2015-03-22 Anders Carlsson <andersca@apple.com> _WKWebsiteDataStore should clear WebSQL databases https://bugs.webkit.org/show_bug.cgi?id=142947 Reviewed by Sam Weinig. Add a variable that keeps track of the types of data we want to operate on, for easier debugging. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController fetchWebsiteData:]): (-[WK2BrowserWindowController fetchAndClearWebsiteData:]): (-[WK2BrowserWindowController clearWebsiteData:]): 2015-03-20 Mark Hahnenberg <mhahnenb@gmail.com> GCTimer should know keep track of nested GC phases https://bugs.webkit.org/show_bug.cgi?id=142675 Reviewed by Darin Adler. Adds a tool to aid in parsing the GC phase timing output into a tree-like structure based on the parent-child relationships of nested GC phases. * Scripts/parse-gc-phase-timings: Added. (Timing): (Timing.__init__): (Timing.__unicode__): (Timing.__str__): (Timing.__repr__): (parse_input): (print_timing_node): (print_timing_tree): (link_parents): (main): 2015-03-20 Brent Fulgham <bfulgham@apple.com> [Win] Temporarily turn of EWS Windows tests while I debug the test failure. * Scripts/webkitpy/common/config/ews.json: 2015-03-20 Philippe Normand <pnormand@igalia.com> [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository https://bugs.webkit.org/show_bug.cgi?id=142867 Rubber-stamped by Csaba Osztrogon. * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use a fixed revision for the openwebrtc-gst-plugins. 2015-03-19 Ryosuke Niwa <rniwa@webkit.org> Unreviewed build fix. Don't try to report stats for all benchmarks. Just report the geometric mean of preferred means. * Scripts/run-jsc-benchmarks: 2015-03-19 Ryosuke Niwa <rniwa@webkit.org> run-jsc-benchmarks should only report preferred mean https://bugs.webkit.org/show_bug.cgi?id=142874 Reviewed by Geoffrey Garen. Just collect statistics for the preferred mean. * Scripts/run-jsc-benchmarks: 2015-03-19 Alex Christensen <achristensen@webkit.org> [Content Extensions] Test regular expression parse failures. https://bugs.webkit.org/show_bug.cgi?id=142872 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::testPatternStatus): (TestWebKitAPI::TEST_F): Added tests for each parsing status. 2015-03-19 Alex Christensen <achristensen@webkit.org> Fix API tests after r181754. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::testRequest): 2015-03-19 Brady Eidson <beidson@apple.com> Part of content extensions should apply css selectors https://bugs.webkit.org/show_bug.cgi?id=142604 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (WebCore::ContentExtensions::operator<<): 2015-03-19 Brent Fulgham <bfulgham@apple.com> [Win] Activate tests on EWS https://bugs.webkit.org/show_bug.cgi?id=142850 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/common/config/ews.json: Add me as the EWS bot watcher, and activate tests. 2015-03-19 Csaba Osztrogonác <ossy@webkit.org> [GTK] Fix inspector userinterface related incremental build issue https://bugs.webkit.org/show_bug.cgi?id=142849 Reviewed by Carlos Garcia Campos. * Scripts/webkitdirs.pm: (shouldRemoveCMakeCache): 2015-03-18 Alex Christensen <achristensen@webkit.org> [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page. https://bugs.webkit.org/show_bug.cgi?id=142799 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::testPattern): (TestWebKitAPI::TEST_F): Start testing regex failures. 2015-03-18 Dhi Aurrahman <diorahman@rockybars.com> Fix StringView typos after r181525 and r181558 https://bugs.webkit.org/show_bug.cgi?id=142772 Reviewed by Darin Adler. Add some tests in [1] to cover the StringView::startsWith, StringView::startsWithIgnoringASCIICase, StringView::endsWith and StringView::endsWithIgnoringASCIICase implementations. * TestWebKitAPI/Tests/WTF/StringView.cpp: (TestWebKitAPI::TEST): 2015-03-18 Dana Burkart <dburkart@apple.com> Remove extraneous import to fix the build. Unreviewed. * Scripts/webkitpy/port/driver.py: 2015-03-18 Dana Burkart <dburkart@apple.com> ASAN_OPTIONS=allocator_may_return_null=1 needs to be set https://bugs.webkit.org/show_bug.cgi?id=142547 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/port/driver.py: (Driver._setup_environ_for_driver): 2015-03-18 Alexey Proskuryakov <ap@apple.com> Tweak how AppleSystemFontOSSubversion default is added https://bugs.webkit.org/show_bug.cgi?id=142835 Reviewed by Dan Bernstein. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): 2015-03-18 Dan Bernstein <mitz@apple.com> prepare-ChangeLog doesn't understand C string literals split across multiple lines with \ https://bugs.webkit.org/show_bug.cgi?id=142815 Reviewed by Darin Adler. * Scripts/prepare-ChangeLog: (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching quotation mark, use new variable $quotation_mark to remember what we are looking for, and keep consuming the quoted text until the matching quotation mark is reached. Emit the warning only if a line ends without a backslash before the matching quotation mark was found. 2015-03-18 Joseph Pecoraro <pecoraro@apple.com> Remove unused "preprocessor" parameter to sub-CodeGenerators https://bugs.webkit.org/show_bug.cgi?id=142793 Reviewed by Darin Adler. * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: (new): 2015-03-18 Csaba Osztrogonác <ossy@webkit.org> [EFL] Bump gstreamer version to 1.4.4 https://bugs.webkit.org/show_bug.cgi?id=142782 Reviewed by Philippe Normand. * efl/jhbuild.modules: * efl/patches/gst-libav.patch: * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added. * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed. 2015-03-17 Tim Horton <timothy_horton@apple.com> Fix the iOS build. * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: (WTR::InjectedBundle::platformInitialize): 2015-03-17 Dean Jackson <dino@apple.com> check-webkit-style should allow "bool a : 1" https://bugs.webkit.org/show_bug.cgi?id=142794 Reviewed by Brent Fulgham. We should allow member bitfields of the form: bool m_var : 1; It seems that Visual Studio 8 was the last compiler that wasn't happy about not using unsigned here. We already have about 500 cases (in WebCore) where people were ignoring this rule. * Scripts/webkitpy/style/checkers/cpp.py: (check_language): Allow "bool". * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests. (CppStyleTest.test_enum_bitfields): (CppStyleTest.test_plain_integral_bitfields): 2015-03-17 Benjamin Poulain <bpoulain@apple.com> Compile character ranges targeting the same state as range check in the bytecode https://bugs.webkit.org/show_bug.cgi?id=142759 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr> W3C test parser and converter should use test importer host https://bugs.webkit.org/show_bug.cgi?id=142729 Reviewed by Bem Jones-Bey. When instantiated by TestImporter, TestParser and TestConverter are now using the same host. This enables adding more TestImporter unit testing. This patch also ensures that the git object instantiated by TestDownloader is using the same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing. * Scripts/webkitpy/common/system/filesystem_mock.py: (MockFileSystem.copytree): Fixes implementation as it creates a runtime error. * Scripts/webkitpy/w3c/test_downloader.py: (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse. (TestDownloader.checkout_test_repository): Making use of the new git function. * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.find_importable_tests): Adding host as parameter to the parser. (TestImporter.import_tests): Adding host as parameter to the converter. * Scripts/webkitpy/w3c/test_importer_unittest.py: (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests. (TestImporterTest): (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. * Scripts/webkitpy/w3c/test_parser.py: (TestParser.__init__): Adding host as parameter constructor. 2015-03-17 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] WebKitDOM objects leaking https://bugs.webkit.org/show_bug.cgi?id=118788 Reviewed by Darin Adler and Sergio Villar Senin. Update DOMObjectCache unit test to check that DOM objects are also released when new contents are loaded in the web view, and the old document is detached from the frame. * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: (testWebKitDOMObjectCache): * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: (runTest): 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr> W3C test importer default import folder should be LayoutTests/imported/w3c https://bugs.webkit.org/show_bug.cgi?id=142728 Reviewed by Bem Jones-Bey. * Scripts/webkitpy/w3c/test_importer.py: (parse_args): Updating the default destination option value to 'imported/w3c'. 2015-03-17 Philippe Normand <pnormand@igalia.com> [GTK] basic OpenWebRTC build support https://bugs.webkit.org/show_bug.cgi?id=142393 Reviewed by Carlos Garcia Campos. * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This is not the upstream OpenWebRTC repository. This temporary fork contains a few patches needed by WebKit for audio/video rendering. 2015-03-17 Gyuyoung Kim <gyuyoung.kim@samsung.com> [CMake][EFL] Build test tools only for developer mode https://bugs.webkit.org/show_bug.cgi?id=142761 Reviewed by Csaba Osztrogonác. Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode. * CMakeLists.txt: 2015-03-17 Joseph Pecoraro <pecoraro@apple.com> Remove never used "useLayerOnTop" bindings generator argument https://bugs.webkit.org/show_bug.cgi?id=142773 Reviewed by Darin Adler. * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: (new): 2015-03-16 Ryosuke Niwa <rniwa@webkit.org> Enable ES6 classes by default https://bugs.webkit.org/show_bug.cgi?id=142774 Reviewed by Gavin Barraclough. * Scripts/webkitperl/FeatureList.pm: 2015-03-16 Alexey Proskuryakov <ap@apple.com> Fix webkitpy tests after r181585. Looks like "me" cannot be anyone's email, it's a special case. * Scripts/webkitpy/common/config/contributors.json: 2015-03-16 Alexey Proskuryakov <ap@apple.com> Add tolerance to WebAudio tests https://bugs.webkit.org/show_bug.cgi?id=142676 Reviewed by Tim Horton. * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: (TestResultWriter.create_audio_diff_and_write_result): * Scripts/webkitpy/layout_tests/models/test_failures.py: (FailureAudio.write_failure): * Scripts/webkitpy/port/base.py: (Port.do_audio_results_differ): Diff audio failures. * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing tests to use real parseable WAV data, and got rid of base64, which there didn't seem to have been any reason for. 2015-03-16 Alexey Proskuryakov <ap@apple.com> [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed https://bugs.webkit.org/show_bug.cgi?id=142720 Reviewed by Myles C. Maxfield. Activate system copies of Microsoft fonts for the current process, thus overriding any other ones that could be preferred by the system otherwise. * DumpRenderTree/mac/DumpRenderTree.mm: (activateSystemCoreWebFonts): (adjustFonts): * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: (WTR::activateSystemCoreWebFonts): (WTR::activateFonts): 2015-03-16 Xabier Rodriguez Calvar <calvaris@igalia.com> Created Streams API watchlist https://bugs.webkit.org/show_bug.cgi?id=142684 Reviewed by Benjamin Poulain. * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI watchlist and added Benjamin, Youenn and me to it. 2015-03-15 Benjamin Poulain <benjamin@webkit.org> CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen https://bugs.webkit.org/show_bug.cgi?id=142715 Reviewed by Brent Fulgham. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: (TestWebKitAPI::TEST): 2015-03-15 Benjamin Poulain <bpoulain@apple.com> Change the exact attribute matching to be ASCII case-insensitive https://bugs.webkit.org/show_bug.cgi?id=142609 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: * TestWebKitAPI/Tests/WTF/StringView.cpp: 2015-03-13 Youenn Fablet <youenn.fablet@crf.canon.fr> WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it https://bugs.webkit.org/show_bug.cgi?id=134764 Reviewed by Ryosuke Niwa. TestDownloader is introduced to download W3C tests from the official W3C tests repositories (https://github.com/w3c/web-platform-tests.git and https://github.com/w3c/csswg-test.git). TestDownloader clones the repositories and checkouts revisions of the tests defined in LayoutTests/imported/w3c/resources/TestRepositories. Similarly to https://codereview.chromium.org/148173016, TestDownloader copies part of the files based on the rules defined in LayoutTests/imported/w3c/resources/ImportExpectations. TestDownloader is used by TestImporter when no source directory is provided. * Scripts/webkitpy/w3c/test_downloader.py: Added. (TestDownloader): (TestDownloader.default_options): (TestDownloader.load_test_repositories): (TestDownloader.__init__): (TestDownloader.checkout_test_repository): (TestDownloader._init_paths_from_expectations): (TestDownloader._add_test_suite_paths): (TestDownloader._empty_directory): (TestDownloader.copy_tests): (TestDownloader.download_tests): * Scripts/webkitpy/w3c/test_importer.py: (main): (parse_args): (TestImporter.__init__): (TestImporter.do_import): (TestImporter.test_downloader): (TestImporter.find_importable_tests.should_keep_subdir): (TestImporter.should_convert_test_harness_links): (TestImporter.import_tests): (TestImporter.write_import_log): 2015-03-12 Alexey Proskuryakov <ap@apple.com> [Mavericks] Test snapshots are 1600x1200 on Retina devices https://bugs.webkit.org/show_bug.cgi?id=142630 Reviewed by Tim Horton. * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage): Removed an ifdef that disabled the fix on Mavericks. 2015-03-12 Csaba Osztrogonác <ossy@webkit.org> Remove isWK2 cruft from webkitdirs.pm after r170426 https://bugs.webkit.org/show_bug.cgi?id=142618 Reviewed by Daniel Bates. * Scripts/webkitdirs.pm: (isWK2): Deleted. 2015-03-12 Alexey Proskuryakov <ap@apple.com> testRunner.setAlwaysAcceptCookies does not work with NetworkProcess https://bugs.webkit.org/show_bug.cgi?id=138687 Reviewed by Carlos Garcia Campos. Always change cookie policy from UI process, as changing it from WebProcess doesn't affect other processes. The implementation is imperfect, because the change happens asynchronously, but I don't expect it to be a problem in practice. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setAlwaysAcceptCookies): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): 2015-03-12 Csaba Osztrogonác <ossy@webkit.org> [EFL] Enable building EFL 1.13 with NEON support https://bugs.webkit.org/show_bug.cgi?id=142619 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: 2015-03-11 Alex Christensen <achristensen@webkit.org> [Content Extensions] Add resource type and load type triggers. https://bugs.webkit.org/show_bug.cgi?id=142422 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::testRequest): (TestWebKitAPI::mainDocumentRequest): (TestWebKitAPI::TEST_F): (TestWebKitAPI::testURL): Deleted. 2015-03-10 Sam Weinig <sam@webkit.org> Allow adding a button in input elements for auto fill related functionality <rdar://problem/19782066> https://bugs.webkit.org/show_bug.cgi?id=142564 Reviewed by Anders Carlsson. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): Update for new callback. 2015-03-11 Benjamin Poulain <bpoulain@apple.com> Add basic support for BOL and EOL assertions to the URL Filter parser https://bugs.webkit.org/show_bug.cgi?id=142568 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): 2015-03-11 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add support for handling TLS errors to MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=142576 Reviewed by Sergio Villar Senin. It's useful for testing TLS errors handling itself, but also to allow ignoring TLS errors when testing. * MiniBrowser/gtk/BrowserWindow.c: (webViewLoadFailedWithTLSerrors): (browserWindowConstructed): 2015-03-11 Myles C. Maxfield <mmaxfield@apple.com> Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline() https://bugs.webkit.org/show_bug.cgi?id=142569 Reviewed by David Hyatt. Test Optional::valueOrCompute(). * TestWebKitAPI/Tests/WTF/Optional.cpp: (TestWebKitAPI::TEST): 2015-03-11 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add an option to enable MiniBrowser for non developer builds and always install it https://bugs.webkit.org/show_bug.cgi?id=126688 Reviewed by Gustavo Noronha Silva. * CMakeLists.txt: Build testing tools only for developer builds, but MiniBrowser when ENABLE_MINIBROWSER option is ON. * MiniBrowser/gtk/CMakeLists.txt: Only add -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds, and add a rule to install the MiniBrowser. * MiniBrowser/gtk/main.c: (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer builds. 2015-03-11 Brent Fulgham <bfulgham@apple.com> Add some DateMath tests to TestWebKitAPI https://bugs.webkit.org/show_bug.cgi?id=142565 Reviewed by Alexey Proskuryakov. * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file. * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto. * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto." * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added. 2015-03-10 Brent Fulgham <bfulgham@apple.com> Regression(r181257): WTF_WorkQueue.Simple is flaky https://bugs.webkit.org/show_bug.cgi?id=142560 Unreviewed attempt to improve test stability. * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for the WorkQueue a little later to redue flakiness. 2015-03-10 Myles C. Maxfield <mmaxfield@apple.com> Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion https://bugs.webkit.org/show_bug.cgi?id=142555 Reviewed by Simon Fraser. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize): 2015-03-10 Alex Christensen <achristensen@webkit.org> Use unsigned for HashSet size. https://bugs.webkit.org/show_bug.cgi?id=142518 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WTF/HashMap.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/HashSet.cpp: (TestWebKitAPI::testInitialCapacity): * TestWebKitAPI/Tests/WTF/ListHashSet.cpp: (TestWebKitAPI::TEST): 2015-03-10 Daniel Bates <dabates@apple.com> [iOS] Add WebKitSystemInterface for iOS 8.2 https://bugs.webkit.org/show_bug.cgi?id=142505 Rubber-stamped by Anders Carlsson. Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a. I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script copy-webkitlibraries-to-product-directory in r181286. * Scripts/copy-webkitlibraries-to-product-directory: 2015-03-10 Benjamin Poulain <bpoulain@apple.com> Extend URL filter's Term definition to support groups/subpatterns https://bugs.webkit.org/show_bug.cgi?id=142519 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::testURL): 2015-03-06 Jer Noble <jer.noble@apple.com> Add an option to run-webkit-tests to override the LayoutTests/ directory https://bugs.webkit.org/show_bug.cgi?id=142418 Reviewed by David Kilzer. Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests directory. The base port will parse the options during initialization and store the override location if present. layout_tests_dir() will return this overridden location if set. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): * Scripts/webkitpy/port/base.py: (Port.__init__): (Port.layout_tests_dir): 2015-03-09 Martin Robinson <mrobinson@igalia.com> [CMake] Enable WorkQueue tests for CMake ports https://bugs.webkit.org/show_bug.cgi?id=142473 Reviewed by Darin Adler. * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to the list of source files. * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory to the list of include directories for EFL. 2015-03-09 David Kilzer <ddkilzer@apple.com> Attempt to fix timeouts on iOS Simulator layout tests * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS Simulator end after the first 50 tests time out. Some analysis this past weekend shows that the 'Booted' status in the output of `xcrun simctl list` is not sufficient (and watching the test run shows that SpringBoard hasn't fully started to the point where it's displaying icons on the home screen). The workaround until we have a better fix is to add an arbitrary timeout to let SpringBoard finish launching. In practice, 15 seconds is probably enough, but 30 seconds should nearly always work. 2015-03-09 Per Arne Vollan <peavo@outlook.com> Unreviewed. Add myself as a committer. * Scripts/webkitpy/common/config/contributors.json: 2015-03-09 David Kilzer <ddkilzer@apple.com> Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add an expectation that will fail if we hit the race condition. This test is inherently racy and will deadlock if the first job for queue2 takes the mutex lock before the second job for queue1. 2015-03-08 Brent Fulgham <bfulgham@apple.com> [Win] WTF::WorkQueue does not balance ref/deref properly https://bugs.webkit.org/show_bug.cgi?id=142471 Reviewed by Antti Koivisto. * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: (TestWebKitAPI::TEST): Check that the refcount is correct. 2015-03-08 Gyuyoung Kim <gyuyoung.kim@samsung.com> Do not show passing test result on output of EFL layout test https://bugs.webkit.org/show_bug.cgi?id=142380 Reviewed by Darin Adler. To show passing tests has caused inconvenience when we detect problem tests in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port in order not to show passing tests in the output of EFL layout test. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunWebKitTests.start): 2015-03-08 Brent Fulgham <bfulgham@apple.com> Unreviewed build fix. * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: (TestWebKitAPI::TEST): Remove two unused variables. 2015-03-08 Brent Fulgham <bfulgham@apple.com> Add some WorkQueue tests to TestWebKitAPI https://bugs.webkit.org/show_bug.cgi?id=142447 Reviewed by Sam Weinig. * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added. (TestWebKitAPI::simpleTest): (TestWebKitAPI::longTest): (TestWebKitAPI::thirdTest): (TestWebKitAPI::finishedTests): (TestWebKitAPI::TEST): (TestWebKitAPI::longTest2): 2015-03-08 Carlos Garcia Campos <cgarcia@igalia.com> Remove willDestroyFrame in WKBundlePageLoaderClient https://bugs.webkit.org/show_bug.cgi?id=142389 Reviewed by Anders Carlsson. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): 2015-03-07 Brent Fulgham <bfulgham@apple.com> [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage https://bugs.webkit.org/show_bug.cgi?id=142433 Reviewed by Darin Adler. Include more TestWebKitAPI tests when building for Windows. Also fix a build error in MetaAllocator.cpp caused by one of the Microsoft headers #defining 'small'. * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: 2015-03-06 Sam Weinig <sam@webkit.org> [Content Extensions] Move compiling of content extensions to the UIProcess https://bugs.webkit.org/show_bug.cgi?id=142402 Reviewed by Benjamin Poulain. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp. (TestWebKitAPI::InMemoryCompiledContentExtension::create): (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension): (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension): (TestWebKitAPI::TEST_F): * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed. Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension is now abstract). 2015-03-06 Brent Fulgham <bfulgham@apple.com> [Win] Correct Windows build. Rubberstamped by Michael Saboff * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error in the GOTO labels. 2015-03-06 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished https://bugs.webkit.org/show_bug.cgi?id=142385 Reviewed by Sergio Villar Senin. Use stack allocated GMainLoopSources to make sure they are cancelled automatically if the test finishes before they have been processed. * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: (testWebViewSyncRequestOnMaxConns): 2015-03-06 Csaba Osztrogonác <ossy@webkit.org> Remove Mountain Lion libraries since ML isn't supported https://bugs.webkit.org/show_bug.cgi?id=142332 Reviewed by Darin Adler. * Scripts/copy-webkitlibraries-to-product-directory: 2015-03-06 Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet <youenn.fablet@crf.canon.fr> Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS https://bugs.webkit.org/show_bug.cgi?id=142083 Reviewed by Simon Fraser. Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (WebPlatformTestServer._copy_webkit_test_files): 2015-03-06 Csaba Osztrogonác <ossy@webkit.org> setup-git-clone fails due to the failure to download python-irclib-0.4.8 https://bugs.webkit.org/show_bug.cgi?id=141946 Reviewed by Ryosuke Niwa. Check in ircbot.py and irclib.py to avoid network problems in the future. * Scripts/webkitpy/common/net/irc/ircbot.py: * Scripts/webkitpy/thirdparty/__init__.py: (AutoinstallImportHook.find_module): (AutoinstallImportHook._install_irc): Deleted. * Scripts/webkitpy/thirdparty/__init___unittest.py: (ThirdpartyTest.test_imports): * Scripts/webkitpy/thirdparty/irc/__init__.py: Added. * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added. * Scripts/webkitpy/thirdparty/irc/irclib.py: Added. 2015-03-06 David Kilzer <ddkilzer@apple.com> Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds See also fix to config.json in r181097. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): Add missing "WK2" to the names of the perf bots. 2015-03-06 Csaba Osztrogonác <ossy@webkit.org> run-jsc-stress-tests should determine the architecture from ELF binaries https://bugs.webkit.org/show_bug.cgi?id=142335 Reviewed by Darin Adler. * Scripts/run-jsc-stress-tests: 2015-03-05 David Kilzer <ddkilzer@apple.com> [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator' <http://webkit.org/b/142226> Reviewed by Darin Adler. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_baseline_search_path): Switch the TestExpectations order of ios-simulator-wk2 from this: ios-simulator-wk2, wk2, ios-simulator To this: ios-simulator-wk2, ios-simualtor, wk2 2015-03-05 Brent Fulgham <bfulgham@apple.com> [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after https://bugs.webkit.org/show_bug.cgi?id=142370 Reviewed by Dean Jackson. * Scripts/webkitdirs.pm: (buildVisualStudioProject): Tell MSBuild to output log files to two separate logs, one for warnings, the other for errors. * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs into the standard BuildOutput.htm document. 2015-03-05 David Kilzer <ddkilzer@apple.com> Dashboard has trouble parsing iOS test output <http://webkit.org/b/142364> Reviewed by Alex Christensen. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: (BuildbotTestResults.prototype._parseResults.resultSummarizer): Add fallback path to build a regex using 'matchString' so that it matches anywhere in the line. In practice, 'matchString' is a prefix for the label following the number. 2015-03-05 Alex Christensen <achristensen@webkit.org> Fix linker warnings in TestWebKitAPI. https://bugs.webkit.org/show_bug.cgi?id=141912 Reviewed by David Kilzer. * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Do not export TearDownTestCase or SetUpTestCase symbols. 2015-03-05 Brent Fulgham <bfulgham@apple.com> [Win] Unreviewed EWS fix. * Scripts/webkitdirs.pm: (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes the EWS output more usable. 2015-03-05 Chris Dumez <cdumez@apple.com> Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16() https://bugs.webkit.org/show_bug.cgi?id=142350 Reviewed by Michael Saboff and Benjamin Poulain. Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't crash if the string is 8-bit but the pattern is 16-bit (and vice-versa). * TestWebKitAPI/Tests/WTF/WTFString.cpp: (TestWebKitAPI::TEST): 2015-03-05 Brent Fulgham <bfulgham@apple.com> [Win] Ensure build target directory exists when launching MSBuild https://bugs.webkit.org/show_bug.cgi?id=142360 Reviewed by Dean Jackson. Create the build output directory (if it doesn't exist) before launching MSBuild so that it can immediately begin writing logs. * Scripts/webkitdirs.pm: (buildVisualStudioProject): 2015-03-05 Chris Dumez <cdumez@apple.com> run-webkit-tests and run-perf-tests should use WebKitTestRunner by default https://bugs.webkit.org/show_bug.cgi?id=142325 Reviewed by Csaba Osztrogonác. run-webkit-tests and run-perf-tests now use WebKitTestRunner by default. As a result, "--webkit-test-runner / -2" parameters are replaced by "--dump-render-tree / -1" so developers can run DumpRenderTree rather than WebKitTestRunner. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunWebKit1Tests): (RunWebKit1Tests.start): (RunWebKit1LeakTests): (RunWebKit1LeakTests.start): (RunAndUploadPerfTestsWebKit1): (RunAndUploadPerfTestsWebKit1.start): (TestFactory): (TestWebKit1LeaksFactory): (TestWebKit1LeaksFactory.__init__): (TestWebKit1Factory): (TestWebKit1AllButJSCFactory): (TestAllButJSCFactory): (BuildAndPerfTestWebKit1Factory): (BuildAndPerfTestWebKit1Factory.__init__): (BuildAndPerfTestFactory): (BuildAndPerfTestFactory.__init__): (DownloadAndPerfTestWebKit1Factory): (DownloadAndPerfTestWebKit1Factory.__init__): (DownloadAndPerfTestFactory): (DownloadAndPerfTestFactory.__init__): (RunWebKitLeakTests): Deleted. (RunWebKitLeakTests.start): Deleted. (RunWebKit2Tests): Deleted. (RunWebKit2Tests.start): Deleted. (RunAndUploadPerfTestsWebKit2): Deleted. (RunAndUploadPerfTestsWebKit2.start): Deleted. (TestLeaksFactory): Deleted. (TestLeaksFactory.__init__): Deleted. (TestWebKit2Factory): Deleted. (TestWebKit2AndJSCFactory): Deleted. (BuildAndPerfTestWebKit2Factory): Deleted. (BuildAndPerfTestWebKit2Factory.__init__): Deleted. (DownloadAndPerfTestWebKit2Factory): Deleted. (DownloadAndPerfTestWebKit2Factory.__init__): Deleted. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._parse_args): * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_build_driver): 2015-03-05 Brent Fulgham <bfulgham@apple.com> [Win] Switch to MSBuild so we get more useful stdout logging in buildbot https://bugs.webkit.org/show_bug.cgi?id=140845 Reviewed by David Kilzer. Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013 and generate suitable build commands to drive a full build from our existing solution files. * Scripts/webkitdirs.pm: (msBuildInstallDir): Added. (determineConfigurationForVisualStudio): Revise to use MSBuild command line arguments to drive the build. (setupCygwinEnv): Warn user if MSBuild cannot be located. (buildVisualStudioProject): Revise to use MSBuild command line arguments to specify build architecture. * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't bother looking for CoreUI or SafariTheme build logs. 2015-03-05 Csaba Osztrogonác <ossy@webkit.org> [buildbot] mastercfg_unittest.py should be runnable easily https://bugs.webkit.org/show_bug.cgi?id=142219 Reviewed by Chris Dumez. Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is the last Twisted version works together with this buildbot version. * Scripts/webkitpy/common/system/autoinstall.py: (AutoInstaller): Added prepend_to_search_path argument to be able to prefer autoinstalled package to system package. (AutoInstaller.__init__): (AutoInstaller._set_up_target_dir): (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too. (AutoInstaller._prepare_package): (AutoInstaller._extract_targz): Renamed to _extract_tar. * Scripts/webkitpy/thirdparty/__init__.py: (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0. 2015-03-05 Lukasz Bialek <l.bialek@samsung.com> [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked https://bugs.webkit.org/show_bug.cgi?id=131162 Reviewed by Gyuyoung Kim. * MiniBrowser/efl/main.c: (on_download_request): (on_download_finished): (on_download_failed): (window_create): Adapt download callbacks to new callback mechanism 2015-03-05 Carlos Garcia Campos <cgarcia@igalia.com> Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927. In r180927 we updated the libsoup version used by the jhbuild. In this new version the sniffer uses image/x-icon instead of image/vnd.microsoft.icon for blank.ico resource. * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: (testWebResourceMimeType): 2015-03-05 Carlos Garcia Campos <cgarcia@igalia.com> [SOUP] Check TLS errors as soon as they are set in the SoupMessage https://bugs.webkit.org/show_bug.cgi?id=142244 Reviewed by Sergio Villar Senin. Check that the SSL server doesn't process any request in case of TLS errors when the policy is set to FAIL. * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: (testTLSErrorsPolicy): (testTLSErrorsRedirect): (testTLSErrorsHTTPAuth): (testLoadFailedWithTLSErrors): (testSubresourceLoadFailedWithTLSErrors): (httpsServerCallback): 2015-03-05 Pawel Forysiuk <p.forysiuk@samsung.com> [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty() https://bugs.webkit.org/show_bug.cgi?id=141154 Reviewed by Jer Noble. Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default. For the sake of completeness WebKitTestRunner should specify temporary folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc. Default non legacy paths are set up in ProcessPoolConfiguration constructor. They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation to get data storage paths. Only Mac port has an actual implementation of it. However, WebKitTestRunner overrides them in favour of unique temporary dir which is taken from libraryPathForTesting(). Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation is not implemented for EFL and GTK ports it returns an empty string. All default data folders besides MediaKeys are overridden in TestRunner code with unique temporary folders derived from DUMPRENDERTREE_TEMP env variable. GTK port does not enable encrypted keys by default so WebMediaKeyStorageManager::initialize() code path is never triggered. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all WebKit ports. 2015-03-05 Csaba Osztrogonác <ossy@webkit.org> [buildbot] Add regression test to check which builder runs which tests https://bugs.webkit.org/show_bug.cgi?id=142166 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: (BuildStepsConstructorTest.createTest): (BuildStepsTest): (BuildStepsTest.generateTests): (BuildStepsTest.createTest): (BuildStepsTest.createTest.doTest): (BuildStepsTest.test_unnecessary_expected_results): 2015-03-04 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r181054. https://bugs.webkit.org/show_bug.cgi?id=142320 Broke the api tests (Requested by sundiamonde on #webkit). Reverted changeset: "Fix linker warnings in TestWebKitAPI." https://bugs.webkit.org/show_bug.cgi?id=141912 http://trac.webkit.org/changeset/181054 2015-03-04 Alex Christensen <achristensen@webkit.org> Fix linker warnings in TestWebKitAPI. https://bugs.webkit.org/show_bug.cgi?id=141912 Reviewed by David Kilzer. * TestWebKitAPI/Configurations/Base.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore. 2015-03-04 Alexey Proskuryakov <ap@apple.com> [Mac] Set SystemUIFontSelect in DRT and WKTR https://bugs.webkit.org/show_bug.cgi?id=142303 Reviewed by Myles C. Maxfield. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize): 2015-03-04 Chris Dumez <cdumez@apple.com> Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=142314 <rdar://problem/20046835> Reviewed by Ryosuke Niwa. Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree to get WK2 code coverage. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-03-04 Alex Christensen <achristensen@webkit.org> Move content extensions test to properly named directory. https://bugs.webkit.org/show_bug.cgi?id=142299 Reviewed by Tim Horton. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformConfigureViewForTest): 2015-03-04 Youenn Fablet <youenn.fablet@crf.canon.fr> W3C test importer should use filesystem instead of os.walk https://bugs.webkit.org/show_bug.cgi?id=142085 Reviewed by Bem Jones-Bey. Added FileSystem.dirs_under to remove the use of os.walk in test importer. Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer. Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under. Made use of FileSystem.dirs_under within TestImporter.find_importable_tests. Added a unit test to check that test importer is now black-box testable using a Mock system. * Scripts/webkitpy/common/system/filesystem.py: (FileSystem.dirs_under): Returns a list of filtered sub-directories. (FileSystem.dirs_under.filter_all): * Scripts/webkitpy/common/system/filesystem_mock.py: (MockFileSystem.dirs_under): (MockFileSystem.dirs_under.filter_all): (MockFileSystem.getsize): * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: (MockFileSystemTest.test_dirs_under): (MockFileSystemTest.test_dirs_under.filter_dir): * Scripts/webkitpy/common/system/filesystem_unittest.py: (RealFileSystemTest.test_sep): (RealFileSystemTest): (RealFileSystemTest.test_dirs_under): (RealFileSystemTest.test_dirs_under.filter_this_dir): * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.do_import): (TestImporter.find_importable_tests.should_keep_subdir): (TestImporter.find_importable_tests): (TestImporter.should_keep_subdir): Deleted. (TestImporter.should_skip_file): Deleted. * Scripts/webkitpy/w3c/test_importer_unittest.py: (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported. 2015-03-04 Timothy Horton <timothy_horton@apple.com> [WebEditingTester] Add support for the find and replace bar https://bugs.webkit.org/show_bug.cgi?id=142247 Reviewed by Enrica Casucci. While it's not hooked up yet in WKWebView, adding support for the find bar to WebEditingTester will help us implement that functionality. * WebEditingTester/AppDelegate.h: * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate performTextFinderAction:]): * WebEditingTester/MainMenu.xib: Receive performTextFinderAction: and forward it to the frontmost WebDocumentController. * WebEditingTester/WK2WebDocumentController.m: (-[WK2WebDocumentController awakeFromNib]): (-[WK2WebDocumentController performTextFinderAction:]): (-[WK2WebDocumentController findBarView]): (-[WK2WebDocumentController setFindBarView:]): (-[WK2WebDocumentController isFindBarVisible]): (-[WK2WebDocumentController setFindBarVisible:]): (-[WK2WebDocumentController findBarViewDidChangeHeight]): (-[WK2WebDocumentController layout]): Implement performTextFinderAction: for WebKit2, and have a NSTextFinder pointing at the WKWebView (currently nothing will work, but the bar will show up). Install and uninstall the bar as needed. * WebEditingTester/WebDocument.xib: Don't use a full-size content view. There's no need, and it makes find bar layout harder. * WebEditingTester/WebDocumentController.h: * WebEditingTester/WebDocumentController.m: (-[WebDocumentController performTextFinderAction:]): 2015-03-03 Sam Weinig <sam@webkit.org> [Content Extensions] Split parsing and compiling of content extensions into their own files https://bugs.webkit.org/show_bug.cgi?id=142259 Reviewed by Anders Carlsson. Add basic unit test for the content filter compiler. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added. (WebCore::ContentExtensions::operator<<): (TestWebKitAPI::ContentFilterTest::SetUp): (TestWebKitAPI::TEST_F): 2015-03-04 Matthew Mirman <mmirman@apple.com> Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory https://bugs.webkit.org/show_bug.cgi?id=142230 Reviewed by Csaba Osztrogonác. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (TestFactory): (TestFactory.getProduct): Added (TestFactory.__init__): moved downloader to getProduct (BuildAndTestFactory): (BuildAndTestFactory.getProduct): Added (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end. (BuildAndTestWebKit2Factory): Deleted. Wasn't used anywhere. 2015-03-04 Debarshi Ray <debarshir@gnome.org> [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality https://bugs.webkit.org/show_bug.cgi?id=142225 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewWebContextLifetime): (beforeAll): 2015-03-03 David Kilzer <ddkilzer@apple.com> [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name <http://webkit.org/b/142243> Reviewed by Alexey Proskuryakov. * WebKitTestRunner/TestController.cpp: (WTR::TestController::webProcessName): (WTR::TestController::networkProcessName): - Return the same process name on iOS and Mac because they both use the same process name for local engineering builds. 2015-03-03 David Kilzer <ddkilzer@apple.com> check-webkit-style: Add exception for FrameworkSoftLink.h header order <http://webkit.org/b/141872> Reviewed by Alex Christensen. * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded semi-colons in various places and fix whitespace. (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION constants. (_IncludeState.__init__): Add self._visited_soft_link_section boolean state variable. (_IncludeState.visited_soft_link_section): Getter for self._visited_soft_link_section. (_IncludeState.check_next_include_order): Update state machine for soft-link headers. Add check that soft-link headers always appear last. (_classify_include): Add check for soft-link header type. (check_include_line): Return early if there is a soft-link header error. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (OrderOfIncludesTest.test_public_primary_header): Add tests for including soft-link headers. (OrderOfIncludesTest.test_classify_include): Add test for _SOFT_LINK_HEADER type. 2015-03-03 Alexey Proskuryakov <ap@apple.com> build.webkit.org/dashboard: Don't repeatedly handle each test type https://bugs.webkit.org/show_bug.cgi?id=142211 Reviewed by Tim Horton and Matt Hanson. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted. (Buildbot.prototype.apiTestResultsURLForIteration): Deleted. (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted. (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted. (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted. (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted. Removed functions that build a link to test step results. The buildbot provides these links in JSON. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: (BuildbotIteration): Put failing tests into an array, instead of named variables. (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org. We can easily add them to the map as needed. (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues. (BuildbotIteration.prototype._parseData): Moved code for parsing step results away to BuildbotTestResults class. We used to parse here, build an intermediate data structure, and then build a BuildbotTestResults object, which was strange. (BuildbotIteration.prototype.loadLayoutTestResults): Ditto. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Corrected an unrelated assertion that was buggy, and kept firing. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: (BuildbotTestResults): (BuildbotTestResults.prototype._parseResults.resultSummarizer): (BuildbotTestResults.prototype._parseResults): (BuildbotTestResults.prototype.addFullLayoutTestResults): Moved the code for parsing JSON results for a single step here. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype._testStepFailureDescription): (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures): (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted. (BuildbotTesterQueueView.prototype.update): Deleted. (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted. Updated for the new data structures. One behavior change is that we now display individual counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout test failures, 3 platform api test failures". 2015-03-03 Matthew Mirman <mmirman@apple.com> JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue. https://bugs.webkit.org/show_bug.cgi?id=142094 Reviewed by Csaba Osztrogonác. * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157 * BuildSlaveSupport/build.webkit.org-config/master.cfg: (TestFactory): (TestFactory.__init__): Made running of JSC tests conditional. (TestAllButJSCFactory): (TestJSCFactory): Added. (TestJSCFactory.__init__): (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2. 2015-03-03 David Kilzer <ddkilzer@apple.com> `build-webkit --help` is wrong about how to build for the iOS simulator <http://webkit.org/b/142223> Reviewed by Csaba Osztrogonác. * Scripts/build-webkit: Fix help. 2015-03-03 Carlos Garcia Campos <cgarcia@igalia.com> Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build. * gtk/jhbuild.modules: 2015-03-03 Carlos Garcia Campos <cgarcia@igalia.com> [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit https://bugs.webkit.org/show_bug.cgi?id=141508 Reviewed by Sergio Villar Senin. Add a unit test to check that synchronous XHRs load even if the maximum connection limits are reached. * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: (testWebViewSyncRequestOnMaxConns): (serverCallback): (beforeAll): * gtk/jhbuild.modules: Bump libsoup version to 2.49.91. 2015-03-02 Alexey Proskuryakov <ap@apple.com> Update the name of ASan build step. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: 2015-03-02 Jer Noble <jer.noble@apple.com> [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled. https://bugs.webkit.org/show_bug.cgi?id=142121 Reviewed by Simon Fraser. Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies that the initial and final screen rects for the web content are as expected. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added. * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added. (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): (runJavaScriptAlert): (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView): (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView): (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale): (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent): (TestWebKitAPI::FullscreenZoomInitialFrame::runTest): (TestWebKitAPI::TEST_F): 2015-03-01 David Kilzer <ddkilzer@apple.com> LayoutTestRealy: Prepend __XPC_ to the key, not the value! Follow-up fix for: LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks <http://webkit.org/b/142145> * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController _environmentVariables]): Fix think-o. 2015-03-01 David Kilzer <ddkilzer@apple.com> LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks <http://webkit.org/b/142145> Reviewed by Simon Fraser. * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController _environmentVariables]): Add. (-[LTRelayController launchApp]): Use -_environmentVariables. 2015-02-28 David Kilzer <ddkilzer@apple.com> [iOS] Stop running webkit-build-directory on every layout test This was originally fixed by David Farler for Bug 135409 in r172602. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't run webkit-build-directory every time it's called. 2015-02-28 Youenn Fablet <youenn.fablet@crf.canon.fr> W3C importer should use filesystem instead of shutil/host https://bugs.webkit.org/show_bug.cgi?id=142012 Reviewed by Bem Jones-Bey. Removed direct use of python shutil and os, except for os.walk which will require its own fix. * Scripts/webkitpy/w3c/test_importer.py: (main): (TestImporter.do_import): (TestImporter.find_importable_tests): (TestImporter.import_tests): (TestImporter.remove_deleted_files): (TestImporter.write_import_log): 2015-02-28 Youenn Fablet <youenn.fablet@crf.canon.fr> W3C test importer should use filesystem to read and write files https://bugs.webkit.org/show_bug.cgi?id=142084 Reviewed by Bem Jones-Bey. Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open(). * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.import_tests): (TestImporter.remove_deleted_files): (TestImporter.write_import_log): 2015-02-27 Sam Weinig <sam@webkit.org> Add WebKit2 SPI to create a DOM File object https://bugs.webkit.org/show_bug.cgi?id=142109 Reviewed by Tim Horton. Add a test for WKBundleFileHandleRef. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added. (TestWebKitAPI::didReceiveMessageFromInjectedBundle): (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added. (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest): * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added. 2015-02-27 Michael Saboff <msaboff@apple.com> Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot https://bugs.webkit.org/show_bug.cgi?id=142112 Reviewed by Filip Pizlo. Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use <someDir> as the library path. * Scripts/run-jsc-benchmarks: 2015-02-27 Alex Christensen <achristensen@webkit.org> [WinCairo] Unreviewed build fix. * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props. 2015-02-27 Anders Carlsson <andersca@apple.com> Add infrastructure for handling website data in the network process https://bugs.webkit.org/show_bug.cgi?id=142092 Reviewed by Andreas Kling. Add a menu item that will fetch all website data, delete the returned data records, and fetch all website data again so we can confirm that it's all empty. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController fetchAndClearWebsiteData:]): 2015-02-26 Brent Fulgham <bfulgham@apple.com> [Win] Remove remaining SafariTheme cruft https://bugs.webkit.org/show_bug.cgi?id=142075 Reviewed by Anders Carlsson. Remove reference to SafariTheme-switching preference. * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): (prepareConsistentTestingEnvironment): 2015-02-26 Doug Russell <d_russell@apple.com> AX: Expose caret browsing preference to accessibility API https://bugs.webkit.org/show_bug.cgi?id=141862 Reviewed by Chris Fleizach. Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running). Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events. * DumpRenderTree/AccessibilityUIElement.cpp: (setBoolAttributeValueCallback): (selectedTextMarkerRangeCallback): (resetSelectedTextMarkerRangeCallback): (AccessibilityUIElement::setBoolAttributeValue): (AccessibilityUIElement::selectedTextMarkerRange): (AccessibilityUIElement::resetSelectedTextMarkerRange): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::setBoolAttributeValue): (AccessibilityUIElement::selectedTextMarkerRange): (AccessibilityUIElement::resetSelectedTextMarkerRange): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::selectedTextMarkerRange): (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange): (WTR::AccessibilityUIElement::setBoolAttributeValue): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::setBoolAttributeValue): (WTR::AccessibilityUIElement::selectedTextMarkerRange): (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange): 2015-02-26 Brent Fulgham <bfulgham@apple.com> [Win] Remove WebKitExportGenerator project (and related) https://bugs.webkit.org/show_bug.cgi?id=142035 Reviewed by Dean Jackson. * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a build log from WebKitExportGenerator. 2015-02-26 Csaba Osztrogonác <ossy@webkit.org> [EFL] Bump EFL version to 1.13.0 https://bugs.webkit.org/show_bug.cgi?id=141708 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: 2015-02-26 Sam Weinig <sam@webkit.org> Check in missing WebEditingTester.xcconfig file. * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added. 2015-02-26 Csaba Osztrogonác <ossy@webkit.org> [webkitpy] Remove skipped file related crufts https://bugs.webkit.org/show_bug.cgi?id=142046 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/port/base.py: (Port.skipped_layout_tests): (Port._tests_from_skipped_file_contents): Deleted. (Port): Deleted. (Port._expectations_from_skipped_files): Deleted. * Scripts/webkitpy/port/mac_unittest.py: (MacTest.test_default_timeout_ms): (MacTest): Deleted. (test_tests_from_skipped_file_contents): Deleted. 2015-02-26 Brent Fulgham <bfulgham@apple.com> [Win] Unreviewed WinCairo build fix after r180653. TestWebKitAPI should know about proper WEBCORE_EXPORT definitions. * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added. * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added. 2015-02-25 Brent Fulgham <bfulgham@apple.com> [Win] Use WEBCORE_EXPORT instead of Definition file https://bugs.webkit.org/show_bug.cgi?id=141734 Reviewed by Alex Christensen. * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: Use a precompiled header so we can define our export macros properly. * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters: Visual studio automatic update stuff. * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props: Set up Precompiled Header use for project.. * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added. * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export declarations for building DumpRenderTree as a client of WebCore/WebKit. 2015-02-25 Mark Lam <mark.lam@apple.com> ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack. <https://webkit.org/b/141672> Reviewed by Alexey Proskuryakov. ASan does not like the fact that we memcpy the stack for GC scans. So, we're working around this by using our own memcpy (asanUnsafeMemcpy) implementation that we can tell ASan to ignore. Also removed the previous added directive to ignore *tryCopyOtherThreadStack* which isn't effective for working around this issue. * asan/webkit-asan-ignore.txt: 2015-02-25 Benjamin Poulain <bpoulain@apple.com> CodeBlock crashes when dumping op_push_name_scope https://bugs.webkit.org/show_bug.cgi?id=141953 Reviewed by Filip Pizlo. * Scripts/run-jsc-stress-tests: 2015-02-25 Youenn Fablet <youenn.fablet@crf.canon.fr> W3C test importer should use argparse instead of optparse https://bugs.webkit.org/show_bug.cgi?id=142013 Reviewed by Bem Jones-Bey. * Scripts/webkitpy/w3c/test_importer.py: (main): Updating according argparse. (parse_args): Moving from optparse to argparse. 2015-02-25 Brady Eidson <beidson@apple.com> Get rid of TestInvocation::pathOrURL https://bugs.webkit.org/show_bug.cgi?id=142021 Reviewed by Tim Horton. The pathOrURL string is a relative path used as an argument to WebKitTestRunner, but most code that uses it expected an absolute path. This gets rid of the member and replaces all uses with a more descriptive "urlContains" method. * WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWebViewSizeForTest): (WTR::TestController::updateWindowScaleForTest): (WTR::shouldUseFixedLayout): (WTR::TestController::updateLayoutTypeForTest): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::TestInvocation): (WTR::TestInvocation::urlContains): (WTR::TestInvocation::shouldLogFrameLoadDelegates): (WTR::TestInvocation::shouldLogHistoryClientCallbacks): (WTR::TestInvocation::invoke): (WTR::shouldLogFrameLoadDelegates): Deleted. (WTR::shouldLogHistoryClientCallbacks): Deleted. * WebKitTestRunner/TestInvocation.h: (WTR::TestInvocation::pathOrURL): Deleted. * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::shouldMakeViewportFlexible): (WTR::TestController::platformConfigureViewForTest): * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::shouldUseThreadedScrolling): (WTR::TestController::platformConfigureViewForTest): 2015-02-25 Brady Eidson <beidson@apple.com> Layout test support for user content filters https://bugs.webkit.org/show_bug.cgi?id=142018 Reviewed by Tim Horton. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json file before loading the test itself. 2015-02-24 Sam Weinig <sam@webkit.org> Convert WebEditingTester to use xcconfig files https://bugs.webkit.org/show_bug.cgi?id=141879 Reviewed by Darin Adler. Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser. * WebEditingTester/Configurations: Added. * WebEditingTester/Configurations/Base.xcconfig: Added. * WebEditingTester/Configurations/DebugRelease.xcconfig: Added. * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: 2015-02-24 Andy Estes <aestes@apple.com> Teach MiniBrowser how to disable per-window web processes https://bugs.webkit.org/show_bug.cgi?id=141988 Reviewed by Darin Adler. * MiniBrowser/mac/AppDelegate.m: (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled. * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): Added a new Settings menu item. (-[SettingsController validateMenuItem:]): Validated the new Settings menu item. (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect. (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults. 2015-02-24 Alexey Proskuryakov <ap@apple.com> Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length https://bugs.webkit.org/show_bug.cgi?id=141889 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: 2015-02-24 Yusuke Suzuki <utatane.tea@gmail.com> REGRESSION(r179429): Can't type comments in Facebook https://bugs.webkit.org/show_bug.cgi?id=141859 Reviewed by Brent Fulgham. Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): 2015-02-24 Michael Catanzaro <mcatanzaro@igalia.com> Crash loading local file with WebPageProxy::loadAlternateHTMLString https://bugs.webkit.org/show_bug.cgi?id=141867 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can be shared with the new test. (TestWebKitAPI::TEST): Add a cross-platform test for this crash. * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash. (testLoadAlternateHTMLForLocalPage): (beforeAll): 2015-02-24 David Kilzer <ddkilzer@apple.com> [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs <http://webkit.org/b/141900> Reviewed by Myles C. Maxfield. * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: (OTHER_LDFLAGS_BASE): Link to CoreText.framework. * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm. - Rename to share code with iOS. - Add USE(APPKIT) around AppKit-specific headers and code. - Fix a check-webkit-style warning. * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm. - Remove ios/ActivateFontsIOS.mm. - Fix InjectedBundle/cocoa group to represent the directory on disk. Includes a change to InjectedBundlePageCocoa.mm. 2015-02-23 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r180547 and r180550. https://bugs.webkit.org/show_bug.cgi?id=141957 Broke 10 Windows tests. (Requested by bfulgham_ on #webkit). Reverted changesets: "REGRESSION(r179429): Can't type comments in Facebook" https://bugs.webkit.org/show_bug.cgi?id=141859 http://trac.webkit.org/changeset/180547 "Constructor returning null should construct an object instead of null" https://bugs.webkit.org/show_bug.cgi?id=141640 http://trac.webkit.org/changeset/180550 2015-02-23 Yusuke Suzuki <utatane.tea@gmail.com> REGRESSION(r179429): Can't type comments in Facebook https://bugs.webkit.org/show_bug.cgi?id=141859 Reviewed by Geoffrey Garen. Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): 2015-02-23 KwangHyuk Kim <hyuki.kim@samsung.com> [EFL] fix eo errors https://bugs.webkit.org/show_bug.cgi?id=141909 Reviewed by Gyuyoung Kim. Fix eo errors that occur whenever minibrowser is launched. - elm_obj_entry_text_style_user_push can only be applied for elm_entry - elm_obj_win_resize_object_add's first parameter should be elm_win * MiniBrowser/efl/main.c: (window_create): 2015-02-23 Ryosuke Niwa <rniwa@webkit.org> Unreviewed build fix after r180535. Removed the test case that wasn't compiling. * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: (TestWebKitAPI::TEST): 2015-02-23 Brent Fulgham <bfulgham@apple.com> WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment https://bugs.webkit.org/show_bug.cgi?id=141935 Reviewed by Myles C. Maxfield. * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few tests for assigning from nullptr. 2015-02-23 Brent Fulgham <bfulgham@apple.com> WTF::WeakPtr should have a 'forget' method. https://bugs.webkit.org/show_bug.cgi?id=141923 Reviewed by Myles C. Maxfield. * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: (TestWebKitAPI::TEST): Added 'Forget' tests case. 2015-02-23 Alexey Proskuryakov <ap@apple.com> build.webkit.org/dashboard CrashOnly queues should not show two green bubbles https://bugs.webkit.org/show_bug.cgi?id=141920 Reviewed by Tim Horton. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Do the same thing as we do for regular green bubbles. 2015-02-23 Alexey Proskuryakov <ap@apple.com> Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch https://bugs.webkit.org/show_bug.cgi?id=141925 Reviewed by Tim Horton. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._presentPopoverForRevisionRange): 2015-02-23 Anders Carlsson <andersca@apple.com> Add API for fetching website data records to _WKWebsiteDataStore https://bugs.webkit.org/show_bug.cgi?id=141926 Reviewed by Beth Dakin. * MiniBrowser/mac/MainMenu.xib: * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController fetchWebsiteData:]): Add menu item to fetch and dump website data. 2015-02-23 David Kilzer <ddkilzer@apple.com> [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute <http://webkit.org/b/141884> Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/port/leakdetector.py: (LeakDetector._callstacks_to_exclude_from_leaks): Remove snowleopard, lion and older leaks. Add known leak for mavericks, but check Port.operating_system before calling Port.is_mavericks. * Scripts/webkitpy/port/mac.py: (MacPort.is_snowleopard): Delete. (MacPort.is_lion): Delete. (MacPort.is_mavericks): Add. 2015-02-23 Alexey Proskuryakov <ap@apple.com> build.webkit.org/dashboard should filter out commits to other branches https://bugs.webkit.org/show_bug.cgi?id=140362 Reviewed by Tim Horton. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._presentPopoverForPendingCommits): (BuildbotQueueView.prototype._presentPopoverForRevisionRange): (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): (BuildbotQueueView.prototype.revisionContentForIteration): (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted. (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted. (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js: (Trac.prototype.get oldestRecordedRevisionNumber): (Trac.prototype.commitsOnBranch): (Trac.prototype._xmlTimelineURL): (Trac.prototype._convertCommitInfoElementToObject): (Trac.prototype._update): (Trac.prototype.startPeriodicUpdates): (Trac.prototype.loadMoreHistoricalData): (Trac.prototype.update): Deleted. 2015-02-21 Youenn Fablet <youenn.fablet@crf.canon.fr> Tests don't work on some bots: Failed to stop wptwk https://bugs.webkit.org/show_bug.cgi?id=141235 Reviewed by Ryosuke Niwa. Logging of server subprocesses in launcher script. Killing of server subprocesses when stopping/before starting. Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (WebPlatformTestServer.__init__): (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher. (WebPlatformTestServer): (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process. (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file. (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change. (TestWebPlatformTestServer): (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file. 2015-02-20 Timothy Horton <timothy_horton@apple.com> [WebEditingTester] Allow dropping HTML files on the app https://bugs.webkit.org/show_bug.cgi?id=141834 Reviewed by Simon Fraser. * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate openDocument:]): (-[WebEditingAppDelegate application:openFile:]): Implement application:openFile:, factoring file loading code out of openDocument. * WebEditingTester/Info.plist: Register as an editor for HTML files. * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Enrica is not an organization. 2015-02-20 Timothy Horton <timothy_horton@apple.com> [WebEditingTester] Expand "WK" to "WebKit" in a few places https://bugs.webkit.org/show_bug.cgi?id=141833 Reviewed by Anders Carlsson. * WebEditingTester/AppDelegate.h: * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate newEditor:]): (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]): (-[WebEditingAppDelegate validateMenuItem:]): (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]): (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted. (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted. (-[WebEditingAppDelegate showOperations:]): Deleted. * WebEditingTester/MainMenu.xib: The WK abbreviation is unnaturally grating in menu items for some reason. 2015-02-20 Timothy Horton <timothy_horton@apple.com> [WebEditingTester] Add a custom protocol for loading canned content https://bugs.webkit.org/show_bug.cgi?id=141830 Reviewed by Enrica Casucci. Add a canned:// protocol handler, which can be used to emulate behaviors in WebKit client apps (like Mail) that use custom protocol handlers, which can have important effects on editing (mostly, the URLs are only valid inside of the client application, but not when copied/dragged out). For now, we only support two canned files: canned://dice is a PNG of dice (stolen from LayoutTests/) canned://text is the string "canned text" served as text/html In the future we could support things like very large (generated) files, progressive loading, etc. to further simulate conditions in other apps. * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Register the protocol with CFNetwork, and the scheme with WebKit2. * WebEditingTester/Canned Content/dice.png: Added. * WebEditingTester/CannedContent.h: Added. * WebEditingTester/CannedContent.m: Added. (-[CannedContent initWithRequest:cachedResponse:client:]): (+[CannedContent canonicalRequestForRequest:]): (+[CannedContent canInitWithRequest:]): We only want to handle canned:// URLs. (-[CannedContent startLoading]): For now, immediately load the two files we know about. Otherwise, immediately fail the load. (-[CannedContent stopLoading]): * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: 2015-02-20 Timothy Horton <timothy_horton@apple.com> [WebEditingTester] Implement an open panel https://bugs.webkit.org/show_bug.cgi?id=141829 Reviewed by Simon Fraser. * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]): (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]): (-[WebEditingAppDelegate openDocument:]): Add an open panel (with radio buttons to pick which WebKit to open with). Loads the file as an HTML string. 2015-02-20 Simon Fraser <simon.fraser@apple.com> [WebEditingTester] @properties, dot syntax, and remember the window position https://bugs.webkit.org/show_bug.cgi?id=141843 Reviewed by Tim Horton. Modernize a bit with more dot syntax, use @property for the web views, and give the main window an Autosave name so it remembers the widow position. * WebEditingTester/WK1WebDocumentController.m: (-[WK1WebDocumentController awakeFromNib]): (-[WK1WebDocumentController loadHTMLString:]): * WebEditingTester/WK2WebDocumentController.m: (-[WK2WebDocumentController awakeFromNib]): * WebEditingTester/WebDocument.xib: 2015-02-20 Timothy Horton <timothy_horton@apple.com> [WebEditingTester] Hook up key equivalents for new window action https://bugs.webkit.org/show_bug.cgi?id=141828 Reviewed by Enrica Casucci. * WebEditingTester/AppDelegate.h: * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate applicationDidFinishLaunching:]): (-[WebEditingAppDelegate newEditor:]): (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]): (-[WebEditingAppDelegate toggleUseWK2ByDefault:]): (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]): (defaultConfiguration): Deleted. (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted. Move WKWebViewConfiguration setup into WK2WebDocumentController. Remove unused application termination code. Update new-window menu item key equivalents when launching and when changing the use-WebKit2-by-default setting. Make WebDocumentController subclasses all initialized the same way, and use that to factor out alloc/init. Rename loadContent to loadHTMLString for future use. * WebEditingTester/MainMenu.xib: Add default key equivalents. Cmd-N will always make the default kind of window (controlled by the pref). Cmd-Opt-N will always make the other kind. The menu items are configured as alternates so they only show up if you press alt (just like in MiniBrowser). * WebEditingTester/WK1WebDocumentController.m: (-[WK1WebDocumentController loadHTMLString:]): (-[WK1WebDocumentController loadContent]): Deleted. * WebEditingTester/WK2WebDocumentController.h: * WebEditingTester/WK2WebDocumentController.m: (defaultConfiguration): (-[WK2WebDocumentController awakeFromNib]): (-[WK2WebDocumentController loadHTMLString:]): (-[WK2WebDocumentController initWithConfiguration:]): Deleted. (-[WK2WebDocumentController dealloc]): Deleted. * WebEditingTester/WebDocumentController.h: * WebEditingTester/WebDocumentController.m: (-[WebDocumentController init]): (-[WebDocumentController initWithWindow:]): (+[WebDocumentController defaultEditingSource]): (-[WebDocumentController loadHTMLString:]): (-[WebDocumentController windowDidLoad]): Deleted. (-[WebDocumentController defaultEditingSource]): Deleted. (-[WebDocumentController applicationTerminating]): Deleted. (-[WebDocumentController loadContent]): Deleted. 2015-02-20 Timothy Horton <timothy_horton@apple.com> [WebEditingTester] ARC-ify WebEditingTester https://bugs.webkit.org/show_bug.cgi?id=141827 Reviewed by Sam Weinig. * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate showOperations:]): * WebEditingTester/EditingOperations.m: (editingOperations): * WebEditingTester/WK1WebDocumentController.m: (-[WK1WebDocumentController dealloc]): Deleted. * WebEditingTester/WK2WebDocumentController.m: (-[WK2WebDocumentController dealloc]): Deleted. * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Turn on ARC and remove a few retain/release/autorelease calls. We don't need to implement dealloc in either document controller because WebView and WKWebView's UIDelegate property does not hold a strong reference. 2015-02-20 Timothy Horton <timothy_horton@apple.com> [WebEditingTester] Factor out list of editing operations https://bugs.webkit.org/show_bug.cgi?id=141826 Reviewed by Sam Weinig. * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate showOperations:]): * WebEditingTester/EditingOperations.h: Added. * WebEditingTester/EditingOperations.m: Added. (editingOperations): * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Move EditingOperations array to its own file, and make it an NSArray instead of a C array. Adjust accordingly in showOperations:. 2015-02-20 Michael Saboff <msaboff@apple.com> DFG JIT needs to check for stack overflow at the start of Program and Eval execution https://bugs.webkit.org/show_bug.cgi?id=141676 Reviewed by Filip Pizlo. Set the newly added --maximumEvalCacheableSourceLength option for eager test runs. This is needed to allow the eval out of stack tests to tier up. Without this option, we don't cache the likely large string expression that we want to eval. * Scripts/run-jsc-stress-tests: 2015-02-19 Daniel Bates <dabates@apple.com> REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run https://bugs.webkit.org/show_bug.cgi?id=141815 <rdar://problem/19893933> Reviewed by Simon Fraser. Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it was booted by iOS Simulator in a previous run of run-webkit-test. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run(). (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps(). 2015-02-19 David Kilzer <ddkilzer@apple.com> check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files <http://webkit.org/b/141799> Reviewed by Alex Christensen. * Scripts/webkitpy/style/checkers/cpp.py: (_IncludeState.check_next_include_order): Don't emit a warning if the primary header exists and the source file name ends with "SoftLink.cpp". Add 'filename' argument to method. (check_include_line): Pass in 'filename'. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (OrderOfIncludesTest.test_check_next_include_order__no_config): (OrderOfIncludesTest.test_check_next_include_order__no_self): (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): (OrderOfIncludesTest.test_check_next_include_order__other_then_config): (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): - Add test filename arguments for calls to check_next_include_order(). (OrderOfIncludesTest.test_primary_header): Add test for a file name ending in "SoftLink.cpp". 2015-02-18 Enrica Casucci <enrica@apple.com> Add new tool to test editable Webviews. https://bugs.webkit.org/show_bug.cgi?id=141772 Reviewed by Tim Horton. Adding WebEditingTester, a Cocoa application to test WK1 and Wk2 views in editable mode. * WebEditingTester: Added. * WebEditingTester/AppDelegate.h: Added. * WebEditingTester/AppDelegate.m: Added. (-[WebEditingAppDelegate init]): (defaultConfiguration): (-[WebEditingAppDelegate applicationDidFinishLaunching:]): (-[WebEditingAppDelegate applicationWillTerminate:]): (-[WebEditingAppDelegate newEditor:]): (-[WebEditingAppDelegate showOperations:]): (-[WebEditingAppDelegate useWebKit2ByDefault]): (-[WebEditingAppDelegate toggleUseWK2ByDefault:]): (-[WebEditingAppDelegate validateMenuItem:]): * WebEditingTester/Info.plist: Added. * WebEditingTester/MainMenu.xib: Added. * WebEditingTester/WK1WebDocumentController.h: Added. * WebEditingTester/WK1WebDocumentController.m: Added. (-[WK1WebDocumentController awakeFromNib]): (-[WK1WebDocumentController loadContent]): (-[WK1WebDocumentController dealloc]): (-[WK1WebDocumentController pasteAsMarkup:]): * WebEditingTester/WK2WebDocumentController.h: Added. * WebEditingTester/WK2WebDocumentController.m: Added. (-[WK2WebDocumentController initWithConfiguration:]): (-[WK2WebDocumentController pasteAsMarkup:]): (-[WK2WebDocumentController awakeFromNib]): (-[WK2WebDocumentController dealloc]): (-[WK2WebDocumentController loadContent]): * WebEditingTester/WebDocument.xib: Added. * WebEditingTester/WebDocumentController.h: Added. * WebEditingTester/WebDocumentController.m: Added. (-[WebDocumentController initWithWindow:]): (-[WebDocumentController windowDidLoad]): (-[WebDocumentController defaultEditingSource]): (-[WebDocumentController applicationTerminating]): (-[WebDocumentController loadContent]): * WebEditingTester/WebEditingTester.xcodeproj: Added. * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added. * WebEditingTester/main.m: Added. (main): 2015-02-18 Csaba Osztrogonác <ossy@webkit.org> Run JSC tests on ARM EFL bots https://bugs.webkit.org/show_bug.cgi?id=141165 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunJavaScriptCoreTests.countFailures): (RunRemoteJavaScriptCoreTests): (RunRemoteJavaScriptCoreTests.start): (BuildAndRemoteJSCTestsFactory): (BuildAndRemoteJSCTestsFactory.__init__): 2015-02-18 Alexey Proskuryakov <ap@apple.com> Streamline unexported function build fixes https://bugs.webkit.org/show_bug.cgi?id=141761 Reviewed by Alex Christensen. * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted. We don't need to ignore symbols that are not exported due to the .unexp file. 2015-02-18 Timothy Horton <timothy_horton@apple.com> Remove more references to WebCore.exp.in https://bugs.webkit.org/show_bug.cgi?id=141747 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: (ShouldBuildTest): 2015-02-17 Myles C. Maxfield <mmaxfield@apple.com> Windows test results should not fall back to mac-mountainlion after r180176 https://bugs.webkit.org/show_bug.cgi?id=141719 Reviewed by Brent Fulgham. * BuildSlaveSupport/build.webkit.org-config/wkbuild.py: (_should_file_trigger_build): * Scripts/webkitpy/port/win.py: (WinPort.default_baseline_search_path): * Scripts/webkitpy/port/win_unittest.py: (WinPortTest.test_baseline_search_path): 2015-02-17 Daniel Bates <dabates@apple.com> [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests https://bugs.webkit.org/show_bug.cgi?id=141718 Reviewed by Alex Christensen. We should only run layout tests if simctl can successfully boot and shutdown the testing device. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed(). Log a error and return False if we are unable to boot the simulator device so that the caller can take appropriate action, say exit(3) before running any layout tests. * Scripts/webkitpy/xcode/simulator.py: (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device with the specified UDID. (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device with the specified UDID can successfully boot and shut down. We make at most two attempts to boot and shut down the device, erasing the device between tries so as to restore the device to a known good state. 2015-02-17 Daniel Bates <dabates@apple.com> run_webkit_tests.py should not know about iOS Simulator details https://bugs.webkit.org/show_bug.cgi?id=141711 Reviewed by Alex Christensen. Run_webkit_tests.py should only parse the iOS-specific command line options --runtime and --device-type. Let the port-specific logic in ios.py validate the parsed options and instantiate internal data structures. Currently run_webkit_tests.py parses the iOS-specific command line options --runtime and --device-type, validates them, and instantiates internal data structures from the parsed strings. Instead the validation logic and instantiation of internal data structures should be handled by the iOS port object. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options): Remove logic to validate --runtime and --device-type and instantiate internal data structures for them. * Scripts/webkitpy/port/driver.py: (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type, respectively. * Scripts/webkitpy/port/ios.py: Sort the list of imports. (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime object from --runtime, if specified. Otherwise, instantiates a Runtime object for the latest installed iphonesimulator SDK version. (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType object from --device-type, if specified. Otherwise, instantiates a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit machine, respectively. (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator runtime is available to use. (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type and simulator_runtime for the iOS Simulator device type and runtime, respectively. * Scripts/webkitpy/xcode/simulator.py: (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier() with a runtime identifier for the specified iOS version. 2015-02-17 Dana Burkart <dburkart@apple.com> ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack https://bugs.webkit.org/show_bug.cgi?id=141672 Reviewed by David Kilzer. * asan/webkit-asan-ignore.txt: 2015-02-17 Alex Christensen <achristensen@webkit.org> Remove WebCore.exp.in and clean up. https://bugs.webkit.org/show_bug.cgi?id=141491 Reviewed by Andreas Kling. * Scripts/sort-export-file: Removed. * Scripts/webkitpy/style/checker.py: (_all_categories): (FileType): (CheckerDispatcher._file_type): (CheckerDispatcher._create_checker): Don't check if the export files are sorted. * Scripts/webkitpy/style/checkers/exportfile.py: Removed. * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed. 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com> Unreviewed. Fix GTK+ make distcheck. Do not exclude bmalloc directory from the tarball. * gtk/manifest.txt.in: 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com> Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214. I forgot to add the return of a bool function. * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: (WebKitDOMNodeTest::testDOMCache): 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] GObject DOM bindings object are cached forever https://bugs.webkit.org/show_bug.cgi?id=141558 Reviewed by Sergio Villar Senin. Add checks for all DOM objects to ensure they are not leaked. Also add a dedicated test for the DOM Object Cache. * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: (WebKitDOMNodeFilterTest::testTreeWalker): (WebKitDOMNodeFilterTest::testNodeIterator): * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: (WebKitDOMNodeTest::testHierarchyNavigation): (WebKitDOMNodeTest::testInsertion): (WebKitDOMNodeTest::testTagNames): (WebKitDOMNodeTest::testDOMCache): (registerTests): * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult): (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative): (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom): * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: (testWebKitDOMObjectCache): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (documentLoadedCallback): 2015-02-16 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] WebKitFrame objects are never released https://bugs.webkit.org/show_bug.cgi?id=141641 Reviewed by Martin Robinson. Add a way to check GObjects leaks for WebProcess tests and check WebKitFrame objects are not leaked. * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: (WebKitFrameTest::testMainFrame): (WebKitFrameTest::testURI): (WebKitFrameTest::testJavaScriptContext): * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: (WebProcessTest::assertObjectIsDeletedWhenTestFinishes): (runTest): * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: 2015-02-16 Tim Horton <timothy_horton@apple.com> Fix the MiniBrowser build with newer clang * MiniBrowser/mac/SettingsController.m: (-[SettingsController _toggleBooleanDefault:]): * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController windowWillClose:]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController windowWillClose:]): NSApp is id and clang gets confused about which -delegate we're talking about. 2015-02-16 Antti Koivisto <antti@apple.com> Develop/Disable Caches does not properly disable disk cache https://bugs.webkit.org/show_bug.cgi?id=141636 Reviewed by Anders Carlsson. Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to the network process too. This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::setCacheModel): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Forward to TestController. (WTR::TestRunner::setCacheModel): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 2015-02-16 Andrzej Badowski <a.badowski@samsung.com> Unreviewed. Add myself as a committer. * Scripts/webkitpy/common/config/contributors.json: 2015-02-15 David Kilzer <ddkilzer@apple.com> REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols <http://webkit.org/b/141607> * Scripts/check-for-weak-vtables-and-externals: Ignore weak externals in Source/WebCore/Configurations/WebCore.unexp when building with Xcode 5.x. (readXcode5SymbolsToIgnore): Add. 2015-02-15 KwangHyuk Kim <hyuki.kim@samsung.com> [EFL] fix Evas GL engine error. https://bugs.webkit.org/show_bug.cgi?id=141621 Reviewed by Gyuyoung Kim. As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set. * MiniBrowser/efl/main.c: (elm_main): 2015-02-14 Csaba Osztrogonác <ossy@webkit.org> [buildbot] Enable run-api-tests on release Mac bots https://bugs.webkit.org/show_bug.cgi?id=141518 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunUnitTests): (BuildFactory.__init__): (TestFactory.__init__): (BuildAndTestFactory.__init__): (RunUnitTests.start): Deleted. (unitTestsSupported): Deleted. 2015-02-13 Anders Carlsson <andersca@apple.com> Add a move constructor and move assignment operator to Deque https://bugs.webkit.org/show_bug.cgi?id=141571 Reviewed by Andreas Kling. * TestWebKitAPI/Tests/WTF/Deque.cpp: (TestWebKitAPI::TEST): 2015-02-13 Csaba Osztrogonác <ossy@webkit.org> run-jsc-stress-tests --remote should skip profiler tests https://bugs.webkit.org/show_bug.cgi?id=141470 Reviewed by Filip Pizlo. * Scripts/run-jsc-stress-tests: 2015-02-13 Anders Carlsson <andersca@apple.com> Add an initializer list constructor to Deque https://bugs.webkit.org/show_bug.cgi?id=141565 Reviewed by Andreas Kling. * TestWebKitAPI/Tests/WTF/Deque.cpp: (TestWebKitAPI::TEST): 2015-02-13 Csaba Osztrogonác <ossy@webkit.org> [buildbot] Remove buildJSCTool cruft from master.cfg https://bugs.webkit.org/show_bug.cgi?id=141513 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunJavaScriptCoreTests): (RunJavaScriptCoreTests.start): (RunWebKitTests): (RunWebKitTests.start): (TestFactory.__init__): (TestLeaksFactory.__init__): (RunJavaScriptCoreTests.__init__): Deleted. (RunWebKitTests.__init__): Deleted. 2015-02-13 Csaba Osztrogonác <ossy@webkit.org> Unreviewed, remove empty directories. * DumpRenderTree/gtk: Removed. * DumpRenderTree/gtk/fonts: Removed. * DumpRenderTree/unix: Removed. * DumpRenderTree/unix/TestNetscapePlugin: Removed. * GtkLauncher: Removed. * TestWebKitAPI/Tests/WebKitGtk: Removed. * TestWebKitAPI/Tests/WebKitGtk/resources: Removed. * WebKitTestRunner/WebKitTestRunnerAppTests: Removed. * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed. 2015-02-13 Csaba Osztrogonác <ossy@webkit.org> Remove Windows cruft from Tools/Scripts/build-webkittestrunner https://bugs.webkit.org/show_bug.cgi?id=141519 Reviewed by Alexey Proskuryakov. * Scripts/build-webkittestrunner: 2015-02-12 Alex Christensen <achristensen@webkit.org> Removed empty directory. * WinCELauncher: Removed. 2015-02-12 Csaba Osztrogonác <ossy@webkit.org> run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux https://bugs.webkit.org/show_bug.cgi?id=141202 Reviewed by Darin Adler. * Scripts/run-jsc-stress-tests: 2015-02-12 Brent Fulgham <bfulgham@apple.com> [Win] Test bot infrastructure should not try to find/use old Safari DLLs https://bugs.webkit.org/show_bug.cgi?id=141517 Reviewed by Anders Carlsson. We do not need to locate or use the DLL's that came with Safari, so stop failing when we cannot find them. Also remove some old Qt cruft from this script. * BuildSlaveSupport/built-product-archive: (archiveBuiltProduct): (extractBuiltProduct): 2015-02-11 Brent Fulgham <bfulgham@apple.com> [Win] [64-bit] Work around MSVC2013 Runtime Bug https://bugs.webkit.org/show_bug.cgi?id=141498 <rdar://problem/19803642> Reviewed by Anders Carlsson. Disable FMA3 instruction use in the MSVC math library to work around a VS2013 runtime crash. We can remove this workaround when we switch to VS2015. * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to disable FMA3 support. * DumpRenderTree/win/DumpRenderTree.cpp: Ditto. * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto. * DumpRenderTree/win/TestRunnerWin.cpp: Ditto. * Scripts/webkitperl/httpd.pm: Ditto. * TestWebKitAPI/win/main.cpp: Ditto. * WinLauncher/Common.cpp: Ditto. * win/DLLLauncher/DLLLauncherMain.cpp: Ditto. 2015-02-12 Csaba Osztrogonác <ossy@webkit.org> run-jsc-stress-tests should accept remote host config from JSON file https://bugs.webkit.org/show_bug.cgi?id=141509 Reviewed by Michael Saboff. * Scripts/run-javascriptcore-tests: (runJSCStressTests): * Scripts/run-jsc-stress-tests: 2015-02-12 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add API to allow overriding the default color chooser implementation https://bugs.webkit.org/show_bug.cgi?id=98935 Reviewed by Gustavo Noronha Silva. Add a color chooser implementation for MiniBrowser using GtkPopover when the GTK+ version is recent enough. And a test case to check the new color chooser API. * MiniBrowser/gtk/BrowserWindow.c: (colorChooserRGBAChanged): (popoverColorClosed): (colorChooserRequestFinished): (runColorChooserCallback): (browserWindowConstructed): * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: (testWebViewColorChooserRequest): (beforeAll): 2015-02-11 Csaba Osztrogonác <ossy@webkit.org> Make run-jsc-stress-tests --remote work with make-based runner https://bugs.webkit.org/show_bug.cgi?id=141079 Reviewed by Darin Adler. * Scripts/run-javascriptcore-tests: (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments. * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner, except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner to avoid code duplication. 2015-02-11 Csaba Osztrogonác <ossy@webkit.org> run-jsc-stress tests should detect the number of processors on the remote machine too https://bugs.webkit.org/show_bug.cgi?id=141196 Reviewed by Darin Adler. * Scripts/run-javascriptcore-tests: (runJSCStressTests): Pass through the --child-processes argument. * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function to detect the number of local and remote processors with the same algorithm. Additionally introduced $numChildProcesses to emphasize it isn't necessarily same as $numProcessors. 2015-02-11 Csaba Osztrogonác <ossy@webkit.org> run-jsc-stress-tests should pass JSC_timeout to remote hosts https://bugs.webkit.org/show_bug.cgi?id=141164 Reviewed by Darin Adler. Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one. * Scripts/run-jsc-stress-tests: 2015-02-11 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add default color chooser implementation using GtkColorChooserDialog https://bugs.webkit.org/show_bug.cgi?id=141392 Reviewed by Gustavo Noronha Silva. Enable INPUT_TYPE_COLOR by default for GTK+ port. * Scripts/webkitperl/FeatureList.pm: 2015-02-09 Csaba Osztrogonác <ossy@webkit.org> run-jsc-stress-tests shell test runner should run tests in fixed order https://bugs.webkit.org/show_bug.cgi?id=141383 Reviewed by Darin Adler. * Scripts/jsc-stress-test-helpers/shell-runner.sh: 2015-02-08 Chris Fleizach <cfleizach@apple.com> AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events https://bugs.webkit.org/show_bug.cgi?id=140485 Reviewed by Anders Carlsson. Implement takeFocus() as a way to set focus through accessibility wrappers. * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::takeFocus): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::takeFocus): 2015-02-08 Darin Adler <darin@apple.com> Remove the SVG instance tree https://bugs.webkit.org/show_bug.cgi?id=140602 Reviewed by Dean Jackson. * Scripts/check-for-global-initializers: Removed special case for SVGElementInstance.o. 2015-02-07 David Kilzer <ddkilzer@apple.com> [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable <http://webkit.org/b/141365> Reviewed by Daniel Bates. * Scripts/webkitpy/xcode/simulator.py: (Simulator): Add unavailable_version_re precompiled regex. (Simulator._parse_devices): Check for unavailable versions and ignore them if found when parsing the output of `xcrun simctl list`. * Scripts/webkitpy/xcode/simulator_unittest.py: (test_unavailable_devices): Add test with output from `xcrun simctl list` with unavailable runtimes that fails before the fix. 2015-02-07 Chris Dumez <cdumez@apple.com> Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions https://bugs.webkit.org/show_bug.cgi?id=141321 Reviewed by Darin Adler. Use new Vector::removeFirstMatching() / removeAllMatching() methods. 2015-02-07 David Kilzer <ddkilzer@apple.com> [iOS] Make Simulator class testable <http://webkit.org/b/141358> Rubber-stamped by Darin Adler. * Scripts/webkitpy/common/system/platforminfo.py: (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list` command to here from Simulator.refresh() in xcode/simulator.py so that the output of the command can be mocked. * Scripts/webkitpy/common/system/platforminfo_mock.py: (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list to None. (MockPlatformInfo.xcode_simctl_list): Add method that returns self.expected_xcode_simctl_list expectation. * Scripts/webkitpy/xcode/simulator.py: Add missing copyright and license header. (Simulator.__init__): Add optional 'host' parameter to make it possible to pass in a mock object for testing. Set self._host to 'host' parameter or create Host() object. (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list() method. * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test for current code. (SimulatorTest): (SimulatorTest.setUp): (SimulatorTest._set_expected_xcrun_simctl_list): (SimulatorTest.test_simulator_device_types): (test_invalid_device_types_header): (test_invalid_runtimes_header): (test_invalid_devices_header): 2015-02-07 Csaba Osztrogonác <ossy@webkit.org> run-jsc-stress-tests --remote should use the default ssh port https://bugs.webkit.org/show_bug.cgi?id=141287 Reviewed by Darin Adler. * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number. 2015-02-06 Dana Burkart <dburkart@apple.com> dashboard: BuildbotTesterQueueView crashesOnly logic is wrong https://bugs.webkit.org/show_bug.cgi?id=141349 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): (BuildbotTesterQueueView.prototype.update): 2015-02-06 Alexey Proskuryakov <ap@apple.com> Report network process crashes during layout tests https://bugs.webkit.org/show_bug.cgi?id=139646 Reviewed by Anders Carlsson. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): (WTR::TestController::networkProcessName): (WTR::TestController::networkProcessDidCrash): * WebKitTestRunner/TestController.h: 2015-02-06 Csaba Osztrogonác <ossy@webkit.org> run-jsc-stress-tests --remote should create remote directory before copying the bundle https://bugs.webkit.org/show_bug.cgi?id=141329 Reviewed by Michael Saboff. * Scripts/run-jsc-stress-tests: 2015-02-06 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Remove WebKitWebView::close-notification signal https://bugs.webkit.org/show_bug.cgi?id=141330 Reviewed by Gustavo Noronha Silva. Update notifications unit tests according to the API changes, and add a test case to check that onclose event is fired when a notification is closed by the user. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewNotification): 2015-02-05 Alexey Proskuryakov <ap@apple.com> Dashboard doesn't consider building ASan a productive step https://bugs.webkit.org/show_bug.cgi?id=141312 Reviewed by Simon Fraser. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: 2015-02-05 Daniel Bates <dabates@apple.com> [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime https://bugs.webkit.org/show_bug.cgi?id=141306 Reviewed by Alexey Proskuryakov. The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object corresponding to the last-most runtime parsed from the output of `simctl list` for any non- existent runtime. * Scripts/webkitpy/xcode/simulator.py: (Runtime.from_identifier): 2015-02-05 Daniel Bates <dabates@apple.com> LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app https://bugs.webkit.org/show_bug.cgi?id=139746 <rdar://problem/19283658> Reviewed by Alexey Proskuryakov. Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app if the simulator device is not in state Booted. Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after launching/relaunching the iOS Simulator app and a simulator app can only be installed on a device that is in the Booted state. LayoutTestRelay may run before the device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app. We should defer executing LayoutTestRelay until the simulator device booted by iOS Simulator is in the Booted state. * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing Simulator methods with the module name, simulator. (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state before launching iOS Simulator to boot it. (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator. (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory(). * Scripts/webkitpy/xcode/simulator.py: (Device.__init__): Remove parameter state and an instance variable of the same name, which represented the state of the device when we created this object as part of parsing the output of `simctl list`. Callers interested in the state of the device are more likely interested in the current state of the device as opposed to the state of the device when the Device object was created. (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device. (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called from both this function and Simulator.device_state(). (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function. (Simulator.DeviceState): Added; class of constants. (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified device is in the specified state. (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file. (Simulator.device_directory): Added. (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it. 2015-02-05 Alexey Proskuryakov <ap@apple.com> Disable retries on Mac debug testers https://bugs.webkit.org/show_bug.cgi?id=141296 Reviewed by Simon Fraser. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-02-05 Dan Bernstein <mitz@apple.com> Need a way to force $xcodeSDK in webkitdirs.pm https://bugs.webkit.org/show_bug.cgi?id=141291 Reviewed by Anders Carlsson. * Scripts/webkitdirs.pm: (setXcodeSDK): Added. 2015-02-05 Youenn Fablet <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com> [Streams API] Implement a barebone ReadableStream interface https://bugs.webkit.org/show_bug.cgi?id=141045 Reviewed by Benjamin Poulain. * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch. 2015-02-04 Joseph Pecoraro <pecoraro@apple.com> filter-build-webkit: reduce more unfiltered output https://bugs.webkit.org/show_bug.cgi?id=141282 Reviewed by Daniel Bates. * Scripts/filter-build-webkit: Report CompileDTraceScript and Preprocess lines as successful. 2015-02-04 Dana Burkart <dburkart@apple.com> Botwatcher's Dashboard is cramped https://bugs.webkit.org/show_bug.cgi?id=140273 Reviewed by Alexey Proskuryakov. Add a heading key which will allow for arbitrary headings in builder queues. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): (BuildbotBuilderQueueView.prototype.update): (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: (BuildbotIteration.prototype._parseData): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js: (BuildbotLeaksQueueView.prototype.update): (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js: (BuildbotPerformanceQueueView.prototype.update): (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._unauthorizedAccess): (BuildbotQueueView.prototype._appendBuild): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: (BuildbotTestResults): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): (BuildbotTesterQueueView.prototype.update): (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted. 2015-02-04 Simon Fraser <simon.fraser@apple.com> WKTR should not use -mainScreen to pick a color profile https://bugs.webkit.org/show_bug.cgi?id=141265 Reviewed by Tim Horton. -[NSScreen mainScreen] depends on the active window, so use the first screen (which is the one we put the window on anyway). Do some cleanup in DRT that makes the code look similar. * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::PlatformWebView): 2015-02-04 Simon Fraser <simon.fraser@apple.com> LayoutTestHelper should set the color profile of all displays https://bugs.webkit.org/show_bug.cgi?id=141260 Reviewed by Tim Horton. WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen. which is the screen with the active window. Make things more robust by changing the colorspace of all displays, not just the main screen, when running layout tests. * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC * DumpRenderTree/mac/LayoutTestHelper.m: (originalColorProfileURLs): (colorProfileURLForDisplay): (displayUUIDStrings): (saveDisplayColorProfiles): (setDisplayColorProfile): (restoreDisplayColorProfiles): (installLayoutTestColorProfile): (restoreUserColorProfile): (main): Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not toll-free bridged, sadly). Use the map to restore all profiles on exit. Convert to use more Obj-C types. 2015-02-04 Daniel Bates <dabates@apple.com> test-webkitpy fails on Mac without iphoneos SDK https://bugs.webkit.org/show_bug.cgi?id=141255 <rdar://problem/19619691> I inadvertently committed the wrong exception message. Fix up the exception message to instruct a person to install the iOS SDK when it cannot be found. * Scripts/webkitpy/port/ios.py: (IOSPort.determine_full_port_name): 2015-02-04 Youenn Fablet <youenn.fablet@crf.canon.fr> W3C test importer should sort the list of files when generating the w3c-import.log https://bugs.webkit.org/show_bug.cgi?id=141156 Reviewed by Bem Jones-Bey. Sort explicitly the list of imported files written in the w3c-import.log. Removed logging of the import date. * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.write_import_log): 2015-02-04 Daniel Bates <dabates@apple.com> test-webkitpy fails on Mac without iphoneos SDK https://bugs.webkit.org/show_bug.cgi?id=141255 <rdar://problem/19619691> Reviewed by David Kilzer and Alexey Proskuryakov. Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should should not require the iphoneos SDK to be installed to run the webkitpy tests. * Scripts/webkitpy/common/system/platforminfo.py: (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if installed. We take advantage of the behavior that xcrun --show-sdk-version only writes to standard output if the SDK is installed to return the empty string if the SDK is not installed. * Scripts/webkitpy/common/system/platforminfo_mock.py: (MockPlatformInfo.xcode_sdk_version): Added. * Scripts/webkitpy/port/ios.py: (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version() to get the version of the iphoneos SDK, if installed. 2015-02-04 Alexey Proskuryakov <ap@apple.com> run-webkit-tests doesn't always capture ASan violation reports https://bugs.webkit.org/show_bug.cgi?id=141231 Reviewed by Darin Adler. * Scripts/webkitpy/port/driver.py: (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided by the driver already (as is the case with ASan violations, which are printed to stderr). (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan report. (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into a separate variable for reporting. 2015-02-03 Ryosuke Niwa <rniwa@webkit.org> [webkitpy] Add platform specific Skipped file mechanism for performance tests https://bugs.webkit.org/show_bug.cgi?id=141152 Reviewed by Csaba Osztrogonác. Support a test-expectation-like syntax in performance tests' skipped files. e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports. * Scripts/webkitpy/port/base.py: (Port.skipped_perf_tests): Implemented the syntax support by a regular expression. * Scripts/webkitpy/port/base_unittest.py: (PortTest.test_skipped_perf_tests): Test the new syntax. 2015-02-04 Alexey Proskuryakov <ap@apple.com> When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green https://bugs.webkit.org/show_bug.cgi?id=141236 Reviewed by Sam Weinig. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js: (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus): 2015-02-04 Chris Dumez <cdumez@apple.com> Add removeFirst(value) / removeAll(value) methods to WTF::Vector https://bugs.webkit.org/show_bug.cgi?id=141192 Reviewed by Benjamin Poulain. Add API tests for Vector::removeFirst(value) and Vector::removeAll(value). * TestWebKitAPI/Tests/WTF/Vector.cpp: (TestWebKitAPI::TEST): 2015-02-03 Tim Horton <timothy_horton@apple.com> Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR https://bugs.webkit.org/show_bug.cgi?id=141217 Reviewed by Sam Weinig. * WebKitTestRunner/TestController.cpp: (WTR::copyWebCryptoMasterKey): (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): (WTR::TestController::ensureViewSupportsOptions): (WTR::TestController::didCommitNavigation): (WTR::TestController::didFinishNavigation): (WTR::TestController::canAuthenticateAgainstProtectionSpace): (WTR::TestController::didReceiveAuthenticationChallenge): (WTR::TestController::decidePolicyForPluginLoad): (WTR::TestController::decidePolicyForNavigationAction): (WTR::TestController::decidePolicyForNavigationResponse): (WTR::TestController::didCommitLoadForFrame): Deleted. (WTR::TestController::didFinishLoadForFrame): Deleted. * WebKitTestRunner/TestController.h: Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.) 2015-02-03 Dhi Aurrahman <diorahman@rockybars.com> Unreviewed. Add myself as a committer. * Scripts/webkitpy/common/config/contributors.json: 2015-02-03 Brent Fulgham <bfulgham@apple.com> [Win] Unreviewed test fix. * DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed, so was not matching expected output. 2015-02-03 Youenn Fablet <youenn.fablet@crf.canon.fr> Unreviewed. Moving myself to the committer section at last. * Scripts/webkitpy/common/config/contributors.json: 2015-02-03 Brent Fulgham <bfulgham@apple.com> [Win] Tests fail because DRT reports '(null)' instead of an empty string https://bugs.webkit.org/show_bug.cgi?id=141205 Reviewed by Anders Carlsson. * DumpRenderTree/win/HistoryDelegate.cpp: (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values properly so that we match expected DumpRenderTree output. 2015-02-03 Michael Catanzaro <mcatanzaro@igalia.com> [GTK] TestWebKitAccessibility is not skipped https://bugs.webkit.org/show_bug.cgi?id=141179 Reviewed by Carlos Garcia Campos. Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being skipped, and it apparently works reliably on the bots. * Scripts/run-gtk-tests: (TestRunner): 2015-02-03 Carlos Alberto Lopez Perez <clopez@igalia.com> run-perf-tests: allow to specify a wrapper command. https://bugs.webkit.org/show_bug.cgi?id=141172 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): Update text to indicate is also valid for WTR. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._parse_args): Add wrapper command. 2015-02-03 Brent Fulgham <bfulgham@apple.com> [Win] Correct version parsing warning in update-webkit https://bugs.webkit.org/show_bug.cgi?id=141200 Reviewed by Anders Carlsson. * Scripts/webkitdirs.pm: (setupAppleWinEnv): Strip out any specific version build level from the Cygwin version information. 2015-02-03 Brent Fulgham <bfulgham@apple.com> [Win] Attempt to improve the reliability of HTTP service https://bugs.webkit.org/show_bug.cgi?id=141191 Reviewed by Darin Adler. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location. (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file when stopping the service doesn't do so on its own (for Windows runs). 2015-02-03 Youenn Fablet <youenn.fablet@crf.canon.fr> Web platform test server should not need to create __init__.py files https://bugs.webkit.org/show_bug.cgi?id=141030 Reviewed by Ryosuke Niwa. W3C TestImporter ensures that copied __init__.py files are not empty. If needed, a comment is inserted in __init__.py files. Added a unit test to check that web-platform-tests tools and scripts python modules can be imported. * Scripts/webkitpy/common/system/filesystem.py: (FileSystem.getsize): * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: (TestWebPlatformTestServer.test_start_cmd): (TestWebPlatformTestServer): (TestWebPlatformTestServer.test_import_web_platform_test_modules): * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.import_tests): 2015-01-26 Youenn Fablet <youenn.fablet@crf.canon.fr> Unreviewed. Moving myself to the committer section. * Scripts/webkitpy/common/config/contributors.json: 2015-02-02 Saam Barati <saambarati1@gmail.com> Create tests for JSC's Control Flow Profiler https://bugs.webkit.org/show_bug.cgi?id=141123 Reviewed by Filip Pizlo. * Scripts/run-javascriptcore-tests: (runJSCStressTests): * Scripts/run-jsc-stress-tests: 2015-02-02 Csaba Osztrogonác <ossy@webkit.org> Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests https://bugs.webkit.org/show_bug.cgi?id=141158 Reviewed by Darin Adler. * Scripts/run-jsc-stress-tests: 2015-02-02 Michael Catanzaro <mcatanzaro@igalia.com> [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q https://bugs.webkit.org/show_bug.cgi?id=141142 Reviewed by Carlos Garcia Campos. * MiniBrowser/gtk/BrowserWindow.c: (browser_window_init): Quit on Ctrl+W or Ctrl+Q 2015-02-01 Youenn Fablet <youenn.fablet@crf.canon.fr> Web platform test server is not always launching properly on Mac EWS bots https://bugs.webkit.org/show_bug.cgi?id=141141 Unreviewed. * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules. 2015-01-31 Sam Weinig <sam@webkit.org> Remove even more Mountain Lion support https://bugs.webkit.org/show_bug.cgi?id=141124 Reviewed by Alexey Proskuryakov. * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::attributedStringRangeIsMisspelled): * DumpRenderTree/mac/Configurations/Base.xcconfig: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts): (prepareConsistentTestingEnvironment): * DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): (-[EventSendingController contextClick]): * DumpRenderTree/mac/TextInputController.m: * LayoutTestRelay/Configurations/Base.xcconfig: * LayoutTestRelay/Configurations/DebugRelease.xcconfig: * MiniBrowser/Configurations/Base.xcconfig: * MiniBrowser/Configurations/DebugRelease.xcconfig: * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]): (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]): * TestWebKitAPI/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: (-[DownloadDelegate _downloadDidFinish:]): * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/mac/InjectedBundleControllerMac.mm: (TestWebKitAPI::InjectedBundleController::platformInitialize): * WebKitLauncher/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled): * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts): * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): (WTR::TestController::webProcessName): * WebKitTestRunner/mac/EventSenderProxy.mm: * asan/asan.xcconfig: 2015-01-31 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r179408. https://bugs.webkit.org/show_bug.cgi?id=141117 This didn't fully fix the issue (Requested by anttik on #webkit). Reverted changeset: "OSObjectPtr does not work with dispatch_data_t on Maverics" https://bugs.webkit.org/show_bug.cgi?id=141081 http://trac.webkit.org/changeset/179408 2015-01-31 Youenn Fablet <youenn.fablet@crf.canon.fr> https://trac.webkit.org/changeset/179439 breaks a python test https://bugs.webkit.org/show_bug.cgi?id=141114 Unreviewed. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests. 2015-01-31 Youenn Fablet <youenn.fablet@crf.canon.fr> Import W3C web platform tests infrastructure https://bugs.webkit.org/show_bug.cgi?id=140934 Reviewed by Ryosuke Niwa. Loading necessary web platform tests modules before launching server. Ensuring that some empty __init__.py files are present and create them if necessary. * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: 2015-01-30 Brent Fulgham <bfulgham@apple.com> [Win] Another unreviewed test fix. Correct copy/paste error in buildbot handling. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__): (LayoutTestApacheHttpd._get_apache_config_file_path): 2015-01-30 Brent Fulgham <bfulgham@apple.com> [Win] Unreviewed test fix. Correct path handling based on failures on test bots to get things running again. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__): (LayoutTestApacheHttpd._get_apache_config_file_path): 2015-01-30 Chris Dumez <cdumez@apple.com> Unreviewed. Fix Windows build after r179409. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::notifyDone): (TestRunner::queueLoad): 2015-01-30 Chris Dumez <cdumez@apple.com> Rename shared() static member functions to singleton() for singleton classes. https://bugs.webkit.org/show_bug.cgi?id=141088 Reviewed by Ryosuke Niwa and Benjamin Poulain. Rename shared() static member functions to singleton() for singleton classes as per the recent coding style change. 2015-01-30 Antti Koivisto <antti@apple.com> OSObjectPtr does not work with dispatch_data_t on Maverics https://bugs.webkit.org/show_bug.cgi?id=141081 Reviewed by Pratik Solanki. * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: (TestWebKitAPI::TEST): 2015-01-30 Brent Fulgham <bfulgham@apple.com> [Win] Switch to Apache on Windows https://bugs.webkit.org/show_bug.cgi?id=141060 Reviewed by Alexey Proskuryakov. Update our scripts under Windows (and Cygwin) to locate and use the XAMPP installation of Apache for running tests. * Scripts/run-webkit-httpd: * Scripts/webkitperl/httpd.pm: (getHTTPDPath): (getDefaultConfigForTestDirectory): (getHTTPDConfigPathForTestDirectory): * Scripts/webkitpy/common/system/executive_unittest.py: (ExecutiveTest.serial_test_kill_process): * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__): (LayoutTestApacheHttpd._get_apache_config_file_path): (LayoutTestApacheHttpd._stop_running_server): * Scripts/webkitpy/layout_tests/servers/http_server_base.py: (HttpServerBase._is_server_running_on_all_ports): * Scripts/webkitpy/port/base.py: (Port._apache_config_file_name_for_platform): * Scripts/webkitpy/port/port_testcase.py: (test_apache_config_file_name_for_platform): * Scripts/webkitpy/port/win.py: (WinPort.show_results_html_file): (WinPort._uses_apache): (WinPort): (WinPort._path_to_apache): 2015-01-29 Alexey Proskuryakov <ap@apple.com> Built result takes too long to be compressed on bots https://bugs.webkit.org/show_bug.cgi?id=141056 Reviewed by Daniel Bates. Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger. * BuildSlaveSupport/test-result-archive: (archiveTestResults): 2015-01-29 Sam Weinig <sam@webkit.org> Remove support for screen font substitution https://bugs.webkit.org/show_bug.cgi?id=141038 Reviewed by Tim Horton. * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): Remove call to now setScreenFontSubstitutionEnabled() which is a no-op. 2015-01-29 Csaba Osztrogonác <ossy@webkit.org> Make run-jsc-stress-tests --remote work on Linux too https://bugs.webkit.org/show_bug.cgi?id=141000 Reviewed by Darin Adler. * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl, use bash/dash compatible signal names, use Linux/Mac compatible find options, use bash/dash compatible functions. * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options. 2015-01-29 Csaba Osztrogonác <ossy@webkit.org> [buildbot] Simplify jscore-test buildstep https://bugs.webkit.org/show_bug.cgi?id=140821 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile. (RunJavaScriptCoreTests.countFailures): Added. (RunJavaScriptCoreTests.commandComplete): Deleted. (RunJavaScriptCoreTests.evaluateCommand): Deleted. (RunJavaScriptCoreTests.getText): Deleted. (RunJavaScriptCoreTests.getText2): Deleted. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated. (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output): (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output): (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output): (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output): 2015-01-29 Csaba Osztrogonác <ossy@webkit.org> Unreviewed, revert r179337, we don't need this dependency. * efl/install-dependencies: * gtk/install-dependencies: 2015-01-28 Shivakumar JM <shiva.jm@samsung.com> Unreviewed. Moving myself to the committer section. * Scripts/webkitpy/common/config/contributors.json: 2015-01-28 Csaba Osztrogonác <ossy@webkit.org> URTBF after r179326, added uuid-dev package as new dependency. * efl/install-dependencies: * gtk/install-dependencies: 2015-01-28 Timothy Horton <timothy_horton@apple.com> Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace https://bugs.webkit.org/show_bug.cgi?id=140673 Reviewed by Sam Weinig. * Scripts/dtrace/trace-webkit2-messages.d: Added. Add a DTrace script that outputs a small blob of JSON per message. 2015-01-28 Geoffrey Garen <ggaren@apple.com> Removed fastMallocForbid / fastMallocAllow https://bugs.webkit.org/show_bug.cgi?id=141012 Reviewed by Mark Hahnenberg. Fixed a test bug I noticed while testing. * DumpRenderTree/JavaScriptThreading.cpp: (stopJavaScriptThreads): Lock the javaScriptThreads lock before accessing javaScriptThreads -- otherwise, you'll ASSERT. 2015-01-28 Dana Burkart <dburkart@apple.com> asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address https://bugs.webkit.org/show_bug.cgi?id=141015 Reviewed by Alexey Proskuryakov. * asan/asan.xcconfig: 2015-01-28 Sam Weinig <sam@webkit.org> Fix the build. * Scripts/copy-webkitlibraries-to-product-directory: 2015-01-28 Lucas Forschler <lforschler@apple.com> Increase the FileUpload block size in an attempt to improve network performance. Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (UploadBuiltProduct.__init__): 2015-01-28 Dana Burkart <dburkart@apple.com> Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig https://bugs.webkit.org/show_bug.cgi?id=136765 Reviewed by Alexey Proskuryakov. * DumpRenderTree/mac/Configurations/Base.xcconfig: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * LayoutTestRelay/Configurations/Base.xcconfig: * LayoutTestRelay/Configurations/DebugRelease.xcconfig: * MiniBrowser/Configurations/Base.xcconfig: * MiniBrowser/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * WebKitLauncher/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: 2015-01-28 Joanmarie Diggs <jdiggs@igalia.com> AX: [ATK] Implement support for new AtkRole types for MathML https://bugs.webkit.org/show_bug.cgi?id=140916 Reviewed by Chris Fleizach. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4 2015-01-28 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Stop removing color marks from unit tests output https://bugs.webkit.org/show_bug.cgi?id=140996 Reviewed by Philippe Normand. Since r178236 google tests use a custom simplified output without any colors, so we don't need to handle the case of non ttys to remove the color marks. * Scripts/run-gtk-tests: (TestRunner.__init__): (TestRunner._run_test_command.parse_line): 2015-01-28 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails https://bugs.webkit.org/show_bug.cgi?id=131731 Reviewed by Žan Doberšek. A web page loaded offscreen is in prerender state not hidden. * Scripts/run-gtk-tests: (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewPageVisibility): 2015-01-27 Alexey Proskuryakov <ap@apple.com> Partially revert r178802. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: 2015-01-27 Alexey Proskuryakov <ap@apple.com> build.webkit.org/dashboard asserts on some commits https://bugs.webkit.org/show_bug.cgi?id=140926 Reviewed by Tim Horton. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js: (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory. 2015-01-27 Alexey Proskuryakov <ap@apple.com> Make flakiness dashboard OS list actually match test_expectations.py https://bugs.webkit.org/show_bug.cgi?id=140969 Reviewed by Ryosuke Niwa. * TestResultServer/static-dashboards/flakiness_dashboard.js: 2015-01-27 Brent Fulgham <bfulgham@apple.com> [Win] WinLauncher crashes on eleventh site visited https://bugs.webkit.org/show_bug.cgi?id=140960 Reviewed by Anders Carlsson. * WinLauncher/WinLauncher.cpp: (WinLauncher::showLastVisitedSites): Don't access off the end of the history array. 2015-01-27 Alexey Proskuryakov <ap@apple.com> [Mac] Disable building Java applets by default https://bugs.webkit.org/show_bug.cgi?id=140957 rdar://problem/19619529 Reviewed by Anders Carlsson. It was actually already disabled unconditionally, by accident. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): * Scripts/webkitpy/port/mac.py: (MacPort._check_port_build): (MacPort._build_java_test_support): 2015-01-27 Daniel Bates <dabates@apple.com> [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work https://bugs.webkit.org/show_bug.cgi?id=140949 Reviewed by Alexey Proskuryakov. Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without builders so that run-webkit-tests can lint the appropriate TestExpectation files. * Scripts/webkitpy/port/builders.py: * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here... (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)" in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py. 2015-01-27 Alexey Proskuryakov <ap@apple.com> Update bots on the flakiness dashboard https://bugs.webkit.org/show_bug.cgi?id=140956 Reviewed by Ryosuke Niwa. * TestResultServer/static-dashboards/builders.jsonp: * TestResultServer/static-dashboards/flakiness_dashboard.js: 2015-01-27 Daniel Bates <dabates@apple.com> [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths https://bugs.webkit.org/show_bug.cgi?id=140942 Reviewed by Alexey Proskuryakov. The directory LayoutTests/platform/wk2 contains test expectations and test results that are applicable to all WebKit2 ports. We should make use of this information when running layout tests using iOS WebKit2. Additionally, make use of the convenience function Port._wk2_port_name() for the name of the WebKit2 port instead of directly using string concatenation. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_baseline_search_path): 2015-01-27 Csaba Osztrogonác <ossy@webkit.org> [Win] Disable FTL stress tests https://bugs.webkit.org/show_bug.cgi?id=140932 Reviewed by Brent Fulgham. * Scripts/run-javascriptcore-tests: 2015-01-27 Daniel Bates <dabates@apple.com> REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development https://bugs.webkit.org/show_bug.cgi?id=140939 Reviewed by Eric Carlson. Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106." * Scripts/webkitdirs.pm: (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm and define a function called wanted. 2015-01-27 Daniel Bates <dabates@apple.com> Teach run-webkit-app --simulator how to install custom built app https://bugs.webkit.org/show_bug.cgi?id=140691 Fix inadvertent omission of directory test flag in expression to check for the existence of the iOS simulator device-specific directory for user installed apps. * Scripts/webkitdirs.pm: (hasUserInstalledAppInSimulatorDevice): 2015-01-26 Brent Fulgham <bfulgham@apple.com> [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener https://bugs.webkit.org/show_bug.cgi?id=87426 <rdar://problem/11527899> Reviewed by Darin Adler. Revise COMPtr to work better with our HashMap implementation. Use modern loop syntax. * DumpRenderTree/win/AccessibilityControllerWin.cpp: (AccessibilityController::~AccessibilityController): (AccessibilityController::winNotificationReceived): * DumpRenderTree/win/DumpRenderTree.cpp: (dumpBackForwardListForAllWindows): 2015-01-26 Csaba Osztrogonác <ossy@webkit.org> [Win] Enable JSC stress tests by default https://bugs.webkit.org/show_bug.cgi?id=128307 Reviewed by Brent Fulgham. * Scripts/run-javascriptcore-tests: 2015-01-26 Simon Fraser <simon.fraser@apple.com> [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts https://bugs.webkit.org/show_bug.cgi?id=139748 Reviewed by Daniel Bates. There was much confusion resulting from the multitude of aliases used to build/test for the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout tests directory. This fixes an issue where run-api-tests and some other scripts failed when run with --simulator. * Scripts/build-webkit: * Scripts/package-root: (usage): * Scripts/webkitdirs.pm: (argumentsForConfiguration): (determineXcodeSDK): * Scripts/webkitpy/port/factory.py: (platform_options): 2015-01-26 Simon Fraser <simon.fraser@apple.com> [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed https://bugs.webkit.org/show_bug.cgi?id=140203 rdar://problem/19198492 Reviewed by Sam Weinig. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added. (TEST): 2015-01-26 David Kilzer <ddkilzer@apple.com> Add iOS EWS to build.webkit.org/dashboard <http://webkit.org/b/140627> Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: (BubbleQueueServer): Add ios-ews queue info. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Add iOS8Device platform. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw iOS device logo. 2015-01-26 Filip Pizlo <fpizlo@apple.com> copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set https://bugs.webkit.org/show_bug.cgi?id=140896 Reviewed by Michael Saboff. I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This makes our script do this. Note that an alternative would be to run clang via "xcrun clang" rather than directly, but this would be harder given llvm's autoconf setup. * Scripts/copy-webkitlibraries-to-product-directory: 2015-01-26 Alexey Proskuryakov <ap@apple.com> Update bot assignments. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-01-26 Youenn Fablet <youenn.fablet@crf.canon.fr> Integrate WP python server into WebKit test framework https://bugs.webkit.org/show_bug.cgi?id=127094 Reviewed by Ryosuke Niwa. This patch adds W3C web server (wptserver) as a new HTTP server. wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt. wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt. Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process. Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process. It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server. * Scripts/webkitpy/common/system/executive_mock.py: (MockProcess.communicate): * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter. (LayoutTestRunner.__init__): (LayoutTestRunner.run_tests): (LayoutTestRunner.start_servers): (LayoutTestRunner.stop_servers): * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop. (LayoutTestRunnerTests._run_tests): (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server): (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server): (LayoutTestRunnerTests): (LayoutTestRunnerTests.test_servers_started): * Scripts/webkitpy/layout_tests/controllers/manager.py: Updated to check whether a test is a wpt test and whether wpt server launch is needed. (Manager.__init__): (Manager._is_http_test): (Manager._is_web_platform_test): (Manager._run_tests): * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ManagerTest.test_needs_servers.get_wpt_doc_root): (ManagerTest.test_needs_servers.get_manager): (ManagerTest.test_needs_servers): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server. (parse_args): * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added. (main): * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added. (doc_root): (base_url): (WebPlatformTestServer): (WebPlatformTestServer.__init__): (WebPlatformTestServer._set_start_cmd): (WebPlatformTestServer._copy_webkit_test_files): (WebPlatformTestServer._clean_webkit_test_files): (WebPlatformTestServer._prepare_config): (WebPlatformTestServer._spawn_process): (WebPlatformTestServer._stop_running_server): * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added. (TestWebPlatformTestServer): (TestWebPlatformTestServer.test_start_cmd): * Scripts/webkitpy/port/base.py: (Port.__init__): (Port.to.start_web_platform_test_server): (Port.to): (Port.to.web_platform_test_server_doc_root): (Port.to.web_platform_test_server_base_url): (Port.to.stop_web_platform_test_server): * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines. (Driver.__init__): (Driver.is_web_platform_test): (Driver.test_to_uri): (Driver.uri_to_test): (Driver._command_from_driver_input): * Scripts/webkitpy/port/driver_unittest.py: Updated tests according new conversion rules. (DriverTest.test_test_to_uri): (DriverTest.test_uri_to_test): 2015-01-26 Daniel Bates <dabates@apple.com> Teach run-webkit-app --simulator how to install custom built app https://bugs.webkit.org/show_bug.cgi?id=140691 Reviewed by David Kilzer. We should teach run-webkit-app --simulator how to install a custom built app. Currently run-webkit-app --simulator can only run a system app or an app that was installed using the simctl command line tool. For convenience we should teach run-webkit-app --simulator how to install a custom built app. As a side effect of this change run-safari --simulator will install and run a custom built of MobileSafari (if it exists). * Scripts/webkitdirs.pm: (iOSSimulatorDevices): Added FIXME comment to decouple device representation in Perl from the structure of the device.plist file. (plistPathFromBundle): Fix if-statement condition so that we actually perform a file system check to determine the plist path for a Mac app bundle. (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise, it will complain that it cannot find the file: "Domain ... does not exist". (appDisplayNameFromBundle): Ditto. (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return until a simulator device is the specified state. (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator (if it's open) before opening it again so as to ensure that the iOS Simulator boots the specified device. (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID. As implied by its name, this function will not return until the specified simulator device UDID is in the shutdown state. (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator device with the specified UDID. (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath() before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk, which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk. (hasUserInstalledAppInSimulatorDevice): Added. (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the "Booted" state. (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now, switching between a system installed app and a custom built version of the same app (e.g. custom build of MobileSafari) will erase all contents and settings in the simulator device. (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator() as that was the only caller of this function. (bootedIOSSimulatorDevice): Deleted. (openIOSSimulator): Deleted. 2015-01-26 Alexey Proskuryakov <ap@apple.com> Update bot assignments. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-01-26 Alexey Proskuryakov <ap@apple.com> Leaks bot shouldn't run JSC tests https://bugs.webkit.org/show_bug.cgi?id=140877 Reviewed by Darin Adler. Shaves off 48 minutes of time. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (TestLeaksFactory): Slim down the leaks queue. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.print_leaks_summary): * Scripts/webkitpy/port/mac.py: (MacPort.print_leaks_summary): Don't yell when leaks are detected. 2015-01-26 Csaba Osztrogonác <ossy@webkit.org> Refactor run-javascriptcore-tests https://bugs.webkit.org/show_bug.cgi?id=140824 Reviewed by Darin Adler. Separated mozilla, stress test code paths and determining skipped mozilla tests into subroutines. * Scripts/run-javascriptcore-tests: (runMozillaTests): (runJSCStressTests): (defaultJsDriverArgsForMozillaTests): 2015-01-26 Csaba Osztrogonác <ossy@webkit.org> [buildbot] Fix grammar of TestWithFailureCount https://bugs.webkit.org/show_bug.cgi?id=140884 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (TestWithFailureCount): (TestWithFailureCount.commandComplete): (TestWithFailureCount.getText2): (RunUnitTests): (RunPythonTests): (RunPerlTests): (RunLLINTCLoopTests): (Run32bitJSCTests): * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: (RunLLINTCLoopTestsTest.test_failure): (Run32bitJSCTestsTest.test_failure): (RunUnitTestsTest.assertFailures): 2015-01-26 Youenn Fablet <youenn.fablet@crf.canon.fr> Unreviewed. Moving myself to the committer section. * Scripts/webkitpy/common/config/contributors.json: 2015-01-26 Michael Catanzaro <mcatanzaro@igalia.com> and Carlos Garcia Campos <cgarcia@igalia.com> [GTK] gtkdoc does not appear in DevHelp https://bugs.webkit.org/show_bug.cgi?id=139369 Reviewed by Philippe Normand. * gtk/generate-gtkdoc: Create the generators in the main function and use them to get the local cross renference dependencies. Also pass the generator module name to webkitdom.write_doc_files(). (get_gtkdoc_module_paths): Receive a list of local cross reference dependencies. (get_generator_for_config): Set the main_sgml_file property of the GtkDoc object from the configuration file. (generate_documentation): Generate the documentation for the given generator. (generate_documentation_for_config): Deleted. * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames. * gtk/webkitdom.py: (write_doc_files): Receive the module name used to build the -sections.txt filename. 2015-01-26 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r179107. https://bugs.webkit.org/show_bug.cgi?id=140880 The GCC in the bots doesn't support the AsyncTask implementation (Requested by KaL on #webkit). Reverted changeset: "[GTK] Enable IndexedDB" https://bugs.webkit.org/show_bug.cgi?id=98932 http://trac.webkit.org/changeset/179107 2015-01-26 Csaba Osztrogonác <ossy@webkit.org> [EFL] Bump libseccomp version to 2.1.1 https://bugs.webkit.org/show_bug.cgi?id=140357 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: 2015-01-25 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Enable IndexedDB https://bugs.webkit.org/show_bug.cgi?id=98932 Reviewed by Žan Doberšek. * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port. 2015-01-25 Alexey Proskuryakov <ap@apple.com> Would like leaks bot results at build.webkit.org/dashboard https://bugs.webkit.org/show_bug.cgi?id=122657 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Record links provided by buildbot steps. Currently, the dashboard hardcodes more links than necessary, could use the ones from buildbot in more places. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue): Reflect configuration option for leaks queues. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Add leaks queues to performance column. First, leaks are about performance indeed, and second, this is where we have some space to spare. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at least a year. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: (table.queue-grid td): Moved height from queue-view - we can now have more than one queue view per cell. The heigt is needed to avoid ugly overlapping while loading results - once the results are loaded, all rows are currently higher than that. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css: (.leaks-popover): Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Load BuildbotLeaksQueueView.js. 2015-01-25 peavo@outlook.com <peavo@outlook.com> [Win] Add WebKit message loop interface. https://bugs.webkit.org/show_bug.cgi?id=140857 Reviewed by Brent Fulgham. Added message loop interface which will run the message loop, and perform required tasks (like calling CFRunLoopRunInMode) on each iteration of the loop. * WinLauncher/WinMain.cpp: (wWinMain): Use new message loop interface. 2015-01-24 Dan Bernstein <mitz@apple.com> update-webkit’s --internal option is unused https://bugs.webkit.org/show_bug.cgi?id=140861 Reviewed by Anders Carlsson. * Scripts/update-webkit: Removed the option. 2015-01-24 Brent Fulgham <bfulgham@apple.com> DumpRenderTree needs to run with Windows native controls on Windows https://bugs.webkit.org/show_bug.cgi?id=25592 Reviewed by Anders Carlsson. * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): Tell DRT to use native controls. (prepareConsistentTestingEnvironment): Ditto. 2015-01-23 David Kilzer <ddkilzer@apple.com> test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports <http://webkit.org/b/140787> Reviewed by Daniel Bates. * Scripts/webkitpy/port/ios.py: (IOSPort.determine_full_port_name): Instead of checking the type of the current host, test if /usr/bin/xcrun exists before trying to use it. 2015-01-23 Csaba Osztrogonác <ossy@webkit.org> Fix the false positive build failures on the Windows buildbots https://bugs.webkit.org/show_bug.cgi?id=140819 Reviewed by Brent Fulgham. Increase the build timeout (without producing output) to 2 hours for Windows bots, the default 20 minutes is enough for others since they produce output during the build. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (BuildFactory.__init__): 2015-01-23 Brent Fulgham <bfulgham@apple.com> [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage https://bugs.webkit.org/show_bug.cgi?id=140839 Reviewed by Dean Jackson. * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::language): Retrieve the 'language' BSTR from the IA2Locale structure and pass it to DRT. 2015-01-23 Brent Fulgham <bfulgham@apple.com> [Win] Update DRT Accessibility implementation to better match Mac. https://bugs.webkit.org/show_bug.cgi?id=140830 Reviewed by Dean Jackson. * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::titleUIElement): (AccessibilityUIElement::parentElement): (convertToDRTLabel): (AccessibilityUIElement::role): (AccessibilityUIElement::title): (AccessibilityUIElement::description): (AccessibilityUIElement::stringValue): (AccessibilityUIElement::helpText): (AccessibilityUIElement::isFocused): 2015-01-23 Sergio Villar Senin <svillar@igalia.com> REGRESSION: run-perf-tests --profiler= seems to have broken https://bugs.webkit.org/show_bug.cgi?id=113528 Reviewed by Daniel Bates. The problem is that "perf --record" (or the equivalent call for other profilers) is never called whenever there is a wrapper option in the port. We should inject the profiler call first (should it exists) and then use the port wrapper. * Scripts/webkitpy/port/driver.py: (Driver._command_wrapper): * Scripts/webkitpy/port/driver_unittest.py: (DriverTest.test_profiler_and_wrapper): New unit test. 2015-01-22 David Kilzer <ddkilzer@apple.com> configure-xcode-for-ios-development needs to import webkitdirs.pm <http://webkit.org/b/140704> Fixes the following runtime error: Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167. * Scripts/configure-xcode-for-ios-development: Add back code to import webkitdirs.pm for the exitStatus() method. Not sure why I removed it before patch review. 2015-01-22 Timothy Horton <timothy_horton@apple.com> REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work https://bugs.webkit.org/show_bug.cgi?id=140795 Reviewed by Jon Honeycutt. * BuildSlaveSupport/build.webkit.org-config/config.json: r178847 accidentally remove the scheduler for this bot. Re-add it to the Yosemite scheduler. 2015-01-22 Brent Fulgham <bfulgham@apple.com> [Win] Expose missing editing features through WebView interface https://bugs.webkit.org/show_bug.cgi?id=140773 <rdar://problem/19565421> Reviewed by Dean Jackson. Connect the various WebView editing delegate methods to our test infrastructure. Also prefer _bstr_t to raw BSTR types to simplify life cycle management. * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): * DumpRenderTree/win/EditingDelegate.cpp: (EditingDelegate::QueryInterface): (dumpPath): (dump): (EditingDelegate::shouldBeginEditingInDOMRange): (EditingDelegate::shouldEndEditingInDOMRange): (EditingDelegate::shouldInsertNode): (EditingDelegate::shouldInsertText): (EditingDelegate::shouldDeleteDOMRange): (EditingDelegate::shouldChangeSelectedDOMRange): (EditingDelegate::shouldApplyStyle): (EditingDelegate::shouldChangeTypingStyle): (EditingDelegate::doPlatformCommand): (EditingDelegate::webViewDidBeginEditing): (EditingDelegate::webViewDidChange): (EditingDelegate::webViewDidEndEditing): (EditingDelegate::webViewDidChangeTypingStyle): (EditingDelegate::webViewDidChangeSelection): (EditingDelegate::checkSpellingOfString): (EditingDelegate::onNotify): * DumpRenderTree/win/EditingDelegate.h: 2015-01-22 Ryosuke Niwa <rniwa@webkit.org> Add a build flag for ES6 class syntax https://bugs.webkit.org/show_bug.cgi?id=140760 Reviewed by Michael Saboff. * Scripts/webkitperl/FeatureList.pm: 2015-01-22 Daniel Bates <dabates@apple.com> [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal runtime in simctl output https://bugs.webkit.org/show_bug.cgi?id=140751 Reviewed by David Kilzer. Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies with an error because it does not know how to parse the output of the simctl tool to identify an Apple Internal runtime. * Scripts/webkitpy/xcode/simulator.py: (Runtime.__init__): Add parameter is_internal_runtime (defaults to False). (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality. (Runtime.__repr__): Update printable representation of Runtime object to indicate whether the runtime is an internal runtime. (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime. (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the appropriate value. (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that it updates the appropriate Runtime object. (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support looking up a Runtime object for an internal runtime. 2015-01-22 Alexey Proskuryakov <ap@apple.com> LeaksViewer doesn't show recent builds if there are less than 10 https://bugs.webkit.org/show_bug.cgi?id=140716 Reviewed by Tim Horton. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: 2015-01-22 Lucas Forschler <lforschler@apple.com> Add Apple build slaves. Fixed text alignment for slave list. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-01-21 Lucas Forschler <lforschler@apple.com> Teach build.webkit.org about bot308 and bot309. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-01-21 Lucas Forschler <lforschler@apple.com> Add two Apple Mavericks slaves. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-01-21 Daniel Bates <dabates@apple.com> Add iOS WebKit1 TestExpectation file https://bugs.webkit.org/show_bug.cgi?id=140739 Reviewed by David Kilzer. Teach run-webkit-tests to look for iOS WebKit1-specific test results and expectations in directory LayoutTests/platform/ios-simulator-wk1. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_baseline_search_path): 2015-01-21 David Kilzer <ddkilzer@apple.com> [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK <http://webkit.org/b/140704> Reviewed by Daniel Bates. * Scripts/configure-xcode-for-ios-development: - Update copyright. - Remove FIXME addressed by r178709. - Call copyMissingHeadersToIPhoneOSSDKIfNeeded(). (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy missing headers from iphonesimulator SDK to iphoneos SDK. (sdkDirectory): Add method that returns SDK directory. (sdkPlatformDirectory): Extract method from xcodeSDKSpecificationsPath() that returns SDK platform directory. (xcodeSDKSpecificationsPath): Update to use sdkPlatformDirectory(). 2015-01-21 Alexey Proskuryakov <ap@apple.com> https://build.webkit.org/dashboard/metrics.html fails because of ios-ews https://bugs.webkit.org/show_bug.cgi?id=140731 Reviewed by Tim Horton. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo. 2015-01-21 Brent Fulgham <bfulgham@apple.com> [Win] eventSender does not support scalePageBy https://bugs.webkit.org/show_bug.cgi?id=140726 <rdar://problem/19549865> Reviewed by Dean Jackson. * DumpRenderTree/win/EventSender.cpp: (scalePageByCallback): Provide implementation using new WebView method. 2015-01-21 Lucas Forschler <lforschler@apple.com> Remove Apple Mountain Lion Build & Test slaves. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-01-21 Csaba Osztrogonác <ossy@webkit.org> Remove ENABLE(INSPECTOR) ifdef guards https://bugs.webkit.org/show_bug.cgi?id=140668 Reviewed by Darin Adler. * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::showWebInspector): (TestRunner::closeWebInspector): (TestRunner::evaluateInWebInspector): * Scripts/webkitperl/FeatureList.pm: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::showWebInspector): (WTR::TestRunner::closeWebInspector): (WTR::TestRunner::evaluateInWebInspector): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): 2015-01-20 Alexey Proskuryakov <ap@apple.com> Update build.webkit.org/dashboard to match current Mac queues. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted. (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted. 2015-01-20 Lucas Forschler <lforschler@apple.com> Update Apple MountainLion Leaks slave to Yosemite Update Apple MountainLion Release (32-bit) Build slave to Yosemite Unreviewed. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-01-20 Lucas Forschler <lforschler@apple.com> Update LeaksViewer from MountainLion to Yosemite Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: (LeaksViewer._displayURLPrompt): 2015-01-20 Jake Nielsen <jacob_nielsen@apple.com> Fix EWS python unit tests and address code comments as per 140476 https://bugs.webkit.org/show_bug.cgi?id=140637 Reviewed by David Kilzer. * Scripts/webkitpy/port/base.py: (Port): (Port.__init__): Adds DEFAULT_ARCHITECTURE member. (Port.architecture): Removes architecture member and instead uses self.get_option('architecture'). Also removes redundant architecture method. (Port.set_architecture): Adds a setter for the architecture variable to be able to set a flag upon modification. (Port.test_configuration): Uses self.architecture() instead of self._architecture. * Scripts/webkitpy/port/ios.py: Overrides DEFAULT_ARCHITECTURE. (IOSPort): (IOSPort.determine_full_port_name): Uses subprocess.check_output instead of Popen. Uses rstrip instead of strip. Fixes regex to not match arbitrary characters after the relevent digits are matched. (IOSPort.__init__): Removes old _architecture defaulting strategy. (IOSPort._build_driver_flags): Uses self.architecture() instead of self._architecture. (IOSSimulatorPort): Overrides DEFAULT_ARCHITECTURE. (IOSSimulatorPort.__init__): Removes old _architecture defaulting strategy. * Scripts/webkitpy/port/mac.py: (MacPort): Overrides DEFAULT_ARCHITECTURE. (MacPort.__init__): Removes old _architecture defaulting strategy. * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.run_command): Checks the did_override_architecture flag to determine whether to add the --architecture option. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Uses ews.architecture rather than trying to discern the correct architecture using a port object. (EarlyWarningSystemTest._default_expected_logs): * Scripts/webkitpy/tool/commands/queues.py: Removes use of optparse, and removes the import statement. (AbstractQueue.__init__): (PatchProcessingQueue.begin_work_queue): 2015-01-20 Sam Weinig <sam@webkit.org> Attempt to fix Mountain Lion and EFL tests. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Disable Process-per-tab and network process on Mountain Lion and EFL. 2015-01-20 Darin Adler <darin@apple.com> Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE https://bugs.webkit.org/show_bug.cgi?id=140679 Reviewed by Anders Carlsson. * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Removed a reference to SVGElementInstanceList. 2015-01-20 Michael Catanzaro <mcatanzaro@igalia.com> [GTK] WebViewTest should prohibit overriding initializeWebExtensions() https://bugs.webkit.org/show_bug.cgi?id=140028 Reviewed by Carlos Garcia Campos. This won't work as expected, since this function is called before the WebViewTest constructor completes. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: 2015-01-20 David Kilzer <ddkilzer@apple.com> configure-xcode-for-ios-development needs to update iPhoneOS SDK <http://webkit.org/b/140661> Reviewed by Daniel Bates. * Scripts/configure-xcode-for-ios-development: Add for() loop to run createXcodeSpecificationFilesForSDKIfNeeded() for both "iphoneos" and "iphonesimulator" SDKs. (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from the main body of the script. 2015-01-20 Tomas Popela <tpopela@redhat.com> [GTK] Add API to set the web view editable into WebKit2 GTK+ API https://bugs.webkit.org/show_bug.cgi?id=139443 Reviewed by Carlos Garcia Campos. Create the new test cases for setting the editable property on the web view and on the contenteditable enabled document. Also rework the current tests that are expecting that the web view is editable. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: (loadTestHtml): (testWebViewEditorCutCopyPasteNonEditable): (testWebViewEditorCutCopyPasteEditable): (testWebViewEditorSelectAllNonEditable): (testWebViewEditorSelectAllEditable): (runEditorEditableCutTests): (testWebViewEditorEditableOnNonEditable): (testWebViewEditorEditableOnContentEditable): (testWebViewEditorNonEditable): (beforeAll): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::isEditable): (WebViewTest::setEditable): 2015-01-20 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add an option to create WebKitWebView snapshots with transparent background https://bugs.webkit.org/show_bug.cgi?id=140617 Reviewed by Gustavo Noronha Silva. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewSnapshot): Check that the same snapshot with transparent background is different than the default one filled with white. 2015-01-19 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add API to change the WebKitWebView background color https://bugs.webkit.org/show_bug.cgi?id=140610 Reviewed by Gustavo Noronha Silva. Add --bg-color command line option to MiniBrowser to be able to manually test the API passing any RGBA color to MiniBrowser. Also add a simple unit test to check that getting and setting colors from the API point of view. * MiniBrowser/gtk/BrowserWindow.c: (browser_window_set_background_color): * MiniBrowser/gtk/BrowserWindow.h: * MiniBrowser/gtk/main.c: (createBrowserWindow): (parseBackgroundColor): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewBackgroundColor): (beforeAll): 2015-01-19 Brent Fulgham <bfulgham@apple.com> [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing https://bugs.webkit.org/show_bug.cgi?id=140665 Reviewed by Brian Burg. * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to match expected test output. 2015-01-19 Benjamin Poulain <bpoulain@apple.com> Remove the support for custom suffixes on ChangeLog https://bugs.webkit.org/show_bug.cgi?id=140648 Reviewed by David Kilzer. Custom suffixes were used for the iOS branch of WebKit. Now that everything is opensource, there is no need for it. * Scripts/VCSUtils.pm: (changeLogSuffix): Deleted. (changeLogFileName): Deleted. * Scripts/commit-log-editor: * Scripts/prepare-ChangeLog: (getLatestChangeLogs): (generateNewChangeLogs): (generateFileList): * Scripts/resolve-ChangeLogs: (findChangeLog): 2015-01-19 Timothy Horton <timothy_horton@apple.com> Adjust naming of action menu SPI https://bugs.webkit.org/show_bug.cgi?id=140644 <rdar://problem/19448129> Reviewed by Brian Weinstein. * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]): (TestWebKitAPI::TEST): 2015-01-19 Michael Catanzaro <mcatanzaro@igalia.com> [GTK] Generate the make dist manifest from a CMake template file https://bugs.webkit.org/show_bug.cgi?id=139387 Reviewed by Martin Robinson. Remove the code that performs variable substitution on manifest.txt. Replace the custom variables used in that file with CMake variables. * gtk/make-dist.py: (Manifest.add_directory): (Manifest.get_full_source_path): (Manifest.process_line): (Manifest.resolve_variables): Deleted. (Manifest.get_full_tarball_path): Deleted. * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt. 2015-01-19 Brent Fulgham <bfulgham@apple.com> [Win] Correct merge error in last commit. * DumpRenderTree/win/AccessibilityControllerWin.cpp: (findAccessibleObjectById): Undo accidental paste made during landing. 2015-01-19 Brent Fulgham <bfulgham@apple.com> [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read https://bugs.webkit.org/show_bug.cgi?id=139906 Reviewed by Dean Jackson. WebKit on Windows was creating uninitialized VARIANT structures, then attempting to use them. This patch fixes that. * DumpRenderTree/win/AccessibilityControllerWin.cpp: (findAccessibleObjectById): (AccessibilityController::focusedElement): (logEventProc): (notificationListenerProc): * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::getChildAtIndex): (AccessibilityUIElement::titleUIElement): (self): (AccessibilityUIElement::role): (AccessibilityUIElement::valueDescription): (accessibilityState): (AccessibilityUIElement::isChecked): * DumpRenderTree/win/DumpRenderTree.cpp: (dumpFrameScrollPosition): (dumpFramesAsText): * DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::decidePolicyForNavigationAction): * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::exceededDatabaseQuota): * WinLauncher/Common.cpp: (setWindowText): 2015-01-19 Dean Jackson <dino@apple.com> Add "override" to fix the build with newer clangs. * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: (TestWebKitAPI::CalculationDeletionTestNode::operator==): 2015-01-19 David Kilzer <ddkilzer@apple.com> [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject() <http://webkit.org/b/140623> Reviewed by Daniel Bates. * Scripts/build-webkit: Update help for --device switch. * Scripts/webkitdirs.pm: (determineXcodeSDK): When passing --device, prefer the internal iOS SDK if it exists, else fall back to the external iOS SDK. (buildXCodeProject): Use xcodeSDK() as -sdk argument for xcodebuild instead of trying to sanitize values. 2015-01-19 Alexey Proskuryakov <ap@apple.com> "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests. https://bugs.webkit.org/show_bug.cgi?id=140606 Reviewed by Csaba Osztrogonác. * Scripts/webkitpy/bindings/main.py: (BindingsTests.generate_supplemental_dependency): (BindingsTests.main): 2015-01-19 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] [WK2] TestWebKitWebView snapshot fails https://bugs.webkit.org/show_bug.cgi?id=120404 Reviewed by Žan Doberšek. Rework the test to make sure the snapshot is always created at the desired size. * Scripts/run-gtk-tests: (TestRunner): Unskip /webkit2/WebKitWebView/snapshot. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewSnapshot): Use a fixed size for the document, and disable scrollbars to make sure the visible area is always the WebView size. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width and height parameters to create the window with a given size. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: 2015-01-18 David Kilzer <ddkilzer@apple.com> iOS EWS queue name should be consistent <http://webkit.org/b/140585> Reviewed by Daniel Bates. * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device' to 'ios'. * Scripts/webkitpy/common/config/ports.py: Ditto. (DeprecatedPort.port): (IOSPort): * Scripts/webkitpy/port/ios.py: Ditto. (IOSPort): * Scripts/webkitpy/port/factory.py: (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort appears before ios.IOSPort. If this is not done, `run-webkit-tests --ios-simulator` will get the wrong Port class (IOSPort instead of IOSSimulatorPort) due to the way that PortFactory.get() uses prefix matching of <Port>.port_name to find the correct class to use. 2015-01-18 Alexey Proskuryakov <ap@apple.com> build.webkit.org/dashboard: OS X EWS is now on Mavericks https://bugs.webkit.org/show_bug.cgi?id=140595 Reviewed by Csaba Osztrogonác. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: (BubbleQueueServer): 2015-01-17 David Kilzer <ddkilzer@apple.com> Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots * Scripts/webkitpy/port/ios.py: (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that test-webkitpy doesn't fail since iOS 7.x SDKs are installed on the Mountain Lion and Mavericks bots. 2015-01-17 David Kilzer <ddkilzer@apple.com> Attempt to fix webkitpy tests on GTK Linux ports * Scripts/webkitpy/port/ios.py: (IOSPort.determine_full_port_name): Set a sensible default if not running on a Mac platform or if no iOS SDK is installed. 2015-01-17 Jake Nielsen <jacob_nielsen@apple.com> Create iOS-EWS client queue https://bugs.webkit.org/show_bug.cgi?id=140476 Reviewed by Alexey Proskuryakov. * EWSTools/start-queue-mac.sh: Adds call to configure-xcode-for-ios-development for iOS EWS. * Scripts/webkitpy/common/config/ews.json: Adds the iOS EWS config entry. * Scripts/webkitpy/common/config/ports.py: (DeprecatedPort.port): Adds IOSPort to the port map. (IOSPort): (IOSPort.build_webkit_command): Adds --sdk=iphoneos to the webkit build command. * Scripts/webkitpy/port/base.py: (Port.architecture): Adds an accessor for the architecture member variable. * Scripts/webkitpy/port/factory.py: (PortFactory): Adds IOSPort to the port class list. * Scripts/webkitpy/port/ios.py: Adds the IOSPort to encapsulate iOS-specific things. (IOSPort): (IOSPort.determine_full_port_name): (IOSPort.__init__): (IOSPort._build_driver_flags): (IOSPort.operating_system): * Scripts/webkitpy/tool/commands/download_unittest.py: Adds the archetecture option to the mock options. (DownloadCommandsTest._default_options): * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Appends the archetecture option into calls to webkit-patch. (AbstractEarlyWarningSystem.review_patch): (AbstractEarlyWarningSystem.run_command): (AbstractEarlyWarningSystem.load_ews_classes): * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Adds logic to soothe the unittest now that --architecture is being thrown around everywhere. (EarlyWarningSystemTest._default_expected_logs): * Scripts/webkitpy/tool/commands/queues.py: Adds glue code to ferry the --architecture option around. (AbstractQueue.__init__): (PatchProcessingQueue.begin_work_queue): * Scripts/webkitpy/tool/steps/abstractstep.py: Adds the archetecture option to all AbstractSteps so that EarlyWarningSystem doesn't start shoving --architecture into unsuspecting commands. (AbstractStep.options): * Scripts/webkitpy/tool/steps/build.py: Translates the --architecture option into an ARCHS= format to pass to build-webkit. (Build.build): * Scripts/webkitpy/tool/steps/options.py: Adds a definition for the --architecture option. (Options): 2015-01-16 Sam Weinig <sam@webkit.org> Add a basic configuration object for WKView https://bugs.webkit.org/show_bug.cgi?id=140559 Reviewed by Anders Carlsson. Add tests for WKPageConfigurationRef. * TestWebKitAPI/PlatformWebView.h: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added. (TestWebKitAPI::TEST): (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::setPageLoaderClient): * TestWebKitAPI/mac/PlatformWebViewMac.mm: (TestWebKitAPI::PlatformWebView::initialize): (TestWebKitAPI::PlatformWebView::PlatformWebView): 2015-01-16 Myles C. Maxfield <mmaxfield@apple.com> WeakPtr functions crash when created with default constructor https://bugs.webkit.org/show_bug.cgi?id=140479 Reviewed by Andreas Kling. Add WeakPtr API tests. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added. * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor. 2015-01-16 Chris Dumez <cdumez@apple.com> Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail https://bugs.webkit.org/show_bug.cgi?id=140568 Reviewed by Alexey Proskuryakov. Fix the script parsing CSSPropertyNames.in to stop splitting lines on '=' sign. The '=' sign is also used in StyleBuilder parameters: e.g. "Longhands=background-position-x|background-position-y". This would confuse the script and treat this as a CSS property: "background-position-x|background-position-y". We now split on white space and treat the first string on the line to be the property name (this is the syntax in this file). * Scripts/webkitpy/w3c/test_converter.py: (_W3CTestConverter.__init__): (_W3CTestConverter.read_webkit_prefixed_css_property_list): 2015-01-16 Daniel Bates <dabates@apple.com> REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS https://bugs.webkit.org/show_bug.cgi?id=135589 Reviewed by David Kilzer. Derived from a patch by David Farler. Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968> run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari in terms of the simctl command line utility. * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED. (eraseIOSSimulatorDevice): Added. (bootedIOSSimulatorDevice): Added. (iosSimulatorApplicationsPath): Added. (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath(). (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1). (quitIOSSimulator): Added. (iosSimulatorDeviceByName): Modified to find the first simulator device that matches the specified name and currently selected iOS runtime. (isIOSSimulatorSystemInstalledApp): Added. (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator. (deleteiOSSimulatorDevice): Deleted. (loadIPhoneSimulatorNotificationIfNeeded): Deleted. (installAndLaunchIOSWebKitAppInSimulator): Deleted. 2015-01-16 Alex Christensen <alex.christensen@flexsim.com> Resurrect the WinCairo bot. https://bugs.webkit.org/show_bug.cgi?id=139908 Reviewed by Csaba Osztrogonác. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (appendCustomBuildFlags): * BuildSlaveSupport/test-result-archive: (archiveTestResults): Add WinCairo buildbot. 2015-01-16 Chris Dumez <cdumez@apple.com> webkit-patch should auto-install the keyring python module https://bugs.webkit.org/show_bug.cgi?id=140547 Reviewed by David Kilzer. Auto-install the keyring python module. This is the module that webkit-patch uses for cross-platform access to the keyring service. Without this module, if the password if not in the keychain, webkit-patch will keep asking for your username / password and never remember them. * Scripts/webkitpy/common/net/credentials.py: * Scripts/webkitpy/thirdparty/__init__.py: (AutoinstallImportHook.find_module): (AutoinstallImportHook._install_keyring): 2015-01-15 Csaba Osztrogonác <ossy@webkit.org> Remove ENABLE(SQL_DATABASE) guards https://bugs.webkit.org/show_bug.cgi?id=140434 Reviewed by Darin Adler. * Scripts/webkitperl/FeatureList.pm: 2015-01-15 Daniel Bates <dabates@apple.com> [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice https://bugs.webkit.org/show_bug.cgi?id=139685 <rdar://problem/19281317> Reviewed by Simon Fraser. Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular, the test LayoutTests/fast/dom/gc-10.html may dump its result twice. Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously as opposed to synchronously. So, the WebThread or the main thread may perform other tasks before DRT dumps the output of a test. In particular, the WebThread may start a new page load (say, as a result of continued JavaScript execution), which will ultimately lead to dumping the test result again. Instead we want DRT to dump the test result synchronously such that we capture the state of the web page either when the page is loaded or when window.testRunner.notifyDone() is called. * DumpRenderTree/ios/PixelDumpSupportIOS.mm: (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to flush CA transactions to the window. * DumpRenderTree/mac/DumpRenderTree.mm: (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test. (dump): Renamed; formerly named dumpTestResults(). (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate enabling repaint support on iOS. (-[DumpRenderTree _deferDumpToMainThread]): Deleted. (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted. (dumpTestResults): Deleted. 2015-01-15 Brent Fulgham <bfulgham@apple.com> [Win] Miscellaneous DRT fixes https://bugs.webkit.org/show_bug.cgi?id=116562 Reviewed by Tim Horton. While investigating the cause of several Windows crashes, I found: (1) Messy conversions to and from BSTR types (2) Weird mixes of wide-string and narrow string conversions (3) Passing nullptr to some CoreFoundation routines that do not permit null arguments. (4) Commands to link the executable to the VS2005 runtime. This patch cleans up these issues to improve DRT reliability on Windows. * DumpRenderTree/cg/ImageDiffCG.cpp: (main): Get rid of VS2005 runtime linking. * DumpRenderTree/win/DumpRenderTree.cpp: (urlSuitableForTestResult): Protect against being asked to process an empty URL. (dumpHistoryItem): Do BSTR string building using _bstr_t, rather than converting to/from wchar_t buffers. (runTest): Simplify string and BSTR handling. (createWebViewAndOffscreenWindow): Ditto. (main): Get rid of VS2005 runtime linking. * DumpRenderTree/win/TestRunnerWin.cpp: (jsStringRefToWString): Simplify code. (TestRunner::pathToLocalResource): (TestRunner::setUserStyleSheetLocation): * TestWebKitAPI/win/main.cpp: Get rid of VS2005 runtime linking. * win/DLLLauncher/DLLLauncherMain.cpp: (wWinMain): Ditto. 2015-01-15 Alexey Proskuryakov <ap@apple.com> Stop hardcoding mac-mountainlion in commit queue https://bugs.webkit.org/show_bug.cgi?id=140492 Reviewed by Anders Carlsson. Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and there should be no change in behavior, because: 1. PatchProcessingQueue converts the name with _new_port_name_from_old() before using it to create a port object. 2. Although it doesn't convert the name before using DeprecatedPort.port(), it is actually correct to use "mac" for the name there. We only used to get the expected behavior with "mac-mountainlion" accidentally, because of a fallback to "mac" for unknown deprecated port names. * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue): 2015-01-14 Jake Nielsen <jacob_nielsen@apple.com> Create iOS-EWS server queue https://bugs.webkit.org/show_bug.cgi?id=140473 Reviewed by Benjamin Poulain. * QueueStatusServer/app.yaml: Updates the SVN version number. * QueueStatusServer/config/queues.py: Add ios-ews queue. * QueueStatusServer/model/queues.py: (Queue.display_name): Makes sure the display name is pretty! 2015-01-14 Daniel Bates <dabates@apple.com> [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime https://bugs.webkit.org/show_bug.cgi?id=140301 <rdar://problem/19389266> Reviewed by Jon Honeycutt. Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator with an unavailable runtime. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime, which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the specified runtime cannot be used because it is unavailable. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(), which was formerly named testing_device. * Scripts/webkitpy/xcode/simulator.py: (Device.create): Modified to lookup created device by the UDID returned by simctl, which is more robust than looking up the simulator device by name and runtime. This approach also avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows unavailable runtimes under the same iOS heading it would use to show it as available). (Simulator.find_device_by_udid): Added. (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults to False) to ignore devices that are unavailable (say, because their runtime is unavailable). (Simulator.available_runtimes): Added. (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage of the reverse=True argument to sorted() to sort the list of available runtimes such that the first element of the sorted list is the runtime with the highest version number. (Simulator.lookup_or_create_device): Renamed; formerly named testing_device. 2015-01-14 Csaba Osztrogonác <ossy@webkit.org> Remove WK2 Windows cruft https://bugs.webkit.org/show_bug.cgi?id=140440 Reviewed by Anders Carlsson. * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed. * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed. * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed. 2015-01-13 Hunseop Jeong <hs85.jeong@samsung.com> Fix TestWTF failed in TestWebKitAPI https://bugs.webkit.org/show_bug.cgi?id=140333 Reviewed by Sam Weinig. Clear the std::ostringstream before starting test. * TestWebKitAPI/Tests/WTF/RefLogger.h: (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger): 2015-01-13 Michael Catanzaro <mcatanzaro@igalia.com> TestWebKitWebContext depends on British English spellcheck dictionary https://bugs.webkit.org/show_bug.cgi?id=140403 Reviewed by Martin Robinson. Install all English hunspell dictionaries on Fedora and Arch. * gtk/install-dependencies: 2015-01-13 Michael Catanzaro <mcatanzaro@igalia.com> [GTK] install-dependencies should grok dnf https://bugs.webkit.org/show_bug.cgi?id=140396 Reviewed by Martin Robinson. Fedora: install dependencies with dnf if yum is not installed. * gtk/install-dependencies: 2015-01-12 Hunseop Jeong <hs85.jeong@samsung.com> [EFL][GTK] Fix build after r178309 https://bugs.webkit.org/show_bug.cgi?id=140381 Reviewed by Gyuyoung Kim. * TestWebKitAPI/CMakeLists.txt: Added the API directory 2015-01-11 Sam Weinig <sam@webkit.org> Remove support for SharedWorkers https://bugs.webkit.org/show_bug.cgi?id=140344 Reviewed by Anders Carlsson. * Scripts/webkitperl/FeatureList.pm: 2015-01-12 Anders Carlsson <andersca@apple.com> Make delegates conform to formal delegate protocols https://bugs.webkit.org/show_bug.cgi?id=140370 Reviewed by Dan Bernstein. * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::numberOfPendingGeolocationPermissionRequests): (TestRunner::setGeolocationPermission): 2015-01-10 Michael Catanzaro <mcatanzaro@igalia.com> build-webkit: silence output of 'which' https://bugs.webkit.org/show_bug.cgi?id=140278 Reviewed by Daniel Bates. Use a more elegent test for the existance of ninja and eclipse. * Scripts/webkitdirs.pm: (commandExists): Don't assume the command supports --version (canUseNinja): Use commandExists() (canUseEclipse): Use commandExists() 2015-01-09 Sam Weinig <sam@webkit.org> Update the output format for run-api-tests https://bugs.webkit.org/show_bug.cgi?id=140332 Reviewed by Dan Bernstein. Changes the output format for run-api-tests be a bit simpler (no longer indented based on suite, as we were not really using suite very well) but also include details in the case of failure. Changes verbose mode to no longer spew out the gtest default printer output, as the custom printer now includes the failure information. * Scripts/run-api-tests: (runTestsBySuite): (runTest): Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**" with colorized variants and strip out leaks spew (the leaks can be added back using the new --show-leaks argument). * TestWebKitAPI/TestsController.cpp: (TestWebKitAPI::Printer::OnTestPartResult): (TestWebKitAPI::Printer::OnTestEnd): (TestWebKitAPI::TestsController::run): Implement a custom result printer that just prints out the information we want. 2015-01-09 Sam Weinig <sam@webkit.org> TestWebKitAPI should print out the lists that fail at the end https://bugs.webkit.org/show_bug.cgi?id=140329 Reviewed by Tim Horton. * Scripts/run-api-tests: (runTestsBySuite): Print out failures and timeouts in all modes, not just verbose. 2015-01-07 Geoffrey Garen <ggaren@apple.com> Make bmalloc work with ASan https://bugs.webkit.org/show_bug.cgi?id=140194 Reviewed by Mark Lam. * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports ASan automatically (by forwarding to system malloc at runtime). 2015-01-09 Daniel Bates <dabates@apple.com> [iOS] Make DumpRenderTree build with public SDK https://bugs.webkit.org/show_bug.cgi?id=140311 Reviewed by Sam Weinig. Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in header UIKit/UIMath.h), and std::max() instead of the macro function MAX. Additionally, remove unused header CoreGraphics/CGFontDB.h. * DumpRenderTree/mac/DumpRenderTree.mm: (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]): 2015-01-09 Alexey Proskuryakov <ap@apple.com> platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines https://bugs.webkit.org/show_bug.cgi?id=140300 Reviewed by Simon Fraser. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::updateWindowScaleForTest): (WTR::TestController::configureViewForTest): * WebKitTestRunner/TestController.h: 2015-01-09 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> Unreviewed. Moving myself to the committer section. * Scripts/webkitpy/common/config/contributors.json: 2015-01-09 Carlos Garcia Campos <cgarcia@igalia.com> Add a script to check for platform layering violations https://bugs.webkit.org/show_bug.cgi?id=140248 Reviewed by Darin Adler. It prints all the cases where files inside platform include headers that are not in platform directory. * Scripts/check-for-platform-layering-violations: Added. (get_platform_headers): (check_source_file): 2015-01-08 Alexey Proskuryakov <ap@apple.com> [Mac WK2] Test snapshots are 1600x1200 on Retina devices https://bugs.webkit.org/show_bug.cgi?id=139884 Reviewed by Tim Horton. * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage): Tell CGWindowListCreateImage to use the correct resolution. I don't really understand what the "nominal resolution" is, but this appears to work in practice. 2015-01-08 Brent Fulgham <bfulgham@apple.com> [Win] DumpRenderTree is always using 800x600 size, even if tests need other size. https://bugs.webkit.org/show_bug.cgi?id=140256 Reviewed by Anders Carlsson. * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while running with heap validation checks. (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for the "svg\\W3C-SVG-1.1" test directory. (removeFontFallbackIfPresent): Use nullptr instead of 0. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearPersistentUserStyleSheet): Ditto. 2015-01-08 Alexey Proskuryakov <ap@apple.com> Follow-up to: When WebProcess is slow to respond to IPC, that's mistakenly reported as crash https://bugs.webkit.org/show_bug.cgi?id=140218 * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness): Undone an accidental change - check for self.has_crashed() again. This code path is for ports that don't have a signal handler printing #CRASHED when main process crashes. * Scripts/webkitpy/port/driver_unittest.py: (DriverTest.test_check_for_driver_crash.assert_crash): (DriverTest.test_check_for_driver_crash): Updated the tests, all changes are expected. 2015-01-08 Alexey Proskuryakov <ap@apple.com> When WebProcess is slow to respond to IPC, that's mistakenly reported as crash https://bugs.webkit.org/show_bug.cgi?id=140218 Reviewed by Darin Adler. * Scripts/webkitpy/port/driver.py: (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for "process crashed" condition. These don't make sense together - it's either a crash or a timeout, and we should detect those properly at a much lower level. (Driver.run_test): Ditto. (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness cases. * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::webProcessName): (WTR::TestController::processDidCrash): Factored out hardcoded child process names, as we now use these in two places. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child process name, so that it can be sampled (fixes sampling on Mavericks and above). 2015-01-08 Zan Dobersek <zdobersek@igalia.com> Reorder my list of email addresses, keeping the Bugzilla address at the top since Bugzilla and other webkitpy scripts rely on that ordering. * Scripts/webkitpy/common/config/contributors.json: 2015-01-08 Zan Dobersek <zdobersek@igalia.com> Moving myself to the reviewers section and updating the list of my email addresses. * Scripts/webkitpy/common/config/contributors.json: 2015-01-07 Michael Catanzaro <mcatanzaro@igalia.com> [GTK] Build gtk-doc without gtkdoc-mktmpl https://bugs.webkit.org/show_bug.cgi?id=140225 Reviewed by Darin Adler. Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we don't modify the tmpl files that it generates, it's not doing anything for us. * gtk/gtkdoc.py: (GTKDoc.generate): (GTKDoc._run_gtkdoc_scangobj): (GTKDoc._run_gtkdoc_mktmpl): Deleted. 2015-01-07 Gwang Yoon Hwang <yoon@igalia.com> [GTK][ThreadedCompositor] Add support for threaded compositor. https://bugs.webkit.org/show_bug.cgi?id=118265 Reviewed by Martin Robinson. Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and autotools build systems. The feature is disabled by default. And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag from the feature flags. * Scripts/webkitperl/FeatureList.pm: 2015-01-07 Daniel Bates <dabates@apple.com> [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT https://bugs.webkit.org/show_bug.cgi?id=137371 Reviewed by David Kilzer. Use SPI wrapper headers instead of directly referencing private SPI headers. * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: * DumpRenderTree/ios/PixelDumpSupportIOS.mm: * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios to the list of iOS header search directories so that we can include header UIKitSPI.h. * DumpRenderTree/mac/DumpRenderTree.mm: * DumpRenderTree/mac/DumpRenderTreeWindow.h: * DumpRenderTree/mac/EventSendingController.mm: * DumpRenderTree/mac/TestRunnerMac.mm: 2015-01-07 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r178068. https://bugs.webkit.org/show_bug.cgi?id=140235 Breaks the iOS build (Requested by enrica on #webkit). Reverted changeset: "[iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT" https://bugs.webkit.org/show_bug.cgi?id=137371 http://trac.webkit.org/changeset/178068 2015-01-07 Daniel Bates <dabates@apple.com> [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT https://bugs.webkit.org/show_bug.cgi?id=137371 Reviewed by David Kilzer. Use SPI wrapper headers instead of directly referencing private SPI headers. * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: * DumpRenderTree/ios/PixelDumpSupportIOS.mm: * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios to the list of header search directories so that we can include header UIKitSPI.h. * DumpRenderTree/mac/DumpRenderTree.mm: * DumpRenderTree/mac/DumpRenderTreeWindow.h: * DumpRenderTree/mac/EventSendingController.mm: * DumpRenderTree/mac/TestRunnerMac.mm: 2015-01-07 Brent Fulgham <bfulgham@apple.com> [Win] Unreviewed test change to improve run reproducibility * Scripts/webkitpy/port/win.py: (WinPort.default_child_processes): Run a single DRT instance to help identify failures caused by earlier test runs. 2015-01-07 Myles C. Maxfield <mmaxfield@apple.com> Myles C. Maxfield is a reviewer now https://bugs.webkit.org/show_bug.cgi?id=140196 Reviewed by Dean Jackson. * Scripts/webkitpy/common/config/contributors.json: 2015-01-07 Myles C. Maxfield <mmaxfield@apple.com> Make webkit-patch try harder to find keychain credentials https://bugs.webkit.org/show_bug.cgi?id=140170 Reviewed by Ryosuke Niwa. When the user manually enters a password into webkit-patch, we hand that off to the Keyring Python module. However, that module creates a generic password entry instead of an internet password entry. We should look for both kinds. * Scripts/webkitpy/common/net/credentials.py: (Credentials._run_security_tool): (Credentials._credentials_from_keychain): * Scripts/webkitpy/common/net/credentials_unittest.py: (test_security_output_parse_entry_not_found): (_assert_security_call): 2015-01-06 Anders Carlsson <andersca@apple.com> Try to fix the Mountain Lion build. * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: (TestWebKitAPI::didGetImageForMatchResult): 2015-01-06 Alexey Proskuryakov <ap@apple.com> Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry https://bugs.webkit.org/show_bug.cgi?id=140095 Reviewed by Anders Carlsson. * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release builds, but not in debug ones. 2015-01-06 Brent Fulgham <bfulgham@apple.com> [Win] Extend WinLauncher with support for Page Zoom https://bugs.webkit.org/show_bug.cgi?id=140152 Reviewed by Anders Carlsson. * WinLauncher/Common.cpp: (WndProc): * WinLauncher/WinLauncher.cpp: (WinLauncher::resetZoom): (WinLauncher::zoomIn): (WinLauncher::zoomOut): * WinLauncher/WinLauncher.h: * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: * win/DLLLauncher/DLLLauncherMain.cpp: (wWinMain): 2015-01-06 Anders Carlsson <andersca@apple.com> Fix API tests that are broken under HiDPI https://bugs.webkit.org/show_bug.cgi?id=140146 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: (TestWebKitAPI::didGetImageForMatchResult): NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels. * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: (TestWebKitAPI::DeviceScaleFactorOnBack::runTest): Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start out in a window that has a backing scale factor of 1. * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Ditto. 2015-01-06 Alexey Proskuryakov <ap@apple.com> ADDRESS_SANITIZER macro is overloaded https://bugs.webkit.org/show_bug.cgi?id=140130 Reviewed by Anders Carlsson. * WebKitTestRunner/TestController.cpp: Use the new macro. 2015-01-05 Joseph Pecoraro <pecoraro@apple.com> Remove some stale class names in check-for-inappropriate-objc-class-names https://bugs.webkit.org/show_bug.cgi?id=140104 Reviewed by Darin Adler. * Scripts/check-for-inappropriate-objc-class-names: These UIWK* classes no longer exist. 2015-01-05 Anders Carlsson <andersca@apple.com> heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html https://bugs.webkit.org/show_bug.cgi?id=140096 rdar://problem/19368938 Reviewed by Alexey Proskuryakov. When creating a new page, don't pass clientInfo when setting up the frame and policy clients, since clientInfo points to a web view, not the test controller. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): 2015-01-05 Hunseop Jeong <hs85.jeong@samsung.com> [EFL][GTK] WKPreferencesDefaults test failed after r177506 https://bugs.webkit.org/show_bug.cgi?id=140077 Reviewed by Csaba Osztrogonác. WebKit C SPI is available on EFL,GTK. Changed the define order to pass the API test. * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: (TestWebKitAPI::TEST): 2015-01-01 Alexey Proskuryakov <ap@apple.com> Simplify WebKitTestRunner timeout tracking https://bugs.webkit.org/show_bug.cgi?id=140036 Reviewed by Darin Adler. The code for configuring timeouts was mostly dead, because run-webkit-tests never passes the --timeout option to WebKitTestRunner. * WebKitTestRunner/Options.h: * WebKitTestRunner/Options.cpp: (WTR::Options::Options): (WTR::OptionsHandler::OptionsHandler): (WTR::handleOptionTimeout): Deleted. Removed support for --timeout. Timeouts are passed for each test individually, and defaults are good enough for the rare cases where WebKitTestRunner is run manually without run-webkit-tests. * WebKitTestRunner/TestController.cpp: (WTR::TestController::TestController): (WTR::TestController::initialize): (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::reattachPageToWebProcess): (WTR::TestController::runUntil): * WebKitTestRunner/TestController.h: Simplified runUntil by passing the actual timeout, not an enum. Increased short timeout for ASan enabled builds, as WebProcess launching takes quite a while. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout. * WebKitTestRunner/efl/TestControllerEfl.cpp: (WTR::TestController::platformRunUntil): * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::platformRunUntil): Build fixes. 2015-01-02 Anders Carlsson <andersca@apple.com> Remove now unused storage tracker glue from DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=140045 Reviewed by Darin Adler. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/StorageTrackerDelegate.h: Removed. * DumpRenderTree/StorageTrackerDelegate.mm: Removed. * DumpRenderTree/TestRunner.cpp: (TestRunner::staticFunctions): (syncLocalStorageCallback): Deleted. (observeStorageTrackerNotificationsCallback): Deleted. (deleteAllLocalStorageCallback): Deleted. (deleteLocalStorageForOriginCallback): Deleted. (localStorageDiskUsageForOriginCallback): Deleted. (originsWithLocalStorageCallback): Deleted. * DumpRenderTree/TestRunner.h: * DumpRenderTree/mac/DumpRenderTree.mm: (allocateGlobalControllers): (releaseGlobalControllers): * DumpRenderTree/mac/DumpRenderTreeMac.h: * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::syncLocalStorage): Deleted. (TestRunner::localStorageDiskUsageForOrigin): Deleted. (TestRunner::observeStorageTrackerNotifications): Deleted. (TestRunner::deleteAllLocalStorage): Deleted. (TestRunner::originsWithLocalStorage): Deleted. (TestRunner::deleteLocalStorageForOrigin): Deleted. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::syncLocalStorage): Deleted. (TestRunner::localStorageDiskUsageForOrigin): Deleted. (TestRunner::observeStorageTrackerNotifications): Deleted. (TestRunner::deleteAllLocalStorage): Deleted. (TestRunner::originsWithLocalStorage): Deleted. (TestRunner::deleteLocalStorageForOrigin): Deleted. 2015-01-01 Darin Adler <darin@apple.com> We often misspell identifier as "identifer" https://bugs.webkit.org/show_bug.cgi?id=140025 Reviewed by Michael Saboff. * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: * Scripts/webkitdirs.pm: (appIdentifierFromBundle): (installAndLaunchIOSWebKitAppInSimulator): Fix misspellings 2015-01-01 Zalan Bujtas <zalan@apple.com> Saturated arithmetics: Incorrect float/double clamping. https://bugs.webkit.org/show_bug.cgi?id=139888 rdar://problem/19330885 Reviewed by Simon Fraser. Clamp float and double values correctly when applying saturated arithmetics. * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: (TestWebKitAPI::TEST): 2014-12-30 Krzysztof Czech <k.czech@samsung.com> [EFL] Bump version of ATK used by jhbuild to 2.15.2 https://bugs.webkit.org/show_bug.cgi?id=139816 Reviewed by Gyuyoung Kim. Bump version of ATK used by jhbuild to 2.15.2 * efl/jhbuild.modules: 2014-12-29 Fabien Vallée <fvallee@connected-labs.com> [jhBuild] cairo build error (-flto) https://bugs.webkit.org/show_bug.cgi?id=139056 Reviewed by Philippe Normand. cairo fails to link with gcc 4.9 due to lto related issue. This problem has been partially addressed by cairo: http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c use the cairo --disable-lto option and remove jhbuild makeargs fixes the issue. * gtk/jhbuild.modules: * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added. 2014-12-27 Myles C. Maxfield <mmaxfield@apple.com> [Mac] Enable kerning, ligatures, and printer fonts https://bugs.webkit.org/show_bug.cgi?id=139970 Rubber stamped by Simon Fraser. Flip the switch. * DumpRenderTree/mac/DumpRenderTree.mm: * WebKitTestRunner/TestController.cpp: * WebKitTestRunner/mac/main.mm: 2014-12-26 Dan Bernstein <mitz@apple.com> <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain https://bugs.webkit.org/show_bug.cgi?id=139950 Reviewed by David Kilzer. * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so in a manner that works with Xcode 5.1.1. 2014-12-24 Dan Bernstein <mitz@apple.com> Engineering builds of MiniBrowser ignore deprecated declaration warnings https://bugs.webkit.org/show_bug.cgi?id=139941 Reviewed by Darin Adler. * MiniBrowser/Configurations/Base.xcconfig: Added semicolon. * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS to YES. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of deprecated NSOKButton. 2014-12-24 Youenn Fablet <youenn.fablet@crf.canon.fr> W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion https://bugs.webkit.org/show_bug.cgi?id=134763 Reviewed by Ryosuke Niwa. Adding an option to disable test harness link conversion. * Scripts/webkitpy/w3c/test_converter.py: (convert_for_webkit): (_W3CTestConverter.__init__): (_W3CTestConverter.convert_attributes_if_needed): * Scripts/webkitpy/w3c/test_importer.py: (parse_args): (TestImporter.import_tests): 2014-12-23 Alexey Proskuryakov <ap@apple.com> DumpRenderTree crashes are mis-reported as timeouts on Yosemite https://bugs.webkit.org/show_bug.cgi?id=139933 Reviewed by Daniel Bates. Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447), and there is no way for run-webkit-tests to tell a crashed process from a frozen one until ReportCrash lets it go. Reuse existing machinery that tells run-webkit-tests about crashes. The script may even get the actual crash log eventually - even when it times out waiting for the log, it makes a second lookup at the very end, after all tests finish. There may be further improvements needed here, but this small fix addresses most cases that happen in practice. * DumpRenderTree/mac/DumpRenderTree.mm: (writeCrashedMessageOnFatalError): (dumpRenderTree): Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac. * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an unhelpful comment. 2014-12-23 Alexey Proskuryakov <ap@apple.com> Don't force -O1 for debug ASan builds https://bugs.webkit.org/show_bug.cgi?id=139926 Reviewed by Darin Adler. * asan/asan.xcconfig: 2014-12-23 Alexey Proskuryakov <ap@apple.com> Simplify building with ASan https://bugs.webkit.org/show_bug.cgi?id=139916 Reviewed by Mark Rowe. * Scripts/set-webkit-configuration: Store ASan state into a new configuration file. We could also update Configuration file format, but that's a little scary because of how many places in code read it. * Scripts/webkitdirs.pm: (determineASanIsEnabled): Read it from ASan configuration file. (argumentsForConfiguration): Added a FIXME. (asanIsEnabled): A caching wrapper similar to what we have for other configuration options. (XcodeOptions): Pass the options needed for ASan. * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there no warnings to avoid. Removed explicit linking options, as -fsanitize=address does that automatically. 2014-12-23 Alexey Proskuryakov <ap@apple.com> TestWebKitAPI build is broken when ASan is enabled https://bugs.webkit.org/show_bug.cgi?id=139902 Reviewed by Darin Adler. * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Inherit linker flags from DebugRelease, which respects ASAN. 2014-12-22 Simon Fraser <simon.fraser@apple.com> Sort the Xcode project file. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 2014-12-22 Lucas Forschler <lforschler@apple.com> Update apple-mac-114 to bot629. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/config.json: 2014-12-22 Lucas Forschler <lforschler@apple.com> Replace Apple bot104 with bot124. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/config.json: 2014-12-22 Csaba Osztrogonác <ossy@webkit.org> URTBF after r177639. * TestWebKitAPI/CMakeLists.txt: 2014-12-22 Grzegorz Czajkowski <g.czajkowski@samsung.com> [EFL] MiniBrowser steals web view's focus https://bugs.webkit.org/show_bug.cgi?id=139482 Reviewed by Gyuyoung Kim. Although we set focus on ewk_view while MiniBrowser initialization Ecore steals it in a favor of main window. As a result focused element on web page is unable to receive events. * MiniBrowser/efl/main.c: (window_create): Prevent window from stealing web view's focus on start up. 2014-12-19 Brent Fulgham <bfulgham@apple.com> [Win] Revise DRT logic to match Mac. Rubberstamped by Anders Carlsson. Update the Windows logic to perform initialization of preferences and WebKit settings to match Mac. Also make sure that we only ever emit #EOF tokens under the same circumstances as the Mac version. * DumpRenderTree/win/DumpRenderTree.cpp: (dump): (resetWebPreferencesToConsistentValues): (setDefaultsToConsistentValuesForTesting): (resetWebViewToConsistentStateBeforeTesting): (sizeWebViewForCurrentTest): (runTest): (createWebViewAndOffscreenWindow): (allocateGlobalControllers): (prepareConsistentTestingEnvironment): (main): (resetDefaultsToConsistentValues): Deleted. 2014-12-19 Roger Fong <roger_fong@apple.com> Unreviewed. Rollout r177605. * EWSTools/start-queue-win.sh: 2014-12-19 Roger Fong <roger_fong@apple.com> Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true. * EWSTools/start-queue-win.sh: 2014-12-19 Daniel Bates <dabates@apple.com> [iOS] Add WebKitSystemInterface for iOS 8.1 https://bugs.webkit.org/show_bug.cgi?id=139831 Reviewed by Alexey Proskuryakov. Implement support in copy-webkitlibraries-to-product-directory to copy WebKitSystemInterface for iOS to the product directory and have build-webkit pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS. * Scripts/build-webkit: * Scripts/copy-webkitlibraries-to-product-directory: 2014-12-19 Daniel Bates <dabates@apple.com> copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit https://bugs.webkit.org/show_bug.cgi?id=139829 Reviewed by Alexey Proskuryakov. The script build-webkit calls script copy-webkitlibraries-to-product-directory with argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory expects the Xcode SDK to be specified using the --sdk-name command line argument. Currently copy-webkitlibraries-to-product-directory has its own logic to handle parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm logic to both avoid duplicating effort and make the command line options for copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent with the approach used in other WebKit tools. As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK copy-webkitlibraries-to-product-directory now recognizes --device and --simulator shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively. * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to improve the readability of the code. (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature) be included in a library. (unpackIfNecessary): Modified to call executeRanlib(). 2014-12-19 Alexey Proskuryakov <ap@apple.com> REGRESSION (177368): Some tests started to immediately time out https://bugs.webkit.org/show_bug.cgi?id=139826 Reviewed by Daniel Bates. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test ends in a load failure, we don't dump, so we used to leak the timer. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone): Added a comment. 2014-12-19 Brent Fulgham <bfulgham@apple.com> [Win] Add accessor for serializing HTTP loads https://bugs.webkit.org/show_bug.cgi?id=139817 Reviewed by Mark Lam. * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method. * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also remove some redundant code from the destructor. 2014-12-19 Alexey Proskuryakov <ap@apple.com> Clean up a fix for performance test bot failing to build https://bugs.webkit.org/show_bug.cgi?id=139818 Reviewed by Csaba Osztrogonác. The "_1" in step name was annoying. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (CleanBuildIfScheduled.start): (RunAndUploadPerfTests): (DownloadAndPerfTestFactory.__init__): (DownloadAndPerfTestWebKit2Factory.__init__): (CleanBuildUnconditionally): Deleted. (CleanBuildUnconditionally.start): Deleted. 2014-12-19 Csaba Osztrogonác <ossy@webkit.org> REGRESSION(r177535): It broke the GTK performance bot https://bugs.webkit.org/show_bug.cgi?id=139811 Reviewed by Carlos Garcia Campos. Trigger clean build only on mac platform. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (DownloadAndPerfTestFactory.__init__): (DownloadAndPerfTestWebKit2Factory.__init__): 2014-12-18 KwangHyuk Kim <hyuki.kim@samsung.com> Unreviewed, moved myself to the list of committers. * Scripts/webkitpy/common/config/contributors.json: 2014-12-18 Brent Fulgham <bfulgham@apple.com> [Win] Update DumpRenderTree to more closely match Mac version https://bugs.webkit.org/show_bug.cgi?id=139799 Reviewed by Tim Horton. * DumpRenderTree/win/AccessibilityControllerWin.cpp: (AccessibilityController::accessibleElementById): Correct use of BSTR to avoid leak. * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and update to match Mac version more closely. (dumpFramesAsText): (dump): (resetDefaultsToConsistentValues): (resetWebViewToConsistentStateBeforeTesting): (sizeWebViewForCurrentTest): (runTest): (openWindows): (windowToWebViewMap): (createWebViewAndOffscreenWindow): (sharedCFURLCache): (initializeGlobalsFromCommandLineOptions): (main): * DumpRenderTree/win/TestRunnerWin.cpp: Ditto. (TestRunner::addDisallowedURL): (TestRunner::applicationCacheDiskUsageForOrigin): (TestRunner::syncLocalStorage): (TestRunner::localStorageDiskUsageForOrigin): (TestRunner::observeStorageTrackerNotifications): (TestRunner::clearApplicationCacheForOrigin): (TestRunner::originsWithApplicationCache): (TestRunner::deleteAllLocalStorage): (TestRunner::setStorageDatabaseIdleInterval): (TestRunner::closeIdleLocalStorageDatabases): (TestRunner::originsWithLocalStorage): (TestRunner::deleteLocalStorageForOrigin): (TestRunner::copyDecodedHostName): (TestRunner::copyEncodedHostName): (TestRunner::keepWebHistory): (TestRunner::numberOfPendingGeolocationPermissionRequests): (TestRunner::setAppCacheMaximumSize): (TestRunner::setCustomPolicyDelegate): (TestRunner::goBack): (TestRunner::setDefersLoading): (TestRunner::setDomainRelaxationForbiddenForURLScheme): (TestRunner::setMockDeviceOrientation): (TestRunner::setMockGeolocationPosition): (TestRunner::setMockGeolocationPositionUnavailableError): (TestRunner::setIconDatabaseEnabled): (TestRunner::setMainFrameIsFirstResponder): (TestRunner::setSpatialNavigationEnabled): (TestRunner::setPluginsEnabled): (TestRunner::setAutomaticLinkDetectionEnabled): (TestRunner::setUseDashboardCompatibilityMode): (TestRunner::dispatchPendingLoadRequests): (TestRunner::findString): (TestRunner::setCacheModel): (TestRunner::apiTestNewWindowDataLoadBaseURL): (TestRunner::setWebViewEditable): (TestRunner::authenticateSession): (TestRunner::abortModal): (TestRunner::setSerializeHTTPLoads): (TestRunner::addChromeInputField): (TestRunner::removeChromeInputField): (TestRunner::focusWebView): (TestRunner::setBackingScaleFactor): (TestRunner::grantWebNotificationPermission): (TestRunner::denyWebNotificationPermission): (TestRunner::removeAllWebNotificationPermissions): (TestRunner::simulateWebNotificationClick): 2014-12-18 Gavin Barraclough <barraclough@apple.com> Add strong typing to RefCounter interface, return value as a bool. https://bugs.webkit.org/show_bug.cgi?id=139776 Reviewed by Geoff Garen. Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>. This means there is no compile time type checking to prevent mistakes. Update the count() method to token<>(), templated on type used to identify the token being returned. Calls to token<T>() will return a result of type RefCounter::Token<T>. There are a few problems with the fact the counter will return you an exact count of the number of outstanding tokens: - It is desirable to only fire the callback on zero-edge changes; it is more consistent to do so if the value is only readable as a boolean. - It is desirable to provide the value as an argument to the callback, however to make this useful for integer values it is also necessary to indicate the direction of change (0->1 is often interesting where 2->1 is not). - There is a mismatch between the precision of returning a count, and the inherent imprecision of a token based mechanism, where it may be difficult to guarantee absolutely no unnecessary refcount churn, and thus unintentional counter values. * TestWebKitAPI/Tests/WTF/RefCounter.cpp: (TestWebKitAPI::TEST): - update API test. 2014-12-18 Alexey Proskuryakov <ap@apple.com> Disable retries on Mac Release WK2 testers https://bugs.webkit.org/show_bug.cgi?id=139798 Reviewed by Simon Fraser. * BuildSlaveSupport/build.webkit.org-config/config.json: 2014-12-18 Alexey Proskuryakov <ap@apple.com> Perf tests frequently fail saying "build not up to date" https://bugs.webkit.org/show_bug.cgi?id=139786 Illegitimately yet authoritatively reviewed by Lucas Forschler. Undo the rest of the first fix, and implement the behavior differently. is_clean isn't automatically forwarded from config.json to properties. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (CleanBuildUnconditionally): (CleanBuildUnconditionally.start): (DownloadAndPerfTestFactory.__init__): (DownloadAndPerfTestWebKit2Factory.__init__): 2014-12-18 Alexey Proskuryakov <ap@apple.com> Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl. I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory found nothing. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (BuildAndPerfTestFactory): (BuildAndPerfTestWebKit2Factory): 2014-12-18 Alexey Proskuryakov <ap@apple.com> Perf tests frequently fail saying "build not up to date" https://bugs.webkit.org/show_bug.cgi?id=139786 Reviewed by Ryosuke Niwa. Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build directory to get rid of stale precompiled headers, and let it rebuild DumpRenderTree each time, that's fast. Also, removed unused "build and perf test" code. * BuildSlaveSupport/build.webkit.org-config/config.json: 2014-12-18 Brent Fulgham <bfulgham@apple.com> [Win] Unreviewed gardening. Reorder file contents to match Mac version. Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes it easier to see what steps are missing when running under Windows. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::callShouldCloseOnWebView): (TestRunner::clearAllApplicationCaches): (TestRunner::applicationCacheDiskUsageForOrigin): (TestRunner::syncLocalStorage): (TestRunner::localStorageDiskUsageForOrigin): (TestRunner::observeStorageTrackerNotifications): (TestRunner::clearApplicationCacheForOrigin): (TestRunner::originsWithApplicationCache): (TestRunner::clearAllDatabases): (TestRunner::deleteAllLocalStorage): (TestRunner::setStorageDatabaseIdleInterval): (TestRunner::closeIdleLocalStorageDatabases): (TestRunner::originsWithLocalStorage): (TestRunner::deleteLocalStorageForOrigin): (TestRunner::numberOfPendingGeolocationPermissionRequests): (jsStringRefToWString): (TestRunner::setAppCacheMaximumSize): (TestRunner::setDatabaseQuota): (TestRunner::goBack): (TestRunner::setDefersLoading): (TestRunner::setDomainRelaxationForbiddenForURLScheme): (TestRunner::setAutomaticLinkDetectionEnabled): (TestRunner::dispatchPendingLoadRequests): (TestRunner::overridePreference): (TestRunner::removeAllVisitedLinks): (TestRunner::waitForPolicyDelegate): (TestRunner::resetPageVisibility): (TestRunner::setPageVisibility): (TestRunner::grantWebNotificationPermission): (TestRunner::denyWebNotificationPermission): (TestRunner::removeAllWebNotificationPermissions): (TestRunner::simulateWebNotificationClick): (TestRunner::simulateLegacyWebNotificationClick): 2014-12-18 Brent Fulgham <bfulgham@apple.com> [Win] Correct Windows tests after Bug 139149 (edit) https://bugs.webkit.org/show_bug.cgi?id=139781 Reviewed by Anders Carlsson. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache interface. 2014-12-18 Simon Fraser <simon.fraser@apple.com> [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts https://bugs.webkit.org/show_bug.cgi?id=139748 Reviewed by Daniel Bates. Staging change to support --ios-sim and --ios-simulator temporarily until the bots have all been updated. * Scripts/webkitpy/port/factory.py: (platform_options): 2014-12-18 Simon Fraser <simon.fraser@apple.com> Build more of TestWebKitAPI for iOS https://bugs.webkit.org/show_bug.cgi?id=139747 Reviewed by Daniel Bates. Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES, which excluded some tests that should be run for iOS. Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is available (i.e. Mac OS X), and most files use that. Some files with Mac-only functionality (ActionMenus, Downloads) use #if PLATFORM(MAC). Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory to share code between Mac and iOS. * TestWebKitAPI/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: * TestWebKitAPI/InjectedBundleController.cpp: * TestWebKitAPI/InjectedBundleMain.cpp: * TestWebKitAPI/JavaScriptTest.cpp: * TestWebKitAPI/PlatformUtilities.cpp: * TestWebKitAPI/PlatformUtilities.h: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp: * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp: * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: * TestWebKitAPI/Tests/WebKit2/Find.cpp: * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp: * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp: * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp: * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp: * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm: * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp: * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/WKString.cpp: * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp: * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp: * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm. (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm: * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp. (TestWebKitAPI::Util::run): (TestWebKitAPI::Util::sleep): (TestWebKitAPI::Util::toSTD): * TestWebKitAPI/config.h: * TestWebKitAPI/mac/JavaScriptTestMac.mm: * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: (TestWebKitAPI::Util::run): Deleted. (TestWebKitAPI::Util::sleep): Deleted. (TestWebKitAPI::Util::toSTD): Deleted. 2014-12-18 Dániel Bátyai <dbatyai.u-szeged@partner.samsung.com> [GTK] Add support for FTL JIT on ARM64 https://bugs.webkit.org/show_bug.cgi?id=139677 Reviewed by Csaba Osztrogonác. * gtk/jhbuild-optional.modules: * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added. * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added. 2014-12-18 Adrian Perez de Castro <aperez@igalia.com> [GTK] Implement webkit_web_view_is_playing_audio() https://bugs.webkit.org/show_bug.cgi?id=138918 Reviewed by Carlos Garcia Campos. Add test case case for webkit_web_view_is_playing_audio() and the WebKitWebView::is-playing-audio property. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (urlForResource): Utility function to get URLs pointing to resources under the Tools/TestWebKitAPI/Tests/WebKit2/ directory. (testWebViewIsPlayingAudio): Added. (beforeAll): * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h: (getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK API tests resources directory, or the WebKit2 C API tests resources directory. The default value of the flag is to use the WebKit2 GTK one, to avoid having to change existing tests. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (isPlayingAudioChanged): Added. (WebViewTest::waitUntilIsPlayingAudioChanged): Added. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: 2014-12-18 Carlos Alberto Lopez Perez <clopez@igalia.com> [GTK] [EFL] Enable per_test_timeout https://bugs.webkit.org/show_bug.cgi?id=139771 Reviewed by Csaba Osztrogonác. This is needed to make WKTR use either the default port timeout, or the user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests. Otherwise WTR will use the default (30 seconds after r177363 and r177471). * Scripts/webkitpy/port/efl.py: (EflPort.supports_per_test_timeout): Enabled. * Scripts/webkitpy/port/gtk.py: (GtkPort.supports_per_test_timeout): Enabled. 2014-12-17 Lucas Forschler <lforschler@apple.com> Move Apple buildbot slaves to their new home. Reviewed by Roger Fong. * BuildSlaveSupport/build.webkit.org-config/config.json: 2014-12-17 Alexey Proskuryakov <ap@apple.com> REGRESSION (r177363): Gtk and Efl testing is broken https://bugs.webkit.org/show_bug.cgi?id=139734 Reviewed by Simon Fraser. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner.__init__): Remove timeout adjustment from here, because it affected both script and tool timeout. This is still the right place for this logic, but it would be a larger refactoring than I can do right now. * Scripts/webkitpy/port/base.py: (Port.supports_per_test_timeout): Added a FIXME. (Port.default_timeout_ms): Now that the effective timeout is longer, change this to avoid making tests take more time. * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here. (Driver._check_for_driver_timeout): Fix the timeout detection. (Driver._read_block): Actually use the timeout detection code. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): Use TestRunner default timeout when there isn't a timeout passed from command line for the test. * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms): Update results for the new default. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.test_hung_thread): Restore a test that I previously deleted, it was actually a good one. 2014-12-17 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r177456. https://bugs.webkit.org/show_bug.cgi?id=139749 Broke webkitpy and Mac tests (Requested by ap on #webkit). Reverted changeset: "REGRESSION (r177363): Gtk and Efl testing is broken" https://bugs.webkit.org/show_bug.cgi?id=139734 http://trac.webkit.org/changeset/177456 2014-12-17 Alexey Proskuryakov <ap@apple.com> REGRESSION (r177363): Gtk and Efl testing is broken https://bugs.webkit.org/show_bug.cgi?id=139734 Reviewed by Simon Fraser. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner.__init__): Remove timeout adjustment from here, because it affected both script and tool timeout. This is still the right place for this logic, but it would be a larger refactoring than I can do right now. * Scripts/webkitpy/port/base.py: (Port.supports_per_test_timeout): Added a FIXME. (Port.default_timeout_ms): Now that the effective timeout is longer, change this to avoid making tests take more time. * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): Use TestRunner default timeout when there isn't a timeout passed from command line for the test. 2014-12-17 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded https://bugs.webkit.org/show_bug.cgi?id=139725 Reviewed by Martin Robinson. The timeout is already in milliseconds, so we don't need to do any conversion. * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded): 2014-12-17 Hunseop Jeong <hs85.jeong@samsung.com> [EFL]Fix build warning in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=139723 Reviewed by Darin Adler. The warning is caused by the compiler wanting the first argument to be a string literal, not a dynamically created string. * MiniBrowser/efl/main.c: (quit): 2014-12-16 Sam Weinig <sam@webkit.org> TestWebKitAPI should use a static lib to support both Mac and iOS cleanly https://bugs.webkit.org/show_bug.cgi?id=139718 Reviewed by Mark Rowe. Change TestWebKitAPI to be more like DumpRenderTree by moving all the source files into a static lib which the command line utility can link link against. This will allow us to create a TestWebKitAPI.app that can run on iOS. * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 2014-12-16 Alexey Proskuryakov <ap@apple.com> Sort out timeout implementations in DRT and WKTR https://bugs.webkit.org/show_bug.cgi?id=139671 Remove an obsolete test that doesn't capture how run-webkit-tests interacts with the tool. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.test_hung_thread): 2014-12-15 Alexey Proskuryakov <ap@apple.com> Sort out timeout implementations in DRT and WKTR https://bugs.webkit.org/show_bug.cgi?id=139671 Reviewed by Simon Fraser. Test timeout implementation had many deficiencies, please see the bug for details. Most notably, we shouldn't have the tool confused about timeouts vs. failures, and [ Slow ] modifiers should work a lot better. * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner): * DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout): * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump): DumpRenderTree already read the --timeout option from command line, and webkitpy was already configured to pass it on Mac and iOS. Let's actually use it. TestCommand already had the same 30 second default, so this doesn't change behavior when DRT is ran manually without the option. Windows DumpRenderTree will need to be fixed separately (that's easy). * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()): Don't print the timeout message to stdout to match WebKitTestRunner. It would be slightly better to use stderr in both, as this is an out of band message, but that's a larger refactoring, and the difference is minimal in practice. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner.__init__): Ensure that script and tool timeouts are substantially different. We want the tool to reliably detect timeouts that can be detected, and not race with the script for that. * Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2 timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value is honored inmore cases, that could make tests run slower. * Scripts/webkitpy/port/driver.py: (Driver.__init__): (Driver.run_test): (Driver.cmd_line): (Driver._check_for_driver_timeout): Detect tests that have the timeout output, and make these have the proper Timeout result. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): Remove an incorrect recent change - 80 * 1000 is 80 seconds, not 80 milliseconds. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setCustomTimeout): Deleted. * WebKitTestRunner/InjectedBundle/TestRunner.h: (WTR::TestRunner::setCustomTimeout): * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded): * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded): * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded): * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded): Updated to use a timeout passed from UI process, which used to be ignored. * WebKitTestRunner/TestController.cpp: (WTR::TestController::TestController): (WTR::TestController::runUntil): (WTR::TestController::getCustomTimeout): Deleted. * WebKitTestRunner/TestController.h: Delete unused m_timeout. First, it was always 0, and second, we don't need it at all. Changed default message timeouts to match new run-webkit-tests timeout. These don't affect ports where timeout is passed per test (shouldn't they all be like that?). * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): (WTR::TestInvocation::setCustomTimeout): Deleted. * WebKitTestRunner/TestInvocation.h: (WTR::TestInvocation::setCustomTimeout): (WTR::TestInvocation::customTimeout): Ditto. 2014-12-16 Grzegorz Czajkowski <g.czajkowski@samsung.com> [EFL] Add logging domain for MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=139642 Reviewed by Gyuyoung Kim. Similarly to EWebKit2, provide logging facility for MiniBrowser based on Eina Log module to have a convenient way to display all/subset/none messages for EFL based libraries and MiniBrowser. Usage: 1. Disable all messages: EINA_LOG_LEVEL=0 ./Tools/Scripts/run-launcher --efl 2. Enable all messages: EINA_LOG_LEVEL=7 ./Tools/Scripts/run-launcher --efl 3. Enable MiniBrowser and EWebkit2 messages only: EINA_LOG_LEVELS="minibrowser:7,ewebkit2:7" ./Tools/Scripts/run-launcher --efl More information and examples you can find here: http://docs.enlightenment.org/auto/eet/tutorial_log_page.html * MiniBrowser/efl/main.c: (on_mouse_wheel): (on_window_resize): (save_page_contents_callback): (script_execute_callback): (on_key_down): (on_download_request): (on_download_finished): (on_download_failed): (quit): (on_refresh_button_clicked): (on_stop_button_clicked): (navigation_button_longpress_process): (on_popup_menu_item_clicked): (popup_menu_populate): (on_popup_menu_show): (on_window_create): (context_menu_item_selected_cb): (context_menu_populate): (on_context_menu_show): (on_context_menu_hide): (on_navigation_policy_decision): (window_create): (parse_cookies_policy): (elm_main): (has_scheme): (list_item_label_get): (on_popup_menu_hide): (on_window_close): (on_home_button_clicked): Replace locally info() macro with newly introduced one which uses Eina Log module. There is no logic change. 2014-12-15 Dániel Bátyai <dbatyai.u-szeged@partner.samsung.com> [EFL] FTL JIT not working on ARM64 https://bugs.webkit.org/show_bug.cgi?id=139295 Reviewed by Michael Saboff. Added patches for llvm to add ARM64 support for FTL JIT * efl/jhbuild.modules: * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added. * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added. 2014-12-15 Timothy Horton <timothy_horton@apple.com> Move Said to the committers section. * Scripts/webkitpy/common/config/contributors.json: 2014-12-15 Timothy Horton <timothy_horton@apple.com> Implement Data Detectors immediate actions for WebKit2 https://bugs.webkit.org/show_bug.cgi?id=139617 <rdar://problem/19198539> Reviewed by Beth Dakin. * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: (TestWebKitAPI::TEST): Temporarily disable the action menu tests while the underlying code is in flux. 2014-12-14 Andreas Kling <akling@apple.com> Replace PassRef with Ref/Ref&& across the board. <https://webkit.org/b/139587> Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/Ref.cpp: (TestWebKitAPI::passWithRef): (TestWebKitAPI::TEST): (TestWebKitAPI::passWithPassRef): Deleted. * TestWebKitAPI/Tests/WTF/RefCounter.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/RefPtr.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: (TestWebKitAPI::createTestValue): 2014-12-13 Grzegorz Czajkowski <g.czajkowski@samsung.com> [EFL] MiniBrowser's window_create may return NULL https://bugs.webkit.org/show_bug.cgi?id=139585 Reviewed by Gyuyoung Kim. Move NULL checking before using object which window_create returns. * MiniBrowser/efl/main.c: (elm_main): 2014-12-12 Alexey Proskuryakov <ap@apple.com> Layout Test http/tests/loading/307-after-303-after-post.html is flaky https://bugs.webkit.org/show_bug.cgi?id=73030 Reviewed by Anders Carlsson. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon database to empty to avoid having it fetch default favicons at random times. DumpRenderTree also disables it, and also it has a way for tests to temporarily enable it. 2014-12-12 Lucas Forschler <lforschler@apple.com> Update Apple owned build slaves after infrastructure update. Reviewed by Ryosuke Niwa. * BuildSlaveSupport/build.webkit.org-config/config.json: 2014-12-11 Carlos Alberto Lopez Perez <clopez@igalia.com> [GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild. https://bugs.webkit.org/show_bug.cgi?id=139537 Reviewed by Carlos Garcia Campos. * jhbuild/jhbuild-wrapper: Pass the port name in the invocation of get_dependencies_path(). * jhbuild/jhbuildutils.py: (get_dependencies_path): Fix the function to return the new dependencies path: DependenciesPORT. (enter_jhbuild_environment_if_available): Pass the port name when invoking get_dependencies_path(). 2014-12-10 Lucas Forschler <lforschler@apple.com> Update Apple owned build slaves. Rubber-stamped by Dana Burkart. * BuildSlaveSupport/build.webkit.org-config/config.json: 2014-12-10 Daniel Bates <dabates@apple.com> [iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app timeout instead of test failure https://bugs.webkit.org/show_bug.cgi?id=139525 Reviewed by Zalan Bujtas. Increase the default process timeout limit in run-webkit-tests to 80ms to prevent run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps output. Following <http://trac.webkit.org/changeset/174642>, DumpRenderTree.app waits for the WebThread to spin its run loop before dumping its output. A test that calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone() before DumpRenderTree.app's watchdog timer expires may be incorrectly reported by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure because run-webkit-tests may terminate a DumpRenderTree.app process when it exceeds its process time limit (defaults to 35ms) regardless of whether such a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): 2014-12-09 Gustavo Noronha Silva <gustavo.noronha@collabora.com> [GTK][WK2] Add HTML5 Notifications support https://bugs.webkit.org/show_bug.cgi?id=61140 Reviewed by Carlos Garcia Campos. * Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewNotification): (beforeAll): * MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests. (permissionRequestDialogCallback): (webViewDecidePermissionRequest): (geolocationRequestDialogCallback): Deleted. 2014-12-09 Benjamin Poulain <bpoulain@apple.com> Fix webkitpy test expectation Not sure what I messed up, but TOTAL_SKIPS was not right. * Scripts/webkitpy/port/test.py: 2014-12-09 Benjamin Poulain <bpoulain@apple.com> Remove virtual test support from webkitpy https://bugs.webkit.org/show_bug.cgi?id=139427 Reviewed by Alexey Proskuryakov. It seems that the only concrete client of virtual tests is the unit tests :D This patch tries to clean as much useless code as possible. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.test_tolerance): (RunTest.test_virtual): Deleted. * Scripts/webkitpy/layout_tests/views/printing.py: (Printer._print_test_trace): * Scripts/webkitpy/port/base.py: (Port.expected_filename): (Port.tests): (Port.test_isfile): (Port.test_isdir): (Port.sample_process): (Port.find_system_pid): (Port.test_expectations_file_position): (Port.virtual_test_suites): Deleted. (Port): Deleted. (Port.populated_virtual_test_suites): Deleted. (Port._virtual_tests): Deleted. (Port.lookup_virtual_test_base): Deleted. (Port.lookup_virtual_test_args): Deleted. (VirtualTestSuite): Deleted. (VirtualTestSuite.__init__): Deleted. (VirtualTestSuite.__repr__): Deleted. * Scripts/webkitpy/port/base_unittest.py: (PortTest.test_test_exists): (PortTest.test_test_isfile): (PortTest.test_test_isdir): (PortTest.test_tests): * Scripts/webkitpy/port/driver.py: (DriverProxy.run_test): Deleted. * Scripts/webkitpy/port/test.py: (TestPort._skipped_tests_for_unsupported_features): (TestPort.all_baseline_variants): (TestPort.virtual_test_suites): Deleted. * Scripts/webkitpy/tool/commands/queries.py: (PrintBaselines.__init__): (PrintBaselines.execute): * Scripts/webkitpy/tool/commands/queries_unittest.py: (PrintBaselinesTest.test_basic): (PrintBaselinesTest.test_multiple): (PrintBaselinesTest.test_csv): 2014-12-09 Csaba Osztrogonác <ossy@webkit.org> Blink Merge: Remove 'http_lock' code from webkitpy https://bugs.webkit.org/show_bug.cgi?id=136722 Reviewed by Alexey Proskuryakov. Based on Blink commit by Dirk Pranke <dpranke@chromium.org> https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: (LayoutTestRunner.__init__): (LayoutTestRunner.run_tests): (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock. (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: (FakePrinter.flush): (LayoutTestRunnerTests._runner): (LayoutTestRunnerTests._run_tests): (LayoutTestRunnerTests.test_servers_started): (LockCheckingRunner): Deleted. (LockCheckingRunner.__init__): Deleted. (LockCheckingRunner.handle_finished_list): Deleted. (LayoutTestRunnerTests.test_http_locking): Deleted. * Scripts/webkitpy/port/base.py: (Port.__init__): (Port.to.http_server_supports_ipv6): (Port.to.stop_websocket_server): (Port.to.acquire_http_lock): Deleted. (Port.to.release_http_lock): Deleted. * Scripts/webkitpy/port/http_lock.py: Removed. * Scripts/webkitpy/port/http_lock_unittest.py: Removed. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.show_results_html_file): (IOSSimulatorPort.acquire_http_lock): Deleted. (IOSSimulatorPort): Deleted. (IOSSimulatorPort.release_http_lock): Deleted. * Scripts/webkitpy/port/mac.py: (MacPort.show_results_html_file): (MacPort): Deleted. (MacPort.acquire_http_lock): Deleted. (MacPort.release_http_lock): Deleted. * Scripts/webkitpy/port/mock_drt.py: (MockDRTPort.start_websocket_server): (MockDRTPort.stop_websocket_server): (MockDRTPort.acquire_http_lock): Deleted. (MockDRTPort.release_http_lock): Deleted. * Scripts/webkitpy/port/mock_drt_unittest.py: (MockDRTPortTest.test_uses_apache): (MockDRTPortTest.integration_test_http_lock): Deleted. * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.assert_servers_are_up): (PortTestCase.integration_test_http_lock): Deleted. * Scripts/webkitpy/port/test.py: (TestPort.start_websocket_server): (TestPort.stop_websocket_server): (TestPort.acquire_http_lock): Deleted. (TestPort.release_http_lock): Deleted. 2014-12-09 Alberto Garcia <berto@igalia.com> convertToUTF8String converts null string to empty string https://bugs.webkit.org/show_bug.cgi?id=133904 Reviewed by Carlos Garcia Campos. Test that trying to get the value of a non-existent attribute returns 0 instead of an empty string. * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: (WebKitDOMNodeTest::testInsertion): 2014-12-09 Joanmarie Diggs <jdiggs@igalia.com> [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2 https://bugs.webkit.org/show_bug.cgi?id=139070 Reviewed by Carlos Garcia Campos. * gtk/jhbuild.modules: 2014-12-08 Tim Horton <timothy_horton@apple.com> Add action menu tests https://bugs.webkit.org/show_bug.cgi?id=139156 Reviewed by Dean Jackson. * TestWebKitAPI/PlatformWebView.h: * TestWebKitAPI/mac/PlatformWebViewMac.mm: (TestWebKitAPI::PlatformWebView::PlatformWebView): Add a mechanism allowing tests to provide their own WKView subclass. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added. Add a file with lots of menu targets. * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added. (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]): (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]): (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]): Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process. (-[ActionMenusTestWKView _setOverrideActionMenuItems:]): (TestWebKitAPI::didFinishLoadForFrameCallback): (TestWebKitAPI::didFinishDownloadCallback): (TestWebKitAPI::didCreateDownloadDestinationCallback): Watch downloads and ensure that they match the content we expect. (TestWebKitAPI::watchPasteboardForString): (TestWebKitAPI::watchPasteboardForImage): (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext): (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext): (TestWebKitAPI::javaScriptStringCallback): (TestWebKitAPI::javaScriptBoolCallback): (TestWebKitAPI::callJavaScriptReturningString): (TestWebKitAPI::callJavaScriptReturningBool): (TestWebKitAPI::watchEditableAreaForString): (TestWebKitAPI::waitForVideoReady): (TestWebKitAPI::retrieveSelection): (TestWebKitAPI::retrieveSelectionInElement): (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync): (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled): Add many helpers for testing, especially to make asynchronous things synchronous. (TestWebKitAPI::windowPointForTarget): (TestWebKitAPI::inset8): Hard-code points in action-menu-targets.html for hit testing. (TestWebKitAPI::TEST): Add a suite of tests for WebKit2 action menus. * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added. (TestWebKitAPI::createActionContextForPhoneNumber): (TestWebKitAPI::ActionMenuTest::ActionMenuTest): (TestWebKitAPI::ActionMenuTest::prepareForActionMenu): (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint): (TestWebKitAPI::ActionMenuTest::drawRect): (TestWebKitAPI::ActionMenuTest::didCreatePage): Add a bundle with a PageOverlay and a actionContextForResultAtPoint override, so that we can test that infrastructure. 2014-12-08 Philippe Normand <pnormand@igalia.com> [GTK] UserMedia Permission Request API https://bugs.webkit.org/show_bug.cgi?id=136449 Reviewed by Carlos Garcia Campos. The GTK version of the MiniBrowser has gained UserMedia permission request support. * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page requires user permission to access audio/video devices. (permissionRequestDialogCallback): (webViewDecidePermissionRequest): (geolocationRequestDialogCallback): Deleted. 2014-12-08 Anders Carlsson <andersca@apple.com> Add a stubbed out method for clearing out the website data store https://bugs.webkit.org/show_bug.cgi?id=139404 Reviewed by Antti Koivisto. Add a debug menu item for testing clearing of website data. * MiniBrowser/mac/MainMenu.xib: * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController clearWebsiteData:]): 2014-12-07 Gwang Yoon Hwang <yoon@igalia.com> Update style checker to deal with "const override" https://bugs.webkit.org/show_bug.cgi?id=139371 Reviewed by Csaba Osztrogonác. check-webkit-style shouldn't complain about an open brace to start a line after a function definition with const override. * Scripts/webkitpy/style/checkers/cpp.py: (check_braces): * Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest.test_brace_at_begin_of_line): 2014-12-07 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Fix GObject DOM bindings API break tests after r176920 https://bugs.webkit.org/show_bug.cgi?id=139368 Reviewed by Gustavo Noronha Silva. Remove the @version from the symbol name before comparing. * gtk/check-for-webkitdom-api-breaks: (read_expected_api): 2014-12-07 Carlos Garcia Campos <cgarcia@igalia.com> Remove the option to automatically update the GObject DOM bindings symbols file https://bugs.webkit.org/show_bug.cgi?id=139366 Reviewed by Martin Robinson. It's currently broken, because symbols now need to be in a specific order. Now that the symbols file only contains stable API, it's not a problem to manually update it every time new API is added. * gtk/check-for-webkitdom-api-breaks: (read_expected_api): (check_api): (write_expected_api): Deleted. 2014-12-07 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Use GMainLoopSource in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=138831 Reviewed by Sergio Villar Senin. * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: (WTR::TestRunner::platformInitialize): (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer): (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded): (WTR::waitToDumpWatchdogTimerCallback): Deleted. * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::notifyDone): (WTR::TestController::platformRunUntil): (WTR::cancelTimeout): Deleted. 2014-12-07 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Missing API detected in GObject DOM bindings after r176630 https://bugs.webkit.org/show_bug.cgi?id=139201 Reviewed by Gustavo Noronha Silva. Handle deprecated symbols again when generating the GObject DOM bindings documentation. * gtk/webkitdom.py: (WebKitDOMDocGenerator): (WebKitDOMDocGenerator.is_deprecated_symbol_file): (WebKitDOMDocGenerator.generate): (WebKitDOMDocGeneratorSections.__init__): (WebKitDOMDocGeneratorSections._find_deprecated_symbols): (WebKitDOMDocGeneratorSections.write_section): 2014-12-07 Csaba Osztrogonác <ossy@webkit.org> [EFL][jhbuild] Fix libsoup build with clang https://bugs.webkit.org/show_bug.cgi?id=139088 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: * efl/patches/soup-clang-warning-fix1.patch: Added. * efl/patches/soup-clang-warning-fix2.patch: Added. 2014-12-06 Alexey Proskuryakov <ap@apple.com> [Mac] DumpRenderTree sets storage directory incorrectly https://bugs.webkit.org/show_bug.cgi?id=139347 Reviewed by Dan Bernstein. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): Don't use user defaults to pass per-instance paths, as user defaults are shared across all instances. 2014-12-05 Chris Fleizach <cfleizach@apple.com> AX: I cannot activate links on the mobile version of news.google.com https://bugs.webkit.org/show_bug.cgi?id=139330 Reviewed by Simon Fraser. Implement press for iOS. * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::press): 2014-12-05 Daniel Bates <dabates@apple.com> [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor() https://bugs.webkit.org/show_bug.cgi?id=139326 Reviewed by Anders Carlsson. Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor() to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot using the same scale factor as used in WebKit. * DumpRenderTree/ios/PixelDumpSupportIOS.mm: (createBitmapContextFromWebView): 2014-12-05 Anders Carlsson <andersca@apple.com> REGRESSION (r176677): All tests crash on Windows https://bugs.webkit.org/show_bug.cgi?id=139321 Reviewed by Alexey Proskuryakov. * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Don't call CFRelease on the url while we have an outstanding pointer to its string, and use the right number of bytes when allocating the testURL buffer. 2014-12-05 Daniel Bates <dabates@apple.com> [iOS] DumpRenderTree produces many reference test mismatches https://bugs.webkit.org/show_bug.cgi?id=139314 Reviewed by Simon Fraser. Fixes an issue where the scale factor used to render the snapshot taken by DumpRenderTree may differ from the device scale factor. In particular, the scale factor used to render a snapshot of a test may differ from the scale factor used to render the snapshot of its expected result. Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to snapshot the UIWebBrowserView. This SPI always render using a scale factor of one when the backing store for the LegacyTileLayer objects were out-of- date regardless of the device scale factor. Instead we should use UIImage and CALayer API to perform the snapshot with respect to the device scale factor. Additionally write iOS pixel dump support logic in terms of existing DumpRenderTree abstractions so as to support generating and comparing pixel dump checksums as well as make the iOS code more consistent with the logic used by other ports. * DumpRenderTree/PixelDumpSupport.cpp: (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard. * DumpRenderTree/ios/PixelDumpSupportIOS.mm: (BitmapContext::createFromUIImage): Added. (BitmapContext::pixelData): Added. (BitmapContext::BitmapContext): Added. (computeMD5HashStringForBitmapContext): Added. (dumpBitmap): Added. (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here. (dumpWebViewAsPixelsAndCompareWithExpected): Deleted. 2014-12-05 Anders Carlsson <andersca@apple.com> Give all web pages a website data store https://bugs.webkit.org/show_bug.cgi?id=139317 Reviewed by Tim Horton. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate newPrivateWindow:]): Don't release the controller - it's implicitly retained by the window. 2014-12-05 Daniel Bates <dabates@apple.com> [iOS] DumpRenderTree fails to render every other test when pixel tests are on https://bugs.webkit.org/show_bug.cgi?id=137581 <rdar://problem/18642906> Reviewed by Simon Fraser. Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content of the test that proceeded the currently running test. * DumpRenderTree/ios/PixelDumpSupportIOS.mm: (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow] as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles. 2014-12-05 Jer Noble <jer.noble@apple.com> [WTF] MediaTime should support round-tripping from and to doubles. https://bugs.webkit.org/show_bug.cgi?id=139248 Reviewed by Eric Carlson. Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display the MediaTimes after this change. * TestWebKitAPI/Tests/WTF/MediaTime.cpp: (WTF::operator<<): (TestWebKitAPI::TEST): * lldb/lldb_webkit.py: (WTFMediaTime_SummaryProvider): (WTFMediaTimeProvider.timeValueAsDouble): (WTFMediaTimeProvider.isIndefinite): (WTFMediaTimeProvider): (WTFMediaTimeProvider.hasDoubleValue): 2014-12-05 Anders Carlsson <andersca@apple.com> Add a private browsing mode to MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=139308 Reviewed by Sam Weinig. * MiniBrowser/mac/AppDelegate.m: (defaultConfiguration): (-[BrowserAppDelegate newWindow:]): (-[BrowserAppDelegate newPrivateWindow:]): * MiniBrowser/mac/MainMenu.xib: * MiniBrowser/mac/WK2BrowserWindowController.h: * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]): (-[WK2BrowserWindowController initWithConfiguration:]): (-[WK2BrowserWindowController dealloc]): (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): 2014-12-04 Alexey Proskuryakov <ap@apple.com> Run http tests parallel https://bugs.webkit.org/show_bug.cgi?id=138958 Reviewed by Daniel Bates. Remove the concept of "locked shard". Now http tests are just like any other tests. We start HTTP and WebSocket servers at the start if we need them, and terminate them when done with all the tests (not when the last http test runs, which is unnecessarily unpredictable). This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the patch, they used to take over 15 minutes. As part of the fix, we no longer pass the number of servers to Apache. I don't think that these parameters did what we wanted them to do; Apache handles the load just fine without them. The change applies to all platforms. I fixed everything I could find on Mac, and Ossy told me that he's been running http tests in parallel for a long time. If there is increased instability for some ports, it will need to be fixed - there is generally nothing special about http tests at this point, and most code is cross-platform in WebKit2. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: (LayoutTestRunner.__init__): (LayoutTestRunner.run_tests): (LayoutTestRunner.start_servers_with_lock): (LayoutTestRunner._handle_started_test): (Worker.handle): (Sharder.__init__): (Sharder.shard_tests): (Sharder._shard_every_file): (Sharder._shard_by_directory): (LayoutTestRunner._handle_finished_test_list): Deleted. (LayoutTestRunner._handle_finished_test_list.find): Deleted. (Sharder._shard_in_two): Deleted. (Sharder): Deleted. (Sharder._resize_shards): Deleted. (Sharder._resize_shards.divide_and_round_up): Deleted. (Sharder._resize_shards.extract_and_flatten): Deleted. (Sharder._resize_shards.split_at): Deleted. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: (FakePrinter.print_workers_and_shards): (LayoutTestRunnerTests.test_servers_started.start_http_server): (LayoutTestRunnerTests.test_servers_started): (SharderTests.get_shards): (SharderTests.test_shard_by_dir): (SharderTests.test_shard_every_file): (SharderTests): Deleted. (SharderTests.test_shard_in_two): Deleted. (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted. (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted. (SharderTests.test_multiple_locked_shards): Deleted. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ManagerTest.test_needs_servers.get_manager): (ManagerTest.integration_test_needs_servers.get_manager): (ManagerTest.test_look_for_new_crash_logs.get_manager): (ManagerTest): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.test_batch_size): (RunTest.test_max_locked_shards): Deleted. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__): * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: (TestLayoutTestApacheHttpd.test_start_cmd): * Scripts/webkitpy/layout_tests/servers/http_server.py: (Lighttpd.__init__): * Scripts/webkitpy/layout_tests/servers/http_server_base.py: (HttpServerBase.__init__): * Scripts/webkitpy/layout_tests/views/printing.py: (Printer.print_workers_and_shards): * Scripts/webkitpy/port/base.py: (Port.default_child_processes): (Port.to.start_http_server): (Port.default_max_locked_shards): Deleted. * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.make_port): (PortTestCase.test_default_max_locked_shards): Deleted. * Scripts/webkitpy/port/test.py: (TestPort.start_http_server): 2014-12-04 Alexey Proskuryakov <ap@apple.com> Don't lock perf tests in run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=139264 Reviewed by Daniel Bates. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: * Scripts/webkitpy/layout_tests/controllers/manager.py: * Scripts/webkitpy/layout_tests/models/test_input.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: 2014-12-03 Alexey Proskuryakov <ap@apple.com> http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it https://bugs.webkit.org/show_bug.cgi?id=139243 Reviewed by Anders Carlsson. We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a chance to allow untrusted certificates. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): Set up more client objects for secondary windows. We may be able to share some of the code with main view creation function, but it's not exactly the same (notably, we do not focus a secondary window when it's done loading). 2014-12-03 Joanmarie Diggs <jdiggs@igalia.com> AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed https://bugs.webkit.org/show_bug.cgi?id=139071 Reviewed by Chris Fleizach. Add string value for ATK_ROLE_STATIC in roleToString. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: 2014-12-03 Renato Nagy <rnagy@inf.u-szeged.hu> check-webkit-style is confused by ternary expression inside first member initializer https://bugs.webkit.org/show_bug.cgi?id=136442 Reviewed by Csaba Osztrogonác. * Scripts/webkitpy/style/checkers/cpp.py: (check_member_initialization_list): 2014-12-03 Carlos Alberto Lopez Perez <clopez@igalia.com> [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed. https://bugs.webkit.org/show_bug.cgi?id=139220 Reviewed by Philippe Normand. * gtk/jhbuild.modules: * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added. 2014-12-03 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com> Remove unused JSC runtime options https://bugs.webkit.org/show_bug.cgi?id=133070 Reviewed by Csaba Osztrogonác. * Scripts/run-jsc-stress-tests: 2014-12-03 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> [EFL] Add subtle crypto to the build system https://bugs.webkit.org/show_bug.cgi?id=138612 Reviewed by Csaba Osztrogonác. * Scripts/webkitperl/FeatureList.pm: 2014-12-02 Joanmarie Diggs <jdiggs@igalia.com> AX: [ATK] Table captions and table rows are missing from the accessible hierarchy https://bugs.webkit.org/show_bug.cgi?id=139005 Reviewed by Chris Fleizach. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for ATK_ROLE_CAPTION to roleToString 2014-12-02 Alexey Proskuryakov <ap@apple.com> http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests https://bugs.webkit.org/show_bug.cgi?id=139149 Reviewed by Anders Carlsson. WebKit2 already cleared application caches between runs (although it wasn't entirely effective without WebCore changes in this patch). * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs. * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this function is not implemented on Windows, see below). * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches): Ameded a FIXME. 2014-12-02 Gavin Barraclough <barraclough@apple.com> Generalize PageActivityAssertionToken https://bugs.webkit.org/show_bug.cgi?id=139106 Reviewed by Sam Weinig. Add an API test for WTF::RefCounter. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added. (TestWebKitAPI::TEST): - added RefCounter test. 2014-12-02 Alexey Proskuryakov <ap@apple.com> [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL https://bugs.webkit.org/show_bug.cgi?id=139174 Reviewed by Simon Fraser. * DumpRenderTree/TestRunner.cpp: * DumpRenderTree/TestRunner.h: Renamed testPathOrURL to testURL, because this variable always contains a URL. * DumpRenderTree/mac/DumpRenderTree.mm: (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming. (testPathFromURL): Moved from FrameLoadDelegate.mm. (runTest): Set crash reporter information here, as we know the exact test URL. * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash reporter information here. * DumpRenderTree/mac/ResourceLoadDelegate.mm: * DumpRenderTree/mac/TestRunnerMac.mm: Updated for testPathOrURL renaming. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know test URL until load starts, so save it into TestRunner now. A new TestRunner object is created for each test. * WebKitTestRunner/InjectedBundle/TestRunner.h: (WTR::TestRunner::testURL): (WTR::TestRunner::setTestURL): Make TestRunner know the test name. For now, it's good enough to have it once load starts, but if we ever need it earlier, we can send it with BeginTest message. * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Use test URL, not currently loading URL for CrashReporter. * WebKitTestRunner/cocoa/CrashReporterInfo.mm: (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon (WebKit1 already had it right). * DumpRenderTree/win/DumpRenderTree.cpp: (sizeWebViewForCurrentTest): (runTest): * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::willSendRequest): Changed Windows DumpRenderTree to also use URL in TestRunner. 2014-12-02 Daniel Bates <dabates@apple.com> [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs https://bugs.webkit.org/show_bug.cgi?id=139143 Reviewed by David Kilzer. Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>, teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it crashes. Run-webkit-tests will record as crashing the test associated with the DumpRenderTree instance that wrote that string. Currently almost all of the DumpRenderTree.app crashes are recorded by run- webkit-tests as a time-out because ReportCrash(8) delays delivery of the process exit notification for DumpRenderTree.app to LayoutTestRelay, which launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay (since it exceeded the time-out time limit) before it can inform rub-webkit-tests about a crash. Additionally, update the crash message format written to standard error when LayoutTestRelay detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the crash message format used by WebKitTestRunner when it detects that the WebProcess crashed. Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app when they crash in their test machinery logic/UI process code. * DumpRenderTree/mac/DumpRenderTree.mm: (writeCrashedMessageOnFatalError): Added. (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals: SIGILL, SIGFPE, SIGBUS and SIGSEGV. * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format similar to the format used by WebKitTestRunner so that run-webkit-tests will collect the crash logs for WebKitTestRunner/DumpRenderTree.app. * Scripts/webkitpy/port/driver.py: (Driver.__init__): Update comment. (Driver._check_for_driver_crash): Ditto. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled regular expression. This constant is used as an optimization to avoid compiling the same regular expression across invocations of _get_crash_log(). (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be closer to where they are used. 2014-12-01 Anders Carlsson <andersca@apple.com> Remove WKBundleRemoveAllVisitedLinks https://bugs.webkit.org/show_bug.cgi?id=139163 Reviewed by Sam Weinig. Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): 2014-12-02 Anders Carlsson <andersca@apple.com> Fix Windows build. * DumpRenderTree/win/DumpRenderTree.cpp: (setAlwaysAcceptCookies): 2014-12-02 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> [EFL] Remove edbus dependency from jhbuild https://bugs.webkit.org/show_bug.cgi?id=139130 Reviewed by Gyuyoung Kim. After http://trac.webkit.org/changeset/176555 we don't need it anymore. * efl/jhbuild.modules: 2014-12-02 Philippe Normand <pnormand@igalia.com> [jhbuild] wrong Dependencies path https://bugs.webkit.org/show_bug.cgi?id=139176 Reviewed by Martin Robinson. * Scripts/webkitpy/port/base.py: (Port._should_use_jhbuild): 2014-12-02 Philippe Normand <pnormand@igalia.com> [GStreamer] Bump internal jhbuild versions to 1.4.4 https://bugs.webkit.org/show_bug.cgi?id=138866 Reviewed by Carlos Garcia Campos. * gtk/jhbuild.modules: * gtk/patches/gst-events-arent-gstobjects.patch: Removed. * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed. * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed. 2014-12-01 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r176566. https://bugs.webkit.org/show_bug.cgi?id=139124 It broke the GTK performance tests. (Requested by clopez on #webkit). Reverted changeset: "[GTK] Use GMainLoopSource in WebKitTestRunner" https://bugs.webkit.org/show_bug.cgi?id=138831 http://trac.webkit.org/changeset/176566 2014-11-29 Anders Carlsson <andersca@apple.com> Crash when calling WKPageClose on the originated page from within createNewPage callback https://bugs.webkit.org/show_bug.cgi?id=139099 <rdar://problem/19052564> Reviewed by Sam Weinig. Add a test. * TestWebKitAPI/PlatformWebView.h: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added. (TestWebKitAPI::runJavaScriptAlert): (TestWebKitAPI::createNewPage): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added. * TestWebKitAPI/mac/PlatformWebViewMac.mm: (TestWebKitAPI::PlatformWebView::PlatformWebView): 2014-11-28 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r176564. https://bugs.webkit.org/show_bug.cgi?id=139093 massive failures on release test bot (Requested by philn on #webkit). Reverted changeset: "[GStreamer] Bump internal jhbuild versions to 1.4.4" https://bugs.webkit.org/show_bug.cgi?id=138866 http://trac.webkit.org/changeset/176564 2014-11-28 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Use GMainLoopSource in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=138831 Reviewed by Sergio Villar Senin. * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: (WTR::TestRunner::platformInitialize): (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer): (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded): (WTR::waitToDumpWatchdogTimerCallback): Deleted. * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::notifyDone): (WTR::TestController::platformRunUntil): (WTR::cancelTimeout): Deleted. 2014-11-24 Philippe Normand <pnormand@igalia.com> [GStreamer] Bump internal jhbuild versions to 1.4.4 https://bugs.webkit.org/show_bug.cgi?id=138866 Reviewed by Carlos Garcia Campos. * gtk/jhbuild.modules: * gtk/patches/gst-events-arent-gstobjects.patch: Removed. * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed. * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed. 2014-11-28 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests https://bugs.webkit.org/show_bug.cgi?id=138834 Reviewed by Sergio Villar Senin. It makes everyting simpler and the tests run faster too, since we don't need to spawn the private bus and wait until the DBus name is registered. The web extension registers a new JavaSCript class with a status method to run the tests, similar to the DBus method. In the UI process side, tests use webkit_web_view_run_java_script() instead of sending a DBus message. * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: (WebKitDOMNodeFilterTest::create): (WebKitDOMNodeFilterTest::testTreeWalker): (WebKitDOMNodeFilterTest::testNodeIterator): (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted. (WebKitDOMNodeFilterTest::runTest): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: (WebKitDOMNodeTest::create): (WebKitDOMNodeTest::testHierarchyNavigation): (WebKitDOMNodeTest::testInsertion): (WebKitDOMNodeTest::testTagNames): (WebKitDOMNodeTest::webPageFromArgs): Deleted. (WebKitDOMNodeTest::runTest): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: (WebKitDOMXPathNSResolverTest::create): (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative): (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom): (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted. (WebKitDOMXPathNSResolverTest::runTest): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: (WebKitFrameTest::create): (WebKitFrameTest::testMainFrame): (WebKitFrameTest::testURI): (WebKitFrameTest::testJavaScriptContext): (WebKitFrameTest::webPageFromArgs): Deleted. (WebKitFrameTest::runTest): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: (testWebKitDOMNodeHierarchyNavigation): (testWebKitDOMNodeInsertion): (testWebKitDOMNodeTagNames): (beforeAll): (afterAll): * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: (runTest): (beforeAll): (afterAll): * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: (testWebKitDOMXPathNSResolverNative): (testWebKitDOMXPathNSResolverCustom): (beforeAll): (afterAll): (runTest): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: (webkitFrameTestRun): (beforeAll): (afterAll): * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: (testsMap): (WebProcessTest::add): (WebProcessTest::create): (runTest): (windowObjectClearedCallback): (webkit_web_extension_initialize): (methodCallCallback): Deleted. (webkit_web_extension_initialize_with_user_data): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed. * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::runWebProcessTest): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: 2014-11-28 Csaba Osztrogonác <ossy@webkit.org> [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules https://bugs.webkit.org/show_bug.cgi?id=139086 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: * efl/patches/libseccomp-pick-up-CC.patch: Added. 2014-11-28 Bartlomiej Gajda <b.gajda@samsung.com> [EFL] Add warning if CMake version is too old for building with ninja. https://bugs.webkit.org/show_bug.cgi?id=139055 Reviewed by Gyuyoung Kim. CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have that version in their repositories. * efl/install-dependencies: 2014-11-28 Andrzej Badowski <a.badowski@samsung.com> [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table. https://bugs.webkit.org/show_bug.cgi?id=139044 Reviewed by Chris Fleizach. ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell. The proposed solution will enable the use of this method for the object table. Existing test shows the result. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::columnHeaders): 2014-11-27 Ryuan Choi <ryuan.choi@navercorp.com> [EFL] Remove E_Dbus dependency https://bugs.webkit.org/show_bug.cgi?id=136355 Reviewed by Gyuyoung Kim. * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes. 2014-11-26 Akos Kiss <akiss@inf.u-szeged.hu> [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk. https://bugs.webkit.org/show_bug.cgi?id=139047 Reviewed by Carlos Garcia Campos. * efl/jhbuild.modules: * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added. * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed. * gtk/jhbuild-optional.modules: * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added. * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed. 2014-11-25 Tanay C <tanay.c@samsung.com> [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll https://bugs.webkit.org/show_bug.cgi?id=138090 Reviewed by Carlos Garcia Campos. * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll (browserWindowZoomIn): Added. (browserWindowZoomOut): Added. (scrollEventCallback): Added. (zoomInCallback): Modified. (zoomOutCallback): Modified. (browserWindowConstructed): Modified. 2014-11-25 Csaba Osztrogonác <ossy@webkit.org> [EFL] REGRESSION(r176514): It made performance tests fail https://bugs.webkit.org/show_bug.cgi?id=139037 Reviewed by Gyuyoung Kim. * Scripts/webkitpy/port/efl.py: (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR. * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists. 2014-11-24 Michael Catanzaro <mcatanzaro@igalia.com> [GTK] update-webkitgtk-libs fails to build fontconfig https://bugs.webkit.org/show_bug.cgi?id=139032 Reviewed by Martin Robinson. On Fedora, if docbook-utils is installed but docbook-utils-pdf is not, fontconfig will try to generate documentation and fail. * gtk/install-dependencies: 2014-11-24 Carlos Garcia Campos <cgarcia@igalia.com> Unreviewed. Fix GTK+ make distcheck. * gtk/manifest.txt: Remove deleted files. 2014-11-24 Krzysztof Czech <k.czech@samsung.com> [EFL] Utilize Eail library to support accessibility in EFL https://bugs.webkit.org/show_bug.cgi?id=137742 Reviewed by Gyuyoung Kim. Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional. * efl/jhbuild-optional.modules: Added. * efl/jhbuild.modules: 2014-11-24 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view() https://bugs.webkit.org/show_bug.cgi?id=139023 Reviewed by Sergio Villar Senin. Rename WebKitWebView/default-context as WebKitWebView/web-context and check we are always using the right context for new web views. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewWebContext): (beforeAll): (testWebViewDefaultContext): Deleted. 2014-11-23 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add API to override the default local storage directory https://bugs.webkit.org/show_bug.cgi?id=138828 Reviewed by Gustavo Noronha Silva. Add test to check that the local storage directory is created at the path given on construction. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextConfiguration): (beforeAll): * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h: (Test::Test): (Test::~Test): Deleted. 2014-11-21 Zalan Bujtas <zalan@apple.com> Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser. https://bugs.webkit.org/show_bug.cgi?id=138981 Reviewed by Simon Fraser. * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]): (-[SettingsController simpleLineLayoutDebugBordersEnabled]): * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController didChangeSettings]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController didChangeSettings]): 2014-11-21 Csaba Osztrogonác <ossy@webkit.org> Remove http lock code from webkitperl https://bugs.webkit.org/show_bug.cgi?id=138959 Reviewed by Alexey Proskuryakov. * Scripts/webkitperl/httpd.pm: (cleanUp): (extractLockNumber): Deleted. (getLockFiles): Deleted. (getNextAvailableLockNumber): Deleted. (getLockNumberForCurrentRunning): Deleted. (waitForHTTPDLock): Deleted. (scheduleHttpTesting): Deleted. (getWaitTime): Deleted. 2014-11-20 Hunseop Jeong <hs85.jeong@samsung.com> [EFL] The option value of fixed layout is false in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=138830 Reviewed by Gyuyoung Kim. Changed the option value of fixed layout to EINA_TRUE in MiniBrowser. * MiniBrowser/efl/main.c: 2014-11-20 Adrian Perez de Castro <aperez@igalia.com> [GTK] Provide convenience API in DOM bindings to post messages to user message handlers https://bugs.webkit.org/show_bug.cgi?id=138871 Reviewed by Carlos Garcia Campos. Add a test case for the convenience API for posting user messages added to the DOM bindings. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: (testUserContentManagerMessageFromConvenienceDOMBindings): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (documentLoadedCallback): 2014-11-19 Dana Burkart <dburkart@apple.com> Work around the fact that different masters may have different names for their codebases. https://bugs.webkit.org/show_bug.cgi?id=138878 Reviewed by Mark Rowe. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: (parseRevisionProperty): Changed. Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in opensource / internal codebase naming convention. 2014-11-19 Chris Fleizach <cfleizach@apple.com> AX: Screen braille input doesn't work on forms. https://bugs.webkit.org/show_bug.cgi?id=138804 Unreviewed build fix. * DumpRenderTree/AccessibilityUIElement.cpp: (AccessibilityUIElement::setValue): 2014-11-19 Chris Fleizach <cfleizach@apple.com> AX: Screen braille input doesn't work on forms. https://bugs.webkit.org/show_bug.cgi?id=138804 Reviewed by Mario Sanchez Prada. Add a method to setValue through the AX API in DRT. * DumpRenderTree/AccessibilityUIElement.cpp: (setValueCallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::setValue): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::setValue): 2014-11-18 Csaba Osztrogonác <ossy@webkit.org> Remove the WinCairo buildbot https://bugs.webkit.org/show_bug.cgi?id=138805 Reviewed by Alex Christensen. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (appendCustomBuildFlags): * BuildSlaveSupport/test-result-archive: (archiveTestResults): 2014-11-18 Daniel Bates <dabates@apple.com> [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt SPI are not available in public SDK https://bugs.webkit.org/show_bug.cgi?id=138802 Reviewed by David Kilzer. Include header MachVMSPI.h instead of including the private header mach/mach_vm.h. * DumpRenderTree/mac/CheckedMalloc.cpp: 2014-11-18 Carlos Garcia Campos <cgarcia@igalia.com> Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256. Forgot to fix this test before landing. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewDefaultContext): 2014-11-18 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add API to create a WebKitWebContext https://bugs.webkit.org/show_bug.cgi?id=138826 Reviewed by Gustavo Noronha Silva. Use a different WebKitWebContext for every test to ensure test cases are independent to each other. Tests using DBus to communicate with the injected bundle extension now use a unique name for the well known DBus name. * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: (beforeAll): Remove comment about the order of the tests and move the success test before the failed one now that tests don't depend on each others. * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: (beforeAll): Remove call to set the web extensions directory, since this is now done for all test in the Test constructor. * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: (beforeAll): Do not create a temporary directory, a temporary data directory is now created for all tests. (afterAll): * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID to the web process test runner. (testWebKitDOMNodeInsertion): Ditto. (testWebKitDOMNodeTagNames): Ditto. (beforeAll): Remove call to set the web extensions directory. * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: (runTest): Pass the web extension ID to the web process test runner. (beforeAll): Remove call to set the web extensions directory. * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: (runTest): Pass the web extension ID to the web process test runner. (beforeAll): Remove call to set the web extensions directory. * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: (createFileAtDestination): Use Test::dataDirectory() as base dir for temporary files. (beforeAll): Do not create a temporary directory. (afterAll): * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: (webkitFrameTestRun): Pass the web extension ID to the web process test runner. (beforeAll): Remove call to set the web extensions directory. * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: (beforeAll): Remove call to set the web extensions directory. * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp: (testProcessPerWebView): Use local member instead of global variable. (testMultiprocessWebViewCreateReadyClose): Ditto. (beforeAll): Do not connect to initialize-web-extensions, Test now connects to the signal for all tests and calls a virtual method that test can override. (afterAll): (initializeWebExtensions): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: (testPrintOperationPrint): Use Test::dataDirectory() as base dir for temporary files. (beforeAll): Do not create a temporary directory. (afterAll): * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: (beforeAll): Remove call to set the web extensions directory. * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: (beforeAll): Remove comment about the tests order. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: (testWebExtensionGetTitle): Build the DBus service name using the web extension ID. (testDocumentLoadedSignal): Ditto. (testWebKitWebViewProcessCrashed): Ditto. (testWebExtensionIsolatedWorld): Ditto. (beforeAll): Remove initialization-user-data test, since now all tests are passing user data to the web extension. (testWebExtensionInitializationUserData): Deleted. (initializeWebExtensions): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: (testSetDirectory): Use the web context member inherited from Test. (testClearDatabase): Ditto. (testGetFaviconURI): Ditto. (beforeAll): Do not create a temporary directory. (afterAll): (webkitFaviconDatabaseFinalizedCallback): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: (UserContentManagerTest::UserContentManagerTest): (beforeAll): Remove call to set the web extensions directory. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextDefault): Check also that a newly create web context is not the default web context. (testWebContextSpellChecker): Use the web context member inherited from Test. (testWebContextLanguages): Ditto. * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (methodCallCallback): Remove GetInitializationUserData method. (webkit_web_extension_initialize_with_user_data): Always create the DBus name using the user data provided. (makeBusName): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: (webkit_web_extension_initialize_with_user_data): Create the DBus name using the user data provided. (webkit_web_extension_initialize): Deleted. * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp: (Test::dataDirectory): Return the temporary data directory. (removeNonEmptyDirectory): Also remove directories recursively. (main): Remove the disk cache directory initialization, since this is now done in the Test constructor. * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h: (Test::initializeWebExtensionsCallback): Call the virtual method initializeWebExtensions() (Test::Test): Create a new WebKitWebContext and initialize it. (Test::~Test): Disconnect initialize-web-extensions signal. (Test::initializeWebExtensions): Set the web extensions directory and user data. * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr. (WebProcessTestRunner::runTest): Build the DBus proxy using a unique name created with the Test web extension ID. (WebProcessTestRunner::proxy): Deleted. * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::WebViewTest): Create the web view with the Test web context. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user content manager parameter to the constructor. 2014-11-18 ChangSeok Oh <changseok.oh@collabora.com> [GTK] Mesa build fails over llvm-3.5 https://bugs.webkit.org/show_bug.cgi?id=138825 Reviewed by Gustavo Noronha Silva. OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build. * gtk/jhbuild.modules: * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added. 2014-11-17 Daniel Bates <dabates@apple.com> Unreviewed, rolling out r176232. Broke the Mac build. Will investigate offline. Reverted changeset: "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt" https://bugs.webkit.org/show_bug.cgi?id=138802 http://trac.webkit.org/changeset/176232 2014-11-17 Daniel Bates <dabates@apple.com> [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt SPI are not available in public SDK https://bugs.webkit.org/show_bug.cgi?id=138802 Reviewed by David Kilzer. Include header MachVMSPI.h instead of including the private header mach/mach_vm.h. * DumpRenderTree/mac/CheckedMalloc.cpp: 2014-11-17 Jake Nielsen <jacob_nielsen@apple.com> Having 30+ flaky failures breaks EWS https://bugs.webkit.org/show_bug.cgi?id=138743 Reviewed by Alexey Proskuryakov. Adds tests to ensure that the problem has been solved. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: (test_first_failure_limit): (test_first_failure_limit_with_some_tree_redness): (test_second_failure_limit): (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness): (test_first_and_second_failure_limit): (test_first_and_clean_failure_limit): (test_first_second_and_clean_failure_limit): (test_very_red_tree_retry): Deleted. Really this was renamed to test_first_second_and_clean_failure_limit. * Scripts/webkitpy/tool/bot/patchanalysistask.py: Makes the appropriate changes to PatchAnalysisTask to make sure that even when the first test run hits the failure limit, it will still try a second run. (PatchAnalysisTask._results_failed_different_tests): (PatchAnalysisTask._test_patch): (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted. 2014-11-17 Ting-Wei Lan <lantw44@gmail.com> [GTK] Add library search paths from LDFLAGS before pkg-config --libs https://bugs.webkit.org/show_bug.cgi?id=136018 Reviewed by Carlos Garcia Campos. It is possible that the order of -L arguments in the output of pkg-config is wrong, which causes the linker to find the wrong version (usually older version) of libraries when running gtkdoc-scangobj. * gtk/gtkdoc.py: (GTKDoc._run_gtkdoc_scangobj): 2014-11-17 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> Bump EFL version to 1.12.0 https://bugs.webkit.org/show_bug.cgi?id=138733 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: 2014-11-16 Joanmarie Diggs <jdiggs@igalia.com> AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE https://bugs.webkit.org/show_bug.cgi?id=138771 Reviewed by Chris Fleizach. Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString() * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: 2014-11-15 Joanmarie Diggs <jdiggs@igalia.com> AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles. https://bugs.webkit.org/show_bug.cgi?id=138767 Reviewed by Chris Fleizach. Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString(). * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: 2014-11-14 Alexey Proskuryakov <ap@apple.com> Add shortcut macros to Mac TestExpectations https://bugs.webkit.org/show_bug.cgi?id=138729 Reviewed by Simon Fraser. * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros): Add version macros for current OS versions. 2014-11-13 Alexey Proskuryakov <ap@apple.com> https://bugs.webkit.org/show_bug.cgi?id=138628 A patch that doesn't apply is stuck in commit queue Rubber-stamped by David Kilzer. This also hopefully fixes other issues: - a patch that has cq+ flag set by a non-committer kills commit queue; - EWS never reports failing tests, and keeps spinning instead. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla.set_flag_on_attachment): (Bugzilla.obsolete_attachment): Apply the fix from r174797 to more places. 2014-11-13 Dan Bernstein <mitz@apple.com> Policy client not called for navigations through the page cache https://bugs.webkit.org/show_bug.cgi?id=138703 Reviewed by Alexey Proskuryakov. * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm: (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]): (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): 2014-11-13 Joanmarie Diggs <jdiggs@igalia.com> AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects https://bugs.webkit.org/show_bug.cgi?id=137867 Reviewed by Chris Fleizach. Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be able to test for the presence of ATK_ROLE_INVALID. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::role): 2014-11-13 Juergen Ributzka <juergen@apple.com> Update the "combineModules" script to handel more LLVM metadata. https://bugs.webkit.org/show_bug.cgi?id=138514 Reviewed by Filip Pizlo. * ReducedFTL/combineModules.rb: 2014-11-13 Myles C. Maxfield <mmaxfield@apple.com> Allow constructing a base PassRef with a derived Ref https://bugs.webkit.org/show_bug.cgi?id=138701 Reviewed by Andreas Kling * TestWebKitAPI/Tests/WTF/Ref.cpp: (TestWebKitAPI::passWithPassRef): (TestWebKitAPI::passWithPassRefPtr): (TestWebKitAPI::TEST): 2014-11-05 Ada Chan <adachan@apple.com> Implement new plug-in API for muting plug-ins https://bugs.webkit.org/show_bug.cgi?id=138105 Reviewed by Anders Carlsson. Add a new plug-in test for the mute API. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added. (SetMuted::SetMuted): (SetMuted::isMuted): (SetMuted::cachedIsMuted): (SetMuted::ScriptableObject::hasProperty): (SetMuted::ScriptableObject::getProperty): (SetMuted::ScriptableObject::pluginTest): (SetMuted::NPP_New): (SetMuted::NPP_GetValue): (SetMuted::NPP_SetValue): 2014-11-12 Philippe Normand <pnormand@igalia.com> Unreviewed, GTK gardening. * Scripts/run-gtk-tests: (TestRunner): Skip the UserMediaBasic test because it depends on constraints validation which is going to be fixed in bug #136449. 2014-11-12 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Expose user script messages to GObject DOM bindings https://bugs.webkit.org/show_bug.cgi?id=138411 Reviewed by Philippe Normand. Add a test case to check that user script messages sent using the DOM bindings API are also received in the UI process. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: (UserScriptMessageTest::waitUntilMessageReceived): (UserScriptMessageTest::postMessageAndWaitUntilReceived): (testUserContentManagerScriptMessageFromDOMBindings): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (documentLoadedCallback): 2014-11-12 Carlos Garcia Campos <cgarcia@igalia.com> Unreviewed. Fix GTK+ clean build after r175930. Partial rollout of r175930 to not build the new unit test that broke clean builds in GTK+ port. * TestWebKitAPI/PlatformGTK.cmake: 2014-09-01 Philippe Normand <pnormand@igalia.com> [WK2] UserMediaClient support https://bugs.webkit.org/show_bug.cgi?id=123158 Reviewed by Benjamin Poulain. Simple API test for the UserMedia permission request API. The required test infrastructure is also added, inspired by the Geolocation infrastructure. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia Permission request. * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added. (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new helper method to set the permission request result without user interaction. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto. (WTR::InjectedBundle::setUserMediaPermission): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto. (WTR::TestRunner::setUserMediaPermission): * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto. * WebKitTestRunner/TestController.cpp: (WTR::decidePolicyForUserMediaPermissionRequest): Permission request handler. (WTR::TestController::createOtherPage): Enable the new UserMedia permission request handler. (WTR::TestController::createWebViewWithOptions): Ditto. (WTR::TestController::resetPreferencesToConsistentValues): Enable MediaStream support, this is needed for getUserMedia. (WTR::TestController::resetStateToConsistentValues): clear UserMedia permissions list and flags. (WTR::TestController::setUserMediaPermission): Set permission request result and distpatch it. (WTR::TestController::handleUserMediaPermissionRequest): Save request and dispatch it. (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Dispatch cached permission requests. * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 2014-11-11 David Kilzer <ddkilzer@apple.com> webkit-patch --suggest-reviewers is broken with newer versions of git <http://webkit.org/b/138627> Reviewed by Michael Saboff with feedback from Daniel Bates. * Scripts/webkitpy/common/checkout/scm/git.py: (Git._changes_files_for_commit): Strip blank lines instead of assuming there is always a blank line at the beginning of the list. 2014-11-11 Alexey Proskuryakov <ap@apple.com> DRT and WKTR touch disk cache https://bugs.webkit.org/show_bug.cgi?id=138622 Reviewed by Geoffrey Garen. * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment): Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after, because this function uses the shared cache. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext): Create an empty shared cache to prevent a default one from being created on disk. 2014-10-07 Sergio Villar Senin <svillar@igalia.com> [CSS Grid Layout] Limit the size of explicit/implicit grid https://bugs.webkit.org/show_bug.cgi?id=136217 Reviewed by Andreas Kling. Added a new unit test for the CSS parser. Right now it only checks that we properly clamp the maximum number of tracks on a grid to a maximum of 1 million. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/PlatformEfl.cmake: * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added. (TestWebKitAPI::computeNumberOfTracks): Helper function. (TestWebKitAPI::TEST): Added a CSSPropertyParserTest.GridTrackLimits test case. 2014-11-11 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> webkitpy test fix after r175867 https://bugs.webkit.org/show_bug.cgi?id=138607 Reviewed by Philippe Normand. * Scripts/webkitpy/port/linux_get_crash_log_unittest.py: (GDBCrashLogGeneratorTest.test_generate_crash_log): 2014-11-10 Philippe Normand <pnormand@igalia.com> webkitpy: demangle C++ symbols from crash log stderr https://bugs.webkit.org/show_bug.cgi?id=138565 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/port/linux_get_crash_log.py: (GDBCrashLogGenerator.generate_crash_log): Process stderr output with c++filt. 2014-11-10 Philippe Normand <pnormand@igalia.com> [GTK] fix up the GDB backtrace report tool https://bugs.webkit.org/show_bug.cgi?id=138564 Reviewed by Carlos Garcia Campos. * Scripts/webkitpy/port/gtk.py: (GtkPort._get_crash_log): Match the process name reported by the driver with the GTK port WebProcess executable filename. * Scripts/webkitpy/port/linux_get_crash_log.py: (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed program. (GDBCrashLogGenerator.generate_crash_log): Use %E in the core pattern to workaround the 16 characters size limit of %e. 2014-11-10 Conrad Shultz <conrad_shultz@apple.com> Unreviewed, moved myself to the list of committers. * Scripts/webkitpy/common/config/contributors.json: 2014-11-10 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> [EFL] Fix the test font path after r175555. Reviewed by Csaba Osztrogonác. * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL 2014-11-10 Akos Kiss <akiss@inf.u-szeged.hu> Fix the exception fuzz helper to generate targets in the correct range https://bugs.webkit.org/show_bug.cgi?id=138544 Reviewed by Filip Pizlo. Currently, the script generates exception fuzz targets in the range of 0..($checkCount-1). However, target 0 is never hit, while target 1 is always outside of the outermost try block of the tests, which therefore prints unexpected output and results in false failures when fired at. Additionally, target $checkCount is never generated. This patch fixes the script to generate targets in the range of 2..$checkCount. * Scripts/jsc-stress-test-helpers/js-exception-fuzz: 2014-11-09 Csaba Osztrogonác <ossy@webkit.org> make-passwords-json.py should generarate everything needed for testing https://bugs.webkit.org/show_bug.cgi?id=138503 Reviewed by Ryosuke Niwa. * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py: Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py. Additionally generate auth.json, credentials.cfg and committers.cfg too. (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication. (BuildBotConfigLoader._create_mock_passwords_dict): Deleted. 2014-11-09 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] generate-gtkdoc should ignore invalid files https://bugs.webkit.org/show_bug.cgi?id=138542 Reviewed by Darin Adler. * gtk/generate-gtkdoc: (files_to_ignore.file_should_be_ignored): Return True to ignore invalid files. 2014-11-08 Alexey Proskuryakov <ap@apple.com> Delete cookies between tests https://bugs.webkit.org/show_bug.cgi?id=138528 Reviewed by Sam Weinig. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): Do it. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): Added a FIXME. 2014-11-08 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Run layout tests using the network process https://bugs.webkit.org/show_bug.cgi?id=138428 Reviewed by Martin Robinson. Shared secondary process is the default in the GTK+ port, but we should run the tests using the network process to ensure everything works with the network process. In the future, the shared secondary process model might be a special case of multiple processes with 1 as maximum number of processes, but always using the network process. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): 2014-11-08 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Allow to create a view with a related page in WTR https://bugs.webkit.org/show_bug.cgi?id=138501 Reviewed by Martin Robinson. * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as related page to WKViewCreate. * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::PlatformWebView): Pass the given related page to WKViewCreate. 2014-11-08 Carlos Garcia Campos <cgarcia@igalia.com> WTR crashes after running a test when NetworkProcess enabled https://bugs.webkit.org/show_bug.cgi?id=138500 Reviewed by Alexey Proskuryakov. WebNotificationProvider destructor is calling WKNotificationManagerSetProvider, but m_notificationManager is null because removeNotificationManager was already called. * WebKitTestRunner/WebNotificationProvider.cpp: (WTR::WebNotificationProvider::~WebNotificationProvider): Check m_notificationManager is not null before calling WKNotificationManagerSetProvider. 2014-11-06 Jake Nielsen <jacob_nielsen@apple.com> Remove duplicate code from PatchAnalysisTask._test_patch and fix bug regarding incorrect call to PatchAnalysisTask.report_failure https://bugs.webkit.org/show_bug.cgi?id=138229 Reviewed by Daniel Bates. * Scripts/webkitpy/common/net/layouttestresults.py: Makes sure test_results returns a list. (LayoutTestResults.test_results): * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Makes unit tests also check to make sure task.results_from_patch_test_run() and task.results_from_test_run_without_patch return instances of LayoutTestResults. (CommitQueueTaskTest._run_and_expect_patch_analysis_result): * Scripts/webkitpy/tool/bot/patchanalysistask.py: Condenses duplicate code into _should_defer_patch_or_throw, and removes the now-unused _clean_tree_results member. (PatchAnalysisTask.__init__): (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): (PatchAnalysisTask._should_defer_patch_or_throw): (PatchAnalysisTask._test_patch): (PatchAnalysisTask.results_from_patch_test_run): (PatchAnalysisTask.results_from_test_run_without_patch): Deleted. * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Removes needless call to results_from_test_run_without_patch (AbstractEarlyWarningSystem._failing_tests_message): * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Changes order of test failure messages to be in the order that they appear. (AbstractEarlyWarningSystemTest.test_failing_tests_message): * Scripts/webkitpy/tool/commands/queues.py: Removes needless call to results_from_test_run_without_patch. (CommitQueue._failing_tests_message): * Scripts/webkitpy/tool/commands/queues_unittest.py: (MockCommitQueueTask.results_from_test_run_without_patch): Deleted. 2014-11-06 Ryuan Choi <ryuan.choi@navercorp.com> Unreviewed. Reorder my e-mail addresses in contributors.json * Scripts/webkitpy/common/config/contributors.json: 2014-11-06 Matthew Hanson <matthew_hanson@apple.com> Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev https://bugs.webkit.org/show_bug.cgi?id=138475 Reviewed by Ryosuke Niwa. The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit. This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish. * Scripts/webkitpy/common/checkout/scm/git.py: (Git._run_git_svn_find_rev): Add comment mentioning that svn_revisions need to begin with 'r'. Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location. Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take. Remove code that coerced the revision/treeish into a string and prepended an 'r'. 2014-11-06 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add context menu API to Web Process Extensions https://bugs.webkit.org/show_bug.cgi?id=138311 Reviewed by Gustavo Noronha Silva. Add tests cases for WebKitWebPage::context-menu signal. * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: (testContextMenuWebExtensionMenu): (testContextMenuWebExtensionNode): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (serializeContextMenu): (serializeNode): (contextMenuCallback): (pageCreatedCallback): 2014-11-06 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r175690. https://bugs.webkit.org/show_bug.cgi?id=138460 We are not ready to run layout tests using the network process yet (Requested by KaL on #webkit). Reverted changeset: "[GTK] Run layout tests using the network process" https://bugs.webkit.org/show_bug.cgi?id=138428 http://trac.webkit.org/changeset/175690 2014-11-06 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Run layout tests using the network process https://bugs.webkit.org/show_bug.cgi?id=138428 Reviewed by Martin Robinson. Shared secondary process is the default in the GTK+ port, but we should run the tests using the network process to ensure everything works with the network process. In the future, the shared secondary process model might be a special case of multiple processes with 1 as maximum number of processes, but always using the network process. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): 2014-11-05 Dan Bernstein <mitz@apple.com> Remove the unused deletion UI feature https://bugs.webkit.org/show_bug.cgi?id=138442 Rubber-stamped by Alexey Proskuryakov. * DumpRenderTree/mac/EditingDelegate.mm: (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of delegate method that’s been removed. 2014-11-05 Alexey Proskuryakov <ap@apple.com> fast/dom/remove-body-during-body-replacement2.html fails on WK2 https://bugs.webkit.org/show_bug.cgi?id=138334 Reviewed by Anders Carlsson. Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder calls, which works because each frame is an NSView in WK1. WK2 makes equivalent -makeFirstResponder calls, which may or may not be needed for other reasons, but it also needs to reset internal focus explicitly. It's not clear if this is the right long-term fix or a workaround for a WebKit bug. WebKit behavior appears wrong, but it matches Firefox. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::resetAfterTest): 2014-11-05 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add WebKitWebResource::failed-with-tls-errors signal https://bugs.webkit.org/show_bug.cgi?id=137862 Reviewed by Gustavo Noronha Silva. Add a test case to check that WebKitWebResource::failed-with-tls-errors is emitted when a subresource load fails due to TLS errors. * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: (TLSSubresourceTest::resourceLoadStartedCallback): (TLSSubresourceTest::TLSSubresourceTest): (TLSSubresourceTest::subresourceFailedCallback): (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback): (TLSSubresourceTest::subresourceLoadStarted): (TLSSubresourceTest::subresourceFailedWithTLSErrors): (TLSSubresourceTest::waitUntilSubresourceLoadFail): (testSubresourceLoadFailedWithTLSErrors): (httpsServerCallback): (httpServerCallback): (beforeAll): 2014-11-05 Alexey Proskuryakov <ap@apple.com> Build fix for some compiler versions. * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was unhappy because this is a getter, and these shouldn't have side effects. 2014-11-04 Matthew Hanson <matthew_hanson@apple.com> Add a method for performing cherrypick-merges. https://bugs.webkit.org/show_bug.cgi?id=138375 Reviewed by Ryosuke Niwa. Adds support for cherrypick-merges. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.cherrypick_merge): Added. 2014-11-04 Matthew Hanson <matthew_hanson@apple.com> Add a way to ascertain the SVN URL associated with a Git branch. https://bugs.webkit.org/show_bug.cgi?id=138374 Reviewed by Ryosuke Niwa. The svn_url method returns the SVN URL associated with the current Git branch. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.svn_url): Added. 2014-11-04 Matthew Hanson <matthew_hanson@apple.com> Add the ability to search for modifications that are staged for commit. https://bugs.webkit.org/show_bug.cgi?id=138373 Reviewed by Ryosuke Niwa and Daniel Bates. This makes is easy to do identify files that require merge post-processing, in addition to stand-alone utility. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.modifications_staged_for_commit): Added. 2014-11-04 Matthew Hanson <matthew_hanson@apple.com> Add a branch keyword argument to _run_git_svn_find_rev. https://bugs.webkit.org/show_bug.cgi?id=138372 Reviewed by Ryosuke Niwa. The addition of this keyword argument allows clients to determine the Git hash of commits made on an SVN branch, provided that branch has been fetched locally. * Scripts/webkitpy/common/checkout/scm/git.py: (Git._run_git_svn_find_rev): Add a branch keyword argument that is added to the end of the command, if present. 2014-11-04 Chris Dumez <cdumez@apple.com> Add ptr() method to Ref class https://bugs.webkit.org/show_bug.cgi?id=138361 Reviewed by Darin Adler. Use the new Ref::ptr() method. * TestWebKitAPI/Tests/WTF/Ref.cpp: (TestWebKitAPI::TEST): 2014-11-04 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> [jhbuild] Make it possible to build GTK/EFL in same repository https://bugs.webkit.org/show_bug.cgi?id=137448 Reviewed by Martin Robinson. * Scripts/webkitdirs.pm: (getJhbuildPath): * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: (getPlatformFontsPath): * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: (WTR::getFontsPath): * jhbuild/jhbuild-wrapper: (determine_platform): (install_jhbuild): * jhbuild/jhbuildrc_common.py: (init): 2014-11-04 Dániel Bátyai <dbatyai.u-szeged@partner.samsung.com> [EFL] Bump LLVM to version 3.5.0 https://bugs.webkit.org/show_bug.cgi?id=138312 Reviewed by Csaba Osztrogonác. * efl/jhbuild.modules: * efl/patches/llvm-elf-add-stackmaps.patch: Added. * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added. 2014-11-03 Simon Fraser <simon.fraser@apple.com> Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2 https://bugs.webkit.org/show_bug.cgi?id=138257 Reviewed by Tim Horton. Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows the user to toggle region page overlays on and off. Two overlays are available, for the non-fast scrollable region, and the region of element with wheel event handlers. * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController nonFastScrollableRegionOverlayVisible]): (-[SettingsController wheelEventHandlerRegionOverlayVisible]): (-[SettingsController preferenceKeyForRegionOverlayTag:]): (-[SettingsController toggleDebugOverlay:]): (-[SettingsController debugOverlayVisible:]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController didChangeSettings]): 2014-11-03 Alexey Proskuryakov <ap@apple.com> REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page https://bugs.webkit.org/show_bug.cgi?id=138323 Reviewed by Zalan Bujtas. * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down. 2014-11-03 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> [ninja] Don't remove response files for verbose builds https://bugs.webkit.org/show_bug.cgi?id=137816 Reviewed by Csaba Osztrogonác. * Scripts/webkitdirs.pm: (determineNinjaVersion): (buildCMakeGeneratedProject): 2014-11-02 Akos Kiss <akiss@inf.u-szeged.hu> [GTK] Fix the build of FTL JIT https://bugs.webkit.org/show_bug.cgi?id=138298 Reviewed by Carlos Garcia Campos. * gtk/jhbuild-optional.modules: Bump up LLVM version to 3.5.0 release and apply patches. * gtk/patches/llvm-elf-add-stackmaps.patch: Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM trunk. * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added. Ensures that PC-relative relocations in EH frames are not truncated to 32 bits on x86_64. 2014-10-31 Michael Saboff <msaboff@apple.com> No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests https://bugs.webkit.org/show_bug.cgi?id=138268 Reviewed by Andreas Kling. Added a --arch and --os option to set or override the values that are normally computed based on examining the JavaScriptCore we want to test. * Scripts/run-jsc-stress-tests: 2014-10-31 Dan Bernstein <mitz@apple.com> llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory https://bugs.webkit.org/show_bug.cgi?id=138259 Reviewed by Geoff Garen. * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s going to be empty to silence the warning. 2014-10-31 Adrian Perez de Castro <aperez@igalia.com> [GTK] Support script message handlers WebKitUserContentManager https://bugs.webkit.org/show_bug.cgi?id=133730 Reviewed by Carlos Garcia Campos. Support user script message handlers in WebKitUserContentManager. This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which an option is added to the CMake build files. The option is disabled globally by default, and the WebKitGTK port enables it. On the API level, two new methods to register and unregister names are provided in the "window.webkit" namespace, and on message reception the "WebKitUserContentManager::script-message-received" signal is emitted, using the registered names as signal detail. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: Add test case for user script message handlers. (scriptMessageReceived): (testUserContentManagerScriptMessageReceived): (beforeAll): 2014-10-30 Matthew Hanson <matthew_hanson@apple.com> bisect-builds should support WebKit clients other than Safari https://bugs.webkit.org/show_bug.cgi?id=138225 This patch adds support for bisecting WebKit nightly builds with clients other than Safari. The -a / --application optional argument allows the user to specify which application (or application bundle) should be run against the WebKit nightly builds. Reviewed by David Kilzer. * Scripts/bisect-builds: Swap out $safariPath for the more general $applicationPath Leave --safari-path as a commandline option for backwards compatibility (mountAndRunNightly): Use File::Spec->cat correctly (one directory per argument) Use open --wait-apps instead of running the target application directly 2014-10-30 Dana Burkart <dburkart@apple.com> <rdar://problem/18821260> Perpare for the mysterious future Reviewed by Lucas Forschler. * DumpRenderTree/mac/Configurations/Base.xcconfig: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * LayoutTestRelay/Configurations/Base.xcconfig: * LayoutTestRelay/Configurations/DebugRelease.xcconfig: * MiniBrowser/Configurations/Base.xcconfig: * MiniBrowser/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * WebKitLauncher/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: 2014-10-30 Matthew Hanson <matthew_hanson@apple.com> Update safariVersion to safariVersionString https://bugs.webkit.org/show_bug.cgi?id=138193 The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x, but it should have also been done for the "4 Public Beta" check in OS X 10.4.x. Rubber-stamped by David Kilzer. * Scripts/bisect-builds: (makeNightlyList): Compare safariVersionString to a string literal, instead of safariVersion. 2014-10-30 Rohit Kumar <kumar.rohit@samsung.com> [GTK] Minibrowser : Add window fullscreen support for Minibrowser https://bugs.webkit.org/show_bug.cgi?id=137775 Reviewed by Carlos Garcia Campos. * MiniBrowser/gtk/BrowserWindow.c: (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key. (browser_window_init): 2014-10-29 Jake Nielsen <jacob_nielsen@apple.com> CommitQueue and EWS should reject any patches that result in consistent test failures that aren't present on the tree. https://bugs.webkit.org/show_bug.cgi?id=138184 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/layout_tests/models/test_results.py: Adds a simple hashing function to allow for set operations to handle TestResult objects properly. (TestResult.__hash__): * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Adds one unit test, and modifies others to agree with the notion that patches that introduce new test failures (but also have flakyness) should be rejected rather than spin. (MockCommitQueue.report_flaky_tests): (CommitQueueTaskTest._run_and_expect_patch_analysis_result): (test_double_flaky_test_failure): (test_two_flaky_tests): (test_very_flaky_patch): (test_very_flaky_patch_with_some_tree_redness): (test_different_test_failures): (test_different_test_failures_with_some_tree_redness): (test_different_test_failures_with_some_tree_redness_and_some_fixes): (test_mildly_flaky_patch): (test_mildly_flaky_patch_with_some_tree_redness): * Scripts/webkitpy/tool/bot/patchanalysistask.py: Makes PatchAnalysisTask reject said patches. (PatchAnalysisTask._test_patch): 2014-10-29 Youenn Fablet <youenn.fablet@crf.canon.fr> WinCairoRequirements.zip cannot be downloaded from dropbox https://bugs.webkit.org/show_bug.cgi?id=138113 Reviewed by Alexey Proskuryakov. * Scripts/update-webkit-dependency: Removing --sslv3 option from curl 2014-10-29 Matthew Hanson <matthew_hanson@apple.com> bisect-builds should filter out nightlies that predate the introduction of an OS X operating system https://bugs.webkit.org/show_bug.cgi?id=138193 This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.) It also does a bit of refactoring, including distinguishing between versions and version strings and saving versions to local variables instead of using eval in each conditional. Reviewed by David Kilzer. * Scripts/bisect-builds: (makeNightlyList): Restrict the set of nightlies to r174650 and above when running Yosemite. Restrict the set of nightlies to r157846 and above when running Mavericks. Restrict the set of nightlies to r122421 and above when running Mountain Lion. 2014-10-29 Csaba Osztrogonác <ossy@webkit.org> [EFL] build-webkit should try harder to avoid re-running cmake https://bugs.webkit.org/show_bug.cgi?id=137949 Reviewed by Martin Robinson. * Scripts/webkitdirs.pm: (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL. (generateBuildSystemFromCMakeProject): Comment fix after r174681. 2014-10-28 Daniel Bates <dabates@apple.com> Unify logic in RunTests.run() to run the Python unit tests https://bugs.webkit.org/show_bug.cgi?id=138160 Reviewed by Martin Robinson. Unify the interactive and non-interactive code path for running the Python unit tests in step RunTests so as to remove duplicate code to compute the the path to the script test-webkitpy and log an informative message ("Running Python unit tests") to the console. No new tests since no functionality was changed. * Scripts/webkitpy/port/base.py: (Port.python_unittest_results_directory): * Scripts/webkitpy/tool/steps/runtests.py: (RunTests.run): 2014-10-28 Jake Nielsen <jacob_nielsen@apple.com> Make runtest.py call test-webkitpy with the --json flag when in non-interactive mode. https://bugs.webkit.org/show_bug.cgi?id=137667 Reviewed by Daniel Bates. * Scripts/webkitpy/port/base.py: Adds the python_unittest_results_directory method. (Port.python_unittest_results_directory): * Scripts/webkitpy/tool/steps/runtests.py: Changes RunTests to call test-webkitpy with the --json flag if the --non-interactive flag is set. (RunTests): (RunTests.run): 2014-10-28 Rebecca Hauck <rhauck@adobe.com> import-w3c-tests should use re.escape() wherever it's handling file paths https://bugs.webkit.org/show_bug.cgi?id=137934 This patch adds re.escape() to a few places where we're doing string conversions. This prevents errors when attribute values coincidentally have character sequences that can be interpreted as regular expressions. Reviewed by Bem Jones-Bey. * Scripts/webkitpy/w3c/test_converter.py: (_W3CTestConverter.convert_attributes_if_needed): 2014-10-28 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp https://bugs.webkit.org/show_bug.cgi?id=138130 Reviewed by Csaba Osztrogonác. * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: 2014-10-25 Raniere Silva <raniere@ime.unicamp.br> Fix link to Arch Linux Wiki https://bugs.webkit.org/show_bug.cgi?id=138010 Reviewed by Benjamin Poulain. * gtk/install-dependencies: 2014-10-25 Alexey Proskuryakov <ap@apple.com> Test regressions are not detected when image result is missing https://bugs.webkit.org/show_bug.cgi?id=138070 Reviewed by Simon Fraser. * Scripts/webkitpy/layout_tests/models/test_run_results.py: * Scripts/webkitpy/layout_tests/views/buildbot_results.py: Count these as regressions, not as flaky tests. * Scripts/webkitpy/port/test.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test it. 2014-10-24 Timothy Horton <timothy_horton@apple.com> Add Conrad Shultz to the contributors list. * Scripts/webkitpy/common/config/contributors.json: 2014-10-24 Dan Bernstein <mitz@apple.com> build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404 https://bugs.webkit.org/show_bug.cgi?id=138046 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was 401. Otherwise, we’ll retry normally in 45 seconds. 2014-10-24 Marcos Chavarría Teijeiro <chavarria1991@gmail.com> [GTK] Implement is_selected method on WebKitHitTestResult https://bugs.webkit.org/show_bug.cgi?id=137110 Reviewed by Tim Horton. Add tests for new context SELECTION on WebKitHitTestResult. * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: (testContextMenuDefaultMenu): * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: (testWebViewMouseTarget): 2014-10-23 Roger Fong <roger_fong@apple.com> [Win] Skip failing JSC tests following r175078 https://bugs.webkit.org/show_bug.cgi?id=130967. * Scripts/run-javascriptcore-tests: 2014-10-22 Jake Nielsen <jacob_nielsen@apple.com> commitqueuetask_unittest.py should be made more concise. https://bugs.webkit.org/show_bug.cgi?id=137985 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Refactors tests to use MockSimpleTestPlanCommitQueue where possible. (MockCommitQueue.__init__): (MockCommitQueue.report_flaky_tests): (MockCommitQueue): (MockCommitQueue.get_reported_flaky_tests): (MockSimpleTestPlanCommitQueue.__init__): (MockSimpleTestPlanCommitQueue.run_command): (MockSimpleTestPlanCommitQueue.did_run_clean_tests): (CommitQueueTaskTest._run_and_expect_patch_analysis_result): (test_land_failure): (test_failed_archive): (test_double_flaky_test_failure): (test_test_failure): (test_red_test_failure): (test_very_red_tree_retry): (test_red_tree_patch_rejection): (test_one_flaky_test): (test_tree_more_red_than_patch): (MockCommitQueue.test_results): Deleted. (test_simple_flaky_test_failure): Deleted. (_expect_validate): Deleted. (_expect_validate.MockDelegate): Deleted. (_expect_validate.MockDelegate.refetch_patch): Deleted. (_expect_validate.MockDelegate.expected_failures): Deleted. (_mock_patch): Deleted. (test_validate): Deleted. * Scripts/webkitpy/tool/bot/patchanalysistask.py: Fixes a bug that slipped through the cracks prior to this change. (PatchAnalysisTask._test_patch): 2014-10-22 Alexey Proskuryakov <ap@apple.com> Flakiness dashboard should support OS X Yosemite https://bugs.webkit.org/show_bug.cgi?id=137986 Reviewed by Ryosuke Niwa. * TestResultServer/app.yaml: * TestResultServer/static-dashboards/builders.jsonp: * TestResultServer/static-dashboards/flakiness_dashboard.js: 2014-10-22 Jake Nielsen <jacob_nielsen@apple.com> commitqueuetask should include more tests to ensure that the behavior of PatchAnalysisTask._test_patch() is well defined https://bugs.webkit.org/show_bug.cgi?id=137977 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Adds the MockSimpleTestPlanCommitQueue class, which makes it easier and more readable to define tests that are meant to test the behaviour of PatchAnalysisTask._test_patch(), and adds several unit tests. (FailingTestCommitQueue.test_results): (PatchAnalysisResult): (MockSimpleTestPlanCommitQueue): (MockSimpleTestPlanCommitQueue.__init__): (MockSimpleTestPlanCommitQueue.run_command): (MockSimpleTestPlanCommitQueue._mock_test_result): (MockSimpleTestPlanCommitQueue.test_results): (CommitQueueTaskTest._run_and_expect_patch_analysis_result): (test_flaky_test_failure): (test_failed_archive): (test_two_flaky_tests): (test_one_flaky_test): (test_very_flaky_patch): (test_very_flaky_patch_with_some_tree_redness): (test_different_test_failures): (test_different_test_failures_with_some_tree_redness): (test_mildly_flaky_patch): (test_mildly_flaky_patch_with_some_tree_redness): (test_tree_more_red_than_patch): 2014-10-22 Jake Nielsen <jacob_nielsen@apple.com> PatchAnalysisTask._test_patch() needs refactoring https://bugs.webkit.org/show_bug.cgi?id=137904 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Fixes several small bugs, and makes minor changes to accomodate the changes in PatchAnalysisTask. (MockCommitQueue.refetch_patch): (MockCommitQueue.test_results): (test_flaky_test_failure): (test_failed_archive): (test_very_red_tree_retry): (_expect_validate.MockDelegate.refetch_patch): (MockCommitQueue.expected_failures): Deleted. (_expect_validate.MockDelegate.expected_failures): Deleted. * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed. * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed. * Scripts/webkitpy/tool/bot/patchanalysistask.py: Removes the unexpected_failures member, adds the _clean_tree_results member, adds a helper function for _test_patch, and refactors _test_patch to be more readable. (PatchAnalysisTask.__init__): (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): (PatchAnalysisTask._test_patch): (PatchAnalysisTask.results_from_test_run_without_patch): * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. (AbstractEarlyWarningSystem.begin_work_queue): (AbstractEarlyWarningSystem._failing_tests_message): (AbstractEarlyWarningSystem.command_failed): (AbstractEarlyWarningSystem.expected_failures): Deleted. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Makes changes to accomodate the changes made to PatchAnalysisTask. (AbstractEarlyWarningSystemTest.test_failing_tests_message): * Scripts/webkitpy/tool/commands/perfalizer.py: Removes Perfalizer's dependancy on ExpectedFailures. (PerfalizerTask.refetch_patch): (PerfalizerTask.expected_failures): Deleted. * Scripts/webkitpy/tool/commands/queues.py: Removes CommitQueue's dependancy on ExpectedFailures, and adds an initializer to allow for mock injection. (CommitQueue.__init__): (CommitQueue.begin_work_queue): (CommitQueue.process_work_item): (CommitQueue._failing_tests_message): * Scripts/webkitpy/tool/commands/queues_unittest.py: Removes dependancy on ExpectedFailures, and instead uses mock injection. (MockCommitQueueTask): (MockCommitQueueTask.results_from_patch_test_run): (MockCommitQueueTask.results_from_test_run_without_patch): (mock_run_webkit_patch): 2014-10-22 Rohit Kumar <kumar.rohit@samsung.com> [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window https://bugs.webkit.org/show_bug.cgi?id=136736 Reviewed by Gyuyoung Kim. * MiniBrowser/efl/main.c: (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window. (window_create): 2014-10-22 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Move GtkInputMethodFilter from Platform to WebKit2 https://bugs.webkit.org/show_bug.cgi?id=137884 Reviewed by Gustavo Noronha Silva. Move InputMethodFilter test from WebCore tests to WebKit2 tests and adapt it to use the new InputMethodFilter WebKit class. Instead of having virtual methods just for testing, it has a testing mode that logs the events. * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp. (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter): (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter): (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter): (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter): (TestWebKitAPI::TEST): (TestWebKitAPI::temporaryGetPreeditStringOverride): (TestWebKitAPI::temporaryResetOverride): (TestWebKitAPI::verifyCanceledComposition): 2014-10-21 Alexey Proskuryakov <ap@apple.com> build.webkit.org/dashboard: Cannot click on green tester bubbles https://bugs.webkit.org/show_bug.cgi?id=137909 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): 2014-10-21 Brent Fulgham <bfulgham@apple.com> [Win] Run DumpRenderTree using native controls, not SafariTheme.dll. https://bugs.webkit.org/show_bug.cgi?id=137932 Reviewed by Simon Fraser. This is the first step in moving over to native Windows rendering for our layout tests. Once this change lands, approximately 300 tests will start failing on Windows. I will rebaseline these changes against our test hardware and update this bug with the commits related to that work. * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that we use native Windows drawing style. 2014-10-21 Dániel Bátyai <dbatyai.u-szeged@partner.samsung.com> Fix FTL Native Inlining for EFL https://bugs.webkit.org/show_bug.cgi?id=137774 Reviewed by Michael Saboff. Added Clang as an optional module to jhbuild. * efl/jhbuild.modules: 2014-10-20 Michael Catanzaro <mcatanzaro@igalia.com> Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL https://bugs.webkit.org/show_bug.cgi?id=137832 Reviewed by Carlos Garcia Campos. Ensure each test sets the TLS errors policy that it really needs. Have each test except testTLSErrorsPolicy stash and restore the original TLS errors policy. Update testTLSErrorsPolicy to account for the new default policy. * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: (testSSL): (testInsecureContent): (testTLSErrorsPolicy): (testTLSErrorsRedirect): (testTLSErrorsHTTPAuth): (testLoadFailedWithTLSErrors): (beforeAll): 2014-10-21 Carlos Garcia Campos <cgarcia@igalia.com> Unreviewed. Unskip inspector server unit tests. They should pass now. * Scripts/run-gtk-tests: (TestRunner): 2014-10-21 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails https://bugs.webkit.org/show_bug.cgi?id=132044 Reviewed by Brian Burg. * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: (openRemoteDebuggingSession): Remove trailing slash when concatenating base inspector URL with the page, because the inspector returns the relative paths with a leading slash. 2014-10-20 Tanay C <tanay.c@samsung.com> [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search https://bugs.webkit.org/show_bug.cgi?id=137023 Reviewed by Gyuyoung Kim. * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search (search_box_show): Modified. (search_box_hide): Modified. (on_search_field_activated): Modified. (on_search_backward_button_clicked): Modified. (on_search_forward_button_clicked): Modified. (on_search_case_option_changed): Added. (on_search_word_start_option_changed): Added. (window_create): Modified. 2014-10-20 Tanay C <tanay.c@samsung.com> [GTK][Minibrowser] Escape key does not hide the search box https://bugs.webkit.org/show_bug.cgi?id=137734 Reviewed by Philippe Normand. * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide (stopPageLoad): Modified. 2014-10-18 Antti Koivisto <antti@apple.com> REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error https://bugs.webkit.org/show_bug.cgi?id=137855 Reviewed by Dan Bernstein. Test and warn if the dumped response mime type differs from the platform response mime type. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didReceiveResponseForResource): (WTR::InjectedBundlePage::platformResponseMimeType): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: (WTR::InjectedBundlePage::platformResponseMimeType): 2014-10-17 Joseph Pecoraro <pecoraro@apple.com> Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore https://bugs.webkit.org/show_bug.cgi?id=137835 Reviewed by Andreas Kling. * Scripts/run-inspector-perf-tests.py: Removed. This script is stale, as PerformanceTests/inspector no longer exists. 2014-10-17 Simon Fraser <simon.fraser@apple.com> Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_baseline_search_path): 2014-10-17 Simon Fraser <simon.fraser@apple.com> [iOS] Simplify test fallback paths for iOS Simulator testing https://bugs.webkit.org/show_bug.cgi?id=137830 Reviewed by Zalan Bujtas. Make the fallback paths be: ios-simulator -> generic ios-simulator-wk2->ios-simulator -> generic so don't include mac in the fallback path. Also remove the version handling for simplicity. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort): (IOSSimulatorPort.default_baseline_search_path): 2014-10-17 Dana Burkart <dburkart@apple.com> Fix typos in the dashboard config file. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): 2014-10-17 Brent Fulgham <bfulgham@apple.com> [Win] Allow WinLauncher to specify Custom User Agent strings https://bugs.webkit.org/show_bug.cgi?id=137828 Reviewed by Dean Jackson. * WinLauncher/Common.cpp: Add support for custom user agent strings. * WinLauncher/WinLauncher.cpp: Add some convenience methods to get and set the user agent strings. * WinLauncher/WinLauncher.h: * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu resources and dialog for setting custom User Agent strings. * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: 2014-10-16 Simon Fraser <simon.fraser@apple.com> [iOS] Turn off font autosizing for iOS WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=137806 Reviewed by Sam Weinig. Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS. Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0 to disable font autosizing. Add platformResetPreferencesToConsistentValues() and implement it in the iOS test controller to set platform-specific prefs. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): (WTR::TestController::platformResetPreferencesToConsistentValues): * WebKitTestRunner/TestController.h: * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::platformResetPreferencesToConsistentValues): * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformResetPreferencesToConsistentValues): 2014-10-16 Dan Bernstein <mitz@apple.com> OSObjectPtr is missing leakRef() https://bugs.webkit.org/show_bug.cgi?id=137798 Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added. 2014-10-16 Lucas Forschler <lforschler@apple.com> Update target platform to remove Leopard, Snow Leopard, Lion. Add Yosemite. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/wkbuild.py: (_should_file_trigger_build): 2014-10-16 David Kilzer <ddkilzer@apple.com> commit-queue: fails to replace OO-PS! with reviewer name <http://webkit.org/b/137795> Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out email addresses to unauthenticated page loads, so we must always authenticate before getting bug data so we get full email addresses. 2014-10-16 David Kilzer <ddkilzer@apple.com> commit-queue: fails to close bugs after successfully landing patches <http://webkit.org/b/137794> Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to tell Mechanize to use the second <textarea> on the page with name="comment". 2014-10-16 Brent Fulgham <bfulgham@apple.com> [Win] Update DRT to match Mac Logic https://bugs.webkit.org/show_bug.cgi?id=137787 Reviewed by Dean Jackson. * DumpRenderTree/win/DumpRenderTree.cpp: (initialize): 0 -> nullptr (runTest): Initialize MSG structure before using. (main): Add CRT debug flags if building DRT with debug malloc on Windows. Also, cleanly shut down COM when exiting. * DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from header and add printf to match Mac. (FrameLoadDelegate::windowScriptObjectAvailable): Ditto. * DumpRenderTree/win/FrameLoadDelegate.h: (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted. (FrameLoadDelegate::windowScriptObjectAvailable): Deleted. * DumpRenderTree/win/ResourceLoadDelegate.cpp: (isLocalhost): Added. (hostIsUsedBySomeTestsToGenerateError): Added. (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use of certain error and redirect host names. * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if anything should be output to the console. This modifies behavior to match the Mac. (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto. (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto. (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto. (UIDelegate::webViewAddMessageToConsole): Ditto. * WinLauncher/PageLoadTestClient.cpp: (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I added last week. 2014-10-16 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r174754. https://bugs.webkit.org/show_bug.cgi?id=137789 Speculative fix for Windows test was ineffective. (Requested by rfong on #webkit). Reverted changeset: "[Windows] Add some more logging to debug Windows test issues." http://trac.webkit.org/changeset/174754 2014-10-15 Gyuyoung Kim <gyuyoung.kim@samsung.com> Unreviewed, add myself to CoordinatedGraphics watchers. * Scripts/webkitpy/common/config/watchlist: 2014-10-15 Roger Fong <roger_fong@apple.com> [Windows] Speculative Windows test fix. * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs. 2014-10-15 Rebecca Hauck <rhauck@adobe.com> import-w3c-test rewrites relative src paths in ref files incorrectly https://bugs.webkit.org/show_bug.cgi?id=137586 This patch fixes a bug in test_converter.py where src paths were getting rewritten as ../../some-path instead of <script src="../../some-path>". It also adds support for rewriting src paths in style elements, which was missing before and it adds tests for this case. Reviewed by Bem Jones-Bey. * Scripts/webkitpy/w3c/test_converter.py: (_W3CTestConverter.convert_attributes_if_needed): * Scripts/webkitpy/w3c/test_converter_unittest.py: (test_convert_attributes_if_needed): (verify_reference_relative_paths): 2014-10-15 Jake Nielsen <jacob_nielsen@apple.com> Add --json flag to test-webkitpy to emit JSON formatted test results to stdout https://bugs.webkit.org/show_bug.cgi?id=137353 Reviewed by Daniel Bates. * Scripts/webkitpy/port/server_process_unittest.py: Adds the read method to MockFile to allow the stdout of test_webkitpy to be redirected without causing erroneous test failures. In particular, webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe and webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup because when redirecting to a file, the _wait_for_data_and_update_buffers_using_select method in server_process.py will find that there is a read file descriptor in its call to select.select, which eventually leads to it calling read() on the MockFile object. (MockFile.read): * Scripts/webkitpy/test/main.py: Adds the _print_results_as_json method and the --json flag which determines whether _print_results_as_json will get called. (Tester._parse_args): (Tester._print_results_as_json): (Tester._print_results_as_json.result_dict_from_tuple): (Tester._run_tests): 2014-10-13 David Farler <dfarler@apple.com> [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr. https://bugs.webkit.org/show_bug.cgi?id=137662 Reviewed by Darin Adler. The layout test harness can close LayoutTestRelay's subprocess stdout and stderr in the case of a timeout or if a run is cancelled and the FIFOs are cleaned up. If LayoutTestRelay finds that no one is listening to its stdout/stderr (broken pipe), then just exit(1), there is nothing to report. * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController didReceiveStdoutData:]): Add @try/@catch for NSFileHandleOperationException. (-[LTRelayController didReceiveStderrData:]): Add @try/@catch for NSFileHandleOperationException. 2014-10-15 Rohit Kumar <kumar.rohit@samsung.com> [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser https://bugs.webkit.org/show_bug.cgi?id=137060 Reviewed by Philippe Normand. Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively. * MiniBrowser/gtk/BrowserWindow.c: (zoomInCallback): (zoomOutCallback): (defaultZoomCallback): Callback for default zoom keyboard support. (browser_window_init): 2014-10-14 Simon Fraser <simon.fraser@apple.com> [Mac] DRT stderr logging after the test completes gets attributed to the next test Reviewed by Alexey Proskuryakov. DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later logging to stderr to get associated with the next test. Fix by logging #EOF to stderr later, after we've completely finished with this test. * DumpRenderTree/mac/DumpRenderTree.mm: (dumpTestResults): (runTest): 2014-10-14 Brent Fulgham <bfulgham@apple.com> [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files. * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore. 2014-10-14 Csaba Osztrogonác <ossy@webkit.org> [cmake] Fix the make build after r174683 https://bugs.webkit.org/show_bug.cgi?id=137703 Reviewed by Martin Robinson. * Scripts/webkitdirs.pm: (buildCMakeGeneratedProject): 2014-10-14 Myles C. Maxfield <mmaxfield@apple.com> Adding myself to the watchlist to CachedFont Unreviewed. * Scripts/webkitpy/common/config/watchlist: 2014-10-14 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> [EFL][GTK] Make it possible to get verbose output with ninja https://bugs.webkit.org/show_bug.cgi?id=137606 Reviewed by Csaba Osztrogonác. * Scripts/webkitdirs.pm: (buildCMakeGeneratedProject): 2014-10-14 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> [EFL] Make it possible to use ninja for EFL build too https://bugs.webkit.org/show_bug.cgi?id=137605 Reviewed by Csaba Osztrogonác. * Scripts/webkitdirs.pm: (generateBuildSystemFromCMakeProject): * efl/install-dependencies: 2014-10-14 Rohit Kumar <kumar.rohit@samsung.com> [GTK] Minibrowser : Add home buton and keyboard support for home page load https://bugs.webkit.org/show_bug.cgi?id=137486 Reviewed by Philippe Normand. * MiniBrowser/gtk/BrowserWindow.c: (loadHomePage): Callback for home page load. (browser_window_init): * MiniBrowser/gtk/BrowserWindow.h: * MiniBrowser/gtk/main.c: (main): 2014-10-14 Manuel Rego Casasnovas <rego@igalia.com> import-w3c-tests doesn't prefix property values https://bugs.webkit.org/show_bug.cgi?id=137600 Reviewed by Bem Jones-Bey. Some property values are prefixed in WebKit. Modified the W3C import script in order to prefix property values and not only properties. The patch re-uses most of the already existent logic to prefix properties. * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values from CSSValueKeywords.in and adapt converter to modify both properties and property values. (convert_for_webkit): (_W3CTestConverter.__init__): (_W3CTestConverter.output): (_W3CTestConverter.read_webkit_prefixed_css_property_list): (_W3CTestConverter): (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values): (_W3CTestConverter.add_webkit_prefix_following_regex): (_W3CTestConverter.convert_reference_relpaths): (_W3CTestConverter.convert_style_data): (_W3CTestConverter.convert_attributes_if_needed): (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted. * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to include checks for property values too. (W3CTestConverterTest.test_read_prefixed_property_list): (verify_no_conversion_happened): (verify_prefixed_properties): (verify_prefixed_property_values): (generate_test_content_properties_and_values): (generate_test_content): * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage prefixed property values and inform about them. (TestImporter.import_tests): (TestImporter.write_import_log): 2014-10-13 Jer Noble <jer.noble@apple.com> MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC https://bugs.webkit.org/show_bug.cgi?id=137533 Reviewed by Andy Estes. Follow up patch; bail out of the test early (without failing) if the platform does not support MSE. * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: (TestWebKitAPI::isMSEEnabledCallback): (TestWebKitAPI::TEST): 2014-10-13 Brent Fulgham <bfulgham@apple.com> [Win] Implement a page load profiling tool https://bugs.webkit.org/show_bug.cgi?id=137673 Reviewed by Dean Jackson. Add a tool to capture and summarize page load statistics. * WinLauncher/Common.cpp: (parseCommandLine): Move from WinMain.cpp so that it can be shared with internal tools. * WinLauncher/PageLoadTestClient.cpp: Added. (PageLoadTestClient::PageLoadTestClient): (PageLoadTestClient::pageLoadStartedAtTime): (PageLoadTestClient::didStartProvisionalLoad): (PageLoadTestClient::didCommitLoad): (PageLoadTestClient::didFirstLayoutForMainFrame): (PageLoadTestClient::didHandleOnLoadEvents): (PageLoadTestClient::didFinishLoad): (PageLoadTestClient::didFailLoad): (PageLoadTestClient::didInitiateResourceLoad): (PageLoadTestClient::didEndResourceLoad): (PageLoadTestClient::pageLoadEndedAtTime): (PageLoadTestClient::endPageLoad): (PageLoadTestClient::clearPageLoadState): (PageLoadTestClient::shouldConsiderPageLoadEnded): (PageLoadTestClient::maybeEndPageLoadSoon): (PageLoadTestClient::setPageURL): (PageLoadTestClient::dumpRunStatistics): * WinLauncher/PrintWebUIDelegate.cpp: (PrintWebUIDelegate::createWebViewWithRequest): Handle nullptr URL properly. * WinLauncher/ResourceLoadDelegate.cpp: Added. (ResourceLoadDelegate::QueryInterface): (ResourceLoadDelegate::AddRef): (ResourceLoadDelegate::Release): (ResourceLoadDelegate::identifierForInitialRequest): (ResourceLoadDelegate::willSendRequest): (ResourceLoadDelegate::didReceiveAuthenticationChallenge): (ResourceLoadDelegate::didCancelAuthenticationChallenge): (ResourceLoadDelegate::didReceiveResponse): (ResourceLoadDelegate::didReceiveContentLength): (ResourceLoadDelegate::didFinishLoadingFromDataSource): (ResourceLoadDelegate::didFailLoadingWithError): (ResourceLoadDelegate::plugInFailedWithError): * WinLauncher/ResourceLoadDelegate.h: Added. (ResourceLoadDelegate::ResourceLoadDelegate): * WinLauncher/WinLauncher.cpp: (WinLauncher::WinLauncher): Accept argument to indicate we want to capture page loading statistics. (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation and set private load delegate state. (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation that sets the view's resource load delegate. (WinLauncher::loadURL): If no URL is passed, load the test document. * WinLauncher/WinLauncher.h: (WinLauncher::pageLoadTestClient): * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files. * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto. * WinLauncher/WinLauncherWebHost.cpp: (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine. (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that it could be used from other source files. (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics. (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto. (WinLauncherWebHost::didFailLoadWithError): Ditto. (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto. (WinLauncherWebHost::didFirstLayoutInFrame): Ditto. (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto. (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto. (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted. * WinLauncher/WinLauncherWebHost.h: * WinLauncher/WinMain.cpp: (wWinMain): Create and use new delegates for gathering page load data. * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build. 2014-10-13 Simon Fraser <simon.fraser@apple.com> Improve the test image diffs page https://bugs.webkit.org/show_bug.cgi?id=137674 Reviewed by Alexey Proskuryakov. Don't treat the input file as a format string, otherwise we have to escape special characters. Just do a couple of replaces. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: (TestResultWriter.write_image_diff_files): 2014-10-13 Carlos Alberto Lopez Perez <clopez@igalia.com> [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21. https://bugs.webkit.org/show_bug.cgi?id=137659 Reviewed by Martin Robinson. * Scripts/webkitpy/port/xvfbdriver.py: (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin 2014-10-13 Alexey Proskuryakov <ap@apple.com> Add more detailed wait time information to EWS metrics https://bugs.webkit.org/show_bug.cgi?id=137649 Reviewed by Daniel Bates. Added average and worst time (we used to only have median), and also a percentage of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes. There is always some wait due to the polling nature of the queues, which is well understood and doesn't need to be measured. What needs to be measured is whether there is enough bot machines to process patches as soon as they are submitted. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: (Analyzer.prototype._analyzeBubblePerformance): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: (MetricsBubbleView.prototype._update): 2014-10-11 Jer Noble <jer.noble@apple.com> MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC https://bugs.webkit.org/show_bug.cgi?id=137533 Reviewed by Darin Adler. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added. * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added. 2014-10-13 Simon Fraser <simon.fraser@apple.com> iOS DRT snapshots are limited to the page visible area https://bugs.webkit.org/show_bug.cgi?id=137650 Reviewed by Daniel Bates. LegacyTileCache drawing was limited to the window's visible area, found by crawling up the layer hierarchy to the root layer. This caused test snapshots to be missing non-composited content outside the iPhone visible area, which hinders testing. Fix by adding a test-only mode where the window visible area is the entire window. * DumpRenderTree/ios/PixelDumpSupportIOS.mm: (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix. * DumpRenderTree/mac/DumpRenderTreeWindow.mm: (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES for the DRT window. 2014-10-12 Simon Fraser <simon.fraser@apple.com> Page not fully rendered in iOS DRT snapshots https://bugs.webkit.org/show_bug.cgi?id=137638 Reviewed by Tim Horton. In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop to ensure that the page has laid out and is rendered by the time we take the snapshot. * DumpRenderTree/mac/DumpRenderTree.mm: (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved. (-[DumpRenderTree _webThreadInvoked]): Moved. (-[DumpRenderTree _waitForWebThreadThenDump]): (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread relies on dispatch_async too, and the inner block won't complete until the outer block has completed. (dumpTestResults): Move the guts of dump() here. (runTest): Whitespace. 2014-10-12 Alexey Proskuryakov <ap@apple.com> Adding svn:ignore so that .pyc files don't show up as new. * Scripts/webkitpy/xcode: Added property svn:ignore. 2014-10-12 Ryuan Choi <ryuan.choi@gmail.com> [EFL] Introduce EWebKit_Extension https://bugs.webkit.org/show_bug.cgi?id=134921 Reviewed by Gyuyoung Kim. * MiniBrowser/efl/main.c: Added x option to test extension path. (window_create): (elm_main): * Scripts/webkitpy/common/config/watchlist: Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI. * Scripts/webkitpy/style/checker.py: Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions. 2014-10-11 Simon Fraser <simon.fraser@apple.com> After r174628 we send the test process a SIGTERM before the SIGKILL. * Scripts/webkitpy/common/system/executive_unittest.py: (ExecutiveTest.serial_test_kill_process): 2014-10-11 KwangHyuk Kim <hyuki.kim@samsung.com> [EFL] Enable WebP support. https://bugs.webkit.org/show_bug.cgi?id=136156 Reviewed by Gyuyoung Kim. Include libwebp-dev package to support WebP for WK2 Efl. * efl/install-dependencies: 2014-10-11 Carlos Garcia Campos <cgarcia@igalia.com> [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource https://bugs.webkit.org/show_bug.cgi?id=137485 Reviewed by Sergio Villar Senin. Update GMainLoopSource tests. Most of the tests are now run twice, first with a GMainLoopSource and then with a GThreadSafeMainLoopSource, since both should have the same behaviour. The threading test uses GThreadSafeMainLoopSource and the delete on destroy test uses GMainLoopSource. The tests themselves haven't changed, since there's no change in behaviour. * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: (TestWebKitAPI::GMainLoopSourceTest::source): (TestWebKitAPI::basicRescheduling): (TestWebKitAPI::TEST): (TestWebKitAPI::reentrantRescheduling): (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): (TestWebKitAPI::basicDestroyCallbacks): (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): 2014-10-10 Dana Burkart <dburkart@apple.com> Fix fat-fingered function name in git-add-reviewer. Unreviewed. * Scripts/git-add-reviewer: (getConfigValue): 2014-10-10 David Farler <dfarler@apple.com> [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals https://bugs.webkit.org/show_bug.cgi?id=137528 Reviewed by Simon Fraser. Catch SIGINT and SIGTERM signals in the LayoutTestRelay and SIGKILL the paired simulator app before exiting cleanly. webkitpy only uses SIGKILL to kill processes which you cannot catch. Send SIGTERM to the process and give it chance to do its thing before sending SIGKILL. Sending a SIGKILL to an already dead PID is safe. * LayoutTestRelay/LayoutTestRelay/LTRelayController.h: * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController finish]): * LayoutTestRelay/LayoutTestRelay/main.m: (receivedSignal): (main): 2014-10-10 David Farler <dfarler@apple.com> [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR https://bugs.webkit.org/show_bug.cgi?id=137527 Reviewed by Simon Fraser. NSFileHandle doesn't notify of EOF in its readability handler. Use a dispatch_source_t and an event handler that is called when reading is possible. In the handler block, do a run-of-the-mill read(2) from standard input and detect EOF in the usual way by checking that zero bytes were read. Once an EOF is received, the FIFOs are disconnected, the simulator app is killed, and the relay exits with status 0. * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): (-[LTRelayController didDisconnect]): (-[LTRelayController didConnect]): (-[LTRelayController launchApp]): Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any confusion with this new dispatch source, called "standardInputDispatchSource". (-[LTRelayController finish]): Added. (-[LTRelayController readFileHandle:]): Deleted. 2014-10-10 KwangHyuk Kim <hyuki.kim@samsung.com> [EFL] Crash on facebook.com https://bugs.webkit.org/show_bug.cgi?id=137562 Reviewed by Chris Dumez. Crash occurs on the facebook.com when the webview is resized after the <select> item is clicked but no item is chosen. This crash is just caused by the reference of invalidated variable. From the EwkView::closePopupMenu(), ewk_menu is just invalidated. Therefore ewk_menu variable is not available anymore when on_popup_menu_hide() on MiniBrowser is called. As a result, just set ewk_menu to NULL in order to prevent crash condition. * MiniBrowser/efl/main.c: (on_popup_menu_hide): 2014-10-10 Alexey Proskuryakov <ap@apple.com> A small wording change for clarity. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: (MetricsBubbleView.prototype._update): 2014-10-10 Alexey Proskuryakov <ap@apple.com> Dashboard metrics page should have EWS statistics https://bugs.webkit.org/show_bug.cgi?id=137626 Reviewed by Ryosuke Niwa. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: (BubbleQueue): Put shortName in the object, so that it's actually useful. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: (BubbleQueueServer): Re-ordered queues to match bubble order. (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler. (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added analysis for bubble queues. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: (buildBubbleQueuesTable): Build the UI. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html: Added JS sources to load. * QueueStatusServer/app.yaml: To update app version. * QueueStatusServer/handlers/processingtimesjson.py: Added. * QueueStatusServer/main.py: Added a handler for processing-times-json. 2014-10-10 Alexey Proskuryakov <ap@apple.com> REGRESSION: Commit queue doesn't process rollouts https://bugs.webkit.org/show_bug.cgi?id=137623 Reviewed by Tim Horton. * QueueStatusServer/app.yaml: * QueueStatusServer/handlers/updateworkitems.py: (UpdateWorkItems._work_items_from_request): 2014-10-10 Simon Fraser <simon.fraser@apple.com> Fix syntax error after r174601. * Scripts/run-javascriptcore-tests: 2014-10-10 Michael Saboff <msaboff@apple.com> Add ability to select tarfile name in run-jsc-stress-tests https://bugs.webkit.org/show_bug.cgi?id=137614 Reviewed by Mark Hahnenberg. Added optional file name argument to the --tarball option. * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first extra test given after the options wont be used for the optional tarball file name. * Scripts/run-jsc-stress-tests: 2014-10-10 Chris Dumez <cdumez@apple.com> Unreviewed, update my information in contributors.json Use my preferred first name and update my expertise areas. * Scripts/webkitpy/common/config/contributors.json: 2014-10-10 Adrien Destugues <pulkomandy@gmail.com> Fix perl scripts to run with env on Linux https://bugs.webkit.org/show_bug.cgi?id=137601 Reviewed by Csaba Osztrogonác. Use of arguments in #! is nonstandard and does not behave the same on different systems. Linux would look for an executable named "perl -w" "use warnings;" does the same things in a more portable way. * Scripts/commit-log-editor: * Scripts/num-cpus: * Scripts/prepare-ChangeLog: * Scripts/run-launcher: * Scripts/svn-create-patch: 2014-10-10 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> [jhbuild] We should be able to disable wiping on configuration change https://bugs.webkit.org/show_bug.cgi?id=137446 Reviewed by Csaba Osztrogonác. The default behaviour isn't changed, wiping on configuration change feature can be disabled with setting JHBUILD_WIPE_ON_CHANGE=0 environment variable or passing --no-wipe-on-change command line option. * Scripts/update-webkit-libs-jhbuild: 2014-10-09 Andy Estes <aestes@apple.com> Teach webkitpy about OS X Yosemite https://bugs.webkit.org/show_bug.cgi?id=137585 Reviewed by Simon Fraser. * Scripts/webkitpy/common/system/platforminfo.py: (PlatformInfo._determine_mac_version): * Scripts/webkitpy/common/system/platforminfo_unittest.py: (TestPlatformInfo.test_os_version): * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectationParser): * Scripts/webkitpy/port/builders.py: * Scripts/webkitpy/port/mac.py: (MacPort): * Scripts/webkitpy/port/mac_unittest.py: (test_versions): (test_baseline_search_path): * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: (TestRebaselineTest.test_baseline_directory): (TestRebaselineExpectations.test_rebaseline_expectations): 2014-10-09 Dana Burkart <dburkart@apple.com> Add Mac OS Yosemite dashboard support. Rubber-stamped by Lucas Forschler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: 2014-10-08 Ryosuke Niwa <rniwa@webkit.org> Add Babak to contributors.json and add historical email addresses for some contributors https://bugs.webkit.org/show_bug.cgi?id=137546 Reviewed by Christophe Dumez. contributors.json is used to analyze historical commit data and change logs. Add back historical email addresses for some contributors and also add Babak (Shafiei). * Scripts/webkitpy/common/config/contributors.json: 2014-10-09 Lucas Forschler <lforschler@apple.com> Add Mac OS Yosemite webkit build infrastructure. This patch adds 15 bots to our build.webkit.org configuration. We are matching the current Mavericks machines 1:1. This patch includes some minor spacing changes to the buildslaves section to make everything similar. Reviewed by Matt Hanson. * BuildSlaveSupport/build.webkit.org-config/config.json: 2014-10-09 Dana Burkart <dburkart@apple.com> Don't use backticks when running commands, as we run into sh-related interpolation issues. Also, fix our usage of system() to properly retrieve the status code. https://bugs.webkit.org/show_bug.cgi?id=137541 Reviewed by Darin Adler. * Scripts/git-add-reviewer: (interactive): (nonInteractive): (requireCleanWorkTree): (cherryPick): (commit): (addReviewerToFile): (head): (isAncestor): (toCommit): (changeLogsForCommit): (resetToCommit): (getConfigValue): (runCommandWithOutput): 2014-10-09 Tim Horton <timothy_horton@apple.com> Add a WebKit1 preference for selection services https://bugs.webkit.org/show_bug.cgi?id=137498 <rdar://problem/18572699> Reviewed by Simon Fraser. * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController awakeFromNib]): Turn on image and selection services in the Legacy WebKit MiniBrowser. 2014-10-09 Adrien Destugues <pulkomandy@gmail.com> Get the patch scripts running on Haiku https://bugs.webkit.org/show_bug.cgi?id=137559 Reviewed by Benjamin Poulain. Use /usr/bin/env instead of hardcoding path to perl. Declare haiku platform in platforminfo.py to avoid check-webkit-style failure. * Scripts/commit-log-editor: * Scripts/num-cpus: * Scripts/prepare-ChangeLog: * Scripts/run-launcher: * Scripts/svn-create-patch: * Scripts/webkitpy/common/system/platforminfo.py: (PlatformInfo._determine_os_name): 2014-10-08 Jake Nielsen <jacob_nielsen@apple.com> StyleQueue should throw a PatchIsNotValid exception to achieve consistency with CommitQueue and EWS https://bugs.webkit.org/show_bug.cgi?id=137500 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/tool/bot/stylequeuetask.py: Adds a call to validate() in run(). (StyleQueueTask.run): * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Adds a return False in the patch is not valid exception statement. (AbstractEarlyWarningSystem.review_patch): * Scripts/webkitpy/tool/commands/queues.py: Adds a return False in the patch is not valid exception statement in commit queue, and adds an except statement to catch PatchIsNotValid exceptions in style queue. (CommitQueue.process_work_item): (StyleQueue.review_patch): 2014-10-08 Carlos Garcia Campos <cgarcia@igalia.com> Race condition with WebKitWebView:is-loading after starting page load https://bugs.webkit.org/show_bug.cgi?id=136692 Reviewed by Gustavo Noronha Silva. * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp: (loadChangedCallback): Only check is-loading is false when load has finished if the load didn't fail due to a cancellation. (loadFailedCallback): Only check is-loading is false if the load didn't fail due to a cancellation. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::loadURI): Check is-loading is true and active URI is the requested one rigth after requesting the load. (WebViewTest::loadHtml): Ditto. (WebViewTest::loadPlainText): Ditto. (WebViewTest::loadBytes): Ditto. (WebViewTest::loadRequest): Ditto. (WebViewTest::loadAlternateHTML): Ditto. (WebViewTest::goBack): Ditto. (WebViewTest::goForward): Ditto. (WebViewTest::goToBackForwardListItem): Ditto. 2014-10-08 Brent Fulgham <bfulgham@apple.com> [Win] Resolve various static analyzer warnings in Tools. https://bugs.webkit.org/show_bug.cgi?id=137534 Reviewed by Dean Jackson. * DumpRenderTree/cg/ImageDiffCG.cpp: (main): User proper printf specifiers. * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::childrenCount): Handle possibility that gcc_accChildCount returns with an error. (accessibilityState): Ditto for gcc_accState. * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper check for return value from 'isHTML'. HRESULT is not a boolean and cannot be treated as such. * DumpRenderTree/win/DumpRenderTree.cpp: (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused by comparing an unsigned value as being greater-than zero. * DumpRenderTree/win/EditingDelegate.cpp: (dump): Pass proper character pointer type to printf. (EditingDelegate::shouldBeginEditingInDOMRange): Ditto. (EditingDelegate::shouldEndEditingInDOMRange): Ditto. (EditingDelegate::shouldInsertNode): Ditto. (EditingDelegate::shouldInsertText): Ditto. (EditingDelegate::shouldDeleteDOMRange): Ditto. (EditingDelegate::shouldChangeSelectedDOMRange): Ditto. (EditingDelegate::shouldApplyStyle): Ditto. * DumpRenderTree/win/EventSender.cpp: (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc. * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match system headers. * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure from CreateDIBSection. * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf. * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under older versions of MSVC we no longer support. * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API for 64-bit builds. * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen. * TestWebKitAPI/TestsController.h: Ditto. * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName. * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid performing bitwise | before the comparison is done. 2014-10-08 Ada Chan <adachan@apple.com> Add a test for WKPageIsPlayingAudio(). https://bugs.webkit.org/show_bug.cgi?id=137048 Reviewed by Darin Adler. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project. * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added. (TestWebKitAPI::nullJavaScriptCallback): (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::isPlayingAudioDidChangeCallback): (TestWebKitAPI::setUpClients): (TestWebKitAPI::TEST): This test loads a page with a video in it. When the page is loaded, we first check that WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video. When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio() now returns true for the page. * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added. * TestWebKitAPI/Tests/WebKit2/test.mp4: Added. This is a video copied from LayoutTests/media/content. 2014-10-08 Csaba Osztrogonác <ossy@webkit.org> [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller https://bugs.webkit.org/show_bug.cgi?id=137516 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/thirdparty/__init__.py: (AutoinstallImportHook._install_irc): 2014-10-08 Carlos Alberto Lopez Perez <clopez@igalia.com> [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives. https://bugs.webkit.org/show_bug.cgi?id=137520 Reviewed by Philippe Normand. Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text> For other distributions, we are already installing libjpeg-turbo. So, do the same for Debian and derivatives. * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg. 2014-10-08 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> [webkitpy] Add back the workaround to replace ZipFile.extractall() https://bugs.webkit.org/show_bug.cgi?id=137519 Reviewed by Csaba Osztrogonác. It was removed by <http://trac.webkit.org/changeset/174266>, because the comment stated it is a workaround for buggy python 2.6.1 which shipped on Snow Leopard. But it turned out the bug is still valid with python 2.7 shipped on the latest Ubuntu (12.04 and 14.04) and OS X 10.9. * Scripts/webkitpy/common/system/autoinstall.py: (AutoInstaller): (AutoInstaller._extract_all): (AutoInstaller._unzip): 2014-10-08 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r174335. https://bugs.webkit.org/show_bug.cgi?id=137515 It broke EFL layout test totally (Requested by gyuyoung on #webkit). Reverted changeset: "[EFL] Introduce EWebKit_Extension" https://bugs.webkit.org/show_bug.cgi?id=134921 http://trac.webkit.org/changeset/174335 2014-10-08 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Make forwarding headers generation depend on source code https://bugs.webkit.org/show_bug.cgi?id=137394 Reviewed by Philippe Normand. * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule. * TestWebKitAPI/PlatformGTK.cmake: Only run generate-forwarding-headers.pl when source code changes. * WebKitTestRunner/PlatformGTK.cmake: Ditto. 2014-10-07 Tanay C <tanay.c@samsung.com> Remove build warnings in Hashmap API tests https://bugs.webkit.org/show_bug.cgi?id=137484 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/HashMap.cpp: (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 2014-10-07 Jake Nielsen <jacob_nielsen@apple.com> Commit queue doesn't drop obsolete patches sometimes https://bugs.webkit.org/show_bug.cgi?id=137460 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Adds another test patch for use in queues_unittest.py. courtesy of Csaba Osztrogonác <ossy@webkit.org> (MockBugzilla): * Scripts/webkitpy/tool/bot/commitqueuetask.py: Raises a PatchIsNotValid exception in the case of validate() returning false. (CommitQueueTask.run): * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Raises a PatchIsNotValid exception in the case of validate() returning false. (EarlyWarningSystemTask.run): * Scripts/webkitpy/tool/bot/patchanalysistask.py: Defines PatchIsNotValid exception. (PatchIsNotValid): (PatchIsNotValid.__init__): * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Remove call to validate() and instead catches the PatchIsNotValid exception. (AbstractEarlyWarningSystem.review_patch): * Scripts/webkitpy/tool/commands/queues.py: Adds logic to catch the PatchIsNotValid exception. (CommitQueue.process_work_item): * Scripts/webkitpy/tool/commands/queues_unittest.py: Adds the test_non_valid_patch test to ensure that invalid patches are handled properly, and don't just result in indefinite spinning. courtesy of Csaba Osztrogonác <ossy@webkit.org> (test_non_valid_patch): 2014-10-07 Daniel Bates <dabates@apple.com> [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds https://bugs.webkit.org/show_bug.cgi?id=137499 Reviewed by Simon Fraser. Fixes an issue where the TestExpectation file for the iOS Simulator platform was only honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64- bit simulator builds of iOS WebKit. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort._generate_all_test_configurations): 2014-10-07 Youenn Fablet <youenn.fablet@crf.canon.fr> [GTK] jhbuild modules should build xserver with the --without-dtrace option. https://bugs.webkit.org/show_bug.cgi?id=137482 Reviewed by Martin Robinson. * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config. 2014-10-07 Carlos Garcia Campos <cgarcia@igalia.com> [SOUP] TLS errors should take precedence over HTTP authentication https://bugs.webkit.org/show_bug.cgi?id=137300 Reviewed by Sergio Villar Senin. Add a test case to check that authenticate signal is not emitted in case of TLS errors, and the load fails instead. * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: (webViewAuthenticationCallback): (testTLSErrorsHTTPAuth): (httpsServerCallback): (beforeAll): 2014-10-06 Ryosuke Niwa <rniwa@webkit.org> Make webkit-patch find-users useful https://bugs.webkit.org/show_bug.cgi?id=137475 Reviewed by Alexey Proskuryakov. Make find-users use the CommitterList instead of accessing Bugzilla. This essentially exposes the same functionality as webkitbot's whois command. * Scripts/webkitpy/tool/commands/findusers.py: (FindUsers.execute): 2014-10-06 Chris Fleizach <cfleizach@apple.com> AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:] https://bugs.webkit.org/show_bug.cgi?id=137289 Unreviewed build fix. * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::getChildrenWithRange): 2014-10-06 Alexey Proskuryakov <ap@apple.com> build.webkit.org/dashboard: Add commit queue https://bugs.webkit.org/show_bug.cgi?id=137462 Reviewed by Tim Horton. Generalizes EWS into "bubble queue", which also includes commit queue and style queue. Style queue is still invisible, as it doesn't have an associated platform, and also we never have problems with it anyway, so it's not worth watching. The UI now allows for adding more bots to the Other column (such as leaks bot). To make that actually happen, we'll need to refactor QueueView, allowing for multiple sources of data in a cell. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js. (BubbleQueue): (BubbleQueue.prototype.get statusPageURL): (BubbleQueue.prototype.update): (BubbleQueue.prototype.loadDetailedStatus): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js. (BubbleQueueServer): (BubbleQueueServer.prototype.jsonQueueLengthURL): (BubbleQueueServer.prototype.jsonQueueStatusURL): (BubbleQueueServer.prototype.queueStatusURL): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js. (BubbleQueueView): (BubbleQueueView.prototype.update.appendQueue): (BubbleQueueView.prototype.update): (BubbleQueueView.prototype._addQueueHeadingToPopover): (BubbleQueueView.prototype._popoverContentForBubbleQueue): (BubbleQueueView.prototype._presentPopoverForBubbleQueue): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css: (.bubble-server-popover .popover-queue-heading .queue-charts-link): (.bubble-server-popover .latest-status-no-link): (.bubble-server-popover .bot-status-description): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: (buildAggregateTable): (buildQueuesTable): Removed dysfunctional support for EWS for now. It will be different. 2014-10-06 Alexey Proskuryakov <ap@apple.com> One more case of incorrect comparison in recordpatchevent.py https://bugs.webkit.org/show_bug.cgi?id=137459 Reviewed by Tim Horton. * QueueStatusServer/app.yaml: * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.started): 2014-10-06 Alexey Proskuryakov <ap@apple.com> webkit-queues PatchLog is incorrect for patches that took less than a second https://bugs.webkit.org/show_bug.cgi?id=137453 Reviewed by Tim Horton. * QueueStatusServer/app.yaml: Updated app version. * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped): Don't bail out for patches that took 0 seconds to process (as frequently happens when a patch is obsolete). 2014-10-06 Csaba Osztrogonác <ossy@webkit.org> EWS bubble hover shows wrong timestamps https://bugs.webkit.org/show_bug.cgi?id=137252 Reviewed by Alexey Proskuryakov. Add "Z" suffix to timestamps to make sure if it is handled as UTC time. * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON.get): * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._iso_time): 2014-10-06 Mario Sanchez Prada <mario@webkit.org> Unreviewed, updated list of email addresses in contributors.json * Scripts/webkitpy/common/config/contributors.json: Added my former email address in Igalia, for the sake of completeness. 2014-10-06 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com> Unreviewed, moved myself to the list of committers. * Scripts/webkitpy/common/config/contributors.json: 2014-10-05 Ryuan Choi <ryuan.choi@gmail.com> [EFL] Introduce EWebKit_Extension https://bugs.webkit.org/show_bug.cgi?id=134921 Reviewed by Gyuyoung Kim. * MiniBrowser/efl/main.c: Added x option to test extension path. (window_create): (elm_main): * Scripts/webkitpy/common/config/watchlist: Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI. * Scripts/webkitpy/style/checker.py: Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions. 2014-10-04 Csaba Osztrogonác <ossy@webkit.org> [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild https://bugs.webkit.org/show_bug.cgi?id=137390 Reviewed by Carlos Garcia Campos. * Scripts/update-webkit-libs-jhbuild: 2014-10-04 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally https://bugs.webkit.org/show_bug.cgi?id=137391 Reviewed by Martin Robinson. Add a custom command to only re-generate webkit2gtk-tests-resources.gresource when any of its dependencies changes. * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: 2014-10-04 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues https://bugs.webkit.org/show_bug.cgi?id=135502 Reviewed by Martin Robinson. When writing to stdout/stderr fails due to a UnicodeDecodeError exception, try again without encoding the output. * gtk/gtkdoc.py: (GTKDoc._run_command): 2014-10-03 Alexey Proskuryakov <ap@apple.com> Bugzilla status bubble displays an exception showing attachment 175738 https://bugs.webkit.org/show_bug.cgi?id=137410 Reviewed by Tim Horton. * QueueStatusServer/app.yaml: Update version. * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble): Don't fail even if expected status message is missing. * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define the field in the same way it's defined in QueueStatus table. 2014-10-03 Alexey Proskuryakov <ap@apple.com> Record latest message in PatchLog for quick access https://bugs.webkit.org/show_bug.cgi?id=137405 Fixing a typo. * QueueStatusServer/app.yaml: * QueueStatusServer/handlers/releasepatch.py: 2014-10-03 Alexey Proskuryakov <ap@apple.com> Record latest message in PatchLog for quick access https://bugs.webkit.org/show_bug.cgi?id=137405 Reviewed by Ryosuke Niwa. It's no SQL... * QueueStatusServer/handlers/releasepatch.py: * QueueStatusServer/handlers/updatestatus.py: * QueueStatusServer/loggers/recordpatchevent.py: * QueueStatusServer/model/patchlog.py: 2014-10-02 David Farler <dfarler@apple.com> -asan-blacklist option also renamed to generic -fsanitize-blacklist https://bugs.webkit.org/show_bug.cgi?id=137377 Reviewed by Daniel Bates. * asan/asan.xcconfig: -asan-blacklist -> -fsanitize-blacklist http://llvm.org/viewvc/llvm-project?view=revision&revision=212505 2014-10-03 Roger Fong <roger_fong@apple.com> [Windows] Include batch size argument to layout tests on Windows. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunWebKitTests.start): This is a speculative fix for the the inconsistent crashes we are seeing on Windows. These crashes seem to happen on random tests though generally in a spread out fashion. It seems possible that the DRT instance is being clobbered somehow after running too many tests in a row so we will try to mitigate this by just forcing DRT to restart periodically. 2014-10-03 Roger Fong <roger_fong@apple.com> [Windows] Settle for 2 chid processes running NRWT on Windows. * Scripts/webkitpy/port/win.py: (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2. 2014-10-03 Akos Kiss <akiss@inf.u-szeged.hu> [GTK] Bump up and patch dependencies to allow building for aarch64 https://bugs.webkit.org/show_bug.cgi?id=137147 Reviewed by Martin Robinson. The currently used versions of pixman, libffi, librsvg, glib, glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure and/or build for aarch64, so they are bumped up and patched where necessary. Wherever possible, the same versions and patches were used as for the EFL port bump-up (https://bugs.webkit.org/show_bug.cgi?id=135885). After the bump-up, a hitherto hidden bug in gst-plugins-good caused a regression by crashing http/tests/media/video-redirect.html . A patch already in upstream fixes that bug. This change does not touch xserver, which also needs bumping up, but will be dealt with later. * gtk/jhbuild.modules: Specified versions and patches necessary to correctly build for aarch64. * gtk/patches/gst-events-arent-gstobjects.patch: Added. Patches gst-plugins-good to fix a bug in .mov file demuxing. * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Added. Patches gst-plugins-base to configure correctly for aarch64. * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Added. Bumps up config.guess and config.sub in librsvg to recognize aarch64. * gtk/patches/libxml2-2.9.0-dtd.patch: Removed. Not necessary for libxml2 v2.9.1 anymore. 2014-09-28 Sam Weinig <sam@webkit.org> Remove RefPtrHashMap https://bugs.webkit.org/show_bug.cgi?id=137200 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/HashMap.cpp: (TestWebKitAPI::TEST): Add tests for using a HashMap with RefPtr keys, focusing on ensuring that a minimum of refcount churn occurs. 2014-10-03 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> Remove workarounds for versions of Python before 2.7 https://bugs.webkit.org/show_bug.cgi?id=137338 Reviewed by Csaba Osztrogonác. * Scripts/webkitpy/common/system/autoinstall.py: (AutoInstaller._extract_targz): (AutoInstaller._unzip): (AutoInstaller): Deleted. (AutoInstaller._extract_all): Deleted. * Scripts/webkitpy/common/webkitunittest.py: (TestCase.setUp): Deleted. * Scripts/webkitpy/layout_tests/models/test_configuration.py: (TestConfigurationConverter.collapse_macros): (TestConfigurationConverter.to_specifiers_list.try_collapsing): (TestConfigurationConverter.to_specifiers_list.try_abbreviating): (TestConfigurationConverter): (TestConfigurationConverter.combinations): Deleted. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: * Scripts/webkitpy/port/base.py: 2014-10-03 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r174264. https://bugs.webkit.org/show_bug.cgi?id=137392 It broke run-webkit-tests (Requested by ebalazsfalvi on #webkit). Reverted changeset: "Remove workarounds for versions of Python before 2.7" https://bugs.webkit.org/show_bug.cgi?id=137338 http://trac.webkit.org/changeset/174264 2014-10-03 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> Remove workarounds for versions of Python before 2.7 https://bugs.webkit.org/show_bug.cgi?id=137338 Reviewed by Csaba Osztrogonác. * Scripts/webkitpy/common/system/autoinstall.py: (AutoInstaller._extract_targz): (AutoInstaller._unzip): (AutoInstaller): Deleted. (AutoInstaller._extract_all): Deleted. * Scripts/webkitpy/common/webkitunittest.py: (TestCase.setUp): Deleted. * Scripts/webkitpy/layout_tests/models/test_configuration.py: (TestConfigurationConverter.collapse_macros): (TestConfigurationConverter.to_specifiers_list.try_collapsing): (TestConfigurationConverter.to_specifiers_list.try_abbreviating): (TestConfigurationConverter): (TestConfigurationConverter.combinations): Deleted. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: * Scripts/webkitpy/port/base.py: * Scripts/webkitpy/port/driver.py: (ContentBlock.__init__): * Scripts/webkitpy/port/server_process.py: (ServerProcess._reset): 2014-10-03 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> Remove autoinstaller workaround for python 2.6 https://bugs.webkit.org/show_bug.cgi?id=137343 Reviewed by Daniel Bates. Reverting <http://trac.webkit.org/changeset/124928>, neither Python 2.6, nor Snow Leopard is supported anymore, so the workaround is not needed anymore. * Scripts/webkitpy/common/system/autoinstall.py: (AutoInstaller.install): * Scripts/webkitpy/test/main.py: (Tester._run_tests): * Scripts/webkitpy/thirdparty/__init__.py: (AutoinstallImportHook._install_mechanize): (AutoinstallImportHook._install_pep8): (AutoinstallImportHook._install_pylint): (AutoinstallImportHook._install_buildbot): (AutoinstallImportHook._install_coverage): (AutoinstallImportHook._install_eliza): (AutoinstallImportHook._install_irc): (AutoinstallImportHook._install): (autoinstall_everything): 2014-10-02 Daniel Bates <dabates@apple.com> Use version number 101000 instead of 10100 for OS X Yosemite https://bugs.webkit.org/show_bug.cgi?id=137372 Reviewed by Mark Rowe. The version number for OS X Yosemite is 101000. * DumpRenderTree/mac/TextInputController.m: 2014-10-02 Alexey Proskuryakov <ap@apple.com> update-work-items should never delete items https://bugs.webkit.org/show_bug.cgi?id=137366 Reviewed by Ryosuke Niwa. As we don't just replace the whole list any more, indicate which items are high priority, and which are not. Hight priority ones will be prepended to the queue, others will be appended. This creates a bit of unfairness in that high priority item queue becomes a LIFO. But hopefully we will never have many rollouts competing like that. * QueueStatusServer/app.yaml: Update version. * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high priority and regular items separately. Removed some error handling that used to end up in returning status 500 - an uncaught exception does that automatically. * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code. * QueueStatusServer/model/workitems.py: Added a way to add high priority items. * QueueStatusServer/templates/updateworkitems.html: Added a field for high priority items. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log line that complicated testing. * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately. * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular priority items into separate lists. * Scripts/webkitpy/common/net/statusserver_mock.py: * Scripts/webkitpy/tool/bot/feeders_unittest.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated tests. 2014-10-02 Brendan Long <b.long@cablelabs.com> Annoying build warnings in WTFString API tests https://bugs.webkit.org/show_bug.cgi?id=137360 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/WTFString.cpp: (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok). 2014-10-02 Roger Fong <roger_fong@apple.com> [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again. * Scripts/webkitpy/port/win.py: (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now. 2014-10-02 David Farler <dfarler@apple.com> Move ASan arguments from LLVM (-mllvm) to the frontend https://bugs.webkit.org/show_bug.cgi?id=137365 Reviewed by David Kilzer. * asan/asan.xcconfig: Remove the -mllvm prefix to the asan-blacklist argument, moving it to the clang frontend. http://llvm.org/viewvc/llvm-project?view=revision&revision=212505 2014-10-02 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r174120. https://bugs.webkit.org/show_bug.cgi?id=137350 While number of failures is reasonable with 2 processes, test results seem to be inconsistent between runs (Requested by rfong on #webkit). Reverted changeset: "[Windows] Back to 2 child processes for NRWT on Windows." http://trac.webkit.org/changeset/174120 2014-10-02 Jeff Miller <jeffm@apple.com> DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite https://bugs.webkit.org/show_bug.cgi?id=137347 Reviewed by Dan Bernstein. * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Use WebKitSystemInterfaceYosemite on OS X 10.10. * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto. 2014-10-02 Carlos Alberto Lopez Perez <clopez@igalia.com> [GTK] [JHBuild] Switch sourceware.org mirror to http. Unreviewed. The ftp access is recently failing to work as expected, and the bots fail to download the file. The same mirror is available via http and seems to work better. * gtk/jhbuild.modules: 2014-10-01 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r174185. https://bugs.webkit.org/show_bug.cgi?id=137334 Patch that adds logging causes webkitpy failures (Requested by rfong on #webkit). Reverted changeset: "commitqueuetasks_unittest references a non-existent member variable" https://bugs.webkit.org/show_bug.cgi?id=137303 http://trac.webkit.org/changeset/174185 2014-10-01 Jake Nielsen <jacob_nielsen@apple.com> EWS and Commit Queue should know better than to spew 500 failed results in the case of extremely red patches. https://bugs.webkit.org/show_bug.cgi?id=137324 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Adds a check for did_exceed_test_failure_limit. (AbstractEarlyWarningSystem._failing_tests_message): * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Alters the task mock to respond properly to results_from_patch_test_run(patch) (AbstractEarlyWarningSystemTest.test_failing_tests_message): * Scripts/webkitpy/tool/commands/queues.py: Adds a check for did_exceed_test_failure_limit. (CommitQueue._failing_tests_message): 2014-10-01 Daniel Bates <dabates@apple.com> Unreviewed, rolling out r174192. Revert the unit test fix in r174192 since we reverted r174187 in r174194 due to correctness issues. See <http://webkit.org/b/137329> for more details. Reverted changeset: "Test fix after r174187" http://trac.webkit.org/changeset/174192 2014-10-01 Mark Rowe <mrowe@apple.com> <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users Reviewed by Dan Bernstein. * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2 for the LLVM components when on Yosemite. 2014-10-01 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r174187. https://bugs.webkit.org/show_bug.cgi?id=137329 webkitpy failures, and thorton says the patch is wrong (Requested by dethbakin on #webkit). Reverted changeset: "[Windows] Increase layout test timeout for Windows following r174162." http://trac.webkit.org/changeset/174187 2014-10-01 Brent Fulgham <bfulgham@apple.com> Test fix after r174187 * Scripts/webkitpy/port/win_unittest.py: (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests. 2014-10-01 Roger Fong <roger_fong@apple.com> [Windows] Increase layout test timeout for Windows following r174162. * Scripts/webkitpy/port/win.py: (WinPort.default_timeout_ms): 2014-10-01 Jake Nielsen <jacob_nielsen@apple.com> commitqueuetasks_unittest references a non-existent member variable when mock-reporting flaky tests. https://bugs.webkit.org/show_bug.cgi?id=137303 Reviewed by Daniel Bates. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: (MockCommitQueue.report_flaky_tests): Makes the appropriate name change. (test_simple_flaky_test_failure): Adds a unit test to make sure that the code is excercised. 2014-10-01 Jake Nielsen <jacob_nielsen@apple.com> EWS is inconclusively spinning forever on a patch that breaks 500+ tests https://bugs.webkit.org/show_bug.cgi?id=137223 Reviewed by Tim Horton. * Scripts/webkitpy/tool/bot/patchanalysistask.py: Checks to see whether the tests have exceeded the failure limit, and only spins off another test if they have not exceeded the limit. (PatchAnalysisTask._test_patch): 2014-10-01 Brian J. Burg <burg@cs.washington.edu> Unreviewed, add Katie Madonna as a contributor. * Scripts/webkitpy/common/config/contributors.json: 2014-10-01 Jake Nielsen <jacob_nielsen@apple.com> commitqueuetasks_unittest does not construct FailingTestCommitQueue objects properly in its test cases. https://bugs.webkit.org/show_bug.cgi?id=137281 Reviewed by Daniel Bates. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: (FailingTestCommitQueue.test_results): Adds an assert to make FailingTestCommitQueue harder to mis-use. (test_double_flaky_test_failure): Nests the intended test failure strings into one-length lists. (test_red_test_failure): Nests the intended test failure strings into one-length lists. 2014-10-01 Alexey Proskuryakov <ap@apple.com> REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian https://bugs.webkit.org/show_bug.cgi?id=136987 Reviewed by Daniel Bates. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): Specify the default encoding for all WebKit developers to get consistent results. 2014-10-01 Alexey Proskuryakov <ap@apple.com> EWS is too eager to say that a patch does not apply to trunk of repository https://bugs.webkit.org/show_bug.cgi?id=137290 Reviewed by Ryosuke Niwa. * QueueStatusServer/app.yaml: Updated app version. * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble): (StatusBubble._build_bubbles_for_attachment): Rewrote to make more sense. 2014-09-30 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> Remove thirdparty/unittest2 from webkitpy https://bugs.webkit.org/show_bug.cgi?id=137251 Reviewed by Brent Fulgham. Additionally ordered imports in related webkitpy files and removed unnecessary shebangs from unittest files. * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py: * Scripts/webkitpy/common/checkout/changelog_unittest.py: * Scripts/webkitpy/common/checkout/checkout_unittest.py: * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: * Scripts/webkitpy/common/checkout/diff_parser_unittest.py: * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: * Scripts/webkitpy/common/config/committers_unittest.py: * Scripts/webkitpy/common/config/committervalidator_unittest.py: * Scripts/webkitpy/common/config/contributionareas_unittest.py: * Scripts/webkitpy/common/config/ports_unittest.py: * Scripts/webkitpy/common/config/urls_unittest.py: * Scripts/webkitpy/common/editdistance_unittest.py: * Scripts/webkitpy/common/find_files_unittest.py: * Scripts/webkitpy/common/lru_cache_unittest.py: * Scripts/webkitpy/common/memoized_unittest.py: * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: * Scripts/webkitpy/common/net/credentials_unittest.py: * Scripts/webkitpy/common/net/failuremap_unittest.py: * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py: * Scripts/webkitpy/common/net/layouttestresults_unittest.py: * Scripts/webkitpy/common/net/networktransaction_unittest.py: * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py: * Scripts/webkitpy/common/net/statusserver_unittest.py: * Scripts/webkitpy/common/net/unittestresults_unittest.py: * Scripts/webkitpy/common/newstringio_unittest.py: * Scripts/webkitpy/common/prettypatch_unittest.py: * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: * Scripts/webkitpy/common/system/crashlogs_unittest.py: * Scripts/webkitpy/common/system/environment_unittest.py: * Scripts/webkitpy/common/system/executive.py: Ordered imports. * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports. * Scripts/webkitpy/common/system/executive_unittest.py: * Scripts/webkitpy/common/system/file_lock_integrationtest.py: * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: * Scripts/webkitpy/common/system/filesystem_unittest.py: * Scripts/webkitpy/common/system/logtesting.py: * Scripts/webkitpy/common/system/logutils_unittest.py: * Scripts/webkitpy/common/system/outputcapture.py: * Scripts/webkitpy/common/system/outputcapture_unittest.py: * Scripts/webkitpy/common/system/outputtee_unittest.py: * Scripts/webkitpy/common/system/path_unittest.py: * Scripts/webkitpy/common/system/platforminfo_unittest.py: * Scripts/webkitpy/common/system/profiler_unittest.py: * Scripts/webkitpy/common/system/stack_utils_unittest.py: * Scripts/webkitpy/common/system/user_unittest.py: * Scripts/webkitpy/common/system/workspace_unittest.py: * Scripts/webkitpy/common/system/zipfileset_unittest.py: * Scripts/webkitpy/common/thread/messagepump_unittest.py: * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py: * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: * Scripts/webkitpy/common/webkitunittest.py: * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py: * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py: * Scripts/webkitpy/layout_tests/models/test_results_unittest.py: * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: * Scripts/webkitpy/layout_test