2015-04-12 Gyuyoung Kim [EFL] Enable Media Source https://bugs.webkit.org/show_bug.cgi?id=143635 Reviewed by Csaba Osztrogonác. * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port. 2015-04-12 Alexey Proskuryakov build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded https://bugs.webkit.org/show_bug.cgi?id=143646 Reviewed by David Kilzer. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): 2015-04-11 Alexey Proskuryakov Use en_US spell checker for tests on Mac instead of Multilingual https://bugs.webkit.org/show_bug.cgi?id=143641 Reviewed by Dan Bernstein. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): While at it, override NSUserDictionaryReplacementItems, so that user replacements cannot affect tests. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize): Made this more like WebKit1 version. 2015-04-10 Tim Horton Replace setFixedLayoutSizeEnabled: with an enum of layout modes https://bugs.webkit.org/show_bug.cgi?id=143576 Reviewed by Simon Fraser. * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: (TEST): Adopt. 2015-04-09 Gyuyoung Kim Update my email address and expertise. https://bugs.webkit.org/show_bug.cgi?id=143586 Unreviewed, just update my info. * Scripts/webkitpy/common/config/contributors.json: 2015-04-09 Joseph Pecoraro Flakiness Dashboard not loading insecure content if loaded with https URL https://bugs.webkit.org/show_bug.cgi?id=143570 Reviewed by Alexey Proskuryakov. * TestResultServer/app.yaml: * TestResultServer/static-dashboards/loader.js: Switch to https scheme. 2015-04-09 Csaba Osztrogonác [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times https://bugs.webkit.org/show_bug.cgi?id=142907 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/PlatformEfl.cmake: * TestWebKitAPI/PlatformGTK.cmake: * WebKitTestRunner/PlatformEfl.cmake: * WebKitTestRunner/PlatformGTK.cmake: 2015-04-08 Brent Fulgham [Mac] Unreviewed test fix after r182584 https://bugs.webkit.org/show_bug.cgi?id=143452 Put both of these tests back to their original state now that the underlying problem is fixed. * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: (TestWebKitAPI::TEST): 2015-04-08 Filip Pizlo run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice https://bugs.webkit.org/show_bug.cgi?id=143553 Reviewed by Ryosuke Niwa. Remove the spurious printVMs left over from an earlier change. * Scripts/run-jsc-benchmarks: 2015-04-08 Brent Fulgham [Mac] Unreviewed test fix after r182581 The behavior of control-left-click is controlled by a system preference. Our test bots have this turned off. * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: (TestWebKitAPI::TEST): 2015-04-08 Brent Fulgham [Mac] WebKit is not honoring OS preferences for secondary click behaviors https://bugs.webkit.org/show_bug.cgi?id=143452 Reviewed by Tim Horton. Add a new API test to confirm that Cocoa mouse button press events are properly tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.) The WK2 test dispatches mouse down events to a PlatformWebView, and checks with some registered event handlers that the expected button press and context menu events are received. The WK1 unit test creates an NSEvent with the desired button press state, and then uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event. We check the resulting PlatformMouseEvent for proper state. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files. * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added. (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test. * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added. * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added. (TestWebKitAPI::canCallMenuTypeForEvent): Helper function. (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test. * TestWebKitAPI/mac/PlatformWebViewMac.mm: (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing mouse down events. * TestWebKitAPI/mac/PlatformWebViewMac.h: 2015-04-08 Michael Catanzaro [GTK] Add pango to jhbuild-optional.modules https://bugs.webkit.org/show_bug.cgi?id=143537 Reviewed by Martin Robinson. * gtk/jhbuild-optional.modules: Add pango. 2015-04-08 Carlos Alberto Lopez Perez [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22. https://bugs.webkit.org/show_bug.cgi?id=143530 Reviewed by Žan Doberšek. Assume that the default value for display (:0) is reserved and start checking on :1 Adjust webkitpy test and include two new test cases for this bug (display number not specified) and for X server named Xorg.bin (previous bug 1376599) * Scripts/webkitpy/port/xvfbdriver.py: (XvfbDriver._next_free_display) * Scripts/webkitpy/port/xvfbdriver_unittest.py: (XvfbDriverTest.test_start_no_pixel_tests): (XvfbDriverTest.test_start_pixel_tests): (XvfbDriverTest.test_start_arbitrary_worker_number): (XvfbDriverTest.test_next_free_display): (XvfbDriverTest.test_start_next_worker): 2015-04-08 Alex Christensen Block popups from content extensions. https://bugs.webkit.org/show_bug.cgi?id=143497 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): Added popup test. 2015-04-08 Alex Christensen and Patrick Gansterer Add CMake build system for WinCairo port. https://bugs.webkit.org/show_bug.cgi?id=115944 Reviewed by Chris Dumez. * CMakeLists.txt: * WinLauncher/CMakeLists.txt: Added. 2015-04-08 Carlos Garcia Campos [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user https://bugs.webkit.org/show_bug.cgi?id=143521 Reviewed by Martin Robinson. Add a way to detect unexpected web process crashes to WebViewTest, and a test case to testDOMCache to trigger the crash. * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: (WebKitDOMNodeTest::testDOMCache): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: (testWebKitWebViewProcessCrashed): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::WebViewTest): (WebViewTest::webProcessCrashed): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: 2015-04-07 Alexey Proskuryakov PageVisibilityStateWithWindowChanges should only be enabled on Yosemite rdar://problem/20461342 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: 2015-04-07 Commit Queue Unreviewed, rolling out r182511. https://bugs.webkit.org/show_bug.cgi?id=143507 caused debug test failures (Requested by alexchristensen on #webkit). Reverted changeset: "Block popups from content extensions." https://bugs.webkit.org/show_bug.cgi?id=143497 http://trac.webkit.org/changeset/182511 2015-04-07 Alex Christensen Block popups from content extensions. https://bugs.webkit.org/show_bug.cgi?id=143497 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): Added popup test. 2015-04-07 Benjamin Poulain Get the features.json files ready for open contributions https://bugs.webkit.org/show_bug.cgi?id=143436 Reviewed by Darin Adler. * Scripts/webkitpy/style/checkers/jsonchecker.py: (JSONFeaturesChecker.check): Extend the syntax checking a bit, but leave everything non-mandatory very loose until we figure what fields are important. 2015-04-07 Tim Horton Expose and test fixedLayoutSize via modern WebKit SPI https://bugs.webkit.org/show_bug.cgi?id=143500 Reviewed by Simon Fraser. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added. (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]): (TEST): Add a test that verifies that fixedLayoutSize works at all, that it persists through a navigation, and that turning it back off reverts to laying out at the size of the view. 2015-04-07 Michael Catanzaro Unreviewed. Add myself as a committer. * Scripts/webkitpy/common/config/contributors.json: 2015-04-07 Brent Fulgham [Win] Bots complain about missing /etc/catalog https://bugs.webkit.org/show_bug.cgi?id=143484 Reviewed by Chris Dumez. The libxml2 build on Mac, iOS, and Windows does not provide the set of default catalog files. We do not actually need these for our purposes, but we get warnings and some bot flakiness because they are not present. We can avoid both problems the same way the Mac and iOS ports do, by setting the XML_CATALOG_FILES environment variable to 'empty string', which avoid the warnings and bot problems. * Scripts/webkitpy/port/win.py: (WinPort.setup_environ_for_server): Added. 2015-04-06 Sam Weinig Use content extensions in MiniBrowser. https://bugs.webkit.org/show_bug.cgi?id=143446 Reviewed by Alex Christensen. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: * MiniBrowser/mac/AppDelegate.h: * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate init]): (-[BrowserAppDelegate showExtensionsManager:]): (-[BrowserAppDelegate userContentContoller]): * MiniBrowser/mac/ExtensionManagerWindowController.h: Added. * MiniBrowser/mac/ExtensionManagerWindowController.m: Added. (-[ExtensionManagerWindowController init]): (-[ExtensionManagerWindowController windowDidLoad]): (-[ExtensionManagerWindowController add:]): (-[ExtensionManagerWindowController remove:]): * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added. * MiniBrowser/mac/MainMenu.xib: 2015-04-07 Youenn Fablet web-platform-tests server should retrieve the modules file relatively to its docroot path https://bugs.webkit.org/show_bug.cgi?id=142742 Reviewed by Darin Adler. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path. 2015-04-06 Commit Queue Unreviewed, rolling out r182445. https://bugs.webkit.org/show_bug.cgi?id=143459 broke 32 bit build (Requested by alexchristensen on #webkit). Reverted changeset: "Use content extensions in MiniBrowser." https://bugs.webkit.org/show_bug.cgi?id=143446 http://trac.webkit.org/changeset/182445 2015-04-06 Sam Weinig Use content extensions in MiniBrowser. https://bugs.webkit.org/show_bug.cgi?id=143446 Reviewed by Alex Christensen. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: * MiniBrowser/mac/AppDelegate.h: * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate init]): (-[BrowserAppDelegate showExtensionsManager:]): (-[BrowserAppDelegate userContentContoller]): * MiniBrowser/mac/ExtensionManagerWindowController.h: Added. * MiniBrowser/mac/ExtensionManagerWindowController.m: Added. (-[ExtensionManagerWindowController init]): (-[ExtensionManagerWindowController windowDidLoad]): (-[ExtensionManagerWindowController add:]): (-[ExtensionManagerWindowController remove:]): * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added. * MiniBrowser/mac/MainMenu.xib: 2015-04-06 Michael Catanzaro [GTK] install-dependencies should prefer dnf to yum https://bugs.webkit.org/show_bug.cgi?id=143441 Reviewed by Martin Robinson. Test for the existance of dnf before yum, and only try to use yum if dnf does not exist. * gtk/install-dependencies: 2015-04-06 Andy Estes [iOS] 'make clean' fails in Tools/WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=143455 Reviewed by Dan Bernstein. This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets. * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds. 2015-04-06 Alexey Proskuryakov WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines https://bugs.webkit.org/show_bug.cgi?id=143450 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST): Make sure that the view is actually closed, regardless of anything else that happens beneath. Also, removed unnecessary get() calls. 2015-04-03 Alexey Proskuryakov Reduce the dependency on Flash in regression tests https://bugs.webkit.org/show_bug.cgi?id=143391 Reviewed by Anders Carlsson. * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad): Only allow QuickTime and the test plug-in. 2015-04-06 Youenn Fablet W3C test importer should generate the modules installed dynamically to run wpt tests https://bugs.webkit.org/show_bug.cgi?id=142738 Reviewed by Ryosuke Niwa. The test importer can now generate the submodules description file based on information extracted from the corresponding git repository. The implementation is done within TestDownloader and it is activated for the WPT repository. LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (WebPlatformTestServer._install_modules): Updated to cope with path as array. * Scripts/webkitpy/w3c/test_downloader.py: (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests. (TestDownloader): (TestDownloader._git_submodules_description): Computes submodule description. (TestDownloader.generate_git_submodules_description): Write submodule description in a file. * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.do_import): Added the possibility to post process the tests. (TestImporter): (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file. (TestImporter.should_convert_test_harness_links): Updated according new options format. * Scripts/webkitpy/w3c/test_importer_unittest.py: (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering. (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__): (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status): (TestImporterTest.test_submodules_generation): Added to check that modules description files works. 2015-04-05 Antti Koivisto Bloom filter should support longer hashes https://bugs.webkit.org/show_bug.cgi?id=143419 Reviewed by Dan Bernstein. * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: (TestWebKitAPI::generateRandomDigests): (TestWebKitAPI::TEST): 2015-04-03 Csaba Osztrogonác run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux https://bugs.webkit.org/show_bug.cgi?id=143372 Reviewed by Darin Adler. * Scripts/run-jsc-stress-tests: 2015-04-03 Antti Koivisto Add non-counting bloom filter class https://bugs.webkit.org/show_bug.cgi?id=143366 Reviewed by Sam Weinig. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added. (TestWebKitAPI::generateRandomHashes): (TestWebKitAPI::TEST): 2015-04-03 Csaba Osztrogonác FTL JIT tests should fail if LLVM library isn't available https://bugs.webkit.org/show_bug.cgi?id=143374 Reviewed by Mark Lam. * Scripts/run-jsc-stress-tests: 2015-04-03 Csaba Osztrogonác [EFL] Speedup jhbuild with disable running autogen.sh https://bugs.webkit.org/show_bug.cgi?id=143369 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: 2015-04-01 Alexey Proskuryakov filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines https://bugs.webkit.org/show_bug.cgi?id=143282 Reviewed by Daniel Bates. * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it. 2015-04-01 Alexey Proskuryakov When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures https://bugs.webkit.org/show_bug.cgi?id=143240 rdar://problem/19990425 Reviewed by Tim Horton. * DumpRenderTree/mac/LayoutTestHelper.m: (colorProfileURLForDisplay): (saveDisplayColorProfiles): Gracefully handle it when the current profile cannot be retrieved, fixing at least one case when LayoutTestHelper couldn't start. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._set_up_run): (Manager._force_pixel_tests_if_needed): * Scripts/webkitpy/port/base.py: (Port.to.start_helper): * Scripts/webkitpy/port/mac.py: (MacPort.start_helper): Return and check an error from start_helper(). 2015-04-01 Brent Fulgham [Win] Run test-webkitpy as part of EWS (just like we do on other platforms) https://bugs.webkit.org/show_bug.cgi?id=143321 Reviewed by Alexey Proskuryakov. * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop. 2015-04-01 Enrica Casucci Injected bundle messages should be at the page level. https://bugs.webkit.org/show_bug.cgi?id=143283 Reviewed by Alexey Proskuryakov. Updating WebKitTestRunner to use the new page level messaging. The author of this patch is Tim Horton, I just finished it. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::mouseDown): (WTR::EventSendingController::mouseUp): (WTR::EventSendingController::mouseMoveTo): (WTR::EventSendingController::leapForward): (WTR::EventSendingController::scheduleAsynchronousClick): (WTR::EventSendingController::keyDown): (WTR::EventSendingController::scheduleAsynchronousKeyDown): (WTR::EventSendingController::mouseScrollBy): (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): (WTR::EventSendingController::continuousMouseScrollBy): (WTR::EventSendingController::addTouchPoint): (WTR::EventSendingController::updateTouchPoint): (WTR::EventSendingController::setTouchModifier): (WTR::EventSendingController::setTouchPointRadius): (WTR::EventSendingController::touchStart): (WTR::EventSendingController::touchMove): (WTR::EventSendingController::touchEnd): (WTR::EventSendingController::touchCancel): (WTR::EventSendingController::clearTouchPoints): (WTR::EventSendingController::releaseTouchPoint): (WTR::EventSendingController::cancelTouchPoint): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessage): (WTR::InjectedBundle::didReceiveMessageToPage): (WTR::InjectedBundle::done): (WTR::InjectedBundle::outputText): (WTR::InjectedBundle::postNewBeforeUnloadReturnValue): (WTR::InjectedBundle::postAddChromeInputField): (WTR::InjectedBundle::postRemoveChromeInputField): (WTR::InjectedBundle::postFocusWebView): (WTR::InjectedBundle::postSetBackingScaleFactor): (WTR::InjectedBundle::postSetWindowIsKey): (WTR::InjectedBundle::postSimulateWebNotificationClick): (WTR::InjectedBundle::postSetAddsVisitedLinks): (WTR::InjectedBundle::setGeolocationPermission): (WTR::InjectedBundle::setMockGeolocationPosition): (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError): (WTR::InjectedBundle::setUserMediaPermission): (WTR::InjectedBundle::setCustomPolicyDelegate): (WTR::InjectedBundle::setHidden): (WTR::InjectedBundle::setCacheModel): (WTR::InjectedBundle::shouldProcessWorkQueue): (WTR::InjectedBundle::processWorkQueue): (WTR::InjectedBundle::queueBackNavigation): (WTR::InjectedBundle::queueForwardNavigation): (WTR::InjectedBundle::queueLoad): (WTR::InjectedBundle::queueLoadHTMLString): (WTR::InjectedBundle::queueReload): (WTR::InjectedBundle::queueLoadingScript): (WTR::InjectedBundle::queueNonLoadingScript): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setHandlesAuthenticationChallenges): (WTR::TestRunner::setAuthenticationUsername): (WTR::TestRunner::setAuthenticationPassword): (WTR::TestRunner::secureEventInputIsEnabled): (WTR::TestRunner::setBlockAllPlugins): * WebKitTestRunner/TestController.cpp: (WTR::TestController::createWebViewWithOptions): (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::didReceivePageMessageFromInjectedBundle): (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 2015-04-01 Commit Queue Unreviewed, rolling out r182174 and r182177. https://bugs.webkit.org/show_bug.cgi?id=143314 Try to correct EWS failures (Requested by bfulgham on #webkit). Reverted changesets: "Python SCM should be able to retrieve untracked files" https://bugs.webkit.org/show_bug.cgi?id=143135 http://trac.webkit.org/changeset/182174 "[buildbot] clean-build script should remove untracked files and revert local changes too" https://bugs.webkit.org/show_bug.cgi?id=142400 http://trac.webkit.org/changeset/182177 2015-04-01 Alex Christensen [Content Extensions] Properly handle regexes that match everything. https://bugs.webkit.org/show_bug.cgi?id=143281 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::testRequest): (TestWebKitAPI::makeBackend): (TestWebKitAPI::TEST_F): Removed duplicate code and added test. 2015-03-31 Benjamin Poulain Content Extensions: split the state machines to minimize prefix states https://bugs.webkit.org/show_bug.cgi?id=143253 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): (TestWebKitAPI::testPatternStatus): 2015-03-31 Yusuke Suzuki Clean up Identifier factories to clarify the meaning of StringImpl* https://bugs.webkit.org/show_bug.cgi?id=143146 Reviewed by Filip Pizlo. Simple API tests for StringImpl are added. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: (TestWebKitAPI::TEST): 2015-03-31 Csaba Osztrogonác [EFL] Add AArch64 builder and tester bot to build.webkit.org https://bugs.webkit.org/show_bug.cgi?id=143092 Reviewed by Gyuyoung Kim. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (Factory.__init__): * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: 2015-03-31 Youenn Fablet [buildbot] clean-build script should remove untracked files and revert local changes too https://bugs.webkit.org/show_bug.cgi?id=142400 Reviewed by Ryosuke Niwa. This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files. A helper routine SCM.discard_untracked_files is added for that purpose. * BuildSlaveSupport/clean-build: (main): Making call to Scripts/clean-webkit * Scripts/clean-webkit: Added. (main): Revert changes and delete untracked files. * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (SCMTest._shared_test_discard_untracked_files): (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly. 2015-03-31 Youenn Fablet Python SCM should be able to retrieve untracked files https://bugs.webkit.org/show_bug.cgi?id=143135 Reviewed by Ryosuke Niwa. This patch introduces SCM.untracked_files to retrieve a list of untracked files. Ignored files may be included or not in this list according boolean passed to the function. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.untracked_files): * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.untracked_files): * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (SCMTest._shared_test_untracked_files): (test_untracked_files): (GitSVNTest.test_untracked_files): * Scripts/webkitpy/common/checkout/scm/svn.py: (SVN.untracked_files): 2015-03-30 Alex Christensen [Content Extensions] Correctly handle regular expressions matching everything https://bugs.webkit.org/show_bug.cgi?id=143235 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::checkCompilerError): (TestWebKitAPI::TEST_F): Test ContentExtensionErrors. 2015-03-30 Alexey Proskuryakov DumpRenderTree should set NSWindowDisplayWithRunLoopObserver https://bugs.webkit.org/show_bug.cgi?id=143241 rdar://problem/20351297 Reviewed by Mark Lam. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): 2015-03-30 Gyuyoung Kim [CMake][EFL] Remove redundant library link and include path https://bugs.webkit.org/show_bug.cgi?id=143221 Reviewed by Csaba Osztrogonác. * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path. 2015-03-30 Sam Weinig [Content Extensions] Flesh out the UserContentExtensionStore https://bugs.webkit.org/show_bug.cgi?id=143123 Reviewed by Benjamin Poulain. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added. Add tests for _WKUserContentExtensionStore. 2015-03-30 Marcos Chavarría Teijeiro Update install-dependencies Fedora packages after r181624 https://bugs.webkit.org/show_bug.cgi?id=143215 Add json-glib, libv4l, openssl and pulseaudio development packages to the Fedora list providing we need them to build WebKit dependencies for this distribution. Reviewed by Philippe Normand. * gtk/install-dependencies: 2015-03-30 Commit Queue Unreviewed, rolling out r182119. https://bugs.webkit.org/show_bug.cgi?id=143196 problem with syntax (Requested by youenn on #webkit). Reverted changeset: "[buildbot] clean-build script should remove untracked files and revert local changes too" https://bugs.webkit.org/show_bug.cgi?id=142400 http://trac.webkit.org/changeset/182119 2015-03-30 Benjamin Poulain Start the features.json files https://bugs.webkit.org/show_bug.cgi?id=143207 Reviewed by Darin Adler. I kept the style checking light. We'll have to figure what is the best format for each field. * Scripts/webkitpy/style/checker.py: (CheckerDispatcher._create_checker): * Scripts/webkitpy/style/checkers/jsonchecker.py: (JSONContributorsChecker.check): (JSONFeaturesChecker): (JSONFeaturesChecker.check): 2015-03-29 Youenn Fablet [buildbot] clean-build script should remove untracked files and revert local changes too https://bugs.webkit.org/show_bug.cgi?id=142400 Reviewed by Ryosuke Niwa. This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files. * BuildSlaveSupport/clean-build: (main): Adding call to Tools/Scripts/clean-webkit. * Scripts/clean-webkit: Added. (main): Removes untracked and changed files. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.untracked_files): Retrieves GIT untracked files. * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.untracked_files): Retrieves SVN untracked files. (SCM): (SCM.discard_untracked_files): Deletes untracked files/folders. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (SCMTest._shared_test_untracked_files): Unit testing for untracked files. (test_untracked_files): (GitSVNTest.test_untracked_files): * Scripts/webkitpy/common/checkout/scm/svn.py: (SVN.untracked_files): 2015-03-27 Gyuyoung Kim [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro https://bugs.webkit.org/show_bug.cgi?id=143138 Reviewed by Csaba Osztrogonác. INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS. * ImageDiff/CMakeLists.txt: Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS. * WebKitTestRunner/CMakeLists.txt: ditto. 2015-03-27 Myles C. Maxfield Support building WTF on Windows without Cygwin https://bugs.webkit.org/show_bug.cgi?id=143084 Reviewed by Brent Fulgham. Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things. This patch also migrates to using File::Spec->catfile() for directory separators. * Scripts/update-webkit-dependency: (wanted): * Scripts/update-webkit-support-libs: (wanted): (downloadExpectedVersionNumber): (zipFileVersion): (toUnixPath): Deleted. * Scripts/webkitdirs.pm: (determineSourceDir): (windowsSourceSourceDir): (windowsLibrariesDir): (windowsOutputDir): (checkInstalledTools): (buildVisualStudioProject): 2015-03-27 Alex Christensen Fix WinCairo bot. https://bugs.webkit.org/show_bug.cgi?id=143086 Reviewed by Brent Fulgham. * Scripts/webkitdirs.pm: (buildVisualStudioProject): (runSvnUpdateAndResolveChangeLogs): Use ActivePerl-friendly perl. 2015-03-27 Csaba Osztrogonác URTBF after r182059 to fix the EFL build. * TestWebKitAPI/CMakeLists.txt: 2015-03-26 Alexey Proskuryakov Layout test results URL loads in WK1 but not WK2 minibrowser https://bugs.webkit.org/show_bug.cgi?id=143117 Reviewed by Tim Horton. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and everything. (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto. 2015-03-26 Jer Noble Add --allowed-host support to run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=142938 Reviewed by Brent Fulgham. Accept --allowed-host arguments from run-webkit-tests and pass them through to DumpRenderTree and WebKitTestRunner. Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results are placed in the wrong location. The argument is compared with each tests's path, and if a relative path or a path with '..' was used, results are placed alongside the test. Take the absolute path of the --layout-test-dir argument, collapsing path components like '..'. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): * Scripts/webkitpy/port/base.py: (Port.__init__): (Port.allowed_hosts): * Scripts/webkitpy/port/driver.py: (Driver.cmd_line): 2015-03-26 Jer Noble [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers https://bugs.webkit.org/show_bug.cgi?id=142931 Reviewed by Brent Fulgham. Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at runtime. To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified hostname to a whitelist; requests to these hosts will allowed to proceed normally. Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the top loading frame, which causes a subsequent crash when further resources are requested. Instead, get the top loading frame from the page, as we do elsewhere in this class. * DumpRenderTree/TestRunner.h: (TestRunner::allowedHosts): (TestRunner::setAllowedHosts): * DumpRenderTree/mac/DumpRenderTree.mm: (initializeGlobalsFromCommandLineOptions): (runTest): * DumpRenderTree/mac/ResourceLoadDelegate.mm: (isAllowedHost): (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessage): (WTR::InjectedBundle::isAllowedHost): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::isAllowedHost): (WTR::InjectedBundlePage::willSendRequestForFrame): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/Options.cpp: (WTR::handleOptionAllowedHost): (WTR::OptionsHandler::OptionsHandler): * WebKitTestRunner/Options.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): (WTR::TestController::resetStateToConsistentValues): * WebKitTestRunner/TestController.h: 2015-03-26 Brady Eidson Apply ContentExtension actions after redirects. and https://bugs.webkit.org/show_bug.cgi?id=143055 Reviewed by Alex Christensen. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL which is specifically interesting to a new test. 2015-03-26 Csaba Osztrogonác [EFL] Disable building libseccomp on AArch64 https://bugs.webkit.org/show_bug.cgi?id=143094 Reviewed by Gyuyoung Kim. * efl/jhbuildrc: 2015-03-26 Csaba Osztrogonác [jhbuild] git should use only 1 thread for cloning jhbuild https://bugs.webkit.org/show_bug.cgi?id=143095 Reviewed by Gyuyoung Kim. * jhbuild/jhbuild-wrapper: (clone_jhbuild): 2015-03-25 Joseph Pecoraro Update prepare-ChangeLog to work with ES6 Class syntax https://bugs.webkit.org/show_bug.cgi?id=143069 Reviewed by Timothy Hatcher. * Scripts/prepare-ChangeLog: (get_function_line_ranges_for_javascript): Better handle ES6 Class syntax. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: (BaseClass): (DerivedClass): (DerivedClass.staticMethod): (DerivedClass.prototype.method.nestedFunctionInsideMethod): (DerivedClass.prototype.method): (DerivedClass.prototype.get getter): (namespace.MyClass): (namespace.MyClass.staticMethod): (namespace.MyClass.prototype.method.nestedFunctionInsideMethod): (namespace.MyClass.prototype.method): (namespace.MyClass.prototype.get getter): Proof! 2015-03-25 Filip Pizlo Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC https://bugs.webkit.org/show_bug.cgi?id=142993 Reviewed by Mark Lam. Bunch of support for testing executable allocation failure. * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added. (fail): * Scripts/run-javascriptcore-tests: (runJSCStressTests): * Scripts/run-jsc-stress-tests: 2015-03-25 Myles C. Maxfield Fix Windows build from r181977. Unreviewed. * Scripts/update-webkit-dependency: 2015-03-25 Sam Weinig Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter): 2015-03-25 Myles C. Maxfield Migrate update-webkit for Windows to not require Cygwin https://bugs.webkit.org/show_bug.cgi?id=143040 Reviewed by Brent Fulgham. * Scripts/update-webkit-dependency: (wanted): (toUnixPath): Deleted. * Scripts/webkitdirs.pm: (fontExists): (checkInstalledTools): (setupAppleWinEnv): 2015-03-25 Sam Weinig [Content Extensions] Convert content extension compiling to return error codes and write its output using a client https://bugs.webkit.org/show_bug.cgi?id=143059 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter): Update for new interface of compileRuleList(). 2015-03-25 Alex Christensen [Content Extensions] Add multi-DFA compiling and interpreting. https://bugs.webkit.org/show_bug.cgi?id=143010 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::testRequest): (TestWebKitAPI::TEST_F): Add some tests for ignore-previous-rules and large rulesets. 2015-03-25 Alexey Proskuryakov Mavericks WK1 still runs JSC tests https://bugs.webkit.org/show_bug.cgi?id=143035 Reviewed by Csaba Osztrogonác. * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line with other bots. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests accordingly. 2015-03-25 Commit Queue Unreviewed, rolling out r181932. https://bugs.webkit.org/show_bug.cgi?id=143041 The test fails most of the time on bots (Requested by ap on #webkit). Reverted changeset: "[Content Extensions] Add multi-DFA compiling and interpreting." https://bugs.webkit.org/show_bug.cgi?id=143010 http://trac.webkit.org/changeset/181932 2015-03-24 Alex Christensen [Content Extensions] Add multi-DFA compiling and interpreting. https://bugs.webkit.org/show_bug.cgi?id=143010 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::testRequest): (TestWebKitAPI::TEST_F): Add some tests for ignore-previous-rules and large rulesets. 2015-03-24 Benjamin Poulain Make URL filter patterns matching consistent and add a simple canonicalization step https://bugs.webkit.org/show_bug.cgi?id=142998 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: 2015-03-24 Csaba Osztrogonác [EFL] Add OpenWebRTC in jhbuild https://bugs.webkit.org/show_bug.cgi?id=142778 Reviewed by Gyuyoung Kim. Original patch by Philippe Normand * efl/install-dependencies: Dependencies for OpenWebRTC. * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and the openwebrtc gst plugins. 2015-03-23 Brent Fulgham Regression(r181257): WTF_WorkQueue.Simple is flaky https://bugs.webkit.org/show_bug.cgi?id=142560 Remove the check that the refCount has returned to one after the individual tasks have completed. It's too nondeterministic when the reference count will be reduced. Reviewed by Alexey Proskuryakov * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: (TestWebKitAPI::TEST): Remove test that refCount is back to 1. 2015-03-23 Gyuyoung Kim [CMake][EFL] Put failure API test excutables into failure directory https://bugs.webkit.org/show_bug.cgi?id=142965 Reviewed by Csaba Osztrogonác. Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory. * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*. * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test. 2015-03-22 Benjamin Poulain CSS Selectors: fix attribute case-insensitive matching of Contain and List https://bugs.webkit.org/show_bug.cgi?id=142932 Reviewed by Darin Adler. Add tests for the new features and fix some existing tests using the stringFromUTF8() utility recently added by Dhi. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: (TestWebKitAPI::stringFromUTF8): * TestWebKitAPI/Tests/WTF/StringView.cpp: 2015-03-22 Michael Catanzaro [GTK] install-dependencies should install orc https://bugs.webkit.org/show_bug.cgi?id=142955 Reviewed by Martin Robinson. Install orc, needed by openwebrtc * gtk/install-dependencies: 2015-03-22 Benjamin Poulain Detect when url filter pattern with groups match the empty string https://bugs.webkit.org/show_bug.cgi?id=142930 Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: 2015-03-22 Anders Carlsson _WKWebsiteDataStore should clear WebSQL databases https://bugs.webkit.org/show_bug.cgi?id=142947 Reviewed by Sam Weinig. Add a variable that keeps track of the types of data we want to operate on, for easier debugging. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController fetchWebsiteData:]): (-[WK2BrowserWindowController fetchAndClearWebsiteData:]): (-[WK2BrowserWindowController clearWebsiteData:]): 2015-03-20 Mark Hahnenberg GCTimer should know keep track of nested GC phases https://bugs.webkit.org/show_bug.cgi?id=142675 Reviewed by Darin Adler. Adds a tool to aid in parsing the GC phase timing output into a tree-like structure based on the parent-child relationships of nested GC phases. * Scripts/parse-gc-phase-timings: Added. (Timing): (Timing.__init__): (Timing.__unicode__): (Timing.__str__): (Timing.__repr__): (parse_input): (print_timing_node): (print_timing_tree): (link_parents): (main): 2015-03-20 Brent Fulgham [Win] Temporarily turn of EWS Windows tests while I debug the test failure. * Scripts/webkitpy/common/config/ews.json: 2015-03-20 Philippe Normand [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository https://bugs.webkit.org/show_bug.cgi?id=142867 Rubber-stamped by Csaba Osztrogon. * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use a fixed revision for the openwebrtc-gst-plugins. 2015-03-19 Ryosuke Niwa Unreviewed build fix. Don't try to report stats for all benchmarks. Just report the geometric mean of preferred means. * Scripts/run-jsc-benchmarks: 2015-03-19 Ryosuke Niwa run-jsc-benchmarks should only report preferred mean https://bugs.webkit.org/show_bug.cgi?id=142874 Reviewed by Geoffrey Garen. Just collect statistics for the preferred mean. * Scripts/run-jsc-benchmarks: 2015-03-19 Alex Christensen [Content Extensions] Test regular expression parse failures. https://bugs.webkit.org/show_bug.cgi?id=142872 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::testPatternStatus): (TestWebKitAPI::TEST_F): Added tests for each parsing status. 2015-03-19 Alex Christensen Fix API tests after r181754. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::testRequest): 2015-03-19 Brady Eidson Part of content extensions should apply css selectors https://bugs.webkit.org/show_bug.cgi?id=142604 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (WebCore::ContentExtensions::operator<<): 2015-03-19 Brent Fulgham [Win] Activate tests on EWS https://bugs.webkit.org/show_bug.cgi?id=142850 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/common/config/ews.json: Add me as the EWS bot watcher, and activate tests. 2015-03-19 Csaba Osztrogonác [GTK] Fix inspector userinterface related incremental build issue https://bugs.webkit.org/show_bug.cgi?id=142849 Reviewed by Carlos Garcia Campos. * Scripts/webkitdirs.pm: (shouldRemoveCMakeCache): 2015-03-18 Alex Christensen [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page. https://bugs.webkit.org/show_bug.cgi?id=142799 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::testPattern): (TestWebKitAPI::TEST_F): Start testing regex failures. 2015-03-18 Dhi Aurrahman Fix StringView typos after r181525 and r181558 https://bugs.webkit.org/show_bug.cgi?id=142772 Reviewed by Darin Adler. Add some tests in [1] to cover the StringView::startsWith, StringView::startsWithIgnoringASCIICase, StringView::endsWith and StringView::endsWithIgnoringASCIICase implementations. * TestWebKitAPI/Tests/WTF/StringView.cpp: (TestWebKitAPI::TEST): 2015-03-18 Dana Burkart Remove extraneous import to fix the build. Unreviewed. * Scripts/webkitpy/port/driver.py: 2015-03-18 Dana Burkart ASAN_OPTIONS=allocator_may_return_null=1 needs to be set https://bugs.webkit.org/show_bug.cgi?id=142547 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/port/driver.py: (Driver._setup_environ_for_driver): 2015-03-18 Alexey Proskuryakov Tweak how AppleSystemFontOSSubversion default is added https://bugs.webkit.org/show_bug.cgi?id=142835 Reviewed by Dan Bernstein. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): 2015-03-18 Dan Bernstein prepare-ChangeLog doesn't understand C string literals split across multiple lines with \ https://bugs.webkit.org/show_bug.cgi?id=142815 Reviewed by Darin Adler. * Scripts/prepare-ChangeLog: (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching quotation mark, use new variable $quotation_mark to remember what we are looking for, and keep consuming the quoted text until the matching quotation mark is reached. Emit the warning only if a line ends without a backslash before the matching quotation mark was found. 2015-03-18 Joseph Pecoraro Remove unused "preprocessor" parameter to sub-CodeGenerators https://bugs.webkit.org/show_bug.cgi?id=142793 Reviewed by Darin Adler. * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: (new): 2015-03-18 Csaba Osztrogonác [EFL] Bump gstreamer version to 1.4.4 https://bugs.webkit.org/show_bug.cgi?id=142782 Reviewed by Philippe Normand. * efl/jhbuild.modules: * efl/patches/gst-libav.patch: * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added. * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed. 2015-03-17 Tim Horton Fix the iOS build. * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: (WTR::InjectedBundle::platformInitialize): 2015-03-17 Dean Jackson check-webkit-style should allow "bool a : 1" https://bugs.webkit.org/show_bug.cgi?id=142794 Reviewed by Brent Fulgham. We should allow member bitfields of the form: bool m_var : 1; It seems that Visual Studio 8 was the last compiler that wasn't happy about not using unsigned here. We already have about 500 cases (in WebCore) where people were ignoring this rule. * Scripts/webkitpy/style/checkers/cpp.py: (check_language): Allow "bool". * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests. (CppStyleTest.test_enum_bitfields): (CppStyleTest.test_plain_integral_bitfields): 2015-03-17 Benjamin Poulain Compile character ranges targeting the same state as range check in the bytecode https://bugs.webkit.org/show_bug.cgi?id=142759 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): 2015-03-17 Youenn Fablet W3C test parser and converter should use test importer host https://bugs.webkit.org/show_bug.cgi?id=142729 Reviewed by Bem Jones-Bey. When instantiated by TestImporter, TestParser and TestConverter are now using the same host. This enables adding more TestImporter unit testing. This patch also ensures that the git object instantiated by TestDownloader is using the same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing. * Scripts/webkitpy/common/system/filesystem_mock.py: (MockFileSystem.copytree): Fixes implementation as it creates a runtime error. * Scripts/webkitpy/w3c/test_downloader.py: (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse. (TestDownloader.checkout_test_repository): Making use of the new git function. * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.find_importable_tests): Adding host as parameter to the parser. (TestImporter.import_tests): Adding host as parameter to the converter. * Scripts/webkitpy/w3c/test_importer_unittest.py: (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests. (TestImporterTest): (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. * Scripts/webkitpy/w3c/test_parser.py: (TestParser.__init__): Adding host as parameter constructor. 2015-03-17 Carlos Garcia Campos [GTK] WebKitDOM objects leaking https://bugs.webkit.org/show_bug.cgi?id=118788 Reviewed by Darin Adler and Sergio Villar Senin. Update DOMObjectCache unit test to check that DOM objects are also released when new contents are loaded in the web view, and the old document is detached from the frame. * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: (testWebKitDOMObjectCache): * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: (runTest): 2015-03-17 Youenn Fablet W3C test importer default import folder should be LayoutTests/imported/w3c https://bugs.webkit.org/show_bug.cgi?id=142728 Reviewed by Bem Jones-Bey. * Scripts/webkitpy/w3c/test_importer.py: (parse_args): Updating the default destination option value to 'imported/w3c'. 2015-03-17 Philippe Normand [GTK] basic OpenWebRTC build support https://bugs.webkit.org/show_bug.cgi?id=142393 Reviewed by Carlos Garcia Campos. * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This is not the upstream OpenWebRTC repository. This temporary fork contains a few patches needed by WebKit for audio/video rendering. 2015-03-17 Gyuyoung Kim [CMake][EFL] Build test tools only for developer mode https://bugs.webkit.org/show_bug.cgi?id=142761 Reviewed by Csaba Osztrogonác. Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode. * CMakeLists.txt: 2015-03-17 Joseph Pecoraro Remove never used "useLayerOnTop" bindings generator argument https://bugs.webkit.org/show_bug.cgi?id=142773 Reviewed by Darin Adler. * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: (new): 2015-03-16 Ryosuke Niwa Enable ES6 classes by default https://bugs.webkit.org/show_bug.cgi?id=142774 Reviewed by Gavin Barraclough. * Scripts/webkitperl/FeatureList.pm: 2015-03-16 Alexey Proskuryakov Fix webkitpy tests after r181585. Looks like "me" cannot be anyone's email, it's a special case. * Scripts/webkitpy/common/config/contributors.json: 2015-03-16 Alexey Proskuryakov Add tolerance to WebAudio tests https://bugs.webkit.org/show_bug.cgi?id=142676 Reviewed by Tim Horton. * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: (TestResultWriter.create_audio_diff_and_write_result): * Scripts/webkitpy/layout_tests/models/test_failures.py: (FailureAudio.write_failure): * Scripts/webkitpy/port/base.py: (Port.do_audio_results_differ): Diff audio failures. * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing tests to use real parseable WAV data, and got rid of base64, which there didn't seem to have been any reason for. 2015-03-16 Alexey Proskuryakov [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed https://bugs.webkit.org/show_bug.cgi?id=142720 Reviewed by Myles C. Maxfield. Activate system copies of Microsoft fonts for the current process, thus overriding any other ones that could be preferred by the system otherwise. * DumpRenderTree/mac/DumpRenderTree.mm: (activateSystemCoreWebFonts): (adjustFonts): * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: (WTR::activateSystemCoreWebFonts): (WTR::activateFonts): 2015-03-16 Xabier Rodriguez Calvar Created Streams API watchlist https://bugs.webkit.org/show_bug.cgi?id=142684 Reviewed by Benjamin Poulain. * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI watchlist and added Benjamin, Youenn and me to it. 2015-03-15 Benjamin Poulain CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen https://bugs.webkit.org/show_bug.cgi?id=142715 Reviewed by Brent Fulgham. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: (TestWebKitAPI::TEST): 2015-03-15 Benjamin Poulain Change the exact attribute matching to be ASCII case-insensitive https://bugs.webkit.org/show_bug.cgi?id=142609 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: * TestWebKitAPI/Tests/WTF/StringView.cpp: 2015-03-13 Youenn Fablet WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it https://bugs.webkit.org/show_bug.cgi?id=134764 Reviewed by Ryosuke Niwa. TestDownloader is introduced to download W3C tests from the official W3C tests repositories (https://github.com/w3c/web-platform-tests.git and https://github.com/w3c/csswg-test.git). TestDownloader clones the repositories and checkouts revisions of the tests defined in LayoutTests/imported/w3c/resources/TestRepositories. Similarly to https://codereview.chromium.org/148173016, TestDownloader copies part of the files based on the rules defined in LayoutTests/imported/w3c/resources/ImportExpectations. TestDownloader is used by TestImporter when no source directory is provided. * Scripts/webkitpy/w3c/test_downloader.py: Added. (TestDownloader): (TestDownloader.default_options): (TestDownloader.load_test_repositories): (TestDownloader.__init__): (TestDownloader.checkout_test_repository): (TestDownloader._init_paths_from_expectations): (TestDownloader._add_test_suite_paths): (TestDownloader._empty_directory): (TestDownloader.copy_tests): (TestDownloader.download_tests): * Scripts/webkitpy/w3c/test_importer.py: (main): (parse_args): (TestImporter.__init__): (TestImporter.do_import): (TestImporter.test_downloader): (TestImporter.find_importable_tests.should_keep_subdir): (TestImporter.should_convert_test_harness_links): (TestImporter.import_tests): (TestImporter.write_import_log): 2015-03-12 Alexey Proskuryakov [Mavericks] Test snapshots are 1600x1200 on Retina devices https://bugs.webkit.org/show_bug.cgi?id=142630 Reviewed by Tim Horton. * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage): Removed an ifdef that disabled the fix on Mavericks. 2015-03-12 Csaba Osztrogonác Remove isWK2 cruft from webkitdirs.pm after r170426 https://bugs.webkit.org/show_bug.cgi?id=142618 Reviewed by Daniel Bates. * Scripts/webkitdirs.pm: (isWK2): Deleted. 2015-03-12 Alexey Proskuryakov testRunner.setAlwaysAcceptCookies does not work with NetworkProcess https://bugs.webkit.org/show_bug.cgi?id=138687 Reviewed by Carlos Garcia Campos. Always change cookie policy from UI process, as changing it from WebProcess doesn't affect other processes. The implementation is imperfect, because the change happens asynchronously, but I don't expect it to be a problem in practice. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setAlwaysAcceptCookies): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): 2015-03-12 Csaba Osztrogonác [EFL] Enable building EFL 1.13 with NEON support https://bugs.webkit.org/show_bug.cgi?id=142619 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: 2015-03-11 Alex Christensen [Content Extensions] Add resource type and load type triggers. https://bugs.webkit.org/show_bug.cgi?id=142422 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::testRequest): (TestWebKitAPI::mainDocumentRequest): (TestWebKitAPI::TEST_F): (TestWebKitAPI::testURL): Deleted. 2015-03-10 Sam Weinig Allow adding a button in input elements for auto fill related functionality https://bugs.webkit.org/show_bug.cgi?id=142564 Reviewed by Anders Carlsson. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): Update for new callback. 2015-03-11 Benjamin Poulain Add basic support for BOL and EOL assertions to the URL Filter parser https://bugs.webkit.org/show_bug.cgi?id=142568 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::TEST_F): 2015-03-11 Carlos Garcia Campos [GTK] Add support for handling TLS errors to MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=142576 Reviewed by Sergio Villar Senin. It's useful for testing TLS errors handling itself, but also to allow ignoring TLS errors when testing. * MiniBrowser/gtk/BrowserWindow.c: (webViewLoadFailedWithTLSerrors): (browserWindowConstructed): 2015-03-11 Myles C. Maxfield Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline() https://bugs.webkit.org/show_bug.cgi?id=142569 Reviewed by David Hyatt. Test Optional::valueOrCompute(). * TestWebKitAPI/Tests/WTF/Optional.cpp: (TestWebKitAPI::TEST): 2015-03-11 Carlos Garcia Campos [GTK] Add an option to enable MiniBrowser for non developer builds and always install it https://bugs.webkit.org/show_bug.cgi?id=126688 Reviewed by Gustavo Noronha Silva. * CMakeLists.txt: Build testing tools only for developer builds, but MiniBrowser when ENABLE_MINIBROWSER option is ON. * MiniBrowser/gtk/CMakeLists.txt: Only add -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds, and add a rule to install the MiniBrowser. * MiniBrowser/gtk/main.c: (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer builds. 2015-03-11 Brent Fulgham Add some DateMath tests to TestWebKitAPI https://bugs.webkit.org/show_bug.cgi?id=142565 Reviewed by Alexey Proskuryakov. * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file. * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto. * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto." * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added. 2015-03-10 Brent Fulgham Regression(r181257): WTF_WorkQueue.Simple is flaky https://bugs.webkit.org/show_bug.cgi?id=142560 Unreviewed attempt to improve test stability. * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for the WorkQueue a little later to redue flakiness. 2015-03-10 Myles C. Maxfield Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion https://bugs.webkit.org/show_bug.cgi?id=142555 Reviewed by Simon Fraser. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize): 2015-03-10 Alex Christensen Use unsigned for HashSet size. https://bugs.webkit.org/show_bug.cgi?id=142518 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WTF/HashMap.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/HashSet.cpp: (TestWebKitAPI::testInitialCapacity): * TestWebKitAPI/Tests/WTF/ListHashSet.cpp: (TestWebKitAPI::TEST): 2015-03-10 Daniel Bates [iOS] Add WebKitSystemInterface for iOS 8.2 https://bugs.webkit.org/show_bug.cgi?id=142505 Rubber-stamped by Anders Carlsson. Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a. I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script copy-webkitlibraries-to-product-directory in r181286. * Scripts/copy-webkitlibraries-to-product-directory: 2015-03-10 Benjamin Poulain Extend URL filter's Term definition to support groups/subpatterns https://bugs.webkit.org/show_bug.cgi?id=142519 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::testURL): 2015-03-06 Jer Noble Add an option to run-webkit-tests to override the LayoutTests/ directory https://bugs.webkit.org/show_bug.cgi?id=142418 Reviewed by David Kilzer. Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests directory. The base port will parse the options during initialization and store the override location if present. layout_tests_dir() will return this overridden location if set. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): * Scripts/webkitpy/port/base.py: (Port.__init__): (Port.layout_tests_dir): 2015-03-09 Martin Robinson [CMake] Enable WorkQueue tests for CMake ports https://bugs.webkit.org/show_bug.cgi?id=142473 Reviewed by Darin Adler. * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to the list of source files. * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory to the list of include directories for EFL. 2015-03-09 David Kilzer Attempt to fix timeouts on iOS Simulator layout tests * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS Simulator end after the first 50 tests time out. Some analysis this past weekend shows that the 'Booted' status in the output of `xcrun simctl list` is not sufficient (and watching the test run shows that SpringBoard hasn't fully started to the point where it's displaying icons on the home screen). The workaround until we have a better fix is to add an arbitrary timeout to let SpringBoard finish launching. In practice, 15 seconds is probably enough, but 30 seconds should nearly always work. 2015-03-09 Per Arne Vollan Unreviewed. Add myself as a committer. * Scripts/webkitpy/common/config/contributors.json: 2015-03-09 David Kilzer Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add an expectation that will fail if we hit the race condition. This test is inherently racy and will deadlock if the first job for queue2 takes the mutex lock before the second job for queue1. 2015-03-08 Brent Fulgham [Win] WTF::WorkQueue does not balance ref/deref properly https://bugs.webkit.org/show_bug.cgi?id=142471 Reviewed by Antti Koivisto. * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: (TestWebKitAPI::TEST): Check that the refcount is correct. 2015-03-08 Gyuyoung Kim Do not show passing test result on output of EFL layout test https://bugs.webkit.org/show_bug.cgi?id=142380 Reviewed by Darin Adler. To show passing tests has caused inconvenience when we detect problem tests in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port in order not to show passing tests in the output of EFL layout test. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunWebKitTests.start): 2015-03-08 Brent Fulgham Unreviewed build fix. * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: (TestWebKitAPI::TEST): Remove two unused variables. 2015-03-08 Brent Fulgham Add some WorkQueue tests to TestWebKitAPI https://bugs.webkit.org/show_bug.cgi?id=142447 Reviewed by Sam Weinig. * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added. (TestWebKitAPI::simpleTest): (TestWebKitAPI::longTest): (TestWebKitAPI::thirdTest): (TestWebKitAPI::finishedTests): (TestWebKitAPI::TEST): (TestWebKitAPI::longTest2): 2015-03-08 Carlos Garcia Campos Remove willDestroyFrame in WKBundlePageLoaderClient https://bugs.webkit.org/show_bug.cgi?id=142389 Reviewed by Anders Carlsson. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): 2015-03-07 Brent Fulgham [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage https://bugs.webkit.org/show_bug.cgi?id=142433 Reviewed by Darin Adler. Include more TestWebKitAPI tests when building for Windows. Also fix a build error in MetaAllocator.cpp caused by one of the Microsoft headers #defining 'small'. * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: 2015-03-06 Sam Weinig [Content Extensions] Move compiling of content extensions to the UIProcess https://bugs.webkit.org/show_bug.cgi?id=142402 Reviewed by Benjamin Poulain. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp. (TestWebKitAPI::InMemoryCompiledContentExtension::create): (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension): (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension): (TestWebKitAPI::TEST_F): * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed. Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension is now abstract). 2015-03-06 Brent Fulgham [Win] Correct Windows build. Rubberstamped by Michael Saboff * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error in the GOTO labels. 2015-03-06 Carlos Garcia Campos [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished https://bugs.webkit.org/show_bug.cgi?id=142385 Reviewed by Sergio Villar Senin. Use stack allocated GMainLoopSources to make sure they are cancelled automatically if the test finishes before they have been processed. * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: (testWebViewSyncRequestOnMaxConns): 2015-03-06 Csaba Osztrogonác Remove Mountain Lion libraries since ML isn't supported https://bugs.webkit.org/show_bug.cgi?id=142332 Reviewed by Darin Adler. * Scripts/copy-webkitlibraries-to-product-directory: 2015-03-06 Carlos Alberto Lopez Perez and Youenn Fablet Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS https://bugs.webkit.org/show_bug.cgi?id=142083 Reviewed by Simon Fraser. Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (WebPlatformTestServer._copy_webkit_test_files): 2015-03-06 Csaba Osztrogonác setup-git-clone fails due to the failure to download python-irclib-0.4.8 https://bugs.webkit.org/show_bug.cgi?id=141946 Reviewed by Ryosuke Niwa. Check in ircbot.py and irclib.py to avoid network problems in the future. * Scripts/webkitpy/common/net/irc/ircbot.py: * Scripts/webkitpy/thirdparty/__init__.py: (AutoinstallImportHook.find_module): (AutoinstallImportHook._install_irc): Deleted. * Scripts/webkitpy/thirdparty/__init___unittest.py: (ThirdpartyTest.test_imports): * Scripts/webkitpy/thirdparty/irc/__init__.py: Added. * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added. * Scripts/webkitpy/thirdparty/irc/irclib.py: Added. 2015-03-06 David Kilzer Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds See also fix to config.json in r181097. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): Add missing "WK2" to the names of the perf bots. 2015-03-06 Csaba Osztrogonác run-jsc-stress-tests should determine the architecture from ELF binaries https://bugs.webkit.org/show_bug.cgi?id=142335 Reviewed by Darin Adler. * Scripts/run-jsc-stress-tests: 2015-03-05 David Kilzer [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator' Reviewed by Darin Adler. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_baseline_search_path): Switch the TestExpectations order of ios-simulator-wk2 from this: ios-simulator-wk2, wk2, ios-simulator To this: ios-simulator-wk2, ios-simualtor, wk2 2015-03-05 Brent Fulgham [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after https://bugs.webkit.org/show_bug.cgi?id=142370 Reviewed by Dean Jackson. * Scripts/webkitdirs.pm: (buildVisualStudioProject): Tell MSBuild to output log files to two separate logs, one for warnings, the other for errors. * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs into the standard BuildOutput.htm document. 2015-03-05 David Kilzer Dashboard has trouble parsing iOS test output Reviewed by Alex Christensen. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: (BuildbotTestResults.prototype._parseResults.resultSummarizer): Add fallback path to build a regex using 'matchString' so that it matches anywhere in the line. In practice, 'matchString' is a prefix for the label following the number. 2015-03-05 Alex Christensen Fix linker warnings in TestWebKitAPI. https://bugs.webkit.org/show_bug.cgi?id=141912 Reviewed by David Kilzer. * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Do not export TearDownTestCase or SetUpTestCase symbols. 2015-03-05 Brent Fulgham [Win] Unreviewed EWS fix. * Scripts/webkitdirs.pm: (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes the EWS output more usable. 2015-03-05 Chris Dumez Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16() https://bugs.webkit.org/show_bug.cgi?id=142350 Reviewed by Michael Saboff and Benjamin Poulain. Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't crash if the string is 8-bit but the pattern is 16-bit (and vice-versa). * TestWebKitAPI/Tests/WTF/WTFString.cpp: (TestWebKitAPI::TEST): 2015-03-05 Brent Fulgham [Win] Ensure build target directory exists when launching MSBuild https://bugs.webkit.org/show_bug.cgi?id=142360 Reviewed by Dean Jackson. Create the build output directory (if it doesn't exist) before launching MSBuild so that it can immediately begin writing logs. * Scripts/webkitdirs.pm: (buildVisualStudioProject): 2015-03-05 Chris Dumez run-webkit-tests and run-perf-tests should use WebKitTestRunner by default https://bugs.webkit.org/show_bug.cgi?id=142325 Reviewed by Csaba Osztrogonác. run-webkit-tests and run-perf-tests now use WebKitTestRunner by default. As a result, "--webkit-test-runner / -2" parameters are replaced by "--dump-render-tree / -1" so developers can run DumpRenderTree rather than WebKitTestRunner. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunWebKit1Tests): (RunWebKit1Tests.start): (RunWebKit1LeakTests): (RunWebKit1LeakTests.start): (RunAndUploadPerfTestsWebKit1): (RunAndUploadPerfTestsWebKit1.start): (TestFactory): (TestWebKit1LeaksFactory): (TestWebKit1LeaksFactory.__init__): (TestWebKit1Factory): (TestWebKit1AllButJSCFactory): (TestAllButJSCFactory): (BuildAndPerfTestWebKit1Factory): (BuildAndPerfTestWebKit1Factory.__init__): (BuildAndPerfTestFactory): (BuildAndPerfTestFactory.__init__): (DownloadAndPerfTestWebKit1Factory): (DownloadAndPerfTestWebKit1Factory.__init__): (DownloadAndPerfTestFactory): (DownloadAndPerfTestFactory.__init__): (RunWebKitLeakTests): Deleted. (RunWebKitLeakTests.start): Deleted. (RunWebKit2Tests): Deleted. (RunWebKit2Tests.start): Deleted. (RunAndUploadPerfTestsWebKit2): Deleted. (RunAndUploadPerfTestsWebKit2.start): Deleted. (TestLeaksFactory): Deleted. (TestLeaksFactory.__init__): Deleted. (TestWebKit2Factory): Deleted. (TestWebKit2AndJSCFactory): Deleted. (BuildAndPerfTestWebKit2Factory): Deleted. (BuildAndPerfTestWebKit2Factory.__init__): Deleted. (DownloadAndPerfTestWebKit2Factory): Deleted. (DownloadAndPerfTestWebKit2Factory.__init__): Deleted. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._parse_args): * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_build_driver): 2015-03-05 Brent Fulgham [Win] Switch to MSBuild so we get more useful stdout logging in buildbot https://bugs.webkit.org/show_bug.cgi?id=140845 Reviewed by David Kilzer. Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013 and generate suitable build commands to drive a full build from our existing solution files. * Scripts/webkitdirs.pm: (msBuildInstallDir): Added. (determineConfigurationForVisualStudio): Revise to use MSBuild command line arguments to drive the build. (setupCygwinEnv): Warn user if MSBuild cannot be located. (buildVisualStudioProject): Revise to use MSBuild command line arguments to specify build architecture. * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't bother looking for CoreUI or SafariTheme build logs. 2015-03-05 Csaba Osztrogonác [buildbot] mastercfg_unittest.py should be runnable easily https://bugs.webkit.org/show_bug.cgi?id=142219 Reviewed by Chris Dumez. Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is the last Twisted version works together with this buildbot version. * Scripts/webkitpy/common/system/autoinstall.py: (AutoInstaller): Added prepend_to_search_path argument to be able to prefer autoinstalled package to system package. (AutoInstaller.__init__): (AutoInstaller._set_up_target_dir): (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too. (AutoInstaller._prepare_package): (AutoInstaller._extract_targz): Renamed to _extract_tar. * Scripts/webkitpy/thirdparty/__init__.py: (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0. 2015-03-05 Lukasz Bialek [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked https://bugs.webkit.org/show_bug.cgi?id=131162 Reviewed by Gyuyoung Kim. * MiniBrowser/efl/main.c: (on_download_request): (on_download_finished): (on_download_failed): (window_create): Adapt download callbacks to new callback mechanism 2015-03-05 Carlos Garcia Campos Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927. In r180927 we updated the libsoup version used by the jhbuild. In this new version the sniffer uses image/x-icon instead of image/vnd.microsoft.icon for blank.ico resource. * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: (testWebResourceMimeType): 2015-03-05 Carlos Garcia Campos [SOUP] Check TLS errors as soon as they are set in the SoupMessage https://bugs.webkit.org/show_bug.cgi?id=142244 Reviewed by Sergio Villar Senin. Check that the SSL server doesn't process any request in case of TLS errors when the policy is set to FAIL. * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: (testTLSErrorsPolicy): (testTLSErrorsRedirect): (testTLSErrorsHTTPAuth): (testLoadFailedWithTLSErrors): (testSubresourceLoadFailedWithTLSErrors): (httpsServerCallback): 2015-03-05 Pawel Forysiuk [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty() https://bugs.webkit.org/show_bug.cgi?id=141154 Reviewed by Jer Noble. Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default. For the sake of completeness WebKitTestRunner should specify temporary folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc. Default non legacy paths are set up in ProcessPoolConfiguration constructor. They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation to get data storage paths. Only Mac port has an actual implementation of it. However, WebKitTestRunner overrides them in favour of unique temporary dir which is taken from libraryPathForTesting(). Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation is not implemented for EFL and GTK ports it returns an empty string. All default data folders besides MediaKeys are overridden in TestRunner code with unique temporary folders derived from DUMPRENDERTREE_TEMP env variable. GTK port does not enable encrypted keys by default so WebMediaKeyStorageManager::initialize() code path is never triggered. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all WebKit ports. 2015-03-05 Csaba Osztrogonác [buildbot] Add regression test to check which builder runs which tests https://bugs.webkit.org/show_bug.cgi?id=142166 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: (BuildStepsConstructorTest.createTest): (BuildStepsTest): (BuildStepsTest.generateTests): (BuildStepsTest.createTest): (BuildStepsTest.createTest.doTest): (BuildStepsTest.test_unnecessary_expected_results): 2015-03-04 Commit Queue Unreviewed, rolling out r181054. https://bugs.webkit.org/show_bug.cgi?id=142320 Broke the api tests (Requested by sundiamonde on #webkit). Reverted changeset: "Fix linker warnings in TestWebKitAPI." https://bugs.webkit.org/show_bug.cgi?id=141912 http://trac.webkit.org/changeset/181054 2015-03-04 Alex Christensen Fix linker warnings in TestWebKitAPI. https://bugs.webkit.org/show_bug.cgi?id=141912 Reviewed by David Kilzer. * TestWebKitAPI/Configurations/Base.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore. 2015-03-04 Alexey Proskuryakov [Mac] Set SystemUIFontSelect in DRT and WKTR https://bugs.webkit.org/show_bug.cgi?id=142303 Reviewed by Myles C. Maxfield. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize): 2015-03-04 Chris Dumez Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=142314 Reviewed by Ryosuke Niwa. Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree to get WK2 code coverage. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-03-04 Alex Christensen Move content extensions test to properly named directory. https://bugs.webkit.org/show_bug.cgi?id=142299 Reviewed by Tim Horton. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformConfigureViewForTest): 2015-03-04 Youenn Fablet W3C test importer should use filesystem instead of os.walk https://bugs.webkit.org/show_bug.cgi?id=142085 Reviewed by Bem Jones-Bey. Added FileSystem.dirs_under to remove the use of os.walk in test importer. Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer. Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under. Made use of FileSystem.dirs_under within TestImporter.find_importable_tests. Added a unit test to check that test importer is now black-box testable using a Mock system. * Scripts/webkitpy/common/system/filesystem.py: (FileSystem.dirs_under): Returns a list of filtered sub-directories. (FileSystem.dirs_under.filter_all): * Scripts/webkitpy/common/system/filesystem_mock.py: (MockFileSystem.dirs_under): (MockFileSystem.dirs_under.filter_all): (MockFileSystem.getsize): * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: (MockFileSystemTest.test_dirs_under): (MockFileSystemTest.test_dirs_under.filter_dir): * Scripts/webkitpy/common/system/filesystem_unittest.py: (RealFileSystemTest.test_sep): (RealFileSystemTest): (RealFileSystemTest.test_dirs_under): (RealFileSystemTest.test_dirs_under.filter_this_dir): * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.do_import): (TestImporter.find_importable_tests.should_keep_subdir): (TestImporter.find_importable_tests): (TestImporter.should_keep_subdir): Deleted. (TestImporter.should_skip_file): Deleted. * Scripts/webkitpy/w3c/test_importer_unittest.py: (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported. 2015-03-04 Timothy Horton [WebEditingTester] Add support for the find and replace bar https://bugs.webkit.org/show_bug.cgi?id=142247 Reviewed by Enrica Casucci. While it's not hooked up yet in WKWebView, adding support for the find bar to WebEditingTester will help us implement that functionality. * WebEditingTester/AppDelegate.h: * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate performTextFinderAction:]): * WebEditingTester/MainMenu.xib: Receive performTextFinderAction: and forward it to the frontmost WebDocumentController. * WebEditingTester/WK2WebDocumentController.m: (-[WK2WebDocumentController awakeFromNib]): (-[WK2WebDocumentController performTextFinderAction:]): (-[WK2WebDocumentController findBarView]): (-[WK2WebDocumentController setFindBarView:]): (-[WK2WebDocumentController isFindBarVisible]): (-[WK2WebDocumentController setFindBarVisible:]): (-[WK2WebDocumentController findBarViewDidChangeHeight]): (-[WK2WebDocumentController layout]): Implement performTextFinderAction: for WebKit2, and have a NSTextFinder pointing at the WKWebView (currently nothing will work, but the bar will show up). Install and uninstall the bar as needed. * WebEditingTester/WebDocument.xib: Don't use a full-size content view. There's no need, and it makes find bar layout harder. * WebEditingTester/WebDocumentController.h: * WebEditingTester/WebDocumentController.m: (-[WebDocumentController performTextFinderAction:]): 2015-03-03 Sam Weinig [Content Extensions] Split parsing and compiling of content extensions into their own files https://bugs.webkit.org/show_bug.cgi?id=142259 Reviewed by Anders Carlsson. Add basic unit test for the content filter compiler. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added. (WebCore::ContentExtensions::operator<<): (TestWebKitAPI::ContentFilterTest::SetUp): (TestWebKitAPI::TEST_F): 2015-03-04 Matthew Mirman Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory https://bugs.webkit.org/show_bug.cgi?id=142230 Reviewed by Csaba Osztrogonác. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (TestFactory): (TestFactory.getProduct): Added (TestFactory.__init__): moved downloader to getProduct (BuildAndTestFactory): (BuildAndTestFactory.getProduct): Added (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end. (BuildAndTestWebKit2Factory): Deleted. Wasn't used anywhere. 2015-03-04 Debarshi Ray [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality https://bugs.webkit.org/show_bug.cgi?id=142225 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewWebContextLifetime): (beforeAll): 2015-03-03 David Kilzer [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name Reviewed by Alexey Proskuryakov. * WebKitTestRunner/TestController.cpp: (WTR::TestController::webProcessName): (WTR::TestController::networkProcessName): - Return the same process name on iOS and Mac because they both use the same process name for local engineering builds. 2015-03-03 David Kilzer check-webkit-style: Add exception for FrameworkSoftLink.h header order Reviewed by Alex Christensen. * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded semi-colons in various places and fix whitespace. (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION constants. (_IncludeState.__init__): Add self._visited_soft_link_section boolean state variable. (_IncludeState.visited_soft_link_section): Getter for self._visited_soft_link_section. (_IncludeState.check_next_include_order): Update state machine for soft-link headers. Add check that soft-link headers always appear last. (_classify_include): Add check for soft-link header type. (check_include_line): Return early if there is a soft-link header error. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (OrderOfIncludesTest.test_public_primary_header): Add tests for including soft-link headers. (OrderOfIncludesTest.test_classify_include): Add test for _SOFT_LINK_HEADER type. 2015-03-03 Alexey Proskuryakov build.webkit.org/dashboard: Don't repeatedly handle each test type https://bugs.webkit.org/show_bug.cgi?id=142211 Reviewed by Tim Horton and Matt Hanson. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted. (Buildbot.prototype.apiTestResultsURLForIteration): Deleted. (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted. (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted. (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted. (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted. Removed functions that build a link to test step results. The buildbot provides these links in JSON. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: (BuildbotIteration): Put failing tests into an array, instead of named variables. (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org. We can easily add them to the map as needed. (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues. (BuildbotIteration.prototype._parseData): Moved code for parsing step results away to BuildbotTestResults class. We used to parse here, build an intermediate data structure, and then build a BuildbotTestResults object, which was strange. (BuildbotIteration.prototype.loadLayoutTestResults): Ditto. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Corrected an unrelated assertion that was buggy, and kept firing. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: (BuildbotTestResults): (BuildbotTestResults.prototype._parseResults.resultSummarizer): (BuildbotTestResults.prototype._parseResults): (BuildbotTestResults.prototype.addFullLayoutTestResults): Moved the code for parsing JSON results for a single step here. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype._testStepFailureDescription): (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures): (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted. (BuildbotTesterQueueView.prototype.update): Deleted. (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted. Updated for the new data structures. One behavior change is that we now display individual counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout test failures, 3 platform api test failures". 2015-03-03 Matthew Mirman JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue. https://bugs.webkit.org/show_bug.cgi?id=142094 Reviewed by Csaba Osztrogonác. * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157 * BuildSlaveSupport/build.webkit.org-config/master.cfg: (TestFactory): (TestFactory.__init__): Made running of JSC tests conditional. (TestAllButJSCFactory): (TestJSCFactory): Added. (TestJSCFactory.__init__): (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2. 2015-03-03 David Kilzer `build-webkit --help` is wrong about how to build for the iOS simulator Reviewed by Csaba Osztrogonác. * Scripts/build-webkit: Fix help. 2015-03-03 Carlos Garcia Campos Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build. * gtk/jhbuild.modules: 2015-03-03 Carlos Garcia Campos [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit https://bugs.webkit.org/show_bug.cgi?id=141508 Reviewed by Sergio Villar Senin. Add a unit test to check that synchronous XHRs load even if the maximum connection limits are reached. * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: (testWebViewSyncRequestOnMaxConns): (serverCallback): (beforeAll): * gtk/jhbuild.modules: Bump libsoup version to 2.49.91. 2015-03-02 Alexey Proskuryakov Update the name of ASan build step. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: 2015-03-02 Jer Noble [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled. https://bugs.webkit.org/show_bug.cgi?id=142121 Reviewed by Simon Fraser. Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies that the initial and final screen rects for the web content are as expected. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added. * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added. (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): (runJavaScriptAlert): (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView): (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView): (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale): (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent): (TestWebKitAPI::FullscreenZoomInitialFrame::runTest): (TestWebKitAPI::TEST_F): 2015-03-01 David Kilzer LayoutTestRealy: Prepend __XPC_ to the key, not the value! Follow-up fix for: LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController _environmentVariables]): Fix think-o. 2015-03-01 David Kilzer LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks Reviewed by Simon Fraser. * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController _environmentVariables]): Add. (-[LTRelayController launchApp]): Use -_environmentVariables. 2015-02-28 David Kilzer [iOS] Stop running webkit-build-directory on every layout test This was originally fixed by David Farler for Bug 135409 in r172602. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't run webkit-build-directory every time it's called. 2015-02-28 Youenn Fablet W3C importer should use filesystem instead of shutil/host https://bugs.webkit.org/show_bug.cgi?id=142012 Reviewed by Bem Jones-Bey. Removed direct use of python shutil and os, except for os.walk which will require its own fix. * Scripts/webkitpy/w3c/test_importer.py: (main): (TestImporter.do_import): (TestImporter.find_importable_tests): (TestImporter.import_tests): (TestImporter.remove_deleted_files): (TestImporter.write_import_log): 2015-02-28 Youenn Fablet W3C test importer should use filesystem to read and write files https://bugs.webkit.org/show_bug.cgi?id=142084 Reviewed by Bem Jones-Bey. Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open(). * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.import_tests): (TestImporter.remove_deleted_files): (TestImporter.write_import_log): 2015-02-27 Sam Weinig Add WebKit2 SPI to create a DOM File object https://bugs.webkit.org/show_bug.cgi?id=142109 Reviewed by Tim Horton. Add a test for WKBundleFileHandleRef. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added. (TestWebKitAPI::didReceiveMessageFromInjectedBundle): (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added. (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest): * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added. 2015-02-27 Michael Saboff Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot https://bugs.webkit.org/show_bug.cgi?id=142112 Reviewed by Filip Pizlo. Added check for VMs in the form of /{DumpRenderTree,webkitTestRunner,jsc} and use as the library path. * Scripts/run-jsc-benchmarks: 2015-02-27 Alex Christensen [WinCairo] Unreviewed build fix. * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props. 2015-02-27 Anders Carlsson Add infrastructure for handling website data in the network process https://bugs.webkit.org/show_bug.cgi?id=142092 Reviewed by Andreas Kling. Add a menu item that will fetch all website data, delete the returned data records, and fetch all website data again so we can confirm that it's all empty. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController fetchAndClearWebsiteData:]): 2015-02-26 Brent Fulgham [Win] Remove remaining SafariTheme cruft https://bugs.webkit.org/show_bug.cgi?id=142075 Reviewed by Anders Carlsson. Remove reference to SafariTheme-switching preference. * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): (prepareConsistentTestingEnvironment): 2015-02-26 Doug Russell AX: Expose caret browsing preference to accessibility API https://bugs.webkit.org/show_bug.cgi?id=141862 Reviewed by Chris Fleizach. Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running). Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events. * DumpRenderTree/AccessibilityUIElement.cpp: (setBoolAttributeValueCallback): (selectedTextMarkerRangeCallback): (resetSelectedTextMarkerRangeCallback): (AccessibilityUIElement::setBoolAttributeValue): (AccessibilityUIElement::selectedTextMarkerRange): (AccessibilityUIElement::resetSelectedTextMarkerRange): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::setBoolAttributeValue): (AccessibilityUIElement::selectedTextMarkerRange): (AccessibilityUIElement::resetSelectedTextMarkerRange): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::selectedTextMarkerRange): (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange): (WTR::AccessibilityUIElement::setBoolAttributeValue): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::setBoolAttributeValue): (WTR::AccessibilityUIElement::selectedTextMarkerRange): (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange): 2015-02-26 Brent Fulgham [Win] Remove WebKitExportGenerator project (and related) https://bugs.webkit.org/show_bug.cgi?id=142035 Reviewed by Dean Jackson. * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a build log from WebKitExportGenerator. 2015-02-26 Csaba Osztrogonác [EFL] Bump EFL version to 1.13.0 https://bugs.webkit.org/show_bug.cgi?id=141708 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: 2015-02-26 Sam Weinig Check in missing WebEditingTester.xcconfig file. * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added. 2015-02-26 Csaba Osztrogonác [webkitpy] Remove skipped file related crufts https://bugs.webkit.org/show_bug.cgi?id=142046 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/port/base.py: (Port.skipped_layout_tests): (Port._tests_from_skipped_file_contents): Deleted. (Port): Deleted. (Port._expectations_from_skipped_files): Deleted. * Scripts/webkitpy/port/mac_unittest.py: (MacTest.test_default_timeout_ms): (MacTest): Deleted. (test_tests_from_skipped_file_contents): Deleted. 2015-02-26 Brent Fulgham [Win] Unreviewed WinCairo build fix after r180653. TestWebKitAPI should know about proper WEBCORE_EXPORT definitions. * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added. * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added. 2015-02-25 Brent Fulgham [Win] Use WEBCORE_EXPORT instead of Definition file https://bugs.webkit.org/show_bug.cgi?id=141734 Reviewed by Alex Christensen. * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: Use a precompiled header so we can define our export macros properly. * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters: Visual studio automatic update stuff. * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props: Set up Precompiled Header use for project.. * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added. * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export declarations for building DumpRenderTree as a client of WebCore/WebKit. 2015-02-25 Mark Lam ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack. Reviewed by Alexey Proskuryakov. ASan does not like the fact that we memcpy the stack for GC scans. So, we're working around this by using our own memcpy (asanUnsafeMemcpy) implementation that we can tell ASan to ignore. Also removed the previous added directive to ignore *tryCopyOtherThreadStack* which isn't effective for working around this issue. * asan/webkit-asan-ignore.txt: 2015-02-25 Benjamin Poulain CodeBlock crashes when dumping op_push_name_scope https://bugs.webkit.org/show_bug.cgi?id=141953 Reviewed by Filip Pizlo. * Scripts/run-jsc-stress-tests: 2015-02-25 Youenn Fablet W3C test importer should use argparse instead of optparse https://bugs.webkit.org/show_bug.cgi?id=142013 Reviewed by Bem Jones-Bey. * Scripts/webkitpy/w3c/test_importer.py: (main): Updating according argparse. (parse_args): Moving from optparse to argparse. 2015-02-25 Brady Eidson Get rid of TestInvocation::pathOrURL https://bugs.webkit.org/show_bug.cgi?id=142021 Reviewed by Tim Horton. The pathOrURL string is a relative path used as an argument to WebKitTestRunner, but most code that uses it expected an absolute path. This gets rid of the member and replaces all uses with a more descriptive "urlContains" method. * WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWebViewSizeForTest): (WTR::TestController::updateWindowScaleForTest): (WTR::shouldUseFixedLayout): (WTR::TestController::updateLayoutTypeForTest): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::TestInvocation): (WTR::TestInvocation::urlContains): (WTR::TestInvocation::shouldLogFrameLoadDelegates): (WTR::TestInvocation::shouldLogHistoryClientCallbacks): (WTR::TestInvocation::invoke): (WTR::shouldLogFrameLoadDelegates): Deleted. (WTR::shouldLogHistoryClientCallbacks): Deleted. * WebKitTestRunner/TestInvocation.h: (WTR::TestInvocation::pathOrURL): Deleted. * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::shouldMakeViewportFlexible): (WTR::TestController::platformConfigureViewForTest): * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::shouldUseThreadedScrolling): (WTR::TestController::platformConfigureViewForTest): 2015-02-25 Brady Eidson Layout test support for user content filters https://bugs.webkit.org/show_bug.cgi?id=142018 Reviewed by Tim Horton. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json file before loading the test itself. 2015-02-24 Sam Weinig Convert WebEditingTester to use xcconfig files https://bugs.webkit.org/show_bug.cgi?id=141879 Reviewed by Darin Adler. Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser. * WebEditingTester/Configurations: Added. * WebEditingTester/Configurations/Base.xcconfig: Added. * WebEditingTester/Configurations/DebugRelease.xcconfig: Added. * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: 2015-02-24 Andy Estes Teach MiniBrowser how to disable per-window web processes https://bugs.webkit.org/show_bug.cgi?id=141988 Reviewed by Darin Adler. * MiniBrowser/mac/AppDelegate.m: (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled. * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): Added a new Settings menu item. (-[SettingsController validateMenuItem:]): Validated the new Settings menu item. (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect. (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults. 2015-02-24 Alexey Proskuryakov Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length https://bugs.webkit.org/show_bug.cgi?id=141889 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: 2015-02-24 Yusuke Suzuki REGRESSION(r179429): Can't type comments in Facebook https://bugs.webkit.org/show_bug.cgi?id=141859 Reviewed by Brent Fulgham. Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): 2015-02-24 Michael Catanzaro Crash loading local file with WebPageProxy::loadAlternateHTMLString https://bugs.webkit.org/show_bug.cgi?id=141867 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can be shared with the new test. (TestWebKitAPI::TEST): Add a cross-platform test for this crash. * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash. (testLoadAlternateHTMLForLocalPage): (beforeAll): 2015-02-24 David Kilzer [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs Reviewed by Myles C. Maxfield. * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: (OTHER_LDFLAGS_BASE): Link to CoreText.framework. * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm. - Rename to share code with iOS. - Add USE(APPKIT) around AppKit-specific headers and code. - Fix a check-webkit-style warning. * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm. - Remove ios/ActivateFontsIOS.mm. - Fix InjectedBundle/cocoa group to represent the directory on disk. Includes a change to InjectedBundlePageCocoa.mm. 2015-02-23 Commit Queue Unreviewed, rolling out r180547 and r180550. https://bugs.webkit.org/show_bug.cgi?id=141957 Broke 10 Windows tests. (Requested by bfulgham_ on #webkit). Reverted changesets: "REGRESSION(r179429): Can't type comments in Facebook" https://bugs.webkit.org/show_bug.cgi?id=141859 http://trac.webkit.org/changeset/180547 "Constructor returning null should construct an object instead of null" https://bugs.webkit.org/show_bug.cgi?id=141640 http://trac.webkit.org/changeset/180550 2015-02-23 Yusuke Suzuki REGRESSION(r179429): Can't type comments in Facebook https://bugs.webkit.org/show_bug.cgi?id=141859 Reviewed by Geoffrey Garen. Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): 2015-02-23 KwangHyuk Kim [EFL] fix eo errors https://bugs.webkit.org/show_bug.cgi?id=141909 Reviewed by Gyuyoung Kim. Fix eo errors that occur whenever minibrowser is launched. - elm_obj_entry_text_style_user_push can only be applied for elm_entry - elm_obj_win_resize_object_add's first parameter should be elm_win * MiniBrowser/efl/main.c: (window_create): 2015-02-23 Ryosuke Niwa Unreviewed build fix after r180535. Removed the test case that wasn't compiling. * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: (TestWebKitAPI::TEST): 2015-02-23 Brent Fulgham WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment https://bugs.webkit.org/show_bug.cgi?id=141935 Reviewed by Myles C. Maxfield. * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few tests for assigning from nullptr. 2015-02-23 Brent Fulgham WTF::WeakPtr should have a 'forget' method. https://bugs.webkit.org/show_bug.cgi?id=141923 Reviewed by Myles C. Maxfield. * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: (TestWebKitAPI::TEST): Added 'Forget' tests case. 2015-02-23 Alexey Proskuryakov build.webkit.org/dashboard CrashOnly queues should not show two green bubbles https://bugs.webkit.org/show_bug.cgi?id=141920 Reviewed by Tim Horton. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Do the same thing as we do for regular green bubbles. 2015-02-23 Alexey Proskuryakov Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch https://bugs.webkit.org/show_bug.cgi?id=141925 Reviewed by Tim Horton. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._presentPopoverForRevisionRange): 2015-02-23 Anders Carlsson Add API for fetching website data records to _WKWebsiteDataStore https://bugs.webkit.org/show_bug.cgi?id=141926 Reviewed by Beth Dakin. * MiniBrowser/mac/MainMenu.xib: * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController fetchWebsiteData:]): Add menu item to fetch and dump website data. 2015-02-23 David Kilzer [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/port/leakdetector.py: (LeakDetector._callstacks_to_exclude_from_leaks): Remove snowleopard, lion and older leaks. Add known leak for mavericks, but check Port.operating_system before calling Port.is_mavericks. * Scripts/webkitpy/port/mac.py: (MacPort.is_snowleopard): Delete. (MacPort.is_lion): Delete. (MacPort.is_mavericks): Add. 2015-02-23 Alexey Proskuryakov build.webkit.org/dashboard should filter out commits to other branches https://bugs.webkit.org/show_bug.cgi?id=140362 Reviewed by Tim Horton. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._presentPopoverForPendingCommits): (BuildbotQueueView.prototype._presentPopoverForRevisionRange): (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): (BuildbotQueueView.prototype.revisionContentForIteration): (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted. (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted. (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js: (Trac.prototype.get oldestRecordedRevisionNumber): (Trac.prototype.commitsOnBranch): (Trac.prototype._xmlTimelineURL): (Trac.prototype._convertCommitInfoElementToObject): (Trac.prototype._update): (Trac.prototype.startPeriodicUpdates): (Trac.prototype.loadMoreHistoricalData): (Trac.prototype.update): Deleted. 2015-02-21 Youenn Fablet Tests don't work on some bots: Failed to stop wptwk https://bugs.webkit.org/show_bug.cgi?id=141235 Reviewed by Ryosuke Niwa. Logging of server subprocesses in launcher script. Killing of server subprocesses when stopping/before starting. Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (WebPlatformTestServer.__init__): (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher. (WebPlatformTestServer): (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process. (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file. (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change. (TestWebPlatformTestServer): (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file. 2015-02-20 Timothy Horton [WebEditingTester] Allow dropping HTML files on the app https://bugs.webkit.org/show_bug.cgi?id=141834 Reviewed by Simon Fraser. * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate openDocument:]): (-[WebEditingAppDelegate application:openFile:]): Implement application:openFile:, factoring file loading code out of openDocument. * WebEditingTester/Info.plist: Register as an editor for HTML files. * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Enrica is not an organization. 2015-02-20 Timothy Horton [WebEditingTester] Expand "WK" to "WebKit" in a few places https://bugs.webkit.org/show_bug.cgi?id=141833 Reviewed by Anders Carlsson. * WebEditingTester/AppDelegate.h: * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate newEditor:]): (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]): (-[WebEditingAppDelegate validateMenuItem:]): (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]): (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted. (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted. (-[WebEditingAppDelegate showOperations:]): Deleted. * WebEditingTester/MainMenu.xib: The WK abbreviation is unnaturally grating in menu items for some reason. 2015-02-20 Timothy Horton [WebEditingTester] Add a custom protocol for loading canned content https://bugs.webkit.org/show_bug.cgi?id=141830 Reviewed by Enrica Casucci. Add a canned:// protocol handler, which can be used to emulate behaviors in WebKit client apps (like Mail) that use custom protocol handlers, which can have important effects on editing (mostly, the URLs are only valid inside of the client application, but not when copied/dragged out). For now, we only support two canned files: canned://dice is a PNG of dice (stolen from LayoutTests/) canned://text is the string "canned text" served as text/html In the future we could support things like very large (generated) files, progressive loading, etc. to further simulate conditions in other apps. * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Register the protocol with CFNetwork, and the scheme with WebKit2. * WebEditingTester/Canned Content/dice.png: Added. * WebEditingTester/CannedContent.h: Added. * WebEditingTester/CannedContent.m: Added. (-[CannedContent initWithRequest:cachedResponse:client:]): (+[CannedContent canonicalRequestForRequest:]): (+[CannedContent canInitWithRequest:]): We only want to handle canned:// URLs. (-[CannedContent startLoading]): For now, immediately load the two files we know about. Otherwise, immediately fail the load. (-[CannedContent stopLoading]): * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: 2015-02-20 Timothy Horton [WebEditingTester] Implement an open panel https://bugs.webkit.org/show_bug.cgi?id=141829 Reviewed by Simon Fraser. * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]): (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]): (-[WebEditingAppDelegate openDocument:]): Add an open panel (with radio buttons to pick which WebKit to open with). Loads the file as an HTML string. 2015-02-20 Simon Fraser [WebEditingTester] @properties, dot syntax, and remember the window position https://bugs.webkit.org/show_bug.cgi?id=141843 Reviewed by Tim Horton. Modernize a bit with more dot syntax, use @property for the web views, and give the main window an Autosave name so it remembers the widow position. * WebEditingTester/WK1WebDocumentController.m: (-[WK1WebDocumentController awakeFromNib]): (-[WK1WebDocumentController loadHTMLString:]): * WebEditingTester/WK2WebDocumentController.m: (-[WK2WebDocumentController awakeFromNib]): * WebEditingTester/WebDocument.xib: 2015-02-20 Timothy Horton [WebEditingTester] Hook up key equivalents for new window action https://bugs.webkit.org/show_bug.cgi?id=141828 Reviewed by Enrica Casucci. * WebEditingTester/AppDelegate.h: * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate applicationDidFinishLaunching:]): (-[WebEditingAppDelegate newEditor:]): (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]): (-[WebEditingAppDelegate toggleUseWK2ByDefault:]): (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]): (defaultConfiguration): Deleted. (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted. Move WKWebViewConfiguration setup into WK2WebDocumentController. Remove unused application termination code. Update new-window menu item key equivalents when launching and when changing the use-WebKit2-by-default setting. Make WebDocumentController subclasses all initialized the same way, and use that to factor out alloc/init. Rename loadContent to loadHTMLString for future use. * WebEditingTester/MainMenu.xib: Add default key equivalents. Cmd-N will always make the default kind of window (controlled by the pref). Cmd-Opt-N will always make the other kind. The menu items are configured as alternates so they only show up if you press alt (just like in MiniBrowser). * WebEditingTester/WK1WebDocumentController.m: (-[WK1WebDocumentController loadHTMLString:]): (-[WK1WebDocumentController loadContent]): Deleted. * WebEditingTester/WK2WebDocumentController.h: * WebEditingTester/WK2WebDocumentController.m: (defaultConfiguration): (-[WK2WebDocumentController awakeFromNib]): (-[WK2WebDocumentController loadHTMLString:]): (-[WK2WebDocumentController initWithConfiguration:]): Deleted. (-[WK2WebDocumentController dealloc]): Deleted. * WebEditingTester/WebDocumentController.h: * WebEditingTester/WebDocumentController.m: (-[WebDocumentController init]): (-[WebDocumentController initWithWindow:]): (+[WebDocumentController defaultEditingSource]): (-[WebDocumentController loadHTMLString:]): (-[WebDocumentController windowDidLoad]): Deleted. (-[WebDocumentController defaultEditingSource]): Deleted. (-[WebDocumentController applicationTerminating]): Deleted. (-[WebDocumentController loadContent]): Deleted. 2015-02-20 Timothy Horton [WebEditingTester] ARC-ify WebEditingTester https://bugs.webkit.org/show_bug.cgi?id=141827 Reviewed by Sam Weinig. * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate showOperations:]): * WebEditingTester/EditingOperations.m: (editingOperations): * WebEditingTester/WK1WebDocumentController.m: (-[WK1WebDocumentController dealloc]): Deleted. * WebEditingTester/WK2WebDocumentController.m: (-[WK2WebDocumentController dealloc]): Deleted. * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Turn on ARC and remove a few retain/release/autorelease calls. We don't need to implement dealloc in either document controller because WebView and WKWebView's UIDelegate property does not hold a strong reference. 2015-02-20 Timothy Horton [WebEditingTester] Factor out list of editing operations https://bugs.webkit.org/show_bug.cgi?id=141826 Reviewed by Sam Weinig. * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate showOperations:]): * WebEditingTester/EditingOperations.h: Added. * WebEditingTester/EditingOperations.m: Added. (editingOperations): * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Move EditingOperations array to its own file, and make it an NSArray instead of a C array. Adjust accordingly in showOperations:. 2015-02-20 Michael Saboff DFG JIT needs to check for stack overflow at the start of Program and Eval execution https://bugs.webkit.org/show_bug.cgi?id=141676 Reviewed by Filip Pizlo. Set the newly added --maximumEvalCacheableSourceLength option for eager test runs. This is needed to allow the eval out of stack tests to tier up. Without this option, we don't cache the likely large string expression that we want to eval. * Scripts/run-jsc-stress-tests: 2015-02-19 Daniel Bates REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run https://bugs.webkit.org/show_bug.cgi?id=141815 Reviewed by Simon Fraser. Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it was booted by iOS Simulator in a previous run of run-webkit-test. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run(). (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps(). 2015-02-19 David Kilzer check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files Reviewed by Alex Christensen. * Scripts/webkitpy/style/checkers/cpp.py: (_IncludeState.check_next_include_order): Don't emit a warning if the primary header exists and the source file name ends with "SoftLink.cpp". Add 'filename' argument to method. (check_include_line): Pass in 'filename'. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (OrderOfIncludesTest.test_check_next_include_order__no_config): (OrderOfIncludesTest.test_check_next_include_order__no_self): (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): (OrderOfIncludesTest.test_check_next_include_order__other_then_config): (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): - Add test filename arguments for calls to check_next_include_order(). (OrderOfIncludesTest.test_primary_header): Add test for a file name ending in "SoftLink.cpp". 2015-02-18 Enrica Casucci Add new tool to test editable Webviews. https://bugs.webkit.org/show_bug.cgi?id=141772 Reviewed by Tim Horton. Adding WebEditingTester, a Cocoa application to test WK1 and Wk2 views in editable mode. * WebEditingTester: Added. * WebEditingTester/AppDelegate.h: Added. * WebEditingTester/AppDelegate.m: Added. (-[WebEditingAppDelegate init]): (defaultConfiguration): (-[WebEditingAppDelegate applicationDidFinishLaunching:]): (-[WebEditingAppDelegate applicationWillTerminate:]): (-[WebEditingAppDelegate newEditor:]): (-[WebEditingAppDelegate showOperations:]): (-[WebEditingAppDelegate useWebKit2ByDefault]): (-[WebEditingAppDelegate toggleUseWK2ByDefault:]): (-[WebEditingAppDelegate validateMenuItem:]): * WebEditingTester/Info.plist: Added. * WebEditingTester/MainMenu.xib: Added. * WebEditingTester/WK1WebDocumentController.h: Added. * WebEditingTester/WK1WebDocumentController.m: Added. (-[WK1WebDocumentController awakeFromNib]): (-[WK1WebDocumentController loadContent]): (-[WK1WebDocumentController dealloc]): (-[WK1WebDocumentController pasteAsMarkup:]): * WebEditingTester/WK2WebDocumentController.h: Added. * WebEditingTester/WK2WebDocumentController.m: Added. (-[WK2WebDocumentController initWithConfiguration:]): (-[WK2WebDocumentController pasteAsMarkup:]): (-[WK2WebDocumentController awakeFromNib]): (-[WK2WebDocumentController dealloc]): (-[WK2WebDocumentController loadContent]): * WebEditingTester/WebDocument.xib: Added. * WebEditingTester/WebDocumentController.h: Added. * WebEditingTester/WebDocumentController.m: Added. (-[WebDocumentController initWithWindow:]): (-[WebDocumentController windowDidLoad]): (-[WebDocumentController defaultEditingSource]): (-[WebDocumentController applicationTerminating]): (-[WebDocumentController loadContent]): * WebEditingTester/WebEditingTester.xcodeproj: Added. * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added. * WebEditingTester/main.m: Added. (main): 2015-02-18 Csaba Osztrogonác Run JSC tests on ARM EFL bots https://bugs.webkit.org/show_bug.cgi?id=141165 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunJavaScriptCoreTests.countFailures): (RunRemoteJavaScriptCoreTests): (RunRemoteJavaScriptCoreTests.start): (BuildAndRemoteJSCTestsFactory): (BuildAndRemoteJSCTestsFactory.__init__): 2015-02-18 Alexey Proskuryakov Streamline unexported function build fixes https://bugs.webkit.org/show_bug.cgi?id=141761 Reviewed by Alex Christensen. * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted. We don't need to ignore symbols that are not exported due to the .unexp file. 2015-02-18 Timothy Horton Remove more references to WebCore.exp.in https://bugs.webkit.org/show_bug.cgi?id=141747 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: (ShouldBuildTest): 2015-02-17 Myles C. Maxfield Windows test results should not fall back to mac-mountainlion after r180176 https://bugs.webkit.org/show_bug.cgi?id=141719 Reviewed by Brent Fulgham. * BuildSlaveSupport/build.webkit.org-config/wkbuild.py: (_should_file_trigger_build): * Scripts/webkitpy/port/win.py: (WinPort.default_baseline_search_path): * Scripts/webkitpy/port/win_unittest.py: (WinPortTest.test_baseline_search_path): 2015-02-17 Daniel Bates [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests https://bugs.webkit.org/show_bug.cgi?id=141718 Reviewed by Alex Christensen. We should only run layout tests if simctl can successfully boot and shutdown the testing device. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed(). Log a error and return False if we are unable to boot the simulator device so that the caller can take appropriate action, say exit(3) before running any layout tests. * Scripts/webkitpy/xcode/simulator.py: (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device with the specified UDID. (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device with the specified UDID can successfully boot and shut down. We make at most two attempts to boot and shut down the device, erasing the device between tries so as to restore the device to a known good state. 2015-02-17 Daniel Bates run_webkit_tests.py should not know about iOS Simulator details https://bugs.webkit.org/show_bug.cgi?id=141711 Reviewed by Alex Christensen. Run_webkit_tests.py should only parse the iOS-specific command line options --runtime and --device-type. Let the port-specific logic in ios.py validate the parsed options and instantiate internal data structures. Currently run_webkit_tests.py parses the iOS-specific command line options --runtime and --device-type, validates them, and instantiates internal data structures from the parsed strings. Instead the validation logic and instantiation of internal data structures should be handled by the iOS port object. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options): Remove logic to validate --runtime and --device-type and instantiate internal data structures for them. * Scripts/webkitpy/port/driver.py: (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type, respectively. * Scripts/webkitpy/port/ios.py: Sort the list of imports. (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime object from --runtime, if specified. Otherwise, instantiates a Runtime object for the latest installed iphonesimulator SDK version. (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType object from --device-type, if specified. Otherwise, instantiates a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit machine, respectively. (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator runtime is available to use. (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type and simulator_runtime for the iOS Simulator device type and runtime, respectively. * Scripts/webkitpy/xcode/simulator.py: (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier() with a runtime identifier for the specified iOS version. 2015-02-17 Dana Burkart ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack https://bugs.webkit.org/show_bug.cgi?id=141672 Reviewed by David Kilzer. * asan/webkit-asan-ignore.txt: 2015-02-17 Alex Christensen Remove WebCore.exp.in and clean up. https://bugs.webkit.org/show_bug.cgi?id=141491 Reviewed by Andreas Kling. * Scripts/sort-export-file: Removed. * Scripts/webkitpy/style/checker.py: (_all_categories): (FileType): (CheckerDispatcher._file_type): (CheckerDispatcher._create_checker): Don't check if the export files are sorted. * Scripts/webkitpy/style/checkers/exportfile.py: Removed. * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed. 2015-02-17 Carlos Garcia Campos Unreviewed. Fix GTK+ make distcheck. Do not exclude bmalloc directory from the tarball. * gtk/manifest.txt.in: 2015-02-17 Carlos Garcia Campos Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214. I forgot to add the return of a bool function. * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: (WebKitDOMNodeTest::testDOMCache): 2015-02-17 Carlos Garcia Campos [GTK] GObject DOM bindings object are cached forever https://bugs.webkit.org/show_bug.cgi?id=141558 Reviewed by Sergio Villar Senin. Add checks for all DOM objects to ensure they are not leaked. Also add a dedicated test for the DOM Object Cache. * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: (WebKitDOMNodeFilterTest::testTreeWalker): (WebKitDOMNodeFilterTest::testNodeIterator): * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: (WebKitDOMNodeTest::testHierarchyNavigation): (WebKitDOMNodeTest::testInsertion): (WebKitDOMNodeTest::testTagNames): (WebKitDOMNodeTest::testDOMCache): (registerTests): * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult): (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative): (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom): * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: (testWebKitDOMObjectCache): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (documentLoadedCallback): 2015-02-16 Carlos Garcia Campos [GTK] WebKitFrame objects are never released https://bugs.webkit.org/show_bug.cgi?id=141641 Reviewed by Martin Robinson. Add a way to check GObjects leaks for WebProcess tests and check WebKitFrame objects are not leaked. * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: (WebKitFrameTest::testMainFrame): (WebKitFrameTest::testURI): (WebKitFrameTest::testJavaScriptContext): * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: (WebProcessTest::assertObjectIsDeletedWhenTestFinishes): (runTest): * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: 2015-02-16 Tim Horton Fix the MiniBrowser build with newer clang * MiniBrowser/mac/SettingsController.m: (-[SettingsController _toggleBooleanDefault:]): * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController windowWillClose:]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController windowWillClose:]): NSApp is id and clang gets confused about which -delegate we're talking about. 2015-02-16 Antti Koivisto Develop/Disable Caches does not properly disable disk cache https://bugs.webkit.org/show_bug.cgi?id=141636 Reviewed by Anders Carlsson. Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to the network process too. This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::setCacheModel): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Forward to TestController. (WTR::TestRunner::setCacheModel): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 2015-02-16 Andrzej Badowski Unreviewed. Add myself as a committer. * Scripts/webkitpy/common/config/contributors.json: 2015-02-15 David Kilzer REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols * Scripts/check-for-weak-vtables-and-externals: Ignore weak externals in Source/WebCore/Configurations/WebCore.unexp when building with Xcode 5.x. (readXcode5SymbolsToIgnore): Add. 2015-02-15 KwangHyuk Kim [EFL] fix Evas GL engine error. https://bugs.webkit.org/show_bug.cgi?id=141621 Reviewed by Gyuyoung Kim. As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set. * MiniBrowser/efl/main.c: (elm_main): 2015-02-14 Csaba Osztrogonác [buildbot] Enable run-api-tests on release Mac bots https://bugs.webkit.org/show_bug.cgi?id=141518 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunUnitTests): (BuildFactory.__init__): (TestFactory.__init__): (BuildAndTestFactory.__init__): (RunUnitTests.start): Deleted. (unitTestsSupported): Deleted. 2015-02-13 Anders Carlsson Add a move constructor and move assignment operator to Deque https://bugs.webkit.org/show_bug.cgi?id=141571 Reviewed by Andreas Kling. * TestWebKitAPI/Tests/WTF/Deque.cpp: (TestWebKitAPI::TEST): 2015-02-13 Csaba Osztrogonác run-jsc-stress-tests --remote should skip profiler tests https://bugs.webkit.org/show_bug.cgi?id=141470 Reviewed by Filip Pizlo. * Scripts/run-jsc-stress-tests: 2015-02-13 Anders Carlsson Add an initializer list constructor to Deque https://bugs.webkit.org/show_bug.cgi?id=141565 Reviewed by Andreas Kling. * TestWebKitAPI/Tests/WTF/Deque.cpp: (TestWebKitAPI::TEST): 2015-02-13 Csaba Osztrogonác [buildbot] Remove buildJSCTool cruft from master.cfg https://bugs.webkit.org/show_bug.cgi?id=141513 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunJavaScriptCoreTests): (RunJavaScriptCoreTests.start): (RunWebKitTests): (RunWebKitTests.start): (TestFactory.__init__): (TestLeaksFactory.__init__): (RunJavaScriptCoreTests.__init__): Deleted. (RunWebKitTests.__init__): Deleted. 2015-02-13 Csaba Osztrogonác Unreviewed, remove empty directories. * DumpRenderTree/gtk: Removed. * DumpRenderTree/gtk/fonts: Removed. * DumpRenderTree/unix: Removed. * DumpRenderTree/unix/TestNetscapePlugin: Removed. * GtkLauncher: Removed. * TestWebKitAPI/Tests/WebKitGtk: Removed. * TestWebKitAPI/Tests/WebKitGtk/resources: Removed. * WebKitTestRunner/WebKitTestRunnerAppTests: Removed. * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed. 2015-02-13 Csaba Osztrogonác Remove Windows cruft from Tools/Scripts/build-webkittestrunner https://bugs.webkit.org/show_bug.cgi?id=141519 Reviewed by Alexey Proskuryakov. * Scripts/build-webkittestrunner: 2015-02-12 Alex Christensen Removed empty directory. * WinCELauncher: Removed. 2015-02-12 Csaba Osztrogonác run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux https://bugs.webkit.org/show_bug.cgi?id=141202 Reviewed by Darin Adler. * Scripts/run-jsc-stress-tests: 2015-02-12 Brent Fulgham [Win] Test bot infrastructure should not try to find/use old Safari DLLs https://bugs.webkit.org/show_bug.cgi?id=141517 Reviewed by Anders Carlsson. We do not need to locate or use the DLL's that came with Safari, so stop failing when we cannot find them. Also remove some old Qt cruft from this script. * BuildSlaveSupport/built-product-archive: (archiveBuiltProduct): (extractBuiltProduct): 2015-02-11 Brent Fulgham [Win] [64-bit] Work around MSVC2013 Runtime Bug https://bugs.webkit.org/show_bug.cgi?id=141498 Reviewed by Anders Carlsson. Disable FMA3 instruction use in the MSVC math library to work around a VS2013 runtime crash. We can remove this workaround when we switch to VS2015. * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to disable FMA3 support. * DumpRenderTree/win/DumpRenderTree.cpp: Ditto. * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto. * DumpRenderTree/win/TestRunnerWin.cpp: Ditto. * Scripts/webkitperl/httpd.pm: Ditto. * TestWebKitAPI/win/main.cpp: Ditto. * WinLauncher/Common.cpp: Ditto. * win/DLLLauncher/DLLLauncherMain.cpp: Ditto. 2015-02-12 Csaba Osztrogonác run-jsc-stress-tests should accept remote host config from JSON file https://bugs.webkit.org/show_bug.cgi?id=141509 Reviewed by Michael Saboff. * Scripts/run-javascriptcore-tests: (runJSCStressTests): * Scripts/run-jsc-stress-tests: 2015-02-12 Carlos Garcia Campos [GTK] Add API to allow overriding the default color chooser implementation https://bugs.webkit.org/show_bug.cgi?id=98935 Reviewed by Gustavo Noronha Silva. Add a color chooser implementation for MiniBrowser using GtkPopover when the GTK+ version is recent enough. And a test case to check the new color chooser API. * MiniBrowser/gtk/BrowserWindow.c: (colorChooserRGBAChanged): (popoverColorClosed): (colorChooserRequestFinished): (runColorChooserCallback): (browserWindowConstructed): * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: (testWebViewColorChooserRequest): (beforeAll): 2015-02-11 Csaba Osztrogonác Make run-jsc-stress-tests --remote work with make-based runner https://bugs.webkit.org/show_bug.cgi?id=141079 Reviewed by Darin Adler. * Scripts/run-javascriptcore-tests: (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments. * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner, except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner to avoid code duplication. 2015-02-11 Csaba Osztrogonác run-jsc-stress tests should detect the number of processors on the remote machine too https://bugs.webkit.org/show_bug.cgi?id=141196 Reviewed by Darin Adler. * Scripts/run-javascriptcore-tests: (runJSCStressTests): Pass through the --child-processes argument. * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function to detect the number of local and remote processors with the same algorithm. Additionally introduced $numChildProcesses to emphasize it isn't necessarily same as $numProcessors. 2015-02-11 Csaba Osztrogonác run-jsc-stress-tests should pass JSC_timeout to remote hosts https://bugs.webkit.org/show_bug.cgi?id=141164 Reviewed by Darin Adler. Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one. * Scripts/run-jsc-stress-tests: 2015-02-11 Carlos Garcia Campos [GTK] Add default color chooser implementation using GtkColorChooserDialog https://bugs.webkit.org/show_bug.cgi?id=141392 Reviewed by Gustavo Noronha Silva. Enable INPUT_TYPE_COLOR by default for GTK+ port. * Scripts/webkitperl/FeatureList.pm: 2015-02-09 Csaba Osztrogonác run-jsc-stress-tests shell test runner should run tests in fixed order https://bugs.webkit.org/show_bug.cgi?id=141383 Reviewed by Darin Adler. * Scripts/jsc-stress-test-helpers/shell-runner.sh: 2015-02-08 Chris Fleizach AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events https://bugs.webkit.org/show_bug.cgi?id=140485 Reviewed by Anders Carlsson. Implement takeFocus() as a way to set focus through accessibility wrappers. * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::takeFocus): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::takeFocus): 2015-02-08 Darin Adler Remove the SVG instance tree https://bugs.webkit.org/show_bug.cgi?id=140602 Reviewed by Dean Jackson. * Scripts/check-for-global-initializers: Removed special case for SVGElementInstance.o. 2015-02-07 David Kilzer [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable Reviewed by Daniel Bates. * Scripts/webkitpy/xcode/simulator.py: (Simulator): Add unavailable_version_re precompiled regex. (Simulator._parse_devices): Check for unavailable versions and ignore them if found when parsing the output of `xcrun simctl list`. * Scripts/webkitpy/xcode/simulator_unittest.py: (test_unavailable_devices): Add test with output from `xcrun simctl list` with unavailable runtimes that fails before the fix. 2015-02-07 Chris Dumez Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions https://bugs.webkit.org/show_bug.cgi?id=141321 Reviewed by Darin Adler. Use new Vector::removeFirstMatching() / removeAllMatching() methods. 2015-02-07 David Kilzer [iOS] Make Simulator class testable Rubber-stamped by Darin Adler. * Scripts/webkitpy/common/system/platforminfo.py: (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list` command to here from Simulator.refresh() in xcode/simulator.py so that the output of the command can be mocked. * Scripts/webkitpy/common/system/platforminfo_mock.py: (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list to None. (MockPlatformInfo.xcode_simctl_list): Add method that returns self.expected_xcode_simctl_list expectation. * Scripts/webkitpy/xcode/simulator.py: Add missing copyright and license header. (Simulator.__init__): Add optional 'host' parameter to make it possible to pass in a mock object for testing. Set self._host to 'host' parameter or create Host() object. (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list() method. * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test for current code. (SimulatorTest): (SimulatorTest.setUp): (SimulatorTest._set_expected_xcrun_simctl_list): (SimulatorTest.test_simulator_device_types): (test_invalid_device_types_header): (test_invalid_runtimes_header): (test_invalid_devices_header): 2015-02-07 Csaba Osztrogonác run-jsc-stress-tests --remote should use the default ssh port https://bugs.webkit.org/show_bug.cgi?id=141287 Reviewed by Darin Adler. * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number. 2015-02-06 Dana Burkart dashboard: BuildbotTesterQueueView crashesOnly logic is wrong https://bugs.webkit.org/show_bug.cgi?id=141349 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): (BuildbotTesterQueueView.prototype.update): 2015-02-06 Alexey Proskuryakov Report network process crashes during layout tests https://bugs.webkit.org/show_bug.cgi?id=139646 Reviewed by Anders Carlsson. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): (WTR::TestController::networkProcessName): (WTR::TestController::networkProcessDidCrash): * WebKitTestRunner/TestController.h: 2015-02-06 Csaba Osztrogonác run-jsc-stress-tests --remote should create remote directory before copying the bundle https://bugs.webkit.org/show_bug.cgi?id=141329 Reviewed by Michael Saboff. * Scripts/run-jsc-stress-tests: 2015-02-06 Carlos Garcia Campos [GTK] Remove WebKitWebView::close-notification signal https://bugs.webkit.org/show_bug.cgi?id=141330 Reviewed by Gustavo Noronha Silva. Update notifications unit tests according to the API changes, and add a test case to check that onclose event is fired when a notification is closed by the user. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewNotification): 2015-02-05 Alexey Proskuryakov Dashboard doesn't consider building ASan a productive step https://bugs.webkit.org/show_bug.cgi?id=141312 Reviewed by Simon Fraser. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: 2015-02-05 Daniel Bates [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime https://bugs.webkit.org/show_bug.cgi?id=141306 Reviewed by Alexey Proskuryakov. The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object corresponding to the last-most runtime parsed from the output of `simctl list` for any non- existent runtime. * Scripts/webkitpy/xcode/simulator.py: (Runtime.from_identifier): 2015-02-05 Daniel Bates LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app https://bugs.webkit.org/show_bug.cgi?id=139746 Reviewed by Alexey Proskuryakov. Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app if the simulator device is not in state Booted. Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after launching/relaunching the iOS Simulator app and a simulator app can only be installed on a device that is in the Booted state. LayoutTestRelay may run before the device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app. We should defer executing LayoutTestRelay until the simulator device booted by iOS Simulator is in the Booted state. * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing Simulator methods with the module name, simulator. (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state before launching iOS Simulator to boot it. (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator. (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory(). * Scripts/webkitpy/xcode/simulator.py: (Device.__init__): Remove parameter state and an instance variable of the same name, which represented the state of the device when we created this object as part of parsing the output of `simctl list`. Callers interested in the state of the device are more likely interested in the current state of the device as opposed to the state of the device when the Device object was created. (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device. (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called from both this function and Simulator.device_state(). (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function. (Simulator.DeviceState): Added; class of constants. (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified device is in the specified state. (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file. (Simulator.device_directory): Added. (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it. 2015-02-05 Alexey Proskuryakov Disable retries on Mac debug testers https://bugs.webkit.org/show_bug.cgi?id=141296 Reviewed by Simon Fraser. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-02-05 Dan Bernstein Need a way to force $xcodeSDK in webkitdirs.pm https://bugs.webkit.org/show_bug.cgi?id=141291 Reviewed by Anders Carlsson. * Scripts/webkitdirs.pm: (setXcodeSDK): Added. 2015-02-05 Youenn Fablet and Xabier Rodriguez Calvar [Streams API] Implement a barebone ReadableStream interface https://bugs.webkit.org/show_bug.cgi?id=141045 Reviewed by Benjamin Poulain. * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch. 2015-02-04 Joseph Pecoraro filter-build-webkit: reduce more unfiltered output https://bugs.webkit.org/show_bug.cgi?id=141282 Reviewed by Daniel Bates. * Scripts/filter-build-webkit: Report CompileDTraceScript and Preprocess lines as successful. 2015-02-04 Dana Burkart Botwatcher's Dashboard is cramped https://bugs.webkit.org/show_bug.cgi?id=140273 Reviewed by Alexey Proskuryakov. Add a heading key which will allow for arbitrary headings in builder queues. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): (BuildbotBuilderQueueView.prototype.update): (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: (BuildbotIteration.prototype._parseData): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js: (BuildbotLeaksQueueView.prototype.update): (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js: (BuildbotPerformanceQueueView.prototype.update): (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._unauthorizedAccess): (BuildbotQueueView.prototype._appendBuild): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: (BuildbotTestResults): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): (BuildbotTesterQueueView.prototype.update): (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted. 2015-02-04 Simon Fraser WKTR should not use -mainScreen to pick a color profile https://bugs.webkit.org/show_bug.cgi?id=141265 Reviewed by Tim Horton. -[NSScreen mainScreen] depends on the active window, so use the first screen (which is the one we put the window on anyway). Do some cleanup in DRT that makes the code look similar. * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::PlatformWebView): 2015-02-04 Simon Fraser LayoutTestHelper should set the color profile of all displays https://bugs.webkit.org/show_bug.cgi?id=141260 Reviewed by Tim Horton. WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen. which is the screen with the active window. Make things more robust by changing the colorspace of all displays, not just the main screen, when running layout tests. * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC * DumpRenderTree/mac/LayoutTestHelper.m: (originalColorProfileURLs): (colorProfileURLForDisplay): (displayUUIDStrings): (saveDisplayColorProfiles): (setDisplayColorProfile): (restoreDisplayColorProfiles): (installLayoutTestColorProfile): (restoreUserColorProfile): (main): Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not toll-free bridged, sadly). Use the map to restore all profiles on exit. Convert to use more Obj-C types. 2015-02-04 Daniel Bates test-webkitpy fails on Mac without iphoneos SDK https://bugs.webkit.org/show_bug.cgi?id=141255 I inadvertently committed the wrong exception message. Fix up the exception message to instruct a person to install the iOS SDK when it cannot be found. * Scripts/webkitpy/port/ios.py: (IOSPort.determine_full_port_name): 2015-02-04 Youenn Fablet W3C test importer should sort the list of files when generating the w3c-import.log https://bugs.webkit.org/show_bug.cgi?id=141156 Reviewed by Bem Jones-Bey. Sort explicitly the list of imported files written in the w3c-import.log. Removed logging of the import date. * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.write_import_log): 2015-02-04 Daniel Bates test-webkitpy fails on Mac without iphoneos SDK https://bugs.webkit.org/show_bug.cgi?id=141255 Reviewed by David Kilzer and Alexey Proskuryakov. Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should should not require the iphoneos SDK to be installed to run the webkitpy tests. * Scripts/webkitpy/common/system/platforminfo.py: (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if installed. We take advantage of the behavior that xcrun --show-sdk-version only writes to standard output if the SDK is installed to return the empty string if the SDK is not installed. * Scripts/webkitpy/common/system/platforminfo_mock.py: (MockPlatformInfo.xcode_sdk_version): Added. * Scripts/webkitpy/port/ios.py: (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version() to get the version of the iphoneos SDK, if installed. 2015-02-04 Alexey Proskuryakov run-webkit-tests doesn't always capture ASan violation reports https://bugs.webkit.org/show_bug.cgi?id=141231 Reviewed by Darin Adler. * Scripts/webkitpy/port/driver.py: (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided by the driver already (as is the case with ASan violations, which are printed to stderr). (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan report. (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into a separate variable for reporting. 2015-02-03 Ryosuke Niwa [webkitpy] Add platform specific Skipped file mechanism for performance tests https://bugs.webkit.org/show_bug.cgi?id=141152 Reviewed by Csaba Osztrogonác. Support a test-expectation-like syntax in performance tests' skipped files. e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports. * Scripts/webkitpy/port/base.py: (Port.skipped_perf_tests): Implemented the syntax support by a regular expression. * Scripts/webkitpy/port/base_unittest.py: (PortTest.test_skipped_perf_tests): Test the new syntax. 2015-02-04 Alexey Proskuryakov When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green https://bugs.webkit.org/show_bug.cgi?id=141236 Reviewed by Sam Weinig. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js: (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus): 2015-02-04 Chris Dumez Add removeFirst(value) / removeAll(value) methods to WTF::Vector https://bugs.webkit.org/show_bug.cgi?id=141192 Reviewed by Benjamin Poulain. Add API tests for Vector::removeFirst(value) and Vector::removeAll(value). * TestWebKitAPI/Tests/WTF/Vector.cpp: (TestWebKitAPI::TEST): 2015-02-03 Tim Horton Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR https://bugs.webkit.org/show_bug.cgi?id=141217 Reviewed by Sam Weinig. * WebKitTestRunner/TestController.cpp: (WTR::copyWebCryptoMasterKey): (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): (WTR::TestController::ensureViewSupportsOptions): (WTR::TestController::didCommitNavigation): (WTR::TestController::didFinishNavigation): (WTR::TestController::canAuthenticateAgainstProtectionSpace): (WTR::TestController::didReceiveAuthenticationChallenge): (WTR::TestController::decidePolicyForPluginLoad): (WTR::TestController::decidePolicyForNavigationAction): (WTR::TestController::decidePolicyForNavigationResponse): (WTR::TestController::didCommitLoadForFrame): Deleted. (WTR::TestController::didFinishLoadForFrame): Deleted. * WebKitTestRunner/TestController.h: Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.) 2015-02-03 Dhi Aurrahman Unreviewed. Add myself as a committer. * Scripts/webkitpy/common/config/contributors.json: 2015-02-03 Brent Fulgham [Win] Unreviewed test fix. * DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed, so was not matching expected output. 2015-02-03 Youenn Fablet Unreviewed. Moving myself to the committer section at last. * Scripts/webkitpy/common/config/contributors.json: 2015-02-03 Brent Fulgham [Win] Tests fail because DRT reports '(null)' instead of an empty string https://bugs.webkit.org/show_bug.cgi?id=141205 Reviewed by Anders Carlsson. * DumpRenderTree/win/HistoryDelegate.cpp: (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values properly so that we match expected DumpRenderTree output. 2015-02-03 Michael Catanzaro [GTK] TestWebKitAccessibility is not skipped https://bugs.webkit.org/show_bug.cgi?id=141179 Reviewed by Carlos Garcia Campos. Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being skipped, and it apparently works reliably on the bots. * Scripts/run-gtk-tests: (TestRunner): 2015-02-03 Carlos Alberto Lopez Perez run-perf-tests: allow to specify a wrapper command. https://bugs.webkit.org/show_bug.cgi?id=141172 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): Update text to indicate is also valid for WTR. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._parse_args): Add wrapper command. 2015-02-03 Brent Fulgham [Win] Correct version parsing warning in update-webkit https://bugs.webkit.org/show_bug.cgi?id=141200 Reviewed by Anders Carlsson. * Scripts/webkitdirs.pm: (setupAppleWinEnv): Strip out any specific version build level from the Cygwin version information. 2015-02-03 Brent Fulgham [Win] Attempt to improve the reliability of HTTP service https://bugs.webkit.org/show_bug.cgi?id=141191 Reviewed by Darin Adler. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location. (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file when stopping the service doesn't do so on its own (for Windows runs). 2015-02-03 Youenn Fablet Web platform test server should not need to create __init__.py files https://bugs.webkit.org/show_bug.cgi?id=141030 Reviewed by Ryosuke Niwa. W3C TestImporter ensures that copied __init__.py files are not empty. If needed, a comment is inserted in __init__.py files. Added a unit test to check that web-platform-tests tools and scripts python modules can be imported. * Scripts/webkitpy/common/system/filesystem.py: (FileSystem.getsize): * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: (TestWebPlatformTestServer.test_start_cmd): (TestWebPlatformTestServer): (TestWebPlatformTestServer.test_import_web_platform_test_modules): * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.import_tests): 2015-01-26 Youenn Fablet Unreviewed. Moving myself to the committer section. * Scripts/webkitpy/common/config/contributors.json: 2015-02-02 Saam Barati Create tests for JSC's Control Flow Profiler https://bugs.webkit.org/show_bug.cgi?id=141123 Reviewed by Filip Pizlo. * Scripts/run-javascriptcore-tests: (runJSCStressTests): * Scripts/run-jsc-stress-tests: 2015-02-02 Csaba Osztrogonác Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests https://bugs.webkit.org/show_bug.cgi?id=141158 Reviewed by Darin Adler. * Scripts/run-jsc-stress-tests: 2015-02-02 Michael Catanzaro [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q https://bugs.webkit.org/show_bug.cgi?id=141142 Reviewed by Carlos Garcia Campos. * MiniBrowser/gtk/BrowserWindow.c: (browser_window_init): Quit on Ctrl+W or Ctrl+Q 2015-02-01 Youenn Fablet Web platform test server is not always launching properly on Mac EWS bots https://bugs.webkit.org/show_bug.cgi?id=141141 Unreviewed. * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules. 2015-01-31 Sam Weinig Remove even more Mountain Lion support https://bugs.webkit.org/show_bug.cgi?id=141124 Reviewed by Alexey Proskuryakov. * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::attributedStringRangeIsMisspelled): * DumpRenderTree/mac/Configurations/Base.xcconfig: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts): (prepareConsistentTestingEnvironment): * DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): (-[EventSendingController contextClick]): * DumpRenderTree/mac/TextInputController.m: * LayoutTestRelay/Configurations/Base.xcconfig: * LayoutTestRelay/Configurations/DebugRelease.xcconfig: * MiniBrowser/Configurations/Base.xcconfig: * MiniBrowser/Configurations/DebugRelease.xcconfig: * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]): (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]): * TestWebKitAPI/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: (-[DownloadDelegate _downloadDidFinish:]): * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/mac/InjectedBundleControllerMac.mm: (TestWebKitAPI::InjectedBundleController::platformInitialize): * WebKitLauncher/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled): * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts): * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): (WTR::TestController::webProcessName): * WebKitTestRunner/mac/EventSenderProxy.mm: * asan/asan.xcconfig: 2015-01-31 Commit Queue Unreviewed, rolling out r179408. https://bugs.webkit.org/show_bug.cgi?id=141117 This didn't fully fix the issue (Requested by anttik on #webkit). Reverted changeset: "OSObjectPtr does not work with dispatch_data_t on Maverics" https://bugs.webkit.org/show_bug.cgi?id=141081 http://trac.webkit.org/changeset/179408 2015-01-31 Youenn Fablet https://trac.webkit.org/changeset/179439 breaks a python test https://bugs.webkit.org/show_bug.cgi?id=141114 Unreviewed. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests. 2015-01-31 Youenn Fablet Import W3C web platform tests infrastructure https://bugs.webkit.org/show_bug.cgi?id=140934 Reviewed by Ryosuke Niwa. Loading necessary web platform tests modules before launching server. Ensuring that some empty __init__.py files are present and create them if necessary. * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: 2015-01-30 Brent Fulgham [Win] Another unreviewed test fix. Correct copy/paste error in buildbot handling. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__): (LayoutTestApacheHttpd._get_apache_config_file_path): 2015-01-30 Brent Fulgham [Win] Unreviewed test fix. Correct path handling based on failures on test bots to get things running again. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__): (LayoutTestApacheHttpd._get_apache_config_file_path): 2015-01-30 Chris Dumez Unreviewed. Fix Windows build after r179409. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::notifyDone): (TestRunner::queueLoad): 2015-01-30 Chris Dumez Rename shared() static member functions to singleton() for singleton classes. https://bugs.webkit.org/show_bug.cgi?id=141088 Reviewed by Ryosuke Niwa and Benjamin Poulain. Rename shared() static member functions to singleton() for singleton classes as per the recent coding style change. 2015-01-30 Antti Koivisto OSObjectPtr does not work with dispatch_data_t on Maverics https://bugs.webkit.org/show_bug.cgi?id=141081 Reviewed by Pratik Solanki. * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: (TestWebKitAPI::TEST): 2015-01-30 Brent Fulgham [Win] Switch to Apache on Windows https://bugs.webkit.org/show_bug.cgi?id=141060 Reviewed by Alexey Proskuryakov. Update our scripts under Windows (and Cygwin) to locate and use the XAMPP installation of Apache for running tests. * Scripts/run-webkit-httpd: * Scripts/webkitperl/httpd.pm: (getHTTPDPath): (getDefaultConfigForTestDirectory): (getHTTPDConfigPathForTestDirectory): * Scripts/webkitpy/common/system/executive_unittest.py: (ExecutiveTest.serial_test_kill_process): * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__): (LayoutTestApacheHttpd._get_apache_config_file_path): (LayoutTestApacheHttpd._stop_running_server): * Scripts/webkitpy/layout_tests/servers/http_server_base.py: (HttpServerBase._is_server_running_on_all_ports): * Scripts/webkitpy/port/base.py: (Port._apache_config_file_name_for_platform): * Scripts/webkitpy/port/port_testcase.py: (test_apache_config_file_name_for_platform): * Scripts/webkitpy/port/win.py: (WinPort.show_results_html_file): (WinPort._uses_apache): (WinPort): (WinPort._path_to_apache): 2015-01-29 Alexey Proskuryakov Built result takes too long to be compressed on bots https://bugs.webkit.org/show_bug.cgi?id=141056 Reviewed by Daniel Bates. Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger. * BuildSlaveSupport/test-result-archive: (archiveTestResults): 2015-01-29 Sam Weinig Remove support for screen font substitution https://bugs.webkit.org/show_bug.cgi?id=141038 Reviewed by Tim Horton. * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): Remove call to now setScreenFontSubstitutionEnabled() which is a no-op. 2015-01-29 Csaba Osztrogonác Make run-jsc-stress-tests --remote work on Linux too https://bugs.webkit.org/show_bug.cgi?id=141000 Reviewed by Darin Adler. * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl, use bash/dash compatible signal names, use Linux/Mac compatible find options, use bash/dash compatible functions. * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options. 2015-01-29 Csaba Osztrogonác [buildbot] Simplify jscore-test buildstep https://bugs.webkit.org/show_bug.cgi?id=140821 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile. (RunJavaScriptCoreTests.countFailures): Added. (RunJavaScriptCoreTests.commandComplete): Deleted. (RunJavaScriptCoreTests.evaluateCommand): Deleted. (RunJavaScriptCoreTests.getText): Deleted. (RunJavaScriptCoreTests.getText2): Deleted. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated. (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output): (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output): (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output): (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output): 2015-01-29 Csaba Osztrogonác Unreviewed, revert r179337, we don't need this dependency. * efl/install-dependencies: * gtk/install-dependencies: 2015-01-28 Shivakumar JM Unreviewed. Moving myself to the committer section. * Scripts/webkitpy/common/config/contributors.json: 2015-01-28 Csaba Osztrogonác URTBF after r179326, added uuid-dev package as new dependency. * efl/install-dependencies: * gtk/install-dependencies: 2015-01-28 Timothy Horton Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace https://bugs.webkit.org/show_bug.cgi?id=140673 Reviewed by Sam Weinig. * Scripts/dtrace/trace-webkit2-messages.d: Added. Add a DTrace script that outputs a small blob of JSON per message. 2015-01-28 Geoffrey Garen Removed fastMallocForbid / fastMallocAllow https://bugs.webkit.org/show_bug.cgi?id=141012 Reviewed by Mark Hahnenberg. Fixed a test bug I noticed while testing. * DumpRenderTree/JavaScriptThreading.cpp: (stopJavaScriptThreads): Lock the javaScriptThreads lock before accessing javaScriptThreads -- otherwise, you'll ASSERT. 2015-01-28 Dana Burkart asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address https://bugs.webkit.org/show_bug.cgi?id=141015 Reviewed by Alexey Proskuryakov. * asan/asan.xcconfig: 2015-01-28 Sam Weinig Fix the build. * Scripts/copy-webkitlibraries-to-product-directory: 2015-01-28 Lucas Forschler Increase the FileUpload block size in an attempt to improve network performance. Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (UploadBuiltProduct.__init__): 2015-01-28 Dana Burkart Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig https://bugs.webkit.org/show_bug.cgi?id=136765 Reviewed by Alexey Proskuryakov. * DumpRenderTree/mac/Configurations/Base.xcconfig: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * LayoutTestRelay/Configurations/Base.xcconfig: * LayoutTestRelay/Configurations/DebugRelease.xcconfig: * MiniBrowser/Configurations/Base.xcconfig: * MiniBrowser/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * WebKitLauncher/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: 2015-01-28 Joanmarie Diggs AX: [ATK] Implement support for new AtkRole types for MathML https://bugs.webkit.org/show_bug.cgi?id=140916 Reviewed by Chris Fleizach. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4 2015-01-28 Carlos Garcia Campos [GTK] Stop removing color marks from unit tests output https://bugs.webkit.org/show_bug.cgi?id=140996 Reviewed by Philippe Normand. Since r178236 google tests use a custom simplified output without any colors, so we don't need to handle the case of non ttys to remove the color marks. * Scripts/run-gtk-tests: (TestRunner.__init__): (TestRunner._run_test_command.parse_line): 2015-01-28 Carlos Garcia Campos [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails https://bugs.webkit.org/show_bug.cgi?id=131731 Reviewed by Žan Doberšek. A web page loaded offscreen is in prerender state not hidden. * Scripts/run-gtk-tests: (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewPageVisibility): 2015-01-27 Alexey Proskuryakov Partially revert r178802. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: 2015-01-27 Alexey Proskuryakov build.webkit.org/dashboard asserts on some commits https://bugs.webkit.org/show_bug.cgi?id=140926 Reviewed by Tim Horton. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js: (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory. 2015-01-27 Alexey Proskuryakov Make flakiness dashboard OS list actually match test_expectations.py https://bugs.webkit.org/show_bug.cgi?id=140969 Reviewed by Ryosuke Niwa. * TestResultServer/static-dashboards/flakiness_dashboard.js: 2015-01-27 Brent Fulgham [Win] WinLauncher crashes on eleventh site visited https://bugs.webkit.org/show_bug.cgi?id=140960 Reviewed by Anders Carlsson. * WinLauncher/WinLauncher.cpp: (WinLauncher::showLastVisitedSites): Don't access off the end of the history array. 2015-01-27 Alexey Proskuryakov [Mac] Disable building Java applets by default https://bugs.webkit.org/show_bug.cgi?id=140957 rdar://problem/19619529 Reviewed by Anders Carlsson. It was actually already disabled unconditionally, by accident. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): * Scripts/webkitpy/port/mac.py: (MacPort._check_port_build): (MacPort._build_java_test_support): 2015-01-27 Daniel Bates [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work https://bugs.webkit.org/show_bug.cgi?id=140949 Reviewed by Alexey Proskuryakov. Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without builders so that run-webkit-tests can lint the appropriate TestExpectation files. * Scripts/webkitpy/port/builders.py: * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here... (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)" in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py. 2015-01-27 Alexey Proskuryakov Update bots on the flakiness dashboard https://bugs.webkit.org/show_bug.cgi?id=140956 Reviewed by Ryosuke Niwa. * TestResultServer/static-dashboards/builders.jsonp: * TestResultServer/static-dashboards/flakiness_dashboard.js: 2015-01-27 Daniel Bates [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths https://bugs.webkit.org/show_bug.cgi?id=140942 Reviewed by Alexey Proskuryakov. The directory LayoutTests/platform/wk2 contains test expectations and test results that are applicable to all WebKit2 ports. We should make use of this information when running layout tests using iOS WebKit2. Additionally, make use of the convenience function Port._wk2_port_name() for the name of the WebKit2 port instead of directly using string concatenation. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_baseline_search_path): 2015-01-27 Csaba Osztrogonác [Win] Disable FTL stress tests https://bugs.webkit.org/show_bug.cgi?id=140932 Reviewed by Brent Fulgham. * Scripts/run-javascriptcore-tests: 2015-01-27 Daniel Bates REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development https://bugs.webkit.org/show_bug.cgi?id=140939 Reviewed by Eric Carlson. Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106." * Scripts/webkitdirs.pm: (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm and define a function called wanted. 2015-01-27 Daniel Bates Teach run-webkit-app --simulator how to install custom built app https://bugs.webkit.org/show_bug.cgi?id=140691 Fix inadvertent omission of directory test flag in expression to check for the existence of the iOS simulator device-specific directory for user installed apps. * Scripts/webkitdirs.pm: (hasUserInstalledAppInSimulatorDevice): 2015-01-26 Brent Fulgham [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener https://bugs.webkit.org/show_bug.cgi?id=87426 Reviewed by Darin Adler. Revise COMPtr to work better with our HashMap implementation. Use modern loop syntax. * DumpRenderTree/win/AccessibilityControllerWin.cpp: (AccessibilityController::~AccessibilityController): (AccessibilityController::winNotificationReceived): * DumpRenderTree/win/DumpRenderTree.cpp: (dumpBackForwardListForAllWindows): 2015-01-26 Csaba Osztrogonác [Win] Enable JSC stress tests by default https://bugs.webkit.org/show_bug.cgi?id=128307 Reviewed by Brent Fulgham. * Scripts/run-javascriptcore-tests: 2015-01-26 Simon Fraser [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts https://bugs.webkit.org/show_bug.cgi?id=139748 Reviewed by Daniel Bates. There was much confusion resulting from the multitude of aliases used to build/test for the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout tests directory. This fixes an issue where run-api-tests and some other scripts failed when run with --simulator. * Scripts/build-webkit: * Scripts/package-root: (usage): * Scripts/webkitdirs.pm: (argumentsForConfiguration): (determineXcodeSDK): * Scripts/webkitpy/port/factory.py: (platform_options): 2015-01-26 Simon Fraser [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed https://bugs.webkit.org/show_bug.cgi?id=140203 rdar://problem/19198492 Reviewed by Sam Weinig. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added. (TEST): 2015-01-26 David Kilzer Add iOS EWS to build.webkit.org/dashboard Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: (BubbleQueueServer): Add ios-ews queue info. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Add iOS8Device platform. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw iOS device logo. 2015-01-26 Filip Pizlo copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set https://bugs.webkit.org/show_bug.cgi?id=140896 Reviewed by Michael Saboff. I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This makes our script do this. Note that an alternative would be to run clang via "xcrun clang" rather than directly, but this would be harder given llvm's autoconf setup. * Scripts/copy-webkitlibraries-to-product-directory: 2015-01-26 Alexey Proskuryakov Update bot assignments. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-01-26 Youenn Fablet Integrate WP python server into WebKit test framework https://bugs.webkit.org/show_bug.cgi?id=127094 Reviewed by Ryosuke Niwa. This patch adds W3C web server (wptserver) as a new HTTP server. wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt. wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt. Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process. Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process. It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server. * Scripts/webkitpy/common/system/executive_mock.py: (MockProcess.communicate): * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter. (LayoutTestRunner.__init__): (LayoutTestRunner.run_tests): (LayoutTestRunner.start_servers): (LayoutTestRunner.stop_servers): * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop. (LayoutTestRunnerTests._run_tests): (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server): (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server): (LayoutTestRunnerTests): (LayoutTestRunnerTests.test_servers_started): * Scripts/webkitpy/layout_tests/controllers/manager.py: Updated to check whether a test is a wpt test and whether wpt server launch is needed. (Manager.__init__): (Manager._is_http_test): (Manager._is_web_platform_test): (Manager._run_tests): * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ManagerTest.test_needs_servers.get_wpt_doc_root): (ManagerTest.test_needs_servers.get_manager): (ManagerTest.test_needs_servers): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server. (parse_args): * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added. (main): * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added. (doc_root): (base_url): (WebPlatformTestServer): (WebPlatformTestServer.__init__): (WebPlatformTestServer._set_start_cmd): (WebPlatformTestServer._copy_webkit_test_files): (WebPlatformTestServer._clean_webkit_test_files): (WebPlatformTestServer._prepare_config): (WebPlatformTestServer._spawn_process): (WebPlatformTestServer._stop_running_server): * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added. (TestWebPlatformTestServer): (TestWebPlatformTestServer.test_start_cmd): * Scripts/webkitpy/port/base.py: (Port.__init__): (Port.to.start_web_platform_test_server): (Port.to): (Port.to.web_platform_test_server_doc_root): (Port.to.web_platform_test_server_base_url): (Port.to.stop_web_platform_test_server): * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines. (Driver.__init__): (Driver.is_web_platform_test): (Driver.test_to_uri): (Driver.uri_to_test): (Driver._command_from_driver_input): * Scripts/webkitpy/port/driver_unittest.py: Updated tests according new conversion rules. (DriverTest.test_test_to_uri): (DriverTest.test_uri_to_test): 2015-01-26 Daniel Bates Teach run-webkit-app --simulator how to install custom built app https://bugs.webkit.org/show_bug.cgi?id=140691 Reviewed by David Kilzer. We should teach run-webkit-app --simulator how to install a custom built app. Currently run-webkit-app --simulator can only run a system app or an app that was installed using the simctl command line tool. For convenience we should teach run-webkit-app --simulator how to install a custom built app. As a side effect of this change run-safari --simulator will install and run a custom built of MobileSafari (if it exists). * Scripts/webkitdirs.pm: (iOSSimulatorDevices): Added FIXME comment to decouple device representation in Perl from the structure of the device.plist file. (plistPathFromBundle): Fix if-statement condition so that we actually perform a file system check to determine the plist path for a Mac app bundle. (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise, it will complain that it cannot find the file: "Domain ... does not exist". (appDisplayNameFromBundle): Ditto. (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return until a simulator device is the specified state. (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator (if it's open) before opening it again so as to ensure that the iOS Simulator boots the specified device. (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID. As implied by its name, this function will not return until the specified simulator device UDID is in the shutdown state. (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator device with the specified UDID. (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath() before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk, which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk. (hasUserInstalledAppInSimulatorDevice): Added. (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the "Booted" state. (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now, switching between a system installed app and a custom built version of the same app (e.g. custom build of MobileSafari) will erase all contents and settings in the simulator device. (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator() as that was the only caller of this function. (bootedIOSSimulatorDevice): Deleted. (openIOSSimulator): Deleted. 2015-01-26 Alexey Proskuryakov Update bot assignments. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-01-26 Alexey Proskuryakov Leaks bot shouldn't run JSC tests https://bugs.webkit.org/show_bug.cgi?id=140877 Reviewed by Darin Adler. Shaves off 48 minutes of time. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (TestLeaksFactory): Slim down the leaks queue. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.print_leaks_summary): * Scripts/webkitpy/port/mac.py: (MacPort.print_leaks_summary): Don't yell when leaks are detected. 2015-01-26 Csaba Osztrogonác Refactor run-javascriptcore-tests https://bugs.webkit.org/show_bug.cgi?id=140824 Reviewed by Darin Adler. Separated mozilla, stress test code paths and determining skipped mozilla tests into subroutines. * Scripts/run-javascriptcore-tests: (runMozillaTests): (runJSCStressTests): (defaultJsDriverArgsForMozillaTests): 2015-01-26 Csaba Osztrogonác [buildbot] Fix grammar of TestWithFailureCount https://bugs.webkit.org/show_bug.cgi?id=140884 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (TestWithFailureCount): (TestWithFailureCount.commandComplete): (TestWithFailureCount.getText2): (RunUnitTests): (RunPythonTests): (RunPerlTests): (RunLLINTCLoopTests): (Run32bitJSCTests): * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: (RunLLINTCLoopTestsTest.test_failure): (Run32bitJSCTestsTest.test_failure): (RunUnitTestsTest.assertFailures): 2015-01-26 Youenn Fablet Unreviewed. Moving myself to the committer section. * Scripts/webkitpy/common/config/contributors.json: 2015-01-26 Michael Catanzaro and Carlos Garcia Campos [GTK] gtkdoc does not appear in DevHelp https://bugs.webkit.org/show_bug.cgi?id=139369 Reviewed by Philippe Normand. * gtk/generate-gtkdoc: Create the generators in the main function and use them to get the local cross renference dependencies. Also pass the generator module name to webkitdom.write_doc_files(). (get_gtkdoc_module_paths): Receive a list of local cross reference dependencies. (get_generator_for_config): Set the main_sgml_file property of the GtkDoc object from the configuration file. (generate_documentation): Generate the documentation for the given generator. (generate_documentation_for_config): Deleted. * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames. * gtk/webkitdom.py: (write_doc_files): Receive the module name used to build the -sections.txt filename. 2015-01-26 Commit Queue Unreviewed, rolling out r179107. https://bugs.webkit.org/show_bug.cgi?id=140880 The GCC in the bots doesn't support the AsyncTask implementation (Requested by KaL on #webkit). Reverted changeset: "[GTK] Enable IndexedDB" https://bugs.webkit.org/show_bug.cgi?id=98932 http://trac.webkit.org/changeset/179107 2015-01-26 Csaba Osztrogonác [EFL] Bump libseccomp version to 2.1.1 https://bugs.webkit.org/show_bug.cgi?id=140357 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: 2015-01-25 Carlos Garcia Campos [GTK] Enable IndexedDB https://bugs.webkit.org/show_bug.cgi?id=98932 Reviewed by Žan Doberšek. * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port. 2015-01-25 Alexey Proskuryakov Would like leaks bot results at build.webkit.org/dashboard https://bugs.webkit.org/show_bug.cgi?id=122657 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Record links provided by buildbot steps. Currently, the dashboard hardcodes more links than necessary, could use the ones from buildbot in more places. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue): Reflect configuration option for leaks queues. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Add leaks queues to performance column. First, leaks are about performance indeed, and second, this is where we have some space to spare. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at least a year. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: (table.queue-grid td): Moved height from queue-view - we can now have more than one queue view per cell. The heigt is needed to avoid ugly overlapping while loading results - once the results are loaded, all rows are currently higher than that. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css: (.leaks-popover): Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Load BuildbotLeaksQueueView.js. 2015-01-25 peavo@outlook.com [Win] Add WebKit message loop interface. https://bugs.webkit.org/show_bug.cgi?id=140857 Reviewed by Brent Fulgham. Added message loop interface which will run the message loop, and perform required tasks (like calling CFRunLoopRunInMode) on each iteration of the loop. * WinLauncher/WinMain.cpp: (wWinMain): Use new message loop interface. 2015-01-24 Dan Bernstein update-webkit’s --internal option is unused https://bugs.webkit.org/show_bug.cgi?id=140861 Reviewed by Anders Carlsson. * Scripts/update-webkit: Removed the option. 2015-01-24 Brent Fulgham DumpRenderTree needs to run with Windows native controls on Windows https://bugs.webkit.org/show_bug.cgi?id=25592 Reviewed by Anders Carlsson. * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): Tell DRT to use native controls. (prepareConsistentTestingEnvironment): Ditto. 2015-01-23 David Kilzer test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports Reviewed by Daniel Bates. * Scripts/webkitpy/port/ios.py: (IOSPort.determine_full_port_name): Instead of checking the type of the current host, test if /usr/bin/xcrun exists before trying to use it. 2015-01-23 Csaba Osztrogonác Fix the false positive build failures on the Windows buildbots https://bugs.webkit.org/show_bug.cgi?id=140819 Reviewed by Brent Fulgham. Increase the build timeout (without producing output) to 2 hours for Windows bots, the default 20 minutes is enough for others since they produce output during the build. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (BuildFactory.__init__): 2015-01-23 Brent Fulgham [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage https://bugs.webkit.org/show_bug.cgi?id=140839 Reviewed by Dean Jackson. * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::language): Retrieve the 'language' BSTR from the IA2Locale structure and pass it to DRT. 2015-01-23 Brent Fulgham [Win] Update DRT Accessibility implementation to better match Mac. https://bugs.webkit.org/show_bug.cgi?id=140830 Reviewed by Dean Jackson. * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::titleUIElement): (AccessibilityUIElement::parentElement): (convertToDRTLabel): (AccessibilityUIElement::role): (AccessibilityUIElement::title): (AccessibilityUIElement::description): (AccessibilityUIElement::stringValue): (AccessibilityUIElement::helpText): (AccessibilityUIElement::isFocused): 2015-01-23 Sergio Villar Senin REGRESSION: run-perf-tests --profiler= seems to have broken https://bugs.webkit.org/show_bug.cgi?id=113528 Reviewed by Daniel Bates. The problem is that "perf --record" (or the equivalent call for other profilers) is never called whenever there is a wrapper option in the port. We should inject the profiler call first (should it exists) and then use the port wrapper. * Scripts/webkitpy/port/driver.py: (Driver._command_wrapper): * Scripts/webkitpy/port/driver_unittest.py: (DriverTest.test_profiler_and_wrapper): New unit test. 2015-01-22 David Kilzer configure-xcode-for-ios-development needs to import webkitdirs.pm Fixes the following runtime error: Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167. * Scripts/configure-xcode-for-ios-development: Add back code to import webkitdirs.pm for the exitStatus() method. Not sure why I removed it before patch review. 2015-01-22 Timothy Horton REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work https://bugs.webkit.org/show_bug.cgi?id=140795 Reviewed by Jon Honeycutt. * BuildSlaveSupport/build.webkit.org-config/config.json: r178847 accidentally remove the scheduler for this bot. Re-add it to the Yosemite scheduler. 2015-01-22 Brent Fulgham [Win] Expose missing editing features through WebView interface https://bugs.webkit.org/show_bug.cgi?id=140773 Reviewed by Dean Jackson. Connect the various WebView editing delegate methods to our test infrastructure. Also prefer _bstr_t to raw BSTR types to simplify life cycle management. * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): * DumpRenderTree/win/EditingDelegate.cpp: (EditingDelegate::QueryInterface): (dumpPath): (dump): (EditingDelegate::shouldBeginEditingInDOMRange): (EditingDelegate::shouldEndEditingInDOMRange): (EditingDelegate::shouldInsertNode): (EditingDelegate::shouldInsertText): (EditingDelegate::shouldDeleteDOMRange): (EditingDelegate::shouldChangeSelectedDOMRange): (EditingDelegate::shouldApplyStyle): (EditingDelegate::shouldChangeTypingStyle): (EditingDelegate::doPlatformCommand): (EditingDelegate::webViewDidBeginEditing): (EditingDelegate::webViewDidChange): (EditingDelegate::webViewDidEndEditing): (EditingDelegate::webViewDidChangeTypingStyle): (EditingDelegate::webViewDidChangeSelection): (EditingDelegate::checkSpellingOfString): (EditingDelegate::onNotify): * DumpRenderTree/win/EditingDelegate.h: 2015-01-22 Ryosuke Niwa Add a build flag for ES6 class syntax https://bugs.webkit.org/show_bug.cgi?id=140760 Reviewed by Michael Saboff. * Scripts/webkitperl/FeatureList.pm: 2015-01-22 Daniel Bates [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal runtime in simctl output https://bugs.webkit.org/show_bug.cgi?id=140751 Reviewed by David Kilzer. Following the fix for , run-webkit-tests --ios-sim dies with an error because it does not know how to parse the output of the simctl tool to identify an Apple Internal runtime. * Scripts/webkitpy/xcode/simulator.py: (Runtime.__init__): Add parameter is_internal_runtime (defaults to False). (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality. (Runtime.__repr__): Update printable representation of Runtime object to indicate whether the runtime is an internal runtime. (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime. (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the appropriate value. (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that it updates the appropriate Runtime object. (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support looking up a Runtime object for an internal runtime. 2015-01-22 Alexey Proskuryakov LeaksViewer doesn't show recent builds if there are less than 10 https://bugs.webkit.org/show_bug.cgi?id=140716 Reviewed by Tim Horton. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: 2015-01-22 Lucas Forschler Add Apple build slaves. Fixed text alignment for slave list. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-01-21 Lucas Forschler Teach build.webkit.org about bot308 and bot309. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-01-21 Lucas Forschler Add two Apple Mavericks slaves. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-01-21 Daniel Bates Add iOS WebKit1 TestExpectation file https://bugs.webkit.org/show_bug.cgi?id=140739 Reviewed by David Kilzer. Teach run-webkit-tests to look for iOS WebKit1-specific test results and expectations in directory LayoutTests/platform/ios-simulator-wk1. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_baseline_search_path): 2015-01-21 David Kilzer [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK Reviewed by Daniel Bates. * Scripts/configure-xcode-for-ios-development: - Update copyright. - Remove FIXME addressed by r178709. - Call copyMissingHeadersToIPhoneOSSDKIfNeeded(). (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy missing headers from iphonesimulator SDK to iphoneos SDK. (sdkDirectory): Add method that returns SDK directory. (sdkPlatformDirectory): Extract method from xcodeSDKSpecificationsPath() that returns SDK platform directory. (xcodeSDKSpecificationsPath): Update to use sdkPlatformDirectory(). 2015-01-21 Alexey Proskuryakov https://build.webkit.org/dashboard/metrics.html fails because of ios-ews https://bugs.webkit.org/show_bug.cgi?id=140731 Reviewed by Tim Horton. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo. 2015-01-21 Brent Fulgham [Win] eventSender does not support scalePageBy https://bugs.webkit.org/show_bug.cgi?id=140726 Reviewed by Dean Jackson. * DumpRenderTree/win/EventSender.cpp: (scalePageByCallback): Provide implementation using new WebView method. 2015-01-21 Lucas Forschler Remove Apple Mountain Lion Build & Test slaves. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-01-21 Csaba Osztrogonác Remove ENABLE(INSPECTOR) ifdef guards https://bugs.webkit.org/show_bug.cgi?id=140668 Reviewed by Darin Adler. * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::showWebInspector): (TestRunner::closeWebInspector): (TestRunner::evaluateInWebInspector): * Scripts/webkitperl/FeatureList.pm: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::showWebInspector): (WTR::TestRunner::closeWebInspector): (WTR::TestRunner::evaluateInWebInspector): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): 2015-01-20 Alexey Proskuryakov Update build.webkit.org/dashboard to match current Mac queues. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted. (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted. 2015-01-20 Lucas Forschler Update Apple MountainLion Leaks slave to Yosemite Update Apple MountainLion Release (32-bit) Build slave to Yosemite Unreviewed. * BuildSlaveSupport/build.webkit.org-config/config.json: 2015-01-20 Lucas Forschler Update LeaksViewer from MountainLion to Yosemite Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: (LeaksViewer._displayURLPrompt): 2015-01-20 Jake Nielsen Fix EWS python unit tests and address code comments as per 140476 https://bugs.webkit.org/show_bug.cgi?id=140637 Reviewed by David Kilzer. * Scripts/webkitpy/port/base.py: (Port): (Port.__init__): Adds DEFAULT_ARCHITECTURE member. (Port.architecture): Removes architecture member and instead uses self.get_option('architecture'). Also removes redundant architecture method. (Port.set_architecture): Adds a setter for the architecture variable to be able to set a flag upon modification. (Port.test_configuration): Uses self.architecture() instead of self._architecture. * Scripts/webkitpy/port/ios.py: Overrides DEFAULT_ARCHITECTURE. (IOSPort): (IOSPort.determine_full_port_name): Uses subprocess.check_output instead of Popen. Uses rstrip instead of strip. Fixes regex to not match arbitrary characters after the relevent digits are matched. (IOSPort.__init__): Removes old _architecture defaulting strategy. (IOSPort._build_driver_flags): Uses self.architecture() instead of self._architecture. (IOSSimulatorPort): Overrides DEFAULT_ARCHITECTURE. (IOSSimulatorPort.__init__): Removes old _architecture defaulting strategy. * Scripts/webkitpy/port/mac.py: (MacPort): Overrides DEFAULT_ARCHITECTURE. (MacPort.__init__): Removes old _architecture defaulting strategy. * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.run_command): Checks the did_override_architecture flag to determine whether to add the --architecture option. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Uses ews.architecture rather than trying to discern the correct architecture using a port object. (EarlyWarningSystemTest._default_expected_logs): * Scripts/webkitpy/tool/commands/queues.py: Removes use of optparse, and removes the import statement. (AbstractQueue.__init__): (PatchProcessingQueue.begin_work_queue): 2015-01-20 Sam Weinig Attempt to fix Mountain Lion and EFL tests. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Disable Process-per-tab and network process on Mountain Lion and EFL. 2015-01-20 Darin Adler Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE https://bugs.webkit.org/show_bug.cgi?id=140679 Reviewed by Anders Carlsson. * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Removed a reference to SVGElementInstanceList. 2015-01-20 Michael Catanzaro [GTK] WebViewTest should prohibit overriding initializeWebExtensions() https://bugs.webkit.org/show_bug.cgi?id=140028 Reviewed by Carlos Garcia Campos. This won't work as expected, since this function is called before the WebViewTest constructor completes. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: 2015-01-20 David Kilzer configure-xcode-for-ios-development needs to update iPhoneOS SDK Reviewed by Daniel Bates. * Scripts/configure-xcode-for-ios-development: Add for() loop to run createXcodeSpecificationFilesForSDKIfNeeded() for both "iphoneos" and "iphonesimulator" SDKs. (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from the main body of the script. 2015-01-20 Tomas Popela [GTK] Add API to set the web view editable into WebKit2 GTK+ API https://bugs.webkit.org/show_bug.cgi?id=139443 Reviewed by Carlos Garcia Campos. Create the new test cases for setting the editable property on the web view and on the contenteditable enabled document. Also rework the current tests that are expecting that the web view is editable. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: (loadTestHtml): (testWebViewEditorCutCopyPasteNonEditable): (testWebViewEditorCutCopyPasteEditable): (testWebViewEditorSelectAllNonEditable): (testWebViewEditorSelectAllEditable): (runEditorEditableCutTests): (testWebViewEditorEditableOnNonEditable): (testWebViewEditorEditableOnContentEditable): (testWebViewEditorNonEditable): (beforeAll): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::isEditable): (WebViewTest::setEditable): 2015-01-20 Carlos Garcia Campos [GTK] Add an option to create WebKitWebView snapshots with transparent background https://bugs.webkit.org/show_bug.cgi?id=140617 Reviewed by Gustavo Noronha Silva. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewSnapshot): Check that the same snapshot with transparent background is different than the default one filled with white. 2015-01-19 Carlos Garcia Campos [GTK] Add API to change the WebKitWebView background color https://bugs.webkit.org/show_bug.cgi?id=140610 Reviewed by Gustavo Noronha Silva. Add --bg-color command line option to MiniBrowser to be able to manually test the API passing any RGBA color to MiniBrowser. Also add a simple unit test to check that getting and setting colors from the API point of view. * MiniBrowser/gtk/BrowserWindow.c: (browser_window_set_background_color): * MiniBrowser/gtk/BrowserWindow.h: * MiniBrowser/gtk/main.c: (createBrowserWindow): (parseBackgroundColor): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewBackgroundColor): (beforeAll): 2015-01-19 Brent Fulgham [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing https://bugs.webkit.org/show_bug.cgi?id=140665 Reviewed by Brian Burg. * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to match expected test output. 2015-01-19 Benjamin Poulain Remove the support for custom suffixes on ChangeLog https://bugs.webkit.org/show_bug.cgi?id=140648 Reviewed by David Kilzer. Custom suffixes were used for the iOS branch of WebKit. Now that everything is opensource, there is no need for it. * Scripts/VCSUtils.pm: (changeLogSuffix): Deleted. (changeLogFileName): Deleted. * Scripts/commit-log-editor: * Scripts/prepare-ChangeLog: (getLatestChangeLogs): (generateNewChangeLogs): (generateFileList): * Scripts/resolve-ChangeLogs: (findChangeLog): 2015-01-19 Timothy Horton Adjust naming of action menu SPI https://bugs.webkit.org/show_bug.cgi?id=140644 Reviewed by Brian Weinstein. * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]): (TestWebKitAPI::TEST): 2015-01-19 Michael Catanzaro [GTK] Generate the make dist manifest from a CMake template file https://bugs.webkit.org/show_bug.cgi?id=139387 Reviewed by Martin Robinson. Remove the code that performs variable substitution on manifest.txt. Replace the custom variables used in that file with CMake variables. * gtk/make-dist.py: (Manifest.add_directory): (Manifest.get_full_source_path): (Manifest.process_line): (Manifest.resolve_variables): Deleted. (Manifest.get_full_tarball_path): Deleted. * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt. 2015-01-19 Brent Fulgham [Win] Correct merge error in last commit. * DumpRenderTree/win/AccessibilityControllerWin.cpp: (findAccessibleObjectById): Undo accidental paste made during landing. 2015-01-19 Brent Fulgham [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read https://bugs.webkit.org/show_bug.cgi?id=139906 Reviewed by Dean Jackson. WebKit on Windows was creating uninitialized VARIANT structures, then attempting to use them. This patch fixes that. * DumpRenderTree/win/AccessibilityControllerWin.cpp: (findAccessibleObjectById): (AccessibilityController::focusedElement): (logEventProc): (notificationListenerProc): * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::getChildAtIndex): (AccessibilityUIElement::titleUIElement): (self): (AccessibilityUIElement::role): (AccessibilityUIElement::valueDescription): (accessibilityState): (AccessibilityUIElement::isChecked): * DumpRenderTree/win/DumpRenderTree.cpp: (dumpFrameScrollPosition): (dumpFramesAsText): * DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::decidePolicyForNavigationAction): * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::exceededDatabaseQuota): * WinLauncher/Common.cpp: (setWindowText): 2015-01-19 Dean Jackson Add "override" to fix the build with newer clangs. * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: (TestWebKitAPI::CalculationDeletionTestNode::operator==): 2015-01-19 David Kilzer [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject() Reviewed by Daniel Bates. * Scripts/build-webkit: Update help for --device switch. * Scripts/webkitdirs.pm: (determineXcodeSDK): When passing --device, prefer the internal iOS SDK if it exists, else fall back to the external iOS SDK. (buildXCodeProject): Use xcodeSDK() as -sdk argument for xcodebuild instead of trying to sanitize values. 2015-01-19 Alexey Proskuryakov "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests. https://bugs.webkit.org/show_bug.cgi?id=140606 Reviewed by Csaba Osztrogonác. * Scripts/webkitpy/bindings/main.py: (BindingsTests.generate_supplemental_dependency): (BindingsTests.main): 2015-01-19 Carlos Garcia Campos [GTK] [WK2] TestWebKitWebView snapshot fails https://bugs.webkit.org/show_bug.cgi?id=120404 Reviewed by Žan Doberšek. Rework the test to make sure the snapshot is always created at the desired size. * Scripts/run-gtk-tests: (TestRunner): Unskip /webkit2/WebKitWebView/snapshot. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewSnapshot): Use a fixed size for the document, and disable scrollbars to make sure the visible area is always the WebView size. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width and height parameters to create the window with a given size. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: 2015-01-18 David Kilzer iOS EWS queue name should be consistent Reviewed by Daniel Bates. * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device' to 'ios'. * Scripts/webkitpy/common/config/ports.py: Ditto. (DeprecatedPort.port): (IOSPort): * Scripts/webkitpy/port/ios.py: Ditto. (IOSPort): * Scripts/webkitpy/port/factory.py: (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort appears before ios.IOSPort. If this is not done, `run-webkit-tests --ios-simulator` will get the wrong Port class (IOSPort instead of IOSSimulatorPort) due to the way that PortFactory.get() uses prefix matching of .port_name to find the correct class to use. 2015-01-18 Alexey Proskuryakov build.webkit.org/dashboard: OS X EWS is now on Mavericks https://bugs.webkit.org/show_bug.cgi?id=140595 Reviewed by Csaba Osztrogonác. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: (BubbleQueueServer): 2015-01-17 David Kilzer Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots * Scripts/webkitpy/port/ios.py: (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that test-webkitpy doesn't fail since iOS 7.x SDKs are installed on the Mountain Lion and Mavericks bots. 2015-01-17 David Kilzer Attempt to fix webkitpy tests on GTK Linux ports * Scripts/webkitpy/port/ios.py: (IOSPort.determine_full_port_name): Set a sensible default if not running on a Mac platform or if no iOS SDK is installed. 2015-01-17 Jake Nielsen Create iOS-EWS client queue https://bugs.webkit.org/show_bug.cgi?id=140476 Reviewed by Alexey Proskuryakov. * EWSTools/start-queue-mac.sh: Adds call to configure-xcode-for-ios-development for iOS EWS. * Scripts/webkitpy/common/config/ews.json: Adds the iOS EWS config entry. * Scripts/webkitpy/common/config/ports.py: (DeprecatedPort.port): Adds IOSPort to the port map. (IOSPort): (IOSPort.build_webkit_command): Adds --sdk=iphoneos to the webkit build command. * Scripts/webkitpy/port/base.py: (Port.architecture): Adds an accessor for the architecture member variable. * Scripts/webkitpy/port/factory.py: (PortFactory): Adds IOSPort to the port class list. * Scripts/webkitpy/port/ios.py: Adds the IOSPort to encapsulate iOS-specific things. (IOSPort): (IOSPort.determine_full_port_name): (IOSPort.__init__): (IOSPort._build_driver_flags): (IOSPort.operating_system): * Scripts/webkitpy/tool/commands/download_unittest.py: Adds the archetecture option to the mock options. (DownloadCommandsTest._default_options): * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Appends the archetecture option into calls to webkit-patch. (AbstractEarlyWarningSystem.review_patch): (AbstractEarlyWarningSystem.run_command): (AbstractEarlyWarningSystem.load_ews_classes): * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Adds logic to soothe the unittest now that --architecture is being thrown around everywhere. (EarlyWarningSystemTest._default_expected_logs): * Scripts/webkitpy/tool/commands/queues.py: Adds glue code to ferry the --architecture option around. (AbstractQueue.__init__): (PatchProcessingQueue.begin_work_queue): * Scripts/webkitpy/tool/steps/abstractstep.py: Adds the archetecture option to all AbstractSteps so that EarlyWarningSystem doesn't start shoving --architecture into unsuspecting commands. (AbstractStep.options): * Scripts/webkitpy/tool/steps/build.py: Translates the --architecture option into an ARCHS= format to pass to build-webkit. (Build.build): * Scripts/webkitpy/tool/steps/options.py: Adds a definition for the --architecture option. (Options): 2015-01-16 Sam Weinig Add a basic configuration object for WKView https://bugs.webkit.org/show_bug.cgi?id=140559 Reviewed by Anders Carlsson. Add tests for WKPageConfigurationRef. * TestWebKitAPI/PlatformWebView.h: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added. (TestWebKitAPI::TEST): (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::setPageLoaderClient): * TestWebKitAPI/mac/PlatformWebViewMac.mm: (TestWebKitAPI::PlatformWebView::initialize): (TestWebKitAPI::PlatformWebView::PlatformWebView): 2015-01-16 Myles C. Maxfield WeakPtr functions crash when created with default constructor https://bugs.webkit.org/show_bug.cgi?id=140479 Reviewed by Andreas Kling. Add WeakPtr API tests. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added. * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor. 2015-01-16 Chris Dumez Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail https://bugs.webkit.org/show_bug.cgi?id=140568 Reviewed by Alexey Proskuryakov. Fix the script parsing CSSPropertyNames.in to stop splitting lines on '=' sign. The '=' sign is also used in StyleBuilder parameters: e.g. "Longhands=background-position-x|background-position-y". This would confuse the script and treat this as a CSS property: "background-position-x|background-position-y". We now split on white space and treat the first string on the line to be the property name (this is the syntax in this file). * Scripts/webkitpy/w3c/test_converter.py: (_W3CTestConverter.__init__): (_W3CTestConverter.read_webkit_prefixed_css_property_list): 2015-01-16 Daniel Bates REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS https://bugs.webkit.org/show_bug.cgi?id=135589 Reviewed by David Kilzer. Derived from a patch by David Farler. Following the removal IPhoneSimulatorNotification.pm in run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari in terms of the simctl command line utility. * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED. (eraseIOSSimulatorDevice): Added. (bootedIOSSimulatorDevice): Added. (iosSimulatorApplicationsPath): Added. (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath(). (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1). (quitIOSSimulator): Added. (iosSimulatorDeviceByName): Modified to find the first simulator device that matches the specified name and currently selected iOS runtime. (isIOSSimulatorSystemInstalledApp): Added. (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator. (deleteiOSSimulatorDevice): Deleted. (loadIPhoneSimulatorNotificationIfNeeded): Deleted. (installAndLaunchIOSWebKitAppInSimulator): Deleted. 2015-01-16 Alex Christensen Resurrect the WinCairo bot. https://bugs.webkit.org/show_bug.cgi?id=139908 Reviewed by Csaba Osztrogonác. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (appendCustomBuildFlags): * BuildSlaveSupport/test-result-archive: (archiveTestResults): Add WinCairo buildbot. 2015-01-16 Chris Dumez webkit-patch should auto-install the keyring python module https://bugs.webkit.org/show_bug.cgi?id=140547 Reviewed by David Kilzer. Auto-install the keyring python module. This is the module that webkit-patch uses for cross-platform access to the keyring service. Without this module, if the password if not in the keychain, webkit-patch will keep asking for your username / password and never remember them. * Scripts/webkitpy/common/net/credentials.py: * Scripts/webkitpy/thirdparty/__init__.py: (AutoinstallImportHook.find_module): (AutoinstallImportHook._install_keyring): 2015-01-15 Csaba Osztrogonác Remove ENABLE(SQL_DATABASE) guards https://bugs.webkit.org/show_bug.cgi?id=140434 Reviewed by Darin Adler. * Scripts/webkitperl/FeatureList.pm: 2015-01-15 Daniel Bates [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice https://bugs.webkit.org/show_bug.cgi?id=139685 Reviewed by Simon Fraser. Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular, the test LayoutTests/fast/dom/gc-10.html may dump its result twice. Following , we dump the test result asynchronously as opposed to synchronously. So, the WebThread or the main thread may perform other tasks before DRT dumps the output of a test. In particular, the WebThread may start a new page load (say, as a result of continued JavaScript execution), which will ultimately lead to dumping the test result again. Instead we want DRT to dump the test result synchronously such that we capture the state of the web page either when the page is loaded or when window.testRunner.notifyDone() is called. * DumpRenderTree/ios/PixelDumpSupportIOS.mm: (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to flush CA transactions to the window. * DumpRenderTree/mac/DumpRenderTree.mm: (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test. (dump): Renamed; formerly named dumpTestResults(). (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate enabling repaint support on iOS. (-[DumpRenderTree _deferDumpToMainThread]): Deleted. (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted. (dumpTestResults): Deleted. 2015-01-15 Brent Fulgham [Win] Miscellaneous DRT fixes https://bugs.webkit.org/show_bug.cgi?id=116562 Reviewed by Tim Horton. While investigating the cause of several Windows crashes, I found: (1) Messy conversions to and from BSTR types (2) Weird mixes of wide-string and narrow string conversions (3) Passing nullptr to some CoreFoundation routines that do not permit null arguments. (4) Commands to link the executable to the VS2005 runtime. This patch cleans up these issues to improve DRT reliability on Windows. * DumpRenderTree/cg/ImageDiffCG.cpp: (main): Get rid of VS2005 runtime linking. * DumpRenderTree/win/DumpRenderTree.cpp: (urlSuitableForTestResult): Protect against being asked to process an empty URL. (dumpHistoryItem): Do BSTR string building using _bstr_t, rather than converting to/from wchar_t buffers. (runTest): Simplify string and BSTR handling. (createWebViewAndOffscreenWindow): Ditto. (main): Get rid of VS2005 runtime linking. * DumpRenderTree/win/TestRunnerWin.cpp: (jsStringRefToWString): Simplify code. (TestRunner::pathToLocalResource): (TestRunner::setUserStyleSheetLocation): * TestWebKitAPI/win/main.cpp: Get rid of VS2005 runtime linking. * win/DLLLauncher/DLLLauncherMain.cpp: (wWinMain): Ditto. 2015-01-15 Alexey Proskuryakov Stop hardcoding mac-mountainlion in commit queue https://bugs.webkit.org/show_bug.cgi?id=140492 Reviewed by Anders Carlsson. Use "mac", not "mac-". This matches how EWS queues are initialized, and there should be no change in behavior, because: 1. PatchProcessingQueue converts the name with _new_port_name_from_old() before using it to create a port object. 2. Although it doesn't convert the name before using DeprecatedPort.port(), it is actually correct to use "mac" for the name there. We only used to get the expected behavior with "mac-mountainlion" accidentally, because of a fallback to "mac" for unknown deprecated port names. * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue): 2015-01-14 Jake Nielsen Create iOS-EWS server queue https://bugs.webkit.org/show_bug.cgi?id=140473 Reviewed by Benjamin Poulain. * QueueStatusServer/app.yaml: Updates the SVN version number. * QueueStatusServer/config/queues.py: Add ios-ews queue. * QueueStatusServer/model/queues.py: (Queue.display_name): Makes sure the display name is pretty! 2015-01-14 Daniel Bates [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime https://bugs.webkit.org/show_bug.cgi?id=140301 Reviewed by Jon Honeycutt. Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator with an unavailable runtime. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime, which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the specified runtime cannot be used because it is unavailable. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(), which was formerly named testing_device. * Scripts/webkitpy/xcode/simulator.py: (Device.create): Modified to lookup created device by the UDID returned by simctl, which is more robust than looking up the simulator device by name and runtime. This approach also avoids returning the wrong device due to (simctl list shows unavailable runtimes under the same iOS heading it would use to show it as available). (Simulator.find_device_by_udid): Added. (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults to False) to ignore devices that are unavailable (say, because their runtime is unavailable). (Simulator.available_runtimes): Added. (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage of the reverse=True argument to sorted() to sort the list of available runtimes such that the first element of the sorted list is the runtime with the highest version number. (Simulator.lookup_or_create_device): Renamed; formerly named testing_device. 2015-01-14 Csaba Osztrogonác Remove WK2 Windows cruft https://bugs.webkit.org/show_bug.cgi?id=140440 Reviewed by Anders Carlsson. * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed. * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed. * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed. 2015-01-13 Hunseop Jeong Fix TestWTF failed in TestWebKitAPI https://bugs.webkit.org/show_bug.cgi?id=140333 Reviewed by Sam Weinig. Clear the std::ostringstream before starting test. * TestWebKitAPI/Tests/WTF/RefLogger.h: (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger): 2015-01-13 Michael Catanzaro TestWebKitWebContext depends on British English spellcheck dictionary https://bugs.webkit.org/show_bug.cgi?id=140403 Reviewed by Martin Robinson. Install all English hunspell dictionaries on Fedora and Arch. * gtk/install-dependencies: 2015-01-13 Michael Catanzaro [GTK] install-dependencies should grok dnf https://bugs.webkit.org/show_bug.cgi?id=140396 Reviewed by Martin Robinson. Fedora: install dependencies with dnf if yum is not installed. * gtk/install-dependencies: 2015-01-12 Hunseop Jeong [EFL][GTK] Fix build after r178309 https://bugs.webkit.org/show_bug.cgi?id=140381 Reviewed by Gyuyoung Kim. * TestWebKitAPI/CMakeLists.txt: Added the API directory 2015-01-11 Sam Weinig Remove support for SharedWorkers https://bugs.webkit.org/show_bug.cgi?id=140344 Reviewed by Anders Carlsson. * Scripts/webkitperl/FeatureList.pm: 2015-01-12 Anders Carlsson Make delegates conform to formal delegate protocols https://bugs.webkit.org/show_bug.cgi?id=140370 Reviewed by Dan Bernstein. * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::numberOfPendingGeolocationPermissionRequests): (TestRunner::setGeolocationPermission): 2015-01-10 Michael Catanzaro build-webkit: silence output of 'which' https://bugs.webkit.org/show_bug.cgi?id=140278 Reviewed by Daniel Bates. Use a more elegent test for the existance of ninja and eclipse. * Scripts/webkitdirs.pm: (commandExists): Don't assume the command supports --version (canUseNinja): Use commandExists() (canUseEclipse): Use commandExists() 2015-01-09 Sam Weinig Update the output format for run-api-tests https://bugs.webkit.org/show_bug.cgi?id=140332 Reviewed by Dan Bernstein. Changes the output format for run-api-tests be a bit simpler (no longer indented based on suite, as we were not really using suite very well) but also include details in the case of failure. Changes verbose mode to no longer spew out the gtest default printer output, as the custom printer now includes the failure information. * Scripts/run-api-tests: (runTestsBySuite): (runTest): Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**" with colorized variants and strip out leaks spew (the leaks can be added back using the new --show-leaks argument). * TestWebKitAPI/TestsController.cpp: (TestWebKitAPI::Printer::OnTestPartResult): (TestWebKitAPI::Printer::OnTestEnd): (TestWebKitAPI::TestsController::run): Implement a custom result printer that just prints out the information we want. 2015-01-09 Sam Weinig TestWebKitAPI should print out the lists that fail at the end https://bugs.webkit.org/show_bug.cgi?id=140329 Reviewed by Tim Horton. * Scripts/run-api-tests: (runTestsBySuite): Print out failures and timeouts in all modes, not just verbose. 2015-01-07 Geoffrey Garen Make bmalloc work with ASan https://bugs.webkit.org/show_bug.cgi?id=140194 Reviewed by Mark Lam. * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports ASan automatically (by forwarding to system malloc at runtime). 2015-01-09 Daniel Bates [iOS] Make DumpRenderTree build with public SDK https://bugs.webkit.org/show_bug.cgi?id=140311 Reviewed by Sam Weinig. Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in header UIKit/UIMath.h), and std::max() instead of the macro function MAX. Additionally, remove unused header CoreGraphics/CGFontDB.h. * DumpRenderTree/mac/DumpRenderTree.mm: (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]): 2015-01-09 Alexey Proskuryakov platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines https://bugs.webkit.org/show_bug.cgi?id=140300 Reviewed by Simon Fraser. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::updateWindowScaleForTest): (WTR::TestController::configureViewForTest): * WebKitTestRunner/TestController.h: 2015-01-09 Tibor Meszaros Unreviewed. Moving myself to the committer section. * Scripts/webkitpy/common/config/contributors.json: 2015-01-09 Carlos Garcia Campos Add a script to check for platform layering violations https://bugs.webkit.org/show_bug.cgi?id=140248 Reviewed by Darin Adler. It prints all the cases where files inside platform include headers that are not in platform directory. * Scripts/check-for-platform-layering-violations: Added. (get_platform_headers): (check_source_file): 2015-01-08 Alexey Proskuryakov [Mac WK2] Test snapshots are 1600x1200 on Retina devices https://bugs.webkit.org/show_bug.cgi?id=139884 Reviewed by Tim Horton. * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage): Tell CGWindowListCreateImage to use the correct resolution. I don't really understand what the "nominal resolution" is, but this appears to work in practice. 2015-01-08 Brent Fulgham [Win] DumpRenderTree is always using 800x600 size, even if tests need other size. https://bugs.webkit.org/show_bug.cgi?id=140256 Reviewed by Anders Carlsson. * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while running with heap validation checks. (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for the "svg\\W3C-SVG-1.1" test directory. (removeFontFallbackIfPresent): Use nullptr instead of 0. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearPersistentUserStyleSheet): Ditto. 2015-01-08 Alexey Proskuryakov Follow-up to: When WebProcess is slow to respond to IPC, that's mistakenly reported as crash https://bugs.webkit.org/show_bug.cgi?id=140218 * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness): Undone an accidental change - check for self.has_crashed() again. This code path is for ports that don't have a signal handler printing #CRASHED when main process crashes. * Scripts/webkitpy/port/driver_unittest.py: (DriverTest.test_check_for_driver_crash.assert_crash): (DriverTest.test_check_for_driver_crash): Updated the tests, all changes are expected. 2015-01-08 Alexey Proskuryakov When WebProcess is slow to respond to IPC, that's mistakenly reported as crash https://bugs.webkit.org/show_bug.cgi?id=140218 Reviewed by Darin Adler. * Scripts/webkitpy/port/driver.py: (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for "process crashed" condition. These don't make sense together - it's either a crash or a timeout, and we should detect those properly at a much lower level. (Driver.run_test): Ditto. (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness cases. * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::webProcessName): (WTR::TestController::processDidCrash): Factored out hardcoded child process names, as we now use these in two places. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child process name, so that it can be sampled (fixes sampling on Mavericks and above). 2015-01-08 Zan Dobersek Reorder my list of email addresses, keeping the Bugzilla address at the top since Bugzilla and other webkitpy scripts rely on that ordering. * Scripts/webkitpy/common/config/contributors.json: 2015-01-08 Zan Dobersek Moving myself to the reviewers section and updating the list of my email addresses. * Scripts/webkitpy/common/config/contributors.json: 2015-01-07 Michael Catanzaro [GTK] Build gtk-doc without gtkdoc-mktmpl https://bugs.webkit.org/show_bug.cgi?id=140225 Reviewed by Darin Adler. Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we don't modify the tmpl files that it generates, it's not doing anything for us. * gtk/gtkdoc.py: (GTKDoc.generate): (GTKDoc._run_gtkdoc_scangobj): (GTKDoc._run_gtkdoc_mktmpl): Deleted. 2015-01-07 Gwang Yoon Hwang [GTK][ThreadedCompositor] Add support for threaded compositor. https://bugs.webkit.org/show_bug.cgi?id=118265 Reviewed by Martin Robinson. Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and autotools build systems. The feature is disabled by default. And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag from the feature flags. * Scripts/webkitperl/FeatureList.pm: 2015-01-07 Daniel Bates [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT https://bugs.webkit.org/show_bug.cgi?id=137371 Reviewed by David Kilzer. Use SPI wrapper headers instead of directly referencing private SPI headers. * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: * DumpRenderTree/ios/PixelDumpSupportIOS.mm: * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios to the list of iOS header search directories so that we can include header UIKitSPI.h. * DumpRenderTree/mac/DumpRenderTree.mm: * DumpRenderTree/mac/DumpRenderTreeWindow.h: * DumpRenderTree/mac/EventSendingController.mm: * DumpRenderTree/mac/TestRunnerMac.mm: 2015-01-07 Commit Queue Unreviewed, rolling out r178068. https://bugs.webkit.org/show_bug.cgi?id=140235 Breaks the iOS build (Requested by enrica on #webkit). Reverted changeset: "[iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT" https://bugs.webkit.org/show_bug.cgi?id=137371 http://trac.webkit.org/changeset/178068 2015-01-07 Daniel Bates [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT https://bugs.webkit.org/show_bug.cgi?id=137371 Reviewed by David Kilzer. Use SPI wrapper headers instead of directly referencing private SPI headers. * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: * DumpRenderTree/ios/PixelDumpSupportIOS.mm: * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios to the list of header search directories so that we can include header UIKitSPI.h. * DumpRenderTree/mac/DumpRenderTree.mm: * DumpRenderTree/mac/DumpRenderTreeWindow.h: * DumpRenderTree/mac/EventSendingController.mm: * DumpRenderTree/mac/TestRunnerMac.mm: 2015-01-07 Brent Fulgham [Win] Unreviewed test change to improve run reproducibility * Scripts/webkitpy/port/win.py: (WinPort.default_child_processes): Run a single DRT instance to help identify failures caused by earlier test runs. 2015-01-07 Myles C. Maxfield Myles C. Maxfield is a reviewer now https://bugs.webkit.org/show_bug.cgi?id=140196 Reviewed by Dean Jackson. * Scripts/webkitpy/common/config/contributors.json: 2015-01-07 Myles C. Maxfield Make webkit-patch try harder to find keychain credentials https://bugs.webkit.org/show_bug.cgi?id=140170 Reviewed by Ryosuke Niwa. When the user manually enters a password into webkit-patch, we hand that off to the Keyring Python module. However, that module creates a generic password entry instead of an internet password entry. We should look for both kinds. * Scripts/webkitpy/common/net/credentials.py: (Credentials._run_security_tool): (Credentials._credentials_from_keychain): * Scripts/webkitpy/common/net/credentials_unittest.py: (test_security_output_parse_entry_not_found): (_assert_security_call): 2015-01-06 Anders Carlsson Try to fix the Mountain Lion build. * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: (TestWebKitAPI::didGetImageForMatchResult): 2015-01-06 Alexey Proskuryakov Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry https://bugs.webkit.org/show_bug.cgi?id=140095 Reviewed by Anders Carlsson. * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release builds, but not in debug ones. 2015-01-06 Brent Fulgham [Win] Extend WinLauncher with support for Page Zoom https://bugs.webkit.org/show_bug.cgi?id=140152 Reviewed by Anders Carlsson. * WinLauncher/Common.cpp: (WndProc): * WinLauncher/WinLauncher.cpp: (WinLauncher::resetZoom): (WinLauncher::zoomIn): (WinLauncher::zoomOut): * WinLauncher/WinLauncher.h: * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: * win/DLLLauncher/DLLLauncherMain.cpp: (wWinMain): 2015-01-06 Anders Carlsson Fix API tests that are broken under HiDPI https://bugs.webkit.org/show_bug.cgi?id=140146 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: (TestWebKitAPI::didGetImageForMatchResult): NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels. * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: (TestWebKitAPI::DeviceScaleFactorOnBack::runTest): Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start out in a window that has a backing scale factor of 1. * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Ditto. 2015-01-06 Alexey Proskuryakov ADDRESS_SANITIZER macro is overloaded https://bugs.webkit.org/show_bug.cgi?id=140130 Reviewed by Anders Carlsson. * WebKitTestRunner/TestController.cpp: Use the new macro. 2015-01-05 Joseph Pecoraro Remove some stale class names in check-for-inappropriate-objc-class-names https://bugs.webkit.org/show_bug.cgi?id=140104 Reviewed by Darin Adler. * Scripts/check-for-inappropriate-objc-class-names: These UIWK* classes no longer exist. 2015-01-05 Anders Carlsson heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html https://bugs.webkit.org/show_bug.cgi?id=140096 rdar://problem/19368938 Reviewed by Alexey Proskuryakov. When creating a new page, don't pass clientInfo when setting up the frame and policy clients, since clientInfo points to a web view, not the test controller. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): 2015-01-05 Hunseop Jeong [EFL][GTK] WKPreferencesDefaults test failed after r177506 https://bugs.webkit.org/show_bug.cgi?id=140077 Reviewed by Csaba Osztrogonác. WebKit C SPI is available on EFL,GTK. Changed the define order to pass the API test. * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: (TestWebKitAPI::TEST): 2015-01-01 Alexey Proskuryakov Simplify WebKitTestRunner timeout tracking https://bugs.webkit.org/show_bug.cgi?id=140036 Reviewed by Darin Adler. The code for configuring timeouts was mostly dead, because run-webkit-tests never passes the --timeout option to WebKitTestRunner. * WebKitTestRunner/Options.h: * WebKitTestRunner/Options.cpp: (WTR::Options::Options): (WTR::OptionsHandler::OptionsHandler): (WTR::handleOptionTimeout): Deleted. Removed support for --timeout. Timeouts are passed for each test individually, and defaults are good enough for the rare cases where WebKitTestRunner is run manually without run-webkit-tests. * WebKitTestRunner/TestController.cpp: (WTR::TestController::TestController): (WTR::TestController::initialize): (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::reattachPageToWebProcess): (WTR::TestController::runUntil): * WebKitTestRunner/TestController.h: Simplified runUntil by passing the actual timeout, not an enum. Increased short timeout for ASan enabled builds, as WebProcess launching takes quite a while. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout. * WebKitTestRunner/efl/TestControllerEfl.cpp: (WTR::TestController::platformRunUntil): * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::platformRunUntil): Build fixes. 2015-01-02 Anders Carlsson Remove now unused storage tracker glue from DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=140045 Reviewed by Darin Adler. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/StorageTrackerDelegate.h: Removed. * DumpRenderTree/StorageTrackerDelegate.mm: Removed. * DumpRenderTree/TestRunner.cpp: (TestRunner::staticFunctions): (syncLocalStorageCallback): Deleted. (observeStorageTrackerNotificationsCallback): Deleted. (deleteAllLocalStorageCallback): Deleted. (deleteLocalStorageForOriginCallback): Deleted. (localStorageDiskUsageForOriginCallback): Deleted. (originsWithLocalStorageCallback): Deleted. * DumpRenderTree/TestRunner.h: * DumpRenderTree/mac/DumpRenderTree.mm: (allocateGlobalControllers): (releaseGlobalControllers): * DumpRenderTree/mac/DumpRenderTreeMac.h: * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::syncLocalStorage): Deleted. (TestRunner::localStorageDiskUsageForOrigin): Deleted. (TestRunner::observeStorageTrackerNotifications): Deleted. (TestRunner::deleteAllLocalStorage): Deleted. (TestRunner::originsWithLocalStorage): Deleted. (TestRunner::deleteLocalStorageForOrigin): Deleted. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::syncLocalStorage): Deleted. (TestRunner::localStorageDiskUsageForOrigin): Deleted. (TestRunner::observeStorageTrackerNotifications): Deleted. (TestRunner::deleteAllLocalStorage): Deleted. (TestRunner::originsWithLocalStorage): Deleted. (TestRunner::deleteLocalStorageForOrigin): Deleted. 2015-01-01 Darin Adler We often misspell identifier as "identifer" https://bugs.webkit.org/show_bug.cgi?id=140025 Reviewed by Michael Saboff. * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: * Scripts/webkitdirs.pm: (appIdentifierFromBundle): (installAndLaunchIOSWebKitAppInSimulator): Fix misspellings 2015-01-01 Zalan Bujtas Saturated arithmetics: Incorrect float/double clamping. https://bugs.webkit.org/show_bug.cgi?id=139888 rdar://problem/19330885 Reviewed by Simon Fraser. Clamp float and double values correctly when applying saturated arithmetics. * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: (TestWebKitAPI::TEST): 2014-12-30 Krzysztof Czech [EFL] Bump version of ATK used by jhbuild to 2.15.2 https://bugs.webkit.org/show_bug.cgi?id=139816 Reviewed by Gyuyoung Kim. Bump version of ATK used by jhbuild to 2.15.2 * efl/jhbuild.modules: 2014-12-29 Fabien Vallée [jhBuild] cairo build error (-flto) https://bugs.webkit.org/show_bug.cgi?id=139056 Reviewed by Philippe Normand. cairo fails to link with gcc 4.9 due to lto related issue. This problem has been partially addressed by cairo: http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c use the cairo --disable-lto option and remove jhbuild makeargs fixes the issue. * gtk/jhbuild.modules: * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added. 2014-12-27 Myles C. Maxfield [Mac] Enable kerning, ligatures, and printer fonts https://bugs.webkit.org/show_bug.cgi?id=139970 Rubber stamped by Simon Fraser. Flip the switch. * DumpRenderTree/mac/DumpRenderTree.mm: * WebKitTestRunner/TestController.cpp: * WebKitTestRunner/mac/main.mm: 2014-12-26 Dan Bernstein REGRESSION (r177027): iOS builds use the wrong toolchain https://bugs.webkit.org/show_bug.cgi?id=139950 Reviewed by David Kilzer. * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so in a manner that works with Xcode 5.1.1. 2014-12-24 Dan Bernstein Engineering builds of MiniBrowser ignore deprecated declaration warnings https://bugs.webkit.org/show_bug.cgi?id=139941 Reviewed by Darin Adler. * MiniBrowser/Configurations/Base.xcconfig: Added semicolon. * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS to YES. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of deprecated NSOKButton. 2014-12-24 Youenn Fablet W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion https://bugs.webkit.org/show_bug.cgi?id=134763 Reviewed by Ryosuke Niwa. Adding an option to disable test harness link conversion. * Scripts/webkitpy/w3c/test_converter.py: (convert_for_webkit): (_W3CTestConverter.__init__): (_W3CTestConverter.convert_attributes_if_needed): * Scripts/webkitpy/w3c/test_importer.py: (parse_args): (TestImporter.import_tests): 2014-12-23 Alexey Proskuryakov DumpRenderTree crashes are mis-reported as timeouts on Yosemite https://bugs.webkit.org/show_bug.cgi?id=139933 Reviewed by Daniel Bates. Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447), and there is no way for run-webkit-tests to tell a crashed process from a frozen one until ReportCrash lets it go. Reuse existing machinery that tells run-webkit-tests about crashes. The script may even get the actual crash log eventually - even when it times out waiting for the log, it makes a second lookup at the very end, after all tests finish. There may be further improvements needed here, but this small fix addresses most cases that happen in practice. * DumpRenderTree/mac/DumpRenderTree.mm: (writeCrashedMessageOnFatalError): (dumpRenderTree): Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac. * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an unhelpful comment. 2014-12-23 Alexey Proskuryakov Don't force -O1 for debug ASan builds https://bugs.webkit.org/show_bug.cgi?id=139926 Reviewed by Darin Adler. * asan/asan.xcconfig: 2014-12-23 Alexey Proskuryakov Simplify building with ASan https://bugs.webkit.org/show_bug.cgi?id=139916 Reviewed by Mark Rowe. * Scripts/set-webkit-configuration: Store ASan state into a new configuration file. We could also update Configuration file format, but that's a little scary because of how many places in code read it. * Scripts/webkitdirs.pm: (determineASanIsEnabled): Read it from ASan configuration file. (argumentsForConfiguration): Added a FIXME. (asanIsEnabled): A caching wrapper similar to what we have for other configuration options. (XcodeOptions): Pass the options needed for ASan. * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there no warnings to avoid. Removed explicit linking options, as -fsanitize=address does that automatically. 2014-12-23 Alexey Proskuryakov TestWebKitAPI build is broken when ASan is enabled https://bugs.webkit.org/show_bug.cgi?id=139902 Reviewed by Darin Adler. * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Inherit linker flags from DebugRelease, which respects ASAN. 2014-12-22 Simon Fraser Sort the Xcode project file. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 2014-12-22 Lucas Forschler Update apple-mac-114 to bot629. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/config.json: 2014-12-22 Lucas Forschler Replace Apple bot104 with bot124. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/config.json: 2014-12-22 Csaba Osztrogonác URTBF after r177639. * TestWebKitAPI/CMakeLists.txt: 2014-12-22 Grzegorz Czajkowski [EFL] MiniBrowser steals web view's focus https://bugs.webkit.org/show_bug.cgi?id=139482 Reviewed by Gyuyoung Kim. Although we set focus on ewk_view while MiniBrowser initialization Ecore steals it in a favor of main window. As a result focused element on web page is unable to receive events. * MiniBrowser/efl/main.c: (window_create): Prevent window from stealing web view's focus on start up. 2014-12-19 Brent Fulgham [Win] Revise DRT logic to match Mac. Rubberstamped by Anders Carlsson. Update the Windows logic to perform initialization of preferences and WebKit settings to match Mac. Also make sure that we only ever emit #EOF tokens under the same circumstances as the Mac version. * DumpRenderTree/win/DumpRenderTree.cpp: (dump): (resetWebPreferencesToConsistentValues): (setDefaultsToConsistentValuesForTesting): (resetWebViewToConsistentStateBeforeTesting): (sizeWebViewForCurrentTest): (runTest): (createWebViewAndOffscreenWindow): (allocateGlobalControllers): (prepareConsistentTestingEnvironment): (main): (resetDefaultsToConsistentValues): Deleted. 2014-12-19 Roger Fong Unreviewed. Rollout r177605. * EWSTools/start-queue-win.sh: 2014-12-19 Roger Fong Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true. * EWSTools/start-queue-win.sh: 2014-12-19 Daniel Bates [iOS] Add WebKitSystemInterface for iOS 8.1 https://bugs.webkit.org/show_bug.cgi?id=139831 Reviewed by Alexey Proskuryakov. Implement support in copy-webkitlibraries-to-product-directory to copy WebKitSystemInterface for iOS to the product directory and have build-webkit pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS. * Scripts/build-webkit: * Scripts/copy-webkitlibraries-to-product-directory: 2014-12-19 Daniel Bates copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit https://bugs.webkit.org/show_bug.cgi?id=139829 Reviewed by Alexey Proskuryakov. The script build-webkit calls script copy-webkitlibraries-to-product-directory with argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory expects the Xcode SDK to be specified using the --sdk-name command line argument. Currently copy-webkitlibraries-to-product-directory has its own logic to handle parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm logic to both avoid duplicating effort and make the command line options for copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent with the approach used in other WebKit tools. As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK copy-webkitlibraries-to-product-directory now recognizes --device and --simulator shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively. * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to improve the readability of the code. (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature) be included in a library. (unpackIfNecessary): Modified to call executeRanlib(). 2014-12-19 Alexey Proskuryakov REGRESSION (177368): Some tests started to immediately time out https://bugs.webkit.org/show_bug.cgi?id=139826 Reviewed by Daniel Bates. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test ends in a load failure, we don't dump, so we used to leak the timer. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone): Added a comment. 2014-12-19 Brent Fulgham [Win] Add accessor for serializing HTTP loads https://bugs.webkit.org/show_bug.cgi?id=139817 Reviewed by Mark Lam. * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method. * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also remove some redundant code from the destructor. 2014-12-19 Alexey Proskuryakov Clean up a fix for performance test bot failing to build https://bugs.webkit.org/show_bug.cgi?id=139818 Reviewed by Csaba Osztrogonác. The "_1" in step name was annoying. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (CleanBuildIfScheduled.start): (RunAndUploadPerfTests): (DownloadAndPerfTestFactory.__init__): (DownloadAndPerfTestWebKit2Factory.__init__): (CleanBuildUnconditionally): Deleted. (CleanBuildUnconditionally.start): Deleted. 2014-12-19 Csaba Osztrogonác REGRESSION(r177535): It broke the GTK performance bot https://bugs.webkit.org/show_bug.cgi?id=139811 Reviewed by Carlos Garcia Campos. Trigger clean build only on mac platform. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (DownloadAndPerfTestFactory.__init__): (DownloadAndPerfTestWebKit2Factory.__init__): 2014-12-18 KwangHyuk Kim Unreviewed, moved myself to the list of committers. * Scripts/webkitpy/common/config/contributors.json: 2014-12-18 Brent Fulgham [Win] Update DumpRenderTree to more closely match Mac version https://bugs.webkit.org/show_bug.cgi?id=139799 Reviewed by Tim Horton. * DumpRenderTree/win/AccessibilityControllerWin.cpp: (AccessibilityController::accessibleElementById): Correct use of BSTR to avoid leak. * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and update to match Mac version more closely. (dumpFramesAsText): (dump): (resetDefaultsToConsistentValues): (resetWebViewToConsistentStateBeforeTesting): (sizeWebViewForCurrentTest): (runTest): (openWindows): (windowToWebViewMap): (createWebViewAndOffscreenWindow): (sharedCFURLCache): (initializeGlobalsFromCommandLineOptions): (main): * DumpRenderTree/win/TestRunnerWin.cpp: Ditto. (TestRunner::addDisallowedURL): (TestRunner::applicationCacheDiskUsageForOrigin): (TestRunner::syncLocalStorage): (TestRunner::localStorageDiskUsageForOrigin): (TestRunner::observeStorageTrackerNotifications): (TestRunner::clearApplicationCacheForOrigin): (TestRunner::originsWithApplicationCache): (TestRunner::deleteAllLocalStorage): (TestRunner::setStorageDatabaseIdleInterval): (TestRunner::closeIdleLocalStorageDatabases): (TestRunner::originsWithLocalStorage): (TestRunner::deleteLocalStorageForOrigin): (TestRunner::copyDecodedHostName): (TestRunner::copyEncodedHostName): (TestRunner::keepWebHistory): (TestRunner::numberOfPendingGeolocationPermissionRequests): (TestRunner::setAppCacheMaximumSize): (TestRunner::setCustomPolicyDelegate): (TestRunner::goBack): (TestRunner::setDefersLoading): (TestRunner::setDomainRelaxationForbiddenForURLScheme): (TestRunner::setMockDeviceOrientation): (TestRunner::setMockGeolocationPosition): (TestRunner::setMockGeolocationPositionUnavailableError): (TestRunner::setIconDatabaseEnabled): (TestRunner::setMainFrameIsFirstResponder): (TestRunner::setSpatialNavigationEnabled): (TestRunner::setPluginsEnabled): (TestRunner::setAutomaticLinkDetectionEnabled): (TestRunner::setUseDashboardCompatibilityMode): (TestRunner::dispatchPendingLoadRequests): (TestRunner::findString): (TestRunner::setCacheModel): (TestRunner::apiTestNewWindowDataLoadBaseURL): (TestRunner::setWebViewEditable): (TestRunner::authenticateSession): (TestRunner::abortModal): (TestRunner::setSerializeHTTPLoads): (TestRunner::addChromeInputField): (TestRunner::removeChromeInputField): (TestRunner::focusWebView): (TestRunner::setBackingScaleFactor): (TestRunner::grantWebNotificationPermission): (TestRunner::denyWebNotificationPermission): (TestRunner::removeAllWebNotificationPermissions): (TestRunner::simulateWebNotificationClick): 2014-12-18 Gavin Barraclough Add strong typing to RefCounter interface, return value as a bool. https://bugs.webkit.org/show_bug.cgi?id=139776 Reviewed by Geoff Garen. Currently all token vended by a RefCounter have the same type - Ref. This means there is no compile time type checking to prevent mistakes. Update the count() method to token<>(), templated on type used to identify the token being returned. Calls to token() will return a result of type RefCounter::Token. There are a few problems with the fact the counter will return you an exact count of the number of outstanding tokens: - It is desirable to only fire the callback on zero-edge changes; it is more consistent to do so if the value is only readable as a boolean. - It is desirable to provide the value as an argument to the callback, however to make this useful for integer values it is also necessary to indicate the direction of change (0->1 is often interesting where 2->1 is not). - There is a mismatch between the precision of returning a count, and the inherent imprecision of a token based mechanism, where it may be difficult to guarantee absolutely no unnecessary refcount churn, and thus unintentional counter values. * TestWebKitAPI/Tests/WTF/RefCounter.cpp: (TestWebKitAPI::TEST): - update API test. 2014-12-18 Alexey Proskuryakov Disable retries on Mac Release WK2 testers https://bugs.webkit.org/show_bug.cgi?id=139798 Reviewed by Simon Fraser. * BuildSlaveSupport/build.webkit.org-config/config.json: 2014-12-18 Alexey Proskuryakov Perf tests frequently fail saying "build not up to date" https://bugs.webkit.org/show_bug.cgi?id=139786 Illegitimately yet authoritatively reviewed by Lucas Forschler. Undo the rest of the first fix, and implement the behavior differently. is_clean isn't automatically forwarded from config.json to properties. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (CleanBuildUnconditionally): (CleanBuildUnconditionally.start): (DownloadAndPerfTestFactory.__init__): (DownloadAndPerfTestWebKit2Factory.__init__): 2014-12-18 Alexey Proskuryakov Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl. I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory found nothing. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (BuildAndPerfTestFactory): (BuildAndPerfTestWebKit2Factory): 2014-12-18 Alexey Proskuryakov Perf tests frequently fail saying "build not up to date" https://bugs.webkit.org/show_bug.cgi?id=139786 Reviewed by Ryosuke Niwa. Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build directory to get rid of stale precompiled headers, and let it rebuild DumpRenderTree each time, that's fast. Also, removed unused "build and perf test" code. * BuildSlaveSupport/build.webkit.org-config/config.json: 2014-12-18 Brent Fulgham [Win] Unreviewed gardening. Reorder file contents to match Mac version. Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes it easier to see what steps are missing when running under Windows. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::callShouldCloseOnWebView): (TestRunner::clearAllApplicationCaches): (TestRunner::applicationCacheDiskUsageForOrigin): (TestRunner::syncLocalStorage): (TestRunner::localStorageDiskUsageForOrigin): (TestRunner::observeStorageTrackerNotifications): (TestRunner::clearApplicationCacheForOrigin): (TestRunner::originsWithApplicationCache): (TestRunner::clearAllDatabases): (TestRunner::deleteAllLocalStorage): (TestRunner::setStorageDatabaseIdleInterval): (TestRunner::closeIdleLocalStorageDatabases): (TestRunner::originsWithLocalStorage): (TestRunner::deleteLocalStorageForOrigin): (TestRunner::numberOfPendingGeolocationPermissionRequests): (jsStringRefToWString): (TestRunner::setAppCacheMaximumSize): (TestRunner::setDatabaseQuota): (TestRunner::goBack): (TestRunner::setDefersLoading): (TestRunner::setDomainRelaxationForbiddenForURLScheme): (TestRunner::setAutomaticLinkDetectionEnabled): (TestRunner::dispatchPendingLoadRequests): (TestRunner::overridePreference): (TestRunner::removeAllVisitedLinks): (TestRunner::waitForPolicyDelegate): (TestRunner::resetPageVisibility): (TestRunner::setPageVisibility): (TestRunner::grantWebNotificationPermission): (TestRunner::denyWebNotificationPermission): (TestRunner::removeAllWebNotificationPermissions): (TestRunner::simulateWebNotificationClick): (TestRunner::simulateLegacyWebNotificationClick): 2014-12-18 Brent Fulgham [Win] Correct Windows tests after Bug 139149 (edit) https://bugs.webkit.org/show_bug.cgi?id=139781 Reviewed by Anders Carlsson. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache interface. 2014-12-18 Simon Fraser [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts https://bugs.webkit.org/show_bug.cgi?id=139748 Reviewed by Daniel Bates. Staging change to support --ios-sim and --ios-simulator temporarily until the bots have all been updated. * Scripts/webkitpy/port/factory.py: (platform_options): 2014-12-18 Simon Fraser Build more of TestWebKitAPI for iOS https://bugs.webkit.org/show_bug.cgi?id=139747 Reviewed by Daniel Bates. Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES, which excluded some tests that should be run for iOS. Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is available (i.e. Mac OS X), and most files use that. Some files with Mac-only functionality (ActionMenus, Downloads) use #if PLATFORM(MAC). Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory to share code between Mac and iOS. * TestWebKitAPI/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: * TestWebKitAPI/InjectedBundleController.cpp: * TestWebKitAPI/InjectedBundleMain.cpp: * TestWebKitAPI/JavaScriptTest.cpp: * TestWebKitAPI/PlatformUtilities.cpp: * TestWebKitAPI/PlatformUtilities.h: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp: * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp: * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: * TestWebKitAPI/Tests/WebKit2/Find.cpp: * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp: * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp: * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp: * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp: * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm: * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp: * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/WKString.cpp: * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp: * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp: * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm. (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm: * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp. (TestWebKitAPI::Util::run): (TestWebKitAPI::Util::sleep): (TestWebKitAPI::Util::toSTD): * TestWebKitAPI/config.h: * TestWebKitAPI/mac/JavaScriptTestMac.mm: * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: (TestWebKitAPI::Util::run): Deleted. (TestWebKitAPI::Util::sleep): Deleted. (TestWebKitAPI::Util::toSTD): Deleted. 2014-12-18 Dániel Bátyai [GTK] Add support for FTL JIT on ARM64 https://bugs.webkit.org/show_bug.cgi?id=139677 Reviewed by Csaba Osztrogonác. * gtk/jhbuild-optional.modules: * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added. * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added. 2014-12-18 Adrian Perez de Castro [GTK] Implement webkit_web_view_is_playing_audio() https://bugs.webkit.org/show_bug.cgi?id=138918 Reviewed by Carlos Garcia Campos. Add test case case for webkit_web_view_is_playing_audio() and the WebKitWebView::is-playing-audio property. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (urlForResource): Utility function to get URLs pointing to resources under the Tools/TestWebKitAPI/Tests/WebKit2/ directory. (testWebViewIsPlayingAudio): Added. (beforeAll): * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h: (getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK API tests resources directory, or the WebKit2 C API tests resources directory. The default value of the flag is to use the WebKit2 GTK one, to avoid having to change existing tests. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (isPlayingAudioChanged): Added. (WebViewTest::waitUntilIsPlayingAudioChanged): Added. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: 2014-12-18 Carlos Alberto Lopez Perez [GTK] [EFL] Enable per_test_timeout https://bugs.webkit.org/show_bug.cgi?id=139771 Reviewed by Csaba Osztrogonác. This is needed to make WKTR use either the default port timeout, or the user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests. Otherwise WTR will use the default (30 seconds after r177363 and r177471). * Scripts/webkitpy/port/efl.py: (EflPort.supports_per_test_timeout): Enabled. * Scripts/webkitpy/port/gtk.py: (GtkPort.supports_per_test_timeout): Enabled. 2014-12-17 Lucas Forschler Move Apple buildbot slaves to their new home. Reviewed by Roger Fong. * BuildSlaveSupport/build.webkit.org-config/config.json: 2014-12-17 Alexey Proskuryakov REGRESSION (r177363): Gtk and Efl testing is broken https://bugs.webkit.org/show_bug.cgi?id=139734 Reviewed by Simon Fraser. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner.__init__): Remove timeout adjustment from here, because it affected both script and tool timeout. This is still the right place for this logic, but it would be a larger refactoring than I can do right now. * Scripts/webkitpy/port/base.py: (Port.supports_per_test_timeout): Added a FIXME. (Port.default_timeout_ms): Now that the effective timeout is longer, change this to avoid making tests take more time. * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here. (Driver._check_for_driver_timeout): Fix the timeout detection. (Driver._read_block): Actually use the timeout detection code. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): Use TestRunner default timeout when there isn't a timeout passed from command line for the test. * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms): Update results for the new default. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.test_hung_thread): Restore a test that I previously deleted, it was actually a good one. 2014-12-17 Commit Queue Unreviewed, rolling out r177456. https://bugs.webkit.org/show_bug.cgi?id=139749 Broke webkitpy and Mac tests (Requested by ap on #webkit). Reverted changeset: "REGRESSION (r177363): Gtk and Efl testing is broken" https://bugs.webkit.org/show_bug.cgi?id=139734 http://trac.webkit.org/changeset/177456 2014-12-17 Alexey Proskuryakov REGRESSION (r177363): Gtk and Efl testing is broken https://bugs.webkit.org/show_bug.cgi?id=139734 Reviewed by Simon Fraser. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner.__init__): Remove timeout adjustment from here, because it affected both script and tool timeout. This is still the right place for this logic, but it would be a larger refactoring than I can do right now. * Scripts/webkitpy/port/base.py: (Port.supports_per_test_timeout): Added a FIXME. (Port.default_timeout_ms): Now that the effective timeout is longer, change this to avoid making tests take more time. * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): Use TestRunner default timeout when there isn't a timeout passed from command line for the test. 2014-12-17 Carlos Garcia Campos [GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded https://bugs.webkit.org/show_bug.cgi?id=139725 Reviewed by Martin Robinson. The timeout is already in milliseconds, so we don't need to do any conversion. * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded): 2014-12-17 Hunseop Jeong [EFL]Fix build warning in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=139723 Reviewed by Darin Adler. The warning is caused by the compiler wanting the first argument to be a string literal, not a dynamically created string. * MiniBrowser/efl/main.c: (quit): 2014-12-16 Sam Weinig TestWebKitAPI should use a static lib to support both Mac and iOS cleanly https://bugs.webkit.org/show_bug.cgi?id=139718 Reviewed by Mark Rowe. Change TestWebKitAPI to be more like DumpRenderTree by moving all the source files into a static lib which the command line utility can link link against. This will allow us to create a TestWebKitAPI.app that can run on iOS. * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 2014-12-16 Alexey Proskuryakov Sort out timeout implementations in DRT and WKTR https://bugs.webkit.org/show_bug.cgi?id=139671 Remove an obsolete test that doesn't capture how run-webkit-tests interacts with the tool. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.test_hung_thread): 2014-12-15 Alexey Proskuryakov Sort out timeout implementations in DRT and WKTR https://bugs.webkit.org/show_bug.cgi?id=139671 Reviewed by Simon Fraser. Test timeout implementation had many deficiencies, please see the bug for details. Most notably, we shouldn't have the tool confused about timeouts vs. failures, and [ Slow ] modifiers should work a lot better. * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner): * DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout): * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump): DumpRenderTree already read the --timeout option from command line, and webkitpy was already configured to pass it on Mac and iOS. Let's actually use it. TestCommand already had the same 30 second default, so this doesn't change behavior when DRT is ran manually without the option. Windows DumpRenderTree will need to be fixed separately (that's easy). * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()): Don't print the timeout message to stdout to match WebKitTestRunner. It would be slightly better to use stderr in both, as this is an out of band message, but that's a larger refactoring, and the difference is minimal in practice. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner.__init__): Ensure that script and tool timeouts are substantially different. We want the tool to reliably detect timeouts that can be detected, and not race with the script for that. * Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2 timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value is honored inmore cases, that could make tests run slower. * Scripts/webkitpy/port/driver.py: (Driver.__init__): (Driver.run_test): (Driver.cmd_line): (Driver._check_for_driver_timeout): Detect tests that have the timeout output, and make these have the proper Timeout result. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): Remove an incorrect recent change - 80 * 1000 is 80 seconds, not 80 milliseconds. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setCustomTimeout): Deleted. * WebKitTestRunner/InjectedBundle/TestRunner.h: (WTR::TestRunner::setCustomTimeout): * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded): * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded): * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded): * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded): Updated to use a timeout passed from UI process, which used to be ignored. * WebKitTestRunner/TestController.cpp: (WTR::TestController::TestController): (WTR::TestController::runUntil): (WTR::TestController::getCustomTimeout): Deleted. * WebKitTestRunner/TestController.h: Delete unused m_timeout. First, it was always 0, and second, we don't need it at all. Changed default message timeouts to match new run-webkit-tests timeout. These don't affect ports where timeout is passed per test (shouldn't they all be like that?). * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): (WTR::TestInvocation::setCustomTimeout): Deleted. * WebKitTestRunner/TestInvocation.h: (WTR::TestInvocation::setCustomTimeout): (WTR::TestInvocation::customTimeout): Ditto. 2014-12-16 Grzegorz Czajkowski [EFL] Add logging domain for MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=139642 Reviewed by Gyuyoung Kim. Similarly to EWebKit2, provide logging facility for MiniBrowser based on Eina Log module to have a convenient way to display all/subset/none messages for EFL based libraries and MiniBrowser. Usage: 1. Disable all messages: EINA_LOG_LEVEL=0 ./Tools/Scripts/run-launcher --efl 2. Enable all messages: EINA_LOG_LEVEL=7 ./Tools/Scripts/run-launcher --efl 3. Enable MiniBrowser and EWebkit2 messages only: EINA_LOG_LEVELS="minibrowser:7,ewebkit2:7" ./Tools/Scripts/run-launcher --efl More information and examples you can find here: http://docs.enlightenment.org/auto/eet/tutorial_log_page.html * MiniBrowser/efl/main.c: (on_mouse_wheel): (on_window_resize): (save_page_contents_callback): (script_execute_callback): (on_key_down): (on_download_request): (on_download_finished): (on_download_failed): (quit): (on_refresh_button_clicked): (on_stop_button_clicked): (navigation_button_longpress_process): (on_popup_menu_item_clicked): (popup_menu_populate): (on_popup_menu_show): (on_window_create): (context_menu_item_selected_cb): (context_menu_populate): (on_context_menu_show): (on_context_menu_hide): (on_navigation_policy_decision): (window_create): (parse_cookies_policy): (elm_main): (has_scheme): (list_item_label_get): (on_popup_menu_hide): (on_window_close): (on_home_button_clicked): Replace locally info() macro with newly introduced one which uses Eina Log module. There is no logic change. 2014-12-15 Dániel Bátyai [EFL] FTL JIT not working on ARM64 https://bugs.webkit.org/show_bug.cgi?id=139295 Reviewed by Michael Saboff. Added patches for llvm to add ARM64 support for FTL JIT * efl/jhbuild.modules: * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added. * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added. 2014-12-15 Timothy Horton Move Said to the committers section. * Scripts/webkitpy/common/config/contributors.json: 2014-12-15 Timothy Horton Implement Data Detectors immediate actions for WebKit2 https://bugs.webkit.org/show_bug.cgi?id=139617 Reviewed by Beth Dakin. * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: (TestWebKitAPI::TEST): Temporarily disable the action menu tests while the underlying code is in flux. 2014-12-14 Andreas Kling Replace PassRef with Ref/Ref&& across the board. Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/Ref.cpp: (TestWebKitAPI::passWithRef): (TestWebKitAPI::TEST): (TestWebKitAPI::passWithPassRef): Deleted. * TestWebKitAPI/Tests/WTF/RefCounter.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/RefPtr.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: (TestWebKitAPI::createTestValue): 2014-12-13 Grzegorz Czajkowski [EFL] MiniBrowser's window_create may return NULL https://bugs.webkit.org/show_bug.cgi?id=139585 Reviewed by Gyuyoung Kim. Move NULL checking before using object which window_create returns. * MiniBrowser/efl/main.c: (elm_main): 2014-12-12 Alexey Proskuryakov Layout Test http/tests/loading/307-after-303-after-post.html is flaky https://bugs.webkit.org/show_bug.cgi?id=73030 Reviewed by Anders Carlsson. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon database to empty to avoid having it fetch default favicons at random times. DumpRenderTree also disables it, and also it has a way for tests to temporarily enable it. 2014-12-12 Lucas Forschler Update Apple owned build slaves after infrastructure update. Reviewed by Ryosuke Niwa. * BuildSlaveSupport/build.webkit.org-config/config.json: 2014-12-11 Carlos Alberto Lopez Perez [GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild. https://bugs.webkit.org/show_bug.cgi?id=139537 Reviewed by Carlos Garcia Campos. * jhbuild/jhbuild-wrapper: Pass the port name in the invocation of get_dependencies_path(). * jhbuild/jhbuildutils.py: (get_dependencies_path): Fix the function to return the new dependencies path: DependenciesPORT. (enter_jhbuild_environment_if_available): Pass the port name when invoking get_dependencies_path(). 2014-12-10 Lucas Forschler Update Apple owned build slaves. Rubber-stamped by Dana Burkart. * BuildSlaveSupport/build.webkit.org-config/config.json: 2014-12-10 Daniel Bates [iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app timeout instead of test failure https://bugs.webkit.org/show_bug.cgi?id=139525 Reviewed by Zalan Bujtas. Increase the default process timeout limit in run-webkit-tests to 80ms to prevent run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps output. Following , DumpRenderTree.app waits for the WebThread to spin its run loop before dumping its output. A test that calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone() before DumpRenderTree.app's watchdog timer expires may be incorrectly reported by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure because run-webkit-tests may terminate a DumpRenderTree.app process when it exceeds its process time limit (defaults to 35ms) regardless of whether such a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): 2014-12-09 Gustavo Noronha Silva [GTK][WK2] Add HTML5 Notifications support https://bugs.webkit.org/show_bug.cgi?id=61140 Reviewed by Carlos Garcia Campos. * Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewNotification): (beforeAll): * MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests. (permissionRequestDialogCallback): (webViewDecidePermissionRequest): (geolocationRequestDialogCallback): Deleted. 2014-12-09 Benjamin Poulain Fix webkitpy test expectation Not sure what I messed up, but TOTAL_SKIPS was not right. * Scripts/webkitpy/port/test.py: 2014-12-09 Benjamin Poulain Remove virtual test support from webkitpy https://bugs.webkit.org/show_bug.cgi?id=139427 Reviewed by Alexey Proskuryakov. It seems that the only concrete client of virtual tests is the unit tests :D This patch tries to clean as much useless code as possible. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.test_tolerance): (RunTest.test_virtual): Deleted. * Scripts/webkitpy/layout_tests/views/printing.py: (Printer._print_test_trace): * Scripts/webkitpy/port/base.py: (Port.expected_filename): (Port.tests): (Port.test_isfile): (Port.test_isdir): (Port.sample_process): (Port.find_system_pid): (Port.test_expectations_file_position): (Port.virtual_test_suites): Deleted. (Port): Deleted. (Port.populated_virtual_test_suites): Deleted. (Port._virtual_tests): Deleted. (Port.lookup_virtual_test_base): Deleted. (Port.lookup_virtual_test_args): Deleted. (VirtualTestSuite): Deleted. (VirtualTestSuite.__init__): Deleted. (VirtualTestSuite.__repr__): Deleted. * Scripts/webkitpy/port/base_unittest.py: (PortTest.test_test_exists): (PortTest.test_test_isfile): (PortTest.test_test_isdir): (PortTest.test_tests): * Scripts/webkitpy/port/driver.py: (DriverProxy.run_test): Deleted. * Scripts/webkitpy/port/test.py: (TestPort._skipped_tests_for_unsupported_features): (TestPort.all_baseline_variants): (TestPort.virtual_test_suites): Deleted. * Scripts/webkitpy/tool/commands/queries.py: (PrintBaselines.__init__): (PrintBaselines.execute): * Scripts/webkitpy/tool/commands/queries_unittest.py: (PrintBaselinesTest.test_basic): (PrintBaselinesTest.test_multiple): (PrintBaselinesTest.test_csv): 2014-12-09 Csaba Osztrogonác Blink Merge: Remove 'http_lock' code from webkitpy https://bugs.webkit.org/show_bug.cgi?id=136722 Reviewed by Alexey Proskuryakov. Based on Blink commit by Dirk Pranke https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: (LayoutTestRunner.__init__): (LayoutTestRunner.run_tests): (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock. (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: (FakePrinter.flush): (LayoutTestRunnerTests._runner): (LayoutTestRunnerTests._run_tests): (LayoutTestRunnerTests.test_servers_started): (LockCheckingRunner): Deleted. (LockCheckingRunner.__init__): Deleted. (LockCheckingRunner.handle_finished_list): Deleted. (LayoutTestRunnerTests.test_http_locking): Deleted. * Scripts/webkitpy/port/base.py: (Port.__init__): (Port.to.http_server_supports_ipv6): (Port.to.stop_websocket_server): (Port.to.acquire_http_lock): Deleted. (Port.to.release_http_lock): Deleted. * Scripts/webkitpy/port/http_lock.py: Removed. * Scripts/webkitpy/port/http_lock_unittest.py: Removed. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.show_results_html_file): (IOSSimulatorPort.acquire_http_lock): Deleted. (IOSSimulatorPort): Deleted. (IOSSimulatorPort.release_http_lock): Deleted. * Scripts/webkitpy/port/mac.py: (MacPort.show_results_html_file): (MacPort): Deleted. (MacPort.acquire_http_lock): Deleted. (MacPort.release_http_lock): Deleted. * Scripts/webkitpy/port/mock_drt.py: (MockDRTPort.start_websocket_server): (MockDRTPort.stop_websocket_server): (MockDRTPort.acquire_http_lock): Deleted. (MockDRTPort.release_http_lock): Deleted. * Scripts/webkitpy/port/mock_drt_unittest.py: (MockDRTPortTest.test_uses_apache): (MockDRTPortTest.integration_test_http_lock): Deleted. * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.assert_servers_are_up): (PortTestCase.integration_test_http_lock): Deleted. * Scripts/webkitpy/port/test.py: (TestPort.start_websocket_server): (TestPort.stop_websocket_server): (TestPort.acquire_http_lock): Deleted. (TestPort.release_http_lock): Deleted. 2014-12-09 Alberto Garcia convertToUTF8String converts null string to empty string https://bugs.webkit.org/show_bug.cgi?id=133904 Reviewed by Carlos Garcia Campos. Test that trying to get the value of a non-existent attribute returns 0 instead of an empty string. * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: (WebKitDOMNodeTest::testInsertion): 2014-12-09 Joanmarie Diggs [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2 https://bugs.webkit.org/show_bug.cgi?id=139070 Reviewed by Carlos Garcia Campos. * gtk/jhbuild.modules: 2014-12-08 Tim Horton Add action menu tests https://bugs.webkit.org/show_bug.cgi?id=139156 Reviewed by Dean Jackson. * TestWebKitAPI/PlatformWebView.h: * TestWebKitAPI/mac/PlatformWebViewMac.mm: (TestWebKitAPI::PlatformWebView::PlatformWebView): Add a mechanism allowing tests to provide their own WKView subclass. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added. Add a file with lots of menu targets. * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added. (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]): (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]): (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]): Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process. (-[ActionMenusTestWKView _setOverrideActionMenuItems:]): (TestWebKitAPI::didFinishLoadForFrameCallback): (TestWebKitAPI::didFinishDownloadCallback): (TestWebKitAPI::didCreateDownloadDestinationCallback): Watch downloads and ensure that they match the content we expect. (TestWebKitAPI::watchPasteboardForString): (TestWebKitAPI::watchPasteboardForImage): (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext): (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext): (TestWebKitAPI::javaScriptStringCallback): (TestWebKitAPI::javaScriptBoolCallback): (TestWebKitAPI::callJavaScriptReturningString): (TestWebKitAPI::callJavaScriptReturningBool): (TestWebKitAPI::watchEditableAreaForString): (TestWebKitAPI::waitForVideoReady): (TestWebKitAPI::retrieveSelection): (TestWebKitAPI::retrieveSelectionInElement): (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync): (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled): Add many helpers for testing, especially to make asynchronous things synchronous. (TestWebKitAPI::windowPointForTarget): (TestWebKitAPI::inset8): Hard-code points in action-menu-targets.html for hit testing. (TestWebKitAPI::TEST): Add a suite of tests for WebKit2 action menus. * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added. (TestWebKitAPI::createActionContextForPhoneNumber): (TestWebKitAPI::ActionMenuTest::ActionMenuTest): (TestWebKitAPI::ActionMenuTest::prepareForActionMenu): (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint): (TestWebKitAPI::ActionMenuTest::drawRect): (TestWebKitAPI::ActionMenuTest::didCreatePage): Add a bundle with a PageOverlay and a actionContextForResultAtPoint override, so that we can test that infrastructure. 2014-12-08 Philippe Normand [GTK] UserMedia Permission Request API https://bugs.webkit.org/show_bug.cgi?id=136449 Reviewed by Carlos Garcia Campos. The GTK version of the MiniBrowser has gained UserMedia permission request support. * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page requires user permission to access audio/video devices. (permissionRequestDialogCallback): (webViewDecidePermissionRequest): (geolocationRequestDialogCallback): Deleted. 2014-12-08 Anders Carlsson Add a stubbed out method for clearing out the website data store https://bugs.webkit.org/show_bug.cgi?id=139404 Reviewed by Antti Koivisto. Add a debug menu item for testing clearing of website data. * MiniBrowser/mac/MainMenu.xib: * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController clearWebsiteData:]): 2014-12-07 Gwang Yoon Hwang Update style checker to deal with "const override" https://bugs.webkit.org/show_bug.cgi?id=139371 Reviewed by Csaba Osztrogonác. check-webkit-style shouldn't complain about an open brace to start a line after a function definition with const override. * Scripts/webkitpy/style/checkers/cpp.py: (check_braces): * Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest.test_brace_at_begin_of_line): 2014-12-07 Carlos Garcia Campos [GTK] Fix GObject DOM bindings API break tests after r176920 https://bugs.webkit.org/show_bug.cgi?id=139368 Reviewed by Gustavo Noronha Silva. Remove the @version from the symbol name before comparing. * gtk/check-for-webkitdom-api-breaks: (read_expected_api): 2014-12-07 Carlos Garcia Campos Remove the option to automatically update the GObject DOM bindings symbols file https://bugs.webkit.org/show_bug.cgi?id=139366 Reviewed by Martin Robinson. It's currently broken, because symbols now need to be in a specific order. Now that the symbols file only contains stable API, it's not a problem to manually update it every time new API is added. * gtk/check-for-webkitdom-api-breaks: (read_expected_api): (check_api): (write_expected_api): Deleted. 2014-12-07 Carlos Garcia Campos [GTK] Use GMainLoopSource in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=138831 Reviewed by Sergio Villar Senin. * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: (WTR::TestRunner::platformInitialize): (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer): (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded): (WTR::waitToDumpWatchdogTimerCallback): Deleted. * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::notifyDone): (WTR::TestController::platformRunUntil): (WTR::cancelTimeout): Deleted. 2014-12-07 Carlos Garcia Campos [GTK] Missing API detected in GObject DOM bindings after r176630 https://bugs.webkit.org/show_bug.cgi?id=139201 Reviewed by Gustavo Noronha Silva. Handle deprecated symbols again when generating the GObject DOM bindings documentation. * gtk/webkitdom.py: (WebKitDOMDocGenerator): (WebKitDOMDocGenerator.is_deprecated_symbol_file): (WebKitDOMDocGenerator.generate): (WebKitDOMDocGeneratorSections.__init__): (WebKitDOMDocGeneratorSections._find_deprecated_symbols): (WebKitDOMDocGeneratorSections.write_section): 2014-12-07 Csaba Osztrogonác [EFL][jhbuild] Fix libsoup build with clang https://bugs.webkit.org/show_bug.cgi?id=139088 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: * efl/patches/soup-clang-warning-fix1.patch: Added. * efl/patches/soup-clang-warning-fix2.patch: Added. 2014-12-06 Alexey Proskuryakov [Mac] DumpRenderTree sets storage directory incorrectly https://bugs.webkit.org/show_bug.cgi?id=139347 Reviewed by Dan Bernstein. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): Don't use user defaults to pass per-instance paths, as user defaults are shared across all instances. 2014-12-05 Chris Fleizach AX: I cannot activate links on the mobile version of news.google.com https://bugs.webkit.org/show_bug.cgi?id=139330 Reviewed by Simon Fraser. Implement press for iOS. * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::press): 2014-12-05 Daniel Bates [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor() https://bugs.webkit.org/show_bug.cgi?id=139326 Reviewed by Anders Carlsson. Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor() to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot using the same scale factor as used in WebKit. * DumpRenderTree/ios/PixelDumpSupportIOS.mm: (createBitmapContextFromWebView): 2014-12-05 Anders Carlsson REGRESSION (r176677): All tests crash on Windows https://bugs.webkit.org/show_bug.cgi?id=139321 Reviewed by Alexey Proskuryakov. * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Don't call CFRelease on the url while we have an outstanding pointer to its string, and use the right number of bytes when allocating the testURL buffer. 2014-12-05 Daniel Bates [iOS] DumpRenderTree produces many reference test mismatches https://bugs.webkit.org/show_bug.cgi?id=139314 Reviewed by Simon Fraser. Fixes an issue where the scale factor used to render the snapshot taken by DumpRenderTree may differ from the device scale factor. In particular, the scale factor used to render a snapshot of a test may differ from the scale factor used to render the snapshot of its expected result. Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to snapshot the UIWebBrowserView. This SPI always render using a scale factor of one when the backing store for the LegacyTileLayer objects were out-of- date regardless of the device scale factor. Instead we should use UIImage and CALayer API to perform the snapshot with respect to the device scale factor. Additionally write iOS pixel dump support logic in terms of existing DumpRenderTree abstractions so as to support generating and comparing pixel dump checksums as well as make the iOS code more consistent with the logic used by other ports. * DumpRenderTree/PixelDumpSupport.cpp: (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard. * DumpRenderTree/ios/PixelDumpSupportIOS.mm: (BitmapContext::createFromUIImage): Added. (BitmapContext::pixelData): Added. (BitmapContext::BitmapContext): Added. (computeMD5HashStringForBitmapContext): Added. (dumpBitmap): Added. (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here. (dumpWebViewAsPixelsAndCompareWithExpected): Deleted. 2014-12-05 Anders Carlsson Give all web pages a website data store https://bugs.webkit.org/show_bug.cgi?id=139317 Reviewed by Tim Horton. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate newPrivateWindow:]): Don't release the controller - it's implicitly retained by the window. 2014-12-05 Daniel Bates [iOS] DumpRenderTree fails to render every other test when pixel tests are on https://bugs.webkit.org/show_bug.cgi?id=137581 Reviewed by Simon Fraser. Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content of the test that proceeded the currently running test. * DumpRenderTree/ios/PixelDumpSupportIOS.mm: (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow] as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles. 2014-12-05 Jer Noble [WTF] MediaTime should support round-tripping from and to doubles. https://bugs.webkit.org/show_bug.cgi?id=139248 Reviewed by Eric Carlson. Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display the MediaTimes after this change. * TestWebKitAPI/Tests/WTF/MediaTime.cpp: (WTF::operator<<): (TestWebKitAPI::TEST): * lldb/lldb_webkit.py: (WTFMediaTime_SummaryProvider): (WTFMediaTimeProvider.timeValueAsDouble): (WTFMediaTimeProvider.isIndefinite): (WTFMediaTimeProvider): (WTFMediaTimeProvider.hasDoubleValue): 2014-12-05 Anders Carlsson Add a private browsing mode to MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=139308 Reviewed by Sam Weinig. * MiniBrowser/mac/AppDelegate.m: (defaultConfiguration): (-[BrowserAppDelegate newWindow:]): (-[BrowserAppDelegate newPrivateWindow:]): * MiniBrowser/mac/MainMenu.xib: * MiniBrowser/mac/WK2BrowserWindowController.h: * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]): (-[WK2BrowserWindowController initWithConfiguration:]): (-[WK2BrowserWindowController dealloc]): (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): 2014-12-04 Alexey Proskuryakov Run http tests parallel https://bugs.webkit.org/show_bug.cgi?id=138958 Reviewed by Daniel Bates. Remove the concept of "locked shard". Now http tests are just like any other tests. We start HTTP and WebSocket servers at the start if we need them, and terminate them when done with all the tests (not when the last http test runs, which is unnecessarily unpredictable). This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the patch, they used to take over 15 minutes. As part of the fix, we no longer pass the number of servers to Apache. I don't think that these parameters did what we wanted them to do; Apache handles the load just fine without them. The change applies to all platforms. I fixed everything I could find on Mac, and Ossy told me that he's been running http tests in parallel for a long time. If there is increased instability for some ports, it will need to be fixed - there is generally nothing special about http tests at this point, and most code is cross-platform in WebKit2. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: (LayoutTestRunner.__init__): (LayoutTestRunner.run_tests): (LayoutTestRunner.start_servers_with_lock): (LayoutTestRunner._handle_started_test): (Worker.handle): (Sharder.__init__): (Sharder.shard_tests): (Sharder._shard_every_file): (Sharder._shard_by_directory): (LayoutTestRunner._handle_finished_test_list): Deleted. (LayoutTestRunner._handle_finished_test_list.find): Deleted. (Sharder._shard_in_two): Deleted. (Sharder): Deleted. (Sharder._resize_shards): Deleted. (Sharder._resize_shards.divide_and_round_up): Deleted. (Sharder._resize_shards.extract_and_flatten): Deleted. (Sharder._resize_shards.split_at): Deleted. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: (FakePrinter.print_workers_and_shards): (LayoutTestRunnerTests.test_servers_started.start_http_server): (LayoutTestRunnerTests.test_servers_started): (SharderTests.get_shards): (SharderTests.test_shard_by_dir): (SharderTests.test_shard_every_file): (SharderTests): Deleted. (SharderTests.test_shard_in_two): Deleted. (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted. (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted. (SharderTests.test_multiple_locked_shards): Deleted. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ManagerTest.test_needs_servers.get_manager): (ManagerTest.integration_test_needs_servers.get_manager): (ManagerTest.test_look_for_new_crash_logs.get_manager): (ManagerTest): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.test_batch_size): (RunTest.test_max_locked_shards): Deleted. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__): * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: (TestLayoutTestApacheHttpd.test_start_cmd): * Scripts/webkitpy/layout_tests/servers/http_server.py: (Lighttpd.__init__): * Scripts/webkitpy/layout_tests/servers/http_server_base.py: (HttpServerBase.__init__): * Scripts/webkitpy/layout_tests/views/printing.py: (Printer.print_workers_and_shards): * Scripts/webkitpy/port/base.py: (Port.default_child_processes): (Port.to.start_http_server): (Port.default_max_locked_shards): Deleted. * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.make_port): (PortTestCase.test_default_max_locked_shards): Deleted. * Scripts/webkitpy/port/test.py: (TestPort.start_http_server): 2014-12-04 Alexey Proskuryakov Don't lock perf tests in run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=139264 Reviewed by Daniel Bates. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: * Scripts/webkitpy/layout_tests/controllers/manager.py: * Scripts/webkitpy/layout_tests/models/test_input.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: 2014-12-03 Alexey Proskuryakov http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it https://bugs.webkit.org/show_bug.cgi?id=139243 Reviewed by Anders Carlsson. We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a chance to allow untrusted certificates. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): Set up more client objects for secondary windows. We may be able to share some of the code with main view creation function, but it's not exactly the same (notably, we do not focus a secondary window when it's done loading). 2014-12-03 Joanmarie Diggs AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed https://bugs.webkit.org/show_bug.cgi?id=139071 Reviewed by Chris Fleizach. Add string value for ATK_ROLE_STATIC in roleToString. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: 2014-12-03 Renato Nagy check-webkit-style is confused by ternary expression inside first member initializer https://bugs.webkit.org/show_bug.cgi?id=136442 Reviewed by Csaba Osztrogonác. * Scripts/webkitpy/style/checkers/cpp.py: (check_member_initialization_list): 2014-12-03 Carlos Alberto Lopez Perez [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed. https://bugs.webkit.org/show_bug.cgi?id=139220 Reviewed by Philippe Normand. * gtk/jhbuild.modules: * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added. 2014-12-03 Zsolt Borbely Remove unused JSC runtime options https://bugs.webkit.org/show_bug.cgi?id=133070 Reviewed by Csaba Osztrogonác. * Scripts/run-jsc-stress-tests: 2014-12-03 Eva Balazsfalvi [EFL] Add subtle crypto to the build system https://bugs.webkit.org/show_bug.cgi?id=138612 Reviewed by Csaba Osztrogonác. * Scripts/webkitperl/FeatureList.pm: 2014-12-02 Joanmarie Diggs AX: [ATK] Table captions and table rows are missing from the accessible hierarchy https://bugs.webkit.org/show_bug.cgi?id=139005 Reviewed by Chris Fleizach. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for ATK_ROLE_CAPTION to roleToString 2014-12-02 Alexey Proskuryakov http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests https://bugs.webkit.org/show_bug.cgi?id=139149 Reviewed by Anders Carlsson. WebKit2 already cleared application caches between runs (although it wasn't entirely effective without WebCore changes in this patch). * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs. * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this function is not implemented on Windows, see below). * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches): Ameded a FIXME. 2014-12-02 Gavin Barraclough Generalize PageActivityAssertionToken https://bugs.webkit.org/show_bug.cgi?id=139106 Reviewed by Sam Weinig. Add an API test for WTF::RefCounter. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added. (TestWebKitAPI::TEST): - added RefCounter test. 2014-12-02 Alexey Proskuryakov [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL https://bugs.webkit.org/show_bug.cgi?id=139174 Reviewed by Simon Fraser. * DumpRenderTree/TestRunner.cpp: * DumpRenderTree/TestRunner.h: Renamed testPathOrURL to testURL, because this variable always contains a URL. * DumpRenderTree/mac/DumpRenderTree.mm: (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming. (testPathFromURL): Moved from FrameLoadDelegate.mm. (runTest): Set crash reporter information here, as we know the exact test URL. * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash reporter information here. * DumpRenderTree/mac/ResourceLoadDelegate.mm: * DumpRenderTree/mac/TestRunnerMac.mm: Updated for testPathOrURL renaming. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know test URL until load starts, so save it into TestRunner now. A new TestRunner object is created for each test. * WebKitTestRunner/InjectedBundle/TestRunner.h: (WTR::TestRunner::testURL): (WTR::TestRunner::setTestURL): Make TestRunner know the test name. For now, it's good enough to have it once load starts, but if we ever need it earlier, we can send it with BeginTest message. * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Use test URL, not currently loading URL for CrashReporter. * WebKitTestRunner/cocoa/CrashReporterInfo.mm: (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon (WebKit1 already had it right). * DumpRenderTree/win/DumpRenderTree.cpp: (sizeWebViewForCurrentTest): (runTest): * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::willSendRequest): Changed Windows DumpRenderTree to also use URL in TestRunner. 2014-12-02 Daniel Bates [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs https://bugs.webkit.org/show_bug.cgi?id=139143 Reviewed by David Kilzer. Similar to the Windows-specific fix in , teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it crashes. Run-webkit-tests will record as crashing the test associated with the DumpRenderTree instance that wrote that string. Currently almost all of the DumpRenderTree.app crashes are recorded by run- webkit-tests as a time-out because ReportCrash(8) delays delivery of the process exit notification for DumpRenderTree.app to LayoutTestRelay, which launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay (since it exceeded the time-out time limit) before it can inform rub-webkit-tests about a crash. Additionally, update the crash message format written to standard error when LayoutTestRelay detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the crash message format used by WebKitTestRunner when it detects that the WebProcess crashed. Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app when they crash in their test machinery logic/UI process code. * DumpRenderTree/mac/DumpRenderTree.mm: (writeCrashedMessageOnFatalError): Added. (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals: SIGILL, SIGFPE, SIGBUS and SIGSEGV. * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format similar to the format used by WebKitTestRunner so that run-webkit-tests will collect the crash logs for WebKitTestRunner/DumpRenderTree.app. * Scripts/webkitpy/port/driver.py: (Driver.__init__): Update comment. (Driver._check_for_driver_crash): Ditto. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled regular expression. This constant is used as an optimization to avoid compiling the same regular expression across invocations of _get_crash_log(). (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be closer to where they are used. 2014-12-01 Anders Carlsson Remove WKBundleRemoveAllVisitedLinks https://bugs.webkit.org/show_bug.cgi?id=139163 Reviewed by Sam Weinig. Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): 2014-12-02 Anders Carlsson Fix Windows build. * DumpRenderTree/win/DumpRenderTree.cpp: (setAlwaysAcceptCookies): 2014-12-02 Eva Balazsfalvi [EFL] Remove edbus dependency from jhbuild https://bugs.webkit.org/show_bug.cgi?id=139130 Reviewed by Gyuyoung Kim. After http://trac.webkit.org/changeset/176555 we don't need it anymore. * efl/jhbuild.modules: 2014-12-02 Philippe Normand [jhbuild] wrong Dependencies path https://bugs.webkit.org/show_bug.cgi?id=139176 Reviewed by Martin Robinson. * Scripts/webkitpy/port/base.py: (Port._should_use_jhbuild): 2014-12-02 Philippe Normand [GStreamer] Bump internal jhbuild versions to 1.4.4 https://bugs.webkit.org/show_bug.cgi?id=138866 Reviewed by Carlos Garcia Campos. * gtk/jhbuild.modules: * gtk/patches/gst-events-arent-gstobjects.patch: Removed. * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed. * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed. 2014-12-01 Commit Queue Unreviewed, rolling out r176566. https://bugs.webkit.org/show_bug.cgi?id=139124 It broke the GTK performance tests. (Requested by clopez on #webkit). Reverted changeset: "[GTK] Use GMainLoopSource in WebKitTestRunner" https://bugs.webkit.org/show_bug.cgi?id=138831 http://trac.webkit.org/changeset/176566 2014-11-29 Anders Carlsson Crash when calling WKPageClose on the originated page from within createNewPage callback https://bugs.webkit.org/show_bug.cgi?id=139099 Reviewed by Sam Weinig. Add a test. * TestWebKitAPI/PlatformWebView.h: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added. (TestWebKitAPI::runJavaScriptAlert): (TestWebKitAPI::createNewPage): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added. * TestWebKitAPI/mac/PlatformWebViewMac.mm: (TestWebKitAPI::PlatformWebView::PlatformWebView): 2014-11-28 Commit Queue Unreviewed, rolling out r176564. https://bugs.webkit.org/show_bug.cgi?id=139093 massive failures on release test bot (Requested by philn on #webkit). Reverted changeset: "[GStreamer] Bump internal jhbuild versions to 1.4.4" https://bugs.webkit.org/show_bug.cgi?id=138866 http://trac.webkit.org/changeset/176564 2014-11-28 Carlos Garcia Campos [GTK] Use GMainLoopSource in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=138831 Reviewed by Sergio Villar Senin. * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: (WTR::TestRunner::platformInitialize): (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer): (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded): (WTR::waitToDumpWatchdogTimerCallback): Deleted. * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::notifyDone): (WTR::TestController::platformRunUntil): (WTR::cancelTimeout): Deleted. 2014-11-24 Philippe Normand [GStreamer] Bump internal jhbuild versions to 1.4.4 https://bugs.webkit.org/show_bug.cgi?id=138866 Reviewed by Carlos Garcia Campos. * gtk/jhbuild.modules: * gtk/patches/gst-events-arent-gstobjects.patch: Removed. * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed. * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed. 2014-11-28 Carlos Garcia Campos [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests https://bugs.webkit.org/show_bug.cgi?id=138834 Reviewed by Sergio Villar Senin. It makes everyting simpler and the tests run faster too, since we don't need to spawn the private bus and wait until the DBus name is registered. The web extension registers a new JavaSCript class with a status method to run the tests, similar to the DBus method. In the UI process side, tests use webkit_web_view_run_java_script() instead of sending a DBus message. * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: (WebKitDOMNodeFilterTest::create): (WebKitDOMNodeFilterTest::testTreeWalker): (WebKitDOMNodeFilterTest::testNodeIterator): (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted. (WebKitDOMNodeFilterTest::runTest): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: (WebKitDOMNodeTest::create): (WebKitDOMNodeTest::testHierarchyNavigation): (WebKitDOMNodeTest::testInsertion): (WebKitDOMNodeTest::testTagNames): (WebKitDOMNodeTest::webPageFromArgs): Deleted. (WebKitDOMNodeTest::runTest): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: (WebKitDOMXPathNSResolverTest::create): (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative): (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom): (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted. (WebKitDOMXPathNSResolverTest::runTest): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: (WebKitFrameTest::create): (WebKitFrameTest::testMainFrame): (WebKitFrameTest::testURI): (WebKitFrameTest::testJavaScriptContext): (WebKitFrameTest::webPageFromArgs): Deleted. (WebKitFrameTest::runTest): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: (testWebKitDOMNodeHierarchyNavigation): (testWebKitDOMNodeInsertion): (testWebKitDOMNodeTagNames): (beforeAll): (afterAll): * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: (runTest): (beforeAll): (afterAll): * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: (testWebKitDOMXPathNSResolverNative): (testWebKitDOMXPathNSResolverCustom): (beforeAll): (afterAll): (runTest): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: (webkitFrameTestRun): (beforeAll): (afterAll): * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: (testsMap): (WebProcessTest::add): (WebProcessTest::create): (runTest): (windowObjectClearedCallback): (webkit_web_extension_initialize): (methodCallCallback): Deleted. (webkit_web_extension_initialize_with_user_data): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed. * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::runWebProcessTest): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: 2014-11-28 Csaba Osztrogonác [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules https://bugs.webkit.org/show_bug.cgi?id=139086 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: * efl/patches/libseccomp-pick-up-CC.patch: Added. 2014-11-28 Bartlomiej Gajda [EFL] Add warning if CMake version is too old for building with ninja. https://bugs.webkit.org/show_bug.cgi?id=139055 Reviewed by Gyuyoung Kim. CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have that version in their repositories. * efl/install-dependencies: 2014-11-28 Andrzej Badowski [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table. https://bugs.webkit.org/show_bug.cgi?id=139044 Reviewed by Chris Fleizach. ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell. The proposed solution will enable the use of this method for the object table. Existing test shows the result. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::columnHeaders): 2014-11-27 Ryuan Choi [EFL] Remove E_Dbus dependency https://bugs.webkit.org/show_bug.cgi?id=136355 Reviewed by Gyuyoung Kim. * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes. 2014-11-26 Akos Kiss [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk. https://bugs.webkit.org/show_bug.cgi?id=139047 Reviewed by Carlos Garcia Campos. * efl/jhbuild.modules: * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added. * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed. * gtk/jhbuild-optional.modules: * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added. * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed. 2014-11-25 Tanay C [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll https://bugs.webkit.org/show_bug.cgi?id=138090 Reviewed by Carlos Garcia Campos. * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll (browserWindowZoomIn): Added. (browserWindowZoomOut): Added. (scrollEventCallback): Added. (zoomInCallback): Modified. (zoomOutCallback): Modified. (browserWindowConstructed): Modified. 2014-11-25 Csaba Osztrogonác [EFL] REGRESSION(r176514): It made performance tests fail https://bugs.webkit.org/show_bug.cgi?id=139037 Reviewed by Gyuyoung Kim. * Scripts/webkitpy/port/efl.py: (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR. * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists. 2014-11-24 Michael Catanzaro [GTK] update-webkitgtk-libs fails to build fontconfig https://bugs.webkit.org/show_bug.cgi?id=139032 Reviewed by Martin Robinson. On Fedora, if docbook-utils is installed but docbook-utils-pdf is not, fontconfig will try to generate documentation and fail. * gtk/install-dependencies: 2014-11-24 Carlos Garcia Campos Unreviewed. Fix GTK+ make distcheck. * gtk/manifest.txt: Remove deleted files. 2014-11-24 Krzysztof Czech [EFL] Utilize Eail library to support accessibility in EFL https://bugs.webkit.org/show_bug.cgi?id=137742 Reviewed by Gyuyoung Kim. Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional. * efl/jhbuild-optional.modules: Added. * efl/jhbuild.modules: 2014-11-24 Carlos Garcia Campos [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view() https://bugs.webkit.org/show_bug.cgi?id=139023 Reviewed by Sergio Villar Senin. Rename WebKitWebView/default-context as WebKitWebView/web-context and check we are always using the right context for new web views. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewWebContext): (beforeAll): (testWebViewDefaultContext): Deleted. 2014-11-23 Carlos Garcia Campos [GTK] Add API to override the default local storage directory https://bugs.webkit.org/show_bug.cgi?id=138828 Reviewed by Gustavo Noronha Silva. Add test to check that the local storage directory is created at the path given on construction. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextConfiguration): (beforeAll): * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h: (Test::Test): (Test::~Test): Deleted. 2014-11-21 Zalan Bujtas Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser. https://bugs.webkit.org/show_bug.cgi?id=138981 Reviewed by Simon Fraser. * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]): (-[SettingsController simpleLineLayoutDebugBordersEnabled]): * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController didChangeSettings]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController didChangeSettings]): 2014-11-21 Csaba Osztrogonác Remove http lock code from webkitperl https://bugs.webkit.org/show_bug.cgi?id=138959 Reviewed by Alexey Proskuryakov. * Scripts/webkitperl/httpd.pm: (cleanUp): (extractLockNumber): Deleted. (getLockFiles): Deleted. (getNextAvailableLockNumber): Deleted. (getLockNumberForCurrentRunning): Deleted. (waitForHTTPDLock): Deleted. (scheduleHttpTesting): Deleted. (getWaitTime): Deleted. 2014-11-20 Hunseop Jeong [EFL] The option value of fixed layout is false in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=138830 Reviewed by Gyuyoung Kim. Changed the option value of fixed layout to EINA_TRUE in MiniBrowser. * MiniBrowser/efl/main.c: 2014-11-20 Adrian Perez de Castro [GTK] Provide convenience API in DOM bindings to post messages to user message handlers https://bugs.webkit.org/show_bug.cgi?id=138871 Reviewed by Carlos Garcia Campos. Add a test case for the convenience API for posting user messages added to the DOM bindings. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: (testUserContentManagerMessageFromConvenienceDOMBindings): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (documentLoadedCallback): 2014-11-19 Dana Burkart Work around the fact that different masters may have different names for their codebases. https://bugs.webkit.org/show_bug.cgi?id=138878 Reviewed by Mark Rowe. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: (parseRevisionProperty): Changed. Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in opensource / internal codebase naming convention. 2014-11-19 Chris Fleizach AX: Screen braille input doesn't work on forms. https://bugs.webkit.org/show_bug.cgi?id=138804 Unreviewed build fix. * DumpRenderTree/AccessibilityUIElement.cpp: (AccessibilityUIElement::setValue): 2014-11-19 Chris Fleizach AX: Screen braille input doesn't work on forms. https://bugs.webkit.org/show_bug.cgi?id=138804 Reviewed by Mario Sanchez Prada. Add a method to setValue through the AX API in DRT. * DumpRenderTree/AccessibilityUIElement.cpp: (setValueCallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::setValue): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::setValue): 2014-11-18 Csaba Osztrogonác Remove the WinCairo buildbot https://bugs.webkit.org/show_bug.cgi?id=138805 Reviewed by Alex Christensen. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (appendCustomBuildFlags): * BuildSlaveSupport/test-result-archive: (archiveTestResults): 2014-11-18 Daniel Bates [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt SPI are not available in public SDK https://bugs.webkit.org/show_bug.cgi?id=138802 Reviewed by David Kilzer. Include header MachVMSPI.h instead of including the private header mach/mach_vm.h. * DumpRenderTree/mac/CheckedMalloc.cpp: 2014-11-18 Carlos Garcia Campos Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256. Forgot to fix this test before landing. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewDefaultContext): 2014-11-18 Carlos Garcia Campos [GTK] Add API to create a WebKitWebContext https://bugs.webkit.org/show_bug.cgi?id=138826 Reviewed by Gustavo Noronha Silva. Use a different WebKitWebContext for every test to ensure test cases are independent to each other. Tests using DBus to communicate with the injected bundle extension now use a unique name for the well known DBus name. * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: (beforeAll): Remove comment about the order of the tests and move the success test before the failed one now that tests don't depend on each others. * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: (beforeAll): Remove call to set the web extensions directory, since this is now done for all test in the Test constructor. * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: (beforeAll): Do not create a temporary directory, a temporary data directory is now created for all tests. (afterAll): * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID to the web process test runner. (testWebKitDOMNodeInsertion): Ditto. (testWebKitDOMNodeTagNames): Ditto. (beforeAll): Remove call to set the web extensions directory. * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: (runTest): Pass the web extension ID to the web process test runner. (beforeAll): Remove call to set the web extensions directory. * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: (runTest): Pass the web extension ID to the web process test runner. (beforeAll): Remove call to set the web extensions directory. * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: (createFileAtDestination): Use Test::dataDirectory() as base dir for temporary files. (beforeAll): Do not create a temporary directory. (afterAll): * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: (webkitFrameTestRun): Pass the web extension ID to the web process test runner. (beforeAll): Remove call to set the web extensions directory. * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: (beforeAll): Remove call to set the web extensions directory. * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp: (testProcessPerWebView): Use local member instead of global variable. (testMultiprocessWebViewCreateReadyClose): Ditto. (beforeAll): Do not connect to initialize-web-extensions, Test now connects to the signal for all tests and calls a virtual method that test can override. (afterAll): (initializeWebExtensions): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: (testPrintOperationPrint): Use Test::dataDirectory() as base dir for temporary files. (beforeAll): Do not create a temporary directory. (afterAll): * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: (beforeAll): Remove call to set the web extensions directory. * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: (beforeAll): Remove comment about the tests order. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: (testWebExtensionGetTitle): Build the DBus service name using the web extension ID. (testDocumentLoadedSignal): Ditto. (testWebKitWebViewProcessCrashed): Ditto. (testWebExtensionIsolatedWorld): Ditto. (beforeAll): Remove initialization-user-data test, since now all tests are passing user data to the web extension. (testWebExtensionInitializationUserData): Deleted. (initializeWebExtensions): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: (testSetDirectory): Use the web context member inherited from Test. (testClearDatabase): Ditto. (testGetFaviconURI): Ditto. (beforeAll): Do not create a temporary directory. (afterAll): (webkitFaviconDatabaseFinalizedCallback): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: (UserContentManagerTest::UserContentManagerTest): (beforeAll): Remove call to set the web extensions directory. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextDefault): Check also that a newly create web context is not the default web context. (testWebContextSpellChecker): Use the web context member inherited from Test. (testWebContextLanguages): Ditto. * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (methodCallCallback): Remove GetInitializationUserData method. (webkit_web_extension_initialize_with_user_data): Always create the DBus name using the user data provided. (makeBusName): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: (webkit_web_extension_initialize_with_user_data): Create the DBus name using the user data provided. (webkit_web_extension_initialize): Deleted. * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp: (Test::dataDirectory): Return the temporary data directory. (removeNonEmptyDirectory): Also remove directories recursively. (main): Remove the disk cache directory initialization, since this is now done in the Test constructor. * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h: (Test::initializeWebExtensionsCallback): Call the virtual method initializeWebExtensions() (Test::Test): Create a new WebKitWebContext and initialize it. (Test::~Test): Disconnect initialize-web-extensions signal. (Test::initializeWebExtensions): Set the web extensions directory and user data. * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr. (WebProcessTestRunner::runTest): Build the DBus proxy using a unique name created with the Test web extension ID. (WebProcessTestRunner::proxy): Deleted. * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::WebViewTest): Create the web view with the Test web context. * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user content manager parameter to the constructor. 2014-11-18 ChangSeok Oh [GTK] Mesa build fails over llvm-3.5 https://bugs.webkit.org/show_bug.cgi?id=138825 Reviewed by Gustavo Noronha Silva. OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build. * gtk/jhbuild.modules: * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added. 2014-11-17 Daniel Bates Unreviewed, rolling out r176232. Broke the Mac build. Will investigate offline. Reverted changeset: "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt" https://bugs.webkit.org/show_bug.cgi?id=138802 http://trac.webkit.org/changeset/176232 2014-11-17 Daniel Bates [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt SPI are not available in public SDK https://bugs.webkit.org/show_bug.cgi?id=138802 Reviewed by David Kilzer. Include header MachVMSPI.h instead of including the private header mach/mach_vm.h. * DumpRenderTree/mac/CheckedMalloc.cpp: 2014-11-17 Jake Nielsen Having 30+ flaky failures breaks EWS https://bugs.webkit.org/show_bug.cgi?id=138743 Reviewed by Alexey Proskuryakov. Adds tests to ensure that the problem has been solved. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: (test_first_failure_limit): (test_first_failure_limit_with_some_tree_redness): (test_second_failure_limit): (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness): (test_first_and_second_failure_limit): (test_first_and_clean_failure_limit): (test_first_second_and_clean_failure_limit): (test_very_red_tree_retry): Deleted. Really this was renamed to test_first_second_and_clean_failure_limit. * Scripts/webkitpy/tool/bot/patchanalysistask.py: Makes the appropriate changes to PatchAnalysisTask to make sure that even when the first test run hits the failure limit, it will still try a second run. (PatchAnalysisTask._results_failed_different_tests): (PatchAnalysisTask._test_patch): (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted. 2014-11-17 Ting-Wei Lan [GTK] Add library search paths from LDFLAGS before pkg-config --libs https://bugs.webkit.org/show_bug.cgi?id=136018 Reviewed by Carlos Garcia Campos. It is possible that the order of -L arguments in the output of pkg-config is wrong, which causes the linker to find the wrong version (usually older version) of libraries when running gtkdoc-scangobj. * gtk/gtkdoc.py: (GTKDoc._run_gtkdoc_scangobj): 2014-11-17 Eva Balazsfalvi Bump EFL version to 1.12.0 https://bugs.webkit.org/show_bug.cgi?id=138733 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: 2014-11-16 Joanmarie Diggs AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE https://bugs.webkit.org/show_bug.cgi?id=138771 Reviewed by Chris Fleizach. Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString() * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: 2014-11-15 Joanmarie Diggs AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles. https://bugs.webkit.org/show_bug.cgi?id=138767 Reviewed by Chris Fleizach. Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString(). * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: 2014-11-14 Alexey Proskuryakov Add shortcut macros to Mac TestExpectations https://bugs.webkit.org/show_bug.cgi?id=138729 Reviewed by Simon Fraser. * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros): Add version macros for current OS versions. 2014-11-13 Alexey Proskuryakov https://bugs.webkit.org/show_bug.cgi?id=138628 A patch that doesn't apply is stuck in commit queue Rubber-stamped by David Kilzer. This also hopefully fixes other issues: - a patch that has cq+ flag set by a non-committer kills commit queue; - EWS never reports failing tests, and keeps spinning instead. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla.set_flag_on_attachment): (Bugzilla.obsolete_attachment): Apply the fix from r174797 to more places. 2014-11-13 Dan Bernstein Policy client not called for navigations through the page cache https://bugs.webkit.org/show_bug.cgi?id=138703 Reviewed by Alexey Proskuryakov. * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm: (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]): (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): 2014-11-13 Joanmarie Diggs AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects https://bugs.webkit.org/show_bug.cgi?id=137867 Reviewed by Chris Fleizach. Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be able to test for the presence of ATK_ROLE_INVALID. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::role): 2014-11-13 Juergen Ributzka Update the "combineModules" script to handel more LLVM metadata. https://bugs.webkit.org/show_bug.cgi?id=138514 Reviewed by Filip Pizlo. * ReducedFTL/combineModules.rb: 2014-11-13 Myles C. Maxfield Allow constructing a base PassRef with a derived Ref https://bugs.webkit.org/show_bug.cgi?id=138701 Reviewed by Andreas Kling * TestWebKitAPI/Tests/WTF/Ref.cpp: (TestWebKitAPI::passWithPassRef): (TestWebKitAPI::passWithPassRefPtr): (TestWebKitAPI::TEST): 2014-11-05 Ada Chan Implement new plug-in API for muting plug-ins https://bugs.webkit.org/show_bug.cgi?id=138105 Reviewed by Anders Carlsson. Add a new plug-in test for the mute API. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added. (SetMuted::SetMuted): (SetMuted::isMuted): (SetMuted::cachedIsMuted): (SetMuted::ScriptableObject::hasProperty): (SetMuted::ScriptableObject::getProperty): (SetMuted::ScriptableObject::pluginTest): (SetMuted::NPP_New): (SetMuted::NPP_GetValue): (SetMuted::NPP_SetValue): 2014-11-12 Philippe Normand Unreviewed, GTK gardening. * Scripts/run-gtk-tests: (TestRunner): Skip the UserMediaBasic test because it depends on constraints validation which is going to be fixed in bug #136449. 2014-11-12 Carlos Garcia Campos [GTK] Expose user script messages to GObject DOM bindings https://bugs.webkit.org/show_bug.cgi?id=138411 Reviewed by Philippe Normand. Add a test case to check that user script messages sent using the DOM bindings API are also received in the UI process. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: (UserScriptMessageTest::waitUntilMessageReceived): (UserScriptMessageTest::postMessageAndWaitUntilReceived): (testUserContentManagerScriptMessageFromDOMBindings): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (documentLoadedCallback): 2014-11-12 Carlos Garcia Campos Unreviewed. Fix GTK+ clean build after r175930. Partial rollout of r175930 to not build the new unit test that broke clean builds in GTK+ port. * TestWebKitAPI/PlatformGTK.cmake: 2014-09-01 Philippe Normand [WK2] UserMediaClient support https://bugs.webkit.org/show_bug.cgi?id=123158 Reviewed by Benjamin Poulain. Simple API test for the UserMedia permission request API. The required test infrastructure is also added, inspired by the Geolocation infrastructure. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia Permission request. * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added. (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new helper method to set the permission request result without user interaction. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto. (WTR::InjectedBundle::setUserMediaPermission): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto. (WTR::TestRunner::setUserMediaPermission): * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto. * WebKitTestRunner/TestController.cpp: (WTR::decidePolicyForUserMediaPermissionRequest): Permission request handler. (WTR::TestController::createOtherPage): Enable the new UserMedia permission request handler. (WTR::TestController::createWebViewWithOptions): Ditto. (WTR::TestController::resetPreferencesToConsistentValues): Enable MediaStream support, this is needed for getUserMedia. (WTR::TestController::resetStateToConsistentValues): clear UserMedia permissions list and flags. (WTR::TestController::setUserMediaPermission): Set permission request result and distpatch it. (WTR::TestController::handleUserMediaPermissionRequest): Save request and dispatch it. (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Dispatch cached permission requests. * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 2014-11-11 David Kilzer webkit-patch --suggest-reviewers is broken with newer versions of git Reviewed by Michael Saboff with feedback from Daniel Bates. * Scripts/webkitpy/common/checkout/scm/git.py: (Git._changes_files_for_commit): Strip blank lines instead of assuming there is always a blank line at the beginning of the list. 2014-11-11 Alexey Proskuryakov DRT and WKTR touch disk cache https://bugs.webkit.org/show_bug.cgi?id=138622 Reviewed by Geoffrey Garen. * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment): Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after, because this function uses the shared cache. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext): Create an empty shared cache to prevent a default one from being created on disk. 2014-10-07 Sergio Villar Senin [CSS Grid Layout] Limit the size of explicit/implicit grid https://bugs.webkit.org/show_bug.cgi?id=136217 Reviewed by Andreas Kling. Added a new unit test for the CSS parser. Right now it only checks that we properly clamp the maximum number of tracks on a grid to a maximum of 1 million. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/PlatformEfl.cmake: * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added. (TestWebKitAPI::computeNumberOfTracks): Helper function. (TestWebKitAPI::TEST): Added a CSSPropertyParserTest.GridTrackLimits test case. 2014-11-11 Eva Balazsfalvi webkitpy test fix after r175867 https://bugs.webkit.org/show_bug.cgi?id=138607 Reviewed by Philippe Normand. * Scripts/webkitpy/port/linux_get_crash_log_unittest.py: (GDBCrashLogGeneratorTest.test_generate_crash_log): 2014-11-10 Philippe Normand webkitpy: demangle C++ symbols from crash log stderr https://bugs.webkit.org/show_bug.cgi?id=138565 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/port/linux_get_crash_log.py: (GDBCrashLogGenerator.generate_crash_log): Process stderr output with c++filt. 2014-11-10 Philippe Normand [GTK] fix up the GDB backtrace report tool https://bugs.webkit.org/show_bug.cgi?id=138564 Reviewed by Carlos Garcia Campos. * Scripts/webkitpy/port/gtk.py: (GtkPort._get_crash_log): Match the process name reported by the driver with the GTK port WebProcess executable filename. * Scripts/webkitpy/port/linux_get_crash_log.py: (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed program. (GDBCrashLogGenerator.generate_crash_log): Use %E in the core pattern to workaround the 16 characters size limit of %e. 2014-11-10 Conrad Shultz Unreviewed, moved myself to the list of committers. * Scripts/webkitpy/common/config/contributors.json: 2014-11-10 Eva Balazsfalvi [EFL] Fix the test font path after r175555. Reviewed by Csaba Osztrogonác. * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL 2014-11-10 Akos Kiss Fix the exception fuzz helper to generate targets in the correct range https://bugs.webkit.org/show_bug.cgi?id=138544 Reviewed by Filip Pizlo. Currently, the script generates exception fuzz targets in the range of 0..($checkCount-1). However, target 0 is never hit, while target 1 is always outside of the outermost try block of the tests, which therefore prints unexpected output and results in false failures when fired at. Additionally, target $checkCount is never generated. This patch fixes the script to generate targets in the range of 2..$checkCount. * Scripts/jsc-stress-test-helpers/js-exception-fuzz: 2014-11-09 Csaba Osztrogonác make-passwords-json.py should generarate everything needed for testing https://bugs.webkit.org/show_bug.cgi?id=138503 Reviewed by Ryosuke Niwa. * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py: Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py. Additionally generate auth.json, credentials.cfg and committers.cfg too. (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication. (BuildBotConfigLoader._create_mock_passwords_dict): Deleted. 2014-11-09 Carlos Garcia Campos [GTK] generate-gtkdoc should ignore invalid files https://bugs.webkit.org/show_bug.cgi?id=138542 Reviewed by Darin Adler. * gtk/generate-gtkdoc: (files_to_ignore.file_should_be_ignored): Return True to ignore invalid files. 2014-11-08 Alexey Proskuryakov Delete cookies between tests https://bugs.webkit.org/show_bug.cgi?id=138528 Reviewed by Sam Weinig. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): Do it. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): Added a FIXME. 2014-11-08 Carlos Garcia Campos [GTK] Run layout tests using the network process https://bugs.webkit.org/show_bug.cgi?id=138428 Reviewed by Martin Robinson. Shared secondary process is the default in the GTK+ port, but we should run the tests using the network process to ensure everything works with the network process. In the future, the shared secondary process model might be a special case of multiple processes with 1 as maximum number of processes, but always using the network process. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): 2014-11-08 Carlos Garcia Campos [GTK] Allow to create a view with a related page in WTR https://bugs.webkit.org/show_bug.cgi?id=138501 Reviewed by Martin Robinson. * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as related page to WKViewCreate. * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::PlatformWebView): Pass the given related page to WKViewCreate. 2014-11-08 Carlos Garcia Campos WTR crashes after running a test when NetworkProcess enabled https://bugs.webkit.org/show_bug.cgi?id=138500 Reviewed by Alexey Proskuryakov. WebNotificationProvider destructor is calling WKNotificationManagerSetProvider, but m_notificationManager is null because removeNotificationManager was already called. * WebKitTestRunner/WebNotificationProvider.cpp: (WTR::WebNotificationProvider::~WebNotificationProvider): Check m_notificationManager is not null before calling WKNotificationManagerSetProvider. 2014-11-06 Jake Nielsen Remove duplicate code from PatchAnalysisTask._test_patch and fix bug regarding incorrect call to PatchAnalysisTask.report_failure https://bugs.webkit.org/show_bug.cgi?id=138229 Reviewed by Daniel Bates. * Scripts/webkitpy/common/net/layouttestresults.py: Makes sure test_results returns a list. (LayoutTestResults.test_results): * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Makes unit tests also check to make sure task.results_from_patch_test_run() and task.results_from_test_run_without_patch return instances of LayoutTestResults. (CommitQueueTaskTest._run_and_expect_patch_analysis_result): * Scripts/webkitpy/tool/bot/patchanalysistask.py: Condenses duplicate code into _should_defer_patch_or_throw, and removes the now-unused _clean_tree_results member. (PatchAnalysisTask.__init__): (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): (PatchAnalysisTask._should_defer_patch_or_throw): (PatchAnalysisTask._test_patch): (PatchAnalysisTask.results_from_patch_test_run): (PatchAnalysisTask.results_from_test_run_without_patch): Deleted. * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Removes needless call to results_from_test_run_without_patch (AbstractEarlyWarningSystem._failing_tests_message): * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Changes order of test failure messages to be in the order that they appear. (AbstractEarlyWarningSystemTest.test_failing_tests_message): * Scripts/webkitpy/tool/commands/queues.py: Removes needless call to results_from_test_run_without_patch. (CommitQueue._failing_tests_message): * Scripts/webkitpy/tool/commands/queues_unittest.py: (MockCommitQueueTask.results_from_test_run_without_patch): Deleted. 2014-11-06 Ryuan Choi Unreviewed. Reorder my e-mail addresses in contributors.json * Scripts/webkitpy/common/config/contributors.json: 2014-11-06 Matthew Hanson Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev https://bugs.webkit.org/show_bug.cgi?id=138475 Reviewed by Ryosuke Niwa. The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit. This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish. * Scripts/webkitpy/common/checkout/scm/git.py: (Git._run_git_svn_find_rev): Add comment mentioning that svn_revisions need to begin with 'r'. Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location. Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take. Remove code that coerced the revision/treeish into a string and prepended an 'r'. 2014-11-06 Carlos Garcia Campos [GTK] Add context menu API to Web Process Extensions https://bugs.webkit.org/show_bug.cgi?id=138311 Reviewed by Gustavo Noronha Silva. Add tests cases for WebKitWebPage::context-menu signal. * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: (testContextMenuWebExtensionMenu): (testContextMenuWebExtensionNode): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (serializeContextMenu): (serializeNode): (contextMenuCallback): (pageCreatedCallback): 2014-11-06 Commit Queue Unreviewed, rolling out r175690. https://bugs.webkit.org/show_bug.cgi?id=138460 We are not ready to run layout tests using the network process yet (Requested by KaL on #webkit). Reverted changeset: "[GTK] Run layout tests using the network process" https://bugs.webkit.org/show_bug.cgi?id=138428 http://trac.webkit.org/changeset/175690 2014-11-06 Carlos Garcia Campos [GTK] Run layout tests using the network process https://bugs.webkit.org/show_bug.cgi?id=138428 Reviewed by Martin Robinson. Shared secondary process is the default in the GTK+ port, but we should run the tests using the network process to ensure everything works with the network process. In the future, the shared secondary process model might be a special case of multiple processes with 1 as maximum number of processes, but always using the network process. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): 2014-11-05 Dan Bernstein Remove the unused deletion UI feature https://bugs.webkit.org/show_bug.cgi?id=138442 Rubber-stamped by Alexey Proskuryakov. * DumpRenderTree/mac/EditingDelegate.mm: (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of delegate method that’s been removed. 2014-11-05 Alexey Proskuryakov fast/dom/remove-body-during-body-replacement2.html fails on WK2 https://bugs.webkit.org/show_bug.cgi?id=138334 Reviewed by Anders Carlsson. Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder calls, which works because each frame is an NSView in WK1. WK2 makes equivalent -makeFirstResponder calls, which may or may not be needed for other reasons, but it also needs to reset internal focus explicitly. It's not clear if this is the right long-term fix or a workaround for a WebKit bug. WebKit behavior appears wrong, but it matches Firefox. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::resetAfterTest): 2014-11-05 Carlos Garcia Campos [GTK] Add WebKitWebResource::failed-with-tls-errors signal https://bugs.webkit.org/show_bug.cgi?id=137862 Reviewed by Gustavo Noronha Silva. Add a test case to check that WebKitWebResource::failed-with-tls-errors is emitted when a subresource load fails due to TLS errors. * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: (TLSSubresourceTest::resourceLoadStartedCallback): (TLSSubresourceTest::TLSSubresourceTest): (TLSSubresourceTest::subresourceFailedCallback): (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback): (TLSSubresourceTest::subresourceLoadStarted): (TLSSubresourceTest::subresourceFailedWithTLSErrors): (TLSSubresourceTest::waitUntilSubresourceLoadFail): (testSubresourceLoadFailedWithTLSErrors): (httpsServerCallback): (httpServerCallback): (beforeAll): 2014-11-05 Alexey Proskuryakov Build fix for some compiler versions. * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was unhappy because this is a getter, and these shouldn't have side effects. 2014-11-04 Matthew Hanson Add a method for performing cherrypick-merges. https://bugs.webkit.org/show_bug.cgi?id=138375 Reviewed by Ryosuke Niwa. Adds support for cherrypick-merges. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.cherrypick_merge): Added. 2014-11-04 Matthew Hanson Add a way to ascertain the SVN URL associated with a Git branch. https://bugs.webkit.org/show_bug.cgi?id=138374 Reviewed by Ryosuke Niwa. The svn_url method returns the SVN URL associated with the current Git branch. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.svn_url): Added. 2014-11-04 Matthew Hanson Add the ability to search for modifications that are staged for commit. https://bugs.webkit.org/show_bug.cgi?id=138373 Reviewed by Ryosuke Niwa and Daniel Bates. This makes is easy to do identify files that require merge post-processing, in addition to stand-alone utility. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.modifications_staged_for_commit): Added. 2014-11-04 Matthew Hanson Add a branch keyword argument to _run_git_svn_find_rev. https://bugs.webkit.org/show_bug.cgi?id=138372 Reviewed by Ryosuke Niwa. The addition of this keyword argument allows clients to determine the Git hash of commits made on an SVN branch, provided that branch has been fetched locally. * Scripts/webkitpy/common/checkout/scm/git.py: (Git._run_git_svn_find_rev): Add a branch keyword argument that is added to the end of the command, if present. 2014-11-04 Chris Dumez Add ptr() method to Ref class https://bugs.webkit.org/show_bug.cgi?id=138361 Reviewed by Darin Adler. Use the new Ref::ptr() method. * TestWebKitAPI/Tests/WTF/Ref.cpp: (TestWebKitAPI::TEST): 2014-11-04 Tibor Meszaros [jhbuild] Make it possible to build GTK/EFL in same repository https://bugs.webkit.org/show_bug.cgi?id=137448 Reviewed by Martin Robinson. * Scripts/webkitdirs.pm: (getJhbuildPath): * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: (getPlatformFontsPath): * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: (WTR::getFontsPath): * jhbuild/jhbuild-wrapper: (determine_platform): (install_jhbuild): * jhbuild/jhbuildrc_common.py: (init): 2014-11-04 Dániel Bátyai [EFL] Bump LLVM to version 3.5.0 https://bugs.webkit.org/show_bug.cgi?id=138312 Reviewed by Csaba Osztrogonác. * efl/jhbuild.modules: * efl/patches/llvm-elf-add-stackmaps.patch: Added. * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added. 2014-11-03 Simon Fraser Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2 https://bugs.webkit.org/show_bug.cgi?id=138257 Reviewed by Tim Horton. Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows the user to toggle region page overlays on and off. Two overlays are available, for the non-fast scrollable region, and the region of element with wheel event handlers. * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController nonFastScrollableRegionOverlayVisible]): (-[SettingsController wheelEventHandlerRegionOverlayVisible]): (-[SettingsController preferenceKeyForRegionOverlayTag:]): (-[SettingsController toggleDebugOverlay:]): (-[SettingsController debugOverlayVisible:]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController didChangeSettings]): 2014-11-03 Alexey Proskuryakov REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page https://bugs.webkit.org/show_bug.cgi?id=138323 Reviewed by Zalan Bujtas. * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down. 2014-11-03 Eva Balazsfalvi [ninja] Don't remove response files for verbose builds https://bugs.webkit.org/show_bug.cgi?id=137816 Reviewed by Csaba Osztrogonác. * Scripts/webkitdirs.pm: (determineNinjaVersion): (buildCMakeGeneratedProject): 2014-11-02 Akos Kiss [GTK] Fix the build of FTL JIT https://bugs.webkit.org/show_bug.cgi?id=138298 Reviewed by Carlos Garcia Campos. * gtk/jhbuild-optional.modules: Bump up LLVM version to 3.5.0 release and apply patches. * gtk/patches/llvm-elf-add-stackmaps.patch: Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM trunk. * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added. Ensures that PC-relative relocations in EH frames are not truncated to 32 bits on x86_64. 2014-10-31 Michael Saboff No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests https://bugs.webkit.org/show_bug.cgi?id=138268 Reviewed by Andreas Kling. Added a --arch and --os option to set or override the values that are normally computed based on examining the JavaScriptCore we want to test. * Scripts/run-jsc-stress-tests: 2014-10-31 Dan Bernstein llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory https://bugs.webkit.org/show_bug.cgi?id=138259 Reviewed by Geoff Garen. * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s going to be empty to silence the warning. 2014-10-31 Adrian Perez de Castro [GTK] Support script message handlers WebKitUserContentManager https://bugs.webkit.org/show_bug.cgi?id=133730 Reviewed by Carlos Garcia Campos. Support user script message handlers in WebKitUserContentManager. This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which an option is added to the CMake build files. The option is disabled globally by default, and the WebKitGTK port enables it. On the API level, two new methods to register and unregister names are provided in the "window.webkit" namespace, and on message reception the "WebKitUserContentManager::script-message-received" signal is emitted, using the registered names as signal detail. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: Add test case for user script message handlers. (scriptMessageReceived): (testUserContentManagerScriptMessageReceived): (beforeAll): 2014-10-30 Matthew Hanson bisect-builds should support WebKit clients other than Safari https://bugs.webkit.org/show_bug.cgi?id=138225 This patch adds support for bisecting WebKit nightly builds with clients other than Safari. The -a / --application optional argument allows the user to specify which application (or application bundle) should be run against the WebKit nightly builds. Reviewed by David Kilzer. * Scripts/bisect-builds: Swap out $safariPath for the more general $applicationPath Leave --safari-path as a commandline option for backwards compatibility (mountAndRunNightly): Use File::Spec->cat correctly (one directory per argument) Use open --wait-apps instead of running the target application directly 2014-10-30 Dana Burkart Perpare for the mysterious future Reviewed by Lucas Forschler. * DumpRenderTree/mac/Configurations/Base.xcconfig: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * LayoutTestRelay/Configurations/Base.xcconfig: * LayoutTestRelay/Configurations/DebugRelease.xcconfig: * MiniBrowser/Configurations/Base.xcconfig: * MiniBrowser/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * WebKitLauncher/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: 2014-10-30 Matthew Hanson Update safariVersion to safariVersionString https://bugs.webkit.org/show_bug.cgi?id=138193 The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x, but it should have also been done for the "4 Public Beta" check in OS X 10.4.x. Rubber-stamped by David Kilzer. * Scripts/bisect-builds: (makeNightlyList): Compare safariVersionString to a string literal, instead of safariVersion. 2014-10-30 Rohit Kumar [GTK] Minibrowser : Add window fullscreen support for Minibrowser https://bugs.webkit.org/show_bug.cgi?id=137775 Reviewed by Carlos Garcia Campos. * MiniBrowser/gtk/BrowserWindow.c: (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key. (browser_window_init): 2014-10-29 Jake Nielsen CommitQueue and EWS should reject any patches that result in consistent test failures that aren't present on the tree. https://bugs.webkit.org/show_bug.cgi?id=138184 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/layout_tests/models/test_results.py: Adds a simple hashing function to allow for set operations to handle TestResult objects properly. (TestResult.__hash__): * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Adds one unit test, and modifies others to agree with the notion that patches that introduce new test failures (but also have flakyness) should be rejected rather than spin. (MockCommitQueue.report_flaky_tests): (CommitQueueTaskTest._run_and_expect_patch_analysis_result): (test_double_flaky_test_failure): (test_two_flaky_tests): (test_very_flaky_patch): (test_very_flaky_patch_with_some_tree_redness): (test_different_test_failures): (test_different_test_failures_with_some_tree_redness): (test_different_test_failures_with_some_tree_redness_and_some_fixes): (test_mildly_flaky_patch): (test_mildly_flaky_patch_with_some_tree_redness): * Scripts/webkitpy/tool/bot/patchanalysistask.py: Makes PatchAnalysisTask reject said patches. (PatchAnalysisTask._test_patch): 2014-10-29 Youenn Fablet WinCairoRequirements.zip cannot be downloaded from dropbox https://bugs.webkit.org/show_bug.cgi?id=138113 Reviewed by Alexey Proskuryakov. * Scripts/update-webkit-dependency: Removing --sslv3 option from curl 2014-10-29 Matthew Hanson bisect-builds should filter out nightlies that predate the introduction of an OS X operating system https://bugs.webkit.org/show_bug.cgi?id=138193 This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.) It also does a bit of refactoring, including distinguishing between versions and version strings and saving versions to local variables instead of using eval in each conditional. Reviewed by David Kilzer. * Scripts/bisect-builds: (makeNightlyList): Restrict the set of nightlies to r174650 and above when running Yosemite. Restrict the set of nightlies to r157846 and above when running Mavericks. Restrict the set of nightlies to r122421 and above when running Mountain Lion. 2014-10-29 Csaba Osztrogonác [EFL] build-webkit should try harder to avoid re-running cmake https://bugs.webkit.org/show_bug.cgi?id=137949 Reviewed by Martin Robinson. * Scripts/webkitdirs.pm: (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL. (generateBuildSystemFromCMakeProject): Comment fix after r174681. 2014-10-28 Daniel Bates Unify logic in RunTests.run() to run the Python unit tests https://bugs.webkit.org/show_bug.cgi?id=138160 Reviewed by Martin Robinson. Unify the interactive and non-interactive code path for running the Python unit tests in step RunTests so as to remove duplicate code to compute the the path to the script test-webkitpy and log an informative message ("Running Python unit tests") to the console. No new tests since no functionality was changed. * Scripts/webkitpy/port/base.py: (Port.python_unittest_results_directory): * Scripts/webkitpy/tool/steps/runtests.py: (RunTests.run): 2014-10-28 Jake Nielsen Make runtest.py call test-webkitpy with the --json flag when in non-interactive mode. https://bugs.webkit.org/show_bug.cgi?id=137667 Reviewed by Daniel Bates. * Scripts/webkitpy/port/base.py: Adds the python_unittest_results_directory method. (Port.python_unittest_results_directory): * Scripts/webkitpy/tool/steps/runtests.py: Changes RunTests to call test-webkitpy with the --json flag if the --non-interactive flag is set. (RunTests): (RunTests.run): 2014-10-28 Rebecca Hauck import-w3c-tests should use re.escape() wherever it's handling file paths https://bugs.webkit.org/show_bug.cgi?id=137934 This patch adds re.escape() to a few places where we're doing string conversions. This prevents errors when attribute values coincidentally have character sequences that can be interpreted as regular expressions. Reviewed by Bem Jones-Bey. * Scripts/webkitpy/w3c/test_converter.py: (_W3CTestConverter.convert_attributes_if_needed): 2014-10-28 Tibor Meszaros [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp https://bugs.webkit.org/show_bug.cgi?id=138130 Reviewed by Csaba Osztrogonác. * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: 2014-10-25 Raniere Silva Fix link to Arch Linux Wiki https://bugs.webkit.org/show_bug.cgi?id=138010 Reviewed by Benjamin Poulain. * gtk/install-dependencies: 2014-10-25 Alexey Proskuryakov Test regressions are not detected when image result is missing https://bugs.webkit.org/show_bug.cgi?id=138070 Reviewed by Simon Fraser. * Scripts/webkitpy/layout_tests/models/test_run_results.py: * Scripts/webkitpy/layout_tests/views/buildbot_results.py: Count these as regressions, not as flaky tests. * Scripts/webkitpy/port/test.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test it. 2014-10-24 Timothy Horton Add Conrad Shultz to the contributors list. * Scripts/webkitpy/common/config/contributors.json: 2014-10-24 Dan Bernstein build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404 https://bugs.webkit.org/show_bug.cgi?id=138046 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was 401. Otherwise, we’ll retry normally in 45 seconds. 2014-10-24 Marcos Chavarría Teijeiro [GTK] Implement is_selected method on WebKitHitTestResult https://bugs.webkit.org/show_bug.cgi?id=137110 Reviewed by Tim Horton. Add tests for new context SELECTION on WebKitHitTestResult. * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: (testContextMenuDefaultMenu): * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: (testWebViewMouseTarget): 2014-10-23 Roger Fong [Win] Skip failing JSC tests following r175078 https://bugs.webkit.org/show_bug.cgi?id=130967. * Scripts/run-javascriptcore-tests: 2014-10-22 Jake Nielsen commitqueuetask_unittest.py should be made more concise. https://bugs.webkit.org/show_bug.cgi?id=137985 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Refactors tests to use MockSimpleTestPlanCommitQueue where possible. (MockCommitQueue.__init__): (MockCommitQueue.report_flaky_tests): (MockCommitQueue): (MockCommitQueue.get_reported_flaky_tests): (MockSimpleTestPlanCommitQueue.__init__): (MockSimpleTestPlanCommitQueue.run_command): (MockSimpleTestPlanCommitQueue.did_run_clean_tests): (CommitQueueTaskTest._run_and_expect_patch_analysis_result): (test_land_failure): (test_failed_archive): (test_double_flaky_test_failure): (test_test_failure): (test_red_test_failure): (test_very_red_tree_retry): (test_red_tree_patch_rejection): (test_one_flaky_test): (test_tree_more_red_than_patch): (MockCommitQueue.test_results): Deleted. (test_simple_flaky_test_failure): Deleted. (_expect_validate): Deleted. (_expect_validate.MockDelegate): Deleted. (_expect_validate.MockDelegate.refetch_patch): Deleted. (_expect_validate.MockDelegate.expected_failures): Deleted. (_mock_patch): Deleted. (test_validate): Deleted. * Scripts/webkitpy/tool/bot/patchanalysistask.py: Fixes a bug that slipped through the cracks prior to this change. (PatchAnalysisTask._test_patch): 2014-10-22 Alexey Proskuryakov Flakiness dashboard should support OS X Yosemite https://bugs.webkit.org/show_bug.cgi?id=137986 Reviewed by Ryosuke Niwa. * TestResultServer/app.yaml: * TestResultServer/static-dashboards/builders.jsonp: * TestResultServer/static-dashboards/flakiness_dashboard.js: 2014-10-22 Jake Nielsen commitqueuetask should include more tests to ensure that the behavior of PatchAnalysisTask._test_patch() is well defined https://bugs.webkit.org/show_bug.cgi?id=137977 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Adds the MockSimpleTestPlanCommitQueue class, which makes it easier and more readable to define tests that are meant to test the behaviour of PatchAnalysisTask._test_patch(), and adds several unit tests. (FailingTestCommitQueue.test_results): (PatchAnalysisResult): (MockSimpleTestPlanCommitQueue): (MockSimpleTestPlanCommitQueue.__init__): (MockSimpleTestPlanCommitQueue.run_command): (MockSimpleTestPlanCommitQueue._mock_test_result): (MockSimpleTestPlanCommitQueue.test_results): (CommitQueueTaskTest._run_and_expect_patch_analysis_result): (test_flaky_test_failure): (test_failed_archive): (test_two_flaky_tests): (test_one_flaky_test): (test_very_flaky_patch): (test_very_flaky_patch_with_some_tree_redness): (test_different_test_failures): (test_different_test_failures_with_some_tree_redness): (test_mildly_flaky_patch): (test_mildly_flaky_patch_with_some_tree_redness): (test_tree_more_red_than_patch): 2014-10-22 Jake Nielsen PatchAnalysisTask._test_patch() needs refactoring https://bugs.webkit.org/show_bug.cgi?id=137904 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Fixes several small bugs, and makes minor changes to accomodate the changes in PatchAnalysisTask. (MockCommitQueue.refetch_patch): (MockCommitQueue.test_results): (test_flaky_test_failure): (test_failed_archive): (test_very_red_tree_retry): (_expect_validate.MockDelegate.refetch_patch): (MockCommitQueue.expected_failures): Deleted. (_expect_validate.MockDelegate.expected_failures): Deleted. * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed. * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed. * Scripts/webkitpy/tool/bot/patchanalysistask.py: Removes the unexpected_failures member, adds the _clean_tree_results member, adds a helper function for _test_patch, and refactors _test_patch to be more readable. (PatchAnalysisTask.__init__): (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): (PatchAnalysisTask._test_patch): (PatchAnalysisTask.results_from_test_run_without_patch): * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. (AbstractEarlyWarningSystem.begin_work_queue): (AbstractEarlyWarningSystem._failing_tests_message): (AbstractEarlyWarningSystem.command_failed): (AbstractEarlyWarningSystem.expected_failures): Deleted. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Makes changes to accomodate the changes made to PatchAnalysisTask. (AbstractEarlyWarningSystemTest.test_failing_tests_message): * Scripts/webkitpy/tool/commands/perfalizer.py: Removes Perfalizer's dependancy on ExpectedFailures. (PerfalizerTask.refetch_patch): (PerfalizerTask.expected_failures): Deleted. * Scripts/webkitpy/tool/commands/queues.py: Removes CommitQueue's dependancy on ExpectedFailures, and adds an initializer to allow for mock injection. (CommitQueue.__init__): (CommitQueue.begin_work_queue): (CommitQueue.process_work_item): (CommitQueue._failing_tests_message): * Scripts/webkitpy/tool/commands/queues_unittest.py: Removes dependancy on ExpectedFailures, and instead uses mock injection. (MockCommitQueueTask): (MockCommitQueueTask.results_from_patch_test_run): (MockCommitQueueTask.results_from_test_run_without_patch): (mock_run_webkit_patch): 2014-10-22 Rohit Kumar [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window https://bugs.webkit.org/show_bug.cgi?id=136736 Reviewed by Gyuyoung Kim. * MiniBrowser/efl/main.c: (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window. (window_create): 2014-10-22 Carlos Garcia Campos [GTK] Move GtkInputMethodFilter from Platform to WebKit2 https://bugs.webkit.org/show_bug.cgi?id=137884 Reviewed by Gustavo Noronha Silva. Move InputMethodFilter test from WebCore tests to WebKit2 tests and adapt it to use the new InputMethodFilter WebKit class. Instead of having virtual methods just for testing, it has a testing mode that logs the events. * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp. (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter): (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter): (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter): (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter): (TestWebKitAPI::TEST): (TestWebKitAPI::temporaryGetPreeditStringOverride): (TestWebKitAPI::temporaryResetOverride): (TestWebKitAPI::verifyCanceledComposition): 2014-10-21 Alexey Proskuryakov build.webkit.org/dashboard: Cannot click on green tester bubbles https://bugs.webkit.org/show_bug.cgi?id=137909 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): 2014-10-21 Brent Fulgham [Win] Run DumpRenderTree using native controls, not SafariTheme.dll. https://bugs.webkit.org/show_bug.cgi?id=137932 Reviewed by Simon Fraser. This is the first step in moving over to native Windows rendering for our layout tests. Once this change lands, approximately 300 tests will start failing on Windows. I will rebaseline these changes against our test hardware and update this bug with the commits related to that work. * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that we use native Windows drawing style. 2014-10-21 Dániel Bátyai Fix FTL Native Inlining for EFL https://bugs.webkit.org/show_bug.cgi?id=137774 Reviewed by Michael Saboff. Added Clang as an optional module to jhbuild. * efl/jhbuild.modules: 2014-10-20 Michael Catanzaro Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL https://bugs.webkit.org/show_bug.cgi?id=137832 Reviewed by Carlos Garcia Campos. Ensure each test sets the TLS errors policy that it really needs. Have each test except testTLSErrorsPolicy stash and restore the original TLS errors policy. Update testTLSErrorsPolicy to account for the new default policy. * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: (testSSL): (testInsecureContent): (testTLSErrorsPolicy): (testTLSErrorsRedirect): (testTLSErrorsHTTPAuth): (testLoadFailedWithTLSErrors): (beforeAll): 2014-10-21 Carlos Garcia Campos Unreviewed. Unskip inspector server unit tests. They should pass now. * Scripts/run-gtk-tests: (TestRunner): 2014-10-21 Carlos Garcia Campos [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails https://bugs.webkit.org/show_bug.cgi?id=132044 Reviewed by Brian Burg. * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: (openRemoteDebuggingSession): Remove trailing slash when concatenating base inspector URL with the page, because the inspector returns the relative paths with a leading slash. 2014-10-20 Tanay C [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search https://bugs.webkit.org/show_bug.cgi?id=137023 Reviewed by Gyuyoung Kim. * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search (search_box_show): Modified. (search_box_hide): Modified. (on_search_field_activated): Modified. (on_search_backward_button_clicked): Modified. (on_search_forward_button_clicked): Modified. (on_search_case_option_changed): Added. (on_search_word_start_option_changed): Added. (window_create): Modified. 2014-10-20 Tanay C [GTK][Minibrowser] Escape key does not hide the search box https://bugs.webkit.org/show_bug.cgi?id=137734 Reviewed by Philippe Normand. * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide (stopPageLoad): Modified. 2014-10-18 Antti Koivisto REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error https://bugs.webkit.org/show_bug.cgi?id=137855 Reviewed by Dan Bernstein. Test and warn if the dumped response mime type differs from the platform response mime type. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didReceiveResponseForResource): (WTR::InjectedBundlePage::platformResponseMimeType): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: (WTR::InjectedBundlePage::platformResponseMimeType): 2014-10-17 Joseph Pecoraro Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore https://bugs.webkit.org/show_bug.cgi?id=137835 Reviewed by Andreas Kling. * Scripts/run-inspector-perf-tests.py: Removed. This script is stale, as PerformanceTests/inspector no longer exists. 2014-10-17 Simon Fraser Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_baseline_search_path): 2014-10-17 Simon Fraser [iOS] Simplify test fallback paths for iOS Simulator testing https://bugs.webkit.org/show_bug.cgi?id=137830 Reviewed by Zalan Bujtas. Make the fallback paths be: ios-simulator -> generic ios-simulator-wk2->ios-simulator -> generic so don't include mac in the fallback path. Also remove the version handling for simplicity. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort): (IOSSimulatorPort.default_baseline_search_path): 2014-10-17 Dana Burkart Fix typos in the dashboard config file. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): 2014-10-17 Brent Fulgham [Win] Allow WinLauncher to specify Custom User Agent strings https://bugs.webkit.org/show_bug.cgi?id=137828 Reviewed by Dean Jackson. * WinLauncher/Common.cpp: Add support for custom user agent strings. * WinLauncher/WinLauncher.cpp: Add some convenience methods to get and set the user agent strings. * WinLauncher/WinLauncher.h: * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu resources and dialog for setting custom User Agent strings. * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: 2014-10-16 Simon Fraser [iOS] Turn off font autosizing for iOS WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=137806 Reviewed by Sam Weinig. Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS. Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0 to disable font autosizing. Add platformResetPreferencesToConsistentValues() and implement it in the iOS test controller to set platform-specific prefs. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): (WTR::TestController::platformResetPreferencesToConsistentValues): * WebKitTestRunner/TestController.h: * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::platformResetPreferencesToConsistentValues): * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformResetPreferencesToConsistentValues): 2014-10-16 Dan Bernstein OSObjectPtr is missing leakRef() https://bugs.webkit.org/show_bug.cgi?id=137798 Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added. 2014-10-16 Lucas Forschler Update target platform to remove Leopard, Snow Leopard, Lion. Add Yosemite. Unreviewed. * BuildSlaveSupport/build.webkit.org-config/wkbuild.py: (_should_file_trigger_build): 2014-10-16 David Kilzer commit-queue: fails to replace OO-PS! with reviewer name Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out email addresses to unauthenticated page loads, so we must always authenticate before getting bug data so we get full email addresses. 2014-10-16 David Kilzer commit-queue: fails to close bugs after successfully landing patches Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to tell Mechanize to use the second