2014-04-29 Simon Fraser Remove Settings::compositedScrollingForFramesEnabled https://bugs.webkit.org/show_bug.cgi?id=132352 Reviewed by Andreas Kling. The usesCompositedScrolling setting was only used by Chromium, so remove it and associated code. * page/FrameView.cpp: (WebCore::FrameView::usesCompositedScrolling): Deleted. * page/FrameView.h: * page/Settings.in: * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateScrollLayerPosition): 2014-04-29 Zsolt Borbely Move removeEquivalentProperties functions to EditingStyle https://bugs.webkit.org/show_bug.cgi?id=131093 Reviewed by Darin Adler. Moved the removeEquivalentProperties functions from StyleProperties to EditingStyle class. * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeEquivalentProperties): Deleted. * css/StyleProperties.h: * editing/EditingStyle.cpp: (WebCore::EditingStyle::removeStyleAddedByNode): (WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode): (WebCore::EditingStyle::prepareToApplyAt): (WebCore::EditingStyle::removeEquivalentProperties): (WebCore::extractPropertiesNotIn): * editing/EditingStyle.h: 2014-04-29 David Hyatt [New Multicolumn] Implement support for compositing https://bugs.webkit.org/show_bug.cgi?id=132298 Reviewed by Simon Fraser. * rendering/RenderLayer.cpp: (WebCore::accumulateOffsetTowardsAncestor): Add in a case for the new columns that calls into the multi-column flow thread to get an offset to adjust by. * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread): Make sure this code only runs for named flow threads. * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::canBeComposited): Turn on compositing support for in-flow RenderFlowThreads instead of always returning false * rendering/RenderMultiColumnFlowThread.cpp: (WebCore::RenderMultiColumnFlowThread::physicalTranslationOffsetFromFlowToRegion): Changed this function to fix a couple of bugs exposed by compositing/columns tests. Its end goal is the same, but the approach is improved. * rendering/RenderMultiColumnSet.cpp: (WebCore::RenderMultiColumnSet::endFlow): Don't pad out to a multiple of column height. You can't flip around a flow thread to get back to accurate physical coordinates if bogus padding is introduced. This seemed to have no effect on any layout tests when removed, so I don't think it was really serving any useful purpose. (WebCore::RenderMultiColumnSet::columnTranslationForOffset): Don't factor in the overall flow thread portion, since this is handled by the callers now. (WebCore::RenderMultiColumnSet::adjustRegionBoundsFromFlowThreadPortionRect): * rendering/RenderMultiColumnSet.h: Change this function to be ASSERT_NOT_REACHED(), since we want to know if someone calls it. It only runs for named flow thread compositing code, so it would be a mistake if this ever gets invoked. 2014-04-29 Mark Hahnenberg JSProxies should be cacheable https://bugs.webkit.org/show_bug.cgi?id=132351 Reviewed by Geoffrey Garen. No new tests. Whenever we encounter a proxy in an inline cache we should try to cache on the proxy's target instead of giving up. This patch adds support for a simple "recursive" inline cache if the base object we're accessing is a pure forwarding proxy. JSGlobalObject and its subclasses are the only ones to benefit from this right now. This is performance neutral on the benchmarks we track. Currently we won't cache on JSDOMWindow due to HasImpureGetOwnPropertySlot, but this issue will be fixed soon. * bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructure): 2014-04-29 Brent Fulgham [Mac, iOS] Support caption activation via JS webkitHasClosedCaptions method https://bugs.webkit.org/show_bug.cgi?id=132320 Reviewed by Eric Carlson. * Modules/mediacontrols/mediaControlsApple.css: (video::-webkit-media-text-track-container .hidden): Added. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::configureTextTrackGroup): Added call to new 'updateCaptionsContainer'. (WebCore::HTMLMediaElement::updateCaptionContainer): Added. * html/HTMLMediaElement.h: * html/shadow/MediaControlElements.cpp: (WebCore::MediaControlTextTrackContainerElement::hide): Use CSS class .hidden instead of hard-coded "display:none". (WebCore::MediaControlTextTrackContainerElement::show): Ditto. * html/shadow/MediaControlElements.h: 2014-04-28 Roger Fong Plugins hidden by images should autoplay. https://bugs.webkit.org/show_bug.cgi?id=132222. Reviewed by Jon Lee and Darin Adler. * WebCore.exp.in: Add exports needed by WK2. 2014-04-29 Filip Pizlo Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT) https://bugs.webkit.org/show_bug.cgi?id=112840 Rubber stamped by Geoffrey Garen. It already has a lot of tests. * Configurations/FeatureDefines.xcconfig: 2014-04-29 Brady Eidson Change Image Controls replacement to use selection and paste and https://bugs.webkit.org/show_bug.cgi?id=131992 Reviewed by Tim Horton. * WebCore.exp.in: Remove deleted symbol. * html/shadow/mac/ImageControlsButtonElementMac.cpp: (WebCore::ImageControlsButtonElementMac::defaultEventHandler): * page/ContextMenuController.cpp: (WebCore::ContextMenuController::showImageControlsMenu): Select the image element before showing the menu. (WebCore::ContextMenuController::replaceControlledImage): Deleted. * page/ContextMenuController.h: 2014-04-29 Jer Noble [iOS] Remove workaround for . https://bugs.webkit.org/show_bug.cgi?id=132338 Reviewed by Darin Adler. Now that is fixed, remove the workaround by replacing the call to -_updatePlaybackControlsViewController with one to -layoutIfNeeded. * platform/ios/WebVideoFullscreenInterfaceAVKit.mm: (WebVideoFullscreenInterfaceAVKit::enterFullscreen): 2014-04-29 Zan Dobersek ScriptExecutionContext::Task should work well with C++11 lambdas https://bugs.webkit.org/show_bug.cgi?id=129795 Reviewed by Darin Adler. Instead of having classes that subclass ScriptExecutionContext::Task and override the performTask(ScriptExecutionContext*) method, have the ScriptExecutionContext::Task take in a std::function-like object trough the constructor which would contain the code currently kept in the performTask() methods. This enables inlining C++11 lambdas into ScriptExecutionContext::postTask() calls. For cleanup tasks, the Task object can be implicitly constructed by using the initializer list constructor with the first argument being the ScriptExecutionContext::Task::CleanupTask tag. The ScriptExecutionContext class remains non-copyable and now stores the passed-in invokable object in the std::function wrapper, along with a boolean member that indicates whether the task is of cleanup nature. * Modules/quota/StorageErrorCallback.cpp: (WebCore::StorageErrorCallback::CallbackTask::CallbackTask): (WebCore::StorageErrorCallback::CallbackTask::performTask): Deleted. * Modules/quota/StorageErrorCallback.h: (WebCore::StorageErrorCallback::CallbackTask::create): Deleted. * Modules/webdatabase/Database.cpp: (WebCore::Database::~Database): (WebCore::Database::runTransaction): (WebCore::Database::scheduleTransactionCallback): (WebCore::DerefContextTask::create): Deleted. (WebCore::DerefContextTask::performTask): Deleted. (WebCore::DerefContextTask::isCleanupTask): Deleted. (WebCore::DerefContextTask::DerefContextTask): Deleted. (WebCore::callTransactionErrorCallback): Deleted. (WebCore::DeliverPendingCallbackTask::create): Deleted. (WebCore::DeliverPendingCallbackTask::performTask): Deleted. (WebCore::DeliverPendingCallbackTask::DeliverPendingCallbackTask): Deleted. * Modules/webdatabase/DatabaseManager.cpp: (WebCore::DatabaseManager::openDatabase): (WebCore::DatabaseCreationCallbackTask::create): Deleted. (WebCore::DatabaseCreationCallbackTask::performTask): Deleted. (WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask): Deleted. * Modules/webdatabase/DatabaseSync.cpp: (WebCore::CloseSyncDatabaseOnContextThreadTask::create): Deleted. (WebCore::CloseSyncDatabaseOnContextThreadTask::performTask): Deleted. (WebCore::CloseSyncDatabaseOnContextThreadTask::CloseSyncDatabaseOnContextThreadTask): Deleted. * Modules/webdatabase/SQLCallbackWrapper.h: (WebCore::SQLCallbackWrapper::clear): (WebCore::SQLCallbackWrapper::SafeReleaseTask::create): Deleted. (WebCore::SQLCallbackWrapper::SafeReleaseTask::performTask): Deleted. (WebCore::SQLCallbackWrapper::SafeReleaseTask::isCleanupTask): Deleted. (WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask): Deleted. * Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData): (WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmount): (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake): (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageError): (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks): * Modules/websockets/ThreadableWebSocketChannelClientWrapper.h: * Modules/websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize): (WebCore::WorkerThreadableWebSocketChannel::mainThreadDestroy): (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect): (WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::create): Deleted. (WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::~WorkerGlobalScopeDidInitializeTask): Deleted. (WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask): Deleted. * Modules/websockets/WorkerThreadableWebSocketChannel.h: * bindings/js/JSCallbackData.h: (WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask): (WebCore::DeleteCallbackDataTask::create): Deleted. (WebCore::DeleteCallbackDataTask::performTask): Deleted. (WebCore::DeleteCallbackDataTask::isCleanupTask): Deleted. * bindings/js/JSDOMGlobalObjectTask.cpp: (WebCore::JSGlobalObjectTask::JSGlobalObjectTask): (WebCore::JSGlobalObjectTask::~JSGlobalObjectTask): Deleted. (WebCore::JSGlobalObjectTask::performTask): Deleted. * bindings/js/JSDOMGlobalObjectTask.h: * bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::queueTaskToEventLoop): * bindings/js/JSWorkerGlobalScopeBase.cpp: (WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop): * bindings/scripts/CodeGeneratorJS.pm: * bindings/scripts/test/JS/JSTestCallback.cpp: (WebCore::JSTestCallback::~JSTestCallback): (GenerateCallbackImplementation): * dom/CrossThreadTask.h: (WebCore::CrossThreadTask1::performTask): (WebCore::CrossThreadTask2::performTask): (WebCore::CrossThreadTask3::performTask): (WebCore::CrossThreadTask4::performTask): (WebCore::CrossThreadTask5::performTask): (WebCore::CrossThreadTask6::performTask): (WebCore::CrossThreadTask7::performTask): (WebCore::CrossThreadTask8::performTask): (WebCore::createCallbackTask): (WebCore::CrossThreadTask1::create): Deleted. (WebCore::CrossThreadTask2::create): Deleted. (WebCore::CrossThreadTask3::create): Deleted. (WebCore::CrossThreadTask4::create): Deleted. (WebCore::CrossThreadTask5::create): Deleted. (WebCore::CrossThreadTask6::create): Deleted. (WebCore::CrossThreadTask7::create): Deleted. (WebCore::CrossThreadTask8::create): Deleted. * dom/Document.cpp: (WebCore::Document::addConsoleMessage): (WebCore::Document::addMessage): (WebCore::Document::postTask): (WebCore::Document::pendingTasksTimerFired): (WebCore::PerformTaskContext::PerformTaskContext): Deleted. (WebCore::Document::didReceiveTask): Deleted. * dom/Document.h: * dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::processMessagePortMessagesSoon): (WebCore::ScriptExecutionContext::timerAlignmentInterval): (WebCore::ProcessMessagesSoonTask::create): Deleted. (WebCore::ScriptExecutionContext::AddConsoleMessageTask::performTask): Deleted. (WebCore::ScriptExecutionContext::Task::~Task): Deleted. * dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::Task::Task): (WebCore::ScriptExecutionContext::Task::performTask): (WebCore::ScriptExecutionContext::Task::isCleanupTask): (WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask): (WebCore::ScriptExecutionContext::AddConsoleMessageTask::create): Deleted. * dom/StringCallback.cpp: (WebCore::StringCallback::scheduleCallback): * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::postListenerTask): (WebCore::CallCacheListenerTask::create): Deleted. (WebCore::CallCacheListenerTask::CallCacheListenerTask): Deleted. * workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerProxy::postTaskToLoader): (WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope): (WebCore::SharedWorkerConnectTask::SharedWorkerConnectTask): (WebCore::DefaultSharedWorkerRepository::workerScriptLoaded): (WebCore::DefaultSharedWorkerRepository::connectToWorker): (WebCore::SharedWorkerConnectTask::create): Deleted. (WebCore::SharedWorkerConnectTask::performTask): Deleted. * workers/WorkerEventQueue.cpp: (WebCore::WorkerEventQueue::EventDispatcher::EventDispatcher): (WebCore::WorkerEventQueue::EventDispatcher::~EventDispatcher): (WebCore::WorkerEventQueue::EventDispatcher::dispatch): (WebCore::WorkerEventQueue::enqueueEvent): (WebCore::WorkerEventQueue::cancelEvent): (WebCore::WorkerEventQueue::close): * workers/WorkerEventQueue.h: * workers/WorkerGlobalScope.cpp: (WebCore::WorkerGlobalScope::close): (WebCore::WorkerGlobalScope::postTask): (WebCore::WorkerGlobalScope::addConsoleMessage): (WebCore::WorkerGlobalScope::addMessage): (WebCore::CloseWorkerGlobalScopeTask::create): Deleted. (WebCore::CloseWorkerGlobalScopeTask::performTask): Deleted. (WebCore::CloseWorkerGlobalScopeTask::isCleanupTask): Deleted. * workers/WorkerGlobalScope.h: * workers/WorkerLoaderProxy.h: * workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::postMessageToWorkerObject): (WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope): (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope): (WebCore::WorkerMessagingProxy::postTaskToLoader): (WebCore::WorkerMessagingProxy::postExceptionToWorkerObject): (WebCore::WorkerMessagingProxy::workerThreadCreated): (WebCore::WorkerMessagingProxy::notifyNetworkStateChange): (WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed): (WebCore::WorkerMessagingProxy::workerGlobalScopeClosed): (WebCore::WorkerMessagingProxy::postMessageToPageInspector): (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject): (WebCore::WorkerMessagingProxy::reportPendingActivity): (WebCore::MessageWorkerGlobalScopeTask::create): Deleted. (WebCore::MessageWorkerGlobalScopeTask::MessageWorkerGlobalScopeTask): Deleted. (WebCore::MessageWorkerGlobalScopeTask::performTask): Deleted. (WebCore::MessageWorkerTask::create): Deleted. (WebCore::MessageWorkerTask::MessageWorkerTask): Deleted. (WebCore::MessageWorkerTask::performTask): Deleted. (WebCore::WorkerExceptionTask::create): Deleted. (WebCore::WorkerExceptionTask::WorkerExceptionTask): Deleted. (WebCore::WorkerExceptionTask::performTask): Deleted. (WebCore::WorkerGlobalScopeDestroyedTask::create): Deleted. (WebCore::WorkerGlobalScopeDestroyedTask::WorkerGlobalScopeDestroyedTask): Deleted. (WebCore::WorkerGlobalScopeDestroyedTask::performTask): Deleted. (WebCore::WorkerTerminateTask::create): Deleted. (WebCore::WorkerTerminateTask::WorkerTerminateTask): Deleted. (WebCore::WorkerTerminateTask::performTask): Deleted. (WebCore::WorkerThreadActivityReportTask::create): Deleted. (WebCore::WorkerThreadActivityReportTask::WorkerThreadActivityReportTask): Deleted. (WebCore::WorkerThreadActivityReportTask::performTask): Deleted. (WebCore::PostMessageToPageInspectorTask::create): Deleted. (WebCore::PostMessageToPageInspectorTask::PostMessageToPageInspectorTask): Deleted. (WebCore::PostMessageToPageInspectorTask::performTask): Deleted. (WebCore::NotifyNetworkStateChangeTask::create): Deleted. (WebCore::NotifyNetworkStateChangeTask::NotifyNetworkStateChangeTask): Deleted. (WebCore::NotifyNetworkStateChangeTask::performTask): Deleted. * workers/WorkerMessagingProxy.h: * workers/WorkerRunLoop.cpp: (WebCore::WorkerRunLoop::postTask): (WebCore::WorkerRunLoop::postTaskAndTerminate): (WebCore::WorkerRunLoop::postTaskForMode): (WebCore::WorkerRunLoop::Task::create): (WebCore::WorkerRunLoop::Task::performTask): (WebCore::WorkerRunLoop::Task::Task): * workers/WorkerRunLoop.h: * workers/WorkerThread.cpp: (WebCore::WorkerThread::stop): (WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads): (WebCore::WorkerThreadShutdownFinishTask::create): Deleted. (WebCore::WorkerThreadShutdownFinishTask::performTask): Deleted. (WebCore::WorkerThreadShutdownFinishTask::isCleanupTask): Deleted. (WebCore::WorkerThreadShutdownStartTask::create): Deleted. (WebCore::WorkerThreadShutdownStartTask::performTask): Deleted. (WebCore::WorkerThreadShutdownStartTask::isCleanupTask): Deleted. 2014-04-29 Manuel Rego Casasnovas REGRESSION (r167879): Heap-use-after-free in WebCore::RenderFlexibleBox https://bugs.webkit.org/show_bug.cgi?id=132337 Reviewed by Simon Fraser. From Blink r154582 by This is a regression from the changes in OrderIterator. The issue is that we don't invalidate our iterator when a child is removed. This means that we could hold onto free'd memory until the next layout when we will recompute the iterator. The solution is simple: just clear the memory when we remove a child. Note that RenderGrid is not impacted by this bug as we don't use the iterator outside layout yet, but if we do it at some point the very same problem will arise, so the same treatment was applied to the class. Test: fast/flexbox/order-iterator-crash.html * rendering/OrderIterator.cpp: (WebCore::OrderIterator::invalidate): Clear m_children Vector. * rendering/OrderIterator.h: (WebCore::OrderIteratorPopulator::OrderIteratorPopulator): Use invalidate() method. * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::removeChild): Invalidate m_orderIterator. * rendering/RenderFlexibleBox.h: Add removeChild() signature. * rendering/RenderGrid.cpp: Invalidate m_orderIterator. (WebCore::RenderGrid::removeChild): * rendering/RenderGrid.h: Add removeChild() header. 2014-04-29 Enrica Casucci iOS build fix after http://trac.webkit.org/changeset/167937. Unreviewed. * rendering/RenderThemeIOS.mm: (WebCore::RenderThemeIOS::adjustButtonStyle): 2014-04-29 Hans Muller [CSS Shapes] off-by-one error in Shape::createRasterShape() https://bugs.webkit.org/show_bug.cgi?id=132154 Reviewed by Bem Jones-Bey. This is a port of a patch for a bug that was reported by and fixed in Blink by David Vest: https://codereview.chromium.org/237123002/. Shape::createRasterShape() now consistently reports "end-point exclusive" intervals. Before the patch an entire row of pixels was above the shape-image-threshold, the interval's end index was reported as image.width. Now it's image.width + 1, which is consistent with the way the end index is reported if the last above threshold pixel is within an image row. Two existing tests were revised to account for this change. * rendering/shapes/RasterShape.cpp: (WebCore::RasterShape::getExcludedIntervals): * rendering/shapes/Shape.cpp: (WebCore::Shape::createRasterShape): 2014-04-29 Bem Jones-Bey Wrap CSS length conversion arguments in an object https://bugs.webkit.org/show_bug.cgi?id=131552 Reviewed by Andreas Kling. This patch introduces a class CSSToLengthConversionData to wrap the data required to convert CSS lengths to Lengths. This simplifies the plumbing that goes on whenever we need to resolve CSS lengths and makes it easier to update the arguments needed for resolving these (in particular adding a RenderView for resolving viewport units at style recalc time; removing the computingFontSize bool also appears possible). Note that the zoom argument, which was previously a float in some places and a double in others is now a float. This is a port of a Blink patch by timloh@chromium.org. No new tests, no behavior change. * CMakeLists.txt: * WebCore.vcxproj/WebCore.vcxproj: * WebCore.xcodeproj/project.pbxproj: * css/BasicShapeFunctions.cpp: (WebCore::convertToLength): (WebCore::convertToLengthSize): (WebCore::convertToCenterCoordinate): (WebCore::cssValueToBasicShapeRadius): (WebCore::basicShapeForValue): * css/BasicShapeFunctions.h: * css/CSSCalculationValue.cpp: (WebCore::CSSCalcValue::computeLengthPx): (WebCore::determineCategory): * css/CSSCalculationValue.h: (WebCore::CSSCalcValue::createCalculationValue): * css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::addStops): (WebCore::positionFromValue): (WebCore::CSSGradientValue::computeEndPoint): (WebCore::CSSLinearGradientValue::createGradient): (WebCore::CSSRadialGradientValue::resolveRadius): (WebCore::CSSRadialGradientValue::createGradient): * css/CSSGradientValue.h: * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLength): (WebCore::CSSPrimitiveValue::computeLengthDouble): * css/CSSPrimitiveValue.h: * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::convertToLength): * css/CSSToLengthConversionData.cpp: Added. (WebCore::CSSToLengthConversionData::zoom): * css/CSSToLengthConversionData.h: Added. (WebCore::CSSToLengthConversionData::CSSToLengthConversionData): (WebCore::CSSToLengthConversionData::style): (WebCore::CSSToLengthConversionData::rootStyle): (WebCore::CSSToLengthConversionData::computingFontSize): (WebCore::CSSToLengthConversionData::copyWithAdjustedZoom): * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::CSSToStyleMap): (WebCore::CSSToStyleMap::mapFillSize): (WebCore::CSSToStyleMap::mapFillXPosition): (WebCore::CSSToStyleMap::mapFillYPosition): (WebCore::CSSToStyleMap::mapNinePieceImageQuad): * css/CSSToStyleMap.h: (WebCore::CSSToStyleMap::CSSToStyleMap): Deleted. * css/DeprecatedStyleBuilder.cpp: (WebCore::ApplyPropertyAuto::applyValue): (WebCore::ApplyPropertyClip::convertToLength): (WebCore::ApplyPropertyLength::applyValue): (WebCore::ApplyPropertyBorderRadius::applyValue): (WebCore::ApplyPropertyComputeLength::applyValue): (WebCore::ApplyPropertyFontSize::applyValue): (WebCore::csstoLengthConversionDataWithTextZoomFactor): (WebCore::ApplyPropertyMarqueeIncrement::applyValue): (WebCore::ApplyPropertyLineHeight::applyValue): (WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue): (WebCore::ApplyPropertyWordSpacing::applyValue): (WebCore::ApplyPropertyPageSize::mmLength): (WebCore::ApplyPropertyPageSize::inchLength): (WebCore::ApplyPropertyPageSize::applyValue): (WebCore::ApplyPropertyVerticalAlign::applyValue): (WebCore::ApplyPropertyClipPath::applyValue): (WebCore::ApplyPropertyShape::applyValue): (WebCore::ApplyPropertyTextIndent::applyValue): * css/MediaQueryEvaluator.cpp: (WebCore::colorMediaFeatureEval): (WebCore::color_indexMediaFeatureEval): (WebCore::monochromeMediaFeatureEval): (WebCore::orientationMediaFeatureEval): (WebCore::aspect_ratioMediaFeatureEval): (WebCore::device_aspect_ratioMediaFeatureEval): (WebCore::device_pixel_ratioMediaFeatureEval): (WebCore::resolutionMediaFeatureEval): (WebCore::gridMediaFeatureEval): (WebCore::computeLength): (WebCore::device_heightMediaFeatureEval): (WebCore::device_widthMediaFeatureEval): (WebCore::heightMediaFeatureEval): (WebCore::widthMediaFeatureEval): (WebCore::min_colorMediaFeatureEval): (WebCore::max_colorMediaFeatureEval): (WebCore::min_color_indexMediaFeatureEval): (WebCore::max_color_indexMediaFeatureEval): (WebCore::min_monochromeMediaFeatureEval): (WebCore::max_monochromeMediaFeatureEval): (WebCore::min_aspect_ratioMediaFeatureEval): (WebCore::max_aspect_ratioMediaFeatureEval): (WebCore::min_device_aspect_ratioMediaFeatureEval): (WebCore::max_device_aspect_ratioMediaFeatureEval): (WebCore::min_device_pixel_ratioMediaFeatureEval): (WebCore::max_device_pixel_ratioMediaFeatureEval): (WebCore::min_heightMediaFeatureEval): (WebCore::max_heightMediaFeatureEval): (WebCore::min_widthMediaFeatureEval): (WebCore::max_widthMediaFeatureEval): (WebCore::min_device_heightMediaFeatureEval): (WebCore::max_device_heightMediaFeatureEval): (WebCore::min_device_widthMediaFeatureEval): (WebCore::max_device_widthMediaFeatureEval): (WebCore::min_resolutionMediaFeatureEval): (WebCore::max_resolutionMediaFeatureEval): (WebCore::animationMediaFeatureEval): (WebCore::transitionMediaFeatureEval): (WebCore::transform_2dMediaFeatureEval): (WebCore::transform_3dMediaFeatureEval): (WebCore::view_modeMediaFeatureEval): (WebCore::video_playable_inlineMediaFeatureEval): (WebCore::hoverMediaFeatureEval): (WebCore::pointerMediaFeatureEval): (WebCore::MediaQueryEvaluator::eval): * css/SVGCSSStyleSelector.cpp: (WebCore::StyleResolver::applySVGProperty): * css/StyleResolver.cpp: (WebCore::StyleResolver::State::clear): (WebCore::StyleResolver::State::initForStyleResolve): (WebCore::StyleResolver::convertToIntLength): (WebCore::StyleResolver::convertToFloatLength): (WebCore::createGridTrackBreadth): (WebCore::StyleResolver::applyProperty): (WebCore::StyleResolver::createFilterOperations): * css/StyleResolver.h: (WebCore::StyleResolver::State::setStyle): (WebCore::StyleResolver::State::cssToLengthConversionData): * css/TransformFunctions.cpp: (WebCore::convertToFloatLength): (WebCore::transformsForValue): * css/TransformFunctions.h: * css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::setMatrixValue): * rendering/RenderThemeIOS.mm: (WebCore::applyCommonButtonPaddingToStyle): (WebCore::RenderThemeIOS::adjustButtonStyle): 2014-04-29 Zoltan Horvath [CSS Shapes] complex calc args for inset round vanish https://bugs.webkit.org/show_bug.cgi?id=132293 Reviewed by Bem Jones-Bey. In order to use calc in the rounded parameters for inset shapes, we need to pass RenderStyle for the value creation as we did for the width arguments. Without taking RenderStyle into account, we hit an assert not reache in CSSPrimitiveValue::init in the debug builds. I've added new parsing test. * css/BasicShapeFunctions.cpp: (WebCore::valueForBasicShape): * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::init): * css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::create): * css/CSSValuePool.h: (WebCore::CSSValuePool::createValue): 2014-04-29 Zoltan Horvath [CSS Shapes] complex calc values for shape-margin return null for computed style https://bugs.webkit.org/show_bug.cgi?id=132313 Reviewed by Bem Jones-Bey. We need to pass RenderStyle* to the cssValuePool when parsing shape-margin in order to use calc() as a parameter. I've added the new test case to parsing-shape-margin.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): 2014-04-29 Chris Fleizach AX: Row span info is wrong for table cells when a footer section is placed above a body section https://bugs.webkit.org/show_bug.cgi?id=131832 Reviewed by Mario Sanchez Prada. If a