2018-04-25 Michael Catanzaro [CMake] Some options should be marked as advanced https://bugs.webkit.org/show_bug.cgi?id=184972 Reviewed by Konstantin Tokarev. * Source/cmake/FindLibGcrypt.cmake: * Source/cmake/FindWebP.cmake: 2018-04-25 Michael Catanzaro [GTK] Miscellaneous build cleanups https://bugs.webkit.org/show_bug.cgi?id=184399 Reviewed by Žan Doberšek. * Source/cmake/OptionsGTK.cmake: 2018-04-24 Leo Balter Land test262 test results associated with Test262 runner https://bugs.webkit.org/show_bug.cgi?id=184667 Reviewed by Michael Saboff. * .gitignore: Ignore test262 results file. 2018-04-24 Zan Dobersek [WPE] Remove libgbm dependency https://bugs.webkit.org/show_bug.cgi?id=184906 Reviewed by Carlos Garcia Campos. Remove the libgbm CMake search module. It's not necessary anymore after r230562. * Source/cmake/FindLibGBM.cmake: Removed. 2018-04-23 Michael Catanzaro [GTK] check target looks broken https://bugs.webkit.org/show_bug.cgi?id=184407 Reviewed by Carlos Garcia Campos. It's pretty clear that nobody has been using check for a long time. We got rid of check-for-webkitdom-api-breaks a long time ago, when we stopped autogenerating the DOM API, but it's still used in the check target. Fix this. Also, the check target for some reason runs itself from the Source subdirectory of the builddir, but the test script expects to be run from the toplevel build directory. Fix this too. Add VERBATIM for good measure. * Source/PlatformGTK.cmake: 2018-04-20 Daniel Bates Unreviewed, rolling out r230117. Broke find-in-page for PDFs Reverted changeset: "ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]" https://bugs.webkit.org/show_bug.cgi?id=184161 https://trac.webkit.org/changeset/230117 2018-04-20 Carlos Garcia Campos [GTK] Local cross references are broken in API documentation https://bugs.webkit.org/show_bug.cgi?id=184771 Reviewed by Michael Catanzaro. Update the documentation html paths and install the JSC GLib API too. * Source/PlatformGTK.cmake: 2018-04-18 Carlos Garcia Campos Unreviewed. Update OptionsGTK.cmake and NEWS for 2.21.1 release. * Source/cmake/OptionsGTK.cmake: Bump version numbers. 2018-04-17 Zan Dobersek [CMake] Add and enable the ENABLE_CSS_ANIMATIONS_LEVEL_2 feature define https://bugs.webkit.org/show_bug.cgi?id=184681 Reviewed by Carlos Garcia Campos. * Source/cmake/WebKitFeatures.cmake: Add the ENABLE_CSS_ANIMATIONS_LEVEL_2 feature define. Follow Cocoa ports and enable it by default. 2018-04-15 Michael Catanzaro [WPE] Install files needed for WebKitWebExtensions https://bugs.webkit.org/show_bug.cgi?id=179915 Reviewed by Žan Doberšek. * Source/cmake/OptionsWPE.cmake: 2018-04-12 Ryan Haddad Unreviewed, rolling out r230554. The non-ASCII character in the filename causes issues with SVN Reverted changeset: "input.webkitEntries does not work as expected when folder contains accented chars" https://bugs.webkit.org/show_bug.cgi?id=184517 https://trac.webkit.org/changeset/230554 2018-04-12 Zan Dobersek [WPE] Switch testing process to using WPEBackend-fdo https://bugs.webkit.org/show_bug.cgi?id=184357 Reviewed by Carlos Alberto Lopez Perez. * Source/cmake/FindWPEBackend-fdo.cmake: Renamed from Source/cmake/FindWPEBackend-mesa.cmake. 2018-04-11 Thibault Saunier [GStreamer] Use of playbin3 when USE_PLAYBIN3 environment variable is set https://bugs.webkit.org/show_bug.cgi?id=184498 Reviewed by Philippe Normand. This is the same behaviour as with playbin itself. Make sure to keep using "playbin" for MediaSource. * Source/cmake/GStreamerDefinitions.cmake: 2018-04-09 Michael Catanzaro [WPE] Use GNU install directories https://bugs.webkit.org/show_bug.cgi?id=184377 Reviewed by Carlos Garcia Campos. Notably, this means all the CMake arguments that distributors use to customize install directories (-DCMAKE_INSTALL_*DIR) will no longer be ignored. * Source/cmake/OptionsCommon.cmake: * Source/cmake/OptionsWPE.cmake: 2018-04-08 Fujii Hironori [CMake] WebKit should link to WebCore as a PRIVATE library if WebCore is a static library https://bugs.webkit.org/show_bug.cgi?id=184127 Reviewed by Konstantin Tokarev. Building TestWebKitLib on Windows causes a linkage error of multiply defined symbols because TestWebKitLib links to both WebCore and WebKit. TestWebKitLib explicitly links only with WebKit, But, WebCore is propagated because WebKit links WebCore as public. * Source/cmake/OptionsGTK.cmake (ADD_WHOLE_ARCHIVE_TO_LIBRARIES): Do not wrap PRIVATE and PUBLIC keywords with -Wl,--whole-archive. 2018-04-08 Michael Catanzaro [WPE][GTK] Remove applicationDirectoryPath() and sharedResourcePath() https://bugs.webkit.org/show_bug.cgi?id=184381 Reviewed by Carlos Garcia Campos. * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: 2018-04-02 Per Arne Vollan Remove references to internal version of WebKitQuartzCoreAdditions in CMake files. https://bugs.webkit.org/show_bug.cgi?id=184246 Unreviewed build fix. * Source/PlatformWin.cmake: 2018-04-02 Alejandro G. Castro [GTK] Make libwebrtc backend buildable for GTK port https://bugs.webkit.org/show_bug.cgi?id=178860 Reviewed by Youenn Fablet. * Source/CMakeLists.txt: Add the libwebrtc directory to the compilation. * Source/cmake/OptionsGTK.cmake: Add the USE_LIBWEBRTC option to allow compilation of the specific code. 2018-03-30 Daniel Bates ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:] https://bugs.webkit.org/show_bug.cgi?id=184161 Reviewed by Per Arne Vollan. * ManualTests/DragInlinePDFImageDocument.html: Added. * ManualTests/resources/simple.pdf: Added. 2018-03-28 Tim Horton Make it possible to disable building the tools with Make https://bugs.webkit.org/show_bug.cgi?id=184109 Reviewed by Simon Fraser. * Makefile: 2018-03-25 Carlos Garcia Campos [GTK][WPE] Add API to convert between DOM and JSCValue https://bugs.webkit.org/show_bug.cgi?id=183448 Reviewed by Michael Catanzaro. Define FORWARDING_HEADERS_WPE_DOM_DIR. * Source/cmake/OptionsWPE.cmake: 2018-03-22 Adrian Perez de Castro [WPE] Enable WOFF2 support https://bugs.webkit.org/show_bug.cgi?id=178158 Reviewed by Frédéric Wang. * Source/cmake/OptionsWPE.cmake: Add needed logic to detect the Brotli and WOFF2 libraries. 2018-03-21 Carlos Garcia Campos [GTK][WPE] Initial implementation of JavaScriptCore glib bindings https://bugs.webkit.org/show_bug.cgi?id=164061 Reviewed by Michael Catanzaro. Set global variables used by the makefiles. * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: 2018-03-15 Ms2ger [GTK][WPE] Enable service workers https://bugs.webkit.org/show_bug.cgi?id=178576 Reviewed by Žan Doberšek. * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: 2018-03-12 Yoav Weiss Runtime flag for link prefetch and remove link subresource. https://bugs.webkit.org/show_bug.cgi?id=183540 Reviewed by Chris Dumez. Remove the LINK_PREFETCH build time flag. * Source/cmake/OptionsWin.cmake: * Source/cmake/WebKitFeatures.cmake: * Source/cmake/tools/vsprops/FeatureDefines.props: * Source/cmake/tools/vsprops/FeatureDefinesCairo.props: 2018-03-12 Zan Dobersek Unreviewed. Unbreak the WPE layout testing that's been broken since r229470. Due to disassociation between ENABLE(ACCESSIBILITY) and HAVE(ACCESSIBILITY), the injected bundle for the WPE port was left with undefined symbols. This is fixed with ENABLE_ACCESSIBILITY being enabled for the WPE port as well. * Source/cmake/OptionsWPE.cmake: 2018-03-12 Carlos Garcia Campos Unreviewed. Fix library version of JavaScriptCoreGTK. * Source/cmake/OptionsGTK.cmake: 2018-03-09 Carlos Garcia Campos Unreviewed. Bump WebKitGTK+ version to 2.21.0. * Source/cmake/OptionsGTK.cmake: 2018-03-08 Tim Horton Add a way to not build libwebrtc when building WebKit via Makefiles https://bugs.webkit.org/show_bug.cgi?id=183437 Reviewed by Dan Bernstein. * Source/Makefile: 2018-03-05 Don Olmstead [CMake] Split JSC header copying into public and private targets https://bugs.webkit.org/show_bug.cgi?id=183251 Reviewed by Konstantin Tokarev. * Source/cmake/WebKitMacros.cmake: 2018-03-02 Don Olmstead Add clang-format configuration https://bugs.webkit.org/show_bug.cgi?id=183302 Reviewed by Ryosuke Niwa. * .clang-format: Added. 2018-03-01 Michael Catanzaro [CMake] configure failure for aarch64 https://bugs.webkit.org/show_bug.cgi?id=183268 Unreviewed build fix. This failure is caused by a simple typo. * Source/cmake/OptionsCommon.cmake: 2018-02-26 Yousuke Kimoto [WinCairo] WebKit2_C.h should be included for TestWebKit https://bugs.webkit.org/show_bug.cgi?id=182682 Reviewed by Yusuke Suzuki. Added a new definition "BUILDING_WIN_CAIRO_WEBKIT" to specify the wincairo webkit build. * Source/cmake/OptionsWinCairo.cmake: 2018-02-26 Fujii Hironori [CMake][OpenVR] Linkage errors happen because only OpenVR is compiled with -stdlib=libc++ if Clang is used https://bugs.webkit.org/show_bug.cgi?id=183116 Reviewed by Žan Doberšek. OpenVR has a option USE_LIBCXX to enable/disable that behavior. Let's disable it. * Source/CMakeLists.txt: Added a option command for USE_LIBCXX to set OFF as default. 2018-02-21 Don Olmstead [CMake] Expose HAVE macros globally https://bugs.webkit.org/show_bug.cgi?id=183011 Reviewed by Michael Catanzaro. * Source/cmake/OptionsCommon.cmake: * Source/cmake/WebKitFeatures.cmake: 2018-02-21 Don Olmstead [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h https://bugs.webkit.org/show_bug.cgi?id=182883 Reviewed by Per Arne Vollan. * Source/cmake/OptionsAppleWin.cmake: * Source/cmake/OptionsWin.cmake: * Source/cmake/OptionsWinCairo.cmake: 2018-02-21 Michael Catanzaro [GTK] USE_UPOWER causes crashes inside a chroot or on systems with broken dbus/upower https://bugs.webkit.org/show_bug.cgi?id=181825 Reviewed by Carlos Garcia Campos. Get rid of the upower-glib dependency. We will use upower's D-Bus API instead. * Source/cmake/FindUPowerGLib.cmake: Removed. * Source/cmake/OptionsGTK.cmake: 2018-02-20 Adrian Perez de Castro [GTK][CMake] Support building with Enchant 2.x https://bugs.webkit.org/show_bug.cgi?id=182933 Reviewed by Michael Catanzaro. * Source/cmake/FindEnchant.cmake: Check for both the "enchant" and "enchant-2" pkg-config components, picking the first available for which the headers and library are usable. 2018-02-19 Philippe Normand [GStreamer] Playbin3 support https://bugs.webkit.org/show_bug.cgi?id=182530 Reviewed by Xabier Rodriguez-Calvar. * Source/cmake/GStreamerDefinitions.cmake: New USE(GSTREAMER_PLAYBIN3) feature. This should be enabled only for very recent versions of GStreamer (1.14 at least) and is optional, for now. 2018-02-18 Philippe Normand [GTK][WPE] Fullscreen video is broken https://bugs.webkit.org/show_bug.cgi?id=182740 Reviewed by Michael Catanzaro. * Source/cmake/WebKitFeatures.cmake: Enable the VIDEO_USES_ELEMENT_FULLSCREEN feature on CMake ports. 2018-02-16 Dean Jackson Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa https://bugs.webkit.org/show_bug.cgi?id=182894 Reviewed by Tim Horton. Rename OPENGL_ES_2 to OPENGL_ES. * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: 2018-02-09 Ross Kirsling Simplify .gitignore's WebKitLibraries/win section. https://bugs.webkit.org/show_bug.cgi?id=182618 Reviewed by Per Arne Vollan. We need to update this section for WinCairoRequirements regardless, but it never needed to be this longwinded in the first place. * .gitignore: 2018-02-08 Fujii Hironori [Meta][Win] Support ICU 59.1+ https://bugs.webkit.org/show_bug.cgi?id=181004 Reviewed by Alex Christensen. ICU 59 changed the type of UChar from wchar_t to char16_t on Windows. We need a lot of conversions between UChar* and wchar_t* to call Windows API because it takes string as wchar_t*. Fortunately, ICU is configurable to define UChar as wchar_t as well as the prior ICU. * Source/cmake/OptionsWin.cmake: Add a compile option -DUCHAR_TYPE=wchar_t. 2018-02-08 Michael Catanzaro Unreviewed, switch -pthread to -lpthread per recommendation from Adrian https://bugs.webkit.org/show_bug.cgi?id=182400 This is tested and works fine. * Source/cmake/WebKitCompilerFlags.cmake: 2018-02-05 Yousuke Kimoto [WinCairo] Refine WebKitLegacy and WebKit build for wincairo https://bugs.webkit.org/show_bug.cgi?id=182478 Reviewed by Alex Christensen. * Source/cmake/OptionsWinCairo.cmake: Added a ENABLE_WIN_CAIRO_WEBKIT option to build webkit for wincairo. 2018-02-05 Michael Catanzaro Unreviewed, fix build using the new ENABLE_ADDRESS_SANITIZER option https://bugs.webkit.org/show_bug.cgi?id=182400 I failed to properly test a last-minute change. * Source/cmake/WebKitCompilerFlags.cmake: 2018-02-05 Michael Catanzaro [CMake] Add ENABLE_ADDRESS_SANITIZER to make it easier to build with asan support https://bugs.webkit.org/show_bug.cgi?id=182400 Reviewed by Konstantin Tokarev. * Source/cmake/OptionsGTK.cmake: * Source/cmake/WebKitCompilerFlags.cmake: 2018-01-31 Michael Catanzaro Update ReadMe.md https://bugs.webkit.org/show_bug.cgi?id=182314 Reviewed by Alex Christensen. Add download link for Epiphany Technology Preview. Improve build instructions for GTK. Add build instructions for WPE. Add instructions to run MiniBrowser on Linux. Miscellaneous typographical adjustments. * ReadMe.md: 2018-01-30 Sergio Villar Senin [WebVR][GTK][WPE] Exclude OpenVR from tarballs https://bugs.webkit.org/show_bug.cgi?id=182284 Reviewed by Michael Catanzaro. Added private build options for USE_OPENVR. * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: 2018-01-30 Basuke Suzuki [WinCairo] Fix forwarding header conflict of WebKit on WinCairo https://bugs.webkit.org/show_bug.cgi?id=177202 Reviewed by Alex Christensen. * Source/cmake/WebKitMacros.cmake: 2018-01-29 Jiewen Tan [WebAuthN] Add a compile-time feature flag https://bugs.webkit.org/show_bug.cgi?id=182211 Reviewed by Brent Fulgham. * Source/cmake/WebKitFeatures.cmake: * Source/cmake/tools/vsprops/FeatureDefines.props: * Source/cmake/tools/vsprops/FeatureDefinesCairo.props: 2018-01-18 Sergio Villar Senin [WebVR] Add OpenVR to the tree and to the build https://bugs.webkit.org/show_bug.cgi?id=177298 Reviewed by Žan Doberšek. * Source/CMakeLists.txt: * Source/cmake/OptionsGTK.cmake: Enable USE_OPENVR. * Source/cmake/OptionsWPE.cmake: Ditto. 2018-01-18 Dan Bernstein [Xcode] Shared schemes in the WebKit workspace still have build pre-actions that invoke copy-webkitlibraries-to-product-directory https://bugs.webkit.org/show_bug.cgi?id=181784 Reviewed by Anders Carlsson. * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Remove the build pre-action. * WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Ditto. 2018-01-17 Michael Catanzaro WEBKIT_FRAMEWORK should not modify file-global include directories https://bugs.webkit.org/show_bug.cgi?id=181656 Reviewed by Konstantin Tokarev. Only modify the system include directories of the target passed to WEBKIT_FRAMEWORK. * Source/cmake/WebKitMacros.cmake: 2018-01-17 Carlos Garcia Campos Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.6 release. * Source/cmake/OptionsGTK.cmake: Bump version numbers. 2018-01-15 Michael Catanzaro REGRESSION(r226266): [GTK] RELEASE_ASSERT(reservedZoneSize >= minimumReservedZoneSize) in JSC::VM::updateStackLimits https://bugs.webkit.org/show_bug.cgi?id=181438 Reviewed by Carlos Garcia Campos. Build JSC as a shared library. Stop using -fvisibility=hidden. This is a shame, but it is causing problems that I don't know how to fix. * Source/cmake/OptionsGTK.cmake: * Source/cmake/WebKitCompilerFlags.cmake: 2018-01-11 Keith Miller Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION https://bugs.webkit.org/show_bug.cgi?id=181573 Reviewed by Simon Fraser. * Source/cmake/WebKitFeatures.cmake: 2018-01-10 Per Arne Vollan [Win] WebKitLegacy should be a dll, not a static library. https://bugs.webkit.org/show_bug.cgi?id=181500 Reviewed by Alex Christensen. Set WebKitLegacy library type to shared. * Source/cmake/OptionsWin.cmake: 2018-01-09 Carlos Garcia Campos Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.5 release. * Source/cmake/OptionsGTK.cmake: Bump version numbers. 2018-01-09 Carlos Garcia Campos Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.4 release. * Source/cmake/OptionsGTK.cmake: Bump version numbers. 2018-01-05 Fujii Hironori REGRESSION(r226306)[Win][CMake] Unnecessary recompilations triggered by unconditionally copied header files of DerivedSources https://bugs.webkit.org/show_bug.cgi?id=181324 Reviewed by Konstantin Tokarev. r226306 changed to use cmake -E copy to copy header files of DerivedSources. This command copies files unconditionally, then introduced unnecessary recompilations. * Source/cmake/WebKitMacros.cmake: Use copy_if_different instead of copy. 2018-01-03 Ting-Wei Lan Replace hard-coded paths in shebangs with #!/usr/bin/env https://bugs.webkit.org/show_bug.cgi?id=181040 Reviewed by Alex Christensen. * Source/cmake/tools/scripts/auto-version.pl: * Source/cmake/tools/scripts/feature-defines.pl: * Source/cmake/tools/scripts/version-stamp.pl: == Rolled over to ChangeLog-2018-01-01 ==