1 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
3 There should be a way to associate bugs with analysis tasks
4 https://bugs.webkit.org/show_bug.cgi?id=138977
6 Reviewed by Benjamin Poulain.
8 Updated associate-bug.php to match the new database schema.
10 * public/include/json-header.php:
11 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
12 already camel-cased in require_existence_of. This makes the function usable elsewhere.
14 * public/privileged-api/associate-bug.php:
15 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
16 Also verify that those values are integers using require_format.
18 * public/v2/analysis.js:
19 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
20 (App.Bug.label): Added.
21 (App.BugAdapter): Added.
22 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
23 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
25 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
26 containing the bug information.
29 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
30 (App.AnalysisTaskRoute):
31 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
32 (App.AnalysisTaskController._fetchedManifest): Added.
33 (App.AnalysisTaskController.actions.associateBug): Added.
35 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
38 (Measurement.prototype.associateBug): Deleted.
40 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
41 Added a table show the bug information. Also hide the chart until chartData is available.
43 * public/v2/manifest.js:
46 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
48 Fix misc bugs and typos in app.js
49 https://bugs.webkit.org/show_bug.cgi?id=138946
51 Reviewed by Benjamin Poulain.
54 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
55 (App.ChartsController.init):
56 (App.buildPopup): Renamed from App.BuildPopup.
57 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
58 remove() on the wrong object (an array as opposed to elements in the array).
59 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
60 _highlights is always an array and evalutes to true.
62 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
64 New perf dashboard should provide UI to create a new analysis task
65 https://bugs.webkit.org/show_bug.cgi?id=138910
67 Reviewed by Benjamin Poulain.
69 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
70 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
72 With this patch, we can create a new analysis task by selection a range of points and opening
73 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
74 in the chart hyperlinked to the analysis task.
76 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
78 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
79 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
81 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
82 and adds the associated bugs to each task in the array.
85 * public/api/runs.php: Reverted changes made in r175006.
86 (fetch_runs_for_config):
89 * public/api/test-groups.php:
90 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
92 * public/include/db.php:
93 (Database::select_first_or_last_row):
94 (Database::select_rows): Extracted from select_first_or_last_row.
96 * public/v2/analysis.js:
97 (App.AnalysisTask): Added "bugs" property.
98 (App.Bug): Added now that bugs are regular data store objects.
101 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
102 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
103 platform that are associated with a specific range of runs.
104 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
105 (App.PaneController.actions.associateBug): Deleted.
106 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
107 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
108 once we've created one.
109 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
110 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
111 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
112 (App.PaneController._updateBugs): Deleted.
113 (App.PaneController._updateMarkedPoints): Deleted.
114 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
115 the name is missing or when at most one point is selected.
117 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
118 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
119 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
120 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
121 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
122 clickable bars for analysis tasks.
123 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
124 bar for analysis tasks to place them at the right location.
125 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
127 * public/v2/chart-pane.css:
128 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
129 (.chart .rangeBar): Added.
132 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
134 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
135 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
136 task bars in the interactive chart component.
138 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
140 Fix typos in r176203.
143 (App.ChartsController.actions.addPaneByMetricAndPlatform):
144 (App.AnalysisTaskRoute):
146 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
148 Unreviewed. Updated the install instruction.
152 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
154 App.Manifest shouldn't use App.__container__.lookup
155 https://bugs.webkit.org/show_bug.cgi?id=138768
157 Reviewed by Andreas Kling.
159 Removed the hack to find the store object via App.__container__.lookup.
160 Pass around the store object instead.
163 (App.DashboardRow._createPane): Add "store" property to the pane.
164 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
165 (App.IndexController.gridChanged): Ditto.
166 (App.IndexController.actions.addRow): Ditto.
167 (App.IndexController.init): Ditto.
168 (App.Pane._fetch): Ditto.
169 (App.ChartsController._parsePaneList): Ditto.
170 (App.ChartsController._updateQueryString): Ditto.
171 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
172 (App.BuildPopup): Ditto.
173 (App.AnalysisTaskRoute.model): Ditto.
174 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
176 * public/v2/manifest.js:
177 (App.Manifest.fetch): Removed the code to find the store object.
179 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
181 Fix Ember.js warnings the new perf dashboard
182 https://bugs.webkit.org/show_bug.cgi?id=138531
184 Reviewed by Darin Adler.
186 Fixed various warnings.
189 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
191 (PrivilegedAPI._post): Removed the superfluous console.log.
192 (CommitLogs.fetchForTimeRange): Ditto.
193 * public/v2/index.html: Added tbody as required by the HTML specification.
195 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
197 Fix typos in r175768.
200 (App.AnalysisTaskViewModel.roots):
202 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
204 Introduce the concept of analysis task to perf dashboard
205 https://bugs.webkit.org/show_bug.cgi?id=138517
207 Reviewed by Andreas Kling.
209 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
210 a single platform and used to bisect regressions in the range.
212 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
214 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
215 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
216 test runs. Analysis tasks not associated with test runs are used for try new patches.
217 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
218 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
219 build_requests - A build request represents a single pending build for A/B testing.
221 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
225 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
226 the specified analysis task group as well as build requests associated with them.
228 (fetch_test_groups_for_task):
229 (fetch_build_requests_for_task):
230 (fetch_build_requests_for_group):
232 (format_build_request):
234 * public/include/json-header.php:
235 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
238 * public/privileged-api/associate-bug.php:
239 (main): Fixed a typo.
241 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
244 (ensure_config_from_runs):
246 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
248 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
250 (App.AnalysisTask.create):
252 (App.TestGroupAdapter):
253 (App.AnalysisTaskSerializer):
254 (App.TestGroupSerializer):
257 * public/v2/app.css: Added style rules for the analysis page.
260 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
262 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
263 exactly one selected point as we can still create an analysis task.
264 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
265 grammatical and also alert'ed the error message when there is one.
266 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
267 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
268 once XHR request has completed.
269 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
270 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
271 is selected in the details pane.
273 (App.AnalysisRoute): Added.
274 (App.AnalysisTaskRoute): Added.
275 (App.AnalysisTaskViewModel): Added.
276 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
277 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
278 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
279 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
280 the user selects an option for all roots in A or B configuration.
281 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
283 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
286 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
287 point so that we can use it in App.AnalysisTaskViewModel.roots.
288 (TimeSeries.prototype.findPointByMeasurementId): Added.
289 (TimeSeries.prototype.seriesBetweenPoints): Added.
291 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
292 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
293 when multiple points are selected. Finally, added a new template for the analysis task page.
295 * public/v2/manifest.js:
296 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
297 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
298 App.AnalysisTaskViewModel._taskUpdated.
300 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
302 Remove App.PaneController.bugsChangeCount in the new perf dashboard
303 https://bugs.webkit.org/show_bug.cgi?id=138111
305 Reviewed by Darin Adler.
308 (App.PaneController.bugsChangeCount): Removed.
309 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
310 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
311 Finds the list of current run's points that are associated with bugs.
312 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
313 * public/v2/chart-pane.css:
314 (.chart .marked): Renamed from .hasBugs.
315 * public/v2/index.html: Specify chartPointRadius and markedPoints.
317 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
319 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
320 https://bugs.webkit.org/show_bug.cgi?id=138099
322 Reviewed by Benjamin Poulain.
324 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
325 _showDetails inverting the order of the current and old measurements.
328 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
329 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
330 current (latest) measurement and the first point is the oldest measurement.
331 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
333 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
335 Perf dashboard should provide a way to associate bugs with a test run
336 https://bugs.webkit.org/show_bug.cgi?id=137857
338 Reviewed by Andreas Kling.
340 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
341 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
342 the Apache configuration.
345 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
346 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
347 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
348 via the cookie and returns a token computed from those two values as well as the remote username.
350 The font end code then POST's the request along with the returned token. The server side code verifies
351 that the specified token can be generated from the salt and the expiration time set in the cookie, and
352 the token hasn't expired.
355 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
356 have zero or exactly one bug associated with a test run.
358 * public/admin/bug-trackers.php: Added the support for editing bug_url.
359 * public/api/runs.php:
360 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
361 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
362 an associated bug if there is one.
363 (format_run): Calls parse_bugs_array.
365 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
366 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
367 have a valid JSON payload.
368 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
369 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
370 the expiration time stored in the cookie.
371 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
373 * public/include/manifest.php:
374 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
375 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
378 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
380 * public/privileged-api/associate-bug.php: Added.
381 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
382 attack via ensure_privileged_api_data_and_token, which calls verify_token.
384 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
387 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
391 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
392 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
393 they would overlap on each other if both of them are shown.
394 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
395 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
396 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
397 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
398 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
399 showing the search pane.
400 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
401 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
402 bugs in the selected range.
404 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
405 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
406 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
407 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
408 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
409 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
410 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
411 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
413 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
414 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
415 to selectionChanged action instead of just finding the first and the last points.
417 * public/v2/chart-pane.css: Updated the style.
420 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
421 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
422 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
423 we haven't already obtained a CSRF token or if the token has already been expired.
424 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
426 (Measurement.prototype.bugs): Added.
427 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
428 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
430 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
433 * public/v2/manifest.js:
434 (App.BugTracker.bugUrl):
435 (App.BugTracker.newBugUrl): Added.
436 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
437 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
438 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
439 (App.Manifest.bugTrackers): Added.
440 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
441 their respective ids to make the ordering stable.
443 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
445 Remove unused jobs table
446 https://bugs.webkit.org/show_bug.cgi?id=137724
448 Reviewed by Daniel Bates.
450 Removed jobs table in the database as well as related code.
453 * public/admin/jobs.php: Removed.
454 * public/admin/tests.php:
455 * public/include/admin-header.php:
457 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
459 New perf dashboard should have an ability to search commits by a keyword
460 https://bugs.webkit.org/show_bug.cgi?id=137675
462 Reviewed by Geoffrey Garen.
464 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
465 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
466 This API change allows fetch_commits_between to generate results without processing Postgres query results.
468 In the front end side, we've added a search pane in pane controller, and the interactive chart component
469 now has a concept of highlighted items which is used to indicate commits found by the search pane.
471 * public/api/commits.php:
472 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
473 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
474 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
475 (format_commit): Renamed from format_commits. Now only formats one commit.
477 * public/include/db.php:
478 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
480 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
483 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
484 which is a hash table that contains highlighted items' measurements' ids as keys.
485 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
486 the default commit repository.
487 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
488 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
489 Added the code to initialize this._highlights.
490 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
491 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
492 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
493 the existing lines for the old highlighted items.
494 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
495 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
497 * public/v2/chart-pane.css: Added style for the search pane and the search button.
499 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
501 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
502 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
503 (CommitLogs._cacheConsecutiveCommits): Ditto.
504 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
505 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
506 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
508 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
509 for showingDetails since this property is no longer used.
511 * public/v2/manifest.js:
512 (App.Manifest.repositories): Added.
513 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
514 the default repository to search.
515 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
517 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
519 Unreviewed build fix after r174555.
521 * public/include/manifest.php:
522 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
523 * tests/admin-regenerate-manifest.js: Fixed the test case.
525 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
527 New perf dashboard UI tries to fetch commits all the time
528 https://bugs.webkit.org/show_bug.cgi?id=137592
530 Reviewed by Andreas Kling.
532 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
533 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
534 no reported commits as they are all going to fail.
536 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
537 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
538 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
539 of commits sorted chronologically by time.
541 * public/include/manifest.php:
544 (App.CommitsViewerComponent.commitsChanged):
547 (FetchCommitsForTimeRange):
548 (FetchCommitsForTimeRange._cachedCommitsByRepository):
550 * public/v2/manifest.js:
553 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
555 Another unreviewed build fix after r174477.
557 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
559 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
561 * public/include/report-processor.php:
563 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
565 Unreviewed build fix after r174477.
567 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
568 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
570 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
571 This is necessary for baseline and target values manually added via admin pages.
573 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
575 Add v2 UI for the perf dashboard
576 https://bugs.webkit.org/show_bug.cgi?id=137537
578 Rubber-stamped by Andreas Kling.
581 * public/v2/app.css: Added.
582 * public/v2/app.js: Added.
583 * public/v2/chart-pane.css: Added.
584 * public/v2/data.js: Added.
585 * public/v2/index.html: Added.
586 * public/v2/js: Added.
587 * public/v2/js/d3: Added.
588 * public/v2/js/d3/LICENSE: Added.
589 * public/v2/js/d3/d3.js: Added.
590 * public/v2/js/d3/d3.min.js: Added.
591 * public/v2/js/ember-data.js: Added.
592 * public/v2/js/ember.js: Added.
593 * public/v2/js/handlebars.js: Added.
594 * public/v2/js/jquery.min.js: Added.
595 * public/v2/js/statistics.js: Added.
596 * public/v2/manifest.js: Added.
597 * public/v2/popup.js: Added.
599 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
601 Remove superfluously duplicated code in public/api/report-commits.php.
603 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
605 Perf dashboard should store commit logs
606 https://bugs.webkit.org/show_bug.cgi?id=137510
608 Reviewed by Darin Adler.
610 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
612 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
613 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
614 a subversion directory. The git version of this script will be added in a follow up patch.
617 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
618 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
619 relationship via "build_commits" relations.
621 In order to migrate an existing instance of this application, run the following SQL commands:
625 INSERT INTO commits (commit_repository, commit_revision, commit_time)
626 (SELECT DISTINCT ON (revision_repository, revision_value)
627 revision_repository, revision_value, revision_time FROM build_revisions);
629 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
630 FROM commits, build_revisions
631 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
633 DROP TABLE build_revisions;
638 The helper script to submit commit logs can be used as follows:
640 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
641 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
643 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
644 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
645 "feeder-slave-password" as the builder name and the builder password respectively.
647 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
648 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
651 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
653 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
654 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
656 - Not specified - It returns every single commit for a given repository.
657 - Matches "oldest" - It returns the commit with the oldest timestamp.
658 - Matches "latest" - It returns the commit with the latest timestamp.
659 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
660 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
661 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
662 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
663 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
664 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
666 (commit_from_revision):
667 (fetch_commits_between):
670 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
671 See tests/api-report-commits.js for examples on how to use this API.
673 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
674 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
675 to optimize this and other JSON APIs.
677 * public/include/db.php:
678 (Database::select_or_insert_row):
679 (Database::update_or_insert_row): Added.
680 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
681 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
683 (Database::select_first_row):
684 (Database::select_last_row): Added.
685 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
686 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
688 * public/include/report-processor.php:
689 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
690 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
691 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
694 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
696 * tests/api-report-commits.js: Added.
697 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
700 * tools/pull-svn.py: Added. See above for how to use this script.
702 (determine_first_revision_to_fetch):
703 (fetch_revision_from_dasbhoard):
704 (fetch_commit_and_resolve_author):
707 (resolve_author_name_from_email):
710 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
712 Update Install.md for Mavericks and fix typos
713 https://bugs.webkit.org/show_bug.cgi?id=137276
715 Reviewed by Benjamin Poulain.
717 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
719 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
721 Finally, init-database.sql is no longer located inside database directory.
725 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
727 Report run id's in api/runs.php for the new dashboard UI
728 https://bugs.webkit.org/show_bug.cgi?id=135813
730 Reviewed by Andreas Kling.
732 Include run_id in the generated JSON.
734 * public/api/runs.php:
735 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
738 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
740 Merging platforms mixes baselines and targets into reported data
741 https://bugs.webkit.org/show_bug.cgi?id=135260
743 Reviewed by Andreas Kling.
745 When merging two platforms, move test configurations of a different type (baseline, target)
746 as well as of different metric (Time, Runs).
748 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
749 It's sufficient to detect one such test_runs object.
751 * public/admin/platforms.php:
754 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
756 Merging platforms mixes baselines and targets into reported data
757 https://bugs.webkit.org/show_bug.cgi?id=135260
759 Reviewed by Geoffrey Garen.
761 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
762 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
764 * public/admin/platforms.php:
766 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
768 Build fix after r171361.
770 * public/js/helper-classes.js:
771 (.this.formattedBuildTime):
773 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
775 Perf dashboard spends 2s processing JSON data during the page loads
776 https://bugs.webkit.org/show_bug.cgi?id=135152
778 Reviewed by Andreas Kling.
780 In the Apple internal dashboard, we were spending as much as 2 seconds
781 converting raw JSON data into proper JS objects while loading the dashboard.
783 This caused the apparent unresponsiveness of the dashboard despite of the fact
784 charts themselves updated almost instantaneously.
787 * public/js/helper-classes.js:
788 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
789 lazily as creating new Date objects and running string replace is expensive.
790 (TestBuild.formattedTime):
791 (TestBuild.formattedBuildTime):
792 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
793 (PerfTestRuns.addResult): Deleted.
795 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
797 Perf dashboard shouldn't show the full git hash
798 https://bugs.webkit.org/show_bug.cgi?id=135083
800 Reviewed by Benjamin Poulain.
802 Detect Git/Mercurial hash by checking the length.
804 If it's a hash, use the first 8 characters in the label
805 while retaining the full length to be used in hyperlinks.
807 * public/js/helper-classes.js:
808 (.this.formattedRevisions):
811 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
813 Add an instruction on how to backup the database.
814 https://bugs.webkit.org/show_bug.cgi?id=133391
816 Rubber-stamped by Andreas Kling.
820 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
822 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
824 * public/js/helper-classes.js:
825 (PerfTestRuns.smallerIsBetter):
827 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
837 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
839 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
840 https://bugs.webkit.org/show_bug.cgi?id=131157
842 Reviewed by Andreas Kling.
844 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
845 This allows, for example, adding all metrics such as Arithmetic and Geometric for
846 a given test suite without also adding its subtests.
852 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
854 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
855 https://bugs.webkit.org/show_bug.cgi?id=131155
857 Reviewed by Andreas Kling.
859 The bug was caused by Chart.attach binding event listeners on plot container on each call.
860 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
861 click when attach() has been called even number of times, keeping the tooltip invisible.
863 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
864 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
865 is called for the first time.
869 (Chart..bindPlotEventHandlers):
871 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
873 WebKitPerfMonitor: Tooltips can be cut off at the top
874 https://bugs.webkit.org/show_bug.cgi?id=130960
876 Reviewed by Andreas Kling.
879 (#title): Removed the gradients, box shadows, and border from the header.
880 (#title h1): Reduce the font size.
881 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
883 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
884 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
885 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
886 * public/js/helper-classes.js:
887 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
888 tooltip extending above y=0.
890 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
892 WebKitPerfMonitor: Y-axis adjustment is too aggressive
893 https://bugs.webkit.org/show_bug.cgi?id=130937
895 Reviewed by Andreas Kling.
897 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
898 results. This had two major problems:
899 1. Two standard deviations can be too small to show the confidence interval for results.
900 2. Sometimes baseline and target can be more than two standards deviations away.
902 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
903 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
904 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
905 the margin on each side separately to reduce the empty space on either side.
907 A more rigorous approach would involve computing least squared value of results with respect to intervals
908 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
911 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
912 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
913 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
914 We wouldn't see the difference between measured values versus baseline and target values otherwise.
915 * public/js/helper-classes.js:
916 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
917 interval delta cannot be computed.
918 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
919 within the given interval.
920 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
921 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
922 (PerfTestRuns..unscaledMeansForAllResults):
923 (PerfTestRuns.min): Take the confidence interval delta into account.
924 (PerfTestRuns.max): Ditto.
925 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
926 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
928 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
930 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
932 Some CSS tweaks after r166477 and r166479,
936 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
938 WebKitPerfMonitor: Sometimes text inside panes overlap
939 https://bugs.webkit.org/show_bug.cgi?id=130956
941 Reviewed by Gyuyoung Kim.
943 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
944 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
945 reduces the total height of the pane and fits more information per screen capita on the dashboard.
947 * public/index.html: Updated and added a bunch of CSS rules for the new look.
948 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
949 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
950 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
951 of the build info shown in a chart pane and a tooltip.
952 (Chart): Made .status a table.
953 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
954 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
955 now that status.text no longer contains it.
956 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
958 * public/js/helper-classes.js:
959 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
960 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
961 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
962 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
963 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
964 capital letter; e.g. "MB" instead of "M B".
966 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
968 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
969 https://bugs.webkit.org/show_bug.cgi?id=130957
971 Reviewed by Gyuyoung Kim.
973 Moved the slider into the header. Also reduced the spacing between the header and platform names.
974 This reclaims 50px × width of the screen real estate.
977 (#title): Reduced the space below the header from 20px to 10px.
979 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
980 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
981 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
982 real estate between the header and the platform names.
984 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
986 Update the install guidelines for perf.webkit.org
987 https://bugs.webkit.org/show_bug.cgi?id=129895
989 Reviewed by Ryosuke Niwa.
991 The current install guideline for perf.webkit.org discourages the use of the installed
992 Server application. I've actualized the documentation for Mavericks, and modified the
993 guideline to include the instructions for Server.app also.
997 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
999 Update perf.webkit.org json example
1000 https://bugs.webkit.org/show_bug.cgi?id=129907
1002 Reviewed by Andreas Kling.
1004 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
1008 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
1010 Merge database-common.js and utility.js into run-tests.js.
1012 Reviewed by Matthew Hanson.
1014 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
1015 Also moved init-database.sql out of the database directory and removed the directory entirely.
1017 * database: Removed.
1018 * database/database-common.js: Removed.
1019 * database/utility.js: Removed.
1020 * init-database.sql: Moved from database/init-database.sql.
1022 (connect): Moved from database-common.js.
1023 (pathToDatabseSQL): Extracted from pathToLocalScript.
1024 (pathToTests): Moved from database-common.js.
1027 (SerializedTaskQueue): Ditto.
1029 (initializeDatabase):
1030 (TestEnvironment.it):
1031 (TestEnvironment.queryAndFetchAll):
1034 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1036 Remove the dependency on node.js from the production code.
1038 Reviewed by Ricky Mondello.
1040 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
1042 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
1043 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
1044 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
1045 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
1046 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
1048 Also removed the js files that are no longer used.
1050 * config.json: Moved from database/config.json.
1051 * database/aggregate.js: Removed. No longer used.
1052 * database/database-common.js: Removed unused functions, and updated the path to config.json.
1053 * database/process-jobs.js: Removed. No longer used.
1054 * database/sample-data.sql: Removed. We have a much better corpus of data now.
1055 * database/schema.graffle: Removed. It's completely obsolete.
1056 * public/include/db.php: Updated the path to config.json.
1057 * public/include/evaluator.js: Removed.
1059 * public/include/report-processor.php:
1060 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
1061 storing values into $expressions and calling evaluate_expressions_by_node.
1062 (TestRunsGenerator::aggregate_values): Added.
1063 (TestRunsGenerator::compute_caches): Directly compute the caches.
1065 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1067 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
1069 * public/admin/platforms.php:
1070 * public/include/db.php:
1072 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1074 Zoomed y-axis view is ununsable when the last result is an outlier.
1076 Reviewed by Stephanie Lewis.
1078 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
1079 the last result so that the graph looks sane if the last result was an outlier. However, always show
1080 the last result's mean even if it was an outlier.
1082 * public/index.html:
1083 * public/js/helper-classes.js:
1084 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
1085 Also added the ability to cache the unscaled means to avoid recomputation.
1086 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
1087 (PerfTestRuns.max): Ditto.
1088 (PerfTestRuns.sampleStandardDeviation): Ditto.
1089 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
1091 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1095 * public/admin/tests.php:
1096 * public/js/helper-classes.js:
1098 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
1100 Use two standard deviations instead as I mentioned in the mailing list.
1102 * public/index.html:
1104 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
1106 The performance dashboard erroneously shows upward arrow for combined metrics.
1108 A single outlier can ruin the zoomed y-axis view.
1110 Rubber-stamped by Antti Koivisto.
1112 * public/index.html:
1113 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
1114 from the latest results' mean.
1115 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
1116 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
1117 (Chart.toggleYAxis):
1118 * public/js/helper-classes.js:
1119 (PerfTestRuns.sampleStandardDeviation): Added.
1120 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
1122 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
1124 Don't include the confidence interval when computing the y-axis.
1126 Rubber-stamped by Simon Fraser.
1128 * public/js/helper-classes.js:
1132 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
1134 Tiny CSS tweak for tooltips.
1136 * public/index.html:
1138 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
1140 Remove the erroneously repeated code.
1142 * public/admin/test-configurations.php:
1144 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1146 <rdar://problem/15704893> perf dashboard should show baseline numbers
1148 Reviewed by Stephanie Lewis.
1150 * public/admin/bug-trackers.php:
1151 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
1154 * public/admin/platforms.php:
1155 (merge_list): Ditto.
1157 * public/admin/test-configurations.php: Added.
1158 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
1159 build_revisions as they're not meaningful for baseline / target numbers.
1160 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
1161 one test run so that we don't accidentally delete a reported test run.
1162 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
1163 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
1164 and delete existing ones.
1166 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
1167 on each platform; there could be configurations of distinct types such as "current" and "baseline".
1168 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
1170 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
1171 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
1172 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
1173 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
1174 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
1176 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
1178 * public/include/admin-header.php:
1179 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
1180 have id and type sub columns, and each custom column could generate multiple rows.
1182 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
1183 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
1184 We then proceed to generate the second header row with sub column names.
1186 When generating the actual content, we first generate all custom columns as they may have multiple rows in
1187 which case regular columns need rowspan set to the maximum number of rows.
1189 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
1192 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
1193 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
1194 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
1195 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
1196 expanded to occupy all sub columns.
1198 * public/include/manifest.php:
1199 (ManifestGenerator::platforms): Don't add the metric more than once.
1201 * public/include/test-name-resolver.php:
1202 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
1203 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
1204 full metric name later.
1205 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
1206 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
1207 (TestNameResolver::full_name_for_test): Added.
1208 (TestNameResolver::full_name_for_metric): Added.
1209 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
1211 * public/js/helper-classes.js:
1212 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
1213 test runs created to set baseline and target points.
1215 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1217 Build fix after r57928. Removed a superfluous close parenthesis.
1219 * public/api/runs.php:
1221 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1223 Unreviewed build & typo fixes.
1225 * public/admin/platforms.php:
1226 * tests/admin-platforms.js:
1228 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1230 <rdar://problem/15704893> perf dashboard should show baseline numbers
1232 Rubber-stamped by Antti Koivisto.
1234 Organize some code into functions in runs.php.
1236 Also added back $paths that was erroneously removed in r57925 from json-header.php.
1238 * public/api/runs.php:
1239 (fetch_runs_for_config): Extracted.
1240 (format_run): Ditto.
1242 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1244 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
1246 * database/config.json:
1247 * public/admin/reprocess-report.php:
1248 * public/api/report.php:
1249 * public/api/runs.php:
1250 * public/include/json-header.php:
1252 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1254 Commit yet another forgotten change.
1256 Something went horribly wrong with my merge :(
1258 * database/init-database.sql:
1260 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1262 Commit one more forgotten change. Sorry for making a mess here.
1264 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1266 Commit the forgotten files.
1268 * public/admin/platforms.php: Added.
1269 * tests/admin-platforms.js: Added.
1271 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1273 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
1275 Reviewed by Stephanie Lewis.
1277 Added /admin/platforms/ page to hide and merge platforms.
1279 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
1280 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
1281 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
1282 each test configuration a distinct "test run" for each build.
1284 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
1285 their test configurations into platform B.
1287 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
1288 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
1289 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
1290 in platform B, in which case R should relate to T_B instead.
1292 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
1293 new platform. We then migrate the test configurations of the remaining test runs.
1295 * database/init-database.sql: Added platform_hidden.
1297 * public/admin/platforms.php: Added.
1298 (merge_platforms): Added. Implements the algorithm described above.
1299 (merge_list): Added.
1301 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
1302 is hidden since it doesn't do anything.
1304 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
1305 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
1306 missing it since unchecked checkbox doesn't set the value in $_POST.
1307 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
1308 switch statement instead of repeated if's.
1309 (AdministrativePage::render_table): Emit "update-column" for update_field.
1311 * public/include/db.php: Disable warnings when we're not in the debug mode.
1313 * public/include/manifest.php:
1314 (ManifestGenerator::platforms): Skip platforms that have been hidden.
1317 (TestEnvironment.postJSON):
1318 (TestEnvironment.httpGet):
1319 (TestEnvironment.httpPost): Added.
1320 (sendHttpRequest): Set the content type if specified.
1322 * tests/admin-platforms.js: Added tests.
1324 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
1326 Extract the code to compute full test names from tests.php.
1328 Reviewed by Stephanie Lewis.
1330 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
1331 and paves our way to re-use the code in other pages.
1333 * public/admin/tests.php:
1335 * public/include/db.php:
1336 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
1337 tests.php and test-name-resolver.php.
1339 * public/include/test-name-resolver.php: Added.
1340 (TestNameResolver::__construct):
1341 (TestNameResolver::compute_full_name): Moved from tests.php.
1342 (TestNameResolver::map_metrics_to_tests): Ditto.
1343 (TestNameResolver::sort_tests_by_full_name): Ditto.
1344 (TestNameResolver::tests): Added.
1345 (TestNameResolver::test_id_for_full_name): Ditto.
1346 (TestNameResolver::metrics_for_test_id): Ditto.
1347 (TestNameResolver::child_metrics_for_test_id): Ditto.
1348 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
1350 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
1352 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
1354 Reviewed by Stephanie Lewis.
1356 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
1358 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
1359 but that's sufficient to correct the wrongfully processed reports for now.
1361 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
1362 We should eventually add a nice UI to find and reprocess reports.
1364 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
1366 * public/include/db.php: Added the forgotten call to prefixed_column_names.
1368 * public/include/report-processor.php: Copied from public/api/report.php.
1369 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
1370 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
1371 create a new report or authenticate the builder password (the password is never stored in the report).
1372 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
1373 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
1374 (ReportProcessor::store_report): Ditto.
1376 * tests/admin-reprocess-report.js: Added.
1378 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
1380 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
1382 Reviewed by Ricky Mondello.
1384 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
1385 for the same build number as a single build by ignoring build time. This was necessary to associate
1386 multiple reports by a single build - e.g. for different performance test suites - because the scripts
1387 we use to submit results computed its own "build time" when they're called.
1389 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
1390 last week; new reports were wrongfully associated with old build numbers.
1392 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
1393 to the same build. Instead, we create a new build object for those reports. Since the longest set of
1394 tests we have only take a couple of hours to run, 24 hours should be more than enough.
1396 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
1397 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
1398 (builder, build number, build time).
1400 * public/api/report.php:
1401 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
1402 when no such build exists. This prevents a report from being associated with a very old build of the same
1405 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
1406 a similar bug in the future sooner.
1408 * tests/api-report.js: Added three test cases.
1410 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
1412 Merged the upstream changes to db.php
1413 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
1415 * public/include/db.php:
1417 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
1419 Update other scripts and tests per previous patch.
1421 * public/include/manifest.php:
1422 * tests/admin-regenerate-manifest.js:
1424 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
1426 Remove metrics_unit.
1428 Reviewed by Ricky Mondello.
1430 This column is no longer used by the front-end code since r48360.
1432 * database/init-database.sql:
1433 * public/admin/tests.php:
1435 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
1437 Unreviewed build fix.
1439 * public/api/report.php:
1441 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
1443 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
1445 Reviewed by Ricky Mondello.
1447 Support a new alternative format for aggregated results where we have raw values as well as
1448 the list aggregators so that instead of
1449 "metrics": {"Time": ["Arithmetic"]}
1451 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
1453 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
1454 dashboard and the generated results page, which doesn't know how to aggregate values.
1456 We need to keep the support for the old format because all other existing performance tests
1457 all rely on the old format. Even if we updated the tests, we need the dashboard to support
1458 the old format during the transition.
1460 * public/api/report.php:
1461 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
1462 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
1464 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
1466 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
1468 Unreviewed; Tweak the CSS so that chart panes align vertically.
1470 * public/index.html:
1472 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
1474 SafariPerfMonitor should support Combined metric.
1476 * public/js/helper-classes.js:
1477 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
1478 value as well but assume it to be greater-is-better for now.
1480 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
1482 Commit the forgotten init-database change to add iteration_relative_time.
1484 * database/init-database.sql:
1486 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
1488 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
1490 Reviewed by Ricky Mondello.
1492 Add the support for each value to have a relative time. This is necessary for frame rate history
1493 since a frame rate needs to be associated with a time it was sampled.
1495 * database/init-database.sql: Added iteration_relative_time to run_iterations.
1497 * public/api/report.php:
1498 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
1499 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
1500 with relative time since taking the average of two frame rates for two subtests taken at two
1501 different times doesn't make any sense.
1502 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
1503 etc..., use the second element since we assume values are of the form (relative time, frame rate).
1504 Also exit early with an error if the number of elements in the array is not a pair.
1505 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
1507 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
1508 iteration_relative_time.
1510 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
1512 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
1514 Reviewed by Ricky Mondello.
1516 Support that. It's one line change.
1518 * public/api/report.php:
1519 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
1520 to match the convention assumed elsewhere.
1521 * tests/api-report.js: Added a test case.
1523 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1525 SafariPerfMonitor shows popups for points outside of the visible region.
1527 Rubber-stamped by Simon Fraser.
1529 * public/index.html:
1530 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
1531 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
1532 may return an item underneath y-axis labels.
1534 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1536 Tweak the CSS a little to avoid the test name overlapping with the summary table.
1538 * public/index.html:
1540 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1542 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
1544 * public/index.html:
1546 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1548 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
1549 <rdar://problem/13992271> Should scale Y axis to include error ranges
1551 Reviewed by Ricky Mondello.
1553 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
1554 the main graph doesn't go outside the graph even when the y-axis is adjusted.
1556 * database/config.json:
1557 * public/index.html:
1558 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
1559 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
1560 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
1562 * public/js/helper-classes.js:
1563 (PerfTestResult.confidenceIntervalDelta):
1564 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
1565 (PerfTestRuns.min): Take confidence interval delta into account.
1566 (PerfTestRuns.max): Ditto.
1567 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
1569 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1571 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
1573 * public/api/report.php:
1574 (ReportProcessor::recursively_ensure_tests):
1575 * tests/api-report.js: Added a test.
1577 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1579 Unreviewed build fixes.
1581 * public/api/report.php:
1582 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
1583 Also, tolerate reports without any revision information.
1585 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
1588 * tests/api-report.js: Added few test cases.
1590 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1592 Commit another change that was supposed to be committed in r50331.
1595 (TestEnvironment.this.postJSON):
1596 (TestEnvironment.this.httpGet):
1599 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
1601 Commit the remaining files.
1603 * public/admin/regenerate-manifest.php:
1604 * public/include/admin-header.php:
1605 * public/include/json-header.php:
1606 * public/include/manifest.php:
1608 (TestEnvironment.this.postJSON):
1609 (TestEnvironment.this.httpGet):
1612 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
1614 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
1616 Reviewed by Ricky Mondello.
1618 Added some tests for admin/regenerate-manifest.
1620 * public/admin/regenerate-manifest.php: Use require_once instead of require.
1621 * public/include/admin-header.php: Ditto.
1622 * public/include/json-header.php: Ditto.
1624 * public/include/manifest.php:
1625 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
1626 When there are no builders, simply return an empty array.
1629 (TestEnvironment.postJSON):
1630 (TestEnvironment.httpGet): Added.
1631 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
1633 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
1635 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
1637 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
1638 and run_iterations. Also fixed a typo in report.php found by new tests.
1640 * public/api/report.php:
1641 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
1642 * tests/api-report.js: Added more test cases.
1644 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
1646 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
1648 Reviewed by Ricky Mondello.
1650 Add a test runner script and some simple test cases.
1652 * database/config.json: Added the configuration for "testServer".
1653 * database/database-common.js:
1654 (pathToTests): Added.
1655 * run-tests.js: Added.
1658 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
1659 and if there are, asks the user if it’s okay to delete all of the data contained therein.
1660 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
1662 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
1663 in the current database using PostgreSQL's information_schema.
1664 (askYesOrNoQuestion):
1666 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
1668 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
1669 (TestEnvironment.assert): Exposes assert to tests.
1670 (TestEnvironment.console): Exposes console to tests.
1671 (TestEnvironment.describe): Adds a description.
1672 (TestEnvironment.it): Adds a test case.
1673 (TestEnvironment.postJSON):
1674 (TestEnvironment.queryAndFetchAll):
1675 (TestEnvironment.sha256):
1676 (TestEnvironment.notifyDone): Ends the current test case.
1680 (TestContext): An object created for each test case. Conceptually, this object is always on
1681 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
1682 this object via currentTestContext.
1683 (TestContext.description):
1685 (TestContext.logError):
1688 * tests/api-report.js: Added some basic tests for /api/report.php.
1690 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1692 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
1694 The problem was that we were detecting whether we're updating dashboard or not by checking
1695 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
1696 all configurations. Use separate 'dashboard' action to execute the code even when
1697 metric_configurations is empty.
1699 * public/admin/tests.php:
1701 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1703 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
1705 Reviewed by Ricky Mondello.
1707 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
1708 from ReportProcessor as a preparation to replace deprecated aggregate.js.
1710 * public/api/report.php:
1711 (ReportProcessor::exit_with_error): Moved.
1712 (ReportProcessor::process): Use the extracted TestRunsGenerator.
1713 (TestRunsGenerator): Added.
1714 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
1715 (TestRunsGenerator::add_aggregated_metric): Moved.
1716 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
1717 (TestRunsGenerator::aggregate): Moved. Made public.
1718 (TestRunsGenerator::aggregate_current_test_level): Moved.
1719 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
1720 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
1721 (TestRunsGenerator::compute_caches): Moved. Made public.
1722 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
1723 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
1724 (TestRunsGenerator::rollback_with_error): Moved.
1726 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1728 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
1730 Reviewed by Remy Demarest.
1732 Regenerate the manifest file when updating fields or adding new items that are included in
1735 * public/admin/bug-trackers.php:
1736 * public/admin/builders.php:
1737 * public/admin/regenerate-manifest.php:
1738 * public/admin/repositories.php:
1739 * public/admin/tests.php:
1740 * public/include/admin-header.php:
1741 (regenerate_manifest): Extracted from regenerate-manifest.php.
1743 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1745 Unreviewed build fix for memory test results.
1747 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
1748 aggregating at each level.
1750 * public/api/report.php:
1751 (ReportProcessor::recursively_ensure_tests):
1752 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
1753 (ReportProcessor::add_values_for_aggregation):
1754 (ReportProcessor::aggregate):
1755 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
1757 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
1759 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
1760 not the number of iteration groups. Also, don't set group number when the entire run belongs
1761 a single iteration group.
1763 * public/api/report.php:
1764 (ReportProcessor::commit):
1766 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1768 SafariPerfMonitor: Introduce iteration groups
1770 Reviewed by Remy Demarest.
1772 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
1773 the runtime environment variances to get more stable results. And it's desirable to keep track of
1774 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
1776 This patch introduces "iteration groups" to keep track of this extra information.
1778 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
1779 the outer array denotes iteration groups and each inner array contains iteration values for each group.
1782 * database/init-database.sql: Add iteration_group column.
1783 * public/api/report.php:
1784 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
1786 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
1787 contains the list of values indexed by the iteration order and group sizes. Store the group size so
1788 that we can restore the iteration groups before passing it to node.js and restore them later.
1790 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
1791 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
1793 Also check that each iteration group in each subtest are consistent with one another. To see why we need
1794 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
1795 that each iteration group in T1 and T2 have the same size:
1796 T1 = [[1, 2], [3, 4, 5]]
1797 T2 = [[6, 7], [8, 9, 10]]
1799 so that the aggregated result (the sum in this case) can have the same groups as in:
1800 T = [[7, 9], [11, 13, 15]]
1802 If some iteration groups in T1 and T2 had a different size as in:
1803 T1 = [[1, 2, 3], [4, 5]]
1804 T2 = [[6, 7], [8, 9, 10]]
1806 Then iteration groups of the aggregated T is ambiguous.
1808 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
1809 (ReportProcessor::commit): Store iteration_group values.
1811 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1813 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
1814 migrated to perf.webkit.org.
1816 * database/perf-webkit-migrator.js: Removed.
1818 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1820 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
1822 * public/index.html:
1825 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1827 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
1829 Reviewed by Ricky Mondello.
1831 It is often desirable to see charts of a given test for all platforms, or to be able to see
1832 charts of all subtests on a given platform when trying to triage perf. regressions.
1834 Support this use case by adding the ability to do so on the charts page.
1836 Also, we used to disable items on the test list based on the platform chosen. This turned out
1837 to be a bad UI because in many situations you want to be able to compare results of the same test
1838 on multiple platforms.
1840 In this new UI, we have three select elements, each of which selects the following:
1841 1. Top-level test - Test suite such as Dromaeo
1842 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
1843 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
1844 3. Platform - Mountain Lion, Qt, etc...
1846 A user can select "all" for metric and platform but we disallow doing both at once since adding
1847 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
1848 think of a use case where you want to look at that many charts at once. We can support this later
1849 if valid use cases come up.
1851 * public/index.html:
1852 (.showCharts.addOption): Extracted.
1853 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
1854 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
1855 metricList has onchange handler that enables/disables items on platformList.
1857 (init): Sort tests and test metrics here instead of doing that in showCharts.
1859 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
1861 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
1863 Reviewed by Remy Demarest and Ricky Mondello.
1865 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
1866 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
1867 templates to the manifest file instead. Each build now only contains the builder id.
1869 * public/api/runs.php: Removed the part of the query that joined builders table. This
1870 speeds up the query quite a bit.
1872 * public/include/manifest.php:
1873 (ManifestGenerator::generate): Generate builders field.
1874 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
1875 associative array that contains name and its build URL template.
1877 * public/index.html:
1878 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
1879 instead of a revision since this function is used for revisions and build page URLs now.
1880 (.buildLabelWithLinks): Include the linkified build number.
1882 * public/js/helper-classes.js:
1883 (TestBuild.builder): Added.
1884 (TestBuild.buildNumber): Added.
1885 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
1886 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
1888 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
1890 Tooltips interfere with user interactions
1892 Rubber-stamped by Simon Fraser.
1894 Disable tooltip on the dashboard page since graphs are too small to be useful there.
1895 Also, show graphs for only 10 days by default as opposed to 20.
1896 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
1898 * public/index.html:
1899 * public/js/helper-classes.js:
1901 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
1903 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
1904 to be compatible with webkit-perf.appspot.com.
1906 * public/admin/builders.php:
1907 * public/api/report.php:
1909 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
1913 Add a missing constraint on builds table. For a given builder, there should be exactly
1914 one build for a given build number.
1916 Also add report_committed_at to reports table to record the time at which a given report
1917 was processed and test_runs and run_iterations rows were committed into the database.
1919 * database/config.json:
1920 * public/api/report.php:
1922 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
1924 Unreviewed. Add more checks for empty SQL query results.
1926 * public/include/manifest.php:
1928 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1930 More build fixes on perf.webkit.org.
1932 * public/api/runs.php: Make PostgreSQL happier.
1933 * public/include/manifest.php: Don't assume we always have bug trackers.
1935 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1937 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
1938 and fix other miscellaneous UI bugs.
1940 Rubber-stamped by Simon Fraser.
1942 Removed the code to determine whether smaller value is better or not for a given test in index.html
1943 in the favor of using that of PerfTestRuns.
1945 * public/include/manifest.php: Fixed a typo.
1946 * public/index.html:
1948 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
1950 * public/js/helper-classes.js:
1951 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
1953 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
1954 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
1955 at roughly 2,000 units to avoid this.
1957 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
1958 The only thing we can avoid is innerHTML.
1960 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1962 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
1964 * public/include/evaluator.js:
1966 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1968 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
1970 Reviewed by Remy Demarest.
1972 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
1973 admin/bug-trackers.php and can be associated with multiple repositories.
1975 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
1976 to determine the set of bug trackers to show for a given set of blame lists.
1977 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
1978 a place to file bugs against the regression.
1980 * database/init-database.sql: Added bug_trackers and tracker_repositories.
1981 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
1983 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
1984 bug trackers, namely associated repositories.
1986 * public/include/admin-header.php: Added a link to bug-trackers.php
1987 * public/include/manifest.php:
1988 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
1989 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
1991 (ManifestGenerator::repositories):
1993 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
1994 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
1995 'repositories' where the latter contains the list of associated repository names.
1997 * public/index.html:
1998 (Chart): Takes bugTrackers as as argument.
1999 (Chart.showTooltipWithResults): Removed the hard-coded list.
2001 (init.addPlatformsToDashboard):
2002 (init.showCharts.createChartFromListPair):
2003 (init): Stores the list of bug trackers in the manifest to a local variable.
2005 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2007 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
2009 * public/include/evaluator.js:
2011 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2013 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
2015 Reviewed by Remy Demarest.
2017 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
2018 new row into the database.
2020 * public/admin/aggregators.php: Use AdministrativePage.
2021 * public/admin/builders.php: Ditto.
2022 * public/admin/repositories.php: Ditto.
2023 * public/include/admin-header.php:
2024 (AdministrativePage): Added.
2025 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
2026 to an associative array that describes the column.
2027 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
2028 - label: Human readable name of the column.
2029 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
2030 column exists only before we create password_hash column at the insertion time.
2032 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
2033 titlecase (e.g. new_bug is converted to New Bug).
2034 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
2035 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
2036 textarea for a given editing mode ('text', 'url', or 'string').
2037 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
2038 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
2040 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
2042 Build fix. Some systems don't support r+. Use proc_open instead.
2044 * public/api/report.php:
2046 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
2048 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
2049 when computing the y-axis of data points to show tooltips at.
2051 * public/index.html:
2053 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
2055 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
2058 * public/.htaccess: Removed.
2060 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
2064 * public/include/manifest.php: Build fix. db is on this.
2065 * public/js/statistics.js:
2066 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
2068 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
2070 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
2072 Reviewed by Anders Carlsson.
2074 Rewrote and merged populate-from-report.js into report.php.
2076 * database/config.json: Added a path to node.js.
2078 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
2079 Once we land this patch and update the administrative pages, we can remove this column.
2081 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
2082 that table is going away once we remove the node.js backend.
2084 * database/populate-from-report.js: Removed.
2085 * public/api/report.php: Added.
2087 (ReportProcessor.__construct):
2088 (ReportProcessor.process):
2090 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
2091 verified to be submitted by a known builder.
2093 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
2094 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
2095 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
2096 inside a transaction because there could be multiple reports for a single build, each containing results for
2099 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
2100 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
2101 add_values_to_commit, and add_values_for_aggregation.
2103 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
2104 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
2105 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
2108 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
2109 to be aggregated in ReportProcessor.aggregate.
2111 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
2113 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
2114 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
2115 given for each row (child metrics of M). This function extracts each column (iteration) via
2116 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
2117 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
2119 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
2120 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
2121 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
2123 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
2124 (ReportProcessor.evaluate_expressions_by_node): See above.
2126 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
2127 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
2128 results also need the said caches.
2130 (ReportProcessor.add_values_to_commit):
2132 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
2133 the transaction as needed if anything goes wrong.
2135 (ReportProcessor.rollback_with_error)
2137 * public/include/db.php:
2138 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
2139 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
2140 contiguously in a SQL statement.
2142 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
2143 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
2144 a column value of the choice.
2146 (Database.begin_transaction): Added.
2147 (Database.commit_transaction): Added.
2148 (Database.rollback_transaction): Added.
2150 * public/include/evaluator.js: Added.
2151 * public/include/json-header.php:
2152 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
2153 context under which the request failed.
2154 (successful_exit): Merge "additional details".
2155 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
2156 (merge_additional_details):
2158 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
2160 SafariPerfMonitor: Add more helper functions to db.php
2162 Reviewed by Remy Demarest.
2164 Added Database::insert_row and array_get to make common database operations easier.
2166 * public/admin/aggregators.php: Use Database::insert_row instead of
2167 execute_query_and_expect_one_row_to_be_affected.
2169 * public/admin/builders.php: Ditto.
2171 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
2172 inserting a row. With insert_row, we don't need that.
2174 * public/include/admin-header.php: Ditto.
2176 * public/include/db.php:
2177 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
2178 return the default value (defaults to NULL) if the key doesn't exist.
2180 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
2183 (Database::prepare_params): Added. Takes an associative array of column names and their values,
2184 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
2185 column names all in the same order.
2187 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
2188 the given prefix. Values are given in a form of an associative array where keys are unprefixed
2189 column names and values are corresponding values. When the row is successfully inserted, it returns
2190 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
2191 indicating the success of the insertion.
2193 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
2195 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
2197 Reviewed by Conrad Shultz.
2199 Rewrote the manifest generator in PHP.
2201 * database/generate-manifest.js: Removed.
2202 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
2203 * public/include/db.php:
2204 (array_ensure_item_has_array): Added.
2205 * public/include/evaluator.js: Added.
2206 * public/include/json-header.php:
2207 * public/include/manifest.php: Added.
2209 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
2211 Dates on overflow plot are overlapping
2213 Rubber-stamped by Simon Fraser.
2215 Don't show more than 5 days.
2217 * public/index.html:
2218 * public/js/helper-classes.js:
2219 (TestBuild.UTCtoPST):
2222 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
2224 Show build time as well as commit time on the dashboard and tooltips.
2226 Rubber-stamped by Simon Fraser.
2228 Include both the maximum commit time and build time in buildLabelWithLinks.
2229 Also use ISO format to save the screen real estate.
2231 * public/index.html:
2232 (buildLabelWithLinks):
2233 * public/js/helper-classes.js:
2235 (TestBuild.buildTime):
2236 (TestBuild.formattedBuildTime):
2238 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
2240 Unreviewed; Convert metric.name to metric.unit in the front end.
2242 * public/js/helper-classes.js:
2244 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
2246 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
2248 Rubber-stamped by Simon Fraser.
2250 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
2251 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
2252 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
2254 * public/index.html:
2255 (.buildLabelWithLinks): Extracted from TestBuild.label.
2256 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
2257 on Radar and WebKit Bugzilla.
2258 * public/js/helper-classes.js:
2259 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
2260 (PerfTestResult.isBetterThan): Added.
2261 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
2262 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
2263 to indicate progressions or regressions.
2264 (PerfTestResult.label):
2265 (TestBuild.formattedTime): Added.
2266 (TestBuild.platform): Added.
2267 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
2268 (TestBuild.smallerIsBetter): Added.
2269 (Tooltip.show): Take a raw markup instead of two results.
2271 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
2273 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
2275 Rubber-stamped by Tim Horton.
2277 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
2278 since each platform may have a different number of tests to be shown on the dashboard.
2280 * public/index.html:
2282 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
2284 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
2286 * public/js/helper-classes.js:
2289 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
2291 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
2293 Rubber-stamped by Tim Horton.
2295 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
2297 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
2298 the revision r1234 was the revision used in the previous build.
2300 * public/api/runs.php:
2301 (parse_revisions_array): Trim double quotations around repository names and revisions.
2302 * public/js/helper-classes.js:
2305 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
2307 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
2309 Rubber-stamped by Tim Horton.
2311 * public/index.html:
2312 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
2313 on the dashboard page as it's way too noisy.
2315 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
2317 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
2318 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
2319 so that the tooltip for hover can be reused further.
2321 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
2322 and find the first point that lies on the right of the cursor position. We then compute the midpoint
2323 between this and the previous point and pick the closer of the two. It returns an item-like object
2324 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
2326 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
2328 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
2329 the first or "current" data points (as opposed to target or baseline data points).
2331 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
2332 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
2333 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
2335 * public/js/helper-classes.js:
2336 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this
2337 work to the client via bindClick.
2339 (Tooltip.show): Move tooltip up by 5px. Also added a FIXME to move this offset computation to the client.
2341 (Tooltip.bindClick): Added.
2343 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
2345 Yet another build fix. metricId*s*.
2347 * public/admin/tests.php:
2349 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
2351 Another build fix. Use the new payload format for the aggregate job.
2353 * public/admin/tests.php:
2355 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
2359 * database/aggregate.js: Use variables that actually exist.
2360 * database/database-common.js:
2361 (ensureConfigurationIdFromList): Add the newly added configuration to the list so that subsequent
2362 function calls will find this configuration.
2364 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
2366 <rdar://problem/13130139> SafariPerfMonitor: Add ReadMe
2368 Reviewed by Ricky Mondello.
2370 Turned InstallManual into a proper markdown document and added ReadMe.md.
2372 * InstallManual: Removed.
2373 * InstallManual.md: Moved from InstallManual.
2376 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
2378 <rdar://problem/13109335> SafariPerfMonitor: Add baseline and target lines
2380 Reviewed by Ricky Mondello.
2382 This patch prepares the front end code to process baseline and target results properly.
2384 * public/index.html:
2385 (fetchTest.createRunAndResults): Extracted.
2386 (fetchTest): Call createRunAndResults on current, baseline, and target values of the JSON.
2387 Deleted the comment about how sorting will be unnecessary once we start results in the server side
2388 since sorting by the maximum revision commit time turned out to be non-trivial in php.
2390 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
2392 <rdar://problem/13057071> SafariPerfMonitor: Use newer version of flot that supports timezone properly
2394 Reviewed by Tim Horton.
2396 Use flot at https://github.com/flot/flot/commit/ec168da2cb8619ebf59c7e721d12c44a7960ff41.
2397 These files are "dynamically linked" to our app.
2399 * public/index.html:
2400 * public/js/jquery-1.8.2.min.js: Removed.
2401 * public/js/jquery.colorhelpers.js: Added.
2402 * public/js/jquery.flot.categories.js: Added.
2403 * public/js/jquery.flot.crosshair.js: Added.
2404 * public/js/jquery.flot.errorbars.js: Added.
2405 * public/js/jquery.flot.fillbetween.js: Added.
2406 * public/js/jquery.flot.js: Added.
2407 * public/js/jquery.flot.min.js: Removed.
2408 * public/js/jquery.flot.navigate.js: Added.
2409 * public/js/jquery.flot.resize.js: Added.
2410 * public/js/jquery.flot.selection.js: Added.
2411 * public/js/jquery.flot.stack.js: Added.
2412 * public/js/jquery.flot.symbol.js: Added.
2413 * public/js/jquery.flot.threshold.js: Added.
2414 * public/js/jquery.flot.time.js: Added.
2415 * public/js/jquery.js: Added.
2417 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
2419 Return NaN instead of throwing when there aren't enough samples.
2421 Reviewed by Sam Weinig.
2423 It's better to return NaN when we don't have enough samples so that we can treat it
2424 as if we don't have any confidence interval.
2426 * public/js/statistics.js:
2429 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
2431 Build fix. Apparently Safari sometimes appends / at the end of hash location. Remove that.
2433 * public/js/helper-classes.js:
2434 (URLState.parseIfNeeded):
2436 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
2438 <rdar://problem/13081582> SafariPerfMonitor: Always use parameterized SQL functions in php code
2440 Reviewed by Ricky Mondello.
2442 Parameterized execute_query_and_expect_one_row_to_be_affected and updated the code accordingly.
2444 * public/admin/aggregators.php: Use heredoc.
2445 * public/admin/builders.php:
2446 * public/admin/jobs.php:
2447 * public/admin/repositories.php:
2448 * public/admin/tests.php: Updated the forms to use unprefixed field names to match other pages.
2449 This allows us to use update_field when updating test's url and metric's unit. Changed the action
2450 to regenerate aggregated matrix from "update" to "add" to simplify the dependencies in if-else.
2451 Also removed a stray code to update unit and url simultaneously since it's never used.
2452 * public/include/admin-header.php:
2453 (execute_query_and_expect_one_row_to_be_affected): Added $params. Also automatically convert
2454 empty strings to NULL as it was previously done via $db->quote_string_or_null_if_empty in callers.
2455 (update_field): Moved from repositories.php.
2457 * public/include/db.php:
2458 (quote_string_or_null_if_empty): Removed now that nobody uses this function.
2460 2013-01-25 Ryosuke Niwa <rniwa@webkit.org>
2462 Build fixes. Treat mean, sum, and square sum as float, not int.
2464 Also use 95% confidence interval instead of 90% confidence interval.
2466 * public/api/runs.php:
2467 * public/js/helper-classes.js:
2468 (.this.confidenceIntervalDelta):
2470 2013-01-24 Ryosuke Niwa <rniwa@webkit.org>
2472 Add an administrative page to edit repository information.
2474 Reviewed by Ricky Mondello.
2476 * public/admin/repositories.php: Added.
2477 * public/include/admin-header.php:
2479 2013-01-23 Ryosuke Niwa <rniwa@webkit.org>
2481 <rdar://problem/13067539> SafariPerfMonitor: Automatically create aggregated metrics from builder reports
2483 Reviewed by Ricky Mondello.
2485 Auto-create aggregated matrix such as arithmetic means and geometric means as requested and add a job
2486 to aggregate results for those matrix in populate-from-report.js.
2488 * database/generate-manifest.js:
2489 (.): Include aggregator names such as Arithmetic and Geometric in the list of metrics.
2490 * database/init-database.sql: Remove an erroneous unique constraint. There could be multiple matrix that share
2491 the same test and name (e.g. Dromaeo, Time) with different aggregators (e.g. Arithmetic and Geometric).
2492 * database/populate-from-report.js:
2494 (getReport): No change even though the diff looks as if it moved.
2495 (processReport): Extracted from main. Fetch the list of aggregators, pass that to recursivelyEnsureTestsIdsAndMetricsIds
2496 to obtain the list of aggregated metrics (such as arithmetic means) that need to be passed to aggregate.js
2497 (scheduleJobs): Extracted from processReport. Add a job to aggregate results.
2498 (recursivelyEnsureTestsIdsAndMetricsIds): When a metric is a list of names, assume them as aggregator names,
2499 and add corresponding metrics for them. Note we convert those names to ids using the dictionary we obtained
2501 (ensureMetricId): Take an aggregator id as an argument.
2502 * database/process-jobs.js: Support multiple metric ids and build id. Note that aggregate.js aggregates results
2503 for all builds when the build id is not specified.
2504 * public/admin/tests.php:
2505 * public/index.html: Include the aggregator name in the full name since there could be multiple metrics
2506 of the same name with different aggregators.
2508 2013-01-22 Ryosuke Niwa <rniwa@webkit.org>
2510 Build fix. Don't pass in arguments to in the wrong order.
2512 * database/aggregate.js:
2514 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
2516 <rdar://problem/13057110> SafariPerfMonitor: x-axis is messed up
2518 Reviewed by Ricky Mondello.
2520 Since the version of flot we use doesn't support showing graphs in the current locate or
2521 in a specific timezone, convert all timestamps to PST manually (Date's constructor will still
2522 treat them as in UTC). We don't want to use the current locate because other websites on
2523 webkit.org assume PST.
2525 Also append this information to build's label.
2527 * public/js/helper-classes.js:
2531 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
2533 Store test URLs reported by builders.
2535 Reviewed by Ricky Mondello.
2537 * database/populate-from-report.js:
2538 (recursivelyEnsureTestsIdsAndMetricsIds): Pass in the test url.
2539 (ensureTestId): Store the URL.
2541 2013-01-20 Ryosuke Niwa <rniwa@webkit.org>
2543 Yet another build fix; don't blow up even if we didn't have any test configurations.
2545 * public/admin/tests.php:
2547 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
2549 Build fix; don't instantiate Date when a timestamp wasn't provided.
2551 * database/populate-from-report.js:
2553 2013-01-18 Ryosuke Niwa <rniwa@webkit.org>
2555 Rename SafariPerfDashboard to SafariPerfMonitor and add a install manual.
2557 Reviewed by Tim Horton.
2559 Added an install manual.
2561 * InstallManual: Added.
2563 2012-12-21 Ryosuke Niwa <rniwa@webkit.org>
2565 Minor build fix. Don't unset builderPassword when it's not set.
2567 * public/api/report.php:
2569 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2571 Prettify JSON payloads and make very large payloads not explode the table in jobs.php.
2573 Reviewed by Ricky Mondello.
2575 * public/admin/admin.css: Make a very large payload scrollable.
2576 * public/admin/jobs.php: Format JSONs.
2578 2012-12-19 Ryosuke Niwa <rniwa@webkit.org>
2580 <rdar://problem/12897424> SafariPerfMonitor: Add ability to report results from bots
2582 Reviewed by Ricky Mondello.
2584 Add report.php and populate-from-report.js that process JSON files submitted by builders.
2586 * database/populate-from-report.js: Added.
2588 (getReport): Obtains the payload (the actual report) from "jobs" table.
2589 (recursivelyEnsureTestsIdsAndMetricsIds): "reports.tests" contain a tree of tests, test metrics,
2590 and their results. This function recursively traverses tests and metrics and ensure their ids.
2592 (metricToUnit): Maps a metric name to a unit. This should really be done in the client side since
2593 there is no point in storing unit given that every metric maps to exactly one unit (i.e. the mapping
2594 is a "function" in mathematical sense).
2596 (ensureRepositoryIdsForAllRevisions):
2597 (getIdOrCreateBuildWithRevisions):
2598 (ensureBuildIdAndRevisions): Obtains a build id given a builder name, a build number, and a build time
2599 if one already exists. If not, then inserts a new build and corresponding revisions information (e.g.
2600 build 123 may contain WebKit revision r456789). We don't retrieve rows for revisions since we don't use
2602 (insertRun): Insert new rows into "test_runs" and "run_iterations" tables, thereby recording the new
2603 test results all in a single transaction. This allows us to keep the database consistent in that either
2604 a build has been reported or not at least in "test_runs" and "run_iterations" tables. It'll be ideal if
2605 we could do the same for "builds" and "build_revisions" but that's not a hard requirement as far as
2606 other parts of the application are concerned.
2607 (scheduleQueriesToInsertRun):
2608 * database/process-jobs.js: Add a call to populate-from-report.js.
2609 * public/api/report.php: Added. Adds a new job named "report" to be processed by populate-from-report.js.
2610 * public/include/db.php: Support parameterized query.
2611 * public/include/json-header.php: Always include 'status' in the response so that builder submitting
2612 a test result could confirm that the submission indeed succeeded.
2614 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2616 Rename get(Id)OrCreate*(Id) to ensure*Id as suggested by Ricky on one of his code reviews.
2618 * database/aggregate.js:
2619 * database/database-common.js:
2620 (selectColumnCreatingRowIfNeeded):
2621 (ensureRepositoryId):
2622 (ensureConfigurationIdFromList):
2623 * database/perf-webkit-migrator.js:
2626 (getOrCreateBuildId):
2628 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
2630 Extract commonly-used functions from aggregate.js and perf-webkit-migrator.js.
2632 Reviewed by Ricky Mondello.
2634 As a preparation to add report.js that processes a JSON file submitted by bots, extract various functions
2635 and classes from aggregate.js and perf-webkit-migrator.js to be shared.
2637 * database/aggregate.js: Extracted TaskQueue and SerializedTaskQueue into utility.js.
2640 (saveAggregatedResults):
2641 * database/database-common.js:
2642 (getIdOrCreatePlatform): Extracted from webkit-perf-migrator.js.
2643 (getIdOrCreateRepository): Ditto.
2644 (getConfigurationsForPlatformAndMetrics): Renamed from fetchConfigurations. Extracted from aggregator.js.
2645 (getIdFromListOrInsertConfiguration): Renamed from getOrInsertConfiguration. Extracted from aggregator.js.
2646 * database/perf-webkit-migrator.js:
2647 * database/utility.js: Added.
2648 (TaskQueue): Extracted from aggregator.js. Fixed a bug that prevented tasks added after start() is called
2649 from being executed.
2650 (TaskQueue.startTasksInQueue): Execute remaining tasks without serializing them. If the queue is empty,
2651 call the callback passed into start().
2652 (TaskQueue.taskCallback): The function each task calls back. Decrement the counter and call statTasksInQueue.
2653 (TaskQueue.addTask):
2655 (SerializedTaskQueue): Unlike TaskQueue, this class executes each task sequentially.
2656 (SerializedTaskQueue.executeNextTask):
2657 (SerializedTaskQueue.addTask):
2658 (SerializedTaskQueue.start):
2660 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2662 Revert erroneously committed changes.
2664 * database/config.json:
2666 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2668 aggregator.js should be able to accept multiple metric ids and a single build id.
2670 Reviewed by Ricky Mondello.
2672 Make aggregator.js accept multiple ids and generate results for single build when bots are
2673 reporting new results.
2675 * database/aggregate.js:
2676 (parseArgv): Added. Returns an object containing the parsed representation of argv,
2677 which currently contains metricIDs and buildIds.
2678 (main): Use parseArgv and processConfigurations
2679 (processPlatform): Use build ids passed in or obtain all builds for the given platform.
2680 (processPlatform.processConfigurations): Extracted.
2682 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
2684 Add an administrative page for builders.
2686 Reviewed by Ricky Mondello.
2688 We need an administrative page to add and edit builder information.
2689 Also renamed "slaves" to "builders" in order to reduce the amount of technical jargon we use.
2691 * database/init-database.sql: Renamed slaves table to builders. Drop slave_os and slave_spec
2692 since we don't have plans to use those columns in near future. Also make builder_name unique
2693 as required by the rest of the app.
2694 * public/admin/builders.php: Added.
2695 * public/api/runs.php: Updated per the table rename.
2696 * public/include/admin-header.php: Added a link to builders.php.
2698 2012-12-14 Ryosuke Niwa <rniwa@webkit.org>
2700 Build fixes for r46982.
2702 * database/aggregate.js:
2703 (fetchConfigurations): Bind i so that it's not always metricIds.length.
2704 (fetchBuildsForPlatform): Return run_build as build_id since that's what caller expects.
2705 (processBuild): Don't print "." until we've committed transactions. It's misleading.
2707 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
2709 Unreviewed. Move some php files to public/include as suggested by Mark on a code review.
2711 * public/admin/aggregators.php:
2712 * public/admin/footer.php: Removed.
2713 * public/admin/header.php: Removed.
2714 * public/admin/index.php:
2715 * public/admin/jobs.php:
2716 * public/admin/tests.php:
2717 * public/api/json-header.php: Removed.
2718 * public/api/runs.php:
2719 * public/db.php: Removed.
2720 * public/include: Added.
2721 * public/include/admin-footer.php: Copied from public/admin/footer.php.
2722 * public/include/admin-header.php: Copied from public/admin/header.php.
2723 * public/include/db.php: Copied from public/db.php.
2724 * public/include/json-header.php: Copied from public/api/json-header.php.
2726 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
2728 <rdar://problem/12822613> SafariPerfMonitor: implement naive value aggregation mechanism
2730 Reviewed by Ricky Mondello.
2732 Added the initial implementation of value aggregation.
2733 Also added abilities to configure the dashboard page in tests.php.
2735 * database/aggregate.js: Added.
2736 (TaskQueue): Added. Execute all tasks at once and waits for those tasks to complete.
2737 (TaskQueue.addTask):
2739 (SerializedTaskQueue): Added. Execute tasks sequentially after one another until all of them are completed.
2740 (SerializedTaskQueue.addTask):
2741 (SerializedTaskQueue.start):
2744 (fetchConfigurations):
2745 (fetchBuildsForPlatform):
2747 (testsWithDifferentIterationCounts):
2748 (aggregateIterationsForMetric): Retrieve run_iterations and aggregate results in memory.
2749 (saveAggregatedResults): Insert into test_runs and test_config in transactions.
2750 (getOrInsertConfiguration):
2752 * database/database-common.js:
2753 (fetchTable): Log an error as an error.
2754 (getOrCreateId): Extracted from perf-webkit-migrator.
2755 (statistics): Added.
2756 * database/perf-webkit-migrator.js:
2757 (migrateTestConfig): Converted units to respective metric names. Also removed the code to add jobs to update
2758 runs JSON since runs JSONs are generated on demand now.
2760 (getOrCreatePlatformId):
2761 (getOrCreateTestId):
2762 (getOrCreateConfigurationId):
2763 (getOrCreateRevisionId):
2764 (getOrCreateRepositoryId):
2765 (getOrCreateBuildId):
2766 * database/process-jobs.js:
2767 (processJob): Handle 'aggregate' type.
2769 2012-12-11 Ryosuke Niwa <rniwa@webkit.org>
2771 Fix the dashboard after adding test_metrics.
2773 Reviewed by Ricky Mondello.
2775 Rename test to metrics in various functions and sort tests on the charts page.
2776 Also representing whether a test appears or not by setting a flag on dashboard
2777 was bogus because test objects are shared by multiple platforms. Instead, store
2778 dashboard platform list as intended by the manifest JSON.
2780 * public/index.html:
2781 (PerfTestRuns): Renamed test to metric.
2783 (showCharts): Ditto; also sort metrics' full names before adding them to the select element.
2784 (fullName): Moved so that it appears above where it's called.
2785 * public/js/helper-classes.js:
2787 2012-12-10 Ryosuke Niwa <rniwa@webkit.org>
2789 Update tests.php to reflect recent changes in the database schema.
2791 Reviewed by Conrad Shultz.
2793 Made the following changes to tests.php:
2794 1. Disallow adding metrics to tests without subtests.
2795 2. Made dashboard configurable by adding checkboxes for each platform on each metric.
2796 3. Linkified tests with subtests instead of showing all them at once.
2798 * public/admin/admin.css:
2799 (.action-field, .notice):
2801 * public/admin/header.php: Specify paths by absolute paths so that tests.php can use PATH_INFO.
2802 (execute_query_and_expect_one_row_to_be_affected): Return a boolean. Used in tests.php while adding test_metrics.
2803 (add_job): Extracted.
2804 * public/admin/tests.php: See above.
2805 (array_item_set_default): Added.
2806 (array_item_or_default): Renamed from get_value_with_default.
2807 (compute_full_name): Extracted.
2808 (sort_tests): Ditto.
2809 (map_metrics_to_tests): Ditto.
2811 2012-12-06 Ryosuke Niwa <rniwa@webkit.org>
2813 <rdar://problem/12832324> SafariPerfMonitor: Linkify test names
2815 Reviewed by Simon Fraser.
2817 Linkify the headers using metric.test.url when it's provided.
2819 * public/index.html:
2821 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2823 Use parameterized pg_query_params in query_and_fetch_all
2825 Reviewed by Conrad Shultz.
2827 Address a review comment by Mark by using pg_query_params instead of pg_query in query_and_fetch_all.
2829 * public/api/runs.php:
2831 (ctype_alnum_underscore): Added.
2833 2012-12-04 Ryosuke Niwa <rniwa@webkit.org>
2835 Update the migration tool to support test_metrics.
2837 Reviewed by Mark Rowe.
2839 Updated the migration tool from webkit-perf.appspot.com to support test_metrics.
2840 Also import run_iteration rows as runs JSON files now include individual values.
2842 * database/database-common.js:
2843 (addJob): Extracted.
2844 * database/perf-webkit-migrator.js:
2845 (migrateTestConfig): Interchange the order in which we fetch runs and add configurations
2846 so that we can pass in the metric name and unit to getOrCreateConfigurationId.
2847 (getOrCreateConfigurationId): Updated to add both test configuration and test metric.
2850 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2852 Build fix. Suppress "Undefined index" warning.
2854 * public/admin/tests.php:
2856 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2858 Fix a commit error in r46756. api/ should obviously be added under public/
2861 * api/json-header.php: Removed.
2862 * api/runs.php: Removed.
2863 * public/api: Copied from api.
2865 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2867 SafariPerfMonitor: Linkify revisions and revisions range
2868 <rdar://problem/12801010>
2870 Reviewed by Mark Rowe.
2872 Linkify revisions in TestBuild.label. Pass in manifest.repositories to TestBuild's constructor
2873 since it needs to know "url" and "blameUrl".
2875 Also tweaked the appearance of graphs on charts page to better align graphs when unit names are long.
2877 * public/index.html:
2878 * public/js/helper-classes.js:
2880 (TestBuild.revision): Renamed from webkitRevision. Now returns an arbitrary revision number.
2881 (TestBuild.label): Add labels for all revisions.
2885 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2887 Make the generation of "runs" JSON dynamic and support test_metrics.
2889 Reviewed by Mark Rowe.
2891 It turned out that we can fetch all runs for a given configuration in roughly 100-200ms.
2893 Since there could be hundreds, if not thousands, of tests for each configuration and users
2894 aren't necessarily interested in looking at all test results, it's much more efficient to
2895 generate runs JSON dynamically (i.e. polling) upon a request instead of generating all of them
2896 when bots report new results (i.e. pushing).
2898 Rewrote the script to generate runs JSON in php and also supported test_metrics table.
2901 * api/json-header.php: Added. Sets Content-Type and cache policies (10 minutes by default).
2902 (exit_with_error): Added.
2903 (successful_exit): Added.
2904 * api/runs.php: Added. Ported database/database-common.js. It's much shorter in php!
2905 * database/generate-runs.js: Removed.
2906 * database/process-jobs.js: No longer supports "runs".
2907 * public/.htaccess: Added. Always add MultiView so that api/runs can receive a path info.
2908 * public/db.php: Print "Nothing to see here." when it's accessed directly.
2910 * public/index.html: Fetch runs JSONs from /api/runs/ instead of data/.
2912 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2914 Update tests.php and sample-data.sql per addition of test_metrics.
2916 Rubber-stamped by Timothy Hatcher.
2918 Remove a useless code from tests.php that used to update the unit and the url of a test
2919 since it's no longer used, and add the UI and the ability to add a new aggregator to a test.
2921 Also update the sample data to reflect the addition of test_metrics.
2923 * database/sample-data.sql:
2924 * public/admin/tests.php:
2926 2012-11-30 Ryosuke Niwa <rniwa@webkit.org>
2928 Share more code between admin pages.
2930 Reviewed by Timothy Hatcher.
2932 Added notice and execute_query_and_expect_one_row_to_be_affected helper functions to share more code
2933 between admin pages.
2935 Also moved the code to connect to the database into header.php to be shared. Admin pages just need
2936 to check the nullity of global $db now.
2938 * public/admin/aggregators.php:
2939 * public/admin/header.php:
2941 (execute_query_and_expect_one_row_to_be_affected): Added.
2942 * public/admin/index.php:
2943 * public/admin/jobs.php:
2944 * public/admin/tests.php:
2946 2012-11-29 Ryosuke Niwa <rniwa@webkit.org>
2948 SafariPerfMonitor: Add admin page to edit aggregators
2949 <rdar://problem/12782687>
2951 Reviewed by Mark Rowe.
2953 Add aggregators.php. It's very simple. We should probably share more code between various admin pages.
2955 * public/admin/aggregators.php: Added.
2956 * public/admin/header.php:
2957 * public/admin/jobs.php: Removed an erroneous hidden input element.
2959 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
2961 Fix a syntax error in init-database.sql and add the missing drop table at the beginning.
2963 * database/init-database.sql:
2965 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
2967 SafariPerfMonitor: Allow multiple metrics per test
2968 <rdar://problem/12773506>
2970 Rubber-stamped by Mark Rowe.
2972 Introduce a new table test_metrics. This table represents metrics each test can have
2973 such as time, memory allocation, frame rate as well as aggregation such as arithmetic mean
2976 Updated admin/tests.php and index.html accordingly.
2978 Also create few indexes based on postgres' "explain analysis" as suggested by Mark.
2980 * database/generate-manifest.js:
2981 (buildPlatformMapIfPossible):
2982 * database/generate-runs.js:
2984 * database/init-database.sql:
2985 * database/schema.graffle:
2986 * public/admin/admin.css:
2989 * public/admin/tests.php:
2990 * public/index.html:
2992 2012-11-27 Ryosuke Niwa <rniwa@webkit.org>
2994 SafariPerfMonitor: Improve the webkit-perf migration tool
2995 <rdar://problem/12760882>
2997 Reviewed by Mark Rowe.
2999 Make the migrator tool skip runs when fetching runs failed since webkit-perf.appspot.com is unreliable
3000 and we don't want to pause the whole importation process until the user comes back to decide whether
3003 Also place form controls next to each test in tests.php so that users don't have to scroll all the way
3004 down to make modifications.
3006 Finally, add unique constraint to (run_config, run_build) in test_runs table in order to optimize a query
3007 of the form: "SELECT run_id FROM test_runs WHERE run_config = $1 AND run_build = $2",
3009 * database/init-database.sql:
3010 * database/perf-webkit-migrator.js:
3011 (migrateTestConfig):
3012 * database/schema.graffle:
3013 * public/admin/admin.css:
3015 * public/admin/tests.php:
3017 2012-11-16 Ryosuke Niwa <rniwa@webkit.org>
3019 Create a new performance dashboard
3020 <rdar://problem/12625582>
3022 Rubber-stamped by Mark Rowe.
3024 Add the initial implementation of the perf dashboard.
3027 * database/config.json: Added.
3028 * database/database-common.js: Added.
3033 (pathToLocalScript):
3035 * database/generate-manifest.js: Added.
3038 (buildPlatformMapIfPossible):
3039 (generateFileIfPossible):
3040 * database/perf-webkit-migrator.js: Added.
3041 * database/process-jobs.js: Added.
3042 * database/sample-data.sql: Added.
3043 * database/schema.graffle: Added.
3045 * public/admin: Added.
3046 * public/admin/README: Added.
3047 * public/admin/admin.css: Added.
3048 * public/admin/footer.php: Added.
3049 * public/admin/header.php: Added.
3050 * public/admin/index.php: Added.
3051 * public/admin/jobs.php: Added.
3052 * public/admin/tests.php: Added.
3053 * public/common.css: Added.
3054 * public/data: Added.
3055 * public/db.php: Added.
3056 * public/index.html: Added.
3058 * public/js/helper-classes.js: Added.
3059 * public/js/jquery-1.8.2.min.js: Added.
3060 * public/js/jquery.flot.min.js: Added.
3061 * public/js/jquery.flot.plugins.js: Added.
3062 * public/js/shared.js: Added.
3063 (fileNameFromPlatformAndTest):
3064 * public/js/statistics.js: Added.