1 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
6 (App.AnalysisTaskViewModel.roots):
8 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
10 Introduce the concept of analysis task to perf dashboard
11 https://bugs.webkit.org/show_bug.cgi?id=138517
13 Reviewed by Andreas Kling.
15 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
16 a single platform and used to bisect regressions in the range.
18 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
20 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
21 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
22 test runs. Analysis tasks not associated with test runs are used for try new patches.
23 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
24 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
25 build_requests - A build request represents a single pending build for A/B testing.
27 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
31 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
32 the specified analysis task group as well as build requests associated with them.
34 (fetch_test_groups_for_task):
35 (fetch_build_requests_for_task):
36 (fetch_build_requests_for_group):
38 (format_build_request):
40 * public/include/json-header.php:
41 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
44 * public/privileged-api/associate-bug.php:
47 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
50 (ensure_config_from_runs):
52 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
54 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
56 (App.AnalysisTask.create):
58 (App.TestGroupAdapter):
59 (App.AnalysisTaskSerializer):
60 (App.TestGroupSerializer):
63 * public/v2/app.css: Added style rules for the analysis page.
66 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
68 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
69 exactly one selected point as we can still create an analysis task.
70 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
71 grammatical and also alert'ed the error message when there is one.
72 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
73 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
74 once XHR request has completed.
75 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
76 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
77 is selected in the details pane.
79 (App.AnalysisRoute): Added.
80 (App.AnalysisTaskRoute): Added.
81 (App.AnalysisTaskViewModel): Added.
82 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
83 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
84 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
85 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
86 the user selects an option for all roots in A or B configuration.
87 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
89 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
92 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
93 point so that we can use it in App.AnalysisTaskViewModel.roots.
94 (TimeSeries.prototype.findPointByMeasurementId): Added.
95 (TimeSeries.prototype.seriesBetweenPoints): Added.
97 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
98 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
99 when multiple points are selected. Finally, added a new template for the analysis task page.
101 * public/v2/manifest.js:
102 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
103 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
104 App.AnalysisTaskViewModel._taskUpdated.
106 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
108 Remove App.PaneController.bugsChangeCount in the new perf dashboard
109 https://bugs.webkit.org/show_bug.cgi?id=138111
111 Reviewed by Darin Adler.
114 (App.PaneController.bugsChangeCount): Removed.
115 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
116 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
117 Finds the list of current run's points that are associated with bugs.
118 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
119 * public/v2/chart-pane.css:
120 (.chart .marked): Renamed from .hasBugs.
121 * public/v2/index.html: Specify chartPointRadius and markedPoints.
123 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
125 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
126 https://bugs.webkit.org/show_bug.cgi?id=138099
128 Reviewed by Benjamin Poulain.
130 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
131 _showDetails inverting the order of the current and old measurements.
134 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
135 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
136 current (latest) measurement and the first point is the oldest measurement.
137 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
139 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
141 Perf dashboard should provide a way to associate bugs with a test run
142 https://bugs.webkit.org/show_bug.cgi?id=137857
144 Reviewed by Andreas Kling.
146 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
147 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
148 the Apache configuration.
151 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
152 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
153 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
154 via the cookie and returns a token computed from those two values as well as the remote username.
156 The font end code then POST's the request along with the returned token. The server side code verifies
157 that the specified token can be generated from the salt and the expiration time set in the cookie, and
158 the token hasn't expired.
161 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
162 have zero or exactly one bug associated with a test run.
164 * public/admin/bug-trackers.php: Added the support for editing bug_url.
165 * public/api/runs.php:
166 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
167 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
168 an associated bug if there is one.
169 (format_run): Calls parse_bugs_array.
171 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
172 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
173 have a valid JSON payload.
174 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
175 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
176 the expiration time stored in the cookie.
177 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
179 * public/include/manifest.php:
180 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
181 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
184 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
186 * public/privileged-api/associate-bug.php: Added.
187 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
188 attack via ensure_privileged_api_data_and_token, which calls verify_token.
190 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
193 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
197 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
198 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
199 they would overlap on each other if both of them are shown.
200 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
201 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
202 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
203 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
204 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
205 showing the search pane.
206 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
207 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
208 bugs in the selected range.
210 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
211 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
212 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
213 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
214 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
215 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
216 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
217 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
219 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
220 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
221 to selectionChanged action instead of just finding the first and the last points.
223 * public/v2/chart-pane.css: Updated the style.
226 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
227 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
228 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
229 we haven't already obtained a CSRF token or if the token has already been expired.
230 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
232 (Measurement.prototype.bugs): Added.
233 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
234 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
236 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
239 * public/v2/manifest.js:
240 (App.BugTracker.bugUrl):
241 (App.BugTracker.newBugUrl): Added.
242 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
243 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
244 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
245 (App.Manifest.bugTrackers): Added.
246 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
247 their respective ids to make the ordering stable.
249 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
251 Remove unused jobs table
252 https://bugs.webkit.org/show_bug.cgi?id=137724
254 Reviewed by Daniel Bates.
256 Removed jobs table in the database as well as related code.
259 * public/admin/jobs.php: Removed.
260 * public/admin/tests.php:
261 * public/include/admin-header.php:
263 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
265 New perf dashboard should have an ability to search commits by a keyword
266 https://bugs.webkit.org/show_bug.cgi?id=137675
268 Reviewed by Geoffrey Garen.
270 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
271 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
272 This API change allows fetch_commits_between to generate results without processing Postgres query results.
274 In the front end side, we've added a search pane in pane controller, and the interactive chart component
275 now has a concept of highlighted items which is used to indicate commits found by the search pane.
277 * public/api/commits.php:
278 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
279 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
280 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
281 (format_commit): Renamed from format_commits. Now only formats one commit.
283 * public/include/db.php:
284 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
286 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
289 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
290 which is a hash table that contains highlighted items' measurements' ids as keys.
291 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
292 the default commit repository.
293 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
294 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
295 Added the code to initialize this._highlights.
296 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
297 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
298 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
299 the existing lines for the old highlighted items.
300 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
301 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
303 * public/v2/chart-pane.css: Added style for the search pane and the search button.
305 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
307 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
308 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
309 (CommitLogs._cacheConsecutiveCommits): Ditto.
310 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
311 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
312 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
314 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
315 for showingDetails since this property is no longer used.
317 * public/v2/manifest.js:
318 (App.Manifest.repositories): Added.
319 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
320 the default repository to search.
321 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
323 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
325 Unreviewed build fix after r174555.
327 * public/include/manifest.php:
328 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
329 * tests/admin-regenerate-manifest.js: Fixed the test case.
331 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
333 New perf dashboard UI tries to fetch commits all the time
334 https://bugs.webkit.org/show_bug.cgi?id=137592
336 Reviewed by Andreas Kling.
338 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
339 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
340 no reported commits as they are all going to fail.
342 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
343 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
344 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
345 of commits sorted chronologically by time.
347 * public/include/manifest.php:
350 (App.CommitsViewerComponent.commitsChanged):
353 (FetchCommitsForTimeRange):
354 (FetchCommitsForTimeRange._cachedCommitsByRepository):
356 * public/v2/manifest.js:
359 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
361 Another unreviewed build fix after r174477.
363 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
365 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
367 * public/include/report-processor.php:
369 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
371 Unreviewed build fix after r174477.
373 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
374 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
376 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
377 This is necessary for baseline and target values manually added via admin pages.
379 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
381 Add v2 UI for the perf dashboard
382 https://bugs.webkit.org/show_bug.cgi?id=137537
384 Rubber-stamped by Andreas Kling.
387 * public/v2/app.css: Added.
388 * public/v2/app.js: Added.
389 * public/v2/chart-pane.css: Added.
390 * public/v2/data.js: Added.
391 * public/v2/index.html: Added.
392 * public/v2/js: Added.
393 * public/v2/js/d3: Added.
394 * public/v2/js/d3/LICENSE: Added.
395 * public/v2/js/d3/d3.js: Added.
396 * public/v2/js/d3/d3.min.js: Added.
397 * public/v2/js/ember-data.js: Added.
398 * public/v2/js/ember.js: Added.
399 * public/v2/js/handlebars.js: Added.
400 * public/v2/js/jquery.min.js: Added.
401 * public/v2/js/statistics.js: Added.
402 * public/v2/manifest.js: Added.
403 * public/v2/popup.js: Added.
405 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
407 Remove superfluously duplicated code in public/api/report-commits.php.
409 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
411 Perf dashboard should store commit logs
412 https://bugs.webkit.org/show_bug.cgi?id=137510
414 Reviewed by Darin Adler.
416 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
418 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
419 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
420 a subversion directory. The git version of this script will be added in a follow up patch.
423 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
424 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
425 relationship via "build_commits" relations.
427 In order to migrate an existing instance of this application, run the following SQL commands:
431 INSERT INTO commits (commit_repository, commit_revision, commit_time)
432 (SELECT DISTINCT ON (revision_repository, revision_value)
433 revision_repository, revision_value, revision_time FROM build_revisions);
435 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
436 FROM commits, build_revisions
437 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
439 DROP TABLE build_revisions;
444 The helper script to submit commit logs can be used as follows:
446 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
447 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
449 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
450 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
451 "feeder-slave-password" as the builder name and the builder password respectively.
453 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
454 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
457 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
459 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
460 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
462 - Not specified - It returns every single commit for a given repository.
463 - Matches "oldest" - It returns the commit with the oldest timestamp.
464 - Matches "latest" - It returns the commit with the latest timestamp.
465 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
466 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
467 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
468 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
469 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
470 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
472 (commit_from_revision):
473 (fetch_commits_between):
476 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
477 See tests/api-report-commits.js for examples on how to use this API.
479 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
480 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
481 to optimize this and other JSON APIs.
483 * public/include/db.php:
484 (Database::select_or_insert_row):
485 (Database::update_or_insert_row): Added.
486 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
487 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
489 (Database::select_first_row):
490 (Database::select_last_row): Added.
491 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
492 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
494 * public/include/report-processor.php:
495 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
496 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
497 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
500 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
502 * tests/api-report-commits.js: Added.
503 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
506 * tools/pull-svn.py: Added. See above for how to use this script.
508 (determine_first_revision_to_fetch):
509 (fetch_revision_from_dasbhoard):
510 (fetch_commit_and_resolve_author):
513 (resolve_author_name_from_email):
516 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
518 Update Install.md for Mavericks and fix typos
519 https://bugs.webkit.org/show_bug.cgi?id=137276
521 Reviewed by Benjamin Poulain.
523 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
525 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
527 Finally, init-database.sql is no longer located inside database directory.
531 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
533 Report run id's in api/runs.php for the new dashboard UI
534 https://bugs.webkit.org/show_bug.cgi?id=135813
536 Reviewed by Andreas Kling.
538 Include run_id in the generated JSON.
540 * public/api/runs.php:
541 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
544 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
546 Merging platforms mixes baselines and targets into reported data
547 https://bugs.webkit.org/show_bug.cgi?id=135260
549 Reviewed by Andreas Kling.
551 When merging two platforms, move test configurations of a different type (baseline, target)
552 as well as of different metric (Time, Runs).
554 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
555 It's sufficient to detect one such test_runs object.
557 * public/admin/platforms.php:
560 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
562 Merging platforms mixes baselines and targets into reported data
563 https://bugs.webkit.org/show_bug.cgi?id=135260
565 Reviewed by Geoffrey Garen.
567 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
568 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
570 * public/admin/platforms.php:
572 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
574 Build fix after r171361.
576 * public/js/helper-classes.js:
577 (.this.formattedBuildTime):
579 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
581 Perf dashboard spends 2s processing JSON data during the page loads
582 https://bugs.webkit.org/show_bug.cgi?id=135152
584 Reviewed by Andreas Kling.
586 In the Apple internal dashboard, we were spending as much as 2 seconds
587 converting raw JSON data into proper JS objects while loading the dashboard.
589 This caused the apparent unresponsiveness of the dashboard despite of the fact
590 charts themselves updated almost instantaneously.
593 * public/js/helper-classes.js:
594 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
595 lazily as creating new Date objects and running string replace is expensive.
596 (TestBuild.formattedTime):
597 (TestBuild.formattedBuildTime):
598 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
599 (PerfTestRuns.addResult): Deleted.
601 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
603 Perf dashboard shouldn't show the full git hash
604 https://bugs.webkit.org/show_bug.cgi?id=135083
606 Reviewed by Benjamin Poulain.
608 Detect Git/Mercurial hash by checking the length.
610 If it's a hash, use the first 8 characters in the label
611 while retaining the full length to be used in hyperlinks.
613 * public/js/helper-classes.js:
614 (.this.formattedRevisions):
617 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
619 Add an instruction on how to backup the database.
620 https://bugs.webkit.org/show_bug.cgi?id=133391
622 Rubber-stamped by Andreas Kling.
626 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
628 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
630 * public/js/helper-classes.js:
631 (PerfTestRuns.smallerIsBetter):
633 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
643 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
645 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
646 https://bugs.webkit.org/show_bug.cgi?id=131157
648 Reviewed by Andreas Kling.
650 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
651 This allows, for example, adding all metrics such as Arithmetic and Geometric for
652 a given test suite without also adding its subtests.
658 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
660 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
661 https://bugs.webkit.org/show_bug.cgi?id=131155
663 Reviewed by Andreas Kling.
665 The bug was caused by Chart.attach binding event listeners on plot container on each call.
666 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
667 click when attach() has been called even number of times, keeping the tooltip invisible.
669 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
670 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
671 is called for the first time.
675 (Chart..bindPlotEventHandlers):
677 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
679 WebKitPerfMonitor: Tooltips can be cut off at the top
680 https://bugs.webkit.org/show_bug.cgi?id=130960
682 Reviewed by Andreas Kling.
685 (#title): Removed the gradients, box shadows, and border from the header.
686 (#title h1): Reduce the font size.
687 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
689 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
690 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
691 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
692 * public/js/helper-classes.js:
693 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
694 tooltip extending above y=0.
696 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
698 WebKitPerfMonitor: Y-axis adjustment is too aggressive
699 https://bugs.webkit.org/show_bug.cgi?id=130937
701 Reviewed by Andreas Kling.
703 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
704 results. This had two major problems:
705 1. Two standard deviations can be too small to show the confidence interval for results.
706 2. Sometimes baseline and target can be more than two standards deviations away.
708 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
709 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
710 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
711 the margin on each side separately to reduce the empty space on either side.
713 A more rigorous approach would involve computing least squared value of results with respect to intervals
714 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
717 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
718 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
719 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
720 We wouldn't see the difference between measured values versus baseline and target values otherwise.
721 * public/js/helper-classes.js:
722 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
723 interval delta cannot be computed.
724 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
725 within the given interval.
726 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
727 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
728 (PerfTestRuns..unscaledMeansForAllResults):
729 (PerfTestRuns.min): Take the confidence interval delta into account.
730 (PerfTestRuns.max): Ditto.
731 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
732 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
734 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
736 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
738 Some CSS tweaks after r166477 and r166479,
742 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
744 WebKitPerfMonitor: Sometimes text inside panes overlap
745 https://bugs.webkit.org/show_bug.cgi?id=130956
747 Reviewed by Gyuyoung Kim.
749 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
750 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
751 reduces the total height of the pane and fits more information per screen capita on the dashboard.
753 * public/index.html: Updated and added a bunch of CSS rules for the new look.
754 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
755 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
756 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
757 of the build info shown in a chart pane and a tooltip.
758 (Chart): Made .status a table.
759 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
760 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
761 now that status.text no longer contains it.
762 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
764 * public/js/helper-classes.js:
765 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
766 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
767 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
768 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
769 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
770 capital letter; e.g. "MB" instead of "M B".
772 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
774 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
775 https://bugs.webkit.org/show_bug.cgi?id=130957
777 Reviewed by Gyuyoung Kim.
779 Moved the slider into the header. Also reduced the spacing between the header and platform names.
780 This reclaims 50px × width of the screen real estate.
783 (#title): Reduced the space below the header from 20px to 10px.
785 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
786 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
787 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
788 real estate between the header and the platform names.
790 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
792 Update the install guidelines for perf.webkit.org
793 https://bugs.webkit.org/show_bug.cgi?id=129895
795 Reviewed by Ryosuke Niwa.
797 The current install guideline for perf.webkit.org discourages the use of the installed
798 Server application. I've actualized the documentation for Mavericks, and modified the
799 guideline to include the instructions for Server.app also.
803 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
805 Update perf.webkit.org json example
806 https://bugs.webkit.org/show_bug.cgi?id=129907
808 Reviewed by Andreas Kling.
810 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
814 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
816 Merge database-common.js and utility.js into run-tests.js.
818 Reviewed by Matthew Hanson.
820 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
821 Also moved init-database.sql out of the database directory and removed the directory entirely.
824 * database/database-common.js: Removed.
825 * database/utility.js: Removed.
826 * init-database.sql: Moved from database/init-database.sql.
828 (connect): Moved from database-common.js.
829 (pathToDatabseSQL): Extracted from pathToLocalScript.
830 (pathToTests): Moved from database-common.js.
833 (SerializedTaskQueue): Ditto.
835 (initializeDatabase):
836 (TestEnvironment.it):
837 (TestEnvironment.queryAndFetchAll):
840 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
842 Remove the dependency on node.js from the production code.
844 Reviewed by Ricky Mondello.
846 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
848 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
849 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
850 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
851 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
852 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
854 Also removed the js files that are no longer used.
856 * config.json: Moved from database/config.json.
857 * database/aggregate.js: Removed. No longer used.
858 * database/database-common.js: Removed unused functions, and updated the path to config.json.
859 * database/process-jobs.js: Removed. No longer used.
860 * database/sample-data.sql: Removed. We have a much better corpus of data now.
861 * database/schema.graffle: Removed. It's completely obsolete.
862 * public/include/db.php: Updated the path to config.json.
863 * public/include/evaluator.js: Removed.
865 * public/include/report-processor.php:
866 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
867 storing values into $expressions and calling evaluate_expressions_by_node.
868 (TestRunsGenerator::aggregate_values): Added.
869 (TestRunsGenerator::compute_caches): Directly compute the caches.
871 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
873 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
875 * public/admin/platforms.php:
876 * public/include/db.php:
878 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
880 Zoomed y-axis view is ununsable when the last result is an outlier.
882 Reviewed by Stephanie Lewis.
884 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
885 the last result so that the graph looks sane if the last result was an outlier. However, always show
886 the last result's mean even if it was an outlier.
889 * public/js/helper-classes.js:
890 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
891 Also added the ability to cache the unscaled means to avoid recomputation.
892 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
893 (PerfTestRuns.max): Ditto.
894 (PerfTestRuns.sampleStandardDeviation): Ditto.
895 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
897 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
901 * public/admin/tests.php:
902 * public/js/helper-classes.js:
904 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
906 Use two standard deviations instead as I mentioned in the mailing list.
910 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
912 The performance dashboard erroneously shows upward arrow for combined metrics.
914 A single outlier can ruin the zoomed y-axis view.
916 Rubber-stamped by Antti Koivisto.
919 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
920 from the latest results' mean.
921 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
922 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
924 * public/js/helper-classes.js:
925 (PerfTestRuns.sampleStandardDeviation): Added.
926 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
928 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
930 Don't include the confidence interval when computing the y-axis.
932 Rubber-stamped by Simon Fraser.
934 * public/js/helper-classes.js:
938 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
940 Tiny CSS tweak for tooltips.
944 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
946 Remove the erroneously repeated code.
948 * public/admin/test-configurations.php:
950 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
952 <rdar://problem/15704893> perf dashboard should show baseline numbers
954 Reviewed by Stephanie Lewis.
956 * public/admin/bug-trackers.php:
957 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
960 * public/admin/platforms.php:
963 * public/admin/test-configurations.php: Added.
964 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
965 build_revisions as they're not meaningful for baseline / target numbers.
966 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
967 one test run so that we don't accidentally delete a reported test run.
968 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
969 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
970 and delete existing ones.
972 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
973 on each platform; there could be configurations of distinct types such as "current" and "baseline".
974 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
976 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
977 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
978 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
979 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
980 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
982 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
984 * public/include/admin-header.php:
985 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
986 have id and type sub columns, and each custom column could generate multiple rows.
988 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
989 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
990 We then proceed to generate the second header row with sub column names.
992 When generating the actual content, we first generate all custom columns as they may have multiple rows in
993 which case regular columns need rowspan set to the maximum number of rows.
995 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
998 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
999 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
1000 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
1001 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
1002 expanded to occupy all sub columns.
1004 * public/include/manifest.php:
1005 (ManifestGenerator::platforms): Don't add the metric more than once.
1007 * public/include/test-name-resolver.php:
1008 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
1009 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
1010 full metric name later.
1011 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
1012 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
1013 (TestNameResolver::full_name_for_test): Added.
1014 (TestNameResolver::full_name_for_metric): Added.
1015 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
1017 * public/js/helper-classes.js:
1018 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
1019 test runs created to set baseline and target points.
1021 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1023 Build fix after r57928. Removed a superfluous close parenthesis.
1025 * public/api/runs.php:
1027 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1029 Unreviewed build & typo fixes.
1031 * public/admin/platforms.php:
1032 * tests/admin-platforms.js:
1034 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1036 <rdar://problem/15704893> perf dashboard should show baseline numbers
1038 Rubber-stamped by Antti Koivisto.
1040 Organize some code into functions in runs.php.
1042 Also added back $paths that was erroneously removed in r57925 from json-header.php.
1044 * public/api/runs.php:
1045 (fetch_runs_for_config): Extracted.
1046 (format_run): Ditto.
1048 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1050 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
1052 * database/config.json:
1053 * public/admin/reprocess-report.php:
1054 * public/api/report.php:
1055 * public/api/runs.php:
1056 * public/include/json-header.php:
1058 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1060 Commit yet another forgotten change.
1062 Something went horribly wrong with my merge :(
1064 * database/init-database.sql:
1066 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1068 Commit one more forgotten change. Sorry for making a mess here.
1070 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1072 Commit the forgotten files.
1074 * public/admin/platforms.php: Added.
1075 * tests/admin-platforms.js: Added.
1077 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1079 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
1081 Reviewed by Stephanie Lewis.
1083 Added /admin/platforms/ page to hide and merge platforms.
1085 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
1086 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
1087 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
1088 each test configuration a distinct "test run" for each build.
1090 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
1091 their test configurations into platform B.
1093 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
1094 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
1095 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
1096 in platform B, in which case R should relate to T_B instead.
1098 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
1099 new platform. We then migrate the test configurations of the remaining test runs.
1101 * database/init-database.sql: Added platform_hidden.
1103 * public/admin/platforms.php: Added.
1104 (merge_platforms): Added. Implements the algorithm described above.
1105 (merge_list): Added.
1107 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
1108 is hidden since it doesn't do anything.
1110 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
1111 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
1112 missing it since unchecked checkbox doesn't set the value in $_POST.
1113 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
1114 switch statement instead of repeated if's.
1115 (AdministrativePage::render_table): Emit "update-column" for update_field.
1117 * public/include/db.php: Disable warnings when we're not in the debug mode.
1119 * public/include/manifest.php:
1120 (ManifestGenerator::platforms): Skip platforms that have been hidden.
1123 (TestEnvironment.postJSON):
1124 (TestEnvironment.httpGet):
1125 (TestEnvironment.httpPost): Added.
1126 (sendHttpRequest): Set the content type if specified.
1128 * tests/admin-platforms.js: Added tests.
1130 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
1132 Extract the code to compute full test names from tests.php.
1134 Reviewed by Stephanie Lewis.
1136 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
1137 and paves our way to re-use the code in other pages.
1139 * public/admin/tests.php:
1141 * public/include/db.php:
1142 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
1143 tests.php and test-name-resolver.php.
1145 * public/include/test-name-resolver.php: Added.
1146 (TestNameResolver::__construct):
1147 (TestNameResolver::compute_full_name): Moved from tests.php.
1148 (TestNameResolver::map_metrics_to_tests): Ditto.
1149 (TestNameResolver::sort_tests_by_full_name): Ditto.
1150 (TestNameResolver::tests): Added.
1151 (TestNameResolver::test_id_for_full_name): Ditto.
1152 (TestNameResolver::metrics_for_test_id): Ditto.
1153 (TestNameResolver::child_metrics_for_test_id): Ditto.
1154 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
1156 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
1158 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
1160 Reviewed by Stephanie Lewis.
1162 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
1164 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
1165 but that's sufficient to correct the wrongfully processed reports for now.
1167 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
1168 We should eventually add a nice UI to find and reprocess reports.
1170 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
1172 * public/include/db.php: Added the forgotten call to prefixed_column_names.
1174 * public/include/report-processor.php: Copied from public/api/report.php.
1175 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
1176 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
1177 create a new report or authenticate the builder password (the password is never stored in the report).
1178 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
1179 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
1180 (ReportProcessor::store_report): Ditto.
1182 * tests/admin-reprocess-report.js: Added.
1184 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
1186 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
1188 Reviewed by Ricky Mondello.
1190 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
1191 for the same build number as a single build by ignoring build time. This was necessary to associate
1192 multiple reports by a single build - e.g. for different performance test suites - because the scripts
1193 we use to submit results computed its own "build time" when they're called.
1195 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
1196 last week; new reports were wrongfully associated with old build numbers.
1198 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
1199 to the same build. Instead, we create a new build object for those reports. Since the longest set of
1200 tests we have only take a couple of hours to run, 24 hours should be more than enough.
1202 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
1203 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
1204 (builder, build number, build time).
1206 * public/api/report.php:
1207 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
1208 when no such build exists. This prevents a report from being associated with a very old build of the same
1211 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
1212 a similar bug in the future sooner.
1214 * tests/api-report.js: Added three test cases.
1216 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
1218 Merged the upstream changes to db.php
1219 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
1221 * public/include/db.php:
1223 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
1225 Update other scripts and tests per previous patch.
1227 * public/include/manifest.php:
1228 * tests/admin-regenerate-manifest.js:
1230 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
1232 Remove metrics_unit.
1234 Reviewed by Ricky Mondello.
1236 This column is no longer used by the front-end code since r48360.
1238 * database/init-database.sql:
1239 * public/admin/tests.php:
1241 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
1243 Unreviewed build fix.
1245 * public/api/report.php:
1247 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
1249 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
1251 Reviewed by Ricky Mondello.
1253 Support a new alternative format for aggregated results where we have raw values as well as
1254 the list aggregators so that instead of
1255 "metrics": {"Time": ["Arithmetic"]}
1257 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
1259 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
1260 dashboard and the generated results page, which doesn't know how to aggregate values.
1262 We need to keep the support for the old format because all other existing performance tests
1263 all rely on the old format. Even if we updated the tests, we need the dashboard to support
1264 the old format during the transition.
1266 * public/api/report.php:
1267 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
1268 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
1270 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
1272 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
1274 Unreviewed; Tweak the CSS so that chart panes align vertically.
1276 * public/index.html:
1278 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
1280 SafariPerfMonitor should support Combined metric.
1282 * public/js/helper-classes.js:
1283 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
1284 value as well but assume it to be greater-is-better for now.
1286 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
1288 Commit the forgotten init-database change to add iteration_relative_time.
1290 * database/init-database.sql:
1292 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
1294 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
1296 Reviewed by Ricky Mondello.
1298 Add the support for each value to have a relative time. This is necessary for frame rate history
1299 since a frame rate needs to be associated with a time it was sampled.
1301 * database/init-database.sql: Added iteration_relative_time to run_iterations.
1303 * public/api/report.php:
1304 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
1305 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
1306 with relative time since taking the average of two frame rates for two subtests taken at two
1307 different times doesn't make any sense.
1308 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
1309 etc..., use the second element since we assume values are of the form (relative time, frame rate).
1310 Also exit early with an error if the number of elements in the array is not a pair.
1311 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
1313 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
1314 iteration_relative_time.
1316 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
1318 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
1320 Reviewed by Ricky Mondello.
1322 Support that. It's one line change.
1324 * public/api/report.php:
1325 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
1326 to match the convention assumed elsewhere.
1327 * tests/api-report.js: Added a test case.
1329 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1331 SafariPerfMonitor shows popups for points outside of the visible region.
1333 Rubber-stamped by Simon Fraser.
1335 * public/index.html:
1336 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
1337 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
1338 may return an item underneath y-axis labels.
1340 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1342 Tweak the CSS a little to avoid the test name overlapping with the summary table.
1344 * public/index.html:
1346 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1348 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
1350 * public/index.html:
1352 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1354 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
1355 <rdar://problem/13992271> Should scale Y axis to include error ranges
1357 Reviewed by Ricky Mondello.
1359 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
1360 the main graph doesn't go outside the graph even when the y-axis is adjusted.
1362 * database/config.json:
1363 * public/index.html:
1364 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
1365 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
1366 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
1368 * public/js/helper-classes.js:
1369 (PerfTestResult.confidenceIntervalDelta):
1370 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
1371 (PerfTestRuns.min): Take confidence interval delta into account.
1372 (PerfTestRuns.max): Ditto.
1373 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
1375 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1377 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
1379 * public/api/report.php:
1380 (ReportProcessor::recursively_ensure_tests):
1381 * tests/api-report.js: Added a test.
1383 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1385 Unreviewed build fixes.
1387 * public/api/report.php:
1388 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
1389 Also, tolerate reports without any revision information.
1391 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
1394 * tests/api-report.js: Added few test cases.
1396 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1398 Commit another change that was supposed to be committed in r50331.
1401 (TestEnvironment.this.postJSON):
1402 (TestEnvironment.this.httpGet):
1405 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
1407 Commit the remaining files.
1409 * public/admin/regenerate-manifest.php:
1410 * public/include/admin-header.php:
1411 * public/include/json-header.php:
1412 * public/include/manifest.php:
1414 (TestEnvironment.this.postJSON):
1415 (TestEnvironment.this.httpGet):
1418 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
1420 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
1422 Reviewed by Ricky Mondello.
1424 Added some tests for admin/regenerate-manifest.
1426 * public/admin/regenerate-manifest.php: Use require_once instead of require.
1427 * public/include/admin-header.php: Ditto.
1428 * public/include/json-header.php: Ditto.
1430 * public/include/manifest.php:
1431 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
1432 When there are no builders, simply return an empty array.
1435 (TestEnvironment.postJSON):
1436 (TestEnvironment.httpGet): Added.
1437 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
1439 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
1441 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
1443 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
1444 and run_iterations. Also fixed a typo in report.php found by new tests.
1446 * public/api/report.php:
1447 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
1448 * tests/api-report.js: Added more test cases.
1450 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
1452 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
1454 Reviewed by Ricky Mondello.
1456 Add a test runner script and some simple test cases.
1458 * database/config.json: Added the configuration for "testServer".
1459 * database/database-common.js:
1460 (pathToTests): Added.
1461 * run-tests.js: Added.
1464 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
1465 and if there are, asks the user if it’s okay to delete all of the data contained therein.
1466 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
1468 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
1469 in the current database using PostgreSQL's information_schema.
1470 (askYesOrNoQuestion):
1472 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
1474 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
1475 (TestEnvironment.assert): Exposes assert to tests.
1476 (TestEnvironment.console): Exposes console to tests.
1477 (TestEnvironment.describe): Adds a description.
1478 (TestEnvironment.it): Adds a test case.
1479 (TestEnvironment.postJSON):
1480 (TestEnvironment.queryAndFetchAll):
1481 (TestEnvironment.sha256):
1482 (TestEnvironment.notifyDone): Ends the current test case.
1486 (TestContext): An object created for each test case. Conceptually, this object is always on
1487 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
1488 this object via currentTestContext.
1489 (TestContext.description):
1491 (TestContext.logError):
1494 * tests/api-report.js: Added some basic tests for /api/report.php.
1496 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1498 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
1500 The problem was that we were detecting whether we're updating dashboard or not by checking
1501 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
1502 all configurations. Use separate 'dashboard' action to execute the code even when
1503 metric_configurations is empty.
1505 * public/admin/tests.php:
1507 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1509 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
1511 Reviewed by Ricky Mondello.
1513 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
1514 from ReportProcessor as a preparation to replace deprecated aggregate.js.
1516 * public/api/report.php:
1517 (ReportProcessor::exit_with_error): Moved.
1518 (ReportProcessor::process): Use the extracted TestRunsGenerator.
1519 (TestRunsGenerator): Added.
1520 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
1521 (TestRunsGenerator::add_aggregated_metric): Moved.
1522 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
1523 (TestRunsGenerator::aggregate): Moved. Made public.
1524 (TestRunsGenerator::aggregate_current_test_level): Moved.
1525 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
1526 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
1527 (TestRunsGenerator::compute_caches): Moved. Made public.
1528 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
1529 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
1530 (TestRunsGenerator::rollback_with_error): Moved.
1532 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1534 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
1536 Reviewed by Remy Demarest.
1538 Regenerate the manifest file when updating fields or adding new items that are included in
1541 * public/admin/bug-trackers.php:
1542 * public/admin/builders.php:
1543 * public/admin/regenerate-manifest.php:
1544 * public/admin/repositories.php:
1545 * public/admin/tests.php:
1546 * public/include/admin-header.php:
1547 (regenerate_manifest): Extracted from regenerate-manifest.php.
1549 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1551 Unreviewed build fix for memory test results.
1553 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
1554 aggregating at each level.
1556 * public/api/report.php:
1557 (ReportProcessor::recursively_ensure_tests):
1558 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
1559 (ReportProcessor::add_values_for_aggregation):
1560 (ReportProcessor::aggregate):
1561 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
1563 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
1565 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
1566 not the number of iteration groups. Also, don't set group number when the entire run belongs
1567 a single iteration group.
1569 * public/api/report.php:
1570 (ReportProcessor::commit):
1572 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1574 SafariPerfMonitor: Introduce iteration groups
1576 Reviewed by Remy Demarest.
1578 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
1579 the runtime environment variances to get more stable results. And it's desirable to keep track of
1580 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
1582 This patch introduces "iteration groups" to keep track of this extra information.
1584 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
1585 the outer array denotes iteration groups and each inner array contains iteration values for each group.
1588 * database/init-database.sql: Add iteration_group column.
1589 * public/api/report.php:
1590 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
1592 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
1593 contains the list of values indexed by the iteration order and group sizes. Store the group size so
1594 that we can restore the iteration groups before passing it to node.js and restore them later.
1596 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
1597 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
1599 Also check that each iteration group in each subtest are consistent with one another. To see why we need
1600 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
1601 that each iteration group in T1 and T2 have the same size:
1602 T1 = [[1, 2], [3, 4, 5]]
1603 T2 = [[6, 7], [8, 9, 10]]
1605 so that the aggregated result (the sum in this case) can have the same groups as in:
1606 T = [[7, 9], [11, 13, 15]]
1608 If some iteration groups in T1 and T2 had a different size as in:
1609 T1 = [[1, 2, 3], [4, 5]]
1610 T2 = [[6, 7], [8, 9, 10]]
1612 Then iteration groups of the aggregated T is ambiguous.
1614 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
1615 (ReportProcessor::commit): Store iteration_group values.
1617 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1619 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
1620 migrated to perf.webkit.org.
1622 * database/perf-webkit-migrator.js: Removed.
1624 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1626 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
1628 * public/index.html:
1631 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1633 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
1635 Reviewed by Ricky Mondello.
1637 It is often desirable to see charts of a given test for all platforms, or to be able to see
1638 charts of all subtests on a given platform when trying to triage perf. regressions.
1640 Support this use case by adding the ability to do so on the charts page.
1642 Also, we used to disable items on the test list based on the platform chosen. This turned out
1643 to be a bad UI because in many situations you want to be able to compare results of the same test
1644 on multiple platforms.
1646 In this new UI, we have three select elements, each of which selects the following:
1647 1. Top-level test - Test suite such as Dromaeo
1648 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
1649 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
1650 3. Platform - Mountain Lion, Qt, etc...
1652 A user can select "all" for metric and platform but we disallow doing both at once since adding
1653 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
1654 think of a use case where you want to look at that many charts at once. We can support this later
1655 if valid use cases come up.
1657 * public/index.html:
1658 (.showCharts.addOption): Extracted.
1659 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
1660 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
1661 metricList has onchange handler that enables/disables items on platformList.
1663 (init): Sort tests and test metrics here instead of doing that in showCharts.
1665 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
1667 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
1669 Reviewed by Remy Demarest and Ricky Mondello.
1671 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
1672 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
1673 templates to the manifest file instead. Each build now only contains the builder id.
1675 * public/api/runs.php: Removed the part of the query that joined builders table. This
1676 speeds up the query quite a bit.
1678 * public/include/manifest.php:
1679 (ManifestGenerator::generate): Generate builders field.
1680 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
1681 associative array that contains name and its build URL template.
1683 * public/index.html:
1684 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
1685 instead of a revision since this function is used for revisions and build page URLs now.
1686 (.buildLabelWithLinks): Include the linkified build number.
1688 * public/js/helper-classes.js:
1689 (TestBuild.builder): Added.
1690 (TestBuild.buildNumber): Added.
1691 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
1692 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
1694 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
1696 Tooltips interfere with user interactions
1698 Rubber-stamped by Simon Fraser.
1700 Disable tooltip on the dashboard page since graphs are too small to be useful there.
1701 Also, show graphs for only 10 days by default as opposed to 20.
1702 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
1704 * public/index.html:
1705 * public/js/helper-classes.js:
1707 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
1709 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
1710 to be compatible with webkit-perf.appspot.com.
1712 * public/admin/builders.php:
1713 * public/api/report.php:
1715 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
1719 Add a missing constraint on builds table. For a given builder, there should be exactly
1720 one build for a given build number.
1722 Also add report_committed_at to reports table to record the time at which a given report
1723 was processed and test_runs and run_iterations rows were committed into the database.
1725 * database/config.json:
1726 * public/api/report.php:
1728 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
1730 Unreviewed. Add more checks for empty SQL query results.
1732 * public/include/manifest.php:
1734 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1736 More build fixes on perf.webkit.org.
1738 * public/api/runs.php: Make PostgreSQL happier.
1739 * public/include/manifest.php: Don't assume we always have bug trackers.
1741 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1743 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
1744 and fix other miscellaneous UI bugs.
1746 Rubber-stamped by Simon Fraser.
1748 Removed the code to determine whether smaller value is better or not for a given test in index.html
1749 in the favor of using that of PerfTestRuns.
1751 * public/include/manifest.php: Fixed a typo.
1752 * public/index.html:
1754 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
1756 * public/js/helper-classes.js:
1757 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
1759 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
1760 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
1761 at roughly 2,000 units to avoid this.
1763 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
1764 The only thing we can avoid is innerHTML.
1766 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1768 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
1770 * public/include/evaluator.js:
1772 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1774 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
1776 Reviewed by Remy Demarest.
1778 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
1779 admin/bug-trackers.php and can be associated with multiple repositories.
1781 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
1782 to determine the set of bug trackers to show for a given set of blame lists.
1783 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
1784 a place to file bugs against the regression.
1786 * database/init-database.sql: Added bug_trackers and tracker_repositories.
1787 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
1789 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
1790 bug trackers, namely associated repositories.
1792 * public/include/admin-header.php: Added a link to bug-trackers.php
1793 * public/include/manifest.php:
1794 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
1795 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
1797 (ManifestGenerator::repositories):
1799 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
1800 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
1801 'repositories' where the latter contains the list of associated repository names.
1803 * public/index.html:
1804 (Chart): Takes bugTrackers as as argument.
1805 (Chart.showTooltipWithResults): Removed the hard-coded list.
1807 (init.addPlatformsToDashboard):
1808 (init.showCharts.createChartFromListPair):
1809 (init): Stores the list of bug trackers in the manifest to a local variable.
1811 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1813 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
1815 * public/include/evaluator.js:
1817 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1819 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
1821 Reviewed by Remy Demarest.
1823 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
1824 new row into the database.
1826 * public/admin/aggregators.php: Use AdministrativePage.
1827 * public/admin/builders.php: Ditto.
1828 * public/admin/repositories.php: Ditto.
1829 * public/include/admin-header.php:
1830 (AdministrativePage): Added.
1831 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
1832 to an associative array that describes the column.
1833 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
1834 - label: Human readable name of the column.
1835 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
1836 column exists only before we create password_hash column at the insertion time.
1838 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
1839 titlecase (e.g. new_bug is converted to New Bug).
1840 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
1841 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
1842 textarea for a given editing mode ('text', 'url', or 'string').
1843 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
1844 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
1846 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
1848 Build fix. Some systems don't support r+. Use proc_open instead.
1850 * public/api/report.php:
1852 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
1854 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
1855 when computing the y-axis of data points to show tooltips at.
1857 * public/index.html:
1859 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
1861 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
1864 * public/.htaccess: Removed.
1866 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
1870 * public/include/manifest.php: Build fix. db is on this.
1871 * public/js/statistics.js:
1872 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
1874 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
1876 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
1878 Reviewed by Anders Carlsson.
1880 Rewrote and merged populate-from-report.js into report.php.
1882 * database/config.json: Added a path to node.js.
1884 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
1885 Once we land this patch and update the administrative pages, we can remove this column.
1887 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
1888 that table is going away once we remove the node.js backend.
1890 * database/populate-from-report.js: Removed.
1891 * public/api/report.php: Added.
1893 (ReportProcessor.__construct):
1894 (ReportProcessor.process):
1896 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
1897 verified to be submitted by a known builder.
1899 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
1900 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
1901 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
1902 inside a transaction because there could be multiple reports for a single build, each containing results for
1905 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
1906 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
1907 add_values_to_commit, and add_values_for_aggregation.
1909 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
1910 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
1911 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
1914 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
1915 to be aggregated in ReportProcessor.aggregate.
1917 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
1919 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
1920 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
1921 given for each row (child metrics of M). This function extracts each column (iteration) via
1922 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
1923 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
1925 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
1926 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
1927 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
1929 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
1930 (ReportProcessor.evaluate_expressions_by_node): See above.
1932 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
1933 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
1934 results also need the said caches.
1936 (ReportProcessor.add_values_to_commit):
1938 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
1939 the transaction as needed if anything goes wrong.
1941 (ReportProcessor.rollback_with_error)
1943 * public/include/db.php:
1944 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
1945 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
1946 contiguously in a SQL statement.
1948 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
1949 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
1950 a column value of the choice.
1952 (Database.begin_transaction): Added.
1953 (Database.commit_transaction): Added.
1954 (Database.rollback_transaction): Added.
1956 * public/include/evaluator.js: Added.
1957 * public/include/json-header.php:
1958 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
1959 context under which the request failed.
1960 (successful_exit): Merge "additional details".
1961 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
1962 (merge_additional_details):
1964 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
1966 SafariPerfMonitor: Add more helper functions to db.php
1968 Reviewed by Remy Demarest.
1970 Added Database::insert_row and array_get to make common database operations easier.
1972 * public/admin/aggregators.php: Use Database::insert_row instead of
1973 execute_query_and_expect_one_row_to_be_affected.
1975 * public/admin/builders.php: Ditto.
1977 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
1978 inserting a row. With insert_row, we don't need that.
1980 * public/include/admin-header.php: Ditto.
1982 * public/include/db.php:
1983 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
1984 return the default value (defaults to NULL) if the key doesn't exist.
1986 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
1989 (Database::prepare_params): Added. Takes an associative array of column names and their values,
1990 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
1991 column names all in the same order.
1993 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
1994 the given prefix. Values are given in a form of an associative array where keys are unprefixed
1995 column names and values are corresponding values. When the row is successfully inserted, it returns
1996 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
1997 indicating the success of the insertion.
1999 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
2001 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
2003 Reviewed by Conrad Shultz.
2005 Rewrote the manifest generator in PHP.
2007 * database/generate-manifest.js: Removed.
2008 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
2009 * public/include/db.php:
2010 (array_ensure_item_has_array): Added.
2011 * public/include/evaluator.js: Added.
2012 * public/include/json-header.php:
2013 * public/include/manifest.php: Added.
2015 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
2017 Dates on overflow plot are overlapping
2019 Rubber-stamped by Simon Fraser.
2021 Don't show more than 5 days.
2023 * public/index.html:
2024 * public/js/helper-classes.js:
2025 (TestBuild.UTCtoPST):
2028 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
2030 Show build time as well as commit time on the dashboard and tooltips.
2032 Rubber-stamped by Simon Fraser.
2034 Include both the maximum commit time and build time in buildLabelWithLinks.
2035 Also use ISO format to save the screen real estate.
2037 * public/index.html:
2038 (buildLabelWithLinks):
2039 * public/js/helper-classes.js:
2041 (TestBuild.buildTime):
2042 (TestBuild.formattedBuildTime):
2044 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
2046 Unreviewed; Convert metric.name to metric.unit in the front end.
2048 * public/js/helper-classes.js:
2050 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
2052 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
2054 Rubber-stamped by Simon Fraser.
2056 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
2057 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
2058 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
2060 * public/index.html:
2061 (.buildLabelWithLinks): Extracted from TestBuild.label.
2062 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
2063 on Radar and WebKit Bugzilla.
2064 * public/js/helper-classes.js:
2065 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
2066 (PerfTestResult.isBetterThan): Added.
2067 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
2068 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
2069 to indicate progressions or regressions.
2070 (PerfTestResult.label):
2071 (TestBuild.formattedTime): Added.
2072 (TestBuild.platform): Added.
2073 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
2074 (TestBuild.smallerIsBetter): Added.
2075 (Tooltip.show): Take a raw markup instead of two results.
2077 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
2079 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
2081 Rubber-stamped by Tim Horton.
2083 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
2084 since each platform may have a different number of tests to be shown on the dashboard.
2086 * public/index.html:
2088 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
2090 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
2092 * public/js/helper-classes.js:
2095 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
2097 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
2099 Rubber-stamped by Tim Horton.
2101 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
2103 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
2104 the revision r1234 was the revision used in the previous build.
2106 * public/api/runs.php:
2107 (parse_revisions_array): Trim double quotations around repository names and revisions.
2108 * public/js/helper-classes.js:
2111 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
2113 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
2115 Rubber-stamped by Tim Horton.
2117 * public/index.html:
2118 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
2119 on the dashboard page as it's way too noisy.
2121 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
2123 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
2124 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
2125 so that the tooltip for hover can be reused further.
2127 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
2128 and find the first point that lies on the right of the cursor position. We then compute the midpoint
2129 between this and the previous point and pick the closer of the two. It returns an item-like object
2130 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
2132 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
2134 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
2135 the first or "current" data points (as opposed to target or baseline data points).
2137 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
2138 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
2139 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
2141 * public/js/helper-classes.js:
2142 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this
2143 work to the client via bindClick.
2145 (Tooltip.show): Move tooltip up by 5px. Also added a FIXME to move this offset computation to the client.
2147 (Tooltip.bindClick): Added.
2149 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
2151 Yet another build fix. metricId*s*.
2153 * public/admin/tests.php:
2155 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
2157 Another build fix. Use the new payload format for the aggregate job.
2159 * public/admin/tests.php:
2161 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
2165 * database/aggregate.js: Use variables that actually exist.
2166 * database/database-common.js:
2167 (ensureConfigurationIdFromList): Add the newly added configuration to the list so that subsequent
2168 function calls will find this configuration.
2170 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
2172 <rdar://problem/13130139> SafariPerfMonitor: Add ReadMe
2174 Reviewed by Ricky Mondello.
2176 Turned InstallManual into a proper markdown document and added ReadMe.md.
2178 * InstallManual: Removed.
2179 * InstallManual.md: Moved from InstallManual.
2182 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
2184 <rdar://problem/13109335> SafariPerfMonitor: Add baseline and target lines
2186 Reviewed by Ricky Mondello.
2188 This patch prepares the front end code to process baseline and target results properly.
2190 * public/index.html:
2191 (fetchTest.createRunAndResults): Extracted.
2192 (fetchTest): Call createRunAndResults on current, baseline, and target values of the JSON.
2193 Deleted the comment about how sorting will be unnecessary once we start results in the server side
2194 since sorting by the maximum revision commit time turned out to be non-trivial in php.
2196 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
2198 <rdar://problem/13057071> SafariPerfMonitor: Use newer version of flot that supports timezone properly
2200 Reviewed by Tim Horton.
2202 Use flot at https://github.com/flot/flot/commit/ec168da2cb8619ebf59c7e721d12c44a7960ff41.
2203 These files are "dynamically linked" to our app.
2205 * public/index.html:
2206 * public/js/jquery-1.8.2.min.js: Removed.
2207 * public/js/jquery.colorhelpers.js: Added.
2208 * public/js/jquery.flot.categories.js: Added.
2209 * public/js/jquery.flot.crosshair.js: Added.
2210 * public/js/jquery.flot.errorbars.js: Added.
2211 * public/js/jquery.flot.fillbetween.js: Added.
2212 * public/js/jquery.flot.js: Added.
2213 * public/js/jquery.flot.min.js: Removed.
2214 * public/js/jquery.flot.navigate.js: Added.
2215 * public/js/jquery.flot.resize.js: Added.
2216 * public/js/jquery.flot.selection.js: Added.
2217 * public/js/jquery.flot.stack.js: Added.
2218 * public/js/jquery.flot.symbol.js: Added.
2219 * public/js/jquery.flot.threshold.js: Added.
2220 * public/js/jquery.flot.time.js: Added.
2221 * public/js/jquery.js: Added.
2223 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
2225 Return NaN instead of throwing when there aren't enough samples.
2227 Reviewed by Sam Weinig.
2229 It's better to return NaN when we don't have enough samples so that we can treat it
2230 as if we don't have any confidence interval.
2232 * public/js/statistics.js:
2235 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
2237 Build fix. Apparently Safari sometimes appends / at the end of hash location. Remove that.
2239 * public/js/helper-classes.js:
2240 (URLState.parseIfNeeded):
2242 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
2244 <rdar://problem/13081582> SafariPerfMonitor: Always use parameterized SQL functions in php code
2246 Reviewed by Ricky Mondello.
2248 Parameterized execute_query_and_expect_one_row_to_be_affected and updated the code accordingly.
2250 * public/admin/aggregators.php: Use heredoc.
2251 * public/admin/builders.php:
2252 * public/admin/jobs.php:
2253 * public/admin/repositories.php:
2254 * public/admin/tests.php: Updated the forms to use unprefixed field names to match other pages.
2255 This allows us to use update_field when updating test's url and metric's unit. Changed the action
2256 to regenerate aggregated matrix from "update" to "add" to simplify the dependencies in if-else.
2257 Also removed a stray code to update unit and url simultaneously since it's never used.
2258 * public/include/admin-header.php:
2259 (execute_query_and_expect_one_row_to_be_affected): Added $params. Also automatically convert
2260 empty strings to NULL as it was previously done via $db->quote_string_or_null_if_empty in callers.
2261 (update_field): Moved from repositories.php.
2263 * public/include/db.php:
2264 (quote_string_or_null_if_empty): Removed now that nobody uses this function.
2266 2013-01-25 Ryosuke Niwa <rniwa@webkit.org>
2268 Build fixes. Treat mean, sum, and square sum as float, not int.
2270 Also use 95% confidence interval instead of 90% confidence interval.
2272 * public/api/runs.php:
2273 * public/js/helper-classes.js:
2274 (.this.confidenceIntervalDelta):
2276 2013-01-24 Ryosuke Niwa <rniwa@webkit.org>
2278 Add an administrative page to edit repository information.
2280 Reviewed by Ricky Mondello.
2282 * public/admin/repositories.php: Added.
2283 * public/include/admin-header.php:
2285 2013-01-23 Ryosuke Niwa <rniwa@webkit.org>
2287 <rdar://problem/13067539> SafariPerfMonitor: Automatically create aggregated metrics from builder reports
2289 Reviewed by Ricky Mondello.
2291 Auto-create aggregated matrix such as arithmetic means and geometric means as requested and add a job
2292 to aggregate results for those matrix in populate-from-report.js.
2294 * database/generate-manifest.js:
2295 (.): Include aggregator names such as Arithmetic and Geometric in the list of metrics.
2296 * database/init-database.sql: Remove an erroneous unique constraint. There could be multiple matrix that share
2297 the same test and name (e.g. Dromaeo, Time) with different aggregators (e.g. Arithmetic and Geometric).
2298 * database/populate-from-report.js:
2300 (getReport): No change even though the diff looks as if it moved.
2301 (processReport): Extracted from main. Fetch the list of aggregators, pass that to recursivelyEnsureTestsIdsAndMetricsIds
2302 to obtain the list of aggregated metrics (such as arithmetic means) that need to be passed to aggregate.js
2303 (scheduleJobs): Extracted from processReport. Add a job to aggregate results.
2304 (recursivelyEnsureTestsIdsAndMetricsIds): When a metric is a list of names, assume them as aggregator names,
2305 and add corresponding metrics for them. Note we convert those names to ids using the dictionary we obtained
2307 (ensureMetricId): Take an aggregator id as an argument.
2308 * database/process-jobs.js: Support multiple metric ids and build id. Note that aggregate.js aggregates results
2309 for all builds when the build id is not specified.
2310 * public/admin/tests.php:
2311 * public/index.html: Include the aggregator name in the full name since there could be multiple metrics
2312 of the same name with different aggregators.
2314 2013-01-22 Ryosuke Niwa <rniwa@webkit.org>
2316 Build fix. Don't pass in arguments to in the wrong order.
2318 * database/aggregate.js:
2320 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
2322 <rdar://problem/13057110> SafariPerfMonitor: x-axis is messed up
2324 Reviewed by Ricky Mondello.
2326 Since the version of flot we use doesn't support showing graphs in the current locate or
2327 in a specific timezone, convert all timestamps to PST manually (Date's constructor will still
2328 treat them as in UTC). We don't want to use the current locate because other websites on
2329 webkit.org assume PST.
2331 Also append this information to build's label.
2333 * public/js/helper-classes.js:
2337 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
2339 Store test URLs reported by builders.
2341 Reviewed by Ricky Mondello.
2343 * database/populate-from-report.js:
2344 (recursivelyEnsureTestsIdsAndMetricsIds): Pass in the test url.
2345 (ensureTestId): Store the URL.
2347 2013-01-20 Ryosuke Niwa <rniwa@webkit.org>
2349 Yet another build fix; don't blow up even if we didn't have any test configurations.
2351 * public/admin/tests.php:
2353 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
2355 Build fix; don't instantiate Date when a timestamp wasn't provided.
2357 * database/populate-from-report.js:
2359 2013-01-18 Ryosuke Niwa <rniwa@webkit.org>
2361 Rename SafariPerfDashboard to SafariPerfMonitor and add a install manual.
2363 Reviewed by Tim Horton.
2365 Added an install manual.
2367 * InstallManual: Added.
2369 2012-12-21 Ryosuke Niwa <rniwa@webkit.org>
2371 Minor build fix. Don't unset builderPassword when it's not set.
2373 * public/api/report.php:
2375 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2377 Prettify JSON payloads and make very large payloads not explode the table in jobs.php.
2379 Reviewed by Ricky Mondello.
2381 * public/admin/admin.css: Make a very large payload scrollable.
2382 * public/admin/jobs.php: Format JSONs.
2384 2012-12-19 Ryosuke Niwa <rniwa@webkit.org>
2386 <rdar://problem/12897424> SafariPerfMonitor: Add ability to report results from bots
2388 Reviewed by Ricky Mondello.
2390 Add report.php and populate-from-report.js that process JSON files submitted by builders.
2392 * database/populate-from-report.js: Added.
2394 (getReport): Obtains the payload (the actual report) from "jobs" table.
2395 (recursivelyEnsureTestsIdsAndMetricsIds): "reports.tests" contain a tree of tests, test metrics,
2396 and their results. This function recursively traverses tests and metrics and ensure their ids.
2398 (metricToUnit): Maps a metric name to a unit. This should really be done in the client side since
2399 there is no point in storing unit given that every metric maps to exactly one unit (i.e. the mapping
2400 is a "function" in mathematical sense).
2402 (ensureRepositoryIdsForAllRevisions):
2403 (getIdOrCreateBuildWithRevisions):
2404 (ensureBuildIdAndRevisions): Obtains a build id given a builder name, a build number, and a build time
2405 if one already exists. If not, then inserts a new build and corresponding revisions information (e.g.
2406 build 123 may contain WebKit revision r456789). We don't retrieve rows for revisions since we don't use
2408 (insertRun): Insert new rows into "test_runs" and "run_iterations" tables, thereby recording the new
2409 test results all in a single transaction. This allows us to keep the database consistent in that either
2410 a build has been reported or not at least in "test_runs" and "run_iterations" tables. It'll be ideal if
2411 we could do the same for "builds" and "build_revisions" but that's not a hard requirement as far as
2412 other parts of the application are concerned.
2413 (scheduleQueriesToInsertRun):
2414 * database/process-jobs.js: Add a call to populate-from-report.js.
2415 * public/api/report.php: Added. Adds a new job named "report" to be processed by populate-from-report.js.
2416 * public/include/db.php: Support parameterized query.
2417 * public/include/json-header.php: Always include 'status' in the response so that builder submitting
2418 a test result could confirm that the submission indeed succeeded.
2420 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2422 Rename get(Id)OrCreate*(Id) to ensure*Id as suggested by Ricky on one of his code reviews.
2424 * database/aggregate.js:
2425 * database/database-common.js:
2426 (selectColumnCreatingRowIfNeeded):
2427 (ensureRepositoryId):
2428 (ensureConfigurationIdFromList):
2429 * database/perf-webkit-migrator.js:
2432 (getOrCreateBuildId):
2434 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
2436 Extract commonly-used functions from aggregate.js and perf-webkit-migrator.js.
2438 Reviewed by Ricky Mondello.
2440 As a preparation to add report.js that processes a JSON file submitted by bots, extract various functions
2441 and classes from aggregate.js and perf-webkit-migrator.js to be shared.
2443 * database/aggregate.js: Extracted TaskQueue and SerializedTaskQueue into utility.js.
2446 (saveAggregatedResults):
2447 * database/database-common.js:
2448 (getIdOrCreatePlatform): Extracted from webkit-perf-migrator.js.
2449 (getIdOrCreateRepository): Ditto.
2450 (getConfigurationsForPlatformAndMetrics): Renamed from fetchConfigurations. Extracted from aggregator.js.
2451 (getIdFromListOrInsertConfiguration): Renamed from getOrInsertConfiguration. Extracted from aggregator.js.
2452 * database/perf-webkit-migrator.js:
2453 * database/utility.js: Added.
2454 (TaskQueue): Extracted from aggregator.js. Fixed a bug that prevented tasks added after start() is called
2455 from being executed.
2456 (TaskQueue.startTasksInQueue): Execute remaining tasks without serializing them. If the queue is empty,
2457 call the callback passed into start().
2458 (TaskQueue.taskCallback): The function each task calls back. Decrement the counter and call statTasksInQueue.
2459 (TaskQueue.addTask):
2461 (SerializedTaskQueue): Unlike TaskQueue, this class executes each task sequentially.
2462 (SerializedTaskQueue.executeNextTask):
2463 (SerializedTaskQueue.addTask):
2464 (SerializedTaskQueue.start):
2466 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2468 Revert erroneously committed changes.
2470 * database/config.json:
2472 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2474 aggregator.js should be able to accept multiple metric ids and a single build id.
2476 Reviewed by Ricky Mondello.
2478 Make aggregator.js accept multiple ids and generate results for single build when bots are
2479 reporting new results.
2481 * database/aggregate.js:
2482 (parseArgv): Added. Returns an object containing the parsed representation of argv,
2483 which currently contains metricIDs and buildIds.
2484 (main): Use parseArgv and processConfigurations
2485 (processPlatform): Use build ids passed in or obtain all builds for the given platform.
2486 (processPlatform.processConfigurations): Extracted.
2488 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
2490 Add an administrative page for builders.
2492 Reviewed by Ricky Mondello.
2494 We need an administrative page to add and edit builder information.
2495 Also renamed "slaves" to "builders" in order to reduce the amount of technical jargon we use.
2497 * database/init-database.sql: Renamed slaves table to builders. Drop slave_os and slave_spec
2498 since we don't have plans to use those columns in near future. Also make builder_name unique
2499 as required by the rest of the app.
2500 * public/admin/builders.php: Added.
2501 * public/api/runs.php: Updated per the table rename.
2502 * public/include/admin-header.php: Added a link to builders.php.
2504 2012-12-14 Ryosuke Niwa <rniwa@webkit.org>
2506 Build fixes for r46982.
2508 * database/aggregate.js:
2509 (fetchConfigurations): Bind i so that it's not always metricIds.length.
2510 (fetchBuildsForPlatform): Return run_build as build_id since that's what caller expects.
2511 (processBuild): Don't print "." until we've committed transactions. It's misleading.
2513 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
2515 Unreviewed. Move some php files to public/include as suggested by Mark on a code review.
2517 * public/admin/aggregators.php:
2518 * public/admin/footer.php: Removed.
2519 * public/admin/header.php: Removed.
2520 * public/admin/index.php:
2521 * public/admin/jobs.php:
2522 * public/admin/tests.php:
2523 * public/api/json-header.php: Removed.
2524 * public/api/runs.php:
2525 * public/db.php: Removed.
2526 * public/include: Added.
2527 * public/include/admin-footer.php: Copied from public/admin/footer.php.
2528 * public/include/admin-header.php: Copied from public/admin/header.php.
2529 * public/include/db.php: Copied from public/db.php.
2530 * public/include/json-header.php: Copied from public/api/json-header.php.
2532 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
2534 <rdar://problem/12822613> SafariPerfMonitor: implement naive value aggregation mechanism
2536 Reviewed by Ricky Mondello.
2538 Added the initial implementation of value aggregation.
2539 Also added abilities to configure the dashboard page in tests.php.
2541 * database/aggregate.js: Added.
2542 (TaskQueue): Added. Execute all tasks at once and waits for those tasks to complete.
2543 (TaskQueue.addTask):
2545 (SerializedTaskQueue): Added. Execute tasks sequentially after one another until all of them are completed.
2546 (SerializedTaskQueue.addTask):
2547 (SerializedTaskQueue.start):
2550 (fetchConfigurations):
2551 (fetchBuildsForPlatform):
2553 (testsWithDifferentIterationCounts):
2554 (aggregateIterationsForMetric): Retrieve run_iterations and aggregate results in memory.
2555 (saveAggregatedResults): Insert into test_runs and test_config in transactions.
2556 (getOrInsertConfiguration):
2558 * database/database-common.js:
2559 (fetchTable): Log an error as an error.
2560 (getOrCreateId): Extracted from perf-webkit-migrator.
2561 (statistics): Added.
2562 * database/perf-webkit-migrator.js:
2563 (migrateTestConfig): Converted units to respective metric names. Also removed the code to add jobs to update
2564 runs JSON since runs JSONs are generated on demand now.
2566 (getOrCreatePlatformId):
2567 (getOrCreateTestId):
2568 (getOrCreateConfigurationId):
2569 (getOrCreateRevisionId):
2570 (getOrCreateRepositoryId):
2571 (getOrCreateBuildId):
2572 * database/process-jobs.js:
2573 (processJob): Handle 'aggregate' type.
2575 2012-12-11 Ryosuke Niwa <rniwa@webkit.org>
2577 Fix the dashboard after adding test_metrics.
2579 Reviewed by Ricky Mondello.
2581 Rename test to metrics in various functions and sort tests on the charts page.
2582 Also representing whether a test appears or not by setting a flag on dashboard
2583 was bogus because test objects are shared by multiple platforms. Instead, store
2584 dashboard platform list as intended by the manifest JSON.
2586 * public/index.html:
2587 (PerfTestRuns): Renamed test to metric.
2589 (showCharts): Ditto; also sort metrics' full names before adding them to the select element.
2590 (fullName): Moved so that it appears above where it's called.
2591 * public/js/helper-classes.js:
2593 2012-12-10 Ryosuke Niwa <rniwa@webkit.org>
2595 Update tests.php to reflect recent changes in the database schema.
2597 Reviewed by Conrad Shultz.
2599 Made the following changes to tests.php:
2600 1. Disallow adding metrics to tests without subtests.
2601 2. Made dashboard configurable by adding checkboxes for each platform on each metric.
2602 3. Linkified tests with subtests instead of showing all them at once.
2604 * public/admin/admin.css:
2605 (.action-field, .notice):
2607 * public/admin/header.php: Specify paths by absolute paths so that tests.php can use PATH_INFO.
2608 (execute_query_and_expect_one_row_to_be_affected): Return a boolean. Used in tests.php while adding test_metrics.
2609 (add_job): Extracted.
2610 * public/admin/tests.php: See above.
2611 (array_item_set_default): Added.
2612 (array_item_or_default): Renamed from get_value_with_default.
2613 (compute_full_name): Extracted.
2614 (sort_tests): Ditto.
2615 (map_metrics_to_tests): Ditto.
2617 2012-12-06 Ryosuke Niwa <rniwa@webkit.org>
2619 <rdar://problem/12832324> SafariPerfMonitor: Linkify test names
2621 Reviewed by Simon Fraser.
2623 Linkify the headers using metric.test.url when it's provided.
2625 * public/index.html:
2627 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2629 Use parameterized pg_query_params in query_and_fetch_all
2631 Reviewed by Conrad Shultz.
2633 Address a review comment by Mark by using pg_query_params instead of pg_query in query_and_fetch_all.
2635 * public/api/runs.php:
2637 (ctype_alnum_underscore): Added.
2639 2012-12-04 Ryosuke Niwa <rniwa@webkit.org>
2641 Update the migration tool to support test_metrics.
2643 Reviewed by Mark Rowe.
2645 Updated the migration tool from webkit-perf.appspot.com to support test_metrics.
2646 Also import run_iteration rows as runs JSON files now include individual values.
2648 * database/database-common.js:
2649 (addJob): Extracted.
2650 * database/perf-webkit-migrator.js:
2651 (migrateTestConfig): Interchange the order in which we fetch runs and add configurations
2652 so that we can pass in the metric name and unit to getOrCreateConfigurationId.
2653 (getOrCreateConfigurationId): Updated to add both test configuration and test metric.
2656 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2658 Build fix. Suppress "Undefined index" warning.
2660 * public/admin/tests.php:
2662 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2664 Fix a commit error in r46756. api/ should obviously be added under public/
2667 * api/json-header.php: Removed.
2668 * api/runs.php: Removed.
2669 * public/api: Copied from api.
2671 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2673 SafariPerfMonitor: Linkify revisions and revisions range
2674 <rdar://problem/12801010>
2676 Reviewed by Mark Rowe.
2678 Linkify revisions in TestBuild.label. Pass in manifest.repositories to TestBuild's constructor
2679 since it needs to know "url" and "blameUrl".
2681 Also tweaked the appearance of graphs on charts page to better align graphs when unit names are long.
2683 * public/index.html:
2684 * public/js/helper-classes.js:
2686 (TestBuild.revision): Renamed from webkitRevision. Now returns an arbitrary revision number.
2687 (TestBuild.label): Add labels for all revisions.
2691 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2693 Make the generation of "runs" JSON dynamic and support test_metrics.
2695 Reviewed by Mark Rowe.
2697 It turned out that we can fetch all runs for a given configuration in roughly 100-200ms.
2699 Since there could be hundreds, if not thousands, of tests for each configuration and users
2700 aren't necessarily interested in looking at all test results, it's much more efficient to
2701 generate runs JSON dynamically (i.e. polling) upon a request instead of generating all of them
2702 when bots report new results (i.e. pushing).
2704 Rewrote the script to generate runs JSON in php and also supported test_metrics table.
2707 * api/json-header.php: Added. Sets Content-Type and cache policies (10 minutes by default).
2708 (exit_with_error): Added.
2709 (successful_exit): Added.
2710 * api/runs.php: Added. Ported database/database-common.js. It's much shorter in php!
2711 * database/generate-runs.js: Removed.
2712 * database/process-jobs.js: No longer supports "runs".
2713 * public/.htaccess: Added. Always add MultiView so that api/runs can receive a path info.
2714 * public/db.php: Print "Nothing to see here." when it's accessed directly.
2716 * public/index.html: Fetch runs JSONs from /api/runs/ instead of data/.
2718 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2720 Update tests.php and sample-data.sql per addition of test_metrics.
2722 Rubber-stamped by Timothy Hatcher.
2724 Remove a useless code from tests.php that used to update the unit and the url of a test
2725 since it's no longer used, and add the UI and the ability to add a new aggregator to a test.
2727 Also update the sample data to reflect the addition of test_metrics.
2729 * database/sample-data.sql:
2730 * public/admin/tests.php:
2732 2012-11-30 Ryosuke Niwa <rniwa@webkit.org>
2734 Share more code between admin pages.
2736 Reviewed by Timothy Hatcher.
2738 Added notice and execute_query_and_expect_one_row_to_be_affected helper functions to share more code
2739 between admin pages.
2741 Also moved the code to connect to the database into header.php to be shared. Admin pages just need
2742 to check the nullity of global $db now.
2744 * public/admin/aggregators.php:
2745 * public/admin/header.php:
2747 (execute_query_and_expect_one_row_to_be_affected): Added.
2748 * public/admin/index.php:
2749 * public/admin/jobs.php:
2750 * public/admin/tests.php:
2752 2012-11-29 Ryosuke Niwa <rniwa@webkit.org>
2754 SafariPerfMonitor: Add admin page to edit aggregators
2755 <rdar://problem/12782687>
2757 Reviewed by Mark Rowe.
2759 Add aggregators.php. It's very simple. We should probably share more code between various admin pages.
2761 * public/admin/aggregators.php: Added.
2762 * public/admin/header.php:
2763 * public/admin/jobs.php: Removed an erroneous hidden input element.
2765 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
2767 Fix a syntax error in init-database.sql and add the missing drop table at the beginning.
2769 * database/init-database.sql:
2771 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
2773 SafariPerfMonitor: Allow multiple metrics per test
2774 <rdar://problem/12773506>
2776 Rubber-stamped by Mark Rowe.
2778 Introduce a new table test_metrics. This table represents metrics each test can have
2779 such as time, memory allocation, frame rate as well as aggregation such as arithmetic mean
2782 Updated admin/tests.php and index.html accordingly.
2784 Also create few indexes based on postgres' "explain analysis" as suggested by Mark.
2786 * database/generate-manifest.js:
2787 (buildPlatformMapIfPossible):
2788 * database/generate-runs.js:
2790 * database/init-database.sql:
2791 * database/schema.graffle:
2792 * public/admin/admin.css:
2795 * public/admin/tests.php:
2796 * public/index.html:
2798 2012-11-27 Ryosuke Niwa <rniwa@webkit.org>
2800 SafariPerfMonitor: Improve the webkit-perf migration tool
2801 <rdar://problem/12760882>
2803 Reviewed by Mark Rowe.
2805 Make the migrator tool skip runs when fetching runs failed since webkit-perf.appspot.com is unreliable
2806 and we don't want to pause the whole importation process until the user comes back to decide whether
2809 Also place form controls next to each test in tests.php so that users don't have to scroll all the way
2810 down to make modifications.
2812 Finally, add unique constraint to (run_config, run_build) in test_runs table in order to optimize a query
2813 of the form: "SELECT run_id FROM test_runs WHERE run_config = $1 AND run_build = $2",
2815 * database/init-database.sql:
2816 * database/perf-webkit-migrator.js:
2817 (migrateTestConfig):
2818 * database/schema.graffle:
2819 * public/admin/admin.css:
2821 * public/admin/tests.php:
2823 2012-11-16 Ryosuke Niwa <rniwa@webkit.org>
2825 Create a new performance dashboard
2826 <rdar://problem/12625582>
2828 Rubber-stamped by Mark Rowe.
2830 Add the initial implementation of the perf dashboard.
2833 * database/config.json: Added.
2834 * database/database-common.js: Added.
2839 (pathToLocalScript):
2841 * database/generate-manifest.js: Added.
2844 (buildPlatformMapIfPossible):
2845 (generateFileIfPossible):
2846 * database/perf-webkit-migrator.js: Added.
2847 * database/process-jobs.js: Added.
2848 * database/sample-data.sql: Added.
2849 * database/schema.graffle: Added.
2851 * public/admin: Added.
2852 * public/admin/README: Added.
2853 * public/admin/admin.css: Added.
2854 * public/admin/footer.php: Added.
2855 * public/admin/header.php: Added.
2856 * public/admin/index.php: Added.
2857 * public/admin/jobs.php: Added.
2858 * public/admin/tests.php: Added.
2859 * public/common.css: Added.
2860 * public/data: Added.
2861 * public/db.php: Added.
2862 * public/index.html: Added.
2864 * public/js/helper-classes.js: Added.
2865 * public/js/jquery-1.8.2.min.js: Added.
2866 * public/js/jquery.flot.min.js: Added.
2867 * public/js/jquery.flot.plugins.js: Added.
2868 * public/js/shared.js: Added.
2869 (fileNameFromPlatformAndTest):
2870 * public/js/statistics.js: Added.