Clean up ChunkedUpdateDrawingAreaProxy
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-12-16  Antonio Gomes  <agomes@rim.com>
2
3         Reviewed by Martin Robinson.
4
5         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
6         https://bugs.webkit.org/show_bug.cgi?id=51163
7
8         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
9         GTK+'s DRT should also reset to UNIX after each test execution.
10
11         * DumpRenderTree/gtk/DumpRenderTree.cpp:
12         (resetDefaultsToConsistentValues):
13
14 2010-12-17  David Levin  <levin@chromium.org>
15
16         Reviewed by Eric Seidel.
17
18         check-webkit-style should understand WTF #include guards
19         https://bugs.webkit.org/show_bug.cgi?id=44911
20
21         * Scripts/webkitpy/style/checkers/cpp.py:
22         (get_header_guard_cpp_variable): modify to suggest the WTF style
23         of header guard when appropriate.
24         (check_for_header_guard): handle multiple return values from
25         get_header_guard_cpp_variable
26         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
27         (CppStyleTest.test_build_header_guard): Added tests for the WTF
28         header style.
29
30 2010-12-16  David Levin  <levin@chromium.org>
31
32         Reviewed by Eric Seidel.
33
34         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
35         https://bugs.webkit.org/show_bug.cgi?id=51210
36
37         The error only shows up when using python 2.6 or later.
38
39         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
40         the decprecated field error,message with something equivalent.
41
42 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
43
44         Reviewed by Eric Seidel.
45
46         Add --exit-after-n-failures/crashes to NRWT
47         https://bugs.webkit.org/show_bug.cgi?id=51160
48         
49         Abort test run (in a similar way to how control-C is handled) when
50         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
51         that number of unexpected failures/crashes/timeouts.
52
53         * Scripts/webkitpy/layout_tests/port/test.py:
54         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
55         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
56
57 2010-12-16  David Levin  <levin@chromium.org>
58
59         Reviewed by Shinichiro Hamaji.
60
61         check-webkit-style unit tests has some duplicate boilerplate code.
62         https://bugs.webkit.org/show_bug.cgi?id=49519
63
64         * Scripts/webkitpy/style/checkers/cpp.py:
65         (update_include_state): Replaced the "io" parameter with the global
66         configuration _unit_test_config. This allowed not calling into
67         functions at a low level and also not plumbing through the injection
68         information through many levels of code.
69         (check_for_include_what_you_use): Ditto.
70         (process_file_data): Added the ability to set up the unit test config
71         to allow for injection.
72         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
73         (ErrorCollector.__init__): Added support for having a filter for errors.
74         (ErrorCollector.__call__): Ditto.
75         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
76         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
77         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
78         functions in the cpp.py with generic processing and a filter that
79         indicates what errors should be kept.
80         (CppStyleTestBase.perform_multi_line_lint): Ditto.
81         (CppStyleTestBase.perform_language_rules_check): Ditto.
82         (CppStyleTestBase.perform_function_lengths_check): Ditto.
83         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
84         (CppStyleTestBase.perform_include_what_you_use): Ditto.
85         (CppStyleTest.test_multi_line_comments): Added another
86         error message which applies to the test case.
87         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
88         to not have config.h, since it is processed as a header file.
89         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
90         style and indentation in checked code.
91         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
92         Fixed line number.
93         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
94         Ditto.
95
96 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
97
98         Unreviewed, rolling out r74136.
99         http://trac.webkit.org/changeset/74136
100         https://bugs.webkit.org/show_bug.cgi?id=51135
101
102         r74136 breaks chromium canary bots because some tests are not
103         rebaselined correctly to resolve EOL differences (Requested by
104         jianli on #webkit).
105
106         * Scripts/webkitpy/layout_tests/port/base.py:
107         * Scripts/webkitpy/layout_tests/port/test.py:
108         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
109
110 2010-12-15  Adam Roben  <aroben@apple.com>
111
112         Teach check-webkit-style to check .vcproj and .vsprops files for XML
113         syntax errors
114
115         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
116         XML syntax errors in .vcproj/.vsprops files
117
118         Reviewed by Dave Levin.
119
120         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
121         that should be treated as XML and that should be allowed to contain
122         carriage returns. (These lists happen to be identical currently.)
123         (FileType): Added a new XML type.
124         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
125         Just does a simple file extension check.
126         (CheckerDispatcher._file_type): Added a case for XML files.
127         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
128         files (surprise!).
129         (StyleProcessor.process): Ask the dispatcher whether we should pass the
130         lines through the carriage checker.
131
132         * Scripts/webkitpy/style/checker_unittest.py:
133         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
134         Added. Checks a few file names to see if carriage returns are allowed
135         or not.
136         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
137         other assert_checker_* functions.
138         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
139         test_*_paths functions.
140         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
141         test_*_paths functions.
142         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
143         file from this test case, as vcproj files now have a type.
144         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
145         Added. Similar to the other should_* functions.
146         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
147         Added. Checks that carriage returns aren't checked for or stripped for
148         allowed files.
149
150         * Scripts/webkitpy/style/checkers/xml.py: Added.
151         (XMLChecker.__init__): Simple init method.
152         (XMLChecker.check): Pass each line through the expat parser, and record
153         a style error for any errors thrown by the parser.
154
155         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
156         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
157         produce a style error.
158         (XMLCheckerTest.assert_error): Checks that the given XML produces an
159         error of the given category on the given line.
160         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
161         checking that the XMLChecker constructor works properly.
162         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
163         cause a style error (see, e.g., r73887).
164         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
165         cause a style error (see, e.g., r73773).
166         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
167         properly.
168         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
169         tags cause a style error (see, e.g., r72795).
170         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
171         style error.
172
173 2010-12-15  Lucas Forschler  <lforschler@apple.com>
174
175         Reviewed by Stephanie Lewis.
176
177         https://bugs.webkit.org/show_bug.cgi?id=51117
178         Add a new leopard test bot
179         really really commit to trunk this time.
180
181         * BuildSlaveSupport/build.webkit.org-config/config.json:
182
183 2010-12-15  Sam Weinig  <sam@webkit.org>
184
185         Reviewed by Anders Carlsson.
186
187         WebKit2: Can't add files to an <input type=file>
188         https://bugs.webkit.org/show_bug.cgi?id=51087
189
190         * MiniBrowser/mac/BrowserWindowController.m:
191         (runOpenPanel):
192         (-[BrowserWindowController awakeFromNib]):
193         Add simple implementation of runOpenPanel callback.
194
195         * MiniBrowser/win/BrowserView.cpp:
196         (BrowserView::create):
197         * WebKitTestRunner/TestController.cpp:
198         (WTR::createOtherPage):
199         (WTR::TestController::initialize):
200         Stub out runOpenPanel callback. 
201
202 2010-12-14  Eric Seidel  <eric@webkit.org>
203
204         Reviewed by Adam Barth.
205
206         commit-queue should upload failure diffs when tests flake
207         https://bugs.webkit.org/show_bug.cgi?id=51051
208
209         To make this testable I needed to pipe FileSystem down onto tool.
210         We've wanted it there for a long time anyway.
211
212         This patch is kinda a big hack.  But we don't have a nice
213         way to read results.html files.  I think this will need further
214         revision before this code actually feels clean.
215
216         As part of testing this change, I had to make MockBugzilla.create_bug
217         actually return an id (like it should) which required updating
218         a few other unit test results (for the better).
219
220         The results_matching_keys change in layouttestresults/rebasline
221         was an alternate path which I decided not to use in the end, but
222         I left the change as it seemed an improvement.
223
224         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
225         * Scripts/webkitpy/common/net/layouttestresults.py:
226         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
227         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
228         * Scripts/webkitpy/tool/commands/queues.py:
229         * Scripts/webkitpy/tool/commands/rebaseline.py:
230         * Scripts/webkitpy/tool/main.py:
231         * Scripts/webkitpy/tool/mocktool.py:
232
233 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
234
235         Reviewed by James Robinson.
236
237         new-run-webkit-tests ignores trailing EOL differences in text tests
238         https://bugs.webkit.org/show_bug.cgi?id=36983
239
240         Changed the handling of new-line characters within new-run-webkit-tests
241         to match old-run-webkit-tests.  Differences in leading and trailing empty
242         lines in text expectation files are no longer ignored.
243
244         * Scripts/webkitpy/layout_tests/port/base.py:
245         * Scripts/webkitpy/layout_tests/port/test.py:
246         Added unit tests.  Removed old duplicate unit test entries.
247         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
248
249 2010-12-15  Ojan Vafai  <ojan@chromium.org>
250
251         Reviewed by Adam Barth.
252
253         make status-bubble white-space:nowrap so we can measure it's width without wrapping
254         https://bugs.webkit.org/show_bug.cgi?id=51149
255
256         * QueueStatusServer/templates/statusbubble.html:
257
258 2010-12-15  Ojan Vafai  <ojan@chromium.org>
259
260         Reviewed by Adam Barth.
261
262         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
263         https://bugs.webkit.org/show_bug.cgi?id=51125
264
265         * QueueStatusServer/templates/statusbubble.html:
266
267 2010-12-15  Darin Adler  <darin@apple.com>
268
269         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
270
271 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
272
273         Unreviewed, rolling out r74117.
274         http://trac.webkit.org/changeset/74117
275         https://bugs.webkit.org/show_bug.cgi?id=51113
276
277         This broke the GTK1 build. (Requested by mrobinson on
278         #webkit).
279
280         * Scripts/webkitdirs.pm:
281
282 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
283
284         Reviewed by Martin Robinson.
285
286         Change generate-forwarding-headers.pl for GTK port usage 
287         (https://bugs.webkit.org/show_bug.cgi?id=37369)
288
289         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
290
291 2010-12-14  Kent Tamura  <tkent@chromium.org>
292
293         Reviewed by Jian Li.
294
295         [DRT/Chromium] Remove another unnecessary error message
296         https://bugs.webkit.org/show_bug.cgi?id=51083
297
298         * DumpRenderTree/chromium/WebViewHost.cpp:
299         (WebViewHost::didInvalidateRect):
300
301 2010-12-14  Lucas Forschler  <lforschler@apple.com>
302
303         Reviewed by Stephanie Lewis.
304
305         Add a new Leopard Debug Test WK2 Bot
306
307         * BuildSlaveSupport/build.webkit.org-config/config.json:
308
309 2010-12-14  Ojan Vafai  <ojan@chromium.org>
310
311         Fix python unittests after http://trac.webkit.org/changeset/74070.
312
313         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
314
315 2010-12-14  Kent Tamura  <tkent@chromium.org>
316
317         Reviewed by Jian Li.
318
319         [DRT/Chromium] Remove a unnecessary error message
320         https://bugs.webkit.org/show_bug.cgi?id=51069
321
322         * DumpRenderTree/chromium/WebViewHost.cpp:
323         (WebViewHost::paintInvalidatedRegion):
324
325 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
326
327         Reviewed by Ojan Vafai.
328
329         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
330         https://bugs.webkit.org/show_bug.cgi?id=48926
331
332         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
333         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
334
335 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
336
337         Reviewed by Eric Seidel.
338
339         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
340         https://bugs.webkit.org/show_bug.cgi?id=50231
341
342         Guard CONFIG+=link_pkgconfig with !symbian.
343
344         * DumpRenderTree/qt/DumpRenderTree.pro:
345         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
346         * WebKitTestRunner/qt/WebKitTestRunner.pro:
347
348 2010-12-14  Philippe Normand  <pnormand@igalia.com>
349
350         Reviewed by Ojan Vafai.
351
352         [new-run-webkit-tests] expectations parsing is slow
353         https://bugs.webkit.org/show_bug.cgi?id=50635
354
355         Avoid expensive iteration of all the tests when checking if a test
356         file is to be skipped or not.
357
358         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
359         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
360         * Scripts/webkitpy/layout_tests/port/test.py:
361
362 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
363
364         Reviewed by Xan Lopez.
365
366         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
367         https://bugs.webkit.org/show_bug.cgi?id=27048
368
369         Add support in DRT for checking whether an accessibility UI
370         element is focusable and/or focused. Implemented for GTK.
371
372         * DumpRenderTree/AccessibilityUIElement.cpp:
373         (getIsFocusedCallback): New.
374         (getIsFocusableCallback): New.
375         (AccessibilityUIElement::getJSClass): Add the new available
376         callbacks for isFocused and isFocusable.
377         * DumpRenderTree/AccessibilityUIElement.h:
378         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
379         (AccessibilityUIElement::isFocused): New, implemented by checking
380         whether the related AtkState value is in the object's state set.
381         (AccessibilityUIElement::isFocusable): Ditto.
382         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
383         (AccessibilityUIElement::isFocused): New, dummy implementation.
384         (AccessibilityUIElement::isFocusable): Ditto.
385         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
386         (AccessibilityUIElement::isFocused): Ditto.
387         (AccessibilityUIElement::isFocusable): Ditto.
388
389 2010-12-14  Eric Seidel  <eric@webkit.org>
390
391         Reviewed by Ojan Vafai.
392
393         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
394         https://bugs.webkit.org/show_bug.cgi?id=50715
395
396         This patch makes webkit-patch print the following:
397
398         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
399         Install a 64-bit git for better performance, see:
400         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
401
402         I wrote this mostly because I have approximately 8 machines that I use
403         and making sure each one is using a good Git install seemed folly.
404         webkit-patch makes a lot of git calls, so using a fast git can shave
405         several seconds in every invocation.  See the webkit-dev thread for more info.
406
407         This message will print twice during 'webkit-patch upload',
408         once from webkit-patch and once from check-webkit-style.
409
410         Unfortunately there is no good way to test this due to how machine-dependent
411         the code is.  I considered writing a test for the log message, but it seemed not worth it.
412
413         * Scripts/webkitpy/common/checkout/scm.py:
414
415 2010-12-13  Eric Seidel  <eric@webkit.org>
416
417         Reviewed by Adam Barth.
418
419         FlakyTestReporter doesn't understand bots running from multiple email addresses
420         https://bugs.webkit.org/show_bug.cgi?id=50960
421
422         This explains at least one of the dupes of:
423         https://bugs.webkit.org/show_bug.cgi?id=50863
424         that we saw filed by the commit-queue this morning.
425         I think the other one was explained by my previous fix to result counting code.
426
427         Since this is really hard to test with a unit test, instead I
428         create a new (possibly useful in the future) command
429         which given a layout test path will return you
430         the one bug which our tools would assume it the flaky test bug.
431         If some other script wants to use bug-for-test we'll
432         need to extend it with some options like --create-if-missing or similar.
433
434         * Scripts/webkitpy/common/net/bugzilla/bug.py:
435         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
436         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
437         * Scripts/webkitpy/tool/commands/__init__.py:
438         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
439
440 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
441
442         Reviewed by James Robinson.
443
444         Add option to build-webkit to not build WebKit2
445         https://bugs.webkit.org/show_bug.cgi?id=50988
446         
447         Add support for a --no-webkit2 option to build-webkit. It seems to save
448         ~1 minute from clean builds and ~10 seconds from no-op builds.
449
450         * Scripts/build-webkit:
451
452 2010-12-13  Lucas Forschler  <lforschler@apple.com>
453
454         Reviewed by Dave Kilzer.
455
456         Update iexploder from 1.3.2 to 1.7.2
457         Move 1.3.2 into its own subdir
458         Add 1.7.2 into its own subdir
459         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
460
461         * Scripts/run-iexploder-tests:
462         * Scripts/update-iexploder-cssproperties:
463         * iExploder/CHANGELOG.txt: Removed.
464         * iExploder/LICENSE.txt: Removed.
465         * iExploder/README.txt: Removed.
466         * iExploder/htdocs: Removed.
467         * iExploder/iexploder-1.3.2: Added.
468         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
469         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
470         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
471         * iExploder/iexploder-1.3.2/htdocs: Added.
472         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
473         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
474         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
475         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
476         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
477         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
478         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
479         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
480         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
481         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
482         * iExploder/iexploder-1.3.2/tools: Added.
483         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
484         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
485         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
486         * iExploder/iexploder-1.7.2: Added.
487         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
488         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
489         * iExploder/iexploder-1.7.2/README.txt: Added.
490         * iExploder/iexploder-1.7.2/output: Added.
491         * iExploder/iexploder-1.7.2/src: Added.
492         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
493         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
494         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
495         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
496         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
497         * iExploder/iexploder-1.7.2/src/css-properties: Added.
498         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
499         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
500         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
501         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
502         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
503         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
504         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
505         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
506         * iExploder/iexploder-1.7.2/src/css-values: Added.
507         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
508         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
509         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
510         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
511         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
512         * iExploder/iexploder-1.7.2/src/headers: Added.
513         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
514         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
515         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
516         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
517         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
518         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
519         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
520         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
521         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
522         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
523         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
524         * iExploder/iexploder-1.7.2/src/html-tags: Added.
525         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
526         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
527         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
528         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
529         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
530         * iExploder/iexploder-1.7.2/src/html-values: Added.
531         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
532         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
533         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
534         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
535         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
536         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
537         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
538         * iExploder/iexploder-1.7.2/src/index.html: Added.
539         * iExploder/iexploder-1.7.2/src/media: Added.
540         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
541         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
542         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
543         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
544         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
545         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
546         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
547         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
548         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
549         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
550         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
551         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
552         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
553         * iExploder/iexploder-1.7.2/src/mime-types: Added.
554         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
555         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
556         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
557         * iExploder/iexploder-1.7.2/src/protocols: Added.
558         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
559         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
560         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
561         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
562         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
563         * iExploder/iexploder-1.7.2/src/version.rb: Added.
564         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
565         * iExploder/iexploder-1.7.2/testcases: Added.
566         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
567         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
568         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
569         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
570         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
571         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
572         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
573         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
574         * iExploder/iexploder-1.7.2/tools: Added.
575         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
576         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
577         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
578         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
579         * iExploder/tools: Removed.
580
581 2010-12-13  Sam Weinig  <sam@webkit.org>
582
583         Reviewed by Anders Carlsson.
584
585         Remove associated page concept from WKView constructor
586         https://bugs.webkit.org/show_bug.cgi?id=50983
587
588         Step 1: Remove associate page constructors from WKView and make
589         all views use the shared namespace for the context.
590
591         * TestWebKitAPI/PlatformWebView.h:
592         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
593         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
594         * WebKitTestRunner/PlatformWebView.h:
595         * WebKitTestRunner/TestController.cpp:
596         (WTR::createOtherPage):
597         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
598         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
599         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
600
601 2010-12-13  Sam Weinig  <sam@webkit.org>
602
603         Reviewed by Anders Carlsson.
604
605         Change the WebKit2 public API so there is no explicit WKPageNamespace object
606         https://bugs.webkit.org/show_bug.cgi?id=50898
607
608         * MiniBrowser/mac/AppDelegate.h:
609         * MiniBrowser/mac/AppDelegate.m:
610         * MiniBrowser/mac/BrowserWindowController.h:
611         * MiniBrowser/mac/BrowserWindowController.m:
612         * MiniBrowser/win/BrowserView.cpp:
613         Convert MiniBrowser to not use PageNamespaces.
614
615         * TestWebKitAPI/PlatformWebView.h:
616         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
617         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
618         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
619         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
620         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
621         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
622         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
623         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
624         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
625         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
626         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
627         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
628         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
629         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
630         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
631         Convert TestWebKitAPI to not use PageNamespaces.
632
633         * WebKitTestRunner/PlatformWebView.h:
634         * WebKitTestRunner/TestController.cpp:
635         * WebKitTestRunner/TestController.h:
636         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
637         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
638         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
639         Convert WebKitTestRunner to not use PageNamespaces.
640
641 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
642
643         Reviewed by Eric Seidel.
644
645         webkit-patch rollout should be able to do multi-revision rollouts
646         https://bugs.webkit.org/show_bug.cgi?id=33336
647
648         Make it possible to pass more than one revision to webkit-patch.
649
650         * Scripts/webkitpy/common/checkout/api.py:
651         * Scripts/webkitpy/common/checkout/changelog.py:
652         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
653         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
654         * Scripts/webkitpy/tool/commands/download.py:
655         * Scripts/webkitpy/tool/commands/download_unittest.py:
656         * Scripts/webkitpy/tool/mocktool.py:
657         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
658         * Scripts/webkitpy/tool/steps/revertrevision.py:
659
660 2010-12-13  Eric Seidel  <eric@webkit.org>
661
662         Unreviewed.
663
664         Teach webkit-patch how to search bugzilla
665         https://bugs.webkit.org/show_bug.cgi?id=50500
666
667         webkit-patch bug-search fails when there is only one result.
668         Turns out we needed a bit more logic in our result count parsing code.
669
670         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
671         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
672
673 2010-12-13  Antti Koivisto  <antti@apple.com>
674
675         Reviewed by Alexey Proskuryakov.
676
677         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
678         https://bugs.webkit.org/show_bug.cgi?id=50758
679
680         * DumpRenderTree/LayoutTestController.cpp:
681         (setSerializeHTTPLoadsCallback):
682         (LayoutTestController::staticFunctions):
683         * DumpRenderTree/LayoutTestController.h:
684         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
685         (LayoutTestController::setSerializeHTTPLoads):
686         * DumpRenderTree/mac/DumpRenderTree.mm:
687         (resetDefaultsToConsistentValues):
688         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
689         (LayoutTestController::setSerializeHTTPLoads):
690         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
691         (LayoutTestController::setSerializeHTTPLoads):
692
693 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
694
695         Reviewed by Ojan Vafai.
696
697         Remove "use-drt" option from test step command line, since the option was removed in r73748.
698         https://bugs.webkit.org/show_bug.cgi?id=50936
699
700         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
701
702 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
703
704         Reviewed by Csaba Osztrogonác.
705
706         Add revlink to BuildBot status
707         https://bugs.webkit.org/show_bug.cgi?id=50914
708
709         This adds a hyperlink to trac changeset on the revision numbers. 
710
711         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
712
713 2010-12-13  Andras Becsi  <abecsi@webkit.org>
714
715         Reviewed by Csaba Osztrogonác.
716
717         [Qt][WK2] Fix build if WebKitTools are not available
718         https://bugs.webkit.org/show_bug.cgi?id=50242
719
720         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
721         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
722         * MiniBrowser/DerivedSources.pro: Added.
723
724 2010-12-13  Eric Seidel  <eric@webkit.org>
725
726         Reviewed by Adam Barth.
727
728         EWS Queues should remove orpahned pyc files before starting
729         https://bugs.webkit.org/show_bug.cgi?id=50904
730
731         A previous check added a platform.py which caused
732         EWS bots on some platforms to hit an import exception.
733         The platform.py file was removed in a subsequent commit, but
734         the EWS bots in question stayed stuck.  This change will
735         fix those bots once restarted (and prevent this in the future).
736
737         I also went ahead and unified start-queue and start-commit-queue
738         since they were nearly identical.  I also added bot_id support
739         to both force all EWSes to have bot ids as well as get rid of the one
740         remaining reason why I had my own copies of these scripts.
741         Hopefully this will be enough to get all the other bot admins
742         (ahem, Adam, ahem) to move to using these checked in copies as well.
743
744         * EWSTools/start-commit-queue.sh: Removed.
745         * EWSTools/start-queue.sh:
746
747 2010-10-28  MORITA Hajime  <morrita@google.com>
748
749         Reviewed by Ojan Vafai.
750
751         spellcheck does not check pasted text
752         https://bugs.webkit.org/show_bug.cgi?id=40092
753
754         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
755         to control the setting.
756
757         * DumpRenderTree/LayoutTestController.cpp:
758         (setAsynchronousSpellCheckingEnabledCallback):
759         (LayoutTestController::staticFunctions):
760         * DumpRenderTree/LayoutTestController.h:
761         * DumpRenderTree/chromium/LayoutTestController.h:
762         * DumpRenderTree/chromium/LayoutTestController.cpp:
763         (LayoutTestController::LayoutTestController):
764         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
765         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
766         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
767         * DumpRenderTree/mac/DumpRenderTree.mm:
768         (resetDefaultsToConsistentValues):
769         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
770         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
771         * DumpRenderTree/qt/LayoutTestControllerQt.h:
772         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
773         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
774         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
775         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
776         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
777         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
778
779 2010-12-12  Sam Weinig  <sam@webkit.org>
780
781         Reviewed by Anders Carlsson.
782
783         Fix failing API test. It turns out that a pop-state event
784         is sent before every fragment navigation, so we have to test
785         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
786
787         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
788         (TestWebKitAPI::didSameDocumentNavigationForFrame):
789
790 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
791
792         Reviewed by Eric Seidel.
793
794         [GTK] Add new-run-webkit-tests support to gtk
795         https://bugs.webkit.org/show_bug.cgi?id=50681
796
797         Adding the basic support to run the new-run-webkit-tests.
798
799         * Scripts/webkitpy/layout_tests/port/gtk.py:
800
801 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
802
803         Reviewed by Kenneth Rohde Christiansen.
804
805         [Qt] Mock DeviceOrientation client for DRT
806         https://bugs.webkit.org/show_bug.cgi?id=47490
807
808         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
809         (WebCore::DumpRenderTree::DumpRenderTree):
810         (WebCore::DumpRenderTree::~DumpRenderTree):
811         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
812         (LayoutTestController::setMockDeviceOrientation):
813
814 2010-12-11  Philippe Normand  <pnormand@igalia.com>
815
816         Reviewed by Gustavo Noronha Silva.
817
818         [GTK] launcher: disable the Mozilla-style fullscreen API
819         https://bugs.webkit.org/show_bug.cgi?id=50874
820
821         Disabling the fullscreen API until its implementation for GTK is
822         mature enough. The webview setting for it is already FALSE by
823         default.
824
825         * GtkLauncher/main.c:
826         (createWindow):
827
828 2010-12-10  Eric Seidel  <eric@webkit.org>
829
830         Reviewed by Adam Barth.
831
832         commit-queue flaky test messages show cryptic version information for mac os x
833         https://bugs.webkit.org/show_bug.cgi?id=50864
834
835         Turns out platform.platform() returns kernel version information
836         which isn't helpful, and just plain confusing on Mac
837         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
838
839         So I've updated PlatformInfo.display_name() to special case
840         mac.  I also found a bad use of sys.platform in the process
841         and fixed that.  (sys.platform always returns 'darwin' on mac).
842
843         * Scripts/webkitpy/common/system/platforminfo.py:
844         * Scripts/webkitpy/common/system/user.py:
845         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
846         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
847         * Scripts/webkitpy/tool/commands/queues_unittest.py:
848
849 2010-12-10  Eric Seidel  <eric@webkit.org>
850
851         Unreviewed.
852
853         Exception seen while reporting flaky test with commit-queue.
854         Just a missing include.
855
856         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
857         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
858
859 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
860
861         Reviewed by Eric Seidel.
862
863         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
864         https://bugs.webkit.org/show_bug.cgi?id=50796
865
866         Also updating the test code to use JSONResultsGeneratorBase and
867         to improve test coverage for incremental cases.
868
869         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
870         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
871
872 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
873
874         Reviewed by Darin Adler.
875
876         prepare-ChangeLog --help doesn't mention --bug shorthand -b
877         https://bugs.webkit.org/show_bug.cgi?id=50835
878
879         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
880
881 2010-12-10  Eric Seidel  <eric@webkit.org>
882
883         Reviewed by Adam Barth.
884
885         Bugs created by the commit-queue should all block on a master bug
886         https://bugs.webkit.org/show_bug.cgi?id=50857
887
888         This makes all bugs created by the commit-queue block on:
889         https://bugs.webkit.org/show_bug.cgi?id=50856
890
891         In the process of testing this, I found that the existing
892         create_bug code was wrong.  I also found that existing
893         unit tests for create-rollout used invalid values
894         for options.blocks.  I fixed both issues and tested.
895
896         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
897         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
898         * Scripts/webkitpy/tool/commands/commandtest.py:
899         * Scripts/webkitpy/tool/commands/download_unittest.py:
900         * Scripts/webkitpy/tool/commands/upload_unittest.py:
901         * Scripts/webkitpy/tool/mocktool.py:
902         * Scripts/webkitpy/tool/steps/options.py:
903
904 2010-12-10  Eric Seidel  <eric@webkit.org>
905
906         Reviewed by Adam Barth.
907
908         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
909         https://bugs.webkit.org/show_bug.cgi?id=50853
910
911         I also discovered when doing this that the code was posting
912         the comment on the wrong bug, but that's fixed here too.
913
914         * Scripts/webkitpy/common/net/bugzilla/bug.py:
915         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
916         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
917         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
918         * Scripts/webkitpy/tool/commands/queues_unittest.py:
919         * Scripts/webkitpy/tool/mocktool.py:
920
921 2010-12-10  Anders Carlsson  <andersca@apple.com>
922
923         Reviewed by John Sullivan.
924
925         Make WKContextGetStatistics gather global statistics
926         https://bugs.webkit.org/show_bug.cgi?id=50850
927
928         Remove the code that gets the statistics and fills in the per context
929         statistics information for now.
930
931         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
932         (-[BrowserStatisticsWindowController refreshStatistics:]):
933
934 2010-12-10  Eric Seidel  <eric@webkit.org>
935
936         Unreviewed.
937
938         commit-queue should report port/platform information when commenting on flaky test bugs
939         https://bugs.webkit.org/show_bug.cgi?id=50839
940
941         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
942         which was only used by new run webkit tests (and clearly not unit tested).
943
944         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
945         * Scripts/webkitpy/tool/main.py:
946         * Scripts/webkitpy/tool/mocktool.py:
947
948 2010-12-10  Eric Seidel  <eric@webkit.org>
949
950         Reviewed by Tony Chang.
951
952         commit-queue should report port/platform information when commenting on flaky test bugs
953         https://bugs.webkit.org/show_bug.cgi?id=50839
954
955         This was a suggestion from Tony Chang this morning.
956         I added a platform.py class so I could easily mock the platform call,
957         but that may not be the final solution for this mocking.
958         We'll try it and see.
959
960         * Scripts/webkitpy/common/system/platform.py: Added.
961         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
962         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
963         * Scripts/webkitpy/tool/commands/queues_unittest.py:
964         * Scripts/webkitpy/tool/main.py:
965         * Scripts/webkitpy/tool/mocktool.py:
966
967 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
968
969         Reviewed by Joseph Pecoraro.
970
971         Bug 43455 - [Qt]: Implement Application Cache Quotas
972         https://bugs.webkit.org/show_bug.cgi?id=43455
973
974         Introduce functions to allow new appcache layout test origin-quota.html
975         to work correctly under Qt.
976
977         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
978         (WebCore::DumpRenderTree::DumpRenderTree):
979         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
980         * DumpRenderTree/qt/DumpRenderTreeQt.h:
981
982         Introduce functions to allow new appcache layout test origin-quota.html
983         to be successful under qt. Changes required because LayoutTestControllerQt
984         does not inherit from LayoutController.
985
986         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
987         (LayoutTestController::reset):
988         (LayoutTestController::clearAllApplicationCaches):
989         (LayoutTestController::setApplicationCacheOriginQuota):
990         * DumpRenderTree/qt/LayoutTestControllerQt.h:
991         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
992         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
993
994 2010-12-10  Eric Seidel  <eric@webkit.org>
995
996         Reviewed by Adam Barth.
997
998         Move buildbot.py into its own module so we can split it out into one-file-per-class
999         https://bugs.webkit.org/show_bug.cgi?id=50806
1000
1001         We're adding more buildbot logic these days, so it makes sense
1002         to give buildbot its own module.
1003
1004         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
1005         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
1006         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
1007         * Scripts/webkitpy/common/net/failuremap.py:
1008         * Scripts/webkitpy/common/net/regressionwindow.py:
1009         * Scripts/webkitpy/tool/commands/rebaseline.py:
1010
1011 2010-12-10  Tony Chang  <tony@chromium.org>
1012
1013         Reviewed by Eric Seidel.
1014
1015         Use FileSystem::remove when cleaning up http lock files
1016         https://bugs.webkit.org/show_bug.cgi?id=50830
1017
1018         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1019
1020 2010-12-10  Joone Hur  <joone@kldp.org>
1021
1022         Reviewed by Martin Robinson.
1023
1024         [GTK] DRT needs layoutTestController.setCacheModel
1025         https://bugs.webkit.org/show_bug.cgi?id=50705
1026         
1027         webkit_set_cache_mode() is called to set the cache model.
1028         
1029         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1030         (LayoutTestController::setCacheModel): Set the cache model. 
1031
1032 2010-12-10  Tony Chang  <tony@chromium.org>
1033
1034         Reviewed by Ojan Vafai.
1035
1036         [chromium] remove --use-drt and add --use-test-shell
1037         https://bugs.webkit.org/show_bug.cgi?id=50701
1038
1039         * Scripts/webkitpy/common/config/ports.py:
1040         * Scripts/webkitpy/common/config/ports_unittest.py:
1041         * Scripts/webkitpy/layout_tests/port/chromium.py:
1042         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1043         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1044         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1045         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1046         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1047         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1048         * Scripts/webkitpy/layout_tests/port/webkit.py:
1049         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1050         * Scripts/webkitpy/style/checkers/test_expectations.py:
1051         * Scripts/webkitpy/tool/commands/queries.py:
1052
1053 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
1054
1055         Reviewed by Steve Block.
1056
1057         [Chromium] Implement mocks for client-based geolocation
1058         https://bugs.webkit.org/show_bug.cgi?id=46895
1059
1060         * DumpRenderTree/chromium/LayoutTestController.cpp:
1061         (LayoutTestController::setGeolocationPermission):
1062         (LayoutTestController::setMockGeolocationPosition):
1063         (LayoutTestController::setMockGeolocationError):
1064         * DumpRenderTree/chromium/LayoutTestController.h:
1065         * DumpRenderTree/chromium/WebViewHost.cpp:
1066         (WebViewHost::geolocationClient):
1067         (WebViewHost::geolocationClientMock):
1068         (WebViewHost::reset):
1069         * DumpRenderTree/chromium/WebViewHost.h:
1070
1071 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
1072
1073         Reviewed by Martin Robinson.
1074
1075         [GTK] Add hasSpellingMarker support to the DRT
1076         https://bugs.webkit.org/show_bug.cgi?id=50739
1077
1078         Implemented the hasSpellingMarker to support spelling tests.
1079
1080         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1081         (LayoutTestController::hasSpellingMarker):
1082
1083 2010-12-10  Eric Seidel  <eric@webkit.org>
1084
1085         Reviewed by Ojan Vafai.
1086
1087         webkit-patch: not possible to use build-and-test with local commits
1088         https://bugs.webkit.org/show_bug.cgi?id=33378
1089
1090         Make --no-clean not even check if we have local commits.
1091         It's unclear to me why the code was originally written this way.
1092         I was unable to dig up a reason from svn history.
1093
1094         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1095         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1096
1097 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
1098
1099         Reviewed by Martin Robinson.
1100
1101         [GTK] AX: implement isEnabled in DRT
1102         https://bugs.webkit.org/show_bug.cgi?id=50814
1103
1104         Implement AccessibilityUIElement::isEnabled() for GTK.
1105
1106         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1107         (checkElementState): New function to refactor common code.
1108         (AccessibilityUIElement::isEnabled): Implement this by checking
1109         the current state of the AtkObject.
1110         (AccessibilityUIElement::isSelected): Use the new
1111         checkElementState function.
1112
1113 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1114
1115         Reviewed by Kenneth Rohde Christiansen.
1116
1117         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
1118         https://bugs.webkit.org/show_bug.cgi?id=50750
1119
1120         * MiniBrowser/qt/BrowserView.cpp:
1121         (BrowserView::BrowserView):
1122         * MiniBrowser/qt/BrowserView.h:
1123         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1124         (WTR::WebView::WebView):
1125
1126 2010-12-10  Joone Hur  <joone@kldp.org>
1127
1128         Reviewed by Xan Lopez.
1129
1130         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
1131         https://bugs.webkit.org/show_bug.cgi?id=50808
1132
1133         Unskipping the following test cases:
1134         userscripts/mixed-case-stylesheet.html
1135         userscripts/simple-stylesheet.html
1136         userscripts/user-style-all-frames.html
1137
1138         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1139         (LayoutTestController::addUserStyleSheet):
1140
1141 2010-12-10  Joone Hur  <joone@kldp.org>
1142
1143         Reviewed by Eric Seidel.
1144
1145         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
1146         https://bugs.webkit.org/show_bug.cgi?id=50783
1147
1148         This patch allows to unskip the following test cases:
1149         printing/page-rule-selection.html
1150         printing/page-format-data.html
1151
1152         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1153         (LayoutTestController::pageProperty): Added.
1154         (LayoutTestController::isPageBoxVisible): Ditto.
1155         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
1156         (LayoutTestController::addUserStyleSheet): Ditto.
1157
1158 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1159
1160         Reviewed by Kenneth Rohde Christiansen.
1161
1162         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
1163
1164         A menu allows to switch QNAM back to the same thread.
1165
1166         * QtTestBrowser/launcherwindow.cpp:
1167         (LauncherWindow::initializeView):
1168         (LauncherWindow::createChrome):
1169         (LauncherWindow::toggleThreadedQnam):
1170         * QtTestBrowser/launcherwindow.h:
1171         (WindowOptions::WindowOptions):
1172         * QtTestBrowser/webpage.cpp:
1173         (WebPage::WebPage):
1174         (WebPage::setQnamThreaded):
1175         * QtTestBrowser/webpage.h:
1176         (QnamThread::QnamThread):
1177         (QnamThread::~QnamThread):
1178         (QnamThread::networkAccessManager):
1179         (QnamThread::run):
1180
1181 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
1182
1183         Reviewed by Xan Lopez.
1184
1185         [Gtk] style="font-family: courier" makes text disappear
1186         https://bugs.webkit.org/show_bug.cgi?id=47452
1187
1188         Add a test that verifies that fonts without valid charmaps are
1189         never selected.
1190
1191         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1192         (initializeFonts): Initialize DRT with our font (derived from Ahem)
1193         that has no valid charmap.
1194         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
1195         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
1196         settings which may disable selection of bitmap fonts.
1197
1198 2010-12-10  Eric Seidel  <eric@webkit.org>
1199
1200         Unreviewed.
1201
1202         The commit-queue should file bugs about flaky tests it encounters
1203         https://bugs.webkit.org/show_bug.cgi?id=50803
1204
1205         create_bug_for_flaky_test was insufficiently tested, thus buggy.
1206         Now it's tested.
1207
1208         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1209         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1210
1211 2010-12-10  Eric Seidel  <eric@webkit.org>
1212
1213         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
1214
1215         The commit-queue should file bugs about flaky tests it encounters
1216         https://bugs.webkit.org/show_bug.cgi?id=50803
1217
1218         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1219
1220 2010-12-09  Eric Seidel  <eric@webkit.org>
1221
1222         Reviewed by Adam Barth.
1223
1224         The commit-queue should file bugs about flaky tests it encounters
1225         https://bugs.webkit.org/show_bug.cgi?id=50803
1226
1227         This change got a bit big.  I also added a new config.urls file
1228         because I needed to share the view_source_url code with committervalidator.py.
1229
1230         This adds a new class FlakyTestReporter which holds all the logic about
1231         reporting flaky tests to bugzilla.
1232
1233         Right now this code knows how to look up bugs for flaky tests.
1234         If it can't find a bug filed from the commit-queue, it will open a new
1235         one, ccing the relevant people and adding information about the failure.
1236
1237         It is not yet smart enough to chase down duplicate chains, or to include
1238         the actual failure diff.  But those can be added in later iterations.
1239
1240         * Scripts/webkitpy/common/checkout/api.py:
1241         * Scripts/webkitpy/common/checkout/changelog.py:
1242         * Scripts/webkitpy/common/checkout/commitinfo.py:
1243         * Scripts/webkitpy/common/config/committervalidator.py:
1244         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1245         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1246         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
1247         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1248         * Scripts/webkitpy/tool/bot/irc_command.py:
1249         * Scripts/webkitpy/tool/bot/sheriff.py:
1250         * Scripts/webkitpy/tool/commands/download.py:
1251         * Scripts/webkitpy/tool/commands/queues.py:
1252         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1253         * Scripts/webkitpy/tool/comments.py:
1254         * Scripts/webkitpy/tool/mocktool.py:
1255         * Scripts/webkitpy/tool/steps/commit.py:
1256
1257 2010-12-09  Eric Seidel  <eric@webkit.org>
1258
1259         Reviewed by Adam Barth.
1260
1261         Teach webkit-patch how to search bugzilla
1262         https://bugs.webkit.org/show_bug.cgi?id=50500
1263
1264         This is a step towards teaching webkitpy how to file
1265         new bugs for flaky tests and update them when new flakes occur.
1266
1267         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1268         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1269         * Scripts/webkitpy/tool/commands/__init__.py:
1270         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
1271
1272 2010-12-09  Adam Barth  <abarth@webkit.org>
1273
1274         Reviewed by Ojan Vafai.
1275
1276         commit-queue errors out due to local commits
1277         https://bugs.webkit.org/show_bug.cgi?id=50766
1278
1279         We seem to be tripping over having local commits in the working copy a
1280         lot recently.  I don't quite fully understand what the issue is, but
1281         this patch attempts to solve the problem by adding an explicit clean
1282         step before processing a patch.  Previously, we did the cleaning as
1283         part of the apply-attachment step, so this might not actually fix the
1284         problem.
1285
1286         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1287         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1288         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1289
1290 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
1291
1292         Reviewed by Ojan Vafai.
1293
1294         Make new-run-webkit-tests --lint-test-files log slightly better
1295         messages and return -1 if lint fails. Remove the
1296         'suppress_errors' keyword param to the TestExpectationsFile
1297         class, and clean up logging and exception raising for error
1298         handling. Also add more unit tests and clean up the unit test code a bit.
1299
1300         https://bugs.webkit.org/show_bug.cgi?id=50205
1301
1302         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1303         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1304         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
1305         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
1306         * Scripts/webkitpy/layout_tests/port/chromium.py:
1307         * Scripts/webkitpy/style/checkers/test_expectations.py:
1308         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1309
1310 2010-12-09  Tony Chang  <tony@chromium.org>
1311
1312         Unreviewed, fix for windows code.  We were catching the wrong
1313         exception in Windows.
1314
1315         * Scripts/webkitpy/common/system/filesystem.py:
1316
1317 2010-12-09  Antonio Gomes  <agomes@rim.com>
1318
1319         Reviewed by Martin Robinson.
1320
1321         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
1322         https://bugs.webkit.org/show_bug.cgi?id=48429
1323
1324         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
1325
1326         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1327         (LayoutTestController::workerThreadCount):
1328
1329 2010-12-06  Philippe Normand  <pnormand@igalia.com>
1330
1331         Reviewed by Martin Robinson.
1332
1333         [GTK] Support the Mozilla-style Fullscreen Javascript API
1334         https://bugs.webkit.org/show_bug.cgi?id=50572
1335
1336         Enable the Javascript Fullscreen support in the GtkLauncher. Also
1337         make DRT update the Chrome when the WebView settings have been
1338         reset to consistent values.
1339
1340         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1341         (resetDefaultsToConsistentValues):
1342         * GtkLauncher/main.c:
1343         (create_window):
1344         * Scripts/build-webkit:
1345
1346 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
1347
1348         Reviewed by Tor Arne Vestbø
1349
1350         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
1351         https://bugs.webkit.org/show_bug.cgi?id=50742
1352
1353         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
1354
1355         * Scripts/webkitdirs.pm:
1356
1357 2010-12-09  Joone Hur  <joone@kldp.org>
1358
1359          Reviewed by Martin Robinson.
1360
1361          [GTK] Support for viewport meta tag
1362          https://bugs.webkit.org/show_bug.cgi?id=45443
1363
1364          Add support for testing the viewport properties for WebKitGtk.
1365
1366          * DumpRenderTree/LayoutTestController.cpp:
1367          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
1368          (LayoutTestController::staticFunctions):
1369          * DumpRenderTree/LayoutTestController.h:
1370          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1371          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
1372          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1373          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1374          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1375          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1376          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1377          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1378          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1379          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1380
1381 2010-12-08  William Siegrist <wsiegrist@apple.com>
1382
1383         Reviewed by Eric Seidel.
1384
1385         Migrate buildbot.py from xmlrpc to json.
1386         https://bugs.webkit.org/show_bug.cgi?id=50647
1387
1388         * Scripts/webkitpy/common/net/buildbot.py:
1389
1390 2010-12-08  Tony Chang  <tony@chromium.org>
1391
1392         Reviewed by Eric Seidel.
1393
1394         make starting the websocket server more reliable on windows
1395         https://bugs.webkit.org/show_bug.cgi?id=50712
1396
1397         * Scripts/webkitpy/common/system/filesystem.py:
1398         (remove): Substitute method for os.remove to retry on error on Windows
1399         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1400         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
1401
1402 2010-12-08  Jessie Berlin  <jberlin@apple.com>
1403
1404         Reviewed by Adam Roben.
1405
1406         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
1407         https://bugs.webkit.org/show_bug.cgi?id=50656
1408
1409         * MiniBrowser/mac/BrowserWindowController.m:
1410         (-[BrowserWindowController awakeFromNib]):
1411         Indicate that exceededDatabaseQuota is not implemented.
1412         * MiniBrowser/win/BrowserView.cpp:
1413         (BrowserView::create):
1414         Ditto.
1415         * WebKitTestRunner/TestController.cpp:
1416         (WTR::createOtherPage):
1417         Ditto.
1418         (WTR::TestController::initialize):
1419         Ditto.
1420
1421 2010-12-08  Antonio Gomes  <agomes@rim.com>
1422
1423         Reviewed by Martin Robinson.
1424
1425         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
1426         https://bugs.webkit.org/show_bug.cgi?id=48429
1427
1428         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
1429         * webkit_gc_collect_javascript_objects;
1430         * webkit_gc_collect_javascript_objects_on_alternate_thread;
1431         * webkit_gc_count_javascript_objects;
1432         * webkit_web_frame_layout.
1433
1434         These were all only used by GTK+ DRT.
1435
1436         * DumpRenderTree/gtk/EventSender.cpp:
1437         (dispatchEvent):
1438         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1439         (GCController::collect):
1440         (GCController::collectOnAlternateThread):
1441         (GCController::getJSObjectCount):
1442
1443 2010-12-07  Tony Chang  <tony@chromium.org>
1444
1445         Reviewed by Ojan Vafai.
1446
1447         [chromium] force NRWT to use DRT
1448         https://bugs.webkit.org/show_bug.cgi?id=50359
1449
1450         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1451
1452 2010-12-06  Sam Weinig  <sam@webkit.org>
1453
1454         Reviewed by Anders Carlsson.
1455
1456         Generalize didChangeLocationWithinPageForFrame for all same document navigations
1457         https://bugs.webkit.org/show_bug.cgi?id=50584
1458
1459         * MiniBrowser/mac/BrowserWindowController.m:
1460         (didSameDocumentNavigationForFrame):
1461         (-[BrowserWindowController awakeFromNib]):
1462         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
1463         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1464         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1465         (TestWebKitAPI::TEST):
1466         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1467         (WTR::InjectedBundlePage::InjectedBundlePage):
1468         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
1469         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1470         * WebKitTestRunner/TestController.cpp:
1471         (WTR::TestController::initialize):
1472
1473 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
1474
1475         Reviewed by Ojan Vafai.
1476
1477         Make TestResultsServer return 404 for non-existing results files.
1478         https://bugs.webkit.org/show_bug.cgi?id=50581
1479
1480         * TestResultServer/handlers/testfilehandler.py:
1481
1482 2010-12-06  Tony Chang  <tony@chromium.org>
1483
1484         Reviewed by Ojan Vafai.
1485
1486         [chromium] fix an assert hit in DRT
1487         https://bugs.webkit.org/show_bug.cgi?id=50575
1488
1489         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
1490         semantics.
1491
1492         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
1493         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
1494         WTF::RefCountedBase::ref()).
1495
1496         * DumpRenderTree/chromium/TestWebWorker.h:
1497         (TestWebWorker::TestWebWorker):
1498
1499 2010-12-02  Ojan Vafai  <ojan@chromium.org>
1500
1501         Reviewed by Eric Seidel.
1502
1503         make webkit-patch command work when the git branch is not synced to the remote svn branch
1504         https://bugs.webkit.org/show_bug.cgi?id=50424
1505
1506         * Scripts/webkitpy/common/checkout/scm.py:
1507         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1508
1509 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
1510
1511         Reviewed by Andreas Kling.
1512
1513         [WINCE] Add build system
1514         https://bugs.webkit.org/show_bug.cgi?id=50522
1515
1516         * CMakeListsWinCE.txt: Added.
1517
1518 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1519
1520         Reviewed by Tony Chang.
1521
1522         Allow the Chromium port to have Leopard-specific baselines
1523         https://bugs.webkit.org/show_bug.cgi?id=50506
1524
1525         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1526
1527 2010-12-03  Tony Chang  <tony@chromium.org>
1528
1529         Reviewed by Kent Tamura.
1530
1531         [chromium] fix 2 bugs with inspector tests in DRT
1532         https://bugs.webkit.org/show_bug.cgi?id=50492
1533
1534         Tasks can outlive the tasklist (even when canceled) so this was
1535         causing a crash when ~WebTask() ran.  Avoid this by unregistering
1536         when a task is canceled.
1537
1538         Also fix an assert when closing devtool windows by copying some
1539         logic from test_shell.
1540
1541         * DumpRenderTree/chromium/Task.cpp:
1542         (WebTask::~WebTask):
1543         (TaskList::revokeAll):
1544         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
1545             the tasklist (since the task can outlive the tasklist).
1546         * DumpRenderTree/chromium/TestShell.h:
1547         (TestShell::devToolsWebView):
1548         * DumpRenderTree/chromium/WebViewHost.cpp:
1549         (WebViewHost::~WebViewHost): Don't load about:blank when closing
1550             a window if the window has devtools loaded.  This avoids an
1551             ASSERT and matches test_shell.
1552
1553 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
1554
1555         Reviewed by Martin Robinson.
1556
1557         [GTK] Fix GtkLauncher.c style, use webkit style
1558         https://bugs.webkit.org/show_bug.cgi?id=50542
1559
1560         * GtkLauncher/main.c:
1561         (activateUriEntryCb):
1562         (updateTitle):
1563         (linkHoverCb):
1564         (notifyTitleCb):
1565         (notifyLoadStatusCb):
1566         (notifyProgressCb):
1567         (destroyCb):
1568         (goBackCb):
1569         (goForwardCb):
1570         (create_webViewCb):
1571         (webViewReadyCb):
1572         (closeWebViewCb):
1573         (createBrowser):
1574         (createStatusbar):
1575         (createToolbar):
1576         (createWindow):
1577         (main):
1578
1579 2010-12-04  Antonio Gomes  <agomes@rim.com>
1580
1581         Reviewed by Martin Robinson.
1582
1583         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
1584         https://bugs.webkit.org/show_bug.cgi?id=48429
1585
1586         Moved more private method declared with WEBKIT_API to
1587         DumpRenderTreeSupportGtk, since they were only being used by DRT.
1588
1589         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1590         (resetDefaultsToConsistentValues):
1591         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1592         (LayoutTestController::addOriginAccessWhitelistEntry):
1593         (LayoutTestController::execCommand):
1594         (LayoutTestController::isCommandEnabled):
1595
1596 2010-12-04  Antonio Gomes  <agomes@rim.com>
1597
1598         Reviewed by Andreas Kling.
1599
1600         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
1601
1602         Method was removed by http://trac.webkit.org/changeset/71604
1603
1604         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1605
1606 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
1607
1608         Reviewed by Xan Lopez.
1609
1610         [GTK] Fix compilation warnings reported by clang
1611         https://bugs.webkit.org/show_bug.cgi?id=50252
1612
1613         * GtkLauncher/main.c:
1614         (create_window): The create_statusbar function does not have
1615         parameters.
1616
1617 2010-12-05  Robert Hogan  <robert@webkit.org>
1618
1619         Reviewed by Andreas Kling.
1620
1621         [Qt] Zero-sized font does not yet work
1622
1623         Fix fast/text/font-size-zero.html
1624
1625         Copy other ports by setting minimumFontSize to 0 for DRT runs.
1626
1627         https://bugs.webkit.org/show_bug.cgi?id=49759
1628
1629         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1630         (WebCore::WebPage::WebPage):
1631
1632 2010-12-04  Sam Weinig  <sam@webkit.org>
1633
1634         Reviewed by Jon Honeycutt.
1635
1636         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
1637         https://bugs.webkit.org/show_bug.cgi?id=50511
1638
1639         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
1640         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
1641
1642         * MiniBrowser/mac/BrowserWindowController.m:
1643         (didChangeLocationWithinPageForFrame):
1644         (-[BrowserWindowController awakeFromNib]):
1645         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
1646         * TestWebKitAPI/PlatformUtilities.cpp:
1647         (TestWebKitAPI::Util::toWK):
1648         * TestWebKitAPI/PlatformUtilities.h:
1649         (TestWebKitAPI::Util::adoptWK):
1650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1651         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
1652         (TestWebKitAPI::nullJavaScriptCallback):
1653         (TestWebKitAPI::didFinishLoadForFrame):
1654         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
1655         (TestWebKitAPI::TEST):
1656         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
1657         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1658         * TestWebKitAPI/win/copy-resources.cmd:
1659         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1660         (WTR::InjectedBundlePage::InjectedBundlePage):
1661         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
1662         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1663         * WebKitTestRunner/TestController.cpp:
1664         (WTR::TestController::initialize):
1665
1666 2010-11-08  Antonio Gomes  <agomes@rim.com>
1667
1668         Reviewed by Martin Robinson.
1669
1670         [Gtk] Populate DumpRenderTreeSupportGtk
1671         https://bugs.webkit.org/show_bug.cgi?id=48429
1672
1673         Made the previous calls to webkit_web_frame* functions defined as private
1674         APIs in webkitprivate.h go through DRTSupportGtk.
1675
1676         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1677         (AccessibilityController::focusedElement):
1678         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1679         (dumpFramesAsText):
1680         (resetDefaultsToConsistentValues):
1681         (dump):
1682         (webViewDocumentLoadFinished):
1683         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1684         (LayoutTestController::counterValueForElementById):
1685         (LayoutTestController::pageNumberForElementById):
1686         (LayoutTestController::numberOfPages):
1687         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1688         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1689         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1690         (LayoutTestController::numberOfActiveAnimations):
1691         (LayoutTestController::suspendAnimations):
1692         (LayoutTestController::resumeAnimations):
1693         (LayoutTestController::markerTextForListItem):
1694
1695 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1696
1697         Reviewed by Tony Chang.
1698
1699         Rebaseline server: use pretty text diff output
1700         https://bugs.webkit.org/show_bug.cgi?id=50484
1701         
1702         Serve *-pretty-diff.html for text diff output.
1703
1704         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1705         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1706         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1707         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1708
1709 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1710
1711         Unreviewed, rolling out r73302.
1712         http://trac.webkit.org/changeset/73302
1713         https://bugs.webkit.org/show_bug.cgi?id=50499
1714
1715         Causes crashes in debug LayoutTests (Requested by xan_ on
1716         #webkit).
1717
1718         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1719         (AccessibilityUIElement::AccessibilityUIElement):
1720         (AccessibilityUIElement::parentElementCallback):
1721         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1722         * DumpRenderTree/chromium/CppBoundClass.cpp:
1723         * DumpRenderTree/chromium/CppBoundClass.h:
1724
1725 2010-12-03  Sam Weinig  <sam@webkit.org>
1726
1727         Reviewed by Maciej Stachowiak.
1728
1729         Enable <a ping> for Mac/Windows/WebKit2 builds
1730         <rdar://problem/8504473>
1731         https://bugs.webkit.org/show_bug.cgi?id=50488
1732
1733         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1734         (TestWebKitAPI::TEST): Test that the default value of
1735         WKPreferencesGetHyperlinkAuditingEnabled is true.
1736
1737 2010-12-03  Chris Guillory  <chris.guillory@google.com>
1738
1739         Reviewed by Chris Fleizach.
1740
1741         Include the FrameView widget of a RenderWidget in the accessibility tree.
1742         https://bugs.webkit.org/show_bug.cgi?id=49106
1743
1744         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1745         (AccessibilityUIElement::AccessibilityUIElement):
1746         (AccessibilityUIElement::parentElementCallback):
1747         (AccessibilityUIElement::isEqualCallback):
1748         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1749         * DumpRenderTree/chromium/CppBoundClass.cpp:
1750         (CppBoundClass::getFromCppVariant):
1751         * DumpRenderTree/chromium/CppBoundClass.h:
1752
1753 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1754
1755         Reviewed by Tony Chang.
1756
1757         Rebaseline server: organize tests by state, add dry run mode
1758         https://bugs.webkit.org/show_bug.cgi?id=50473
1759         
1760         Group tests in the menu by state, so that it's easier to see after
1761         processing the queue which failed.
1762         
1763         Add support for the --dry-run flag so that it's easier to test changes
1764         such as this (stubs out filesystem and SCM operations).
1765
1766         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1767         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1768         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1769
1770 2010-12-03  Brady Eidson  <beidson@apple.com>
1771
1772         Reviewed by Anders Carlsson.
1773
1774         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
1775         WebKit2 Authentication Support
1776
1777         Keep these builds working:
1778         * MiniBrowser/mac/BrowserWindowController.m:
1779         (-[BrowserWindowController awakeFromNib]):
1780
1781         * WebKitTestRunner/TestController.cpp:
1782         (WTR::TestController::initialize):
1783
1784 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
1785
1786         Reviewed by Tony Chang.
1787
1788         Rebaseline server: move existing baselines
1789         https://bugs.webkit.org/show_bug.cgi?id=50421
1790         
1791         Implement moving of existing baselines: move all files that are about
1792         to be overwriten by update baselines.
1793         
1794         Also fix a typo in the UI JS.
1795
1796         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1797         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1798         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
1799
1800 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1801
1802         Unreviewed, rolling out r73211.
1803         http://trac.webkit.org/changeset/73211
1804         https://bugs.webkit.org/show_bug.cgi?id=50450
1805
1806         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
1807         yutak on #webkit).
1808
1809         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1810
1811 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1812
1813         Unreviewed, rolling out r73222.
1814         http://trac.webkit.org/changeset/73222
1815         https://bugs.webkit.org/show_bug.cgi?id=50449
1816
1817         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
1818         (Requested by yutak on #webkit).
1819
1820         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1821         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1822         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1823         * Scripts/webkitpy/layout_tests/port/base.py:
1824         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1825         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1826
1827 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1828
1829         Unreviewed, rolling out r73228.
1830         http://trac.webkit.org/changeset/73228
1831         https://bugs.webkit.org/show_bug.cgi?id=50448
1832
1833         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
1834         (Requested by yutak on #webkit).
1835
1836         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1837         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1838         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1839         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
1840         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1841
1842 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1843
1844         Unreviewed, rolling out r73231.
1845         http://trac.webkit.org/changeset/73231
1846         https://bugs.webkit.org/show_bug.cgi?id=50443
1847
1848         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
1849         (Requested by yutak on #webkit).
1850
1851         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1852         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1853         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1854         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1855
1856 2010-12-03  David Levin  <levin@chromium.org>
1857
1858         Reviewed by Shinichiro Hamaji.
1859
1860         check-webkit-style: false positive reported for #if macro
1861         https://bugs.webkit.org/show_bug.cgi?id=48242
1862
1863         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
1864           all preprocessor commands.
1865         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
1866
1867 2010-12-02  Eric Seidel  <eric@webkit.org>
1868
1869         Reviewed by Adam Barth.
1870
1871         Update the EWSTools scripts to use modern-style git repos
1872         https://bugs.webkit.org/show_bug.cgi?id=50402
1873
1874         * EWSTools/create-webkit-git:
1875         * EWSTools/start-commit-queue.sh:
1876         * EWSTools/start-queue.sh:
1877
1878 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
1879
1880         Fix Chromium Linux plugin tests by not logging
1881         unconditionally from the event handling code.
1882
1883         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1884         (handleEventX11):
1885
1886 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
1887
1888         Reviewed by Tony Chang.
1889
1890         nrwt multiprocessing - move logic back into run_webkit_tests
1891
1892         This change moves a bunch of logic that I had put into
1893         message_broker back into run_webkit_tests, in a slightly
1894         different format. WorkerMessageBroker needed to become less aware of
1895         the logic the TestRunner class uses, and more generic.
1896         Eventually the MessageBroker will only do generic messaging and
1897         thread/process-pooling, and (almost) all of the
1898         run-webkit-tests-specific logic will be moved to
1899         run_webkit_tests.py and dump_render_tree_thread.py.
1900         
1901         The biggest changes are that the Broker can now start a single
1902         worker, but the responsibility for starting all of them is pushed
1903         back to the TestRunner (Manager), and the logic for checking if
1904         the threads are done or wedged is moved back to TestRunner. We
1905         also remove WorkerMessageBroker.cleanup (not needed) and
1906         cancel_workers (they have to be cancelled individually).
1907         
1908         The  message_broker is now encapsulated inside
1909         TestRunner._run_tests(); it only needs to exist while actually
1910         running the tests.
1911
1912         Also, delete a bunch of tests in message_broker_unittest that no
1913         longer make much sense.
1914
1915         This patch depends on bug 50372.
1916
1917         https://bugs.webkit.org/show_bug.cgi?id=50374
1918
1919         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1920         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1921         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1922         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1923         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1924
1925 2010-12-02  Hayato Ito  <hayato@chromium.org>
1926
1927         Reviewed by Eric Seidel.
1928
1929         Refactor test_types's compare_output() method so that it takes a
1930         TestInput object.
1931
1932         compare_output() will need additional information included in a TestInput
1933         object to support reftests. This change is a pre-requirement of that.
1934
1935         https://bugs.webkit.org/show_bug.cgi?id=50362
1936
1937         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1938         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1939         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1940         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
1941         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1942
1943 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
1944
1945         Reviewed by Anders Carlsson.
1946
1947         Add the ability to run script on 'new' and 'paint' in the test plugin
1948         https://bugs.webkit.org/show_bug.cgi?id=50425
1949         
1950         Add "onnew" and "onpaintevent" attributes to the test plugin,
1951         so that tests can run JS at these times.
1952
1953         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1954         (pluginAllocate):
1955         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1956         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1957         (NPP_New):
1958         (NPP_Destroy):
1959         (handleEventCarbon):
1960         (handleEventCocoa):
1961         (NPP_HandleEvent):
1962
1963 2010-12-02  Sam Weinig  <sam@webkit.org>
1964
1965         Fix Qt build.
1966
1967         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1968         (WTR::PlatformWebView::PlatformWebView):
1969
1970 2010-12-02  Sam Weinig  <sam@webkit.org>
1971
1972         Reviewed by Anders Carlsson.
1973
1974         WebKit2 Preferences should be held off the PageGroup, not the Context
1975         https://bugs.webkit.org/show_bug.cgi?id=50414
1976
1977         Update for API changes.
1978
1979         * WebKitTestRunner/PlatformWebView.h:
1980         * WebKitTestRunner/TestController.cpp:
1981         (WTR::createOtherPage):
1982         (WTR::TestController::initialize):
1983         (WTR::TestController::resetStateToConsistentValues):
1984         * WebKitTestRunner/TestController.h:
1985         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1986         (WTR::PlatformWebView::PlatformWebView):
1987         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1988         (WTR::PlatformWebView::PlatformWebView):
1989
1990 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
1991
1992         Reviewed by Tony Chang.
1993
1994         new-run-webkit-tests: minor cleanup for multiprocessing work
1995
1996         This change:
1997         * moves worker naming into TestShellThread, eliminating a
1998           parameter to the constructor and putting the responsibility in
1999           the correct place.
2000         * eliminates the _WorkerState() class in message_broker, because
2001           it turns out that state really needs to be in run_webkit_tests
2002         * renames the Broker classes to be module-private.
2003         * fixes a bunch of minor commenting and whitespace issues to
2004           make subsequent patches a bit clearer.
2005         * Adds a Port hook for default_worker_model() so that we can
2006           accomodate the potential for different worker models on
2007           different ports.
2008         * merge in the fix from 50420 for the brokenness introduced in
2009           bug 50367.
2010
2011         This patch depends on bug 50367.
2012
2013         https://bugs.webkit.org/show_bug.cgi?id=50372
2014
2015         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2016         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2017         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2018         * Scripts/webkitpy/layout_tests/port/base.py:
2019         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2020         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2021
2022 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2023
2024         Reviewed by Tony Chang.
2025
2026         This change is a bunch of cleanup / refactoring of the file
2027         below. It moves a bunch of free functions to methods on the
2028         TestShellThread class, and restructures other methods to be
2029         closer to the structure we'll need for the multiprocessing
2030         rewrite.
2031
2032         It also makes the logic of --run-singly a *lot* easier to follow
2033         by nestling all of the separate-thread logic into a single
2034         routine.
2035
2036         There should be no semantic changes in this patch, just cleanup.
2037
2038         https://bugs.webkit.org/show_bug.cgi?id=50367
2039
2040         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2041
2042 2010-12-02  Tony Chang  <tony@chromium.org>
2043
2044         Unreviewed, rolling out r73164.
2045         http://trac.webkit.org/changeset/73164
2046         https://bugs.webkit.org/show_bug.cgi?id=50359
2047
2048         broke debugger tests on win
2049
2050         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2051
2052 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2053
2054         Reviewed by Tony Chang.
2055
2056         Rebaseline server: add updating of baselines
2057         https://bugs.webkit.org/show_bug.cgi?id=50305
2058         
2059         Implements updating of baselines, where we copy -actual.* files over
2060         the current -expected.* files. To do this, we need a
2061         _get_actual_result_files method to get test results files and a
2062         _rebaseline_test method to actually do the file copy and SCM operation.
2063         _rebaseline_test logs output into a buffer, this is useful for both
2064         showing result in the UI and for unit tests.
2065         
2066         To make passing around of the various test environment properties
2067         (results directory, filesystem, SCM, etc) easier, add a TestConfig
2068         class for them.
2069         
2070         Moving of existing baselines is not implemented yet, this patch is big
2071         enough as it is.
2072
2073         * Scripts/webkitpy/common/system/filesystem.py:
2074         * Scripts/webkitpy/common/system/filesystem_mock.py:
2075         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2076         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2077         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2078         * Scripts/webkitpy/tool/mocktool.py:
2079
2080 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
2081
2082         Unreviewed build fix after vcproj updates.
2083
2084         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
2085         that WIN_CAIRO is defined for this build.
2086         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
2087         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
2088         (these were previously 'Debug_Cairo' and 'Release_Cairo'
2089
2090 2010-12-02  Sam Weinig  <sam@webkit.org>
2091
2092         Reviewed by Anders Carlsson.
2093
2094         WebKit2 needs API to turn on popup blocking
2095         https://bugs.webkit.org/show_bug.cgi?id=50407
2096
2097         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2098         (TestWebKitAPI::TEST):
2099         * WebKitTestRunner/TestController.cpp:
2100         (WTR::TestController::resetStateToConsistentValues):
2101
2102 2010-12-01  Tony Chang  <tony@chromium.org>
2103
2104         Reviewed by Ojan Vafai.
2105
2106         [chromium] force NRWT to use DRT
2107         https://bugs.webkit.org/show_bug.cgi?id=50359
2108
2109         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2110
2111 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
2112
2113         Reviewed by Xan Lopez.
2114
2115         [GTK] DumpRenderTree has two copies of JavaScriptCore
2116         https://bugs.webkit.org/show_bug.cgi?id=49877
2117
2118         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
2119         LDADD list for DumpRenderTree.
2120
2121 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
2122
2123         Unreviewed: Added myself to list of Committers.
2124
2125         * Scripts/webkitpy/common/config/committers.py:
2126
2127 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
2128
2129         Reviewed by Adam Barth.
2130
2131         build-webkit --chromium always updates DEPS and re-generates project files
2132         https://bugs.webkit.org/show_bug.cgi?id=50340
2133         
2134         Make build-webkit --chromium invoke update-webkit-chromium only when
2135         --update-chromium is passed in, so that we don't add 20 seconds to all
2136         builds.
2137         
2138         Making all invocations update was added with r61883, with the goal of
2139         making EWS bots always update. The bots will switch to using this flag
2140         (as will all other webkit-patch build steps) so nothing should change
2141         for them.
2142
2143         * Scripts/webkitdirs.pm:
2144         * Scripts/webkitpy/common/config/ports.py:
2145         * Scripts/webkitpy/common/config/ports_unittest.py:
2146
2147 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
2148
2149         Reviewed by Tony Chang.
2150
2151         new-run-webkit-tests: add a --dry-run / -n flag
2152         https://bugs.webkit.org/show_bug.cgi?id=50045
2153
2154         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2155         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2156
2157 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2158
2159         Reviewed by Adam Roben.
2160
2161         WinCairo build should not use link-time code generation (LTCG)
2162         https://bugs.webkit.org/show_bug.cgi?id=50353
2163
2164         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2165         * DumpRenderTree/win/DumpRenderTree.vcproj:
2166         * DumpRenderTree/win/ImageDiff.vcproj:
2167         * FindSafari/FindSafari.vcproj:
2168         * MiniBrowser/MiniBrowser.vcproj:
2169         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2170         * WebKitAPITest/WebKitAPITest.vcproj:
2171         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2172         * WebKitTestRunner/win/InjectedBundle.vcproj:
2173         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2174         * WinLauncher/WinLauncher.vcproj:
2175         * record-memory-win/record-memory-win.vcproj:
2176
2177 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2178
2179         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
2180         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
2181         adding the file to the sources list was not enough to force the rebuild.
2182
2183         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2184         Remove an empty line at the end of this file to force a rebuild.
2185
2186 2010-12-01  Sam Weinig  <sam@webkit.org>
2187
2188         Fix windows build.
2189
2190         * MiniBrowser/win/BrowserView.cpp:
2191         (BrowserView::create):
2192
2193 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2194
2195         Add missing file to the TestNetscapePlugin sources list after r73057.
2196
2197         * GNUmakefile.am: Add missing file.
2198
2199 2010-12-01  Sam Weinig  <sam@webkit.org>
2200
2201         Reviewed by Anders Carlsson.
2202
2203         Add PageGrouping to WebKit2 API
2204         https://bugs.webkit.org/show_bug.cgi?id=50332
2205
2206         - Update testing harnesses to deal with new PageGroup API.
2207
2208         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2209         (WKBundleInitialize):
2210         * TestWebKitAPI/InjectedBundleController.cpp:
2211         (TestWebKitAPI::InjectedBundleController::initialize):
2212         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
2213         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
2214         * TestWebKitAPI/InjectedBundleController.h:
2215         * TestWebKitAPI/InjectedBundleTest.h:
2216         (TestWebKitAPI::InjectedBundleTest::initialize):
2217         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
2218         * TestWebKitAPI/PlatformUtilities.cpp:
2219         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2220         * TestWebKitAPI/PlatformUtilities.h:
2221         * TestWebKitAPI/PlatformWebView.h:
2222         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2223         (TestWebKitAPI::TEST):
2224         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2225         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2226         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2227         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2228         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2229         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2230         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2231         (WTR::InjectedBundle::didInitializePageGroup):
2232         (WTR::InjectedBundle::initialize):
2233         (WTR::InjectedBundle::beginTesting):
2234         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2235         (WTR::InjectedBundle::pageGroup):
2236         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2237         (WTR::LayoutTestController::addUserScript):
2238         (WTR::LayoutTestController::addUserStyleSheet):
2239         (WTR::LayoutTestController::setXSSAuditorEnabled):
2240         * WebKitTestRunner/TestController.cpp:
2241         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2242         (WTR::PlatformWebView::PlatformWebView):
2243
2244 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2245
2246         Reviewed by Adam Roben.
2247
2248         vcproj changes can't be applied cleanly by the Windows EWS bot
2249         https://bugs.webkit.org/show_bug.cgi?id=50328
2250
2251         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2252         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
2253         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2254         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
2255         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
2256         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
2257         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
2258         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
2259         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
2260         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
2261         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
2262         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
2263         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
2264         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2265         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
2266         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
2267         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
2268         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
2269         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
2270         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
2271         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
2272         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
2273         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
2274         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
2275         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
2276         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
2277         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
2278         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
2279         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
2280         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
2281         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
2282         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
2283         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
2284         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
2285         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
2286         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
2287         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
2288         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
2289         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
2290         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
2291         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
2292         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
2293         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
2294         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
2295         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
2296
2297 2010-12-01  Anders Carlsson  <andersca@apple.com>
2298
2299         Reviewed by Darin Adler.
2300
2301         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
2302         https://bugs.webkit.org/show_bug.cgi?id=50336
2303
2304         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2305         Add new test.
2306
2307         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2308         (PluginTest::NPP_New):
2309         Add default implementation/
2310
2311         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2312         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
2313         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
2314         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
2315         Get the user agent.
2316
2317         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2318         (NPP_New):
2319         Call PluginTest::NPP_New.
2320
2321         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2322         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2323         Add new files.
2324
2325         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2326         (webkit_test_plugin_new_instance):
2327         Call PluginTest::NPP_New.
2328
2329 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
2330
2331         [wx] Build fixes after recent trunk changes.
2332
2333         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2334         (LayoutTestController::findString):
2335         * wx/build/settings.py:
2336
2337 2010-12-01  Dan Bernstein  <mitz@apple.com>
2338
2339         Reviewed by Darin Adler.
2340
2341         WebKitTestRunner needs layoutTestController.findString
2342         https://bugs.webkit.org/show_bug.cgi?id=50238
2343
2344         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
2345         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2346         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
2347         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2348
2349 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2350
2351         Try using svn:eol-style native on a vcproj file.
2352
2353         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
2354
2355 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
2356
2357         Reviewed by Adam Roben.
2358
2359         [WINCE] Add WinCELauncher
2360         https://bugs.webkit.org/show_bug.cgi?id=50217
2361
2362         * WinCELauncher/main.cpp: Added.
2363
2364 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2365
2366         Reviewed by Kenneth Rohde Christiansen.
2367
2368         [Qt] Implement layoutTestController.findString
2369         https://bugs.webkit.org/show_bug.cgi?id=50236
2370
2371         Add the missing function to the LayoutTestController.
2372
2373         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2374         (LayoutTestController::findString):
2375         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2376
2377 2010-11-30  Tony Chang  <tony@chromium.org>
2378
2379         Reviewed by Adam Barth.
2380
2381         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
2382         https://bugs.webkit.org/show_bug.cgi?id=49036
2383
2384         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
2385             for CppVariants.
2386         (LayoutTestController::cppVariantToBool):
2387         (LayoutTestController::cppVariantToInt32):
2388         (LayoutTestController::setDatabaseQuota):
2389         (LayoutTestController::evaluateInWebInspector):
2390         (LayoutTestController::setMockGeolocationError):
2391
2392 2010-11-30  Eric Seidel  <eric@webkit.org>
2393
2394         Reviewed by Tony Chang.
2395
2396         update-webkit should call git fetch before git svn rebase
2397         https://bugs.webkit.org/show_bug.cgi?id=50273
2398
2399         After discussion on webkit-dev, we've decided to move the "default"
2400         git setup to pulling updates from git.webkit.org in preference
2401         to rebuilding the local svn index using git svn fetch every time.
2402
2403         This change should have no effect on people using the "old" git setup
2404         and should dramatically increase the speed of updates for those using
2405         the "new" git setup along with update-webkit.  I'm about to move the
2406         EWS and other queues over to this setup once this lands.
2407
2408         * Scripts/update-webkit:
2409
2410 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
2411
2412         Reviewed by Xan Lopez.
2413
2414         GTK: AX: implement press in DRT
2415         https://bugs.webkit.org/show_bug.cgi?id=36146
2416
2417         Implement AccessibilityUIElement::press() for GTK.
2418
2419         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2420         (AccessibilityUIElement::press): Implemented.
2421
2422 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
2423
2424         Reviewed by Tony Chang.
2425
2426         config.webkit_base_dir returns a path with a trailing slash
2427         https://bugs.webkit.org/show_bug.cgi?id=50197
2428         
2429         config.webkit_base_dir() should return a path without a trailing slash,
2430         like all the other methods that return paths.
2431         
2432         Undoes MockFileSytem changes by r72640, since they're no longer
2433         necessary for GetBaselinesTest to pass.
2434
2435         * Scripts/webkitpy/common/system/filesystem_mock.py:
2436         * Scripts/webkitpy/layout_tests/port/base.py:
2437         * Scripts/webkitpy/layout_tests/port/config.py:
2438         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2439
2440 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2441
2442         Reviewed by Tony Chang.
2443
2444         Rebaseline server: baseline display tweaks
2445         https://bugs.webkit.org/show_bug.cgi?id=50207
2446         
2447         Determine which baselines were used when running the tests and highlight
2448         them in the UI. Sort platform names alphabetically.
2449         
2450         Also makes the server URL be launched in the user's browser
2451         automatically.
2452
2453         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2454         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2455         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2456         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2457         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2458
2459 2010-11-30  Dan Bernstein  <mitz@apple.com>
2460
2461         Reviewed by Anders Carlsson.
2462
2463         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
2464         https://bugs.webkit.org/show_bug.cgi?id=50238
2465
2466         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2467         (WTR::LayoutTestController::findString): Added.
2468         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2469
2470 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
2471
2472         Reviewed by Adam Roben.
2473
2474         All projects on Windows should use cmd files for build events
2475         https://bugs.webkit.org/show_bug.cgi?id=50213
2476
2477         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2478         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
2479         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
2480         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2481         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
2482         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
2483         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2484         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
2485         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
2486         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
2487         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2488         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
2489         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
2490         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
2491         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2492         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
2493         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
2494         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2495         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
2496         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
2497         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2498         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2499         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
2500         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
2501         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
2502         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
2503         * WinLauncher/WinLauncherCommon.vsprops:
2504         * WinLauncher/WinLauncherPostBuild.cmd: Added.
2505         * WinLauncher/WinLauncherPreBuild.cmd: Added.
2506
2507 2010-11-29  Dan Bernstein  <mitz@apple.com>
2508
2509         GTK DumpRenderTree build fix after r72887.
2510
2511         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2512         (LayoutTestController::findString):
2513
2514 2010-11-29  Dan Bernstein  <mitz@apple.com>
2515
2516         Windows DumpRenderTree build fix after r72887.
2517
2518         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2519         (LayoutTestController::findString): Added empty implementation.
2520
2521 2010-11-29  Dan Bernstein  <mitz@apple.com>
2522
2523         Reviewed by Darin Adler.
2524
2525         DumpRenderTree changes for testing the text search API.
2526         https://bugs.webkit.org/show_bug.cgi?id=50038
2527
2528         * DumpRenderTree/LayoutTestController.cpp:
2529         (findStringCallback):
2530         (LayoutTestController::staticFunctions):
2531         * DumpRenderTree/LayoutTestController.h:
2532         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2533         (LayoutTestController::findString):
2534         * MiniBrowser/mac/BrowserWindowController.m:
2535         (-[BrowserWindowController find:]):
2536
2537 2010-11-29  Johnny Ding  <jnd@chromium.org>
2538
2539         Unreviewed: Add myself to the list of Committers.
2540
2541         * Scripts/webkitpy/common/config/committers.py:
2542
2543 2010-11-29  Mark Rowe  <mrowe@apple.com>
2544
2545         Reviewed by Adele Peterson.
2546
2547         <rdar://problem/8694997> DumpRenderTree fails to build.
2548
2549         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
2550
2551 2010-11-29  Mark Rowe  <mrowe@apple.com>
2552
2553         Reviewed by Adele Peterson.
2554
2555         <rdar://problem/8694997> DumpRenderTree fails to build.
2556
2557         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
2558         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
2559         * DumpRenderTree/mac/PerlSupport/Makefile:
2560
2561 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
2562
2563         Reviewed by Martin Robinson.
2564
2565         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
2566         https://bugs.webkit.org/show_bug.cgi?id=50154
2567
2568         Added missing checks to allAttributes().
2569
2570         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2571         (AccessibilityUIElement::allAttributes): Added missing checks.
2572
2573 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2574
2575         Reviewed by Kenneth Rohde Christiansen.
2576
2577         [Qt] Allow pre-generation for package builds for WebKit2
2578         https://bugs.webkit.org/show_bug.cgi?id=50139
2579
2580         Use a build variable for the generated directory path and set the
2581         value based on CONFIG just like for WebKit1.
2582
2583         For non-package builds use a relative base path for the
2584         genrated directory just like for WebKit1.
2585
2586         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2587         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2588
2589 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2590
2591         Reviewed by Kenneth Rohde Christiansen.
2592
2593         [Qt] Move some build logic from Qt to platform independent code
2594         https://bugs.webkit.org/show_bug.cgi?id=50134
2595
2596         Create target directories inside generate-forwarding-headers.pl.
2597
2598         * Scripts/generate-forwarding-headers.pl:
2599
2600 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2601
2602         Reviewed by Martin Robinson.
2603
2604         [GTK] Windowless plugins gets broken key input
2605         https://bugs.webkit.org/show_bug.cgi?id=49927
2606
2607         Convert the XEvent::keycode to ASCII before printing it. Not
2608         doing this was causing false positive in 
2609         plugins/keyboard-events.html.
2610
2611         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2612         (keycode_to_char):
2613         (webkit_test_plugin_handle_event):
2614
2615 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
2616
2617         Reviewed by Antonio Gomes.
2618
2619         [Qt] Html autofocus not working with QGraphicsWebView
2620         https://bugs.webkit.org/show_bug.cgi?id=43169
2621
2622         Tell the scene to set the webview item as the currently
2623         focused item. This makes the input field with autofocus get
2624         focus as it should.
2625
2626         * QtTestBrowser/webview.cpp:
2627         (WebViewGraphicsBased::WebViewGraphicsBased):
2628
2629 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
2630
2631         Reviewed by Tony Chang.
2632
2633         nrwt - clean up create_driver interface and print out the
2634         command line used for DumpRenderTree/TestShell.
2635
2636         This patch adds a driver_cmd_line() call to the Port class in
2637         order to retrive the command line to print it out (as part of
2638         --print config).
2639
2640         In addition, this patch cleans up the Port.create_driver()
2641         signature and the Driver constructor interface to take a worker
2642         number and no longer require the image_path argument (Chromium's
2643         drivers now synthesize the image_path from the worker number
2644         internally).
2645
2646         https://bugs.webkit.org/show_bug.cgi?id=49934
2647
2648         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2649         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2650         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2651         * Scripts/webkitpy/layout_tests/port/base.py:
2652         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2653         * Scripts/webkitpy/layout_tests/port/chromium.py:
2654         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2655         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2656         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2657         * Scripts/webkitpy/layout_tests/port/test.py:
2658         * Scripts/webkitpy/layout_tests/port/webkit.py:
2659         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2660         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2661
2662 2010-11-24  Ojan Vafai  <ojan@chromium.org>
2663
2664         Reviewed by Tony Chang.
2665
2666         [chromium] improve memory usage for test results server and store fewer runs
2667         https://bugs.webkit.org/show_bug.cgi?id=50035
2668
2669         Store fewer runs and don't pass full files around when we only need bools.
2670         Greatly improves error rates on test-results.appspot.com.
2671
2672         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2673         * TestResultServer/handlers/testfilehandler.py:
2674         * TestResultServer/model/dashboardfile.py:
2675         * TestResultServer/model/jsonresults.py:
2676
2677 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
2678
2679         Reviewed by Tony Chang.
2680
2681         This patch implements the first part of the manager side of the
2682         Broker objects - it handles creating threads, waiting for them
2683         to complete, and running a single-threaded loop as well.
2684
2685         https://bugs.webkit.org/show_bug.cgi?id=49779
2686
2687         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2688         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2689         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2690         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2691
2692 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
2693
2694         Reviewed by David Levin.
2695
2696         DRT should not generate pixel output for text/plain tests
2697         https://bugs.webkit.org/show_bug.cgi?id=50002
2698         
2699         Modify Mac, Windows and GTK DRT implementations to disable pixel output
2700         when encountering a text/plain response (the Chromium one already does
2701         this, and none of the other ports special-case text/plain output in
2702         the first place).
2703
2704         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2705         (dump):
2706         * DumpRenderTree/mac/DumpRenderTree.mm:
2707         (dump):
2708         * DumpRenderTree/win/DumpRenderTree.cpp:
2709         (dump):
2710
2711 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
2712
2713         Unreviewed.
2714
2715         Add my other email address to committers.py.
2716
2717         * Scripts/webkitpy/common/config/committers.py:
2718
2719 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
2720
2721         Reviewed by Csaba Osztrogonác.
2722
2723         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
2724         https://bugs.webkit.org/show_bug.cgi?id=49975
2725
2726         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
2727         to enable the script to define it 0 in case of a minimal build.
2728
2729 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
2730
2731         Reviewed by Xan Lopez.
2732
2733         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
2734         https://bugs.webkit.org/show_bug.cgi?id=49143
2735
2736         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2737         (createWebView): Call the new connectEditingCallbacks function.
2738         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
2739         (dumpNodePath):
2740         (dumpRange):
2741         (insertActionString):
2742         (selectionAffinityString):
2743         (shouldBeginEditing):
2744         (shouldEndEditing):
2745         (shouldInsertNode):
2746         (shouldInsertText):
2747         (shouldDeleteRange):
2748         (shouldShowDeleteInterfaceForElement):
2749         (shouldChangeSelectedRange):
2750         (shouldApplyStyle):
2751         (editingBegan):
2752         (userChangedContents):
2753         (editingEnded):
2754         (selectionChanged):
2755         (connectEditingCallbacks):
2756         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
2757         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
2758
2759 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
2760
2761         Reviewed by Andreas Kling.
2762
2763         [Qt] Make QtTestBrowser remember the selected user agent
2764         https://bugs.webkit.org/show_bug.cgi?id=50021
2765
2766         Set user agent for a new page by using the old page's
2767
2768         * QtTestBrowser/mainwindow.cpp:
2769         (MainWindow::setPage):
2770
2771 2010-11-24 Patrick Gansterer <paroga@webkit.org>
2772
2773         Reviewed by Csaba Osztrogonác.
2774
2775         Remove Bakefile build system files
2776         https://bugs.webkit.org/show_bug.cgi?id=49983
2777
2778         r53757 only removed the content, but not the files.
2779         This patch removes that empty files.
2780
2781         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
2782         * wx/browser/browser.bkl: Removed.
2783         * wx/build-wxwebkit: Removed.
2784
2785 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
2786
2787         Reviewed by Tony Chang.
2788
2789         This patch cleans up the logic used to shard tests into groups a
2790         bit and adds the --worker-model flag to NRWT. The flag is only
2791         used at the moment to control whether to run single-threaded or
2792         not, but eventually will also allow toggling between threads and
2793         processes.
2794
2795         Also add a minor cleanup with _test_is_slow(), which just
2796         eliminates some repetition and gives slightly better encapsulation.
2797
2798         https://bugs.webkit.org/show_bug.cgi?id=49773
2799
2800         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2801         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2802
2803 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
2804
2805         Reviewed by Tony Chang.
2806
2807         Rebaseline server: list current baselines and platforms
2808         https://bugs.webkit.org/show_bug.cgi?id=49991
2809         
2810         List existing baselines (with Trac links) for tests.
2811         
2812         Add dropdowns for choosing with platform baselines to target (and what
2813         to do with existing ones).
2814
2815         Also fix MockFileSystem.join to behave more like os.path.join (unit
2816         test was ending up with two consecutive slashes in a layout test
2817         path).        
2818
2819         * Scripts/webkitpy/common/system/filesystem_mock.py:
2820         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2821         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2822         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2823         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2824         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2825         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2826         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
2827
2828 2010-11-23  Ojan Vafai  <ojan@chromium.org>
2829
2830         Reviewed by Tony Chang.
2831
2832         remove timeout argument to urlopen
2833         https://bugs.webkit.org/show_bug.cgi?id=49995
2834
2835         Apparently the version of python we have on the bots doesn't accept a timeout argument.
2836
2837         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2838
2839 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2840
2841         Unreviewed, rolling out r72628.
2842         http://trac.webkit.org/changeset/72628
2843         https://bugs.webkit.org/show_bug.cgi?id=49994
2844
2845         This patch is causing layout-test failtures on GTK Linux
2846         64-bit Debug (Requested by ctguil on #webkit).
2847
2848         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2849         (AccessibilityUIElement::AccessibilityUIElement):
2850         (AccessibilityUIElement::parentElementCallback):
2851         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2852         * DumpRenderTree/chromium/CppBoundClass.cpp:
2853         * DumpRenderTree/chromium/CppBoundClass.h:
2854
2855 2010-11-22  Ojan Vafai  <ojan@chromium.org>
2856
2857         Reviewed by Tony Chang.
2858
2859         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
2860         https://bugs.webkit.org/show_bug.cgi?id=49944
2861
2862         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2863
2864 2010-11-23  Chris Guillory  <chris.guillory@google.com>
2865
2866         Reviewed by Dimitri Glazkov.
2867
2868         Include the FrameView widget of a RenderWidget in the accessibility tree.
2869         https://bugs.webkit.org/show_bug.cgi?id=49106
2870
2871         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2872         (AccessibilityUIElement::AccessibilityUIElement):
2873         (AccessibilityUIElement::parentElementCallback):
2874         (AccessibilityUIElement::isEqualCallback):
2875         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2876         * DumpRenderTree/chromium/CppBoundClass.cpp:
2877         (CppBoundClass::getFromCppVariant):
2878         * DumpRenderTree/chromium/CppBoundClass.h:
2879
2880 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
2881
2882         Reviewed by Kenneth Rohde Christiansen.
2883
2884         [EFL] Add tiled backing store to EWebLauncher
2885         https://bugs.webkit.org/show_bug.cgi?id=45777
2886
2887         Allow EWebLauncher to choose between single and tiled backing store
2888
2889         * EWebLauncher/main.c:
2890         (on_key_down):
2891         (browserCreate):
2892         (main):
2893
2894 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
2895
2896         Reviewed by Tor Arne Vestbø.
2897
2898         [Qt] Review the setUserPermission & friends API
2899         https://bugs.webkit.org/show_bug.cgi?id=46810
2900
2901         Renamed requestPermissionFromUser to featurePermissionRequested
2902         and cancelRequestsForPermission to featurePermissionRequestCanceled.
2903
2904         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2905         (WebCore::WebPage::WebPage):
2906         * QtTestBrowser/webpage.cpp:
2907         (WebPage::WebPage):
2908         (WebPage::featurePermissionRequestCanceled):
2909         * QtTestBrowser/webpage.h:
2910
2911 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
2912
2913         Reviewed by Tor Arne Vestbø.
2914
2915         [Qt] Review the setUserPermission & friends API
2916         https://bugs.webkit.org/show_bug.cgi?id=46810
2917
2918         Rename setUserPermission to setFeaturePermission
2919
2920         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2921         (WebCore::WebPage::requestPermission):
2922         (WebCore::WebPage::permissionSet):
2923         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2924         (LayoutTestController::grantDesktopNotificationPermission):
2925         * QtTestBrowser/webpage.cpp:
2926         (WebPage::requestPermission):
2927
2928 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
2929
2930         Reviewed by Tor Arne Vestbø.
2931
2932         [Qt] Review the setUserPermission & friends API
2933         https://bugs.webkit.org/show_bug.cgi?id=46810
2934
2935         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
2936         and GeolocationPermissionDomain to Geolocation.
2937
2938         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2939         (WebCore::WebPage::WebPage):
2940         (WebCore::WebPage::requestPermission):
2941         (WebCore::WebPage::cancelPermission):
2942         (WebCore::WebPage::permissionSet):
2943         (WebCore::DumpRenderTree::geolocationPermissionSet):
2944         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2945         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2946         (LayoutTestController::grantDesktopNotificationPermission):
2947         * QtTestBrowser/webpage.cpp:
2948         (WebPage::WebPage):
2949         (WebPage::requestPermission):
2950         (WebPage::cancelRequestsForPermission):
2951         * QtTestBrowser/webpage.h:
2952
2953 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
2954
2955         Reviewed by Tor Arne Vestbø.
2956
2957         [Qt] Review the setUserPermission & friends API
2958         https://bugs.webkit.org/show_bug.cgi?id=46810
2959
2960         Add a ByUser suffix to PermissionGranted/Denied. In the future
2961         we can add PermissionGrantedByDefault.
2962
2963
2964         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2965         (WebCore::WebPage::requestPermission):
2966         (WebCore::WebPage::permissionSet):
2967         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2968         (LayoutTestController::grantDesktopNotificationPermission):
2969         * QtTestBrowser/webpage.cpp:
2970         (WebPage::requestPermission):
2971
2972 2010-11-18  Satish Sampath  <satish@chromium.org>
2973
2974         Reviewed by Jeremy Orlow.
2975
2976         For speech input event, send an event object containing all the recognition results and metadata.
2977         https://bugs.webkit.org/show_bug.cgi?id=49736
2978
2979         Updated DRT by renaming the mock result method on all platforms to the new signature.
2980
2981         * DumpRenderTree/LayoutTestController.cpp:
2982         (addMockSpeechInputResultCallback):
2983         (LayoutTestController::staticFunctions):
2984         * DumpRenderTree/LayoutTestController.h:
2985         * DumpRenderTree/chromium/LayoutTestController.cpp:
2986         (LayoutTestController::LayoutTestController):
2987         (LayoutTestController::addMockSpeechInputResult):
2988         * DumpRenderTree/chromium/LayoutTestController.h:
2989         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2990         (LayoutTestController::addMockSpeechInputResult):
2991         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2992         (LayoutTestController::addMockSpeechInputResult):
2993         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2994         (LayoutTestController::addMockSpeechInputResult):
2995         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2996         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2997         (LayoutTestController::addMockSpeechInputResult):
2998         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2999         (LayoutTestController::addMockSpeechInputResult):
3000
3001 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
3002
3003         Reviewed by Tony Chang.
3004
3005         Fix some spacing issues with log messages with
3006         new-run-webkit-tests --verbose.
3007
3008         https://bugs.webkit.org/show_bug.cgi?id=49936
3009
3010         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3011
3012 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3013
3014         Reviewed by Adam Barth.
3015
3016         update scm to work with different remote branches
3017         https://bugs.webkit.org/show_bug.cgi?id=49949
3018
3019         This works if there are multiple svn tracking branches
3020         and/or if the tracking branch is refs/remots/origin/master
3021         instead of refs/remotes/trunk which is the direction we're trying
3022         to head since that makes fetches faster.
3023
3024         * Scripts/webkitpy/common/checkout/scm.py:
3025         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3026
3027 2010-11-22  Hayato Ito  <hayato@chromium.org>
3028
3029         Reviewed by Shinichiro Hamaji.
3030
3031         Ignore reference files which will be used by reftests when collecting
3032         test cases.
3033         https://bugs.webkit.org/show_bug.cgi?id=49835
3034
3035         * Scripts/webkitpy/layout_tests/port/test_files.py:
3036         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3037
3038 2010-11-22  Adam Roben  <aroben@apple.com>
3039
3040         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
3041
3042         Apple's Windows build allows placing header files and import libraries for WebKit's
3043         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
3044         $WebKitLibrariesDir environment variable. This is both required for production builds and
3045         convenient for Apple-internal developer builds. Apple's production builds also require that
3046         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
3047         builds, the files are copied into that directory tree by the
3048         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
3049         copying is done by
3050         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
3051
3052         This .vsprops copying is problematic in one very important case: when a developer updates
3053         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
3054         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
3055         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
3056         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
3057         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
3058         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
3059
3060         To fix this, we now use normal relative paths to access the .vsprops files in the source
3061         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
3062         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
3063         unset, so the normal relative paths are used to read the .vsprops files out of the source
3064         tree directly. In production builds, this environment variable is set to a fake directory
3065         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
3066         is resolved.
3067         
3068         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
3069
3070         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3071
3072         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
3073         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
3074         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
3075         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
3076         FeatureDefines.vsprops becomes:
3077
3078         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3079
3080         which resolves to:
3081
3082         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3083
3084         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
3085         actually exist since they are matched by an equal number of ".." path components.)
3086
3087         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
3088         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
3089
3090         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
3091         updated
3092
3093         Reviewed by Dave Hyatt.
3094
3095         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3096         * DumpRenderTree/win/DumpRenderTree.vcproj:
3097         * DumpRenderTree/win/ImageDiff.vcproj:
3098         * FindSafari/FindSafari.vcproj:
3099         * MiniBrowser/MiniBrowser.vcproj:
3100         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3101         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3102         * WebKitAPITest/WebKitAPITest.vcproj:
3103         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3104         * WebKitTestRunner/win/InjectedBundle.vcproj:
3105         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3106         * WinLauncher/WinLauncher.vcproj:
3107         * record-memory-win/record-memory-win.vcproj:
3108         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
3109         files.
3110
3111 2010-11-22  Adam Roben  <aroben@apple.com>
3112
3113         Make it possible to run tests on Windows without Visual Studio or VC++
3114         Express installed
3115
3116         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
3117         are not installed. But this function doesn't need to be called when we
3118         already have a build available and are just trying to run the tests.
3119
3120         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
3121         because Visual Studio/VC++ Express aren't installed
3122
3123         Reviewed by Dave Hyatt.
3124
3125         * Scripts/webkitdirs.pm:
3126         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
3127         it is not needed by this function. Also added a FIXME.
3128
3129         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
3130         relying on determineConfigurationForVisualStudio doing it.
3131
3132 2010-11-19  Hayato Ito  <hayato@chromium.org>
3133
3134         Reviewed by Shinichiro Hamaji.
3135
3136         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
3137
3138         https://bugs.webkit.org/show_bug.cgi?id=49812
3139
3140         * Scripts/webkitpy/layout_tests/driver_test.py:
3141         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3142         * Scripts/webkitpy/layout_tests/port/base.py:
3143         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3144         * Scripts/webkitpy/layout_tests/port/chromium.py:
3145         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3146         * Scripts/webkitpy/layout_tests/port/test.py:
3147         * Scripts/webkitpy/layout_tests/port/webkit.py:
3148         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3149         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3150
3151 2010-11-22  Hayato Ito  <hayato@chromium.org>
3152
3153         Reviewed by Tony Chang.
3154
3155         [NRWT] Retry a few times in reading a png image to avoid a race condition.
3156
3157         https://bugs.webkit.org/show_bug.cgi?id=49924
3158
3159         * Scripts/webkitpy/layout_tests/port/chromium.py:
3160
3161 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
3162
3163         Reviewed by Kenneth Rohde Christiansen.
3164
3165         Fix EWebLauncher zoom discretization
3166         https://bugs.webkit.org/show_bug.cgi?id=49810
3167
3168         * EWebLauncher/main.c:
3169         (nearest_zoom_level_get):
3170         (zoom_level_set):
3171         (on_load_finished):
3172         (on_key_down):
3173
3174 2010-11-21  Sam Weinig  <sam@webkit.org>
3175
3176         Rubber-stamped by Dan Bernstein.
3177
3178         Fix ~300 WebKit2 tests by enabling developer extras preference.
3179
3180         * WebKitTestRunner/TestController.cpp:
3181         (WTR::TestController::resetStateToConsistentValues):
3182
3183 2010-11-21  Sam Weinig  <sam@webkit.org>
3184
3185         Reviewed by Dan Bernstein.
3186
3187         Textareas should be resizable by default
3188         https://bugs.webkit.org/show_bug.cgi?id=49892
3189
3190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3191         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
3192         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3193         Add preferences test.
3194
3195 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
3196
3197         Reviewed by Tony Chang.
3198
3199         Rebaseline server: checksum-only differences and prefetching
3200         https://bugs.webkit.org/show_bug.cgi?id=49841
3201         
3202         Add support for image test results where the only difference is in the
3203         checksum.
3204         
3205         Add prefetching of the image results from the next test.
3206         
3207         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3208         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3209         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3210
3211 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3212
3213         Reviewed by Tony Chang.
3214
3215         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
3216
3217         Add the 'worker number' and 'worker name' concepts to the 
3218         TestShellThread objects, and move test_types and test_args from
3219         the TestRunner to the TestShellThread.
3220
3221         https://bugs.webkit.org/show_bug.cgi?id=49768
3222
3223         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3224         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3225
3226 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3227
3228         Reviewed by Ojan Vafai.
3229
3230         Do some minor cleanup and bug fixing.
3231
3232         https://bugs.webkit.org/show_bug.cgi?id=49777
3233
3234         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3235         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3236
3237 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3238
3239         Reviewed by Ojan Vafai.
3240
3241         nrwt - config.build_directory() is busted
3242
3243         Fixes a typo that was causing us to usually return the top level
3244         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
3245         bug was hidden by test stubs that were too simplistic :(.
3246
3247         https://bugs.webkit.org/show_bug.cgi?id=49815
3248
3249         * Scripts/webkitpy/common/system/executive_mock.py:
3250         * Scripts/webkitpy/layout_tests/port/config.py:
3251         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3252
3253 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3254
3255         Reviewed by Adam Roben.
3256
3257         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
3258         https://bugs.webkit.org/show_bug.cgi?id=49819
3259
3260         * DumpRenderTree/DumpRenderTree.sln:
3261         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3262         * DumpRenderTree/win/DumpRenderTree.vcproj:
3263         * DumpRenderTree/win/ImageDiff.vcproj:
3264         * FindSafari/FindSafari.vcproj:
3265         * MiniBrowser/MiniBrowser.vcproj:
3266         * TestWebKitAPI/win/TestWebKitAPI.sln:
3267         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3268         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3269         * WebKitAPITest/WebKitAPITest.vcproj:
3270         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3271         * WebKitTestRunner/win/InjectedBundle.vcproj:
3272         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3273         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3274         * WinLauncher/WinLauncher.vcproj:
3275         * record-memory-win/record-memory-win.vcproj:
3276
3277 2010-11-19  Adam Roben  <aroben@apple.com>
3278
3279         Add some more Windows slaves
3280
3281         This is probably more than we will be using in the immediate future,
3282         but having some extra slave names makes experimenting with different
3283         configurations easier.
3284
3285         Reviewed by Jon Honeycutt.
3286
3287         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
3288         Windows slaves and distributed them among the three different Test
3289         builders.
3290
3291 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
3292
3293         Reviewed by Ojan Vafai.
3294
3295         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3296         https://bugs.webkit.org/show_bug.cgi?id=49702
3297
3298         Re-landing r72357 with a test fix.
3299
3300         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3301         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3302         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3303
3304 2010-11-19  Avi Drissman  <avi@google.com>
3305
3306         Reviewed by Antonio Gomes.
3307
3308         Complete support for Unix editing mode
3309         https://bugs.webkit.org/show_bug.cgi?id=49757
3310
3311         * DumpRenderTree/LayoutTestController.cpp:
3312         (setEditingBehaviorCallback):
3313         * DumpRenderTree/chromium/LayoutTestController.cpp:
3314         (LayoutTestController::setEditingBehavior):
3315
3316 2010-11-19  Adam Roben  <aroben@apple.com>
3317
3318         Fix run-javascriptcore-tests when there's a space in the path to
3319         testapi
3320
3321         Reviewed by Sam Weinig.
3322
3323         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
3324         system() to force it to interpret spaces in the path correctly.
3325
3326 2010-11-19  Adam Roben  <aroben@apple.com>
3327
3328         Update scripts for .exe name changes after r72327
3329
3330         As of r72327, the "_debug" suffix is only used in Debug_All builds.
3331
3332         Reviewed by Sam Weinig.
3333
3334         * Scripts/run-javascriptcore-tests:
3335         (testapiPath):
3336
3337         * Scripts/sunspider-compare-results:
3338         (pathToBuiltJSC):
3339
3340         * Scripts/webkitdirs.pm:
3341         (jscPath):
3342         (safariPath):
3343
3344 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3345
3346         Reviewed by Darin Adler.
3347
3348         Normalize Cairo/CFLite project/solution configuration names
3349         https://bugs.webkit.org/show_bug.cgi?id=49818
3350
3351         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3352         * DumpRenderTree/win/DumpRenderTree.vcproj:
3353         * DumpRenderTree/win/ImageDiff.vcproj:
3354         * MiniBrowser/MiniBrowser.vcproj:
3355         * TestWebKitAPI/win/TestWebKitAPI.sln:
3356         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3357         * WebKitAPITest/WebKitAPITest.vcproj:
3358         * WebKitTestRunner/win/InjectedBundle.vcproj:
3359         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3360         * WinLauncher/WinLauncher.vcproj:
3361         * Scripts/webkitdirs.pm: Updated cairo build configs.
3362
3363 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3364
3365         Reviewed by Adam Roben.
3366
3367         Windows vcproj configuration names should be normalized across projects
3368         https://bugs.webkit.org/show_bug.cgi?id=49776
3369
3370         * DumpRenderTree/DumpRenderTree.sln:
3371         * FindSafari/FindSafari.vcproj:
3372         * TestWebKitAPI/win/TestWebKitAPI.sln:
3373         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3374         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
3375         * WebKitAPITest/WebKitAPITest.vcproj:
3376         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3377         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3378         * WebKitTestRunner/WebKitTestRunner.sln:
3379         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3380         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
3381         * record-memory-win/record-memory-win.vcproj:
3382
3383 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3384
3385         Build fix - as per DRT-mac, always enabled developer extras,
3386         in win/qt/gtk DRT.
3387
3388         This is necessary to enable rich exception messages to be generated
3389         following https://bugs.webkit.org/show_bug.cgi?id=49708.
3390
3391         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3392         (shouldEnableDeveloperExtras):
3393         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3394         (WebCore::shouldEnableDeveloperExtras):
3395         * DumpRenderTree/win/DumpRenderTree.cpp:
3396         (shouldEnableDeveloperExtras):
3397
3398 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
3399
3400         Unreviewed, rolling out r72357.
3401         http://trac.webkit.org/changeset/72357
3402         https://bugs.webkit.org/show_bug.cgi?id=49784
3403
3404         It broke test-webkitpy tests since the patch didn't have the
3405         corresponding test update (Requested by kinuko on #webkit).
3406
3407         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3408         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3409
3410 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
3411
3412         Reviewed by Tony Chang.
3413
3414         Rebaseline server: add rebaseline queue
3415         https://bugs.webkit.org/show_bug.cgi?id=49763
3416         
3417         Add a UI queue (a multi-item <select>) where tests to be baselined
3418         can be enqueued (also supports basic removal). A queue is used instead
3419         of immediately doing rebaselines since SCM operations can take a while.
3420         It's better to go through lots of tests quickly to mark them as
3421         needing rebaselining and then batch the SCM operations.
3422         
3423         Also adds a simple log where results can be displayed.
3424
3425         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3426         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3427         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3428         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
3429         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3430         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3431
3432 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3433
3434         Reviewed by Oliver Hunt.
3435
3436         Bug 49708 - Stop recompiling functions to regenerate exception info.
3437
3438         Instead only hold info as necessary – keep divot info is the inspector
3439         is enabled, line number info is debugging or profiling, and handler
3440         info for functions with try/catch.
3441
3442         * DumpRenderTree/mac/DumpRenderTree.mm:
3443         (shouldEnableDeveloperExtras):
3444             - always enable the developer tools from DRT, to ensure we
3445               produce rich error messages on JavaScript exceptions.
3446
3447 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
3448
3449         Reviewed by Ojan Vafai.
3450
3451         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3452         https://bugs.webkit.org/show_bug.cgi?id=49702
3453
3454         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3455         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3456
3457 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
3458
3459         Reviewed by Tony Chang.
3460
3461         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
3462
3463         Create the first version of the 'message_broker' package. This
3464         class will encapsulate all of the threading/multiprocessing and
3465         message-sending details for the communication between the
3466         'manager' object and the 'worker' objects. For the moment, it
3467         just holds some routines and tests for logging thread stacks.
3468
3469         There should be no functional changes in this patch, just moving stuff
3470         around.
3471
3472         https://bugs.webkit.org/show_bug.cgi?id=49707
3473
3474         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3475         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
3476         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
3477         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
3478         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3479         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3480
3481 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3482
3483         Reviewed by Adam Roben.
3484
3485         Remove leftover Windows Debug_Internal configurations
3486         https://bugs.webkit.org/show_bug.cgi?id=49758
3487
3488         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3489         * DumpRenderTree/win/DumpRenderTree.vcproj:
3490         * DumpRenderTree/win/ImageDiff.vcproj:
3491         * MiniBrowser/MiniBrowser.vcproj:
3492         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3493         * WebKitAPITest/WebKitAPITest.vcproj:
3494         * WebKitTestRunner/win/InjectedBundle.vcproj:
3495         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3496         * WinLauncher/WinLauncher.vcproj:
3497
3498 2010-11-18  Adam Roben  <aroben@apple.com>
3499
3500         Add three new Windows XP build slaves
3501
3502         Reviewed by Steve Falkenburg.
3503
3504         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
3505         new slaves, and added them to the Windows XP Debug (Tests) builder.
3506
3507 2010-11-18  Daniel Bates  <dbates@rim.com>
3508
3509         Reviewed by Adam Roben.
3510
3511         update-webkit-support-libs should fall back to existing
3512         WebKitSupportLibrary version if there is no internet connectivity
3513         https://bugs.webkit.org/show_bug.cgi?id=49503
3514
3515         Fall back to existing support libraries (if present) when there is
3516         no internet connection.
3517
3518         Currently, update-webkit-support-libs dies with an "out-of-date"
3519         error when there is no internet connection because it cannot
3520         retrieve versioning information from developer.apple.com. Because
3521         update-webkit-support-libs fails, build-webkit fails. Instead,
3522         if there is no internet connection and the support libraries are
3523         present then we should warn the user and exit() with success so
3524         that build-webkit can work without an internet connection.
3525
3526         * Scripts/update-webkit-support-libs:
3527
3528 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3529
3530         Reviewed by Adam Roben.
3531
3532         Debug_Internal Windows configuration is unnecessary, should be removed
3533         https://bugs.webkit.org/show_bug.cgi?id=49753
3534
3535         * DumpRenderTree/win/DumpRenderTree.cpp:
3536         * MiniBrowser/win/stdafx.h:
3537         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3538         * WebKitTestRunner/win/TestControllerWin.cpp:
3539
3540 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3541
3542         Reviewed by Adam Roben.
3543
3544         Clean up vcproj errors
3545         https://bugs.webkit.org/show_bug.cgi?id=49741
3546
3547         * MiniBrowser/MiniBrowser.vcproj:
3548         * WebKitAPITest/WebKitAPITest.vcproj:
3549         * WebKitTestRunner/win/InjectedBundle.vcproj:
3550         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3551
3552 2010-11-18  Hayato Ito  <hayato@chromium.org>
3553
3554         Reviewed by Shinichiro Hamaji.
3555
3556         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
3557         which is caused by r72249.
3558
3559         https://bugs.webkit.org/show_bug.cgi?id=49751
3560
3561         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3562
3563 2010-11-18  Adam Roben  <aroben@apple.com>
3564
3565         Implement layoutTestController.waitForPolicyDelegate on Windows
3566
3567         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>