Set the font smoothing preference in DRT
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-11-25  Adam Roben  <aroben@apple.com>
2
3         Set the font smoothing preference in DRT
4
5         This makes the pixel results on Windows closer to the Mac results.
6
7         Reviewed by Mitz.
8
9         * DumpRenderTree/win/DumpRenderTree.cpp:
10         (initializePreferences):
11
12 2007-11-25  Adam Roben  <aroben@apple.com>
13
14         Port ImageDiff to CG and C++
15
16         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
17         <rdar://5071708>
18
19         Reviewed by Sam.
20
21         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
22         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
23         (main):
24         (createImageFromStdin):
25         (compareImages):
26         (getDifferenceBitmap):
27         (computePercentageDifferent):
28         * DumpRenderTree/win/ImageDiff.vcproj: Added.
29
30 2007-11-25  Adam Roben  <aroben@apple.com>
31
32         Fix image diff link generation on Windows
33
34         Reviewed by Sam.
35
36         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
37         to toURL.
38
39 2007-11-25  Adam Roben  <aroben@apple.com>
40
41         Implement pixel dumping in Windows DRT
42
43         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
44         <rdar://5071708>
45
46         Reviewed by Sam.
47
48         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
49         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
50         Content-Length header.
51         (getMD5HashStringForBitmap):
52         (dumpWebViewAsPixelsAndCompareWithExpected):
53         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
54         * DumpRenderTree/win/DumpRenderTree.cpp:
55         (dump): Do a pixel dump if requested.
56         (main): Parse pixel test options.
57         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
58         the cg/ subdirectory to the include path.
59         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
60         available in a header or import library, so we have to go through this
61         LoadLibrary/GetProcAddress dance to use them.
62         (cryptDLL):
63         (init):
64         (update):
65         (final):
66         (MD5_Init):
67         (MD5_Update):
68         (MD5_Final):
69         * DumpRenderTree/win/MD5.h: Added.
70         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
71         moved up to the top level to share it with Mac eventually.
72         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
73         (getBitmapContextFromWebView): Forces the WebView to paint using a
74         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
75
76 2007-11-25  Adam Roben  <aroben@apple.com>
77
78         Clean up Windows DRT's option parsing a little bit
79
80         Reviewed by Sam.
81
82         * DumpRenderTree/win/DumpRenderTree.cpp:
83         (main): Put non-option arguments into a Vector.
84
85 2007-11-25  Adam Roben  <aroben@apple.com>
86
87         Make Windows DRT stop changing LF into CRLF
88
89         Reviewed by Sam.
90
91         * DumpRenderTree/win/DumpRenderTree.cpp:
92         (main): Put stdout in binary mode.
93         * Scripts/run-webkit-tests: Remove the CRLF hack.
94
95 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
96
97         Removed empty directory.
98
99         * Scripts/resources: Removed.
100
101 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
102
103         Fix bisect-builds to work with recent WebKit nightly builds.
104
105         Reviewed by Dan.
106
107         * Scripts/bisect-builds: Check for the 
108         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
109         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
110         to WebKit.app/Contents/Resources.
111
112 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
113
114         Reviewed by Maciej.
115
116         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
117         not closed (affects digg.com)
118
119         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
120         one after finishing with a test to avoid having its delayed onload handler firing when
121         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
122         but it helps somewhat.
123
124 2007-11-22  Mark Rowe  <mrowe@apple.com>
125
126         Reviewed by Alp Toker.
127
128         Fix build-webkit to propagate make's exit status if it fails.
129
130         * Scripts/webkitdirs.pm:
131
132 2007-11-22  Dan Bernstein  <mitz@apple.com>
133
134         Reviewed by Mark Rowe.
135
136         - fix crash when running pixel tests
137
138         * DumpRenderTree/mac/DumpRenderTree.mm:
139         (dumpRenderTree): Parse the command line options before setting up the
140         environment so that we know if we need to set up the pixel dump
141         machinery.
142
143 2007-11-21  Eric Seidel  <eric@webkit.org>
144
145         Speculative build fix for Tiger.
146
147         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
148
149 2007-11-21  Eric Seidel  <eric@webkit.org>
150
151         Reviewed by Tim Hatcher.
152
153         Break out more of DumpRenderTree.mm into individual files
154
155         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
156         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
157         (checkedMalloc):
158         (checkedRealloc):
159         (makeLargeMallocFailSilently):
160         * DumpRenderTree/mac/CheckedMalloc.h: Added.
161         * DumpRenderTree/mac/DumpRenderTree.mm:
162         (crashHandler):
163         (dump):
164         * DumpRenderTree/mac/DumpRenderTreeMac.h:
165         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
166         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
167         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
168         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
169         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
170         (javaScriptThreads):
171         (runJavaScriptThread):
172         (startJavaScriptThreads):
173         (stopJavaScriptThreads):
174         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
175         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
176         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
177         (restoreColorSpace):
178         (setDefaultColorProfileToRGB):
179         (initializeColorSpaceAndScreeBufferForPixelTests):
180         (md5HashStringForBitmap):
181         (dumpWebViewAsPixelsAndCompareWithExpected):
182
183 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
184
185         Move install-unix-extras to wx directory as it seems only to be used by that 
186         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
187         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
188         have install-unix-extras install into WebKitLibraries as per
189         convention.
190         
191         Reviewed by Mark Rowe.
192
193         * Scripts/install-unix-extras: Removed.
194         * wx/build-wxwebkit:
195         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
196
197 2007-11-21  Eric Seidel  <eric@webkit.org>
198
199         Reviewed by Adam.
200
201         More refactoring for greater code readability
202
203         * DumpRenderTree/mac/DumpRenderTree.mm:
204         (initializeGlobalsFromCommandLineOptions):
205         (initializeColorSpaceAndScreeBufferForPixelTests):
206         (addTestPluginsToPluginSearchPath):
207         (useLongRunningServerMode):
208         (runTestingServerLoop):
209         (prepareConsistentTestingEnvironment):
210         (dumpRenderTree):
211         (main):
212         (dumpFramesAsText):
213         (dumpBackForwardListForWebView):
214         (sizeWebViewForCurrentTest):
215         (methodNameStringForFailedTest):
216         (dumpBackForwardListForAllWindows):
217         (dumpWebViewAsPixelsAndCompareWithExpected):
218         (invalidateAnyPreviousWaitToDumpWatchdog):
219         (dump):
220         * DumpRenderTree/mac/DumpRenderTreeMac.h:
221         * DumpRenderTree/mac/UIDelegate.mm:
222         (-[UIDelegate webView:createWebViewWithRequest:]):
223
224 2007-11-21  Eric Seidel  <eric@webkit.org>
225
226         Reviewed by Tim Hatcher.
227
228         Abstract more of DRT into static methods
229
230         * DumpRenderTree/mac/DumpRenderTree.mm:
231         (setDefaultsToConsistentValuesForTesting):
232         (setupSignalHandlers):
233         (allocateGlobalControllers):
234         (releaseAndZero):
235         (releaseGlobalControllers):
236         (dumpRenderTree):
237         (shouldLogFrameLoadDelegates):
238         (createCFURLFromPathOrURL):
239         (resetWebViewToConsistentStateBeforeTesting):
240         (runTest):
241
242 2007-11-21  Eric Seidel  <eric@webkit.org>
243
244         Reviewed by Tim Hatcher.
245
246         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
247
248         * DumpRenderTree/DumpRenderTree.h:
249         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
250         * DumpRenderTree/mac/DumpRenderTree.mm:
251         (dumpRenderTree):
252         (dump):
253         (runTest):
254         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
255         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
256         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
257         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
258         (-[DumpRenderTreePasteboard declareType:owner:]):
259         (+[LocalPasteboard alloc]):
260         (-[LocalPasteboard init]):
261         (-[LocalPasteboard dealloc]):
262         (-[LocalPasteboard name]):
263         (-[LocalPasteboard releaseGlobally]):
264         (-[LocalPasteboard declareTypes:owner:]):
265         (-[LocalPasteboard addTypes:owner:]):
266         (-[LocalPasteboard changeCount]):
267         (-[LocalPasteboard types]):
268         (-[LocalPasteboard availableTypeFromArray:]):
269         (-[LocalPasteboard setData:forType:]):
270         (-[LocalPasteboard dataForType:]):
271         (-[LocalPasteboard setPropertyList:forType:]):
272         (-[LocalPasteboard setString:forType:]):
273         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
274         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
275         (+[DumpRenderTreeWindow allWindows]):
276         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
277         (-[DumpRenderTreeWindow dealloc]):
278         (-[DumpRenderTreeWindow isKeyWindow]):
279         (-[DumpRenderTreeWindow keyDown:]):
280
281 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
282
283         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
284         it indiscriminately copies any headers inside JavaScriptCore,
285         which includes Tiger ICU headers. 
286
287         * wx/build-wxwebkit:
288         Don't run WebCore/move-js-headers.sh any longer.
289
290 2007-11-20  Adam Treat  <treat@kde.org>
291
292         Reviewed by David Kilzer.
293
294         * Prepend git branch name to $baseProductDir
295
296         * Scripts/VCSUtils.pm:
297         * Scripts/webkitdirs.pm:
298
299 2007-11-20  Mark Rowe  <mrowe@apple.com>
300
301         Reviewed by Simon Hausmann.
302
303         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
304         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
305         Have it trigger a "make distclean" rather than "make clean" to ensure that the
306         built product and generated Makefile's are removed.
307
308 2007-11-19  Alp Toker  <alp@atoker.com>
309
310         Reviewed by Mark Rowe.
311
312         http://bugs.webkit.org/show_bug.cgi?id=16040
313         [GTK] GtkLauncher should be written in C
314
315         Port GtkLauncher to plain C.
316
317         Use a more conventional GTK+ coding style.
318
319         Use a toolbar instead of menus.
320
321         Various signature fixes and cleanups.
322
323         Add a license header. Assume all previous modifications were copyright
324         assigned to Apple Inc. by default.
325
326         * GtkLauncher/GtkLauncher.pro:
327         * GtkLauncher/main.c: Added.
328         (activate_url_entry_cb):
329         (update_title):
330         (link_hover_cb):
331         (title_change_cb):
332         (progress_change_cb):
333         (destroy_cb):
334         (go_back_cb):
335         (go_forward_cb):
336         (create_browser):
337         (create_statusbar):
338         (create_toolbar):
339         (create_window):
340         (main):
341         * GtkLauncher/main.cpp: Removed.
342
343 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
344
345         Build script fixes to ensure they do the right thing for the 
346         wx port, and update build-wxwebkit to reflect the way the
347         build scripts now work.
348
349         Reviewed by Adam.
350
351         * Scripts/build-testkjs:
352         * Scripts/build-webkit:
353         * Scripts/run-javascriptcore-tests:
354         * Scripts/webkitdirs.pm:
355         * wx/build-wxwebkit:
356
357 2007-11-18  Eric Seidel  <eric@webkit.org>
358
359         Reviewed by Anders.
360
361         Make run-javascriptcore-tests report failures on exit (to support git bisect)
362
363         * Scripts/run-javascriptcore-tests:
364
365 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
366
367         Reviewed by Adam Roben.
368
369         Make run-webkit-tests work with Windows debug build.
370
371         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
372         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
373         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
374         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
375         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
376
377 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
378
379         Add wxWebKit sample and build script, and integrate it with 
380         build-webkit. Also make build-webkit --clean work for all
381         ports.
382
383         Reviewed by Darin Adler.
384
385         * Scripts/build-webkit:
386         * Scripts/webkitdirs.pm:
387         * wx: Added.
388         * wx/browser: Added.
389         * wx/browser/browser.bkl: Added.
390         * wx/browser/browser.cpp: Added.
391         * wx/build-wxwebkit: Added.
392
393 2007-11-17  Adam Roben  <aroben@apple.com>
394
395         Make it easy to run Safari in the debugger on Windows
396
397         I've added a new script, debug-safari, which launches Safari in the
398         debugger. On OS X it just calls gdb-safari.
399
400         Reviewed by Mark Rowe.
401
402         * FindSafari/FindSafari.cpp:
403         (_tmain): Added a /debugger flag, which in combination with
404         /printSafariLauncher will print a script that launches Safari in the
405         debugger.
406         * Scripts/debug-safari: Added.
407         * Scripts/run-safari: Changed to call runSafari().
408         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
409         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
410         first argument along to FindSafari.
411         * Scripts/webkitdirs.pm:
412         (sub runSafari): Added.
413
414 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
415
416         Reviewed by Adam Roben.
417
418         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
419
420 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
421
422         Reviewed by David Kilzer.
423
424         The git config command was renamed to repo-config at some point. This
425         change tries git config and then git repo-config if the first fails.
426
427         * Scripts/prepare-ChangeLog:
428         (gitConfig):
429
430 2007-11-16  Dan Bernstein  <mitz@apple.com>
431
432         Reviewed by Darin Adler and Sam Weinig.
433
434         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
435
436         * DumpRenderTree/win/EventSender.cpp:
437         (keyDownCallback): For characters that cannot be entered on the active
438         keyboard layout, send a WM_CHAR message with the character along with
439         a WM_KEYDOWN message with a virtual key code of 255.
440
441 2007-11-16  Mark Rowe  <mrowe@apple.com>
442
443         Reviewed by Tim Hatcher.
444
445         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
446
447         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
448         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
449
450 2007-11-15  Adam Roben  <aroben@apple.com>
451
452         Make run-safari actually work on Windows
453
454         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
455         chdir call.
456
457 2007-11-14  Adam Roben  <aroben@apple.com>
458
459         Updates to Safari launching now that 3.0.4 is released
460
461         Reviewed by Sam.
462
463         * FindSafari/FindSafari.cpp:
464         (getWebViewCLSID): Use version-independent ProgID.
465         * Scripts/run-safari: Use run-webkit-nightly.cmd.
466
467 2007-11-14  Anders Carlsson  <andersca@apple.com>
468
469         Reviewed by Adam.
470
471         <rdar://problem/5309081>
472         In DRT, "plugin.logDestroy = true" not working on Windows.
473         
474         * DumpRenderTree/win/TestNetscapePlugin/main.c:
475         (NPP_Destroy):
476
477 2007-11-14  Eric Seidel  <eric@webkit.org>
478
479         Reviewed by Sam.
480
481         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
482
483 2007-11-14  Anders Carlsson  <andersca@apple.com>
484
485         Reviewed by Adam.
486
487         <rdar://problem/5141186>
488         window.layoutTestController.setWindowIsKey is not implemented in DRT.
489         
490         Implement setWindowIsKey.
491         
492         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
493         (LayoutTestController::setWindowIsKey):
494
495 2007-11-13  Sam Weinig  <sam@webkit.org>
496
497         Reviewed by Adam Roben.
498
499         Fix for <rdar://problem/5382579>
500         http/tests/security/cross-frame-access-put.html reports large 
501         negative numbers for screenLeft and screenTop (Mac reports "0")
502
503         * DumpRenderTree/win/UIDelegate.cpp:
504         (UIDelegate::UIDelegate): Initialize the RECT.
505         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
506         (UIDelegate::webViewFrame): ditto.
507         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
508
509 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
510
511         Reviewed by Adam.
512
513         - Make Drosera show source, source URLs, and function stack on Windows,
514         and some minor fixes.
515
516         * Drosera/DebuggerDocument.cpp: Force source to always update display.
517         (DebuggerDocument::updateFileSource):
518         * Drosera/debugger.js: Force source to always update display.
519         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
520         menu controls.
521         (DebuggerClient::resume):
522         (DebuggerClient::pause):
523         (DebuggerClient::stepInto):
524         (DebuggerClient::stepOver):
525         (DebuggerClient::stepOut):
526         (DebuggerClient::showConsole):
527         (DebuggerClient::closeCurrentFile):
528         * Drosera/win/DebuggerClient.h: Ditto.
529         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
530         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
531         removed two bugs.  1) caller could be in a bad state when asked to
532         assign into it. 2) BSTRs were not created correctly.
533         (DebuggerDocument::getPlatformCurrentFunctionStack):
534         * Drosera/win/Drosera.cpp: Hook up the menu controls.
535         (droseraWndProc):
536         (handleCommand):
537         (Drosera::resume):
538         (Drosera::pause):
539         (Drosera::stepInto):
540         (Drosera::stepOver):
541         (Drosera::stepOut):
542         (Drosera::showConsole):
543         (Drosera::closeCurrentFile):
544         * Drosera/win/Drosera.h: Hook up the menu controls.
545         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
546         functions, added a null check, and fixed another bug where caller could
547         be in a bad state when asked to assign into it.
548         (ServerConnection::didLoadMainResourceForDataSource):
549         (ServerConnection::getCallerFrame):
550         * Drosera/win/ServerConnection.h: Safety first.
551
552 2007-11-13  Dan Bernstein  <mitz@apple.com>
553
554         Reviewed by Darin Adler.
555
556         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
557           DumpRenderTree --pixel-tests renders each test twice
558
559         * DumpRenderTree/mac/DumpRenderTree.mm:
560         (dumpRenderTree): Removed the --paint option because the painting code
561         is always exercised as a result of
562         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
563         calling -displayIfNeeded.
564         (dump): Changed to always grab the image from the window since the view
565         is always displayed.
566         (runTest):
567         (displayWebView):
568         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
569         because it always paints.
570
571 2007-11-12  Antti Koivisto  <antti@apple.com>
572
573         Reviewed by Adele.
574         
575         Add support for http media tests
576
577         * Scripts/run-webkit-tests:
578
579 2007-11-12  Sam Weinig  <sam@webkit.org>
580
581         Reviewed by Adam Roben.
582
583         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
584
585         * DumpRenderTree/win/DumpRenderTree.cpp:
586         (runTest):
587         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
588         (LayoutTestController::setPrivateBrowsingEnabled):
589
590 2007-11-12  Adam Roben  <aroben@apple.com>
591
592         * Scripts/update-webkit-localizable-strings: Changed to only scan the
593         mac and win subdirectories.
594
595 2007-11-11  Adam Roben  <aroben@apple.com>
596
597         Fix <rdar://5133816> keepWebHistory is not implemented
598
599         Fixes fast/history/clicked-link-is-visited.html.
600
601         Reviewed by Darin.
602
603         * DumpRenderTree/win/DumpRenderTree.cpp:
604         (runTest): Clear the optionalSharedHistory.
605         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
606         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
607
608 2007-11-10  Sam Weinig  <sam@webkit.org>
609
610         Reviewed by Tim Hatcher.
611
612         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
613         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
614         is turned on)
615
616         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
617
618         Added test: http/tests/security/cross-frame-access-private-browsing.html
619
620         * DumpRenderTree/LayoutTestController.cpp:
621         (setPrivateBrowsingEnabledCallback):
622         (LayoutTestController::staticFunctions):
623         * DumpRenderTree/LayoutTestController.h:
624         * DumpRenderTree/mac/DumpRenderTree.mm:
625         (runTest): Default to private browsing disabled.
626         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
627         (LayoutTestController::setPrivateBrowsingEnabled):
628         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
629         (LayoutTestController::setPrivateBrowsingEnabled):
630
631 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
632
633         Reviewed by Adam.
634
635         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
636         WebCore's!
637
638         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
639         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
640         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
641         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
642         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
643         * Drosera/win/Drosera.cpp:
644         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
645
646 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
647
648         Reviewed by Sam.
649
650         - Use the new IWebFrame [local] function signature and get the shared
651         server correctly.
652
653         * Drosera/win/DebuggerClient.cpp:
654         (DebuggerClient::didFinishLoadForFrame):
655         * Drosera/win/ServerConnection.cpp:
656         (ServerConnection::attemptToCreateServerConnection):
657
658 2007-11-07  Dan Bernstein  <mitz@apple.com>
659
660         Reviewed by Darin Adler.
661
662         - add an option to run-webkit-tests to ignore pixel test failures where
663           all pixels differ by no more than a specified threshold
664
665         * DumpRenderTree/mac/ImageDiff.m:
666         (main):
667         (compareImages):
668         (computePercentageDifferent):
669         * Scripts/run-webkit-tests:
670
671 2007-11-07  Simon Hausmann  <hausmann@kde.org>
672
673         Reviewed by Lars.
674
675         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
676
677         * DumpRenderTree/qt/DumpRenderTree.cpp:
678
679 2007-11-07  Simon Hausmann  <hausmann@kde.org>
680
681         Reviewed by Lars.
682
683         Reworked the QWebSettings API.
684         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
685
686         * DumpRenderTree/qt/DumpRenderTree.cpp:
687
688 2007-11-07  Simon Hausmann  <hausmann@kde.org>
689
690         Reviewed by Lars.
691
692         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
693
694         * DumpRenderTree/qt/jsobjects.cpp:
695
696 2007-11-07  Simon Hausmann  <hausmann@kde.org>
697
698         Reviewed by Lars Knoll <lars@trolltech.com>.
699
700         Add a QWebPage::frameCreated() signal and fix DRT
701         
702         The removal of createFrame in QWebPage broke the re-implementation
703         in DumpRenderTree. Instead emit a frameCreated() signal and
704         connect to it in DumpRenderTree.
705         
706
707         * DumpRenderTree/qt/DumpRenderTree.cpp:
708         (WebCore::WebPage::WebPage):
709         (WebCore::DumpRenderTree::dump):
710         (WebCore::DumpRenderTree::connectFrame):
711         * DumpRenderTree/qt/DumpRenderTree.h:
712
713 2007-11-07  Simon Hausmann  <hausmann@kde.org>
714
715         Reviewed by Lars Knoll <lars@trolltech.com>.
716
717         Moved all the event handlers from QWebFrame into QWebPage.
718         
719         This cleans up the public API and allows us to remove the
720         HackWebFrame hack in DumpRenderTree.
721         
722
723         * DumpRenderTree/qt/jsobjects.cpp:
724         (EventSender::mouseDown):
725         (EventSender::mouseUp):
726         (EventSender::mouseMoveTo):
727
728 2007-11-07  Simon Hausmann  <hausmann@kde.org>
729
730         Reviewed by Mark.
731
732         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
733         to prevent the default implementation from popping up messageboxes.
734
735         * DumpRenderTree/qt/DumpRenderTree.cpp:
736         (WebCore::WebPage::javaScriptConfirm):
737         (WebCore::WebPage::javaScriptPrompt):
738
739 2007-11-06  Eric Seidel  <eric@webkit.org>
740
741         * Scripts/build-testkjs: build fix... too many $$
742
743 2007-11-06  Eric Seidel  <eric@webkit.org>
744
745         Reviewed by Mark Rowe.
746
747         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
748
749 2007-11-05  Adam Roben  <aroben@apple.com>
750
751         Add support on Windows for WEBKIT_TESTFONTS
752
753         This environment variable lets you specify where the fonts to be used
754         by DumpRenderTree reside. The Qt port is already using this, so I'm
755         just following their lead.
756
757         Reviewed by Darin.
758
759         * DumpRenderTree/win/DumpRenderTree.cpp:
760         (exePath): Refactored code out of initialize().
761         (fontsPath): Returns either $WEBKIT_TESTFONTS or
762         DumpRenderTree.resources.
763         (initialize): Use the new fontsPath function.
764         (main): Use the new exePath function.
765         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
766         variable to DRT, like Qt does.
767
768 2007-11-05  Mark Rowe  <mrowe@apple.com>
769
770         Rubber-stamped by Alp Toker.
771
772         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
773
774         * GtkLauncher/main.cpp:
775         (goToURLBarText):
776         (main):
777
778 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
779
780         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
781         <http://bugs.webkit.org/show_bug.cgi?id=15830>
782
783         Reviewed by Timothy.
784
785         Restrict the range of nightly builds used by the bisect-builds script
786         based on the version of Safari and the version of Mac OS X being used.
787
788         Mac OS X 10.4: Safari 2.0: r11976 or newer
789         Mac OS X 10.4: Safari 3.0: r19992 or newer
790
791         Mac OS X 10.5: Safari 2.0: r19594 or newer
792         Mac OS X 10.5: Safari 3.0: r25124 or newer
793
794         * Scripts/bisect-builds:
795         (findMacOSXVersion): Added.
796         (makeNightlyList): Added argument to provide version of Mac OS X.
797         Restrict range of nightly builds based on Safari and Mac OS X versions.
798
799 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
800
801         Reviewed by Maciej.
802
803         - This patch involves several changes, all of them were noticed that
804         they were needed by the work being done in WebKit to get Drosera and
805         WebKit working together on Windows.
806         - The changes are:
807         1) Added a debugger console for output messages.
808         2) Drosera now listens for the WebKit server (before, the server would
809         have to be running before Drosera was started.)
810         3) Fixed a bug where the WebView started out as 0x0 pixels.
811         4) Fixed a bug when there is no scope.
812         5) Added the HTML, JS, and CSS to the project file to make them easy to
813         find.
814         6) Made the ServerConnection functions virtual.
815
816         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
817         for the WebKit server.
818         (DebuggerClient::DebuggerClient):
819         (DebuggerClient::~DebuggerClient):
820         (DebuggerClient::didFinishLoadForFrame):
821         (DebuggerClient::serverConnected):
822         (DebuggerClient::attemptToCreateServerConnection):
823         * Drosera/win/DebuggerClient.h: Ditto.
824         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
825         scope.
826         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
827         (DebuggerDocument::platformValueForScopeVariableNamed):
828         * Drosera/win/Drosera.cpp:
829         (_tWinMain): Added a console in debug for output messages.
830         (Drosera::Drosera): Listen for server.
831         (Drosera::initUI): The server now Initializes COM.
832         (Drosera::serverConnected): Part of the listening for the server.
833         (Drosera::attemptToCreateServerConnection): Ditto.
834         * Drosera/win/Drosera.h: New interface for listening for the server.
835         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
836         files to the VS project.
837         * Drosera/win/ServerConnection.cpp: Part of listening for the server
838         connection.
839         (ServerConnection::ServerConnection):
840         (ServerConnection::attemptToCreateServerConnection):
841         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
842         methods.
843         (ServerConnection::serverConnected):
844
845 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
846
847         Reviewed by Maciej.
848
849         http://bugs.webkit.org/show_bug.cgi?id=15832
850         fast/dom/gc-10.html crashes when run alone
851
852         Check for !done before using objects that can be already deallocated.
853
854         * DumpRenderTree/mac/EditingDelegate.mm:
855         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
856         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
857         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
858         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
859         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
860         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
861         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
862         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
863         (-[EditingDelegate webViewDidBeginEditing:]):
864         (-[EditingDelegate webViewDidChange:]):
865         (-[EditingDelegate webViewDidEndEditing:]):
866         (-[EditingDelegate webViewDidChangeTypingStyle:]):
867         (-[EditingDelegate webViewDidChangeSelection:]):
868         * DumpRenderTree/mac/FrameLoadDelegate.mm:
869         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
870         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
871         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
872         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
873         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
874         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
875         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
876         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
877         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
878         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
879         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
880         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
881         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
882         (-[FrameLoadDelegate webView:willCloseFrame:]):
883         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
884         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
885         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
886         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
887         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
888         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
889         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
890         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
891         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
892
893 2007-11-04  Mark Rowe  <mrowe@apple.com>
894
895         Build fix.  Don't use Carbon.h as the prefix header as it triggers
896         warnings that would otherwise be suppressed due to it being a system header.
897
898         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
899
900 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
901
902         Rubber stamped by Adam.
903         
904         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
905
906         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
907
908 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
909
910         Sort files(...); sections of Xcode project files.
911
912         Rubber-stamped by Darin.
913
914         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
915         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
916         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
917         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
918
919 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
920
921         Script to sort "files(...);" sections in Xcode project.pbxproj files.
922
923         Reviewed by Darin.
924
925         * Scripts/sort-Xcode-project-file: Added.
926
927 2007-11-02  Darin Adler  <darin@apple.com>
928
929         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
930
931 2007-11-02  Darin Adler  <darin@apple.com>
932
933         Reviewed by Maciej.
934
935         * Scripts/run-sunspider: Pass the "--base" option through.
936
937         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
938         the real script do that. Default configuration to Release to match run-sunspider
939         so we don't end up building Debug just to compare results.
940
941 2007-11-01  Adam Roben  <aroben@apple.com>
942
943         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
944
945         Reviewed by Sam.
946
947         * Scripts/commit-log-editor: Show all the directories beneath the
948         source root, instead of just the last one.
949
950 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
951
952         Reviewed by Adam Roben.
953
954         Print out an error message when the Windows build fails
955         and provide guidance on how to find out what went wrong.
956
957         * Scripts/build-webkit:
958         * Scripts/webkitdirs.pm:
959
960 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
961
962         Rubber-stamped by Adam Roben.
963
964         Rolled out r27326 - debug CRT seems to cause no problems after all.
965
966         * DumpRenderTree/win/DumpRenderTree.vcproj:
967
968 2007-10-31  Adam Roben  <aroben@apple.com>
969
970         Switch the Debug configuration to using the non-debug CRT
971
972         This matches WebKit.
973
974         Reviewed by Steve.
975
976         * DumpRenderTree/win/DumpRenderTree.vcproj:
977
978 2007-10-31  Antti Koivisto  <antti@apple.com>
979
980         Reviewed by bdash.
981         
982         Disable media tests when doing leak checking on Tiger.
983         They crash in QuickTime (rdar://problem/5537157).
984
985         * Scripts/run-webkit-tests:
986
987 2007-10-29  Antti Koivisto  <antti@apple.com>
988
989         Reviewed by Maciej.
990         
991         Build media support by default on OSX only.
992
993         * Scripts/build-webkit:
994
995 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
996
997         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
998         get caught by the pre-commit hooks.
999
1000 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1001
1002         Reviewed by Adam.
1003
1004         - This is a collection of relatively unrelated changes and cleanups
1005         to Drosera to prepare it for interacting with WebKit.  A lot of these
1006         changes are just correcting mistakes, for example removing included
1007         headers that are no longer needed.
1008
1009         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1010         this will be needed by the DebuggerClient.
1011         (DebuggerDocument::server):
1012         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1013         * Drosera/win/DebuggerClient.cpp: 
1014         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1015         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1016         (DebuggerClient::createWebViewWithRequest): Added comment about its
1017         purpose. 
1018         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1019         declarations.
1020         (DebuggerClient::webViewLoaded): Moved.
1021         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1022         file, since this was the only place it was used.
1023         (cfStringToBSTR):
1024         * Drosera/win/Drosera.h: Cleaned up the includes.
1025         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1026         * Drosera/win/HelperFunctions.h: Removed.
1027
1028 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1029
1030         Reviewed by Adam.
1031
1032         - Small cleanup in the ServerConnection class.
1033
1034         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1035         and added an include.
1036         (ServerConnection::currentFrame):
1037         (ServerConnection::getCallerFrame):
1038         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1039         made a pointer into a COMPtr, and cleaned up the includes.
1040
1041 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1042
1043         Reviewed by John Sullivan.
1044         
1045         - Place the Localizable.strings file in mac or win directories
1046           if that location exists.
1047         - Also look for UI_STRING in .c files.
1048
1049         * Scripts/extract-localizable-strings:
1050
1051 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1052
1053         Reviewed by Adam.
1054
1055         - Set the eol-style to native and made all the line endings the same
1056         so that I avoid messy diffs that show eol changes.
1057
1058         * Drosera/win/ServerConnection.cpp:
1059         (ServerConnection::didParseSource):
1060         (ServerConnection::didEnterCallFrame):
1061         (ServerConnection::willExecuteStatement):
1062         (ServerConnection::willLeaveCallFrame):
1063         (ServerConnection::exceptionWasRaised):
1064
1065 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1066
1067         Reviewed by Adam.
1068
1069         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1070         functionality that could not have existed previously without the new
1071         interfaces.
1072         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1073         from a BSTR to a JSValueRef.
1074         (DebuggerDocument::platformEvaluateScript): Implemented.
1075         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1076         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1077         Implemented.
1078         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1079         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1080         * Drosera/win/ServerConnection.cpp: Added a helper function.
1081         (ServerConnection::getCallerFrame):
1082         * Drosera/win/ServerConnection.h: Added a helper function.
1083
1084 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1085
1086         updated reviewers for my previous changelog.
1087
1088 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1089         Reviewed by Maciej and Adam and Geoff.
1090
1091         - Minor mac-side improvements including moving a function to a more
1092         appropriate location, fixing a warning, and correctly checking
1093         exceptions.
1094
1095         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1096         (DebuggerDocument::willExecuteStatement):
1097         (DebuggerDocument::didEnterCallFrame):
1098         (DebuggerDocument::willLeaveCallFrame):
1099         (DebuggerDocument::windowScriptObjectAvailable):
1100         (DebuggerDocument::callFunctionOnObject):
1101         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1102         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1103         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1104         because it doesn't require the ServerConnection at all.
1105         (NSStringCreateWithJSStringRef): Made an argument const.
1106         (JSValueRefCreateWithNSString): Made an argument const.
1107         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1108         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1109         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1110         * Drosera/mac/ServerConnection.mm: Ditto.
1111         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1112
1113 2007-10-29  Sam Weinig  <sam@webkit.org>
1114
1115         Reviewed by Adam Roben.
1116
1117         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1118
1119         * DumpRenderTree/LayoutTestController.cpp:
1120         (LayoutTestController::LayoutTestController):
1121         (getGlobalFlagCallback):
1122         (setGlobalFlagCallback):
1123         (LayoutTestController::getJSClass):
1124         (LayoutTestController::staticValues):
1125         * DumpRenderTree/LayoutTestController.h:
1126         (LayoutTestController::globalFlag):
1127         (LayoutTestController::setGlobalFlag):
1128
1129 2007-10-29  Darin Adler  <darin@apple.com>
1130
1131         Reviewed by Maciej.
1132
1133         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1134         resolution instead of its default.
1135
1136 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
1137
1138         Fixed showStatus() to print status for successfully resolved conflicts when using git.
1139
1140         Reviewed by Mark Rowe.
1141
1142         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1143         was successfully resolved, but this would not show any status because the change had
1144         already been cached in the index using "git add".  The solution is to add an optional
1145         second argument to showStatus() which adds the "--cached" switch to the command.
1146
1147         * Scripts/resolve-ChangeLogs:
1148         (showStatus):
1149
1150 2007-10-28  Eric Seidel  <eric@webkit.org>
1151
1152         Reviewed by Maciej and Geoff, in unison.
1153
1154         * Scripts/run-webkit-tests: remove broken --svg option
1155
1156 2007-10-28  Darin Adler  <darin@apple.com>
1157
1158         Reviewed by Adam.
1159
1160         * Scripts/run-sunspider: Default to "Release" configuration rather than
1161         defaulting to the last configuration used as other scripts do. This can
1162         still be overriden on the command line with "--debug" if there's some
1163         reason to do so. Also fix a typo.
1164
1165         * Scripts/sunspider-compare-results: Fix a typo.
1166
1167 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1168
1169         Reviewed by Adam.
1170
1171         - Implemented the WebScriptDebugListener functions now that the
1172         WebScriptDebugServer exists
1173
1174         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1175         functions.
1176         (ServerConnection::currentFrame):
1177         (ServerConnection::didLoadMainResourceForDataSource):
1178         (ServerConnection::didParseSource):
1179         (ServerConnection::failedToParseSource):
1180         (ServerConnection::didEnterCallFrame):
1181         (ServerConnection::willExecuteStatement):
1182         (ServerConnection::willLeaveCallFrame):
1183         (ServerConnection::exceptionWasRaised):
1184         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1185         members arguments list.
1186
1187 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1188
1189         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1190         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1191
1192         Reviewed by Darin.
1193
1194         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1195         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1196         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1197         file.  Note that it may also be used as a stand-alone script.
1198
1199         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1200         * Scripts/resolve-ChangeLogs: Added.
1201         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1202
1203 2007-10-26  Mark Rowe  <mrowe@apple.com>
1204
1205         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1206         to the Qt port on the assumption that it was an implementation of the cross-platform
1207         LayoutTestController class.  It is not, so it did not need to be changed.
1208
1209         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1210
1211 2007-10-25  Mark Rowe  <mrowe@apple.com>
1212
1213         Reviewed by Maciej.
1214
1215         Fix builds with code coverage enabled.
1216
1217         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1218
1219 2007-10-25  Darin Adler  <darin@apple.com>
1220
1221         Reviewed by Mark Rowe.
1222
1223         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1224         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1225
1226 2007-10-25  Stephanie  <slewis@apple.com>
1227
1228         build Fix
1229
1230         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1231
1232 2007-10-25  Stephanie  <slewis@apple.com>
1233
1234         Reviewed by Mark Rowe, Adam Roben.
1235
1236         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1237
1238         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1239
1240 2007-10-25  Alice Liu  <alice.liu@apple.com>
1241
1242         Reviewed by Adam.
1243
1244         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1245
1246         Moving destructor into platform-specific files
1247         * DumpRenderTree/LayoutTestController.cpp:
1248         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1249         (LayoutTestController::~LayoutTestController):
1250         * DumpRenderTree/qt/jsobjects.cpp:
1251         (LayoutTestController::~LayoutTestController):
1252
1253         LayoutTestController wasn't being destroyed
1254         * DumpRenderTree/win/DumpRenderTree.cpp:
1255         (runTest):
1256
1257         Added declspec
1258         * DumpRenderTree/win/EditingDelegate.h:
1259
1260         Reset certain values on the webview (or related delegate) that might 
1261         have changed while running a test
1262         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1263         (LayoutTestController::~LayoutTestController):
1264
1265 2007-10-25  Adam Roben  <aroben@apple.com>
1266
1267         Make sunspider-compare-results work with relative paths
1268
1269         Reviewed by Sam.
1270
1271         * Scripts/sunspider-compare-results: Convert arguments to absolute
1272         paths before we chdir.
1273
1274 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1275
1276         Reviewed by Sam.
1277
1278         - Implemented server calls now the WebScriptDebugServer exists.
1279         - Also removed no longer needed call to initialize CG.
1280
1281         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1282         automatically now.
1283         (_tWinMain):
1284         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1285         (ServerConnection::ServerConnection):
1286         (ServerConnection::~ServerConnection):
1287         (ServerConnection::pause):
1288         (ServerConnection::resume):
1289         (ServerConnection::stepInto):
1290         (ServerConnection::applicationTerminating):
1291         (ServerConnection::serverConnectionDidDie):
1292         * Drosera/win/ServerConnection.h: Now uses the COM class.
1293
1294 2007-10-24  George Staikos  <staikos@kde.org>
1295
1296         Unbreak Qt build.
1297
1298         * Scripts/build-webkit:
1299
1300 2007-10-24  Adam Roben  <aroben@apple.com>
1301
1302         Remove now-unnecessary call to InitializeCoreGraphics
1303
1304         WebKit takes care of this now.
1305
1306         Reviewed by Ada.
1307
1308         * DumpRenderTree/win/DumpRenderTree.cpp:
1309         (initialize):
1310
1311 2007-10-24  Adam Roben  <aroben@apple.com>
1312
1313         Use WebTextRenderer in DRT
1314
1315         Reviewed by Ada.
1316
1317         * DumpRenderTree/win/DumpRenderTree.cpp:
1318         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1319
1320 2007-10-24  Sven Herzberg  <sven@imendio.com>
1321
1322         Reviewed by Mark Rowe.
1323
1324         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1325         Bug 15614: [GTK] qmake based backends don't build on OS X
1326
1327         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1328         GTK backend on a Mac
1329         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1330         isDarwin() to make it reusable in other places (like the workaround-
1331         for-prebuilt-qmake in build-webkit)
1332
1333 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1334
1335         Refurbish update-webkit script.
1336
1337         Reviewed by Adam.
1338
1339         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
1340         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
1341         multi-argument version of system() for flexibility and security.  Check for existence
1342         of Internal directory using -d test instead of -x.
1343
1344 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1345
1346         Minor clean-up of prepare-ChangeLog script.
1347
1348         Reviewed by Adam.
1349
1350         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
1351         of a string.  Use multi-argument versions of open() and system() for flexibility and
1352         security.
1353
1354 2007-10-24  Alice Liu  <alice.liu@apple.com>
1355
1356         Reviewed by Oliver.
1357
1358         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
1359
1360         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
1361         replay the saved events when we're still processing the mousedown that starts the drag
1362         * DumpRenderTree/win/EventSender.cpp:
1363         (doMouseMove):
1364         * DumpRenderTree/win/UIDelegate.cpp:
1365         (UIDelegate::doDragDrop):
1366
1367 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
1368
1369         Reviewed by Sam, Steve and Darin.
1370
1371         - Stubbed out the WebScriptDebugListener functionality in the Server
1372         Connection class to prepare it for receiving those callbacks.
1373         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1374         and the ServerConnection to not need to be initialized with a server
1375         name, since that is not the way we connect to the WebKit server. 
1376
1377         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1378         no exception.  Now it only loggs when there is an exception
1379         (DebuggerDocument::willExecuteStatement):
1380         (DebuggerDocument::didEnterCallFrame):
1381         (DebuggerDocument::willLeaveCallFrame):
1382         (DebuggerDocument::windowScriptObjectAvailable):
1383         (DebuggerDocument::callFunctionOnObject):
1384         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1385         to be instantiated with a server's name.
1386         (DebuggerClient::DebuggerClient):
1387         (DebuggerClient::didFinishLoadForFrame):
1388         * Drosera/win/DebuggerClient.h: Removed unsued variable.
1389         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1390         a server name.
1391         (Drosera::init):
1392         (Drosera::initServer):
1393         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1394         instantiated with a server's name.
1395         * Drosera/win/ServerConnection.cpp: 
1396         (ServerConnection::ServerConnection): No longer needs a server name
1397         (ServerConnection::~ServerConnection): Only release the global context
1398         if there is one.
1399         (ServerConnection::serverConnectionDidDie): Stub for
1400         IWebScriptDebugListener
1401         (ServerConnection::QueryInterface): ditto
1402         (ServerConnection::AddRef): ditto
1403         (ServerConnection::Release): ditto
1404         (ServerConnection::didLoadMainResourceForDataSource): ditto
1405         (ServerConnection::didParseSource): ditto
1406         (ServerConnection::failedToParseSource): ditto
1407         (ServerConnection::didEnterCallFrame): ditto
1408         (ServerConnection::willExecuteStatement): ditto
1409         (ServerConnection::willLeaveCallFrame): ditto
1410         (ServerConnection::exceptionWasRaised): ditto
1411         * Drosera/win/ServerConnection.h: Stubbed out the
1412         IWebScriptDebugListener functions, and this class no longer needs to be
1413         instantiated with a server name.
1414
1415 2007-10-24  Lars Knoll  <lars@trolltech.com>
1416
1417         Reviewed by Simon.
1418
1419         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1420
1421         * DumpRenderTree/qt/jsobjects.h:
1422
1423 2007-10-24  Lars Knoll  <lars@trolltech.com>
1424
1425         Reviewed by Simon.
1426
1427         add another command.
1428
1429         * DumpRenderTree/qt/jsobjects.cpp:
1430         (TextInputController::doCommand):
1431
1432 2007-10-24  Lars Knoll  <lars@trolltech.com>
1433
1434         Reviewed by Simon.
1435
1436         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
1437
1438         * DumpRenderTree/qt/jsobjects.cpp:
1439         (EventSender::keyDown):
1440         * DumpRenderTree/qt/jsobjects.h:
1441
1442 2007-10-24  Lars Knoll  <lars@trolltech.com>
1443
1444         Reviewed by Simon.
1445
1446         implement eventSender.keyDown().
1447
1448         * DumpRenderTree/qt/jsobjects.cpp:
1449         (EventSender::keyDown):
1450
1451 2007-10-24  Lars Knoll  <lars@trolltech.com>
1452
1453         Reviewed by Simon.
1454
1455         some smaller fixes to the editing support in DRT. Makes another few tests pass.
1456
1457         * DumpRenderTree/qt/DumpRenderTree.cpp:
1458         (WebCore::DumpRenderTree::DumpRenderTree):
1459         (WebCore::DumpRenderTree::initJSObjects):
1460         * DumpRenderTree/qt/jsobjects.cpp:
1461         (TextInputController::doCommand):
1462
1463 2007-10-24  Lars Knoll  <lars@trolltech.com>
1464
1465         Reviewed by Simon.
1466
1467         first bit of implementation for the textinputcontroller.
1468
1469         * DumpRenderTree/qt/DumpRenderTree.cpp:
1470         (WebCore::DumpRenderTree::DumpRenderTree):
1471         * DumpRenderTree/qt/DumpRenderTree.h:
1472         * DumpRenderTree/qt/jsobjects.cpp:
1473         (TextInputController::TextInputController):
1474         (TextInputController::doCommand):
1475         * DumpRenderTree/qt/jsobjects.h:
1476
1477 2007-10-24  Lars Knoll  <lars@trolltech.com>
1478
1479         Reviewed by Simon.
1480
1481         make the man webpage believe it has focus, so the editing tests work correctly.
1482
1483         * DumpRenderTree/qt/DumpRenderTree.cpp:
1484         (WebCore::DumpRenderTree::DumpRenderTree):
1485
1486 2007-10-24  Lars Knoll  <lars@trolltech.com>
1487
1488         Reviewed by Simon.
1489
1490         implement layoutTestController.dumpEditingCallbacks() correctly.
1491
1492         * DumpRenderTree/qt/DumpRenderTree.cpp:
1493         (WebCore::DumpRenderTree::DumpRenderTree):
1494         * DumpRenderTree/qt/jsobjects.cpp:
1495         (LayoutTestController::reset):
1496         (LayoutTestController::dumpEditingCallbacks):
1497
1498 2007-10-24  Lars Knoll  <lars@trolltech.com>
1499
1500         Reviewed by Simon.
1501
1502         Implement support for testing editing.
1503
1504         * DumpRenderTree/qt/DumpRenderTree.cpp:
1505         (WebCore::DumpRenderTree::DumpRenderTree):
1506
1507 2007-10-23  Sam Weinig  <sam@webkit.org>
1508
1509         Check for null BSTR that can be passed to the UIDelegate methods
1510         from javascript null and undefined.  Fixes a failing test case on
1511         Windows (fast/dom/Window/alert-undefined.html)
1512
1513         Reviewed by Eric Seidel.
1514
1515         * DumpRenderTree/win/UIDelegate.cpp:
1516         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1517         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1518         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1519         (UIDelegate::webViewAddMessageToConsole):
1520
1521 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1522
1523         Reviewed by Darin.
1524         
1525         Don't print a massive pile of setenvs from tools that automatically build testkjs.
1526
1527         * Scripts/build-testkjs:
1528
1529 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1530
1531         Reviewed by Darin.
1532
1533         - add wrapper that finds the right copy of testkjs
1534         
1535         * Scripts/sunspider-compare-results: Added.
1536
1537 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
1538
1539         Reviewed by Sam.
1540
1541         - After talking with Steve I now see that the WebKit server must be
1542         running for DCOM to create the distributed objects, which makes sense
1543         and currently WebKit only allows one instance to be running at a time
1544         which avoids accidentally connecting to the wrong server
1545         - In light of this I have removed the code for the attach box and
1546         NotificationServer and known server names, since they are all extranious
1547         now.
1548
1549         * Drosera/win/Drosera.cpp: Removed notification classes and known server
1550         names.
1551         (_tWinMain): Uses init instead of initUI.
1552         (droseraWndProc): No longer creats an attach dialog box.
1553         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
1554         it's not manditory to call init before doing COM stuff.
1555         (Drosera::init): calls initUI and will call attach when the
1556         functionality exists. 
1557         (Drosera::initUI): Has changed very little.
1558         (Drosera::attach): Changed the signature to reflect that we no longer
1559         need the dictionary of known server names.
1560         * Drosera/win/Drosera.h: Removed notification classes and known server
1561         names.  Also renamed and moved some functions.
1562         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
1563         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
1564         headers to the resources folder. 
1565         * Drosera/win/resource.h: Removed the Attach box.
1566
1567 2007-10-22  Adam Roben  <aroben@apple.com>
1568
1569         Windows build fix
1570
1571         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
1572
1573 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
1574
1575         - Removed a leak that was fixed.
1576
1577         * Scripts/run-webkit-tests:
1578
1579 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1580
1581         Reviewed by Darin.
1582
1583         - Changed the Client so that the DebuggerDocument now own the
1584         ServerConnection.  This simplifies ownership and cleanup. 
1585
1586         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
1587         ServerConnection.
1588         (DebuggerClient::initWithServerName):
1589         (DebuggerClient::didFinishLoadForFrame):
1590         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
1591         ServerConnection.
1592         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
1593         until after we have a server which we are attached to.
1594         (Drosera::initUI):
1595         (Drosera::attach):
1596         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
1597         out previously.
1598
1599 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1600
1601         Reviewed by Nikolas.
1602
1603         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
1604
1605         * Scripts/run-javascriptcore-tests:
1606
1607 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1608
1609         Reviewed by Nikolas.
1610
1611         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
1612
1613         * Scripts/build-drosera:
1614         * Scripts/build-dumprendertree:
1615         * Scripts/build-testkjs:
1616         * Scripts/build-webkit:
1617         * Scripts/run-javascriptcore-tests:
1618         * Scripts/run-sunspider:
1619         * Scripts/run-webkit-tests:
1620         * Scripts/webkitdirs.pm:
1621
1622 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
1623
1624         Reviewed by Mark Rowe.
1625         
1626         Fix for local database support after r26879
1627         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1628
1629         * Scripts/build-webkit:
1630
1631 2007-10-22  Holger Freyther  <zecke@selfish.org>
1632
1633         Reviewed by Simon Hausmann <hausmann@kde.org>.
1634
1635         - Do not build testkjs as an application bundle. This is
1636         needed for run-javascriptcore-tests on OSX.
1637         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
1638         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
1639         as we do not have -rpath on OSX.
1640
1641         * DumpRenderTree/qt/DumpRenderTree.pro:
1642         * Scripts/run-webkit-tests:
1643
1644 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1645
1646         Reviewed by aroben.
1647
1648         Fix support for Signed-off-by detection in prepare-ChangeLog
1649         --git-commit. The Signed-off-by tag does not appear in the header
1650         but usually at the end.
1651
1652         * Scripts/prepare-ChangeLog:
1653
1654 2007-10-21  Mark Rowe  <mrowe@apple.com>
1655
1656         Reviewed by Eric.
1657
1658         Fix run-javascriptcore-tests for Gtk.
1659
1660         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
1661
1662 2007-10-20  Eric Seidel  <eric@webkit.org>
1663
1664         Reviewed by aroben.
1665
1666         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
1667
1668 2007-10-20  Eric Seidel  <eric@webkit.org>
1669
1670         Reviewed by darin.
1671         
1672         Add improved argument handling to run-sunspider, including
1673         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
1674         Also re-factor code into subroutines
1675
1676         * Scripts/build-dumprendertree: removed bogus comments
1677         * Scripts/build-testkjs: Added.
1678         * Scripts/run-javascriptcore-tests: use build-testkjs
1679         * Scripts/run-sunspider: improved argument handling, abstraction
1680         * Scripts/run-webkit-tests: improved abstraction
1681
1682 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
1683
1684         Not reviewed, Windows build fix.
1685
1686         * DumpRenderTree/win/EventSender.cpp:
1687         (keyDownCallback):
1688
1689 2007-10-20  Darin Adler  <darin@apple.com>
1690
1691         Reviewed by Tim Hatcher.
1692
1693         - http://bugs.webkit.org/show_bug.cgi?id=15544
1694           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
1695           not rely on Apple-specific key codes
1696
1697         * DumpRenderTree/mac/EventSendingController.mm:
1698         (-[EventSendingController keyDown:withModifiers:]):
1699         Added named key "rightArrow". Later we could have a whole table of these.
1700         Also tweaked modifiers code a little.
1701
1702         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
1703
1704 2007-10-19  Darin Adler  <darin@apple.com>
1705
1706         Reviewed by Eric.
1707
1708         - http://bugs.webkit.org/show_bug.cgi?id=15566
1709           possible fix for leak seen in DumpRenderTree
1710
1711         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
1712         Delete the item if it's not put on the queue, since the caller has
1713         no way of knowing that. Would be better to have the parameter type
1714         be auto_ptr to express the fact that we take ownership.
1715
1716         - unrelated change
1717
1718         * Drosera/mac/main.m: Add missing include.
1719
1720 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1721
1722         Reviewed by Adam.
1723
1724         - This change should be identical but for some reason was not working
1725         on my machine.
1726
1727         * Scripts/prepare-ChangeLog:
1728
1729 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1730
1731         Reviewed by Oliver and Tim.
1732
1733         - Made use of RetainPtr to avoid retain and release issues and moved the
1734         log function to DebuggerDocumentPlatform, which seems to be a more
1735         logical place for it to live.
1736         - Also moved knownServers from the ServerConnection to
1737         DebuggerApplication to match the Windows code and because it makes sense
1738         that a connection knows its own server but not all of them.
1739
1740         * Drosera/mac/DebuggerClient.h: Moved the log function to
1741           DebuggerDocumentPlatform.
1742         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
1743           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
1744           call for the server name up from the ServerConnection class.
1745         (-[DebuggerClient dealloc]):
1746         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
1747           for the server name up from the ServerConnection.
1748         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
1749         (DebuggerDocument::platformPause):
1750         (DebuggerDocument::platformResume):
1751         (DebuggerDocument::platformStepInto):
1752         (DebuggerDocument::platformEvaluateScript):
1753         (DebuggerDocument::getPlatformCurrentFunctionStack):
1754         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1755         (DebuggerDocument::platformValueForScopeVariableNamed):
1756         (DebuggerDocument::platformLog): Log directly from here. No need to call
1757           DebuggerClient.
1758         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
1759           way I see it, a ServerConnection should only know about its connection
1760           and the group of all possible servers should be kept by the
1761           application.
1762         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
1763           currentServerName, it makes sense that the connection should know that
1764           name.
1765         (-[ServerConnection currentServerName]):
1766
1767 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1768
1769         Reviewed by Adam.
1770
1771         - Integrated changes from mac drosera.  Recently I've encapsulated
1772         out the server connection object from the rest of Drosera because
1773         it is very platform dependent right now and RPC is not implemented on
1774         windows.  This functionality, of communicating with the WebKit server
1775         is the next area I will be focusing on in Windows.
1776
1777         - Other changes and cleanup were made to organize the code and add notes
1778         on which parts still need work.  Also some mac code is added and
1779         commented out, to act as pseudocode for the logic of those parts.
1780
1781         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
1782           pointer.
1783         * Drosera/config.h: Added whitespace.
1784         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
1785           these files got moved into Drosera.h/cpp
1786         * Drosera/win/DebuggerApplication.h: Removed.
1787         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
1788           happened here to better match the logic flow of the same code on the 
1789           mac side and to use the new ServerConnection class.
1790         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
1791         (DebuggerClient::initWithServerName): Initializer that will set up the
1792           class to use a ServerConnection object.  This was necessary so I could
1793           create a DebuggerClient without having to initilaize it at
1794           construction.
1795         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
1796           will be the UIDelegate and FrameLoadDelegate.
1797         (DebuggerClient::AddRef): For IUnknown.
1798         (DebuggerClient::Release): For IUnknown.
1799         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
1800           this still needs to set the global context of the server, but
1801           IWebFrame does not have an accessor for the global context yet. 
1802         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
1803           this is a pass through for the same function in the document.
1804         (DebuggerClient::didReceiveTitle): Unimplemented part of
1805           FrameLoadDelegate this would change the title of the window.
1806         (DebuggerClient::createWebViewWithRequest): Part of the
1807           FrameLoadDelegate.  This is about new windows via Window.open() and
1808           how their delegates are set.
1809         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
1810           UIDelegate.  Just a debug function for printing messages.
1811         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
1812           because the Client should be the UIDelegate and FrameLoadDelegate
1813           to match the delegates on mac.
1814         (DebuggerClient::webViewLoaded): Added accessor method.
1815         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
1816           forgotten to add this file before.  This is where the platform
1817           dependent versions of the Documents functions live. Most of these are
1818           unimplemented because some piece of functionality does not exist on
1819           Windows yet.
1820         (DebuggerDocument::platformPause):
1821         (DebuggerDocument::platformResume):
1822         (DebuggerDocument::platformStepInto):
1823         (DebuggerDocument::platformEvaluateScript):
1824         (DebuggerDocument::getPlatformCurrentFunctionStack):
1825         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1826         (DebuggerDocument::platformValueForScopeVariableNamed):
1827         (DebuggerDocument::platformLog):
1828         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
1829           responsibilities becaue they belong in the Client. Also I laid the
1830           groundwork for attaching Drosera to a WebKit process
1831         (attachWndProc): Now if a server is selected the Client becomes it's
1832           delegate.
1833         (Drosera::Drosera): Added the construction of the Client and dictionary
1834           of server names. 
1835         (Drosera::initUI): This is no longer the delegates, the Client is.
1836         (Drosera::webViewLoaded): Now asks the Client instead of holding local
1837           state. 
1838         (Drosera::applicationDidFinishLaunching): Placeholder for needed
1839           notification registration when it's possible to implement.
1840         (Drosera::serverLoaded): Ditto
1841         (Drosera::serverUnloaded): Ditto
1842         (Drosera::attach): Attach Drosera to the WebKit server.
1843         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
1844         (Drosera::getInst): 
1845         (Drosera::setInst):
1846         (Drosera::knownServers):
1847         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
1848           and added the ServerConnection.
1849         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
1850         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
1851           Most of the functions are completely unimlemented because they cannot
1852           connect with the WebKit server, because one does not exist on Windows
1853           yet.
1854         (ServerConnection::initWithServerName): 
1855         (ServerConnection::~ServerConnection):
1856         (ServerConnection::setGlobalContext):
1857         (ServerConnection::pause):
1858         (ServerConnection::resume):
1859         (ServerConnection::stepInto):
1860         (ServerConnection::switchToServerNamed):
1861         (ServerConnection::applicationTerminating):
1862         (ServerConnection::serverConnectionDidDie):
1863         (ServerConnection::currentFrame):
1864         * Drosera/win/ServerConnection.h: Added. Ditto.
1865         (ServerConnection::ServerConnection):
1866
1867 2007-10-19  Alice Liu  <alice.liu@apple.com>
1868
1869         Reviewed by Darin.
1870
1871         Fix for these broken layout tests on Windows:
1872         
1873         fast/forms/focus-selection-input.html
1874         fast/forms/focus-selection-textarea.html
1875         fast/forms/select-accesskey.html
1876         
1877         * DumpRenderTree/win/EventSender.cpp:
1878         (keyDownCallback):
1879         correct the VK code for alt key.
1880         
1881 2007-10-19  Eric Seidel  <eric@webkit.org>
1882
1883         Reviewed by Mark Rowe.
1884         
1885         Make the GtkLauncher code slightly more readable.
1886
1887         * GtkLauncher/main.cpp:
1888         (setupMainMenu): Added.
1889         (setupMainWindowUI): Added.
1890         (main):
1891
1892 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
1893
1894         Rubber stamped by Adam.
1895         
1896         - don't delay-load WebKit in DumpRenderTree.
1897
1898         * DumpRenderTree/win/DumpRenderTree.vcproj:
1899
1900 2007-10-18  Dan Bernstein  <mitz@apple.com>
1901
1902         Reviewed by Adam Roben.
1903
1904         - fix <rdar://problem/5313523>
1905         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
1906
1907         * DumpRenderTree/mac/DumpRenderTree.mm:
1908         (dump): Changed to use _responseMIMEType.
1909
1910 2007-10-17  Adam Roben  <aroben@apple.com>
1911
1912         Make it possible to have Windows-specific tests and results
1913
1914         When searching for tests to run and the Skipped file, we will only
1915         look in platform/win and the cross-platform directory. When looking
1916         for expected results, we will look in platform/win, then
1917         platform/mac-leopard, then platform/mac, then finally the
1918         cross-platform directory.
1919
1920         Reviewed by Sam.
1921
1922         * Scripts/run-webkit-tests:
1923         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
1924         searching in the cross-platform directory.
1925         (sub buildPlatformHierarchy): Removed some unneeded calls to
1926         dirname/basename.
1927
1928 2007-10-17  Adam Roben  <aroben@apple.com>
1929
1930         Add back the call to register WebKit that we had before WebKitInitializer existed
1931
1932         This is needed to ensure that the right WebKit is used when
1933         instantiating COM objects.
1934
1935         Reviewed by Oliver.
1936
1937         * DumpRenderTree/win/debug_internal.vsprops: Define
1938         DEBUG_WEBKIT_HAS_SUFFIX.
1939         * DumpRenderTree/win/DumpRenderTree.cpp:
1940         (initialize):
1941
1942 2007-10-17  Adam Roben  <aroben@apple.com>
1943
1944         Import File::Basename in webkitdirs since we use it
1945
1946         * Scripts/webkitdirs.pm:
1947
1948 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
1949
1950         - Updated the tiger leaks list to make the internal bots green.
1951
1952         * Scripts/run-webkit-tests:
1953
1954 2007-10-17  Adam Roben  <aroben@apple.com>
1955
1956         Build fix for VC++ Express
1957
1958         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
1959         and ole32.lib.
1960
1961 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1962
1963         Reviewed by Sam.
1964
1965         - Minor mac improvements based on observations I made while implementing the
1966         Windows code.
1967
1968         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
1969         then hand it to the Client who will retain it, it should just be the client who
1970         creates and owns the server.
1971         (-[DebuggerApplication attach:]):
1972         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
1973         * Drosera/mac/DebuggerClient.mm: Creates the server.
1974         (-[DebuggerClient initWithServerName:]):
1975         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
1976         can instead forward declare what it needs.
1977
1978 2007-10-16  Darin Adler  <darin@apple.com>
1979
1980         Reviewed by Geoff Garen.
1981
1982         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
1983         want to turn failing tests into platform-specific test results. Also did a
1984         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
1985         would take the type of results into account only some of the time.
1986
1987 2007-10-16  Adam Roben  <aroben@apple.com>
1988
1989         Add a new nightly launcher script for Windows
1990
1991         This new script is for versions of Safari that don't delay-load
1992         WebKit. I had to make FindSafari be able to print out the nightly
1993         launcher script on stdout because Windows shell scripts can't capture
1994         the output from a command into an environment variable.
1995
1996         Reviewed by Steve.
1997
1998         * FindSafari/FindSafari.cpp:
1999         (_tmain): Added /printSafariLauncher option.
2000         * Scripts/run-webkit-nightly.cmd: Added.
2001
2002 2007-10-16  Adam Roben  <aroben@apple.com>
2003
2004         Replace WebKitInitializer with FindSafari
2005
2006         We now rely on setting the PATH environment variable to tell Windows
2007         where to find WebKit and its dependencies (similar to
2008         DYLD_FRAMEWORK_PATH on Mac).
2009
2010         This change also make DumpRenderTree no longer delay-load WebKit.
2011
2012         Reviewed by Sam.
2013
2014         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2015         FindSafari.
2016         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2017         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2018         WebKitInitializer, don't delay-load WebKit.
2019         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2020         * Scripts/run-webkit-tests: Ditto.
2021         * Scripts/webkitdirs.pm:
2022         (sub setPathForRunningWebKitApp): Added.
2023         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2024         * WebKitInitializer/WebKitInitializer.h: Removed.
2025         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2026         * WebKitInitializer/debug.vsprops: Removed.
2027         * WebKitInitializer/debug_internal.vsprops: Removed.
2028         * WebKitInitializer/release.vsprops: Removed.
2029
2030 2007-10-16  Adam Roben  <aroben@apple.com>
2031
2032         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2033
2034         http://bugs.webkit.org/show_bug.cgi?id=15532
2035
2036         FindSafari simply prints the location of an installed Safari.exe on
2037         stdout.
2038
2039         Reviewed by Darin.
2040
2041         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2042         (getStringValue):
2043         (getWebViewCLSID):
2044         (getInstalledWebKitDirectory):
2045         (_tmain):
2046         * FindSafari/FindSafari.vcproj: Added.
2047         * Scripts/webkitdirs.pm:
2048         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2049
2050 2007-10-16  Adam Roben  <aroben@apple.com>
2051
2052         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2053
2054         Reviewed by Kevin McCullough.
2055
2056         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2057         when referring to WebKit.dll.
2058         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2059         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2060         * DumpRenderTree/win/release.vsprops: Ditto.
2061         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2062         never have a _debug suffix on WebKit.dll.
2063         * WebKitInitializer/WebKitInitializer.cpp:
2064         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2065         specified.
2066         * WebKitInitializer/debug_internal.vsprops: Added
2067         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2068
2069 2007-10-16  Darin Adler  <darin@apple.com>
2070
2071         Reviewed by Adele.
2072
2073         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2074         Remove now-unneeded control/alt key hack; the tests have been updated.
2075
2076 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2077
2078         - Updated leaks list because our internal bot upgraded it's version of leopard and 
2079         one of the leaks was fixed between that revision and the bot's previous version of
2080         leopard.
2081
2082         * Scripts/run-webkit-tests:
2083
2084 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
2085
2086         Reviewed by Tim.
2087
2088         - I encapsulated out the server connecton functionality because it is a specific part
2089         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2090         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
2091         Windows.  So the majority of this patch is moving preexisting functionality.
2092
2093         - Also I removed the prefix header and changed to use config.h because it is more
2094         standard on how we use config.h in windows and it didn't make much sense to keep
2095         the prefix header and the config.h
2096
2097         * Drosera/DebuggerDocument.cpp:
2098         (DebuggerDocument::DebuggerDocument):
2099         * Drosera/DebuggerDocument.h:
2100         * Drosera/config.h:
2101         * Drosera/mac/DebuggerApplication.mm:
2102         (-[DebuggerApplication attach:]):
2103         * Drosera/mac/DebuggerClient.h:
2104         * Drosera/mac/DebuggerClient.mm:
2105         (-[DebuggerClient initWithServerConnection:]):
2106         (-[DebuggerClient dealloc]):
2107         (-[DebuggerClient windowDidLoad]):
2108         (-[DebuggerClient windowWillClose:]):
2109         (-[DebuggerClient webView:didFinishLoadForFrame:]):
2110         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2111         * Drosera/mac/DebuggerDocumentPlatform.mm:
2112         (DebuggerDocument::platformPause):
2113         (DebuggerDocument::platformResume):
2114         (DebuggerDocument::platformStepInto):
2115         (DebuggerDocument::platformEvaluateScript):
2116         (DebuggerDocument::getPlatformCurrentFunctionStack):
2117         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2118         (DebuggerDocument::platformValueForScopeVariableNamed):
2119         (DebuggerDocument::platformLog):
2120         * Drosera/mac/Drosera.pch: Removed.
2121         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2122         * Drosera/mac/ServerConnection.h: Added.
2123         * Drosera/mac/ServerConnection.mm: Added.
2124         (-[ServerConnection initWithServerName:]):
2125         (-[ServerConnection dealloc]):
2126         (-[ServerConnection setGlobalContext:]):
2127         (-[ServerConnection pause]):
2128         (-[ServerConnection resume]):
2129         (-[ServerConnection stepInto]):
2130         (-[ServerConnection switchToServerNamed:]):
2131         (-[ServerConnection applicationTerminating:]):
2132         (-[ServerConnection serverConnectionDidDie:]):
2133         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2134         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2135         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2136         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2137         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2138         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2139         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2140         (-[ServerConnection currentFrame]):
2141         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2142         (-[ServerConnection knownServers]):
2143
2144 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
2145
2146         Reviewed by Eric.
2147
2148         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2149           Script to automatically search nightly builds for regressions (bisect-builds)
2150
2151         * Scripts/bisect-builds: Added.
2152
2153 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2154
2155         Reviewed by Darin.
2156
2157         - New JavaScript benchmark
2158         http://bugs.webkit.org/show_bug.cgi?id=15515
2159
2160         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2161         current development or release build of JavaScriptCore.
2162
2163 2007-10-15  Mark Rowe  <mrowe@apple.com>
2164
2165         Reviewed by Sam.
2166
2167         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2168
2169         * Scripts/webkitdirs.pm:
2170         - Change checkArgv to remove the options from @ARGV to prevent
2171         them from interfering with further option processing.
2172         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2173         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2174         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2175         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2176
2177 2007-10-15  Darin Adler  <darin@apple.com>
2178
2179         Reviewed by Sam.
2180
2181         - added logging of window.prompt and window.confirm
2182
2183         * DumpRenderTree/mac/UIDelegate.mm:
2184         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2185         Implement the recommended delegate rather than the deprecated one.
2186         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2187         Added.
2188         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2189         Added.
2190
2191         * DumpRenderTree/win/UIDelegate.h:
2192         * DumpRenderTree/win/UIDelegate.cpp:
2193         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2194         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2195         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2196         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2197
2198 2007-10-15  Alice Liu  <alice.liu@apple.com>
2199
2200         Reviewed by Sam Weinig.
2201
2202         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2203
2204         * DumpRenderTree/win/DumpRenderTree.cpp:
2205         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2206         (main): allocate the global policy delegate for DRT's custom use
2207         * DumpRenderTree/win/DumpRenderTree.vcproj:
2208         Adding files to project
2209         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2210         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2211         (LayoutTestController::setCustomPolicyDelegate):
2212         set the webview's policy delegate to DRT's custom one if the test requests it.
2213         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2214         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2215         (PolicyDelegate::PolicyDelegate):
2216         (PolicyDelegate::QueryInterface):
2217         (PolicyDelegate::AddRef):
2218         (PolicyDelegate::Release):
2219         (PolicyDelegate::decidePolicyForNavigationAction):
2220         * DumpRenderTree/win/PolicyDelegate.h: Added.
2221         (PolicyDelegate::decidePolicyForNewWindowAction):
2222         (PolicyDelegate::decidePolicyForMIMEType):
2223         (PolicyDelegate::unableToImplementPolicyWithError):
2224
2225 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2226
2227         Reviewed by Mark.
2228
2229         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2230         when querying for QMAKE_MKSPECS.
2231
2232 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2233
2234         Reviewed by Adam Roben.
2235         
2236         Fix run-webkit-tests is too greedy calculating platform hierarchy
2237         http://bugs.webkit.org/show_bug.cgi?id=15465
2238         
2239         Fix run-webkit-tests being too greedy in trying to split the platform name up
2240         causing it to try and find tests in every directory above the first "-" in the
2241         path to the LayoutTests
2242
2243         * Scripts/run-webkit-tests:
2244
2245 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2246
2247         Reviewed by Darin.
2248
2249         http://bugs.webkit.org/show_bug.cgi?id=15006
2250         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2251         to reduce code duplication.
2252
2253         * Scripts/build-webkit:
2254         * Scripts/webkitdirs.pm:
2255         buildQMakeProject() renamed to buildQMakeQtProject().
2256         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2257         unused $colorize has been removed.
2258
2259 === Start merge of feature-branch 2007-10-12 ===
2260
2261 2007-10-08  Eric Seidel  <eric@webkit.org>
2262
2263         Reviewed by Mark Rowe.
2264
2265         * Scripts/build-webkit: add --help, remove unused --color
2266
2267 2007-10-07  Eric Seidel  <eric@webkit.org>
2268
2269         Reviewed by darin.
2270
2271         * Drosera/mac/DebuggerDocumentPlatform.mm:
2272         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2273
2274 2007-10-03  Rob Buis  <buis@kde.org>
2275
2276         Reviewed by Olliej.
2277
2278         Adapt to changed location of Ahem font.
2279
2280         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2281
2282 2007-10-02  Eric Seidel  <eric@webkit.org>
2283
2284         Reviewed by Adam Roben.
2285         
2286         Make pixel tests more useful!
2287         Finally fix the image diff 0.00% mystery problem
2288         Highlight any image differences in the image diff.
2289         Add a link from image diffs back to original test file.
2290
2291         * DumpRenderTree/mac/ImageDiff.m:
2292         (compareImages): highlight any differences
2293         (computePercentageDifferent): round to two decimal places
2294         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2295
2296 2007-10-02  Eric Seidel  <eric@webkit.org>
2297
2298         Reviewed by Alexey Proskuryakov.
2299
2300         * Scripts/run-webkit-tests: print the % image difference on main results page
2301
2302 2007-10-02  Mark Rowe  <mrowe@apple.com>
2303
2304         Reviewed by Oliver.
2305
2306         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2307
2308         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2309         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2310
2311 2007-10-01  Mark Rowe  <mrowe@apple.com>
2312
2313         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2314
2315 2007-09-25  Eric Seidel  <eric@webkit.org>
2316
2317         Reviewed by Mark Rowe.
2318         
2319         DerivedSources.make was finding "ENABLE_SVG" in the string
2320         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2321         quite correctly.
2322
2323         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2324
2325 2007-09-25  Mark Rowe  <mrowe@apple.com>
2326
2327         Rubber-stamped by Eric.
2328
2329         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2330         This makes it possible to automate nightly builds for the feature-branch.
2331
2332 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
2333
2334         Rubber stamped by Mark.
2335
2336         Enable svg experimental features as default here in feature-branch.
2337
2338         * Scripts/build-webkit:
2339
2340 2007-06-29  Antti Koivisto  <antti@apple.com>
2341
2342         Reviewed by Weinig.
2343         
2344         Add VIDEO flag for timed media features
2345
2346         * Scripts/build-webkit
2347         
2348 === End merge of feature-branch 2007-10-12 ===
2349
2350 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2351
2352         Reviewed by Darin.
2353
2354         - Updated rational for the leaks list to be more clear.
2355
2356         * Scripts/run-webkit-tests:
2357
2358 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2359
2360         Rubber Stamp by Sam.
2361
2362         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
2363         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2364
2365         * Scripts/run-webkit-tests:
2366
2367 2007-10-10  Simon Hausmann  <hausmann@kde.org>
2368
2369         Reviewed by Lars.
2370
2371         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2372         includes are needed for INT_MAX, std::auto_ptr and the like.
2373
2374         * DumpRenderTree/qt/main.cpp:
2375
2376 2007-10-09  Lars Knoll  <lars@trolltech.com>
2377
2378         Reviewed by Simon.
2379
2380         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2381
2382         * DumpRenderTree/qt/jsobjects.cpp:
2383         (LayoutTestController::encodeHostName):
2384         (LayoutTestController::decodeHostName):
2385         * DumpRenderTree/qt/jsobjects.h:
2386
2387 2007-10-09  Lars Knoll  <lars@trolltech.com>
2388
2389         Reviewed by Simon.
2390
2391         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2392
2393         * DumpRenderTree/qt/DumpRenderTree.cpp:
2394         (WebCore::WebPage::createFrame):
2395         (WebCore::DumpRenderTree::DumpRenderTree):
2396         (WebCore::DumpRenderTree::titleChanged):
2397         * DumpRenderTree/qt/DumpRenderTree.h:
2398         * DumpRenderTree/qt/jsobjects.cpp:
2399         (LayoutTestController::reset):
2400         * DumpRenderTree/qt/jsobjects.h:
2401
2402 2007-10-09  Lars Knoll  <lars@trolltech.com>
2403
2404         Reviewed by Simon.
2405
2406         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
2407
2408         * DumpRenderTree/qt/DumpRenderTree.h:
2409         * DumpRenderTree/qt/jsobjects.cpp:
2410         (LayoutTestController::clearBackForwardList):
2411         * DumpRenderTree/qt/jsobjects.h:
2412
2413 2007-10-09  Lars Knoll  <lars@trolltech.com>
2414
2415         Reviewed by Simon.
2416
2417         make --git-reviewer work again.
2418
2419         * Scripts/prepare-ChangeLog:
2420
2421 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
2422
2423         Rubber stamped by Eric.
2424
2425         Connect to the "hovering-over-link" signal emitted by WebKitPage and
2426         show the current link inside the statusbar.
2427         This shows how to make use of this signal and allows to easily test
2428         http://bugs.webkit.org/show_bug.cgi?id=15299.
2429
2430         * GtkLauncher/main.cpp:
2431         (hoveringOverLink):
2432         (main):
2433
2434 2007-10-05  Lars Knoll  <lars@trolltech.com>
2435
2436         add proper error messages to the FrameLoaderClient.
2437         Implement ChromeClientQt::closeWindowSoon and
2438         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
2439         Some fixes in DRT to make it work correctly with multiple windows.
2440
2441         Reviewed by Maciej.
2442
2443         * DumpRenderTree/qt/DumpRenderTree.cpp:
2444         (WebCore::DumpRenderTree::DumpRenderTree):
2445         (WebCore::DumpRenderTree::createWindow):
2446         (WebCore::DumpRenderTree::windowCount):
2447         * DumpRenderTree/qt/DumpRenderTree.h:
2448         * DumpRenderTree/qt/jsobjects.cpp:
2449         (LayoutTestController::maybeDump):
2450         (LayoutTestController::windowCount):
2451         * DumpRenderTree/qt/jsobjects.h:
2452
2453 2007-10-05  Lars Knoll  <lars@trolltech.com>
2454
2455         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
2456         Add support for layoutTextController.setCanOpenWindows() to DRT
2457         fixing another 2 test cases in fast/dom/Window.
2458
2459         Reviewed by Maciej.
2460
2461         * DumpRenderTree/qt/DumpRenderTree.cpp:
2462         (WebCore::WebPage::WebPage):
2463         (WebCore::WebPage::createWindow):
2464         (WebCore::DumpRenderTree::resetJSObjects):
2465         (WebCore::DumpRenderTree::createWindow):
2466         * DumpRenderTree/qt/DumpRenderTree.h:
2467         * DumpRenderTree/qt/DumpRenderTree.pro:
2468         * DumpRenderTree/qt/jsobjects.cpp:
2469         (LayoutTestController::LayoutTestController):
2470         (LayoutTestController::reset):
2471         * DumpRenderTree/qt/jsobjects.h:
2472         * DumpRenderTree/qt/main.cpp:
2473         * DumpRenderTree/qt/testplugin.cpp: Added.
2474         * DumpRenderTree/qt/testplugin.h: Added.
2475
2476 2007-10-04  Sam Weinig  <sam@webkit.org>
2477
2478         Rubber stamped by Adam.
2479
2480         Remove empty directories.
2481
2482         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2483         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2484
2485 2007-10-03  Darin Adler  <darin@apple.com>
2486
2487         Reviewed by Adam.
2488
2489         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2490         we find the internal libraries in the libraries directory. This
2491         is helpful for Safari team engineers at Apple.
2492
2493 2007-10-03  Adam Roben  <aroben@apple.com>
2494
2495         Update the location of AHEM___.TTF after r25968
2496
2497         Reviewed by Sam.
2498
2499         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2500
2501 2007-10-03  Alp Toker  <alp@atoker.com>
2502
2503         Reviewed by Adam.
2504
2505         http://bugs.webkit.org/show_bug.cgi?id=14726
2506         [gtk] API design. Mapping the WebView delegates to signals.
2507
2508         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2509
2510         * GtkLauncher/main.cpp:
2511         (goToURLBarText):
2512         (titleChanged):
2513         (progressChanged):
2514         (menuMainBackCallback):
2515         (menuMainForwardCallback):
2516         (main):
2517
2518 2007-10-03  Lars Knoll  <lars@trolltech.com>
2519
2520         Reviewed by Rob.
2521
2522         This fixes --strict mode in run-webkit-tests again after
2523         the platform dependent test results have been moved.
2524
2525         * Scripts/run-webkit-tests:
2526
2527 2007-10-03  Lars Knoll  <lars@trolltech.com>
2528
2529         Reviewed by bdash.
2530
2531         remove the hack in run-webkit-tests that forced text only test
2532         to be taken from the platform independent dir. It was only left
2533         there from early days.
2534         
2535         Remove platform dependent results for tests that are text only nowadays,
2536         and add one platform dependent result for a text only test that requires it.
2537
2538         * Scripts/run-webkit-tests:
2539
2540 2007-10-03  Lars Knoll  <lars@trolltech.com>
2541
2542         Reviewed by olliej.
2543
2544         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
2545
2546         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
2547         (WebCore::WebFrame::WebFrame):
2548         (WebCore::WebPage::WebPage):
2549         (WebCore::WebPage::createFrame):
2550         (WebCore::WebPage::javaScriptAlert):
2551         (WebCore::WebPage::javaScriptConsoleMessage):
2552         (WebCore::DumpRenderTree::DumpRenderTree):
2553         (WebCore::DumpRenderTree::~DumpRenderTree):
2554         (WebCore::DumpRenderTree::open):
2555         (WebCore::DumpRenderTree::readStdin):
2556         (WebCore::DumpRenderTree::resetJSObjects):
2557         (WebCore::DumpRenderTree::initJSObjects):
2558         (WebCore::DumpRenderTree::dumpFramesAsText):
2559         (WebCore::DumpRenderTree::dump):
2560         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
2561         (WebCore::DumpRenderTree::layoutTestController):
2562         (WebCore::DumpRenderTree::eventSender):
2563         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
2564         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
2565         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
2566         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
2567         (HackWebFrame::mousePressEvent):
2568         (HackWebFrame::mouseReleaseEvent):
2569         (HackWebFrame::mouseMoveEvent):
2570         (HackWebFrame::HackWebFrame):
2571         (HackWebFrame::~HackWebFrame):
2572         (LayoutTestController::LayoutTestController):
2573         (LayoutTestController::reset):
2574         (LayoutTestController::maybeDump):
2575         (LayoutTestController::waitUntilDone):
2576         (LayoutTestController::notifyDone):
2577         (LayoutTestController::dumpEditingCallbacks):
2578         (LayoutTestController::queueReload):
2579         (LayoutTestController::provisionalLoad):
2580         (LayoutTestController::timerEvent):
2581         (EventSender::EventSender):
2582         (EventSender::mouseDown):
2583         (EventSender::mouseUp):
2584         (EventSender::mouseMoveTo):
2585         (EventSender::leapForward):
2586         (EventSender::keyDown):
2587         (EventSender::frameUnderMouse):
2588         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
2589         (LayoutTestController::isLoading):
2590         (LayoutTestController::setLoading):
2591         (LayoutTestController::shouldDumpAsText):
2592         (LayoutTestController::shouldDumpChildrenAsText):
2593         (LayoutTestController::shouldWaitUntilDone):
2594         (LayoutTestController::dumpAsText):
2595         (LayoutTestController::dumpChildFramesAsText):
2596         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
2597         (messageHandler):
2598         (crashHandler):
2599         (main):
2600         * Scripts/run-webkit-tests:
2601
2602 2007-10-03  Mark Rowe  <mrowe@apple.com>
2603
2604         Reviewed by Alp Toker.
2605
2606         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
2607         should take precedence over QTDIR when determining which port we are working with.
2608
2609         * Scripts/webkitdirs.pm: 
2610
2611 2007-10-02  Adam Roben  <aroben@apple.com>
2612
2613         Add keychain to the list of default packages to install
2614
2615         Rubberstamped by Sam.
2616
2617         * CygwinDownloader/cygwin-downloader.py:
2618         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2619
2620 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
2621
2622         Reviewed by Adam.
2623
2624         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
2625         Also makes WebCore regression test case logic work when using git.
2626
2627         * Scripts/prepare-ChangeLog:
2628         (reviewerAndDescriptionForGitCommit): Added.
2629
2630 2007-10-02  Lars Knoll  <lars@trolltech.com>
2631
2632         Reviewed by bdash.
2633
2634         Add API to retrieve the frame name from QWebFrame.
2635         Implement support for DRT::dumpChildrenAsText.
2636
2637         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2638         (WebCore::DumpRenderTree::dumpFramesAsText):
2639         (WebCore::DumpRenderTree::dump):
2640         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2641         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2642         (LayoutTestController::LayoutTestController):
2643         (LayoutTestController::reset):
2644         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2645
2646 2007-10-02  Lars Knoll  <lars@trolltech.com>
2647
2648         Reviewed by bdash.
2649
2650         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
2651
2652         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2653         (WebCore::DumpRenderTree::readStdin):
2654
2655 2007-10-02  Mark Rowe  <mrowe@apple.com>
2656
2657         Reviewed by Oliver.
2658
2659         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2660
2661         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2662         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2663
2664 2007-10-02  Mark Rowe  <mrowe@apple.com>
2665
2666         Rubber-stamped by Maciej.
2667
2668         Configuration changes from build.webkit.org.  The major change is refactoring to work
2669         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
2670         last few weeks.
2671
2672         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2673         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
2674         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
2675         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
2676         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
2677         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
2678         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
2679         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
2680
2681 2007-10-02  Lars Knoll  <lars@trolltech.com>
2682
2683         Reviewed by Maciej.
2684
2685         Add support for eventSender.mouseMove to DRT.
2686         Fixes fast/css/hover-affects-child.html
2687
2688         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2689         (EventSender::mouseMoveTo):
2690
2691 2007-10-01  Mark Rowe  <mrowe@apple.com>
2692
2693         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2694
2695 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
2696
2697         Reviewed by Hyatt.
2698
2699         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
2700
2701         * Scripts/svn-apply:
2702         (gitdiff2svndiff): Ignore lines beginning with "new file".
2703         * Scripts/svn-unapply:
2704         (gitdiff2svndiff): Ditto.
2705
2706 2007-09-30  George Staikos  <staikos@kde.org>
2707
2708         Qt build fix (Mac OS X specific)
2709
2710         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2711
2712 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2713
2714         Reviewed by Mark.
2715
2716         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
2717         Remove Bakefiles from svn.
2718
2719         * GtkLauncher/Bakefiles.bkgen: Removed.
2720         * GtkLauncher/ENV: Removed.
2721         * GtkLauncher/gdklauncher.bkl: Removed.
2722         * GtkLauncher/mk: Removed.
2723         * Scripts/regenerate-makefiles: Removed.
2724
2725 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
2726
2727         Reviewed by John.
2728
2729         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
2730
2731         * Scripts/run-webkit-tests:
2732
2733 2007-09-26  Adam Roben  <aroben@apple.com>
2734
2735         Make not finding an installed WebKit non-fatal
2736
2737         What really matters is that we are able to load WebKit and its
2738         dependencies, not whether we think we've found an installed WebKit.
2739
2740         Reviewed by Sam.
2741
2742         * WebKitInitializer/WebKitInitializer.cpp:
2743         (getWebViewCLSID): Use new LOG_WARNING macro.
2744         (getInstalledWebKitDirectory): Ditto.
2745         (initializeWebKit): Don't die if we didn't find an installed WebKit,
2746         and use new macros.
2747         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
2748
2749 2007-09-26  Adam Roben  <aroben@apple.com>
2750
2751         Committed this file before saving it
2752
2753         * WebKitInitializer/debug_internal.vsprops:
2754
2755 2007-09-26  Adam Roben  <aroben@apple.com>
2756
2757         Load WebKit and its dependencies manually so they come from DllDirectory
2758
2759         I had to change WebKitInitializer to use malloc/free instead of
2760         new/delete to avoid pulling in WebKit (and its dependencies) early
2761         through use of fastMalloc.
2762
2763         Reviewed by Oliver.
2764
2765         * WebKitInitializer/WebKitInitializer.cpp:
2766         (getStringValue): Changed to use malloc/free.
2767         (getInstalledWebKitDirectory): Ditto.
2768         (initializeWebKit): Call SetDllDirectory first, then load all of
2769         WebKit's dependencies manually, finally followed by WebKit itself.
2770         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
2771         configuration to match our other projects.
2772         * WebKitInitializer/debug_internal.vsprops: Added.
2773
2774 2007-09-25  Adam Roben  <aroben@apple.com>
2775
2776         Actually define DEBUG/NDEBUG so that we load WebKit correctly
2777
2778         Rubberstamped by Sam.
2779
2780         * WebKitInitializer/WebKitInitializer.vcproj:
2781
2782 2007-09-25  Adam Roben  <aroben@apple.com>
2783
2784         Make DumpRenderTree delay-load its dependencies
2785
2786         This lets WebKitInitializer re-route the dependencies to be loaded out
2787         of the Safari installation directory.
2788
2789         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
2790         same thing), since we can't import the kCFAllocatorDefault symbol when
2791         delay-loading CoreFoundation.dll.
2792
2793         Rubberstamped by Sam.
2794
2795         * DumpRenderTree/win/DumpRenderTree.cpp:
2796         (runTest):
2797         (javaScriptThreads):
2798         * DumpRenderTree/win/DumpRenderTree.vcproj:
2799         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2800         (LayoutTestController::setWaitToDump):
2801
2802 2007-09-25  Adam Roben  <aroben@apple.com>
2803
2804         Pull ole32.lib into WebKitInitializer
2805
2806         Rubberstamped by Sam.
2807
2808         * WebKitInitializer/WebKitInitializer.vcproj:
2809
2810 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2811
2812         Reviewed by Adam.
2813
2814         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
2815           LGPL'ed files contain incorrect FSF address
2816
2817         * Drosera/config.h:
2818
2819 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2820
2821         Reviewed by Adam.
2822
2823         Make svn-apply and svn-unapply work with git-diff formatted patches.
2824
2825         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
2826         (gitdiff2svndiff): Added.
2827         * Scripts/svn-unapply: Ditto.
2828         (gitdiff2svndiff): Added.
2829
2830 2007-09-25  Adam Roben  <aroben@apple.com>
2831
2832         Pull advapi32.lib into WebKitInitializer
2833
2834         This is needed to get the registry functions we use.
2835
2836         Rubberstamped by Sam.
2837
2838         * WebKitInitializer/WebKitInitializer.vcproj:
2839
2840 2007-09-25  Adam Roben  <aroben@apple.com>
2841
2842         Add python and rsync to cygwin-downloader
2843
2844         Our build slaves need this, and it can't hurt for everyone else to
2845         have it, too.
2846
2847         Reviewed by Sam.
2848
2849         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
2850         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2851
2852 2007-09-25  Adam Roben  <aroben@apple.com>
2853
2854         Add WebKitInitializer and use it in DumpRenderTree
2855
2856         WebKitInitializer is a static library that has one function,
2857         initializeWebKit(). This registers WebKit and sets up the DLL search
2858         path so that WebKit's dependencies that are installed with Safari can
2859         be found.
2860
2861         Reviewed by Sam.
2862
2863         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
2864         DumpRenderTree depend on it.
2865         * DumpRenderTree/win/DumpRenderTree.cpp:
2866         (initialize): Call initializeWebKit.
2867         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
2868         WebKitInitializer.lib.
2869         * WebKitInitializer/WebKitInitializer.cpp: Added.
2870         (getStringValue):
2871         (getWebViewCLSID):
2872         (getInstalledWebKitDirectory):
2873         (initializeWebKit):
2874         * WebKitInitializer/WebKitInitializer.h: Added.
2875         * WebKitInitializer/WebKitInitializer.vcproj: Added.
2876         * WebKitInitializer/debug.vsprops: Added.
2877         * WebKitInitializer/release.vsprops: Added.
2878
2879 2007-09-25  Adam Roben  <aroben@apple.com>
2880
2881         Make run-webkit-tests respect set-webkit-configuration
2882
2883         Reviewed by Sam.
2884
2885         * Scripts/run-webkit-tests: Initialize $configuration to whatever
2886         set-webkit-configuration was last set to.
2887
2888 2007-09-25  Mark Rowe  <mrowe@apple.com>
2889
2890         Rubber-stamped by Eric.
2891
2892         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2893         This makes it possible to automate nightly builds for the feature-branch.
2894
2895 2007-09-25  Adam Roben  <aroben@apple.com>
2896
2897         A couple of fixes/enhancements to update-webkit-*-libs
2898
2899         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
2900         to tell update-webkit-support-libraries where it should find the
2901         WebKitSupportLibrary.zip file you downloaded.
2902
2903         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
2904         Windows-style path.
2905
2906         Reviewed by Sam.
2907
2908         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
2909         to $auxiliaryLibsURL and removed an irrelevant comment.
2910         * Scripts/update-webkit-support-libs:
2911
2912 2007-09-25  Adam Treat  <treat@kde.org>
2913
2914         Reviewed by Simon and Lars.
2915
2916         Refactors and cleans up Qt DRT member variable names, member variable
2917         initialization, style fixes and general code cleanup.
2918
2919         Adds queueReload slot to LayoutTestController that some tests require.
2920
2921         Subclasses QWebFrame to make sure that all frames have an associated
2922         LayoutTestController JS window object.
2923
2924         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
2925         aren't dumped twice.
2926
2927         EOF fixes.
2928
2929         Together, this patch fixes some 20+ layout tests in QtWebKit.
2930
2931         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2932         (WebCore::WebFrame::WebFrame):
2933         (WebCore::WebPage::WebPage):
2934         (WebCore::WebPage::createFrame):
2935         (WebCore::DumpRenderTree::DumpRenderTree):
2936         (WebCore::DumpRenderTree::open):
2937         (WebCore::DumpRenderTree::readStdin):
2938         (WebCore::DumpRenderTree::initJSObjects):
2939         (WebCore::DumpRenderTree::dump):
2940         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2941         (WebCore::DumpRenderTree::layoutTestController):
2942         (WebCore::DumpRenderTree::eventSender):
2943         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2944         (LayoutTestController::LayoutTestController):
2945         (LayoutTestController::reset):
2946         (LayoutTestController::maybeDump):
2947         (LayoutTestController::waitUntilDone):
2948         (LayoutTestController::notifyDone):
2949         (LayoutTestController::queueReload):
2950         (LayoutTestController::provisionalLoad):
2951         (EventSender::EventSender):
2952         (EventSender::mouseDown):
2953         (EventSender::mouseUp):
2954         (EventSender::mouseMoveTo):
2955         (EventSender::frameUnderMouse):
2956         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2957         (LayoutTestController::isLoading):
2958         (LayoutTestController::setLoading):
2959         (LayoutTestController::dumpAsText):
2960         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2961         (main):
2962
2963 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2964
2965
2966         - Reverted an accidentally checked in file.
2967
2968         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
2969
2970 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2971         Reviewed by Sam.
2972
2973         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
2974
2975         * DumpRenderTree/win/DumpRenderTree.vcproj:
2976         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2977
2978 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
2979
2980         Rubber stamped by Adam.
2981
2982         * GdkLauncher: Removed.
2983         * GdkLauncher/Bakefiles.bkgen: Removed.
2984         * GdkLauncher/ENV: Removed.
2985         * GdkLauncher/GdkLauncher.pro: Removed.
2986         * GdkLauncher/gdklauncher.bkl: Removed.
2987         * GdkLauncher/main.cpp: Removed.
2988         * GdkLauncher/mk: Removed.
2989         * GdkLauncher/simple.svg: Removed.
2990         * GdkLauncher/text.html: Removed.
2991         * GtkLauncher: Added.
2992         * GtkLauncher/GdkLauncher.pro: Removed.
2993         * GtkLauncher/GtkLauncher.pro: Added.
2994         * GtkLauncher/main.cpp:
2995         (updateWindowTitle):
2996         (main):
2997         * Scripts/build-webkit:
2998         * Scripts/regenerate-makefiles:
2999         * Scripts/run-javascriptcore-tests:
3000         * Scripts/run-launcher:
3001         * Scripts/run-webkit-tests:
3002         * Scripts/webkitdirs.pm:
3003
3004 2007-09-21  Timothy Hatcher  <timothy@apple.com>
3005
3006         Reviewed by Darin.
3007
3008         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
3009
3010         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
3011         This is tested by plugins/root-object-premature-delete-crash.html.
3012
3013         * DumpRenderTree/mac/ObjCController.m:
3014         (-[ObjCController accessStoredWebScriptObject]):
3015
3016 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
3017
3018         Reviewed by Oliver.
3019
3020         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
3021
3022         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3023         (FrameLoadDelegate::FrameLoadDelegate):
3024
3025 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
3026
3027         Reviewed by Adam.
3028
3029         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
3030         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
3031
3032         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
3033         Now isQt() and isGdk() use global variables that are only set once.
3034
3035         An array of all the parameters is now given to build-dumprender which includes
3036         the platform on linux.
3037
3038         * Scripts/build-dumprendertree:
3039         * Scripts/run-webkit-tests:
3040         * Scripts/webkitdirs.pm:
3041
3042 2007-09-19  Adam Roben  <aroben@apple.com>
3043
3044         Rubberstamped by Hyatt.
3045
3046         * Spinneret: Removed.
3047
3048 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
3049
3050         Reviewed by David Kilzer.
3051
3052         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
3053
3054 2007-09-18  Sam Weinig  <sam@webkit.org>
3055
3056         Add JSRetainPtr.h #include to fix some builds.
3057
3058         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3059
3060 2007-09-18  Mike Hommey  <glandium@debian.org>
3061
3062         Reviewed by Adam.
3063
3064         * Scripts/prepare-ChangeLog:
3065         - Properly parse GECOS field.
3066         - Use git configuration for user name and email when appropriate.
3067
3068 2007-09-17  Sam Weinig  <sam@webkit.org>
3069
3070         Build fix.
3071
3072         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3073
3074 2007-09-17  Sam Weinig  <sam@webkit.org>
3075
3076         Reviewed by Adam Roben.
3077
3078         Share more code between mac and windows DRT.
3079             - GCController is now shared.
3080             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
3081
3082         * DumpRenderTree/GCController.cpp:
3083         * DumpRenderTree/win/DumpRenderTree.cpp:
3084         * DumpRenderTree/win/DumpRenderTree.vcproj:
3085         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
3086         (FrameLoadDelegate::FrameLoadDelegate):
3087         (FrameLoadDelegate::~FrameLoadDelegate):
3088         (FrameLoadDelegate::windowScriptObjectAvailable):
3089         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
3090         * DumpRenderTree/win/GCController.cpp: Removed.
3091         * DumpRenderTree/win/GCController.h: Removed.
3092         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
3093         (GCController::collect):
3094         (GCController::collectOnAlternateThread):
3095         (GCController::getJSObjectCount):
3096         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
3097         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
3098
3099 2007-09-17  Sam Weinig  <sam@webkit.org>
3100
3101         Reviewed by Adam Roben.
3102
3103         Begin sharing code between mac and windows DRT.
3104             - both now share LayoutTestController.h/cpp and implement platform dependant 
3105               operations in LayoutTestControllerMac/Win.
3106             - DumpRenderTree.h is now shared.
3107             - WorkQueue and WorkQueueItem are also shared.
3108
3109         * DumpRenderTree/DumpRenderTree.h:
3110         * DumpRenderTree/LayoutTestController.cpp:
3111         * DumpRenderTree/win/DumpRenderTree.cpp:
3112         (displayWebView):
3113         (dumpFrameScrollPosition):
3114         (dumpFramesAsText):
3115         (dump):
3116         (runTest):
3117         * DumpRenderTree/win/DumpRenderTree.h: Removed.
3118         * DumpRenderTree/win/DumpRenderTree.vcproj:
3119         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
3120         * DumpRenderTree/win/EditingDelegate.cpp:
3121         (EditingDelegate::shouldBeginEditingInDOMRange):
3122         (EditingDelegate::shouldEndEditingInDOMRange):
3123         (EditingDelegate::shouldInsertNode):
3124         (EditingDelegate::shouldInsertText):
3125         (EditingDelegate::shouldDeleteDOMRange):
3126         (EditingDelegate::shouldChangeSelectedDOMRange):
3127         (EditingDelegate::shouldApplyStyle):
3128         (EditingDelegate::shouldChangeTypingStyle):
3129         (EditingDelegate::doPlatformCommand):
3130         (EditingDelegate::webViewDidBeginEditing):
3131         (EditingDelegate::webViewDidChange):
3132         (EditingDelegate::webViewDidEndEditing):
3133         (EditingDelegate::webViewDidChangeTypingStyle):
3134         (EditingDelegate::webViewDidChangeSelection):
3135         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
3136         * DumpRenderTree/win/LayoutTestController.h: Removed.
3137         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
3138         (LayoutTestController::addDisallowedURL):
3139         (LayoutTestController::clearBackForwardList):
3140         (LayoutTestController::copyDecodedHostName):
3141         (LayoutTestController::copyEncodedHostName):
3142         (LayoutTestController::display):
3143         (LayoutTestController::keepWebHistory):
3144         (LayoutTestController::notifyDone):
3145         (LayoutTestController::queueBackNavigation):
3146         (LayoutTestController::queueForwardNavigation):
3147         (jsStringRefToWString):
3148         (LayoutTestController::queueLoad):
3149         (LayoutTestController::queueReload):
3150         (LayoutTestController::queueScript):
3151         (LayoutTestController::setAcceptsEditing):
3152         (LayoutTestController::setCustomPolicyDelegate):
3153         (LayoutTestController::setMainFrameIsFirstResponder):
3154         (LayoutTestController::setTabKeyCyclesThroughElements):
3155         (LayoutTestController::setUseDashboardCompatibilityMode):
3156         (LayoutTestController::setUserStyleSheetEnabled):
3157         (LayoutTestController::setUserStyleSheetLocation):
3158         (LayoutTestController::setWindowIsKey):
3159         (waitUntilDoneWatchdogFired):
3160         (LayoutTestController::setWaitToDump):
3161         (LayoutTestController::windowCount):
3162         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
3163         (FrameLoadDelegate::didReceiveTitle):
3164         (FrameLoadDelegate::processWork):
3165         (FrameLoadDelegate::locationChangeDone):
3166         (FrameLoadDelegate::windowScriptObjectAvailable):
3167         * DumpRenderTree/win/WorkQueue.cpp: Removed.
3168         * DumpRenderTree/win/WorkQueue.h: Removed.
3169         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
3170         * DumpRenderTree/win/WorkQueueItem.h: Removed.
3171         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
3172         (jsStringRefToWString):
3173         (LoadItem::invoke):
3174         (ScriptItem::invoke):
3175
3176 2007-09-17  Sam Weinig  <sam@webkit.org>
3177
3178         Reviewed by Adam Roben.
3179
3180         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
3181
3182         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
3183         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
3184         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
3185         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
3186         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
3187         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
3188         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
3189         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
3190         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
3191         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
3192         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
3193         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
3194         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
3195         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
3196         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
3197         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
3198         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
3199         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
3200         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
3201         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
3202         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
3203         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
3204         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
3205         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
3206         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
3207         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
3208         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
3209         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
3210         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
3211         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
3212         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
3213         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
3214         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
3215         * DumpRenderTree/win: Added.
3216         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
3217         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
3218         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
3219         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
3220         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
3221         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
3222         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
3223         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
3224         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
3225         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
3226         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
3227         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
3228         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
3229         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3230         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
3231         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
3232         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
3233         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
3234         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3235         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3236         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
3237         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3238         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
3239         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
3240         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
3241         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
3242
3243 2007-09-15  Mark Rowe  <mrowe@apple.com>
3244
3245         Build fix for DumpRenderTree.
3246
3247         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
3248
3249 2007-09-14  Sam Weinig  <sam@webkit.org>
3250
3251         Rubber stamped by Adam Roben.
3252
3253         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
3254           - The UIDelegate was put into a new file while the FrameLoadDelegate was
3255             kept in the WaitUntilDoneDelegate file for the time being.
3256
3257         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3258         (main):
3259         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
3260         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
3261         (UIDelegate::QueryInterface):
3262         (UIDelegate::AddRef):
3263         (UIDelegate::Release):
3264         (UIDelegate::hasCustomMenuImplementation):
3265         (UIDelegate::setFrame):
3266         (UIDelegate::webViewFrame):
3267         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3268         (UIDelegate::webViewAddMessageToConsole):
3269         (UIDelegate::doDragDrop):
3270         (UIDelegate::webViewGetDlgCode):
3271         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
3272         (UIDelegate::UIDelegate):
3273         (UIDelegate::createWebViewWithRequest):
3274         (UIDelegate::webViewShow):
3275         (UIDelegate::webViewClose):
3276         (UIDelegate::webViewFocus):
3277         (UIDelegate::webViewUnfocus):
3278         (UIDelegate::webViewFirstResponder):
3279         (UIDelegate::makeFirstResponder):
3280         (UIDelegate::setStatusText):
3281         (UIDelegate::webViewStatusText):
3282         (UIDelegate::webViewAreToolbarsVisible):
3283         (UIDelegate::setToolbarsVisible):
3284         (UIDelegate::webViewIsStatusBarVisible):
3285         (UIDelegate::setStatusBarVisible):
3286         (UIDelegate::webViewIsResizable):
3287         (UIDelegate::setResizable):
3288         (UIDelegate::setContentRect):
3289         (UIDelegate::webViewContentRect):
3290         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3291         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3292         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3293         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
3294         (UIDelegate::mouseDidMoveOverElement):
3295         (UIDelegate::contextMenuItemsForElement):
3296         (UIDelegate::validateUserInterfaceItem):
3297         (UIDelegate::shouldPerformAction):
3298         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
3299         (UIDelegate::willPerformDragDestinationAction):
3300         (UIDelegate::dragSourceActionMaskForPoint):
3301         (UIDelegate::willPerformDragSourceAction):
3302         (UIDelegate::contextMenuItemSelected):
3303         (UIDelegate::trackCustomPopupMenu):
3304         (UIDelegate::measureCustomMenuItem):
3305         (UIDelegate::drawCustomMenuItem):
3306         (UIDelegate::addCustomMenuDrawingData):
3307         (UIDelegate::cleanUpCustomMenuDrawingData):
3308         (UIDelegate::canTakeFocus):
3309         (UIDelegate::takeFocus):
3310         (UIDelegate::registerUndoWithTarget):
3311         (UIDelegate::removeAllActionsWithTarget):
3312         (UIDelegate::setActionTitle):
3313         (UIDelegate::undo):
3314         (UIDelegate::redo):
3315         (UIDelegate::canUndo):
3316         (UIDelegate::canRedo):
3317         (UIDelegate::webViewResizerRect):
3318         (UIDelegate::webViewDrawResizer):
3319         (UIDelegate::webViewScrolled):
3320         (UIDelegate::webViewShouldInterruptJavaScript):
3321         (UIDelegate::webViewReceivedFocus):
3322         (UIDelegate::webViewLostFocus):
3323         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
3324         (FrameLoadDelegate::QueryInterface):
3325         (FrameLoadDelegate::AddRef):
3326         (FrameLoadDelegate::Release):
3327         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3328         (FrameLoadDelegate::didCommitLoadForFrame):
3329         (FrameLoadDelegate::didReceiveTitle):
3330         (FrameLoadDelegate::processWork):
3331         (processWorkTimer):
3332         (FrameLoadDelegate::locationChangeDone):
3333         (FrameLoadDelegate::didFinishLoadForFrame):
3334         (FrameLoadDelegate::didFailLoadWithError):
3335         (FrameLoadDelegate::windowScriptObjectAvailable):
3336         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
3337         (FrameLoadDelegate::FrameLoadDelegate):
3338
3339 2007-09-14  Sam Weinig  <sam@webkit.org>
3340
3341         Reviewed by Kevin McCullough.
3342
3343         Move mac specific globals in to mac/DumpRenderTreeMac.h
3344
3345         * DumpRenderTree/DumpRenderTree.h:
3346         * DumpRenderTree/DumpRenderTree.mm: Removed.
3347         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3348         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
3349         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
3350
3351 2007-09-14  Brady Eidson  <beidson@apple.com>
3352
3353         Rubberstamped by Weinig
3354
3355         You know, Sam, some of us use case-sensitve filesystems...
3356
3357         * DumpRenderTree/DumpRenderTree.h:
3358         * DumpRenderTree/mac/UIDelegate.mm:
3359
3360 2007-09-14  Sam Weinig  <sam@webkit.org>
3361
3362         Rubber stamped by Adam Roben.
3363
3364         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
3365         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
3366
3367         * DumpRenderTree/AppleScriptController.h: Removed.
3368         * DumpRenderTree/AppleScriptController.m: Removed.
3369         * DumpRenderTree/DumpRenderTree.h:
3370         * DumpRenderTree/DumpRenderTree.mm:
3371         (startJavaScriptThreads):
3372         (stopJavaScriptThreads):
3373         (activateAhemFont):
3374         (setDefaultColorProfileToRGB):
3375         (makeLargeMallocFailSilently):
3376         (dumpFrameScrollPosition):
3377         (dumpFramesAsText):
3378         (dump):
3379         (runTest):
3380         (-[DumpRenderTreeWindow isKeyWindow]):
3381         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3382         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
3383         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
3384         * DumpRenderTree/EditingDelegate.h: Removed.
3385         * DumpRenderTree/EditingDelegate.m: Removed.
3386         * DumpRenderTree/EventSendingController.h: Removed.
3387         * DumpRenderTree/EventSendingController.m: Removed.
3388         * DumpRenderTree/FrameLoadDelegate.h: Removed.
3389         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
3390         * DumpRenderTree/GCController.mm: Removed.
3391         * DumpRenderTree/ImageDiff.m: Removed.
3392         * DumpRenderTree/LayoutTestController.cpp:
3393         (LayoutTestController::LayoutTestController):
3394         (dumpAsTextCallback):
3395         (dumpBackForwardListCallback):
3396         (dumpChildFramesAsTextCallback):
3397         (dumpChildFrameScrollPositionsCallback):
3398         (dumpDOMAsWebArchiveCallback):
3399         (dumpEditingCallbacksCallback):
3400         (dumpFrameLoadCallbacksCallback):
3401         (dumpResourceLoadCallbacksCallback):
3402         (dumpSelectionRectCallback):
3403         (dumpSourceAsWebArchiveCallback):
3404         (dumpTitleChangesCallback):
3405         (repaintSweepHorizontallyCallback):
3406         (setCallCloseOnWebViewsCallback):
3407         (setCanOpenWindowsCallback):
3408         (setCloseRemainingWindowsWhenCompleteCallback):
3409         (testRepaintCallback):
3410         (addFileToPasteboardOnDragCallback):
3411         (waitUntilDoneCallback):
3412         * DumpRenderTree/LayoutTestController.h:
3413         (LayoutTestController::dumpAsText):
3414         (LayoutTestController::setDumpAsText):
3415         (LayoutTestController::dumpBackForwardList):
3416         (LayoutTestController::setDumpBackForwardList):
3417         (LayoutTestController::dumpChildFrameScrollPositions):
3418         (LayoutTestController::setDumpChildFrameScrollPositions):
3419         (LayoutTestController::dumpChildFramesAsText):
3420         (LayoutTestController::setDumpChildFramesAsText):
3421         (LayoutTestController::dumpDOMAsWebArchive):
3422         (LayoutTestController::setDumpDOMAsWebArchive):
3423         (LayoutTestController::dumpSelectionRect):
3424         (LayoutTestController::setDumpSelectionRect):
3425         (LayoutTestController::dumpSourceAsWebArchive):
3426         (LayoutTestController::setDumpSourceAsWebArchive):
3427         (LayoutTestController::dumpTitleChanges):
3428         (LayoutTestController::setDumpTitleChanges):
3429         (LayoutTestController::dumpEditingCallbacks):
3430         (LayoutTestController::setDumpEditingCallbacks):
3431         (LayoutTestController::dumpResourceLoadCallbacks):
3432         (LayoutTestController::setDumpResourceLoadCallbacks):
3433         (LayoutTestController::dumpFrameLoadCallbacks):
3434         (LayoutTestController::setDumpFrameLoadCallbacks):
3435         (LayoutTestController::addFileToPasteboardOnDrag):
3436         (LayoutTestController::setAddFileToPasteboardOnDrag):
3437         (LayoutTestController::callCloseOnWebViews):
3438         (LayoutTestController::setCallCloseOnWebViews):
3439         (LayoutTestController::canOpenWindows):
3440         (LayoutTestController::setCanOpenWindows):
3441         (LayoutTestController::closeRemainingWindowsWhenComplete):
3442         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3443         (LayoutTestController::testRepaint):
3444         (LayoutTestController::setTestRepaint):
3445         (LayoutTestController::testRepaintSweepHorizontally):
3446         (LayoutTestController::setTestRepaintSweepHorizontally):
3447         (LayoutTestController::waitToDump):
3448         (LayoutTestController::windowIsKey):
3449         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
3450         * DumpRenderTree/NavigationController.h: Removed.
3451         * DumpRenderTree/NavigationController.m: Removed.
3452         * DumpRenderTree/ObjCController.h: Removed.
3453         * DumpRenderTree/ObjCController.m: Removed.
3454         * DumpRenderTree/ObjCPlugin.h: Removed.
3455         * DumpRenderTree/ObjCPlugin.m: Removed.
3456         * DumpRenderTree/ObjCPluginFunction.h: Removed.
3457         * DumpRenderTree/ObjCPluginFunction.m: Removed.
3458         * DumpRenderTree/PolicyDelegate.h: Removed.
3459         * DumpRenderTree/PolicyDelegate.m: Removed.
3460         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
3461         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
3462         * DumpRenderTree/TextInputController.h: Removed.
3463         * DumpRenderTree/TextInputController.m: Removed.
3464         * DumpRenderTree/UIDelegate.h: Removed.
3465         * DumpRenderTree/UIDelegate.mm: Removed.
3466         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
3467         * DumpRenderTree/mac: Added.
3468         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
3469         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
3470         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
3471         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
3472         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
3473         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
3474         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3475         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3476         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3477         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3478         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3479         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3480         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3481         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3482         (-[EditingDelegate webViewDidBeginEditing:]):
3483         (-[EditingDelegate webViewDidChange:]):
3484         (-[EditingDelegate webViewDidEndEditing:]):
3485         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3486         (-[EditingDelegate webViewDidChangeSelection:]):
3487         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
3488         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
3489         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
3490         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
3491         (-[FrameLoadDelegate init]):
3492         (-[FrameLoadDelegate dealloc]):
3493         (-[FrameLoadDelegate processWork:]):
3494         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3495         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3496         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3497         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3498         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3499         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3500         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3501         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3502         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3503         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3504         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3505         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3506         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3507         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3508         (-[FrameLoadDelegate webView:willCloseFrame:]):
3509         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3510         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3511         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
3512         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
3513         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
3514         (LayoutTestController::notifyDone):
3515         (LayoutTestController::setWindowIsKey):
3516         (LayoutTestController::setWaitToDump):
3517         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
3518         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
3519         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
3520         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
3521         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
3522         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
3523         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
3524         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
3525         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
3526         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
3527         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
3528         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
3529         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3530         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3531         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3532         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3533         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3534         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3535         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
3536         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
3537         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
3538         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
3539         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
3540         (-[UIDelegate webViewFocus:]):
3541         (-[UIDelegate webView:createWebViewWithRequest:]):
3542         (-[UIDelegate webViewClose:]):
3543         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
3544
3545 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
3546
3547         Reviewed by Adam.
3548
3549         - Changing Win version of Drosera work with recent changes.
3550
3551         * Drosera/DebuggerDocument.cpp:
3552         * Drosera/DebuggerDocument.h:
3553         * Drosera/mac/DebuggerDocumentPlatform.mm:
3554         (NSStringCreateWithJSStringRef):
3555         (JSValueRefCreateWithNSString):
3556         * Drosera/win/DebuggerClient.cpp:
3557         (DebuggerClient::stepInto):
3558         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3559
3560 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
3561