WebKitTools/ChangeLog

   1 2008-12-12  Darin Adler  <darin@apple.com>
   2
   3         * Scripts/do-webcore-rename: Add a renaming idea.
   4
   5 2008-12-12  Holger Hans Peter Freyther  <zecke@selfish.org>
   6
   7         Reviewed by Simon Hausmann.
   8
   9         Update the WebKit.qrc and add a script to automatically generate the file.
  10
  11         With the way rcc and qmake work this can not be done at build time
  12         as the WebKit.qrc must sit inside the directory that contains the files
  13         and at build time we may not change the content of the source directory.
  14
  15         * Scripts/generate-qt-inspector-resource: Added.
  16
  17 2008-12-11  Cameron Zwarich  <zwarich@apple.com>
  18
  19         Rubber-stamped by Mark Rowe.
  20
  21         Roll out r39212 due to assertion failures during layout tests, multiple
  22         layout test failures, memory leaks, and obvious incorrectness.
  23
  24         * DumpRenderTree/LayoutTestController.cpp:
  25         (LayoutTestController::staticFunctions):
  26         * DumpRenderTree/LayoutTestController.h:
  27         * DumpRenderTree/mac/DumpRenderTree.mm:
  28         (resetWebViewToConsistentStateBeforeTesting):
  29         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  30         * DumpRenderTree/win/DumpRenderTree.cpp:
  31         (resetWebViewToConsistentStateBeforeTesting):
  32         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  33         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
  34
  35 2008-12-10  Glenn Wilson  <gwilson@google.com>
  36
  37         Reviewed by Adam Roben.
  38
  39         Changed LayoutTestController and DumpRenderTree to allow for manual
  40         overriding of default preferences at test time.  Also added support for
  41         resetting the preferences after each test.
  42         https://bugs.webkit.org/show_bug.cgi?id=20534
  43
  44         * DumpRenderTree/LayoutTestController.cpp: Added callback method for overriding preferences
  45         * DumpRenderTree/LayoutTestController.h: Added signature for callback
  46         * DumpRenderTree/win/DumpRenderTree.cpp: Added calls to reset preferences after each test if necessary
  47         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added JS override function
  48         * DumpRenderTree/mac/DumpRenderTree.mm: Added calls to reset preferences after each test if necessary
  49         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Added JS override function
  50
  51 2008-12-10  Brady Eidson  <beidson@apple.com>
  52
  53         Reviewed by Darin Adler.
  54
  55         Implement the new policy delegate (including navigation type and permissive mode) for DRT/win
  56
  57         * DumpRenderTree/win/DumpRenderTree.cpp:
  58         * DumpRenderTree/win/DumpRenderTreeWin.h:
  59
  60         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  61         (LayoutTestController::setCustomPolicyDelegate):
  62
  63         * DumpRenderTree/win/PolicyDelegate.cpp:
  64         (PolicyDelegate::PolicyDelegate):
  65         (PolicyDelegate::decidePolicyForNavigationAction):
  66         * DumpRenderTree/win/PolicyDelegate.h:
  67         (PolicyDelegate::setPermissive):
  68
  69 2008-12-10  Brady Eidson  <beidson@apple.com>
  70
  71         Reviewed by Darin
  72
  73         Change the custom policy delegate to actually allow navigation for tests that need it.
  74         The new behavior is opt-in and doesn't require any changes in old tests.
  75
  76         * DumpRenderTree/LayoutTestController.cpp:
  77         (setCustomPolicyDelegateCallback):  Allow for a second boolean argument to set the permissive flag on the custom
  78           policy delegate, which will be false by default to maintain original behavior.
  79         * DumpRenderTree/LayoutTestController.h:
  80         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  81         (LayoutTestController::setCustomPolicyDelegate):
  82
  83         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  84         (LayoutTestController::setCustomPolicyDelegate):  Partially stubbed out for now.
  85         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  86         (LayoutTestController::setCustomPolicyDelegate):  Still stubbed out, but with new param.
  87
  88         * DumpRenderTree/mac/PolicyDelegate.h:
  89         * DumpRenderTree/mac/PolicyDelegate.mm:
  90         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):  If the permissive flag
  91           is set, allow the navigation.
  92         (-[PolicyDelegate setPermissive:]):  Change the behavior between "use" and "ignore" - allowing navigation or not.
  93
  94 2008-12-09  Mark Rowe  <mrowe@apple.com>
  95
  96         Rubber-stamped by Ada Chan.
  97
  98         Fix gdb-safari on Tiger.
  99
 100         gdb on Tiger does not take the -arch flag, so do not pass it.
 101
 102         * Scripts/gdb-safari:
 103
 104 2008-12-09  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
 105
 106         Reviewed by Alexey Proskuryakov.
 107
 108         Ignore WML tests, if no WML support available.
 109
 110         * Scripts/run-webkit-tests:
 111
 112 2008-12-08  Geoffrey Garen  <ggaren@apple.com>
 113
 114         Reviewed by Oliver Hunt.
 115
 116         Added a shortcut for --jsDriver-args, which I use a lot.
 117
 118         * Scripts/run-javascriptcore-tests:
 119
 120 2008-12-08  Stephanie Lewis  <slewis@apple.com>
 121
 122         Fix Tiger build.
 123
 124         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 125
 126 2008-12-08  Darin Adler  <darin@apple.com>
 127
 128         Reviewed by John Sullivan.
 129
 130         - test machinery for https://bugs.webkit.org/show_bug.cgi?id=22409
 131           REGRESSION: cmd-shift-left/right don't switch tabs, instead select text
 132
 133         * DumpRenderTree/LayoutTestController.cpp:
 134         (isCommandEnabledCallback): Added.
 135         (LayoutTestController::staticFunctions): Added "isCommandEnabled".
 136         * DumpRenderTree/LayoutTestController.h: Ditto.
 137         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 138         (LayoutTestController::isCommandEnabled): Ditto.
 139         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 140         (-[CommandValidationTarget initWithAction:]): Added. Used to get the
 141         command validation system to tell us if a comment is enabled.
 142         (-[CommandValidationTarget action]): Ditto.
 143         (-[CommandValidationTarget tag]): Ditto.
 144         (LayoutTestController::isCommandEnabled): Ditto.
 145         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 146         (LayoutTestController::isCommandEnabled): Ditto.
 147
 148 2008-12-08  David Kilzer  <ddkilzer@apple.com>
 149
 150         Bug 22555: Sort "children" sections in Xcode project files
 151
 152         <https://bugs.webkit.org/show_bug.cgi?id=22555>
 153
 154         Reviewed by Eric Seidel.
 155
 156         * DrawTest/DrawTest.xcodeproj/project.pbxproj: Sorted.
 157         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Sorted.
 158         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Sorted.
 159
 160 2008-12-08  David Kilzer  <ddkilzer@apple.com>
 161
 162         Bug 22555: Sort "children" sections in Xcode project files
 163
 164         <https://bugs.webkit.org/show_bug.cgi?id=22555>
 165
 166         Reviewed by Timothy Hatcher.
 167
 168         * Scripts/sort-Xcode-project-file: By popular request, don't sort
 169         the mainGroup in the project (the list of items below the top-level
 170         project file).
 171
 172 2008-12-05  David Kilzer  <ddkilzer@apple.com>
 173
 174         Bug 22555: Sort "children" sections in Xcode project files
 175
 176         <https://bugs.webkit.org/show_bug.cgi?id=22555>
 177
 178         Reviewed by Darin Adler.
 179
 180         Sort "children" sections alphabetically, moving groups (folders) to
 181         the top of each of the lists.  Files are assumed to have extensions,
 182         so %isFile is used to override this behavior.
 183
 184         * Scripts/sort-Xcode-project-file:
 185         (sortChildrenByFileName): Added.
 186         (sortFilesByFileName): Renamed from sortByFileName().
 187
 188 2008-12-05  Eric Seidel  <eric@webkit.org>
 189
 190         Reviewed by Geoff Garen.
 191
 192         https://bugs.webkit.org/show_bug.cgi?id=22683
 193         Fix gtk and qt builds which depend on --qt and --gtk being removed from ARGV
 194         Add a new argumentsForConfiguration() function and clean up some old code to use it.
 195         Rename checkArgV to checkForArgumentAndRemoveFromARGV to be more self-documenting.
 196
 197         * Scripts/run-javascriptcore-tests:
 198         * Scripts/run-launcher:
 199         * Scripts/run-webkit-tests:
 200         * Scripts/webkitdirs.pm:
 201
 202 2008-12-03  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
 203
 204         Reviewed by Cameron Zwarich.
 205
 206         Further preparations for WML layout tests.
 207         Ignore WMLTestCase.js, that's going to be in trunk soon.
 208
 209         * Scripts/make-js-test-wrappers:
 210
 211 2008-12-03  Eric Seidel  <eric@webkit.org>
 212
 213         Build fix for --gtk and --chromium, no review.
 214
 215         Fix run-javascriptcore-tests to pass --gtk, --qt, --chromium, etc.
 216         through to build-jsc.
 217
 218         * Scripts/build-jsc:
 219         * Scripts/webkitdirs.pm:
 220
 221 2008-12-03  Eric Seidel  <eric@webkit.org>
 222
 223         Build fix only, no review.
 224
 225         Remove support for build-webkit --svg-experimental.
 226         All of the "experimental" svg features have their own toggles anyway.
 227         I broke --svg-experimental in my last commit (which then broke clean builds)
 228         I can't find any use of --svg-experimental in our source tree, so removing it.
 229
 230         * Scripts/build-webkit:
 231
 232 2008-12-02  Eric Seidel  <eric@webkit.org>
 233
 234         Reviewed by David Hyatt (and Mark Rowe).
 235
 236         Move --coverage support from build-webkit to webkitdirs.pm to share it with build-jsc
 237         Move --coverage support out of run-javascriptcore-tests and into build-jsc
 238
 239         Finally add a buildXCodeProject function to webkitdirs.pm and move --clean support
 240         there from build-webkit (to allow future sharing with other build-* scripts)
 241
 242         Change run-javascriptcore-tests to expect a --jsDriver-args= argument instead of
 243         picking through ARGV with a blacklist of what arguments weren't jsDriver args
 244         this makes run-javascriptcore-tests transparently support all arguments which
 245         webkitdirs.pm gives it support for.
 246
 247         Make run-javascriptcore-tests actually print what commands it's running before running them.
 248
 249         Add --help support to build-jsc and run-javascriptcore-tests!
 250
 251         Make code to support --svg-experimental defaults take up half as many lines.
 252
 253         * Scripts/build-jsc:
 254         * Scripts/build-webkit:
 255         * Scripts/run-javascriptcore-tests:
 256         * Scripts/webkitdirs.pm:
 257
 258 2008-12-03  Adam Roben  <aroben@apple.com>
 259
 260         Fix a leak in WinLauncher shutdown
 261
 262         Reviewed by Sam Weinig.
 263
 264         * WinLauncher/WinLauncher.cpp:
 265         (_tWinMain): Replaced a delete with a Release. We can't delete the
 266         WebView properly since we only have a pointer to one of its
 267         interfaces. We also shouldn't be deleting COM objects directly anyway,
 268         for a number of reasons.
 269
 270 2008-12-03  Adam Roben  <aroben@apple.com>
 271
 272         Fix a crash on exit in WinLauncher
 273
 274         Reviewed by Sam Weinig.
 275
 276         * WinLauncher/WinLauncher.cpp:
 277         (_tWinMain): Call shutDownWebKit before exiting.
 278
 279 2008-12-03  Adam Roben  <aroben@apple.com>
 280
 281         Add a Debug_Internal configuration to WinLauncher
 282
 283         This matches our other projects.
 284
 285         Reviewed by Sam Weinig.
 286
 287         * WinLauncher/WinLauncher.vcproj: Added a Debug_Internal
 288         configuration, which is identical to Debug except that it also
 289         references debug_internal.vsprops. Also removed some settings that we
 290         should be picking up from the .vsprops files.
 291
 292 2008-12-02  Eric Seidel  <eric@webkit.org>
 293
 294         Reviewed by David Kilzer.
 295
 296         Hack build-webkit --chromium to use Win32 python instead
 297         of using the default cygwin python.  Scons + CYGWIN tries
 298         to build with GCC by default, we force MSVC in our file
 299         but that just results in errors from Scons.  Until we can fix
 300         this latest round of errors, at least make build-webkit --chromium
 301         actually "work" under CYGWIN instead of forcing users to use
 302         a cmd shell directly.
 303
 304         This is working around a Scons bug:
 305         http://scons.tigris.org/issues/show_bug.cgi?id=2266
 306
 307         * Scripts/webkitdirs.pm:
 308
 309 2008-12-01  David Kilzer  <ddkilzer@apple.com>
 310
 311         Bug 22466: REGRESSION (35867): Many resources missing when saving webarchive of webkit.org
 312
 313         <https://bugs.webkit.org/show_bug.cgi?id=22466>
 314         <rdar://problem/6403593>
 315
 316         Reviewed by Brady Eidson.
 317
 318         * DumpRenderTree/mac/DumpRenderTree.mm:
 319         (normalizeHTTPResponseHeaderFields): Added.  Normalizes Date, Etag,
 320         Keep-Alive, Last-Modified and Server header fields to prevent false
 321         positive test failures.
 322         (convertWebResourceResponseToDictionary): Call
 323         normalizeHTTPResponseHeaderFields() to noramlize HTTP response
 324         header fields.
 325
 326 2008-12-01  David D. Kilzer  <ddkilzer@webkit.org>
 327
 328         Bug 22559: Report builds left to test in bisect-builds (like git-bisect)
 329
 330         <https://bugs.webkit.org/show_bug.cgi?id=22559>
 331
 332         Reviewed by Adam Roben.
 333
 334         * Scripts/bisect-builds: Updated status message to report the
 335         maximum number of builds left to test after the current one.
 336         (max): Added.
 337
 338 2008-11-27  Alp Toker  <alp@nuanti.com>
 339
 340         Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
 341         API header breakage at build time.
 342
 343         * GNUmakefile.am:
 344
 345 2008-11-26  Eric Seidel  <eric@webkit.org>
 346
 347         Reviewed by Nikolas Zimmermann and Mark Rowe.
 348
 349         Add support for build-webkit --chromium
 350         https://bugs.webkit.org/show_bug.cgi?id=22515
 351         More cleanups changing isCygwin calls to isAppleWinWebKit and deploying isAppleWebKit where necessary.
 352
 353         * Scripts/build-dumprendertree:
 354         * Scripts/build-jsc:
 355         * Scripts/build-webkit:
 356         * Scripts/gdb-safari:
 357         * Scripts/run-webkit-tests:
 358         * Scripts/webkitdirs.pm:
 359
 360 2008-11-26  Eric Seidel  <eric@webkit.org>
 361
 362         Reviewed by Nikolas Zimmermann.
 363
 364         Add support for build-webkit --chromium (tested on mac)
 365         https://bugs.webkit.org/show_bug.cgi?id=22515
 366         Also simplified some code using checkArgv
 367
 368         * Scripts/build-webkit:
 369         * Scripts/webkitdirs.pm:
 370
 371 2008-11-26  Eric Seidel  <eric@webkit.org>
 372
 373         Reviewed by Nikolas Zimmermann.
 374
 375         More pre-work for adding a build-webkit --chromium which works on Mac and Windows
 376         https://bugs.webkit.org/show_bug.cgi?id=22515
 377         Change a few calls to isCygwin to isAppleWinWebKit and a few calls to isAppleMacWebKit to isDarwin
 378         in preparation for having a chromium cygwin and chromium mac build
 379
 380         * Scripts/build-webkit:
 381         * Scripts/webkitdirs.pm:
 382
 383 2008-11-26  Eric Seidel  <eric@webkit.org>
 384
 385         Reviewed by Nikolas Zimmermann.
 386
 387         Pre-work for getting build-webkit --chromium to work
 388         https://bugs.webkit.org/show_bug.cgi?id=22515
 389         Rename isOSX to isAppleMacWebKit to match what the code does, and add isChromium()
 390
 391         * Scripts/build-dumprendertree:
 392         * Scripts/build-jsc:
 393         * Scripts/build-webkit:
 394         * Scripts/gdb-safari:
 395         * Scripts/run-javascriptcore-tests:
 396         * Scripts/run-webkit-tests:
 397         * Scripts/webkitdirs.pm:
 398
 399 2008-11-26  David Kilzer  <ddkilzer@apple.com>
 400
 401         Bug 22488: Make DRT smarter about charset encoding when post-processing webarchive content
 402
 403         <https://bugs.webkit.org/show_bug.cgi?id=22488>
 404
 405         Reviewed by Brady Eidson.
 406
 407         * DumpRenderTree/mac/DumpRenderTree.mm:
 408         (convertWebResourceDataToString): If an IANA charset encoding string
 409         is provided, convert it to a CFStringEncoding value and then to an
 410         NSStringEncoding value, else fall back to NSUTF8StringEncoding.  We
 411         also nil-check dataAsString, so the worst-case scenario is that the
 412         data won't be decoded to a string (versus crashing DumpRenderTree).
 413
 414 2008-11-26  Jan Michael Alonzo  <jmalonzo@webkit.org>
 415
 416         Reviewed by Holger Freyther.
 417
 418         [Gtk] add/remove tests from Skipped and fix netscape plugin test
 419         https://bugs.webkit.org/show_bug.cgi?id=22484
 420
 421         Remove print'ing to stderr
 422
 423         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
 424         (NP_Initialize):
 425         (NP_Shutdown):
 426
 427 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
 428
 429         Windows build fix.
 430
 431         * DumpRenderTree/cg/PixelDumpSupportCG.h:
 432
 433 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
 434
 435         Windows build fix.
 436
 437         * DumpRenderTree/cg/ImageDiffCG.cpp:
 438
 439 2008-11-24  Darin Fisher  <darin@chromium.org>
 440
 441         Fix bustage.
 442
 443         https://bugs.webkit.org/show_bug.cgi?id=15643
 444
 445         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 446         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
 447
 448 2008-11-24  Glenn Wilson  <gwilson@chromium.org>
 449
 450         Reviewed by Alexey Proskuryakov.
 451
 452         http://bugs.webkit.org/show_bug.cgi?id=15643
 453
 454         Added support for changing the "trailing whitespace" work-around
 455         in LayoutTestController (so layout tests can verify this functionality)
 456
 457         * DumpRenderTree/LayoutTestController.cpp:
 458         (setSelectTrailingWhitespaceEnabledCallback):
 459         (LayoutTestController::staticFunctions):
 460         * DumpRenderTree/LayoutTestController.h:
 461         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 462         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
 463         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 464         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
 465
 466 2008-11-24  Simon Fraser  <simon.fraser@apple.com>
 467
 468         Reviewed by Darin Adler
 469
 470         https://bugs.webkit.org/show_bug.cgi?id=22433
 471
 472         Add script that attempts to detect virtual methods
 473         whose signatures differ only by constness (which can
 474         indicate a programming error).
 475
 476         * Scripts/detect-mismatched-virtual-const: Added.
 477
 478 2008-11-24  Zan Dobersek  <zandobersek@gmail.com>
 479
 480         Reviewed by Holger Freyther.
 481
 482         https://bugs.webkit.org/show_bug.cgi?id=22039
 483
 484         [Gtk+] Implement TestNetscapePlugin for Gtk+ port and add it to the
 485         build.
 486
 487         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 488         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
 489         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 490         (setDefaultsToConsistentStateValuesForTesting):
 491         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: Added.
 492         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: Added.
 493         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: Added.
 494         * GNUmakefile.am:
 495
 496 2008-11-24  Holger Hans Peter Freyther  <zecke@selfish.org>
 497
 498         Reviewed by Mark Rowe.
 499
 500         [Gtk+] Add configure option to enable Web Workers and enable it by default
 501
 502         Add --enable-workers to the buildsystem (used by build-webkit) add
 503         the to be build files to the GNUmakefile.am and change build-webkit
 504         to enable Web Workers by default.
 505
 506         * Scripts/build-webkit:
 507
 508 2008-11-24  Mark Rowe  <mrowe@apple.com>
 509
 510         Reviewed by Alexey Proskuryakov.
 511
 512         Let gdb-safari accept the --debug and --release options once more.
 513
 514         * Scripts/gdb-safari:
 515
 516 2008-11-23  Zan Dobersek  <zandobersek@gmail.com>
 517
 518         Reviewed by Holger Freyther. Landed by Jan Alonzo.
 519
 520         Get SVG tests tested on GTK port.
 521
 522         * Scripts/webkitdirs.pm:
 523
 524 2008-11-19  Greg Bolsinga  <bolsinga@apple.com>
 525
 526         Reviewed by Darin Adler.
 527
 528         https://bugs.webkit.org/show_bug.cgi?id=21810
 529         Remove use of static C++ objects that are destroyed at exit time (destructors)
 530
 531         All static C++ objects that create atexit calls are gone. Update script
 532         to indicate how to fix the problem should a new one appear.
 533
 534         * Scripts/check-for-exit-time-destructors:
 535
 536 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
 537
 538         Reviewed by Darin Adler.
 539
 540         https://bugs.webkit.org/show_bug.cgi?id=22337
 541         Enable workers by default
 542
 543         * Scripts/build-webkit: Changed the default to enabled.
 544
 545 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
 546
 547         Rubber-stamped by Darin Adler.
 548
 549         https://bugs.webkit.org/show_bug.cgi?id=22306
 550         Disable channel messaging support
 551
 552         * Scripts/build-webkit: Add an option to enable channel messaging.
 553
 554 2008-11-17  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
 555
 556         Reviewed by George Staikos.
 557
 558         Add --(no-)wml build flags.
 559
 560         * Scripts/build-webkit:
 561         * Scripts/run-webkit-tests:
 562         * Scripts/webkitdirs.pm:
 563
 564 2008-11-17  Geoffrey Garen  <ggaren@apple.com>
 565
 566         Not reviewed.
 567
 568         Try to fix gtk build.
 569
 570         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 571         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
 572         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
 573
 574 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
 575
 576         Reviewed by Maciej.
 577
 578         Pixel tests should use a default tolerance of 0.1% on Leopard and 1.0%
 579         on Tiger.
 580
 581         https://bugs.webkit.org/show_bug.cgi?id=22271
 582
 583         * Scripts/run-webkit-tests:
 584
 585 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
 586
 587         Reviewed by Sam Weinig.
 588
 589         Added new JavaScript API on LayoutController to pause a running
 590         CSS transition or animation at a given time.
 591
 592         https://bugs.webkit.org/show_bug.cgi?id=21261
 593
 594         * DumpRenderTree/LayoutTestController.cpp:
 595         (pauseAnimationAtTimeOnElementWithIdCallback):
 596         (pauseTransitionAtTimeOnElementWithIdCallback):
 597         (LayoutTestController::staticFunctions):
 598         * DumpRenderTree/LayoutTestController.h:
 599         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 600         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
 601         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
 602         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 603         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
 604         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
 605
 606 2008-11-17  Gabor Loki  <loki@inf.u-szeged.hu>
 607
 608         Reviewed by Darin Adler.
 609
 610         <https://bugs.webkit.org/show_bug.cgi?id=22309>
 611         Pass the remaining options to build system on Qt-port
 612
 613         * Scripts/build-webkit:
 614         * Scripts/webkitdirs.pm:
 615
 616 2008-11-16  Greg Bolsinga  <bolsinga@apple.com>
 617
 618         Reviewed by Darin Adler.
 619
 620         https://bugs.webkit.org/show_bug.cgi?id=21810
 621         Remove use of static C++ objects that are destroyed at exit time (destructors)
 622
 623         Remove .o files from the exclude list that have had their exit-time destructors removed.
 624         Handle case when there is no current symbol.
 625
 626         * Scripts/check-for-exit-time-destructors:
 627
 628 2008-11-16  Sam Weinig  <sam@webkit.org>
 629
 630         * Scripts/do-webcore-rename: Remove now fixed renames.
 631
 632 2008-11-16  Darin Adler  <darin@apple.com>
 633
 634         * Scripts/do-webcore-rename: Plan some future renames.
 635
 636 2008-11-15  Darin Adler  <darin@apple.com>
 637
 638         Rubber stamped by Geoff Garen.
 639
 640         - do the long-planned StructureID -> Structure rename
 641
 642         * Scripts/check-for-global-initializers: Update name of StructureID.o.
 643         * Scripts/do-webcore-rename: Renaming script that I used.
 644
 645 2008-11-15  Greg Bolsinga  <bolsinga@apple.com>
 646
 647         Reviewed by Darin Adler.
 648
 649         https://bugs.webkit.org/show_bug.cgi?id=21810
 650         Remove use of static C++ objects that are destroyed at exit time (destructors)
 651
 652         Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
 653         exit-time destructor. Update code that was changed to fix this issue that ran
 654         into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
 655         in gcc build 5465). Also typdefs for template types needed to be added in some
 656         cases so the type could make it through the macro successfully.
 657
 658         Basically code of the form:
 659         static T m;
 660         becomes:
 661         DEFINE_STATIC_LOCAL(T, m, ());
 662
 663         Also any code of the form:
 664         static T& m = *new T;
 665         also becomes:
 666         DEFINE_STATIC_LOCAL(T, m, ());
 667
 668         Remove .o files from the exclude list that have had their exit-time destructors removed.
 669
 670         * Scripts/check-for-exit-time-destructors:
 671
 672 2008-11-14  Kevin Ollivier  <kevino@theolliviers.com>
 673
 674         wx mac buildbot fix. Also, make sure we don't keep hitting this problem.
 675
 676         * wx/install-unix-extras:
 677
 678 2008-11-14  Alp Toker  <alp@nuanti.com>
 679
 680         GTK DRT build fix for gcc 4.4 snapshot. Add missing stdio include.
 681
 682         Fixes Debian bug #505723
 683         http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505723
 684
 685         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 686
 687 2008-11-14  Krishna <krishnamurty.podipireddy@nokia.com>
 688
 689         Reviewed by Simon Hausmann.
 690
 691         Fix hanging DRT with Qt.
 692
 693         https://bugs.webkit.org/show_bug.cgi?id=22209
 694
 695         * DumpRenderTree/qt/DumpRenderTree.cpp:
 696         (WebCore::DumpRenderTree::dump):
 697         Send empty pixel test data 'block', which is now
 698         expected by run-layout-tests.
 699
 700 2008-11-12  Dmitry Titov  <dimich@chromium.org>
 701
 702         Reviewed by Alexey Proskuryakov.
 703
 704         https://bugs.webkit.org/show_bug.cgi?id=22216
 705
 706         * Scripts/build-webkit:
 707         Addes ENABLE_WORKERS to build-webkit so it's possible to build with workers enabled.
 708
 709 2008-11-06  David Kilzer  <ddkilzer@apple.com>
 710
 711         BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
 712
 713         Apparently older versions of gcc have issues with this patch.
 714         Backing out a second time until the issues are resolved.
 715
 716 2008-11-06  David Kilzer  <ddkilzer@apple.com>
 717
 718         BUILD WAS NOT BROKEN: Rolling r38189 back in.
 719
 720         Please perform a clean build if you see crashes.
 721
 722 2008-11-06  David Kilzer  <ddkilzer@apple.com>
 723
 724         BUILD FIX: Backed out r38189 since it apparently broke the world.
 725
 726 2008-11-06  Chris Fleizach  <cfleizach@apple.com>
 727
 728         Reviewed by Beth Dakin.
 729
 730         Add ability to query an attribute's settable status and the
 731         ability to retrieve a single attribute from an AXObject
 732
 733         * DumpRenderTree/AccessibilityUIElement.cpp:
 734         (isAttributeSettableCallback):
 735         (attributeValueCallback):
 736         (AccessibilityUIElement::getJSClass):
 737         * DumpRenderTree/AccessibilityUIElement.h:
 738         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 739         (+[NSString stringWithJSStringRef:]):
 740         (AccessibilityUIElement::attributeValue):
 741         (AccessibilityUIElement::isAttributeSettable):
 742         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 743         (AccessibilityUIElement::attributeValue):
 744         (AccessibilityUIElement::isAttributeSettable):
 745
 746 2008-11-06  Greg Bolsinga  <bolsinga@apple.com>
 747
 748         Reviewed by Darin Adler.
 749
 750         Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
 751         https://bugs.webkit.org/show_bug.cgi?id=21810
 752
 753         Remove .o files from the exclude list that have had their exit-time destructors removed.
 754
 755         * Scripts/check-for-exit-time-destructors:
 756
 757 2008-11-05  Alp Toker  <alp@nuanti.com>
 758
 759         GTK build script tweak.
 760
 761         Make the path relative since it will appear in all -I compiler flags.
 762         Long argument lists cause bizarre slowdowns in libtool and result
 763         in huge build logs.
 764
 765         * Scripts/webkitdirs.pm:
 766
 767 2008-11-05  Anders Carlsson  <andersca@apple.com>
 768
 769         Fix 64-bit build.
 770
 771         * DumpRenderTree/mac/DumpRenderTree.mm:
 772         (setDefaultsToConsistentValuesForTesting):
 773
 774 2008-11-04  Simon Fraser  <simon.fraser@apple.com>
 775
 776         Add AccessibilityObject.o to the exclude list for the
 777         check for global destructors.
 778
 779         * Scripts/check-for-exit-time-destructors:
 780
 781 2008-11-04  Darin Adler  <darin@apple.com>
 782
 783         * Scripts/check-for-exit-time-destructors: Fix failures seen on the
 784         bot, but for some reason not on my computer.
 785
 786 2008-11-03  Darin Adler  <darin@apple.com>
 787
 788         Reviewed by Tim Hatcher.
 789
 790         - https://bugs.webkit.org/show_bug.cgi?id=22061
 791           create script to check for exit-time destructors
 792
 793         * Scripts/check-for-exit-time-destructors: Added.
 794         Started as a copy of check-for-global-initializers.
 795
 796         * Scripts/check-for-global-initializers: Added code to make
 797         this script rerun any time it's modified, and also to properly
 798         run again after the first time it reports an error.
 799
 800 2008-11-03  Pierre-Olivier Latour  <pol@apple.com>
 801
 802         Reviewed by Dan Bernstein.
 803
 804         Fixed the override of the "AppleScrollBarVariant" system setting to also work with HIToolbox.
 805
 806         https://bugs.webkit.org/show_bug.cgi?id=22054
 807
 808         * DumpRenderTree/mac/DumpRenderTree.mm:
 809         (setDefaultsToConsistentValuesForTesting):
 810
 811 2008-10-31  Cameron Zwarich  <zwarich@apple.com>
 812
 813         Not reviewed.
 814
 815         * Scripts/do-webcore-rename:
 816
 817         Add some renames to contemplate for the future.
 818
 819 2008-10-31  Darin Adler  <darin@apple.com>
 820
 821         Requested by Mark Rowe.
 822
 823         * Scripts/check-for-global-initializers: s/Web Kit/WebKit/.
 824
 825 2008-10-31  David Kilzer  <ddkilzer@apple.com>
 826
 827         Bug 21997: prepare-ChangeLog should filter out ChangeLog files
 828
 829         <https://bugs.webkit.org/show_bug.cgi?id=21997>
 830
 831         Reviewed by Darin Adler.
 832
 833         * Scripts/prepare-ChangeLog:
 834         (generateFileList): Don't add ChangeLog files to %{$functionLists}.
 835         This prevents them from showing up in the new ChangeLog entry.  They
 836         were already excluded from @{$changedFiles}.
 837
 838 2008-10-30  Mark Rowe  <mrowe@apple.com>
 839
 840         Reviewed by Jon Homeycutt.
 841
 842         Explicitly default to building for only the native architecture in debug and release builds.
 843
 844         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
 845
 846 2008-10-30  Pierre-Olivier Latour  <pol@apple.com>
 847
 848         Reviewed by Dan Bernstein.
 849
 850         Fixed 64 bit build failure.
 851
 852         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
 853         (setupMainDisplayColorProfile):
 854         (createBitmapContextFromWebView):
 855
 856 2008-10-28  Alp Toker  <alp@nuanti.com>
 857
 858         Fix GTK DRT following build breakage in r37928.
 859
 860         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 861         (dump):
 862         (runTest):
 863         (main):
 864
 865 2008-10-28  Alp Toker  <alp@nuanti.com>
 866
 867         Reviewed by Mark Rowe.
 868
 869         Fix recently introduced double-free crashes in GTK DRT.
 870
 871         LayoutTestController was made ref-counted in r36606 and Mac/Win DRT
 872         were updated to call ->deref() but GTK DRT was still deleting
 873         gLayoutTestController manually. This patch updates GTK to match the
 874         other ports and resolves the memory allocation issues.
 875
 876         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 877         (runTest):
 878
 879 2008-10-28  Alp Toker  <alp@nuanti.com>
 880
 881         Reviewed by Mark Rowe.
 882
 883         Fix GTK DRT hang when running the tests.
 884
 885         Update output from the DRT tool to print an additional '#EOF' to match
 886         breaking changes that were made in r37434.
 887
 888         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 889         (dump):
 890
 891 2008-10-28  Adele Peterson  <adele@apple.com>
 892
 893         Reviewed by Sam Weinig.
 894
 895         Specify which Localizable.strings to update since we don't always want to update the file in the same
 896         directory where we're searching for the strings to localize.
 897
 898         * Scripts/extract-localizable-strings:
 899         * Scripts/update-webkit-localizable-strings:
 900
 901 2008-10-28  Timothy Hatcher  <timothy@apple.com>
 902
 903         Add support for enabling the profiler, so the profiling tests can continue
 904         work now that the profiler is not always enabled.
 905
 906         https://bugs.webkit.org/show_bug.cgi?id=21927
 907
 908         <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
 909         not slow down JavaScript all the time
 910
 911         Reviewed by Darin Adler and Kevin McCullough.
 912
 913         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
 914         * DumpRenderTree/LayoutTestController.cpp:
 915         (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled.
 916         (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
 917         * DumpRenderTree/LayoutTestController.h:
 918         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 919         (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
 920         * DumpRenderTree/mac/DumpRenderTree.mm:
 921         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
 922         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 923         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
 924         * DumpRenderTree/win/DumpRenderTree.cpp:
 925         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
 926         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 927         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
 928
 929 2008-10-28  Pierre-Olivier Latour  <pol@apple.com>
 930
 931         Reviewed by Dan Bernstein
 932
 933         Primary changes in DumpRenderTree:
 934         - Ensure font smoothing is disabled (this is also called LCD anti-aliasing and
 935         is different from regular font CG anti-aliasing) as font-smoothing settings
 936         depends on the display and can also be changed by the user
 937         - Use a new cleared buffer for each test instead of the reusing same one to
 938         avoid potential result corruption across tests
 939         - Can now receive the expected pixel hash as a suffix to the test path or
 940         url as "path'hash"
 941         - Make sure hash is computed in a endian-independent way
 942         - Improve the code that sets/restores the screen color profile
 943         - Make the code more cross-platformy with std::string goodness
 944         - Added an "on-screen" mode where the snapshot will take into account surfaces
 945         on the window (like OpenGL content): this uses the new CG APIs on 10.5 or
 946         reading from the display framebuffer on 10.4. This mode is not active by
 947         default for performance reason, but must be explicitly activated from the test
 948         file using the new "testOnscreen()" JS API.
 949
 950         Primary changes in ImageDiff:
 951         - Provide a new comparison algorithm that is more tolerant to "acceptable"
 952         failures (i.e. very small differences in font rendering, which --threshold is
 953         not really good at handling)
 954         - Generate normalized intensity-only diff images
 955
 956         Primary changes in run-webkit-tests:
 957         - Take advantage of hashes for pixel tests which makes them much faster by
 958         minimizing image comparisons
 959         - Removed repaint options as these should be set from within test files using
 960         JS API
 961         - Replaced "threshold" option in  by "tolerance" expressed in percents
 962         - Added more logging when in "verbose" mode
 963
 964         https://bugs.webkit.org/show_bug.cgi?id=21322
 965         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 966         * DumpRenderTree/ForwardingHeaders/wtf/PassRefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/PassRefPtr.h.
 967         * DumpRenderTree/ForwardingHeaders/wtf/RefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefPtr.h.
 968         * DumpRenderTree/LayoutTestController.cpp:
 969         (LayoutTestController::LayoutTestController):
 970         (testOnscreenCallback):
 971         (LayoutTestController::staticFunctions):
 972         * DumpRenderTree/LayoutTestController.h:
 973         (LayoutTestController::testOnscreen):
 974         (LayoutTestController::setTestOnscreen):
 975         (LayoutTestController::testPathOrURL):
 976         (LayoutTestController::expectedPixelHash):
 977         * DumpRenderTree/PixelDumpSupport.h:
 978         * DumpRenderTree/cg/ImageDiffCG.cpp:
 979         (strtof):
 980         (releaseMallocBuffer):
 981         (createDifferenceImage):
 982         (imageHasAlpha):
 983         (main):
 984         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 985         (computeMD5HashStringForBitmapContext):
 986         (dumpWebViewAsPixelsAndCompareWithExpected):
 987         * DumpRenderTree/cg/PixelDumpSupportCG.h:
 988         (BitmapContext::createByAdoptingBitmapAndContext):
 989         (BitmapContext::~BitmapContext):
 990         (BitmapContext::cgContext):
 991         (BitmapContext::BitmapContext):
 992         * DumpRenderTree/mac/DumpRenderTree.mm:
 993         (shouldIgnoreWebCoreNodeLeaks):
 994         (setDefaultsToConsistentValuesForTesting):
 995         (crashHandler):
 996         (initializeGlobalsFromCommandLineOptions):
 997         (prepareConsistentTestingEnvironment):
 998         (dumpRenderTree):
 999         (sizeWebViewForCurrentTest):
1000         (dump):
1001         (runTest):
1002         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1003         (restoreMainDisplayColorProfile):
1004         (setupMainDisplayColorProfile):
1005         (createBitmapContextFromWebView):
1006         * DumpRenderTree/win/DumpRenderTree.cpp:
1007         (dump):
1008         (runTest):
1009         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1010         (getBitmapContextFromWebView):
1011         * Scripts/run-webkit-tests:
1012
1013 2008-10-27  Kevin Ollivier  <kevino@theolliviers.com>
1014
1015         wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.
1016
1017         * wx/build-wxwebkit:
1018
1019 2008-10-24  Anders Carlsson  <andersca@apple.com>
1020
1021         Try fixing the 64-bit build.
1022
1023         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
1024         (testGetProperty):
1025
1026 2008-10-24  Anders Carlsson  <andersca@apple.com>
1027
1028         Reviewed by Sam Weinig.
1029
1030         <rdar://problem/5440917> Support NPN_Construct
1031
1032         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1033         (testCallback):
1034         Fix a memory leak.
1035
1036         (testConstruct):
1037         New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.
1038
1039         (pluginInvoke):
1040         Handle testConstruct.
1041
1042         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
1043         (testGetProperty):
1044         Add objectPointer property.
1045
1046         (testEnumerate):
1047         Only enumerate the two first properties.
1048
1049         (testConstruct):
1050         Add a simple construct implementation that just returns the test object.
1051
1052 2008-10-24  David Kilzer  <ddkilzer@apple.com>
1053
1054         Bug 21850: svn-apply and svn-unapply should preserve patch line endings
1055
1056         <https://bugs.webkit.org/show_bug.cgi?id=21850>
1057
1058         Reviewed by Adam Roben.
1059
1060         * Scripts/svn-apply: Save end-of-line characters when stripping them
1061         off each line of a patch so that they may be restored after
1062         processing the line.
1063         * Scripts/svn-unapply: Ditto.
1064
1065 2008-10-23  David Kilzer  <ddkilzer@apple.com>
1066
1067         Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10
1068
1069         <https://bugs.webkit.org/show_bug.cgi?id=21832>
1070
1071         Reviewed by Sam Weinig.
1072
1073         * Scripts/bisect-builds: Use imported tempfile() from File::Temp
1074         instead of 'new File::Temp' to make the script work with Perl 5.10.
1075         * Scripts/sort-Xcode-project-file: Ditto.
1076
1077 2008-10-22  Brady Eidson  <beidson@apple.com>
1078
1079         Reviewed by Adam Roben
1080
1081         <rdar://6261773> - autocomplete="off" doesn't work on Windows
1082
1083         Implement LayoutTestController::elementDoesAutoCompleteForElementWithId() on Windows
1084
1085         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1086
1087 2008-10-22  Darin Adler  <darin@apple.com>
1088
1089         * Scripts/do-webcore-rename: More renaming plans.
1090
1091 2008-10-21  Steve Falkenburg  <sfalken@apple.com>
1092
1093         Exclude strings marked with UNLOCALIZED_STRING or UNLOCALIZED_LPCTSTR.
1094
1095         * Scripts/extract-localizable-strings:
1096
1097 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
1098
1099         Reviewed by Mark Rowe.
1100
1101         - default to 1000 tests per dump tool instance again, now that CTI no longer causes
1102         excess different stack logs.
1103
1104         (Also fix a small bug in my last change.)
1105
1106         * Scripts/run-webkit-tests:
1107
1108 2008-10-17  Stephanie Lewis  <slewis@apple.com>
1109
1110         Reviewed by Mark Rowe.
1111
1112         Fix layout tests that use prologues and epilogues.
1113
1114         * Scripts/run-webkit-tests:
1115
1116 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
1117
1118         Reviewed by Mark Rowe.
1119
1120         - make sure MallocStackLogging is only on for tools we want to
1121         leak check, not other random stuff as well.
1122
1123         * Scripts/run-webkit-tests:
1124
1125 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
1126
1127         Reviewed by Stephanie Lewis.
1128
1129         - make run-webkit-tests --leaks default to 100 tests per run instead of 1000
1130
1131         This should reduce or eliminate crashes on the buildbot due to
1132         running out of memory while stack logging.
1133
1134         * Scripts/run-webkit-tests:
1135
1136 2008-10-16  Jan Michael Alonzo  <jmalonzo@webkit.org>
1137
1138         Gtk build fix. Not reviewed.
1139
1140         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1141         (LayoutTestController::setSmartInsertDeleteEnabled):
1142
1143 2008-10-15  Glenn Wilson  <gwilson@google.com>
1144
1145         Added new method to allow tests to disable smart editing in the course of a test.
1146         This is a possible solution to bug .20655
1147
1148         Reviewed by Tim Hatcher.
1149
1150         * DumpRenderTree/LayoutTestController.cpp:
1151         (setSmartInsertDeleteEnabledCallback): new method
1152         (LayoutTestController::staticFunctions): added new method to static list of callbacks
1153         * DumpRenderTree/LayoutTestController.h: added signature of new method
1154         * DumpRenderTree/mac/DumpRenderTree.mm:
1155         (resetWebViewToConsistentStateBeforeTesting): added state resetting
1156         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1157         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
1158         * DumpRenderTree/win/DumpRenderTree.cpp:
1159         (resetWebViewToConsistentStateBeforeTesting): added state resetting
1160         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1161         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
1162
1163 2008-10-14  Ada Chan  <adachan@apple.com>
1164
1165         Fix windows build.
1166
1167         Reviewed by Sam Weinig.
1168
1169         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1170         * DumpRenderTree/config.h:
1171         * DumpRenderTree/win/DumpRenderTreeWin.h:
1172         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1173         * DumpRenderTree/win/UIDelegate.cpp:
1174
1175 2008-10-13  Timothy Hatcher  <timothy@apple.com>
1176
1177         Make prepare-ChangeLog populate the changed functions for JavaScript files.
1178
1179         https://bugs.webkit.org/show_bug.cgi?id=21567
1180
1181         Reviewed by David Kilzer.
1182
1183         * Scripts/prepare-ChangeLog:
1184         (get_function_line_ranges): Call get_function_line_ranges_for_javascript for
1185         files that end with ".js".
1186         (get_function_line_ranges_for_javascript): Find functions, anonymous functions
1187         and getters/setters.
1188
1189 2008-10-14  Alp Toker  <alp@nuanti.com>
1190
1191         Reviewed by Sam Weinig.
1192
1193         https://bugs.webkit.org/show_bug.cgi?id=16299
1194         Add a config.h file to DRT
1195
1196         Add a config.h to DumpRenderTree and reduce use of DumpRenderTree.h as
1197         an ad-hoc config header.
1198
1199         * DumpRenderTree/AccessibilityController.cpp:
1200         * DumpRenderTree/AccessibilityUIElement.cpp:
1201         * DumpRenderTree/AccessibilityUIElement.h:
1202         * DumpRenderTree/DumpRenderTree.h:
1203         * DumpRenderTree/GCController.cpp:
1204         * DumpRenderTree/LayoutTestController.cpp:
1205         * DumpRenderTree/WorkQueue.cpp:
1206         * DumpRenderTree/config.h: Added.
1207         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1208         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1209         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1210         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1211         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1212         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1213         * DumpRenderTree/win/DumpRenderTree.cpp:
1214         * DumpRenderTree/win/DumpRenderTreeWin.h:
1215         * DumpRenderTree/win/EditingDelegate.cpp:
1216         * DumpRenderTree/win/EventSender.cpp:
1217         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1218         * DumpRenderTree/win/GCControllerWin.cpp:
1219         * DumpRenderTree/win/MD5.cpp:
1220         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1221         * DumpRenderTree/win/PolicyDelegate.cpp:
1222         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1223         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1224         * GNUmakefile.am:
1225
1226 2008-10-13  Chris Fleizach  <cfleizach@apple.com>
1227
1228         Reviewed by Beth Dakin.
1229
1230         Added a method to get the links in a webpage
1231
1232         * DumpRenderTree/AccessibilityUIElement.cpp:
1233         (attributesOfDocumentLinksCallback):
1234         (AccessibilityUIElement::getJSClass):
1235         * DumpRenderTree/AccessibilityUIElement.h:
1236         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1237         (AccessibilityUIElement::getDocumentLinks):
1238         (AccessibilityUIElement::attributesOfDocumentLinks):
1239         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1240         (AccessibilityUIElement::getDocumentLinks):
1241         (AccessibilityUIElement::attributesOfDocumentLinks):
1242
1243 2008-10-13  David Kilzer  <ddkilzer@apple.com>
1244
1245         Bug 21457: resolve-ChangeLogs should be able to operate on a git revision range
1246
1247         <https://bugs.webkit.org/show_bug.cgi?id=21457>
1248
1249         Reviewed by Adam.
1250
1251         * Scripts/resolve-ChangeLogs: Added optional parameter to
1252         -f|--fix-merged switch to run the script on a revision range.
1253         Updated command-line validation checks.
1254         (findChangeLog): Fixed long-standing bug that should have used
1255         $_[0] instead of $_.
1256         (fixMergedChangeLog): Renamed to fixOneMergedChangeLog($).  Updated
1257         to work when called from git filter-branch.  It always restores a
1258         copy of the previous revision before reapplying the patch.
1259         (fixMergedChangeLogs): Added.  Calls itself through git filter-branch
1260         to re-merge ChangeLog files across a revision range.  Removes
1261         .git/refs/original directory on success.
1262         (parseFixMerged): Added.  Custom method to parse the -f|--fix-merged
1263         switch.
1264         (removeChangeLogArguments): Added.  Removes items from @ARGV when
1265         they are ChangeLog paths, and return a list of paths.  This makes it
1266         easier to validate the command-line.
1267         (resolveChangeLog): Added.  Extracted from main code block.  Runs
1268         the traditional single-file merge algorithm.
1269         (usageAndExit): Added.  Extracted from main code block.  Prints
1270         usage statement and exits with error status.
1271
1272 2008-10-12  Darin Adler  <darin@apple.com>
1273
1274         * Scripts/make-js-test-wrappers: Update exceptions list so the script
1275         won't overwrite files and mangle tests.
1276
1277 2008-10-11  Dan Bernstein  <mitz@apple.com>
1278
1279         Reviewed by Sam Weinig and Anders Carlsson.
1280
1281         - update Mac DumpRenderTree to use the new WebView SPI for forcing the
1282           complex text code path
1283         - add --complex-text support to Windows DumpRenderTree
1284
1285         * DumpRenderTree/mac/DumpRenderTree.mm:
1286         (dumpRenderTree):
1287         * DumpRenderTree/win/DumpRenderTree.cpp:
1288         (createWebViewAndOffscreenWindow):
1289         (main):
1290         * Scripts/run-webkit-tests:
1291
1292 2008-10-09  Eric Seidel  <eric@webkit.org>
1293
1294         Reviewed by Oliver Hunt.
1295
1296         https://bugs.webkit.org/show_bug.cgi?id=21498
1297
1298         * Scripts/make-js-test-wrappers: ignore resources/shadow-offset.js
1299
1300 2008-10-09  Cameron Zwarich  <zwarich@apple.com>
1301
1302         Not reviewed.
1303
1304         Add StructureID.o to the exclusion list in the global initializers
1305         script to fix the Debug build.
1306
1307         * Scripts/check-for-global-initializers:
1308
1309 2008-10-08  Mark Rowe  <mrowe@apple.com>
1310
1311         Fix the Windows build after r37434.
1312
1313         * DumpRenderTree/win/DumpRenderTree.cpp:
1314         (dump): Update code to approximate valid C++ syntax.
1315
1316 2008-10-08  Timothy Hatcher  <timothy@apple.com>
1317
1318         Add SVGElementInstance to the list of exceptions that have
1319         global initializers in debug builds.
1320
1321         Rubber-stamped by Mark Rowe.
1322
1323         * Scripts/check-for-global-initializers: Add SVGElementInstance.o.
1324
1325 2008-10-08  Simon Fraser  <simon.fraser@apple.com>
1326
1327         Reviewed by Dan Bernstein
1328
1329         Avoid disconnect between DRT and run-webkit-tests
1330         about whether to expect PNG dumps by having DRT always
1331         print two blocks terminated by #EOF, the second of which
1332         may be empty.
1333
1334         https://bugs.webkit.org/show_bug.cgi?id=21483
1335
1336         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1337         (printPNG):
1338         (dumpWebViewAsPixelsAndCompareWithExpected):
1339         * DumpRenderTree/mac/DumpRenderTree.mm:
1340         (dump):
1341         * DumpRenderTree/win/DumpRenderTree.cpp:
1342         (dump):
1343         * Scripts/run-webkit-tests:
1344
1345 2008-10-07  Adam Roben  <aroben@apple.com>
1346
1347         Make sure short functions get included in ChangeLog output for git
1348         repositories
1349
1350         Reviewed by Dave Kilzer.
1351
1352         * Scripts/prepare-ChangeLog:
1353         (sub diffCommand): Pass -U0 to git diff so that each contiguous change
1354         will get its own chunk without any surrounding context.
1355         (sub extractLineRange): Use the line numbers from the chunk header
1356         without modifying them now that they're accurate.
1357
1358 2008-10-04  Mark Rowe  <mrowe@apple.com>
1359
1360         Reviewed by Tim Hatcher.
1361
1362         Update check-for-weak-vtables to check only the final linked image for weak vtables.
1363         This gives more useful results than checking each object file independently.
1364
1365         * Scripts/check-for-weak-vtables:
1366
1367 2008-10-03  Pierre-Olivier Latour <pol@apple.com>
1368
1369         Reviewed by Darin Adler
1370
1371         Render images to RGBA8 bitmaps independently of platform endianness.
1372
1373         Create image difference bitmap in reference image colorspace instead of device colorspace
1374         (which depends on the main display profile), so that no color matching happens.
1375
1376         https://bugs.webkit.org/show_bug.cgi?id=21336
1377
1378         * DumpRenderTree/cg/ImageDiffCG.cpp:
1379         (createDifferenceBitmap):
1380         (computePercentageDifferent):
1381         (compareImages):
1382
1383 2008-10-02  Simon Fraser  <simon.fraser@apple.com>
1384
1385         Reviewed by Darin Adler
1386
1387         Fix hang when running with --pixel --reset, which occurs
1388         because DRT spews PNG data when the script does not expect it.
1389
1390         https://bugs.webkit.org/show_bug.cgi?id=21323
1391
1392         * Scripts/run-webkit-tests:
1393
1394 2008-09-30  Mark Rowe  <mrowe@apple.com>
1395
1396         Reviewed by Dan Bernstein.
1397
1398         Add a leak counter for CachedResources since we've had two recent leaks involving them.
1399
1400         * Scripts/check-for-global-initializers:
1401
1402 2008-09-30  Mark Rowe  <mrowe@apple.com>
1403
1404         Rubber-stamped by Dan Bernstein.
1405
1406         Fix many leaks seen on fast/backgrounds/svg-as-background-1.html.
1407
1408         JavaScript wrappers were keeping DOM objects alive, which was leading to the SVG background image
1409         being kept alive in the memory cache past our last attempt to empty the cache prior to quitting.
1410         We need to empty the memory cache after forcing a JavaScript garbage collection to ensure that
1411         any live JavaScript wrappers are collected and their corresponding DOM objects have a chance to be
1412         torn down before we exit.
1413
1414         * DumpRenderTree/mac/DumpRenderTree.mm:
1415         (dumpRenderTree):
1416         (main):
1417
1418 2008-09-30  Simon Fraser  <simon.fraser@apple.com>
1419
1420         Reviewed by Dan Bernstein
1421
1422         Don't run pixel comparison for text-only tests.
1423         https://bugs.webkit.org/show_bug.cgi?id=21124
1424
1425         * DumpRenderTree/mac/DumpRenderTree.mm:
1426         (dump):
1427         * Scripts/run-webkit-tests:
1428
1429 2008-09-29  Thiago Macieira  <thiago.macieira@nokia.com>
1430
1431         Reviewed by Simon.
1432
1433         Changed copyright from Trolltech ASA to Nokia.
1434
1435         Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
1436
1437
1438         * DumpRenderTree/qt/DumpRenderTree.cpp:
1439         * DumpRenderTree/qt/jsobjects.cpp:
1440         * DumpRenderTree/qt/jsobjects.h:
1441         * DumpRenderTree/qt/main.cpp:
1442         * DumpRenderTree/qt/testplugin.cpp:
1443         * DumpRenderTree/qt/testplugin.h:
1444
1445 2008-09-28  David Kilzer  <ddkilzer@apple.com>
1446
1447         Bug 21185: resolve-ChangeLogs should be able to fix poorly merged ChangeLog entries after a git svn rebase
1448
1449         <https://bugs.webkit.org/show_bug.cgi?id=21185>
1450
1451         Reviewed by Adam.
1452
1453         * Scripts/resolve-ChangeLogs: Added new -f|--fix-merge switch that
1454         will attempt to reapply the last commit to a ChangeLog file such
1455         that the ChangeLog entry appears at the top of the file.
1456         (findChangeLog): Added prototype and moved method below the exit
1457         statement.
1458         (fixMergedChangeLog): Added.  Method to fix incorrectly merged
1459         ChangeLog entries.
1460
1461 2008-09-27  Anders Carlsson  <andersca@apple.com>
1462
1463         Reviewed by Sam Weinig.
1464
1465         https://bugs.webkit.org/show_bug.cgi?id=21178
1466         <rdar://problem/6248651>
1467
1468         Return the result value from getURL.
1469
1470         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1471         (getURL):
1472
1473 2008-09-26  Matt Lilek  <webkit@mattlilek.com>
1474
1475         Reviewed by Tim Hatcher.
1476
1477         Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.
1478
1479         * Scripts/build-webkit:
1480
1481 2008-09-26  Alice Liu  <alice.liu@apple.com>
1482
1483         Remove usage of atlstr.h and CString for VCExpress compatibility
1484
1485         Reviewed by Stephanie Lewis.
1486
1487         * record-memory-win/main.cpp:
1488         (ProcessArgs):
1489         (UseImage):
1490         (QueryContinuously):
1491         (OneQuery):
1492         (OneQueryMP):
1493
1494 2008-09-26  Kevin Ollivier  <kevino@theolliviers.com>
1495
1496         wx build fix. Update the version of libpng.
1497
1498         * wx/install-unix-extras:
1499
1500 2008-09-24  Sam Weinig  <sam@webkit.org>
1501
1502         Reviewed by Darin Adler.
1503
1504         Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
1505         <rdar://problem/6243534>
1506         Crash below Function.apply when using a runtime array as the argument list
1507
1508         Add method to ObjCController to return a runtime array.
1509
1510         * DumpRenderTree/mac/ObjCController.m:
1511         (+[ObjCController isSelectorExcludedFromWebScript:]):
1512         (+[ObjCController webScriptNameForSelector:]):
1513         (-[ObjCController testArray]):
1514
1515 2008-09-24  Beth Dakin  <bdakin@apple.com>
1516
1517         Reviewed by Sam Weinig.
1518
1519         Speculative build fix.
1520
1521         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1522         (AccessibilityUIElement::supportsPressAction):
1523
1524 2008-09-23  Beth Dakin  <bdakin@apple.com>
1525
1526         Reviewed by Sam Weinig.
1527
1528         This patch extends DumpRenderTree's AccessibilityController to ask
1529         if the focused element supports the press action.
1530
1531         * DumpRenderTree/AccessibilityUIElement.cpp:
1532         (getSupportsPressActionCallback):
1533         (AccessibilityUIElement::getJSClass):
1534         * DumpRenderTree/AccessibilityUIElement.h:
1535         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1536         (AccessibilityUIElement::supportsPressAction):
1537
1538 2008-09-22  Alice Liu  <alice.liu@apple.com>
1539
1540         Adding a stand-alone Windows console application to record a process's memory usage
1541
1542         Reviewed by Steve Falkenburg.
1543
1544         * record-memory-win: Added.
1545         * record-memory-win/main.cpp: Added.
1546         * record-memory-win/record-memory-win.vcproj: Added.
1547
1548 2008-09-22  Chris Fleizach  <cfleizach@apple.com>
1549
1550         Reviewed by Darin Adler.
1551
1552         Support ability to get/set selected text ranges for text controls through AX.
1553
1554         * DumpRenderTree/AccessibilityUIElement.cpp:
1555         (setSelectedTextRangeCallback):
1556         (getSelectedTextRangeCallback):
1557         (AccessibilityUIElement::getJSClass):
1558         * DumpRenderTree/AccessibilityUIElement.h:
1559         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1560         (AccessibilityUIElement::attributesOfRowHeaders):
1561         (AccessibilityUIElement::attributesOfVisibleCells):
1562         (AccessibilityUIElement::rowIndexRange):
1563         (AccessibilityUIElement::columnIndexRange):
1564         (AccessibilityUIElement::cellForColumnAndRow):
1565         (AccessibilityUIElement::selectedTextRange):
1566         (AccessibilityUIElement::setSelectedTextRange):
1567         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1568         (AccessibilityUIElement::selectedTextRange):
1569         (AccessibilityUIElement::setSelectedTextRange):
1570
1571 2008-09-20  Darin Adler  <darin@apple.com>
1572
1573         * DumpRenderTree/mac/DumpRenderTree.mm:
1574         (convertMIMEType): Turn on Stephanie's workaround for Tiger too.
1575
1576 2008-09-19  Alp Toker  <alp@nuanti.com>
1577
1578         Build fix for the 'gold' linker and recent binutils. New behaviour
1579         requires that we link to used libraries explicitly.
1580
1581         * GNUmakefile.am:
1582
1583 2008-09-19  Stephanie Lewis  <slewis@apple.com>
1584
1585         Reviewed by Oliver Hunt.
1586
1587         Implement a workaround for an incorrect mime-type on machines with
1588         Dashcode 2.0.1.  Dashcode is overriding the UTI type for .js files.
1589         See radar <rdar://problem/6234318>.
1590
1591         * DumpRenderTree/mac/DumpRenderTree.mm:
1592         (convertMIMEType):
1593
1594 2008-09-19  Chris Fleizach  <cfleizach@apple.com>
1595
1596         Fixed Windows bustage
1597
1598         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1599         (AccessibilityUIElement::titleUIElement):
1600
1601 2008-09-18  Chris Fleizach  <cfleizach@apple.com>
1602
1603         Reviewed by Darin Adler.
1604
1605         Expose titleUIElement call for DumpRenderTree
1606
1607         * ChangeLog:
1608         * DumpRenderTree/AccessibilityUIElement.cpp:
1609         (titleUIElementCallback):
1610         (AccessibilityUIElement::getJSClass):
1611         * DumpRenderTree/AccessibilityUIElement.h:
1612         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1613         (AccessibilityUIElement::titleUIElement):
1614
1615 2008-09-18  Darin Adler  <darin@apple.com>
1616
1617         * Scripts/do-webcore-rename: More renaming plans.
1618
1619 2008-09-18  Mark Rowe  <mrowe@apple.com>
1620
1621         Reviewed by Dan Bernstein.
1622
1623         Clear the main frame's name between tests to get more consistent test results
1624         when running the WebKit tests with --nthly.
1625
1626         * DumpRenderTree/mac/DumpRenderTree.mm:
1627         (resetWebViewToConsistentStateBeforeTesting):
1628         * DumpRenderTree/win/DumpRenderTree.cpp:
1629         (resetWebViewToConsistentStateBeforeTesting):
1630
1631 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1632
1633         Really fix tiger jsc tests.
1634
1635         * Scripts/run-javascriptcore-tests:
1636
1637 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1638
1639         Reviewed by Maciej Stachowiak.
1640
1641         Fix jsc tests on Tiger.  Make jsc tests smarter about when to use the arch flag.
1642
1643         * Scripts/run-javascriptcore-tests:
1644         * Scripts/webkitdirs.pm:
1645
1646 2008-09-18  Mark Rowe  <mrowe@apple.com>
1647
1648         Rubber-stamped by Sam Weinig.
1649
1650         Print warning to stdout rather than stderr when a test attempts to access a remote resource.
1651         This should make it more obvious when a test does this, as stderr output tends to be obscured
1652         by noise in the test results.
1653
1654         Also fixes some coding style issues in ResourceLoadDelegate.mm.
1655
1656         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1657         (-[NSError _drt_descriptionSuitableForTestResult]):
1658         (-[NSURL _drt_descriptionSuitableForTestResult]):
1659         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1660         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1661         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1662         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1663         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1664         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1665
1666 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1667
1668         Reviewed by Mark Rowe and Maciej Stachowiak..
1669
1670         add a --64-bit option and specify which architecture to run on Mac.
1671
1672         * Scripts/run-javascriptcore-tests:
1673
1674 2008-09-17  Mark Rowe  <mrowe@apple.com>
1675
1676         Reviewed by Sam Weinig.
1677
1678         Fix a crash seen running DumpRenderTree on fast/dom/null-document-window-open-crash.html under guard malloc.
1679
1680         The JS wrapper for LayoutTestController could outlive the wrapped instance, and would crash when
1681         attempting to access the wrapped instance within layoutTestControllerObjectFinalize. We fix this by making
1682         LayoutTestController ref-counted to ensure that it is not outlived by the JS wrapper.
1683
1684         * DumpRenderTree/ForwardingHeaders/wtf/RefCounted.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h.
1685         * DumpRenderTree/LayoutTestController.cpp:
1686         (LayoutTestController::LayoutTestController):
1687         (notifyDoneCallback): Remove code that is no longer needed now that we must always have a wrapped instance.
1688         (layoutTestControllerObjectFinalize): Deref the wrapped object.
1689         (LayoutTestController::makeWindowObject): Ref the wrapped object.
1690         * DumpRenderTree/LayoutTestController.h: Make LayoutTestController RefCounted.
1691         * DumpRenderTree/mac/DumpRenderTree.mm:
1692         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
1693         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Remove code that is no longer needed.
1694         * DumpRenderTree/win/DumpRenderTree.cpp:
1695         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
1696
1697 2008-09-16  Sam Weinig  <sam@webkit.org>
1698
1699         Reviewed by Mark Rowe.
1700
1701         Add flag to disable running sample on tests that timeout.
1702
1703         * Scripts/run-webkit-tests:
1704
1705 2008-09-16  Adam Roben  <aroben@apple.com>
1706
1707         Windows build fix after r36511
1708
1709         Update for rename of layoutTestController to gLayoutTestController.
1710
1711         * DumpRenderTree/LayoutTestController.cpp:
1712         * DumpRenderTree/win/EditingDelegate.cpp:
1713         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1714         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1715         * DumpRenderTree/win/UIDelegate.cpp:
1716
1717 2008-09-16  Adam Roben  <aroben@apple.com>
1718
1719         Add a script to print out the dependency tree of a Visual Studio
1720         solution file
1721
1722         * Scripts/print-msvc-project-dependencies: Added.
1723
1724 2008-09-16  Mark Rowe  <mrowe@apple.com>
1725
1726         Fix the build.
1727
1728         * DumpRenderTree/LayoutTestController.cpp:
1729         (notifyDoneCallback): Call fprintf in a safer manner.
1730
1731 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
1732
1733         Reviewed by Eric Seidel
1734
1735         Protect against tests that call layoutTestController.notifyDone()
1736         more than once, which would lead to memory corruption, by nulling
1737         out the LayoutTestController on the JSObjectRef on destruction. Also
1738         add a finalize callback on the class so that if the LTC outlives
1739         the JSObjectRef, the JSObjectRef backpointer on the LTC can be
1740         nulled out.
1741
1742         https://bugs.webkit.org/show_bug.cgi?id=20875
1743
1744         * DumpRenderTree/LayoutTestController.cpp:
1745         (LayoutTestController::LayoutTestController):
1746         (notifyDoneCallback):
1747         (layoutTestControllerObjectFinalize):
1748         (LayoutTestController::makeWindowObject):
1749         (LayoutTestController::getJSClass):
1750         * DumpRenderTree/LayoutTestController.h:
1751         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1752         (LayoutTestController::~LayoutTestController):
1753
1754 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
1755
1756         Reviewed by Eric Seidel
1757
1758         Step 1 patch: rename global variable for clarity.
1759         https://bugs.webkit.org/show_bug.cgi?id=20875
1760
1761         * DumpRenderTree/DumpRenderTree.h:
1762         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1763         (dumpWebViewAsPixelsAndCompareWithExpected):
1764         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1765         (dumpFramesAsText):
1766         (dump):
1767         (runTest):
1768         (processWork):
1769         (webViewLoadFinished):
1770         (webViewWindowObjectCleared):
1771         * DumpRenderTree/mac/DumpRenderTree.mm:
1772         (allocateGlobalControllers):
1773         (dumpFrameScrollPosition):
1774         (dumpFramesAsText):
1775         (methodNameStringForFailedTest):
1776         (dump):
1777         (runTest):
1778         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1779         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1780         * DumpRenderTree/mac/EditingDelegate.mm:
1781         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1782         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1783         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1784         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1785         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1786         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1787         (-[EditingDelegate webViewDidBeginEditing:]):
1788         (-[EditingDelegate webViewDidChange:]):
1789         (-[EditingDelegate webViewDidEndEditing:]):
1790         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1791         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1792         (-[FrameLoadDelegate processWork:]):
1793         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
1794         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1795         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1796         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1797         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1798         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1799         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1800         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1801         * DumpRenderTree/mac/UIDelegate.mm:
1802         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
1803         (-[UIDelegate webViewFocus:]):
1804         (-[UIDelegate webViewUnfocus:]):
1805         (-[UIDelegate webView:createWebViewWithRequest:]):
1806         (-[UIDelegate webViewClose:]):
1807         * DumpRenderTree/win/DumpRenderTree.cpp:
1808         (dumpFrameScrollPosition):
1809         (dumpFramesAsText):
1810         (dump):
1811         (runTest):
1812
1813 2008-09-15  Alice Liu  <alice.liu@apple.com>
1814
1815         A change needed to make PPC bots pass accessibility/table-cell-spans.html layout test
1816
1817         Reviewed by Stephanie Lewis.
1818
1819         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1820         Calling -[NSValue rangeValue] on nil object was returning bogus results on PPC,
1821         but not Intel.  Add a check for nil before calling.
1822         (AccessibilityUIElement::rowIndexRange):
1823         (AccessibilityUIElement::columnIndexRange):
1824
1825 2008-09-14  Mark Rowe  <mrowe@apple.com>
1826
1827         Build fix.
1828
1829         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1830         (waitUntilDoneWatchdogFired):
1831         * DumpRenderTree/mac/ObjCPlugin.m:
1832
1833 2008-09-08  Dan Bernstein  <mitz@apple.com>
1834
1835         Reviewed by Mark Rowe.
1836
1837         - add an option to run-webkit-tests to always use the complex text code path
1838
1839         * DumpRenderTree/mac/DumpRenderTree.mm:
1840         (initializeGlobalsFromCommandLineOptions):
1841         (dumpRenderTree):
1842         * Scripts/run-webkit-tests:
1843
1844 2008-09-08  Steve Falkenburg  <sfalken@apple.com>
1845
1846         Another Windows nightly build fix.
1847
1848         Reviewed by Sam Weinig.
1849
1850         * FindSafari/FindSafari.cpp:
1851         (_tmain): Delete existing WebKitNightly directory in temp.
1852         * FindSafari/Safari.exe.manifest: Add PROGIDs for each COM class. Remove non-production classes.
1853
1854 2008-09-07  Stephanie Lewis  <slewis@apple.com>
1855
1856         Reviewed by Mark Rowe.
1857
1858         Fix DRT build
1859
1860         * DumpRenderTree/DumpRenderTreePrefix.h:
1861         * DumpRenderTree/win/DumpRenderTree.vcproj:
1862
1863 2008-09-06  Steve Falkenburg  <sfalken@apple.com>
1864
1865         Fix Windows nightlies.
1866
1867         Copy WebKit.dll alongside application so registry-free COM can find it.
1868         Update embedded manifest to force use registry-free COM.
1869
1870         Reviewed by Dave Hyatt.
1871
1872         * FindSafari/FindSafari.cpp:
1873         (copyManifest):
1874         (replaceManifest):
1875         (_tmain):
1876         * FindSafari/FindSafari.rc: Added.
1877         * FindSafari/FindSafari.vcproj:
1878         * FindSafari/Safari.exe.manifest: Added.
1879         * FindSafari/resource.h: Added.
1880
1881 === End merge of squirrelfish-extreme ===
1882
1883 2008-08-31  Mark Rowe  <mrowe@apple.com>
1884
1885         Reviewed by Maciej Stachowiak.
1886
1887         Add a --profile flag to run-sunspider.
1888
1889         * Scripts/webkitdirs.pm: Detect --profile or --profiling passed as a command-line argument
1890         to build scripts as indicating that we should use the "Profiling" configuration.  At present
1891         this is only supported by JavaScriptCore, so using this argument to build any other project
1892         will likely result in unexpected behaviour.
1893
1894 2008-08-27  Mark Rowe  <mrowe@apple.com>
1895
1896         Reviewed by Oliver Hunt.
1897
1898         Fix run-webkit-tests to handle DRT exiting early.
1899
1900         * Scripts/run-webkit-tests: Initialize $expectedResultPaths{$base} before it will be used.
1901
1902 === Start merge of squirrelfish-extreme ===
1903
1904 2008-09-04  Mark Rowe  <mrowe@apple.com>
1905
1906         Reviewed by Eric Seidel.
1907
1908         Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
1909         Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
1910
1911         * Scripts/build-webkit: Remove ENABLE_DASHBOARD_SUPPORT-related code.
1912
1913 2008-09-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
1914
1915         Reviewed by Oliver Hunt.
1916
1917         Bug 20616: Incorporate V8 benchmarks in testing
1918         <https://bugs.webkit.org/show_bug.cgi?id=20616>
1919
1920         Add support for the --v8 option to run-sunspider.
1921
1922         * Scripts/run-sunspider:
1923
1924 2008-09-04  Kevin Ollivier  <kevino@theolliviers.com>
1925
1926         wx buildbot fix. More robust handling of clean when makefiles are not built or
1927         are not completely made.
1928
1929         * wx/build-wxwebkit:
1930
1931 2008-09-03  Mark Rowe  <mrowe@apple.com>
1932
1933         More Mac build fixes.
1934
1935         Set ENABLE_DASHBOARD_SUPPORT when building for Mac via build-webkit.
1936         Also set ENABLE_CROSS_DOCUMENT_MESSAGING in order to match the
1937         default configuration specified in the .xcconfig files.
1938
1939         * Scripts/build-webkit:
1940
1941 2008-09-03  Mark Rowe  <mrowe@apple.com>
1942
1943         Mac build fix.  Ensure that dashboard support is enabled.
1944
1945         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1946
1947 2008-08-25  Steve Falkenburg  <sfalken@apple.com>
1948
1949         Build fix. Copy correct version of ICU.
1950
1951         * DumpRenderTree/win/DumpRenderTree.vcproj:
1952
1953 2008-08-25  Holger Hans Peter Freyther  <zecke@selfish.org>
1954
1955         Reviewed by Simon.
1956
1957         [run-webkit-tests] Use QtLauncher to show the results of the tests
1958         konqueror might not be installed, xdg-open might not be installed but the
1959         QtLauncher should be present.
1960
1961         * Scripts/run-webkit-tests:
1962
1963 2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>
1964
1965         Initial support for accessibility layout tests on Windows.
1966         https://bugs.webkit.org/show_bug.cgi?id=20497
1967
1968         Reviewed by Sam Weinig.
1969
1970         * DumpRenderTree/AccessibilityController.h: Fix typos.
1971         * DumpRenderTree/AccessibilityUIElement.cpp: Change #import to #include.
1972         * DumpRenderTree/AccessibilityUIElement.h: Define _WINSOCKAPI_ to
1973         prevent oleacc.h, which includes windows.h, from including winsock.h.
1974         Fixed typos.
1975         * DumpRenderTree/win/AccessibilityControllerWin.cpp: Added.
1976         (AccessibilityController::AccessibilityController):
1977         (AccessibilityController::~AccessibilityController):
1978         (AccessibilityController::focusedElement): Get the root element, and
1979         request its focused object.
1980         (AccessibilityController::rootElement): Query Windows for the
1981         accessible client object for the WebView's window.
1982         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added.
1983         (AccessibilityUIElement::AccessibilityUIElement):
1984         (AccessibilityUIElement::~AccessibilityUIElement):
1985         (AccessibilityUIElement::getLinkedUIElements): Not implemented.
1986         (AccessibilityUIElement::getChildren): Get the child count, and append
1987         each child.
1988         (AccessibilityUIElement::getChildAtIndex): Get the child at the given
1989         index offset by 1. In MSAA, child 0 is the object itself.
1990         (AccessibilityUIElement::allAttributes): Not implemented.
1991         (AccessibilityUIElement::attributesOfLinkedUIElements): Same.
1992         (AccessibilityUIElement::attributesOfChildren): Same.
1993         (AccessibilityUIElement::parameterizedAttributeNames): Same.
1994         (self): Return a VARIANT representing the "self" object. This is used
1995         when calling methods that require a child variant.
1996         (AccessibilityUIElement::role): Get the MSAA role, a long value, and
1997         convert it into a string with GetRoleText().
1998         (AccessibilityUIElement::title): Get the element's title, and convert
1999         it to a JS String.
2000         (AccessibilityUIElement::description): Same, for description.
2001         (AccessibilityUIElement::width):
2002         (AccessibilityUIElement::height):
2003         (AccessibilityUIElement::intValue): Get the object's value as a string,
2004         and convert the string to a double.
2005         (AccessibilityUIElement::minValue): Not implemented.
2006         (AccessibilityUIElement::maxValue): Same.
2007         (AccessibilityUIElement::insertionPointLineNumber): Same.
2008         (AccessibilityUIElement::attributesOfColumnHeaders): Same.
2009         (AccessibilityUIElement::attributesOfRowHeaders): Same.
2010         (AccessibilityUIElement::attributesOfColumns): Same.
2011         (AccessibilityUIElement::attributesOfRows): Same.
2012         (AccessibilityUIElement::attributesOfVisibleCells): Same.
2013         (AccessibilityUIElement::attributesOfHeader): Same.
2014         (AccessibilityUIElement::indexInTable): Same.
2015         (AccessibilityUIElement::rowIndexRange): Same.
2016         (AccessibilityUIElement::columnIndexRange): Same.
2017         (AccessibilityUIElement::lineForIndex): Same.
2018         (AccessibilityUIElement::boundsForRange): Same.
2019         (AccessibilityUIElement::cellForColumnAndRow): Same.
2020         * DumpRenderTree/win/DumpRenderTree.vcproj: Add accessibility files to
2021         project.  Link to oleacc.lib, the MSAA library.
2022         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2023         (FrameLoadDelegate::FrameLoadDelegate): Initialize the accessibility
2024         controller.
2025         (FrameLoadDelegate::didClearWindowObject): Create a new window object
2026         for the accessibility controller.
2027         * DumpRenderTree/win/FrameLoadDelegate.h:
2028
2029 2008-08-21  Simon Fraser  <simon.fraser@apple.com>
2030
2031         Reviewed by Mark Rowe
2032
2033         Make build-launcher-app work when run from a git repository.
2034         https://bugs.webkit.org/show_bug.cgi?id=20478
2035
2036         * BuildSlaveSupport/build-launcher-app:
2037
2038 2008-08-20  Maxime Britto  <britto@apple.com>
2039
2040         Reviewed by Ada Chan.
2041
2042          rdar://5259746
2043         Mouse events are sent to page while resizing window (affects Gmail)
2044
2045         * DumpRenderTree/win/UIDelegate.h:
2046         (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.
2047
2048 2008-08-19  Chris Fleizach  <cfleizach@apple.com>
2049
2050         Reviewed by Beth Dakin.
2051
2052         Add snowleopard platform in layout tests
2053
2054         Added support for accessing the attributes of
2055         accessibility tables through the accessibility controller
2056         in DumpRenderTree
2057
2058         * DumpRenderTree/AccessibilityUIElement.cpp:
2059         (attributesOfColumnHeadersCallback):
2060         (attributesOfRowHeadersCallback):
2061         (attributesOfColumnsCallback):
2062         (attributesOfRowsCallback):
2063         (attributesOfVisibleCellsCallback):
2064         (attributesOfHeaderCallback):
2065         (indexInTableCallback):
2066         (rowIndexRangeCallback):
2067         (columnIndexRangeCallback):
2068         (childAtIndexCallback):
2069         (cellForColumnAndRowCallback):
2070         (AccessibilityUIElement::getJSClass):
2071         * DumpRenderTree/AccessibilityUIElement.h:
2072         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2073         (convertNSArrayToVector):
2074         (descriptionOfElements):
2075         (AccessibilityUIElement::getLinkedUIElements):
2076         (AccessibilityUIElement::getChildren):
2077         (AccessibilityUIElement::attributesOfLinkedUIElements):
2078         (AccessibilityUIElement::attributesOfChildren):
2079         (AccessibilityUIElement::attributesOfColumnHeaders):
2080         (AccessibilityUIElement::attributesOfRowHeaders):
2081         (AccessibilityUIElement::attributesOfColumns):
2082         (AccessibilityUIElement::attributesOfRows):
2083         (AccessibilityUIElement::attributesOfVisibleCells):
2084         (AccessibilityUIElement::attributesOfHeader):
2085         (AccessibilityUIElement::indexInTable):
2086         (AccessibilityUIElement::rowIndexRange):
2087         (AccessibilityUIElement::columnIndexRange):
2088         (AccessibilityUIElement::cellForColumnAndRow):
2089         * Scripts/run-webkit-tests:
2090
2091 2008-08-19  Alexey Proskuryakov  <ap@webkit.org>
2092
2093         Reviewed by Darin Adler.
2094
2095         Fix run-webkit-tests misreporting crashed tests as timed out ones because DumpRenderTree
2096         is waiting for crash reporter to let it exit.
2097
2098         The fix does not work on Tiger, because the state of the process is indistinguishable from
2099         other waiting processes, at least not with this technique.
2100
2101         * Scripts/run-webkit-tests:
2102
2103 2008-08-18  Alp Toker  <alp@nuanti.com>
2104
2105         Reviewed by Holger Freyther.
2106
2107         https://bugs.webkit.org/show_bug.cgi?id=20350
2108         [GTK] Get DumpRenderTree working
2109
2110         Fixes and enhancements to DumpRenderTree. With these changes, the test
2111         suite can now complete a run producing text and render tree dumps.
2112
2113         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2114         (dumpFramesAsText):
2115         (dump):
2116         (runTest):
2117         (webViewLoadFinished):
2118         (webViewWindowObjectCleared):
2119         (webViewConsoleMessage):
2120         (webViewScriptAlert):
2121         (webViewScriptPrompt):
2122         (webViewScriptConfirm):
2123         (webViewTitleChanged):
2124         (main):
2125         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2126         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2127         (LayoutTestController::clearBackForwardList):
2128         (LayoutTestController::pathToLocalResource):
2129         (LayoutTestController::setAcceptsEditing):
2130         (LayoutTestController::setUserStyleSheetEnabled):
2131         (LayoutTestController::setUserStyleSheetLocation):
2132         (waitToDumpWatchdogFired):
2133         (LayoutTestController::windowCount):
2134         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2135         (JSStringCopyUTF8CString):
2136         (ScriptItem::invoke):
2137
2138 2008-08-17  Geoffrey Garen  <ggaren@apple.com>
2139
2140         Reviewed by Cameron Zwarich.
2141
2142         Updated project files to XCode 3.1.
2143
2144         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2145         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2146
2147 2008-08-15  Mark Rowe  <mrowe@apple.com>
2148
2149         Rubber-stamped by Geoff Garen.
2150
2151         <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
2152
2153         * Scripts/check-for-global-initializers: Ignore initializers when building the debug variant.
2154
2155 2008-08-13  Simon Hausmann  <hausmann@webkit.org>
2156
2157         Rubber-stamped by Holger.
2158
2159         Revert r31585 and disable http tests for the Qt build again unless
2160         explicitly enabled.
2161
2162         Running the http tests unfortunately currently still triggers
2163         failures in non-http tests due to side-effects. Disable them by default for
2164         now, for more reliable results.
2165
2166         * Scripts/run-webkit-tests:
2167
2168 2008-08-10  Jan Michael Alonzo  <jmalonzo@webkit.org>
2169
2170         Reviewed (and updated) by Alp Toker.
2171
2172         https://bugs.webkit.org/show_bug.cgi?id=16620
2173         [GTK] Autotools make dist and make check support
2174
2175         Get make dist working.
2176
2177         Note that not all possible configurations have been tested yet.
2178
2179         * GNUmakefile.am:
2180
2181 2008-08-10  Alp Toker  <alp@nuanti.com>
2182
2183         Remove leftover qmake/GTK+ build files.
2184
2185         * DumpRenderTree/gtk/DumpRenderTree.pro: Removed.
2186         * GtkLauncher/GtkLauncher.pro: Removed.
2187
2188 2008-08-06  Chris Fleizach  <cfleizach@apple.com>
2189
2190         Reviewed by Beth Dakin
2191
2192         AX functions shouldn't return position information because it changes
2193         based on the platform
2194
2195         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2196         (AccessibilityUIElement::boundsForRange):
2197
2198 2008-08-06  Eric Seidel  <eric@webkit.org>
2199
2200         Reviewed by darin.
2201
2202         Fix leaks seen on build-bot by fixing memory management of AccessibilityUIElement.
2203         <https://bugs.webkit.org/show_bug.cgi?id=20297>
2204         <rdar://problem/6093153>
2205
2206         I've made AccessibilityUIElement a stack object for now.  It could be
2207         made RefCounted, but I figured that might be overkill for the moment.
2208         Essentially it's just a RefPtr itself. :)
2209
2210         I also fixed a few typos, such as AccessibilityUIElement() instead of ~AccessibilityUIElement()
2211         which was causing additional leaks. :)
2212
2213         I added toAXElement to remove a bunch of copy/paste code.
2214
2215         * DumpRenderTree/AccessibilityController.h:
2216         * DumpRenderTree/AccessibilityUIElement.cpp:
2217         (toAXElement):
2218         (allAttributesCallback):
2219         (attributesOfLinkedUIElementsCallback):
2220         (attributesOfChildrenCallback):
2221         (lineForIndexCallback):
2222         (boundsForRangeCallback):
2223         (childAtIndexCallback):
2224         (getRoleCallback):
2225         (getTitleCallback):
2226         (getDescriptionCallback):
2227         (getWidthCallback):
2228         (getHeightCallback):
2229         (getIntValueCallback):
2230         (getMinValueCallback):
2231         (getMaxValueCallback):
2232         (getInsertionPointLineNumberCallback):
2233         (finalize):
2234         * DumpRenderTree/AccessibilityUIElement.h:
2235         (AccessibilityUIElement::platformUIElement):
2236         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2237         (AccessibilityController::focusedElement):
2238         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2239         (AccessibilityUIElement::AccessibilityUIElement):
2240         (AccessibilityUIElement::getLinkedUIElements):
2241         (AccessibilityUIElement::getChildren):
2242         (AccessibilityUIElement::getChildAtIndex):
2243         (AccessibilityUIElement::attributesOfLinkedUIElements):
2244         (AccessibilityUIElement::attributesOfChildren):
2245
2246 2008-08-06  Eric Seidel  <eric@webkit.org>
2247
2248         Reviewed by Cameron Zwarich.
2249
2250         Speculative fix for an error I keep seeing in my Cygwin build
2251
2252         * Scripts/webkitdirs.pm: make determineConfigurationProductDir() always call determineConfiguration() even on cygwin
2253
2254 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
2255
2256         Forgot to commit licensing correction in last commit.
2257
2258         * wx/packaging/wxWebKitInstaller.iss.in:
2259
2260 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
2261
2262         Reviewed by Eric Seidel.
2263
2264         Scripts for building a wxWebKit installer for wxPython on Win, eventually will
2265         be used for nightlies.
2266
2267         https://bugs.webkit.org/show_bug.cgi?id=20036
2268
2269         * wx/packaging: Added.
2270         * wx/packaging/build-win-installer.py: Added.
2271         * wx/packaging/wxWebKitInstaller.iss.in: Added.
2272
2273 2008-07-31  Adam Roben  <aroben@apple.com>
2274
2275         Follow-up to r35500
2276
2277         * WinLauncher/WinLauncher.vcproj: Set the manifest properties for the
2278         Release configuration, too.
2279
2280 2008-07-31  Stefan Landvogt <stefan.landvogt@gmail.com>
2281
2282         Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of
2283         the box
2284
2285         <https://bugs.webkit.org/show_bug.cgi?id=20245>
2286
2287         Reviewed by Adam Roben.
2288
2289         * WinLauncher/WinLauncher.vcproj: adding the following properties to
2290         WinLauncher > Properties > Manifest Tool > Isolated COM
2291         Type Library File: $(WebKitOutputDir)\lib\WebKit.tlb
2292         Component File Name: WebKit$(WebKitDLLConfigSuffix)
2293         Doing the change on "All Configurations"
2294
2295 2008-07-31  Adam Roben  <aroben@apple.com>
2296
2297         Windows build bot fix
2298
2299         * DumpRenderTree/win/ImageDiff.vcproj: Don't fail if files that only
2300         exist for people at Apple can't be found. Also updated the ICU version
2301         to 3.8.
2302
2303 2008-07-31  David Kilzer  <ddkilzer@apple.com>
2304
2305         Fix layout test results for webarchive/test-xml-stylesheet.xml
2306
2307         Reviewed by Darin Adler.
2308
2309         * DumpRenderTree/mac/DumpRenderTree.mm:
2310         (convertMIMEType): Work around the "text/xml" local file type
2311         regression in Leopard using the BUILDING_ON_LEOPARD macro.  Also
2312         stop mangling "application/x-javascript" into "text/javascript".
2313         (convertWebResourceDataToString): When checking whether to dump a
2314         resource as text, also check to see if the MIME type is in the
2315         -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
2316         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD
2317         macro.
2318
2319 2008-07-31  Chris Fleizach  <cfleizach@apple.com>
2320
2321         Reviewed by Alice Liu
2322
2323         Add AX support to get the bounds for a range of text
2324         Add AX support to get the child of an element
2325         Add AX support to get all the parameterized attribute names of an element
2326
2327         * DumpRenderTree/AccessibilityUIElement.cpp:
2328         (parameterizedAttributeNamesCallback):
2329         (boundsForRangeCallback):
2330         (childAtIndexCallback):
2331         (AccessibilityUIElement::getJSClass):
2332         * DumpRenderTree/AccessibilityUIElement.h:
2333         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2334         (AccessibilityUIElement::getChildAtIndex):
2335         (AccessibilityUIElement::parameterizedAttributeNames):
2336         (AccessibilityUIElement::boundsForRange):
2337
2338 2008-07-31  Erik Bunce  <elbunce@thehive.com>
2339
2340         Reviewed by Simon.
2341
2342         Make run-launcher set DYLD_LIBRARY_PATH to make things work on Mac OS X.
2343
2344         * Scripts/run-launcher:
2345
2346 2008-07-30  Jessica Kahn  <jess@apple.com>
2347
2348         Reviewed by Adam Roben.
2349
2350         Slightly stricter checking for previous change, suggested by Adam.
2351
2352         * Scripts/extract-localizable-strings:
2353
2354 2008-07-30  Jessica Kahn  <jess@apple.com>
2355
2356         Reviewed by Darin Adler.
2357
2358         Added support for UI_STRING and UI_STRING_KEY macros with flexible prefixes.
2359
2360         * Scripts/extract-localizable-strings:
2361
2362 2008-07-30  Anders Carlsson  <andersca@apple.com>
2363
2364         Reviewed by Adam.
2365
2366         Copy icu38* files instead of icu36* files.
2367
2368         * DumpRenderTree/win/DumpRenderTree.vcproj:
2369
2370 2008-07-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
2371
2372         DRT/Gtk build fix for r35362
2373
2374         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2375         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2376
2377 2008-07-25  Brady Eidson  <beidson@apple.com>
2378
2379         Reviewed by Sam
2380
2381         Add the ability to dump whether-or-not an element should have autocomplete enabled,
2382         from the perspective of the WebKit API
2383
2384         * DumpRenderTree/LayoutTestController.cpp:
2385         (elementDoesAutoCompleteForElementWithIdCallback):
2386         (LayoutTestController::staticFunctions):
2387
2388         * DumpRenderTree/LayoutTestController.h:
2389         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2390         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2391         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2392         (LayoutTestController::elementDoesAutoCompleteForElementWithId): Stub for now until I can get on Windows
2393
2394 2008-07-25  Chris Fleizach  <cfleizach@apple.com>
2395
2396         Reviewed by Beth Dakin
2397
2398         Add support for AXLineForIndex and AXInsertionPointIndex through the
2399         accessibility controller
2400
2401         * DumpRenderTree/AccessibilityUIElement.cpp:
2402         (lineForIndexCallback):
2403         (getInsertionPointLineNumberCallback):
2404         (AccessibilityUIElement::getJSClass):
2405         * DumpRenderTree/AccessibilityUIElement.h:
2406         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2407         (AccessibilityUIElement::insertionPointLineNumber):
2408         (AccessibilityUIElement::lineForIndex):
2409
2410 2008-07-25  Adam Roben  <aroben@apple.com>
2411
2412         Try to fix the Windows build bot
2413
2414         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't try to copy files
2415         that don't exist for people outside of Apple.
2416
2417 2008-07-18  Landry Breuil  <landry@openbsd.org>
2418
2419         Bug 19975: [OpenBSD] Patches to enable build of WebKit
2420
2421         <https://bugs.webkit.org/show_bug.cgi?id=19975>
2422
2423         Reviewed by David Kilzer.
2424
2425         * DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.
2426
2427 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
2428
2429         CygwinDownloader fails to install necessary packages
2430         https://bugs.webkit.org/show_bug.cgi?id=20075
2431
2432         Reviewed by Mark Rowe.
2433
2434         * CygwinDownloader/cygwin-downloader.zip: Rebuilt after two broken
2435         mirrors removed in r34116. Set MIME type to application/octet-stream.
2436
2437 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
2438
2439         CygwinDownloader's make-zip.sh script fails
2440         https://bugs.webkit.org/show_bug.cgi?id=20074
2441
2442         Reviewed by Mark Rowe.
2443
2444         * CygwinDownloader/cygwin-downloader.py:
2445
2446 2008-07-15  Sam Weinig  <sam@webkit.org>
2447
2448         Reviewed by Anders Carlsson.
2449
2450         Refactor accessibility testing code.
2451
2452         We now have:
2453         - AccessibilityController
2454           Controller which has access to the WebView and can provide the focused element, root element
2455           and in the future, elementAtPoint.
2456
2457         - AccessibilityUIElement
2458           Object which provides access to the data provided by the Accessibility APIs.
2459
2460         * DumpRenderTree/AccessibilityController.cpp:
2461         (getFocusedElementCallback):
2462         (getRootElementCallback):
2463         (AccessibilityController::getJSClass):
2464         * DumpRenderTree/AccessibilityController.h:
2465         * DumpRenderTree/AccessibilityUIElement.cpp: Added.
2466         (allAttributesCallback):
2467         (attributesOfLinkedUIElementsCallback):
2468         (attributesOfChildrenCallback):
2469         (getRoleCallback):
2470         (getTitleCallback):
2471         (getDescriptionCallback):
2472         (getWidthCallback):
2473         (getHeightCallback):
2474         (getIntValueCallback):
2475         (getMinValueCallback):
2476         (getMaxValueCallback):
2477         (finalize):
2478         (AccessibilityUIElement::makeJSAccessibilityUIElement):
2479         (AccessibilityUIElement::getJSClass):
2480         * DumpRenderTree/AccessibilityUIElement.h: Added.
2481         (AccessibilityUIElement::platformUIElement):
2482         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2483         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2484         (AccessibilityController::AccessibilityController):
2485         (AccessibilityController::~AccessibilityController):
2486         (AccessibilityController::focusedElement):
2487         (AccessibilityController::rootElement):
2488         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added.
2489         (AccessibilityUIElement::AccessibilityUIElement):
2490         (descriptionOfValue):
2491         (attributesOfElement):
2492         (nsStringToJSStringRef):
2493         (concatenateAttributeAndValue):
2494         (AccessibilityUIElement::getLinkedUIElements):
2495         (AccessibilityUIElement::getChildren):
2496         (AccessibilityUIElement::attributesOfLinkedUIElements):
2497         (AccessibilityUIElement::attributesOfChildren):
2498         (AccessibilityUIElement::allAttributes):
2499         (AccessibilityUIElement::role):
2500         (AccessibilityUIElement::title):
2501         (AccessibilityUIElement::description):
2502         (AccessibilityUIElement::width):
2503         (AccessibilityUIElement::height):
2504         (AccessibilityUIElement::intValue):
2505         (AccessibilityUIElement::minValue):
2506         (AccessibilityUIElement::maxValue):
2507
2508 2008-07-14  Chris Fleizach  <cfleizach@apple.com>
2509
2510         Reviewed by Beth Dakin
2511
2512         Add support to get attributes of the AXChildren of an objecty
2513
2514         * DumpRenderTree/AccessibilityController.cpp:
2515         (attributesOfChildrenForFocusedElementCallback):
2516         (AccessibilityController::staticFunctions):
2517         * DumpRenderTree/AccessibilityController.h:
2518         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2519         (descriptionOfValue):
2520         (AccessibilityController::attributesOfChildrenForFocusedElement):
2521
2522 2008-07-14  Steve Falkenburg  <sfalken@apple.com>
2523
2524         Build fix.
2525
2526         * DumpRenderTree/win/DumpRenderTree.vcproj:
2527
2528 2008-07-14  Adam Roben  <aroben@apple.com>
2529
2530         Attempted Windows build fix
2531
2532         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add
2533         CoreFoundation/OSXCompatibilityHeaders[/GNUCompatibility] to the
2534         include path.
2535
2536 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
2537
2538         Reviewed by Geoff Garen.
2539
2540         Eliminate per-thread JavaScript global data instance support and make arbitrary
2541         global data/global object combinations possible.
2542
2543         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
2544         (runJavaScriptThread): Don't pass a released context reference to JSGarbageCollect.
2545         In this scenario, it was causing crashes after each 10-20 tests, because there was a large
2546         chance for a different thread to cause GC after the context was released.
2547
2548 2008-07-11  Stephanie Lewis  <slewis@apple.com>
2549
2550         Reviewed by Darin Adler.
2551
2552         Make sure we read WebCore Leak messages.  Force full document teardown for DumpRenderTree.
2553
2554         Up timeout limit, some slower machines were timing out before crashtracer finished writing out to disk and quitting DRT.
2555
2556         * DumpRenderTree/mac/DumpRenderTree.mm:
2557         (setDefaultsToConsistentValuesForTesting):
2558         (resetWebViewToConsistentStateBeforeTesting):
2559         * Scripts/run-webkit-tests:
2560
2561 2008-07-10  Steve Falkenburg  <sfalken@apple.com>
2562
2563         Build fix.
2564
2565         * DumpRenderTree/win/DumpRenderTree.vcproj:
2566
2567 2008-07-09  Eric Seidel  <eric@webkit.org>
2568
2569         Reviewed by Mark Rowe.
2570
2571         Print <div> backgrounds when printing from DRT.
2572
2573         * DumpRenderTree/mac/DumpRenderTree.mm:
2574         (setDefaultsToConsistentValuesForTesting):
2575
2576 2008-07-09  Eric Seidel  <eric@webkit.org>
2577
2578         Reviewed by Mark Rowe.
2579
2580         Fix copying of expected results to correct location
2581
2582         * Scripts/run-webkit-tests:
2583
2584 2008-07-09  Eric Seidel  <eric@webkit.org>
2585
2586         Reviewed by aroben.
2587
2588         * DumpRenderTree/LayoutTestController.cpp:
2589         (LayoutTestController::LayoutTestController):
2590         (dumpAsPDFCallback):
2591         (LayoutTestController::staticFunctions):
2592         * DumpRenderTree/LayoutTestController.h:
2593         (LayoutTestController::dumpAsPDF):
2594         (LayoutTestController::setDumpAsPDF):
2595         * DumpRenderTree/mac/DumpRenderTree.mm:
2596         (dumpFrameAsPDF):
2597         (dump):
2598
2599 2008-07-09  Eric Seidel  <eric@webkit.org>
2600
2601         Reviewed by weinig.
2602
2603         Add Content-Type support to DumpRenderTree and run-webkit-tests
2604         and move expected.txt files to expected.webarchive
2605
2606         https://bugs.webkit.org/show_bug.cgi?id=15565
2607
2608         * DumpRenderTree/cg/ImageDiffCG.cpp:
2609         (compareImages):
2610         (main):
2611         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2612         (printPNG):
2613         * DumpRenderTree/mac/DumpRenderTree.mm:
2614         (dump):
2615         * Scripts/run-webkit-tests:
2616
2617 2008-07-08  Jon Honeycutt  <jhoneycutt@apple.com>
2618
2619         Reviewed by Anders.
2620
2621         Port r34988 to Mac: allow tests to define JavaScript to execute when
2622         NPP_DestroyStream or NPP_URLNotify is called.
2623
2624         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2625         (NPP_New): Remove initialization that happens in pluginAllocate. Look
2626         for new arguments onStreamDestroy and onURLNotify.
2627         (NPP_Destroy): Free onStreamDestroy and onURLNotify.
2628         (executeScript): Code moved from onStreamLoad.
2629         (NPP_NewStream): Call executeScript.
2630         (NPP_DestroyStream): Same.
2631         (NPP_URLNotify): Same.
2632
2633 2008-07-07  Beth Dakin  <bdakin@apple.com>
2634
2635         Reviewed by Anders.
2636
2637         This patch extends DRT accessibility tests to add the ability to
2638         query the intValue, minValue, and maxValue of the focused element.
2639
2640         * DumpRenderTree/AccessibilityController.cpp:
2641         (intValueOfFocusedElementCallback):
2642         (minValueOfFocusedElementCallback):
2643         (maxValueOfFocusedElementCallback):
2644         (AccessibilityController::staticFunctions):
2645         * DumpRenderTree/AccessibilityController.h:
2646         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2647         (AccessibilityController::intValueOfFocusedElement):
2648         (AccessibilityController::minValueOfFocusedElement):
2649         (AccessibilityController::maxValueOfFocusedElement):
2650
2651 2008-07-07  Steve Falkenburg  <sfalken@apple.com>
2652
2653         Fix build.
2654
2655         * DumpRenderTree/win/ImageDiff.vcproj:
2656
2657 2008-07-02  Jon Honeycutt  <jhoneycutt@apple.com>
2658
2659         Allow tests to define JavaScript to execute when NPP_DestroyStream or
2660         NPP_URLNotify is called.
2661
2662         Reviewed by Anders.
2663
2664         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add a new
2665         property, "returnErrorFromNewStream." This is to support the test for
2666         <rdar://5983747> Safari crashes trying to load the SilverLight plugin,
2667         caused by WebKit calling NPP_DestroyStream after a plug-in returns an
2668         error from NPP_NewStream.
2669         (pluginGetProperty):
2670         (pluginSetProperty):
2671         (pluginAllocate):
2672         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Added new
2673         members, onStreamDestroy and onURLNotify.
2674         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2675         (NPP_New): Remove initialization of onStreamLoad; this was moved to
2676         pluginAllocate. Look for new arguments onStreamDestroy and
2677         onURLNotify, and store their values.
2678         (NPP_Destroy): Free new members.
2679         (executeScript): Code moved from onStreamLoad
2680         (NPP_NewStream): If returnErrorFromNewStream has been set to true,
2681         return a generic error code. If onStreamLoad is set, execute it as
2682         JavaScript.
2683         (NPP_DestroyStream): If onStreamDestroy is set, execute it as JS.
2684         (NPP_URLNotify): Same, for onURLNotify.
2685
2686 2008-07-02  Brady Eidson  <beidson@apple.com>
2687
2688         Reviewed by Mitz Pettel and John Sullivan
2689
2690         Add the ability to tell DRT to call stopLoading on a WebFrame inside of a didStartProvisionalLoadForFrame
2691         load delegate.
2692
2693         Required to add a layout test for the fix for <rdar://problem/5549871>
2694
2695         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2696         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): If stopProvisionalFrameLoads is set, call
2697           [WebFrame stopLoading] to test for the crash reflected in 5549871
2698
2699         All of the following are infrastructure to add the layoutTestController.setStopProvisionalFrameLoads() call:
2700         * DumpRenderTree/LayoutTestController.cpp:
2701         (LayoutTestController::LayoutTestController):
2702         (setStopProvisionalFrameLoadsCallback):
2703         (LayoutTestController::staticFunctions):
2704         * DumpRenderTree/LayoutTestController.h:
2705         (LayoutTestController::stopProvisionalFrameLoads):
2706         (LayoutTestController::setStopProvisionalFrameLoads):
2707
2708 2008-07-01  Chris Fleizach  <cfleizach@apple.com>
2709
2710         Reviewed by Beth Dakin
2711
2712         Support ability to get width and height of an element through accessibility
2713
2714         * DumpRenderTree/AccessibilityController.cpp:
2715         (widthOfFocusedElementCallback):
2716         (heightOfFocusedElementCallback):
2717         (AccessibilityController::staticFunctions):
2718         * DumpRenderTree/AccessibilityController.h:
2719         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2720         (AccessibilityController::widthOfFocusedElement):
2721         (AccessibilityController::heightOfFocusedElement):
2722
2723 2008-06-30  Chris Fleizach  <cfleizach@apple.com>
2724
2725         Reviewed by Beth Dakin
2726
2727         Support the ability to get the linked ui elements of an object
2728
2729         * DumpRenderTree/AccessibilityController.cpp:
2730         (attributesOfLinkedUIElementsForFocusedElementCallback):
2731         (AccessibilityController::staticFunctions):
2732         * DumpRenderTree/AccessibilityController.h:
2733         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2734         (AccessibilityController::attributesOfLinkedUIElementsForFocusedElement):
2735         (AccessibilityController::allAttributesOfFocusedElement):
2736         (attributesOfElement):
2737         (nsStringToJSStringRef):
2738
2739 2008-06-29  Sam Weinig  <sam@webkit.org>
2740
2741         Fix Tiger build.
2742
2743         * DumpRenderTree/mac/EventSendingController.mm:
2744         (eventTypeForMouseButtonAndAction):
2745
2746 2008-06-27  Eric Seidel  <eric@webkit.org>
2747
2748         Reviewed by darin.
2749
2750         Add multi-button mouseevent support to DRT
2751         https://bugs.webkit.org/show_bug.cgi?id=15173
2752
2753         It's now possible to specify the mouse button with:
2754         eventSender.mouseDown(1); eventSender.mouseUp(1); etc.
2755
2756         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2757         * DumpRenderTree/mac/EventSendingController.h:
2758         * DumpRenderTree/mac/EventSendingController.mm:
2759         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2760         (+[EventSendingController webScriptNameForSelector:]):
2761         (eventTypeForMouseButtonAndAction):
2762         (-[EventSendingController updateClickCountForButton:]):
2763         (-[EventSendingController mouseDown:]):
2764         (-[EventSendingController mouseUp:]):
2765         (-[EventSendingController mouseMoveToX:Y:]):
2766         (-[EventSendingController contextClick]):
2767
2768 2008-06-28  Nikolas Zimmermann  <zimmermann@kde.org>
2769
2770         Reviewed by Oliver.
2771
2772         Copy <test>-expected.png from the right location to /tmp/layout-test-results.
2773         Use $expectedPixelDir instead of $expectedDir. Allows using SVG pixel tests again.
2774
2775         * Scripts/run-webkit-tests:
2776
2777 2008-06-27  Jan Michael Alonzo  <jmalonzo@webkit.org>
2778
2779         Reviewed by Christian Dywan.
2780
2781         [Gtk] Initialize webview settings before running DRT tests
2782         http://bugs.webkit.org/show_bug.cgi?id=19778
2783
2784         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2785         (setDefaultsToConsistentStateValuesForTesting):
2786         (main):
2787
2788 2008-06-26  Darin Adler  <darin@apple.com>
2789
2790         * Scripts/check-for-weak-vtables: Fixed comment.
2791
2792 2008-06-26  Darin Adler  <darin@apple.com>
2793
2794         * Scripts/check-for-weak-vtables: Added.
2795
2796 2008-06-26  Beth Dakin  <bdakin@apple.com>
2797
2798         Reviewed by Sam.
2799
2800         Do not include AXPosition in the dump of all of the accessibility
2801         attributes since it is screen-specific.
2802
2803         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2804         (AccessibilityController::allAttributesOfFocusedElement):
2805
2806 2008-06-26  Beth Dakin  <bdakin@apple.com>
2807
2808         Reviewed by Anders.
2809
2810         This is a speculative fix for the failing layout test on the build
2811         bot. It seems that the problem that the Build Bot is having is
2812         Tiger-specific. On Tiger, [NSValue description] was not very smart.
2813         So I replaced our call to description with a hand-rolled equivalent
2814         that will match on both platforms.
2815
2816         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2817         (descriptionOfValue):
2818
2819 2008-06-25  Beth Dakin  <bdakin@apple.com>
2820
2821         Reviewed by Sam Weinig.
2822
2823         This patch adds support to the AccessibilityController to query the
2824         following attributes specifically, without a full attribute dump:
2825         AXRole, AXTitle, and AXDescription.
2826
2827         * DumpRenderTree/AccessibilityController.cpp:
2828         (allAttributesForFocusedElementCallback):
2829         (roleOfFocusedElementCallback):
2830         (titleOfFocusedElementCallback):
2831         (descriptionOfFocusedElementCallback):
2832         (AccessibilityController::staticFunctions):
2833         * DumpRenderTree/AccessibilityController.h:
2834         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2835         (AccessibilityController::allAttributesForFocusedElement):
2836         (concatenateAttributeAndValue):
2837         (AccessibilityController::roleOfFocusedElement):
2838         (AccessibilityController::titleOfFocusedElement):
2839         (AccessibilityController::descriptionOfFocusedElement):
2840
2841 2008-06-24  Dan Bernstein  <mitz@apple.com>
2842
2843         Reviewed by Stephanie Lewis.
2844
2845         - move the linker flags from the debug configuration in the project
2846           to the shared configuration
2847
2848         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2849         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2850
2851 2008-06-24  Dan Bernstein  <mitz@apple.com>
2852
2853         - try to fix the Tiger build
2854
2855         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2856
2857 2008-06-24  Sam Weinig and Beth Dakin  <bdakin@apple.com and sam@webkit.org>
2858
2859         Reviewed by Darin Adler.
2860
2861         Fix for <rdar://problem/5884881> Make DumpRenderTree support
2862         accessibility tests
2863
2864         This patch adds some basic support for accessibility layout tests
2865         on the Mac.
2866
2867         * DumpRenderTree/AccessibilityController.cpp: Added.
2868         (AccessibilityController::AccessibilityController):
2869         (AccessibilityController::~AccessibilityController):
2870         (dumpCurrentAttributesCallback):
2871         (AccessibilityController::makeWindowObject):
2872         (AccessibilityController::getJSClass):
2873         (AccessibilityController::staticFunctions):
2874         * DumpRenderTree/AccessibilityController.h: Added.
2875         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2876         * DumpRenderTree/mac/AccessibilityControllerMac.mm: Added.
2877         (descriptionOfValue):
2878         (AccessibilityController::dumpCurrentAttributes):
2879         * DumpRenderTree/mac/DumpRenderTree.mm:
2880         * DumpRenderTree/mac/FrameLoadDelegate.h:
2881         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2882         (-[FrameLoadDelegate init]):
2883         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2884
2885 2008-06-24  John Sullivan  <sullivan@apple.com>
2886
2887         Reviewed by Dan Bernstein
2888
2889         * Scripts/extract-localizable-strings:
2890         add UI_STRING_LOCALIZE_LATER, LPCTSTR_UI_STRING_LOCALIZE_LATER, and LOG_WARNING to the
2891         list of debugging macros, to avoid noise when keeping the list of localized string
2892         exceptions up to date
2893
2894 2008-06-24  Dan Bernstein  <mitz@apple.com>
2895
2896         Rubber-stamped by Darin Adler.
2897
2898         - add a font family for testing font-weight
2899
2900         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linker
2901         flags to create data sections for the WeightWatcher fonts.
2902         * DumpRenderTree/fonts: Added.
2903         * DumpRenderTree/fonts/WebKitWeightWatcher100.ttf: Added.
2904         * DumpRenderTree/fonts/WebKitWeightWatcher200.ttf: Added.
2905         * DumpRenderTree/fonts/WebKitWeightWatcher300.ttf: Added.
2906         * DumpRenderTree/fonts/WebKitWeightWatcher400.ttf: Added.
2907         * DumpRenderTree/fonts/WebKitWeightWatcher500.ttf: Added.
2908         * DumpRenderTree/fonts/WebKitWeightWatcher600.ttf: Added.
2909         * DumpRenderTree/fonts/WebKitWeightWatcher700.ttf: Added.
2910         * DumpRenderTree/fonts/WebKitWeightWatcher800.ttf: Added.
2911         * DumpRenderTree/fonts/WebKitWeightWatcher900.ttf: Added.
2912         * DumpRenderTree/mac/DumpRenderTree.mm:
2913         (activateFonts): Renamed activateAhemFont to this and made it activate
2914         the WeightWatcher fonts in addition to Ahem.
2915         (prepareConsistentTestingEnvironment): Adjusted for the name change.
2916         * DumpRenderTree/win/DumpRenderTree.cpp:
2917         (initialize): Added the WeightWatcher fonts.
2918
2919 2008-06-20  Brent Fulgham  <bfulgham@gmail.com>
2920
2921         Reviewed by Darin Adler.
2922
2923         Extend the build-webkit (and set-webkit-configuration) script to
2924         support Cairo-based webkit builds.  (see http://bugs.webkit.org/show_bug.cgi?17952)
2925
2926         * Scripts/build-webkit:  Add --cairo-win32 to the help message
2927         * Scripts/webkitdirs.pm:  Extend the 'determinePassedConfiguration
2928           subroutine to recognize the --cairo-win32 flag.  When present,
2929           the build configuration is changed from Debug/Release to
2930           Debug_Cairo/Release_Cairo.  This flag is only active when the
2931           isCygwin() test is true.
2932
2933 2008-06-17  Dan Bernstein  <mitz@apple.com>
2934
2935         Reviewed by Justin Garcia.
2936
2937         - prefer Leopard results when running on Snow Leopard.
2938
2939         * Scripts/run-webkit-tests: Added a mapping of Snow Leopard to
2940           mac-leopard.
2941         * Scripts/webkitdirs.pm: Added isSnowLeopard().
2942
2943 2008-06-15  Darin Adler  <darin@apple.com>
2944
2945         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2946
2947 2008-06-15  Darin Adler  <darin@apple.com>
2948
2949         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2950
2951 2008-06-15  Darin Adler  <darin@apple.com>
2952
2953         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2954
2955 2008-06-15  Darin Adler  <darin@apple.com>
2956
2957         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2958
2959 2008-06-15  Darin Adler  <darin@apple.com>
2960
2961         * Scripts/do-file-rename: Updated.
2962         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2963
2964 2008-06-15  Darin Adler  <darin@apple.com>
2965
2966         * Scripts/do-file-rename: Updated for the latest round of renaming.
2967         * Scripts/do-webcore-rename: Tweaked and reorganized a bit.
2968
2969 2008-06-15  Darin Adler  <darin@apple.com>
2970
2971         * Scripts/create-exports: Added.
2972         * Scripts/do-file-rename: Added some planned renames.
2973         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2974
2975 2008-06-15  Darin Adler  <darin@apple.com>
2976
2977         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2978
2979 2008-06-15  Maciej Stachowiak  <mjs@apple.com>
2980
2981         Reviewed by Oliver.
2982
2983         - rename testkjs to jsc
2984
2985         * Scripts/build-jsc: Copied from Scripts/build-testkjs.
2986         * Scripts/build-testkjs: Removed.
2987         * Scripts/run-javascriptcore-tests:
2988         * Scripts/run-jsc: Copied from Scripts/run-testkjs.
2989         * Scripts/run-sunspider:
2990         * Scripts/run-testkjs: Removed.
2991         * Scripts/sunspider-compare-results:
2992
2993 2008-06-14  Darin Adler  <darin@apple.com>
2994
2995         * Scripts/do-webcore-rename: Moved planned renames into a separate hash
2996         from the actual renames. Removed many renames that are either done or
2997         no longer planned.
2998
2999 2008-06-14  Darin Adler  <darin@apple.com>
3000
3001         * Scripts/do-webcore-rename: Fixed obvious typo.
3002
3003 2008-06-13  Darin Adler  <darin@apple.com>
3004
3005         * Scripts/make-js-test-wrappers: Added three more exceptions.
3006
3007 2008-06-10  Joerg Bornemann  <joerg.bornemann@trolltech.com>
3008
3009         Reviewed by Simon.
3010
3011         For the qmake based build make it possible to build against makespecs where
3012         QMAKE_CC is defined in a configuration file included from qmake.conf.
3013
3014         * Scripts/webkitdirs.pm: Added support for include() statements in
3015         qmake.conf.
3016
3017 2008-06-09  Alp Toker  <alp@nuanti.com>
3018
3019         gcc3/autotools build fix. Add explicit -O2 -fno-strict-aliasing to
3020         each of the tools since these are no longer set globally.
3021
3022         * GNUmakefile.am:
3023
3024 2008-06-08  Darin Adler  <darin@apple.com>
3025
3026         * Scripts/make-js-test-wrappers: Added another exception.
3027
3028 2008-06-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
3029
3030         Reviewed by Timothy.
3031
3032         Remove the --squirrelfish option from SunSpider, as it is no longer needed.
3033
3034         * Scripts/run-sunspider:
3035
3036 2008-06-05  Alp Toker  <alp@nuanti.com>
3037
3038         Build fix for r34387.
3039
3040         * GNUmakefile.am:
3041
3042 2008-06-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
3043
3044         Reviewed by Oliver.
3045
3046         Add an exception for Opcode.o to the global initializers check so that
3047         we can dump instruction statistics in the JavaScript virtual machine.
3048
3049         * Scripts/check-for-global-initializers:
3050
3051 2008-05-30  Steve Falkenburg  <sfalken@apple.com>
3052
3053         Generate an isolated COM manifest for registry free COM.
3054
3055         * DumpRenderTree/win/DumpRenderTree.vcproj:
3056
3057 2008-06-02  Anders Carlsson  <andersca@apple.com>
3058
3059         Reviewed by David Hyatt and Mitz.
3060
3061         <rdar://problem/5704119>
3062         repro crash in WebCore::RenderPart::setWidget (plugin-related?)
3063
3064         Call -[WebView display] in the "plug-in" failed delegate method, simulating
3065         the sheet that Safari puts up.
3066
3067         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3068         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
3069
3070 2008-05-30  Timothy Hatcher  <timothy@apple.com>
3071
3072         Made the starting line number of scripts be 1-based throughout the engine.
3073         This cleans up script line numbers so they are all consistent now.
3074
3075         Reviewed by Oliver Hunt.
3076
3077         * DumpRenderTree/mac/ObjCController.m:
3078         (runJavaScriptThread): Pass a line number of 1 instead of 0 to JSEvaluateScript.
3079         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
3080         (runJavaScriptThread): Ditto.
3081         * DumpRenderTree/win/DumpRenderTree.cpp:
3082         (runJavaScriptThread): Ditto.
3083
3084 2008-05-29  Geoffrey Garen  <ggaren@apple.com>
3085
3086         Reviewed by Adam Roben.
3087
3088         Fixed VCSUtils.pm to work with git repositories inside symlinks.
3089
3090         * Scripts/VCSUtils.pm: Compute a relative path from the git repository
3091         root, instead of the root of the filesystem, to work around a bug in
3092         abs2rel when traversing symlinked home directories.
3093
3094 2008-05-29  Kevin Ollivier  <kevino@theolliviers.com>
3095
3096         Reviewed by Darin Adler.
3097
3098         Restore original behavior of isOSX() referring to the Mac port, not the OS itself.
3099
3100         https://bugs.webkit.org/show_bug.cgi?id=19311
3101
3102         * Scripts/webkitdirs.pm:
3103
3104 2008-05-29  Alexey Proskuryakov  <ap@webkit.org>
3105
3106         Reviewed by Adam Roben.
3107
3108         Fix run-iexploder-tests and run-mangleme-tests to work with updated shared scripts and
3109         configuration files.
3110
3111         * Scripts/run-iexploder-tests:
3112         * Scripts/run-mangleme-tests:
3113         Renamed runSafari to not conflict with the one in webkitdirs.
3114         Added SSLCertificateFile option for httpd, as now needed.
3115
3116 2008-05-27  Kevin Ollivier  <kevino@theolliviers.com>
3117
3118         wx build fix. Update the sample app after wxWebFrame->wxWebBrowserShell rename.
3119
3120         * wx/browser/browser.cpp:
3121         (MyApp::OnInit):
3122
3123 2008-05-24  Andreia Gaita  <shana@isninja.com>
3124
3125         Reviewed by Alp Toker.
3126
3127         cygwin-downloader.py fixes.
3128
3129         Remove two non-working mirrors. Add a check for missing dependency
3130         packages to avoid bailing out on an inconsistent Cygwin package list.
3131
3132         * CygwinDownloader/cygwin-downloader.py:
3133
3134 2008-05-24  Jan Michael Alonzo  <jmalonzo@webkit.org>
3135
3136         Reviewed by Darin Adler.
3137
3138         Remove useQmake usage. QMake build doesn't support Gtk port
3139         anymore.
3140
3141         Also fix 2 occurences of "Web Kit". Should be WebKit.
3142
3143         * Scripts/build-webkit:
3144         * Scripts/run-javascriptcore-tests:
3145         * Scripts/run-launcher:
3146         * Scripts/run-webkit-tests:
3147         * Scripts/webkitdirs.pm:
3148
3149 2008-05-22  Stephanie Lewis  <slewis@apple.com>
3150
3151         Reviewed by Dan.
3152
3153         implement the beforeUnload UI delegate so that DRT will dispatch beforeunload events.
3154
3155         * DumpRenderTree/mac/UIDelegate.mm:
3156         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]):
3157         * DumpRenderTree/win/UIDelegate.cpp:
3158         (SearchableWebViewHost::runBeforeUnloadConfirmPanelWithMessage):
3159
3160 2008-05-21  Adele Peterson  <adele@apple.com>
3161
3162         Reviewed by Adam.
3163
3164         DumpRenderTree support for <rdar://problem/5787733> fast/dom/HTMLDocument/hasFocus.html fails on Windows
3165
3166         * DumpRenderTree/win/UIDelegate.cpp:
3167         (UIDelegate::webViewFocus): Added.
3168         (UIDelegate::webViewUnfocus): Added.
3169         * DumpRenderTree/win/UIDelegate.h:
3170
3171 2008-05-21  Mark Rowe  <mrowe@apple.com>
3172
3173         Rubber-stamped by Stephanie Lewis.
3174
3175         Set the pass_through flag on Getopt so that extra arguments can be passed through to Safari,
3176         rather than trigger an unknown argument message.  This allows run-webkit-tests to display results
3177         once more.
3178
3179         * Scripts/run-safari:
3180
3181 2008-05-21  Stephanie Lewis  <slewis@apple.com>
3182
3183         Reviewed by Maciej, Mark.
3184
3185         arch doesn't take arguments on tiger.  expand DRT timeout for guardMalloc.
3186
3187         * Scripts/run-webkit-tests:
3188         * Scripts/webkitdirs.pm:
3189
3190 2008-05-20  Mark Rowe  <mrowe@apple.com>
3191
3192         Reviewed by Stephanie Lewis.
3193
3194         Improve the behavior of run-webkit-tests with 64-bit WebKit by automatically inferring whether to run 64-bit.
3195
3196         If --64-bit is not passed to run-webkit-tests, attempt to guess whether we should run 64-bit.
3197         This decision is made based on the 64-bitness of the built WebKit framework if it exists, and
3198         can be manually overridden by passing --64-bit or --no-64-bit.  This removes the need to always
3199         pass an argument to run-webkit-tests after having built with "make x86_64".
3200
3201         * Scripts/gdb-safari:
3202         * Scripts/run-safari:
3203         * Scripts/run-webkit-tests:
3204         * Scripts/webkitdirs.pm: Split the setting of the 64-bit flag, the determination of the
3205         preferred architecture, and exporting of the environment variables for 'arch' out into
3206         separate subroutines.
3207
3208 2008-05-20  Mark Rowe  <mrowe@apple.com>
3209
3210         Fix "make x86_64" by adding x86_64 target to WebKitTools Makefile.
3211
3212         * Makefile:
3213
3214 === End merge of squirrelfish ===
3215
3216 2008-04-14  Maciej Stachowiak  <mjs@apple.com>
3217
3218         Reviewed by Oliver.
3219
3220         - added support for --ubench mode
3221
3222         * Scripts/run-sunspider:
3223
3224 2008-03-26  Geoffrey Garen  <ggaren@apple.com>
3225
3226         Reviewed by Oliver Hunt.
3227
3228         --squirrelfish mode: pared down tests for squirrelfish to chew on.
3229
3230         * Scripts/run-sunspider:
3231
3232 === Start merge of squirrelfish ===
3233
3234 2008-05-21  Darin Adler  <darin@apple.com>
3235
3236         * Scripts/make-js-test-wrappers: Added another exception.
3237
3238 2008-05-19  Stephanie Lewis  <slewis@apple.com>
3239
3240         Reviewed by Adam.
3241
3242         Explicitly set run mode to 32bit unless overridden to avoid
3243         confusion when running tests
3244
3245         * Scripts/build-dumprendertree:
3246         * Scripts/gdb-safari:
3247         * Scripts/run-webkit-tests:
3248         * Scripts/webkitdirs.pm:
3249
3250 2008-05-16  Stephanie Lewis  <slewis@apple.com>
3251
3252         Reviewed by Steve.
3253
3254         Print out pending unload event count. Also print out main frame name to match Mac.
3255
3256         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3257         (descriptionSuitableForTestResult):
3258         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
3259
3260 2008-05-16  Timothy Hatcher  <timothy@apple.com>
3261
3262         Remove the Drosera project, code and resources since it has been
3263         replaced with the Web Inspector's debugger. Removes references to
3264         Drosera in various scripts and makefiles.
3265
3266         Rubber-stamped by Mark Rowe.
3267
3268         * BuildSlaveSupport/build-launcher-app:
3269         * Drosera/DebuggerDocument.cpp: Removed.
3270         * Drosera/DebuggerDocument.h: Removed.
3271         * Drosera/Drosera.icns: Removed.
3272         * Drosera/DroseraWin.make: Removed.
3273         * Drosera/English.lproj/Debugger.nib/classes.nib: Removed.
3274         * Drosera/English.lproj/Debugger.nib/info.nib: Removed.
3275         * Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Removed.
3276         * Drosera/English.lproj/MainMenu.nib/classes.nib: Removed.
3277         * Drosera/English.lproj/MainMenu.nib/info.nib: Removed.
3278         * Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Removed.
3279         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
3280         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Removed.
3281         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
3282         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
3283         * Drosera/ForwardingHeaders/wtf/Platform.h: Removed.
3284         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Removed.
3285         * Drosera/Images/Drosera.ico: Removed.
3286         * Drosera/Images/SourceArrow.png: Removed.
3287         * Drosera/Images/SourceArrowBlank.png: Removed.
3288         * Drosera/Images/SourceArrowOpen.png: Removed.
3289         * Drosera/Images/background_stripe.png: Removed.
3290         * Drosera/Images/breakPoint.tif: Removed.
3291         * Drosera/Images/breakPointDisabled.tif: Removed.
3292         * Drosera/Images/breakpointeditor.png: Removed.
3293         * Drosera/Images/close.tif: Removed.
3294         * Drosera/Images/close_active.tif: Removed.
3295         * Drosera/Images/close_hover.tif: Removed.
3296         * Drosera/Images/console.png: Removed.
3297         * Drosera/Images/continue.tif: Removed.
3298         * Drosera/Images/fileIcon.jpg: Removed.
3299         * Drosera/Images/finishFunction.tif: Removed.
3300         * Drosera/Images/glossyFooterFill.tif: Removed.
3301         * Drosera/Images/glossyHeader.png: Removed.
3302         * Drosera/Images/glossyHeaderPressed.png: Removed.
3303         * Drosera/Images/gradientBackground.png: Removed.
3304         * Drosera/Images/gutter.png: Removed.
3305         * Drosera/Images/navLeftDisabled.png: Removed.
3306         * Drosera/Images/navLeftNormal.png: Removed.
3307         * Drosera/Images/navLeftPressed.png: Removed.
3308         * Drosera/Images/navRightDisabled.png: Removed.
3309         * Drosera/Images/navRightNormal.png: Removed.
3310         * Drosera/Images/navRightPressed.png: Removed.
3311         * Drosera/Images/pause.tif: Removed.
3312         * Drosera/Images/popUpArrows.png: Removed.
3313         * Drosera/Images/programCounter.tif: Removed.
3314         * Drosera/Images/programCounterBreakPoint.tif: Removed.
3315         * Drosera/Images/programCounterBreakPointDisabled.tif: Removed.
3316         * Drosera/Images/run.tif: Removed.
3317         * Drosera/Images/siteCollapsed.tif: Removed.
3318         * Drosera/Images/siteExpanded.tif: Removed.
3319         * Drosera/Images/siteIcon.tif: Removed.
3320         * Drosera/Images/small.ico: Removed.
3321         * Drosera/Images/splitterBar.tif: Removed.
3322         * Drosera/Images/splitterDimple.tif: Removed.
3323         * Drosera/Images/step.tif: Removed.
3324         * Drosera/Images/stepOut.tif: Removed.
3325         * Drosera/Images/stepOver.tif: Removed.
3326         * Drosera/Images/stop.tif: Removed.
3327         * Drosera/Images/toolbarBackground.png: Removed.
3328         * Drosera/Images/verticalSplitterBar.tiff: Removed.
3329         * Drosera/Images/verticalSplitterDimple.tiff: Removed.
3330         * Drosera/Makefile: Removed.
3331         * Drosera/breakpointEditor.html: Removed.
3332         * Drosera/config.h: Removed.
3333         * Drosera/console.css: Removed.
3334         * Drosera/console.html: Removed.
3335         * Drosera/console.js: Removed.
3336         * Drosera/debugger.css: Removed.
3337         * Drosera/debugger.html: Removed.
3338         * Drosera/debugger.js: Removed.
3339         * Drosera/mac/DebuggerApplication.h: Removed.
3340         * Drosera/mac/DebuggerApplication.mm: Removed.
3341         * Drosera/mac/DebuggerClient.h: Removed.
3342         * Drosera/mac/DebuggerClient.mm: Removed.
3343         * Drosera/mac/DebuggerDocumentPlatform.mm: Removed.
3344         * Drosera/mac/Drosera.xcodeproj/project.pbxproj: Removed.
3345         * Drosera/mac/Info.plist: Removed.
3346         * Drosera/mac/LauncherInfo.plist: Removed.
3347         * Drosera/mac/Makefile: Removed.
3348         * Drosera/mac/ServerConnection.h: Removed.
3349         * Drosera/mac/ServerConnection.mm: Removed.
3350         * Drosera/mac/launcher.m: Removed.
3351         * Drosera/mac/main.m: Removed.
3352         * Drosera/viewer.css: Removed.
3353         * Drosera/viewer.html: Removed.
3354         * Drosera/win/BaseDelegate.h: Removed.
3355         * Drosera/win/DebuggerClient.cpp: Removed.
3356         * Drosera/win/DebuggerClient.h: Removed.
3357         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3358         * Drosera/win/Drosera.cpp: Removed.
3359         * Drosera/win/Drosera.h: Removed.
3360         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed.
3361         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed.
3362         * Drosera/win/DroseraPrefix.cpp: Removed.
3363         * Drosera/win/DroseraPrefix.h: Removed.
3364         * Drosera/win/Info.plist: Removed.
3365         * Drosera/win/ServerConnection.cpp: Removed.
3366         * Drosera/win/ServerConnection.h: Removed.
3367         * Drosera/win/resource.h: Removed.
3368         * Makefile:
3369         * Scripts/build-drosera: Removed.
3370         * Scripts/gdb-drosera: Removed.
3371         * Scripts/run-drosera: Removed.
3372         * Scripts/run-drosera-nightly.cmd: Removed.
3373         * Scripts/run-drosera.cmd: Removed.
3374         * Scripts/webkitdirs.pm:
3375
3376 2008-05-15  Stephanie Lewis  <slewis@apple.com>
3377
3378         Reviewed by Anders.
3379
3380         Dump the unload count for a frame after parsing is finished.
3381
3382         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3383         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3384
3385 2008-05-15  Alexey Proskuryakov  <ap@webkit.org>
3386
3387         Reviewed by Dan Bernstein.
3388
3389         https://bugs.webkit.org/show_bug.cgi?id=10707
3390         DumpRenderTree should not be able to access non-local resources
3391
3392         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3393         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3394         Block them, and complain.
3395
3396 2008-05-15  Kevin Ollivier  <kevino@theolliviers.com>
3397
3398         wx build fix. Update the version of libpng to download and instsall.
3399
3400         * wx/install-unix-extras:
3401
3402 2008-05-14  Julien Chaffraix  <jchaffraix@webkit.org>
3403
3404         Reviewed by Eric.
3405
3406         - isDarwin() and isCygwin() returned an empty string if the platform equality check fails.
3407           We now force the return value to be numeric.
3408
3409         - Removed platform checks as it was a work around the previous issue.
3410
3411         - Replaced isDarwin() by isOSX() as they have now the same behaviour.
3412
3413         * Scripts/build-webkit:
3414         * Scripts/webkitdirs.pm:
3415
3416 2008-05-12  Adam Roben  <aroben@apple.com>
3417
3418         Support for testing NPN_PostURL
3419
3420         Reviewed by Anders Carlsson.
3421
3422         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3423         (toCString): Added this helper function.
3424         (testPostURLFile): Added. Writes the passed-in content to the
3425         passed-in file and calls NPN_PostURL with the passed-in URL and
3426         target.
3427         (pluginInvoke): Added a case for testPostURLFile.
3428         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3429         (followShortcuts): Changed to allow paths that don't yet exist.
3430
3431 2008-05-12  Mark Rowe  <mrowe@apple.com>
3432
3433         Reviewed by Sam Weinig.
3434
3435         Minor cleanup of the DRT Xcode project.
3436
3437         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Use GCC_OPTIMIZATION_LEVEL rather than
3438         OPTIMIZATION_CFLAGS.  Don't include Info.plist in the "Copy Bundle Resources" build phase as it does
3439         not need to be there.
3440
3441 2008-05-12  Anders Carlsson  <andersca@apple.com>
3442
3443         Reviewed by Adam.
3444
3445         Add support for testing application caches.
3446
3447         * DumpRenderTree/mac/DumpRenderTree.mm:
3448         (dumpRenderTree):
3449         Empty the cache.
3450
3451         (resetWebViewToConsistentStateBeforeTesting):
3452         Turn on support for the application cache.
3453
3454 2008-05-09  Mark Rowe  <mrowe@apple.com>
3455
3456         Reviewed by Anders Carlsson.
3457
3458         Update TestNetscapePlugIn to build 64-bit using the Cocoa event model.
3459
3460         It currently does not attempt to print events which means that plugins/mouse-events.html
3461         will fail when run 64-bit.  All other tests that use this plugin pass.
3462
3463         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3464         (testGetIntIdentifier):
3465         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3466         (NPP_New):
3467         (NPP_HandleEvent):
3468
3469 2008-05-09  Brady Eidson  <beidson@apple.com>
3470
3471         Reviewed by Adam Roben
3472
3473         Explicitly call shutDownWebKit() before quitting.
3474
3475         * Drosera/win/Drosera.cpp:
3476         (_tWinMain):
3477
3478         * DumpRenderTree/win/DumpRenderTree.cpp:
3479         (main):
3480
3481 2008-05-09  Mark Rowe  <mrowe@apple.com>
3482
3483         Fix the Tiger build of Drosera.
3484
3485         * Drosera/config.h: Define BUILDING_ON_TIGER when building on Tiger.
3486
3487 2008-05-09  Sam Weinig  <sam@webkit.org>
3488
3489         Rubber-stamped by Mark Rowe.
3490
3491         Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.
3492
3493         * Scripts/build-webkit:
3494
3495 2008-05-08  Mark Rowe  <mrowe@apple.com>
3496
3497         Another attempt at a Tiger build fix.
3498
3499         Use DumpRenderTreeMac.h rather than DumpRenderTree.h as DumpRenderTreePasteboard is not an Obj-C++ file.
3500
3501         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3502
3503 2008-05-08  Mark Rowe  <mrowe@apple.com>
3504
3505         Tiger build fix.  Include DumpRenderTree.h so that BUILDING_ON_TIGER will be defined.
3506
3507         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3508
3509 2008-05-08  Mark Rowe  <mrowe@apple.com>
3510
3511         Reviewed by Oliver Hunt and Dan Bernstein.
3512
3513         Update DumpRenderTree to build 64-bit.
3514
3515         The three major changes here are:
3516         1) Use NSInteger in the appropriate places.
3517         2) Use ColorSync API that is available in 64-bit to switch display profiles.
3518         3) Use method-swizzling to achieve similar results to class posing when using the Obj-C 2.0 runtime.
3519
3520         The build of DumpRenderTree will still fail in 64-bit for now as the TestNetscapePlugIn target also
3521         needs updated to successfully build.
3522
3523         * DumpRenderTree/mac/Configurations/Base.xcconfig: Don't prevent Xcode from building 64-bit.
3524         * DumpRenderTree/mac/DumpRenderTree.mm:
3525         (swizzleAllMethods):
3526         (poseAsClass):
3527         (prepareConsistentTestingEnvironment):
3528         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3529         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3530         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3531         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3532         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3533         (restoreColorSpace):
3534         (failedGettingCurrentProfile):
3535         (setDefaultColorProfileToRGB):
3536
3537 2008-05-08  Mark Rowe  <mrowe@apple.com>
3538
3539         Reviewed by Darin Adler.
3540
3541         Clean up Drosera so that it will build 64-bit.
3542
3543         * Drosera/mac/DebuggerApplication.mm:
3544         (-[DebuggerApplication numberOfRowsInTableView:]): Use NSInteger rather than int.
3545         (-[DebuggerApplication tableView:objectValueForTableColumn:row:]): Ditto.
3546         * Drosera/mac/Drosera.xcodeproj/project.pbxproj: Use the default value for VALID_ARCHS.
3547
3548 2008-05-07  David Kilzer  <ddkilzer@apple.com>
3549
3550         Use File::Find and Getopt::Long in make-js-test-wrappers
3551
3552         Reviewed by Darin Adler.
3553
3554         * Scripts/make-js-test-wrappers:
3555         - Updated Apple copyright statement.
3556         - Added command-line switch parsing and -h|--help switch.
3557         - Allowed user to pass list of files/directories on which to do
3558           a restricted search for TEMPLATE.html files.  The default
3559           behavior is still to search the entire LayoutTests directory.
3560         - Removed duplicate 'use strict' statement.
3561         - Replaced use of `find` statements with File::Find::find().
3562         - Remove unneeded chomp() calls now that we use File::Find.
3563         (directoryFilter): Added.  Filters .svn directories when used
3564         with File::Find::find().
3565         (findTemplateFiles): Added.  Returns a list of TEMPLATE.html
3566         files found.
3567
3568 2008-05-05  Steve Falkenburg  <sfalken@apple.com>
3569
3570         Copy dependencies of ImageDiff, DumpRenderTree in post-build step.
3571
3572         * DumpRenderTree/win/DumpRenderTree.vcproj:
3573         * DumpRenderTree/win/ImageDiff.vcproj:
3574
3575 2008-05-05  Adele Peterson  <adele@apple.com>
3576
3577         Reviewed by Adam.
3578
3579         Look for the right ImageDiff executable for debug builds.
3580
3581         * Scripts/run-webkit-tests:
3582
3583 2008-05-05  Darin Adler  <darin@apple.com>
3584
3585         * Scripts/run-webkit-tests: Ignore a Java leak showing up in the WebKit
3586         leak tests.
3587
3588 2008-05-05  Ariya Hidayat  <ariya.hidayat@trolltech.com>
3589
3590         Reviewed by Simon.
3591
3592         In the Qt's DumpRenderTree, adjust the web view properly (because W3C SVG
3593         tests expect to be 480x360)
3594
3595         * DumpRenderTree/qt/DumpRenderTree.cpp:
3596         (WebCore::DumpRenderTree::open):
3597
3598 2008-05-02  Dan Bernstein  <mitz@apple.com>
3599
3600         Reviewed by Adam Roben.
3601
3602         - add an option to svn-apply to set the reviewer name in change logs
3603
3604         * Scripts/svn-apply: Added a [-r|--reviewer name] option.
3605
3606 2008-05-01  David Kilzer  <ddkilzer@apple.com>
3607
3608         Clean up configuration usage in run-webkit-tests
3609
3610         Reviewed by Adam.
3611
3612         * Scripts/run-webkit-tests: Parse configuration switches using
3613         passedConfiguration() from webkitdirs.pm like every other script.
3614         Note that we must still call setConfiguration() afterwards in
3615         case the --configuration switch was used.  Use $configurationOption
3616         when running build-dumprendertree instead of recreating the switch.
3617
3618 2008-04-29  Adam Roben  <aroben@apple.com>
3619
3620         Restore the beloved COMPtr::operator&
3621
3622 2008-04-29  Adam Roben  <aroben@apple.com>
3623
3624         Windows build fixes
3625
3626         Replace COMPtr::operator& with COMPtr::adoptionPointer.
3627
3628 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
3629
3630         Reviewed by Darin Adler.
3631
3632         Fix run-webkit-tests --threading
3633         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
3634         Proxy server issue in Sunday's Nightly
3635
3636         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
3637         (runJavaScriptThread):
3638         (startJavaScriptThreads):
3639         (stopJavaScriptThreads):
3640         Spawned threads were immediately detached, unlike the original ones, so joining them
3641         made no sense. Now, all threads are created detached, and stopJavaScriptThreads() just
3642         waits for them all to exit.
3643
3644 2008-04-28  Holger Hans Peter Freyther  <zecke@selfish.org>
3645
3646         Reviewed by Simon.
3647
3648         Reset dumping resource load callbacks to false for the next test
3649
3650
3651         * DumpRenderTree/qt/jsobjects.cpp:
3652         (LayoutTestController::reset):
3653
3654 2008-04-28  Tor Arne Vestbø  <tavestbo@trolltech.com>
3655
3656         Reviewed by Simon.
3657
3658         Adapt to the latest API changes in WebKit/qt/Api.
3659
3660         * DumpRenderTree/qt/DumpRenderTree.cpp:
3661         (WebCore::DumpRenderTree::DumpRenderTree):
3662         * DumpRenderTree/qt/jsobjects.cpp:
3663
3664 2008-04-26  Robin Dunn  <robin@alldunn.com>
3665
3666         Reviewed by Kevin Ollivier.
3667
3668         Delete the DerivedSources after make clean has been done so that the DerivedSources
3669         don't get re-created. Also, use the proper extension for the Win wxPython extension.
3670
3671         https://bugs.webkit.org/show_bug.cgi?id=18756
3672
3673         * wx/build-wxwebkit:
3674
3675 2008-04-26  Adam Barth <hk9565@gmail.com>
3676
3677         Reviewed by Adam Roben and Sam Weinig.
3678
3679         Updates LayoutTestController to use host instead of domain.
3680
3681         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
3682
3683         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3684         (LayoutTestController::setDatabaseQuota):
3685         * DumpRenderTree/mac/UIDelegate.mm:
3686         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
3687
3688 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
3689
3690         wx build fix. Need the latest libpng. (Somehow my initial test passed without it.)
3691
3692         * wx/install-unix-extras:
3693
3694 2008-04-26  Robin Dunn  <robin@alldunn.com>
3695
3696         Reviewed by Kevin Ollivier.
3697
3698         Allow the user to set the path to SWIG using an environment variable.
3699
3700         https://bugs.webkit.org/show_bug.cgi?id=18660
3701
3702         * wx/build-wxwebkit:
3703
3704 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
3705
3706         wx build fix. Download the latest libpng version for building the
3707         dependencies.
3708
3709         * wx/install-unix-extras:
3710
3711 2008-04-25  Holger Hans Peter Freyther  <zecke@selfish.org>
3712
3713         Reviewed by Simon.
3714
3715         Implement dumping of resource load callbacks to pass http/tests/xmlhttprequest/abort-should-cancel-load.html
3716
3717         Similar to Editing and Frameloading we do the dumping within WebCore
3718
3719
3720         * DumpRenderTree/qt/jsobjects.cpp:
3721         (LayoutTestController::dumpResourceLoadCallbacks):
3722         * DumpRenderTree/qt/jsobjects.h:
3723
3724 2008-04-24  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
3725
3726         Reviewed by Maciej Stachowiak.
3727
3728         http://bugs.webkit.org/show_bug.cgi?id=18485
3729         Typo and documentation fix for build-webkit
3730
3731         * Scripts/build-webkit:
3732
3733 2008-04-24  Anders Carlsson  <andersca@apple.com>
3734
3735         Reviewed by Sam.
3736
3737         Don't call fprintf from the signal handler.
3738
3739         * DumpRenderTree/mac/DumpRenderTree.mm:
3740         (crashHandler):
3741
3742 2008-04-23  Adam Roben  <aroben@apple.com>
3743
3744         Make crashes be reported as crashes, not hangs
3745
3746         Reviewed by David Kilzer.
3747
3748         * Scripts/run-webkit-tests:
3749         (top level): Use the new status field of the output from
3750         readFromDumpToolWithTimer to determine if the test crashed or hung.
3751         (sub readFromDumpToolWithTimer):
3752           - If we fail to read a line and $! is not EAGAIN, then we've crashed
3753             and should not try to read any more.
3754           - Changed the timedout field to a more general status field.
3755
3756 2008-04-22  David Kilzer  <ddkilzer@apple.com>
3757
3758         Bug 18683: update-webkit returns 0 even if it fails
3759
3760         <https://bugs.webkit.org/show_bug.cgi?id=18683>
3761
3762         Reviewed by Mitz Pettel.
3763
3764         * Scripts/update-webkit:
3765         (runSvnUpdate): Die if close() fails.
3766
3767 2008-04-21  Adam Roben  <aroben@apple.com>
3768
3769         Flush stdout/stderr after printing every #EOF separator
3770
3771         This fixes a hang when running the pixel tests on Windows
3772
3773         Reviewed by Mitz Pettel.
3774
3775         * DumpRenderTree/win/DumpRenderTree.cpp:
3776         (dump):
3777         (main): We don't have to flush stdout/stderr in the arguments loop
3778         anymore, as runTest flushes for us.
3779
3780 2008-04-21  Adam Roben  <aroben@apple.com>
3781
3782         Fix pixel tests
3783
3784         * Scripts/run-webkit-tests:
3785         (sub readFromDumpToolWithTimer): Use readline instead of read to
3786         ensure that we don't read past the #EOF marker.
3787
3788 2008-04-21  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
3789
3790         Reviewed by Simon.
3791
3792         Build fix for Qt 4.3
3793
3794         * When building WebCore/internal make sure the QT_[BEGIN,END]_NAMESPACE is
3795         always defined. Do this by adding defines to the compiler line
3796
3797         * DumpRenderTree/qt/DumpRenderTree.pro:
3798
3799 2008-04-19  Mike Hommey  <glandium@debian.org>
3800
3801         Reviewed by Alp Toker.
3802
3803         Don't build GtkLauncher and DumpRenderTree with rpath.
3804
3805         * GNUmakefile.am:
3806
3807 2008-04-18  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
3808
3809         Reviewed by Alp Toker.
3810
3811         http://bugs.webkit.org/show_bug.cgi?id=16620
3812         [GTK] Autotools make dist and make check support
3813
3814         Cleanups.
3815
3816         * GNUmakefile.am:
3817
3818 2008-04-18  Adam Roben  <aroben@apple.com>
3819
3820         Drop the hang timer to 30 seconds
3821
3822         This matches what DRT/mac was using.
3823
3824         Reviewed by Mitz Pettel.
3825
3826         * Scripts/run-webkit-tests:
3827
3828 2008-04-18  Adam Roben  <aroben@apple.com>
3829
3830         Get rid of DRT's Watchdog
3831
3832         run-webkit-tests now detects hangs and samples DRT as needed.
3833
3834         Reviewed by Mitz Pettel.
3835
3836         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Removed
3837         Watchdog* files from the project.
3838         * DumpRenderTree/Watchdog.cpp: Removed.
3839         * DumpRenderTree/Watchdog.h: Removed.
3840         * DumpRenderTree/mac/DumpRenderTree.mm: Removed uses of Watchdog
3841         (dumpRenderTree):
3842         (runTest):
3843         * DumpRenderTree/mac/WatchdogMac.h: Removed.
3844         * DumpRenderTree/mac/WatchdogMac.mm: Removed.
3845         * Scripts/run-webkit-tests:
3846         (sub testCrashedOrTimedOut): Call sampleDumpTool() if we timed out.
3847         (sub sampleDumpTool): Added. Writes a sample report to
3848         ~/Library/Logs/DumpRenderTree/HangReport.txt.
3849
3850 2008-04-18  Simon Hausmann  <hausmann@webkit.org>
3851
3852         Reviewed by Holger.
3853
3854         Adapt to the API changes in WebKit/qt
3855
3856         * DumpRenderTree/qt/DumpRenderTree.cpp:
3857         (WebCore::WebPage::WebPage):
3858         (WebCore::DumpRenderTree::DumpRenderTree):
3859         (WebCore::DumpRenderTree::initJSObjects):
3860         (WebCore::DumpRenderTree::dumpFramesAsText):
3861         (WebCore::DumpRenderTree::dump):
3862
3863 2008-04-17  Adam Roben  <aroben@apple.com>
3864
3865         Fix many tests on Windows
3866
3867         * Scripts/run-webkit-tests:
3868         (readFromDumpToolWithTimer):
3869          - Use read instead of sysread to ensure that we don't interfere with
3870            other uses of buffered IO in this script.
3871         (setFileHandleNonBlocking): Actually set the filehandle to blocking
3872         when specified.
3873
3874 2008-04-17  Adam Roben  <aroben@apple.com>
3875
3876         Fix ~10 tests
3877
3878         * Scripts/run-webkit-tests: Only remove the newline after #EOF, not
3879         whatever newline happens to be at the end of what we've read.
3880
3881 2008-04-17  Adam Roben  <aroben@apple.com>
3882
3883         Remove DRT/win's hang timer
3884
3885         run-webkit-tests takes care of this for us now
3886
3887         Reviewed by Anders Carlsson.
3888
3889         * DumpRenderTree/win/DumpRenderTree.cpp:
3890
3891 2008-04-17  Adam Roben  <aroben@apple.com>
3892
3893         Don't wait for the hang timer twice in the case of a hang
3894
3895         Previously we'd wait for a hang while reading both stdout and stderr
3896         from DRT. Now we'll only wait for one or the other.
3897
3898         Reviewed by Anders Carlsson.
3899
3900         * Scripts/run-webkit-tests:
3901         (top level): Don't wait for stderr to time out if stdout already timed
3902         out.
3903         (readFromDumpToolWithTimer): If $dontWaitForTimeOut is true, quit
3904         after the first read that returns no data.
3905
3906 2008-04-17  Adam Roben  <aroben@apple.com>
3907
3908         Don't throw away the output from timed out tests
3909
3910         Reviewed by Anders Carlsson.
3911
3912         * Scripts/run-webkit-tests:
3913         (top level): Updated for changes to readFromDumpToolWithTimer.
3914         (readFromDumpToolWithTimer): Return a hash that contains both the
3915         output and whether or not the test timed out.
3916
3917 2008-04-17  Adam Roben  <aroben@apple.com>
3918
3919         Make the hang timer 60 seconds
3920
3921         * Scripts/run-webkit-tests:
3922
3923 2008-04-17  Adam Roben  <aroben@apple.com>
3924
3925         Get rid of carriage returns in DRT/win's stderr
3926
3927         Reviewed by Eric Seidel.
3928
3929         * DumpRenderTree/win/DumpRenderTree.cpp:
3930         (main): Mark stderr as binary like we already do for stdout.
3931
3932 2008-04-17  Adam Roben  <aroben@apple.com>
3933
3934         Fix Bug 17678: run-webkit-tests should have a watchdog timer (and
3935         timeout long tests)
3936
3937         <https://bugs.webkit.org/show_bug.cgi?id=17678>
3938
3939         We now abort tests that take longer than 60 seconds to produce output.
3940         This matches the watchdog timer in DRT/mac and DRT/win (which we can
3941         now remove).
3942
3943         Reviewed by Eric Seidel.
3944
3945         * Scripts/run-webkit-tests:
3946         (top level): Read DRT's output using the new readFromDumpToolWithTimer
3947         subroutine. If readFromDumpToolWithTimer returns undefined it means
3948         the test timed out, so we register the test as a hang and move on.
3949         (sub testCrashedOrTimedOut): Renamed from testCrashed. Now handles
3950         both crashed and timed out tests. If the test timed out, we kill DRT
3951         before returning.
3952         (sub linksForTimedOutTest): Added. We don't have any output to link to for
3953         tests that timed out.
3954         (sub recordActualResultsAndDiff): Don't call length on undefined.
3955         (sub readFromDumpToolWithTimer): Added. Performs non-blocking reads
3956         from a filehandle until an #EOF is reached or
3957         $maximumSecondsWithoutOutput have elapsed.
3958         (sub setFileHandleNonBlocking): Marks a filehandle as blocking or
3959         non-blocking.
3960
3961 2008-04-17  Adam Roben  <aroben@apple.com>
3962
3963         Refactor test results page generation
3964
3965         Reviewed by Eric Seidel.
3966
3967         * Scripts/run-webkit-tests:
3968         (sub htmlForResultsSection): Added. Takes a set of tests, a
3969         description, and a subroutine to generate the links for each test, and
3970         creates a HTML string containing a table of the tests and their
3971         links.
3972         (sub linksForExpectedAndActualResults): Added. Replaces the
3973         htmlForExpectedAndActualResults subroutine.
3974         (sub linksForMismatchTest): Added.
3975         (sub linksForCrashOrErrorTest): Added.
3976         (sub linksForNewTest): Added.
3977
3978 2008-04-17  Adam Roben  <aroben@apple.com>
3979
3980         Print the extension for all tests in the test results page
3981
3982         Reviewed by Eric Seidel.
3983
3984         * Scripts/run-webkit-tests:
3985
3986 2008-04-17  Adam Roben  <aroben@apple.com>
3987
3988         Move code that counts finished tests into a subroutine
3989
3990         Reviewed by Eric Seidel.
3991
3992         * Scripts/run-webkit-tests:
3993         (sub countFinishedTest): Added.
3994
3995 2008-04-17  Adam Roben  <aroben@apple.com>
3996
3997         Move code that handles a crash into a subroutine
3998
3999         Reviewed by Eric Seidel.
4000
4001         * Scripts/run-webkit-tests:
4002         (sub testCrashed): Added.
4003
4004 2008-04-17  Eric Seidel  <eric@webkit.org>
4005
4006         Reviewed by hyatt.
4007
4008         Rename RenderView to RenderViewport in the next rename patch.
4009
4010         * Scripts/do-webcore-rename:
4011
4012 2008-04-17  Mario Bensi  <mbensi@pleyo.com>
4013
4014         Reviewed by Alp Toker.
4015
4016         http://bugs.webkit.org/show_bug.cgi?id=18543
4017         DumpRenderTree gtk freeze
4018
4019         fix DumpRenderTree gtk freeze
4020
4021         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4022         (dump):
4023
4024 2008-04-15  Anders Carlsson  <andersca@apple.com>
4025
4026         Add missing ;
4027
4028         * Scripts/build-webkit:
4029
4030 2008-04-15  Anders Carlsson  <andersca@apple.com>
4031
4032         Reviewed by Adam.
4033
4034         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
4035
4036         * Scripts/build-webkit:
4037
4038 2008-04-15  Andre Poenitz  <andre.poenitz@trolltech.com>
4039
4040         Reviewed by Simon.
4041
4042         Fix compilation with Qt namespaces
4043
4044         Qt can be configured to have all of its classes inside a specified namespaces.
4045         This is for example used in plugin/component environments like Eclipse.
4046
4047         This change makes it possible to let the Qt port compile against a namespaced
4048         Qt by the use of macros Qt provides to properly forward declare Qt classes in
4049         the namespace.
4050
4051         * DumpRenderTree/qt/DumpRenderTree.h:
4052
4053 2008-04-08  Kevin Ollivier  <kevino@theolliviers.com>
4054
4055         Reviewed by Darin Adler.
4056
4057         Add a script that propagates any file changes made to the Bakefiles
4058         over to GTK and Qt build systems. Still needs to be wired into
4059         those ports though.
4060
4061         * Scripts/update-sources-list.py: Added.
4062
4063 2008-04-08  Mark Rowe  <mrowe@apple.com>
4064
4065         Clean up after Brady.
4066
4067         * DumpRenderTree/mac/DumpRenderTree.mm: Add an include so that NSInteger can be found.
4068
4069 2008-04-08  Brady Eidson  <beidson@apple.com>
4070
4071         Reviewed by Mitzpettel
4072
4073         Fixed http://bugs.webkit.org/show_bug.cgi?id=18302
4074         -WebArchive subresources dump in random order, intermittent failures
4075
4076         * DumpRenderTree/mac/DumpRenderTree.mm:
4077         (compareResourceURLs): Sorting function based on the resource URLs
4078         (serializeWebArchiveToXML): Sort the subresource array
4079
4080 2008-04-07  Brady Eidson  <beidson@apple.com>
4081
4082         OMG, BUILD - please!
4083
4084         * Scripts/build-webkit:
4085
4086 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
4087
4088         Reviewed by Simon.
4089
4090         * Enable running http tests for Qt again. Failing tests can be put into the skipped list.
4091         * Running these tests on windows and other platforms might need some work.
4092
4093         * Scripts/run-webkit-tests:
4094
4095 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
4096
4097         Reviewed by Simon.
4098
4099         * For the http tests we need the output of the FrameLoaderClient. The QtWebKit API
4100         is not exporting enough to create the output in DRT itself. Settle with the approach
4101         Lars has taken for the Editing support and add branches to our FrameLoaderClient code.
4102         * run-webkit-tests http/tests(/loading) can now be executed.
4103         * For tests in loading/ directories we are going to throw away the dirty
4104         QWebPage to start with something clean.
4105
4106
4107         * DumpRenderTree/qt/DumpRenderTree.cpp:
4108
4109 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
4110
4111         Reviewed by Simon.
4112
4113         * Treat http and https as special URLs as well. Change the main.cpp and
4114         DumpRenderTree.cpp to handle http and https URIs as input.
4115         * I'm not doing the clean up and merging of these two checks now.
4116
4117
4118         * DumpRenderTree/qt/DumpRenderTree.cpp:
4119         (WebCore::DumpRenderTree::readStdin):
4120         * DumpRenderTree/qt/main.cpp:
4121         (main):
4122
4123 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
4124
4125         Reviewed by Simon.
4126
4127         * Remove dumpFrameLoadCallbacks from simple-subframe.html because it is
4128         located in a directory with the name "loading". And this will autoamtically
4129         enable dumping.
4130         * Remove this method from the LayoutTestController as it is unused now and this
4131         avoids adding it to the DRT of the Qt port.
4132
4133
4134         * DumpRenderTree/LayoutTestController.cpp:
4135         (setPrivateBrowsingEnabledCallback):
4136
4137 2008-04-01  Christian Dywan  <christian@imendio.com>
4138
4139         Build fix for GCC 4.3.
4140
4141         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: include string.h
4142
4143 2008-04-01  Simon Hausmann  <hausmann@webkit.org>
4144
4145         Reviewed by Holger.
4146
4147         Fix Qt DRT run by also printing EOF on stderr, as expected by
4148         run-webkit-tests.
4149
4150         * DumpRenderTree/qt/DumpRenderTree.cpp:
4151         (WebCore::DumpRenderTree::dump):
4152
4153 2008-03-31  Julien Chaffraix  <julien.chaffraix@gmail.com>
4154
4155         Reviewed by Darin Adler.
4156
4157         Bug 17665: determineSourceDir() dies if $sourceDir has a trailing backslash
4158
4159         Remove trailing '/' in $sourceDir in determineSourceDir().
4160
4161         Fix suggested by Dmitriy Kazachkov.
4162
4163         * Scripts/webkitdirs.pm:
4164
4165 2008-03-29  Adam Roben  <aroben@apple.com>
4166
4167         Update for rename of an IWebViewPrivate method
4168
4169         Reviewed by Mitz Pettel.
4170
4171         * DumpRenderTree/win/DumpRenderTree.cpp:
4172         (createWebViewAndOffscreenWindow):
4173
4174 2008-03-26  Antti Koivisto  <antti@apple.com>
4175
4176         Reviewed by Anders.
4177
4178         Enable SVG animation support by default.
4179
4180         * Scripts/build-webkit:
4181
4182 2008-03-25  Adam Roben  <aroben@apple.com>
4183
4184         Windows build fix
4185
4186         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
4187         Add $(WebKitLibrariesDir)\include to the include path so we can find
4188         stdint.h there.
4189
4190 2008-03-24  Eric Seidel  <eric@webkit.org>
4191
4192         Reviewed by Mark.
4193
4194         Clean up SVG features message to be less confusing.
4195
4196         * Scripts/build-webkit:
4197
4198 2008-03-24  Sam Weinig  <sam@webkit.org>
4199
4200         Reviewed by Dave Hyatt.
4201
4202         Add EventSender.zoomPageIn/zoomPageOut support to DRT.
4203
4204         * DumpRenderTree/mac/DumpRenderTree.mm:
4205         (resetWebViewToConsistentStateBeforeTesting):
4206         * DumpRenderTree/mac/EventSendingController.mm:
4207         (+[EventSendingController isSelectorExcludedFromWebScript:]):
4208         (-[EventSendingController zoomPageIn]):
4209         (-[EventSendingController zoomPageOut]):
4210         * DumpRenderTree/win/DumpRenderTree.cpp:
4211         (resetWebViewToConsistentStateBeforeTesting):
4212         * DumpRenderTree/win/EventSender.cpp:
4213         (textZoomInCallback):
4214         (textZoomOutCallback):
4215         (zoomPageInCallback):
4216         (zoomPageOutCallback):
4217
4218 2008-03-24  Dan Bernstein  <mitz@apple.com>
4219
4220         Reviewed by Mark Rowe.
4221
4222         - update bisect-builds for Safari 3.1
4223
4224         * Scripts/bisect-builds: Added Safari 3.1 and the corresponding minimal
4225         revision, r29711.
4226
4227 2008-03-21  Rodney Dawes  <dobey@wayofthemonkey.com>
4228
4229         Reviewed by Holger.
4230
4231         http://bugs.webkit.org/show_bug.cgi?id=17981
4232
4233         Add webcore and javascriptcore cppflags to programs' _CPPFLAGS.
4234
4235         * GNUmakefile.am:
4236
4237 2008-03-21  Adam Roben  <aroben@apple.com>
4238
4239         Remove a non-working mirror from cygwin-downloader and add the ruby package
4240
4241         * CygwinDownloader/cygwin-downloader.py:
4242         * CygwinDownloader/cygwin-downloader.zip: Updated.
4243
4244 2008-03-20  Mark Rowe  <mrowe@apple.com>
4245
4246         Reviewed by Sam Weinig.
4247
4248         Ensure that the defines generated for FEATURE_DEFINES are sorted so that they will match the default settings of each project.
4249         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
4250         command-line.
4251
4252         * Scripts/build-webkit:
4253
4254 2008-03-17  Eric Seidel  <eric@webkit.org>
4255
4256         Reviewed by Dan Bernstein.
4257
4258         Fix bogus argCount check breaking plugin test.
4259
4260         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
4261
4262 2008-03-17  Eric Seidel  <eric@webkit.org>
4263
4264         Reviewed by darin.
4265
4266         Cleanup PluginObject.cpp and add support for testing
4267         converting from int -> identifier -> string
4268         and from string -> identifier -> int
4269         as well as round-tripping ints and stings through identifiers
4270
4271         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
4272         (pluginGetProperty):
4273         (pluginSetProperty):
4274         (testDOMAccess):
4275         (stringVariantToIdentifier):
4276         (int32VariantToIdentifier):
4277         (doubleVariantToIdentifier):
4278         (variantToIdentifier):
4279         (testIdentifierToString):
4280         (testIdentifierToInt):
4281         (testCallback):
4282         (getURL):
4283         (removeDefaultMethod):
4284         (getURLNotify):
4285         (testInvokeDefault):
4286         (destroyStream):
4287         (testEnumerate):
4288         (testGetIntIdentifier):
4289         (testGetProperty):
4290         (testEvaluate):
4291         (testGetPropertyReturnValue):
4292         (pluginInvoke):
4293         (pluginInvokeDefault):
4294         (pluginInvalidate):
4295         (pluginAllocate):
4296         (pluginDeallocate):
4297         (handleCallback):
4298
4299 2008-03-16  Kevin Ollivier  <kevino@theolliviers.com>
4300
4301         Rubber stamped by Darin Adler.
4302
4303         Add set-webkit-configuration support for wx port, and centralize
4304         build dir location setting.
4305
4306         http://bugs.webkit.org/show_bug.cgi?id=17790
4307
4308         * wx/browser/browser.bkl:
4309         * wx/build-wxwebkit:
4310
4311 2008-03-15  Darin Adler  <darin@apple.com>
4312
4313         * Scripts/commit-log-editor: Include the name line of the change log entry.
4314         A long time ago I designed this script to not include the name because I
4315         thought it was redundant (same as the name of the person checking in), but
4316         nowadays it's more common for someone to check something in done by someone
4317         else.
4318
4319         * Scripts/do-webcore-rename: Added some&nbs