[Qt] Build files for the WTR's InjectedBundle
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
2
3         Reviewed by Kenneth Rohde Christiansen.
4
5         [Qt] Add WTR's InjectedBundle build files.
6         https://bugs.webkit.org/show_bug.cgi?id=47333
7
8         * Scripts/webkitdirs.pm:
9         * WebKitTestRunner/DerivedSources.pro: Added.
10         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
11         * WebKitTestRunner/WebKitTestRunner.pro: Added.
12         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
13         Content merged in ../DerivedSources.pro
14
15 2010-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
16
17         Unreviewed, rolling out r69315.
18         http://trac.webkit.org/changeset/69315
19         https://bugs.webkit.org/show_bug.cgi?id=47363
20
21         Forgot to add the new files (Requested by kbalazs on #webkit).
22
23         * Scripts/webkitdirs.pm:
24         * WebKitTestRunner/qt/DerivedSources.pro: Added.
25
26 2010-10-07  Sam Weinig  <sam@webkit.org>
27
28         Reviewed by Anders Carlsson.
29
30         Change API tester to ask the executable for the list of all
31         tests instead of relying on the directory structure.
32         https://bugs.webkit.org/show_bug.cgi?id=47359
33
34         * Scripts/run-test-webkit-api: Added.
35         * Scripts/webkitdirs.pm:
36         Add additional script to just launch the api tester with the correct settings.
37
38         * Scripts/run-api-tests:
39         Change to use the new --dump-tests options to build the list of tests and change
40         output to reflect a (suite, testcase) tuple for each test. Also adds some color.
41
42         * TestWebKitAPI/Test.h:
43         (TestWebKitAPI::Test::Register::Register):
44         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
45         (TestWebKitAPI::TEST):
46         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
47         (TestWebKitAPI::TEST):
48         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
49         (TestWebKitAPI::TEST):
50         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
51         (TestWebKitAPI::TEST):
52         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
53         (TestWebKitAPI::TEST):
54         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
55         (TestWebKitAPI::TEST):
56         Give each test a suite name in addition to the test name.
57
58         * TestWebKitAPI/TestsController.cpp:
59         (TestWebKitAPI::TestsController::dumpTestNames):
60         (TestWebKitAPI::TestsController::runTestNamed):
61         * TestWebKitAPI/TestsController.h:
62         * TestWebKitAPI/mac/main.mm:
63         (main):
64         Add option to print all registered tests.
65
66 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
67
68         Reviewed by Kenneth Rohde Christiansen.
69
70         [Qt] Add WTR's InjectedBundle build files.
71         https://bugs.webkit.org/show_bug.cgi?id=47333
72
73         * Scripts/webkitdirs.pm:
74         * WebKitTestRunner/DerivedSources.pro: Added.
75         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
76         * WebKitTestRunner/WebKitTestRunner.pro: Added.
77         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
78         Content merged in ../DerivedSources.pro
79
80 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
81
82         Unreviewed. Do a renaming that was recommended by the reviewer
83         (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
84
85         * WebKitTestRunner/qt/TestControllerQt.cpp:
86         (WTR::RunUntilConditionLoop::start):
87         (WTR::RunUntilConditionLoop::RunUntilConditionLoop):
88         (WTR::TestController::runUntil):
89
90 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
91
92         Reviewed by Kenneth Rohde Christiansen.
93
94         [Qt] Watchdog timer implementation for WTR
95         https://bugs.webkit.org/show_bug.cgi?id=47337
96
97         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
98         the definition of the timer type to a typedef.
99         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
100         Timer implementation with QTimer and a helper QObject class.
101         (WTR::WatchdogTimerHelper::instance):
102         (WTR::WatchdogTimerHelper::timerFired):
103         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
104         (WTR::LayoutTestController::platformInitialize):
105         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
106         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
107
108 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
109
110         Unreviewed buildfix for 69297 again
111
112         * WebKitTestRunner/TestController.cpp:
113         (WTR::blankURL):
114
115 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
116
117         Unreviewed trivial build fix for r69297
118
119         * WebKitTestRunner/TestController.cpp:
120         (WTR::blankURL):
121
122 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
123
124         Reviewed by Kenneth Rohde Christiansen.
125
126         WebKitTestRunner should be portable
127         https://bugs.webkit.org/show_bug.cgi?id=45393
128
129         Use only the WebKit API for working with urls.
130         * WebKitTestRunner/StringFunctions.h:
131         (WTR::createWKURL):
132         * WebKitTestRunner/TestController.cpp:
133         (WTR::blankURL):
134         (WTR::TestController::resetStateToConsistentValues):
135         (WTR::TestController::didFinishLoadForFrame):
136
137 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
138
139         Reviewed by Xan Lopez.
140
141         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
142         https://bugs.webkit.org/show_bug.cgi?id=47332
143
144         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
145         (createBitmapContextFromWebView):
146
147 2010-10-06  Chris Guillory  <chris.guillory@google.com>
148
149         Reviewed by Chris Fleizach.
150
151         Remove unused accessibility functions from webkit.
152         https://bugs.webkit.org/attachment.cgi?bugid=46707
153
154         * DumpRenderTree/chromium/WebViewHost.cpp:
155         (WebViewHost::postAccessibilityNotification):
156         * DumpRenderTree/chromium/WebViewHost.h:
157
158 2010-10-06  Lucas Forschler  <lforschler@apple.com>
159
160         Reviewed by Adam Roben.
161
162         Fix the sunspider-compare-results to actually use the passed in value for $root.
163
164         * Scripts/sunspider-compare-results:
165
166 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
167
168         Reviewed by Kenneth Rohde Christiansen.
169
170         [Qt] Runloop implementation for WTR
171         https://bugs.webkit.org/show_bug.cgi?id=47280
172
173         * WebKitTestRunner/qt/TestControllerQt.cpp:
174         Implemented TestController::runUntil by a timerEvent
175         and a QEventLoop. We step into the event loop from runUntil.
176         While we are waiting in the loop a timerEvent is periodically
177         checking the value of the condition. Once the condition has
178         becoming true the timerEvent wakes us up.
179         (WTR::RunUntilLoop::start):
180         (WTR::RunUntilLoop::RunUntilLoop):
181         (WTR::RunUntilLoop::run):
182         (WTR::RunUntilLoop::timerEvent):
183         (WTR::TestController::platformInitialize):
184         (WTR::TestController::runUntil):
185         * WebKitTestRunner/qt/main.cpp:
186         Start the main event loop first and creating the TestController later.
187         (Launcher::Launcher):
188         (Launcher::~Launcher):
189         (Launcher::launch): Creating the TestController.
190         (main): Setting up a timer for calling Launcher::launch from
191         the main event loop.
192
193 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
194
195         Reviewed by Kenneth Russell.
196
197         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
198         enable 'accelerated-composting' instead of 'accelerated-compositing'.
199
200         https://bugs.webkit.org/show_bug.cgi?id=47312
201
202         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
203         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
204
205 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
206
207         Reviewed by Kenneth Rohde Christiansen.
208
209         [Qt] PlatformWebView implementation for WebKitTestRunner
210         https://bugs.webkit.org/show_bug.cgi?id=47276
211
212         The implementation follows the way how
213         we use the API in MiniBrowser.
214         * WebKitTestRunner/PlatformWebView.h:
215         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
216         (WTR::WebView::wkView):
217         (WTR::WebView::~WebView):
218         (WTR::WebView::WebView):
219         (WTR::PlatformWebView::PlatformWebView):
220         (WTR::PlatformWebView::~PlatformWebView):
221         (WTR::PlatformWebView::resizeTo):
222         (WTR::PlatformWebView::page):
223         (WTR::PlatformWebView::focus):
224         * WebKitTestRunner/qt/WebKitTestRunner.pro:
225
226 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
227
228         Reviewed by Kenneth Rohde Christiansen.
229
230         [Qt] Add WebKitTestRunner's build files
231         https://bugs.webkit.org/show_bug.cgi?id=44155
232
233         Parts was taken by Zoltan Horvath's patch.
234
235         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
236         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
237         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
238         PlatformWKView and PlatformWindow (void* for now).
239         Buildfix the case when __APPLE__ is not defined.
240         * WebKitTestRunner/qt/DerivedSources.pro: Added.
241         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
242         Empty stub implementation.
243         (WTR::registerWindowClass):
244         (WTR::PlatformWebView::PlatformWebView):
245         (WTR::PlatformWebView::~PlatformWebView):
246         (WTR::PlatformWebView::resizeTo):
247         (WTR::PlatformWebView::page):
248         (WTR::PlatformWebView::focus):
249         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
250         Empty stub implementation.
251         (WTR::registerWindowClass):
252         (WTR::TestController::runUntil):
253         (WTR::TestController::platformInitialize):
254         (WTR::TestController::initializeInjectedBundlePath):
255         (WTR::TestController::initializeTestPluginDirectory):
256         (WTR::TestController::platformInitializeContext):
257         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
258         * WebKitTestRunner/qt/main.cpp: Added.
259         (main):
260
261 2010-10-06  Tony Chang  <tony@chromium.org>
262
263         Unreviewed, rolling out r69202.
264         http://trac.webkit.org/changeset/69202
265         https://bugs.webkit.org/show_bug.cgi?id=46937
266
267         Broke compile of test_shell
268
269         * DumpRenderTree/chromium/EventSender.cpp:
270         (EventSender::beginDragWithFiles):
271         * DumpRenderTree/chromium/WebViewHost.cpp:
272         (addDRTFakeFileToDataObject):
273
274 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
275
276         Reviewed by Tony Chang.
277
278         [chromium] Minor naming cleanup in WebDragData, part 2
279         https://bugs.webkit.org/show_bug.cgi?id=46937
280
281         Update DRT to use the renamed methods.
282
283         * DumpRenderTree/chromium/EventSender.cpp:
284         (EventSender::beginDragWithFiles):
285         * DumpRenderTree/chromium/WebViewHost.cpp:
286         (addDRTFakeFileToDataObject):
287
288 2010-10-06  David Kilzer  <ddkilzer@apple.com>
289
290         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
291
292         Reviewed by Adam Roben.
293
294         This is the first step in making webarchive tests work on
295         Windows.
296
297         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
298         new files to the project.
299         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
300         to WebArchiveDumpSupport.mm.
301         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
302         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
303         (serializeWebArchiveToXML):
304
305 2010-10-05  Daniel Bates  <dbates@rim.com>
306
307         Reviewed by David Kilzer.
308
309         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
310         https://bugs.webkit.org/show_bug.cgi?id=46058
311
312         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
313         structure so as to support returning additional information
314         about a change log diff.
315
316         Currently, VCSUtils::fixChangeLogPatch() returns a string that
317         represents the change log diff. Towards supporting the return
318         of additional information, such as whether the change log diff
319         inserts an entry at the top of the ChangeLog file, we need to
320         make VCSUtils::fixChangeLogPatch() return a reference to hash
321         structure.
322
323         * Scripts/VCSUtils.pm:
324           - Modified fixChangeLogPatch() to return a reference to a
325             hash structure.
326           - Added documentation to fixChangeLogPatch().
327           - Modified call site in mergeChangeLogs() as necessary.
328         * Scripts/svn-apply:
329           - Modified call site in patch() as necessary.
330         * Scripts/svn-create-patch:
331           - Modified call site in generateDiff() as necessary.
332         * Scripts/svn-unapply:
333           - Modified call site in patch() as necessary.
334         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
335           - Modified the unit tests as necessary.
336
337 2010-10-05  Tony Chang  <tony@chromium.org>
338
339         Reviewed by Darin Adler.
340
341         fix the link to the expected image on windows
342         https://bugs.webkit.org/show_bug.cgi?id=47228
343
344         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
345             windows, the file must be opened in binary mode when writing
346             binary data.
347
348 2010-10-05  Adam Barth  <abarth@webkit.org>
349
350         Update expected result of unittest to match Tony's change below.
351
352         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
353
354 2010-10-05  Tony Chang  <tony@chromium.org>
355
356         Reviewed by Ojan Vafai (over the shoulder).
357
358         Paper over errors in image_diff so we don't crash the whole test run.
359
360         * Scripts/webkitpy/layout_tests/port/chromium.py:
361
362 2010-10-05  Tony Chang  <tony@chromium.org>
363
364         Unreviewed, make shutil.rmtree more resiliant to errors
365         since windows was raising WindowsError: The process cannot access the file because it
366         is being used by another process.
367
368         * Scripts/webkitpy/layout_tests/port/chromium.py:
369
370 2010-10-05  Tony Chang  <tony@chromium.org>
371
372         Reviewed by Ojan Vafai.
373
374         [chromium] fix image diffing in NRWT
375         https://bugs.webkit.org/show_bug.cgi?id=47128
376
377         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
378             NamedTemporaryFile since it doesn't work on Windows.
379         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
380
381 2010-10-05  Kenneth Russell  <kbr@google.com>
382
383         Reviewed by Tony Chang.
384
385         [chromium] Implement layerTreeAsText in DumpRenderTree
386         https://bugs.webkit.org/show_bug.cgi?id=47216
387
388         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
389         make it callable from DumpRenderTree.
390
391         No new tests; verified with existing compositor layout tests.
392
393         * DumpRenderTree/chromium/LayoutTestController.cpp:
394         (LayoutTestController::LayoutTestController):
395         (LayoutTestController::layerTreeAsText):
396         * DumpRenderTree/chromium/LayoutTestController.h:
397
398 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
399
400         Unreviewed build correction.
401
402         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
403         property sheet so proper libraries are linked.
404
405 2010-10-05  Robert Hogan  <robert@webkit.org>
406
407         Reviewed by Andreas Kling.
408
409         [Qt] Fix url conversion in QWebHistory
410
411         Converting from KURL to WFT::String to QUrl does not
412         permit proper percent encoding later.
413
414         https://bugs.webkit.org/show_bug.cgi?id=47048
415
416         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
417         (WebCore::dumpHistoryItem):
418
419 2010-10-05  Anders Carlsson  <andersca@apple.com>
420
421         Reviewed by Sam Weinig.
422
423         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
424         https://bugs.webkit.org/show_bug.cgi?id=47188
425         <rdar://problem/8514104>
426
427         When constructing the std::string, use the real string length instead of the maximum buffer size.
428
429         * TestWebKitAPI/PlatformUtilities.h:
430         (TestWebKitAPI::Util::toSTD):
431         * WebKitTestRunner/StringFunctions.h:
432         (WTR::toSTD):
433
434 2010-10-04  Sam Weinig  <sam@webkit.org>
435
436         Reviewed by Mark Rowe.
437
438         Add MIMEType accessor to WKFrame
439         <rdar://problem/8347683>
440         https://bugs.webkit.org/show_bug.cgi?id=47138
441
442         * TestWebKitAPI/PlatformUtilities.h:
443         (TestWebKitAPI::Util::toSTD):
444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
445         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
446         (TestWebKitAPI::didStartProvisionalLoadForFrame):
447         (TestWebKitAPI::didCommitLoadForFrame):
448         (TestWebKitAPI::didFinishLoadForFrame):
449         (TestWebKitAPI::TEST):
450         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
451         (TestWebKitAPI::didStartProvisionalLoadForFrame):
452         (TestWebKitAPI::didCommitLoadForFrame):
453         (TestWebKitAPI::didFinishLoadForFrame):
454         (TestWebKitAPI::TEST):
455         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
456         (TestWebKitAPI::TEST):
457         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
458         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
459         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
460         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
461         (TestWebKitAPI::Util::createURLForResource):
462
463 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
464
465         Reviewed by Ojan Vafai.
466
467         [NRWT] Rename current_dir to current_group because it's not a directory
468         https://bugs.webkit.org/show_bug.cgi?id=47169
469
470         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
471         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
472
473 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
474
475         Unreviewed, build fix.
476
477         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
478         which can't always be done. This test uses tempfile.mkdtemp(), which
479         should be safe.
480
481         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
482
483 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
484
485         Unreviewed, build fix.
486
487         Add missing "from __future__ import with_statement" that was
488         breaking test-webkitpy on the Leopard bots (broke in r69040).
489
490         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
491
492 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
493
494         Unreviewed, rolling out r69066.
495         http://trac.webkit.org/changeset/69066
496         https://bugs.webkit.org/show_bug.cgi?id=47163
497
498         Made NRWT reliability worse. (Requested by tkent on #webkit).
499
500         * Scripts/webkitpy/layout_tests/port/chromium.py:
501         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
502
503 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
504
505         Reviewed by Tony Chang.
506
507         [NRWT] Reverse the http tests to alphabetical order.
508         https://bugs.webkit.org/show_bug.cgi?id=47075
509
510         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
511
512 2010-10-04  Robert Hogan  <robert@webkit.org>
513
514         Reviewed by Andreas Kling.
515
516         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
517
518         We need to queue back and forward navigations in the DRT from the
519         LayoutTestController so that maybeDump() knows about them.
520
521         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
522         (LayoutTestController::queueBackNavigation):
523         (LayoutTestController::queueForwardNavigation):
524
525 2010-10-04  Tony Chang  <tony@chromium.org>
526
527         Reviewed by Kent Tamura.
528
529         [chromium] fix image diffing in NRWT
530         https://bugs.webkit.org/show_bug.cgi?id=47128
531
532         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
533               temp file and check the image_diff error code more carefully
534         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
535
536 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
537
538         Reviewed by Adam Barth.
539
540         aroben's change in r68792 actually broke new-run-webkit-tests when
541         running the DRT code path. His change was intended to fix the
542         way we were converting windows paths to URIs when running under
543         Cygwin (the paths were getting one too many "/" on the front).
544         However, the change ended up breaking the chromium_win port, which
545         had slightly different logic.
546
547         This patch removes the port-specific code and adds tests to make
548         sure we're getting the behavior we expect. The Port object no longer
549         exposes a get_absolute_path() method that can be used outside of
550         of converting test filenames, because it's unreliable otherwise
551         (we don't have the right context to know which conversion is intended).
552
553         https://bugs.webkit.org/show_bug.cgi?id=47140
554
555         * Scripts/webkitpy/layout_tests/port/base.py:
556         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
557         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
558         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
559         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
560
561 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
562
563         Unreviewed, build fix.
564
565         Handle crash introduced in r69040 if we are not running in a
566         Chromium checkout.
567
568         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
569
570 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
571
572         Reviewed by Tony Chang.
573
574         Add a way for us to have test expectations that are specific to the
575         official builds of Google Chrome (as opposed to Chromium). This change
576         looks for an additional "test_expectations_chrome.txt" file in
577         Chromium's repository (webkit/tools/layout_tests), and uses the
578         concatenation of that file and the regular test_expectations.txt
579         file for test overrides.
580
581         https://bugs.webkit.org/show_bug.cgi?id=46854
582
583         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
584         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
585
586 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
587
588         Color tests in the list based on existing pass/fail result.
589         
590         Fix the summary data to account for htmlOnly and nonHTML tests.
591
592         * CSSTestSuiteHarness/harness/harness.css:
593         (#test-list > option.pass):
594         (#test-list > option.fail):
595         (#test-list > option.skipped):
596         * CSSTestSuiteHarness/harness/harness.js:
597         (Test):
598         (Test.prototype.statusForFormat):
599         (TestSuite.prototype.fillTestList):
600         (TestSuite.prototype.updateTestList):
601         (TestSuite.prototype.recordResult):
602         (TestSuite.prototype.markTestCompleted):
603         (TestSuite.prototype.countTestsWithFlag):
604         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
605         (TestSuite.prototype.queryDatabaseForSummary):
606
607 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
608
609         Reviewed by Beth Dakin.
610
611         AX: doAXRangeForLine does not work
612         https://bugs.webkit.org/show_bug.cgi?id=47101
613
614         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
615
616         * DumpRenderTree/AccessibilityUIElement.cpp:
617         (rangeForLineCallback):
618         (AccessibilityUIElement::rangeForLine):
619         (AccessibilityUIElement::getJSClass):
620         * DumpRenderTree/AccessibilityUIElement.h:
621         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
622         (AccessibilityUIElement::rangeForLine):
623
624 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
625
626         Unreviewed. Adding myself to the committers list.
627
628         * Scripts/webkitpy/common/config/committers.py:
629
630 2010-10-04  Sam Weinig  <sam@webkit.org>
631
632         Reviewed by Anders Carlsson.
633
634         Add ability to set the CacheModel in Webkit2
635         https://bugs.webkit.org/show_bug.cgi?id=47066
636
637         * MiniBrowser/mac/AppDelegate.m:
638         (-[BrowserAppDelegate init]): Opt minibrowser into
639         a PrimaryWebBrowser cache model.
640
641 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
642
643         Make sure to enter all tests when creating the database
644         for the first time.
645         
646         When migrating to a new version of the suite, be sure to
647         sync up the database and testinfo.data by removing old
648         tests, and inserting new ones.
649
650         * CSSTestSuiteHarness/harness/harness.js:
651         (TestSuite.prototype.openDatabase.creation):
652         (TestSuite.prototype.databaseCreated):
653         (TestSuite.prototype.populateDatabaseFromTestInfoData):
654         (TestSuite.prototype.insertTest):
655
656 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
657
658         More work on treating HTML4 and XHTML1 independently; when 
659         changing the format, rebuild the test list, and update the 
660         numbers in the chapter popup.
661
662         * CSSTestSuiteHarness/harness/harness.js:
663         (Test):
664         (Test.prototype.runForFormat):
665         (Test.prototype.completedForFormat):
666         (ChapterSection):
667         (ChapterSection.prototype.countTests):
668         (Chapter):
669         (Chapter.prototype.description):
670         (Chapter.prototype.countTests):
671         (Chapter.prototype.testCount):
672         (Chapter.prototype.untestedCount):
673         (TestSuite.prototype.buildChapters):
674         (TestSuite.prototype.loadCurrentTest):
675         (TestSuite.prototype.updateProgressLabel):
676         (TestSuite.prototype.processFlags):
677         (TestSuite.prototype.formatChanged):
678
679 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
680
681         Update test suite version 20101001.
682         
683         Handle database migration, and delete tests from the db that are
684         not present in testinfo.data.
685         
686         Load about:blank into the test frame before the test url, to make
687         missing tests more obvious.
688         
689         * CSSTestSuiteHarness/harness/harness.js:
690         (TestSuite.prototype.loadTest):
691         (TestSuite.prototype.openDatabase.creation):
692         (TestSuite.prototype.openDatabase.migration1_0To1_1):
693         (TestSuite.prototype.openDatabase.if.return):
694         (TestSuite.prototype.databaseReady):
695         (TestSuite.prototype.populateDatabaseFromTestInfoData):
696         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
697         (TestSuite.prototype.syncDatabaseWithTestInfoData):
698
699 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
700
701         Add the ability to jump to a specific test.
702
703         * CSSTestSuiteHarness/harness/harness.html:
704         * CSSTestSuiteHarness/harness/harness.js:
705         (TestSuite.prototype.goToTestByName):
706         (TestSuite.prototype.switchToFormat):
707
708 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
709
710         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
711         as the test.
712
713         * CSSTestSuiteHarness/harness/harness.js:
714         (TestSuite.prototype.loadRef):
715
716 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
717
718         Update the UI to reflect the fact that each test needs to be tested
719         in both HTML4 and XHTML1 format.
720         
721         * CSSTestSuiteHarness/harness/harness.js:
722         (Test):
723         (Chapter.prototype.description):
724         (Chapter.prototype.untestedCount):
725         (TestSuite.prototype.fillChapterPopup):
726         (TestSuite.prototype.updateChapterPopup):
727         (TestSuite.prototype.fillTestList):
728         (TestSuite.prototype.updateTestList):
729         (TestSuite.prototype.goToNextIncompleteTest):
730         (TestSuite.prototype.firstIncompleteTestIndex):
731         (TestSuite.prototype.recordResult):
732         (TestSuite.prototype.formatChanged):
733         (TestSuite.prototype.markTestCompleted):
734         (TestSuite.prototype.resetTestStatus):
735
736 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
737
738         Add the ability to remove results for re-testing, and
739         to import results.
740
741         * CSSTestSuiteHarness/harness/harness.css:
742         (.custom button):
743         (#overlay):
744         (#overlay.visible):
745         (.overlay-contents):
746         (.overlay-contents textarea):
747         (.overlay-contents .buttons):
748         (.overlay-contents .note):
749         (.overlay-contents .buttons button):
750         * CSSTestSuiteHarness/harness/harness.html:
751         * CSSTestSuiteHarness/harness/harness.js:
752         (TestSuite.prototype.importResults):
753         (TestSuite.prototype.clearResults):
754         (TestSuite.prototype.markTestCompleted):
755         (TestSuite.prototype.resetTestStatus):
756         (TestSuite.prototype.storeTestResult):
757         (TestSuite.prototype.importTestResults):
758         (TestSuite.prototype.clearTestResults):
759
760 2010-10-01  Sam Weinig  <sam@webkit.org>
761
762         Reviewed by Jon Honeycutt.
763
764         Deploy the new WKString functions to remove most uses of CF from
765         the WebKitTestRunner.
766
767         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
768         (WTR::InjectedBundle::didReceiveMessage):
769         (WTR::InjectedBundle::done):
770         * WebKitTestRunner/StringFunctions.h:
771         (WTR::toWK):
772         (WTR::toJS):
773         (WTR::toSTD):
774         (WTR::operator<<):
775         (WTR::copyURLString):
776         * WebKitTestRunner/TestController.cpp:
777         (WTR::TestController::resetStateToConsistentValues):
778         (WTR::TestController::didFinishLoadForFrame):
779         * WebKitTestRunner/TestInvocation.cpp:
780         (WTR::TestInvocation::invoke):
781         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
782
783 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
784
785         Unreviewed TestResultsServer change.
786
787         Add files introduced by http://crrev.com/61273 to the list of dashboard 
788         files to update.
789
790         * TestResultServer/handlers/dashboardhandler.py:
791
792 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
793
794         Build Fix for Windows.
795
796         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
797             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
798             ForwardingHeaders to the include path.
799
800 2010-10-01  Sam Weinig  <sam@webkit.org>
801
802         Reviewed by Anders Carlsson.
803
804         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
805
806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
807         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
808         (TestWebKitAPI::TEST):
809         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
810         (TestWebKitAPI::TEST):
811
812 2010-10-01  Sam Weinig  <sam@webkit.org>
813
814         Reviewed by Kenneth Rohde Christiansen.
815
816         Add additional WKString API
817         https://bugs.webkit.org/show_bug.cgi?id=46958
818
819         Add basic WKStringRef tests.
820
821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
822         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
823
824 2010-10-01  Sam Weinig  <sam@webkit.org>
825
826         Reviewed by Dan Bernstein.
827
828         Add makefile for TestWebKitAPI and call it from the base makefile.
829
830         * Makefile:
831         * TestWebKitAPI/Makefile: Added.
832
833 2010-10-01  Sam Weinig  <sam@webkit.org>
834
835         Reviewed by Adam Roben.
836
837         Remove unnecessary ForwardingHeaders from test runners.
838         https://bugs.webkit.org/show_bug.cgi?id=47010
839
840         * TestWebKitAPI/Configurations/Base.xcconfig:
841         * TestWebKitAPI/ForwardingHeaders: Removed.
842         * WebKitTestRunner/Configurations/Base.xcconfig:
843         * WebKitTestRunner/ForwardingHeaders: Removed.
844
845 2010-09-30  Adam Barth  <abarth@webkit.org>
846
847         Reviewed by Eric Seidel.
848
849         WebSocket tests are flaky
850         https://bugs.webkit.org/show_bug.cgi?id=46956
851
852         Update these tools to understand how to run the WebSocket tests off the
853         Apache server.
854
855         * Scripts/old-run-webkit-tests:
856         * Scripts/webkitpy/layout_tests/port/base.py:
857         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
858         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
859
860 2010-10-01  Adam Roben  <aroben@apple.com>
861
862         Encode Executive command arguments using UTF-8 on Cygwin
863
864         Cygwin's Python's os.execv doesn't support unicode command arguments.
865         Cygwin's execv expects arguments to be encoded using the current code
866         page. But code pages are limited in what characters they can handle,
867         and our tests include characters that the English code page can't
868         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
869         which can handle all characters but might confuse some commands, for
870         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
871         good enough, but we can deal with that when the problem arises.
872
873         Reviewed by Adam Barth.
874
875         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
876         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
877         fails on Windows
878
879         * Scripts/webkitpy/common/system/executive.py:
880         (Executive._run_command_with_teed_output):
881         (Executive.run_command):
882         On Cygwin, encode arguments using UTF-8.
883
884 2010-10-01  Sam Weinig  <sam@webkit.org>
885
886         Reviewed by Adam Roben.
887
888         Add simple API tester for WebKit2
889         https://bugs.webkit.org/show_bug.cgi?id=46953
890
891         This adds a very simple testing infrastructure for testing APIs exposed
892         through the WebKit project. It consists of two parts: 1) a project that
893         builds the all the tests 2) a script that searches the tests directory and
894         calls the tester once for each test.
895
896         This adds the infrastructure and two tests:
897         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
898         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
899
900         This currently only works on the mac, but is designed to be easily ported 
901         to any platform.
902
903         * Scripts/run-api-tests: Added.
904         * Scripts/build-api-tests: Added.
905         Scripts to build/run the tests.
906
907         * TestWebKitAPI: Added.
908         * TestWebKitAPI/Configurations: Added.
909         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
910         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
911         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
912         * TestWebKitAPI/ForwardingHeaders: Added.
913         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
914         * TestWebKitAPI/PlatformUtilities.h: Added.
915         * TestWebKitAPI/PlatformWebView.h: Added.
916         (TestWebKitAPI::PlatformWebView::platformView):
917         * TestWebKitAPI/StringFunctions.h: Added.
918         * TestWebKitAPI/Test.h: Added.
919         (TestWebKitAPI::Test::~Test):
920         (TestWebKitAPI::Test::name):
921         (TestWebKitAPI::Test::Register::Register):
922         (TestWebKitAPI::Test::Register::create):
923         (TestWebKitAPI::Test::Test):
924         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
925         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
926         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
927         * TestWebKitAPI/TestsController.cpp: Added.
928         (TestWebKitAPI::TestsController::shared):
929         (TestWebKitAPI::TestsController::TestsController):
930         (TestWebKitAPI::TestsController::runTestNamed):
931         (TestWebKitAPI::TestsController::testFailed):
932         (TestWebKitAPI::TestsController::registerCreateTestFunction):
933         * TestWebKitAPI/TestsController.h: Added.
934         * TestWebKitAPI/mac: Added.
935         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
936         (TestWebKitAPI::Util::run):
937         (TestWebKitAPI::Util::createURLForResource):
938         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
939         (TestWebKitAPI::PlatformWebView::PlatformWebView):
940         (TestWebKitAPI::PlatformWebView::resizeTo):
941         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
942         (TestWebKitAPI::PlatformWebView::page):
943         (TestWebKitAPI::PlatformWebView::focus):
944         * TestWebKitAPI/mac/main.mm: Added.
945         Infrastructure.
946
947         * TestWebKitAPI/Tests: Added.
948         * TestWebKitAPI/Tests/WTF: Added.
949         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
950         * TestWebKitAPI/Tests/WebKit2: Added.
951         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
952         (TestWebKitAPI::State::State):
953         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
954         Proof of concept tests.
955
956 2010-10-01  Adam Roben  <aroben@apple.com>
957
958         Don't assume AccessibleObjectFromEvent succeeds
959
960         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
961         DumpRenderTree!notificationListenerProc when running
962         plugins/access-after-page-destroyed.html
963
964         Reviewed by Sam Weinig.
965
966         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
967         (notificationListenerProc): Check both the return value of
968         AccessibleObjectFromEvent and the object it returns, as MSDN
969         recommends.
970
971 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
972
973         Reviewed by Tony Chang.
974
975         [NRWT] Put the http and websocket tests first in the test list.
976         https://bugs.webkit.org/show_bug.cgi?id=46453
977
978         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
979         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
980
981 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
982
983         Unreviewed, adding myself to the committer list.
984
985         * Scripts/webkitpy/common/config/committers.py:
986
987 2010-10-01  Adam Roben  <aroben@apple.com>
988
989         Test NPN_GetValue(NPNVnetscapeWindow)
990
991         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
992         Right-clicking on windowless Flash plugin in WebKit2 makes a context
993         menu appear in the bottom-right corner of the screen
994
995         Reviewed by Anders Carlsson.
996
997         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
998         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
999
1000         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
1001
1002         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
1003         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
1004         (GetValueNetscapeWindow::NPP_SetWindow): Test that
1005         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
1006         isn't our HWND.
1007
1008         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1009         Added GetValueNetscapeWindow.
1010
1011 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
1012
1013         Unreviewed, adding my webkit.org identity to reviewer list.
1014
1015         * Scripts/webkitpy/common/config/committers.py:
1016
1017 2010-09-30  Adam Barth  <abarth@webkit.org>
1018
1019         Reviewed by Eric Seidel.
1020
1021         The WebSocket server should flush its logs
1022         https://bugs.webkit.org/show_bug.cgi?id=46946
1023
1024         The WebSocket server logs are truncated because the driver just
1025         terminates the child.  It should run Python without buffering so we can
1026         see the end of the log.
1027
1028         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1029
1030 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
1031
1032         Add a button to jump to the next untested test.
1033         
1034         * CSSTestSuiteHarness/harness/harness.css:
1035         (.test-type):
1036         (.name > button):
1037         * CSSTestSuiteHarness/harness/harness.html:
1038         * CSSTestSuiteHarness/harness/harness.js:
1039         (Chapter.prototype.description):
1040         (Chapter.prototype.untestedCount):
1041         (TestSuite.prototype.testInfoDataLoaded):
1042         (TestSuite.prototype.fillChapterPopup):
1043         (TestSuite.prototype.updateChapterPopup):
1044         (TestSuite.prototype.buildTestListForChapter):
1045         (TestSuite.prototype.goToNextIncompleteTest):
1046         (TestSuite.prototype.firstIncompleteTestIndex):
1047         (TestSuite.prototype.testCompletionStateChanged):
1048
1049 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
1050
1051         WebKit2 on Windows should use Windows fonts for the various standard
1052         font families
1053         https://bugs.webkit.org/show_bug.cgi?id=43499
1054         <rdar://problem/8272758>
1055
1056         Reviewed by Adam Roben.
1057
1058         * WebKitTestRunner/TestController.cpp:
1059         (WTR::TestController::resetStateToConsistentValues):
1060         Use the Mac fonts for running tests. This matches DRT behavior.
1061
1062 2010-09-30  Adam Barth  <abarth@webkit.org>
1063
1064         Third attempt.  We need a better integration test environment.
1065
1066         * Scripts/webkitpy/common/net/failuremap.py:
1067         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1068
1069 2010-09-30  Robert Hogan  <robert@webkit.org>
1070
1071         Reviewed by Andreas Kling.
1072
1073         [Qt] Support for PlainTextController
1074
1075         Unskip editing/text-iterator/basic-iteration.html
1076
1077         https://bugs.webkit.org/show_bug.cgi?id=38805
1078
1079         * DumpRenderTree/qt/DumpRenderTree.pro:
1080         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1081         (WebCore::DumpRenderTree::DumpRenderTree):
1082         (WebCore::DumpRenderTree::initJSObjects):
1083         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1084         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
1085         (PlainTextController::PlainTextController):
1086         (PlainTextController::plainText):
1087         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
1088
1089 2010-09-30  Adam Barth  <abarth@webkit.org>
1090
1091         Unreviewed.  Second attempt to fix sheriffbot.
1092
1093         * Scripts/webkitpy/common/net/buildbot.py:
1094
1095 2010-09-30  Adam Barth  <abarth@webkit.org>
1096
1097         Unreviewed.
1098
1099         This patch should stop the sheriffbot from throwing an exception.
1100
1101         * Scripts/webkitpy/common/net/buildbot.py:
1102
1103 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
1104
1105         Reviewed by Adam Roben.
1106
1107         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
1108         https://bugs.webkit.org/show_bug.cgi?id=46926
1109
1110         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 
1111             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
1112
1113 2010-09-30  Adam Barth  <abarth@webkit.org>
1114
1115         Reviewed by Eric Seidel.
1116
1117         webkit-patch find-flaky-tests should print results URLs
1118         https://bugs.webkit.org/show_bug.cgi?id=46917
1119
1120         Printing out the results URL makes find-flaky-tests more actionable
1121         because you can see what happens when a test fails.  The output from
1122         the script is still pretty noisy, but it seems useful.
1123
1124         * Scripts/webkitpy/tool/commands/queries.py:
1125
1126 2010-09-30  Chris Marrin  <cmarrin@apple.com>
1127
1128         Reviewed by Simon Fraser.
1129
1130         Make 2D accelerated canvas rendering build on Mac
1131         https://bugs.webkit.org/show_bug.cgi?id=46007
1132         
1133         Added ACCELERATED_2D_CANVAS to build-webkit
1134
1135         * Scripts/build-webkit:
1136
1137 2010-09-29  Kenneth Russell  <kbr@google.com>
1138
1139         Reviewed by Dimitri Glazkov.
1140
1141         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
1142         https://bugs.webkit.org/show_bug.cgi?id=46849
1143
1144         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
1145         works with the compositor integration in both DumpRenderTree and
1146         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
1147         and thereby trigger the compositor's readback code path. Added support
1148         for --enable-accelerated-compositing to DumpRenderTree.
1149
1150         Tested in both test_shell and DumpRenderTree on Linux, the latter by
1151         modifying a compositing layout test, dumping the pixels and verifying
1152         that they matched the output when the compositor was active.
1153
1154         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1155         (main):
1156         * DumpRenderTree/chromium/TestShell.cpp:
1157         (TestShell::TestShell):
1158         (TestShell::resetWebSettings):
1159         * DumpRenderTree/chromium/TestShell.h:
1160         (TestShell::setAcceleratedCompositingEnabled):
1161         * DumpRenderTree/chromium/WebPreferences.cpp:
1162         (WebPreferences::reset):
1163         (WebPreferences::applyTo):
1164         * DumpRenderTree/chromium/WebPreferences.h:
1165         * DumpRenderTree/chromium/WebViewHost.cpp:
1166         (WebViewHost::scheduleComposite):
1167         * DumpRenderTree/chromium/WebViewHost.h:
1168
1169 2010-09-30  Adam Roben  <aroben@apple.com>
1170
1171         Ensure that QueueEngine cleans up its log files when its delegate
1172         tells it to stop processing work
1173
1174         Reviewed by Adam Barth.
1175
1176         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
1177         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
1178         Windows
1179
1180         * Scripts/webkitpy/tool/bot/queueengine.py:
1181         (QueueEngine.run): Stop ourselves normally (including cleaning up log
1182         files) when the delegate tells us to stop processing work.
1183
1184         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1185         (LoggingDelegate.__init__): Moved code here from
1186         RaisingDelegate.__init__.
1187         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
1188         callback.
1189         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
1190         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
1191         care of for us now.
1192         (QueueEngineTest.test_trivial): Make sure we got the expected stop
1193         message.
1194         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
1195         remove the callbacks that are related to processing a single work
1196         item, rather than removing all callbacks after a certain point, as
1197         there are now more callbacks we expect to receive at the end.
1198
1199 2010-09-30  Adam Roben  <aroben@apple.com>
1200
1201         Fix path -> URL conversion on Cygwin
1202
1203         Reviewed by Adam Barth.
1204
1205         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
1206         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
1207
1208         * Scripts/webkitpy/layout_tests/port/base.py:
1209         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
1210         assuming paths already have a leading slash.
1211
1212 2010-09-30  Adam Roben  <aroben@apple.com>
1213
1214         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
1215         be called more than once
1216
1217         The NPP_SetWindow call made when the plugin is torn down was confusing
1218         us, and was causing us to spew an error into the next test.
1219
1220         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
1221         (r68520): plugins/access-after-page-destroyed.html failing on Windows
1222
1223         Reviewed by Anders Carlsson.
1224
1225         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
1226         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
1227         Initialize member.
1228         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
1229         this isn't the first time this is called.
1230
1231 2010-09-30  Eric Seidel  <eric@webkit.org>
1232
1233         Reviewed by Adam Barth.
1234
1235         webkit-patch upload warns that I'm using Xcode when I'm not
1236         https://bugs.webkit.org/show_bug.cgi?id=46869
1237
1238         String.find returns -1 when not found, so switched to "in".
1239
1240         * Scripts/webkitpy/common/system/user.py:
1241         * Scripts/webkitpy/common/system/user_unittest.py:
1242
1243 2010-09-30  Eric Seidel  <eric@webkit.org>
1244
1245         Reviewed by Adam Barth.
1246
1247         webkit-patch failure-reason dies if non-trunk commits are in the blame range
1248         https://bugs.webkit.org/show_bug.cgi?id=46866
1249
1250         I also made failure-reason use RegressionWindow in a cleaner way.
1251
1252         * Scripts/webkitpy/tool/commands/queries.py:
1253
1254 2010-09-29  Adam Barth  <abarth@webkit.org>
1255
1256         Reviewed by Eric Seidel.
1257
1258         webkit-patch find-flaky-tests
1259         https://bugs.webkit.org/show_bug.cgi?id=46876
1260
1261         This command helps us find flaky tests so we can squash them.
1262
1263         * Scripts/webkitpy/tool/commands/queries.py:
1264
1265 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1266
1267         Fix export to use '?' instead of 'null' for
1268         tests with no results.
1269         
1270         * CSSTestSuiteHarness/harness/harness.js:
1271
1272 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1273
1274         Add a warning when a test requires special steps.
1275         Add a Print Preview button for 'paged' tests that
1276         brings up the print dialog, allowing the user to 
1277         judge paged media tests.
1278
1279         * CSSTestSuiteHarness/harness/harness.css:
1280         * CSSTestSuiteHarness/harness/harness.html:
1281         * CSSTestSuiteHarness/harness/harness.js:
1282         (TestSuite.prototype.loadTest):
1283         (TestSuite.prototype.processFlags):
1284
1285 2010-09-29  Adam Barth  <abarth@webkit.org>
1286
1287         Reviewed by Eric Seidel.
1288
1289         Remove revisions_casuing_failures
1290         https://bugs.webkit.org/show_bug.cgi?id=46872
1291
1292         This function exists only to be unit tested.
1293
1294         * Scripts/webkitpy/common/net/failuremap.py:
1295         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1296         * Scripts/webkitpy/tool/mocktool.py:
1297
1298 2010-09-29  Adam Barth  <abarth@webkit.org>
1299
1300         Reviewed by Eric Seidel.
1301
1302         SheriffBot should post the list of failing tests to bugs
1303         https://bugs.webkit.org/show_bug.cgi?id=46871
1304
1305         * Scripts/webkitpy/common/net/buildbot.py:
1306         * Scripts/webkitpy/common/net/failuremap.py:
1307         * Scripts/webkitpy/common/net/regressionwindow.py:
1308         * Scripts/webkitpy/tool/bot/sheriff.py:
1309         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1310         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1311         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1312         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1313         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1314         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1315         * Scripts/webkitpy/tool/mocktool.py:
1316
1317 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
1318
1319         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
1320
1321         [WinCairo] Adds a build slave.
1322         https://bugs.webkit.org/show_bug.cgi?id=46360
1323
1324         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
1325         entries for a debug build of the WinCairo port.
1326         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
1327         platform flag to configuration for wincairo (like gtk, chromium, etc.)
1328         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
1329         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
1330
1331 2010-09-29  Adam Barth  <abarth@webkit.org>
1332
1333         Reviewed by Eric Seidel.
1334
1335         Move more SheriffBot smarts into FailureMap
1336         https://bugs.webkit.org/show_bug.cgi?id=46703
1337
1338         This patch pushes the FailureMap model object further into the
1339         SheriffBot machine.  In addition, it moves a couple operations on this
1340         object from SheriffBot itself to the model.
1341
1342         Eventually, FailureMap will be the canonical context object for
1343         SheriffBot operations.  FailureMap represents a map of the current
1344         failures on the bots that might require remediation.
1345
1346         * Scripts/webkitpy/common/net/failuremap.py:
1347         * Scripts/webkitpy/common/net/regressionwindow.py:
1348         * Scripts/webkitpy/tool/commands/queries.py:
1349         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1350         * Scripts/webkitpy/tool/mocktool.py:
1351
1352 2010-09-29  Tony Chang  <tony@chromium.org>
1353
1354         Reviewed by James Robinson.
1355
1356         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
1357         https://bugs.webkit.org/show_bug.cgi?id=46829
1358
1359         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1360         (DRTDevToolsClient::DRTDevToolsClient):
1361         * DumpRenderTree/chromium/TestShell.cpp:
1362         (TestShell::TestShell):
1363         * DumpRenderTree/chromium/WebViewHost.cpp:
1364         (WebViewHost::postAccessibilityNotification):
1365         (WebViewHost::WebViewHost):
1366
1367 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
1368
1369         Reviewed by Darin Adler.
1370
1371         AX: implement CSS3 Speech "speak"
1372         https://bugs.webkit.org/show_bug.cgi?id=46827
1373
1374         * DumpRenderTree/AccessibilityUIElement.cpp:
1375         (speakCallback):
1376         (AccessibilityUIElement::speak):
1377         (AccessibilityUIElement::getJSClass):
1378         * DumpRenderTree/AccessibilityUIElement.h:
1379         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1380         (AccessibilityUIElement::speak):
1381
1382 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
1383
1384         Reviewed by Adam Barth.
1385
1386         Record bot ID when updating queue status
1387         https://bugs.webkit.org/show_bug.cgi?id=46764
1388         
1389         Since we now have multiple bots handling patches from the commit queue,
1390         we need to differentiate status updates from them, so that we can group
1391         the queue status page in a less confusing way.
1392
1393         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
1394         * QueueStatusServer/model/queuestatus.py: Add bot_id property
1395         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
1396         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
1397         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
1398         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
1399         * Scripts/webkitpy/tool/main.py: Add --bot-id
1400         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
1401
1402 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1403
1404         No review.
1405         
1406         References always refert to a file in .xht format, even
1407         for HTML tests, so fix their loading.
1408
1409         * CSSTestSuiteHarness/harness/harness.js:
1410         (TestSuite.prototype.loadRef):
1411
1412 2010-09-28  Johnny Ding  <jnd@chromium.org>
1413
1414         Reviewed by Adam Barth.
1415
1416         https://bugs.webkit.org/show_bug.cgi?id=41292
1417         Add a new parameter to the test plugin to allow specifying a script 
1418         and a mouse/keyboard event. The specified script will be evaluated
1419         in the browser when the specified event is received by the plugin.
1420
1421         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1422         (pluginAllocate):
1423         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1424         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1425         (NPP_New):
1426         (handleEventCarbon):
1427         (handleEventCocoa):
1428
1429 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1430
1431         Fix export by adding missing argument.
1432
1433         * CSSTestSuiteHarness/harness/harness.js:
1434         (TestSuite.prototype.showResultsForAllTests):
1435
1436 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1437
1438         [wx] Build fix, add missing import.
1439
1440         * wx/packaging/build-win-installer.py:
1441
1442 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1443
1444         No review
1445         
1446         Show which tests have been run by dimming them out in the test list.
1447         
1448         Adjust some element sizes.
1449         
1450         * CSSTestSuiteHarness/harness/harness.css:
1451         (#test-list > option.untested):
1452         (#test-list > option.completed):
1453         (#output):
1454         (.output-options):
1455         * CSSTestSuiteHarness/harness/harness.js:
1456         (Test):
1457         (TestSuite.prototype.fillTestList):
1458         (TestSuite.prototype.updateTestList):
1459         (TestSuite.prototype.setSelectedChapter):
1460         (TestSuite.prototype.recordResult):
1461         (TestSuite.prototype.markTestCompleted):
1462         (TestSuite.prototype.testCompletionStateChanged):
1463         (TestSuite.prototype.loadTestStatus):
1464
1465 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1466
1467         No review.
1468         
1469         Implement export of various queries on the test database, sharing
1470         code with that which displays results inline.
1471
1472         * CSSTestSuiteHarness/harness/harness.js:
1473         ():
1474         (TestSuite.prototype.exportResultsCompletion.var):
1475         (TestSuite.prototype.exportResultsCompletion):
1476         (TestSuite.prototype.showResultsForCompletedTests):
1477         (TestSuite.prototype.exportResultsForCompletedTests):
1478         (TestSuite.prototype.showResultsForAllTests):
1479         (TestSuite.prototype.exportResultsForAllTests):
1480         (TestSuite.prototype.exportResultsForTestsNotRun):
1481         (TestSuite.prototype.exportResultsForTestsWithStatus):
1482         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
1483
1484 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1485
1486         No review.
1487
1488         Work around uncertainty about the order of database
1489         transactions when creating the database, so that we don't
1490         try to query the table before it has been created.
1491
1492         * CSSTestSuiteHarness/harness/harness.js:
1493         (TestSuite):
1494         (TestSuite.prototype.databaseCreated):
1495         (TestSuite.prototype.storeTestResult):
1496         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1497         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
1498         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
1499         (TestSuite.prototype.queryDatabaseForCompletedTests):
1500         (TestSuite.prototype.queryDatabaseForTestsNotRun):
1501
1502 2010-09-28  Tony Chang  <tony@chromium.org>
1503
1504         Reviewed by Eric Seidel.
1505
1506         add python keyring support to webkit-patch
1507         https://bugs.webkit.org/show_bug.cgi?id=41269
1508
1509         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
1510             the python keyring module
1511         * Scripts/webkitpy/common/net/credentials_unittest.py:
1512         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
1513         * Scripts/webkitpy/common/system/user_unittest.py:
1514         * Scripts/webkitpy/tool/mocktool.py:
1515
1516 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1517
1518         Reviewed by Gustavo Noronha Silva.
1519
1520         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
1521         https://bugs.webkit.org/show_bug.cgi?id=46740
1522
1523         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
1524         fonts which can be used to fully test FontConfig rendering settings.
1525
1526 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1527
1528         Reviewed by Gustavo Noronha Silva.
1529
1530         [gtk] Fedora has a different path for the liberation fonts
1531         https://bugs.webkit.org/show_bug.cgi?id=46709
1532
1533         When searching for DRT fonts, also look in the path where those fonts
1534         are commonly found on Fedora systems.
1535
1536         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1537         (initializeFonts): Include logic for looking for Fedora-style font paths.
1538
1539 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1540
1541         Reviewed by Andreas Kling.
1542
1543         run-webkit-tests needs an updated list of directories with webgl tests
1544         https://bugs.webkit.org/show_bug.cgi?id=46747
1545
1546         Update the list of directories containing WebGL tests and a unit test
1547         which depends on this list.
1548
1549         * Scripts/old-run-webkit-tests: Update the list of directories.
1550         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
1551         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
1552
1553 2010-09-28  Adam Barth  <abarth@webkit.org>
1554
1555         Reviewed by Eric Seidel.
1556
1557         Introduce FailureMap to summaries the failures status of all the bots
1558         https://bugs.webkit.org/show_bug.cgi?id=46700
1559
1560         This patch gives the SheriffBot a handle on the list of failing tests.
1561
1562         * Scripts/webkitpy/common/net/buildbot.py:
1563         * Scripts/webkitpy/common/net/failuremap.py: Added.
1564         * Scripts/webkitpy/tool/commands/queries.py:
1565         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1566         * Scripts/webkitpy/tool/mocktool.py:
1567
1568 2010-09-28  Adam Roben  <aroben@apple.com>
1569
1570         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
1571
1572         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
1573         tell a WebKit2 client application that a key event was not handled
1574
1575         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
1576
1577         * MiniBrowser/mac/BrowserWindowController.m:
1578         (-[BrowserWindowController awakeFromNib]):
1579         * MiniBrowser/win/BrowserView.cpp:
1580         (BrowserView::create):
1581         * WebKitTestRunner/TestController.cpp:
1582         (WTR::createOtherPage):
1583         (WTR::TestController::initialize):
1584
1585 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1586
1587         Unreviewed.
1588
1589         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
1590         for the test order, but instead use information from testinfo.data.
1591         
1592         * CSSTestSuiteHarness/harness/harness.html:
1593         * CSSTestSuiteHarness/harness/harness.js:
1594
1595 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1596
1597         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
1598         it causes the process to hang on the gitorious repo.
1599
1600         * wx/packaging/build-mac-installer.py:
1601         * wx/packaging/build-win-installer.py:
1602
1603 2010-09-28  Adam Roben  <aroben@apple.com>
1604
1605         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
1606         called
1607
1608         Reviewed by Anders Carlsson.
1609
1610         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
1611         Full-page Adobe Reader does not paint until window is resized
1612
1613         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1614         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
1615         this level.
1616
1617         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
1618         NPP_SetWindow.
1619
1620         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
1621         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
1622         the plugin's HWND has a non-zero size and that its size/position
1623         matches that specified in the NPWindow.
1624
1625         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1626         (NPP_SetWindow): Call through to the PluginTest.
1627
1628         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1629         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
1630         the files as it saw fit.
1631
1632 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1633
1634         Reviewed by Andreas Kling.
1635
1636         [Qt] Remove support for Qt 4.5
1637         https://bugs.webkit.org/show_bug.cgi?id=46718
1638
1639         Remove the code for versions of Qt prior to 4.6.
1640
1641         * DumpRenderTree/qt/EventSenderQt.cpp:
1642         (EventSender::addTouchPoint):
1643         (EventSender::updateTouchPoint):
1644         (EventSender::setTouchModifier):
1645         (EventSender::touchStart):
1646         (EventSender::touchMove):
1647         (EventSender::touchEnd):
1648         (EventSender::clearTouchPoints):
1649         (EventSender::releaseTouchPoint):
1650         (EventSender::sendTouchEvent):
1651         * DumpRenderTree/qt/EventSenderQt.h:
1652         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1653         (TextInputController::setMarkedText):
1654         * QtTestBrowser/launcherwindow.cpp:
1655         (LauncherWindow::LauncherWindow):
1656         (LauncherWindow::initializeView):
1657         (LauncherWindow::createChrome):
1658         (LauncherWindow::sendTouchEvent):
1659         (LauncherWindow::eventFilter):
1660         (LauncherWindow::applyZoom):
1661         (LauncherWindow::setTouchMocking):
1662         * QtTestBrowser/launcherwindow.h:
1663         * QtTestBrowser/utils.cpp:
1664         (urlFromUserInput):
1665         * QtTestBrowser/webview.cpp:
1666         (WebViewGraphicsBased::animatedFlip):
1667         (WebViewGraphicsBased::animatedYFlip):
1668         * QtTestBrowser/webview.h:
1669         (WebViewGraphicsBased::setYRotation):
1670
1671 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
1672
1673         Reviewed by Andreas Kling.
1674
1675         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
1676         which should point to wcecompat installation. Needs wcecompat
1677         library from http://github.com/mauricek/wcecompat .
1678
1679         * DumpRenderTree/qt/DumpRenderTree.pro:
1680         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1681         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1682
1683 2010-09-28  Daniel Bates  <dbates@rim.com>
1684
1685         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
1686         <https://bugs.webkit.org/show_bug.cgi?id=39136>
1687
1688         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
1689         In particular, this change caused Sheriffbot to raise an exception when
1690         trying to parse the bug id on a bug page. We need to look into this
1691         some more.
1692
1693         * Scripts/webkitpy/common/net/bugzilla.py:
1694         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1695         * Scripts/webkitpy/tool/bot/sheriff.py:
1696         * Scripts/webkitpy/tool/commands/download.py:
1697         * Scripts/webkitpy/tool/commands/queues.py:
1698         * Scripts/webkitpy/tool/commands/upload.py:
1699         * Scripts/webkitpy/tool/steps/closebug.py:
1700         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1701         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1702         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1703
1704 2010-09-28  Adam Barth  <abarth@webkit.org>
1705
1706         Reviewed by Eric Seidel.
1707
1708         Move RegressionWindow further up the dependency chain
1709         https://bugs.webkit.org/show_bug.cgi?id=46698
1710
1711         Baby steps towards pushing this information into bug posts.
1712
1713         * Scripts/webkitpy/common/net/buildbot.py:
1714         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1715         * Scripts/webkitpy/common/net/regressionwindow.py:
1716         * Scripts/webkitpy/tool/commands/queries.py:
1717
1718 2010-09-27  Daniel Bates  <dbates@rim.com>
1719
1720         Reviewed by Adam Barth.
1721
1722         sheriffbot can't roll out security patches
1723         https://bugs.webkit.org/show_bug.cgi?id=39136
1724
1725         Make SheriffBot determine if it's authorized to view a bug
1726         whose change it wants to rollout before it tries to rollout
1727         the change.
1728
1729         Moreover, make both webkit-patch and Sheriffbot provide human-
1730         readable error messages when they are not authorized to view
1731         a bug and when a bug number is invalid.
1732
1733         Currently, Sheriffbot does not parse Bugzilla bugs for
1734         <bug error="...">, which indicates an error when retrieving
1735         a bug. In particular, error="NotPermitted" if a person (or bot)
1736         is not authorized to view a bug. For such error="NotPermitted" bugs,
1737         Sheriffbot raises an exception when parsing the bug report and
1738         this exception does not explicitly indicate Sheriffbot's lack
1739         of authorization. Instead, Sheriffbot should explicitly check
1740         for the presence <bug error="..."> before operating on a bug
1741         and error with a human-readable message if it's not permitted
1742         to view it.
1743
1744         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
1745         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1746           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
1747           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
1748           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
1749         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
1750         * Scripts/webkitpy/tool/commands/download.py: Ditto.
1751         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
1752         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
1753         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
1754         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
1755         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
1756         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
1757
1758 2010-09-27  Adam Barth  <abarth@webkit.org>
1759
1760         Reviewed by Eric Seidel.
1761
1762         Expose more more failure information from Buildbot to SheriffBot
1763         https://bugs.webkit.org/show_bug.cgi?id=46697
1764
1765         This patch moves the information about what tests failured closer to
1766         SheriffBot.  There are still a couple more patches to go before
1767         SheriffBot can post this information to bugs, but this is a step in
1768         that direction.  Yay for unit tests, which caught some bugs in earlier
1769         versions of this patch.
1770
1771         * Scripts/webkitpy/common/net/buildbot.py:
1772         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1773         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
1774         * Scripts/webkitpy/tool/commands/queries.py:
1775
1776 2010-09-27  Eric Seidel  <eric@webkit.org>
1777
1778         Unreviewed.  Fixing 500 error seen in the status server.
1779
1780         It turns out that a = b = []; b.append(1); then a[0] will be 1!
1781         This should have been obvious to me, I guess, but it was not what I was expecting.
1782
1783         * QueueStatusServer/model/activeworkitems.py:
1784
1785 2010-09-27  Adam Barth  <abarth@webkit.org>
1786
1787         Reviewed by Eric Seidel.
1788
1789         commit-queue should reject patches that fail to land
1790         https://bugs.webkit.org/show_bug.cgi?id=46694
1791
1792         This can happen, for example, if there's no reviewer.  Without this
1793         patch, we'll keep retrying the patch.
1794
1795         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1796         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1797
1798 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
1799
1800         Rubber-stamped by Adele Peterson.
1801
1802         Add a harness for running the CSS 2.1 test suite.
1803         
1804         This harness assumes that you've got a local a copy of the suite
1805         adjacent to the 'harness' directory.
1806         
1807         The harness lets you go through the tests in chapter order,
1808         denoting pass/fail/skipped for each test.
1809         
1810         It uses a client-side database to store the results of testing.
1811
1812         * CSSTestSuiteHarness/harness/harness.css: Added.
1813         * CSSTestSuiteHarness/harness/harness.html: Added.
1814         * CSSTestSuiteHarness/harness/harness.js: Added.
1815
1816 2010-09-27  Eric Seidel  <eric@webkit.org>
1817
1818         Reviewed by Adam Barth.
1819
1820         Patch locks should expire if a patch is marked for retry
1821         https://bugs.webkit.org/show_bug.cgi?id=46682
1822
1823         This was part Adam's original CommitQueueTask design,
1824         but support for it was missing from the server.
1825         I added the support, but triggering lock-release based on this
1826         special "retry" status feels a bit strange so I added a FIXME.
1827
1828         I also changed the text in queuestatus.html to say "Lock Acquired"
1829         since "Last Activity" isn't really true.  We only update the lock
1830         date when the patch is started, not on every status update.
1831
1832         I also noticed an exception in next-patch, which I fixed by re-writing
1833         the unzip logic in activeworkitems.py again.
1834
1835         * QueueStatusServer/handlers/updatestatus.py:
1836         * QueueStatusServer/model/activeworkitems.py:
1837         * QueueStatusServer/templates/queuestatus.html:
1838
1839 2010-09-27  Tony Chang  <tony@chromium.org>
1840
1841         Reviewed by David Levin.
1842
1843         [chromium] fix a warning when compiling DRT on 32-bit linux
1844         https://bugs.webkit.org/show_bug.cgi?id=46641
1845
1846         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1847         (DRTPrinter::handleImage):
1848
1849 2010-09-27  Eric Seidel  <eric@webkit.org>
1850
1851         Reviewed by Adam Barth.
1852
1853         queue-status should report when the patch was last locked to a queue
1854         https://bugs.webkit.org/show_bug.cgi?id=46674
1855
1856         This isn't necessarily the best way to expose this information
1857         but having this accessible via the web interface is very
1858         useful until we come up with a nicer way to display this.
1859
1860         I also cleaned up the code in activeworkitems.py a little
1861         to use list comprehensions and to have the code work with
1862         pairs instead of two lists at once.  Eventually I think those
1863         item/time pairs need to be their own little helper class.
1864
1865         * QueueStatusServer/handlers/queuestatus.py:
1866         * QueueStatusServer/model/activeworkitems.py:
1867         * QueueStatusServer/templates/queuestatus.html:
1868
1869 2010-09-27  Tony Chang  <tony@chromium.org>
1870
1871         Reviewed by David Levin.
1872
1873         [chromium] fix detection of missing fonts on DRT
1874         https://bugs.webkit.org/show_bug.cgi?id=46651
1875
1876         * DumpRenderTree/chromium/TestShellGtk.cpp:
1877         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
1878
1879 2010-09-27  Tony Chang  <tony@chromium.org>
1880
1881         Reviewed by Dimitri Glazkov.
1882
1883         add webkit unit tests to the chromium testers
1884         https://bugs.webkit.org/show_bug.cgi?id=46669
1885
1886         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1887         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
1888
1889 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
1890
1891         Unreviewed.
1892
1893         Adding myself to the committers list.
1894
1895         * Scripts/webkitpy/common/config/committers.py:
1896
1897 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
1898
1899         Reviewed by Eric Seidel.
1900
1901         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
1902         https://bugs.webkit.org/show_bug.cgi?id=46634
1903         
1904         Use OutputCapture to prevent console spam (and also check for expected
1905         output).
1906
1907         * Scripts/webkitpy/common/system/user_unittest.py:
1908
1909 2010-09-27  Eric Seidel  <eric@webkit.org>
1910
1911         Reviewed by James Robinson.
1912
1913         start-commit-queue should abort any rebases in progress
1914         https://bugs.webkit.org/show_bug.cgi?id=46640
1915
1916         webkit-patch commit-queue would do this itself, but this just
1917         helps ensure that the commit-queue script is properly updated
1918         before we run it (in the case where a previous rebase is in
1919         progress the git svn rebase would not work before we run the
1920         commit-queue).
1921
1922         * EWSTools/start-commit-queue.sh:
1923
1924 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
1925
1926         Reviewed by Gustavo Noronha Silva.
1927
1928         [GTK] Clean up the DRT fonts.conf and switch to Liberation
1929         https://bugs.webkit.org/show_bug.cgi?id=46038
1930
1931         Switch to Liberation fonts for GTK+ layout tests. This will make our
1932         test results metric-compatible with many Windows/Chromium results. It
1933         also simplifies the fonts.conf that we load and prepares the way for
1934         fixing many font bugs.
1935
1936         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1937         (initializeFonts): Initialize a known list of fonts instead of loading
1938         every font in the WEBKIT_TESTFONTS directory.
1939         * DumpRenderTree/gtk/fonts.conf: Removed.
1940         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1941         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
1942         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
1943         we can load both fonts.conf and AHEM____.TTF from this location.
1944         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
1945         it is no longer used.
1946
1947 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
1948
1949         Reviewed by Ojan Vafai.
1950
1951         new-run-webkit-httpd fails if Perl is not installed
1952         https://bugs.webkit.org/show_bug.cgi?id=46602
1953         
1954         Make Port._read_configuration catch all exceptions, since trying to run
1955         perl (because of _webkit_build_directory) when it's not installed throws
1956         a WindowsError or OSError, not an IOError (this became an issue after 
1957         r68268, since ChromiumPort ends up calling Port.default_configuration in
1958         its constructor, which means that we're ending up on this codepath in
1959         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
1960         new-run-webkit-httpd).
1961
1962         * Scripts/webkitpy/layout_tests/port/base.py:
1963         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1964
1965 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1966
1967         Reviewed by Antonio Gomes.
1968
1969         [EFL] Add setting API to set a local storage database path.
1970         https://bugs.webkit.org/show_bug.cgi?id=45446
1971
1972         Add a setting API to set local storage database path.
1973
1974         * EWebLauncher/main.c:
1975         (on_key_down):
1976         (browserCreate):
1977         (main):
1978
1979 2010-09-26  Sam Weinig  <sam@webkit.org>
1980
1981         Reviewed by Anders Carlsson.
1982
1983         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
1984         https://bugs.webkit.org/show_bug.cgi?id=46587
1985
1986         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1987
1988 2010-09-26  Antonio Gomes  <agomes@rim.com>
1989
1990         Reviewed by Kenneth Rohde Christiansen.
1991
1992         DRT/Mac nodesFromRect support
1993
1994         [Mac][DRT] Implement LayoutTestController::nodesFromRect
1995         https://bugs.webkit.org/show_bug.cgi?id=46580
1996
1997         Implements LayoutTestController::nodesFromRect for Mac DRT, and
1998         adding stubs for GTK+ and Windows.
1999
2000         * DumpRenderTree/LayoutTestController.cpp:
2001         (nodesFromRectCallback):
2002         (LayoutTestController::staticFunctions):
2003         * DumpRenderTree/LayoutTestController.h:
2004         (LayoutTestController::LayoutTestController::nodesFromRect):
2005         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2006         (LayoutTestController::nodesFromRect):
2007
2008 2010-09-25  Nicolas Weber  <thakis@chromium.org>
2009
2010         Reviewed by Adam Barth.
2011
2012         https://bugs.webkit.org/show_bug.cgi?id=46555
2013         Fix typo in prepare-ChangeLog's help output.
2014
2015         * Scripts/prepare-ChangeLog:
2016
2017 2010-09-24  Sam Weinig  <sam@webkit.org>
2018
2019         Reviewed by Darin Adler.
2020
2021         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
2022         <rdar://problem/8359279>
2023         https://bugs.webkit.org/show_bug.cgi?id=46546
2024
2025         * MiniBrowser/mac/BrowserWindowController.m:
2026         (mouseDidMoveOverElement):
2027         (-[BrowserWindowController awakeFromNib]):
2028         * MiniBrowser/win/BrowserView.cpp:
2029         (mouseDidMoveOverElement):
2030         (BrowserView::create):
2031         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2032         (WTR::InjectedBundlePage::InjectedBundlePage):
2033         * WebKitTestRunner/TestController.cpp:
2034         (WTR::createOtherPage):
2035         (WTR::TestController::initialize):
2036
2037 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2038
2039         Reviewed by Adam Barth.
2040
2041         Allow rebaselines for webkit-patch rebaseline to be chosen
2042         https://bugs.webkit.org/show_bug.cgi?id=46407
2043         
2044         Instead of always rebaselining all failing tests, allow a subset to be
2045         chosen.
2046
2047         * Scripts/webkitpy/common/system/user.py:
2048         * Scripts/webkitpy/tool/commands/rebaseline.py:
2049
2050 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
2051
2052         Reviewed by Tony Chang.
2053
2054         [chromium] Implement TextInputController::firstRectForCharacterRange
2055         https://bugs.webkit.org/show_bug.cgi?id=38100
2056
2057         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
2058         No new tests are added since we need to implement the same feature in chromium side
2059         in order to enable any tests that uses this function.
2060
2061         * DumpRenderTree/chromium/TextInputController.cpp:
2062         (TextInputController::firstRectForCharacterRange): Added.
2063
2064 2010-09-24  Adam Barth  <abarth@webkit.org>
2065
2066         Reviewed by Eric Seidel.
2067
2068         commit-queue reports land failures as "PASS"
2069         https://bugs.webkit.org/show_bug.cgi?id=46530
2070
2071         We were ignoring the return value of land instead of passing it back to
2072         CommitQueue.  Of course, this was the one case I forgot to test!
2073
2074         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2075         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2076
2077 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
2078
2079         Reviewed by Eric Seidel.
2080
2081         new-run-webkit-tests prints out nothing when build-dumprendertree fails
2082         https://bugs.webkit.org/show_bug.cgi?id=37563
2083
2084         Print error message when build-dumprendertree fails.
2085
2086         * Scripts/webkitpy/layout_tests/port/webkit.py:
2087         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2088
2089 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2090
2091         Reviewed by Tony Chang.
2092
2093         NRWT doesn't respect config set with set-webkit-configuration
2094         https://bugs.webkit.org/show_bug.cgi?id=46278
2095         
2096         Use Port.default_configuration() instead of hardcoding Release in
2097         ChromiumPort configuration initialization, so that we still inherit the
2098         configuration set by set-webkit-configuration.
2099
2100         * Scripts/webkitpy/layout_tests/port/chromium.py:
2101         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2102
2103 2010-09-24  Chang Shu  <chang.shu@nokia.com>
2104
2105         Reviewed by Csaba Osztrogonác.
2106
2107         [Qt] Fix the code to check file existence.
2108         https://bugs.webkit.org/show_bug.cgi?id=46465
2109
2110         * QtTestBrowser/main.cpp:
2111         (main):
2112
2113 2010-09-23  Tony Chang  <tony@chromium.org>
2114
2115         Unreviewed, rolling out r68232.
2116         http://trac.webkit.org/changeset/68232
2117
2118         Broken NRWT on the canary bots.
2119
2120         * Scripts/webkitpy/layout_tests/port/chromium.py:
2121
2122 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
2123
2124         Unreviewed, build fix.
2125
2126         r68008 broke new-run-webkit-tests in that the chromium ports no
2127         longer respect set-webkit-configuration. The correct fix for this
2128         is being pursued in bug 46278 (along with a bunch of unit tests),
2129         but in the meantime I'm reverting the particular lines that broke
2130         things. This was tested by hand.
2131
2132         * Scripts/webkitpy/layout_tests/port/chromium.py:
2133
2134 2010-09-23  Sam Weinig  <sam@webkit.org>
2135
2136         Reviewed by Anders Carlsson.
2137
2138         WebKit2 API: Need way to know when a frame is removed from the hierarchy
2139         <rdar://problem/8414062>
2140         https://bugs.webkit.org/show_bug.cgi?id=46432
2141
2142         * MiniBrowser/mac/BrowserWindowController.m:
2143         (didRemoveFrameFromHierarchy):
2144         (-[BrowserWindowController awakeFromNib]):
2145         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2146         (WTR::InjectedBundlePage::InjectedBundlePage):
2147         * WebKitTestRunner/TestController.cpp:
2148         (WTR::TestController::initialize):
2149
2150 2010-09-23  Tony Chang  <tony@chromium.org>
2151
2152         Reviewed by Dimitri Glazkov.
2153
2154         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
2155         https://bugs.webkit.org/show_bug.cgi?id=46426
2156
2157         * DumpRenderTree/chromium/LayoutTestController.cpp:
2158         (LayoutTestController::LayoutTestController):
2159         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2160         * DumpRenderTree/chromium/LayoutTestController.h:
2161
2162 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2163
2164         Reviewed by Nate Chapin.
2165
2166         [GTK] r68199 introduced two test failures
2167         https://bugs.webkit.org/show_bug.cgi?id=46424
2168
2169         Fix a regression handling preference overrides that are attached to boolean properties.
2170
2171         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2172         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
2173         so we must check for that when converting a string to a boolean.
2174
2175 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
2176
2177         Reviewed by David Levin.
2178
2179         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
2180         https://bugs.webkit.org/show_bug.cgi?id=46406
2181
2182         This breaks when the method is called with specified size of data (image data), and the
2183         buffer hasn't yet reached this size.
2184
2185         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
2186           index larger than 0.
2187
2188 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2189
2190         Reviewed by Nate Chapin.
2191
2192         [GTK] Some tests from r68174 fail on the GTK+ bots
2193         https://bugs.webkit.org/show_bug.cgi?id=46396
2194
2195         Simplify LayoutTestController::overridePreference to make it easier for
2196         people unfamiliar with the code to keep the list of preferences up to date.
2197         Add the conversion for enable-hyperlink-auditing.
2198
2199         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2200         (LayoutTestController::overridePreference): Use a simple if-else block to determine
2201         out the property name for overrridePreference. Also simplify the logic for setting
2202         string properties. Add the conversion for enable-hyperlink-auditing.
2203
2204 2010-09-23  Tony Chang  <tony@chromium.org>
2205
2206         Reviewed by David Levin.
2207
2208         [chromium] add caretBrowsingEnabled to WebSettings and DRT
2209         https://bugs.webkit.org/show_bug.cgi?id=46388
2210
2211         * DumpRenderTree/chromium/LayoutTestController.cpp:
2212         (LayoutTestController::overridePreference):
2213         * DumpRenderTree/chromium/WebPreferences.cpp:
2214         (WebPreferences::reset):
2215         (WebPreferences::applyTo):
2216         * DumpRenderTree/chromium/WebPreferences.h:
2217
2218 2010-09-23  Nate Chapin  <japhet@chromium.org>
2219
2220         Reviewed by Darin Fisher.
2221
2222         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
2223         https://bugs.webkit.org/show_bug.cgi?id=30458
2224
2225         * DumpRenderTree/chromium/LayoutTestController.cpp:
2226         (LayoutTestController::overridePreference):
2227         * DumpRenderTree/chromium/WebPreferences.cpp:
2228         (WebPreferences::reset):
2229         (WebPreferences::applyTo):
2230         * DumpRenderTree/chromium/WebPreferences.h:
2231         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2232         (resetDefaultsToConsistentValues):
2233         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2234         (LayoutTestController::overridePreference):
2235
2236 2010-09-21  Stephen White  <senorblanco@chromium.org>
2237
2238         Reviewed by David Levin.
2239
2240         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
2241         https://bugs.webkit.org/show_bug.cgi?id=46208
2242
2243         This flag allows the layout tests to be run with or without accelerated
2244         2D canvas rendering.
2245
2246         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2247         (main):
2248         Declare the new flag string, and check for it on startup.
2249         * DumpRenderTree/chromium/TestShell.cpp:
2250         (TestShell::TestShell):
2251         Add a boolean for the new flag, in order to preserve its value over
2252         preferences reset.
2253         (TestShell::resetWebSettings):
2254         Set the new flag to the stored value on reset.
2255         * DumpRenderTree/chromium/TestShell.h:
2256         (TestShell::setAccelerated2dCanvasEnabled):
2257         Add an accessor for the new flag.
2258         * DumpRenderTree/chromium/WebPreferences.cpp:
2259         (WebPreferences::reset):
2260         Initialize the new flag to false.
2261         (WebPreferences::applyTo):
2262         Copy the flag's value to the WebSettings.
2263         * DumpRenderTree/chromium/WebPreferences.h:
2264         Add the new flag.
2265
2266 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2267
2268         Reviewed by Simon Hausmann.
2269
2270         [Qt] Refactor QtWebKitPlatformPlugin interface
2271
2272         Make it easier to keep source-compability for the
2273         QtWebKitPlatformPlugin interface, and run qmake
2274         on the example (but not build) for convenience. 
2275
2276         https://bugs.webkit.org/show_bug.cgi?id=46345
2277
2278         * Scripts/webkitdirs.pm:
2279
2280 2010-09-23  Adam Barth  <abarth@webkit.org>
2281
2282         Reviewed by Eric Seidel.
2283
2284         Tweak some status messages that Eric thought were confusing
2285         https://bugs.webkit.org/show_bug.cgi?id=46342
2286
2287         * Scripts/webkitpy/tool/commands/queues.py:
2288         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2289
2290 2010-09-22  Adam Barth  <abarth@webkit.org>
2291
2292         Reviewed by Eric Seidel.
2293
2294         Fix comm-queue typo
2295         https://bugs.webkit.org/show_bug.cgi?id=46339
2296
2297         We were missing a "self".  The real problem is that we didn't have an
2298         integration test for the failure case.
2299
2300         * Scripts/webkitpy/tool/commands/queues.py:
2301         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2302
2303 2010-09-22  Adam Barth  <abarth@webkit.org>
2304
2305         Reviewed by Eric Seidel.
2306
2307         commit-queue should log more detailed messages to the QueueStatusServer
2308         https://bugs.webkit.org/show_bug.cgi?id=46333
2309
2310         When I created CommitQueueTask, I removed most of the previous logging.
2311         This patch adds back more detailed logging so folks can see their patch
2312         progress through the queue.
2313
2314         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2315         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2316         * Scripts/webkitpy/tool/commands/queues.py:
2317         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2318
2319 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
2320
2321         Reviewed by Darin Fisher.
2322
2323         [Chromium] User style layout tests don't pass on Chromium
2324         https://bugs.webkit.org/show_bug.cgi?id=46069
2325
2326         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
2327         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
2328         behavior from other ports.
2329
2330         * DumpRenderTree/chromium/LayoutTestController.cpp:
2331         (LayoutTestController::addUserStyleSheet):
2332
2333 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2334
2335         Reviewed by Martin Robinson.
2336
2337         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
2338         https://bugs.webkit.org/show_bug.cgi?id=46303.
2339
2340         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
2341         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
2342         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
2343         property sheet.
2344         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
2345         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
2346         appropriate property sheet for the build types.
2347         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
2348         configuration to use appropriate property sheet for CoreFoundation
2349         and CFLite-style builds.
2350
2351 2010-09-22  Adam Barth  <abarth@webkit.org>
2352
2353         Reviewed by Eric Seidel.
2354
2355         Optimize commit-queue performance for green trees
2356         https://bugs.webkit.org/show_bug.cgi?id=46254
2357
2358         This patch redesigns the controller logic for the commit-queue.  In the
2359         new design, the controller exercises much finer-grained control over
2360         the landing process.  In particular:
2361
2362         - Patches that fail to apply now get rejected almost immediately.
2363         - Patches that fail to build get rejects after two builds (instead of
2364           three builds and one test run).
2365         - Patches that run into a flaky test now get accepted after one build
2366           and two test runs instead of three full build-and-test runs.
2367
2368         The main cost of these optimizations is that we don't find out the tree
2369         has a failing test until the very end of the process, but if the tree
2370         has a busted test, there's not much we can do anyway.  We might as well
2371         burn commit-queue resources spinning optimisticly.
2372
2373         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
2374         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
2375         * Scripts/webkitpy/tool/commands/queues.py:
2376
2377 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2378
2379         Reviewed by Martin Robinson.
2380
2381         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
2382         https://bugs.webkit.org/show_bug.cgi?id=46303.
2383
2384         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
2385         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
2386         WinCairo build.
2387         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
2388         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
2389         build targets that use the new InjectedBundleCFLite.vsprops file.
2390
2391 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2392
2393         Unreviewed, build fix.
2394
2395         Fix bustage of rebaseline-chromium-webkit-tests resulting from
2396         r67974. Really need better unit tests for this tool :(
2397
2398         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2399
2400 2010-09-22  Adam Roben  <aroben@apple.com>
2401
2402         Unbreak test-webkitpy
2403
2404         * Scripts/webkitpy/test/main.py:
2405         (Tester.run_tests): Add a line that mysteriously got deleted.
2406
2407 2010-09-22  Adam Roben  <aroben@apple.com>
2408
2409         Make test-webkitpy test WebKit2's scripts
2410
2411         These scripts can't be in WebKitTools due to limitations of Apple's
2412         build process. But that doesn't mean we can't test them!
2413
2414         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
2415         WebKit2/Scripts
2416
2417         Reviewed by Adam Barth.
2418
2419         * Scripts/test-webkitpy:
2420         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
2421         Now takes an external_package_paths parameter and cleans both webkitpy
2422         and any external packages.
2423         (init): Added an external_package_paths parameter which we pass along
2424         to _clean_packages_with_test.
2425         (top level): Add WebKit2/Scripts/webkit2 as our only external package
2426         and pass it along to init and Tester.run_tests.
2427
2428         * Scripts/webkitpy/test/main.py:
2429         (Tester.run_tests): Added an optional external_package_paths
2430         parameter. We modify sys.path so that the external packages can be
2431         imported, and search for unittest files inside all external packages
2432         in addition to inside webkitpy.
2433
2434 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2435
2436         Reviewed by Tony Chang.
2437
2438         new-run-webkit-tests: r68063 broke linux python tests
2439
2440         Add a missing "from __future__ import with_statement" to this
2441         new file; the perils of testing only on the Mac and by review :(
2442
2443         https://bugs.webkit.org/show_bug.cgi?id=46293
2444
2445         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2446
2447 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2448
2449         Reviewed by Tony Chang.
2450
2451         Add a 'chromium-gpu' set of ports that will test the accelerated
2452         GPU paths. This patch adds:
2453
2454         - support for the '--accelerated-compositing' and
2455           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
2456           'no-' flags)
2457         - adds a new set of Ports that will look under
2458           platform/chromium-gpu-$OS/ for baselines before looking in the
2459           regular chromium search path
2460         - adds a new test_expectations.txt file in platform/chromium-gpu
2461           that skips all but the tests we actually want to run with
2462           acceleration.
2463
2464         This patch will allow us to run both with and without acceleration
2465         and to change the defaults for both the regular and -gpu options
2466         as the code evolves.
2467
2468         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
2469         each test bot.
2470
2471         https://bugs.webkit.org/show_bug.cgi?id=46225
2472
2473         * Scripts/webkitpy/layout_tests/port/chromium.py:
2474         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2475         * Scripts/webkitpy/layout_tests/port/factory.py:
2476         * Scripts/webkitpy/layout_tests/port/webkit.py:
2477
2478 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
2479
2480         Reviewed by Kenneth Rohde Christiansen.
2481
2482         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
2483         https://bugs.webkit.org/show_bug.cgi?id=43988
2484
2485         Runs a web debug server on port specified by QtTestBrowser
2486         argument -remote-inspector-port. Property
2487         _q_webInspectorServerPort of the QWebPage instance will be set
2488         according to the argument. All pages with that property set will
2489         be remotely inspectable.
2490
2491         URL for remote inspection of first QWebPage is
2492             http://localhost:9222/webkit/inspector/inspector.html?page=1
2493         where 1 is the number of the QWebPage instance.
2494
2495         The base URL yields an index page with links to the individual inspectors:
2496             http://localhost:9222/
2497
2498         * QtTestBrowser/launcherwindow.cpp:
2499         (LauncherWindow::init):
2500         * QtTestBrowser/launcherwindow.h:
2501         * QtTestBrowser/main.cpp:
2502         (LauncherApplication::handleUserOptions):
2503
2504 2010-09-22  Adam Roben  <aroben@apple.com>
2505
2506         Fix webkit-patch failure-reason now that build.webkit.org has been
2507         updated
2508
2509         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
2510         every time
2511
2512         Reviewed by Eric Seidel.
2513
2514         * Scripts/webkitpy/common/net/buildbot.py:
2515         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
2516         looking for an element that contains text, then returns it.
2517         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
2518         text out of the cells. This way it doesn't matter whether the cells
2519         have <b> children (as for cells in directory rows) or not (as for
2520         cells in file rows)
2521         (BuildBot._parse_twisted_directory_listing): Look for rows that have
2522         the "directory" or "file" class, rather than rows with any class,
2523         since header rows now have a class attribute.
2524
2525         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2526         (BuildBotTest._example_directory_listing): Updated to more closely
2527         match the markup that build.webkit.org is producing now.
2528
2529 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2530
2531         Unreviewed, build fix.
2532
2533         new-run-webkit-tests: fix bug introduced in r68008 where if you
2534         specify --chromium and no --platform, and you're running on
2535         windows, you use the 'chromium-win' port by default instead of the
2536         version-specific port. This breaks the buildbots.
2537
2538         It will be good for this refactoring to settle down so I can
2539         rewrite the logic for default ports and the unit tests to be
2540         clearer (and the testing more comprehensive).
2541
2542         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2543
2544 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2545
2546         Reviewed by Adam Barth.
2547
2548         Modify the Port interface to take only a series of keyword arguments
2549         in the constructor, and modify Port/factory.get() to accomodate that,
2550         and to accept user=XXX as an argument so we can pass
2551         webkitpy.common.system.user.User objects in.
2552
2553         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
2554         to use the common routine in webkitpy.common.system.user.open_url()
2555         to display HTML files.
2556
2557         There was a routine in the Port interface to do the same thing,
2558         but I see no need for a port-specific hook for this, since it is
2559         something that will always be executed by the host environment
2560         and displaying web pages has nothing to do with running layout tests.
2561
2562         Note that new-run-webkit-tests used to use test_shell to display
2563         the page; this is potentially useful so that you can actually click
2564         from a result to the broken page; however, since DumpRenderTree
2565         doesn't support this functionality, it will be going away eventually.
2566
2567         https://bugs.webkit.org/show_bug.cgi?id=46128
2568
2569         * Scripts/webkitpy/layout_tests/port/base.py:
2570         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2571         * Scripts/webkitpy/layout_tests/port/chromium.py:
2572         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2573         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2574         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2575         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2576         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2577         * Scripts/webkitpy/layout_tests/port/factory.py:
2578         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2579         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2580         * Scripts/webkitpy/layout_tests/port/gtk.py:
2581         * Scripts/webkitpy/layout_tests/port/mac.py:
2582         * Scripts/webkitpy/layout_tests/port/qt.py:
2583         * Scripts/webkitpy/layout_tests/port/test.py:
2584         * Scripts/webkitpy/layout_tests/port/webkit.py:
2585         * Scripts/webkitpy/layout_tests/port/win.py:
2586         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2587         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2588         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2589
2590 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2591
2592         Reviewed by Kenneth Rohde Christiansen.
2593
2594         [EFL] Get fresh theme when running EWebLauncher
2595         https://bugs.webkit.org/show_bug.cgi?id=46210
2596
2597         If user tried to run EWebLauncher outside of the build tree, it would
2598         not find the theme and fallback to the installed one. However, since
2599         EWebLauncher is not installed, we always want to take the theme from
2600         the just compiled source code. If user had never installed WebKit's
2601         EFL port it could even receive a segv since no theme would be found.
2602
2603         Now EWebLauncher does not fallback to the installed theme and CMake
2604         gives as DATA_DIR the directory of the theme it has just built.
2605
2606         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
2607         EWebLauncher.
2608         * EWebLauncher/main.c: Use only the theme from build director. Do not
2609         fallback to others as this could hide real bugs.
2610         (quit):
2611         (browserCreate):
2612         (findThemePath):
2613         (main):
2614
2615 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2616
2617         Unreviewed, build fix.
2618
2619         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
2620         it just confuses it.
2621
2622         https://bugs.webkit.org/show_bug.cgi?id=46230
2623
2624         * Scripts/webkitpy/layout_tests/port/webkit.py:
2625
2626 2010-09-21  Lucas Forschler  <lforschler@apple.com>
2627
2628         Reviewed by Stephanie Lewis.
2629
2630         Make a new buildbot for Leopard Debug Test
2631
2632         * BuildSlaveSupport/build.webkit.org-config/config.json:
2633
2634 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2635
2636         Unreviewed, build fix.
2637
2638         Fix breakage of Chromium Mac DRT port caused by r67905.
2639
2640         https://bugs.webkit.org/show_bug.cgi?id=46230
2641
2642         * Scripts/webkitpy/layout_tests/port/webkit.py:
2643
2644 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2645
2646         Unreviewed, build fix.
2647
2648         Add missing import of 'tempfile'.
2649
2650         * Scripts/webkitpy/layout_tests/port/chromium.py:
2651
2652 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
2653
2654         Reviewed by Ojan Vafai.
2655
2656         new-run-webkit-tests: pull the list of tests from the Port, and
2657            make it possible to run with no actual test files in the filesystem.
2658
2659         This set of changes allows us to delete the special
2660         webkitpy/layout_tests/data directory and test the generic code without
2661         touching the filesystem (except to write results). This speeds up
2662         test-webkitpy substantially.
2663
2664         This also cleans up and removes several code paths in the generic
2665         code and fixes some minor bugs, notably in the test_expectations
2666         parsing, which was previously fragile if the tests weren't present.
2667
2668         We also change the way we diff image results to be able to do so
2669         in memory, without relying on files. This slows down chromium
2670         test_shell, which always writes images to files, but should speed
2671         up DRT and ImageDiff-based implementations slightly.
2672
2673         Note that pulling the list of tests to run from the Port will allow
2674         ports to specify what tests to run as an inclusive list; previously
2675         you could only do this as an exclusive list by using a 
2676         test_expectations file or Skipped files; nothing actually uses this
2677         feature yet and it's unclear if it should be used.
2678
2679         Note that there are no functional changes -- apart from now 
2680         always printing out the location of the checksum file when we are
2681         tracing test runs -- and the total number of lines of non-test code
2682         actually drops by two.
2683
2684         There is some more cleanup that can be done in the Port/Driver 
2685         interface and in some handling of filenames, but I'll save that
2686         for another change.
2687
2688         https://bugs.webkit.org/show_bug.cgi?id=45801
2689
2690         * Scripts/webkitpy/layout_tests/data/*: Removed.
2691             - no longer need special mock layout_tests_directory in the
2692               repository.
2693         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2694             - add code to display missing text files, checksums when tracing
2695             - update to not look at the filesystem directly.
2696         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2697             - add more unit tests
2698         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2699             - remove tests_are_present flag
2700             - update with changes in Port interface - no longer access
2701               the filesystem directly, although we still use os.path for
2702               filename manipulation.
2703         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2704             - add more unit tests
2705         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
2706             - renamed to port/test_files.py
2707         * Scripts/webkitpy/layout_tests/port/base.py:
2708             - change diff_image() to expect actual image data, not filenames
2709             - add expected_checksum(), expected_image(), expected_text() to
2710               return the content of the files so that we don't need a filesystem
2711             - add path_exists(), path_isdir() for filesystem-like access.
2712             - add test_dirs() to keep clobber-test-results from needing to
2713               actually look at a real layout tests dir
2714             - add tests() to return the list of tests to run on the port
2715               (calls port/test_files to do the work).
2716             - add update_baseline() to be able to save new baselines
2717             - add uri_to_test_name() from port/dryrun.py so we can easily check
2718               filename_to_uri()
2719         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2720             - add more unit tests
2721         * Scripts/webkitpy/layout_tests/port/chromium.py:
2722             - change diff_image() to accept image content, not filenames.
2723               This will be slower for test_shell/image_diff, but faster
2724               for DRT/ImageDiff.
2725         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2726             - add more unit tests
2727         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2728             - simplify greatly
2729         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2730             - add more unit tests
2731         * Scripts/webkitpy/layout_tests/port/test.py:
2732             - massive rewrite to use in-script list of tests and expectations
2733         * Scripts/webkitpy/layout_tests/port/test_files.py:
2734             - rename from layout_package/test_files.
2735         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2736             - add unit tests
2737         * Scripts/webkitpy/layout_tests/port/webkit.py:
2738             - update diff_image() to take image contents, not files. Should
2739               make things slightly faster.
2740         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2741             - update with changes to diff_image()
2742         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2743             - update with changes to diff_image()
2744         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2745             - remove tests_are_present from test_expectations
2746             - pull the list of tests from port.tests() instead
2747               of calling test_files.py directly.
2748         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2749             - update unit tests
2750         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2751             - update with changes to 
2752         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2753             - update with change in Port interface
2754         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2755             - update with change in Port interface
2756         * Scripts/webkitpy/style/checkers/test_expectations.py:
2757             - remove the tests_are_present flag
2758
2759 2010-09-21  Anders Carlsson  <andersca@apple.com>
2760
2761         Disable logging.
2762
2763         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2764
2765 2010-09-21  Tony Chang  <tony@chromium.org>
2766
2767         Reviewed by Kent Tamura.
2768
2769         add a script for running webkit_unit_tests
2770         https://bugs.webkit.org/show_bug.cgi?id=46014
2771
2772         * Scripts/run-chromium-webkit-unit-tests: Added.
2773
2774 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
2775
2776         Reviewed by Martin Robinson.
2777
2778         Fix linking problems on Windows.
2779         https://bugs.webkit.org/show_bug.cgi?id=45844
2780
2781         * GNUmakefile.am: link the executables with winmm.dll
2782
2783 2010-09-21  Adam Barth  <abarth@webkit.org>
2784
2785         Reviewed by Eric Seidel.
2786
2787         feeder-queue svn updates more often than needed
2788         https://bugs.webkit.org/show_bug.cgi?id=46171
2789
2790         We don't need to poll SVN every time we feed the feeders.  Rather, we
2791         can count on the wrapper shell script to auto-update the queue.
2792
2793         * Scripts/webkitpy/tool/commands/queues.py:
2794         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2795
2796 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2797
2798         Reviewed by Andreas Kling.
2799
2800         [Qt] Add robot loader timeout and extra time options.
2801         https://bugs.webkit.org/show_bug.cgi?id=46172
2802
2803         [-robot-timeout <s>]: Load the next page after s seconds if the current
2804         page didn't finish loading.
2805         [-robot-extra-time <s>]: Wait s seconds after the current page finished
2806         loading before loading the next one. This should allow some time for the
2807         page's JavaScript to execute.
2808
2809         * QtTestBrowser/launcherwindow.cpp:
2810         (LauncherWindow::applyPrefs):
2811         * QtTestBrowser/main.cpp:
2812         (LauncherApplication::robotTimeout):
2813         (LauncherApplication::robotExtraTime):
2814         (LauncherApplication::LauncherApplication):
2815         (LauncherApplication::handleUserOptions):
2816         (main):
2817         * QtTestBrowser/urlloader.cpp:
2818         (UrlLoader::UrlLoader):
2819         (UrlLoader::loadNext):
2820         (UrlLoader::loadUrlList):
2821         * QtTestBrowser/urlloader.h:
2822
2823 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
2824
2825         Unreviewed.
2826
2827         Adding myself to the committers list.
2828
2829         * Scripts/webkitpy/common/config/committers.py:
2830
2831 2010-09-20  Philippe Normand  <pnormand@igalia.com>
2832
2833         Reviewed by Eric Carlson.
2834
2835         [GTK] enhanced context menu for media elements
2836         https://bugs.webkit.org/show_bug.cgi?id=45021
2837
2838         EventSender::contextClick() now returns an array of js
2839         objects. Each object has a title property and a click() method.
2840
2841         * DumpRenderTree/gtk/EventSender.cpp:
2842         (getMenuItemTitleCallback):
2843         (setMenuItemTitleCallback):
2844         (menuItemClickCallback):
2845         (getMenuItemClass):
2846         (contextClickCallback):
2847
2848 2010-09-20  Hayato Ito  <hayato@chromium.org>
2849
2850         Unreviewed.
2851         Adding myself to the committers list.
2852
2853         * Scripts/webkitpy/common/config/committers.py:
2854
2855 2010-09-20  Adam Barth  <abarth@webkit.org>
2856
2857         Reviewed by Eric Seidel.
2858
2859         The tool member variable should be called _tool
2860         https://bugs.webkit.org/show_bug.cgi?id=46160
2861
2862         Created by find-and-replace.
2863
2864         * Scripts/webkitpy/tool/commands/download.py:
2865         * Scripts/webkitpy/tool/commands/openbugs.py:
2866         * Scripts/webkitpy/tool/commands/queries.py:
2867         * Scripts/webkitpy/tool/commands/queues.py:
2868         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2869         * Scripts/webkitpy/tool/commands/rebaseline.py:
2870         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2871         * Scripts/webkitpy/tool/commands/upload.py:
2872         * Scripts/webkitpy/tool/multicommandtool.py:
2873
2874 2010-09-20  Adam Barth  <abarth@webkit.org>
2875
2876         I ran the tests before landing but ignored the fact that they failed.  :(
2877
2878         * Scripts/webkitpy/tool/commands/queues.py:
2879
2880 2010-09-20  Adam Barth  <abarth@webkit.org>
2881
2882         Reviewed by Eric Seidel.
2883
2884         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
2885         https://bugs.webkit.org/show_bug.cgi?id=46141
2886
2887         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
2888         list of work items on the status server.  The individual commit-cluster
2889         nodes then grab the patches from the server and process them.
2890
2891         * Scripts/webkitpy/tool/bot/feeders.py: Added.
2892         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
2893         * Scripts/webkitpy/tool/commands/queues.py:
2894         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2895         * Scripts/webkitpy/tool/commands/queuestest.py:
2896
2897 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
2898
2899         Reviewed by Darin Adler.
2900
2901         build-webkit: Add support for CMake build system
2902         https://bugs.webkit.org/show_bug.cgi?id=44979
2903
2904         * Scripts/build-webkit: Add "--efl" command-line option to build the
2905         EFL port of WebKit.
2906         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
2907         buildEflCMakeProject() subroutines.
2908
2909 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
2910
2911         Reviewed by Ojan Vafai.
2912
2913         new-run-webkit-tests: refactor command line args getting passed to DRT
2914
2915         This change cleans up some argument parsing between functions to get
2916         rid of some overlapping data structures. There should be no functional
2917         changes in this patch; it is pure refactoring in preparation for
2918         landing the Chrome GPU port and adding a generic way to pass
2919         args to DRT/TestShell.
2920
2921         https://bugs.webkit.org/show_bug.cgi?id=46135
2922
2923         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2924           - pass the options argument explicitly to the threads and drivers,
2925             also consolidate the passing of options to the driver.
2926           - pass options directly to process_output() to remove a couple
2927             parameters (minor cleanup).
2928         * Scripts/webkitpy/layout_tests/port/base.py:
2929           - pass the options argument to Port.create_driver().
2930         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2931           - update Port.create_driver() test
2932         * Scripts/webkitpy/layout_tests/port/chromium.py:
2933           - pass the options argument to Port.create_driver(), and clean up
2934             building of the cmd line for DRT.
2935         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2936           - pass the options argument to Port.create_driver()
2937         * Scripts/webkitpy/layout_tests/port/test.py:
2938           - pass the options argument to Port.create_driver()
2939         * Scripts/webkitpy/layout_tests/port/webkit.py:
2940           - pass the options argument to Port.create_driver(), and clean up
2941             building of the cmd line for DRT.
2942         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2943           - consolidate args in _get_dump_render_tree_args and rename to
2944             _get_test_args(); move all of the command-line args to the
2945             Port implementations.
2946
2947 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
2948
2949         Revert change which was accidentally committed along with some expectation changes.
2950
2951         * Scripts/webkitpy/layout_tests/port/base.py:
2952
2953 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2954
2955         Reviewed by Adam Barth.
2956
2957         Add explicit --force-patch flag to webkitpy tools
2958         https://bugs.webkit.org/show_bug.cgi?id=46103
2959         
2960         It wasn't obvious until I read the applypatch.py source code that
2961         --non-interfactive implies passing --force to patch. Add --force-patch
2962         as an alias to the flag, so that this behavior is more discoverable.
2963
2964         * Scripts/webkitpy/tool/steps/applypatch.py:
2965         * Scripts/webkitpy/tool/steps/options.py:
2966
2967 2010-09-20  Eric Seidel  <eric@webkit.org>
2968
2969         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
2970
2971         commit-queue can't land patches
2972         https://bugs.webkit.org/show_bug.cgi?id=46138
2973
2974         Add a line of code I forgot in my last commit.
2975
2976         * Scripts/webkitpy/common/net/bugzilla.py:
2977         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2978
2979 2010-09-20  Adam Barth  <abarth@webkit.org>
2980
2981         Reviewed by Eric Seidel.
2982
2983         The commit-cluster bots still race to lock patch_ids
2984         https://bugs.webkit.org/show_bug.cgi?id=46130
2985
2986         It turns out we need to use a transaction object to make the
2987         read/modify/write lock operation atomic.  From reading the AppEngine
2988         documentation, I think this patch should do what we want.  It's hard to
2989         test locally because the test instance isn't distributed in the same
2990         way the production instance is.
2991
2992         * QueueStatusServer/handlers/nextpatch.py:
2993         * QueueStatusServer/model/activeworkitems.py: Added.
2994
2995 2010-09-20  Andy Estes  <aestes@apple.com>
2996
2997         Reviewed by Adam Barth.
2998
2999         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
3000         https://bugs.webkit.org/show_bug.cgi?id=40961
3001
3002         Implement WebKitUsePreHTML5ParserQuirks preference.
3003
3004         * DumpRenderTree/mac/DumpRenderTree.mm:
3005         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
3006         to false after a test finishes.
3007
3008 2010-09-20  Adam Roben  <aroben@apple.com>
3009
3010         Windows build fix
3011
3012         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
3013         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
3014         we'll pick up the most recent versions of the headers.
3015
3016 2010-09-20  Eric Seidel  <eric@webkit.org>
3017
3018         Reviewed by Adam Barth.
3019
3020         commit-queue should check commit-queue+ again just before committing
3021         https://bugs.webkit.org/show_bug.cgi?id=32679
3022
3023         Added a _revalidate_patch check, right before landing.
3024
3025         Since _revalidate_patch passes the patch_id from the work item
3026         back to bugzilla, I had to fix all of the previous queue tests to
3027         use valid attachment ids (that's the majority of this change).
3028
3029         In order to validate that the bug was still open, I had to teach
3030         bugzilla.Bug about open/closed states.
3031
3032         * Scripts/webkitpy/common/net/bugzilla.py:
3033         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3034         * Scripts/webkitpy/tool/commands/queues.py:
3035         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3036         * Scripts/webkitpy/tool/commands/queuestest.py:
3037         * Scripts/webkitpy/tool/mocktool.py:
3038
3039 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
3040
3041         Unreviewed.
3042
3043         Adding myself as a comitter.
3044
3045         * Scripts/webkitpy/common/config/committers.py:
3046
3047 2010-09-20  Adam Barth  <abarth@webkit.org>
3048
3049         Reviewed by Eric Seidel.
3050
3051         Two instances of commit-queue try to process the same patch
3052         https://bugs.webkit.org/show_bug.cgi?id=46113
3053
3054         This patch makes next-patch atomic so that the server won't vend the
3055         same patch twice in the same hour.
3056
3057         * QueueStatusServer/handlers/nextpatch.py:
3058
3059 2010-09-20  Adam Roben  <aroben@apple.com>
3060
3061         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
3062
3063         We were previously trying to use a CFRunLoopTimer, but since Windows
3064         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
3065         Windows-style timer on Windows.
3066
3067         I also replaced all uses of "watchdog" with "watchdog timer".
3068
3069         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
3070         watchdog timer doesn't work on Windows
3071
3072         Reviewed by Anders Carlsson.
3073
3074         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3075         (WTR::InjectedBundlePage::dump): Updated for rename.
3076
3077         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
3078         platform-specific functions.
3079         (WTR::LayoutTestController::LayoutTestController): Added call to
3080         platformInitialize.
3081         (WTR::LayoutTestController::waitUntilDone): Changed to call
3082         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
3083         right in this function.
3084         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
3085         rename.
3086
3087         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
3088         members needed to support the watchdog timer abstraction. Replaced
3089         some "watchdog"s with "watchdog timer".
3090
3091         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
3092         Added.
3093         (WTR::LayoutTestController::platformInitialize): Does nothing on this
3094         platform.
3095         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
3096         from LayoutTestController.cpp and changed to use an early return.
3097         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
3098         LayoutTestController.cpp.
3099         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3100         Moved code here from LayoutTestController::waitUntilDone and changed
3101         to use an early return.
3102
3103         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
3104         Added.
3105         (WTR::LayoutTestController::platformInitialize): Initialize our
3106         watchdog timer.
3107         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
3108         Kills and clears the watchdog timer.
3109         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
3110         LayoutTestController member function of the same name.
3111         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3112         Added. Sets up the timer if it isn't already set.
3113
3114         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
3115         LayoutTestControllerMac.mm.
3116
3117         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
3118         LayoutTestControllerWin.cpp.
3119
3120 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
3121
3122         Reviewed by Daniel Bates.
3123
3124         [GTK] fast/forms/listbox-selection.html fails
3125         https://bugs.webkit.org/show_bug.cgi?id=45942
3126
3127         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
3128         strings in keyDownCallback.
3129
3130         * DumpRenderTree/gtk/EventSender.cpp:
3131         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
3132         modifier parsing logic.
3133
3134 2010-09-19  Sam Weinig  <sam@webkit.org>
3135
3136         Reviewed by Anders Carlsson.
3137
3138         WebKit2 decidePolicyForNavigationAction should include mouse button information
3139         <rdar://problem/8413165>
3140         https://bugs.webkit.org/show_bug.cgi?id=46060
3141
3142         * MiniBrowser/mac/BrowserWindowController.m:
3143         (decidePolicyForNavigationAction):
3144         (decidePolicyForNewWindowAction):
3145
3146 2010-09-19  Daniel Bates  <dbates@rim.com>
3147
3148         Reviewed by Martin Robinson.
3149
3150         Add unit tests for diffs that delete or modify a change log entry
3151         or describe changes that are far apart
3152         https://bugs.webkit.org/show_bug.cgi?id=46046
3153
3154         Add additional unit tests to test change log diffs that contain
3155         deletions or changes that are far apart from each other in the
3156         ChangeLog file.
3157
3158         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3159           - Added the following unit tests:
3160           "fixChangeLogPatch: [no change] In-place change."
3161           "fixChangeLogPatch: [no change] Remove first entry."
3162           "fixChangeLogPatch: [no change] Remove entry in the middle."
3163           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
3164
3165 2010-09-19  Sam Weinig  <sam@webkit.org>
3166
3167         Reviewed by Anders Carlsson.
3168
3169         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
3170         https://bugs.webkit.org/show_bug.cgi?id=46054
3171
3172         The new one acts like WKBundleNodeHandleRef and allows for getting a
3173         wrapper in a specific world for the handle.
3174
3175         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3176         (WTR::propertyValue):
3177         (WTR::propertyValueDouble):
3178         (WTR::propertyValueInt):
3179         (WTR::numericWindowPropertyValue):
3180         (WTR::toStr):
3181         (WTR::InjectedBundlePage::shouldBeginEditing):
3182         (WTR::InjectedBundlePage::shouldEndEditing):
3183         (WTR::InjectedBundlePage::shouldInsertNode):
3184         (WTR::InjectedBundlePage::shouldInsertText):
3185         (WTR::InjectedBundlePage::shouldDeleteRange):
3186         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3187         (WTR::InjectedBundlePage::shouldApplyStyle):
3188         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3189
3190 2010-09-19  Kent Tamura  <tkent@chromium.org>
3191
3192         Unreviewed. Fix WebGL test regressions by r67809.
3193
3194         * DumpRenderTree/chromium/WebPreferences.cpp:
3195         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
3196
3197 2010-09-19  Kent Tamura  <tkent@chromium.org>
3198
3199         Reviewed by Adam Barth.
3200
3201         [DRT/Chromium] Fix a WebSettings handling bug
3202         https://bugs.webkit.org/show_bug.cgi?id=45945
3203
3204         Before this change, Chromium DRT reset WebSettings for every new
3205         window. It was wrong.
3206         If new window is not the first one, we have to apply the same
3207         settings as the first window.  So, we introduce WebPreference to
3208         store the current settings, and apply it to new windows. It's same
3209         as test_shell's behavior.
3210
3211         * DumpRenderTree/DumpRenderTree.gypi:
3212         * DumpRenderTree/chromium/LayoutTestController.cpp:
3213           Use WebPreferences instead of WebSettings.
3214         (LayoutTestController::setUserStyleSheetEnabled):
3215         (LayoutTestController::setUserStyleSheetLocation):
3216         (LayoutTestController::setAuthorAndUserStylesEnabled):
3217         (LayoutTestController::setPopupBlockingEnabled):
3218         (LayoutTestController::disableImageLoading):
3219         (LayoutTestController::setJavaScriptCanAccessClipboard):
3220         (LayoutTestController::setXSSAuditorEnabled):
3221         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
3222         (LayoutTestController::setAllowFileAccessFromFileURLs):
3223         (LayoutTestController::overridePreference):
3224         (LayoutTestController::setEditingBehavior):
3225         * DumpRenderTree/chromium/TestShell.cpp:
3226         (TestShell::resetWebSettings): Use WebPreferences.
3227         (TestShell::runFileTest): ditto.
3228         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
3229         * DumpRenderTree/chromium/TestShell.h:
3230         (TestShell::preferences):
3231         (TestShell::applyPreferences):
3232         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
3233         * DumpRenderTree/chromium/WebPreferences.h: Added.
3234
3235 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
3236
3237         Reviewed by David Levin.
3238
3239         update-webkit --chromium spitting out a spurious error
3240         https://bugs.webkit.org/show_bug.cgi?id=45868
3241
3242         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
3243
3244 2010-09-18  Sam Weinig  <sam@webkit.org>
3245
3246         Reviewed by Dan Bernstein.
3247
3248         Improve/unify the PageLoadClient interfaces
3249         https://bugs.webkit.org/show_bug.cgi?id=46043
3250
3251         * MiniBrowser/mac/BrowserWindowController.m:
3252         (didStartProvisionalLoadForFrame):
3253         (didReceiveServerRedirectForProvisionalLoadForFrame):
3254         (didFailProvisionalLoadWithErrorForFrame):
3255         (didCommitLoadForFrame):
3256         (didFinishDocumentLoadForFrame):
3257         (didFinishLoadForFrame):
3258         (didFailLoadWithErrorForFrame):
3259         (didReceiveTitleForFrame):
3260         (didFirstLayoutForFrame):
3261         (didFirstVisuallyNonEmptyLayoutForFrame):
3262         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3263         (WTR::InjectedBundlePage::InjectedBundlePage):
3264         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3265         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3266         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3267         (WTR::InjectedBundlePage::didCommitLoadForFrame):
3268         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3269         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3270         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3271         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3272         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3273         * WebKitTestRunner/TestController.cpp:
3274         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3275         (WTR::TestController::didFinishLoadForFrame):
3276         * WebKitTestRunner/TestController.h:
3277
3278 2010-09-17  Eric Seidel  <eric@webkit.org>
3279
3280         Unreviewed.  Adding a shell script I use to run the
3281         commit-queue. Now that multiple machines run the cq,
3282         it makes sense to share the script between them.
3283
3284         * EWSTools/start-commit-queue.sh: Added.
3285
3286 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
3287
3288         Reviewed by Jon Honeycutt.
3289
3290         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
3291         slightly harder to read, so this reverts the previous background colors for various
3292         states, making it easier to read.
3293
3294         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3295         (.success):
3296         (.failure):
3297         (.warnings):
3298         (.exception):
3299         (.start,.running,td.building):
3300         (.offline,td.offline):
3301
3302 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3303
3304         Unreviewed, rolling out r67692.
3305         http://trac.webkit.org/changeset/67692
3306         https://bugs.webkit.org/show_bug.cgi?id=46011
3307
3308         broke layout test dashboard (Requested by johnny_g on
3309         #webkit).
3310
3311         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3312         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3313         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3314
3315 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
3316
3317         Reviewed by Oliver Hunt.
3318
3319         Style bot complains about cairo forward declaration naming
3320         https://bugs.webkit.org/show_bug.cgi?id=45867
3321
3322         Exclude Cairo forward declarations from indentifiers with underscores checks.
3323
3324         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
3325         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3326
3327 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
3328
3329         Reviewed by Ojan Vafai.
3330
3331         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
3332         https://bugs.webkit.org/show_bug.cgi?id=45408
3333
3334         This change also tries to remove duplicated upload_results_json methods
3335         in run_webkit_tests.py and json_results_generator.py.
3336
3337         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3338         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3339         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3340
3341 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
3342
3343         Reviewed by Andreas Kling.
3344
3345         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
3346
3347         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
3348         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
3349         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
3350         all page specific stuff to the UI.
3351
3352         * QtTestBrowser/launcherwindow.cpp:
3353         (LauncherWindow::initializeView):
3354         * QtTestBrowser/mainwindow.cpp:
3355         (MainWindow::MainWindow):
3356         (MainWindow::buildUI):
3357         (MainWindow::setPage):
3358         * QtTestBrowser/mainwindow.h:
3359
3360 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3361
3362         Reviewed by Andreas Kling.
3363
3364         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
3365
3366         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
3367         object will move to the qgraphicsscene instead of the qgraphicsview.
3368
3369         * QtTestBrowser/webview.cpp:
3370         (WebViewGraphicsBased::setPage):
3371         (WebViewGraphicsBased::setResizesToContents):
3372         (WebViewGraphicsBased::resizeEvent):
3373         (WebViewGraphicsBased::animatedFlip):
3374         * QtTestBrowser/webview.h:
3375         (WebViewGraphicsBased::setItemCacheMode):
3376         (WebViewGraphicsBased::itemCacheMode):
3377
3378 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3379
3380         Reviewed by Andreas Kling.
3381
3382         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
3383
3384         We usually separate methods whose body are larger than a few lines from the class definition.
3385
3386         * QtTestBrowser/webview.h:
3387         (WebViewGraphicsBased::yRotation):
3388         (WebViewGraphicsBased::setYRotation):
3389
3390 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3391
3392         Reviewed by Andreas Kling.
3393
3394         Make initializeView method of LauncherWindow private.
3395
3396         No one else needs to be able to call it but LauncherWindow.
3397         Also moving the declation of isGraphicsBased method down in the same file, in order
3398         to better group related methods.
3399
3400         * QtTestBrowser/launcherwindow.h:
3401
3402 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3403
3404         Reviewed by Andreas Kling.
3405
3406         Make the getter 'page' method of MainWindow const.
3407
3408         * QtTestBrowser/mainwindow.cpp:
3409         (MainWindow::page):
3410         * QtTestBrowser/mainwindow.h:
3411
3412 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3413
3414         Reviewed by Andreas Kling.
3415
3416         Remove useless parameter from MainWindow class' constructor.
3417
3418         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
3419         not referred in the constructor body and does not make much sense.
3420
3421         * QtTestBrowser/mainwindow.cpp:
3422         (MainWindow::MainWindow):
3423         * QtTestBrowser/mainwindow.h:
3424
3425 2010-09-15  Tony Chang  <tony@chromium.org>
3426
3427         Reviewed by Kent Tamura.
3428
3429         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
3430         https://bugs.webkit.org/show_bug.cgi?id=42151
3431
3432         * DumpRenderTree/chromium/LayoutTestController.cpp:
3433         (LayoutTestController::LayoutTestController):
3434         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
3435         (WorkItemLoadHTMLString::run):
3436         (LayoutTestController::queueLoadHTMLString):
3437         (LayoutTestController::reset):
3438         (LayoutTestController::setDeferMainResourceDataLoad):
3439         * DumpRenderTree/chromium/LayoutTestController.h:
3440         (LayoutTestController::deferMainResourceDataLoad):
3441         * DumpRenderTree/chromium/WebViewHost.cpp:
3442         (WebViewHost::didCreateDataSource):
3443
3444 2010-09-16  Adrienne Walker  <enne@google.com>
3445
3446         Reviewed by Kenneth Russell.
3447
3448         Add script to synchronize WebKit and Khronos WebGL tests
3449         https://bugs.webkit.org/show_bug.cgi?id=42336
3450
3451         * Scripts/update-webgl-conformance-tests: Added.
3452         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
3453         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
3454
3455 2010-09-16  Sam Weinig  <sam@webkit.org>
3456
3457         Reviewed by Anders Carlsson.
3458
3459         Add support for sending synchronous messages from the InjectedBundle to the WKContext
3460         <rdar://problem/8365320>
3461         https://bugs.webkit.org/show_bug.cgi?id=44785
3462
3463         * MiniBrowser/mac/AppDelegate.m:
3464         (didReceiveSynchronousMessageFromInjectedBundle):
3465         (-[BrowserAppDelegate init]):
3466         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3467         (didCreatePage):
3468         * WebKitTestRunner/TestController.cpp:
3469         (WTR::TestController::initialize):
3470
3471 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
3472
3473         Reviewed by Andreas Kling.
3474
3475         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
3476         https://bugs.webkit.org/show_bug.cgi?id=45885
3477
3478         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
3479
3480         * QtTestBrowser/launcherwindow.cpp:
3481         (LauncherWindow::screenshot):
3482
3483 2010-09-16  Anders Carlsson  <andersca@apple.com>
3484
3485         Fix clang++ build.
3486
3487         * MiniBrowser/mac/BrowserWindowController.m:
3488         (-[BrowserWindowController zoomIn:]):
3489         (-[BrowserWindowController zoomOut:]):
3490         (-[BrowserWindowController resetZoom:]):
3491         Remove trailing semicolons.
3492
3493 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3494
3495         Unreviewed, rolling out r67628.
3496         http://trac.webkit.org/changeset/67628
3497         https://bugs.webkit.org/show_bug.cgi?id=45904
3498
3499         broke the build (Requested by eric_carlson on #webkit).
3500
3501         * DumpRenderTree/gtk/EventSender.cpp:
3502         (contextClickCallback):
3503
3504 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
3505
3506         Unreviewed.
3507
3508         Adding myself as a comitter.
3509
3510         * Scripts/webkitpy/common/config/committers.py:
3511
3512 2010-09-15  Philippe Normand  <pnormand@igalia.com>
3513
3514         Reviewed by Eric Carlson.
3515
3516         [GTK] enhanced context menu for media elements
3517         https://bugs.webkit.org/show_bug.cgi?id=45021
3518
3519         EventSender::contextClick() now returns an array of js
3520         objects. Each object has a title property and a click() method.
3521
3522         * DumpRenderTree/gtk/EventSender.cpp:
3523         (getMenuItemTitleCallback):
3524         (setMenuItemTitleCallback):
3525         (menuItemClickCallback):
3526         (getMenuItemClass):
3527         (contextClickCallback):
3528
3529 2010-09-14  Philippe Normand  <pnormand@igalia.com>
3530
3531         Reviewed by Eric Carlson and Martin Robinson.
3532
3533         [GTK] eventSender.contextClick() should return the contents of the context menu
3534         https://bugs.webkit.org/show_bug.cgi?id=39102
3535
3536         Make the eventSender use the new private WebKitGtk+ API to
3537         retrieve the context-menu item titles and store them in an array.
3538
3539         * DumpRenderTree/gtk/EventSender.cpp:
3540         (contextClickCallback):
3541
3542 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
3543
3544         Reviewed by Jian Li.
3545
3546         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
3547         https://bugs.webkit.org/show_bug.cgi?id=45798
3548
3549         * Scripts/build-webkit:
3550
3551 2010-09-16  Robert Hogan  <robert@webkit.org>
3552
3553         Reviewed by Antonio Gomes.
3554
3555         [Qt] Support globalhistory tests
3556         https://bugs.webkit.org/show_bug.cgi?id=45774
3557
3558         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3559         (WebCore::isGlobalHistoryTest):
3560         (WebCore::DumpRenderTree::open):
3561         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3562         (LayoutTestController::reset):
3563         (LayoutTestController::dumpHistoryCallbacks):
3564         (LayoutTestController::removeAllVisitedLinks):
3565         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3566
3567 2010-09-10  Tony Chang  <tony@chromium.org>
3568
3569         Reviewed by Eric Seidel.
3570
3571         deduplicate-tests should be runnable from any WebKit directory
3572         https://bugs.webkit.org/show_bug.cgi?id=44709
3573
3574         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3575         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3576
3577 2010-09-15  Tony Chang  <tony@chromium.org>
3578
3579         Reviewed by Kent Tamura.
3580
3581         [chromium] sort testing methods in DRT
3582         https://bugs.webkit.org/show_bug.cgi?id=45850
3583
3584         * DumpRenderTree/chromium/EventSender.cpp:
3585         (EventSender::EventSender):
3586         * DumpRenderTree/chromium/LayoutTestController.cpp:
3587         (LayoutTestController::LayoutTestController):
3588         * DumpRenderTree/chromium/TextInputController.cpp: