ed2e4bf5585a986311269877554dfd735f914785
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2
3         Reviewed by Simon Hausmann.
4
5         Make run-webkit-tests work under Cygwin for the Qt port
6
7         setPathForRunningWebKitApp() is implemented for the Qt port
8         by using qmake to query for the location of the Qt libraries.
9
10         This requires the original environment (%ENV) to be untouched,
11         so launchWithCurrentEnv() was refactored to launchWithEnv(),
12         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
13         instead. This has the added benefit of getting rid of the temp
14         variables used for storing the current env.
15
16         openDumpTool() is also refactored a bit into platform-spesific,
17         port-spesific, and generic environment variables.
18
19         Checks for undef was added a few places to fix Perl concat
20         warnings when run-webkit-tests is aborted.
21
22         https://bugs.webkit.org/show_bug.cgi?id=33895
23
24         * Scripts/run-webkit-tests:
25         * Scripts/webkitdirs.pm:
26
27 2010-02-04  Yuzo Fujishima  <yuzo@google.com>
28
29         Unreviewed.
30
31         Add Yuzo to the committers list.
32
33         * Scripts/webkitpy/committers.py:
34
35 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
36
37         Rubber-stamped by Eric Seidel.
38
39         Change "the Chromium name" to "the name of Google Inc." in the licenses
40
41         https://bugs.webkit.org/show_bug.cgi?id=34511
42
43         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
44         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
45         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
46         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
47         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
48         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
49         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
50         * Scripts/webkitpy/layout_tests/port/__init__.py:
51         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
52         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
53         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
54         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
55         * Scripts/webkitpy/layout_tests/port/http_server.py:
56         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
57         * Scripts/webkitpy/layout_tests/port/path_utils.py:
58         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
59         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
60         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
61         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
62         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
63         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
64         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
65
66 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
67
68         Rubber-stamped by Eric Siedel.
69
70         Rename files as part of refactoring the layout_tests package. All
71         the platform_utils* module, the path_utils.py module, and
72         the http server and web socket server modules are moved into a new
73         port/ package.
74
75         https://bugs.webkit.org/show_bug.cgi?id=34511
76
77         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Removed.
78         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Removed.
79         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Removed.
80         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Removed.
81         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
82         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
83         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Removed.
84         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Removed.
85         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Removed.
86         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Removed.
87         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Removed.
88         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Removed.
89         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
90         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
91         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
92         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Removed.
93         * Scripts/webkitpy/layout_tests/port: Added.
94         * Scripts/webkitpy/layout_tests/port/__init__.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
95         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
96         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
97         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
98         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
99         * Scripts/webkitpy/layout_tests/port/http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server.py.
100         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
101         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Copied from Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
102         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Copied from Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
103         * Scripts/webkitpy/layout_tests/port/path_utils.py: Copied from Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
104         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
105         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
106         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
107         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
108         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
109         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
110         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
111
112
113 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
114
115         Rubber-stamped by Eric Seidel.
116
117         Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
118         https://bugs.webkit.org/show_bug.cgi?id=34399
119
120         * Scripts/run-iexploder-tests:
121         * Scripts/run-webkit-httpd:
122         * Scripts/run-webkit-tests:
123         * Scripts/webkitperl/httpd.pm: Added.
124
125 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
126
127         Rubber-stamped by Eric Seidel.
128
129         Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots
130
131         * Scripts/run-iexploder-tests:
132         * Scripts/run-webkit-httpd:
133         * Scripts/run-webkit-tests:
134         * Scripts/webkitperl/httpd.pm: Removed.
135
136 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
137
138         Rubber-stamped by Ariya Hidayat.
139
140         Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
141         https://bugs.webkit.org/show_bug.cgi?id=34399
142
143         * DumpRenderTree/win/EventSender.cpp:
144         (buildModifierFlags):
145         (mouseDownCallback):
146         (mouseUpCallback):
147         (keyDownCallback):
148
149 2010-02-03  Eric Seidel  <eric@webkit.org>
150
151         No review, just fixing copyrights.
152
153         Concerns were expressed about "The Chromium Authors" being
154         a valid legal entity for copyright assignment in the WebKit repository,
155         so this change removes all "The Chromium Authors".
156
157         I looked at the svn logs in src.chromium.org and failed to find any
158         non-google contributions to these files, so they are all now
159         marked as copyright "Google Inc" as all Google contributers assign
160         copyright to "Google Inc" as part of their employment agreement.
161
162         * Scripts/rebaseline-chromium-webkit-tests:
163         * Scripts/run-chromium-webkit-tests:
164         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
165         * Scripts/webkitpy/layout_tests/layout_package/http_server.py:
166         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
167         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
168         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
169         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
170         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
171         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
172         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
173         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
174         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
175         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
176         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
177         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
178         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
179         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
180         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
181         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
182         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
183         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
184         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
185         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
186
187 2010-02-03  Kenneth Rohde Christiansen  <kenneth@webkit.org>
188
189         Reviewed by Ariya Hidayat.
190
191         [Qt] QtLauncher, refactor argument handling in preparation of merge
192         with QGVLauncher
193
194         * QtLauncher/main.cpp:
195         (LauncherApplication::urls):
196         (LauncherApplication::isRobotized):
197         (LauncherApplication::applyDefaultSettings):
198         (LauncherApplication::LauncherApplication):
199         (LauncherApplication::formatKeys):
200         (LauncherApplication::enumToKeys):
201         (fail):
202         (LauncherApplication::handleUserOptions):
203         (main):
204
205 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
206
207         Rubber-stamped by Ariya Hidayat.
208
209         Rolling out r53889, because it might caused flakeyness on the Windows Test bots
210         https://bugs.webkit.org/show_bug.cgi?id=34399
211
212         * DumpRenderTree/win/EventSender.cpp:
213         (mouseDownCallback):
214         (mouseUpCallback):
215         (keyDownCallback):
216
217 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
218
219         Reviewed by Ariya Hidayat.
220
221         [Qt] Fix pixel tests support.
222         https://bugs.webkit.org/show_bug.cgi?id=27813
223
224         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
225         (WebCore::DumpRenderTree::open):
226         (WebCore::DumpRenderTree::processLine):
227          - Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.
228         (WebCore::DumpRenderTree::dump): Fixed and renamed variables.
229
230 2010-02-03  Kevin Watters  <kevinwatters@gmail.com>
231
232         Reviewed by Kevin Ollivier.
233
234         [wx] Enable JIT compilation for wx.
235         
236         https://bugs.webkit.org/show_bug.cgi?id=34536
237
238         * wx/build/settings.py:
239
240 2010-02-02  Kevin Ollivier  <kevino@theolliviers.com>
241
242         [wx] Build fix after introduction of pageNumberForElementById.
243
244         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
245         (LayoutTestController::pageNumberForElementById):
246
247 2010-02-02  Shu Chang  <Chang.Shu@nokia.com>
248
249         Unreviewed.
250
251         Add myself to list of committers.
252
253         * Scripts/webkitpy/committers.py:
254
255 2010-02-02  Chris Jerdonek  <cjerdonek@webkit.org>
256
257         Reviewed by Shinichiro Hamaji.
258
259         Moved filter-related check-webkit-style code into a separate
260         filter module.
261
262         https://bugs.webkit.org/show_bug.cgi?id=34408
263
264         This is preparatory refactoring for Bug 33684, which will allow
265         file and folder-specific filter rules.
266
267         * Scripts/webkitpy/style/checker.py:
268           - Removed CategoryFilter class (moved to filter.py).
269
270         * Scripts/webkitpy/style/checker_unittest.py:
271           - Removed CategoryFilter unit tests (moved to filter_unittest.py).
272
273         * Scripts/webkitpy/style/filter.py: Added.
274           - Added CategoryFilter class (moved from checker.py).
275
276         * Scripts/webkitpy/style/filter_unittest.py: Added.
277           - Added CategoryFilter unit tests (moved from checker_unittest.py).
278
279         * Scripts/webkitpy/style/unittests.py:
280           - Added reference to filter_unittest.py.
281
282 2010-02-01  Chris Jerdonek  <cjerdonek@webkit.org>
283
284         Reviewed by Shinichiro Hamaji.
285
286         Addressed FIXME in check-webkit-style so that the carriage-return
287         check will work for patches.
288
289         https://bugs.webkit.org/show_bug.cgi?id=34260
290
291         Also added support for limiting the number of errors reported
292         per category, per file.
293
294         * Scripts/webkitpy/style/checker.py:
295           - Added new "whitespace/carriage_return" category from common.py.
296           - Added MAX_REPORTS_PER_CATEGORY dictionary.
297           - Added max_reports_per_category attribute to ProcessorOptions class.
298           - Refactored StyleChecker._process_file().
299
300         * Scripts/webkitpy/style/checker_unittest.py:
301           - Updated ProcessorOptionsTest tests.
302           - Added test to check MAX_REPORTS_PER_CATEGORY.
303
304         * Scripts/webkitpy/style/error_handlers.py:
305           - Added support for suppressing the display of errors after
306             reaching a per-category maximum (from max_reports_per_category).
307
308         * Scripts/webkitpy/style/error_handlers_unittest.py:
309           - Added test for suppressing error display.
310
311         * Scripts/webkitpy/style/processors/common.py: Added.
312           - Moved carriage-return check to new file.
313
314         * Scripts/webkitpy/style/processors/common_unittest.py: Added.
315           - Added unit tests for carriage-return check.
316
317         * Scripts/webkitpy/style/unittests.py:
318           - Added reference to common_unittest.py.
319
320 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
321
322         Reviewed by Eric Seidel.
323
324         Provide a way to get page number with layoutTestController
325         https://bugs.webkit.org/show_bug.cgi?id=33840
326
327         * DumpRenderTree/LayoutTestController.cpp:
328         (pageNumberForElementByIdCallback):
329         (LayoutTestController::staticFunctions):
330         * DumpRenderTree/LayoutTestController.h:
331         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
332         (LayoutTestController::pageNumberForElementById):
333         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
334         (LayoutTestController::pageNumberForElementById):
335         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
336         (LayoutTestController::pageNumberForElementById):
337
338 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
339
340         Unreviewed fix for an invalid function call.
341
342         check-webkit-style: Remove filename parameter from all functions where no longer used
343         https://bugs.webkit.org/show_bug.cgi?id=34249
344
345         * Scripts/webkitpy/style/checker.py:
346
347 2010-02-01  Diego Gonzalez  <diego.gonzalez@openbossa.org>
348
349         Reviewed by Kenneth Rohde Christiansen.
350
351         [Qt] DRT Provide global flag ability
352         https://bugs.webkit.org/show_bug.cgi?id=34418
353
354         Add the globalFlag property to the Qt LayoutTestController to allow
355         cross-domain indications.
356
357         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
358         (LayoutTestController::reset):
359         * DumpRenderTree/qt/LayoutTestControllerQt.h:
360         (LayoutTestController::globalFlag):
361         (LayoutTestController::setGlobalFlag):
362
363 2010-02-01  Brady Eidson  <beidson@apple.com>
364
365         Reviewed by Adele Peterson.
366
367         Crash in Safari opening new tabs to "same page"
368         <rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444
369
370         Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:
371
372         * DumpRenderTree/LayoutTestController.cpp:
373         (LayoutTestController::LayoutTestController):
374         (setNewWindowsCopyBackForwardListCallback):
375         (LayoutTestController::staticFunctions):
376
377         * DumpRenderTree/LayoutTestController.h:
378         (LayoutTestController::newWindowsCopyBackForwardList):
379         (LayoutTestController::setNewWindowsCopyBackForwardList):
380
381         * DumpRenderTree/mac/UIDelegate.mm:
382         (-[UIDelegate webView:createWebViewWithRequest:]):
383
384 2010-02-01  Carol Szabo  <carol.szabo@nokia.com>
385
386         Unreviewed.
387
388         Add myself to list of committers.
389
390         * Scripts/webkitpy/committers.py:
391
392 2010-02-01  Nate Chapin  <japhet@chromium.org>
393
394         Rubber-stamped by David Levin.
395
396         Add myself to reviewer list.
397
398         * Scripts/webkitpy/committers.py:
399
400 2010-01-31  Chris Jerdonek  <cjerdonek@webkit.org>
401
402         Reviewed by Shinichiro Hamaji.
403
404         Moved style error handler code to their own classes, and
405         related refactoring. Increased unit test code coverage of
406         style error handling.
407
408         https://bugs.webkit.org/show_bug.cgi?id=34379
409
410         * Scripts/check-webkit-style:
411           - Minor change: added error_count variable.
412
413         * Scripts/webkitpy/style/checker.py:
414           - Renamed ProcessorOptions.should_report_error() to is_reportable().
415           - In the StyleChecker class--
416             - Removed _default_style_error_handler().
417             - Added _increment_error_count().
418             - Refactored to use DefaultStyleErrorHandler and
419               PatchStyleErrorHandler constructors.
420
421         * Scripts/webkitpy/style/checker_unittest.py:
422           - In the StyleStyleCheckerTest class--
423             - Removed write_sample_error().
424             - Removed test_default_style_error_handler().
425
426         * Scripts/webkitpy/style/error_handlers.py: Added.
427           - Added DefaultStyleErrorHandler class.
428           - Added PatchStyleErrorHandler class.
429
430         * Scripts/webkitpy/style/error_handlers_unittest.py: Added.
431           - Added unit tests for DefaultStyleErrorHandler and
432             PatchStyleErrorHandler.
433
434         * Scripts/webkitpy/style/unittests.py:
435           - Added error_handlers unit tests.
436
437 2010-01-29  Mark Rowe  <mrowe@apple.com>
438
439         Rubber-stamped by Stephanie Lewis.
440
441         Fix run-leaks with newer versions of the leaks tool.
442
443         * Scripts/run-leaks:
444
445 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
446
447         Reviewed by Eric Siedel.
448
449         Top-level test drivers for running the Chromium port of run-webkit-tests
450         and being able to rebaseline test results from the test bots.  The
451         files in the Scripts directory are simply wrappers around the files
452         in webkitpy/layout_tests for convenience.
453  
454         https://bugs.webkit.org/show_bug.cgi?id=31498
455
456         * Scripts/rebaseline-chromium-webkit-tests: Added.
457         * Scripts/run-chromium-webkit-tests: Added.
458         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added.
459         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added.
460
461 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
462
463         Reviewed by Eric Siedel.
464
465         Add in the second block of python code for the Chromium port
466         of run-webkit-tests. These files execute different diffs to classify
467         the various types of failures from a test.
468
469         * Scripts/webkitpy/layout_tests/test_types: Added.
470         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Added.
471         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added.
472         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added.
473         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added.
474         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added.
475
476 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
477
478         Reviewed by Eric Siedel.
479
480         Check in the first part of the Chromium Python port of the 
481         run-webkit-tests test driver. The files under 
482         layout_tests/layout_layout constitute most of the implementation;
483         they can be roughly divided into code that parses the 
484         "test_expectations.txt" file that describes how we expect tests to
485         pass or fail, platform-specific hooks for the different Chromium 
486         ports (in platform_utils*), code for parsing the output of the
487         tests and generating results files and HTML and JSON for the
488         dashboards, auxiliary scripts for starting and stopping HTTP and
489         Web Socket servers, and then one of the actual driver files 
490         (test_shell_thread). Code for actually parsing test output for 
491         failures and the top-level driver scripts will follow shortly.
492
493         https://bugs.webkit.org/show_bug.cgi?id=31498
494
495         * Scripts/webkitpy/layout_tests: Added.
496         * Scripts/webkitpy/layout_tests/layout_package: Added.
497         * Scripts/webkitpy/layout_tests/layout_package/__init__.py: Added.
498         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added.
499         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added.
500         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added.
501         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added.
502           - scripts to start and stop apache. Note that the apache file
503             generates a conf file dynamically, and we should switch to 
504             using the same static conf file that the regular run-webkit-tests
505             uses, and we can also use the same httpd2.pem file.
506
507         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added.
508         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added.
509           - scripts to generate the JSON layout test dashboard and the
510             flakiness dashboard
511         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added.
512           - default configuration for LigHTTPd (used on Windows)
513         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added.
514           - utility class that implements progress bars on the console to
515             be displayed while the tests are running
516         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added.
517           - various routines for manipulating paths and URIs
518         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added.
519         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added.
520         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added.
521         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added.
522           - platform-specific aspects of the drivers (binary names, paths,
523             process control, etc.)
524         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added.
525           - code for parsing the 'test_expectations.txt' file to determine
526             which tests are expected to fail (and how) on which platforms
527         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added.
528           - code for handling different kinds of failures (generating output
529             in the results, etc.)
530         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added.
531           - code to gather the lists of tests
532         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added.
533           - code to actually execute tests via TestShell and process
534             the output
535         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added.
536           - scripts to start and stop the pywebsocket server
537
538 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
539
540         Reviewed by Eric Seidel.
541
542         Check in a copy of the simplejson library; it will be used by
543         the Chromium port of run-webkit-tests.
544         
545         https://bugs.webkit.org/show_bug.cgi?id=31498
546
547         * simplejson: Added.
548         * simplejson/LICENSE.txt: Added.
549         * simplejson/README.txt: Added.
550         * simplejson/__init__.py: Added.
551         * simplejson/_speedups.c: Added.
552         (ascii_escape_char):
553         (ascii_escape_unicode):
554         (ascii_escape_str):
555         (py_encode_basestring_ascii):
556         (init_speedups):
557         * simplejson/decoder.py: Added.
558         * simplejson/encoder.py: Added.
559         * simplejson/jsonfilter.py: Added.
560         * simplejson/scanner.py: Added.
561
562 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
563
564         No review
565
566         Add myself to the committers list
567
568         * Scripts/webkitpy/committers.py:
569
570 2010-01-29  Jeremy Orlow  <jorlow@chromium.org>
571
572         Reviewed by Dimitri Glazkov.
573
574         A first step towards the Indexed Database API
575         https://bugs.webkit.org/show_bug.cgi?id=34342
576
577         Add indexed database API.
578
579         * Scripts/build-webkit:
580
581 2010-01-29  Andras Becsi  <abecsi@webkit.org>
582
583         Reviewed by Alexey Proskuryakov.
584
585         Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
586         This fixes a regression introduced in r53559.
587
588         https://bugs.webkit.org/show_bug.cgi?id=34336
589
590         * Scripts/webkitperl/httpd.pm:
591
592 2010-01-28  Jon Honeycutt  <jhoneycutt@apple.com>
593
594         MSAA: Crash when posting a notification for a detached object
595
596         https://bugs.webkit.org/show_bug.cgi?id=34309
597         <rdar://problem/7409759>
598
599         Reviewed by Darin Adler.
600
601         * DumpRenderTree/AccessibilityController.h:
602         Declare new functions. Add new members to store the event hook and the
603         mapping of accessibility elements to their JS callbacks.
604
605         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
606         (AccessibilityController::notificationReceived):
607         Stubbed.
608         (AccessibilityController::addNotificationListener):
609         Stubbed.
610
611         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
612         (AccessibilityController::notificationReceived):
613         Stubbed.
614         (AccessibilityController::addNotificationListener):
615         Stubbed.
616
617         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
618         (AccessibilityController::AccessibilityController):
619         Initialize the event hook.
620         (AccessibilityController::~AccessibilityController):
621         Remove the event hook. Unprotect all of the JS functions that are stored
622         in the map.
623         (logEventProc):
624         Clean-up a variable.
625         (stringEvent):
626         Return a string description of the MSAA event code.
627         (notificationListenerProc):
628         Get the accessible object from the event, and query it for IAccessible.
629         Call the AccessibilityController's notificationReceived().
630         (comparableObject):
631         Use QueryService to obtain the IAccessibleComparable for the
632         IServiceProvider.
633         (AccessibilityController::notificationReceived):
634         Iterate the map of objects that have registered for notification
635         callbacks. Query each for IServiceProvider, then use comparableObject()
636         to get an IAccessibleComparable. If we find an object matching the
637         notified object, call its callback, passing the event that was received.
638         (AccessibilityController::addNotificationListener):
639         If we have not created the event hook, create it. Protect the JS
640         callback function object, and add the object and its callback to our
641         map.
642
643         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
644         (AccessibilityUIElement::addNotificationListener):
645         Call through to the AccessibilityController's addNotificationListener().
646
647         * DumpRenderTree/win/DumpRenderTreeWin.h:
648         Add an extern declaration for the shared FrameLoadDelegate extern, so we
649         can access it from AccessibilityController.
650
651         * DumpRenderTree/win/FrameLoadDelegate.h:
652         (FrameLoadDelegate::accessibilityController):
653         Return the AccessibilityController.
654
655 2010-01-29  Shinichiro Hamaji  <hamaji@chromium.org>
656
657         Reviewed by Darin Adler.
658
659         prepare-ChangeLog outputs useless messages for a nonexistent bug ID
660         https://bugs.webkit.org/show_bug.cgi?id=34313
661
662         * Scripts/prepare-ChangeLog:
663
664 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
665
666         Rubberstamped by Simon Hausmann.
667
668         [Qt] Separate implementation from class definition.
669
670         * QtLauncher/main.cpp:
671         (LauncherWindow::webView):
672         (LauncherWindow::LauncherWindow):
673         (LauncherWindow::~LauncherWindow):
674         (LauncherWindow::keyPressEvent):
675         (LauncherWindow::grabZoomKeys):
676         (LauncherWindow::sendTouchEvent):
677         (LauncherWindow::eventFilter):
678         (LauncherWindow::loadStarted):
679         (LauncherWindow::loadFinished):
680         (LauncherWindow::showLinkHover):
681         (LauncherWindow::zoomIn):
682         (LauncherWindow::zoomOut):
683         (LauncherWindow::resetZoom):
684         (LauncherWindow::toggleZoomTextOnly):
685         (LauncherWindow::print):
686         (LauncherWindow::screenshot):
687         (LauncherWindow::setEditable):
688         (LauncherWindow::dumpHtml):
689         (LauncherWindow::selectElements):
690         (LauncherWindow::setTouchMocking):
691         (LauncherWindow::newWindow):
692         (LauncherWindow::setupUI):
693
694 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
695
696         Reviewed by Ariya Hidayat.
697
698         [Qt] On Maemo5, a click/touch in the location bar (when unfocused)
699         should result in all text selected.
700
701         * QtLauncher/locationedit.cpp:
702         (LocationEdit::focusInEvent):
703         * QtLauncher/locationedit.h:
704
705 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
706
707         Reviewed by Ariya Hidayat.
708
709         [Qt] Show progress reaching 100% for loads.
710
711         * QtLauncher/locationedit.cpp:
712         (LocationEdit::LocationEdit):
713         (LocationEdit::setProgress):
714         (LocationEdit::reset):
715         (LocationEdit::paintEvent):
716         * QtLauncher/locationedit.h:
717
718 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
719
720         Reviewed by Kenneth Rohde Christiansen.
721
722         [Qt] Disable the QtLauncher statusbar on Maemo
723
724         https://bugs.webkit.org/show_bug.cgi?id=34330
725
726         * QtLauncher/main.cpp:
727         (LauncherWindow::showLinkHover):
728         (LauncherWindow::selectElements):
729
730 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
731
732         Reviewed by Kenneth Rohde Christiansen.
733
734         [Qt] Display page loading progress inside the QtLauncher location bar
735
736         https://bugs.webkit.org/show_bug.cgi?id=34210
737
738         * QtLauncher/QtLauncher.pro:
739         * QtLauncher/locationedit.cpp: Added.
740         (LocationEdit::LocationEdit):
741         (LocationEdit::setProgress):
742         (LocationEdit::paintEvent):
743         * QtLauncher/locationedit.h: Added.
744         * QtLauncher/mainwindow.cpp:
745         (MainWindow::buildUI):
746         * QtLauncher/mainwindow.h:
747
748 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
749
750         Reviewed by Kenneth Rohde Christiansen.
751
752         [Qt] Add support for Maemo zoom keys in QtLauncher
753
754         https://bugs.webkit.org/show_bug.cgi?id=34160
755
756         * QtLauncher/main.cpp:
757         (LauncherWindow::LauncherWindow):
758         (LauncherWindow::~LauncherWindow):
759         (LauncherWindow::keyPressEvent):
760         (LauncherWindow::grabZoomKeys):
761
762 2010-01-29  Benjamin Poulain  <benjamin.poulain@nokia.com>
763
764         Reviewed by Kenneth Rohde Christiansen.
765
766         [Qt] Implement the display() method of the layout test controller
767         https://bugs.webkit.org/show_bug.cgi?id=34258
768
769         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
770         (WebCore::DumpRenderTree::DumpRenderTree):
771         (WebCore::DumpRenderTree::showPage):
772         (WebCore::DumpRenderTree::hidePage):
773         * DumpRenderTree/qt/DumpRenderTreeQt.h:
774         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
775         (LayoutTestController::reset):
776         (LayoutTestController::display):
777         * DumpRenderTree/qt/LayoutTestControllerQt.h:
778
779 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
780
781         [wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
782         implements pthread_t in a way that makes it impossible to check its validity,
783         which is needed by ThreadingPthreads.cpp.
784
785         * DumpRenderTree/wscript:
786         * wx/build/settings.py:
787
788 2010-01-28  Andras Becsi  <abecsi@webkit.org>
789
790         Adding myself to the committer list. No review needed.
791
792         * Scripts/webkitpy/committers.py:
793
794 2010-01-28  Hayato Ito  <hayato@chromium.org>
795
796         Reviewed by David Levin.
797
798         Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
799
800         https://bugs.webkit.org/show_bug.cgi?id=34252
801
802         * Scripts/make-script-test-wrappers:
803
804 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
805
806         [wx] Build fix after removal of the zlib image decoder.
807
808         * wx/build/settings.py:
809
810 2010-01-28  Csaba Osztrogonác  <ossy@webkit.org>
811
812         [Qt] Unreviewed, roll out r54000.
813
814         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
815         (WebCore::DumpRenderTree::DumpRenderTree):
816         * DumpRenderTree/qt/DumpRenderTreeQt.h:
817         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
818         (LayoutTestController::reset):
819         * DumpRenderTree/qt/LayoutTestControllerQt.h:
820         (LayoutTestController::display):
821
822 2010-01-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
823
824         Reviewed by Kenneth Rohde Christiansen.
825
826         [Qt] Implement the display() method of the layout test controller
827         https://bugs.webkit.org/show_bug.cgi?id=34258
828
829         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
830         (WebCore::DumpRenderTree::DumpRenderTree):
831         (WebCore::DumpRenderTree::showPage):
832         (WebCore::DumpRenderTree::hidePage):
833         * DumpRenderTree/qt/DumpRenderTreeQt.h:
834         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
835         (LayoutTestController::reset):
836         (LayoutTestController::display):
837         * DumpRenderTree/qt/LayoutTestControllerQt.h:
838
839 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
840
841         Reviewed by Shinichiro Hamaji.
842
843         Eliminated the filename parameter from functions in
844         check-webkit-style's cpp.py where it is no longer used.
845
846         https://bugs.webkit.org/show_bug.cgi?id=34249
847
848         * Scripts/webkitpy/style/processors/cpp.py:
849           - Reduced number of occurrences of "filename" variable from
850             approximately 200 to 120.
851
852         * Scripts/webkitpy/style/processors/cpp_unittest.py:
853           - Refactored unit tests as necessary to accommodate changes to cpp.py.
854           - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
855             where the incorrect file extension was getting passed to
856             cpp_style.check_language().
857
858 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
859
860         Reviewed by Shinichiro Hamaji.
861
862         In check-webkit-style, eliminated the dependency of
863         processors/cpp_unittest.py on checker.py.
864
865         https://bugs.webkit.org/show_bug.cgi?id=34205
866
867         * Scripts/webkitpy/style/checker.py:
868           - Addressed FIXME by removing STYLE_CATEGORIES data.
869           - Added style_categories().
870
871         * Scripts/webkitpy/style/checker_unittest.py:
872           - Minor changes.
873
874         * Scripts/webkitpy/style/processors/cpp.py:
875           - Added categories attribute to CppProcessor class (data
876             was originally checker.STYLE_CATEGORIES).
877
878         * Scripts/webkitpy/style/processors/cpp_unittest.py:
879           - Addressed FIXME by eliminating "import" from checker.py.
880
881 2010-01-28  Anton Muhin  <antonm@chromium.org>
882
883         Reviewed by Shinichiro Hamaji.
884
885         Improve treatment of conditions and rest of the line for if, else, switch and alikes
886         https://bugs.webkit.org/show_bug.cgi?id=34173
887
888         * Scripts/webkitpy/style/cpp_style.py:
889         * Scripts/webkitpy/style/cpp_style_unittest.py:
890
891 2010-01-28  Joe Mason  <jmason@rim.com>
892
893         Reviewed by Adam Barth.
894
895         Limit login retries to 5
896         https://bugs.webkit.org/show_bug.cgi?id=34193
897
898         * Scripts/webkitpy/bugzilla.py:
899
900 2010-01-27  Martin Robinson  <mrobinson@webkit.org>
901
902         Adding myself to the committer list. No review necessary.
903
904         * Scripts/webkitpy/committers.py:
905
906 2010-01-27  George Wright  <gwright@rim.com>
907
908         Reviewed by Adam Treat.
909
910         https://bugs.webkit.org/show_bug.cgi?id=34216
911
912         Add missing include for wtf/Platform.h
913
914         * DumpRenderTree/AccessibilityController.h:
915
916 2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
917
918         Reviewed by Kenneth Rohde Christiansen.
919
920         [Qt] DRT Provide worker thread ability to track counters
921         https://bugs.webkit.org/show_bug.cgi?id=34221
922
923         Implement workerThreadCount() in LayoutTestController of Qt DRT
924
925         Tests:
926         fast/workers/dedicated-worker-lifecycle.html
927         fast/workers/shared-worker-frame-lifecycle.html
928         fast/workers/shared-worker-lifecycle.html
929         fast/workers/worker-lifecycle.html
930
931         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
932         (LayoutTestController::workerThreadCount):
933         * DumpRenderTree/qt/LayoutTestControllerQt.h:
934
935 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
936
937         Rubberstamped by Simon Hausmann.
938
939         [Qt] QtLauncher refactoring:
940
941         Make the LauncherWindow depend less on the view, so that more
942         code can be shared in near future.
943
944         * QtLauncher/main.cpp:
945         (LauncherWindow::sendTouchEvent):
946         (LauncherWindow::loadFinished):
947         (LauncherWindow::zoomIn):
948         (LauncherWindow::zoomOut):
949         (LauncherWindow::resetZoom):
950         (LauncherWindow::toggleZoomTextOnly):
951         (LauncherWindow::dumpHtml):
952         (LauncherWindow::selectElements):
953         (LauncherWindow::setupUI):
954
955 2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
956
957         Reviewed by Eric Seidel.
958
959         Correctly handle the KeyLocation argument that has been introduced
960         recently to test location-dependent key events in EventSender.keyDown.
961         http://bugs.webkit.org/show_bug.cgi?id=28247
962
963         Test: fast/events/keydown-numpad-keys.html
964
965         * DumpRenderTree/gtk/EventSender.cpp:
966         (keyDownCallback):
967
968 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
969
970         Rubberstamped by Simon Hausmann.
971
972         [Qt] QtLauncher refactoring:
973
974         Move out code from the MainWindow (renamed to LauncherWindow)
975         that is not depending on the view, and add it to a new class
976         called MainWindow.
977
978         * QtLauncher/QtLauncher.pro:
979         * QtLauncher/main.cpp:
980         (LauncherWindow::LauncherWindow):
981         (LauncherWindow::eventFilter):
982         (LauncherWindow::loadStarted):
983         (LauncherWindow::loadFinished):
984         (LauncherWindow::newWindow):
985         (LauncherWindow::setupUI):
986         (WebPage::createWindow):
987         (main):
988         * QtLauncher/mainwindow.cpp: Added.
989         (MainWindow::MainWindow):
990         (MainWindow::buildUI):
991         (MainWindow::page):
992         (MainWindow::setAddressUrl):
993         (MainWindow::addCompleterEntry):
994         (MainWindow::load):
995         (MainWindow::changeLocation):
996         (MainWindow::openFile):
997         * QtLauncher/mainwindow.h: Added.
998
999 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1000
1001         Rubberstamped by Simon Hausmann.
1002
1003         [Qt] QtLauncher, coding style fixes.
1004
1005         * QtLauncher/main.cpp:
1006         (MainWindow::MainWindow):
1007         (MainWindow::sendTouchEvent):
1008         (MainWindow::eventFilter):
1009         (MainWindow::loadURL):
1010         (MainWindow::setupUI):
1011         (WebPage::createPlugin):
1012
1013 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1014
1015         Rubberstamped by Simon Hausmann.
1016
1017         [Qt] QtLauncher refactoring, separating the webview and
1018         adding a QGraphicsWebView based version.
1019
1020         * QtLauncher/QtLauncher.pro:
1021         * QtLauncher/main.cpp:
1022         (MainWindow::MainWindow):
1023         * QtLauncher/webpage.h:
1024         * QtLauncher/webview.cpp: Added.
1025         (createContextMenu):
1026         (WebViewGraphicsBased::mousePressEvent):
1027         (WebViewTraditional::mousePressEvent):
1028         (WebViewGraphicsBased::contextMenuEvent):
1029         (WebViewTraditional::contextMenuEvent):
1030         * QtLauncher/webview.h: Added.
1031         (WebViewGraphicsBased::WebViewGraphicsBased):
1032         (WebViewTraditional::WebViewTraditional):
1033
1034 2010-01-27  Alexander Pavlov  <apavlov@chromium.org>
1035
1036         Adding myself as committer. No review necessary.
1037
1038         * Scripts/webkitpy/committers.py:
1039
1040 2010-01-27  Eric Seidel  <eric@webkit.org>
1041
1042         Reviewed by Darin Adler.
1043
1044         webkit-patch needs an open-bugs command
1045         https://bugs.webkit.org/show_bug.cgi?id=30793
1046
1047         * Scripts/test-webkitpy: import OpenBugsTest
1048         * Scripts/webkit-patch: import OpenBugs
1049         * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
1050         * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
1051         * Scripts/webkitpy/commands/queries_unittest.py: ditto
1052         * Scripts/webkitpy/commands/queues_unittest.py: ditto
1053         * Scripts/webkitpy/commands/upload_unittest.py: ditto
1054         * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
1055
1056 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1057
1058         Rubberstamped by Simon Hausmann
1059
1060         [Qt] QtLauncher refactoring, separating utility methods.
1061
1062         * QtLauncher/QtLauncher.pro:
1063         * QtLauncher/main.cpp:
1064         * QtLauncher/utils.cpp: Added.
1065         (urlFromUserInput):
1066         * QtLauncher/utils.h: Added.
1067
1068 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1069
1070         Rubberstamped by Simon Hausmann
1071
1072         [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
1073
1074         * QtLauncher/main.cpp:
1075         (MainWindow::MainWindow):
1076         * QtLauncher/webpage.cpp:
1077         (WebPage::WebPage):
1078         (WebPage::applyProxy):
1079         * QtLauncher/webpage.h:
1080
1081 2010-01-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1082
1083         Reviewed by Tor Arne Vestbø.
1084
1085         [Qt] Corrects debug build of DumpRenderTree on Windows.
1086
1087         * DumpRenderTree/qt/DumpRenderTree.pro:
1088
1089 2010-01-26  Daniel Bates  <dbates@webkit.org>
1090
1091         Reviewed by Adam Barth.
1092
1093         https://bugs.webkit.org/show_bug.cgi?id=34070
1094
1095         Moves the try/catch for OSError exceptions in Executive.run_command
1096         to Credentials.read_credentials() so that the unit test
1097         webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
1098         assert that Executive.run_command throws an OSError exception.
1099
1100         * Scripts/webkitpy/credentials.py:
1101         * Scripts/webkitpy/executive.py: Moved try/catch for OSError to
1102         method Credentials.read_credentials().
1103         * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer
1104         apply: test_run_command_with_bad_command_check_return_code and
1105         test_run_command_with_bad_command_check_calls_error_handler. Added new
1106         test to assert that run_command throws OSError exceptions.
1107
1108 2010-01-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1109
1110         Reviewed by Kenneth Rohde Christiansen.
1111
1112         [Qt] DRT WebHistory support
1113         https://bugs.webkit.org/show_bug.cgi?id=34167
1114
1115         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1116         (LayoutTestController::reset):
1117         (LayoutTestController::webHistoryItemCount):
1118         (LayoutTestController::keepWebHistory):
1119         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1120
1121 2010-01-26  Kent Tamura  <tkent@chromium.org>
1122
1123         Reviewed by Eric Seidel.
1124
1125         [Win] Add modifiers parameter support to Windows DumpRenderTree
1126         https://bugs.webkit.org/show_bug.cgi?id=34068
1127
1128         Add support for functional name modifiers; "addSelectionKey" and
1129         "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
1130         and eventSender.mouseUp().
1131         This change is similar to r53498 for Mac.
1132         
1133         * DumpRenderTree/win/EventSender.cpp:
1134         (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM.
1135         (mouseDownCallback): Call buidlModifiersFlags().
1136         (mouseUpCallback): ditto.
1137         (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
1138
1139 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
1140
1141         Reviewed by Eric Seidel.
1142
1143         The Python autoinstall cache directory now only gets created
1144         in the directory containing autoinstall.py.
1145
1146         https://bugs.webkit.org/show_bug.cgi?id=33365
1147
1148         * Scripts/webkitpy/autoinstall.py:
1149           - Also added a README file to the cache directory saying
1150             where it came from.
1151
1152 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
1153
1154         Reviewed by Eric Seidel.
1155
1156         Moved the check-webkit-style processors into a new
1157         webkitpy/style/processors directory.
1158
1159         https://bugs.webkit.org/show_bug.cgi?id=34060
1160
1161         * Scripts/webkitpy/style/checker.py:
1162         * Scripts/webkitpy/style/checker_unittest.py:
1163         * Scripts/webkitpy/style/cpp_style.py: Removed.
1164         * Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
1165         * Scripts/webkitpy/style/processors: Added.
1166         * Scripts/webkitpy/style/processors/__init__.py: Added.
1167         * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
1168         * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
1169         * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
1170         * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
1171         * Scripts/webkitpy/style/text_style.py: Removed.
1172         * Scripts/webkitpy/style/text_style_unittest.py: Removed.
1173         * Scripts/webkitpy/style/unittests.py:
1174
1175 2010-01-26  Kevin Ollivier  <kevino@theolliviers.com>
1176
1177         [wx] Build fix, make sure stub function returns a value.
1178
1179         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1180         (LayoutTestController::counterValueForElementById):
1181
1182 2010-01-26  Steve Falkenburg  <sfalken@apple.com>
1183
1184         Reviewed by Oliver Hunt.
1185
1186         Windows build references non-existent include paths
1187         https://bugs.webkit.org/show_bug.cgi?id=34175
1188
1189         * DumpRenderTree/win/DumpRenderTree.vcproj:
1190         * DumpRenderTree/win/ImageDiff.vcproj:
1191         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1192
1193 2010-01-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1194
1195         Reviewed by Ariya Hidayat.
1196
1197         [Qt] Separating out the UrlLoader from the QtLauncher in it's
1198         own implementation and header file.
1199
1200         * QtLauncher/main.cpp:
1201         (main):
1202         * QtLauncher/urlloader.cpp: Added.
1203         (UrlLoader::UrlLoader):
1204         (UrlLoader::loadNext):
1205         (UrlLoader::init):
1206         (UrlLoader::getUrl):
1207         * QtLauncher/urlloader.h: Added.
1208
1209 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
1210
1211         Reviewed by Shinichiro Hamaji.
1212
1213         Refactored check-webkit-style by removing the file path
1214         parameter from the style error handler functions.
1215
1216         https://bugs.webkit.org/show_bug.cgi?id=34031
1217
1218         * Scripts/webkitpy/style/checker.py:
1219           - Added _default_style_error_handler() to StyleChecker class.
1220           - Moved handle_style_error() to inside _default_style_error_handler().
1221
1222         * Scripts/webkitpy/style/checker_unittest.py:
1223           - Removed file path from calls to error handler.
1224
1225         * Scripts/webkitpy/style/cpp_style.py:
1226           - Removed file path from calls to error handler.
1227
1228         * Scripts/webkitpy/style/cpp_style_unittest.py:
1229           - Removed file path from calls to error handler.
1230
1231         * Scripts/webkitpy/style/text_style.py:
1232           - Removed file path from calls to error handler.
1233
1234         * Scripts/webkitpy/style/text_style_unittest.py:
1235           - Removed file path from calls to error handler.
1236
1237 2010-01-25  Jeremy Orlow  <jorlow@chromium.org>
1238
1239         Adding myself as reviewer.  No review necessary.
1240
1241         * Scripts/webkitpy/committers.py:
1242
1243 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
1244
1245         Reviewed by Adam Barth.
1246
1247         Improved prepare-ChangeLog so that it preserves the relative
1248         indentation of a git commit message.
1249
1250         https://bugs.webkit.org/show_bug.cgi?id=34058
1251
1252         * Scripts/prepare-ChangeLog:
1253           - Also adjusted the script so that it does not add white
1254             space characters to empty lines.
1255
1256 2010-01-24  Eric Seidel  <eric@webkit.org>
1257
1258         No review, rolling out r53763.
1259         http://trac.webkit.org/changeset/53763
1260         https://bugs.webkit.org/show_bug.cgi?id=33895
1261
1262         Broke 20+ tests on Windows.
1263
1264         * Scripts/run-webkit-tests:
1265         * Scripts/webkitdirs.pm:
1266
1267 2010-01-24  Adam Barth  <abarth@webkit.org>
1268
1269         Rubber stamped by Eric Seidel.
1270
1271         More pep8 compliance.
1272
1273         * Scripts/webkitpy/mock_bugzillatool.py:
1274
1275 2010-01-24  Adam Barth  <abarth@webkit.org>
1276
1277         Rubber stamped by Eric Seidel.
1278
1279         More pep8 compliance.
1280
1281         * Scripts/webkitpy/executive.py:
1282         * Scripts/webkitpy/grammar.py:
1283
1284 2010-01-24  Adam Barth  <abarth@webkit.org>
1285
1286         Rubber stamped by Eric Seidel.
1287
1288         More pep8 compliance.
1289
1290         * Scripts/webkitpy/comments.py:
1291         * Scripts/webkitpy/committers.py:
1292         * Scripts/webkitpy/credentials.py:
1293
1294 2010-01-24  Adam Barth  <abarth@webkit.org>
1295
1296         Rubber stamped by Eric Seidel.
1297
1298         Make changelogs.py pass pep8.
1299
1300         * Scripts/webkitpy/changelogs.py:
1301
1302 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1303
1304         [Qt] Unreviewed build fix
1305
1306         * QtLauncher/QtLauncher.pro:
1307         * QtLauncher/webinspector.h:
1308
1309 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1310
1311         Rubberstamped by Simon Hausmann.
1312
1313         [Qt] Move the WebInspector class to it's own header file.
1314
1315         * QtLauncher/main.cpp:
1316         * QtLauncher/webinspector.h: Added.
1317         (WebInspector::WebInspector):
1318         (WebInspector::showEvent):
1319         (WebInspector::hideEvent):
1320
1321 2010-01-23  Robert Hogan  <robert@roberthogan.net>
1322
1323         Reviewed by Kenneth Rohde Christiansen.
1324
1325         Qt DRT: respect window.close() and window.closed()
1326         
1327         Qt DRT needs to maintain a correct count of open windows
1328         for windowCount(). It also needs to delete windows that
1329         have been closed by window.close().
1330         
1331         This fixes the following tests:
1332         
1333         plugins/destroy-during-npp-new.html
1334         fast/dom/Document/early-document-access.html
1335         fast/dom/Window/window-early-properties.html
1336         fast/events/open-window-from-another-frame.html
1337         fast/events/popup-blocking-click-in-iframe.html
1338         
1339         https://bugs.webkit.org/show_bug.cgi?id=32953
1340
1341         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1342         (WebCore::DumpRenderTree::DumpRenderTree):
1343         (WebCore::DumpRenderTree::createWindow):
1344         (WebCore::DumpRenderTree::windowCloseRequested):
1345         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1346         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1347         (LayoutTestController::maybeDump):
1348
1349 2010-01-23  Dan Bernstein  <mitz@apple.com>
1350
1351         Reviewed by Mark Rowe.
1352
1353         Added a user default for specifying a fallback frameworks path in case
1354         the bundle does not contain frameworks for the current Mac OS X version.
1355
1356         * WebKitLauncher/main.m:
1357         (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
1358         keyed by the FallbackSystemVersions user default and returns it.
1359         (main): If a frameworks directory for the current system version is not found,
1360         try the fallback.
1361
1362 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1363
1364         Reviewed by Simon Hausmann.
1365
1366         Make run-webkit-tests work under Cygwin for the Qt port
1367
1368         setPathForRunningWebKitApp() is implemented for the Qt port
1369         by using qmake to query for the location of the Qt libraries.
1370
1371         This requires the original environment (%ENV) to be untouched,
1372         so launchWithCurrentEnv() was refactored to launchWithEnv(),
1373         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
1374         instead. This has the added benefit of getting rid of the temp
1375         variables used for storing the current env.
1376
1377         openDumpTool() is also refactored a bit into platform-spesific,
1378         port-spesific, and generic environment variables.
1379
1380         Checks for undef was added a few places to fix Perl concat
1381         warnings when run-webkit-tests is aborted.
1382
1383         https://bugs.webkit.org/show_bug.cgi?id=33895
1384
1385         * Scripts/run-webkit-tests:
1386         * Scripts/webkitdirs.pm:
1387
1388 2010-01-22  Kevin Watters  <kevinwatters@gmail.com>
1389
1390         Reviewed by Kevin Ollivier.
1391
1392         [wx] Remove the Bakefile build system, which is no longer being used.
1393         
1394         https://bugs.webkit.org/show_bug.cgi?id=34022
1395
1396         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
1397         * wx/browser/browser.bkl: Removed.
1398         * wx/build-wxwebkit: Removed.
1399
1400 2010-01-22  Gustavo Noronha Silva  <gns@gnome.org>
1401
1402         Reviewed by Simon Fraser.
1403
1404         Reset zoom level to 1.0 when resetting view state. This is causing
1405         many tests to fail after svg/custom/text-zoom.xhtml changes the
1406         zoom level.
1407
1408         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1409         (resetDefaultsToConsistentValues):
1410
1411 2010-01-22  Steve Falkenburg  <sfalken@apple.com>
1412
1413         Reviewed by Darin Adler.
1414
1415         https://bugs.webkit.org/show_bug.cgi?id=34025
1416         Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
1417
1418         * Scripts/build-webkit:
1419
1420 2010-01-22  Adam Barth  <abarth@webkit.org>
1421
1422         Unreviewed.  Arg.  Someone renamed limit to output_limit on me.
1423
1424         * Scripts/webkitpy/commands/queues.py:
1425
1426 2010-01-22  Adam Barth  <abarth@webkit.org>
1427
1428         Rubber stamped by Eric Seidel.
1429
1430         Make __init__.py and buildbot.py pass pep8 style checker.
1431
1432         * Scripts/webkitpy/__init__.py:
1433         * Scripts/webkitpy/buildbot.py:
1434
1435 2010-01-21  Joe Mason  <jmason@rim.com>
1436
1437         Reviewed by Adam Barth.
1438
1439         webkit-patch should retry on invalid password
1440         https://bugs.webkit.org/show_bug.cgi?id=33955
1441
1442         Ask for bugs.webkit.org authentication in a loop.
1443
1444         * Scripts/webkitpy/bugzilla.py:
1445
1446 2010-01-22  Adam Barth  <abarth@webkit.org>
1447
1448         Unreviewed.  Don't call seek on a NoneType.
1449
1450         * Scripts/webkitpy/statusserver.py:
1451
1452 2010-01-22  Petri Latvala  <petri.latvala@nomovok.com>
1453
1454         Reviewed by David Levin.
1455
1456         check-webkit-style breaks on files with unknown types
1457         https://bugs.webkit.org/show_bug.cgi?id=34001
1458
1459         For files with type FileType.NONE, dispatch_processor returns None.
1460
1461         * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
1462
1463 2010-01-22  Adam Barth  <abarth@webkit.org>
1464
1465         Reviewed by Eric Seidel.
1466
1467         Make bugzilla.py and webkitport.py conform to pep8
1468         https://bugs.webkit.org/show_bug.cgi?id=34015
1469
1470         This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
1471         style as enforced by pep8.py.  I wasn't able to get rid of all the
1472         errors because I'm not sure how to wrap some lines properly.  Also,
1473         there are a few deprication errors that I couldn't resolve easily.
1474         However, this is a massive improvement in compliance.
1475
1476         * Scripts/webkitpy/bugzilla.py:
1477         * Scripts/webkitpy/webkitport.py:
1478
1479 2010-01-22  Adam Barth  <abarth@webkit.org>
1480
1481         Reviewed by Darin Adler.
1482
1483         Limit length of EWS results to 5MB
1484         https://bugs.webkit.org/show_bug.cgi?id=34016
1485
1486         Hopefully this will fix the bug where the results link doesn't appear.
1487         Our current theory is that the results blob is too big and the server
1488         is rejecting the request with a 500 error.  That causes us to re-try
1489         the post, but when we re-try the StringIO buffer has its seek pointer
1490         at the end.
1491
1492         * Scripts/webkitpy/commands/queues.py:
1493         * Scripts/webkitpy/statusserver.py:
1494
1495 2010-01-22  Chris Jerdonek  <cjerdonek@webkit.org>
1496
1497         Reviewed by Adam Barth.
1498
1499         Made check-webkit-style able to check patches when script not
1500         run from source root. Also consolidated external references
1501         to a single file.
1502
1503         https://bugs.webkit.org/show_bug.cgi?id=33791
1504
1505         * Scripts/check-webkit-style:
1506           - Changed to import style_references.py.
1507
1508         * Scripts/webkitpy/style/__init__.py:
1509           - Removed __path__ hack that allowed searching Scripts/ directory.
1510
1511         * Scripts/webkitpy/style/checker.py:
1512           - Changed to import style_references.py.
1513
1514         * Scripts/webkitpy/style_references.py: Added.
1515
1516 2010-01-22  Dmitry Titov  <dimich@chromium.org>
1517
1518         Reviewed by Maciej Stachowiak.
1519
1520         Fix the leak of ThreadIdentifiers in threadMap across threads.
1521         https://bugs.webkit.org/show_bug.cgi?id=32689
1522
1523         Add a new test to verify the ThreadIdentifiers are not reused across threads.
1524         The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
1525         waiting for the previous thread to terminate before starting the next.
1526         The treads use WTF::currentThread() in their thread function. Without a fix, this
1527         causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
1528         It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
1529         threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
1530         The test practically does not affect the DRT run time because the threads end immediately.
1531
1532         * DumpRenderTree/mac/DumpRenderTree.mm:
1533         (runThread): Test thread function.
1534         (testThreadIdentifierMap):
1535         (dumpRenderTree):
1536
1537 2010-01-22  Kent Tamura  <tkent@chromium.org>
1538
1539         Reviewed by Maciej Stachowiak.
1540
1541         Fix a bug that mouseDown:withModifiers: is never called.
1542         https://bugs.webkit.org/show_bug.cgi?id=33989
1543
1544         * DumpRenderTree/mac/EventSendingController.mm:
1545         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1546         (+[EventSendingController webScriptNameForSelector:]):
1547
1548 2010-01-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1549
1550         Rubberstamped by Antti Koivisto.
1551
1552         [Qt] Separate out the WebPage class into it's own
1553         cpp/header files. Also, removed the assumption that
1554         the view is a QWebView, in preparation of a merger
1555         of the two Qt WebKit launchers.
1556
1557         * QtLauncher/QtLauncher.pro:
1558         * QtLauncher/main.cpp:
1559         (WebView::mousePressEvent):
1560         * QtLauncher/webpage.cpp: Added.
1561         (WebPage::supportsExtension):
1562         (WebPage::extension):
1563         (WebPage::acceptNavigationRequest):
1564         (WebPage::openUrlInDefaultBrowser):
1565         * QtLauncher/webpage.h: Added.
1566         (WebPage::WebPage):
1567
1568 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
1569
1570         Reviewed by Shinichiro Hamaji.
1571
1572         Refactored to move file name and file-reading related code
1573         from cpp_style.py and text_style.py to checker.py.
1574
1575         https://bugs.webkit.org/show_bug.cgi?id=33775
1576
1577         * Scripts/check-webkit-style:
1578           - Updates caused by changes to checker.py.
1579
1580         * Scripts/webkitpy/style/checker.py:
1581           - Added SKIPPED_FILES_WITH_WARNING list.
1582           - Added SKIPPED_FILES_WITHOUT_WARNING list.
1583           - Added FileType class.
1584           - Added ProcessorDispatcher class.
1585           - In StyleChecker class:
1586             - Renamed process_patch() to check_patch().
1587             - Renamed process_file() to check_file().
1588             - Added _process_file().
1589             - Related refactoring.
1590             - Addressed check_patch() FIXME to share code with process_file().
1591
1592         * Scripts/webkitpy/style/checker_unittest.py:
1593           - Added ProcessorDispatcherSkipTest class.
1594           - Added ProcessorDispatcherDispatchTest class.
1595           - Added StyleCheckerCheckFileTest class.
1596
1597         * Scripts/webkitpy/style/cpp_style.py:
1598           - Renamed process_file_data() to _process_lines.
1599           - Removed process_file() (moved logic to checker.py).
1600           - Removed can_handle() (moved logic to checker.py).
1601           - Added CppProcessor class.
1602           - Removed is_exempt() (moved logic to checker.py).
1603           - Added process_file_data() back as a wrapper function.
1604
1605         * Scripts/webkitpy/style/cpp_style_unittest.py:
1606           - Removed test_can_handle().
1607           - Removed test_is_exempt().
1608           - Added CppProcessorTest class.
1609
1610         * Scripts/webkitpy/style/text_style.py:
1611           - Added TextProcessor class.
1612           - Removed process_file().
1613           - Removed can_handle().
1614
1615         * Scripts/webkitpy/style/text_style_unittest.py:
1616           - Removed test_can_handle().
1617           - Added TextProcessorTest class.
1618
1619 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
1620
1621         Reviewed by David Kilzer.
1622
1623         Create a unit-tested subroutine to parse patch files created
1624         by svn-create-patch.
1625
1626         https://bugs.webkit.org/show_bug.cgi?id=33475
1627
1628         * Scripts/VCSUtils.pm:
1629           - Added parseDiff().
1630           - Added parsePatch().
1631
1632         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added.
1633           - Added unit tests for parseDiff().
1634
1635         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1636           - Total number of tests now computed dynamically.
1637
1638         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added.
1639           - Added unit tests for parsePatch().
1640
1641 2010-01-21  Kevin Ollivier  <kevino@theolliviers.com>
1642
1643         [wx] Build fix, add new directory to dir list.
1644
1645         * wx/build/settings.py:
1646
1647 2010-01-21  Adam Barth  <abarth@webkit.org>
1648
1649         Reviewed by Eric Seidel.
1650
1651         Make the EWS transactional
1652         https://bugs.webkit.org/show_bug.cgi?id=33978
1653
1654         Now if the EWS gets interrupted in the middle of processing a patch,
1655         the bots will re-process the patch.
1656
1657         * Scripts/test-webkitpy:
1658         * Scripts/webkitpy/commands/queues.py:
1659         * Scripts/webkitpy/commands/queues_unittest.py:
1660         * Scripts/webkitpy/patchcollection.py:
1661         * Scripts/webkitpy/patchcollection_unittest.py: Added.
1662
1663 2010-01-21  Adam Barth  <abarth@webkit.org>
1664
1665         Unreviewed.  Add missing "ago" for style in the status bubble.
1666
1667         * QueueStatusServer/templates/statusbubble.html:
1668
1669 2010-01-21  Adam Barth  <abarth@webkit.org>
1670
1671         Reviewed by David Levin.
1672
1673         [style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/
1674         https://bugs.webkit.org/show_bug.cgi?id=33356
1675
1676         White list unix_hacker_style names in WebKit/gtk/webkit because these
1677         are used in the GTK+ API.
1678
1679         * Scripts/webkitpy/style/cpp_style.py:
1680         * Scripts/webkitpy/style/cpp_style_unittest.py:
1681
1682 2010-01-21  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1683
1684         Reviewed by Kenneth Rohde Christiansen.
1685
1686         [Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
1687         https://bugs.webkit.org/show_bug.cgi?id=33945
1688
1689         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1690         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1691         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1692
1693 2010-01-21  Simon Hausmann  <simon.hausmann@nokia.com>
1694
1695         No review, rolling out 53615 as it causes two
1696         crashes on the bot.
1697
1698         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1699         (WebCore::DumpRenderTree::DumpRenderTree):
1700         (WebCore::DumpRenderTree::createWindow):
1701         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1702         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1703         (LayoutTestController::maybeDump):
1704
1705 2010-01-21  Robert Hogan  <robert@roberthogan.net>
1706
1707         Reviewed by Simon Hausmann.
1708
1709         Qt DRT: respect window.close() and window.closed()
1710
1711         Qt DRT needs to maintain a correct count of open windows
1712         for windowCount(). It also needs to delete windows that
1713         have been closed by window.close().
1714
1715         This fixes the following tests:
1716
1717         plugins/destroy-during-npp-new.html
1718         fast/dom/Document/early-document-access.html
1719         fast/dom/Window/window-early-properties.html
1720         fast/events/open-window-from-another-frame.html
1721         fast/events/popup-blocking-click-in-iframe.html
1722
1723         https://bugs.webkit.org/show_bug.cgi?id=32953
1724
1725         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1726         (WebCore::DumpRenderTree::DumpRenderTree):
1727         (WebCore::DumpRenderTree::createWindow):
1728         (WebCore::DumpRenderTree::windowCloseRequested):
1729         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1730         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1731         (LayoutTestController::maybeDump):
1732
1733 2010-01-20  Eric Seidel  <eric@webkit.org>
1734
1735         No review, rolling out r53593.
1736         http://trac.webkit.org/changeset/53593
1737         https://bugs.webkit.org/show_bug.cgi?id=33496
1738
1739         Re-rollout this patch, the commit-queue should not have landed
1740         it again, but it did due to land-diff and rollout both not
1741         clearing flags.
1742
1743         * Scripts/webkitpy/commands/early_warning_system.py:
1744         * Scripts/webkitpy/commands/queues.py:
1745         * Scripts/webkitpy/queueengine.py:
1746         * Scripts/webkitpy/scm.py:
1747         * Scripts/webkitpy/scm_unittest.py:
1748
1749 2010-01-20  Eric Seidel  <eric@webkit.org>
1750
1751         Reviewed by Adam Barth.
1752
1753         webkit-commit-queue status page is confusing
1754         https://bugs.webkit.org/show_bug.cgi?id=33496
1755
1756         This should improve the status page by removing more Fail messages.
1757         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
1758         to behave more like one another.  This meant moving where the failure reporting was done.
1759         Previously the AbstractReviewQueue always used the parent process to report the error,
1760         while CommitQueue used the subprocess when possible, and the parent only reported errors
1761         that we didn't know how to handle (bugs in the commit-queue itself).
1762         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
1763         in both implementations and required teaching handle_script_error in each to post Fail messages
1764         to the status server instead of calling exit(1).
1765
1766         This will also make the style-queue share more bug posting logic with other queues:
1767         https://bugs.webkit.org/show_bug.cgi?id=33871
1768
1769         * Scripts/webkitpy/commands/early_warning_system.py:
1770          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
1771            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
1772            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
1773            _update_status_for_script_error knows how to post the Fail message to the status server.
1774          - Teach _update_status_for_script_error how to post Fail messages to the status server.
1775         * Scripts/webkitpy/commands/queues.py:
1776          - Remove the try block from process_work_item since the caller already has one.
1777          - Only CC watchers on failure to cut down on commit-queue generated mail.
1778          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
1779          - Abstract _format_script_error_output_for_bug to share code between all queues.
1780          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
1781          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
1782          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
1783          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
1784         * Scripts/webkitpy/queueengine.py:
1785          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
1786         * Scripts/webkitpy/scm.py:
1787          - Add new checkout_revision function.
1788         * Scripts/webkitpy/scm_unittest.py:
1789          - Test our new checkout_revision function.
1790
1791 2010-01-20  Fumitoshi Ukai  <ukai@chromium.org>
1792
1793         Reviewed by Alexey Proskuryakov.
1794
1795         WebSocket: Missing Request-URI, when no tralling slash in host
1796         https://bugs.webkit.org/show_bug.cgi?id=33689
1797
1798         Update pywebsocket to 0.4.7.1, which supports alias for resource
1799         name, so that we could test for ws://127.0.0.1:8880
1800
1801         * Scripts/run-webkit-tests:
1802         * Scripts/run-webkit-websocketserver:
1803         * pywebsocket/mod_pywebsocket/dispatch.py:
1804         * pywebsocket/mod_pywebsocket/handshake.py:
1805         * pywebsocket/mod_pywebsocket/standalone.py:
1806         * pywebsocket/setup.py:
1807         * pywebsocket/test/test_dispatch.py:
1808         * pywebsocket/test/test_handshake.py:
1809
1810 2010-01-20  Eric Seidel  <eric@webkit.org>
1811
1812         No review, rolling out r53537.
1813         http://trac.webkit.org/changeset/53537
1814         https://bugs.webkit.org/show_bug.cgi?id=33496
1815
1816         Added a failure condition to the commit-queue and looks to
1817         have broken the EWS bots
1818
1819         * Scripts/webkitpy/commands/early_warning_system.py:
1820         * Scripts/webkitpy/commands/queues.py:
1821         * Scripts/webkitpy/queueengine.py:
1822         * Scripts/webkitpy/scm.py:
1823         * Scripts/webkitpy/scm_unittest.py:
1824
1825 2010-01-20  Jon Honeycutt  <jhoneycutt@apple.com>
1826
1827         MSAA: accSelect() is not implemented
1828
1829         https://bugs.webkit.org/show_bug.cgi?id=33918
1830         <rdar://problem/7436861>
1831
1832         Reviewed by Darin Adler.
1833
1834         * DumpRenderTree/AccessibilityUIElement.cpp:
1835         (takeFocusCallback):
1836         Call the object's takeFocus() function.
1837         (takeSelectionCallback):
1838         Call its takeSelection() function.
1839         (addSelectionCallback):
1840         Call its addSelection() function.
1841         (removeSelectionCallback):
1842         Call its removeSelection() function.
1843         (AccessibilityUIElement::getJSClass):
1844         Add new functions to the JS class definition.
1845
1846         * DumpRenderTree/AccessibilityUIElement.h:
1847         Declare new functions.
1848
1849         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1850         (AccessibilityUIElement::takeFocus):
1851         Stubbed.
1852         (AccessibilityUIElement::takeSelection):
1853         Stubbed.
1854         (AccessibilityUIElement::addSelection):
1855         Stubbed.
1856         (AccessibilityUIElement::removeSelection):
1857         Stubbed.
1858
1859         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1860         (AccessibilityUIElement::takeFocus):
1861         Stubbed.
1862         (AccessibilityUIElement::takeSelection):
1863         Stubbed.
1864         (AccessibilityUIElement::addSelection):
1865         Stubbed.
1866         (AccessibilityUIElement::removeSelection):
1867         Stubbed.
1868
1869         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1870         (AccessibilityUIElement::takeFocus):
1871         Call the object's accSelect() function, passing the appropriate flag.
1872         (AccessibilityUIElement::takeSelection):
1873         Ditto.
1874         (AccessibilityUIElement::addSelection):
1875         Ditto.
1876         (AccessibilityUIElement::removeSelection):
1877         Ditto.
1878
1879 2010-01-20  Andras Becsi  <abecsi@inf.u-szeged.hu>
1880
1881         Reviewed by Alexey Proskuryakov.
1882
1883         Extract Apache handling to httpd.pm module and use the provided functionality
1884         in scripts where Apache is needed.
1885         The module httpd.pm stores the PID of Apache in a variable and cleans up
1886         the PID directory after Apache properly shut down. Catching INT and TERM
1887         signals allows the scripts to close Apache and clean up its PID directory
1888         even if the testing was interrupted.
1889
1890         https://bugs.webkit.org/show_bug.cgi?id=33153
1891
1892         * Scripts/webkitperl/httpd.pm: Added.
1893         * Scripts/run-iexploder-tests:
1894         * Scripts/run-webkit-httpd:
1895         * Scripts/run-webkit-tests:
1896
1897 2010-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1898
1899         Reviewed by Simon Hausmann.
1900
1901         [Qt] Make DumpRenderTree build on Windows
1902
1903         * DumpRenderTree/qt/DumpRenderTree.pro:
1904         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1905         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1906         * DumpRenderTree/qt/main.cpp:
1907
1908 2010-01-20  Steve Block  <steveblock@google.com>
1909
1910         Reviewed by Eric Seidel.
1911
1912         Fix commit bot to land patches in order of the bug last modification date.
1913         https://bugs.webkit.org/show_bug.cgi?id=33395
1914
1915         * Scripts/webkitpy/bugzilla.py: Modified. Added 'order=Last+Changed' to bugzilla commit queue URL.
1916
1917 2010-01-20  Adam Barth  <abarth@webkit.org>
1918
1919         Reviewed by Eric Seidel.
1920
1921         Teach check-webkit-style about WebKit/gtk/tests
1922         https://bugs.webkit.org/show_bug.cgi?id=33892
1923
1924         Removes false positives found in
1925         https://bugs.webkit.org/show_bug.cgi?id=30883
1926
1927         * Scripts/webkitpy/style/cpp_style.py:
1928         * Scripts/webkitpy/style/cpp_style_unittest.py:
1929
1930 2010-01-20  Adam Barth  <abarth@webkit.org>
1931
1932         Reviewed by Eric Seidel.
1933
1934         Teach check-webkit-style about QGVLauncher
1935         https://bugs.webkit.org/show_bug.cgi?id=33890
1936
1937         Remove false positives found in
1938         https://bugs.webkit.org/show_bug.cgi?id=33708
1939
1940         * Scripts/webkitpy/style/cpp_style.py:
1941         * Scripts/webkitpy/style/cpp_style_unittest.py:
1942
1943 2010-01-20  Eric Seidel  <eric@webkit.org>
1944
1945         Reviewed by Adam Barth.
1946
1947         webkit-commit-queue status page is confusing
1948         https://bugs.webkit.org/show_bug.cgi?id=33496
1949
1950         This should improve the status page by removing more Fail messages.
1951         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
1952         to behave more like one another.  This meant moving where the failure reporting was done.
1953         Previously the AbstractReviewQueue always used the parent process to report the error,
1954         while CommitQueue used the subprocess when possible, and the parent only reported errors
1955         that we didn't know how to handle (bugs in the commit-queue itself).
1956         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
1957         in both implementations and required teaching handle_script_error in each to post Fail messages
1958         to the status server instead of calling exit(1).
1959
1960         This will also make the style-queue share more bug posting logic with other queues:
1961         https://bugs.webkit.org/show_bug.cgi?id=33871
1962
1963         * Scripts/webkitpy/commands/early_warning_system.py:
1964          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
1965            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
1966            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
1967            _update_status_for_script_error knows how to post the Fail message to the status server.
1968          - Teach _update_status_for_script_error how to post Fail messages to the status server.
1969         * Scripts/webkitpy/commands/queues.py:
1970          - Remove the try block from process_work_item since the caller already has one.
1971          - Only CC watchers on failure to cut down on commit-queue generated mail.
1972          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
1973          - Abstract _format_script_error_output_for_bug to share code between all queues.
1974          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
1975          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
1976          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
1977          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
1978         * Scripts/webkitpy/queueengine.py:
1979          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
1980         * Scripts/webkitpy/scm.py:
1981          - Add new checkout_revision function.
1982         * Scripts/webkitpy/scm_unittest.py:
1983          - Test our new checkout_revision function.
1984
1985 2010-01-20  Adam Barth  <abarth@webkit.org>
1986
1987         Reviewed by Darin Adler.
1988
1989         Exempt JavaScriptCore/qt/api from style checks
1990         https://bugs.webkit.org/show_bug.cgi?id=33879
1991
1992         Apparently there is a JavaScriptCore API for Qt as well as a WebKit
1993         API.
1994
1995         * Scripts/webkitpy/style/cpp_style.py:
1996         * Scripts/webkitpy/style/cpp_style_unittest.py:
1997
1998 2010-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1999
2000         Reviewed by Simon Hausmann.
2001
2002         [Qt] Don't use QSocketNotifier in the DRT for reading stdin
2003
2004         QSocketNotifier is not available on Windows. Instead we read
2005         stdin synchronously after each test using signals and slots.
2006
2007         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2008         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2009         * DumpRenderTree/qt/main.cpp:
2010
2011 2010-01-19  Adam Barth  <abarth@webkit.org>
2012
2013         Rubber stamped by Eric Seidel.
2014
2015         Move chromium-ews back to building release only to make the EWS faster.
2016
2017         * Scripts/webkitpy/commands/early_warning_system.py:
2018
2019 2010-01-17  Jon Honeycutt  <jhoneycutt@apple.com>
2020
2021         MSAA: The child <option> elements of a non-multiple <select> are not
2022         exposed
2023
2024         https://bugs.webkit.org/show_bug.cgi?id=33773
2025         <rdar://problem/7550556>
2026
2027         Reviewed by Alice Liu.
2028
2029         * DumpRenderTree/AccessibilityUIElement.cpp:
2030         (getIsVisibleCallback):
2031         Call the object's isVisible() function.
2032         (getIsOffScreenCallback):
2033         Ditto, for isOffScreen().
2034         (getIsCollapsedCallback):
2035         Ditto, for isCollapsed().
2036         (getHasPopupCallback):
2037         Ditto, for hasPopup().
2038         (AccessibilityUIElement::getJSClass):
2039         Add isVisible and isOffScreen attributes.
2040
2041         * DumpRenderTree/AccessibilityUIElement.h:
2042         Declare new functions.
2043
2044         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2045         (AccessibilityUIElement::isVisible):
2046         Stubbed.
2047         (AccessibilityUIElement::isOffScreen):
2048         Stubbed.
2049         (AccessibilityUIElement::isCollapsed):
2050         Stubbed.
2051         (AccessibilityUIElement::hasPopup):
2052         Stubbed.
2053
2054         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2055         (AccessibilityUIElement::isVisible):
2056         Stubbed.
2057         (AccessibilityUIElement::isOffScreen):
2058         Stubbed.
2059         (AccessibilityUIElement::isCollapsed):
2060         Stubbed.
2061         (AccessibilityUIElement::hasPopup):
2062         Stubbed.
2063
2064         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2065         (AccessibilityUIElement::showMenu):
2066         Call the object's accDoDefaultAction() to show its popup menu.
2067         (AccessibilityUIElement::isEnabled):
2068         Check that the object does not have the "unavailable" state.
2069         (AccessibilityUIElement::isVisible):
2070         Check that the object does not have the "invisible" state.
2071         (AccessibilityUIElement::isOffScreen):
2072         Check whether the object has the "offscreen" state.
2073         (AccessibilityUIElement::isCollapsed):
2074         Check whether the object has the "collapsed" state.
2075         (AccessibilityUIElement::hasPopup):
2076         Check whether the object has the "has popup" state.
2077
2078 2010-01-19  Victor Wang  <victorw@chromium.org>
2079
2080         Reviewed by Eric Seidel.
2081
2082         Correct committer name.
2083         https://bugs.webkit.org/show_bug.cgi?id=33868
2084
2085         * Scripts/webkitpy/committers.py:
2086
2087 2010-01-19  Kent Tamura  <tkent@chromium.org>
2088
2089         Reviewed by Darin Adler.
2090
2091         [DRT][Mac] Add modifiers parameter to eventSender.mouseDown() and eventSender.mouseUp()
2092         https://bugs.webkit.org/show_bug.cgi?id=33783
2093
2094         Some listbox tests check selection behavior by click events with
2095         "meta" or "shift" keys. Behaviors for such modifier keys are
2096         platform-dependent. The new parameter of mouseDown() and mouseUp()
2097         allows to specify not only concrete modifier keys such as
2098         "shiftKey" "metaKey", but also functional names like
2099         "addSelectionKey" "rangeSelectionKey".
2100
2101         * DumpRenderTree/mac/EventSendingController.mm:
2102         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2103         (+[EventSendingController webScriptNameForSelector:]):
2104         (buildModifierFlags):
2105         (-[EventSendingController mouseDown:withModifiers:]):
2106         (-[EventSendingController mouseDown:]):
2107         (-[EventSendingController mouseUp:withModifiers:]):
2108         (-[EventSendingController mouseUp:]):
2109         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2110
2111 2010-01-19  Adam Barth  <abarth@webkit.org>
2112
2113         Reviewed by Eric Seidel.
2114
2115         Unbreak --request-commit
2116         https://bugs.webkit.org/show_bug.cgi?id=33832
2117
2118         * Scripts/webkitpy/bugzilla.py:
2119
2120 2010-01-19  Eric Seidel  <eric@webkit.org>
2121
2122         Reviewed by Adam Barth.
2123
2124         validate-committer-lists throws exception and committers.py needs a refresh
2125         https://bugs.webkit.org/show_bug.cgi?id=33831
2126
2127         * Scripts/validate-committer-lists: use webkit_logging
2128         * Scripts/webkitpy/committers.py: Add recently minted committers.  Fix Simon Hausmanns email address list to include his webkit-committers@lists address.
2129
2130 2010-01-18  Adam Roben  <aroben@apple.com>
2131
2132         Add LayoutTestController support for calling new WebKit SPI to
2133         disallow setting document.domain
2134
2135         DRT part of fixing <http://webkit.org/b/33806>
2136         <rdar://problem/7552837> Would like API to disallow setting of
2137         document.domain for pages with certain URL schemes
2138
2139         Reviewed by Sam Weinig.
2140
2141         * DumpRenderTree/LayoutTestController.cpp:
2142         (setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls
2143         through to LayoutTestController.
2144         (LayoutTestController::staticFunctions): Added
2145         setDomainRelaxationForbiddenForURLScheme.
2146
2147         * DumpRenderTree/LayoutTestController.h: Added
2148         setDomainRelaxationForbiddenForURLScheme.
2149
2150         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2151         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2152         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2153         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2154         Added. Calls through to WebKit.
2155
2156         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2157         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2158         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2159         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2160         Stubbed out.
2161
2162 2010-01-18  Adam Barth  <abarth@webkit.org>
2163
2164         Reviewed by Adam Roben.
2165
2166         Rename patches-to-commit to patches-in-commit-queue
2167         https://bugs.webkit.org/show_bug.cgi?id=33789
2168
2169         The command really lists the patches in the commit-queue not all the
2170         patches that are pending-commit (as the FIXME commands).
2171
2172         * Scripts/webkitpy/commands/queries.py:
2173         * Scripts/webkitpy/commands/queries_unittest.py:
2174
2175 2010-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2176
2177         Reviewed by Simon Hausmann.
2178
2179         [Qt] Force qmake to generate a single makefile for DerivedSources.pro
2180
2181         * Scripts/webkitdirs.pm:
2182
2183 2010-01-18  Adam Roben  <aroben@apple.com>
2184
2185         Clean up use of /useenv when invoking Visual C++
2186
2187         This change reverts things to their pre-r49485 state. That revision
2188         (and, subsequently, r49664 and r51788) started passing /useenv to
2189         Visual C++, even in cases where we don't want to do so (such as when
2190         invoking Visual C++ Express), in the name of making the Chromium build
2191         work. Now that Chromium isn't using buildVisualStudioProject or
2192         pdevenv, we can put things back they way they were.
2193
2194         Fixes <http://webkit.org/b/33797> build-webkit fails with VC++ Express
2195         (due to /useenv flag)
2196
2197         Reviewed by Sam Weinig.
2198
2199         * Scripts/pdevenv: Always pass /useenv. Chromium doesn't use this
2200         script anymore.
2201         * Scripts/webkitdirs.pm:
2202         (buildVisualStudioProject): Never pass /useenv anymore. pdevenv takes
2203         care of this itself, and we don't want to pass /useenv when not using
2204         pdevenv (e.g., when using VC++ Express, because that will cause it to
2205         ignore the Platform SDK).
2206
2207 2010-01-18  Adam Barth  <abarth@webkit.org>
2208
2209         Reviewed by Eric Seidel.
2210
2211         webkit-patch land-safely should obsolete old patches
2212         https://bugs.webkit.org/show_bug.cgi?id=33788
2213
2214         When posting a commit-queue+ patch with land-safely, we should
2215         obsolete the old patches on the bug.  They're really confusing
2216         because the main use case is to address reviewer feedback on a
2217         previous patch.
2218
2219         * Scripts/webkitpy/commands/upload.py:
2220         * Scripts/webkitpy/commands/upload_unittest.py:
2221
2222 2010-01-18  Adam Barth  <abarth@webkit.org>
2223
2224         Reviewed by David Levin.
2225
2226         webkit-patch should authenticate more often
2227         https://bugs.webkit.org/show_bug.cgi?id=33701
2228
2229         This makes it easier to work with security patches.
2230
2231         * Scripts/webkitpy/bugzilla.py:
2232
2233 2010-01-18  Adam Barth  <abarth@webkit.org>
2234
2235         Reviewed by Darin Adler.
2236
2237         style checker needs to know about GObject-specific requirements
2238         inside WebCore/bindings/gobject/
2239         https://bugs.webkit.org/show_bug.cgi?id=33606
2240
2241         Add an exception to the underscore rule for certain
2242         GObject-specific names.
2243
2244         * Scripts/webkitpy/style/cpp_style.py:
2245         * Scripts/webkitpy/style/cpp_style_unittest.py:
2246
2247 2010-01-18  Adam Barth  <abarth@webkit.org>
2248
2249         Reviewed by Shinichiro Hamaji.
2250
2251         [check-webkit-style] does understand ResourceHandleWin.h
2252         https://bugs.webkit.org/show_bug.cgi?id=32975
2253
2254         I'm not 100% convinced this fix is correct, but without more examples,
2255         it's hard to generalize.  We can always generalize the fix in the
2256         future.
2257
2258         * Scripts/webkitpy/style/cpp_style.py:
2259         * Scripts/webkitpy/style/cpp_style_unittest.py:
2260
2261 2010-01-18  Adam Barth  <abarth@webkit.org>
2262
2263         Unreviewed "build" fix.
2264
2265         * Scripts/webkitpy/bugzilla.py:
2266
2267 2010-01-18  Adam Barth  <abarth@webkit.org>
2268
2269         Unreviewed.  Actually make land-safely mark commit-queue+ as
2270         discussed with Eric.
2271
2272         * Scripts/webkitpy/bugzilla.py:
2273         * Scripts/webkitpy/steps/postdiffforcommit.py:
2274
2275 2010-01-17  Adam Barth  <abarth@webkit.org>
2276
2277         Reviewed by Darin Adler.
2278
2279         style-queue complains about one-line macros that include multiple statements
2280         https://bugs.webkit.org/show_bug.cgi?id=33173
2281
2282         Add an exception for multiple statements on a line that starts a macro.
2283
2284         * Scripts/webkitpy/style/cpp_style.py:
2285         * Scripts/webkitpy/style/cpp_style_unittest.py:
2286
2287 2010-01-17  Adam Barth  <abarth@webkit.org>
2288
2289         Reviewed by Darin Adler.
2290
2291         [check-webkit-style] qt unit testing false positives
2292         https://bugs.webkit.org/show_bug.cgi?id=32833
2293
2294         Exempt the Qt API and unit tests from the style checker.
2295
2296         * Scripts/webkitpy/style/cpp_style.py:
2297         * Scripts/webkitpy/style/cpp_style_unittest.py:
2298
2299 2010-01-17  Adam Barth  <abarth@webkit.org>
2300
2301         Reviewed by Darin Adler.
2302
2303         style-check script reports loads of errors on gtk2drawing.c
2304         https://bugs.webkit.org/show_bug.cgi?id=33771
2305
2306         Exempt WebCore/platform/gtk/gtk2drawing.c and
2307         WebCore/platform/gtk/gtk2drawing.h from style checks.
2308
2309         * Scripts/webkitpy/style/cpp_style.py:
2310         * Scripts/webkitpy/style/cpp_style_unittest.py:
2311
2312 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
2313
2314         Reviewed by Shinichiro Hamaji.
2315
2316         Finished eliminating _cpp_style_state global state variable from
2317         check-webkit-style code and eliminating _CppStyleState class.
2318
2319         https://bugs.webkit.org/show_bug.cgi?id=33764
2320
2321         * Scripts/webkitpy/style/checker.py:
2322           - Minor updates caused by changes to cpp_style.py.
2323
2324         * Scripts/webkitpy/style/cpp_style.py:
2325           - Removed _CppStyleState class.
2326           - Removed verbose_level functions.
2327           - Added verbosity as a parameter to _FunctionState constructor.
2328           - Added verbosity as a parameter to process_file().
2329           - Added verbosity as a parameter to process_file_data().
2330
2331         * Scripts/webkitpy/style/cpp_style_unittest.py:
2332           - Added helper functions to set verbosity while running tests.
2333
2334 2010-01-17  Adam Barth  <abarth@webkit.org>
2335
2336         Reviewed by Shinichiro Hamaji.
2337
2338         check-webkit-style underscore check should be disabled for Qt methods starting with qt_
2339         https://bugs.webkit.org/show_bug.cgi?id=33663
2340
2341         * Scripts/webkitpy/style/cpp_style.py:
2342         * Scripts/webkitpy/style/cpp_style_unittest.py:
2343
2344 2010-01-17  Adam Barth  <abarth@webkit.org>
2345
2346         Reviewed by Eric Seidel.
2347
2348         style-queue complains about missing #include of config.h for non-WebCore projects
2349         https://bugs.webkit.org/show_bug.cgi?id=33170
2350
2351         WebKitAPITests are consumers of the WebKit API and therefore do not
2352         need to follow the same include discipline as the rest of WebKit.  This
2353         patch exempts them from the include checks.
2354
2355         * Scripts/webkitpy/style/cpp_style.py:
2356         * Scripts/webkitpy/style/cpp_style_unittest.py:
2357
2358 2010-01-17  Adam Barth  <abarth@webkit.org>
2359
2360         Reviewed by Eric Seidel.
2361
2362         EWS (Early Warning Systems) should build both debug and release
2363         https://bugs.webkit.org/show_bug.cgi?id=33681
2364
2365         Build both debug and release for chromium-ews.
2366
2367         * Scripts/webkitpy/commands/early_warning_system.py:
2368
2369 2010-01-17  Adam Barth  <abarth@webkit.org>
2370
2371         Reviewed by Darin Adler.
2372
2373         style-queue should include instructions for how to file bugs against check-webkit-style
2374         https://bugs.webkit.org/show_bug.cgi?id=32345
2375
2376         Added some text to the error message asking folks to file bugs against
2377         false positives.
2378
2379         * Scripts/webkitpy/commands/queues.py:
2380
2381 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
2382
2383         Reviewed by Adam Barth.
2384
2385         Eliminated the error_count global variable and related
2386         check-webkit-style refactoring.
2387
2388         https://bugs.webkit.org/show_bug.cgi?id=33678
2389
2390         * Scripts/check-webkit-style:
2391           - Updated to use webkit_argument_defaults().
2392           - Renamed styleChecker to style_checker.
2393
2394         * Scripts/webkitpy/style/checker.py:
2395           - Prefixed the three default arguments with WEBKIT_DEFAULT.
2396           - Added webkit_argument_defaults().
2397           - Added default filter_rules parameter to CategoryFilter constructor.
2398           - Added __ne__() to CategoryFilter class.
2399           - Added __eq__() and __ne__() to ProcessorOptions class.
2400           - Added error_count and _write_error attributes to StyleChecker class.
2401           - Made StyleChecker._handle_error() increment the error count.
2402
2403         * Scripts/webkitpy/style/checker_unittest.py:
2404           - Improved CategoryFilterTest.test_eq().
2405           - Added CategoryFilterTest.test_ne().
2406           - Added test_eq() and test_ne() to ProcessorOptionsTest class.
2407           - Updated unit tests to use webkit_argument_defaults().
2408           - Added StyleCheckerTest class.
2409
2410         * Scripts/webkitpy/style/cpp_style.py:
2411           - Removed references to global error_count.
2412
2413         * Scripts/webkitpy/style/cpp_style_unittest.py:
2414           - Removed CppStyleStateTest class.
2415
2416 2010-01-15  Jon Honeycutt  <jhoneycutt@apple.com>
2417
2418         get_accParent should try to retrieve parent AccessibilityObject, before
2419         calling upon window
2420
2421         https://bugs.webkit.org/show_bug.cgi?id=22893
2422
2423         Reviewed by Darin Adler.
2424
2425         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2426         (AccessibilityUIElement::parentElement):
2427         Get the object's parent. Query it for IAccessible, and return it.
2428
2429 2010-01-16  Dan Bernstein  <mitz@apple.com>
2430
2431         Reviewed by Mark Rowe.
2432
2433         <rdar://problem/7529519> DumpRenderTree crashes in makeLargeMallocFailSilently()
2434
2435         * DumpRenderTree/mac/CheckedMalloc.cpp:
2436         (makeLargeMallocFailSilently): Temporarily allow writing to the default
2437         malloc zone structure while modifying it.
2438
2439 2010-01-16  David Kilzer  <ddkilzer@apple.com>
2440
2441         Added back removed properties to iExploder input files
2442
2443         While the update-iexploder-cssproperties script works great to
2444         add new properties, it has the side-effect of removing old
2445         properties that once were parsed.
2446
2447         * iExploder/htdocs/cssproperties.in: Added back removed
2448         properties into their own section.
2449         * iExploder/htdocs/htmlattrs.in: Ditto.
2450
2451 2010-01-16  Holger Hans Peter Freyther  <zecke@selfish.org>
2452
2453         Reviewed by David Kilzer.
2454
2455         Update iExploder/htdocs/*.in by running update-iexploder-cssproperties 
2456         https://bugs.webkit.org/show_bug.cgi?id=33756
2457
2458         * iExploder/htdocs/cssproperties.in: New CSS attributes
2459         * iExploder/htdocs/htmlattrs.in: New HTML attributes
2460         * iExploder/htdocs/htmltags.in: New HTML tags
2461
2462 2010-01-15  Chris Jerdonek  <chris.jerdonek@gmail.com>
2463
2464         Reviewed by David Kilzer.
2465
2466         Altered parseDiffHeader() to skip unrecognized lines and
2467         other minor clean-ups.
2468
2469         https://bugs.webkit.org/show_bug.cgi?id=33476
2470
2471         * Scripts/VCSUtils.pm:
2472           - Changed parseDiffHeader() as follows:
2473             - Skips over unrecognized lines.
2474             - Addressed FIXME to remove substitution for "diff" line.
2475             - Renamed "version" header hash key to "sourceRevision".
2476             - Eliminated "copiedFromVersion" header hash key.
2477             - Included "sourceRevision" also for copied files.
2478             - Checks that copy revision number matches "sourceRevision".
2479             - No longer returns $foundHeaderEnding.
2480             - Dies if header ending not found.
2481             - Diff header dividing line now always added.
2482
2483         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
2484           - Made necessary changes in parseDiffHeader() unit tests.
2485           - Shortened the file paths in some test cases.
2486
2487 2010-01-14  Yuzo Fujishima  <yuzo@google.com>
2488
2489         Reviewed by Alexey Proskuryakov.
2490
2491         Update pywebsocket to 0.4.6
2492         https://bugs.webkit.org/show_bug.cgi?id=32299
2493         The newer pywebsocket can handle more simultaneous connections.
2494
2495         * pywebsocket/mod_pywebsocket/handshake.py:
2496         * pywebsocket/mod_pywebsocket/standalone.py:
2497         * pywebsocket/setup.py:
2498         * pywebsocket/test/test_handshake.py:
2499
2500 2010-01-14  Eric Seidel  <eric@webkit.org>
2501
2502         Reviewed by Adam Barth.
2503
2504         REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs
2505         https://bugs.webkit.org/show_bug.cgi?id=33638
2506
2507         * Scripts/webkitpy/bugzilla.py:
2508          - Add Bug.id() to match Attachment.id()
2509          - Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers.
2510          - Add back a missing variable to _validate_setter_email found by the new unit tests!
2511         * Scripts/webkitpy/commands/queries.py:
2512          - Add FIXMEs about the commands being confusingly named.
2513         * Scripts/webkitpy/commands/queries_unittest.py:
2514          - Update results to reflect the newly restructured mock bug cache.
2515         * Scripts/webkitpy/commands/queues.py:
2516          - Add a new _validate_patches_in_commit_queue method (this is what fixes the regression).
2517          - Add a FIXME about eventually sorting the patches into some order.
2518         * Scripts/webkitpy/commands/queues_unittest.py:
2519          - Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer.
2520         * Scripts/webkitpy/commands/upload_unittest.py:
2521          - Update results to match the newly restructured mock bug cache.
2522         * Scripts/webkitpy/mock_bugzillatool.py:
2523          - Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs.
2524          - Add a few more attachments and bug dictionaries for use by the tests.
2525
2526 2010-01-13  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2527
2528         Reviewed by Kenneth Christiansen.
2529
2530         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
2531         https://bugs.webkit.org/show_bug.cgi?id=33617
2532
2533         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2534         (WebCore::WebPage::resetSettings):
2535         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2536         (LayoutTestController::setUserStyleSheetLocation):
2537         (LayoutTestController::setUserStyleSheetEnabled):
2538         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2539
2540 2010-01-14  Adam Roben  <aroben@apple.com>
2541
2542         Add LayoutTestController API to force
2543         -webView:resource:willSendRequest:: to return null
2544
2545         Enables tests for <rdar://problem/7533333> <http://webkit.org/b/33533>
2546         window.onload never fires if page contains an <iframe> with a bad
2547         scheme or whose load is cancelled by returning null from resource load
2548         delegate's willSendRequest
2549
2550         Reviewed by Brady Eidson.
2551
2552         * DumpRenderTree/LayoutTestController.cpp:
2553         (LayoutTestController::LayoutTestController): Initialize new member.
2554         (setWillSendRequestReturnsNullCallback): Call through to
2555         LayoutTestController.
2556         (LayoutTestController::staticFunctions): Added new function.
2557
2558         * DumpRenderTree/LayoutTestController.h: Added
2559         m_willSendRequestReturnsNull.
2560         (LayoutTestController::willSendRequestReturnsNull):
2561         (LayoutTestController::setWillSendRequestReturnsNull):
2562         Added standard accessors.
2563
2564         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2565         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2566         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2567         (ResourceLoadDelegate::willSendRequest):
2568         Return null if LayoutTestController says to.
2569
2570 2010-01-14  Kevin Ollivier  <kevino@theolliviers.com>
2571
2572         [wx] Build fix after removal of XBM support.
2573
2574         * wx/build/settings.py:
2575
2576 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2577
2578         Reviewed by Simon Hausmann.
2579
2580         Add support for partial building on Symbian.
2581
2582         The build happens in the source directory as out of source builds are
2583         not supported by qmake for Symbian.
2584
2585         Also the actual build isn't started but it is left to the developer
2586         to choose the architecture/configuration.
2587
2588         * Scripts/webkitdirs.pm:
2589
2590 2010-01-14  Simon Hausmann  <simon.hausmann@nokia.com>
2591
2592         Reviewed by Kenneth Rohde Christiansen.
2593
2594         Add support for "detecting" Symbian environments by either
2595         looking for the EPOCROOT environment variable or via --symbian
2596         being passed on the commandline.
2597
2598         * Scripts/webkitdirs.pm:
2599
2600 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2601
2602         Unreviewed.
2603
2604         [Qt] Use a different Makefile names for sources generation and compilation.
2605         This prevents Makefile overwriting when running build-webkit twice.
2606
2607         * Scripts/webkitdirs.pm:
2608
2609 2010-01-14  Andreas Kling  <andreas.kling@nokia.com>
2610
2611         Reviewed by Kenneth Rohde Christiansen.
2612
2613         [Qt] Add an "alien_QLabel" classId for manual testing of alien widgets.
2614
2615         https://bugs.webkit.org/show_bug.cgi?id=33373
2616
2617         * QtLauncher/main.cpp:
2618         (WebPage::createPlugin):
2619
2620 2010-01-14  Eric Seidel  <eric@webkit.org>
2621
2622         No review, rolling out r53249.
2623         http://trac.webkit.org/changeset/53249
2624         https://bugs.webkit.org/show_bug.cgi?id=33617
2625
2626         This caused http/tests/security/local-user-CSS-from-
2627         remote.html to fail on the Qt Release Build Bot.
2628
2629         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2630         (WebCore::WebPage::resetSettings):
2631         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2632         (LayoutTestController::overridePreference):
2633         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2634
2635 2010-01-14  Chris Jerdonek  <chris.jerdonek@gmail.com>
2636
2637         Reviewed by Shinichiro Hamaji.
2638
2639         Moved error() from cpp_style.py to checker.py.
2640
2641         https://bugs.webkit.org/show_bug.cgi?id=33620
2642
2643         * Scripts/check-webkit-style:
2644           - Addressed FIXME to not set global state.
2645
2646         * Scripts/webkitpy/style/checker.py:
2647           - Added argument validation to ProcessorOptions constructor.
2648           - Added should_report_error() to ProcessorOptions class.
2649           - Removed set_options().
2650           - Added StyleChecker class.
2651
2652         * Scripts/webkitpy/style/checker_unittest.py:
2653           - Added unit test class for ProcessorOptions class.
2654           - Added unit test to check that parse() strips white space.
2655
2656         * Scripts/webkitpy/style/cpp_style.py:
2657           - Removed "filter" and "output_format" methods.
2658           - Removed should_print_error() and error() functions.
2659           - Removed default parameter value from process_file().
2660
2661         * Scripts/webkitpy/style/cpp_style_unittest.py:
2662           - Removed call to cpp_style._should_print_error().
2663           - Removed test_filter() and test_filter_appending().
2664
2665         * Scripts/webkitpy/style/text_style.py:
2666           - Removed default parameter value from process_file().
2667
2668 2010-01-14  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2669
2670         Reviewed by Kenneth Rohde Christiansen.
2671
2672         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
2673         https://bugs.webkit.org/show_bug.cgi?id=33617
2674
2675         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2676         (WebCore::WebPage::resetSettings):
2677         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2678         (LayoutTestController::setUserStyleSheetLocation):
2679         (LayoutTestController::setUserStyleSheetEnabled):
2680         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2681
2682 2010-01-13  Adam Barth  <abarth@webkit.org>
2683
2684         Reviewed by Eric Seidel.
2685
2686         Fix CloseBugForLandDiff unittest to actually run
2687         https://bugs.webkit.org/show_bug.cgi?id=33640
2688
2689         * Scripts/webkitpy/mock_bugzillatool.py:
2690         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
2691
2692 2010-01-12  Jon Honeycutt  <jhoneycutt@apple.com>
2693
2694         MSAA: selected, selectable, extended selectable, and multiple
2695         selectable states are not reported
2696
2697         https://bugs.webkit.org/show_bug.cgi?id=33574
2698         <rdar://problem/7536826>
2699
2700         Reviewed by Darin Adler.
2701
2702         * DumpRenderTree/AccessibilityUIElement.cpp:
2703         (getIsSelectableCallback):
2704         Return the result of calling isSelectable().
2705         (getIsMultiSelectableCallback):
2706         Return the result of calling isMultiSelectable().
2707         (AccessibilityUIElement::getJSClass):
2708         Add isSelected and isMultiSelectable properties to the JSClass
2709         definition.
2710
2711         * DumpRenderTree/AccessibilityUIElement.h:
2712         Declare isSelectable() and isMultiSelectable().
2713
2714         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2715         (AccessibilityUIElement::isSelectable):
2716         Stubbed.
2717         (AccessibilityUIElement::isMultiSelectable):
2718         Stubbed.
2719
2720         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2721         (AccessibilityUIElement::isSelectable):
2722         Stubbed.
2723         (AccessibilityUIElement::isMultiSelectable):
2724         Stubbed.
2725
2726         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2727         (accessibilityState):
2728         Get the object's state, and return it.
2729         (AccessibilityUIElement::isSelected):
2730         Check the object's selected state.
2731         (AccessibilityUIElement::isSelectable):
2732         Check the object's selectable state.
2733         (AccessibilityUIElement::isMultiSelectable):
2734         Check the object's extended/multiple selectable state.
2735
2736 2010-01-13  Adam Barth  <abarth@webkit.org>
2737
2738         Unreviewed.  Repeat the below for CloseBugForLandDiff.
2739
2740         * Scripts/test-webkitpy:
2741         * Scripts/webkitpy/steps/closebugforlanddiff.py:
2742         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added.
2743
2744 2010-01-13  Adam Barth  <abarth@webkit.org>
2745
2746         Unreviewed.  Turn the mac-ews status bubbles back on now that this bot
2747         is running again.
2748
2749         * QueueStatusServer/templates/statusbubble.html:
2750
2751 2010-01-13  Adam Barth  <abarth@webkit.org>
2752
2753         Reviewed by Darin Adler.
2754
2755         REGRESSION(53133): webkit-patch land dies if it can't find a bug id.
2756         https://bugs.webkit.org/show_bug.cgi?id=33634
2757
2758         Deal with the case of no bug patch object in the state.
2759
2760         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
2761         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py:
2762
2763 2010-01-13  Kenneth Russell  <kbr@google.com>
2764
2765         Unreviewed; added myself to the committers list.
2766
2767         * Scripts/webkitpy/committers.py:
2768
2769 2010-01-13  Darin Adler  <darin@apple.com>
2770
2771         Ignore compiled Python in more of webkitpy.
2772
2773         * Scripts/webkitpy/commands: Added property svn:ignore.
2774         * Scripts/webkitpy/steps: Added property svn:ignore.
2775         * Scripts/webkitpy/style: Added property svn:ignore.
2776
2777 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2778
2779         Reviewed by Simon Hausmann.
2780
2781         [Qt] Fix build problem related to the pushd command
2782
2783         * Scripts/webkitdirs.pm:
2784
2785 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2786
2787         Reviewed by Simon Hausmann.
2788
2789         [Qt] Split the build process in two different .pro files.
2790         This allows qmake to be run once all source files are available.
2791
2792         * Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC.
2793
2794 2010-01-13  Shinichiro Hamaji  <hamaji@chromium.org>
2795
2796         Unreviewed tiny typo fix in docstrings.
2797
2798         * Scripts/webkitpy/style/checker_unittest.py:
2799
2800 2010-01-13  Chris Jerdonek  <chris.jerdonek@gmail.com>
2801
2802         Reviewed by Shinichiro Hamaji.
2803
2804         Created a CategoryFilter class to encapsulate the logic of
2805         filter rules.
2806
2807         https://bugs.webkit.org/show_bug.cgi?id=33454
2808
2809         * Scripts/webkitpy/style/checker.py:
2810           - Added CategoryFilter class.
2811
2812         * Scripts/webkitpy/style/checker_unittest.py:
2813           - Added CategoryFilter unit tests.
2814
2815         * Scripts/webkitpy/style/cpp_style.py:
2816           - Updated filter methods to use CategoryFilter.
2817
2818         * Scripts/webkitpy/style/cpp_style_unittest.py:
2819           - Updated references to filters.
2820
2821 2010-01-12  Shinichiro Hamaji  <hamaji@chromium.org>
2822
2823         Unreviewed. Now I can review :)
2824
2825         * Scripts/webkitpy/committers.py:
2826
2827 2010-01-12  Brent Fulgham  <bfulgham@webkit.org>
2828
2829         Reviewed by Darin Adler.
2830
2831         Extend WinLauncher example with better printing features.
2832
2833         * WinLauncher/PrintWebUIDelegate.cpp:
2834         (PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly
2835          larger margins.
2836         (PrintWebUIDelegate::webViewHeaderHeight): Compute header height based
2837          on text metrics.
2838         (PrintWebUIDelegate::webViewFooterHeight): Compute footer height based
2839          on text metrics.
2840         (PrintWebUIDelegate::drawHeaderInRect): Write useful header, along
2841          with separating line.
2842         (PrintWebUIDelegate::drawFooterInRect):
2843         * WinLauncher/PrintWebUIDelegate.h: Remove stubs.
2844         * WinLauncher/WinLauncher.cpp:
2845         (PrintView): Correct loop used to print individual pages.
2846          Previously it started at 0, which is a wild-card to print all
2847          pages at once.
2848
2849 2010-01-12  Alexey Proskuryakov  <ap@apple.com>
2850
2851         Reviewed by Darin Adler.
2852
2853         https://bugs.webkit.org/show_bug.cgi?id=33540
2854         Make it possible to build in debug mode with assertions disabled
2855
2856         * DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]):
2857
2858 2010-01-11  Darin Fisher  <darin@chromium.org>
2859
2860         Reviewed by Dimitri Glazkov.
2861
2862         [Chromium] "build-webkit --chromium" should run "make all" on Linux
2863         https://bugs.webkit.org/show_bug.cgi?id=33500
2864
2865         * Scripts/webkitdirs.pm:
2866
2867 2010-01-12  Eric Seidel  <eric@webkit.org>
2868
2869         Reviewed by Adam Barth.
2870
2871         AssignToCommitter does not need to fetch bugs twice
2872         https://bugs.webkit.org/show_bug.cgi?id=33530
2873
2874         This is a no-brainer patch now that we've added Bug.reviewed_patches
2875
2876         * Scripts/webkitpy/commands/upload.py:
2877
2878 2010-01-12  Eric Seidel  <eric@webkit.org>
2879
2880         Reviewed by Adam Barth.
2881
2882         bugzilla.py should have an Attachment object instead of passing around dictionaries
2883         https://bugs.webkit.org/show_bug.cgi?id=31594
2884
2885         * Scripts/webkitpy/bugzilla.py:
2886          - Add a new Attachment class, with accessor methods for all the necessary properties.
2887          - Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url())
2888          - Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug
2889          - Move committer validation logic into its own class.
2890          - Committer rejection is only used in one place.  Make the new Bug reviewed_patches and commit_queued_patches
2891            handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle
2892            the case where we want to reject patches in bugzilla.
2893          - Simplify fetch_patches_from_commit_queue now that committer validation is simpler.
2894          - Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug.
2895          - Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it.
2896          - Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class.
2897         * Scripts/webkitpy/bugzilla_unittest.py:
2898          - Move test_flag_permission_rejection_message into a new CommitterValidationTest class.
2899         * Scripts/webkitpy/commands/download.py:
2900          - Store "bug_id" in state instead of making a fake patch object.
2901          - Update to use Attachment and Bug objects.
2902         * Scripts/webkitpy/commands/download_unittest.py:
2903          - Update expected results now that our testing framework covers more code.
2904         * Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class.
2905         * Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class.
2906         * Scripts/webkitpy/commands/queries_unittest.py: ditto.
2907         * Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes.
2908         * Scripts/webkitpy/commands/queuestest.py: ditto.
2909         * Scripts/webkitpy/commands/upload.py: ditto.
2910         * Scripts/webkitpy/mock_bugzillatool.py:
2911          - Now that more logic has moved into Attachment and Bug, we have to actually
2912            provide real reviewer emails as well as real reviewer flags.
2913          - Update mock methods to return Attachment objects.
2914         * Scripts/webkitpy/scm.py: Update to use Attachment class.
2915         * Scripts/webkitpy/scm_unittest.py: Update to use Attachment class.
2916         * Scripts/webkitpy/statusserver.py: ditto.
2917         * Scripts/webkitpy/steps/applypatch.py: ditto.
2918         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto.
2919         * Scripts/webkitpy/steps/closebug.py: ditto.
2920         * Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either state["bug_id"] or state["patch"].bug_id()
2921         * Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class.
2922         * Scripts/webkitpy/steps/obsoletepatches.py: ditto.
2923         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto.
2924
2925 2010-01-12  Adam Barth  <abarth@webkit.org>
2926
2927         Unreviewed typo fix.  :(
2928
2929         * Scripts/webkitpy/commands/early_warning_system.py:
2930         * Scripts/webkitpy/commands/queues.py:
2931
2932 2010-01-12  Adam Barth  <abarth@webkit.org>
2933
2934         Unreviewed.  Add "error" to the right part of the message.
2935
2936         * Scripts/webkitpy/commands/queues.py:
2937
2938 2010-01-12  Adam Barth  <abarth@webkit.org>
2939
2940         Reviewed by Eric Seidel.
2941
2942         EWS should show purple when svn-apply fails
2943         https://bugs.webkit.org/show_bug.cgi?id=33527
2944
2945         * Scripts/webkitpy/commands/early_warning_system.py:
2946         * Scripts/webkitpy/commands/queues.py:
2947
2948 2010-01-12  Adam Barth  <abarth@webkit.org>
2949
2950         Reviewed by Eric Seidel.
2951
2952         Remove copy/paste code from subclasses of AbstractReviewQueue
2953         https://bugs.webkit.org/show_bug.cgi?id=33525
2954
2955         * Scripts/webkitpy/commands/early_warning_system.py:
2956         * Scripts/webkitpy/commands/queues.py:
2957
2958 2010-01-12  Adam Barth  <abarth@webkit.org>
2959
2960         Reviewed by Eric Seidel.
2961
2962         Add Gustavo and Xan as gtk-ews watchers
2963         https://bugs.webkit.org/show_bug.cgi?id=33519
2964
2965         * Scripts/webkitpy/commands/early_warning_system.py:
2966
2967 2010-01-12  Adam Barth  <abarth@webkit.org>
2968
2969         Reviewed by Eric Seidel.
2970
2971         webkit-patch shouldn't waste my time for with a component prompt
2972         https://bugs.webkit.org/show_bug.cgi?id=33521
2973
2974         The component field isn't very useful for bugs created with
2975         webkit-patch because they're likely to be resolved quickly.  Instead of
2976         always prompting for a component, we should just default to the "New
2977         Bugs" component.  If the bug stays around for more than five minutes,
2978         we can assign it a proper component.
2979
2980         * Scripts/webkitpy/bugzilla.py:
2981
2982 2010-01-12  Adam Barth  <abarth@webkit.org>
2983
2984         Reviewed by Eric Seidel.
2985
2986         Add experimental "land-safely" command to webkit-patch
2987         https://bugs.webkit.org/show_bug.cgi?id=33518
2988
2989         * Scripts/webkitpy/commands/upload.py:
2990         * Scripts/webkitpy/commands/upload_unittest.py:
2991         * Scripts/webkitpy/steps/__init__.py:
2992         * Scripts/webkitpy/steps/postdiffforcommit.py: Added.
2993
2994 2010-01-11  Kevin Ollivier  <kevino@theolliviers.com>
2995
2996         [wx] Build fix after introduction of JS_NO_EXPORT
2997         
2998         * wx/build/settings.py:
2999
3000 2010-01-11  Eric Seidel  <eric@webkit.org>
3001
3002         No review, rolling out r53079.
3003         http://trac.webkit.org/changeset/53079
3004         https://bugs.webkit.org/show_bug.cgi?id=33197
3005
3006         Adam doens't think this actually works, and believe it caused
3007         a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so
3008         rolling this out.
3009
3010         * Scripts/test-webkitpy:
3011         * Scripts/webkitpy/commands/abstractdiffcommand.py: Removed.
3012         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed.
3013         * Scripts/webkitpy/commands/download.py:
3014         * Scripts/webkitpy/commands/upload.py:
3015         * Scripts/webkitpy/mock_bugzillatool.py:
3016
3017 2010-01-10  Adam Barth  <abarth@webkit.org>
3018
3019         Reviewed by David Kilzer.
3020
3021         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
3022         https://bugs.webkit.org/show_bug.cgi?id=33197
3023
3024         We should just search for bug numbers in the ChangeLogs instead of in
3025         the whole diff.
3026  
3027         * Scripts/test-webkitpy:
3028         * Scripts/webkitpy/commands/abstractdiffcommand.py: Added.
3029         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added.
3030         * Scripts/webkitpy/commands/download.py:
3031         * Scripts/webkitpy/commands/upload.py:
3032         * Scripts/webkitpy/mock_bugzillatool.py:
3033
3034 2010-01-11  Chris Jerdonek  <chris.jerdonek@gmail.com>
3035
3036         Reviewed by David Kilzer.
3037
3038         Created a unit-tested function to parse the header block of
3039         a Git or SVN diff -- for future refactoring of svn-apply and
3040         svn-unapply.
3041
3042         https://bugs.webkit.org/show_bug.cgi?id=33447
3043
3044         * Scripts/VCSUtils.pm:
3045           - Added parseDiffHeader().
3046           - Removed irrelevant comment from gitdiff2svndiff().
3047
3048         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added.
3049           - Added 48 unit tests for parseDiffHeader().
3050
3051 2010-01-10  Adam Barth  <abarth@webkit.org>
3052
3053         Rubber stamped by David Kilzer.
3054
3055         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
3056         https://bugs.webkit.org/show_bug.cgi?id=33197
3057
3058         Fix a typo: Commmand -> Command.
3059
3060         * Scripts/webkitpy/commands/abstractsequencedcommand.py:
3061         * Scripts/webkitpy/commands/download.py:
3062         * Scripts/webkitpy/commands/queries.py:
3063         * Scripts/webkitpy/commands/upload.py:
3064         * Scripts/webkitpy/multicommandtool.py:
3065
3066 2010-01-10  Adam Barth  <abarth@webkit.org>
3067
3068         Reviewed by Darin Adler.
3069
3070         Let webkit-patch work with options in $EDITOR
3071         https://bugs.webkit.org/show_bug.cgi?id=33414
3072
3073         The $EDITOR evironment variable might have command line options like
3074         bbedit -w.  This patch lets us run those $EDITORs.
3075
3076         * Scripts/webkitpy/user.py:
3077
3078 2010-01-10  Robert Hogan  <robert@roberthogan.net>
3079
3080         Reviewed by Adam Barth.
3081
3082         [Qt] Add enableXSSAuditor support to QWebSettings and DRT.
3083
3084         https://bugs.webkit.org/show_bug.cgi?id=33419
3085
3086         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3087         (WebCore::WebPage::WebPage):
3088         (WebCore::WebPage::resetSettings):
3089         (WebCore::DumpRenderTree::createWindow):
3090         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3091         (LayoutTestController::setXSSAuditorEnabled):
3092         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3093
3094 2010-01-10  Adam Barth  <abarth@webkit.org>
3095
3096         Unreviewed cosmetic change.  Remove the status bubble for mac-ews
3097         because we don't have hardware for it at the moment.
3098
3099         * QueueStatusServer/templates/statusbubble.html:
3100
3101 2010-01-09  Daniel Bates  <dbates@webkit.org>
3102
3103         No review, rolling out r53044.
3104         http://trac.webkit.org/changeset/53044
3105         https://bugs.webkit.org/show_bug.cgi?id=33419
3106         
3107         We need to look into this some more because the Qt
3108         bot is failing the XSSAuditor tests. See bug #33419
3109         for more details.
3110
3111         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3112         (WebCore::WebPage::WebPage):
3113         (WebCore::WebPage::resetSettings):
3114         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3115         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3116
3117 2010-01-09  Daniel Bates  <dbates@webkit.org>
3118
3119         Reviewed by Adam Barth.
3120
3121         https://bugs.webkit.org/show_bug.cgi?id=33419
3122
3123         Adds support for the XSSAuditor to the Qt DRT.
3124
3125         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3126         (WebCore::WebPage::WebPage):
3127         (WebCore::WebPage::resetSettings):
3128         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3129         (LayoutTestController::setXSSAuditorEnabled):
3130         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3131
3132 2010-01-09  Adam Barth  <abarth@webkit.org>
3133
3134         Reviewed by Eric Seidel.
3135
3136         Retry writes to QueueStatusServer when we get 500 errors
3137         https://bugs.webkit.org/show_bug.cgi?id=33412
3138
3139         This prevents the queues from failing to mark a patch as "pass" or
3140         "fail" when AppEngine throws 500 errors.
3141
3142         * Scripts/test-webkitpy:
3143         * Scripts/webkitpy/networktransaction.py: Added.
3144         * Scripts/webkitpy/networktransaction_unittest.py: Added.
3145         * Scripts/webkitpy/statusserver.py:
3146         * Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added.
3147         * Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added.
3148         * Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added.
3149
3150 2010-01-09  David Kilzer  <ddkilzer@apple.com>
3151
3152         <http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers
3153
3154         Reviewed by Eric Seidel.
3155
3156         * QueueStatusServer/templates/statusbubble.html: Added
3157         -moz-border-radius and -webkit-border-radius to provide rounded
3158         borders in older Firefox and Safari browsers.
3159
3160 2010-01-09  Chris Jerdonek  <chris.jerdonek@gmail.com>
3161
3162         Reviewed by David Kilzer.
3163
3164         Modified VCSUtils::gitdiff2svndiff() to accept strings that
3165         end in vertical white space.
3166
3167         https://bugs.webkit.org/show_bug.cgi?id=33415
3168
3169         * Scripts/VCSUtils.pm:
3170         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
3171
3172 2010-01-08  Eric Seidel  <eric@webkit.org>
3173
3174         Reviewed by Adam Barth.
3175
3176         run-javascriptcore-tests needs a --quiet flag
3177         https://bugs.webkit.org/show_bug.cgi?id=33399
3178
3179         Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch.
3180
3181         * Scripts/webkitpy/steps/runtests.py:
3182
3183 2010-01-08  Andras Becsi  <abecsi@inf.u-szeged.hu>
3184
3185         Reviewed by Alexey Proskuryakov.
3186
3187         Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order.
3188
3189         To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize
3190         the time when Apache and WebSocketServer is locked by tests.
3191         Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing,
3192         we need to run http and websocket tests after all other tests.
3193         If one however explicitly specifies the tests to run in the argument list of run-webkit-tests
3194         we need to preserve the given order.
3195
3196         * Scripts/run-webkit-tests:
3197
3198 2010-01-08  Adam Barth  <abarth@webkit.org>
3199
3200         Reviewed by Eric Seidel.
3201
3202         Don't post style-queue pass messages to bugs
3203         https://bugs.webkit.org/show_bug.cgi?id=33404
3204
3205         These messages aren't needed any more now that we have the status
3206         bubble reporting pass events passively.
3207
3208         * Scripts/webkitpy/commands/queues.py:
3209
3210 2010-01-08  Adam Barth  <abarth@webkit.org>
3211
3212         Reviewed by Eric Seidel.
3213
3214         Optimize the number of CPUs used for building Qt and Gtk
3215         https://bugs.webkit.org/show_bug.cgi?id=33394
3216
3217         Instead of hardcoding the number 8, we should read the number of CPUs
3218         from the environment.
3219
3220         * Scripts/webkitpy/executive.py:
3221         * Scripts/webkitpy/webkitport.py:
3222         * Scripts/webkitpy/webkitport_unittest.py:
3223
3224 2010-01-08  Chris Fleizach  <cfleizach@apple.com>
3225
3226         Reviewed by Eric Seidel.
3227
3228         REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
3229         https://bugs.webkit.org/show_bug.cgi?id=33300
3230
3231         * DumpRenderTree/AccessibilityUIElement.h:
3232         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3233         (AccessibilityUIElement::AccessibilityUIElement):
3234         (AccessibilityUIElement::~AccessibilityUIElement):
3235         (_accessibilityNotificationCallback):
3236         (AccessibilityUIElement::addNotificationListener):
3237
3238 2010-01-08  Eric Seidel  <eric@webkit.org>
3239
3240         Reviewed by Simon Hausmann.
3241
3242         commit-queue should run run-javascriptcore-tests
3243         https://bugs.webkit.org/show_bug.cgi?id=33376
3244
3245         I also made it run the python and perl unit tests.
3246
3247         * Scripts/webkitpy/steps/runtests.py:
3248         * Scripts/webkitpy/webkitport.py:
3249
3250 2010-01-07  Andras Becsi  <abecsi@inf.u-szeged.hu>
3251
3252         Reviewed by Darin Adler.
3253
3254         Run the http and websocket tests after all other tests.
3255         https://bugs.webkit.org/show_bug.cgi?id=33153
3256
3257         * Scripts/run-webkit-tests:
3258
3259 2010-01-07  Adam Barth  <abarth@webkit.org>
3260
3261         Reviewed by Eric Seidel.
3262
3263         Fix some test-webkitpy expectations
3264         https://bugs.webkit.org/show_bug.cgi?id=33345
3265
3266         I forgot to change these when I added the CheckStyle step.
3267
3268         * Scripts/webkitpy/commands/upload_unittest.py:
3269
3270 2010-01-07  Adam Barth  <abarth@webkit.org>
3271
3272         Reviewed by Eric Seidel.
3273
3274         webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
3275         https://bugs.webkit.org/show_bug.cgi?id=33341
3276
3277         Fix this by moving to the root directory before editing ChangeLogs.
3278         There is a related bug with CheckStyle.
3279
3280         * Scripts/webkitpy/steps/checkstyle.py:
3281         * Scripts/webkitpy/steps/editchangelog.py:
3282
3283 2010-01-07  Eric Seidel  <eric@webkit.org>
3284
3285         Reviewed by Nikolas Zimmermann.
3286
3287         media/unsupported-tracks.html is failing on Snow Leopard Release bot
3288         https://bugs.webkit.org/show_bug.cgi?id=32339
3289
3290         This is a speculative fix.  I do not have a Snow Leopard machine to test on
3291         and I've not seen mention of someone being able to reproduce this locally.
3292
3293         Prevent watchdog timer from firing after a test completes but before
3294         the next one starts, causing the error to appear in the next test.
3295
3296         * DumpRenderTree/mac/DumpRenderTree.mm:
3297         (dump): Stop the watchdog before printing #EOF for the test content.
3298         We only need to care about the JavaScript of the test running too long
3299         or some hang in WebCore.  Any other failures will be covered by the calling
3300         script's own watchdog timer.
3301
3302 2010-01-07  Eric Seidel  <eric@webkit.org>
3303
3304         Reviewed by Adam Barth.
3305
3306         commit-queue is stuck spinning due to exception
3307         https://bugs.webkit.org/show_bug.cgi?id=33358
3308
3309         * Scripts/webkitpy/commands/queues.py:
3310          - Don't try to stringify the exception.
3311
3312 2010-01-07  Mark Rowe  <mrowe@apple.com>
3313
3314         Reviewed by Jon Honeycutt.
3315
3316         Don't leak a JSStringRef within _accessibilityNotificationCallback.
3317
3318         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3319         (_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up
3320         when it goes out of scope.
3321
3322 2010-01-07  Simon Fraser  <simon.fraser@apple.com>
3323
3324         Reviewed by Darin Adler.
3325
3326         Add proposed rename of HTMLPlugInImageElement to HTMLEmbeddedObjectElement.
3327
3328         * Scripts/do-webcore-rename:
3329
3330 2010-01-07  Kim Grönholm  <kim.gronholm@nomovok.com>
3331
3332         Reviewed by Antti Koivisto.
3333
3334         Wrong state and TouchLists in TouchEvents
3335         https://bugs.webkit.org/show_bug.cgi?id=32878
3336
3337         * DumpRenderTree/qt/EventSenderQt.cpp:
3338         (EventSender::touchStart):
3339         (EventSender::touchEnd):
3340         (EventSender::clearTouchPoints):
3341         * DumpRenderTree/qt/EventSenderQt.h:
3342
3343 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
3344
3345         Reviewed by Adam Barth.
3346
3347         Created a module that runs the style package unit tests.
3348
3349         https://bugs.webkit.org/show_bug.cgi?id=32973
3350
3351         * Scripts/test-webkitpy:
3352         * Scripts/webkitpy/style/unittests.py: Added.
3353
3354 2010-01-07  Adam Barth  <abarth@webkit.org>
3355
3356         Reviewed by Maciej Stachowiak.
3357
3358         Don't print a redundant message when confirming a diff
3359         https://bugs.webkit.org/show_bug.cgi?id=33315
3360
3361         Instead of saying "ERROR: User declined" we should just exit because
3362         the use knows they just declined!
3363
3364         * Scripts/webkitpy/steps/confirmdiff.py:
3365
3366 2010-01-07  Adam Barth  <abarth@webkit.org>
3367
3368         Reviewed by Maciej Stachowiak.
3369
3370         Check style before uploading a patch
3371         https://bugs.webkit.org/show_bug.cgi?id=33314
3372
3373         * Scripts/webkitpy/commands/upload.py:
3374         * Scripts/webkitpy/steps/checkstyle.py:
3375         * Scripts/webkitpy/steps/options.py:
3376
3377 2010-01-07  Adam Barth  <abarth@webkit.org>
3378
3379         Reviewed by Maciej Stachowiak.
3380
3381         Add prepare and post to webkit-patch main help
3382         https://bugs.webkit.org/show_bug.cgi?id=33313
3383
3384         * Scripts/webkitpy/commands/upload.py:
3385
3386 2010-01-07  Eric Seidel  <eric@webkit.org>
3387
3388         Reviewed by Adam Barth.
3389
3390         Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
3391         https://bugs.webkit.org/show_bug.cgi?id=33290
3392
3393         Add the Chromium builders to our list of core builders and test that our regexps work.
3394         I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.
3395
3396         * Scripts/webkitpy/buildbot.py:
3397         * Scripts/webkitpy/buildbot_unittest.py:
3398
3399 2010-01-07  Adam Barth  <abarth@webkit.org>
3400
3401         Reviewed by Eric Seidel.
3402
3403         bugzilla-tool needs a new name
3404         https://bugs.webkit.org/show_bug.cgi?id=28459
3405
3406         Rename bugzilla-tool to webkit-patch.  Also, rename some commands to
3407         make more sense with the new name.
3408
3409         * Scripts/bugzilla-tool: Removed.
3410         * Scripts/webkit-patch: Added.
3411         * Scripts/webkit-tools-completion.sh:
3412         * Scripts/webkitpy/bugzilla_unittest.py:
3413         * Scripts/webkitpy/commands/download.py:
3414         * Scripts/webkitpy/commands/download_unittest.py:
3415         * Scripts/webkitpy/commands/early_warning_system.py:
3416         * Scripts/webkitpy/commands/queries.py:
3417         * Scripts/webkitpy/commands/queues.py:
3418         * Scripts/webkitpy/commands/queues_unittest.py:
3419         * Scripts/webkitpy/commands/upload.py:
3420         * Scripts/webkitpy/commands/upload_unittest.py:
3421         * Scripts/webkitpy/queueengine.py:
3422         * Scripts/webkitpy/steps/completerollout.py:
3423
3424 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
3425
3426         Reviewed by Eric Seidel.
3427
3428         Moved style-related modules to webkitpy.style sub-package.
3429
3430         https://bugs.webkit.org/show_bug.cgi?id=32971
3431
3432         * Scripts/check-webkit-style:
3433           - Updated import statement.
3434
3435         * Scripts/test-webkitpy:
3436           - Updated import statements.
3437
3438         * Scripts/webkitpy/cpp_style.py: Removed.
3439           - Moved to webkitpy/style.
3440
3441         * Scripts/webkitpy/cpp_style_unittest.py: Removed.
3442           - Moved to webkitpy/style.
3443
3444         * Scripts/webkitpy/style.py: Removed.
3445           - Moved to webkitpy/style/checker.py.
3446
3447         * Scripts/webkitpy/style/__init__.py: Added.
3448           - Added containing webkitpy directory to package search path.
3449
3450         * Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
3451         * Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
3452           - Updated import statement.
3453
3454         * Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
3455         * Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
3456           - Update import statement.
3457
3458         * Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
3459         * Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
3460         * Scripts/webkitpy/style_unittest.py: Removed.
3461           - Moved to webkitpy/style/checker_unittest.py.
3462
3463         * Scripts/webkitpy/text_style.py: Removed.
3464           - Moved to webkitpy/style.
3465
3466         * Scripts/webkitpy/text_style_unittest.py: Removed.
3467           - Moved to webkitpy/style.
3468
3469 2010-01-06  Kinuko Yasuda  <kinuko@chromium.org>
3470
3471         Reviewed by Eric Seidel.
3472
3473         [Qt] Support the 3rd argument of EventSender.keyDown that
3474         has been recently added to report keyLocation
3475         (see also: https://bugs.webkit.org/show_bug.cgi?id=28247).
3476         https://bugs.webkit.org/show_bug.cgi?id=33250
3477
3478         Test: fast/events/keydown-numpad-keys.html
3479
3480         * DumpRenderTree/qt/EventSenderQt.cpp:
3481         (EventSender::keyDown):
3482         * DumpRenderTree/qt/EventSenderQt.h:
3483
3484 2010-01-06  Eric Seidel  <eric@webkit.org>
3485
3486         Reviewed by Adam Barth.
3487
3488         Add long_help for all common commands.
3489         https://bugs.webkit.org/show_bug.cgi?id=33261
3490
3491         For now these long_helps are pretty basic.
3492         These were all written to just explain the steps
3493         that each command runs.  This style long_help could
3494         be made easier by using:
3495         https://bugs.webkit.org/show_bug.cgi?id=33257
3496
3497         * Scripts/webkitpy/commands/download.py:
3498         * Scripts/webkitpy/commands/queries.py:
3499
3500 2010-01-06  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3501
3502         Reviewed by Kenneth Christiansen.
3503
3504         [Qt] Add page zooming support to Qt DumpRenderTree
3505         https://bugs.webkit.org/show_bug.cgi?id=32898
3506
3507         Patch by Kim Grönholm  <kim.gronholm@nomovok.com>,
3508                  Diego Gonzalez <diego.gonzalez@openbossa.org> and
3509                  Afonso Costa <afonso.costa@openbossa.org>
3510
3511         * DumpRenderTree/qt/EventSenderQt.cpp:
3512         (EventSender::zoomPageIn):
3513         (EventSender::zoomPageOut):
3514         * DumpRenderTree/qt/EventSenderQt.h:
3515
3516 2010-01-06  Eric Seidel  <eric@webkit.org>
3517
3518         No review, just adding Mike Belshe's new bugzilla email at his request.
3519
3520         * Scripts/webkitpy/committers.py:
3521
3522 2010-01-06  Eric Seidel  <eric@webkit.org>
3523
3524         Unreviewed.  Rolling out r52869 and r52853 due to bot
3525         and local run-webkit-test failures
3526
3527         REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
3528         https://bugs.webkit.org/show_bug.cgi?id=33256
3529
3530         The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153
3531
3532         * Scripts/run-webkit-tests:
3533
3534 2010-01-06  Eric Seidel  <eric@webkit.org>
3535
3536         Unreviewed "build" fix.  Just adding missing include.
3537
3538         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
3539         https://bugs.webkit.org/show_bug.cgi?id=29212
3540
3541         * Scripts/webkitpy/steps/completerollout.py:
3542
3543 2010-01-06  Eric Seidel  <eric@webkit.org>
3544
3545         Reviewed by Adam Barth.
3546
3547         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
3548         https://bugs.webkit.org/show_bug.cgi?id=29212
3549
3550         * Scripts/webkitpy/bugzilla.py:
3551          - Make reopen_bug robust against the bug already being open.
3552         * Scripts/webkitpy/commands/download.py:
3553          - Remove dead code from Rollout.
3554         * Scripts/webkitpy/steps/completerollout.py:
3555          - Improve the rollout comment.
3556
3557 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
3558
3559         Reviewed by Darin Adler.
3560
3561         Set isHttpdOpen to 0 if pidfile does not exist for some reason.
3562         Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256.
3563
3564         * Scripts/run-webkit-tests:
3565
3566 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
3567
3568         Reviewed by Darin Adler.
3569
3570         Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(),
3571         and remove the httpd's pidfile directory if httpd terminated.
3572
3573         * Scripts/run-webkit-tests:
3574
3575 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3576
3577         Reviewed by David Levin.
3578
3579         Refactored check-webkit-style's argument parser to not rely
3580         on global state, and improved its error handling and unit
3581         test coverage.
3582
3583         https://bugs.webkit.org/show_bug.cgi?id=32966
3584
3585         * Scripts/check-webkit-style:
3586           - Adjusted to use new argument parser.
3587
3588         * Scripts/webkitpy/cpp_style.py:
3589           - Changed _CppStyleState to accept an array of filter rules
3590             instead of a comma-delimited string.
3591           - Eliminated cpp_style._DEFAULT_FILTER_RULES.
3592           - Eliminated cpp_style._USAGE.
3593
3594         * Scripts/webkitpy/cpp_style_unittest.py:
3595           - Updated test_filter() and test_default_filter().
3596
3597         * Scripts/webkitpy/style.py:
3598           - Converted style._USAGE to create_usage().
3599           - Corrected usage instructions by removing 0 as a valid
3600             --verbose flag value.
3601           - Removed use_webkit_styles().
3602           - Added ProcessorOptions class.
3603           - Added ArgumentDefaults class.
3604           - Added ArgumentPrinter class.
3605           - Removed parse_arguments and added ArgumentParser class.
3606           - Moved exit_with_usage() and exit_with_categories() into
3607             ArgumentParser.
3608           - Refactored parse_arguments() as ArgumentParser.parse().
3609           - Improved parser error handling.
3610
3611         * Scripts/webkitpy/style_unittest.py:
3612           - Added DefaultArgumentsTest class.
3613           - Addressed FIXME to check style.WEBKIT_FILTER_RULES
3614             against style.STYLE_CATEGORIES.
3615           - Added ArgumentPrinterTest class.
3616           - Added ArgumentParserTest class and rewrote parser unit tests.
3617
3618 2010-01-05  Adam Roben  <aroben@apple.com>
3619
3620         Test that it's safe to call IWebView::close when
3621         IWebView::initWithFrame hasn't been called
3622
3623         Part of <http://webkit.org/b/32827> Crash when calling
3624         IWebView::close, then releasing the WebView, without calling
3625         DestroyWindow
3626
3627         Reviewed by Steve Falkenburg.
3628
3629         * WebKitAPITest/tests/WebViewDestruction.cpp:
3630         (WebKitAPITest::CloseWithoutInitWithFrame): Calls IWebView::close
3631         without ever calling IWebView::initWithFrame and tests that we don't
3632         crash or leak.
3633
3634 2010-01-05  Adam Roben  <aroben@apple.com>
3635
3636         Add more WebViewDestruction tests
3637
3638         Fixes <http://webkit.org/b/33216>.
3639
3640         Reviewed by Eric Seidel.
3641
3642         * WebKitAPITest/tests/WebViewDestruction.cpp:
3643         (WebKitAPITest::NoInitWithFrame):
3644         (WebKitAPITest::CloseThenDestroyViewWindow):
3645         (WebKitAPITest::DestroyViewWindowThenClose):
3646         (WebKitAPITest::DestroyHostWindow):
3647         (WebKitAPITest::DestroyHostWindowThenClose):
3648         (WebKitAPITest::CloseThenDestroyHostWindow):
3649         Added these tests that exercise tearing down a WebView in various
3650         ways, all of which we eventually want to have work. Some of them
3651         currently crash or leak.
3652
3653 2010-01-05  Robert Hogan  <robert@roberthogan.net>
3654
3655         Reviewed by Eric Seidel.
3656
3657         [Qt] fix DRT link failures on --no-svg builds when only making changes to DRT
3658         
3659         If you're working from a --minimal or --no-svg build and make changes to the
3660         DRT, then recompile, the build will fail.
3661         
3662         This is because the current behavior at build time is to assume that the
3663         previous Qt build supported SVG and consequently delete libQtWebKit.so.
3664         Unfortunately, just deleting libQtWebKit.so will not cause the library to
3665         re-link. Instead the build will see libQtWebKit.so.4 and co., pass over the
3666         linking phase, and attempt to link the DRT with libQtWebKit.so absent. This
3667         results in a link failure on the DRT.
3668         
3669         Since re-linking libQtWebKit can take up to ten minutes and should be avoided
3670         in cases where not actually required, remove the assumption that
3671         the previous Qt build supported SVG, and amend the symbol detection to look for
3672         a symbol name that is not present in SVG builds. Currently webkitdirs.pm looks
3673         for 'SVGElement' but even non-SVG builds contain the symbol 'isSVGElement'.
3674         
3675         https://bugs.webkit.org/show_bug.cgi?id=32992
3676
3677         * Scripts/webkitdirs.pm:
3678
3679 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3680
3681         Reviewed by David Kilzer.
3682
3683         Switched to generating list of Perl unit test files dynamically,
3684         instead of explicitly.
3685
3686         https://bugs.webkit.org/show_bug.cgi?id=33200
3687
3688         * Scripts/test-webkitperl:
3689
3690 2010-01-05  Yael Aharon  <yael.aharon@nokia.com>
3691
3692         Reviewed by Kenneth Rohde Christiansen.
3693
3694         [Qt] Reimplement EventSender::leapForward
3695         https://bugs.webkit.org/show_bug.cgi?id=33114
3696
3697         Follow Windows implementation of leapForward. When leapForward is called, 
3698         messages are queued and posted after the timeout. A new event loop is created to
3699         handle those messages and the additional messages that are created as a result.
3700
3701         * DumpRenderTree/qt/DumpRenderTree.pro:
3702         * DumpRenderTree/qt/EventSenderQt.cpp:
3703         (EventSender::EventSender):
3704         (EventSender::mouseDown):
3705         (EventSender::mouseUp):
3706         (EventSender::mouseMoveTo):
3707         (EventSender::leapForward):
3708         (EventSender::sendOrQueueEvent):
3709         (EventSender::replaySavedEvents):
3710         (EventSender::eventFilter):
3711         * DumpRenderTree/qt/EventSenderQt.h:
3712
3713 2010-01-05  Adam Barth  <abarth@webkit.org>
3714
3715         Reviewed by Darin Adler.
3716
3717         Fix obscure queue crash in queueengine
3718         https://bugs.webkit.org/show_bug.cgi?id=33196
3719
3720         Sometimes we get an exception that can't be stringified.  For example:
3721
3722         AttributeError: 'ParseError' object has no attribute 'msg'
3723
3724         In these cases, the whole queue dies because we're in the global
3725         exception handler.  Instead of dieing here, we should just print a less
3726         informative message to the console.  We're already printing the whole
3727         backtrace anyway, so there's not much point to stringifying the
3728         exception anyway.
3729
3730         * Scripts/webkitpy/queueengine.py:
3731
3732 2010-01-05  Dominic Mazzoni  <dmazzoni@google.com>
3733
3734         Reviewed by Darin Adler.
3735
3736         https://bugs.webkit.org/show_bug.cgi?id=32571
3737
3738         For an object with an aria role of "checkbox" or "radiobutton",
3739         use the "aria-checked" attribute to determine if it's checked.
3740         These changes add an isChecked() method to AccessibilityUIElement
3741         so that we can check for this property from a layout test.
3742
3743         * DumpRenderTree/AccessibilityUIElement.cpp:
3744         (getIsCheckedCallback):
3745         (AccessibilityUIElement::getJSClass):
3746         * DumpRenderTree/AccessibilityUIElement.h:
3747         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3748         (AccessibilityUIElement::isChecked):
3749         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3750         (AccessibilityUIElement::isChecked):
3751         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3752         (AccessibilityUIElement::isChecked):
3753
3754 2010-01-05  David Levin  <levin@chromium.org>
3755
3756         Reviewed by Darin Adler.
3757
3758         Having a comment for the #endif for a header guard is not required WebKit style.
3759         https://bugs.webkit.org/show_bug.cgi?id=33214
3760
3761         * Scripts/webkitpy/cpp_style.py: removed the check and made the loop exit
3762           early when it has all the needed information to continue.
3763         * Scripts/webkitpy/cpp_style_unittest.py: removed the corresponding tests.
3764
3765 2010-01-05  Adam Roben  <aroben@apple.com>
3766
3767         Share more code in the WebViewDestruction tests
3768
3769         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3770         WebKitAPITest
3771
3772         Reviewed by Sam Weinig.
3773
3774         * WebKitAPITest/tests/WebViewDestruction.cpp:
3775         (WebKitAPITest::createAndInitializeWebView): Renamed from
3776         createWebView. Now initializes the HostWindow and returns the
3777         WebView's HWND via an out-parameter.
3778         (WebKitAPITest::finishWebViewDestructionTest): Added. Code came from
3779         the CloseWithoutDestroyWindow test.
3780         (WebKitAPITest::CloseWithoutDestroyViewWindow): Renamed from
3781         CloseWithoutDestroyWindow and changed to use the new functions.
3782         (WebKitAPITest::MainFrameAfterClose): Changed to use the new
3783         functions.
3784         (WebKitAPITest::NoCloseOrDestroyViewWindow): Renamed from
3785         NoCloseOrDestroyWindow and changed to use the new functions.
3786
3787 2010-01-05  Adam Roben  <aroben@apple.com>
3788
3789         Don't show HostWindows by default
3790
3791         This was making WebKitAPITest very flashy as windows appeared and
3792         disappeared.
3793
3794         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3795         WebKitAPITest
3796
3797         Reviewed by Sam Weinig.
3798
3799         * WebKitAPITest/HostWindow.cpp:
3800         (WebKitAPITest::HostWindow::initialize): Removed the WS_VISIBLE style
3801         from the window.
3802
3803 2010-01-05  Adam Roben  <aroben@apple.com>
3804
3805         Don't hang in WebKitAPITest if no messages have been posted
3806
3807         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3808         WebKitAPITest
3809
3810         Reviewed by Sam Weinig.
3811
3812         * WebKitAPITest/tests/WebViewDestruction.cpp:
3813         (WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage
3814         to avoid hanging if no messages have been posted.
3815
3816 2010-01-05  Adam Roben  <aroben@apple.com>
3817
3818         Fix WebKitCreateInstance helper
3819
3820         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3821         WebKitAPITest
3822
3823         Reviewed by Sam Weinig.
3824
3825         * WebKitAPITest/tests/WebViewDestruction.cpp:
3826         (WebKitAPITest::WebKitCreateInstance): Pass the pointer straight
3827         through, instead of taking its address.
3828
3829 2010-01-04  Maciej Stachowiak  <mjs@apple.com>
3830
3831         Reviewed by Darin Fisher.
3832
3833         Reorganize, document and rename OS() platform macros.
3834         https://bugs.webkit.org/show_bug.cgi?id=33198
3835
3836         Adapt to name changes.
3837         
3838         * DumpRenderTree/DumpRenderTree.h:
3839         * DumpRenderTree/config.h:
3840
3841 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3842
3843         Reviewed by Eric Seidel.
3844
3845         Minor improvements to test-webkit-scripts, as suggested
3846         by an earlier review.
3847
3848         https://bugs.webkit.org/show_bug.cgi?id=33125
3849
3850         * Scripts/test-webkit-scripts:
3851           - Used OptionParser class instead of getopt.getopt().
3852           - Created main() method for __main__ block.
3853           - Enclosed functions in a class.
3854
3855 2010-01-05  Chris Fleizach  <cfleizach@apple.com>
3856
3857         No review. Fix DRT breakage on Tiger/Leopard.
3858
3859         Add ARIA "Live Region" support
3860         https://bugs.webkit.org/show_bug.cgi?id=33117
3861
3862         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3863
3864 2010-01-04  Chris Fleizach  <cfleizach@apple.com>
3865
3866         Reviewed by Darin Adler.
3867
3868         Add ARIA "Live Region" support
3869         https://bugs.webkit.org/show_bug.cgi?id=33117
3870
3871         * DumpRenderTree/AccessibilityUIElement.cpp:
3872         (indexOfChildCallback):
3873         (boolAttributeValueCallback):
3874         (stringAttributeValueCallback):
3875         (addNotificationListenerCallback):
3876         (AccessibilityUIElement::getJSClass):
3877         * DumpRenderTree/AccessibilityUIElement.h:
3878         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3879         (AccessibilityUIElement::indexOfChild):
3880         (AccessibilityUIElement::stringAttributeValue):
3881         (AccessibilityUIElement::boolAttributeValue):
3882         (AccessibilityUIElement::addNotificationListener):
3883         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3884         (AccessibilityUIElement::indexOfChild):
3885         (AccessibilityUIElement::stringAttributeValue):
3886         (AccessibilityUIElement::boolAttributeValue):
3887         (_accessibilityNotificationCallback):
3888         (AccessibilityUIElement::addNotificationListener):
3889         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3890         (AccessibilityUIElement::indexOfChild):
3891         (AccessibilityUIElement::stringAttributeValue):
3892         (AccessibilityUIElement::boolAttributeValue):
3893         (AccessibilityUIElement::addNotificationListener):
3894
3895 2010-01-04  Eric Seidel  <eric@webkit.org>
3896
3897         Reviewed by Adam Barth.
3898
3899         bugzilla-tool rollout should require a reason
3900         https://bugs.webkit.org/show_bug.cgi?id=30810
3901
3902         * Scripts/webkitpy/changelogs.py: Add support for a reason, add auto-wrapping logic.
3903         * Scripts/webkitpy/changelogs_unittest.py: Test reason support.
3904         * Scripts/webkitpy/commands/download.py: rollout now requires a reason, remove unused BUGID argument
3905         * Scripts/webkitpy/commands/download_unittest.py: pass required reason
3906         * Scripts/webkitpy/steps/preparechangelogforrevert.py: pass reason to update_for_revert
3907
3908 2010-01-04  Jon Honeycutt  <jhoneycutt@apple.com>
3909
3910         MSAA: <select> elements should broadcast value change events
3911
3912         https://bugs.webkit.org/show_bug.cgi?id=33088
3913
3914         <rdar://problem/7332364>
3915
3916         Reviewed by Darin Adler.
3917
3918         * DumpRenderTree/AccessibilityController.cpp:
3919         (logValueChangeEventsCallback):
3920         Start logging value change events.
3921         (AccessibilityController::getJSClass):
3922         Add a "logValueChangeEvents" to the AccessibilityController's JS class
3923         definition.
3924         (AccessibilityController::resetToConsistentState):
3925         Disable logging of value change events.
3926
3927         * DumpRenderTree/AccessibilityController.h:
3928         Declare setLogValueChangeEvents(), and add a member variable for the
3929         value change event hook.
3930
3931         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3932         (AccessibilityController::setLogValueChangeEvents):
3933         Stubbed.
3934
3935         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3936         (AccessibilityController::setLogValueChangeEvents):
3937         Stubbed.
3938
3939         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3940         (AccessibilityController::AccessibilityController):
3941         Initialize new member var.
3942         (AccessibilityController::~AccessibilityController):
3943         Disable logging of value change events.
3944         (logEventProc):
3945         When we receive an EVENT_OBJECT_VALUECHANGE, log the name of the object
3946         and its value.
3947         (AccessibilityController::setLogValueChangeEvents):
3948         If disabling logging, unhook the event, and clear the event hook
3949         member var. Otherwise, query for the root element to enable
3950         accessibility, and hook EVENT_OBJECT_VALUECHANGE.
3951
3952 2010-01-04  Adam Barth  <abarth@webkit.org>
3953
3954         Reviewed by Eric Seidel.
3955
3956         long_help for submit-patch
3957         https://bugs.webkit.org/show_bug.cgi?id=33184
3958
3959         * Scripts/webkitpy/commands/upload.py:
3960
3961 2010-01-04  Adam Barth  <abarth@webkit.org>
3962
3963         Reviewed by Eric Seidel.
3964
3965         commit-queue can wrongly reject patches if the buildbots are behind
3966         https://bugs.webkit.org/show_bug.cgi?id=30098
3967
3968         Check to make sure we can currently build and test before trying to
3969         land a patch.
3970
3971         * Scripts/webkitpy/commands/queues.py:
3972
3973 2010-01-04  Adam Roben  <aroben@apple.com>
3974
3975         Add a test harness for the Windows WebKit API, and a few tests
3976
3977         We currently only have tests for a handful of bugs regarding WebView
3978         destruction, but more tests can easily be added later. Eventually
3979         we'll run these tests as part of run-webkit-tests.
3980
3981         Fixes <http://webkit.org/b/33167>.
3982
3983         Reviewed by Sam Weinig.
3984
3985         * WebKitAPITest/HostWindow.cpp: Added.
3986         (WebKitAPITest::HostWindow::HostWindow): Initialize m_window.
3987         (WebKitAPITest::HostWindow::~HostWindow): Destroy our window if
3988         needed.
3989         (WebKitAPITest::HostWindow::initialize): Create our window.
3990         (WebKitAPITest::HostWindow::clientRect): Return our window's client
3991         rect.
3992         (WebKitAPITest::HostWindow::registerWindowClass): Does what it says.
3993         (WebKitAPITest::HostWindow::wndProc): Just call through to
3994         DefWindowProcW.
3995
3996         * WebKitAPITest/HostWindow.h: Added.
3997         (WebKitAPITest::HostWindow::window): Simple getter.
3998
3999         * WebKitAPITest/Test.h: Added. This file defines some macros useful
4000         for writing tests.
4001
4002         * WebKitAPITest/TestsController.cpp: Added.
4003         (WebKitAPITest::TestsController::TestsController): Initialize our
4004         members.
4005         (WebKitAPITest::TestsController::shared): Return the shared instance.
4006         (WebKitAPITest::TestsController::runAllTests): Run a message pump
4007         until a WM_QUIT message is received, then return whether all tests
4008         succeeded.
4009         (WebKitAPITest::TestsController::addTest): Add the test to m_tests and
4010         start running tests soon.
4011         (WebKitAPITest::TestsController::testFailed): Record the failure and
4012         print a message about it to stdout.
4013         (WebKitAPITest::TestsController::runNextTest): If we don't have any
4014         tests to run, post a WM_QUIT message to stop the message pump.
4015         Otherwise, run the test and print whether it passed, then schedule the
4016         next test.
4017         (WebKitAPITest::TestsController::runNextTestSoon): Set a 0-delay timer
4018         to run the next test.
4019         (WebKitAPITest::TestsController::registerWindowClass): Does what it
4020         says.
4021         (WebKitAPITest::TestsController::wndProc): If the runNextTestTimer
4022         fired, call runNextTest(). Pass everything else through to
4023         DefWindowProcW.
4024
4025         * WebKitAPITest/TestsController.h: Added.
4026
4027         * WebKitAPITest/WebKitAPITest.vcproj: Added.
4028
4029         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added.
4030
4031         * WebKitAPITest/main.cpp: Added.
4032         (main): (Mostly) just calls TestsController::runAllTests.
4033
4034         * WebKitAPITest/tests/WebViewDestruction.cpp: Added.
4035         (WebKitAPITest::WebKitCreateInstance): Helper function template to
4036         call through to the real WebKitCreateInstance.
4037         (WebKitAPITest::webViewCount): Helper function to call through to
4038         IWebKitStatistics::webViewCount.
4039         (WebKitAPITest::createWebView): Helper function to create a WebView
4040         and put it inside a HostWindow.
4041         (WebKitAPITest::runMessagePump): Helper function to run a message pump
4042         for a specified number of milliseconds, or until a WM_QUIT message is
4043         received.
4044         (WebKitAPITest::CloseWithoutDestroyWindow): Test for
4045         <http://webkit.org/b/32827>.
4046         (WebKitAPITest::MainFrameAfterClose): Test for
4047         <http://webkit.org/b/32868>.
4048         (WebKitAPITest::NoCloseOrDestroyWindow): Test for
4049         <http://webkit.org/b/33162>.
4050
4051 2010-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4052
4053         Reviewed by David Kilzer.
4054
4055         Add support for Git's "diff.mnemonicprefix" config option to WebKitTools
4056
4057         https://bugs.webkit.org/show_bug.cgi?id=32820
4058
4059         * Scripts/VCSUtils.pm:
4060         * Scripts/svn-apply:
4061         * Scripts/svn-unapply:
4062         * Scripts/test-webkitperl: Run gitdiff2svndiff test
4063         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Added.
4064         * Scripts/webkitpy/diff_parser.py:
4065         * Scripts/webkitpy/diff_parser_unittest.py:
4066
4067 2010-01-04  Chris Jerdonek  <chris.jerdonek@gmail.com>
4068
4069         Reviewed by David Kilzer.
4070
4071         Divided the Perl unit tests into separate files and put
4072         them in a separate directory, and renamed test-webkit-perl
4073         to test-webkitperl.
4074
4075         https://bugs.webkit.org/show_bug.cgi?id=33124
4076
4077         * Scripts/VCSUtils.pm:
4078           - Renamed generateRunPatchCommand() to generatePatchCommand().
4079
4080         * Scripts/VCSUtils_unittest.pl: Removed.
4081           - Divided into three files in Scripts/webkitperl/VCSUtils_unittest.
4082
4083         * Scripts/test-webkit-perl: Removed.
4084           - Renamed to test-webkitperl.
4085
4086         * Scripts/test-webkit-scripts:
4087           - Updated paths to test-webkitpy and test-webkitperl.
4088
4089         * Scripts/test-webkitperl: Copied from Scripts/test-webkit-perl.
4090           - Added paths to new test files.
4091
4092         * Scripts/webkitperl: Added.
4093         * Scripts/webkitperl/VCSUtils_unittest: Added.
4094         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added.
4095         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl: Added.
4096         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Copied from Scripts/VCSUtils_unittest.pl.
4097
4098 2010-01-04  Eric Seidel  <eric@webkit.org>
4099
4100         Reviewed by Adam Barth.
4101
4102         Make bugzilla-tool rollout include a bug link in the ChangeLog entry
4103         https://bugs.webkit.org/show_bug.cgi?id=33146
4104
4105         One more step towards better rollouts.
4106
4107         * Scripts/webkitpy/changelogs.py:
4108         * Scripts/webkitpy/changelogs_unittest.py:
4109         * Scripts/webkitpy/steps/preparechangelogforrevert.py:
4110
4111 2010-01-04  Adam Barth  <abarth@webkit.org>
4112
4113         Reviewed by Eric Seidel.
4114
4115         Sort the step options
4116         https://bugs.webkit.org/show_bug.cgi?id=33144
4117
4118         * Scripts/webkitpy/steps/options.py:
4119
4120 2010-01-04  Eric Seidel  <eric@webkit.org>
4121
4122         Reviewed by Adam Barth.
4123
4124         Need support for longer text in per-command help
4125         https://bugs.webkit.org/show_bug.cgi?id=33143
4126
4127         Add some minimal additional help to land-diff and
4128         pave the way for adding better help to all commands.
4129
4130         * Scripts/webkitpy/commands/download.py: Add small amount of additional help to land-diff
4131         * Scripts/webkitpy/multicommandtool.py: support long_help
4132         * Scripts/webkitpy/multicommandtool_unittest.py: test long_help
4133
4134 2010-01-04  Adam Barth  <abarth@webkit.org>
4135
4136         Reviewed by Eric Seidel.
4137
4138         Add unit test for MarkBugFixed
4139         https://bugs.webkit.org/show_bug.cgi?id=33142
4140
4141         MarkBugFixed is way behind in command technology, but it still needs a
4142         unit test, as the FIXME commands.
4143
4144         Also, remove mark-bug-fixed and create-bug from main help since we have
4145         more modern commands to replace them.
4146
4147         * Scripts/webkitpy/commands/upload.py:
4148         * Scripts/webkitpy/commands/upload_unittest.py:
4149         * Scripts/webkitpy/mock_bugzillatool.py:
4150
4151 2010-01-04  Adam Barth  <abarth@webkit.org>
4152
4153         Reviewed by Eric Seidel.
4154
4155         Add missing unit test for CommitMessageForCurrentDiff
4156         https://bugs.webkit.org/show_bug.cgi?id=33141
4157
4158         * Scripts/webkitpy/commands/upload.py:
4159         * Scripts/webkitpy/commands/upload_unittest.py:
4160
4161 2010-01-04  Adam Barth  <abarth@webkit.org>
4162
4163         Reviewed by Eric Seidel.
4164
4165         Remove raw_input from queues in favor of user.prompt
4166         https://bugs.webkit.org/show_bug.cgi?id=33140
4167
4168         This lets up properly mock out the user interaction instead of hacking
4169         around it with the options.
4170
4171         * Scripts/webkitpy/commands/queues.py:
4172         * Scripts/webkitpy/commands/queuestest.py:
4173
4174 2010-01-04  Eric Seidel  <eric@webkit.org>
4175
4176         Reviewed by Adam Barth.
4177
4178         bugzilla-tool should not require users to install mechanize
4179         https://bugs.webkit.org/show_bug.cgi?id=32635
4180
4181         * Scripts/webkitpy/__init__.py: Add missing declaration for ClientForm (which mechanize requires).
4182
4183 2010-01-04  Eric Seidel  <eric@webkit.org>
4184
4185         Reviewed by Adam Barth.
4186
4187         bugzilla-tool should not require users to install mechanize
4188         https://bugs.webkit.org/show_bug.cgi?id=32635
4189
4190         Use the nifty "autoinstall" module from Daniel Krech:
4191         http://pypi.python.org/pypi/autoinstall/0.2
4192         http://code.google.com/p/pyautoinstall/
4193         It's available under a WebKit-compatible BSD license.
4194
4195         * Scripts/webkitpy/__init__.py:
4196          - bind "mechanize" to an autoinstall importer which will
4197            auto-download mechanize if necessary.
4198         * Scripts/webkitpy/autoinstall.py: Added.
4199         * Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize
4200         * Scripts/webkitpy/statusbot.py: ditto.
4201         * Scripts/webkitpy/webkit_mechanize.py: Removed.
4202
4203 2010-01-04  Adam Barth  <abarth@webkit.org>
4204
4205         Reviewed by Eric Seidel.
4206
4207         [bzt] Move AbstractSequencedCommand to a more general location
4208         https://bugs.webkit.org/show_bug.cgi?id=33137
4209
4210         I do what the FIXME tell me to do.
4211
4212         * Scripts/webkitpy/commands/abstractsequencedcommand.py: Added.
4213         * Scripts/webkitpy/commands/download.py:
4214         * Scripts/webkitpy/commands/upload.py:
4215
4216 2010-01-04  Adam Barth  <abarth@webkit.org>
4217
4218         Reviewed by Eric Seidel.
4219
4220         Rename StatusBot to StatusServer
4221         https://bugs.webkit.org/show_bug.cgi?id=33139
4222
4223         It's not a bot.  It's a server.
4224
4225         * Scripts/bugzilla-tool:
4226         * Scripts/webkitpy/bugzilla.py:
4227         * Scripts/webkitpy/commands/early_warning_system.py:
4228         * Scripts/webkitpy/commands/queues.py:
4229         * Scripts/webkitpy/mock_bugzillatool.py:
4230         * Scripts/webkitpy/queueengine.py:
4231         * Scripts/webkitpy/statusbot.py: Removed.
4232
4233 2010-01-04  Adam Barth  <abarth@webkit.org>
4234
4235         Reviewed by Eric Seidel.
4236
4237         [bzt] submit-pach should have a -o/--open option to open the bug after submit
4238         https://bugs.webkit.org/show_bug.cgi?id=33136
4239
4240         Python makes this very easy.
4241
4242         * Scripts/webkitpy/mock_bugzillatool.py:
4243         * Scripts/webkitpy/steps/options.py:
4244         * Scripts/webkitpy/steps/postdiff.py:
4245         * Scripts/webkitpy/user.py:
4246
4247 2010-01-04  Adam Barth  <abarth@webkit.org>
4248
4249         Reviewed by Eric Seidel.
4250
4251         [bzt] Move steps to a submodule
4252         https://bugs.webkit.org/show_bug.cgi?id=33135
4253
4254         For great victory.  This will probably introduce some regressions
4255         because our test coverage isn't perfect, but I've tried to be careful.
4256
4257         * Scripts/test-webkitpy:
4258         * Scripts/webkitpy/buildsteps.py: Removed.
4259         * Scripts/w