2010-04-28 Eric Seidel <eric@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-04-28  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by David Levin.
4
5         Document that subprocess.poll/wait are not threadsafe
6         https://bugs.webkit.org/show_bug.cgi?id=38289
7
8         * Scripts/webkitpy/common/system/executive.py:
9         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
10         * Scripts/webkitpy/layout_tests/port/chromium.py:
11         * Scripts/webkitpy/layout_tests/port/http_server.py:
12         * Scripts/webkitpy/layout_tests/port/server_process.py:
13         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
14
15 2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>
16
17         Reviewed by Daniel Bates.
18
19         Removed the dividing line (i.e. "====...") logic from the code
20         called by svn-apply and svn-unapply.
21
22         https://bugs.webkit.org/show_bug.cgi?id=38093
23
24         The dividing line logic is unnecessary.  Removing it simplifies the
25         code and makes some subsequent changes easier.
26
27         * Scripts/VCSUtils.pm:
28           - Removed the logic in gitdiff2svndiff() to convert the git
29             "index" line to an SVN dividing line.
30           - Adjusted the logic similarly in parseDiffHeader().
31
32         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
33           - Updated the unit tests as necessary.
34
35         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
36           - Updated the unit tests as necessary.
37           - Corrected an error in the unit tests whereby all elements
38             of an array were referencing the same element rather than
39             distinct elements -- causing unit test failures to be masked.
40
41         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
42           - Updated the unit tests as necessary.
43           - Made the same unit test correction as above for parseDiff.pl.
44
45 2010-04-28  Evan Stade  <estade@chromium.org>
46
47         Unreviewed.
48
49         * Scripts/webkitpy/common/config/committers.py: adding myself as a committer
50
51 2010-04-28  Sam Weinig  <sam@webkit.org>
52
53         Reviewed by Mark Rowe.
54
55         Add MiniBrowser to the lists of modules to build and only build it on
56         SnowLeopard and later.
57
58         * Makefile:
59         * MiniBrowser/Makefile:
60
61 2010-04-28  Sam Weinig  <sam@webkit.org>
62
63         Reviewed by Mark Rowe.
64
65         Make running MiniBrowser.app without explicitly setting DYLD_FRAMEWORK_PATH.
66
67         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
68         * MiniBrowser/mac/make-launchable.sh: Added.
69
70 2010-04-28  Eric Seidel  <eric@webkit.org>
71
72         Reviewed by David Levin.
73
74         Audit all uses of subprocess in webkitpy
75         https://bugs.webkit.org/show_bug.cgi?id=38284
76
77         After further discussions with Jeffrey Yasskin
78         about http://bugs.python.org/issue2320
79         and related issues of using subprocess from
80         multiple threads, I have learned that subprocess
81         is known to be non-threadsafe through recent
82         Python 2.7 builds.
83
84         I'm attempting to lessen our exposure to these
85         subprocess bugs by auditing each use of subprocess
86         in webkitpy.  I did not find any unsafe calls
87         in my audit, but I did remove numerous unneeded
88         import subprocess lines.
89
90         * Scripts/webkitpy/common/checkout/api.py:
91         * Scripts/webkitpy/common/net/bugzilla.py:
92         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
93         * Scripts/webkitpy/common/system/user.py:
94         * Scripts/webkitpy/layout_tests/port/base.py:
95         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
96         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
97         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Added.
98         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
99         * Scripts/webkitpy/layout_tests/port/gtk.py:
100         * Scripts/webkitpy/layout_tests/port/mac.py:
101         * Scripts/webkitpy/layout_tests/port/qt.py:
102         * Scripts/webkitpy/layout_tests/port/webkit.py:
103         * Scripts/webkitpy/layout_tests/port/win.py:
104
105 2010-04-28  Darin Adler  <darin@apple.com>
106
107         Ignore a directory the Python tools creates.
108
109         * Scripts/webkitpy/style: Modified property svn:ignore.
110
111 2010-04-28  Darin Adler  <darin@apple.com>
112
113         * Scripts/extract-localizable-strings: Fix minor mistake in
114         argument checking.
115
116 2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>
117
118         Reviewed by Kenneth Rohde Christiansen.
119
120         [Qt] QWebPage viewMode property
121         https://bugs.webkit.org/show_bug.cgi?id=38119
122
123         Replacing method qt_wrt_setViewMode by wrt_viewMode property.
124
125         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
126         (LayoutTestController::setViewModeMediaFeature):
127
128 2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>
129
130         Reviewed by Shinichiro Hamaji.
131
132         Adjusted check-webkit-style so that files with file type NONE
133         are automatically skipped without warning.
134
135         https://bugs.webkit.org/show_bug.cgi?id=38197
136
137         This change simplifies configuring which files to skip.  It also
138         addresses an issue whereby check-webkit-style was unintentionally
139         checking .vcproj files for carriage returns.
140
141         * Scripts/webkitpy/style/checker.py:
142           - Moved the C++, Python, and text file extensions to new
143             module-level configuration variables.
144           - Removed .pyc from the _SKIPPED_FILES_WITHOUT_WARNING configuration
145             variable.
146           - Changed the numeric values of the FileType enum so that
147             FileType.NONE evaluates to False.
148           - For ProcessorDispatcher.should_skip_without_warning():
149             - Changed the method to return True for FileType.NONE files.
150             - Made ChangeLog files an exception to getting skipped.
151           - Changed the StyleProcessor.process() method to raise an
152             exception if given a file path that should not be processed.
153
154         * Scripts/webkitpy/style/checker_unittest.py:
155           - Updated the unit tests and added more test cases as necessary.
156
157 2010-04-28  Eric Seidel  <eric@webkit.org>
158
159         Reviewed by Jeremy Orlow.
160
161         webkitpy: ScriptError('Failed to run "[u\'taskkill.exe\', u\'/f\', u\'/im\', u\'httpd.exe\']" exit_code: 128',)
162         https://bugs.webkit.org/show_bug.cgi?id=38248
163
164         The previous code did not check the return code of taskkill.
165         When I moved that callsite from using subprocess.call to
166         Executive.run_command having a non-zero return code became an error.
167
168         In this change I've centralized our killall handling in executive,
169         and added tests for it to make sure it works.
170
171         Currently kill_process and kill_all swallow exceptions in the cases
172         where the process(es) to be killed do(es) not exist.
173
174         * Scripts/webkitpy/common/system/executive.py:
175         * Scripts/webkitpy/common/system/executive_unittest.py:
176         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
177         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
178         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
179         * Scripts/webkitpy/layout_tests/port/gtk.py:
180         * Scripts/webkitpy/layout_tests/port/mac.py:
181         * Scripts/webkitpy/layout_tests/port/qt.py:
182         * Scripts/webkitpy/layout_tests/port/win.py:
183
184 2010-04-28  Eric Seidel  <eric@webkit.org>
185
186         Reviewed by Shinichiro Hamaji.
187
188         wdiff_text throws ScriptError because wdiff returns non-zero when files differ
189         https://bugs.webkit.org/show_bug.cgi?id=38246
190
191         wdiff returns 0 when files are the same, 1 when they differ.
192         run_command by default raises ScriptError if the return code is non-zero.
193         Fixed this by adding a custom error handler which only raises if the
194         return code is not 1.
195
196         I broke up the huge wdiff_text() method into little pieces
197         for easier unit testing.  There is only one functional change here
198         and that is the addition of the custom error handler.
199
200         * Scripts/webkitpy/layout_tests/port/base.py:
201         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
202
203 2010-04-28  Fumitoshi Ukai  <ukai@chromium.org>
204
205         Unreviewed build fix.
206
207         * DumpRenderTree/chromium/TestShell.cpp:
208         (TestShell::dumpImage): format '%u' expects type 'unsigned int', but argument 2 has type 'size_t'.
209         * DumpRenderTree/chromium/WebViewHost.cpp:
210         (WebViewHost::willSendRequest): too few arguments for format.
211
212 2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>
213
214         Reviewed by Darin Adler and Eric Seidel.
215
216         Add layoutTestController.setPrinting()
217         https://bugs.webkit.org/show_bug.cgi?id=37203
218
219         * DumpRenderTree/LayoutTestController.cpp:
220         (LayoutTestController::LayoutTestController):
221         (setPrintingCallback):
222         (LayoutTestController::staticFunctions):
223         * DumpRenderTree/LayoutTestController.h:
224         (LayoutTestController::isPrinting):
225         (LayoutTestController::setIsPrinting):
226         * DumpRenderTree/mac/DumpRenderTree.mm:
227         (dump):
228
229 2010-04-27  Michael Nordman  <michaeln@google.com>
230
231         Reviewed by Dmitry Titov.
232
233         [Chromium] Add two things to the webkit API to support appcaches in workers.
234         1) WebURLRequest TargetTypes for worker and shared worker main resources.
235         2) Factory method on class WebCommonWorkerClient to
236            createApplicationCacheHost() for the associated worker.
237
238         https://bugs.webkit.org/show_bug.cgi?id=38147
239
240         * DumpRenderTree/chromium/TestWebWorker.h add a stub impl of the factory method 
241         (TestWebWorker::createApplicationCacheHost):
242
243 2010-04-27  Adam Barth  <abarth@webkit.org>
244
245         Reviewed by Eric Seidel.
246
247         run-bindings-tests doesn't work in an SVN checkout
248         https://bugs.webkit.org/show_bug.cgi?id=38225
249
250         Previously detect_scm_system needed an absolute path for SVN.  Now we
251         accept a relative path.
252
253         * Scripts/webkitpy/common/checkout/scm.py:
254         * Scripts/webkitpy/common/checkout/scm_unittest.py:
255
256 2010-04-27  Sam Weinig  <sam@webkit.org>
257
258         Reviewed by Stephanie Lewis.
259
260         Always build WebKit2 when building on SnowLeopard and later. 
261
262         * Scripts/build-webkit:
263
264 2010-04-27  Sam Weinig  <sam@webkit.org>
265
266         Reviewed by Maciej Stachowiak.
267
268         Fix for https://bugs.webkit.org/show_bug.cgi?id=38238
269         Allow both WebKit and WebKit2 to link to the same WebCore.framework
270
271         * Scripts/build-webkit: Remove the UMBRELLA_LDFLAGS override when building
272         WebCore for WebKit2, it is no longer necessary.
273
274 2010-04-27  James Robinson  <jamesr@chromium.org>
275
276         Reviewed by David Levin.
277
278         Fix a typo in chromium.py that causes NRWT to fail in --verbose
279         mode in a Chromium checkout.
280         https://bugs.webkit.org/show_bug.cgi?id=38234
281
282         * Scripts/webkitpy/layout_tests/port/chromium.py:
283
284 2010-04-27  Darin Fisher  <darin@chromium.org>
285
286         Reviewed by Dimitri Glazkov.
287
288         [Chromium] Remove deprecated form of didChangeLocationWithinPage
289         https://bugs.webkit.org/show_bug.cgi?id=38178
290
291         Switch over to implementing didNavigateWithinPage.
292
293         * DumpRenderTree/chromium/WebViewHost.cpp:
294         (TestWebViewDelegate::didNavigateWithinPage):
295         (WebViewHost::didChangeLocationWithinPage):
296         * DumpRenderTree/chromium/WebViewHost.h:
297
298 2010-04-27  Evan Martin  <evan@chromium.org>
299
300         Unreviewed.
301
302         Adding myself to commmitters list.
303
304         * Scripts/webkitpy/common/config/committers.py:
305
306 2010-04-27  Adam Barth  <abarth@webkit.org>
307
308         Reviewed by Darin Adler.
309
310         run-bindings-tests should use --reset-results instead of --overwrite
311         https://bugs.webkit.org/show_bug.cgi?id=38200
312
313         As requested by Ojan.
314
315         * Scripts/run-bindings-tests:
316
317 2010-04-27  Adam Barth  <abarth@webkit.org>
318
319         Reviewed by Eric Seidel.
320
321         REGRESSION(r58261): webkit-patch edit-changelogs is broken
322         https://bugs.webkit.org/show_bug.cgi?id=38204
323
324         In 58261, we added code to abstract step that interrogates the squash
325         and git_commit options, but it doesn't declare that it uses those
326         options.  That means any command that doesn't happen to declare those
327         options might be broken if it uses the cached_lookup mechanism.
328
329         * Scripts/webkitpy/tool/steps/abstractstep.py:
330         * Scripts/webkitpy/tool/steps/applypatch.py:
331         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
332         * Scripts/webkitpy/tool/steps/build.py:
333         * Scripts/webkitpy/tool/steps/checkstyle.py:
334         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
335         * Scripts/webkitpy/tool/steps/closebug.py:
336         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
337         * Scripts/webkitpy/tool/steps/commit.py:
338         * Scripts/webkitpy/tool/steps/confirmdiff.py:
339         * Scripts/webkitpy/tool/steps/createbug.py:
340         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
341         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
342         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
343         * Scripts/webkitpy/tool/steps/postcodereview.py:
344         * Scripts/webkitpy/tool/steps/postdiff.py:
345         * Scripts/webkitpy/tool/steps/preparechangelog.py:
346         * Scripts/webkitpy/tool/steps/runtests.py:
347         * Scripts/webkitpy/tool/steps/update.py:
348         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
349         * Scripts/webkitpy/tool/steps/validatereviewer.py:
350
351 2010-04-27  Eric Seidel  <eric@webkit.org>
352
353         Reviewed by David Levin.
354
355         prepare-ChangeLog --bug fails on some CYGWIN installs due to missing certs
356         https://bugs.webkit.org/show_bug.cgi?id=38212
357
358         * Scripts/prepare-ChangeLog:
359          - Pass --insecure to curl to work around CYGWIN missing certs.
360
361 2010-04-27  Sam Weinig  <sam@webkit.org>
362
363         Rubber-stamped by Beth Dakin.
364
365         It is no longer necessary to set ENABLE_EXPERIMENTAL_SINGLE_VIEW_MODE
366         or WTF_USE_WEB_THREAD. Remove them.
367
368         * Scripts/build-webkit:
369
370 2010-04-27  Chris Jerdonek  <cjerdonek@webkit.org>
371
372         Reviewed by David Levin.
373
374         Changed Chris Jerdonek from committer to reviewer.
375
376         * Scripts/webkitpy/common/config/committers.py:
377
378 2010-04-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
379
380         Reviewed by Kenneth Rohde Christiansen.
381
382         [Qt] QGraphicsWebView: Arrow keys scroll the graphics-view instead of the web-page
383         https://bugs.webkit.org/show_bug.cgi?id=35834
384
385         The scene should always have the size of the web view otherwhise it is
386         possible to scroll the graphics view.
387
388         * QtLauncher/webview.cpp:
389         (WebViewGraphicsBased::resizeEvent):
390
391 2010-04-27  Diego Gonzalez  <diegohcg@webkit.org>
392
393         Unreviewed.
394
395         Adding myself to committers.py
396
397         * Scripts/webkitpy/common/config/committers.py:
398
399 2010-04-27  Eric Seidel  <eric@webkit.org>
400
401         Reviewed by Adam Barth.
402
403         [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
404         https://bugs.webkit.org/show_bug.cgi?id=37987
405
406         After further research, I believe the hang is caused by:
407         http://bugs.python.org/issue2320
408         Basically Popen() is not reentrant.
409         The workaround is to pass close_fds=True to Popen() on Mac/Linux.
410
411         I fixed our main Popen wrapper "Executive.run_command" to use close_fds=True
412         when appropriate.
413
414         I audited all places we call Popen() and either moved them to run_command
415         or left a FIXME that they are not thread safe.  A few places I added the
416         close_fds workaround there and left an explanitory note.
417
418         * Scripts/webkitpy/common/checkout/scm_unittest.py:
419          - Added note that this Popen use is not threadsafe.
420         * Scripts/webkitpy/common/system/executive.py:
421          - Fixed our Executive.run_* to workaround python bug 2320.
422         * Scripts/webkitpy/common/system/user.py:
423          _ Added note that this Popen use is not threadsafe.
424         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: ditto.
425         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: ditto.
426         * Scripts/webkitpy/layout_tests/port/base.py:
427          - Change wdiff back to using run_command now that we believe it
428            to be threadsafe.
429         * Scripts/webkitpy/layout_tests/port/chromium.py:
430          - Fix to use Executive in places.
431          - Pass self._executive down to the Driver for easier unit testing.
432         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
433          - Re-factor to use a _kill_all method.
434          - Made the _kill_all method use run_command to be threadsafe.
435         * Scripts/webkitpy/layout_tests/port/http_server.py:
436          - Add FIXME about using Executive.
437         * Scripts/webkitpy/layout_tests/port/server_process.py:
438          - Use Executive to be threadsafe.
439         * Scripts/webkitpy/layout_tests/port/webkit.py:
440          - Pass self._executive down to the Driver.
441         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
442          - Add note about Popen not being threadsafe.
443         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
444          - Move one caller to run_command add notes about moving others.
445
446 2010-04-27  Adam Barth  <abarth@webkit.org>
447
448         Reviewed by Maciej Stachowiak.
449
450         REGRESSION(r58261): webkit-patch upload does not work in an SVN checkout.
451         https://bugs.webkit.org/show_bug.cgi?id=38186
452
453         Unfortunately, we don't have a good way of testing this change because
454         our test coverage of the scm.py API is poor...
455
456         * Scripts/webkitpy/common/checkout/scm.py:
457         * Scripts/webkitpy/tool/steps/preparechangelog.py:
458
459 2010-04-26  Eric Seidel  <eric@webkit.org>
460
461         Reviewed by Adam Barth.
462
463         Remove unused code from text_diff.py
464         https://bugs.webkit.org/show_bug.cgi?id=38170
465
466         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
467          - Remove is_render_tree_dump which appears unused.
468
469 2010-04-26  Adam Barth  <abarth@webkit.org>
470
471         Reviewed by Eric Seidel.
472
473         webkit-patch pretty-diff is broken
474         https://bugs.webkit.org/show_bug.cgi?id=38172
475
476         We need to register for these options because they're used when we look
477         up the diff.
478
479         * Scripts/webkitpy/tool/steps/confirmdiff.py:
480
481 2010-04-26  Adam Barth  <abarth@webkit.org>
482
483         Reviewed by Eric Seidel.
484
485         Add ObjC and GObject to run-bindings-test
486         https://bugs.webkit.org/show_bug.cgi?id=38168
487
488         * Scripts/run-bindings-tests:
489
490 2010-04-26  Adam Barth  <abarth@webkit.org>
491
492         Reviewed by Eric Seidel.
493
494         Add testing infrastructure for JSC bindings generator
495         https://bugs.webkit.org/show_bug.cgi?id=38167
496
497         Add support for testing more than one bindings.  Also, converted the
498         script to PEP8 style.
499
500         * Scripts/run-bindings-tests:
501
502 2010-04-26  Eric Seidel  <eric@webkit.org>
503
504         Reviewed by Adam Barth.
505
506         Refactor results.html generation out into a new method and test it
507         https://bugs.webkit.org/show_bug.cgi?id=38164
508
509         Hopefully this results in no change in functionality.
510
511         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
512         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
513
514 2010-04-26  Adam Barth  <abarth@webkit.org>
515
516         Unreviewed, rolling out r58265.
517         http://trac.webkit.org/changeset/58265
518         https://bugs.webkit.org/show_bug.cgi?id=38021
519
520         This change prevents me from uploading patches.  It also breaks sheriff-bot.
521
522         * Scripts/webkitpy/tool/steps/options.py:
523
524 2010-04-26  Eric Seidel  <eric@webkit.org>
525
526         Reviewed by Adam Barth.
527
528         [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
529         https://bugs.webkit.org/show_bug.cgi?id=37987
530
531         Rolled out:
532         http://trac.webkit.org/changeset/58062
533         http://trac.webkit.org/changeset/58060
534         http://trac.webkit.org/changeset/58059
535         http://trac.webkit.org/changeset/58055
536         http://trac.webkit.org/changeset/58054
537         and parts of:
538         http://trac.webkit.org/changeset/58050
539
540         I also wrote some new comments and a tiny amount of new
541         code to help make ChromiumDriver.run_test easier to read.
542
543         In order to unit-test my new code, I had to change ChromiumDriver
544         to not automatically start itself when created.  That ended up
545         being a lot of plumbing, but is hopefully easier to understand now.
546
547         There are no tests for the (restored) wdiff code.  wdiff does not
548         exist on all systems, so for now we will assume it worked since
549         it is just old code being reverted.
550
551          * Scripts/webkitpy/layout_tests/driver_test.py:
552           - Use create_driver instead of start_driver, and be sure to call .stop()
553          * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
554           - Use create_driver instead of start_driver
555          * Scripts/webkitpy/layout_tests/port/base.py:
556           - Added a comment to explain that diffs are binary files.
557           - Various patch reverts relating to wdiff
558           - Add Driver._command_wrapper to share code between WebKitDriver and ChromiumDriver.
559           - Made _command_wrapper use shlex.split to get rid of the FIXME.
560          * Scripts/webkitpy/layout_tests/port/base_unittest.py: Added.
561           - test the new _command_wrapper
562          * Scripts/webkitpy/layout_tests/port/chromium.py:
563          - Use _command_wrapper to get rid of a bunch of ugly code.
564          - Make __init__ stop auto-starting.
565          - Rename create_driver to start_driver.
566          - Added _write_command_and_read_line to make it possible to
567            put a FIXME next to read_line() w/o having to put it in two places.
568          - Moved test_shell command building into _test_shell_command and tested it.
569          - Fix comments to say test_shell since ChromiumDriver is test_shell only.
570          * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Added.
571           - Test the new test_shell_command method.
572          * Scripts/webkitpy/layout_tests/port/dryrun.py:
573           - Rename create_driver to start_driver.
574          * Scripts/webkitpy/layout_tests/port/test.py:
575           - Rename create_driver to start_driver.
576          * Scripts/webkitpy/layout_tests/port/webkit.py:
577           - Rename create_driver to start_driver.
578           - Treat output as binary arrays.
579          * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
580           - Treat diff files as binary.
581          * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
582           - Treat diff files as binary.
583
584 2010-04-26  Adam Barth  <abarth@webkit.org>
585
586         Reviewed by Eric Seidel.
587
588         Move bindings test directory into the scripts directory
589         https://bugs.webkit.org/show_bug.cgi?id=38161
590
591         Change script to point to the new location of these data files.
592
593         * Scripts/run-bindings-tests:
594
595 2010-04-26  Adam Barth  <abarth@webkit.org>
596
597         Unreviewed.  Mark run-bindings-tests executable so we can execute it.
598
599         * Scripts/run-bindings-tests:
600
601 2010-04-26  Tony Chang  <tony@chromium.org>
602
603         Reviewed by David Levin.
604
605         [chromium] build-webkit --chromium should build release by default
606         https://bugs.webkit.org/show_bug.cgi?id=38028
607
608         * Scripts/build-dumprendertree: Also should build release by default
609         * Scripts/build-webkit: Make sure to pass command line args through
610         * Scripts/webkitdirs.pm: Build the right configuration
611
612 2010-04-26  Ojan Vafai  <ojan@chromium.org>
613
614         Reviewed by Eric Seidel.
615
616         complete rietveld bugzilla integration
617         https://bugs.webkit.org/show_bug.cgi?id=38021
618
619         Makes --fancy-review the default. All this means is that the patch will
620         be uploaded to rietveld in addition to bugs.webkit.org. 
621
622         * Scripts/webkitpy/tool/steps/options.py:
623
624 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
625
626         Reviewed by Shinichiro Hamaji.
627
628         For check-webkit-style, renamed the style/processors/ directory
629         to style/checkers/.
630
631         https://bugs.webkit.org/show_bug.cgi?id=38122
632
633         * Scripts/webkitpy/style/checker.py:
634           - Updated import statements.
635
636         * Scripts/webkitpy/style/checker_unittest.py:
637           - Updated import statements.
638
639         * Scripts/webkitpy/style/checkers: Copied from WebKitTools/Scripts/webkitpy/style/processors.
640         * Scripts/webkitpy/style/processors: Removed.
641         * Scripts/webkitpy/style/processors/__init__.py: Removed.
642         * Scripts/webkitpy/style/processors/common.py: Removed.
643         * Scripts/webkitpy/style/processors/common_unittest.py: Removed.
644         * Scripts/webkitpy/style/processors/cpp.py: Removed.
645         * Scripts/webkitpy/style/processors/cpp_unittest.py: Removed.
646         * Scripts/webkitpy/style/processors/python.py: Removed.
647         * Scripts/webkitpy/style/processors/python_unittest.py: Removed.
648         * Scripts/webkitpy/style/processors/python_unittest_input.py: Removed.
649         * Scripts/webkitpy/style/processors/text.py: Removed.
650         * Scripts/webkitpy/style/processors/text_unittest.py: Removed.
651
652 2010-04-06  Ojan Vafai  <ojan@chromium.org>
653
654         Reviewed by Adam Barth.
655
656         Include git commits in the diff for webkit-patch upload/land.
657         https://bugs.webkit.org/show_bug.cgi?id=36394
658
659         Adds --squash, --no-squash and --git-commit.
660
661         --git-commit will use a specific local commit for land/upload.
662         If a commit-range is specified, then that range is treated as
663         a single squashed commit.
664
665         --squash will squash all local changes including working copy changes
666         into a single patch.
667
668         --no-squash is the legacy behavior (upload only considers the working copy,
669         land commits the working copy and then each local commit separately to SVN)
670
671         If neither is specified, then an informative error is raised if there is
672         more than one local commit or when there are local commit(s) and working
673         copy changes.
674
675         If the webkit-patch.squash git config parameter is set, then
676         that will be respected instead of raising an error.
677
678         * Scripts/check-webkit-style:
679         * Scripts/webkitpy/common/checkout/api.py:
680         * Scripts/webkitpy/common/checkout/api_unittest.py:
681         * Scripts/webkitpy/common/checkout/scm.py:
682         * Scripts/webkitpy/common/checkout/scm_unittest.py:
683         * Scripts/webkitpy/style/optparser.py:
684         --git-since is removed and --git-commit no longer implies commit_id..
685         Instead, it treats that individual commit, but also supports commit ranges
686         (e.g. commit_id..) as arguments.
687         * Scripts/webkitpy/style/optparser_unittest.py:
688         * Scripts/webkitpy/style_references.py:
689         * Scripts/webkitpy/tool/commands/download.py:
690         * Scripts/webkitpy/tool/commands/upload.py:
691         * Scripts/webkitpy/tool/main.py:
692         * Scripts/webkitpy/tool/mocktool.py:
693         * Scripts/webkitpy/tool/steps/abstractstep.py:
694         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
695         * Scripts/webkitpy/tool/steps/checkstyle.py:
696         * Scripts/webkitpy/tool/steps/commit.py:
697         * Scripts/webkitpy/tool/steps/options.py:
698         * Scripts/webkitpy/tool/steps/postdiff.py:
699         * Scripts/webkitpy/tool/steps/preparechangelog.py:
700         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
701         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
702         * Scripts/webkitpy/tool/steps/validatereviewer.py:
703
704 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
705
706         Reviewed by Shinichiro Hamaji.
707
708         Deleted the StyleChecker-related classes that are no longer
709         being used.
710
711         https://bugs.webkit.org/show_bug.cgi?id=38118
712
713         * Scripts/webkitpy/style/checker.py:
714           - Deleted the DeprecatedStyleChecker class.
715
716         * Scripts/webkitpy/style/checker_unittest.py:
717           - Deleted the StyleCheckerTest, StyleCheckerCheckFileBase,
718             StyleCheckerCheckFileTest, and StyleCheckerCheckPathsTest classes.
719
720 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
721
722         Reviewed by Shinichiro Hamaji.
723
724         Changed the StyleChecker class to use the new TextFileReader class.
725
726         https://bugs.webkit.org/show_bug.cgi?id=37066
727
728         This revision separates the code responsible for reading and iterating
729         over text files from the rest of check-webkit-style.
730
731         * Scripts/check-webkit-style:
732           - Changed the script to use the new StyleProcessor and
733             TextFileReader classes instead of the StyleChecker class.
734
735         * Scripts/webkitpy/style/checker.py:
736           - Added a FIXME to rename many of uses of the word "processor" to
737             "checker".  We did this to clarify the difference between
738             ProcessorBase instances passed to the TextFileReader and
739             classes that process and check lines for style.
740           - Added a FIXME to remove FileType.NONE as a possible return value
741             of ProcessorDispatcher._file_type().  This will better consolidate
742             the logic of which files should be skipped.
743           - Added a FIXME to delete the StyleChecker class.
744           - Added the StyleProcessor class which implements ProcessorBase.
745             This class is responsible for processing lines to check style
746             (but not for reading files).  For each file, this class creates
747             creates both a carriage-return checker and a format-specific
748             style checker (e.g. one of C++, Python, etc).
749           - Updated the PatchChecker class to use a TextFileReader instance
750             instead of a StyleChecker.
751
752         * Scripts/webkitpy/style/checker_unittest.py:
753           - Added the StyleProcessor_EndToEndTest class to do "end-to-end"
754             tests of the StyleProcessor class.
755           - Added the StyleProcessor_CodeCoverageTest to test the
756             StyleProcessor class with more complete code coverage.
757             Unlike the StyleProcessor_EndToEndTest class, this class makes
758             heavy use of mock parameters.
759           - Added FIXME's to delete the unit test classes that are no
760             longer needed.
761           - Updated the PatchCheckerTest class to use a MockTextFileReader
762             instead of a MockStyleChecker.
763
764         * Scripts/webkitpy/style/filereader.py:
765           - Updated the TextFileReader class to use the preferred logic
766             of checking file existence at the beginning of the process_file()
767             method instead of in the except block, per
768             https://bugs.webkit.org/show_bug.cgi?id=37122
769
770         * Scripts/webkitpy/style/filereader_unittest.py:
771           - In the TextFileReaderTest class:
772             - Moved the test_process_file__should_not_process() method.
773             - Added a test_process_file__file_stdin() method to test
774               the file path "-".
775
776 2010-04-20  Robert Hogan  <robert@webkit.org>
777
778         Reviewed by Simon Hausmann.
779
780         [Qt] Add more support for textInputController
781
782         Add support for selectedRange(), setMarkedText(), insertText(),
783         and firstRectForCharacterRange().
784
785         Unskip tests:
786
787         fast/forms/input-maxlength-ime-preedit.html
788         fast/forms/input-maxlength-ime-completed.html
789         fast/text/international/thai-cursor-position.html
790         fast/events/ime-composition-events-001.html
791         editing/selection/5825350-1.html
792         editing/selection/5825350-2.html
793         editing/selection/mixed-editability-10.html
794
795         https://bugs.webkit.org/show_bug.cgi?id=35702
796
797         * DumpRenderTree/qt/TextInputControllerQt.cpp:
798         (TextInputController::setMarkedText):
799         (TextInputController::insertText):
800         (TextInputController::selectedRange):
801         (TextInputController::firstRectForCharacterRange):
802         * DumpRenderTree/qt/TextInputControllerQt.h:
803
804 2010-04-23  Eric Seidel  <eric@webkit.org>
805
806         Reviewed by Adam Barth.
807
808         check-webkit-style complains about non-utf8 data in layout test result
809         https://bugs.webkit.org/show_bug.cgi?id=38027
810
811         The problem was we were assuming patch files/diff output as utf-8.
812         Turns out they're not.  We have to treat them as binary data because
813         a single patch may have multiple text files in it with conflicting encodings!
814
815         * Scripts/webkitpy/common/checkout/api.py:
816          - contents_at_revision returns a byte array, so decode it to unicode
817            before passing it to parse_latest_entry_from_file
818         * Scripts/webkitpy/common/checkout/api_unittest.py:
819          - Update our mock mock_contents_at_revision to match the encoding
820            semantics of the real one.
821         * Scripts/webkitpy/common/checkout/scm.py:
822          - Be careful not to decode output which may contain file contents
823            (like diff, cat or show) as the encoding for that content is unknown.
824         * Scripts/webkitpy/common/checkout/scm_unittest.py:
825          - Update our tests to use both latin1 and utf-8 encoded data.
826         * Scripts/webkitpy/common/net/bugzilla.py:
827          - _fill_attachment_form should not assume unicode data.  Callers
828            may wish to attach other types of files to bugs.
829         * Scripts/webkitpy/common/prettypatch.py:
830          - Diffs are byte arrays, deal with them as such.
831         * Scripts/webkitpy/common/prettypatch_unittest.py:
832          - Test to make sure we handle diffs with multiple conflicting encodings.
833         * Scripts/webkitpy/common/system/executive_unittest.py:
834          - Make sure that our unicode support does not break our
835            byte array input support for run_command.
836
837 2010-04-23  Sam Weinig  <sam@webkit.org>
838
839         Reviewed by David Levin.
840
841         Fix for https://bugs.webkit.org/show_bug.cgi?id=38060
842         Split up Threading.h
843
844         Add necessary forwarding headers.
845
846         * DumpRenderTree/ForwardingHeaders/wtf/Atomics.h: Added.
847         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
848         * DumpRenderTree/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
849
850 2010-04-23  Xiaomei Ji  <xji@chromium.org>
851
852         No need to review.
853
854         Add xji as committer.
855
856         * Scripts/webkitpy/common/config/committers.py:
857
858 2010-04-23  Kevin Ollivier  <kevino@theolliviers.com>
859
860         [wx] Build fix, add platform stub for new LayoutTestController method.
861
862         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
863         (LayoutTestController::markerTextForListItem):
864
865 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
866
867         Reviewed by Adam Barth.
868
869         new-run-webkit-tests: add a "--retry-failures" flag and a
870         "--no-retry-failures" flag (the former is the default). Also, rename
871         "--print-unexpected-results" and "--retry-unexpected-results" to
872         "--print-last-failures" and "--retry-last-failures" because the
873         retry flag was confusing. The new flag names aren't great, but
874         hopefully they're less confusing.
875
876         https://bugs.webkit.org/show_bug.cgi?id=37838
877
878         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
879
880 2010-04-22  Sam Weinig  <sam@webkit.org>
881
882         Reviewed by Anders Carlsson.
883
884         Fix for https://bugs.webkit.org/show_bug.cgi?id=38022
885         Move isMainThread predicate function to MainThread.h
886
887         Added forwarding header for MainThread.h
888
889         * DumpRenderTree/ForwardingHeaders/wtf/MainThread.h: Added.
890
891 2010-04-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
892
893         Reviewed by Kenneth Rohde Christiansen.
894
895         [Qt] Disable Netscape plugin support for minimal configuration
896         https://bugs.webkit.org/show_bug.cgi?id=38026
897
898         Pass the minimal configuration option to Qt build system 
899         as part of the CONFIG variable.
900
901         * Scripts/build-webkit:
902
903 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
904
905         Unreviewed fix.
906
907         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
908
909 2010-04-22  James Robinson  <jamesr@chromium.org>
910
911         Reviewed by Adam Barth.
912
913         Revert 58077 and follow-ups.  It's broken.
914         https://bugs.webkit.org/show_bug.cgi?id=37664
915
916         * Scripts/new-run-webkit-httpd:
917         * Scripts/new-run-webkit-websocketserver:
918         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
919         * Scripts/webkitpy/layout_tests/port/http_server.py:
920         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
921
922 2010-04-22  Yaar Schnitman  <yaar@chromium.org>
923
924         Reviewed by Adam Barth.
925
926         Integrate v8 testing utility with webkit tests
927         https://bugs.webkit.org/show_bug.cgi?id=37731
928
929         * Scripts/run-bindings-tests: Added.
930
931 2010-04-22  Eric Seidel  <eric@webkit.org>
932
933         Reviewed by Dimitri Glazkov.
934
935         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
936         https://bugs.webkit.org/show_bug.cgi?id=37794
937
938         * Scripts/webkitpy/layout_tests/port/webkit.py:
939          - Remove the assert() since our ServerProcess code does not always
940            seem to be reading the full stderr output (or we're not waiting for it to).
941
942 2010-04-22  Eric Seidel  <eric@webkit.org>
943
944         Reviewed by Adam Barth.
945
946         Add code to help debug new-run-webkit-test hangs on the Chromium bots
947         https://bugs.webkit.org/show_bug.cgi?id=38011
948
949         I can see no reasonable way to test this change.
950         Stubbing out sys._current_frames() and traceback.extract_stack
951         seems folly.  Dumping real data would have line number
952         (and possibly other call stack) variance between runs.
953
954         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
955          - Add _dump_thread_states and _dump_thread_states_if_necessary
956            to have our main thread dump the states of all threads every
957            60 seconds when running in verbose mode.
958          - Better document what is going on in our main loop.
959
960 2010-04-22  Sam Weinig  <sam@webkit.org>
961
962         Reviewed by Anders Carlsson.
963
964         Fix for https://bugs.webkit.org/show_bug.cgi?id=38002
965         Add rudimentary statistics gathering for WebKit2
966
967         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
968         * MiniBrowser/mac/AppDelegate.h:
969         * MiniBrowser/mac/AppDelegate.m:
970         (-[BrowserAppDelegate init]):
971         (-[BrowserAppDelegate newWindow:]):
972         (-[BrowserAppDelegate getCurrentPageNamespace]):
973         (-[BrowserAppDelegate _setProcessModel:]):
974         (-[BrowserAppDelegate showStatisticsWindow:]):
975         (-[BrowserAppDelegate applicationWillTerminate:]):
976         * MiniBrowser/mac/BrowserStatisticsWindow.xib: Added.
977         * MiniBrowser/mac/BrowserStatisticsWindowController.h: Added.
978         * MiniBrowser/mac/BrowserStatisticsWindowController.m: Added.
979         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
980         (-[BrowserStatisticsWindowController dealloc]):
981         (-[BrowserStatisticsWindowController windowDidLoad]):
982         (-[BrowserStatisticsWindowController refreshStatistics:]):
983         * MiniBrowser/mac/BrowserWindowController.h:
984         * MiniBrowser/mac/English.lproj/MainMenu.xib:
985         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
986
987 2010-04-22  Dave Moore  <davemoore@chromium.org>
988
989         Reviewed by Dimitri Glazkov.
990
991         Add test support for icon changes.
992
993         https://bugs.webkit.org/show_bug.cgi?id=33812
994
995         * DumpRenderTree/LayoutTestController.cpp:
996         (LayoutTestController::LayoutTestController):
997         (dumpIconChangesCallback):
998         (LayoutTestController::staticFunctions):
999         * DumpRenderTree/LayoutTestController.h:
1000         (LayoutTestController::dumpIconChanges):
1001         (LayoutTestController::setDumpIconChanges):
1002         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1003         (FrameLoadDelegate::didChangeIcons):
1004         * DumpRenderTree/win/FrameLoadDelegate.h:
1005         * WinLauncher/WinLauncher.h:
1006         (WinLauncherWebHost::didChangeIcons):
1007
1008 2010-04-22  Eric Seidel  <eric@webkit.org>
1009
1010         Unreviewed.  Script fix.  Will ask dpranke to look tomorrow.
1011
1012         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
1013         https://bugs.webkit.org/show_bug.cgi?id=37794
1014
1015         The bots are seeing cases where .error is sometimes empty.
1016         Lets make the code not crash in that case for now.
1017
1018         * Scripts/webkitpy/layout_tests/port/webkit.py:
1019
1020 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1021
1022         Unreviewed fix.
1023
1024         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
1025
1026 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1027
1028         Unreviewed fix.
1029
1030         * Scripts/new-run-webkit-websocketserver: PyWebSocket no longer takes keyword argument 'register_cygwin'.
1031
1032 2010-04-22  Eric Seidel  <eric@webkit.org>
1033
1034         Unreviewed.  Restore the Leopard bots to using
1035         old-run-webkit-tests for now.
1036
1037         * Scripts/run-webkit-tests:
1038
1039 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1040
1041         Unreviewed fix.
1042
1043         * Scripts/webkitpy/layout_tests/port/http_server.py: fix NameError: global name 'env' is not defined.
1044
1045 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1046
1047         Unreviewed fix.
1048
1049         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'env' is not defined.
1050
1051 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1052
1053         Reviewed by Adam Barth.
1054
1055         Chromium: Add --chromium option to new-run-webkit-websocketserver
1056         https://bugs.webkit.org/show_bug.cgi?id=37664
1057
1058         Move cygwin setup logic in chromium_win.py.
1059
1060         * Scripts/new-run-webkit-httpd: remove register_cygwin parameter to pass http_server.
1061         * Scripts/new-run-webkit-websocketserver: add --chromium flag
1062         * Scripts/webkitpy/layout_tests/port/chromium_win.py: setup for cygwin
1063         * Scripts/webkitpy/layout_tests/port/http_server.py: remove cygwin setup logic
1064         * Scripts/webkitpy/layout_tests/port/websocket_server.py: remove cygwin setup logic
1065
1066 2010-04-22  Eric Seidel  <eric@webkit.org>
1067
1068         Reviewed by Adam Barth.
1069
1070         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
1071         https://bugs.webkit.org/show_bug.cgi?id=37794
1072
1073         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1074          - Fix the log message to explain that this is stderr output, not test output.
1075         * Scripts/webkitpy/layout_tests/port/webkit.py:
1076          - Be sure to reset the server_process.error after reading (seems like the wrong
1077            place to do this, but at least this fixes the bug and dpranke and I can talk
1078            about better designs later).
1079          - Also remove the #EOF from the stderr output before returning it.
1080
1081 2010-04-22  Eric Seidel  <eric@webkit.org>
1082
1083         Unreviewed.  Fixing new-run-webkit-tests on the bots.
1084
1085         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1086          - Fixing _compat_shim_option to take variable keyword args.
1087          - Turns out that nargs + callback is ignored unless type is specified.
1088            So I added the type so that the option was properly consumed.
1089            This was why new-run-webkit-tests couldn't find any tests, it
1090            was looking for them under "20" because that was the argument
1091            which should have been consumed by --exit-after-n-failures.
1092
1093 2010-04-22  Tony Chang  <tony@chromium.org>
1094
1095         Not reviewed, build fix for chromium Windows.
1096
1097         [chromium] fix ImageDiff compile on windows
1098         https://bugs.webkit.org/show_bug.cgi?id=37979
1099
1100         * DumpRenderTree/chromium/ImageDiff.cpp:
1101
1102 2010-04-22  Adam Barth  <abarth@webkit.org>
1103
1104         Unreviewed, rolling out r58069.
1105         http://trac.webkit.org/changeset/58069
1106         https://bugs.webkit.org/show_bug.cgi?id=27751
1107
1108         Broke compile on Windows.
1109
1110         * DumpRenderTree/LayoutTestController.cpp:
1111         (LayoutTestController::staticFunctions):
1112         * DumpRenderTree/LayoutTestController.h:
1113         * DumpRenderTree/chromium/LayoutTestController.cpp:
1114         (LayoutTestController::LayoutTestController):
1115         (LayoutTestController::overridePreference):
1116         * DumpRenderTree/chromium/LayoutTestController.h:
1117         * DumpRenderTree/chromium/TestShell.cpp:
1118         (TestShell::resetWebSettings):
1119         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1120         * DumpRenderTree/mac/DumpRenderTree.mm:
1121         (resetDefaultsToConsistentValues):
1122         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1123         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1124         (WebCore::WebPage::WebPage):
1125         (WebCore::WebPage::resetSettings):
1126         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1127         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1128         * DumpRenderTree/win/DumpRenderTree.cpp:
1129         (resetDefaultsToConsistentValues):
1130         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1131         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1132
1133 2010-04-22  Eric Seidel  <eric@webkit.org>
1134
1135         Unreviewed.  Just adding logging.
1136
1137         Adding logging to help debug why the Leopard Bot
1138         can't find any tests to run.
1139
1140         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
1141         * Scripts/webkitpy/layout_tests/port/base.py:
1142         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1143          - Make it a fatal error to have no tests to run.
1144
1145 2010-04-22  Abhishek Arya  <inferno@chromium.org>
1146
1147         Reviewed by Adam Barth.
1148
1149         Add support for controlling clipboard access from javascript.
1150         Clipboard access from javascript is enabled in test framework.
1151         https://bugs.webkit.org/show_bug.cgi?id=27751
1152
1153         * DumpRenderTree/LayoutTestController.cpp:
1154         (setJavaScriptCanAccessClipboardCallback):
1155         (LayoutTestController::staticFunctions):
1156         * DumpRenderTree/LayoutTestController.h:
1157         * DumpRenderTree/chromium/LayoutTestController.cpp:
1158         (LayoutTestController::LayoutTestController):
1159         (LayoutTestController::setJavaScriptCanAccessClipboard):
1160         (LayoutTestController::overridePreference):
1161         * DumpRenderTree/chromium/LayoutTestController.h:
1162         * DumpRenderTree/chromium/TestShell.cpp:
1163         (TestShell::resetWebSettings):
1164         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1165         (LayoutTestController::setJavaScriptCanAccessClipboard):
1166         * DumpRenderTree/mac/DumpRenderTree.mm:
1167         (resetDefaultsToConsistentValues):
1168         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1169         (LayoutTestController::setJavaScriptCanAccessClipboard):
1170         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1171         (WebCore::WebPage::WebPage):
1172         (WebCore::WebPage::resetSettings):
1173         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1174         (LayoutTestController::setJavaScriptCanAccessClipboard):
1175         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1176         * DumpRenderTree/win/DumpRenderTree.cpp:
1177         (resetDefaultsToConsistentValues):
1178         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1179         (LayoutTestController::setJavaScriptCanAccessClipboard):
1180         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1181         (LayoutTestController::setJavaScriptCanAccessClipboard):
1182
1183 2010-04-21  Adam Barth  <abarth@webkit.org>
1184
1185         Reviewed by Eric Seidel.
1186
1187         webkit-patch can't fetch attachments on security bugs
1188         https://bugs.webkit.org/show_bug.cgi?id=37975
1189
1190         Instead of calling CURL, we just need to use our Mechanize object,
1191         which understand bugs.webkit.org authentication.
1192
1193         * Scripts/webkitpy/common/checkout/api.py:
1194         * Scripts/webkitpy/common/net/bugzilla.py:
1195
1196 2010-04-21  Eric Seidel  <eric@webkit.org>
1197
1198         Unreviewed.  Temporary commit, will roll-out before morning.
1199
1200         Turning on new-run-webkit-tests for the Leopard build bot
1201         for testing of the harness.
1202         Users should not noctice (except for the results.html difference).
1203
1204         * Scripts/run-webkit-tests:
1205
1206 2010-04-21  Eric Seidel  <eric@webkit.org>
1207
1208         Unreviewed.  Fix typo in my previous fix attempt.
1209
1210         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1211         https://bugs.webkit.org/show_bug.cgi?id=37765
1212
1213         More on-the-bot debugging, sigh.  I wish I had a local build.
1214
1215         * Scripts/webkitpy/layout_tests/port/base.py:
1216
1217 2010-04-21  Eric Seidel  <eric@webkit.org>
1218
1219         Unreviewed.  Fix typo in my previous fix attempt.
1220
1221         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1222         https://bugs.webkit.org/show_bug.cgi?id=37765
1223
1224         * Scripts/webkitpy/layout_tests/port/base.py:
1225          - Add self. to class variable access.
1226
1227 2010-04-21  Eric Seidel  <eric@webkit.org>
1228
1229         Unreviewed.  Another attempt to fix NRWT for chromium.
1230
1231         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1232         https://bugs.webkit.org/show_bug.cgi?id=37765
1233
1234         * Scripts/webkitpy/layout_tests/port/base.py:
1235          - wdiff_text was returning a byte array instead of a
1236            unicode string.  The simple fix was to just decode
1237            the result.  However, seeing so much duplicated code
1238            with Executive made me cry, so I re-wrote the function
1239            to be more like pretty_patch_text and use run_command
1240            (which already knows how to handle unicode).
1241
1242 2010-04-21  Adam Barth  <abarth@webkit.org>
1243
1244         Reviewed by Eric Seidel.
1245
1246         Windows tests buildbots are too slow to be core builders
1247         https://bugs.webkit.org/show_bug.cgi?id=37970
1248
1249         It's 10:45.  The Windows test bots are still hours behind.  They're too
1250         slow to be core builders.  When they get fast, we can add them back.
1251
1252         * Scripts/webkitpy/common/net/buildbot.py:
1253         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1254
1255 2010-04-21  Eric Seidel  <eric@webkit.org>
1256
1257         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1258
1259         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1260         https://bugs.webkit.org/show_bug.cgi?id=37765
1261
1262         I'm debugging in the blind because I don't have a chromium
1263         build on this laptop.
1264
1265         * Scripts/webkitpy/layout_tests/port/chromium.py:
1266          - Apply the previous fix to a second caller.
1267
1268 2010-04-21  Eric Seidel  <eric@webkit.org>
1269
1270         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1271
1272         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1273         https://bugs.webkit.org/show_bug.cgi?id=37765
1274
1275         * Scripts/webkitpy/layout_tests/port/chromium.py:
1276          - Fix handling of test_shell output so that we always
1277            decode it as utf-8.
1278            Unlike DumpRenderTree test_shell does not ever return
1279            pixel data.  It spits out the pixel dumps in a separate
1280            file, thus all output over stdout is utf-8 text.
1281
1282 2010-04-21  Eric Seidel  <eric@webkit.org>
1283
1284         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1285
1286         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1287         https://bugs.webkit.org/show_bug.cgi?id=37765
1288
1289         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1290          - Pass encoding to _save_baseline_data and write_output_files
1291         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1292          - Make _save_baseline_data and write_output_files take an encoding.
1293         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1294         - Pass encoding to _save_baseline_data and write_output_files
1295
1296 2010-04-21  No'am Rosenthal  <noam.rosenthal@nokia.com>
1297
1298         Reviewed by Kenneth Rohde Christiansen.
1299
1300         [Qt] QtLauncher: make FPS measurement accurate
1301         https://bugs.webkit.org/show_bug.cgi?id=37934
1302
1303         Instead of counting paints, which are not interchangeable with frames that
1304         the user sees, we now set an arbitrary timer for FPS measurements. The idea is
1305         that if the main thread is delayed for any reason, that timer would be delayed
1306         as well.
1307
1308         * QtLauncher/QtLauncher.pro:
1309         * QtLauncher/fpstimer.cpp: Added.
1310         (FpsTimer::FpsTimer):
1311         (FpsTimer::numFrames):
1312         (FpsTimer::start):
1313         (FpsTimer::stop):
1314         (FpsTimer::timerEvent):
1315         * QtLauncher/fpstimer.h: Added.
1316         * QtLauncher/webview.cpp:
1317         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
1318         (WebViewGraphicsBased::updateFrameRate):
1319         (WebViewGraphicsBased::paintEvent):
1320         * QtLauncher/webview.h:
1321
1322 2010-04-21  Eric Seidel  <eric@webkit.org>
1323
1324         Unreviewed, just adding missing ":" in python file.
1325
1326         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1327         https://bugs.webkit.org/show_bug.cgi?id=37765
1328
1329         new-run-webkit-tests --chromium was borked.
1330
1331         * Scripts/webkitpy/layout_tests/port/chromium.py:
1332
1333 2010-04-21  Eric Seidel  <eric@webkit.org>
1334
1335         Reviewed by Adam Barth.
1336
1337         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1338         https://bugs.webkit.org/show_bug.cgi?id=37765
1339
1340         Third time is the charm.  I've fixed all the
1341         new-run-webkit-tests regressions from previous attempts.
1342
1343         I fixed the queue to not ignore Tor as a reviwer in r57531,
1344         but instead it throws an exception every time his name is in a patch.
1345
1346         This fixes our Executive.run_command code to work around a Popen
1347         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
1348         do not correctly handle unicode objects as input or output to
1349         Popen.communicate.
1350
1351         Following the advice of:
1352         http://farmdev.com/talks/unicode/
1353         I have changed all of webkitpy to use unicode() objects as strings
1354         instead of str objects (which in Python 3 are renamed "bytes").
1355
1356         String literals were left as "foo" instead of converting to u"foo"
1357         as u"foo" is only required if the string has a non-ascii code point.
1358         Python is smart about comparing str() and unicode() values and will
1359         log an error to the console if the comparison is ever invalid.
1360
1361         Executive.run* now correctly accept and return unicode() objects.
1362         I attempted to fix all the places that we call .write() to make sure we
1363         encode any unicode() objects into utf-8.
1364
1365         I removed several uses of StringIO.  StringIO should generally always be
1366         passed a unicode() value.
1367
1368         Likewise I replaced most calls to open() with codecs.open().
1369         codecs.open() matches Python 3 open semantics in requiring an encoding
1370         parameter.  Files opened with codecs.open() with a unicode-compatible
1371         encoding will vend unicode() objects from their read() calls, like how
1372         StringIO created with a unicode() object will do.
1373
1374         I also deployed "with" statements wider (now that the project has
1375         settled on Python 2.5) to close a bunch of file descriptor leaks.
1376
1377         * Scripts/webkitpy/common/checkout/api_unittest.py:
1378          - Read/write utf-8 files instead of ascii.
1379          - Update the tests to use test for proper unicode() handling.
1380         * Scripts/webkitpy/common/checkout/changelog.py:
1381          - Document that parse_latest_entry_from_file expects
1382            file-like objects which return unicode strings.
1383         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1384          - Use unicode() strings instead of str() byte arrays.
1385          - Deploy "with" to close file descriptor leaks.
1386         * Scripts/webkitpy/common/checkout/commitinfo.py:
1387          - Remove unneeded import.
1388         * Scripts/webkitpy/common/checkout/scm.py:
1389          - Remove use of str().
1390         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1391          - Read/write utf-8 files and use unicode() strings in testing.
1392         * Scripts/webkitpy/common/config/committers.py:
1393          - Use \u instead of \x to make slightly clearer what we're doing.
1394         * Scripts/webkitpy/common/net/bugzilla.py:
1395          - Add a new _string_contents() method and explain why
1396             we have to call unicode() on the result of soup.string
1397             and why it's safe to do so w/o needing to pass a codec name.
1398           - Remove the (unused) support for passing a file object to add_patch_to_bug().
1399         * Scripts/webkitpy/common/net/buildbot.py:
1400          - Use unicode() instead of str() when needing to coax a
1401             NavigableString object into a unicode() object.
1402         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1403          - Add a test which contains a unicode builder name.
1404         * Scripts/webkitpy/common/net/statusserver.py:
1405          - Remove use of str()
1406         * Scripts/webkitpy/common/prettypatch.py:
1407          - Write out the patch file as utf-8.
1408         * Scripts/webkitpy/common/system/autoinstall.py:
1409          - Write out files with a explicit encodings.
1410          - Deploy "with" to close file descriptor leaks.
1411         * Scripts/webkitpy/common/system/deprecated_logging.py:
1412          - Write out log files as utf-8.
1413         * Scripts/webkitpy/common/system/executive.py:
1414          - Make run* properly take and return unicode() objects.
1415          - Cleaned up input handling in run_command a little by adding
1416            a _compute_input() method which can return early instead of having
1417            such a long/cluttered if-block.
1418         * Scripts/webkitpy/common/system/executive_unittest.py:
1419          - Added a unit test to make sure we don't break Tor again!
1420         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1421          - Write out the test list as utf-8.
1422         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1423          - Write out json files as utf-8.
1424         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1425          - Deploy "with" to close file descriptor leaks.
1426         * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
1427         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
1428         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
1429         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
1430         * Scripts/webkitpy/layout_tests/port/mac.py: ditto.
1431         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1432          - Make the skipped file parsing test unicode.
1433         * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
1434         * Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
1435         * Scripts/webkitpy/layout_tests/port/webkit.py:
1436          - Deploy "with" to close file descriptor leaks.
1437         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1438          - Make explicit the encodings of log files and pid files.
1439         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1440          - Make encodings explicit and deploy "with".
1441         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
1442         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
1443         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
1444         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
1445         * Scripts/webkitpy/style/filereader_unittest.py: ditto.
1446         * Scripts/webkitpy/thirdparty/__init__.py: ditto.
1447         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1448          - Removed extra import.
1449         * Scripts/webkitpy/tool/commands/queues.py:
1450          - No need to map args to strings now that run_command does.
1451          - Update test results to match args changes.
1452          - Document our global argument hacks.
1453         * Scripts/webkitpy/tool/commands/upload.py:
1454          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1455         * Scripts/webkitpy/tool/mocktool.py:
1456          - Rename add_patch_to_bug argument to match bugzilla.py
1457         * Scripts/webkitpy/tool/steps/abstractstep.py:
1458          - Executive.run_* now require lists instead of strings.
1459            The lack of this change was what broke webkit-patch
1460            for svn users the first time this was landed.
1461         * Scripts/webkitpy/tool/steps/postdiff.py:
1462          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1463         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
1464         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
1465         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1466          - Fixed spurious logging seen when running test-webkitpy
1467
1468 2010-04-21  Chris Fleizach  <cfleizach@apple.com>
1469
1470         Reviewed by Alexey Proskuryakov.
1471
1472         aria-liveregion-notifications.html fails on leopard release bot
1473         https://bugs.webkit.org/show_bug.cgi?id=37112
1474
1475         Change the way that notifications are listened for by forcing clients
1476         to call a remove listener as well to match the add listener. DRT will
1477         assert if those are not done in the correct order. 
1478
1479         * DumpRenderTree/AccessibilityUIElement.cpp:
1480         (removeNotificationListenerCallback):
1481         (AccessibilityUIElement::getJSClass):
1482         * DumpRenderTree/AccessibilityUIElement.h:
1483         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1484         (AccessibilityUIElement::removeNotificationListener):
1485         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1486         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
1487         (-[AccessibilityNotificationHandler dealloc]):
1488         (-[AccessibilityNotificationHandler _notificationReceived:]):
1489         (-[AccessibilityNotificationHandler setCallback:]):
1490         (AccessibilityUIElement::AccessibilityUIElement):
1491         (AccessibilityUIElement::~AccessibilityUIElement):
1492         (AccessibilityUIElement::addNotificationListener):
1493         (AccessibilityUIElement::removeNotificationListener):
1494         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1495         (AccessibilityUIElement::removeNotificationListener):
1496
1497 2010-04-21  Anders Carlsson  <andersca@apple.com>
1498
1499         Reviewed by Sam Weinig.
1500
1501         Add debug menu items to show/hide the Web View.
1502         https://bugs.webkit.org/show_bug.cgi?id=37958
1503
1504         * MiniBrowser/mac/BrowserWindowController.h:
1505         * MiniBrowser/mac/BrowserWindowController.m:
1506         (-[BrowserWindowController showHideWebView:]):
1507         (-[BrowserWindowController removeReinsertWebView:]):
1508         (-[BrowserWindowController validateMenuItem:]):
1509         * MiniBrowser/mac/English.lproj/MainMenu.xib:
1510
1511 2010-04-21  Eric Seidel  <eric@webkit.org>
1512
1513         Unreviewed.  Rolling out unicode() changes as they broke NRWT for chromium.
1514         Rolling out:
1515         http://trac.webkit.org/changeset/58014
1516         http://trac.webkit.org/changeset/58016
1517         http://trac.webkit.org/changeset/58020
1518
1519         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbo
1520         https://bugs.webkit.org/show_bug.cgi?id=37765
1521
1522         * Scripts/webkitpy/common/checkout/api_unittest.py:
1523         * Scripts/webkitpy/common/checkout/changelog.py:
1524         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1525         * Scripts/webkitpy/common/checkout/commitinfo.py:
1526         * Scripts/webkitpy/common/checkout/scm.py:
1527         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1528         * Scripts/webkitpy/common/config/committers.py:
1529         * Scripts/webkitpy/common/net/bugzilla.py:
1530         * Scripts/webkitpy/common/net/buildbot.py:
1531         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1532         * Scripts/webkitpy/common/net/statusserver.py:
1533         * Scripts/webkitpy/common/prettypatch.py:
1534         * Scripts/webkitpy/common/system/autoinstall.py:
1535         * Scripts/webkitpy/common/system/deprecated_logging.py:
1536         * Scripts/webkitpy/common/system/executive.py:
1537         * Scripts/webkitpy/common/system/executive_unittest.py:
1538         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1539         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1540         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1541         * Scripts/webkitpy/layout_tests/port/chromium.py:
1542         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1543         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1544         * Scripts/webkitpy/layout_tests/port/gtk.py:
1545         * Scripts/webkitpy/layout_tests/port/mac.py:
1546         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1547         * Scripts/webkitpy/layout_tests/port/qt.py:
1548         * Scripts/webkitpy/layout_tests/port/server_process.py:
1549         * Scripts/webkitpy/layout_tests/port/webkit.py:
1550         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1551         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1552         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1553         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1554         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1555         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1556         * Scripts/webkitpy/style/filereader_unittest.py:
1557         * Scripts/webkitpy/thirdparty/__init__.py:
1558         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1559         * Scripts/webkitpy/tool/commands/queues.py:
1560         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1561         * Scripts/webkitpy/tool/commands/upload.py:
1562         * Scripts/webkitpy/tool/mocktool.py:
1563         * Scripts/webkitpy/tool/steps/abstractstep.py:
1564         * Scripts/webkitpy/tool/steps/postdiff.py:
1565         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
1566         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1567         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1568
1569 2010-04-21  Eric Seidel  <eric@webkit.org>
1570
1571         Unreviewed, fixing NRWT for real this time.
1572
1573         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1574         https://bugs.webkit.org/show_bug.cgi?id=37765
1575
1576         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1577          - Add a hack to fix new-run-webkit-tests
1578            my understanding of codecs.open(encoding=None)
1579            must have been wrong.
1580
1581 2010-04-21  Eric Seidel  <eric@webkit.org>
1582
1583         Unreviewed, just fixing exception seen on builders.
1584
1585         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1586         https://bugs.webkit.org/show_bug.cgi?id=37765
1587
1588         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1589          - Pass and encoding to _write_into_file_at_path
1590
1591 2010-04-21  Eric Seidel  <eric@webkit.org>
1592
1593         Reviewed by Adam Barth.
1594
1595         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1596         https://bugs.webkit.org/show_bug.cgi?id=37765
1597
1598         I fixed the queue to not ignore Tor as a reviwer in r57531,
1599         but instead it throws an exception every time his name is in a patch.
1600
1601         This fixes our Executive.run_command code to work around a Popen
1602         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
1603         do not correctly handle unicode objects as input or output to
1604         Popen.communicate.
1605
1606         Following the advice of:
1607         http://farmdev.com/talks/unicode/
1608         I have changed all of webkitpy to use unicode() objects as strings
1609         instead of str objects (which in Python 3 are renamed "bytes").
1610
1611         String literals were left as "foo" instead of converting to u"foo"
1612         as u"foo" is only required if the string has a non-ascii code point.
1613         Python is smart about comparing str() and unicode() values and will
1614         log an error to the console if the comparison is ever invalid.
1615
1616         Executive.run* now correctly accept and return unicode() objects.
1617         I attempted to fix all the places that we call .write() to make sure we
1618         encode any unicode() objects into utf-8.
1619
1620         I removed several uses of StringIO.  StringIO should generally always be
1621         passed a unicode() value.
1622
1623         Likewise I replaced most calls to open() with codecs.open().
1624         codecs.open() matches Python 3 open semantics in requiring an encoding
1625         parameter.  Files opened with codecs.open() with a unicode-compatible
1626         encoding will vend unicode() objects from their read() calls, like how
1627         StringIO created with a unicode() object will do.
1628
1629         I also deployed "with" statements wider (now that the project has
1630         settled on Python 2.5) to close a bunch of file descriptor leaks.
1631
1632         * Scripts/webkitpy/common/checkout/api_unittest.py:
1633          - Read/write utf-8 files instead of ascii.
1634          - Update the tests to use test for proper unicode() handling.
1635         * Scripts/webkitpy/common/checkout/changelog.py:
1636          - Document that parse_latest_entry_from_file expects
1637            file-like objects which return unicode strings.
1638         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1639          - Use unicode() strings instead of str() byte arrays.
1640          - Deploy "with" to close file descriptor leaks.
1641         * Scripts/webkitpy/common/checkout/commitinfo.py:
1642          - Remove unneeded import.
1643         * Scripts/webkitpy/common/checkout/scm.py:
1644          - Remove use of str().
1645         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1646          - Read/write utf-8 files and use unicode() strings in testing.
1647         * Scripts/webkitpy/common/config/committers.py:
1648          - Use \u instead of \x to make slightly clearer what we're doing.
1649         * Scripts/webkitpy/common/net/bugzilla.py:
1650          - Add a new _string_contents() method and explain why
1651             we have to call unicode() on the result of soup.string
1652             and why it's safe to do so w/o needing to pass a codec name.
1653           - Remove the (unused) support for passing a file object to add_patch_to_bug().
1654         * Scripts/webkitpy/common/net/buildbot.py:
1655          - Use unicode() instead of str() when needing to coax a
1656             NavigableString object into a unicode() object.
1657         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1658          - Add a test which contains a unicode builder name.
1659         * Scripts/webkitpy/common/net/statusserver.py:
1660          - Remove use of str()
1661         * Scripts/webkitpy/common/prettypatch.py:
1662          - Write out the patch file as utf-8.
1663         * Scripts/webkitpy/common/system/autoinstall.py:
1664          - Write out files with a explicit encodings.
1665          - Deploy "with" to close file descriptor leaks.
1666         * Scripts/webkitpy/common/system/deprecated_logging.py:
1667          - Write out log files as utf-8.
1668         * Scripts/webkitpy/common/system/executive.py:
1669          - Make run* properly take and return unicode() objects.
1670          - Cleaned up input handling in run_command a little by adding
1671            a _compute_input() method which can return early instead of having
1672            such a long/cluttered if-block.
1673         * Scripts/webkitpy/common/system/executive_unittest.py:
1674          - Added a unit test to make sure we don't break Tor again!
1675         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1676          - Write out the test list as utf-8.
1677         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1678          - Write out json files as utf-8.
1679         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1680          - Deploy "with" to close file descriptor leaks.
1681         * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
1682         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
1683         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
1684         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
1685         * Scripts/webkitpy/layout_tests/port/mac.py: ditto.
1686         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1687          - Make the skipped file parsing test unicode.
1688         * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
1689         * Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
1690         * Scripts/webkitpy/layout_tests/port/webkit.py:
1691          - Deploy "with" to close file descriptor leaks.
1692         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1693          - Make explicit the encodings of log files and pid files.
1694         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1695          - Make encodings explicit and deploy "with".
1696         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
1697         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
1698         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
1699         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
1700         * Scripts/webkitpy/style/filereader_unittest.py: ditto.
1701         * Scripts/webkitpy/thirdparty/__init__.py: ditto.
1702         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1703          - Removed extra import.
1704         * Scripts/webkitpy/tool/commands/queues.py:
1705          - No need to map args to strings now that run_command does.
1706          - Update test results to match args changes.
1707          - Document our global argument hacks.
1708         * Scripts/webkitpy/tool/commands/upload.py:
1709          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1710         * Scripts/webkitpy/tool/mocktool.py:
1711          - Rename add_patch_to_bug argument to match bugzilla.py
1712         * Scripts/webkitpy/tool/steps/abstractstep.py:
1713          - Executive.run_* now require lists instead of strings.
1714            The lack of this change was what broke webkit-patch
1715            for svn users the first time this was landed.
1716         * Scripts/webkitpy/tool/steps/postdiff.py:
1717          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1718         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
1719         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
1720         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1721          - Fixed spurious logging seen when running test-webkitpy
1722
1723 2010-04-21  Kinuko Yasuda  <kinuko@chromium.org>
1724
1725         Unreviewed.
1726
1727         Add myself in committers.py.
1728
1729         * Scripts/webkitpy/common/config/committers.py:
1730
1731 2010-04-21  Dirk Pranke  <dpranke@chromium.org>
1732
1733         Reviewed by Dimitri Glazkov.
1734
1735         new-run-webkit-tests: fix a bug in the Chromium port where we would
1736         try to talk to a crashed test_shell and raise exceptions that weren't
1737         being caught.
1738
1739         https://bugs.webkit.org/show_bug.cgi?id=37941
1740
1741         * Scripts/webkitpy/layout_tests/port/chromium.py:
1742
1743 2010-04-21  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1744
1745         Unreviewed.
1746
1747         [Qt] [Symbian] Build fix.
1748
1749         Work around a Qt quirk. Some versions of Symbian port Qt
1750         QFontDatabase::removeAllApplicationFonts symbol is not available.
1751
1752         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1753         (WebCore::DumpRenderTree::open):
1754
1755 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
1756
1757         Unreviewed.
1758
1759         https://bugs.webkit.org/show_bug.cgi?id=37933
1760         <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
1761
1762         Adding stub implementation of authenticateSession(). Depending on platform loader behavior,
1763         a real implementation may or may not be necessary for the one test that currently uses it
1764         to pass.
1765
1766         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1767         (LayoutTestController::authenticateSession):
1768         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1769
1770 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
1771
1772         Reviewed by Brady Eidson.
1773
1774         https://bugs.webkit.org/show_bug.cgi?id=37933
1775         <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
1776
1777         Adding authenticateSession() method that adds credentials to per-process credential storage
1778         (for platforms that even have such). No Windows implementation, because writing another
1779         loader for DRT is painful.
1780
1781         * DumpRenderTree/LayoutTestController.cpp:
1782         (authenticateSessionCallback):
1783         (LayoutTestController::staticFunctions):
1784         * DumpRenderTree/LayoutTestController.h:
1785         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1786         (-[SynchronousLoader dealloc]):
1787         (-[SynchronousLoader connectionShouldUseCredentialStorage:]):
1788         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
1789         (-[SynchronousLoader connection:didFailWithError:]):
1790         (-[SynchronousLoader connectionDidFinishLoading:]):
1791         (+[SynchronousLoader makeRequest:withUsername:password:]):
1792         (LayoutTestController::authenticateSession):
1793
1794         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1795         (LayoutTestController::authenticateSession):
1796         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1797         (LayoutTestController::authenticateSession):
1798         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1799         (LayoutTestController::authenticateSession):
1800         Stub implementations.
1801
1802 2010-04-21  Kent Tamura  <tkent@chromium.org>
1803
1804         Reviewed by Dimitri Glazkov.
1805
1806         [DRT/Chromium] Make DRT compilable in Chromium tree
1807         https://bugs.webkit.org/show_bug.cgi?id=37923
1808
1809         We need to use different GYPs in a case of WebKit-only checkout
1810         and a case of whole Chromium checkout because the relative paths
1811         from webkit/ to WebKit/chromium/features.gypi are different in
1812         these cases and we can't use 'conditions' for 'includes' in GYPs.
1813
1814         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1815
1816 2010-04-21  Jakub Wieczorek  <jwieczorek@webkit.org>
1817
1818         Reviewed by Darin Adler.
1819
1820         List item markers are not always updated after changes in the DOM.
1821         https://bugs.webkit.org/show_bug.cgi?id=37060
1822
1823         * DumpRenderTree/LayoutTestController.cpp:
1824         (markerTextForListItemCallback): A function that returns the marker text for a given list item.
1825         (LayoutTestController::staticFunctions):
1826         * DumpRenderTree/LayoutTestController.h:
1827         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1828         (LayoutTestController::markerTextForListItem): Implement it in the GTK port.
1829         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1830         (LayoutTestController::markerTextForListItem): Add a stub.
1831         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1832         (LayoutTestController::LayoutTestController):
1833         (LayoutTestController::markerTextForListItem): Implement it in the Qt port.
1834         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1835         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1836         (LayoutTestController::markerTextForListItem): Add a stub.
1837
1838 2010-04-21  Adam Roben  <aroben@apple.com>
1839
1840         Exclude leaks in CGGradientCreateWithColorComponents from
1841         run-webkit-tests leaks output
1842
1843         The leak in CG is covered by <rdar://problem/7888492>.
1844
1845         Fixes <http://webkit.org/b/37927>.
1846
1847         Reviewed by Eric Carlson.
1848
1849         * Scripts/old-run-webkit-tests:
1850         (sub countAndPrintLeaks): Exclude leaks in
1851         CGGradientCreateWithColorComponents on certain OSs.
1852
1853 2010-04-21  Kent Tamura  <tkent@chromium.org>
1854
1855         Reviewed by Shinichiro Hamaji.
1856
1857         [DRT/Chromium] Import MockSpellCheck from Chromium
1858         https://bugs.webkit.org/show_bug.cgi?id=37910
1859
1860         Import webkit/tools/test_shell/mock_spellcheck.{cc,h} rev.37241 of Chromium.
1861
1862         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1863           Add ICU explicitly because WTFString.h includes ICU headers.
1864           Add MockSpellCheck.{cpp,h}.
1865         * DumpRenderTree/chromium/MockSpellCheck.cpp: Added.
1866         * DumpRenderTree/chromium/MockSpellCheck.h: Added.
1867         * DumpRenderTree/chromium/WebViewHost.cpp:
1868         (WebViewHost::spellCheck):
1869         * DumpRenderTree/chromium/WebViewHost.h:
1870         * DumpRenderTree/chromium/config.h: Define JS_EXPORTDATA, which is used
1871           by wtf/text/AtomicString.h included by wtf/text/WTFString.h.
1872
1873 2010-04-21  Adam Barth  <abarth@webkit.org>
1874
1875         Reviewed by Eric Seidel.
1876
1877         Add webkit-patch pretty-diff
1878         https://bugs.webkit.org/show_bug.cgi?id=37892
1879
1880         This is slightly lame because it asks you whether the diff is correct,
1881         but it's a starting point.
1882
1883         * Scripts/webkitpy/tool/commands/__init__.py:
1884         * Scripts/webkitpy/tool/commands/prettydiff.py: Added.
1885         * Scripts/webkitpy/tool/main.py:
1886
1887 2010-04-21  Adam Barth  <abarth@webkit.org>
1888
1889         Reviewed by Darin Adler.
1890
1891         Remove mention of non-existant --no-build option
1892         https://bugs.webkit.org/show_bug.cgi?id=37893
1893
1894         The option doesn't exist!
1895
1896         * Scripts/webkitpy/tool/commands/stepsequence.py:
1897
1898 2010-04-21  Balazs Kelemen  <kb@inf.u-szeged.hu>
1899
1900         Reviewed by Kenneth Rohde Christiansen.
1901
1902         [Qt] Interrupting JavaScript is cumbersome when you use QtLaucher for testing or profiling.
1903         https://bugs.webkit.org/show_bug.cgi?id=37198
1904
1905         * QtLauncher/main.cpp:
1906         (LauncherWindow::toggleInterruptingJavaScriptEnabled):
1907         (LauncherWindow::newWindow):
1908         (LauncherWindow::cloneWindow):
1909         (LauncherWindow::createChrome):
1910         (main):
1911         * QtLauncher/webpage.cpp:
1912         (WebPage::WebPage):
1913         (WebPage::shouldInterruptJavaScript):
1914         * QtLauncher/webpage.h:
1915         (WebPage::setInterruptingJavaScriptEnabled):
1916
1917 2010-04-21  Eric Seidel  <eric@webkit.org>
1918
1919         Unreviewed, rolling out r57963.
1920         http://trac.webkit.org/changeset/57963
1921         https://bugs.webkit.org/show_bug.cgi?id=37759
1922
1923         Three tests started crashing on the Qt bot.
1924
1925         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1926         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1927
1928 2010-04-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1929
1930         Reviewed by Eric Seidel.
1931
1932         Make new-run-webkit-tests work for the Qt port
1933         https://bugs.webkit.org/show_bug.cgi?id=37588
1934
1935         * Scripts/webkitpy/layout_tests/port/qt.py:
1936
1937 2010-04-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1938
1939         Reviewed by Eric Seidel.
1940
1941         new-run-webkit-tests: try to detect alternate apache path
1942         https://bugs.webkit.org/show_bug.cgi?id=37587
1943
1944         _check_port_build() also needs to return true in the
1945         base implementation to not fail the check_build step.
1946
1947         * Scripts/webkitpy/layout_tests/port/webkit.py:
1948
1949 2010-04-21  Yi Shen  <yi.4.shen@nokia.com>
1950
1951         Reviewed by Simon Hausmann.
1952
1953         [Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
1954         https://bugs.webkit.org/show_bug.cgi?id=37759
1955
1956         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1957         (LayoutTestController::computedStyleIncludingVisitedInfo):
1958         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1959
1960 2010-04-21  Eric Seidel  <eric@webkit.org>
1961
1962         Unreviewed, test fix only.
1963
1964         new-run-webkit-tests: implement a --log trace message to be able to display detailed output of an individual test run
1965         https://bugs.webkit.org/show_bug.cgi?id=37726
1966
1967         This change seems to have broken a test.
1968         Attempting to handle the case where we don't have any
1969         timing information.  Dirk may have to correct this change.
1970
1971         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1972
1973 2010-04-19  Eric Seidel  <eric@webkit.org>
1974
1975         Reviewed by Adam Barth.
1976
1977         new-run-webkit-tests has much higher startup latency than run-webkit-tests
1978         https://bugs.webkit.org/show_bug.cgi?id=37643
1979
1980         I got rid of the -expected.checksum reads during startup.
1981         This makes startup noticably better on my laptop.
1982
1983         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1984          - Use image_hash() instead of .image_hash now that expected.checksum
1985            file reads are done lazily.
1986         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1987          - Add debug logging for this sleep call.
1988            In my testing I never saw this sleep() hit.
1989         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1990          - Sleep a shorter interval to make websocket server
1991            startup more responsive.  On my machine startup was
1992            taking around 1 second.
1993          - Remove the unconditional .5s delay on startup.
1994         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1995          - Make image_hash file reads done lazily in a new image_hash() function.
1996          - Add a "Starting testing ..." meter update after DRT threads have
1997            been started, but before we get updates from the first one.
1998          - Rename variable "t" to a full english name to match WebKit style.
1999
2000 2010-04-20  Daniel Bates  <dbates@rim.com>
2001
2002         Reviewed by Eric Seidel.
2003
2004         https://bugs.webkit.org/show_bug.cgi?id=37748
2005
2006         Make Sheriffbot more inspirational.
2007
2008         * Scripts/webkitpy/common/net/bugzilla.py:
2009         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2010         * Scripts/webkitpy/tool/bot/irc_command.py:
2011         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2012         * Scripts/webkitpy/tool/mocktool.py:
2013
2014 2010-04-20  Kent Tamura  <tkent@chromium.org>
2015
2016         Reviewed by Dimitri Glazkov.
2017
2018         [DRT/Chromium] Import Chromium image_diff as ImageDiff
2019         https://bugs.webkit.org/show_bug.cgi?id=37790
2020
2021         ImageDiff.cpp is based on tools/imagediff/image_diff.cc r41911 of Chromium.
2022
2023         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2024         * DumpRenderTree/chromium/ImageDiff.cpp: Added.
2025         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2026
2027 2010-04-20  Dirk Pranke <dpranke@chromium.org>
2028
2029         This patch to new-run-webkit-tests adds a --log 'trace' option
2030         that prints out detailed info about a given test as it executes
2031         (where the baselines are, what the expectation is, what we got,
2032         how long it took).
2033
2034         https://bugs.webkit.org/show_bug.cgi?id=37726
2035
2036         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2037           - use the newly exposed TestResult class and implement
2038             --log trace
2039         * Scripts/webkitpy/layout_tests/layout_package/dump_render_thread.py:
2040           - rename TestStats to TestResult and make it more public, resulting
2041             in cleaner code
2042         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2043           - add expectation_to_string() as a separate callable function
2044
2045 2010-04-20  Eric Seidel  <eric@webkit.org>
2046
2047         Unreviewed, rolling out r57907.
2048         http://trac.webkit.org/changeset/57907
2049         https://bugs.webkit.org/show_bug.cgi?id=37765
2050
2051         Appears to have broken MacEWS and possibly webkit-patch upload
2052         for svn users.  Needs further investigation.
2053
2054         * Scripts/webkitpy/common/checkout/api.py:
2055         * Scripts/webkitpy/common/checkout/api_unittest.py:
2056         * Scripts/webkitpy/common/checkout/changelog.py:
2057         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2058         * Scripts/webkitpy/common/checkout/commitinfo.py:
2059         * Scripts/webkitpy/common/checkout/scm.py:
2060         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2061         * Scripts/webkitpy/common/config/committers.py:
2062         * Scripts/webkitpy/common/net/bugzilla.py:
2063         * Scripts/webkitpy/common/net/buildbot.py:
2064         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2065         * Scripts/webkitpy/common/net/statusserver.py:
2066         * Scripts/webkitpy/common/prettypatch.py:
2067         * Scripts/webkitpy/common/system/autoinstall.py:
2068         * Scripts/webkitpy/common/system/deprecated_logging.py:
2069         * Scripts/webkitpy/common/system/executive.py:
2070         * Scripts/webkitpy/common/system/executive_unittest.py:
2071         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2072         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2073         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2074         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2075         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2076         * Scripts/webkitpy/tool/commands/queues.py:
2077         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2078         * Scripts/webkitpy/tool/commands/upload.py:
2079         * Scripts/webkitpy/tool/mocktool.py:
2080         * Scripts/webkitpy/tool/steps/abstractstep.py:
2081         * Scripts/webkitpy/tool/steps/postdiff.py:
2082         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
2083         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2084         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2085
2086 2010-04-20  Nate Chapin  <japhet@chromium.org>
2087
2088         Unreviewed.
2089
2090         Update my irc handle in committers.py (natechapin -> japhet).
2091
2092         * Scripts/webkitpy/common/config/committers.py:
2093
2094 2010-04-20  Eric Seidel  <eric@webkit.org>
2095
2096         Reviewed by Adam Barth.
2097
2098         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
2099         https://bugs.webkit.org/show_bug.cgi?id=37765
2100
2101         I fixed the queue to not ignore Tor as a reviwer in r57531,
2102         but instead it throws an exception every time his name is in a patch.
2103
2104         This fixes our Executive.run_command code to work around a Popen
2105         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
2106         do not correctly handle unicode objects as input or output to
2107         Popen.communicate.
2108
2109         Following the advice of:
2110         http://farmdev.com/talks/unicode/
2111         I'm attempting to take the python unicode plunge and use unicode()
2112         objects as strings instead of str() objects everywhere in webkitpy.
2113
2114         We do not have to use u"" instead of "" because u"a" == "a" as expected
2115         in Python.  Python will generate a warning to the console in cases where
2116         a unicode() == str() operation cannot be performed.
2117
2118         I also cleaned up the input handling in run_command a little by adding
2119         a new _compute_input() method which can return early instead of having
2120         such a long/cluttered if-block.
2121
2122         Executive.run* now correctly accept and return unicode() objects.
2123         I attempted to fix all the places that we call .write() to make sure we
2124         encode any unicode() objects into utf-8.
2125
2126         All places which use StringIO need to be sure to pass StringIO a
2127         pre-encoded byte-array (str object) instead of unicode so that
2128         clients which read from the StringIO don't have encoding exceptions.
2129         To make this easier, I removed the patch_file_object support from
2130         add_patch_to_bug, and changed the 4 places which previously used
2131         StringIO to create a fake patch file.
2132
2133         I attempted to document any places where we are not correctly converting
2134         to/from bytes (str() objects) to strings (unicode() objects).
2135
2136         * Scripts/webkitpy/common/checkout/api_unittest.py:
2137          - Read/write utf-8 files instead of ascii.
2138          - Update the tests to use test for proper unicode() handling.
2139         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2140          - Use unicode() strings instead of str() byte arrays.
2141         * Scripts/webkitpy/common/checkout/scm.py:
2142          - Remove use of str().
2143         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2144          - Read/write utf-8 files and use unicode() strings in testing.
2145         * Scripts/webkitpy/common/config/committers.py:
2146          - Use \u instead of \x to make slightly clearer what we're doing.
2147         * Scripts/webkitpy/common/net/bugzilla.py:
2148          - Add a new _string_contents() method and explain why
2149            we have to call unicode() on the result of soup.string
2150            and why it's safe to do so w/o needing to pass a codec name.
2151          - Remove the (unused) support for passing a file object to add_patch_to_bug().
2152         * Scripts/webkitpy/common/net/buildbot.py:
2153          - Use unicode() instead of str() when needing to coax a
2154            NavigableString object into a unicode() object.
2155         * Scripts/webkitpy/common/net/statusserver.py:
2156          - Remove use of str()
2157         * Scripts/webkitpy/common/prettypatch.py:
2158          - Write out the patch file as utf-8.
2159         * Scripts/webkitpy/common/system/autoinstall.py:
2160          - Add a FIXME about encoding.
2161         * Scripts/webkitpy/common/system/deprecated_logging.py:
2162          - Document that tee() works on bytes, not strings.
2163         * Scripts/webkitpy/common/system/executive.py:
2164          - Make run* properly take and return unicode() objects.
2165         * Scripts/webkitpy/common/system/executive_unittest.py:
2166          - Added a unit test to make sure we don't break Tor again!
2167         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2168          - Write out the test list as utf-8.
2169         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2170          - Write out json files as utf-8.
2171         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2172          - Add FIXME about encoding handling.
2173         * Scripts/webkitpy/tool/commands/upload.py:
2174          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
2175         * Scripts/webkitpy/tool/mocktool.py:
2176          - Rename add_patch_to_bug argument to match bugzilla.py
2177         * Scripts/webkitpy/tool/steps/postdiff.py:
2178          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
2179         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto.
2180         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto.
2181         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2182          - Fixed spurious logging seen when running test-webkitpy
2183
2184 2010-04-20  Chris Jerdonek  <cjerdonek@webkit.org>
2185
2186         Reviewed by Shinichiro Hamaji.
2187
2188         For check-webkit-style, implemented __eq__() and __ne__() (the
2189         built-in equality and inequality methods) for the
2190         DefaultStyleErrorHandler class.
2191
2192         https://bugs.webkit.org/show_bug.cgi?id=37850
2193
2194         This will facilitate unit-testing for a subsequent patch,
2195         namely for https://bugs.webkit.org/show_bug.cgi?id=37850
2196
2197         * Scripts/webkitpy/style/error_handlers.py:
2198           - Added __eq__() and __ne__() to the DefaultStyleErrorHandler
2199             class.
2200
2201         * Scripts/webkitpy/style/error_handlers_unittest.py:
2202           - Added unit tests for __eq__() and __ne__().
2203           - Also included a minor clean-up refactoring of combining the
2204             StyleErrorHandlerTestBase class (which has not needed to
2205             be separate due to previous changes) into the
2206             DefaultStyleErrorHandlerTest class.
2207
2208 2010-04-20  Jakub Wieczorek  <jwieczorek@webkit.org>
2209
2210         Unreviewed.
2211
2212         Add my IRC nick to the committers.py list.
2213
2214         * Scripts/webkitpy/common/config/committers.py:
2215
2216 2010-04-20  Kim Grönholm  <kim.gronholm@nomovok.com>
2217
2218         Reviewed by Simon Hausmann.
2219
2220         [Qt] Multitouch mocking in QtLauncher doesn't work with QGraphicsView
2221         https://bugs.webkit.org/show_bug.cgi?id=37816
2222         
2223         Fix multi-touch mocking in QtLauncher when using QGraphicsView.
2224         Test: https://bug-32434-attachments.webkit.org/attachment.cgi?id=44955
2225
2226         * QtLauncher/main.cpp:
2227         (LauncherWindow::eventFilter):
2228         (LauncherWindow::initializeView):
2229
2230 2010-04-20  MORITA Hajime <morrita@google.com>
2231
2232         Unreviewed, add myself to the committers list.
2233
2234         * Scripts/webkitpy/common/config/committers.py:
2235
2236 2010-04-20  Kent Tamura  <tkent@chromium.org>
2237
2238         Reviewed by Shinichiro Hamaji.
2239
2240         [DRT/Chromium] Fix some unexpected results of editing
2241         https://bugs.webkit.org/show_bug.cgi?id=37843
2242
2243         This change fixes about 70 unexpected results.
2244         The original test_webview_delegate.cc doesn't have this bug.
2245         The bug was introduced when I ported it to WebKit tree.
2246
2247         * DumpRenderTree/chromium/WebViewHost.cpp:
2248         (printRangeDescription): Replace the latter startContainer() with endContainer().
2249
2250 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2251
2252         Unreviewed, build fix.
2253
2254         Turn off some unit tests for now - the new-run-webkit-tests dryrun
2255         tests for chromium won't work if you don't have a chromium checkout.
2256
2257         https://bugs.webkit.org/show_bug.cgi?id=37841
2258
2259         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2260
2261 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2262
2263         Unreviewed, build fix.
2264
2265         (Re-)add dryrun.py; this was renamed from passing.py in the previous
2266         CL but apparently somehow didn't get checked in.
2267
2268         https://bugs.webkit.org/show_bug.cgi?id=37841
2269
2270         * Scripts/webkitpy/layout_tests/port/dryrun.py: Added.
2271
2272 2010-04-19  Shinichiro Hamaji  <hamaji@chromium.org>
2273
2274         Reviewed by David Levin.
2275
2276         check-webkit-style: exits when encountering a deleted file
2277         https://bugs.webkit.org/show_bug.cgi?id=37122
2278
2279         This reverts the quick fix done by r57119 and makes check_patch
2280         not call check_file for deleted files.
2281
2282         Also this change fixes the behavior for "-", which should mean
2283         stdin.  Before this change, the style checker just ignored "-"
2284         with a warning message.
2285
2286         * Scripts/webkitpy/style/checker.py:
2287         * Scripts/webkitpy/style/checker_unittest.py:
2288
2289 2010-04-19  Daniel Bates  <dbates@rim.com>
2290
2291         No review, rolling out 57868.
2292         http://trac.webkit.org/changeset/57868
2293         https://bugs.webkit.org/show_bug.cgi?id=37748
2294
2295         Sheriffbot wasn't very inspirational after this patch.
2296         Instead, he was silent when you said hi :-(. Rolling
2297         out this patch so that I can debug/test this some more.
2298
2299         * Scripts/webkitpy/common/net/bugzilla.py:
2300         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2301         * Scripts/webkitpy/tool/bot/irc_command.py:
2302         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2303         * Scripts/webkitpy/tool/mocktool.py:
2304
2305 2010-04-19  Daniel Bates  <dbates@rim.com>
2306
2307         Reviewed by Adam Barth.
2308
2309         https://bugs.webkit.org/show_bug.cgi?id=37748
2310
2311         Make Sheriffbot more inspirational.
2312
2313         * Scripts/webkitpy/common/net/bugzilla.py:
2314         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2315         * Scripts/webkitpy/tool/bot/irc_command.py:
2316         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2317         * Scripts/webkitpy/tool/mocktool.py:
2318
2319 2010-04-19  Kevin Ollivier  <kevino@theolliviers.com>
2320
2321         [wx] Build fix, add missing header.
2322
2323         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2324
2325 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2326  
2327          Reviewed by Adam Barth.
2328  
2329          new-run-webkit-tests - repurpose the "Passing" port as "Dryrun" port
2330          that can be used to test platforms other than the one you are running
2331          on. This can be useful for checking baselines and testing code
2332          coverage.
2333  
2334          Note that running the code on the "wrong" port requires each
2335          port-specific implementation to actually not require any
2336          platform-specific python code (e.g., the chromium-win port must
2337          test for the existence of windows functions before calling them).
2338  
2339          https://bugs.webkit.org/show_bug.cgi?id=37782
2340  
2341          * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2342          * Scripts/webkitpy/layout_tests/port/dryrun.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/port/passing.py.
2343          * Scripts/webkitpy/layout_tests/port/factory.py:
2344          * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2345
2346 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2347
2348         Reviewed by Eric Seidel.
2349
2350         new-run-webkit-tests: add --build (default) and --no-build
2351         options to make that step optional. This flag modifies what happens
2352         in port.check_build().
2353
2354         https://bugs.webkit.org/show_bug.cgi?id=37786
2355
2356         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2357         * Scripts/webkitpy/layout_tests/port/chromium.py:
2358         * Scripts/webkitpy/layout_tests/port/webkit.py:
2359
2360 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2361
2362         Unreviewed, build fix.
2363
2364         new-run-webkit-tests - fix a typo in r57480 that caused us to stop
2365         logging the actual list of unexpected results.
2366
2367         https://bugs.webkit.org/show_bug.cgi?id=37831
2368
2369         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2370
2371 2010-04-19  Dirk Pranke <dpranke@chromium.org>
2372
2373         Reviewed by Adam Barth.
2374
2375         From a patch by Tor Arne Vestbo  <tor.arne.vestbo@nokia.com>
2376
2377         new-run-webkit-tests: make the retry step more explicit
2378         https://bugs.webkit.org/show_bug.cgi?id=37606
2379
2380         It might be confusing to see the test and percent counters
2381         reset without any notice of what's going on, so we make the
2382         message that a retry-run is started explicit.
2383
2384         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2385
2386 2010-04-19  Sam Weinig  <weinig@apple.com>
2387
2388         Reviewed by Anders Carlsson.
2389
2390         Add support for opening a new window (File->New Window) to
2391         Windows MiniBrowser. Accelerator doesn't work.
2392
2393         * MiniBrowser/win/BrowserView.cpp:
2394         (createNewPage): Use BrowserView::create.
2395         * MiniBrowser/win/BrowserWindow.cpp:
2396         (BrowserWindow::onCommand): Respond to ID_FILE_NEW_WINDOW
2397         by creating a new window.
2398         * MiniBrowser/win/BrowserWindow.h:
2399         (BrowserWindow::create): Added. Don't allow creating
2400         BrowserWindows on the stack by making constructor
2401         private and exposing the create function.
2402         * MiniBrowser/win/MiniBrowser.cpp:
2403         (MiniBrowser::createNewWindow): Move new window creation
2404         logic here.
2405         * MiniBrowser/win/MiniBrowser.h:
2406         * MiniBrowser/win/MiniBrowser.rc: 
2407         * MiniBrowser/win/main.cpp:
2408         (_tWinMain): Use the new MiniBrowser::createNewWindow().
2409
2410 2010-04-19  Chris Fleizach  <cfleizach@apple.com>
2411
2412         Reviewed by Beth Dakin.
2413
2414         AX: aria-haspopup needs to be exposed
2415         https://bugs.webkit.org/show_bug.cgi?id=37808
2416
2417         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2418         (AccessibilityUIElement::hasPopup):
2419
2420 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2421
2422         Reviewed by Eric Seidel.
2423
2424         Submit a better workaround for r57806 than the one in r57831 - log
2425         an error and exit if you try to run new-run-webkit-tests with --use-drt
2426         on Windows.
2427
2428         https://bugs.webkit.org/show_bug.cgi?id=37822
2429
2430         * Scripts/webkitpy/layout_tests/port/chromium.py:
2431
2432 2010-04-19  Jesus Sanchez-Palencia  <jesus@webkit.org>
2433
2434         Unreviewed.
2435
2436         Just adding myself as a committer.
2437
2438         * Scripts/webkitpy/common/config/committers.py:
2439
2440 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2441
2442         Reviewed by Eric Seidel.
2443
2444         Add slightly better logging to the websocket python wrapper script,
2445         including a --verbose flag for debug output.
2446
2447         https://bugs.webkit.org/show_bug.cgi?id=37233
2448
2449         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2450         * Scripts/new-run-webkit-websocketserver:
2451
2452 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2453
2454         Reviewed by Eric Seidel.
2455
2456         new-run-webkit-tests: add a way (--print-unexpected-results) to
2457         (re-)print out the tests that produced unexpected results in the
2458         last run. Also add a way (--retry-unexpected-results) to
2459         automatically re-test them.
2460
2461         https://bugs.webkit.org/show_bug.cgi?id=37783
2462
2463         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2464
2465 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2466
2467         Reviewed by Eric Seidel.
2468
2469         Restructure the logging in new-run-webkit-tests so that many of log
2470         messages that were logged to the MeteredStream also get logged in
2471         --verbose mode.
2472
2473         https://bugs.webkit.org/show_bug.cgi?id=37780
2474
2475         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2476         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2477
2478 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2479
2480         Reviewed by Eric Seidel.
2481
2482         new-run-webkit-tests: add 'summary' and 'unexpected-results' options
2483         to the --log flag. Also add a 'progress' flag to enable the regular
2484         progress bar (as opposed to 'detailed-progress', which enables the
2485         dots). Also add a 'nothing' flag to allow you to be explicit that
2486         you don't want any logging on the command line.
2487
2488         The default is
2489         '--log detailed-progress,summary,unexpected,unexpected-results'
2490
2491         (The default logging is unchanged by this patch, this just makes things
2492         properly configurable).
2493
2494         Note that 'nothing' doesn't work properly yet; I need a couple other
2495         patches to land to avoid rewriting things several different ways.
2496
2497         https://bugs.webkit.org/show_bug.cgi?id=37785
2498
2499         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2500
2501 2010-04-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2502
2503         Reviewed by Simon Hausmann.
2504
2505         Make the URL change on committed load.
2506
2507         * QtLauncher/mainwindow.cpp:
2508         (MainWindow::buildUI):
2509         (MainWindow::setAddressUrl):
2510         * QtLauncher/mainwindow.h:
2511
2512 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2513
2514         Reviewed by Eric Seidel.
2515
2516         Fix a typo in the rebaselining tool that causes us to use "debug"
2517         instead of "Debug" in a directory path, which fails on platforms with
2518         case-sensitive filesystems.
2519
2520         https://bugs.webkit.org/show_bug.cgi?id=37819
2521
2522         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2523
2524 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2525
2526         Unreviewed, build fix.
2527
2528         Fix breakage of chromium-win canary bots caused by r57806. That patch
2529         introduced the option of using Chrome's new port of DumpRenderTree,
2530         but unfortunately that port relies on the webkit.py class
2531         implementation which uses non-blocking I/O that isn't available on
2532         Windows. This patch turns off that option and doesn't import the
2533         class if we're running on Windows.
2534
2535         https://bugs.webkit.org/show_bug.cgi?id=37817
2536
2537         * Scripts/webkitpy/layout_tests/port/chromium.py:
2538
2539 2010-04-19  James Robinson  <jamesr@chromium.org>
2540
2541         Reviewed by abarth.
2542
2543         Fix a typo
2544
2545         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2546
2547 2010-04-19  Adam Roben  <aroben@apple.com>
2548
2549         Fix run-webkit-tests when there are spaces in the path
2550
2551         Fixes <http://webkit.org/b/37809>
2552
2553         Reviewed by Adam Barth.
2554
2555         * Scripts/run-webkit-tests: Use an "indirect object" to specify the
2556         path to the harness to exec(). According to perldoc, this usage will
2557         prohibit perl from parsing the arguments to exec() via the shell,
2558         which would incorrectly split paths with spaces in them, etc.
2559
2560 2010-04-19  Dimitri Glazkov  <dglazkov@chromium.org>
2561
2562         Reviewed by Adam Roben.
2563
2564         WinLauncher.h should use LF line-endings and use native line-endings style.
2565         https://bugs.webkit.org/show_bug.cgi?id=37807
2566
2567         * WinLauncher/WinLauncher.h: Added property svn:eol-style, converted to LF line-endings.
2568
2569 2010-04-19  Kent Tamura  <tkent@chromium.org>
2570
2571         Reviewed by Shinichiro Hamaji.
2572
2573         [DRT/Chromium] Fix a test initialization problem
2574         https://bugs.webkit.org/show_bug.cgi?id=37791
2575
2576         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2577         (runTest): Call resetTestController() before runFileTest(). Some
2578           controllers initialize their fields in reset() and not in their
2579           constructors.
2580
2581 2010-04-19  Kent Tamura  <tkent@chromium.org>
2582
2583         Reviewed by Eric Seidel.
2584
2585         [Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt
2586         https://bugs.webkit.org/show_bug.cgi?id=37793
2587
2588         We need to use WebKitDriver instead of ChromiumDriver for Chromium
2589         DRT because its interface is different from test_shell.
2590
2591         Chromium DRT has no UI.  So we can't use it to show test results.
2592
2593         * Scripts/webkitpy/layout_tests/port/chromium.py:
2594
2595 2010-04-18  Eric Seidel  <eric@webkit.org>
2596
2597         Reviewed by Adam Roben.
2598
2599         Make failure-reason more forgiving
2600         https://bugs.webkit.org/show_bug.cgi?id=37525
2601
2602         Removed search_limit, which wasn't very useful anyway.
2603         Added a log about the long load time loading from the builders.
2604         Prompt the user for what revision to start walking from (makes it easy to restart upon failure).
2605
2606         * Scripts/webkitpy/common/net/buildbot.py:
2607         * Scripts/webkitpy/tool/commands/queries.py:
2608
2609 2010-04-18  Chris Jerdonek  <cjerdonek@webkit.org>
2610
2611         Reviewed by Shinichiro Hamaji.
2612
2613         Created a class for check-webkit-style that encapsulates iterating
2614         over text files and reading them.
2615
2616         https://bugs.webkit.org/show_bug.cgi?id=37754
2617
2618         This revision is an intermediate step towards separating our
2619         style-checking code from the logic of iterating over files and
2620         reading them.
2621
2622         * Scripts/webkitpy/common/system/logtesting.py:
2623           - Added a logMessages() method to the LoggingTestCase class.
2624             This method provides unit tests with access to the raw list
2625             of log messages in case the tester needs to do something more
2626             than simply assert the list of existing messages.
2627
2628         * Scripts/webkitpy/style/checker.py:
2629           - Added a ProcessorBase class that processors of lists of lines
2630             should eventually inherit from.
2631           - Also added a FIXME to use the ProcessorBase class and the
2632             TextFileReader class added below.
2633
2634         * Scripts/webkitpy/style/filereader.py: Added.
2635           - Created a TextFileReader class that encapsulates reading
2636             and iterating over text files.
2637
2638         * Scripts/webkitpy/style/filereader_unittest.py: Added.
2639           - Added a TextFileReaderTest class to unit-test the
2640             new TextFileReader class.
2641
2642 2010-04-15  Tony Chang  <tony@chromium.org>
2643
2644         Reviewed by Adam Barth.
2645
2646         [chromium] new-run-webkit-tests should be able to use chromium DRT
2647         https://bugs.webkit.org/show_bug.cgi?id=37645
2648
2649         Make sure that the lack of a chromium checkout doesn't cause the script to
2650         fail.
2651
2652         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2653         * Scripts/webkitpy/layout_tests/port/chromium.py:
2654         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths
2655             to be relative to an upstream output dir.
2656         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag.
2657
2658 2010-04-18  Eric Seidel  <eric@webkit.org>
2659
2660         Unreviewed, fixing the Qt bot.
2661
2662         Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
2663         https://bugs.webkit.org/show_bug.cgi?id=37632
2664
2665         * Scripts/run-webkit-tests:
2666          - Exit non-zero of launching the harness fails.
2667
2668 2010-04-18  Eric Seidel  <eric@webkit.org>
2669
2670         Unreviewed, fixing the Qt bot.
2671
2672         Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
2673         https://bugs.webkit.org/show_bug.cgi?id=37632
2674
2675         * Scripts/run-webkit-tests:
2676          - Fix the wrapper to work for users who do not
2677            have WebKitTools/Scripts in their path.
2678
2679 2010-04-14  Eric Seidel  <eric@webkit.org>
2680
2681         Reviewed by Adam Barth.
2682
2683         Add a layer of indirection when calling run-webkit-tests to
2684         allow testing new-run-webkit-tests on various platforms.
2685         https://bugs.webkit.org/show_bug.cgi?id=37632
2686
2687         This will let us test and fix bugs in new-run-webkit-tests
2688         without needing to restart the buildbot master between tests.
2689
2690         Currently this change leaves run-webkit-tests as-is, but once
2691         its landed we will easily be able to turn on/off
2692         new-run-webkit-tests for various ports/configurations.
2693
2694         I will send a note out to webkit-dev about how we will
2695         be using this launcher script to test on the bots.
2696
2697         * Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests.
2698         * Scripts/run-webkit-tests:
2699          - A new script which decides whether to run new- or old-
2700            run-webkit-tests based on the platform.
2701         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2702          - Add some dummy argument handling for arguments which
2703            old-run-webkit-tests supports but new-run-webkit-tests
2704            does not yet.
2705
2706 2010-04-18  Eric Seidel  <eric@webkit.org>
2707
2708         Reviewed by Adam Barth.
2709
2710         Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
2711         https://bugs.webkit.org/show_bug.cgi?id=33295
2712
2713         The Gtk builders have been green every time I've looked
2714         at them in the last 5 days or so.  It would appear webkit
2715         is now keeping them green and we should update the core
2716         builder list to match reality.
2717
2718         * Scripts/webkitpy/common/net/buildbot.py:
2719         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2720
2721 2010-04-18  Robert Hogan  <robert@webkit.org>
2722
2723         Reviewed by Simon Hausmann.
2724
2725         [Qt] Add support for LayoutTestController commands:
2726                    setSmartInsertDeleteEnabled
2727                    setSelectTrailingWhitespaceEnabled
2728                    execCommand
2729                    isCommandEnabled
2730
2731         https://bugs.webkit.org/show_bug.cgi?id=35844
2732
2733         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2734         (WebCore::WebPage::resetSettings):
2735         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2736         (LayoutTestController::setSmartInsertDeleteEnabled):
2737         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
2738         (LayoutTestController::execCommand):
2739         (LayoutTestController::isCommandEnabled):
2740         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2741
2742 2010-04-17  Adam Barth  <abarth@webkit.org>
2743
2744         Reviewed by Eric Seidel.
2745
2746         Remove steps_references and commands_references
2747         https://bugs.webkit.org/show_bug.cgi?id=37758
2748
2749         We tried using the mumble_references convention to manage our
2750         dependencies, but it doesn't seem to be providing much value for the
2751         steps and commands module because these modules are small pieces of the
2752         larger tool module.  In this patch, I've removed the references file
2753         for these modules.
2754  
2755         I've left the style_references file for the style module because that
2756         module seems better isolated from the rest of webkitpy and the
2757         style_references file appears to be providing some value.
2758
2759         * Scripts/webkitpy/tool/commands/commandtest.py:
2760         * Scripts/webkitpy/tool/commands/download_unittest.py:
2761         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2762         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2763         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2764         * Scripts/webkitpy/tool/commands/queuestest.py:
2765         * Scripts/webkitpy/tool/commands/upload.py:
2766         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2767         * Scripts/webkitpy/tool/commands_references.py: Removed.
2768         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2769         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2770         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2771         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
2772         * Scripts/webkitpy/tool/steps_references.py: Removed.
2773
2774 2010-04-17  Eric Seidel  <eric@webkit.org>
2775
2776         Reviewed by Adam Barth.
2777
2778         WebKit needs a Chromium Mac EWS Builder
2779         https://bugs.webkit.org/show_bug.cgi?id=37742
2780
2781         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2782
2783 2010-04-17  Adam Barth  <abarth@webkit.org>
2784
2785         Fix expected results for unit test broken by
2786         http://trac.webkit.org/changeset/57772
2787
2788         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2789
2790 2010-04-17  Sam Weinig  <weinig@apple.com>
2791
2792         Reviewed by Adam Roben.
2793
2794         Teach windows MiniBrowser how to work with window.open()
2795         and targeted links.
2796
2797         * MiniBrowser/win/BrowserView.cpp:
2798         (createNewPage): Create a new BrowserWindow and return its page.
2799         (showPage): Show the page.
2800         (closePage): Empty implementation.
2801         (runJavaScriptAlert): Empty implementation.
2802         (BrowserView::create): Register a UIClient.
2803         * MiniBrowser/win/BrowserView.h:
2804         (BrowserView::webView): Added.
2805         Change create to take a BrowserWindow instead of an HWND.
2806
2807         * MiniBrowser/win/BrowserWindow.cpp:
2808         (BrowserWindow::wndProc): Respond to WM_NCDESTROY.
2809         (BrowserWindow::goToURL): Added. Forwards to BrowserView.
2810         (BrowserWindow::onCreate): Don't always go to the default
2811         url. Let the caller do this.
2812         (BrowserWindow::onNCDestroy): Delete the window.
2813         * MiniBrowser/win/BrowserWindow.h:
2814         (BrowserWindow::view): Added.
2815         (BrowserWindow::window): Added.
2816
2817         * MiniBrowser/win/main.cpp:
2818         (_tWinMain):
2819         Go to the default URL for the initial page. Allocate the initial
2820         window on the heap for correctness.
2821
2822 2010-04-16  Adam Roben  <aroben@apple.com>
2823
2824         Add the Windows Debug (Test) builder to the list of core builders
2825
2826         It's been green for a few days now, and all the known Windows
2827         flakiness is Release-only.
2828
2829         Rubber-stamped by Mark Rowe.
2830
2831         * Scripts/webkitpy/common/net/buildbot.py:
2832         (BuildBot.core_builder_name_regexps): Added a regular expression to
2833         match the "Windows Debug (Test)" builder.
2834
2835 2010-04-16  Sam Weinig  <sam@webkit.org>
2836
2837         Reviewed by Anders Carlsson.
2838
2839         Fix window.open() and targeted links.
2840
2841         * MiniBrowser/mac/BrowserWindowController.m:
2842         (_createNewPage): Use the correct initializer to and load the window.
2843
2844 2010-04-16  Adam Roben  <aroben@apple.com>
2845
2846         Fix links to layout test results from build status pages
2847
2848         Reviewed by Mark Rowe.
2849
2850         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2851         (ExtractTestResults.finished): Prepend "/" on the URL of the test
2852         results page so that it is treated as an absolute URL.
2853
2854 2010-04-16  Tony Chang  <tony@chromium.org>
2855
2856         Reviewed by Dimitri Glazkov.
2857
2858         [chromium] build DRT on Linux
2859         https://bugs.webkit.org/show_bug.cgi?id=37690
2860
2861         * Scripts/build-dumprendertree: Add support for win and linux
2862
2863 2010-04-16  Sam Weinig  <weinig@apple.com>
2864
2865         Reviewed by Adam Roben.
2866
2867         Use the threaded process model for MiniBrowser if holding down
2868         the shift key on startup.
2869
2870         * MiniBrowser/win/BrowserView.cpp:
2871         (BrowserView::create): 
2872
2873 2010-04-15  Tony Chang  <tony@chromium.org>
2874
2875         Reviewed by Dimitri Glazkov.
2876
2877         [chromium] Add TestShellGtk.cpp so we can link on Linux
2878         https://bugs.webkit.org/show_bug.cgi?id=37561
2879
2880         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add new file and
2881             add platform file exceptions.
2882         * DumpRenderTree/chromium/TestShellGtk.cpp: Added.
2883         (AlarmHandler):
2884         (TestShell::waitTestFinished):
2885
2886 2010-04-15  Tony Chang  <tony@chromium.org>
2887
2888         Reviewed by Dimitri Glazkov.
2889
2890         build DRT on chromium mac
2891         https://bugs.webkit.org/show_bug.cgi?id=37639
2892
2893         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2894         * Scripts/build-dumprendertree: enable build-dumprendertree --chromium
2895
2896 2010-04-15  Kent Tamura  <tkent@chromium.org>
2897
2898         Reviewed by Dimitri Glazkov.
2899
2900         [DRT/Chromium] Add LayoutTestHelper for Mac
2901         https://bugs.webkit.org/show_bug.cgi?id=37668
2902
2903         LayouTestHelper.mm is based on webkit/tools/test_shell/mac/layout_test_helper.mm
2904         of Chromium.
2905
2906         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2907         * DumpRenderTree/chromium/LayoutTestHelper.mm: Added.
2908
2909 2010-04-15  Alexey Proskuryakov  <ap@apple.com>
2910
2911         Reviewed by Geoff Garen.
2912
2913         https://bugs.webkit.org/show_bug.cgi?id=37494
2914         <rdar://problem/7857060> REGRESSION (r57340): fast/events/mouse-drag-from-frame-to-other-frame.html
2915         fails on Windows
2916
2917         * DumpRenderTree/win/EventSender.cpp: (makeEventSender):
2918         * DumpRenderTree/win/EventSender.h:
2919         Tell EventSender if it's being created for a top frame.
2920         
2921         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2922         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): We only want to reset
2923         EventSender machinery when a new test is loaded, not when an iframe (or just its global
2924         object) is created.
2925
2926 2010-04-15  Adam Roben  <aroben@apple.com>
2927
2928         Fix Windows WebKit2 build.
2929
2930         * MiniBrowser/win/MiniBrowser.cpp:
2931
2932 2010-04-15  Ojan Vafai  <ojan@chromium.org>
2933
2934         Reviewed by Adam Barth.
2935
2936         Include codereview issue number in patch description
2937         https://bugs.webkit.org/show_bug.cgi?id=37677
2938
2939         This lets us know which rietveld issue this patch is tied to.
2940
2941         Also, make it so that --fancy-review overrides --no-review.
2942
2943         * Scripts/webkitpy/tool/steps/postcodereview.py:
2944         * Scripts/webkitpy/tool/steps/postdiff.py:
2945
2946 2010-04-15  Adam Roben  <aroben@apple.com>
2947
2948         Make --exit-after-n-failures work when all tests are timing out or crashing
2949
2950         Fixes <http://webkit.org/b/37679>.
2951
2952         Reviewed by Jon Honeycutt.
2953
2954         * Scripts/run-webkit-tests:
2955         (top level): When a test crashes or times out, break out of the main loop if
2956         stopRunningTestsEarlyIfNeeded returns true. Moved some code from the bottom of the main loop
2957         from here...
2958         (stopRunningTestsEarlyIfNeeded): ...to here.
2959
2960 2010-04-15  Sam Weinig  <sam@webkit.org>
2961
2962         Reviewed by Anders Carlsson.
2963
2964         Add WebHistoryClient support.
2965         https://bugs.webkit.org/show_bug.cgi?id=37671
2966
2967         Add HistoryClient logging.
2968
2969         * MiniBrowser/mac/BrowserWindowController.m:
2970         (_didNavigateWithNavigationData):
2971         (_didPerformClientRedirect):
2972         (_didPerformServerRedirect):
2973         (_didUpdateHistoryTitle):
2974         (-[BrowserWindowController awakeFromNib]):
2975
2976 2010-04-15  Anders Carlsson  <andersca@apple.com>
2977
2978         Reviewed by Sam Weinig.
2979
2980         Start the mini browser in threaded mode if shift is pressed during startup.
2981         https://bugs.webkit.org/show_bug.cgi?id=37670
2982
2983         * MiniBrowser/mac/AppDelegate.m:
2984         (-[BrowserAppDelegate init]):
2985
2986 2010-04-15  Chris Fleizach  <cfleizach@apple.com>
2987
2988         Reviewed by Beth Dakin.
2989
2990         AXHelp is being appended from ancestors incorrectly
2991         https://bugs.webkit.org/show_bug.cgi?id=37659
2992
2993         * DumpRenderTree/AccessibilityUIElement.cpp:
2994         (getHelpTextCallback):
2995         (AccessibilityUIElement::getJSClass):
2996         * DumpRenderTree/AccessibilityUIElement.h:
2997         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2998         (AccessibilityUIElement::helpText):
2999         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3000         (AccessibilityUIElement::helpText):
3001         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3002         (AccessibilityUIElement::helpText):
3003
3004 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
3005
3006         Reviewed by Adam Barth.
3007
3008         Re-format run-webkit-tests to fit in 80-columns for PEP-8 compliance.
3009         (broken by r57463 and r57381, at least). I've also filed bug 37477
3010         to fix check-webkit-style to catch these things.
3011
3012         https://bugs.webkit.org/show_bug.cgi?id=38586
3013
3014         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3015
3016 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
3017
3018         Reviewed by Dimitri Glazkov.
3019
3020         Add a way to override the user-visible name for the test binary since
3021         some ports don't call it DumpRenderTree (e.g., Chromium Win uses
3022         test_shell, Chromium Mac uses TestShell) by adding a driver_name()
3023         method to the Port interface.
3024
3025         https://bugs.webkit.org/show_bug.cgi?id=37631
3026
3027         * Scripts/webkitpy/layout_tests/port/base.py:
3028         * Scripts/webkitpy/layout_tests/port/chromium.py:
3029         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3030         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3031
3032 2010-04-14  Anders Carlsson  <andersca@apple.com>
3033
3034         Reviewed by Adam Roben.
3035
3036         Add "Force Repaint" to debug menu.
3037         https://bugs.webkit.org/show_bug.cgi?id=37627
3038
3039         * MiniBrowser/mac/BrowserWindowController.h:
3040         * MiniBrowser/mac/BrowserWindowController.m:
3041         (-[BrowserWindowController forceRepaint:]):
3042         * MiniBrowser/mac/English.lproj/MainMenu.xib:
3043
3044 2010-04-15  Sam Weinig  <sam@webkit.org>
3045
3046         Reviewed by Adam Roben.
3047
3048         Add debug-minibrowser script.
3049
3050         * Scripts/debug-minibrowser: Copied from Scripts/run-minibrowser.
3051         * Scripts/webkitdirs.pm:
3052
3053 2010-04-15  Roland Steiner  <rolandsteiner@chromium.org>
3054  
3055         Reviewed by Dimitri Glazkov.
3056
3057         Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
3058         https://bugs.webkit.org/show_bug.cgi?id=37636
3059  
3060         Second patch: add Windows-specific implementation parts
3061         of TestShell.
3062
3063         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3064         * DumpRenderTree/chromium/TestShell.h:
3065         (TestShell::finishedEvent):
3066         * DumpRenderTree/chromium/TestShellWin.cpp:
3067         (watchDogThread):
3068         (TestShell::waitTestFinished):
3069
3070 2010-04-15  Roland Steiner  <rolandsteiner@chromium.org>
3071
3072         Reviewed by Dimitri Glazkov.
3073
3074         Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
3075         https://bugs.webkit.org/show_bug.cgi?id=37636
3076
3077         First patch: fix compiler errors.
3078
3079         * DumpRenderTree/chromium/EventSender.cpp:
3080         (EventSender::reset):
3081         (EventSender::dispatchMessage):
3082         * DumpRenderTree/chromium/LayoutTestController.cpp:
3083         (LayoutTestController::pathToLocalResource):
3084         * DumpRenderTree/chromium/TestWebWorker.h:
3085         * DumpRenderTree/chromium/TextInputController.cpp:
3086         * DumpRenderTree/chromium/WebViewHost.h:
3087         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3088
3089 2010-04-14  Luiz Agostini  <luiz.agostini@openbossa.org>
3090
3091         Reviewed by Simon Hausmann.
3092
3093         [Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
3094         https://bugs.webkit.org/show_bug.cgi?id=37622
3095
3096         Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
3097         (bug 35844). Moving it back.
3098
3099         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3100         (LayoutTestController::setViewModeMediaFeature):
3101
3102 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
3103
3104         Reviewed by Adam Barth.
3105
3106         Add some very minimal unit tests for new-run-webkit-tests. This should
3107         be enough to catch egregious brokenness like syntax errors and import
3108         declaration issues.
3109
3110         https://bugs.webkit.org/show_bug.cgi?id=37432
3111
3112         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3113         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Added.
3114
3115 2010-04-14  Brian Weinstein  <bweinstein@apple.com>
3116
3117         Reviewed by Adam Roben.
3118
3119         Add a way for the buildbot to kill any old processes that are running. This
3120         is useful because the Windows bots can get in states where a process remains
3121         running (httpd.exe, DumpRenderTree.exe), which causes the bots to get in a red
3122         state, and the processes must be killed manually.
3123
3124         * BuildSlaveSupport/build.webkit.org-config/master.cfg: If we are on Windows, kill
3125             the old processes that might be running.
3126         * BuildSlaveSupport/win/kill-old-processes: Added.
3127
3128 2010-04-14  Sam Weinig  <sam@webkit.org>
3129
3130         Reviewed by Anders Carlsson.
3131
3132         Tear down WebKit more completely on window closing and application
3133         termination. We still don't block application termination for pending
3134         close, but this is a step in the right direction.
3135
3136         * MiniBrowser/mac/AppDelegate.m:
3137         (-[BrowserAppDelegate applicationWillTerminate:]):
3138         * MiniBrowser/mac/BrowserWindowController.h:
3139         * MiniBrowser/mac/BrowserWindowController.m:
3140         (-[BrowserWindowController dealloc]):
3141         (-[BrowserWindowController windowWillClose:]):
3142         (-[BrowserWindowController applicationTerminating]):
3143
3144 2010-04-14  Adam Barth  <abarth@webkit.org>
3145
3146         Reviewed by Eric Seidel.
3147
3148         Use pretty patch for confirming webkit-patch diffs
3149         https://bugs.webkit.org/show_bug.cgi?id=37489
3150
3151         * Scripts/webkitpy/common/prettypatch.py: Added.
3152         * Scripts/webkitpy/tool/commands/download_unittest.py:
3153         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3154         * Scripts/webkitpy/tool/mocktool.py:
3155         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3156
3157 2010-04-14  Eric Seidel  <eric@webkit.org>
3158
3159         Reviewed by Adam Barth.
3160
3161         Teach webkit-patch how to handle revisions missing ChangeLogs
3162         https://bugs.webkit.org/show_bug.cgi?id=37519
3163
3164         Make commit_info_for_revision return None when revision
3165         is missing a ChangeLog.  Previously we would throw an array index
3166         exception.
3167         Teach callers how to handle None.
3168
3169         * Scripts/webkitpy/common/checkout/api.py:
3170         * Scripts/webkitpy/common/checkout/api_unittest.py:
3171         * Scripts/webkitpy/tool/commands/download.py:
3172         * Scripts/webkitpy/tool/commands/queries.py:
3173         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3174
3175 2010-04-13  Eric Seidel  <eric@webkit.org>
3176
3177         Reviewed by Adam Roben.
3178
3179         Add Qt Bot to the list of "core builders" (builders which block the commit-queue when red)
3180         https://bugs.webkit.org/show_bug.cgi?id=33297
3181
3182         This is an experiment.  The bots have been green for
3183         a while.  We'll see if adding them under sheriff-bot protection
3184         will keep them green.
3185
3186         * Scripts/webkitpy/common/net/buildbot.py:
3187         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3188
3189 2010-04-13  Eric Seidel  <eric@webkit.org>
3190
3191         Unreviewed, just fixing a constant in the Rietveld unit test.
3192
3193         * Scripts/webkitpy/common/net/rietveld_unittest.py
3194
3195 2010-04-13  Eric Seidel  <eric@webkit.org>
3196
3197         Unreviewed, just adding missing Mock to fix python tests.
3198
3199         * Scripts/webkitpy/tool/mocktool.py:
3200
3201 2010-04-13  Ojan Vafai  <ojan@chromium.org>
3202
3203         Reviewed by David Levin.
3204
3205         Add experimental prototype Rietveld integration to webkit-patch upload
3206         https://bugs.webkit.org/show_bug.cgi?id=37418
3207
3208         This patch adds bare-bones integration with Rietveld for code reviews.
3209         The behavior is hidden behind the --fancy-review command line flag.
3210         Currently, there's no support for uploading more than one patch per
3211         issue (which is a nice feature of Rietveld).  The plan is to play with
3212         this for a bit and see if it's useful.
3213
3214         Modified from Adam's original patch to autoinstall the rietveld upload script.
3215
3216         * Scripts/webkitpy/common/config/__init__.py:
3217         * Scripts/webkitpy/common/net/rietveld.py: Added.
3218         * Scripts/webkitpy/common/net/rietveld_unitttest.py: Added.
3219         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3220         * Scripts/webkitpy/tool/commands/upload.py:
3221         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3222         * Scripts/webkitpy/tool/main.py:
3223         * Scripts/webkitpy/tool/mocktool.py:
3224         * Scripts/webkitpy/tool/steps/__init__.py:
3225         * Scripts/webkitpy/tool/steps/options.py:
3226         * Scripts/webkitpy/tool/steps/postcodereview.py: Added.
3227         * Scripts/webkitpy/tool/steps/postdiff.py:
3228
3229 2010-04-13  Sam Weinig  <sam@webkit.org>
3230
3231         Rubber-stamped by Mark Rowe.
3232
3233         Add Makefile to MiniBrowser.
3234
3235         * MiniBrowser/Makefile: Added.
3236
3237 2010-04-13  Eric Seidel  <eric@webkit.org>
3238
3239         Unreviewed, just adding a sanity check.
3240
3241         Add check to make sure commit-queue can never commit too short a message
3242         https://bugs.webkit.org/show_bug.cgi?id=37528
3243
3244         The commit-queue made bogus messages here:
3245         http://trac.webkit.org/changeset/57532
3246         http://trac.webkit.org/changeset/57534
3247
3248         This was a regression caused by adding unicode parsing for
3249         our ChangeLog files.  Popen does not seem to play nice with
3250         unicode strings.
3251
3252         I'm also adding an "assert" to make sure short ChangeLogs never happen again.
3253
3254         * Scripts/webkitpy/common/system/executive.py:
3255          - Cast input to strings before passing to POpen
3256         * Scripts/webkitpy/tool/steps/commit.py:
3257          - Validate that commit messages are not to short.
3258
3259 2010-04-13  Adam Roben  <aroben@apple.com>
3260
3261         Robustify new-run-webkit-tests against paths with spaces in them
3262
3263         Reviewed by Eric Seidel.
3264
3265         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3266         (LayoutTestApacheHttpd.__init__): Quote all paths that we pass to
3267         Apache to ensure that paths with spaces in them are interpreted
3268         correctly.
3269
3270 2010-04-13  Csaba Osztrogonác  <ossy@webkit.org>
3271
3272         Unreviewed buildfix after r57537.
3273
3274         * DumpRenderTree/qt/LayoutTestControllerQt.h: Declaration of removeOriginAccessWhitelistEntry() added.
3275
3276 2010-04-13  Sam Weinig  <sam@webkit.org>
3277
3278         Reviewed by Maciej Stachowiak.
3279
3280         Make building new webkit API and MiniBrowser a little easier.
3281
3282         * Scripts/build-webkit: Make building with --webkit2 build the 
3283         MiniBrowser as well and tell you how to use it.
3284         * Scripts/run-minibrowser: Copied from Scripts/run-safari.
3285         * Scripts/webkitdirs.pm: Add runMiniBrowser function.
3286
3287 2010-04-12  Timothy Hatcher  <timothy@apple.com>
3288
3289         SecurityOrigin needs a way to remove individual OriginAccessEntries
3290         https://bugs.webkit.org/show_bug.cgi?id=37449
3291
3292         Reviewed by Dave Hyatt.
3293
3294         * DumpRenderTree/LayoutTestController.cpp:
3295         (removeOriginAccessWhitelistEntryCallback): Added. Call LayoutTestController::removeOriginAccessWhitelistEntry.
3296         (LayoutTestController::staticFunctions): Added removeOriginAccessWhitelistEntry.
3297         * DumpRenderTree/LayoutTestController.h:
3298         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3299         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3300         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3301         (LayoutTestController::removeOriginAccessWhitelistEntry): Added.
3302         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3303         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3304         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3305         (LayoutTestController::removeOriginAccessWhitelistEntry): Added.
3306         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3307         (LayoutTestController::whiteListAccessFromOrigin): FIXME to implement.
3308         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3309
3310 2010-04-13  Timothy Hatcher  <timothy@apple.com>
3311
3312         Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
3313         And LayoutTestController.whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
3314         And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
3315
3316         SecurityOrigin needs a way to remove individual OriginAccessEntries
3317         https://bugs.webkit.org/show_bug.cgi?id=37449
3318
3319         Reviewed by Dave Hyatt.
3320
3321         * DumpRenderTree/LayoutTestController.cpp:
3322         (addOriginAccessWhitelistEntryCallback):
3323         (LayoutTestController::staticFunctions):
3324         * DumpRenderTree/LayoutTestController.h:
3325         * DumpRenderTree/chromium/LayoutTestController.cpp:
3326         (LayoutTestController::LayoutTestController):
3327         (LayoutTestController::addOriginAccessWhitelistEntry):
3328         * DumpRenderTree/chromium/LayoutTestController.h:
3329         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3330         (LayoutTestController::addOriginAccessWhitelistEntry):
3331         * DumpRenderTree/mac/DumpRenderTree.mm:
3332         (resetWebViewToConsistentStateBeforeTesting):
3333         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3334         (LayoutTestController::addOriginAccessWhitelistEntry):
3335         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3336         (LayoutTestController::addOriginAccessWhitelistEntry):
3337         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3338         * DumpRenderTree/win/DumpRenderTree.cpp:
3339         (resetWebViewToConsistentStateBeforeTesting):
3340         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3341         (LayoutTestController::addOriginAccessWhitelistEntry):
3342         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3343         (LayoutTestController::addOriginAccessWhitelistEntry):
3344
3345 2010-04-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3346
3347         Reviewed by Eric Seidel.
3348
3349         Remove duplicate function for new-run-webkit-tests
3350         https://bugs.webkit.org/show_bug.cgi?id=37517
3351
3352         The version() function was already implemented.
3353
3354         * Scripts/webkitpy/layout_tests/port/webkit.py:
3355
3356 2010-04-13  Eric Seidel  <eric@webkit.org>
3357
3358         Reviewed by David Levin.
3359
3360         the commit-queue hates Tor Arne Vestbø
3361         https://bugs.webkit.org/show_bug.cgi?id=37511
3362
3363         We were failing to read reviewers out of ChangeLogs
3364         when the reviewer has unicode characters in his/her name.
3365         I fixed this by explicitly decoding from utf8 every time we
3366         read in a ChangeLog file (they are always UTF8).
3367
3368         * Scripts/webkitpy/common/checkout/changelog.py:
3369         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3370
3371 2010-04-13  Adam Roben  <aroben@apple.com>
3372
3373         Fix run-webkit-tests on Windows with spaces in the path
3374
3375         Fixes <http://webkit.org/b/37509>.
3376
3377         Reviewed by Steve Falkenburg.
3378
3379         * Scripts/run-webkit-tests:
3380         (convertPathUsingCygpath): Remove spaces from the path before passing
3381         them to cygpath, then add them back in after conversion, as some
3382         versions of cygpath seem to convert spaces into newlines.
3383
3384 2010-04-13  Adam Barth  <abarth@webkit.org>
3385
3386         Unreviewed, but approved by Dumitru Daniliuc.  (This patch is intended
3387         to fix the downstream Chromium build bots.  Hopefully it will work!)
3388
3389         Add a driver script for the new websocket server
3390         https://bugs.webkit.org/show_bug.cgi?id=37495
3391
3392         websocket_server.py can't be run directly because its a module and not
3393         a standalone script.  This used to work by accident because it didn't
3394         depend on any other modules.
3395
3396         * Scripts/new-run-webkit-websocketserver: Added.
3397         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3398
3399 2010-04-12  Eric Seidel  <eric@webkit.org>
3400
3401         Reviewed by Adam Barth.
3402
3403         Make new-run-webkit-test PrettyPatch failure reporting more awesome
3404         https://bugs.webkit.org/show_bug.cgi?id=37487
3405
3406         I also fixed an Executive/executive typo.
3407
3408         * Scripts/webkitpy/layout_tests/port/base.py:
3409
3410 2010-04-12  Eric Seidel  <eric@webkit.org>
3411
3412         Reviewed by Adam Barth.
3413
3414         new-run-webkit-tests should only build java support files on Mac
3415         https://bugs.webkit.org/show_bug.cgi?id=37482
3416
3417         Only the mac needs java support files, so I pushed _build_java
3418         down into the Mac port using a new hook "_check_port_build".
3419         In the process I noticed a bunch of code which could be shared
3420         between all ports and thus got rid of _tests_for_disabled_features
3421         and version() copy/paste between all webkit ports.
3422         I also made check_build only bother to check for ImageDiff if we're
3423         using pixel tests.
3424
3425         * Scripts/webkitpy/layout_tests/port/gtk.py:
3426         * Scripts/webkitpy/layout_tests/port/mac.py:
3427         * Scripts/webkitpy/layout_tests/port/qt.py:
3428         * Scripts/webkitpy/layout_tests/port/webkit.py:
3429         * Scripts/webkitpy/layout_tests/port/win.py:
3430
3431 2010-04-12  Dumitru Daniliuc  <dumi@chromium.org>
3432
3433         Unreviewed, trying to make scripts work on machines without
3434         Ruby...
3435
3436         * Scripts/webkitpy/layout_tests/port/base.py:
3437
3438 2010-04-12  Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3439
3440         Reviewed by Eric Seidel.
3441
3442         Add stub files for running new-run-webkit-tests for the Qt port
3443
3444         * Scripts/webkitpy/layout_tests/port/factory.py:
3445         * Scripts/webkitpy/layout_tests/port/qt.py: Added.
3446
3447 2010-04-12  Dirk Pranke  <dpranke@chromium.org>
3448
3449         Reviewed by Eric Seidel.
3450
3451         Modify run_webkit_tests.py to not call sys.exit() at the end of test
3452         run; doing so makes it more difficult to embed the routine for,
3453         among other things, unit tests. We push the exit calling up into
3454         new-run-webkit-tests.
3455
3456         https://bugs.webkit.org/show_bug.cgi?id=37464
3457
3458         * Scripts/new-run-webkit-tests:
3459         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3460
3461 2010-04-12  Eric Seidel  <eric@webkit.org>
3462
3463         Unreviewed.
3464
3465         Add stub Gtk implementation for new-run-webkit-tests.
3466
3467         * Scripts/webkitpy/layout_tests/port/factory.py:
3468         * Scripts/webkitpy/layout_tests/port/gtk.py: Added.
3469
3470 2010-04-12  Eric Seidel  <eric@webkit.org>
3471
3472         Reviewed by Adam Barth.
3473
3474         new-run-webkit-tests fails with exception on systems missing ruby
3475         https://bugs.webkit.org/show_bug.cgi?id=37441
3476
3477         * Scripts/webkitpy/layout_tests/port/base.py:
3478          - Catch failures similar to how wdiff code path does.
3479          - After one failure, stop trying.
3480
3481 2010-04-12  Tony Chang  <tony@chromium.org>
3482
3483         Reviewed by Eric Seidel.
3484
3485         Fix how we import simplejson based on how it's used in this file.
3486         This fixes exceptions raised when trying to write the simplejson output.
3487
3488         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3489
3490 2010-04-11  Chris Jerdonek  <cjerdonek@webkit.org>
3491
3492         Reviewed by Shinichiro Hamaji.
3493
3494         Refactored check-webkit-style so that the StyleChecker class
3495         has no dependencies on patch-related concepts.
3496
3497         https://bugs.webkit.org/show_bug.cgi?id=37065
3498
3499         This patch is an intermediate step towards making the StyleChecker
3500         class a generalized file processor that can do arbitary operations
3501         on the files corresponding to a list of paths.  This patch
3502         also simplifies the unit-testing of patch-checking code.
3503
3504         * Scripts/check-webkit-style:
3505           - Updated to use the new PatchChecker class.
3506
3507         * Scripts/webkitpy/style/checker.py:
3508           - Refactored the StyleChecker.check_patch() method into the
3509             check() method of a new PatchChecker class.
3510
3511         * Scripts/webkitpy/style/checker_unittest.py:
3512           - Refactored the unit tests as necessary, changing the
3513             StyleCheckerCheckPatchTest class to a PatchCheckerTest class.
3514
3515 2010-04-11  Adam Barth  <abarth@webkit.org>
3516
3517         Unreviewed.
3518
3519         Fix new-run-webkit-tests regressions cased by Eric's option parsing patch
3520         https://bugs.webkit.org/show_bug.cgi?id=37430
3521
3522         We need some basic unit testing of this script, or we're going to keep
3523         breaking it like this.  Added missing namespace qualifiers and
3524         propagated renaming of an option.
3525
3526         * Scripts/webkitpy/common/config/ports.py:
3527         * Scripts/webkitpy/layout_tests/driver_test.py:
3528         * Scripts/webkitpy/layout_tests/port/base.py:
3529         * Scripts/webkitpy/layout_tests/port/mac.py:
3530         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3531
3532 2010-04-11  Eric Seidel  <eric@webkit.org>
3533
3534         Reviewed by Adam Barth.
3535
3536         Break new-run-webkit-tests options into groups for easier re-use and possible relocation
3537         https://bugs.webkit.org/show_bug.cgi?id=37408
3538
3539         new-run-webkit-tests currently has one huge function for