ec8a82e71524f3eacc93e3e56830ec8d74f6544a
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-04-11  Brian Weinstein  <bweinstein@gmail.com>
2
3         Reviewed by Darin Adler.
4
5         https://bugs.webkit.org/show_bug.cgi?id=24908
6
7         Allows timeout to be set in run-webkit-tests as a command line argument.
8
9         * Scripts/run-webkit-tests:
10
11 2009-04-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
12
13         Rubber-stamped by Tor Arne Vestbø.
14
15         Add /Programs to the productDir for GTK+, instead of adding
16         /JavaScriptCore, when running jsc.
17
18         * Scripts/run-sunspider:
19
20 2009-04-04  Kevin Ollivier  <kevino@theolliviers.com>
21
22         Build fixes for wxMac/Tiger and PPC builds.
23
24         * wx/build-wxwebkit:
25
26 2009-04-04  Kevin Ollivier  <kevino@theolliviers.com>
27
28         wx build fix. Update the version of ICU dlls.
29
30         * wx/build-wxwebkit:
31
32 2009-04-03  Stephanie Lewis  <slewis@apple.com>
33
34         Reviewed by Mark Rowe.
35
36         Fix running DumpRenderTree with a root.
37
38         * Scripts/run-webkit-tests:
39
40 2009-04-02  Adam Roben  <aroben@apple.com>
41
42         Build fix for Windows machines that don't have WebKitTools/Scipts in
43         their PATH
44
45         * Scripts/pdevenv: Add WebKitTools/Scripts to PATH when launching
46         Visual Studio/VC++ Express.
47
48 2009-04-02  Adam Roben  <aroben@apple.com>
49
50         Use pdevenv when building .vcproj files via our scripts
51
52         Reviewed by Mark Rowe.
53
54         * Scripts/webkitdirs.pm:
55         (sub buildVisualStudioProject): Use pdevenv instead of invoking Visual
56         Studio/VC++ Express directly.
57
58 2009-04-01  Mark Rowe  <mrowe@apple.com>
59
60         Windows support for built-product-archive.
61
62         * BuildSlaveSupport/built-product-archive:
63
64 2009-03-31  Adam Roben  <aroben@apple.com>
65
66         Make resolve-ChangeLogs -f work when the working tree has spaces in
67         its path
68
69         Reviewed by Mark Rowe and David Kilzer.
70
71         * Scripts/resolve-ChangeLogs:
72         (sub fixMergedChangeLogs): Quote the path to resolve-ChangeLogs in
73         case it contains spaces.
74
75 2009-03-31  Alexey Proskuryakov  <ap@webkit.org>
76
77         Reviewed by Darin Adler.
78
79         https://bugs.webkit.org/show_bug.cgi?id=24777
80         WebKit tools are broken on Tiger
81
82         * Scripts/webkitdirs.pm: Don't use arch command with options on Tiger.
83
84 2009-03-31  Darin Adler  <darin@apple.com>
85
86         * Scripts/add-include: Added.
87
88 2009-03-31  Mark Rowe  <mrowe@apple.com>
89
90         Fix use of incorrect constant.
91
92         * BuildSlaveSupport/built-product-archive:
93
94 2009-03-30  Mark Rowe  <mrowe@apple.com>
95
96         Rubber-stamped by Stephanie Lewis.
97
98         Add a script in support of the new build.webkit.org configuration.
99
100         * BuildSlaveSupport/built-product-archive: Added.
101
102 2009-03-30  Darin Adler  <darin@apple.com>
103
104         Reviewed by Sam Weinig.
105
106         Make policy-delegate logging work even for local files by processing the URLs as we
107         do for other delegates.
108
109         * DumpRenderTree/mac/PolicyDelegate.mm:
110         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
111         Use _drt_descriptionSuitableForTestResult on the URL.
112
113         * DumpRenderTree/win/PolicyDelegate.cpp:
114         (PolicyDelegate::decidePolicyForNavigationAction): Use urlSuitableForTestResult on the URL.
115
116 2009-03-30  Adam Roben  <aroben@apple.com>
117
118         Windows build fix
119
120         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
121         (LayoutTestController::waitForPolicyDelegate): Added this empty stub.
122
123         * DumpRenderTree/win/WorkQueueItemWin.cpp:
124         (LoadItem::invoke):
125         (ScriptItem::invoke):
126         Changed to use data members instead of removed member functions.
127
128 2009-03-30  Jan Michael Alonzo  <jmalonzo@webkit.org>
129
130         Gtk DRT build fix per changeset
131         http://trac.webkit.org/changeset/42082. Not reviewed.
132
133         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
134         (LoadItem::invoke):
135         (ScriptItem::invoke):
136
137 2009-03-29  Darin Adler  <darin@apple.com>
138
139         * DumpRenderTree/qt/jsobjects.cpp: Rolled out changes to this file. Maybe this will fix
140         Qt building of DumpRenderTree.
141
142 2009-03-29  Darin Adler  <darin@apple.com>
143
144         Reviewed by Cameron Zwarich.
145
146         Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission
147         https://bugs.webkit.org/show_bug.cgi?id=24922
148
149         Don't rely on delegate methods to guess whether a queued step starts a load or not, because
150         script-triggered loads can't be detected that way. Instead have the steps themselves indicate
151         whether or not a load was triggered.
152
153         * DumpRenderTree/LayoutTestController.cpp:
154         (queueLoadingScriptCallback): Added. Version for scripts that perform loads.
155         (queueNonLoadingScriptCallback): Added. Version for scripts that do not perform loads.
156         (LayoutTestController::staticFunctions): Replaced queueScript with queueLoadingScript and
157         queueNonLoadingScript.
158         (LayoutTestController::queueBackNavigation): Moved here since it's platform-independent now.
159         (LayoutTestController::queueForwardNavigation): Ditto.
160         (LayoutTestController::queueLoadingScript): Replacement for queueScript. Here since it's
161         platform-independent.
162         (LayoutTestController::queueNonLoadingScript): Ditto.
163         (LayoutTestController::queueReload): Moved here since it's platform-independent now.
164         * DumpRenderTree/LayoutTestController.h: Ditto.
165
166         * DumpRenderTree/WorkQueue.cpp:
167         (WorkQueue::processWork): Added. Shared by the different platform's work queue implementations.
168         * DumpRenderTree/WorkQueue.h: Ditto.
169
170         * DumpRenderTree/WorkQueueItem.h: Changed the invoke function to return true if the item
171         started a load. Removed unused getter functions. Made invoke functions private.
172         Added LoadingScriptItem and NonLoadingScriptItem, making ScriptItem an abstract base.
173
174         * DumpRenderTree/gtk/DumpRenderTree.cpp:
175         (processWork): Use the new WorkQueue::processWork function to implement the new rule.
176         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed queue functions that are now
177         platform-independent and in LayoutTestController.cpp.
178         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
179         (LoadItem::invoke): Return true.
180         (ReloadItem::invoke): Ditto.
181         (ScriptItem::invoke): Ditto.
182         (BackForwardItem::invoke): Ditto.
183
184         * DumpRenderTree/mac/FrameLoadDelegate.mm:
185         (-[FrameLoadDelegate processWork:]): Use the new WorkQueue::processWork function to implement
186         the new rule.
187         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed queue functions that are now
188         platform-independent and in LayoutTestController.cpp.
189         * DumpRenderTree/mac/WorkQueueItemMac.mm:
190         (LoadItem::invoke): Return true.
191         (ReloadItem::invoke): Ditto.
192         (ScriptItem::invoke): Ditto.
193         (BackForwardItem::invoke): Ditto.
194
195         * DumpRenderTree/qt/jsobjects.cpp:
196         (LayoutTestController::processWork): Use the new WorkQueue::processWork function to implement
197         the new rule. Removed queue functions that are now platform-independent and in
198         LayoutTestController.cpp.
199
200         * DumpRenderTree/win/FrameLoadDelegate.cpp:
201         (FrameLoadDelegate::processWork): Use the new WorkQueue::processWork function to implement
202         the new rule.
203         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed queue functions that are now
204         platform-independent and in LayoutTestController.cpp.
205         * DumpRenderTree/win/WorkQueueItemWin.cpp:
206         (LoadItem::invoke): Return false when we fail, true when we succeed.
207         (ReloadItem::invoke): Ditto.
208         (ScriptItem::invoke): Ditto.
209         (BackForwardItem::invoke): Ditto.
210
211 2009-03-28  Kevin Ollivier  <kevino@theolliviers.com>
212
213         Reviewed by Eric Seidel.
214         
215         Always use wxGraphicsContext on Mac to ensure path, matrix, etc. support.
216
217         * wx/build-wxwebkit:
218
219 2009-03-27  Darin Adler  <darin@apple.com>
220
221         Reviewed by Sam Weinig.
222
223         * Scripts/extract-localizable-strings: Fixed version check for perl 5.10 compatibility.
224
225 2009-03-27  Darin Adler  <darin@apple.com>
226
227         Reviewed by Sam Weinig.
228
229         Added waitForPolicyDelegate, a more-reliable way to make our mailto form submission
230         tests work.
231
232         * DumpRenderTree/AccessibilityController.cpp:
233         (getFocusedElementCallback): Use static_cast instead of reinterpret_cast because there's
234         no reason to use reinterpret_cast just to get from void* to a specific type.
235         (getRootElementCallback): Ditto.
236         * DumpRenderTree/AccessibilityUIElement.cpp:
237         (toAXElement): Ditto.
238         * DumpRenderTree/GCController.cpp:
239         (collectCallback): Ditto.
240         (collectOnAlternateThreadCallback): Ditto.
241         (getJSObjectCountCallback): Ditto.
242         * DumpRenderTree/LayoutTestController.cpp:
243         (many functions):  Ditto.
244         (waitForPolicyDelegateCallback): Added.
245         (LayoutTestController::staticFunctions): Sorted functions by name.
246         Added waitForPolicyDelegate.
247
248         * DumpRenderTree/LayoutTestController.h: Sorted functions by name.
249         Added waitForPolicyDelegate.
250
251         * DumpRenderTree/mac/DumpRenderTree.mm:
252         (resetWebViewToConsistentStateBeforeTesting): Added code to reset the state of the
253         policy delegate.
254         (runTest): Added an additional call to resetWebViewToConsistentStateBeforeTesting just
255         before loading an empty page. This prevents extra policy delegate calls from being logged.
256
257         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
258         (LayoutTestController::waitForPolicyDelegate): Added. Puts us into wait mode, and then
259         tells the policy delegate to notify when done, then points the web view at the policy delegate.
260
261         * DumpRenderTree/mac/PolicyDelegate.h: Added setControllerToNotifyDone: method.
262
263         * DumpRenderTree/mac/PolicyDelegate.mm:
264         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
265         Added code to do notifyDone if controllerToNotifyDone is set.
266         (-[PolicyDelegate setControllerToNotifyDone:]): Added.
267
268         * DumpRenderTree/win/DumpRenderTree.cpp:
269         (resetWebViewToConsistentStateBeforeTesting): Added code to reset the state of the
270         policy delegate. Also moved the call to resetUndoManager in here.
271         (runTest): Removed the call to resetUndoManager (see above). Added an additional call to
272         resetWebViewToConsistentStateBeforeTesting to match the Mac code.
273
274         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
275         (LayoutTestController::setCustomPolicyDelegate): 0, not NULL.
276
277         * DumpRenderTree/win/PolicyDelegate.cpp:
278         (PolicyDelegate::PolicyDelegate): Initialize m_controllerToNotifyDone to 0.
279         (PolicyDelegate::decidePolicyForNavigationAction): Added code to do notifyDone if
280         m_controllerToNotifyDone is set.
281
282         * DumpRenderTree/win/PolicyDelegate.h: Added setControllerToNotifyDone and
283         m_controllerToNotifyDone.
284
285 2009-03-27  Sam Weinig  <sam@webkit.org>
286
287         Reviewed by Gavin Barraclough.
288
289         Fix for https://bugs.webkit.org/show_bug.cgi?id=24765
290         prepare-ChangeLog and svn-create-patch doesn't work with svn 1.6
291
292         * Scripts/prepare-ChangeLog:
293         * Scripts/svn-create-patch:
294
295 2009-03-26  Darin Adler  <darin@apple.com>
296
297         Reviewed by Geoff Garen.
298
299         * Scripts/do-webcore-rename:Update for rename of JSUnprotectedEventListener to
300         JSEventListener.
301
302 2009-03-26  Darin Adler  <darin@apple.com>
303
304         Reviewed by Geoff Garen.
305
306         * Scripts/do-webcore-rename: Update for rename of JSEventListener to
307         JSProtectedEventListener. This includes all the related renames, but
308         not that one because that one renames the file.
309
310 2009-03-26  Adam Roben  <aroben@apple.com>
311
312         Reduce run-webkit-tests's time out limit to 15 seconds (or 2.5 minutes
313         under GuardMalloc)
314
315         The previous limit was 60 seconds (or 10 minutes under GuardMalloc).
316         There's no evidence that we need the limit to be this long, and having
317         it be so long just makes timed-out tests take forever to complete.
318         DRT's watchdog timer is 10 seconds, so still has time to fire before
319         run-webkit-tests will cut it off.
320
321         Reviewed by Simon Fraser.
322
323         * Scripts/run-webkit-tests:
324         (sub readFromDumpToolWithTimer): Reduced the limit to 15 seconds (or
325         2.5 mintues under GuardMalloc).
326
327 2009-03-26  Adam Roben  <aroben@apple.com>
328
329         Make DRT's watchdog timer actually work on Windows
330
331         We were previously trying to use a CFRunLoopTimer for the watchdog
332         timer on Windows. This doesn't work because we don't use a CFRunLoop
333         on the main thread on Windows.
334
335         This patch changes the watchdog timer on Windows be a normal Windows
336         timer.
337
338         Reviewed by Simon Fraser.
339
340         * DumpRenderTree/DumpRenderTree.h: Moved declaration of
341         waitToDumpWatchdog from here...
342         * DumpRenderTree/mac/DumpRenderTreeMac.h: ...to here.
343
344         * DumpRenderTree/win/DumpRenderTree.cpp:
345         (invalidateAnyPreviousWaitToDumpWatchdog): Added. This function
346         cancels an existing watchdog timer.
347         (dump): Call invalidateAnyPreviousWaitToDumpWatchdog. This will
348         prevent watchdogs from previous tests firing during subsequent ones.
349         This matches Mac's behavior.
350
351         * DumpRenderTree/win/DumpRenderTreeWin.h: Added a declaration of
352         waitToDumpWatchdog.
353
354         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
355         (waitUntilDoneWatchdogFired): Converted this to be a Windows
356         TIMERPROC.
357         (LayoutTestController::setWaitToDump): Changed to use SetTimer instead
358         of CFRunLoopAddTimer.
359
360 2009-03-25  Mark Rowe  <mrowe@apple.com>
361
362         Rubber-stamped by Steve Falkenburg.
363
364         Update test result search path for Windows now that it has updated versions of ICU, libxml2, and friends.
365
366         * Scripts/run-webkit-tests:
367
368 2009-03-24  Mark Rowe  <mrowe@apple.com>
369
370         Fix the Tiger build some more.
371
372         * DumpRenderTree/mac/TextInputController.m:
373
374 2009-03-24  Mark Rowe  <mrowe@apple.com>
375
376         Fix the Tiger build.
377
378         * DumpRenderTree/mac/TextInputController.m:
379
380 2009-03-24  Mark Rowe  <mrowe@apple.com>
381
382         Reviewed by Jon "The Most Boring Man in the World" Honeycutt.
383
384         Explicitly map NSNotFound to -1 so that the result of-characterIndexForPointX:Y: does
385         not differ between 32- and 64-bit.
386
387         * DumpRenderTree/mac/TextInputController.m:
388         (-[TextInputController characterIndexForPointX:Y:]):
389
390 2009-03-24  Mark Rowe  <mrowe@apple.com>
391
392         Reviewed by Sam Weinig.
393
394         Use a different platform search path for tests and skip lists, so that Tiger doesn't end up
395         using the Leopard skip list.  Tests and skip lists are now looked for in the directory for
396         the current OS and the generic "mac" directory.  Tests and skip lists for newer OS versions are
397         ignored.
398
399         * Scripts/run-webkit-tests:
400
401 2009-03-23  Stephanie  <slewis@apple.com>
402
403         Fix root build.
404
405         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
406
407 2009-03-23  Stephanie Lewis  <slewis@apple.com>
408
409         Reviewed by Mark Rowe.
410
411         Add production configuration for creating roots of WebKitTools.
412
413         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
414
415 2009-03-23  Oliver Hunt  <oliver@apple.com>
416
417         Reviewed by Geoff Garen.
418
419         Make testapi run as part of the standard JavaScriptCore tests.
420
421         We only run testapi on the mac as currently windows webkit doesn't
422         place all the necessary files for testapi, and we also test the
423         JSC/CF APIs as well.
424
425         * Scripts/run-javascriptcore-tests:
426
427 2009-03-21  Oliver Hunt  <oliver@apple.com>
428
429         Reviewed by Mark Rowe.
430
431         Make build-jsc build testapi and minidom in addition to jsc itself.
432
433         * Scripts/build-jsc:
434
435 2009-03-20  Anders Carlsson  <andersca@apple.com>
436
437         Reviewed by Darin Adler.
438
439         Only release the result NPVariant if the call to NPN_Invoke was successful.
440         
441         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
442         (testNPRuntime):
443
444 2009-03-19  Gustavo Noronha Silva  <gns@gnome.org>
445
446         Reviewed by Mark Rowe.
447
448         Make determinePassedArchitecture always consume the --32-bit
449         option, also in non-AppleMacWebkit platforms. Solution pointed out
450         by Mark Rowe.
451
452         * Scripts/webkitdirs.pm:
453
454 2009-03-19  Mark Rowe  <mrowe@apple.com>
455
456         Reviewed by Oliver Hunt.
457
458         Work around <rdar://problem/6698023> by activating fonts from disk.
459
460         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Copy fonts into DumpRenderTree.resources
461         in the built products directory.
462         * DumpRenderTree/mac/DumpRenderTree.mm:
463         (activateFonts): Activate the fonts from disk.
464
465 2009-03-18  Mark Rowe  <mrowe@apple.com>
466
467         Reviewed by Dan Bernstein.
468
469         <rdar://problem/6693300> Don't rely on printf from TestNetscapePlugIn appearing in test results
470
471         Switch from using printf to using the NPAPI to invoke console.log so that plug-in messages appear
472         in test results even when the plug-in's stdout differs from DumpRenderTree's stdout.
473
474         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
475         (log): Invoke console.log via the NPAPI.
476         (NPP_Destroy): Call log instead of printf.
477         (NPP_SetWindow): Ditto.
478         (handleEventCarbon): Ditto.
479         (handleEventCocoa): Ditto.
480         (NPP_HandleEvent): Pass the instance in to the event handler.
481
482 2009-03-17  Mark Rowe  <mrowe@apple.com>
483
484         Reviewed by Oliver Hunt.
485
486         Use the normal search rules for tests inside the platform directory.
487
488         This allows tests inside the platform directory to have different results
489         on different versions of Mac OS X.
490
491         * Scripts/run-webkit-tests:
492
493 2009-03-17  David Kilzer  <ddkilzer@apple.com>
494
495         resolve-ChangeLogs should not die on unmerged non-ChangeLog files
496
497         Reviewed by Adam Roben.
498
499         Fixes the following bug in resolve-ChangeLogs:
500
501             Use of uninitialized value in -e at ./WebKitTools/Scripts/resolve-ChangeLogs line 132.
502             Died at ./WebKitTools/Scripts/resolve-ChangeLogs line 164.
503
504         * Scripts/resolve-ChangeLogs:
505         (findUnmergedChangeLogs): Check the result of findChangeLog() to
506         make sure we don't add undef values to the list of files being
507         returned.
508
509 2009-03-17  Gustavo Noronha Silva  <gns@gnome.org>
510
511         Reviewed by Simon Fraser.
512
513         Fix the usage of the $architecture variable for non-Apple-Mac
514         ports.
515
516         * Scripts/webkitdirs.pm:
517
518 2009-03-17  David Kilzer  <ddkilzer@apple.com>
519
520         Bug 24645: bisect-builds script doesn't work with Safari 4 Public Beta (version string)
521
522         <https://bugs.webkit.org/show_bug.cgi?id=24645>
523
524         Reviewed by Mark Rowe.
525
526         * Scripts/bisect-builds:
527         (makeNightlyList): Added checks for Safari 4 Public Beta on
528         Tiger and Leopard.
529
530 2009-03-17  Simon Fraser  <simon.fraser@apple.com>
531
532         Reviewed by Darin Adler
533
534         https://bugs.webkit.org/show_bug.cgi?id=24396
535
536         Change the terminology from '3D transforms' to '3D rendering'.
537
538         * Scripts/build-webkit:
539         * Scripts/run-webkit-tests:
540         * Scripts/webkitdirs.pm:
541
542 2009-03-17  Gustavo Noronha Silva  <gns@gnome.org>
543
544         Reviewed by Mark Rowe.
545
546         Enable HTML5 media elements support by default also for the GTK+
547         port.
548
549         * Scripts/build-webkit:
550
551 2009-03-17  Kevin Ollivier  <kevino@theolliviers.com>
552
553         Reviewed by Mark Rowe.
554         
555         Tweak the BUILDING_ON_* defines so that they work with the default values set by
556         AvailabilityMacros.h.
557         
558         https://bugs.webkit.org/show_bug.cgi?id=24630
559
560         * DumpRenderTree/mac/DumpRenderTreeMac.h:
561
562 2009-03-17  Oliver Hunt  <oliver@apple.com>
563
564         Reviewed by Alexey Proskuryakov.
565
566         Make coverage testing more reliable by ensuring --coverage does not
567         clobber configuration settings, and by removing the unnecessary 
568         dependency on matplotlib.
569
570         * CodeCoverage/regenerate-coverage-display:
571         * Scripts/webkitdirs.pm:
572
573 2009-03-16  Anders Carlsson  <andersca@apple.com>
574
575         Reviewed by Darin Adler and John Sullivan.
576
577         When a plug-in instance is torn down, all plug-in objects will first be invalidated and then deallocated.
578         Since objects can be deallocated in any order, it is not safe to call NPN_ReleaseObject on member variables.
579         
580         Instead, just zero out the member variable in invalidate.
581         
582         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
583         (pluginInvalidate):
584         (pluginDeallocate):
585
586 2009-03-16  Eric Seidel  <eric@webkit.org>
587
588         Reviewed by Sam Weinig.
589         
590         REGRESSION: undo-iframe-location-change.html is failing on the buildbots
591         https://bugs.webkit.org/show_bug.cgi?id=24626
592         
593         Added a call to [[webview undoManager] removeAllActions]
594         to make sure anything left on the undo stack after one test
595         will not affect any later test.
596
597         * DumpRenderTree/mac/DumpRenderTree.mm:
598         (resetWebViewToConsistentStateBeforeTesting):
599
600 2009-03-14  Mark Rowe  <mrowe@apple.com>
601
602         Reviewed by Dan Bernstein.
603
604         Change the layout test result search policy for Mac OS X to fit better with the idea of
605         newer OS versions improving on previous OS versions.
606
607         The results for the latest version of Mac OS X are placed in the "mac" directory.  The
608         results for older versions of Mac OS X are structured as a series of overlays.  When
609         running on Leopard, the results in "mac-leopard" are searched before those in "mac".
610         When running on Tiger, the results in "mac-tiger" are searched before those in
611         "mac-leopard" and "mac".
612
613         * Scripts/run-webkit-tests:
614
615 2009-03-13  Mark Rowe  <mrowe@apple.com>
616
617         Rubber-stamped by Dan Bernstein.
618
619         Take advantage of the ability of recent versions of Xcode to easily switch the active
620         architecture.
621
622         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
623
624 2009-03-13  Mark Rowe  <mrowe@apple.com>
625
626         Reviewed by Timothy Hatcher.
627
628         Remove the --64-bit argument from scripts in favor of them detecting when 64-bit should be preferred.
629
630         The scripts will automatically target 64-bit if the system and hardware support it.  This can be
631         overridden by passing --32-bit to individual scripts, or using set-webkit-configuration --32-bit
632         to make the override persistent.
633
634         * Scripts/build-webkit: Remove architecture-related code.
635         * Scripts/gdb-safari: Remove architecture-related code, and clean up how the environment variables are passed to gdb.
636         * Scripts/run-javascriptcore-tests: Remove architecture-related code.
637         * Scripts/run-safari: Ditto.
638         * Scripts/run-webkit-tests: Ditto.
639         * Scripts/set-webkit-configuration: Handle the --32-bit and --64-bit arguments.  The --32-bit argument will set the
640         architecture preference to the 32-bit architecture of the machine.  The --64-bit argument will remove any architecture
641         override that is in effect so that 64-bit support will be automatically detected.
642         * Scripts/webkitdirs.pm: Add auto-detection of the best architecture for the machine, and the ability to override the
643         auto-detection.
644
645 2009-03-13  Anders Carlsson  <andersca@apple.com>
646
647         Reviewed by Dan Bernstein.
648
649         <rdar://problem/6610666> Revise the Cocoa event model text API
650
651         Add a case statement for NPCocoaEventTextInput.
652         
653         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
654         (handleEventCocoa):
655
656 2009-03-12  Kevin Ollivier  <kevino@theolliviers.com>
657
658         wx build fix. Let DerivedSources.make know we want database APIs.
659
660         * wx/build-wxwebkit:
661
662 2009-03-12  David Kilzer  <ddkilzer@apple.com>
663
664         Bug 24378: resolve-ChangeLogs should use git status or svn status to find and fix unmerged ChangeLogs
665
666         <https://bugs.webkit.org/show_bug.cgi?id=24378>
667
668         Reviewed by Adam Roben.
669
670         * Scripts/resolve-ChangeLogs: If -f|--fix-merged is not passed
671         and no file or directory names are specified on the command-line
672         then try to find unmerged ChangeLog files based on 'svn stat' or
673         'git diff'.  Added global $isGit and $isSVN variables so that
674         isGit() and isSVN() only have to be called once.
675         (findUnmergedChangeLogs): Added.
676
677 2009-03-11  David Kilzer  <ddkilzer@apple.com>
678
679         Clarify comments regarding order of FEATURE_DEFINES
680
681         Rubber-stamped by Mark Rowe.
682
683         * Scripts/build-webkit: Added warning about keeping
684         FEATURE_DEFINES in order and the consequences when they are not.
685
686 2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>
687
688         Reviewed by Holger Freyther.
689
690         Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
691         https://bugs.webkit.org/show_bug.cgi?id=24487
692
693         Also reset WebSettings to its default state for JavaScript
694         profiling, Developer Extras and Private Browsing before running
695         the test (can be after each test but we want to be consistent with
696         other ports in this regard)
697
698         * DumpRenderTree/gtk/DumpRenderTree.cpp:
699         (resetWebViewToConsistentStateBeforeTesting):
700         (runTest):
701         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
702         (LayoutTestController::setPrivateBrowsingEnabled):
703
704 2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>
705
706         Reviewed by Holger Freyther.
707
708         [GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
709         https://bugs.webkit.org/show_bug.cgi?id=2260
710
711         Add plugin support only for X11 builds
712
713         * DumpRenderTree/gtk/DumpRenderTree.cpp:
714         (setDefaultsToConsistentStateValuesForTesting):
715         * GNUmakefile.am:
716
717 2009-03-08  Holger Hans Peter Freyther  <zecke@selfish.org>
718
719         Reviewed by Mark Rowe.
720
721         Implement setJavaScriptProfilingEnabled by enabling the Developer
722         Extras and the JavaScript profiling on the WebKitWebInspector. After
723         this change we pass the three enabled tests in fast/profiler.
724
725         * DumpRenderTree/gtk/DumpRenderTree.cpp:
726         (runTest): Reset setJavaScriptProfilingEnabled after each test run
727         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
728         (LayoutTestController::setJavaScriptProfilingEnabled):
729
730 2009-03-07  Jan Michael Alonzo  <jmalonzo@webkit.org>
731
732         Reviewed by Holger Freyther.
733
734         [Gtk] Enable http history tests
735         https://bugs.webkit.org/show_bug.cgi?id=24394
736
737         Get the index of the current item from the list of (history) items
738         to print before adding the back history items to the list. This
739         will make the 'curr' pointer point to the correct item in the
740         actual results, therefore, passing some of the http/tests/history
741         tests.
742
743         * DumpRenderTree/gtk/DumpRenderTree.cpp:
744         (dumpBackForwardListForWebView):
745
746 2009-03-06  Adam Treat  <adam.treat@torchmobile.com>
747
748         Reviewed by George Staikos.
749
750         When building QtWebKit in release mode make sure that QT_SHARED is defined
751         otherwise none of the public API will be exported.  This leads to missing
752         symbols and link errors if hidden-visibility is used.
753
754         * Scripts/webkitdirs.pm:
755
756 2009-03-06  Adam Roben  <aroben@apple.com>
757
758         Change the isCygwin check in update-webkit to isAppleWinWebKit
759
760         This matches a similar check in build-webkit, and is more correct.
761
762         Reviewed by Alexey Proskuryakov.
763
764         * Scripts/update-webkit: Only call update-webkit-auxiliary-libs if
765         isAppleWinWebKit is true.
766
767 2009-03-06  Adam Roben  <aroben@apple.com>
768
769         Make update-webkit-support-libs fail if WebKitSupportLibrary.zip is
770         present but out of date
771
772         Reviewed by Alexey Proskuryakov.
773
774         * Scripts/update-webkit-support-libs: Changed to use
775         dieAndInstructToDownload when the zip file doesn't exist. Added an MD5
776         check to make sure the file is up-to-date. If it is out of date, print
777         an error message and quit.
778         (sub dieAndInstructToDownload): Added. Prints an error message and
779         quits with an error.
780
781 2009-03-03  Anders Carlsson  <andersca@apple.com>
782
783         Reviewed by John Sullivan.
784
785         https://bugs.webkit.org/show_bug.cgi?id=22884
786         <rdar://problem/6449783>
787         modified layout test crashes Safari
788
789         Add destroyNullStream test function to the test plug-in.
790         
791         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
792         (destroyNullStream):
793         (pluginInvoke):
794
795 2009-03-03  Brady Eidson  <beidson@apple.com>
796
797         Reviewed by Darin Adler
798
799         Support layout test covering <rdar://problem/6616664>
800
801         Change NSURLRequest/IWebURLRequest dumping to include the mainDocumentURL
802
803         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
804         (-[NSURLRequest _drt_descriptionSuitableForTestResult]): Return both the request URL and the 
805           mainDocumentURL.
806         
807         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
808         (descriptionSuitableForTestResult): Return both the request URL and the mainDocumentURL.
809
810 2009-03-02  Sam Weinig  <sam@webkit.org>
811
812         Reviewed by Mark Rowe.
813
814         Enable Geolocation (except on Tiger and Leopard).
815
816         * Scripts/build-webkit:
817
818 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
819
820         Build fixes for wxWidgets Mac trunk build.
821
822         * wx/build-wxwebkit:
823
824 2009-03-02  Timothy Hatcher  <timothy@apple.com>
825
826         Allow for multiline quoted text in JavaScript files when looking for function names.
827
828         https://bugs.webkit.org/show_bug.cgi?id=24296
829
830         Reviewed by David Kilzer.
831
832         * Scripts/prepare-ChangeLog:
833
834 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
835
836         Reviewed by Eric Seidel.
837
838         Add three new drt helper functions that enable all of the tests in
839         LayoutTests/animation/* and LayoutTests/transitions/* to now pass.
840
841         * DumpRenderTree/qt/jsobjects.cpp:
842         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
843         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
844         (LayoutTestController::numberOfActiveAnimations):
845         * DumpRenderTree/qt/jsobjects.h:
846
847 2009-03-02  Adam Roben  <aroben@apple.com>
848
849         Windows build fix after r41349
850
851         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
852         (AccessibilityUIElement::getChildrenWithRange):
853
854 2009-03-01  Chris Fleizach  <cfleizach@apple.com>
855
856         Reviewed by Oliver Hunt.
857
858         Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
859
860         Change getChildAtIndex() to get a range of children instead of all the children.
861         This exercises code in WebCore that returns elements when asked for from a range.
862
863         * DumpRenderTree/AccessibilityUIElement.h:
864         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
865         (AccessibilityUIElement::getChildrenWithRange):
866         (AccessibilityUIElement::getChildAtIndex):
867         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
868         (AccessibilityUIElement::getChildrenWithRange):
869
870 2009-03-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
871
872         Reviewed by Holger Freyther.
873
874          [Gtk] get the HTTP layout tests going
875          https://bugs.webkit.org/show_bug.cgi?id=24259
876
877         Determine the frame's response and decide whether to dump as text
878         or the render tree
879
880         * DumpRenderTree/gtk/DumpRenderTree.cpp:
881         (dump):
882
883 2009-03-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
884
885         Reviewed by Holger Freyther.
886
887         [Gtk] get the HTTP layout tests going
888         https://bugs.webkit.org/show_bug.cgi?id=24259
889
890          Implement dumping of WebKitWebBackForwardList and its history
891          items.
892
893         * DumpRenderTree/gtk/DumpRenderTree.cpp:
894         (compareHistoryItems):
895         (dumpHistoryItem):
896         (dumpBackForwardListForWebView):
897         (dump):
898         (runTest):
899         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
900         (LayoutTestController::clearBackForwardList):
901         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
902         (BackForwardItem::invoke):
903
904 2009-02-28  Zan Dobersek  <zandobersek@gmail.com>
905
906          Reviewed by Holger Freyther.
907
908          Set the resolution for the default screen to 72.0.
909          This way, setting font sizes results in expected values.
910
911          * DumpRenderTree/gtk/DumpRenderTree.cpp:
912          (setDefaultsToConsistentStateValuesForTesting):
913
914 2009-02-28  Gustavo Noronha Silva  <gns@gnome.org>
915
916         Reviewed by Holger Freyther.
917
918         Adds a WebKitMakeArguments environment variable to enable passing
919         of arguments such as '-j2' to make for the autotools build.
920
921         * Scripts/webkitdirs.pm:
922
923 2009-02-28  Gustavo Noronha Silva  <gns@gnome.org>
924
925         Reviewed by Holger Freyther.
926
927         Add a GTK+-only option to enable GNOME Keyring when building.
928
929         * Scripts/build-webkit:
930
931 2009-02-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
932
933         Reviewed by Holger Freyther.
934
935         [Gtk] webkitdirs.pm modify path in when detecting 3D transforms and accelerated compositing
936         https://bugs.webkit.org/show_bug.cgi?id=24076
937
938         Refactor gtk lib detection and put it in builtDylibPathForName
939
940         * Scripts/webkitdirs.pm:
941
942 2009-02-28  Christian Dywan  <christian@twotoasts.de>
943
944         Rubber-stamped by Holger Freyther.
945
946         * GtkLauncher/main.c:
947         (activate_uri_entry_cb):
948         (main): Use the new webkit_web_view_load_uri to open URIs.
949
950 2009-02-27  Xan Lopez  <xan@gnome.org>
951
952         Rubber-stamped by Alexey Proskuryakov.
953
954         https://bugs.webkit.org/show_bug.cgi?id=24222
955         [GTK] Remove checks for old glib versions
956
957         libsoup, which is a hard dependency, needs at least glib 2.15.3,
958         so remove all glib checks for versions older than that.
959
960         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
961         (LayoutTestController::setWaitToDump):
962
963 2009-02-25  Simon Fraser  <simon.fraser@apple.com>
964
965         Reviewed by Eric Seidel
966
967         Fix spew about a WebView being deallocated while key value observers are
968         still registered with it by making sure that we always stop observing
969         _isUsingAcceleratedCompositing in -[DumpRenderTreeWindow close].
970         
971         * DumpRenderTree/mac/DumpRenderTree.mm:
972         (dumpRenderTree):
973         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
974         (-[DumpRenderTreeWindow close]):
975
976 2009-02-25  Adam Treat  <adam.treat@torchmobile.com>
977
978         Reviewed by Alexey Proskuryakov.
979
980         Do not queue the calls to 'DumpRenderTree::dump()' as this can result
981         in more than one call as a test that calls 'notifyDone()' can then be
982         subsequently fully loaded and initiate a second dump.  Also make sure
983         to stop any existing page load that is happening before running the next
984         test.  Combined this serves to produce 217 more passing tests for the
985         Qt port or roughly 5% at this point.
986
987         * DumpRenderTree/qt/DumpRenderTree.cpp:
988         (WebCore::DumpRenderTree::DumpRenderTree):
989         (WebCore::DumpRenderTree::open):
990
991 2009-02-25  Simon Fraser  <simon.fraser@apple.com>
992
993         Reviewed by Dan Bernstein
994
995         https://bugs.webkit.org/show_bug.cgi?id=23854
996
997         Have the DumpRenderTreeWindow observe the -_isUsingAcceleratedCompositing
998         property of the WebView, and use that to turn -autodisplay on and off.
999         This is necessary so that accelerated animations start correctly.
1000         We can thus remove the -display hack in createBitmapContextFromWebView().
1001
1002         * DumpRenderTree/mac/DumpRenderTree.mm:
1003         (createWebViewAndOffscreenWindow):
1004         (dumpRenderTree):
1005         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1006         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1007         (-[DumpRenderTreeWindow close]):
1008         (-[DumpRenderTreeWindow webView]):
1009         (-[DumpRenderTreeWindow startObservingWebView]):
1010         (-[DumpRenderTreeWindow stopObservingWebView]):
1011         (-[DumpRenderTreeWindow observeValueForKeyPath:ofObject:change:context:]):
1012         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1013         (createBitmapContextFromWebView):
1014
1015 2009-02-25  Adam Treat  <adam.treat@torchmobile.com>
1016
1017         Reviewed by Zack Rusin.
1018
1019         https://bugs.webkit.org/show_bug.cgi?id=24158
1020         Implement the queue*() methods of the layoutTestController and begin
1021         implementing the dump of the back/forward list.  This results in 2% more
1022         tests passing as well as 23 currently skipped tests now passing.
1023
1024         * DumpRenderTree/qt/DumpRenderTree.cpp:
1025         (WebCore::DumpRenderTree::dumpBackForwardList):
1026         (WebCore::DumpRenderTree::dump):
1027         * DumpRenderTree/qt/DumpRenderTree.h:
1028         * DumpRenderTree/qt/DumpRenderTree.pro:
1029         * DumpRenderTree/qt/jsobjects.cpp:
1030         (findFrameNamed):
1031         (LoadItem::invoke):
1032         (ReloadItem::invoke):
1033         (ScriptItem::invoke):
1034         (BackForwardItem::invoke):
1035         (LayoutTestController::reset):
1036         (LayoutTestController::processWork):
1037         (LayoutTestController::maybeDump):
1038         (LayoutTestController::queueBackNavigation):
1039         (LayoutTestController::queueForwardNavigation):
1040         (LayoutTestController::queueLoad):
1041         (LayoutTestController::queueReload):
1042         (LayoutTestController::queueScript):
1043         * DumpRenderTree/qt/jsobjects.h:
1044         (LayoutTestController::shouldDumpBackForwardList):
1045         (LayoutTestController::dumpBackForwardList):
1046
1047 2009-02-24  Adam Treat  <adam.treat@torchmobile.com>
1048
1049         Reviewed by Alexey Proskuryakov.
1050
1051         Don't print out that you are generating new results if you are not in fact
1052         generating new results and disable generating new results by default for
1053         the all ports other than the canonical Apple Mac port since this can litter
1054         the source directory with hundreds of new results since other ports
1055         are not as up to date.
1056
1057         * Scripts/run-webkit-tests:
1058
1059 2009-02-24  Adam Treat  <adam.treat@torchmobile.com>
1060
1061         Reviewed by Cameron Zwarich.
1062
1063         The Qt port does not support these yet nor does the nm check work with
1064         QMake based build.
1065
1066         * Scripts/webkitdirs.pm:
1067
1068 2009-02-24  Jan Michael Alonzo  <jmalonzo@webkit.org>
1069
1070         Reviewed by Alexey Proskuryakov.
1071
1072         [Gtk] add options for 3D transforms and HTML5 channel messaging to the build
1073         https://bugs.webkit.org/show_bug.cgi?id=24072
1074
1075         Allow toggling of 3D transforms and HTML5 channel messaging
1076         support for the Autotools (Gtk) build.
1077
1078         Also add '--gtk' in the build-webkit help doc and fix autotools
1079         option for web-workers support.
1080
1081         * Scripts/build-webkit:
1082
1083 2009-02-23  Xan Lopez  <xan@gnome.org>
1084
1085         Reviewed by Alexey Proskuryakov.
1086
1087         https://bugs.webkit.org/show_bug.cgi?id=22624
1088         [SOUP][GTK] Need API to get SoupSession from WebKit.
1089
1090         Add soup flags now that dependency is explicit.
1091
1092         * GNUmakefile.am:
1093
1094 2009-02-22  Mark Rowe  <mrowe@apple.com>
1095
1096         Reviewed by Oliver Hunt.
1097
1098         Fix assertion failures in editing/pasteboard/paste-RTFD.html and editing/pasteboard/paste-TIFF.html in 64-bit.
1099
1100         * DumpRenderTree/mac/DumpRenderTree.mm:
1101         (swizzleAllMethods): When adding a new method to a class, use the implementation and type of the new method rather
1102         than of an arbitrary existing method on the class.
1103
1104 2009-02-13  Eric Seidel  <eric@webkit.org>
1105
1106         Rubber-stamped by Alexey Proskuryakov.
1107
1108         Add a few ignores to make-js-test-wrappers.
1109
1110         * Scripts/make-js-test-wrappers:
1111
1112 2009-02-17  Holger Hans Peter Freyther  <zecke@selfish.org>
1113
1114         Reviewed by Alexey Proskuryakov.
1115
1116         Prepend file:// to the test result filename to make
1117         GtkLauncher display the result page.
1118
1119         * Scripts/run-webkit-tests:
1120
1121 2009-02-16  Gustavo Noronha Silva  <gns@gnome.org>
1122
1123         Reviewed by Adam Roben
1124
1125         Actually use the installation prefix defined in WebKitInstallationPrefix,
1126         in autotools builds.
1127
1128         * Scripts/webkitdirs.pm:
1129
1130 2009-02-12  Simon Fraser  <simon.fraser@apple.com>
1131
1132         No review.
1133
1134         Remove debugging code which was committed by mistake.
1135
1136         * Scripts/run-webkit-tests:
1137
1138 2009-02-12  Simon Fraser  <simon.fraser@apple.com>
1139
1140         Reviewed by Adam Roben
1141
1142         https://bugs.webkit.org/show_bug.cgi?id=23928
1143
1144         Add detection of accelerated compositing and 3d transforms,
1145         and add various directories to $ignoredDirectories when these
1146         features are off.
1147
1148         * Scripts/run-webkit-tests:
1149         * Scripts/webkitdirs.pm:
1150
1151 2009-02-12  Adam Roben  <aroben@apple.com>
1152
1153         Fix Bug 23922: Warning message from run-webkit-tests when Skipped file
1154         contains non-existent tests is confusing and is given for disabled
1155         tests
1156
1157         <https://bugs.webkit.org/show_bug.cgi?id=23922>
1158
1159         We now no longer warn about disabled tests. The warning now reads:
1160
1161         Skipped list contained '$item', but no file of that name could be
1162         found
1163
1164         Reviewed by John Sullivan.
1165
1166         * Scripts/run-webkit-tests:
1167         (top level): Pass the list name to processIgnoreTests so it can print
1168         out a reasonable warning message.
1169         (processIgnoreTests): Take a list name as a second parameter and use
1170         it to display a better warning message. Also check for a "-disabled"
1171         version of the test before warning about it not existing.
1172
1173 2009-02-11  Adam Roben  <aroben@apple.com>
1174
1175         Windows fix for Bug 22239: Implement missing animation & transition
1176         APIs on LayoutTestController for non-mac platforms
1177
1178         <https://bugs.webkit.org/show_bug.cgi?id=22239>
1179
1180         Reviewed by Simon Fraser.
1181
1182         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1183         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1184         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1185         (LayoutTestController::numberOfActiveAnimations):
1186         Implemented these by calling through to IWebFramePrivate.
1187
1188 2009-02-10  Chris Marrin  <cmarrin@apple.com>
1189
1190         Reviewed by Simon Fraser.
1191
1192         * Scripts/build-webkit:
1193
1194         https://bugs.webkit.org/show_bug.cgi?id=23883
1195
1196         Added support --3d-transforms. Defaults to off
1197
1198 2009-02-11  Adam Roben  <aroben@apple.com>
1199
1200         Fix crashes in http/tests/history/redirect-301.pl and friends on
1201         Windows
1202
1203         Reviewed by Alexey Proskuryakov.
1204
1205         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1206         (LayoutTestController::webHistoryItemCount): Null-check the shared
1207         WebHistory instance before dereferencing it.
1208
1209 2009-02-10  Adam Roben  <aroben@apple.com>
1210
1211         Fix Bug 23869: Pixel tests can't be run on Windows
1212
1213         <https://bugs.webkit.org/show_bug.cgi?id=23869>
1214
1215         This patch gets the pixel tests limping along on Windows again.
1216
1217         Reviewed by Dan Bernstein.
1218
1219         * DumpRenderTree/DumpRenderTree.sln: Changed to use the new
1220         Debug_Internal configuration of ImageDiff in the Debug_Internal
1221         configuration of this solution.
1222
1223         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1224         (printPNG): Changed to call fwrite in a loop, since this call was
1225         failing due to the buffer being too large on Windows.
1226         (dumpWebViewAsPixelsAndCompareWithExpected): Removed an unnecessary
1227         #if PLATFORM(MAC)/#endif.
1228
1229         * DumpRenderTree/win/ImageDiff.vcproj: Added a Debug_Internal
1230         configuration that matches the Debug configuration but also references
1231         debug_internal.vsprops.
1232
1233         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1234         (createBitmapContextFromWebView): Renamed from
1235         getBitmapContextFromWebView to match the name used in the
1236         cross-platform code.
1237
1238 2009-02-10  Adam Roben  <aroben@apple.com>
1239
1240         Robustify DumpRenderTree/win a little
1241
1242         DumpRenderTree was previously not holding a ref to the WebViews it
1243         created via window.open. It was getting away with this because
1244         WebViews get reffed by being preference notification observers and by
1245         registering for drag-n-drop messages. Now DRT does hold a ref, in case
1246         this situation changes in the future.
1247
1248         Reviewed by Alexey Proskuryakov.
1249
1250         * DumpRenderTree/win/DumpRenderTree.cpp:
1251         (dumpBackForwardListForAllWindows): Added a .get().
1252         (windowToWebViewMap): Changed to use the WindowToWebViewMap typedef.
1253         * DumpRenderTree/win/DumpRenderTreeWin.h: Changed the
1254         windowToWebViewMap() to hold a ref to the WebViews it contains.
1255
1256 2009-02-05  Simon Fraser  <simon.fraser@apple.com>
1257
1258         Fix the #include file order, per review comments.
1259
1260         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1261
1262 2009-02-05  Simon Fraser  <simon.fraser@apple.com>
1263
1264         Reviewed by Dan Bernstein
1265
1266         https://bugs.webkit.org/show_bug.cgi?id=23362
1267
1268         If the WebHTMLView uses accelerated compositing, we need for force
1269         the on-screen capture path and also force animations to start with -display
1270         since the DRT window has autodisplay disabled.
1271
1272         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1273         (createBitmapContextFromWebView):
1274
1275 2009-02-03  miggilin  <mr.diggilin@gmail.com>
1276
1277         Reviewed by Darin Adler.
1278
1279         Change the way wxWidgets build gets arguments.
1280         Change "checkForArgumentAndRemoveFromARGV" in build-webkit to check if the
1281         argument passed matches one in ARGV exactly (allows, ie, --wx-args not to be
1282         removed when --wx is checked for).
1283
1284         https://bugs.webkit.org/show_bug.cgi?id=23701
1285
1286         * Scripts/build-webkit:
1287         * Scripts/webkitdirs.pm:
1288
1289 2009-01-30  Chris Fleizach  <cfleizach@apple.com>
1290
1291         Reviewed by Oliver Hunt.
1292
1293         Catch exceptions thrown by AppKit when accessing an attribute than an element
1294         doesn't return.
1295
1296         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1297         (attributesOfElement):
1298
1299 2009-01-29  David Kilzer  <ddkilzer@apple.com>
1300
1301         Remove semi-colons from the end of ObjC method implementations
1302
1303         Rubber-stamped by Adam Roben.
1304
1305         $ find WebKitTools -name \*.m -o -name \*.mm -exec perl -e 'undef $/; $s = <>; while ($s =~ m/[\n\r][-+].*;[\s\r\n]+\{/g) { print "$ARGV: $&\n"; }' {} \;
1306
1307         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1308         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1309         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1310         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1311         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1312         * DumpRenderTree/mac/UIDelegate.mm:
1313         (-[UIDelegate webViewFrame:]):
1314
1315 2009-01-28  Geoffrey Garen  <ggaren@apple.com>
1316
1317         Build fix for GTK.
1318
1319         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1320         (LayoutTestController::webHistoryItemCount):
1321
1322 2009-01-28  Geoffrey Garen  <ggaren@apple.com>
1323
1324         Reviewed by Sam Weinig.
1325
1326         Added support for querying how many history items were created during a
1327         layout test.
1328
1329         * DumpRenderTree/LayoutTestController.cpp:
1330         (getWebHistoryItemCountCallback):
1331         (LayoutTestController::staticValues):
1332         * DumpRenderTree/LayoutTestController.h:
1333         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1334         (LayoutTestController::webHistoryItemCount):
1335         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1336         (LayoutTestController::webHistoryItemCount):
1337
1338 2009-01-26  Pierre-Olivier Latour  <pol@apple.com>
1339
1340         Tweaked again earlier fix, this time just to print a warning and not abort if
1341         attempting to generate pixel results and Perian is installed.
1342
1343         https://bugs.webkit.org/show_bug.cgi?id=22615
1344
1345         * Scripts/run-webkit-tests:
1346
1347 2009-01-26  Christian Dywan  <christian@twotoasts.de>
1348
1349         Rubber stamped by Holger Freyther.
1350
1351         * GtkLauncher/main.c:
1352         (main): Initialize threads, which is required for libSoup.
1353
1354 2009-01-23  David Kilzer  <ddkilzer@apple.com>
1355
1356         * Scripts/do-webcore-rename: Removed 10 header guard renames that
1357         had already been fixed, and updated 4 renames whose original values
1358         had changed.
1359
1360 2009-01-22  Anders Carlsson  <andersca@apple.com>
1361
1362         Fix Windows build.
1363
1364         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1365
1366 2009-01-22  Anders Carlsson  <andersca@apple.com>
1367
1368         Reviewed by Sam Weinig.
1369
1370         Clean up the test plug-in code. We now always use the CG drawing model and the
1371         Cocoa event model. It is however possible to revert to the old Carbon event model by
1372         specifying forcecarbon=true in the embed/object tag.
1373
1374         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1375         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1376         (NPP_New):
1377         (handleEventCarbon):
1378         (handleEventCocoa):
1379         (NPP_HandleEvent):
1380
1381 2009-01-21  Pierre-Olivier Latour  <pol@apple.com>
1382
1383         Tweaked earlier fix to only print a warning when Perian is installed,
1384         and fail completely only if attempting to generate new pixel test results.
1385
1386         https://bugs.webkit.org/show_bug.cgi?id=23392
1387
1388         * Scripts/run-webkit-tests:
1389
1390 2009-01-20  Darin Adler  <darin@apple.com>
1391
1392         Reviewed by Alexey Proskuryakov.
1393
1394         Bug 23450: string leaks seen in DumpRenderTree accessibility test code
1395         https://bugs.webkit.org/show_bug.cgi?id=23450
1396
1397         * DumpRenderTree/AccessibilityUIElement.cpp:
1398         (isAttributeSettableCallback): Add the missing JSStringRelease call.
1399         (attributeValueCallback): Ditto.
1400
1401 2009-01-20  Pierre-Olivier Latour  <pol@apple.com>
1402
1403         Reviewed by Darin Adler.
1404
1405         Print warning regarding display color profile change in run-webkit-tests instead of DRT.
1406
1407         https://bugs.webkit.org/show_bug.cgi?id=23392
1408
1409         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1410         (setupMainDisplayColorProfile):
1411         * Scripts/run-webkit-tests:
1412
1413 2009-01-20  Pierre-Olivier Latour  <pol@apple.com>
1414
1415         Reviewed by Darin Adler.
1416
1417         Changed run-webkit-tests to abort on the Mac if pixel tests are enabled and Perian is installed,
1418         in order to avoid result differences in some media tests.
1419
1420         https://bugs.webkit.org/show_bug.cgi?id=22615
1421
1422         * Scripts/run-webkit-tests:
1423         * Scripts/webkitdirs.pm:
1424
1425 2009-01-19  Sam Weinig  <sam@webkit.org>
1426
1427         * Scripts/do-webcore-rename: Add JSValuePtr and ProtectedJSValuePtr.
1428
1429 2009-01-16  Gabor Loki  <loki@inf.u-szeged.hu>
1430
1431         Reviewed by Darin Adler.
1432
1433         * Scripts/webkitdirs.pm: Added '--makeargs' parameter which can pass additional
1434         parameters to make command in QMake projects.
1435
1436 2009-01-16  Chris Fleizach  <cfleizach@apple.com>
1437
1438         Reviewed by Beth Dakin.
1439
1440         Add AX methods to retrieve the parent of an element.
1441
1442         * DumpRenderTree/AccessibilityUIElement.cpp:
1443         (parentElementCallback):
1444         (AccessibilityUIElement::getJSClass):
1445         * DumpRenderTree/AccessibilityUIElement.h:
1446         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1447         (AccessibilityUIElement::parentElement):
1448         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1449         (AccessibilityUIElement::parentElement):
1450
1451 2009-01-16  Anders Carlsson  <andersca@apple.com>
1452
1453         Reviewed by Adam Roben.
1454
1455         Set the count to the right number of elements.
1456
1457         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
1458         (testEnumerate):
1459
1460 2009-01-14  David Kilzer  <ddkilzer@apple.com>
1461
1462         BUILD FIX: Use COM API on Windows in LayoutTestController::setIconDatabaseEnabled()
1463
1464         Rubber-stamped by Alice Liu.
1465
1466         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1467         (LayoutTestController::setIconDatabaseEnabled): Use COM API
1468         to get the shared WebIconDatabase.
1469
1470 2009-01-14  Jeremy Moskovich  <jeremy@chromium.org>
1471
1472         Reviewed by Eric Seidel.
1473
1474         <https://bugs.webkit.org/show_bug.cgi?id=16829>
1475         Implement NPN_SetException()
1476
1477         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1478         (pluginInvoke):
1479         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
1480         (initializeIdentifiers):
1481         (testHasMethod):
1482         (testInvoke):
1483
1484 2009-01-13  Dmitry Titov  <dimich@chromium.org>
1485
1486         Reviewed by David Kilzer.
1487
1488         https://bugs.webkit.org/show_bug.cgi?id=23304
1489         Fix svn-apply to match svn-unapply to recognize added files in 'git diff' patches.
1490
1491         * Scripts/svn-apply: Added a check (similar to svn-unapply) to recognize added files.
1492
1493 2009-01-14  David Kilzer  <ddkilzer@apple.com>
1494
1495         BUILD FIX: Implement LayoutTestController::setIconDatabaseEnabled(bool) for GTK
1496
1497         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1498         (runTest): Added call to reset the icon database to match Mac
1499         and Windows ports.
1500         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1501         (LayoutTestController::setIconDatabaseEnabled): Implemented
1502         stub method.
1503
1504 2009-01-14  David Kilzer  <ddkilzer@apple.com>
1505
1506         Bug 22795: favicons should be saved to webarchives
1507
1508         <https://bugs.webkit.org/show_bug.cgi?id=22795>
1509
1510         Reviewed by Darin Adler.
1511
1512         * DumpRenderTree/LayoutTestController.cpp:
1513         (setIconDatabaseEnabledCallback): Added.
1514         (setJavaScriptProfilingEnabledCallback): Realphabetized.
1515         (LayoutTestController::staticFunctions): Added entry for calling
1516         LayoutTestController.setIconDatabaseEnabled(bool) from JavaScript.
1517         * DumpRenderTree/LayoutTestController.h:
1518         (setIconDatabaseEnabledCallback): Added declaration.
1519         (setJavaScriptProfilingEnabledCallback): Realphabetized.
1520
1521         * DumpRenderTree/mac/DumpRenderTree.mm:
1522         (runTest): Disable the icon database before each test.
1523         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1524         (LayoutTestController::setIconDatabaseEnabled): Added.
1525         (LayoutTestController::setJavaScriptProfilingEnabled): Realphabetized.
1526
1527         * DumpRenderTree/win/DumpRenderTree.cpp:
1528         (runTest): Disable the icon database before each test.
1529         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1530         (LayoutTestController::setIconDatabaseEnabled): Added.
1531
1532 2009-01-14  Steve Falkenburg  <sfalken@apple.com>
1533
1534         Update copyright year in version resources.
1535
1536         Reviewed by Adam Roben.
1537
1538         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
1539
1540 2009-01-14  Dan Bernstein  <mitz@apple.com>
1541
1542         Reviewed by John Sullivan.
1543
1544         - update copyright
1545
1546         * DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist:
1547         * WebKitLauncher/Info.plist:
1548
1549 2009-01-13  Anders Carlsson  <andersca@apple.com>
1550
1551         Reviewed by Sam Weinig.
1552
1553         Add NPRuntime test.
1554
1555         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1556         (testNPRuntime):
1557         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1558         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1559         (NPP_New):
1560         (NPP_GetValue):
1561
1562 2009-01-12  Mark Rowe  <mrowe@apple.com>
1563
1564         Use the modern spelling of WebKit.
1565
1566         * Scripts/find-extra-includes:
1567         * Scripts/report-include-statistics:
1568         * Scripts/run-webkit-app:
1569         * Scripts/svn-unapply:
1570         * Scripts/update-webkit:
1571
1572 2009-01-11  Darin Adler  <darin@apple.com>
1573
1574         * Scripts/make-js-test-wrappers: Updated so it won't overwrite tests in the svg/dom
1575         directory that aren't using standard wrappers.
1576
1577 2009-01-11  Robert Blaut  <webkit@blaut.biz>
1578
1579         Reviewed by Eric Seidel.
1580
1581         <https://bugs.webkit.org/show_bug.cgi?id=23134>
1582         Update bisect-builds for Safari 3.2 to prevent crashes
1583
1584         * Scripts/bisect-builds: Added Safari 3.2 and the corresponding minimal revision, r37348.
1585
1586 2009-01-08  Adam Treat  <adam.treat@torchmobile.com>
1587
1588         Reviewed by Simon Hausmann.
1589
1590         Explicitly set these so that the layout tests do not break.
1591
1592         * DumpRenderTree/qt/DumpRenderTree.cpp:
1593         (WebCore::WebPage::WebPage):
1594
1595 2009-01-07  Glenn Wilson  <gwilson@chromium.org>
1596
1597         Reviewed by Eric Seidel.
1598
1599         Changed DumpRenderTree to re-enable Javascript in web preferences on every test.
1600         This fixes the case when a user mistakenly disables Javascript, and all layout tests crash.
1601
1602         * DumpRenderTree/mac/DumpRenderTree.mm:
1603         (testStringByEvaluatingJavaScriptFromString):
1604         (setDefaultsToConsistentValuesForTesting):
1605
1606 2009-01-07  Holger Hans Peter Freyther  <zecke@selfish.org>
1607
1608         Reviewed by Maciej Stachowiak.
1609
1610         Implement numberOfActiveAnimations to fix the build
1611
1612         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1613         (LayoutTestController::numberOfActiveAnimations):
1614
1615 2009-01-07  Adam Treat  <adam.treat@torchmobile.com>
1616
1617         Reviewed by George Staikos.
1618
1619         Fix unused variable warnings
1620
1621         * DumpRenderTree/qt/DumpRenderTree.cpp:
1622         (WebCore::WebPage::javaScriptAlert):
1623         (WebCore::WebPage::javaScriptConfirm):
1624         (WebCore::WebPage::javaScriptPrompt):
1625         * DumpRenderTree/qt/jsobjects.cpp:
1626         (LayoutTestController::maybeDump):
1627         * DumpRenderTree/qt/main.cpp:
1628         (get_backtrace):
1629         * DumpRenderTree/qt/testplugin.cpp:
1630         (TestPlugin::create):
1631
1632 2009-01-06  Pierre-Olivier Latour  <pol@apple.com>
1633
1634         Reviewed by Darin Adler.
1635
1636         Added new JS API numberOfActiveAnimations() that returns the number of active CSS transitions & animations.
1637         This effectively exposes the new AnimationController::numberOfActiveAnimations() API from WebCore.
1638
1639         https://bugs.webkit.org/show_bug.cgi?id=23126
1640
1641         * DumpRenderTree/LayoutTestController.cpp:
1642         (numberOfActiveAnimationsCallback):
1643         (LayoutTestController::staticFunctions):
1644         * DumpRenderTree/LayoutTestController.h:
1645         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1646         (LayoutTestController::numberOfActiveAnimations):
1647         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1648         (LayoutTestController::numberOfActiveAnimations):
1649
1650 2009-01-04  David Kilzer  <ddkilzer@apple.com>
1651
1652         Don't install internal headers in WebKit framework
1653
1654         Reviewed by Darin Adler.
1655
1656         Since WebHTMLRepresentationInternal.h and WebTypesInternal.h are
1657         no longer installed in WebKit.framework/PrivateHeaders, use the
1658         special relationship of DumpRenderTree within the WebKit source
1659         tree to include the internal headers through relative paths.
1660         Created the concept of mac/InternalHeaders to hide the ugly
1661         paths.
1662
1663         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added
1664         mac/InternalHeaders to HEADER_SEARCH_PATHS.
1665         * DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Added.
1666         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h: Added.
1667
1668 2009-01-02  Adam Treat  <treat@kde.org>
1669
1670         Reviewed by George Staikos.
1671
1672         Add support for fixedLayoutSize to the qt DRT
1673
1674         * DumpRenderTree/qt/jsobjects.cpp:
1675         (LayoutTestController::setFixedLayoutSize):
1676         (LayoutTestController::setUseFixedLayout):
1677         * DumpRenderTree/qt/jsobjects.h:
1678
1679 2009-01-03  David D. Kilzer  <ddkilzer@webkit.org>
1680
1681         Bug 23091: Some webarchive http tests intermittently fail due to Connection/Keep-Alive header differences
1682
1683         <https://bugs.webkit.org/show_bug.cgi?id=23091>
1684
1685         Reviewed by Darin Adler.
1686
1687         * DumpRenderTree/mac/DumpRenderTree.mm:
1688         (normalizeHTTPResponseHeaderFields): Remove Keep-Alive and
1689         Connection headers from webarchive results.
1690
1691 2008-12-31  Zan Dobersek  <zandobersek@gmail.com>
1692
1693         Reviewed by Holger Freyther.
1694
1695         https://bugs.webkit.org/show_bug.cgi?id=22812
1696
1697         Prevent TestNetscapePlugin from installing system-wide.
1698
1699         * GNUmakefile.am:
1700
1701 2008-12-31  Zan Dobersek  <zandobersek@gmail.com>
1702
1703         Reviewed by Holger Freyther.
1704
1705         https://bugs.webkit.org/show_bug.cgi?id=22842
1706
1707         Move WebKitWebView's size allocation into a proper place.
1708
1709         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1710         (dump):
1711         (runTest):
1712
1713 2008-12-24  Mark Rowe  <mrowe@apple.com>
1714
1715         Reviewed by Timothy Hatcher.
1716
1717         Move the guts of determineCurrentSVNRevision to VCSUtils as svnRevisionForDirectory,
1718         and make it work for git too.
1719
1720         * Scripts/VCSUtils.pm:
1721         * Scripts/webkitdirs.pm:
1722
1723 2008-12-22  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
1724
1725         Reviewed by George Staikos.
1726
1727         Ignore http/tests/wml, if no WML support is present.
1728         Add http/tests/wml to list of HTTP tests, allowed to access local resources.
1729
1730         * Scripts/run-webkit-tests:
1731
1732 2008-12-19  David Levin  <levin@chromium.org>
1733
1734         Reviewed by Mark Rowe.
1735
1736         https://bugs.webkit.org/show_bug.cgi?id=22930
1737
1738         Make the git diff command used for preparing the change log avoid using any external diff tools.
1739
1740         * Scripts/prepare-ChangeLog:
1741
1742 2008-12-19  Gustavo Noronha Silva  <gns@gnome.org>
1743
1744         Reviewed by Holger Freyther.
1745
1746         https://bugs.webkit.org/show_bug.cgi?id=22686
1747
1748         Added files which were missing from the TestNetscapePlugin
1749         directory to the SOURCES variable, so that they will be
1750         distributed in a make dist.
1751
1752         * GNUMakefile.am:
1753
1754 2008-12-18  Cameron Zwarich  <zwarich@apple.com>
1755
1756         Reviewed by Geoff Garen.
1757
1758         Add tests for bug 21855: REGRESSION (r37323): Gmail complains about popup blocking when opening a link
1759         <https://bugs.webkit.org/show_bug.cgi?id=21855>
1760         <rdar://problem/6278244>
1761
1762         Add support for scheduling asynchronous clicks to DumpRenderTree, but
1763         only on the Mac.
1764
1765         * DumpRenderTree/mac/EventSendingController.h:
1766         * DumpRenderTree/mac/EventSendingController.mm:
1767         (+[EventSendingController isSelectorExcludedFromWebScript:]): Expose
1768         scheduleAsynchronousClick to JavaScript.
1769         (-[EventSendingController scheduleAsynchronousClick]): Add.
1770
1771 2008-12-15  Darin Adler  <darin@apple.com>
1772
1773         * Scripts/make-js-test-wrappers: Added another exception to avoid overwriting
1774         a custom-written test.
1775
1776 2008-12-15  Simon Hausmann  <hausmann@webkit.org>
1777
1778         Reviewed by Holger Freyther.
1779
1780         Implement setJavaScriptProfilingEnabled in the Qt DRT to pass fast/profiler.
1781
1782         * DumpRenderTree/qt/jsobjects.cpp:
1783         (LayoutTestController::setJavaScriptProfilingEnabled):
1784         * DumpRenderTree/qt/jsobjects.h:
1785
1786 2008-12-13  Zan Dobersek  <zandobersek@gmail.com>
1787
1788         Reviewed by Darin Adler.
1789
1790         https://bugs.webkit.org/show_bug.cgi?id=22039
1791
1792         Implement animation and transition pausing.
1793
1794         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1795         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1796         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1797
1798 2008-12-12  Brent Fulgham  <bfulgham@gmail.com>
1799
1800         Reviewed by Adam Roben.
1801
1802         https://bugs.webkit.org/show_bug.cgi?id=22809
1803
1804         Increase timeout in call to initWithURL so that people actually see
1805         new web pages when they type URLs rather than a blank screen.
1806
1807         * WinLauncher/WinLauncher.cpp:
1808         (loadURL):  Increase timeout in initWithURL from 0 to 60 seconds.
1809
1810 2008-12-12  Darin Adler  <darin@apple.com>
1811
1812         * Scripts/do-webcore-rename: Add a renaming idea.
1813
1814 2008-12-12  Holger Hans Peter Freyther  <zecke@selfish.org>
1815
1816         Reviewed by Simon Hausmann.
1817
1818         Update the WebKit.qrc and add a script to automatically generate the file.
1819
1820         With the way rcc and qmake work this can not be done at build time
1821         as the WebKit.qrc must sit inside the directory that contains the files
1822         and at build time we may not change the content of the source directory.
1823
1824         * Scripts/generate-qt-inspector-resource: Added.
1825
1826 2008-12-11  Cameron Zwarich  <zwarich@apple.com>
1827
1828         Rubber-stamped by Mark Rowe.
1829
1830         Roll out r39212 due to assertion failures during layout tests, multiple
1831         layout test failures, memory leaks, and obvious incorrectness.
1832
1833         * DumpRenderTree/LayoutTestController.cpp:
1834         (LayoutTestController::staticFunctions):
1835         * DumpRenderTree/LayoutTestController.h:
1836         * DumpRenderTree/mac/DumpRenderTree.mm:
1837         (resetWebViewToConsistentStateBeforeTesting):
1838         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1839         * DumpRenderTree/win/DumpRenderTree.cpp:
1840         (resetWebViewToConsistentStateBeforeTesting):
1841         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1842         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1843
1844 2008-12-10  Glenn Wilson  <gwilson@google.com>
1845
1846         Reviewed by Adam Roben.
1847
1848         Changed LayoutTestController and DumpRenderTree to allow for manual
1849         overriding of default preferences at test time.  Also added support for
1850         resetting the preferences after each test.
1851         https://bugs.webkit.org/show_bug.cgi?id=20534
1852
1853         * DumpRenderTree/LayoutTestController.cpp: Added callback method for overriding preferences
1854         * DumpRenderTree/LayoutTestController.h: Added signature for callback
1855         * DumpRenderTree/win/DumpRenderTree.cpp: Added calls to reset preferences after each test if necessary
1856         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added JS override function
1857         * DumpRenderTree/mac/DumpRenderTree.mm: Added calls to reset preferences after each test if necessary
1858         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Added JS override function
1859
1860 2008-12-10  Brady Eidson  <beidson@apple.com>
1861
1862         Reviewed by Darin Adler.
1863
1864         Implement the new policy delegate (including navigation type and permissive mode) for DRT/win
1865
1866         * DumpRenderTree/win/DumpRenderTree.cpp:
1867         * DumpRenderTree/win/DumpRenderTreeWin.h:
1868
1869         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1870         (LayoutTestController::setCustomPolicyDelegate):
1871
1872         * DumpRenderTree/win/PolicyDelegate.cpp:
1873         (PolicyDelegate::PolicyDelegate):
1874         (PolicyDelegate::decidePolicyForNavigationAction):
1875         * DumpRenderTree/win/PolicyDelegate.h:
1876         (PolicyDelegate::setPermissive):
1877
1878 2008-12-10  Brady Eidson  <beidson@apple.com>
1879
1880         Reviewed by Darin
1881
1882         Change the custom policy delegate to actually allow navigation for tests that need it.
1883         The new behavior is opt-in and doesn't require any changes in old tests.
1884
1885         * DumpRenderTree/LayoutTestController.cpp:
1886         (setCustomPolicyDelegateCallback):  Allow for a second boolean argument to set the permissive flag on the custom
1887           policy delegate, which will be false by default to maintain original behavior.
1888         * DumpRenderTree/LayoutTestController.h:
1889         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1890         (LayoutTestController::setCustomPolicyDelegate):
1891
1892         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1893         (LayoutTestController::setCustomPolicyDelegate):  Partially stubbed out for now.
1894         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1895         (LayoutTestController::setCustomPolicyDelegate):  Still stubbed out, but with new param.
1896
1897         * DumpRenderTree/mac/PolicyDelegate.h:
1898         * DumpRenderTree/mac/PolicyDelegate.mm:
1899         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):  If the permissive flag
1900           is set, allow the navigation.
1901         (-[PolicyDelegate setPermissive:]):  Change the behavior between "use" and "ignore" - allowing navigation or not.
1902
1903 2008-12-09  Mark Rowe  <mrowe@apple.com>
1904
1905         Rubber-stamped by Ada Chan.
1906
1907         Fix gdb-safari on Tiger.
1908
1909         gdb on Tiger does not take the -arch flag, so do not pass it.
1910
1911         * Scripts/gdb-safari:
1912
1913 2008-12-09  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
1914
1915         Reviewed by Alexey Proskuryakov.
1916
1917         Ignore WML tests, if no WML support available.
1918
1919         * Scripts/run-webkit-tests:
1920
1921 2008-12-08  Geoffrey Garen  <ggaren@apple.com>
1922
1923         Reviewed by Oliver Hunt.
1924
1925         Added a shortcut for --jsDriver-args, which I use a lot.
1926
1927         * Scripts/run-javascriptcore-tests:
1928
1929 2008-12-08  Stephanie Lewis  <slewis@apple.com>
1930
1931         Fix Tiger build.
1932
1933         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1934
1935 2008-12-08  Darin Adler  <darin@apple.com>
1936
1937         Reviewed by John Sullivan.
1938
1939         - test machinery for https://bugs.webkit.org/show_bug.cgi?id=22409
1940           REGRESSION: cmd-shift-left/right don't switch tabs, instead select text
1941
1942         * DumpRenderTree/LayoutTestController.cpp:
1943         (isCommandEnabledCallback): Added.
1944         (LayoutTestController::staticFunctions): Added "isCommandEnabled".
1945         * DumpRenderTree/LayoutTestController.h: Ditto.
1946         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1947         (LayoutTestController::isCommandEnabled): Ditto.
1948         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1949         (-[CommandValidationTarget initWithAction:]): Added. Used to get the
1950         command validation system to tell us if a comment is enabled.
1951         (-[CommandValidationTarget action]): Ditto.
1952         (-[CommandValidationTarget tag]): Ditto.
1953         (LayoutTestController::isCommandEnabled): Ditto.
1954         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1955         (LayoutTestController::isCommandEnabled): Ditto.
1956
1957 2008-12-08  David Kilzer  <ddkilzer@apple.com>
1958
1959         Bug 22555: Sort "children" sections in Xcode project files
1960
1961         <https://bugs.webkit.org/show_bug.cgi?id=22555>
1962
1963         Reviewed by Eric Seidel.
1964
1965         * DrawTest/DrawTest.xcodeproj/project.pbxproj: Sorted.
1966         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Sorted.
1967         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Sorted.
1968
1969 2008-12-08  David Kilzer  <ddkilzer@apple.com>
1970
1971         Bug 22555: Sort "children" sections in Xcode project files
1972
1973         <https://bugs.webkit.org/show_bug.cgi?id=22555>
1974
1975         Reviewed by Timothy Hatcher.
1976
1977         * Scripts/sort-Xcode-project-file: By popular request, don't sort
1978         the mainGroup in the project (the list of items below the top-level
1979         project file).
1980
1981 2008-12-05  David Kilzer  <ddkilzer@apple.com>
1982
1983         Bug 22555: Sort "children" sections in Xcode project files
1984
1985         <https://bugs.webkit.org/show_bug.cgi?id=22555>
1986
1987         Reviewed by Darin Adler.
1988
1989         Sort "children" sections alphabetically, moving groups (folders) to
1990         the top of each of the lists.  Files are assumed to have extensions,
1991         so %isFile is used to override this behavior.
1992
1993         * Scripts/sort-Xcode-project-file:
1994         (sortChildrenByFileName): Added.
1995         (sortFilesByFileName): Renamed from sortByFileName().
1996
1997 2008-12-05  Eric Seidel  <eric@webkit.org>
1998
1999         Reviewed by Geoff Garen.
2000
2001         https://bugs.webkit.org/show_bug.cgi?id=22683
2002         Fix gtk and qt builds which depend on --qt and --gtk being removed from ARGV
2003         Add a new argumentsForConfiguration() function and clean up some old code to use it.
2004         Rename checkArgV to checkForArgumentAndRemoveFromARGV to be more self-documenting.
2005
2006         * Scripts/run-javascriptcore-tests:
2007         * Scripts/run-launcher:
2008         * Scripts/run-webkit-tests:
2009         * Scripts/webkitdirs.pm:
2010
2011 2008-12-03  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
2012
2013         Reviewed by Cameron Zwarich.
2014
2015         Further preparations for WML layout tests.
2016         Ignore WMLTestCase.js, that's going to be in trunk soon.
2017
2018         * Scripts/make-js-test-wrappers:
2019
2020 2008-12-03  Eric Seidel  <eric@webkit.org>
2021
2022         Build fix for --gtk and --chromium, no review.
2023
2024         Fix run-javascriptcore-tests to pass --gtk, --qt, --chromium, etc.
2025         through to build-jsc.
2026
2027         * Scripts/build-jsc:
2028         * Scripts/webkitdirs.pm:
2029
2030 2008-12-03  Eric Seidel  <eric@webkit.org>
2031
2032         Build fix only, no review.
2033
2034         Remove support for build-webkit --svg-experimental.
2035         All of the "experimental" svg features have their own toggles anyway.
2036         I broke --svg-experimental in my last commit (which then broke clean builds)
2037         I can't find any use of --svg-experimental in our source tree, so removing it.
2038
2039         * Scripts/build-webkit:
2040
2041 2008-12-02  Eric Seidel  <eric@webkit.org>
2042
2043         Reviewed by David Hyatt (and Mark Rowe).
2044
2045         Move --coverage support from build-webkit to webkitdirs.pm to share it with build-jsc
2046         Move --coverage support out of run-javascriptcore-tests and into build-jsc
2047
2048         Finally add a buildXCodeProject function to webkitdirs.pm and move --clean support
2049         there from build-webkit (to allow future sharing with other build-* scripts)
2050
2051         Change run-javascriptcore-tests to expect a --jsDriver-args= argument instead of
2052         picking through ARGV with a blacklist of what arguments weren't jsDriver args
2053         this makes run-javascriptcore-tests transparently support all arguments which
2054         webkitdirs.pm gives it support for.
2055
2056         Make run-javascriptcore-tests actually print what commands it's running before running them.
2057
2058         Add --help support to build-jsc and run-javascriptcore-tests!
2059
2060         Make code to support --svg-experimental defaults take up half as many lines.
2061
2062         * Scripts/build-jsc:
2063         * Scripts/build-webkit:
2064         * Scripts/run-javascriptcore-tests:
2065         * Scripts/webkitdirs.pm:
2066
2067 2008-12-03  Adam Roben  <aroben@apple.com>
2068
2069         Fix a leak in WinLauncher shutdown
2070
2071         Reviewed by Sam Weinig.
2072
2073         * WinLauncher/WinLauncher.cpp:
2074         (_tWinMain): Replaced a delete with a Release. We can't delete the
2075         WebView properly since we only have a pointer to one of its
2076         interfaces. We also shouldn't be deleting COM objects directly anyway,
2077         for a number of reasons.
2078
2079 2008-12-03  Adam Roben  <aroben@apple.com>
2080
2081         Fix a crash on exit in WinLauncher
2082
2083         Reviewed by Sam Weinig.
2084
2085         * WinLauncher/WinLauncher.cpp:
2086         (_tWinMain): Call shutDownWebKit before exiting.
2087
2088 2008-12-03  Adam Roben  <aroben@apple.com>
2089
2090         Add a Debug_Internal configuration to WinLauncher
2091
2092         This matches our other projects.
2093
2094         Reviewed by Sam Weinig.
2095
2096         * WinLauncher/WinLauncher.vcproj: Added a Debug_Internal
2097         configuration, which is identical to Debug except that it also
2098         references debug_internal.vsprops. Also removed some settings that we
2099         should be picking up from the .vsprops files.
2100
2101 2008-12-02  Eric Seidel  <eric@webkit.org>
2102
2103         Reviewed by David Kilzer.
2104
2105         Hack build-webkit --chromium to use Win32 python instead
2106         of using the default cygwin python.  Scons + CYGWIN tries
2107         to build with GCC by default, we force MSVC in our file
2108         but that just results in errors from Scons.  Until we can fix
2109         this latest round of errors, at least make build-webkit --chromium
2110         actually "work" under CYGWIN instead of forcing users to use
2111         a cmd shell directly.
2112
2113         This is working around a Scons bug:
2114         http://scons.tigris.org/issues/show_bug.cgi?id=2266
2115
2116         * Scripts/webkitdirs.pm:
2117
2118 2008-12-01  David Kilzer  <ddkilzer@apple.com>
2119
2120         Bug 22466: REGRESSION (35867): Many resources missing when saving webarchive of webkit.org
2121
2122         <https://bugs.webkit.org/show_bug.cgi?id=22466>
2123         <rdar://problem/6403593>
2124
2125         Reviewed by Brady Eidson.
2126
2127         * DumpRenderTree/mac/DumpRenderTree.mm:
2128         (normalizeHTTPResponseHeaderFields): Added.  Normalizes Date, Etag,
2129         Keep-Alive, Last-Modified and Server header fields to prevent false
2130         positive test failures.
2131         (convertWebResourceResponseToDictionary): Call
2132         normalizeHTTPResponseHeaderFields() to noramlize HTTP response
2133         header fields.
2134
2135 2008-12-01  David D. Kilzer  <ddkilzer@webkit.org>
2136
2137         Bug 22559: Report builds left to test in bisect-builds (like git-bisect)
2138
2139         <https://bugs.webkit.org/show_bug.cgi?id=22559>
2140
2141         Reviewed by Adam Roben.
2142
2143         * Scripts/bisect-builds: Updated status message to report the
2144         maximum number of builds left to test after the current one.
2145         (max): Added.
2146
2147 2008-11-27  Alp Toker  <alp@nuanti.com>
2148
2149         Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
2150         API header breakage at build time.
2151
2152         * GNUmakefile.am:
2153
2154 2008-11-26  Eric Seidel  <eric@webkit.org>
2155
2156         Reviewed by Nikolas Zimmermann and Mark Rowe.
2157
2158         Add support for build-webkit --chromium
2159         https://bugs.webkit.org/show_bug.cgi?id=22515
2160         More cleanups changing isCygwin calls to isAppleWinWebKit and deploying isAppleWebKit where necessary.
2161
2162         * Scripts/build-dumprendertree:
2163         * Scripts/build-jsc:
2164         * Scripts/build-webkit:
2165         * Scripts/gdb-safari:
2166         * Scripts/run-webkit-tests:
2167         * Scripts/webkitdirs.pm:
2168
2169 2008-11-26  Eric Seidel  <eric@webkit.org>
2170
2171         Reviewed by Nikolas Zimmermann.
2172
2173         Add support for build-webkit --chromium (tested on mac)
2174         https://bugs.webkit.org/show_bug.cgi?id=22515
2175         Also simplified some code using checkArgv
2176
2177         * Scripts/build-webkit:
2178         * Scripts/webkitdirs.pm:
2179
2180 2008-11-26  Eric Seidel  <eric@webkit.org>
2181
2182         Reviewed by Nikolas Zimmermann.
2183
2184         More pre-work for adding a build-webkit --chromium which works on Mac and Windows
2185         https://bugs.webkit.org/show_bug.cgi?id=22515
2186         Change a few calls to isCygwin to isAppleWinWebKit and a few calls to isAppleMacWebKit to isDarwin
2187         in preparation for having a chromium cygwin and chromium mac build
2188
2189         * Scripts/build-webkit:
2190         * Scripts/webkitdirs.pm:
2191
2192 2008-11-26  Eric Seidel  <eric@webkit.org>
2193
2194         Reviewed by Nikolas Zimmermann.
2195
2196         Pre-work for getting build-webkit --chromium to work
2197         https://bugs.webkit.org/show_bug.cgi?id=22515
2198         Rename isOSX to isAppleMacWebKit to match what the code does, and add isChromium()
2199
2200         * Scripts/build-dumprendertree:
2201         * Scripts/build-jsc:
2202         * Scripts/build-webkit:
2203         * Scripts/gdb-safari:
2204         * Scripts/run-javascriptcore-tests:
2205         * Scripts/run-webkit-tests:
2206         * Scripts/webkitdirs.pm:
2207
2208 2008-11-26  David Kilzer  <ddkilzer@apple.com>
2209
2210         Bug 22488: Make DRT smarter about charset encoding when post-processing webarchive content
2211
2212         <https://bugs.webkit.org/show_bug.cgi?id=22488>
2213
2214         Reviewed by Brady Eidson.
2215
2216         * DumpRenderTree/mac/DumpRenderTree.mm:
2217         (convertWebResourceDataToString): If an IANA charset encoding string
2218         is provided, convert it to a CFStringEncoding value and then to an
2219         NSStringEncoding value, else fall back to NSUTF8StringEncoding.  We
2220         also nil-check dataAsString, so the worst-case scenario is that the
2221         data won't be decoded to a string (versus crashing DumpRenderTree).
2222
2223 2008-11-26  Jan Michael Alonzo  <jmalonzo@webkit.org>
2224
2225         Reviewed by Holger Freyther.
2226
2227         [Gtk] add/remove tests from Skipped and fix netscape plugin test
2228         https://bugs.webkit.org/show_bug.cgi?id=22484
2229
2230         Remove print'ing to stderr
2231
2232         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2233         (NP_Initialize):
2234         (NP_Shutdown):
2235
2236 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
2237
2238         Windows build fix.
2239
2240         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2241
2242 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
2243
2244         Windows build fix.
2245
2246         * DumpRenderTree/cg/ImageDiffCG.cpp:
2247
2248 2008-11-24  Darin Fisher  <darin@chromium.org>
2249
2250         Fix bustage.
2251
2252         https://bugs.webkit.org/show_bug.cgi?id=15643
2253
2254         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2255         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
2256
2257 2008-11-24  Glenn Wilson  <gwilson@chromium.org>
2258
2259         Reviewed by Alexey Proskuryakov.
2260
2261         http://bugs.webkit.org/show_bug.cgi?id=15643
2262
2263         Added support for changing the "trailing whitespace" work-around
2264         in LayoutTestController (so layout tests can verify this functionality)
2265
2266         * DumpRenderTree/LayoutTestController.cpp:
2267         (setSelectTrailingWhitespaceEnabledCallback):
2268         (LayoutTestController::staticFunctions):
2269         * DumpRenderTree/LayoutTestController.h:
2270         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2271         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
2272         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2273         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
2274
2275 2008-11-24  Simon Fraser  <simon.fraser@apple.com>
2276
2277         Reviewed by Darin Adler
2278
2279         https://bugs.webkit.org/show_bug.cgi?id=22433
2280
2281         Add script that attempts to detect virtual methods
2282         whose signatures differ only by constness (which can
2283         indicate a programming error).
2284
2285         * Scripts/detect-mismatched-virtual-const: Added.
2286
2287 2008-11-24  Zan Dobersek  <zandobersek@gmail.com>
2288
2289         Reviewed by Holger Freyther.
2290
2291         https://bugs.webkit.org/show_bug.cgi?id=22039
2292
2293         [Gtk+] Implement TestNetscapePlugin for Gtk+ port and add it to the
2294         build.
2295
2296         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2297         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
2298         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2299         (setDefaultsToConsistentStateValuesForTesting):
2300         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: Added.
2301         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: Added.
2302         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: Added.
2303         * GNUmakefile.am:
2304
2305 2008-11-24  Holger Hans Peter Freyther  <zecke@selfish.org>
2306
2307         Reviewed by Mark Rowe.
2308
2309         [Gtk+] Add configure option to enable Web Workers and enable it by default
2310
2311         Add --enable-workers to the buildsystem (used by build-webkit) add
2312         the to be build files to the GNUmakefile.am and change build-webkit
2313         to enable Web Workers by default.
2314
2315         * Scripts/build-webkit:
2316
2317 2008-11-24  Mark Rowe  <mrowe@apple.com>
2318
2319         Reviewed by Alexey Proskuryakov.
2320
2321         Let gdb-safari accept the --debug and --release options once more.
2322
2323         * Scripts/gdb-safari:
2324
2325 2008-11-23  Zan Dobersek  <zandobersek@gmail.com>
2326
2327         Reviewed by Holger Freyther. Landed by Jan Alonzo.
2328
2329         Get SVG tests tested on GTK port.
2330
2331         * Scripts/webkitdirs.pm:
2332
2333 2008-11-19  Greg Bolsinga  <bolsinga@apple.com>
2334
2335         Reviewed by Darin Adler.
2336
2337         https://bugs.webkit.org/show_bug.cgi?id=21810
2338         Remove use of static C++ objects that are destroyed at exit time (destructors)
2339
2340         All static C++ objects that create atexit calls are gone. Update script
2341         to indicate how to fix the problem should a new one appear.
2342
2343         * Scripts/check-for-exit-time-destructors:
2344
2345 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
2346
2347         Reviewed by Darin Adler.
2348
2349         https://bugs.webkit.org/show_bug.cgi?id=22337
2350         Enable workers by default
2351
2352         * Scripts/build-webkit: Changed the default to enabled.
2353
2354 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
2355
2356         Rubber-stamped by Darin Adler.
2357
2358         https://bugs.webkit.org/show_bug.cgi?id=22306
2359         Disable channel messaging support
2360
2361         * Scripts/build-webkit: Add an option to enable channel messaging.
2362
2363 2008-11-17  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
2364
2365         Reviewed by George Staikos.
2366
2367         Add --(no-)wml build flags.
2368
2369         * Scripts/build-webkit:
2370         * Scripts/run-webkit-tests:
2371         * Scripts/webkitdirs.pm:
2372
2373 2008-11-17  Geoffrey Garen  <ggaren@apple.com>
2374
2375         Not reviewed.
2376
2377         Try to fix gtk build.
2378
2379         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2380         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2381         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2382
2383 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
2384
2385         Reviewed by Maciej.
2386
2387         Pixel tests should use a default tolerance of 0.1% on Leopard and 1.0%
2388         on Tiger.
2389
2390         https://bugs.webkit.org/show_bug.cgi?id=22271
2391
2392         * Scripts/run-webkit-tests:
2393
2394 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
2395
2396         Reviewed by Sam Weinig.
2397
2398         Added new JavaScript API on LayoutController to pause a running
2399         CSS transition or animation at a given time.
2400
2401         https://bugs.webkit.org/show_bug.cgi?id=21261
2402
2403         * DumpRenderTree/LayoutTestController.cpp:
2404         (pauseAnimationAtTimeOnElementWithIdCallback):
2405         (pauseTransitionAtTimeOnElementWithIdCallback):
2406         (LayoutTestController::staticFunctions):
2407         * DumpRenderTree/LayoutTestController.h:
2408         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2409         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2410         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2411         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2412         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2413         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2414
2415 2008-11-17  Gabor Loki  <loki@inf.u-szeged.hu>
2416
2417         Reviewed by Darin Adler.
2418
2419         <https://bugs.webkit.org/show_bug.cgi?id=22309>
2420         Pass the remaining options to build system on Qt-port
2421
2422         * Scripts/build-webkit:
2423         * Scripts/webkitdirs.pm:
2424
2425 2008-11-16  Greg Bolsinga  <bolsinga@apple.com>
2426
2427         Reviewed by Darin Adler.
2428
2429         https://bugs.webkit.org/show_bug.cgi?id=21810
2430         Remove use of static C++ objects that are destroyed at exit time (destructors)
2431
2432         Remove .o files from the exclude list that have had their exit-time destructors removed.
2433         Handle case when there is no current symbol.
2434
2435         * Scripts/check-for-exit-time-destructors:
2436
2437 2008-11-16  Sam Weinig  <sam@webkit.org>
2438
2439         * Scripts/do-webcore-rename: Remove now fixed renames.
2440
2441 2008-11-16  Darin Adler  <darin@apple.com>
2442
2443         * Scripts/do-webcore-rename: Plan some future renames.
2444
2445 2008-11-15  Darin Adler  <darin@apple.com>
2446
2447         Rubber stamped by Geoff Garen.
2448
2449         - do the long-planned StructureID -> Structure rename
2450
2451         * Scripts/check-for-global-initializers: Update name of StructureID.o.
2452         * Scripts/do-webcore-rename: Renaming script that I used.
2453
2454 2008-11-15  Greg Bolsinga  <bolsinga@apple.com>
2455
2456         Reviewed by Darin Adler.
2457
2458         https://bugs.webkit.org/show_bug.cgi?id=21810
2459         Remove use of static C++ objects that are destroyed at exit time (destructors)
2460
2461         Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
2462         exit-time destructor. Update code that was changed to fix this issue that ran
2463         into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
2464         in gcc build 5465). Also typdefs for template types needed to be added in some
2465         cases so the type could make it through the macro successfully.
2466
2467         Basically code of the form:
2468         static T m;
2469         becomes:
2470         DEFINE_STATIC_LOCAL(T, m, ());
2471
2472         Also any code of the form:
2473         static T& m = *new T;
2474         also becomes:
2475         DEFINE_STATIC_LOCAL(T, m, ());
2476
2477         Remove .o files from the exclude list that have had their exit-time destructors removed.
2478
2479         * Scripts/check-for-exit-time-destructors:
2480
2481 2008-11-14  Kevin Ollivier  <kevino@theolliviers.com>
2482
2483         wx mac buildbot fix. Also, make sure we don't keep hitting this problem.
2484
2485         * wx/install-unix-extras:
2486
2487 2008-11-14  Alp Toker  <alp@nuanti.com>
2488
2489         GTK DRT build fix for gcc 4.4 snapshot. Add missing stdio include.
2490
2491         Fixes Debian bug #505723
2492         http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505723
2493
2494         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2495
2496 2008-11-14  Krishna <krishnamurty.podipireddy@nokia.com>
2497
2498         Reviewed by Simon Hausmann.
2499
2500         Fix hanging DRT with Qt.
2501
2502         https://bugs.webkit.org/show_bug.cgi?id=22209
2503
2504         * DumpRenderTree/qt/DumpRenderTree.cpp:
2505         (WebCore::DumpRenderTree::dump):
2506         Send empty pixel test data 'block', which is now
2507         expected by run-layout-tests.
2508
2509 2008-11-12  Dmitry Titov  <dimich@chromium.org>
2510
2511         Reviewed by Alexey Proskuryakov.
2512
2513         https://bugs.webkit.org/show_bug.cgi?id=22216
2514
2515         * Scripts/build-webkit:
2516         Addes ENABLE_WORKERS to build-webkit so it's possible to build with workers enabled.
2517
2518 2008-11-06  David Kilzer  <ddkilzer@apple.com>
2519
2520         BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
2521
2522         Apparently older versions of gcc have issues with this patch.
2523         Backing out a second time until the issues are resolved.
2524
2525 2008-11-06  David Kilzer  <ddkilzer@apple.com>
2526
2527         BUILD WAS NOT BROKEN: Rolling r38189 back in.
2528
2529         Please perform a clean build if you see crashes.
2530
2531 2008-11-06  David Kilzer  <ddkilzer@apple.com>
2532
2533         BUILD FIX: Backed out r38189 since it apparently broke the world.
2534
2535 2008-11-06  Chris Fleizach  <cfleizach@apple.com>
2536
2537         Reviewed by Beth Dakin.
2538
2539         Add ability to query an attribute's settable status and the
2540         ability to retrieve a single attribute from an AXObject
2541
2542         * DumpRenderTree/AccessibilityUIElement.cpp:
2543         (isAttributeSettableCallback):
2544         (attributeValueCallback):
2545         (AccessibilityUIElement::getJSClass):
2546         * DumpRenderTree/AccessibilityUIElement.h:
2547         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2548         (+[NSString stringWithJSStringRef:]):
2549         (AccessibilityUIElement::attributeValue):
2550         (AccessibilityUIElement::isAttributeSettable):
2551         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2552         (AccessibilityUIElement::attributeValue):
2553         (AccessibilityUIElement::isAttributeSettable):
2554
2555 2008-11-06  Greg Bolsinga  <bolsinga@apple.com>
2556
2557         Reviewed by Darin Adler.
2558
2559         Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
2560         https://bugs.webkit.org/show_bug.cgi?id=21810
2561
2562         Remove .o files from the exclude list that have had their exit-time destructors removed.
2563
2564         * Scripts/check-for-exit-time-destructors:
2565
2566 2008-11-05  Alp Toker  <alp@nuanti.com>
2567
2568         GTK build script tweak.
2569
2570         Make the path relative since it will appear in all -I compiler flags.
2571         Long argument lists cause bizarre slowdowns in libtool and result
2572         in huge build logs.
2573
2574         * Scripts/webkitdirs.pm:
2575
2576 2008-11-05  Anders Carlsson  <andersca@apple.com>
2577
2578         Fix 64-bit build.
2579
2580         * DumpRenderTree/mac/DumpRenderTree.mm:
2581         (setDefaultsToConsistentValuesForTesting):
2582
2583 2008-11-04  Simon Fraser  <simon.fraser@apple.com>
2584
2585         Add AccessibilityObject.o to the exclude list for the
2586         check for global destructors.
2587
2588         * Scripts/check-for-exit-time-destructors:
2589
2590 2008-11-04  Darin Adler  <darin@apple.com>
2591
2592         * Scripts/check-for-exit-time-destructors: Fix failures seen on the
2593         bot, but for some reason not on my computer.
2594
2595 2008-11-03  Darin Adler  <darin@apple.com>
2596
2597         Reviewed by Tim Hatcher.
2598
2599         - https://bugs.webkit.org/show_bug.cgi?id=22061
2600           create script to check for exit-time destructors
2601
2602         * Scripts/check-for-exit-time-destructors: Added.
2603         Started as a copy of check-for-global-initializers.
2604
2605         * Scripts/check-for-global-initializers: Added code to make
2606         this script rerun any time it's modified, and also to properly
2607         run again after the first time it reports an error.
2608
2609 2008-11-03  Pierre-Olivier Latour  <pol@apple.com>
2610
2611         Reviewed by Dan Bernstein.
2612
2613         Fixed the override of the "AppleScrollBarVariant" system setting to also work with HIToolbox.
2614
2615         https://bugs.webkit.org/show_bug.cgi?id=22054
2616
2617         * DumpRenderTree/mac/DumpRenderTree.mm:
2618         (setDefaultsToConsistentValuesForTesting):
2619
2620 2008-10-31  Cameron Zwarich  <zwarich@apple.com>
2621
2622         Not reviewed.
2623
2624         * Scripts/do-webcore-rename:
2625
2626         Add some renames to contemplate for the future.
2627
2628 2008-10-31  Darin Adler  <darin@apple.com>
2629
2630         Requested by Mark Rowe.
2631
2632         * Scripts/check-for-global-initializers: s/Web Kit/WebKit/.
2633
2634 2008-10-31  David Kilzer  <ddkilzer@apple.com>
2635
2636         Bug 21997: prepare-ChangeLog should filter out ChangeLog files
2637
2638         <https://bugs.webkit.org/show_bug.cgi?id=21997>
2639
2640         Reviewed by Darin Adler.
2641
2642         * Scripts/prepare-ChangeLog:
2643         (generateFileList): Don't add ChangeLog files to %{$functionLists}.
2644         This prevents them from showing up in the new ChangeLog entry.  They
2645         were already excluded from @{$changedFiles}.
2646
2647 2008-10-30  Mark Rowe  <mrowe@apple.com>
2648
2649         Reviewed by Jon Homeycutt.
2650
2651         Explicitly default to building for only the native architecture in debug and release builds.
2652
2653         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2654
2655 2008-10-30  Pierre-Olivier Latour  <pol@apple.com>
2656
2657         Reviewed by Dan Bernstein.
2658
2659         Fixed 64 bit build failure.
2660
2661         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2662         (setupMainDisplayColorProfile):
2663         (createBitmapContextFromWebView):
2664
2665 2008-10-28  Alp Toker  <alp@nuanti.com>
2666
2667         Fix GTK DRT following build breakage in r37928.
2668
2669         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2670         (dump):
2671         (runTest):
2672         (main):
2673
2674 2008-10-28  Alp Toker  <alp@nuanti.com>
2675
2676         Reviewed by Mark Rowe.
2677
2678         Fix recently introduced double-free crashes in GTK DRT.
2679
2680         LayoutTestController was made ref-counted in r36606 and Mac/Win DRT
2681         were updated to call ->deref() but GTK DRT was still deleting
2682         gLayoutTestController manually. This patch updates GTK to match the
2683         other ports and resolves the memory allocation issues.
2684
2685         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2686         (runTest):
2687
2688 2008-10-28  Alp Toker  <alp@nuanti.com>
2689
2690         Reviewed by Mark Rowe.
2691
2692         Fix GTK DRT hang when running the tests.
2693
2694         Update output from the DRT tool to print an additional '#EOF' to match
2695         breaking changes that were made in r37434.
2696
2697         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2698         (dump):
2699
2700 2008-10-28  Adele Peterson  <adele@apple.com>
2701
2702         Reviewed by Sam Weinig.
2703
2704         Specify which Localizable.strings to update since we don't always want to update the file in the same
2705         directory where we're searching for the strings to localize.
2706
2707         * Scripts/extract-localizable-strings:
2708         * Scripts/update-webkit-localizable-strings:
2709
2710 2008-10-28  Timothy Hatcher  <timothy@apple.com>
2711
2712         Add support for enabling the profiler, so the profiling tests can continue
2713         work now that the profiler is not always enabled.
2714
2715         https://bugs.webkit.org/show_bug.cgi?id=21927
2716
2717         <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
2718         not slow down JavaScript all the time
2719
2720         Reviewed by Darin Adler and Kevin McCullough.
2721
2722         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
2723         * DumpRenderTree/LayoutTestController.cpp:
2724         (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled.
2725         (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
2726         * DumpRenderTree/LayoutTestController.h:
2727         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2728         (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
2729         * DumpRenderTree/mac/DumpRenderTree.mm:
2730         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
2731         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2732         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
2733         * DumpRenderTree/win/DumpRenderTree.cpp:
2734         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
2735         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2736         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
2737
2738 2008-10-28  Pierre-Olivier Latour  <pol@apple.com>
2739
2740         Reviewed by Dan Bernstein
2741
2742         Primary changes in DumpRenderTree:
2743         - Ensure font smoothing is disabled (this is also called LCD anti-aliasing and
2744         is different from regular font CG anti-aliasing) as font-smoothing settings
2745         depends on the display and can also be changed by the user
2746         - Use a new cleared buffer for each test instead of the reusing same one to
2747         avoid potential result corruption across tests
2748         - Can now receive the expected pixel hash as a suffix to the test path or
2749         url as "path'hash"
2750         - Make sure hash is computed in a endian-independent way
2751         - Improve the code that sets/restores the screen color profile
2752         - Make the code more cross-platformy with std::string goodness
2753         - Added an "on-screen" mode where the snapshot will take into account surfaces
2754         on the window (like OpenGL content): this uses the new CG APIs on 10.5 or
2755         reading from the display framebuffer on 10.4. This mode is not active by
2756         default for performance reason, but must be explicitly activated from the test
2757         file using the new "testOnscreen()" JS API.
2758
2759         Primary changes in ImageDiff:
2760         - Provide a new comparison algorithm that is more tolerant to "acceptable"
2761         failures (i.e. very small differences in font rendering, which --threshold is
2762         not really good at handling)
2763         - Generate normalized intensity-only diff images
2764
2765         Primary changes in run-webkit-tests:
2766         - Take advantage of hashes for pixel tests which makes them much faster by
2767         minimizing image comparisons
2768         - Removed repaint options as these should be set from within test files using
2769         JS API
2770         - Replaced "threshold" option in  by "tolerance" expressed in percents
2771         - Added more logging when in "verbose" mode
2772
2773         https://bugs.webkit.org/show_bug.cgi?id=21322
2774         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2775         * DumpRenderTree/ForwardingHeaders/wtf/PassRefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/PassRefPtr.h.
2776         * DumpRenderTree/ForwardingHeaders/wtf/RefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefPtr.h.
2777         * DumpRenderTree/LayoutTestController.cpp:
2778         (LayoutTestController::LayoutTestController):
2779         (testOnscreenCallback):
2780         (LayoutTestController::staticFunctions):
2781         * DumpRenderTree/LayoutTestController.h:
2782         (LayoutTestController::testOnscreen):
2783         (LayoutTestController::setTestOnscreen):
2784         (LayoutTestController::testPathOrURL):
2785         (LayoutTestController::expectedPixelHash):
2786         * DumpRenderTree/PixelDumpSupport.h:
2787         * DumpRenderTree/cg/ImageDiffCG.cpp:
2788         (strtof):
2789         (releaseMallocBuffer):
2790         (createDifferenceImage):
2791         (imageHasAlpha):
2792         (main):
2793         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2794         (computeMD5HashStringForBitmapContext):
2795         (dumpWebViewAsPixelsAndCompareWithExpected):
2796         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2797         (BitmapContext::createByAdoptingBitmapAndContext):
2798         (BitmapContext::~BitmapContext):
2799         (BitmapContext::cgContext):
2800         (BitmapContext::BitmapContext):
2801         * DumpRenderTree/mac/DumpRenderTree.mm:
2802         (shouldIgnoreWebCoreNodeLeaks):
2803         (setDefaultsToConsistentValuesForTesting):
2804         (crashHandler):
2805         (initializeGlobalsFromCommandLineOptions):
2806         (prepareConsistentTestingEnvironment):
2807         (dumpRenderTree):
2808         (sizeWebViewForCurrentTest):
2809         (dump):
2810         (runTest):
2811         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2812         (restoreMainDisplayColorProfile):
2813         (setupMainDisplayColorProfile):
2814         (createBitmapContextFromWebView):
2815         * DumpRenderTree/win/DumpRenderTree.cpp:
2816         (dump):
2817         (runTest):
2818         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2819         (getBitmapContextFromWebView):
2820         * Scripts/run-webkit-tests:
2821
2822 2008-10-27  Kevin Ollivier  <kevino@theolliviers.com>
2823
2824         wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.
2825
2826         * wx/build-wxwebkit:
2827
2828 2008-10-24  Anders Carlsson  <andersca@apple.com>
2829
2830         Try fixing the 64-bit build.
2831
2832         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
2833         (testGetProperty):
2834
2835 2008-10-24  Anders Carlsson  <andersca@apple.com>
2836
2837         Reviewed by Sam Weinig.
2838
2839         <rdar://problem/5440917> Support NPN_Construct
2840
2841         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2842         (testCallback):
2843         Fix a memory leak.
2844
2845         (testConstruct):
2846         New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.
2847
2848         (pluginInvoke):
2849         Handle testConstruct.
2850
2851         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
2852         (testGetProperty):
2853         Add objectPointer property.
2854
2855         (testEnumerate):
2856         Only enumerate the two first properties.
2857
2858         (testConstruct):
2859         Add a simple construct implementation that just returns the test object.
2860
2861 2008-10-24  David Kilzer  <ddkilzer@apple.com>
2862
2863         Bug 21850: svn-apply and svn-unapply should preserve patch line endings
2864
2865         <https://bugs.webkit.org/show_bug.cgi?id=21850>
2866
2867         Reviewed by Adam Roben.
2868
2869         * Scripts/svn-apply: Save end-of-line characters when stripping them
2870         off each line of a patch so that they may be restored after
2871         processing the line.
2872         * Scripts/svn-unapply: Ditto.
2873
2874 2008-10-23  David Kilzer  <ddkilzer@apple.com>
2875
2876         Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10
2877
2878         <https://bugs.webkit.org/show_bug.cgi?id=21832>
2879
2880         Reviewed by Sam Weinig.
2881
2882         * Scripts/bisect-builds: Use imported tempfile() from File::Temp
2883         instead of 'new File::Temp' to make the script work with Perl 5.10.
2884         * Scripts/sort-Xcode-project-file: Ditto.
2885
2886 2008-10-22  Brady Eidson  <beidson@apple.com>
2887
2888         Reviewed by Adam Roben
2889
2890         <rdar://6261773> - autocomplete="off" doesn't work on Windows
2891
2892         Implement LayoutTestController::elementDoesAutoCompleteForElementWithId() on Windows
2893
2894         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2895
2896 2008-10-22  Darin Adler  <darin@apple.com>
2897
2898         * Scripts/do-webcore-rename: More renaming plans.
2899
2900 2008-10-21  Steve Falkenburg  <sfalken@apple.com>
2901
2902         Exclude strings marked with UNLOCALIZED_STRING or UNLOCALIZED_LPCTSTR.
2903
2904         * Scripts/extract-localizable-strings:
2905
2906 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
2907
2908         Reviewed by Mark Rowe.
2909
2910         - default to 1000 tests per dump tool instance again, now that CTI no longer causes
2911         excess different stack logs.
2912
2913         (Also fix a small bug in my last change.)
2914
2915         * Scripts/run-webkit-tests:
2916
2917 2008-10-17  Stephanie Lewis  <slewis@apple.com>
2918
2919         Reviewed by Mark Rowe.
2920
2921         Fix layout tests that use prologues and epilogues.
2922
2923         * Scripts/run-webkit-tests:
2924
2925 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
2926
2927         Reviewed by Mark Rowe.
2928
2929         - make sure MallocStackLogging is only on for tools we want to
2930         leak check, not other random stuff as well.
2931
2932         * Scripts/run-webkit-tests:
2933
2934 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
2935
2936         Reviewed by Stephanie Lewis.
2937
2938         - make run-webkit-tests --leaks default to 100 tests per run instead of 1000
2939
2940         This should reduce or eliminate crashes on the buildbot due to
2941         running out of memory while stack logging.
2942
2943         * Scripts/run-webkit-tests:
2944
2945 2008-10-16  Jan Michael Alonzo  <jmalonzo@webkit.org>
2946
2947         Gtk build fix. Not reviewed.
2948
2949         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2950         (LayoutTestController::setSmartInsertDeleteEnabled):
2951
2952 2008-10-15  Glenn Wilson  <gwilson@google.com>
2953
2954         Added new method to allow tests to disable smart editing in the course of a test.
2955         This is a possible solution to bug .20655
2956
2957         Reviewed by Tim Hatcher.
2958
2959         * DumpRenderTree/LayoutTestController.cpp:
2960         (setSmartInsertDeleteEnabledCallback): new method
2961         (LayoutTestController::staticFunctions): added new method to static list of callbacks
2962         * DumpRenderTree/LayoutTestController.h: added signature of new method
2963         * DumpRenderTree/mac/DumpRenderTree.mm:
2964         (resetWebViewToConsistentStateBeforeTesting): added state resetting
2965         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2966         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
2967         * DumpRenderTree/win/DumpRenderTree.cpp:
2968         (resetWebViewToConsistentStateBeforeTesting): added state resetting
2969         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2970         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
2971
2972 2008-10-14  Ada Chan  <adachan@apple.com>
2973
2974         Fix windows build.
2975
2976         Reviewed by Sam Weinig.
2977
2978         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2979         * DumpRenderTree/config.h:
2980         * DumpRenderTree/win/DumpRenderTreeWin.h:
2981         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2982         * DumpRenderTree/win/UIDelegate.cpp:
2983
2984 2008-10-13  Timothy Hatcher  <timothy@apple.com>
2985
2986         Make prepare-ChangeLog populate the changed functions for JavaScript files.
2987
2988         https://bugs.webkit.org/show_bug.cgi?id=21567
2989
2990         Reviewed by David Kilzer.
2991
2992         * Scripts/prepare-ChangeLog:
2993         (get_function_line_ranges): Call get_function_line_ranges_for_javascript for
2994         files that end with ".js".
2995         (get_function_line_ranges_for_javascript): Find functions, anonymous functions
2996         and getters/setters.
2997
2998 2008-10-14  Alp Toker  <alp@nuanti.com>
2999
3000         Reviewed by Sam Weinig.
3001
3002         https://bugs.webkit.org/show_bug.cgi?id=16299
3003         Add a config.h file to DRT
3004
3005         Add a config.h to DumpRenderTree and reduce use of DumpRenderTree.h as
3006         an ad-hoc config header.
3007
3008         * DumpRenderTree/AccessibilityController.cpp:
3009         * DumpRenderTree/AccessibilityUIElement.cpp:
3010         * DumpRenderTree/AccessibilityUIElement.h:
3011         * DumpRenderTree/DumpRenderTree.h:
3012         * DumpRenderTree/GCController.cpp:
3013         * DumpRenderTree/LayoutTestController.cpp:
3014         * DumpRenderTree/WorkQueue.cpp:
3015         * DumpRenderTree/config.h: Added.
3016         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3017         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3018         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3019         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
3020         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3021         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3022         * DumpRenderTree/win/DumpRenderTree.cpp:
3023         * DumpRenderTree/win/DumpRenderTreeWin.h:
3024         * DumpRenderTree/win/EditingDelegate.cpp:
3025         * DumpRenderTree/win/EventSender.cpp:
3026         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3027         * DumpRenderTree/win/GCControllerWin.cpp:
3028         * DumpRenderTree/win/MD5.cpp:
3029         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3030         * DumpRenderTree/win/PolicyDelegate.cpp:
3031         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3032         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3033         * GNUmakefile.am:
3034
3035 2008-10-13  Chris Fleizach  <cfleizach@apple.com>
3036
3037         Reviewed by Beth Dakin.
3038
3039         Added a method to get the links in a webpage
3040
3041         * DumpRenderTree/AccessibilityUIElement.cpp:
3042         (attributesOfDocumentLinksCallback):
3043         (AccessibilityUIElement::getJSClass):
3044         * DumpRenderTree/AccessibilityUIElement.h:
3045         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3046         (AccessibilityUIElement::getDocumentLinks):
3047         (AccessibilityUIElement::attributesOfDocumentLinks):
3048         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3049         (AccessibilityUIElement::getDocumentLinks):
3050         (AccessibilityUIElement::attributesOfDocumentLinks):
3051
3052 2008-10-13  David Kilzer  <ddkilzer@apple.com>
3053
3054         Bug 21457: resolve-ChangeLogs should be able to operate on a git revision range
3055
3056         <https://bugs.webkit.org/show_bug.cgi?id=21457>
3057
3058         Reviewed by Adam.
3059
3060         * Scripts/resolve-ChangeLogs: Added optional parameter to
3061         -f|--fix-merged switch to run the script on a revision range.
3062         Updated command-line validation checks.
3063         (findChangeLog): Fixed long-standing bug that should have used
3064         $_[0] instead of $_.
3065         (fixMergedChangeLog): Renamed to fixOneMergedChangeLog($).  Updated
3066         to work when called from git filter-branch.  It always restores a
3067         copy of the previous revision before reapplying the patch.
3068         (fixMergedChangeLogs): Added.  Calls itself through git filter-branch
3069         to re-merge ChangeLog files across a revision range.  Removes
3070         .git/refs/original directory on success.
3071         (parseFixMerged): Added.  Custom method to parse the -f|--fix-merged
3072         switch.
3073         (removeChangeLogArguments): Added.  Removes items from @ARGV when
3074         they are ChangeLog paths, and return a list of paths.  This makes it
3075         easier to validate the command-line.
3076         (resolveChangeLog): Added.  Extracted from main code block.  Runs
3077         the traditional single-file merge algorithm.
3078         (usageAndExit): Added.  Extracted from main code block.  Prints
3079         usage statement and exits with error status.
3080
3081 2008-10-12  Darin Adler  <darin@apple.com>
3082
3083         * Scripts/make-js-test-wrappers: Update exceptions list so the script
3084         won't overwrite files and mangle tests.
3085
3086 2008-10-11  Dan Bernstein  <mitz@apple.com>
3087
3088         Reviewed by Sam Weinig and Anders Carlsson.
3089
3090         - update Mac DumpRenderTree to use the new WebView SPI for forcing the
3091           complex text code path
3092         - add --complex-text support to Windows DumpRenderTree
3093
3094         * DumpRenderTree/mac/DumpRenderTree.mm:
3095         (dumpRenderTree):
3096         * DumpRenderTree/win/DumpRenderTree.cpp:
3097         (createWebViewAndOffscreenWindow):
3098         (main):
3099         * Scripts/run-webkit-tests:
3100
3101 2008-10-09  Eric Seidel  <eric@webkit.org>
3102
3103         Reviewed by Oliver Hunt.
3104
3105         https://bugs.webkit.org/show_bug.cgi?id=21498
3106
3107         * Scripts/make-js-test-wrappers: ignore resources/shadow-offset.js
3108
3109 2008-10-09  Cameron Zwarich  <zwarich@apple.com>
3110
3111         Not reviewed.
3112
3113         Add StructureID.o to the exclusion list in the global initializers
3114         script to fix the Debug build.
3115
3116         * Scripts/check-for-global-initializers:
3117
3118 2008-10-08  Mark Rowe  <mrowe@apple.com>
3119
3120         Fix the Windows build after r37434.
3121
3122         * DumpRenderTree/win/DumpRenderTree.cpp:
3123         (dump): Update code to approximate valid C++ syntax.
3124
3125 2008-10-08  Timothy Hatcher  <timothy@apple.com>
3126
3127         Add SVGElementInstance to the list of exceptions that have
3128         global initializers in debug builds.
3129
3130         Rubber-stamped by Mark Rowe.
3131
3132         * Scripts/check-for-global-initializers: Add SVGElementInstance.o.
3133
3134 2008-10-08  Simon Fraser  <simon.fraser@apple.com>
3135
3136         Reviewed by Dan Bernstein
3137
3138         Avoid disconnect between DRT and run-webkit-tests
3139         about whether to expect PNG dumps by having DRT always
3140         print two blocks terminated by #EOF, the second of which
3141         may be empty.
3142
3143         https://bugs.webkit.org/show_bug.cgi?id=21483
3144
3145         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3146         (printPNG):
3147         (dumpWebViewAsPixelsAndCompareWithExpected):
3148         * DumpRenderTree/mac/DumpRenderTree.mm:
3149         (dump):
3150         * DumpRenderTree/win/DumpRenderTree.cpp:
3151         (dump):
3152         * Scripts/run-webkit-tests:
3153
3154 2008-10-07  Adam Roben  <aroben@apple.com>
3155
3156         Make sure short functions get included in ChangeLog output for git
3157         repositories
3158
3159         Reviewed by Dave Kilzer.
3160
3161         * Scripts/prepare-ChangeLog:
3162         (sub diffCommand): Pass -U0 to git diff so that each contiguous change
3163         will get its own chunk without any surrounding context.
3164         (sub extractLineRange): Use the line numbers from the chunk header
3165         without modifying them now that they're accurate.
3166
3167 2008-10-04  Mark Rowe  <mrowe@apple.com>
3168
3169         Reviewed by Tim Hatcher.
3170
3171         Update check-for-weak-vtables to check only the final linked image for weak vtables.
3172         This gives more useful results than checking each object file independently.
3173
3174         * Scripts/check-for-weak-vtables:
3175
3176 2008-10-03  Pierre-Olivier Latour <pol@apple.com>
3177
3178         Reviewed by Darin Adler
3179
3180         Render images to RGBA8 bitmaps independently of platform endianness.
3181
3182         Create image difference bitmap in reference image colorspace instead of device colorspace
3183         (which depends on the main display profile), so that no color matching happens.
3184
3185         https://bugs.webkit.org/show_bug.cgi?id=21336
3186
3187         * DumpRenderTree/cg/ImageDiffCG.cpp:
3188         (createDifferenceBitmap):
3189         (computePercentageDifferent):
3190         (compareImages):
3191
3192 2008-10-02  Simon Fraser  <simon.fraser@apple.com>
3193
3194         Reviewed by Darin Adler
3195
3196         Fix hang when running with --pixel --reset, which occurs
3197         because DRT spews PNG data when the script does not expect it.
3198
3199         https://bugs.webkit.org/show_bug.cgi?id=21323
3200
3201         * Scripts/run-webkit-tests:
3202
3203 2008-09-30  Mark Rowe  <mrowe@apple.com>
3204
3205         Reviewed by Dan Bernstein.
3206
3207         Add a leak counter for CachedResources since we've had two recent leaks involving them.
3208
3209         * Scripts/check-for-global-initializers:
3210
3211 2008-09-30  Mark Rowe  <mrowe@apple.com>
3212
3213         Rubber-stamped by Dan Bernstein.
3214
3215         Fix many leaks seen on fast/backgrounds/svg-as-background-1.html.
3216
3217         JavaScript wrappers were keeping DOM objects alive, which was leading to the SVG background image
3218         being kept alive in the memory cache past our last attempt to empty the cache prior to quitting.
3219         We need to empty the memory cache after forcing a JavaScript garbage collection to ensure that
3220         any live JavaScript wrappers are collected and their corresponding DOM objects have a chance to be
3221         torn down before we exit.
3222
3223         * DumpRenderTree/mac/DumpRenderTree.mm:
3224         (dumpRenderTree):
3225         (main):
3226
3227 2008-09-30  Simon Fraser  <simon.fraser@apple.com>
3228
3229         Reviewed by Dan Bernstein
3230
3231         Don't run pixel comparison for text-only tests.
3232         https://bugs.webkit.org/show_bug.cgi?id=21124
3233
3234         * DumpRenderTree/mac/DumpRenderTree.mm:
3235         (dump):
3236         * Scripts/run-webkit-tests:
3237
3238 2008-09-29  Thiago Macieira  <thiago.macieira@nokia.com>
3239
3240         Reviewed by Simon.
3241
3242         Changed copyright from Trolltech ASA to Nokia.
3243
3244         Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
3245
3246
3247         * DumpRenderTree/qt/DumpRenderTree.cpp:
3248         * DumpRenderTree/qt/jsobjects.cpp:
3249         * DumpRenderTree/qt/jsobjects.h:
3250         * DumpRenderTree/qt/main.cpp:
3251         * DumpRenderTree/qt/testplugin.cpp:
3252         * DumpRenderTree/qt/testplugin.h:
3253
3254 2008-09-28  David Kilzer  <ddkilzer@apple.com>
3255
3256         Bug 21185: resolve-ChangeLogs should be able to fix poorly merged ChangeLog entries after a git svn rebase
3257
3258         <https://bugs.webkit.org/show_bug.cgi?id=21185>
3259
3260         Reviewed by Adam.
3261
3262         * Scripts/resolve-ChangeLogs: Added new -f|--fix-merge switch that
3263         will attempt to reapply the last commit to a ChangeLog file such
3264         that the ChangeLog entry appears at the top of the file.
3265         (findChangeLog): Added prototype and moved method below the exit
3266         statement.
3267         (fixMergedChangeLog): Added.  Method to fix incorrectly merged
3268         ChangeLog entries.
3269
3270 2008-09-27  Anders Carlsson  <andersca@apple.com>
3271
3272         Reviewed by Sam Weinig.
3273
3274         https://bugs.webkit.org/show_bug.cgi?id=21178
3275         <rdar://problem/6248651>
3276
3277         Return the result value from getURL.
3278
3279         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3280         (getURL):
3281
3282 2008-09-26  Matt Lilek  <webkit@mattlilek.com>
3283
3284         Reviewed by Tim Hatcher.
3285
3286         Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.
3287
3288         * Scripts/build-webkit:
3289
3290 2008-09-26  Alice Liu  <alice.liu@apple.com>
3291
3292         Remove usage of atlstr.h and CString for VCExpress compatibility
3293
3294         Reviewed by Stephanie Lewis.
3295
3296         * record-memory-win/main.cpp:
3297         (ProcessArgs):
3298         (UseImage):
3299         (QueryContinuously):
3300         (OneQuery):
3301         (OneQueryMP):
3302
3303 2008-09-26  Kevin Ollivier  <kevino@theolliviers.com>
3304
3305         wx build fix. Update the version of libpng.
3306
3307         * wx/install-unix-extras:
3308
3309 2008-09-24  Sam Weinig  <sam@webkit.org>
3310
3311         Reviewed by Darin Adler.
3312
3313         Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
3314         <rdar://problem/6243534>
3315         Crash below Function.apply when using a runtime array as the argument list
3316
3317         Add method to ObjCController to return a runtime array.
3318
3319         * DumpRenderTree/mac/ObjCController.m:
3320         (+[ObjCController isSelectorExcludedFromWebScript:]):
3321         (+[ObjCController webScriptNameForSelector:]):
3322         (-[ObjCController testArray]):
3323
3324 2008-09-24  Beth Dakin  <bdakin@apple.com>
3325
3326         Reviewed by Sam Weinig.
3327
3328         Speculative build fix.
3329
3330         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3331         (AccessibilityUIElement::supportsPressAction):
3332
3333 2008-09-23  Beth Dakin  <bdakin@apple.com>
3334
3335         Reviewed by Sam Weinig.
3336
3337         This patch extends DumpRenderTree's AccessibilityController to ask
3338         if the focused element supports the press action.
3339
3340         * DumpRenderTree/AccessibilityUIElement.cpp:
3341         (getSupportsPressActionCallback):
3342         (AccessibilityUIElement::getJSClass):
3343         * DumpRenderTree/AccessibilityUIElement.h:
3344         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3345         (AccessibilityUIElement::supportsPressAction):
3346
3347 2008-09-22  Alice Liu  <alice.liu@apple.com>
3348
3349         Adding a stand-alone Windows console application to record a process's memory usage
3350
3351         Reviewed by Steve Falkenburg.
3352
3353         * record-memory-win: Added.
3354         * record-memory-win/main.cpp: Added.
3355         * record-memory-win/record-memory-win.vcproj: Added.
3356
3357 2008-09-22  Chris Fleizach  <cfleizach@apple.com>
3358
3359         Reviewed by Darin Adler.
3360
3361         Support ability to get/set selected text ranges for text controls through AX.
3362
3363         * DumpRenderTree/AccessibilityUIElement.cpp:
3364         (setSelectedTextRangeCallback):
3365         (getSelectedTextRangeCallback):
3366         (AccessibilityUIElement::getJSClass):
3367         * DumpRenderTree/AccessibilityUIElement.h:
3368         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3369         (AccessibilityUIElement::attributesOfRowHeaders):
3370         (AccessibilityUIElement::attributesOfVisibleCells):
3371         (AccessibilityUIElement::rowIndexRange):
3372         (AccessibilityUIElement::columnIndexRange):
3373         (AccessibilityUIElement::cellForColumnAndRow):
3374         (AccessibilityUIElement::selectedTextRange):
3375         (AccessibilityUIElement::setSelectedTextRange):
3376         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3377         (AccessibilityUIElement::selectedTextRange):
3378         (AccessibilityUIElement::setSelectedTextRange):
3379
3380 2008-09-20  Darin Adler  <darin@apple.com>
3381
3382         * DumpRenderTree/mac/DumpRenderTree.mm:
3383         (convertMIMEType): Turn on Stephanie's workaround for Tiger too.
3384
3385 2008-09-19  Alp Toker  <alp@nuanti.com>
3386
3387         Build fix for the 'gold' linker and recent binutils. New behaviour
3388         requires that we link to used libraries explicitly.
3389
3390         * GNUmakefile.am:
3391
3392 2008-09-19  Stephanie Lewis  <slewis@apple.com>
3393
3394         Reviewed by Oliver Hunt.
3395
3396         Implement a workaround for an incorrect mime-type on machines with
3397         Dashcode 2.0.1.  Dashcode is overriding the UTI type for .js files.
3398         See radar <rdar://problem/6234318>.
3399
3400         * DumpRenderTree/mac/DumpRenderTree.mm:
3401         (convertMIMEType):
3402
3403 2008-09-19  Chris Fleizach  <cfleizach@apple.com>
3404
3405         Fixed Windows bustage
3406
3407         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3408         (AccessibilityUIElement::titleUIElement):
3409
3410 2008-09-18  Chris Fleizach  <cfleizach@apple.com>
3411
3412         Reviewed by Darin Adler.
3413
3414         Expose titleUIElement call for DumpRenderTree
3415
3416         * ChangeLog:
3417         * DumpRenderTree/AccessibilityUIElement.cpp:
3418         (titleUIElementCallback):
3419         (AccessibilityUIElement::getJSClass):
3420         * DumpRenderTree/AccessibilityUIElement.h:
3421         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3422         (AccessibilityUIElement::titleUIElement):
3423
3424 2008-09-18  Darin Adler  <darin@apple.com>
3425
3426         * Scripts/do-webcore-rename: More renaming plans.
3427
3428 2008-09-18  Mark Rowe  <mrowe@apple.com>
3429
3430         Reviewed by Dan Bernstein.
3431
3432         Clear the main frame's name between tests to get more consistent test results
3433         when running the WebKit tests with --nthly.
3434
3435         * DumpRenderTree/mac/DumpRenderTree.mm:
3436         (resetWebViewToConsistentStateBeforeTesting):
3437         * DumpRenderTree/win/DumpRenderTree.cpp:
3438         (resetWebViewToConsistentStateBeforeTesting):
3439
3440 2008-09-18  Stephanie Lewis  <slewis@apple.com>
3441
3442         Really fix tiger jsc tests.
3443
3444         * Scripts/run-javascriptcore-tests:
3445
3446 2008-09-18  Stephanie Lewis  <slewis@apple.com>
3447
3448         Reviewed by Maciej Stachowiak.
3449
3450         Fix jsc tests on Tiger.  Make jsc tests smarter about when to use the arch flag.
3451
3452         * Scripts/run-javascriptcore-tests:
3453         * Scripts/webkitdirs.pm:
3454
3455 2008-09-18  Mark Rowe  <mrowe@apple.com>
3456
3457         Rubber-stamped by Sam Weinig.
3458
3459         Print warning to stdout rather than stderr when a test attempts to access a remote resource.
3460         This should make it more obvious when a test does this, as stderr output tends to be obscured
3461         by noise in the test results.
3462
3463         Also fixes some coding style issues in ResourceLoadDelegate.mm.
3464
3465         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3466         (-[NSError _drt_descriptionSuitableForTestResult]):
3467         (-[NSURL _drt_descriptionSuitableForTestResult]):
3468         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3469         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3470         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3471         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3472         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3473         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3474
3475 2008-09-18  Stephanie Lewis  <slewis@apple.com>
3476
3477         Reviewed by Mark Rowe and Maciej Stachowiak..
3478
3479         add a --64-bit option and specify which architecture to run on Mac.
3480
3481         * Scripts/run-javascriptcore-tests:
3482
3483 2008-09-17  Mark Rowe  <mrowe@apple.com>
3484
3485         Reviewed by Sam Weinig.
3486
3487         Fix a crash seen running DumpRenderTree on fast/dom/null-document-window-open-crash.html under guard malloc.
3488
3489         The JS wrapper for LayoutTestController could outlive the wrapped instance, and would crash when
3490         attempting to access the wrapped instance within layoutTestControllerObjectFinalize. We fix this by making
3491         LayoutTestController ref-counted to ensure that it is not outlived by the JS wrapper.
3492
3493         * DumpRenderTree/ForwardingHeaders/wtf/RefCounted.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h.
3494         * DumpRenderTree/LayoutTestController.cpp:
3495         (LayoutTestController::LayoutTestController):
3496         (notifyDoneCallback): Remove code that is no longer needed now that we must always have a wrapped instance.
3497         (layoutTestControllerObjectFinalize): Deref the wrapped object.
3498         (LayoutTestController::makeWindowObject): Ref the wrapped object.
3499         * DumpRenderTree/LayoutTestController.h: Make LayoutTestController RefCounted.
3500         * DumpRenderTree/mac/DumpRenderTree.mm:
3501         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
3502         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Remove code that is no longer needed.
3503         * DumpRenderTree/win/DumpRenderTree.cpp:
3504         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
3505
3506 2008-09-16  Sam Weinig  <sam@webkit.org>
3507
3508         Reviewed by Mark Rowe.
3509
3510         Add flag to disable running sample on tests that timeout.
3511
3512         * Scripts/run-webkit-tests:
3513
3514 2008-09-16  Adam Roben  <aroben@apple.com>
3515
3516         Windows build fix after r36511
3517
3518         Update for rename of layoutTestController to gLayoutTestController.
3519
3520         * DumpRenderTree/LayoutTestController.cpp:
3521         * DumpRenderTree/win/EditingDelegate.cpp:
3522         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3523         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3524         * DumpRenderTree/win/UIDelegate.cpp:
3525
3526 2008-09-16  Adam Roben  <aroben@apple.com>
3527
3528         Add a script to print out the dependency tree of a Visual Studio
3529         solution file
3530
3531         * Scripts/print-msvc-project-dependencies: Added.
3532
3533 2008-09-16  Mark Rowe  <mrowe@apple.com>
3534
3535         Fix the build.
3536
3537         * DumpRenderTree/LayoutTestController.cpp:
3538         (notifyDoneCallback): Call fprintf in a safer manner.
3539
3540 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
3541
3542         Reviewed by Eric Seidel
3543
3544         Protect against tests that call layoutTestController.notifyDone()
3545         more than once, which would lead to memory corruption, by nulling
3546         out the LayoutTestController on the JSObjectRef on destruction. Also
3547         add a finalize callback on the class so that if the LTC outlives
3548         the JSObjectRef, the JSObjectRef backpointer on the LTC can be
3549         nulled out.
3550
3551         https://bugs.webkit.org/show_bug.cgi?id=20875
3552
3553         * DumpRenderTree/LayoutTestController.cpp:
3554         (LayoutTestController::LayoutTestController):
3555         (notifyDoneCallback):
3556         (layoutTestControllerObjectFinalize):
3557         (LayoutTestController::makeWindowObject):
3558         (LayoutTestController::getJSClass):
3559         * DumpRenderTree/LayoutTestController.h:
3560         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3561         (LayoutTestController::~LayoutTestController):
3562
3563 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
3564
3565         Reviewed by Eric Seidel
3566
3567         Step 1 patch: rename global variable for clarity.
3568         https://bugs.webkit.org/show_bug.cgi?id=20875
3569
3570         * DumpRenderTree/DumpRenderTree.h:
3571         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3572         (dumpWebViewAsPixelsAndCompareWithExpected):
3573         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3574         (dumpFramesAsText):
3575         (dump):
3576         (runTest):
3577         (processWork):
3578         (webViewLoadFinished):
3579         (webViewWindowObjectCleared):
3580         * DumpRenderTree/mac/DumpRenderTree.mm:
3581         (allocateGlobalControllers):
3582         (dumpFrameScrollPosition):
3583         (dumpFramesAsText):
3584         (methodNameStringForFailedTest):
3585         (dump):
3586         (runTest):
3587         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3588         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3589         * DumpRenderTree/mac/EditingDelegate.mm:
3590         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3591         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3592         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3593         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3594         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3595         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3596         (-[EditingDelegate webViewDidBeginEditing:]):
3597         (-[EditingDelegate webViewDidChange:]):
3598         (-[EditingDelegate webViewDidEndEditing:]):
3599         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3600         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3601         (-[FrameLoadDelegate processWork:]):
3602         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3603         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3604         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3605         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3606         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3607         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3608         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3609         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3610         * DumpRenderTree/mac/UIDelegate.mm:
3611         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
3612         (-[UIDelegate webViewFocus:]):
3613         (-[UIDelegate webViewUnfocus:]):
3614         (-[UIDelegate webView:createWebViewWithRequest:]):
3615         (-[UIDelegate webViewClose:]):
3616         * DumpRenderTree/win/DumpRenderTree.cpp:
3617         (dumpFrameScrollPosition):
3618         (dumpFramesAsText):
3619         (dump):
3620         (runTest):
3621
3622 2008-09-15  Alice Liu  <alice.liu@apple.com>
3623
3624         A change needed to make PPC bots pass accessibility/table-cell-spans.html layout test
3625
3626         Reviewed by Stephanie Lewis.
3627
3628         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3629         Calling -[NSValue rangeValue] on nil object was returning bogus results on PPC,
3630         but not Intel.  Add a check for nil before calling.
3631         (AccessibilityUIElement::rowIndexRange):
3632         (AccessibilityUIElement::columnIndexRange):
3633
3634 2008-09-14  Mark Rowe  <mrowe@apple.com>
3635
3636         Build fix.
3637
3638         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3639         (waitUntilDoneWatchdogFired):
3640         * DumpRenderTree/mac/ObjCPlugin.m:
3641
3642 2008-09-08  Dan Bernstein  <mitz@apple.com>
3643
3644         Reviewed by Mark Rowe.
3645
3646         - add an option to run-webkit-tests to always use the complex text code path
3647
3648         * DumpRenderTree/mac/DumpRenderTree.mm:
3649         (initializeGlobalsFromCommandLineOptions):
3650         (dumpRenderTree):
3651         * Scripts/run-webkit-tests:
3652
3653 2008-09-08  Steve Falkenburg  <sfalken@apple.com>
3654
3655         Another Windows nightly build fix.
3656
3657         Reviewed by Sam Weinig.
3658
3659         * FindSafari/FindSafari.cpp:
3660         (_tmain): Delete existing WebKitNightly directory in temp.
3661         * FindSafari/Safari.exe.manifest: Add PROGIDs for each COM class. Remove non-production classes.
3662
3663 2008-09-07  Stephanie Lewis  <slewis@apple.com>
3664
3665         Reviewed by Mark Rowe.
3666
3667         Fix DRT build
3668
3669         * DumpRenderTree/DumpRenderTreePrefix.h:
3670         * DumpRenderTree/win/DumpRenderTree.vcproj:
3671
3672 2008-09-06  Steve Falkenburg  <sfalken@apple.com>
3673
3674         Fix Windows nightlies.
3675
3676         Copy WebKit.dll alongside application so registry-free COM can find it.
3677         Update embedded manifest to force use registry-free COM.
3678
3679         Reviewed by Dave Hyatt.
3680
3681         * FindSafari/FindSafari.cpp:
3682         (copyManifest):
3683         (replaceManifest):
3684         (_tmain):
3685         * FindSafari/FindSafari.rc: Added.
3686         * FindSafari/FindSafari.vcproj:
3687         * FindSafari/Safari.exe.manifest: Added.
3688         * FindSafari/resource.h: Added.
3689
3690 === End merge of squirrelfish-extreme ===
3691
3692 2008-08-31  Mark Rowe  <mrowe@apple.com>
3693
3694         Reviewed by Maciej Stachowiak.
3695
3696         Add a --profile flag to run-sunspider.
3697
3698         * Scripts/webkitdirs.pm: Detect --profile or --profiling passed as a command-line argument
3699         to build scripts as indicating that we should use the "Profiling" configuration.  At present
3700         this is only supported by JavaScriptCore, so using this argument to build any other project
3701         will likely result in unexpected behaviour.
3702
3703 2008-08-27  Mark Rowe  <mrowe@apple.com>
3704
3705         Reviewed by Oliver Hunt.
3706
3707         Fix run-webkit-tests to handle DRT exiting early.
3708
3709         * Scripts/run-webkit-tests: Initialize $expectedResultPaths{$base} before it will be used.
3710
3711 === Start merge of squirrelfish-extreme ===
3712
3713 2008-09-04  Mark Rowe  <mrowe@apple.com>
3714
3715         Reviewed by Eric Seidel.
3716
3717         Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
3718         Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
3719
3720         * Scripts/build-webkit: Remove ENABLE_DASHBOARD_SUPPORT-related code.
3721
3722 2008-09-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
3723
3724         Reviewed by Oliver Hunt.
3725
3726         Bug 20616: Incorporate V8 benchmarks in testing
3727         <https://bugs.webkit.org/show_bug.cgi?id=20616>
3728
3729         Add support for the --v8 option to run-sunspider.
3730
3731         * Scripts/run-sunspider:
3732
3733 2008-09-04  Kevin Ollivier  <kevino@theolliviers.com>
3734
3735         wx buildbot fix. More robust handling of clean when makefiles are not built or
3736         are not completely made.
3737
3738         * wx/build-wxwebkit:
3739
3740 2008-09-03  Mark Rowe  <mrowe@apple.com>
3741
3742         More Mac build fixes.
3743
3744         Set ENABLE_DASHBOARD_SUPPORT when building for Mac via build-webkit.
3745         Also set ENABLE_CROSS_DOCUMENT_MESSAGING in order to match the
3746         default configuration specified in the .xcconfig files.
3747
3748         * Scripts/build-webkit:
3749
3750 2008-09-03  Mark Rowe  <mrowe@apple.com>
3751
3752         Mac build fix.  Ensure that dashboard support is enabled.
3753
3754         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3755
3756 2008-08-25  Steve Falkenburg  <sfalken@apple.com>
3757
3758         Build fix. Copy correct version of ICU.
3759
3760         * DumpRenderTree/win/DumpRenderTree.vcproj:
3761
3762 2008-08-25  Holger Hans Peter Freyther  <zecke@selfish.org>
3763
3764         Reviewed by Simon.
3765
3766         [run-webkit-tests] Use QtLauncher to show the results of the tests
3767         konqueror might not be installed, xdg-open might not be installed but the
3768         QtLauncher should be present.
3769
3770         * Scripts/run-webkit-tests:
3771
3772 2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>
3773
3774         Initial support for accessibility layout tests on Windows.
3775         https://bugs.webkit.org/show_bug.cgi?id=20497
3776
3777         Reviewed by Sam Weinig.
3778
3779         * DumpRenderTree/AccessibilityController.h: Fix typos.
3780         * DumpRenderTree/AccessibilityUIElement.cpp: Change #import to #include.
3781         * DumpRenderTree/AccessibilityUIElement.h: Define _WINSOCKAPI_ to
3782         prevent oleacc.h, which includes windows.h, from including winsock.h.
3783         Fixed typos.
3784         * DumpRenderTree/win/AccessibilityControllerWin.cpp: Added.
3785         (AccessibilityController::AccessibilityController):
3786         (AccessibilityController::~AccessibilityController):
3787         (AccessibilityController::focusedElement): Get the root element, and
3788         request its focused object.
3789         (AccessibilityController::rootElement): Query Windows for the
3790         accessible client object for the WebView's window.
3791         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added.
3792         (AccessibilityUIElement::AccessibilityUIElement):
3793         (AccessibilityUIElement::~AccessibilityUIElement):
3794         (AccessibilityUIElement::getLinkedUIElements): Not implemented.
3795         (AccessibilityUIElement::getChildren): Get the child count, and append
3796         each child.
3797         (AccessibilityUIElement::getChildAtIndex): Get the child at the given
3798         index offset by 1. In MSAA, child 0 is the object itself.
3799         (AccessibilityUIElement::allAttributes): Not implemented.
3800         (AccessibilityUIElement::attributesOfLinkedUIElements): Same.
3801         (AccessibilityUIElement::attributesOfChildren): Same.
3802         (AccessibilityUIElement::parameterizedAttributeNames): Same.
3803         (self): Return a VARIANT representing the "self" object. This is used
3804         when calling methods that require a child variant.
3805         (AccessibilityUIElement::role): Get the MSAA role, a long value, and
3806         convert it into a string with GetRoleText().
3807         (AccessibilityUIElement::title): Get the element's title, and convert
3808         it to a JS String.
3809         (AccessibilityUIElement::description): Same, for description.
3810         (AccessibilityUIElement::width):
3811         (AccessibilityUIElement::height):
3812         (AccessibilityUIElement::intValue): Get the object's value as a string,
3813         and convert the string to a double.
3814         (AccessibilityUIElement::minValue): Not implemented.
3815         (AccessibilityUIElement::maxValue): Same.
3816         (AccessibilityUIElement::insertionPointLineNumber): Same.
3817         (AccessibilityUIElement::attributesOfColumnHeaders): Same.
3818         (AccessibilityUIElement::attributesOfRowHeaders): Same.
3819         (AccessibilityUIElement::attributesOfColumns): Same.
3820         (AccessibilityUIElement::attributesOfRows): Same.
3821         (AccessibilityUIElement::attributesOfVisibleCells): Same.
3822         (AccessibilityUIElement::attributesOfHeader): Same.
3823         (AccessibilityUIElement::indexInTable): Same.
3824         (AccessibilityUIElement::rowIndexRange): Same.
3825         (AccessibilityUIElement::columnIndexRange): Same.
3826         (AccessibilityUIElement::lineForIndex): Same.
3827         (AccessibilityUIElement::boundsForRange): Same.
3828         (AccessibilityUIElement::cellForColumnAndRow): Same.
3829         * DumpRenderTree/win/DumpRenderTree.vcproj: Add accessibility files to
3830         project.  Link to oleacc.lib, the MSAA library.
3831         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3832         (FrameLoadDelegate::FrameLoadDelegate): Initialize the accessibility
3833         controller.
3834         (FrameLoadDelegate::didClearWindowObject): Create a new window object
3835         for the accessibility controller.
3836         * DumpRenderTree/win/FrameLoadDelegate.h:
3837
3838 2008-08-21  Simon Fraser  <simon.fraser@apple.com>
3839
3840         Reviewed by Mark Rowe
3841
3842         Make build-launcher-app work when run from a git repository.
3843         https://bugs.webkit.org/show_bug.cgi?id=20478
3844
3845         * BuildSlaveSupport/build-launcher-app:
3846
3847 2008-08-20  Maxime Britto  <britto@apple.com>
3848
3849         Reviewed by Ada Chan.
3850
3851          rdar://5259746
3852         Mouse events are sent to page while resizing window (affects Gmail)
3853
3854         * DumpRenderTree/win/UIDelegate.h:
3855         (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.
3856
3857 2008-08-19  Chris Fleizach  <cfleizach@apple.com>
3858
3859         Reviewed by Beth Dakin.
3860
3861         Add snowleopard platform in layout tests
3862
3863         Added support for accessing the attributes of
3864         accessibility tables through the accessibility controller
3865         in DumpRenderTree
3866
3867         * DumpRenderTree/AccessibilityUIElement.cpp:
3868         (attributesOfColumnHeadersCallback):
3869         (attributesOfRowHeadersCallback):
3870         (attributesOfColumnsCallback):
3871         (attributesOfRowsCallback):
3872         (attributesOfVisibleCellsCallback):
3873         (attributesOfHeaderCallback):
3874         (indexInTableCallback):
3875         (rowIndexRangeCallback):
3876         (columnIndexRangeCallback):
3877         (childAtIndexCallback):
3878         (cellForColumnAndRowCallback):
3879         (AccessibilityUIElement::getJSClass):
3880         * DumpRenderTree/AccessibilityUIElement.h:
3881         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3882         (convertNSArrayToVector):
3883         (descriptionOfElements):
3884         (AccessibilityUIElement::getLinkedUIElements):
3885         (AccessibilityUIElement::getChildren):
3886         (AccessibilityUIElement::attributesOfLinkedUIElements):
3887         (AccessibilityUIElement::attributesOfChildren):
3888         (AccessibilityUIElement::attributesOfColumnHeaders):
3889         (AccessibilityUIElement::attributesOfRowHeaders):
3890         (AccessibilityUIElement::attributesOfColumns):
3891         (AccessibilityUIElement::attributesOfRows):
3892         (AccessibilityUIElement::attributesOfVisibleCells):
3893         (AccessibilityUIElement::attributesOfHeader):
3894         (AccessibilityUIElement::indexInTable):
3895         (AccessibilityUIElement::rowIndexRange):
3896         (AccessibilityUIElement::columnIndexRange):
3897         (AccessibilityUIElement::cellForColumnAndRow):
3898         * Scripts/run-webkit-tests:
3899
3900 2008-08-19  Alexey Proskuryakov  <ap@webkit.org>
3901
3902         Reviewed by Darin Adler.
3903
3904         Fix run-webkit-tests misreporting crashed tests as timed out ones because DumpRenderTree
3905         is waiting for crash reporter to let it exit.
3906
3907         The fix does not work on Tiger, because the state of the process is indistinguishable from
3908         other waiting processes, at least not with this technique.
3909
3910         * Scripts/run-webkit-tests:
3911
3912 2008-08-18  Alp Toker  <alp@nuanti.com>
3913
3914         Reviewed by Holger Freyther.
3915
3916         https://bugs.webkit.org/show_bug.cgi?id=20350
3917         [GTK] Get DumpRenderTree working
3918
3919         Fixes and enhancements to DumpRenderTree. With these changes, the test
3920         suite can now complete a run producing text and render tree dumps.
3921
3922         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3923         (dumpFramesAsText):
3924         (dump):
3925         (runTest):
3926         (webViewLoadFinished):
3927         (webViewWindowObjectCleared):
3928         (webViewConsoleMessage):
3929         (webViewScriptAlert):
3930         (webViewScriptPrompt):
3931         (webViewScriptConfirm):
3932         (webViewTitleChanged):
3933         (main):
3934         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3935         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3936         (LayoutTestController::clearBackForwardList):
3937         (LayoutTestController::pathToLocalResource):
3938         (LayoutTestController::setAcceptsEditing):
3939         (LayoutTestController::setUserStyleSheetEnabled):
3940         (LayoutTestController::setUserStyleSheetLocation):
3941         (waitToDumpWatchdogFired):
3942         (LayoutTestController::windowCount):
3943         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
3944         (JSStringCopyUTF8CString):
3945         (ScriptItem::invoke):
3946
3947 2008-08-17  Geoffrey Garen  <ggaren@apple.com>
3948
3949         Reviewed by Cameron Zwarich.
3950
3951         Updated project files to XCode 3.1.
3952
3953         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
3954         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3955
3956 2008-08-15  Mark Rowe  <mrowe@apple.com>
3957
3958         Rubber-stamped by Geoff Garen.
3959
3960         <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
3961
3962         * Scripts/check-for-global-initializers: Ignore initializers when building the debug variant.
3963
3964 2008-08-13  Simon Hausmann  <hausmann@webkit.org>
3965
3966         Rubber-stamped by Holger.
3967
3968         Revert r31585 and disable http tests for the Qt build again unless
3969         explicitly enabled.
3970
3971         Running the http tests unfortunately currently still triggers
3972         failures in non-http tests due to side-effects. Disable them by default for
3973         now, for more reliable results.
3974
3975         * Scripts/run-webkit-tests:
3976
3977 2008-08-10  Jan Michael Alonzo  <jmalonzo@webkit.org>
3978
3979         Reviewed (and updated) by Alp Toker.
3980
3981         https://bugs.webkit.org/show_bug.cgi?id=16620
3982         [GTK] Autotools make dist and make check support
3983
3984         Get make dist working.
3985
3986         Note that not all possible configurations have been tested yet.
3987
3988         * GNUmakefile.am:
3989
3990 2008-08-10  Alp Toker  <alp@nuanti.com>
3991
3992         Remove leftover qmake/GTK+ build files.
3993
3994         * DumpRenderTree/gtk/DumpRenderTree.pro: Removed.
3995         * GtkLauncher/GtkLauncher.pro: Removed.
3996
3997 2008-08-06  Chris Fleizach  <cfleizach@apple.com>
3998
3999         Reviewed by Beth Dakin
4000
4001         AX functions shouldn't return position information because it changes
4002         based on the platform
4003
4004         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4005         (AccessibilityUIElement::boundsForRange):
4006
4007 2008-08-06  Eric Seidel  <eric@webkit.org>
4008
4009         Reviewed by darin.
4010
4011         Fix leaks seen on build-bot by fixing memory management of AccessibilityUIElement.
4012         <https://bugs.webkit.org/show_bug.cgi?id=20297>
4013         <rdar://problem/6093153>
4014
4015         I've made AccessibilityUIElement a stack object for now.  It could be
4016         made RefCounted, but I figured that might be overkill for the moment.
4017         Essentially it's just a RefPtr itself. :)
4018
4019         I also fixed a few typos, such as AccessibilityUIElement() instead of ~AccessibilityUIElement()
4020         which was causing additional leaks. :)
4021
4022         I added toAXElement to remove a bunch of copy/paste code.
4023
4024         * DumpRenderTree/AccessibilityController.h:
4025         * DumpRenderTree/AccessibilityUIElement.cpp:
4026         (toAXElement):
4027         (allAttributesCallback):
4028         (attributesOfLinkedUIElementsCallback):
4029         (attributesOfChildrenCallback):
4030         (lineForIndexCallback):
4031         (boundsForRangeCallback):
4032         (childAtIndexCallback):
4033         (getRoleCallback):
4034         (getTitleCallback):
4035         (getDescriptionCallback):
4036         (getWidthCallback):
4037         (getHeightCallback):
4038         (getIntValueCallback):
4039         (getMinValueCallback):
4040         (getMaxValueCallback):
4041         (getInsertionPointLineNumberCallback):
4042         (finalize):
4043         * DumpRenderTree/AccessibilityUIElement.h:
4044         (AccessibilityUIElement::platformUIElement):
4045         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4046         (AccessibilityController::focusedElement):
4047         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4048         (AccessibilityUIElement::AccessibilityUIElement):
4049         (AccessibilityUIElement::getLinkedUIElements):
4050         (AccessibilityUIElement::getChildren):
4051         (AccessibilityUIElement::getChildAtIndex):
4052         (AccessibilityUIElement::attributesOfLinkedUIElements):
4053         (AccessibilityUIElement::attributesOfChildren):
4054
4055 2008-08-06  Eric Seidel  <eric@webkit.org>
4056
4057         Reviewed by Cameron Zwarich.
4058
4059         Speculative fix for an error I keep seeing in my Cygwin build
4060
4061         * Scripts/webkitdirs.pm: make determineConfigurationProductDir() always call determineConfiguration() even on cygwin
4062
4063 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
4064
4065         Forgot to commit licensing correction in last commit.
4066
4067         * wx/packaging/wxWebKitInstaller.iss.in:
4068
4069 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
4070
4071         Reviewed by Eric Seidel.
4072
4073         Scripts for building a wxWebKit installer for wxPython on Win, eventually will
4074         be used for nightlies.
4075
4076         https://bugs.webkit.org/show_bug.cgi?id=20036
4077
4078         * wx/packaging: Added.
4079         * wx/packaging/build-win-installer.py: Added.
4080         * wx/packaging/wxWebKitInstaller.iss.in: Added.
4081
4082 2008-07-31  Adam Roben  <aroben@apple.com>
4083
4084         Follow-up to r35500
4085
4086         * WinLauncher/WinLauncher.vcproj: Set the manifest properties for the
4087         Release configuration, too.
4088
4089 2008-07-31  Stefan Landvogt <stefan.landvogt@gmail.com>
4090
4091         Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of
4092         the box
4093
4094         <https://bugs.webkit.org/show_bug.cgi?id=20245>
4095
4096         Reviewed by Adam Roben.
4097
4098         * WinLauncher/WinLauncher.vcproj: adding the following properties to
4099         WinLauncher > Properties > Manifest Tool > Isolated COM
4100         Type Library File: $(WebKitOutputDir)\lib\WebKit.tlb
4101         Component File Name: WebKit$(WebKitDLLConfigSuffix)
4102         Doing the change on "All Configurations"
4103
4104 2008-07-31  Adam Roben  <aroben@apple.com>
4105
4106         Windows build bot fix
4107
4108         * DumpRenderTree/win/ImageDiff.vcproj: Don't fail if files that only
4109         exist for people at Apple can't be found. Also updated the ICU version
4110         to 3.8.
4111
4112 2008-07-31  David Kilzer  <ddkilzer@apple.com>
4113
4114         Fix layout test results for webarchive/test-xml-stylesheet.xml
4115
4116         Reviewed by Darin Adler.
4117
4118         * DumpRenderTree/mac/DumpRenderTree.mm:
4119         (convertMIMEType): Work around the "text/xml" local file type
4120         regression in Leopard using the BUILDING_ON_LEOPARD macro.  Also
4121         stop mangling "application/x-javascript" into "text/javascript".
4122         (convertWebResourceDataToString): When checking whether to dump a
4123         resource as text, also check to see if the MIME type is in the
4124         -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
4125         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD
4126         macro.
4127
4128 2008-07-31  Chris Fleizach  <cfleizach@apple.com>
4129
4130         Reviewed by Alice Liu
4131
4132         Add AX support to get the bounds for a range of text
4133         Add AX support to get the child of an element
4134         Add AX support to get all the parameterized attribute names of an element
4135
4136         * DumpRenderTree/AccessibilityUIElement.cpp:
4137         (parameterizedAttributeNamesCallback):
4138         (boundsForRangeCallback):
4139         (childAtIndexCallback):
4140         (AccessibilityUIElement::getJSClass):
4141         * DumpRenderTree/AccessibilityUIElement.h:
4142         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4143         (AccessibilityUIElement::getChildAtIndex):
4144         (AccessibilityUIElement::parameterizedAttributeNames):
4145         (AccessibilityUIElement::boundsForRange):
4146
4147 2008-07-31  Erik Bunce  <elbunce@thehive.com>
4148
4149         Reviewed by Simon.
4150
4151         Make run-launcher set DYLD_LIBRARY_PATH to make things work on Mac OS X.
4152
4153         * Scripts/run-launcher:
4154
4155 2008-07-30  Jessica Kahn  <jess@apple.com>
4156
4157         Reviewed by Adam Roben.
4158
4159         Slightly stricter checking for previous change, suggested by Adam.
4160
4161         * Scripts/extract-localizable-strings:
4162
4163 2008-07-30  Jessica Kahn  <jess@apple.com>
4164
4165         Reviewed by Darin Adler.
4166
4167         Added support for UI_STRING and UI_STRING_KEY macros with flexible prefixes.
4168
4169         * Scripts/extract-localizable-strings:
4170
4171 2008-07-30  Anders Carlsson  <andersca@apple.com>
4172
4173         Reviewed by Adam.
4174
4175         Copy icu38* files instead of icu36* files.
4176
4177         * DumpRenderTree/win/DumpRenderTree.vcproj:
4178
4179 2008-07-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
4180
4181         DRT/Gtk build fix for r35362
4182
4183         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4184         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
4185
4186 2008-07-25  Brady Eidson  <beidson@apple.com>
4187
4188         Reviewed by Sam
4189
4190         Add the ability to dump whether-or-not an element should have autocomplete enabled,
4191         from the perspective of the WebKit API
4192
4193         * DumpRenderTree/LayoutTestController.cpp:
4194         (elementDoesAutoCompleteForElementWithIdCallback):
4195         (LayoutTestController::staticFunctions):
4196
4197         * DumpRenderTree/LayoutTestController.h:
4198         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4199         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
4200         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4201         (LayoutTestController::elementDoesAutoCompleteForElementWithId): Stub for now until I can get on Windows
4202
4203 2008-07-25  Chris Fleizach  <cfleizach@apple.com>
4204
4205         Reviewed by Beth Dakin
4206
4207         Add support for AXLineForIndex and AXInsertionPointIndex through the
4208         accessibility controller
4209
4210         * DumpRenderTree/AccessibilityUIElement.cpp:
4211         (lineForIndexCallback):
4212         (getInsertionPointLineNumberCallback):
4213         (AccessibilityUIElement::getJSClass):
4214         * DumpRenderTree/AccessibilityUIElement.h:
4215         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4216         (AccessibilityUIElement::insertionPointLineNumber):
4217         (AccessibilityUIElement::lineForIndex):
4218
4219 2008-07-25  Adam Roben  <aroben@apple.com>
4220
4221         Try to fix the Windows build bot
4222
4223         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't try to copy files
4224         that don't exist for people outside of Apple.
4225
4226 2008-07-18  Landry Breuil  <landry@openbsd.org>
4227
4228         Bug 19975: [OpenBSD] Patches to enable build of WebKit
4229
4230         <https://bugs.webkit.org/show_bug.cgi?id=19975>
4231
4232         Reviewed by David Kilzer.
4233
4234         * DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.
4235
4236 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
4237
4238         CygwinDownloader fails to install necessary packages
4239         https://bugs.webkit.org/show_bug.cgi?id=20075
4240
4241         Reviewed by Mark Rowe.
4242
4243         * CygwinDownloader/cygwin-downloader.zip: Rebuilt after two broken
4244         mirrors removed in r34116. Set MIME type to application/octet-stream.
4245
4246 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
4247
4248         CygwinDownloader's make-zip.sh script fails
4249         https://bugs.webkit.org/show_bug.cgi?id=20074
4250
4251         Reviewed by Mark Rowe.
4252
4253         * CygwinDownloader/cygwin-downloader.py:
4254
4255 2008-07-15  Sam Weinig  <sam@webkit.org>
4256
4257         Reviewed by Anders Carlsson.
4258
4259         Refactor accessibility testing code.
4260
4261         We now have:
4262         - AccessibilityController
4263           Controller which has access to the WebView and can provide the focused element, root element
4264           and in the future, elementAtPoint.
4265
4266         - AccessibilityUIElement
4267           Object which provides access to the data provided by the Accessibility APIs.
4268
4269         * DumpRenderTree/AccessibilityController.cpp:
4270         (getFocusedElementCallback):
4271         (getRootElementCallback):
4272         (AccessibilityController::getJSClass):
4273         * DumpRenderTree/AccessibilityController.h:
4274         * DumpRenderTree/AccessibilityUIElement.cpp: Added.
4275         (allAttributesCallback):
4276         (attributesOfLinkedUIElementsCallback):
4277         (attributesOfChildrenCallback):
4278         (getRoleCallback):
4279         (getTitleCallback):
4280         (getDescriptionCallback):
4281         (getWidthCallback):
4282         (getHeightCallback):
4283         (getIntValueCallback):
4284         (getMinValueCallback):
4285         (getMaxValueCallback):
4286         (finalize):
4287         (AccessibilityUIElement::makeJSAccessibilityUIElement):
4288         (AccessibilityUIElement::getJSClass):
4289         * DumpRenderTree/AccessibilityUIElement.h: Added.
4290         (AccessibilityUIElement::platformUIElement):
4291         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4292         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4293         (AccessibilityController::AccessibilityController):
4294         (AccessibilityController::~AccessibilityController):
4295         (AccessibilityController::focusedElement):
4296         (AccessibilityController::rootElement):
4297         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added.
4298         (AccessibilityUIElement::AccessibilityUIElement):
4299         (descriptionOfValue):
4300         (attributesOfElement):
4301         (nsStringToJSStringRef):
4302         (concatenateAttributeAndValue):
4303         (AccessibilityUIElement::getLinkedUIElements):
4304         (AccessibilityUIElement::getChildren):
4305         (AccessibilityUIElement::attributesOfLinkedUIElements):
4306         (AccessibilityUIElement::attributesOfChildren):
4307         (AccessibilityUIElement::allAttributes):
4308         (AccessibilityUIElement::role):
4309         (AccessibilityUIElement::title):
4310         (AccessibilityUIElement::description):
4311         (AccessibilityUIElement::width):
4312         (AccessibilityUIElement::height):
4313         (AccessibilityUIElement::intValue):
4314         (AccessibilityUIElement::minValue):
4315         (AccessibilityUIElement::maxValue):
4316
4317 2008-07-14  Chris Fleizach  <cfleizach@apple.com>
4318
4319         Reviewed by Beth Dakin
4320
4321         Add support to get attributes of the AXChildren of an objecty
4322
4323         * DumpRenderTree/AccessibilityController.cpp:
4324         (attributesOfChildrenForFocusedElementCallback):
4325         (AccessibilityController::staticFunctions):
4326         * DumpRenderTree/AccessibilityController.h:
4327         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4328         (descriptionOfValue):
4329         (AccessibilityController::attributesOfChildrenForFocusedElement):
4330
4331 2008-07-14  Steve&nb