eaa8d179b3286da25ac68cbd694d628bcb56f007
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-05-30  Timothy Hatcher  <timothy@apple.com>
2
3         Made the starting line number of scripts be 1-based throughout the engine.
4         This cleans up script line numbers so they are all consistent now.
5
6         Reviewed by Oliver Hunt.
7
8         * DumpRenderTree/mac/ObjCController.m:
9         (runJavaScriptThread): Pass a line number of 1 instead of 0 to JSEvaluateScript.
10         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
11         (runJavaScriptThread): Ditto.
12         * DumpRenderTree/win/DumpRenderTree.cpp:
13         (runJavaScriptThread): Ditto.
14
15 2008-05-29  Geoffrey Garen  <ggaren@apple.com>
16
17         Reviewed by Adam Roben.
18
19         Fixed VCSUtils.pm to work with git repositories inside symlinks.
20
21         * Scripts/VCSUtils.pm: Compute a relative path from the git repository
22         root, instead of the root of the filesystem, to work around a bug in
23         abs2rel when traversing symlinked home directories.
24
25 2008-05-29  Kevin Ollivier  <kevino@theolliviers.com>
26
27         Reviewed by Darin Adler.
28         
29         Restore original behavior of isOSX() referring to the Mac port, not the OS itself.
30         
31         https://bugs.webkit.org/show_bug.cgi?id=19311
32
33         * Scripts/webkitdirs.pm:
34
35 2008-05-29  Alexey Proskuryakov  <ap@webkit.org>
36
37         Reviewed by Adam Roben.
38
39         Fix run-iexploder-tests and run-mangleme-tests to work with updated shared scripts and
40         configuration files.
41
42         * Scripts/run-iexploder-tests:
43         * Scripts/run-mangleme-tests:
44         Renamed runSafari to not conflict with the one in webkitdirs.
45         Added SSLCertificateFile option for httpd, as now needed.
46
47 2008-05-27  Kevin Ollivier  <kevino@theolliviers.com>
48
49         wx build fix. Update the sample app after wxWebFrame->wxWebBrowserShell rename.
50
51         * wx/browser/browser.cpp:
52         (MyApp::OnInit):
53
54 2008-05-24  Andreia Gaita  <shana@isninja.com>
55
56         Reviewed by Alp Toker.
57
58         cygwin-downloader.py fixes.
59
60         Remove two non-working mirrors. Add a check for missing dependency
61         packages to avoid bailing out on an inconsistent Cygwin package list.
62
63         * CygwinDownloader/cygwin-downloader.py:
64
65 2008-05-24  Jan Michael Alonzo  <jmalonzo@webkit.org>
66
67         Reviewed by Darin Adler.
68
69         Remove useQmake usage. QMake build doesn't support Gtk port
70         anymore.
71
72         Also fix 2 occurences of "Web Kit". Should be WebKit.
73
74         * Scripts/build-webkit:
75         * Scripts/run-javascriptcore-tests:
76         * Scripts/run-launcher:
77         * Scripts/run-webkit-tests:
78         * Scripts/webkitdirs.pm:
79
80 2008-05-22  Stephanie Lewis  <slewis@apple.com>
81
82         Reviewed by Dan.
83
84         implement the beforeUnload UI delegate so that DRT will dispatch beforeunload events.
85
86         * DumpRenderTree/mac/UIDelegate.mm:
87         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]):
88         * DumpRenderTree/win/UIDelegate.cpp:
89         (SearchableWebViewHost::runBeforeUnloadConfirmPanelWithMessage):
90
91 2008-05-21  Adele Peterson  <adele@apple.com>
92
93         Reviewed by Adam.
94
95         DumpRenderTree support for <rdar://problem/5787733> fast/dom/HTMLDocument/hasFocus.html fails on Windows
96
97         * DumpRenderTree/win/UIDelegate.cpp:
98         (UIDelegate::webViewFocus): Added.
99         (UIDelegate::webViewUnfocus): Added.
100         * DumpRenderTree/win/UIDelegate.h:
101
102 2008-05-21  Mark Rowe  <mrowe@apple.com>
103
104         Rubber-stamped by Stephanie Lewis.
105
106         Set the pass_through flag on Getopt so that extra arguments can be passed through to Safari,
107         rather than trigger an unknown argument message.  This allows run-webkit-tests to display results
108         once more.
109
110         * Scripts/run-safari:
111
112 2008-05-21  Stephanie Lewis  <slewis@apple.com>
113
114         Reviewed by Maciej, Mark.
115   
116         arch doesn't take arguments on tiger.  expand DRT timeout for guardMalloc.
117
118         * Scripts/run-webkit-tests:
119         * Scripts/webkitdirs.pm:
120
121 2008-05-20  Mark Rowe  <mrowe@apple.com>
122
123         Reviewed by Stephanie Lewis.
124
125         Improve the behavior of run-webkit-tests with 64-bit WebKit by automatically inferring whether to run 64-bit.
126
127         If --64-bit is not passed to run-webkit-tests, attempt to guess whether we should run 64-bit.
128         This decision is made based on the 64-bitness of the built WebKit framework if it exists, and
129         can be manually overridden by passing --64-bit or --no-64-bit.  This removes the need to always
130         pass an argument to run-webkit-tests after having built with "make x86_64".
131
132         * Scripts/gdb-safari:
133         * Scripts/run-safari:
134         * Scripts/run-webkit-tests:
135         * Scripts/webkitdirs.pm: Split the setting of the 64-bit flag, the determination of the
136         preferred architecture, and exporting of the environment variables for 'arch' out into
137         separate subroutines.
138
139 2008-05-20  Mark Rowe  <mrowe@apple.com>
140
141         Fix "make x86_64" by adding x86_64 target to WebKitTools Makefile.
142
143         * Makefile:
144
145 === End merge of squirrelfish ===
146
147 2008-04-14  Maciej Stachowiak  <mjs@apple.com>
148
149         Reviewed by Oliver.
150         
151         - added support for --ubench mode
152
153         * Scripts/run-sunspider:
154
155 2008-03-26  Geoffrey Garen  <ggaren@apple.com>
156
157         Reviewed by Oliver Hunt.
158
159         --squirrelfish mode: pared down tests for squirrelfish to chew on.
160
161         * Scripts/run-sunspider:
162
163 === Start merge of squirrelfish ===
164
165 2008-05-21  Darin Adler  <darin@apple.com>
166
167         * Scripts/make-js-test-wrappers: Added another exception.
168
169 2008-05-19  Stephanie Lewis  <slewis@apple.com>
170
171         Reviewed by Adam.
172
173         Explicitly set run mode to 32bit unless overridden to avoid
174         confusion when running tests
175
176         * Scripts/build-dumprendertree:
177         * Scripts/gdb-safari:
178         * Scripts/run-webkit-tests:
179         * Scripts/webkitdirs.pm:
180
181 2008-05-16  Stephanie Lewis  <slewis@apple.com>
182
183         Reviewed by Steve.
184
185         Print out pending unload event count. Also print out main frame name to match Mac.         
186
187         * DumpRenderTree/win/FrameLoadDelegate.cpp:
188         (descriptionSuitableForTestResult):
189         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
190
191 2008-05-16  Timothy Hatcher  <timothy@apple.com>
192
193         Remove the Drosera project, code and resources since it has been
194         replaced with the Web Inspector's debugger. Removes references to
195         Drosera in various scripts and makefiles.
196
197         Rubber-stamped by Mark Rowe.
198
199         * BuildSlaveSupport/build-launcher-app:
200         * Drosera/DebuggerDocument.cpp: Removed.
201         * Drosera/DebuggerDocument.h: Removed.
202         * Drosera/Drosera.icns: Removed.
203         * Drosera/DroseraWin.make: Removed.
204         * Drosera/English.lproj/Debugger.nib/classes.nib: Removed.
205         * Drosera/English.lproj/Debugger.nib/info.nib: Removed.
206         * Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Removed.
207         * Drosera/English.lproj/MainMenu.nib/classes.nib: Removed.
208         * Drosera/English.lproj/MainMenu.nib/info.nib: Removed.
209         * Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Removed.
210         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
211         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Removed.
212         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
213         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
214         * Drosera/ForwardingHeaders/wtf/Platform.h: Removed.
215         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Removed.
216         * Drosera/Images/Drosera.ico: Removed.
217         * Drosera/Images/SourceArrow.png: Removed.
218         * Drosera/Images/SourceArrowBlank.png: Removed.
219         * Drosera/Images/SourceArrowOpen.png: Removed.
220         * Drosera/Images/background_stripe.png: Removed.
221         * Drosera/Images/breakPoint.tif: Removed.
222         * Drosera/Images/breakPointDisabled.tif: Removed.
223         * Drosera/Images/breakpointeditor.png: Removed.
224         * Drosera/Images/close.tif: Removed.
225         * Drosera/Images/close_active.tif: Removed.
226         * Drosera/Images/close_hover.tif: Removed.
227         * Drosera/Images/console.png: Removed.
228         * Drosera/Images/continue.tif: Removed.
229         * Drosera/Images/fileIcon.jpg: Removed.
230         * Drosera/Images/finishFunction.tif: Removed.
231         * Drosera/Images/glossyFooterFill.tif: Removed.
232         * Drosera/Images/glossyHeader.png: Removed.
233         * Drosera/Images/glossyHeaderPressed.png: Removed.
234         * Drosera/Images/gradientBackground.png: Removed.
235         * Drosera/Images/gutter.png: Removed.
236         * Drosera/Images/navLeftDisabled.png: Removed.
237         * Drosera/Images/navLeftNormal.png: Removed.
238         * Drosera/Images/navLeftPressed.png: Removed.
239         * Drosera/Images/navRightDisabled.png: Removed.
240         * Drosera/Images/navRightNormal.png: Removed.
241         * Drosera/Images/navRightPressed.png: Removed.
242         * Drosera/Images/pause.tif: Removed.
243         * Drosera/Images/popUpArrows.png: Removed.
244         * Drosera/Images/programCounter.tif: Removed.
245         * Drosera/Images/programCounterBreakPoint.tif: Removed.
246         * Drosera/Images/programCounterBreakPointDisabled.tif: Removed.
247         * Drosera/Images/run.tif: Removed.
248         * Drosera/Images/siteCollapsed.tif: Removed.
249         * Drosera/Images/siteExpanded.tif: Removed.
250         * Drosera/Images/siteIcon.tif: Removed.
251         * Drosera/Images/small.ico: Removed.
252         * Drosera/Images/splitterBar.tif: Removed.
253         * Drosera/Images/splitterDimple.tif: Removed.
254         * Drosera/Images/step.tif: Removed.
255         * Drosera/Images/stepOut.tif: Removed.
256         * Drosera/Images/stepOver.tif: Removed.
257         * Drosera/Images/stop.tif: Removed.
258         * Drosera/Images/toolbarBackground.png: Removed.
259         * Drosera/Images/verticalSplitterBar.tiff: Removed.
260         * Drosera/Images/verticalSplitterDimple.tiff: Removed.
261         * Drosera/Makefile: Removed.
262         * Drosera/breakpointEditor.html: Removed.
263         * Drosera/config.h: Removed.
264         * Drosera/console.css: Removed.
265         * Drosera/console.html: Removed.
266         * Drosera/console.js: Removed.
267         * Drosera/debugger.css: Removed.
268         * Drosera/debugger.html: Removed.
269         * Drosera/debugger.js: Removed.
270         * Drosera/mac/DebuggerApplication.h: Removed.
271         * Drosera/mac/DebuggerApplication.mm: Removed.
272         * Drosera/mac/DebuggerClient.h: Removed.
273         * Drosera/mac/DebuggerClient.mm: Removed.
274         * Drosera/mac/DebuggerDocumentPlatform.mm: Removed.
275         * Drosera/mac/Drosera.xcodeproj/project.pbxproj: Removed.
276         * Drosera/mac/Info.plist: Removed.
277         * Drosera/mac/LauncherInfo.plist: Removed.
278         * Drosera/mac/Makefile: Removed.
279         * Drosera/mac/ServerConnection.h: Removed.
280         * Drosera/mac/ServerConnection.mm: Removed.
281         * Drosera/mac/launcher.m: Removed.
282         * Drosera/mac/main.m: Removed.
283         * Drosera/viewer.css: Removed.
284         * Drosera/viewer.html: Removed.
285         * Drosera/win/BaseDelegate.h: Removed.
286         * Drosera/win/DebuggerClient.cpp: Removed.
287         * Drosera/win/DebuggerClient.h: Removed.
288         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
289         * Drosera/win/Drosera.cpp: Removed.
290         * Drosera/win/Drosera.h: Removed.
291         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed.
292         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed.
293         * Drosera/win/DroseraPrefix.cpp: Removed.
294         * Drosera/win/DroseraPrefix.h: Removed.
295         * Drosera/win/Info.plist: Removed.
296         * Drosera/win/ServerConnection.cpp: Removed.
297         * Drosera/win/ServerConnection.h: Removed.
298         * Drosera/win/resource.h: Removed.
299         * Makefile:
300         * Scripts/build-drosera: Removed.
301         * Scripts/gdb-drosera: Removed.
302         * Scripts/run-drosera: Removed.
303         * Scripts/run-drosera-nightly.cmd: Removed.
304         * Scripts/run-drosera.cmd: Removed.
305         * Scripts/webkitdirs.pm:
306
307 2008-05-15  Stephanie Lewis  <slewis@apple.com>
308
309         Reviewed by Anders.
310
311         Dump the unload count for a frame after parsing is finished.
312
313         * DumpRenderTree/mac/FrameLoadDelegate.mm:
314         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
315
316 2008-05-15  Alexey Proskuryakov  <ap@webkit.org>
317
318         Reviewed by Dan Bernstein.
319
320         https://bugs.webkit.org/show_bug.cgi?id=10707
321         DumpRenderTree should not be able to access non-local resources
322
323         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
324         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
325         Block them, and complain.
326
327 2008-05-15  Kevin Ollivier  <kevino@theolliviers.com>
328
329         wx build fix. Update the version of libpng to download and instsall.
330
331         * wx/install-unix-extras:
332
333 2008-05-14  Julien Chaffraix  <jchaffraix@webkit.org>
334
335         Reviewed by Eric.
336
337         - isDarwin() and isCygwin() returned an empty string if the platform equality check fails.
338           We now force the return value to be numeric.
339
340         - Removed platform checks as it was a work around the previous issue.
341
342         - Replaced isDarwin() by isOSX() as they have now the same behaviour.
343
344         * Scripts/build-webkit:
345         * Scripts/webkitdirs.pm:
346
347 2008-05-12  Adam Roben  <aroben@apple.com>
348
349         Support for testing NPN_PostURL
350
351         Reviewed by Anders Carlsson.
352
353         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
354         (toCString): Added this helper function.
355         (testPostURLFile): Added. Writes the passed-in content to the
356         passed-in file and calls NPN_PostURL with the passed-in URL and
357         target.
358         (pluginInvoke): Added a case for testPostURLFile.
359         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
360         (followShortcuts): Changed to allow paths that don't yet exist.
361
362 2008-05-12  Mark Rowe  <mrowe@apple.com>
363
364         Reviewed by Sam Weinig.
365
366         Minor cleanup of the DRT Xcode project.
367
368         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Use GCC_OPTIMIZATION_LEVEL rather than
369         OPTIMIZATION_CFLAGS.  Don't include Info.plist in the "Copy Bundle Resources" build phase as it does
370         not need to be there.
371
372 2008-05-12  Anders Carlsson  <andersca@apple.com>
373
374         Reviewed by Adam.
375
376         Add support for testing application caches.
377         
378         * DumpRenderTree/mac/DumpRenderTree.mm:
379         (dumpRenderTree):
380         Empty the cache.
381         
382         (resetWebViewToConsistentStateBeforeTesting):
383         Turn on support for the application cache.
384
385 2008-05-09  Mark Rowe  <mrowe@apple.com>
386
387         Reviewed by Anders Carlsson.
388
389         Update TestNetscapePlugIn to build 64-bit using the Cocoa event model.
390
391         It currently does not attempt to print events which means that plugins/mouse-events.html
392         will fail when run 64-bit.  All other tests that use this plugin pass.
393
394         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
395         (testGetIntIdentifier):
396         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
397         (NPP_New):
398         (NPP_HandleEvent):
399
400 2008-05-09  Brady Eidson  <beidson@apple.com>
401
402         Reviewed by Adam Roben
403
404         Explicitly call shutDownWebKit() before quitting.
405
406         * Drosera/win/Drosera.cpp:
407         (_tWinMain):
408
409         * DumpRenderTree/win/DumpRenderTree.cpp:
410         (main):
411
412 2008-05-09  Mark Rowe  <mrowe@apple.com>
413
414         Fix the Tiger build of Drosera.
415
416         * Drosera/config.h: Define BUILDING_ON_TIGER when building on Tiger.
417
418 2008-05-09  Sam Weinig  <sam@webkit.org>
419
420         Rubber-stamped by Mark Rowe.
421
422         Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.
423
424         * Scripts/build-webkit:
425
426 2008-05-08  Mark Rowe  <mrowe@apple.com>
427
428         Another attempt at a Tiger build fix.
429
430         Use DumpRenderTreeMac.h rather than DumpRenderTree.h as DumpRenderTreePasteboard is not an Obj-C++ file.
431
432         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
433
434 2008-05-08  Mark Rowe  <mrowe@apple.com>
435
436         Tiger build fix.  Include DumpRenderTree.h so that BUILDING_ON_TIGER will be defined.
437
438         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
439
440 2008-05-08  Mark Rowe  <mrowe@apple.com>
441
442         Reviewed by Oliver Hunt and Dan Bernstein.
443
444         Update DumpRenderTree to build 64-bit.
445
446         The three major changes here are:
447         1) Use NSInteger in the appropriate places.
448         2) Use ColorSync API that is available in 64-bit to switch display profiles.
449         3) Use method-swizzling to achieve similar results to class posing when using the Obj-C 2.0 runtime.
450
451         The build of DumpRenderTree will still fail in 64-bit for now as the TestNetscapePlugIn target also
452         needs updated to successfully build.
453
454         * DumpRenderTree/mac/Configurations/Base.xcconfig: Don't prevent Xcode from building 64-bit.
455         * DumpRenderTree/mac/DumpRenderTree.mm:
456         (swizzleAllMethods):
457         (poseAsClass):
458         (prepareConsistentTestingEnvironment):
459         * DumpRenderTree/mac/DumpRenderTreeMac.h:
460         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
461         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
462         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
463         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
464         (restoreColorSpace):
465         (failedGettingCurrentProfile):
466         (setDefaultColorProfileToRGB):
467
468 2008-05-08  Mark Rowe  <mrowe@apple.com>
469
470         Reviewed by Darin Adler.
471
472         Clean up Drosera so that it will build 64-bit.
473
474         * Drosera/mac/DebuggerApplication.mm:
475         (-[DebuggerApplication numberOfRowsInTableView:]): Use NSInteger rather than int.
476         (-[DebuggerApplication tableView:objectValueForTableColumn:row:]): Ditto.
477         * Drosera/mac/Drosera.xcodeproj/project.pbxproj: Use the default value for VALID_ARCHS.
478
479 2008-05-07  David Kilzer  <ddkilzer@apple.com>
480
481         Use File::Find and Getopt::Long in make-js-test-wrappers
482
483         Reviewed by Darin.
484
485         * Scripts/make-js-test-wrappers:
486         - Updated Apple copyright statement.
487         - Added command-line switch parsing and -h|--help switch.
488         - Allowed user to pass list of files/directories on which to do
489           a restricted search for TEMPLATE.html files.  The default
490           behavior is still to search the entire LayoutTests directory.
491         - Removed duplicate 'use strict' statement.
492         - Replaced use of `find` statements with File::Find::find().
493         - Remove unneeded chomp() calls now that we use File::Find.
494         (directoryFilter): Added.  Filters .svn directories when used
495         with File::Find::find().
496         (findTemplateFiles): Added.  Returns a list of TEMPLATE.html
497         files found.
498
499 2008-05-05  Steve Falkenburg  <sfalken@apple.com>
500
501         Copy dependencies of ImageDiff, DumpRenderTree in post-build step.
502
503         * DumpRenderTree/win/DumpRenderTree.vcproj:
504         * DumpRenderTree/win/ImageDiff.vcproj:
505
506 2008-05-05  Adele Peterson  <adele@apple.com>
507
508         Reviewed by Adam.
509
510         Look for the right ImageDiff executable for debug builds.
511
512         * Scripts/run-webkit-tests:
513
514 2008-05-05  Darin Adler  <darin@apple.com>
515
516         * Scripts/run-webkit-tests: Ignore a Java leak showing up in the WebKit
517         leak tests.
518
519 2008-05-05  Ariya Hidayat  <ariya.hidayat@trolltech.com>
520
521         Reviewed by Simon.
522
523         In the Qt's DumpRenderTree, adjust the web view properly (because W3C SVG 
524         tests expect to be 480x360)
525
526         * DumpRenderTree/qt/DumpRenderTree.cpp:
527         (WebCore::DumpRenderTree::open):
528
529 2008-05-02  Dan Bernstein  <mitz@apple.com>
530
531         Reviewed by Adam Roben.
532
533         - add an option to svn-apply to set the reviewer name in change logs
534
535         * Scripts/svn-apply: Added a [-r|--reviewer name] option.
536
537 2008-05-01  David Kilzer  <ddkilzer@apple.com>
538
539         Clean up configuration usage in run-webkit-tests
540
541         Reviewed by Adam.
542
543         * Scripts/run-webkit-tests: Parse configuration switches using
544         passedConfiguration() from webkitdirs.pm like every other script.
545         Note that we must still call setConfiguration() afterwards in
546         case the --configuration switch was used.  Use $configurationOption
547         when running build-dumprendertree instead of recreating the switch.
548
549 2008-04-29  Adam Roben  <aroben@apple.com>
550
551         Restore the beloved COMPtr::operator&
552
553 2008-04-29  Adam Roben  <aroben@apple.com>
554
555         Windows build fixes
556
557         Replace COMPtr::operator& with COMPtr::adoptionPointer.
558
559 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
560
561         Reviewed by Darin.
562
563         Fix run-webkit-tests --threading
564         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
565         Proxy server issue in Sunday's Nightly
566
567         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
568         (runJavaScriptThread):
569         (startJavaScriptThreads):
570         (stopJavaScriptThreads):
571         Spawned threads were immediately detached, unlike the original ones, so joining them
572         made no sense. Now, all threads are created detached, and stopJavaScriptThreads() just
573         waits for them all to exit.
574
575 2008-04-28  Holger Hans Peter Freyther  <zecke@selfish.org>
576
577         Reviewed by Simon.
578
579         Reset dumping resource load callbacks to false for the next test
580         
581
582         * DumpRenderTree/qt/jsobjects.cpp:
583         (LayoutTestController::reset):
584
585 2008-04-28  Tor Arne Vestbø  <tavestbo@trolltech.com>
586
587         Reviewed by Simon.
588
589         Adapt to the latest API changes in WebKit/qt/Api.
590
591         * DumpRenderTree/qt/DumpRenderTree.cpp:
592         (WebCore::DumpRenderTree::DumpRenderTree):
593         * DumpRenderTree/qt/jsobjects.cpp:
594
595 2008-04-26  Robin Dunn  <robin@alldunn.com>
596
597         Reviewed by Kevin Ollivier.
598         
599         Delete the DerivedSources after make clean has been done so that the DerivedSources
600         don't get re-created. Also, use the proper extension for the Win wxPython extension.
601         
602         https://bugs.webkit.org/show_bug.cgi?id=18756
603
604         * wx/build-wxwebkit:
605
606 2008-04-26  Adam Barth <hk9565@gmail.com>
607
608         Reviewed by Adam Roben and Sam Weinig.
609
610         Updates LayoutTestController to use host instead of domain.
611
612         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
613
614         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
615         (LayoutTestController::setDatabaseQuota):
616         * DumpRenderTree/mac/UIDelegate.mm:
617         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
618
619 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
620
621         wx build fix. Need the latest libpng. (Somehow my initial test passed without it.)
622
623         * wx/install-unix-extras:
624
625 2008-04-26  Robin Dunn  <robin@alldunn.com>
626
627         Reviewed by Kevin Ollivier.
628         
629         Allow the user to set the path to SWIG using an environment variable.
630         
631         https://bugs.webkit.org/show_bug.cgi?id=18660
632
633         * wx/build-wxwebkit:
634
635 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
636
637         wx build fix. Download the latest libpng version for building the
638         dependencies.
639
640         * wx/install-unix-extras:
641
642 2008-04-25  Holger Hans Peter Freyther  <zecke@selfish.org>
643
644         Reviewed by Simon.
645
646         Implement dumping of resource load callbacks to pass http/tests/xmlhttprequest/abort-should-cancel-load.html
647         
648         Similar to Editing and Frameloading we do the dumping within WebCore
649         
650
651         * DumpRenderTree/qt/jsobjects.cpp:
652         (LayoutTestController::dumpResourceLoadCallbacks):
653         * DumpRenderTree/qt/jsobjects.h:
654
655 2008-04-24  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
656
657         Reviewed by Maciej Stachowiak.
658
659         http://bugs.webkit.org/show_bug.cgi?id=18485
660         Typo and documentation fix for build-webkit
661
662         * Scripts/build-webkit:
663
664 2008-04-24  Anders Carlsson  <andersca@apple.com>
665
666         Reviewed by Sam.
667
668         Don't call fprintf from the signal handler.
669         
670         * DumpRenderTree/mac/DumpRenderTree.mm:
671         (crashHandler):
672
673 2008-04-23  Adam Roben  <aroben@apple.com>
674
675         Make crashes be reported as crashes, not hangs
676
677         Reviewed by David Kilzer.
678
679         * Scripts/run-webkit-tests:
680         (top level): Use the new status field of the output from
681         readFromDumpToolWithTimer to determine if the test crashed or hung.
682         (sub readFromDumpToolWithTimer):
683           - If we fail to read a line and $! is not EAGAIN, then we've crashed
684             and should not try to read any more.
685           - Changed the timedout field to a more general status field.
686
687 2008-04-22  David Kilzer  <ddkilzer@apple.com>
688
689         Bug 18683: update-webkit returns 0 even if it fails
690
691         <https://bugs.webkit.org/show_bug.cgi?id=18683>
692
693         Reviewed by Mitz Pettel.
694
695         * Scripts/update-webkit:
696         (runSvnUpdate): Die if close() fails.
697
698 2008-04-21  Adam Roben  <aroben@apple.com>
699
700         Flush stdout/stderr after printing every #EOF separator
701
702         This fixes a hang when running the pixel tests on Windows
703
704         Reviewed by Mitz Pettel.
705
706         * DumpRenderTree/win/DumpRenderTree.cpp:
707         (dump):
708         (main): We don't have to flush stdout/stderr in the arguments loop
709         anymore, as runTest flushes for us.
710
711 2008-04-21  Adam Roben  <aroben@apple.com>
712
713         Fix pixel tests
714
715         * Scripts/run-webkit-tests:
716         (sub readFromDumpToolWithTimer): Use readline instead of read to
717         ensure that we don't read past the #EOF marker.
718
719 2008-04-21  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
720
721         Reviewed by Simon.
722
723         Build fix for Qt 4.3
724
725         * When building WebCore/internal make sure the QT_[BEGIN,END]_NAMESPACE is
726         always defined. Do this by adding defines to the compiler line
727
728         * DumpRenderTree/qt/DumpRenderTree.pro:
729
730 2008-04-19  Mike Hommey  <glandium@debian.org>
731
732         Reviewed by Alp Toker.
733
734         Don't build GtkLauncher and DumpRenderTree with rpath.
735
736         * GNUmakefile.am:
737
738 2008-04-18  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
739
740         Reviewed by Alp Toker.
741
742         http://bugs.webkit.org/show_bug.cgi?id=16620
743         [GTK] Autotools make dist and make check support
744
745         Cleanups.
746
747         * GNUmakefile.am:
748
749 2008-04-18  Adam Roben  <aroben@apple.com>
750
751         Drop the hang timer to 30 seconds
752
753         This matches what DRT/mac was using.
754
755         Reviewed by Mitz Pettel.
756
757         * Scripts/run-webkit-tests:
758
759 2008-04-18  Adam Roben  <aroben@apple.com>
760
761         Get rid of DRT's Watchdog
762
763         run-webkit-tests now detects hangs and samples DRT as needed.
764
765         Reviewed by Mitz Pettel.
766
767         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Removed
768         Watchdog* files from the project.
769         * DumpRenderTree/Watchdog.cpp: Removed.
770         * DumpRenderTree/Watchdog.h: Removed.
771         * DumpRenderTree/mac/DumpRenderTree.mm: Removed uses of Watchdog
772         (dumpRenderTree):
773         (runTest):
774         * DumpRenderTree/mac/WatchdogMac.h: Removed.
775         * DumpRenderTree/mac/WatchdogMac.mm: Removed.
776         * Scripts/run-webkit-tests:
777         (sub testCrashedOrTimedOut): Call sampleDumpTool() if we timed out.
778         (sub sampleDumpTool): Added. Writes a sample report to
779         ~/Library/Logs/DumpRenderTree/HangReport.txt.
780
781 2008-04-18  Simon Hausmann  <hausmann@webkit.org>
782
783         Reviewed by Holger.
784
785         Adapt to the API changes in WebKit/qt
786
787         * DumpRenderTree/qt/DumpRenderTree.cpp:
788         (WebCore::WebPage::WebPage):
789         (WebCore::DumpRenderTree::DumpRenderTree):
790         (WebCore::DumpRenderTree::initJSObjects):
791         (WebCore::DumpRenderTree::dumpFramesAsText):
792         (WebCore::DumpRenderTree::dump):
793
794 2008-04-17  Adam Roben  <aroben@apple.com>
795
796         Fix many tests on Windows
797
798         * Scripts/run-webkit-tests:
799         (readFromDumpToolWithTimer):
800          - Use read instead of sysread to ensure that we don't interfere with
801            other uses of buffered IO in this script.
802         (setFileHandleNonBlocking): Actually set the filehandle to blocking
803         when specified.
804
805 2008-04-17  Adam Roben  <aroben@apple.com>
806
807         Fix ~10 tests
808
809         * Scripts/run-webkit-tests: Only remove the newline after #EOF, not
810         whatever newline happens to be at the end of what we've read.
811
812 2008-04-17  Adam Roben  <aroben@apple.com>
813
814         Remove DRT/win's hang timer
815
816         run-webkit-tests takes care of this for us now
817
818         Reviewed by Anders Carlsson.
819
820         * DumpRenderTree/win/DumpRenderTree.cpp:
821
822 2008-04-17  Adam Roben  <aroben@apple.com>
823
824         Don't wait for the hang timer twice in the case of a hang
825
826         Previously we'd wait for a hang while reading both stdout and stderr
827         from DRT. Now we'll only wait for one or the other.
828
829         Reviewed by Anders Carlsson.
830
831         * Scripts/run-webkit-tests:
832         (top level): Don't wait for stderr to time out if stdout already timed
833         out.
834         (readFromDumpToolWithTimer): If $dontWaitForTimeOut is true, quit
835         after the first read that returns no data.
836
837 2008-04-17  Adam Roben  <aroben@apple.com>
838
839         Don't throw away the output from timed out tests
840
841         Reviewed by Anders Carlsson.
842
843         * Scripts/run-webkit-tests:
844         (top level): Updated for changes to readFromDumpToolWithTimer.
845         (readFromDumpToolWithTimer): Return a hash that contains both the
846         output and whether or not the test timed out.
847
848 2008-04-17  Adam Roben  <aroben@apple.com>
849
850         Make the hang timer 60 seconds
851
852         * Scripts/run-webkit-tests:
853
854 2008-04-17  Adam Roben  <aroben@apple.com>
855
856         Get rid of carriage returns in DRT/win's stderr
857
858         Reviewed by Eric Seidel.
859
860         * DumpRenderTree/win/DumpRenderTree.cpp:
861         (main): Mark stderr as binary like we already do for stdout.
862
863 2008-04-17  Adam Roben  <aroben@apple.com>
864
865         Fix Bug 17678: run-webkit-tests should have a watchdog timer (and
866         timeout long tests)
867
868         <https://bugs.webkit.org/show_bug.cgi?id=17678>
869
870         We now abort tests that take longer than 60 seconds to produce output.
871         This matches the watchdog timer in DRT/mac and DRT/win (which we can
872         now remove).
873
874         Reviewed by Eric Seidel.
875
876         * Scripts/run-webkit-tests:
877         (top level): Read DRT's output using the new readFromDumpToolWithTimer
878         subroutine. If readFromDumpToolWithTimer returns undefined it means
879         the test timed out, so we register the test as a hang and move on.
880         (sub testCrashedOrTimedOut): Renamed from testCrashed. Now handles
881         both crashed and timed out tests. If the test timed out, we kill DRT
882         before returning.
883         (sub linksForTimedOutTest): Added. We don't have any output to link to for
884         tests that timed out.
885         (sub recordActualResultsAndDiff): Don't call length on undefined.
886         (sub readFromDumpToolWithTimer): Added. Performs non-blocking reads
887         from a filehandle until an #EOF is reached or
888         $maximumSecondsWithoutOutput have elapsed.
889         (sub setFileHandleNonBlocking): Marks a filehandle as blocking or
890         non-blocking.
891
892 2008-04-17  Adam Roben  <aroben@apple.com>
893
894         Refactor test results page generation
895
896         Reviewed by Eric Seidel.
897
898         * Scripts/run-webkit-tests:
899         (sub htmlForResultsSection): Added. Takes a set of tests, a
900         description, and a subroutine to generate the links for each test, and
901         creates a HTML string containing a table of the tests and their
902         links.
903         (sub linksForExpectedAndActualResults): Added. Replaces the
904         htmlForExpectedAndActualResults subroutine.
905         (sub linksForMismatchTest): Added.
906         (sub linksForCrashOrErrorTest): Added.
907         (sub linksForNewTest): Added.
908
909 2008-04-17  Adam Roben  <aroben@apple.com>
910
911         Print the extension for all tests in the test results page
912
913         Reviewed by Eric Seidel.
914
915         * Scripts/run-webkit-tests:
916
917 2008-04-17  Adam Roben  <aroben@apple.com>
918
919         Move code that counts finished tests into a subroutine
920
921         Reviewed by Eric Seidel.
922
923         * Scripts/run-webkit-tests:
924         (sub countFinishedTest): Added.
925
926 2008-04-17  Adam Roben  <aroben@apple.com>
927
928         Move code that handles a crash into a subroutine
929
930         Reviewed by Eric Seidel.
931
932         * Scripts/run-webkit-tests:
933         (sub testCrashed): Added.
934
935 2008-04-17  Eric Seidel  <eric@webkit.org>
936
937         Reviewed by hyatt.
938         
939         Rename RenderView to RenderViewport in the next rename patch.
940
941         * Scripts/do-webcore-rename:
942
943 2008-04-17  Mario Bensi  <mbensi@pleyo.com>
944
945         Reviewed by Alp Toker.
946
947         http://bugs.webkit.org/show_bug.cgi?id=18543
948         DumpRenderTree gtk freeze
949
950         fix DumpRenderTree gtk freeze 
951
952         * DumpRenderTree/gtk/DumpRenderTree.cpp:
953         (dump):
954
955 2008-04-15  Anders Carlsson  <andersca@apple.com>
956
957         Add missing ;
958         
959         * Scripts/build-webkit:
960         
961 2008-04-15  Anders Carlsson  <andersca@apple.com>
962
963         Reviewed by Adam.
964
965         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
966
967         * Scripts/build-webkit:
968
969 2008-04-15  Andre Poenitz  <andre.poenitz@trolltech.com>
970
971         Reviewed by Simon.
972
973         Fix compilation with Qt namespaces
974
975         Qt can be configured to have all of its classes inside a specified namespaces.
976         This is for example used in plugin/component environments like Eclipse.
977
978         This change makes it possible to let the Qt port compile against a namespaced
979         Qt by the use of macros Qt provides to properly forward declare Qt classes in
980         the namespace.
981
982         * DumpRenderTree/qt/DumpRenderTree.h:
983
984 2008-04-08  Kevin Ollivier  <kevino@theolliviers.com>
985
986         Reviewed by Darin Adler.
987
988         Add a script that propagates any file changes made to the Bakefiles
989         over to GTK and Qt build systems. Still needs to be wired into
990         those ports though.
991
992         * Scripts/update-sources-list.py: Added.
993
994 2008-04-08  Mark Rowe  <mrowe@apple.com>
995
996         Clean up after Brady.
997
998         * DumpRenderTree/mac/DumpRenderTree.mm: Add an include so that NSInteger can be found.
999
1000 2008-04-08  Brady Eidson  <beidson@apple.com>
1001
1002         Reviewed by Mitzpettel
1003
1004         Fixed http://bugs.webkit.org/show_bug.cgi?id=18302
1005         -WebArchive subresources dump in random order, intermittent failures
1006
1007         * DumpRenderTree/mac/DumpRenderTree.mm:
1008         (compareResourceURLs): Sorting function based on the resource URLs
1009         (serializeWebArchiveToXML): Sort the subresource array
1010
1011 2008-04-07  Brady Eidson  <beidson@apple.com>
1012
1013         OMG, BUILD - please!
1014
1015         * Scripts/build-webkit:
1016
1017 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1018
1019         Reviewed by Simon.
1020
1021         * Enable running http tests for Qt again. Failing tests can be put into the skipped list.
1022         * Running these tests on windows and other platforms might need some work.
1023
1024         * Scripts/run-webkit-tests:
1025
1026 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1027
1028         Reviewed by Simon.
1029
1030         * For the http tests we need the output of the FrameLoaderClient. The QtWebKit API
1031         is not exporting enough to create the output in DRT itself. Settle with the approach
1032         Lars has taken for the Editing support and add branches to our FrameLoaderClient code.
1033         * run-webkit-tests http/tests(/loading) can now be executed.
1034         * For tests in loading/ directories we are going to throw away the dirty
1035         QWebPage to start with something clean.
1036         
1037
1038         * DumpRenderTree/qt/DumpRenderTree.cpp:
1039
1040 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1041
1042         Reviewed by Simon.
1043
1044         * Treat http and https as special URLs as well. Change the main.cpp and
1045         DumpRenderTree.cpp to handle http and https URIs as input.
1046         * I'm not doing the clean up and merging of these two checks now.
1047         
1048
1049         * DumpRenderTree/qt/DumpRenderTree.cpp:
1050         (WebCore::DumpRenderTree::readStdin):
1051         * DumpRenderTree/qt/main.cpp:
1052         (main):
1053
1054 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1055
1056         Reviewed by Simon.
1057
1058         * Remove dumpFrameLoadCallbacks from simple-subframe.html because it is
1059         located in a directory with the name "loading". And this will autoamtically
1060         enable dumping.
1061         * Remove this method from the LayoutTestController as it is unused now and this
1062         avoids adding it to the DRT of the Qt port.
1063         
1064
1065         * DumpRenderTree/LayoutTestController.cpp:
1066         (setPrivateBrowsingEnabledCallback):
1067
1068 2008-04-01  Christian Dywan  <christian@imendio.com>
1069
1070         Build fix for GCC 4.3.
1071
1072         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: include string.h
1073
1074 2008-04-01  Simon Hausmann  <hausmann@webkit.org>
1075
1076         Reviewed by Holger.
1077
1078         Fix Qt DRT run by also printing EOF on stderr, as expected by
1079         run-webkit-tests.
1080
1081         * DumpRenderTree/qt/DumpRenderTree.cpp:
1082         (WebCore::DumpRenderTree::dump):
1083
1084 2008-03-31  Julien Chaffraix  <julien.chaffraix@gmail.com>
1085
1086         Reviewed by Darin.
1087
1088         Bug 17665: determineSourceDir() dies if $sourceDir has a trailing backslash
1089
1090         Remove trailing '/' in $sourceDir in determineSourceDir().
1091
1092         Fix suggested by Dmitriy Kazachkov.
1093
1094         * Scripts/webkitdirs.pm:
1095
1096 2008-03-29  Adam Roben  <aroben@apple.com>
1097
1098         Update for rename of an IWebViewPrivate method
1099
1100         Reviewed by Mitz Pettel.
1101
1102         * DumpRenderTree/win/DumpRenderTree.cpp:
1103         (createWebViewAndOffscreenWindow):
1104
1105 2008-03-26  Antti Koivisto  <antti@apple.com>
1106
1107         Reviewed by Anders.
1108         
1109         Enable SVG animation support by default.
1110
1111         * Scripts/build-webkit:
1112
1113 2008-03-25  Adam Roben  <aroben@apple.com>
1114
1115         Windows build fix
1116
1117         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1118         Add $(WebKitLibrariesDir)\include to the include path so we can find
1119         stdint.h there.
1120
1121 2008-03-24  Eric Seidel  <eric@webkit.org>
1122
1123         Reviewed by Mark.
1124
1125         Clean up SVG features message to be less confusing.
1126
1127         * Scripts/build-webkit:
1128
1129 2008-03-24  Sam Weinig  <sam@webkit.org>
1130
1131         Reviewed by Dave Hyatt.
1132
1133         Add EventSender.zoomPageIn/zoomPageOut support to DRT.
1134
1135         * DumpRenderTree/mac/DumpRenderTree.mm:
1136         (resetWebViewToConsistentStateBeforeTesting):
1137         * DumpRenderTree/mac/EventSendingController.mm:
1138         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1139         (-[EventSendingController zoomPageIn]):
1140         (-[EventSendingController zoomPageOut]):
1141         * DumpRenderTree/win/DumpRenderTree.cpp:
1142         (resetWebViewToConsistentStateBeforeTesting):
1143         * DumpRenderTree/win/EventSender.cpp:
1144         (textZoomInCallback):
1145         (textZoomOutCallback):
1146         (zoomPageInCallback):
1147         (zoomPageOutCallback):
1148
1149 2008-03-24  Dan Bernstein  <mitz@apple.com>
1150
1151         Reviewed by Mark Rowe.
1152
1153         - update bisect-builds for Safari 3.1
1154
1155         * Scripts/bisect-builds: Added Safari 3.1 and the corresponding minimal
1156         revision, r29711.
1157
1158 2008-03-21  Rodney Dawes  <dobey@wayofthemonkey.com>
1159
1160         Reviewed by Holger.
1161
1162         http://bugs.webkit.org/show_bug.cgi?id=17981
1163
1164         Add webcore and javascriptcore cppflags to programs' _CPPFLAGS.
1165
1166         * GNUmakefile.am:
1167
1168 2008-03-21  Adam Roben  <aroben@apple.com>
1169
1170         Remove a non-working mirror from cygwin-downloader and add the ruby package
1171
1172         * CygwinDownloader/cygwin-downloader.py:
1173         * CygwinDownloader/cygwin-downloader.zip: Updated.
1174
1175 2008-03-20  Mark Rowe  <mrowe@apple.com>
1176
1177         Reviewed by Sam Weinig.
1178
1179         Ensure that the defines generated for FEATURE_DEFINES are sorted so that they will match the default settings of each project.
1180         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
1181         command-line.
1182
1183         * Scripts/build-webkit:
1184
1185 2008-03-17  Eric Seidel  <eric@webkit.org>
1186
1187         Reviewed by Dan Bernstein.
1188
1189         Fix bogus argCount check breaking plugin test.
1190
1191         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1192
1193 2008-03-17  Eric Seidel  <eric@webkit.org>
1194
1195         Reviewed by darin.
1196
1197         Cleanup PluginObject.cpp and add support for testing
1198         converting from int -> identifier -> string
1199         and from string -> identifier -> int
1200         as well as round-tripping ints and stings through identifiers
1201
1202         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1203         (pluginGetProperty):
1204         (pluginSetProperty):
1205         (testDOMAccess):
1206         (stringVariantToIdentifier):
1207         (int32VariantToIdentifier):
1208         (doubleVariantToIdentifier):
1209         (variantToIdentifier):
1210         (testIdentifierToString):
1211         (testIdentifierToInt):
1212         (testCallback):
1213         (getURL):
1214         (removeDefaultMethod):
1215         (getURLNotify):
1216         (testInvokeDefault):
1217         (destroyStream):
1218         (testEnumerate):
1219         (testGetIntIdentifier):
1220         (testGetProperty):
1221         (testEvaluate):
1222         (testGetPropertyReturnValue):
1223         (pluginInvoke):
1224         (pluginInvokeDefault):
1225         (pluginInvalidate):
1226         (pluginAllocate):
1227         (pluginDeallocate):
1228         (handleCallback):
1229
1230 2008-03-16  Kevin Ollivier  <kevino@theolliviers.com>
1231
1232         Rubber stamped by Darin.
1233
1234         Add set-webkit-configuration support for wx port, and centralize
1235         build dir location setting.
1236
1237         http://bugs.webkit.org/show_bug.cgi?id=17790
1238
1239         * wx/browser/browser.bkl:
1240         * wx/build-wxwebkit:
1241
1242 2008-03-15  Darin Adler  <darin@apple.com>
1243
1244         * Scripts/commit-log-editor: Include the name line of the change log entry.
1245         A long time ago I designed this script to not include the name because I
1246         thought it was redundant (same as the name of the person checking in), but
1247         nowadays it's more common for someone to check something in done by someone
1248         else.
1249
1250         * Scripts/do-webcore-rename: Added some more planned renames and removed
1251         some that were already done "by hand".
1252
1253 2008-03-13  Brent Fulgham  <bfulgham@gmail.com>
1254
1255         Reviewed by Darin.
1256
1257         Correct paths to vsprops files so they use the environment
1258         variable, rather than hard-coded path.
1259         http://bugs.webkit.org/show_bug.cgi?id=17797.
1260
1261         * WinLauncher/WinLauncher.vcproj:  Correct paths to vsprops.
1262
1263 2008-03-12  Steve Falkenburg  <sfalken@apple.com>
1264
1265         VSExpress build fix
1266
1267         * WinLauncher/WinLauncher.vcproj:
1268
1269 2008-03-12  Holger Hans Peter Freyther  <zecke@selfish.org>
1270
1271         Reviewed by Alp Toker.
1272
1273         Run testkjs in the correct productsDir in the GTK+ port.
1274
1275         * Scripts/run-javascriptcore-tests:
1276
1277 2008-03-11  Brent Fulgham  <bfulgham@gmail.com>
1278
1279         Reviewed by Adam Roben.
1280
1281         Enabled WinLauncher as part of normal Windows build.
1282         http://bugs.webkit.org/show_bug.cgi?id=17715.
1283
1284         * WinLauncher/WinLauncher.vcproj: Update to use vsprops so that
1285           it can find the proper libraries to link against.
1286
1287 2008-03-10  Julien Chaffraix  <julien.chaffraix@gmail.com>
1288
1289         Reviewed and landed by Darin.
1290
1291         http://bugs.webkit.org/show_bug.cgi?id=17581
1292         Bug 17581: Use of uninitialized value in string ne at WebKitTools/Scripts/run-webkit-tests line 1576.
1293
1294         Remove the previous warning which occurs when the --random option is used.
1295
1296         * Scripts/run-webkit-tests: verify that $component[0] is defined before checking for
1297         its inequality
1298
1299 2008-03-07  Simon Hausmann  <hausmann@webkit.org>
1300
1301         Reviewed by Darin.
1302
1303         Done with Lars.
1304
1305         Ported the netscape test plugin to QWebPluginFactory.
1306
1307         * DumpRenderTree/qt/DumpRenderTree.cpp:
1308         (WebCore::WebPage::WebPage):
1309         * DumpRenderTree/qt/main.cpp:
1310         * DumpRenderTree/qt/testplugin.cpp:
1311         (TestPlugin::plugins):
1312         (TestPlugin::create):
1313         * DumpRenderTree/qt/testplugin.h:
1314
1315 2008-03-09  Steve Falkenburg  <sfalken@apple.com>
1316
1317         Stop Windows build if an error occurs in a prior project.
1318
1319         Rubber stamped by Darin.
1320
1321         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1322         * DumpRenderTree/win/DumpRenderTree.vcproj:
1323         * DumpRenderTree/win/ImageDiff.vcproj:
1324         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1325
1326 2008-03-08  Julien Chaffraix  <julien.chaffraix@gmail.com>
1327
1328         Reviewed by Mark Rowe.
1329
1330         DRT build fix for Tiger.
1331
1332         * DumpRenderTree/mac/DumpRenderTreeMac.h: Define BUILDING_ON_TIGER.
1333
1334 2008-03-07  Mark Rowe  <mrowe@apple.com>
1335
1336         Reviewed by Oliver Hunt.
1337
1338         Fix WebKit build with GCC 4.2.
1339
1340         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Use correct argument type in method signature.
1341
1342 2008-03-07  Stephanie Lewis <slewis@apple.com>
1343
1344         Reviewed by Oliver.
1345
1346         Add Windows part of <rdar://problem/5693690> 
1347
1348         * DumpRenderTree/win/DumpRenderTree.cpp:
1349         (dump):
1350         (main):
1351
1352 2008-03-07  Alp Toker  <alp@atoker.com>
1353
1354         Back out the r30818, r30819 build fix attempts now the GTK+ build
1355         server has been upgraded.
1356
1357         * Scripts/webkitdirs.pm:
1358
1359 2008-03-07  Stephanie Lewis <slewis@apple.com>
1360
1361         Reviewed by Geoff.
1362
1363         <rdar://problem/5693690> run-webkit-tests swallows STDERR output, including WebCore LEAK messages
1364
1365         * DumpRenderTree/mac/DumpRenderTree.mm:
1366         (dump): push EOF to stderr after every test
1367         * Scripts/run-webkit-tests: collect stderr output and print it
1368
1369 2008-03-07  Steve Falkenburg  <sfalken@apple.com>
1370
1371         Get pdevenv working with Visual Studio Express.
1372         
1373         Reviewed by Adam.
1374
1375         * Scripts/pdevenv:
1376
1377 2008-03-06  Adele Peterson  <adele@apple.com>
1378
1379         Reviewed by Darin.
1380
1381         Updated for testing <rdar://problem/5785895> Implement hasFocus() for HTMLDocument (HTML5)
1382
1383         * DumpRenderTree/mac/UIDelegate.mm:
1384         (-[UIDelegate webViewFocus:]): Remove duplicate code that was also in LayoutTestController::setWindowIsKey
1385         (-[UIDelegate webViewUnfocus:]): Added.  In Safari, the default is to focus another window if there is one.
1386          To easily test cases where the window is unfocused, I made this just call setWindowIsKey(false).
1387
1388 2008-03-06  Matt Lilek  <webkit@mattlilek.com>
1389
1390         Reviewed by Adam Roben.
1391
1392         Bug 17691: REGRESSION: FindSafari doesn't work
1393         http://bugs.webkit.org/show_bug.cgi?id=17691
1394
1395         Swap my change from r30394 to use the Release libraries instead of Debug
1396         since some machines don't have the Debug version.
1397
1398         * FindSafari/FindSafari.vcproj:
1399
1400 2008-03-06  Kevin McCullough  <kmccullough@apple.com>
1401
1402         Reviewed by Sam and Tim.
1403
1404         <rdar://5631450> Drosera: breakpoint indicators disappear after the
1405         script is finished running.
1406         - If there is a pre-existing breakpoint on a line when the file is
1407         updated we need to redraw it.
1408
1409         * Drosera/debugger.js:
1410
1411 2008-03-06  Brady Eidson  <beidson@apple.com>
1412
1413         Tiger build fix...?
1414
1415         * DumpRenderTree/mac/WatchdogMac.mm:
1416
1417 2008-03-06  Brady Eidson  <beidson@apple.com>
1418
1419         Reviewed by Darin
1420
1421         Added a cross-platform Watchdog thread to DRT.
1422
1423         The current watchdog in both DRTWin and DRTMac is Timer based.  Therefore, deadlocks and long running
1424         main thread hangs still affect DRT.
1425
1426         By placing the watchdog on a thread and having DRT "check in" after each test, long-running hangs
1427         and true deadlocks can be caught.
1428
1429         There is one hook for platform specific code.  As I did my development and testing on Mac, and Mac has
1430         `sample` available, the Mac implementation of this hook samples the process before it is killed.
1431
1432         I arbitrarily chose 30 seconds as the timeout for now - this can be tweaked easily if we find a need.
1433
1434         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1435         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added LINKER_DISPLAYS_MANGLED_NAMES
1436
1437         * DumpRenderTree/ForwardingHeaders/wtf/Locker.h: Added.
1438         * DumpRenderTree/ForwardingHeaders/wtf/Threading.h: Added.
1439
1440         * DumpRenderTree/Watchdog.cpp: Added.
1441         (Watchdog::Watchdog):
1442         (Watchdog::~Watchdog):
1443         (Watchdog::start):
1444         (Watchdog::stop):
1445         (Watchdog::checkIn):
1446         (Watchdog::setWatchdogInterval):
1447         (Watchdog::handleHang):
1448         (Watchdog::watchdogThreadStart):
1449         (Watchdog::watchdogThread):
1450         * DumpRenderTree/Watchdog.h: Added.
1451
1452         * DumpRenderTree/mac/WatchdogMac.h: Added.
1453         * DumpRenderTree/mac/WatchdogMac.mm: Added.
1454         (WatchdogMac::handleHang): Sample the process and write it out to a file
1455
1456         * DumpRenderTree/mac/DumpRenderTree.mm:
1457         (dumpRenderTree): Setup and start the watchdog before running any tests
1458         (runTest): Checkin with the watchdog after each test
1459
1460 2008-03-05  Alp Toker  <alp@atoker.com>
1461
1462         Attempt to get the autotools build working again on the bot with
1463         build-webkit.
1464
1465         Force the use of /bin/bash since we seem to have bash-isms in the
1466         configure script right now.
1467
1468         * Scripts/webkitdirs.pm:
1469
1470 2008-03-05  Alp Toker  <alp@atoker.com>
1471
1472         Re-attempt to switch to the autotools build system for GTK+.
1473
1474         Change scripts to continue when distclean fails.
1475
1476         * Scripts/webkitdirs.pm:
1477
1478 2008-03-05  Alp Toker  <alp@atoker.com>
1479
1480         Force qmake for the GTK+ build until we get the build bot to succeed
1481         with autotools (currently dies at make distclean)
1482
1483         * Scripts/webkitdirs.pm:
1484
1485 2008-03-04  Alp Toker  <alp@atoker.com>
1486
1487         Reviewed by Mark Rowe.
1488
1489         Switch the default GTK+ build system from qmake to autotools.
1490
1491         qmake can still be used by defining WEBKIT_BUILD_SYSTEM=qmake
1492
1493         * Scripts/build-webkit:
1494         * Scripts/run-launcher:
1495         * Scripts/run-webkit-tests:
1496         * Scripts/webkitdirs.pm:
1497
1498 2008-03-04  Sam Weinig  <sam@webkit.org>
1499
1500         Reviewed by Darin Adler.
1501
1502         * Scripts/do-webcore-rename: Update renaming plan.
1503
1504 2008-03-02  Brent Fulgham  <bfulgham@gmail.com>
1505
1506         Reviewed by Alp Toker.
1507
1508         Remove some needless LIBS.
1509
1510         * GNUmakefile.am:
1511
1512 2008-03-02  Alp Toker  <alp@atoker.com>
1513
1514         Reviewed by Mark Rowe.
1515
1516         Split the WebKit GTK+ build out of the WebCore build and change the
1517         shared object name to match the package name.
1518
1519         * GNUmakefile.am:
1520
1521 2008-03-01  Mark Rowe  <mrowe@apple.com>
1522
1523         Reviewed by Tim Hatcher.
1524
1525         Update Xcode configuration to support building debug and release from the mysterious future.
1526
1527         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1528
1529 2008-02-29  David Kilzer  <ddkilzer@apple.com>
1530
1531         Pass the correct configuration switch (--Debug|--Release) to build-testkjs.
1532
1533         Reviewed by Dan.
1534
1535         Originally broken in r26838.
1536
1537         * Scripts/run-javascriptcore-tests: Push configuration switch onto @xcodeArgs
1538         not local, unused @args variable.
1539
1540 2008-02-29  David Kilzer  <ddkilzer@apple.com>
1541
1542         Bug 15754: webarchive layout tests fail when WebKit directory path contains symlinks
1543
1544         <http://bugs.webkit.org/show_bug.cgi?id=15754>
1545
1546         Reviewed by Geoff and Darin.
1547
1548         We were using -[NSFileManager currentDirectoryPath] to get the current working directory,
1549         then removing that path from all file:/// URLs in the WebArchive output so these tests
1550         would pass no matter where they were run.
1551
1552         The problem was that -[NSFileManager currentDirectoryPath] resolves symlinks in the
1553         current working directory, but the WebArchive does not.  This left the current working
1554         directory in all file:/// URLs in the test output, and thus all tests failed, for any
1555         developer that used symlinks to get to their WebKit source directory.
1556
1557         The fix is to look backwards for "/LayoutTests/" in the URL we're passed, and simply
1558         remove the current working directory path (no matter what it is) after "file://" but
1559         before "/LayoutTests/".  
1560
1561         * DumpRenderTree/mac/DumpRenderTree.mm:
1562         (normalizeWebResourceURL): Removed unused oldURLBase argument.  We now replace the
1563         current working directory as described above.
1564         (convertWebResourceResponseToDictionary): Remove unused oldURLBase argument.  Update
1565         calls to normalizeWebResourceURL().
1566         (serializeWebArchiveToXML): Removed now unused cwdURL variable.  Update calls to
1567         normalizeWebResourceURL() and convertWebResourceResponseToDictionary().
1568
1569 2008-02-26  Robin Dunn <robin@alldunn.com>
1570
1571         Reviewed by Kevin Ollivier.
1572
1573         Improvements to the wx build script.
1574
1575         http://bugs.webkit.org/show_bug.cgi?id=17492
1576
1577         * wx/build-wxwebkit:
1578         - Update the Windows dll copying logic to copy dlls inside WebKitLibraries/win
1579         - Allow the build script to properly find wxPython includes under different setups
1580         - Make sure WX_PREFIX is set to WXWIN (wxWindows dir environment var.) if not defined
1581
1582 2008-02-26  Timothy Hatcher  <timothy@apple.com>
1583
1584         Reviewed by Darin Adler.
1585
1586         * Scripts/build-webkit: Add --universal and --64-bit flags to make building
1587         64-bit architectures easy. Combine the two flags to build 4-way universal.
1588         * Makefile: Add "64" and "64u" make rules. Fix the universal rule to return
1589         non-zero when the build failes.
1590
1591 2008-02-26  Jessica Kahn  <jess@apple.com>
1592
1593         Reviewed by Darin.
1594
1595         * Scripts/gdb-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in gdb's environment,
1596         so that Safari inherits it when launched. Preexisting code in WebKit checks this
1597         environment variable, and if set, unsets DYLD_FRAMEWORK_PATH, so that applications
1598         launched by Safari continue to use the standard system WebKit.
1599
1600 2008-02-25  Adam Roben  <aroben@apple.com>
1601
1602         Fix run-webkit-tests after r30394
1603
1604         * Scripts/webkitdirs.pm: Never append _debug to FindSafari's
1605         executable name.
1606
1607 2008-02-24  Darin Adler  <darin@apple.com>
1608
1609         * Scripts/do-webcore-rename: Make some updates based on a trial run of
1610         the renaming script.
1611
1612 2008-02-24  Darin Adler  <darin@apple.com>
1613
1614         * Scripts/do-webcore-rename: More renaming plans.
1615
1616 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1617
1618         Rubber stamped by Darin.
1619
1620         Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
1621         whitespaces introduced in the previous commit.
1622
1623         * GNUmakefile.am:
1624
1625 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1626
1627         Rubber-stamped by Darin.
1628
1629         * GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
1630
1631 2008-02-23  David Kilzer  <ddkilzer@apple.com>
1632
1633         Please clarify licensing for some files
1634         <http://bugs.webkit.org/show_bug.cgi?id=14970>
1635
1636         Reviewed by Darin.
1637
1638         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Added
1639         copyright statement.  Replaced license with newer Apple BSD-style license.
1640         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Ditto.
1641         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Ditto.
1642         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Ditto.
1643         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Ditto.
1644         * DumpRenderTree/win/TestNetscapePlugin/main.c: Ditto.
1645         * mangleme/LICENSE: Added (LGPL).
1646
1647 2008-02-22  Anders Carlsson  <andersca@apple.com>
1648
1649         Reviewed by Adam.
1650
1651         <rdar://problem/5748781> 
1652         https://bugs.webkit.org/show_bug.cgi?id=17413
1653         REGRESSION: Latest Nightly doesn't load Java plugin w/Safari 3.1b
1654         
1655         Copy the Java plug-in over to the new location.
1656         
1657         * FindSafari/FindSafari.cpp:
1658         (_tmain):
1659
1660 2008-02-22  Anders Carlsson  <andersca@apple.com>
1661
1662         Reviewed by Adam.
1663
1664         <rdar://problem/5747325> REGRESSION: HTTP layout tests hang
1665         
1666         * DumpRenderTree/win/DumpRenderTree.cpp:
1667         (runTest):
1668         Init the URL request with the correct timeout.
1669
1670 2008-02-21  Mike Auty  <mike.auty@gmail.com>
1671
1672         Reviewed by Alp Toker.
1673
1674         http://bugs.webkit.org/show_bug.cgi?id=17445
1675         [GTK] WebKit doesn't compile with LDFLAGS="-Wl,--as-needed"
1676
1677         GTK+/autotools build system improvements
1678
1679         The GNUmakefile.am files make use of the LDFLAGS variable to include library
1680         additions such as -ljpeg etc.  Unfortunately, if these inclusions aren't made
1681         in LIBADD/LDADD variables, then they are mis-ordered during the linking.
1682
1683         The as-needed flag discards libraries whose functions have not been needed by
1684         earlier libraries, which therefore makes the ordering important.
1685
1686         This moves all -l library inclusion statements from LDFLAGS variables to
1687         LIBADD/LDADD variables.
1688
1689         * GNUmakefile.am:
1690
1691 2008-02-20  Brent Fulgham  <bfulgham@gmail.com>
1692
1693         Reviewed by Alp.
1694
1695         - http://bugs.webkit.org/show_bug.cgi?id=17428
1696           Reenable a Windows-based launcher
1697
1698         This patch reenables the venerable Spinneret application,
1699         changing its name to match the other lanch applications.
1700
1701         * WinLauncher: Added.
1702         * WinLauncher/WinLauncher.cpp: Added.
1703         (WinLauncherWebHost::updateAddressBar):
1704         (WinLauncherWebHost::QueryInterface):
1705         (WinLauncherWebHost::AddRef):
1706         (WinLauncherWebHost::Release):
1707         (resizeSubViews):
1708         (_tWinMain):
1709         (MyRegisterClass):
1710         (InitInstance):
1711         (WndProc):
1712         (MyEditProc):
1713         (About):
1714         (loadURL):
1715         * WinLauncher/WinLauncher.h: Added.
1716         (WinLauncherWebHost::WinLauncherWebHost):
1717         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
1718         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
1719         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1720         (WinLauncherWebHost::didCommitLoadForFrame):
1721         (WinLauncherWebHost::didReceiveTitle):
1722         (WinLauncherWebHost::didReceiveIcon):
1723         (WinLauncherWebHost::didFinishLoadForFrame):
1724         (WinLauncherWebHost::didFailLoadWithError):
1725         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
1726         (WinLauncherWebHost::willPerformClientRedirectToURL):
1727         (WinLauncherWebHost::didCancelClientRedirectForFrame):
1728         (WinLauncherWebHost::willCloseFrame):
1729         (WinLauncherWebHost::windowScriptObjectAvailable):
1730         * WinLauncher/WinLauncher.ico: Added.
1731         * WinLauncher/WinLauncher.rc: Added.
1732         * WinLauncher/WinLauncher.vcproj: Added.
1733         * WinLauncher/resource.h: Added.
1734         * WinLauncher/small.ico: Added.
1735         * WinLauncher/stdafx.cpp: Added.
1736         * WinLauncher/stdafx.h: Added.
1737
1738 2008-02-19  Brady Eidson  <beidson@apple.com>
1739
1740         Reviewed by Geoff
1741
1742         Fixed a bug in DRT --threaded mode
1743
1744         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
1745         (startJavaScriptThreads): Don't detach the newly created thread.  The later call to stopJavaScriptThreads() tries
1746           to pthread_join() each thread that had been created, but you can't join a detached thread!
1747
1748 2008-02-18  Brady Eidson  <beidson@apple.com>
1749
1750         Changes by Geoff Garen, Reviewed by Darin
1751
1752         Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
1753
1754         DRT changes for test: platform/mac/plugins/webScriptObject-exception-deadlock.html
1755
1756         [WebScriptObject valueForKey:] might throw an exception, and previously might have "leaked" the global JSLock
1757         This test calls valueForKey, then runs some arbitrary Javascript on a 2ndary thread.  If the lock has leaked,
1758         this series of method calls will deadlock.  If things are good, it will complete successfully.
1759
1760         * DumpRenderTree/mac/ObjCController.m:
1761         (runJavaScriptThread):
1762         (+[ObjCController isSelectorExcludedFromWebScript:]):
1763         (+[ObjCController webScriptNameForSelector:]):
1764         (-[ObjCController testValueForKey]):
1765
1766 2008-02-18  Matt Lilek  <webkit@mattlilek.com>
1767
1768         Reviewed by Adam.
1769
1770         Remove FindSafari's Release configuration.
1771
1772         * FindSafari/FindSafari.vcproj:
1773
1774 2008-02-15  Adam Roben  <aroben@apple.com>
1775
1776         Fix a typo that broke the Mac build
1777
1778         Reviewed by Mark.
1779
1780         * Scripts/build-webkit:
1781
1782 2008-02-14  Adam Roben  <aroben@apple.com>
1783
1784         Turn on cross-document messaging support by default
1785
1786         Reviewed by Darin.
1787
1788         * Scripts/build-webkit:
1789
1790 2008-02-14  Adam Roben  <aroben@apple.com>
1791
1792         Conditionalize cross-document messaging support
1793
1794         The cross-document messaging parts of HTML 5 are in flux and we want
1795         ports to be able to turn off the support as needed.
1796
1797         Note that the support is turned off by default right now. A subsequent
1798         commit will turn it on by default.
1799
1800         Reviewed by Darin.
1801
1802         * Scripts/build-webkit:
1803
1804 2008-02-14  Darin Adler  <darin@apple.com>
1805
1806        - fix Windows build
1807
1808         * DumpRenderTree/win/UIDelegate.cpp:
1809         (UIDelegate::setStatusText): Update parameter types to match declaration.
1810
1811 2008-02-14  Oliver Hunt  <oliver@apple.com>
1812
1813         Reviewed by Geoff G and Weinig.
1814
1815         Add ability for DRT to report tests setting the status text.
1816
1817         * DumpRenderTree/LayoutTestController.cpp:
1818         (LayoutTestController::LayoutTestController):
1819         (dumpStatusCallbacksCallback):
1820         (LayoutTestController::staticFunctions):
1821         * DumpRenderTree/LayoutTestController.h:
1822         * DumpRenderTree/mac/UIDelegate.mm:
1823         (-[UIDelegate webView:setStatusText:]):
1824         * DumpRenderTree/win/UIDelegate.cpp:
1825         * DumpRenderTree/win/UIDelegate.h:
1826
1827 2008-02-13  Adam Roben  <aroben@apple.com>
1828
1829         Windows build fix
1830
1831         * DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.
1832
1833 2008-02-13  Adam Roben  <aroben@apple.com>
1834
1835         Windows/GTK+ build fix
1836
1837         * DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to
1838         get isnan.
1839
1840 2008-02-13  Brady Eidson  <beidson@apple.com>
1841
1842         Reviewed by Darin Adler
1843
1844         Add some much needed Database support to DRT
1845
1846         * DumpRenderTree/LayoutTestController.cpp:
1847         (LayoutTestController::LayoutTestController):
1848         (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to
1849           databases are called
1850         (clearAllDatabasesCallback): Allow a test to delete all databases
1851         (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get
1852         (LayoutTestController::staticFunctions):
1853
1854         * DumpRenderTree/LayoutTestController.h:
1855         (LayoutTestController::dumpDatabaseCallbacks):
1856         (LayoutTestController::setDumpDatabaseCallbacks):
1857
1858         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1859         (LayoutTestController::clearAllDatabases):
1860         (LayoutTestController::setDatabaseQuota):
1861
1862         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1863         (LayoutTestController::clearAllDatabases): Stubbed out
1864         (LayoutTestController::setDatabaseQuota): Ditto
1865         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1866         (LayoutTestController::clearAllDatabases): Stubbed out with error message
1867         (LayoutTestController::setDatabaseQuota): Ditto
1868
1869         * DumpRenderTree/mac/UIDelegate.mm:
1870         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a
1871           message with details about the event then return a 5mb quota like before
1872
1873
1874 2008-02-12  Steve Falkenburg  <sfalken@apple.com>
1875
1876         Changes to support merged MIDL output.
1877
1878         All COM interfaces are now generated to WebKit.h.
1879
1880         Reviewed by Sam, Ada.
1881
1882         * Drosera/win/BaseDelegate.h:
1883         * Drosera/win/DebuggerClient.cpp:
1884         * Drosera/win/DebuggerDocumentPlatform.cpp:
1885         * Drosera/win/Drosera.cpp:
1886         * Drosera/win/ServerConnection.cpp:
1887         * Drosera/win/ServerConnection.h:
1888         * DumpRenderTree/win/DumpRenderTree.cpp:
1889         * DumpRenderTree/win/EditingDelegate.h:
1890         * DumpRenderTree/win/EventSender.cpp:
1891         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1892         * DumpRenderTree/win/FrameLoadDelegate.h:
1893         * DumpRenderTree/win/GCControllerWin.cpp:
1894         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1895         * DumpRenderTree/win/PolicyDelegate.h:
1896         * DumpRenderTree/win/ResourceLoadDelegate.h:
1897         * DumpRenderTree/win/UIDelegate.cpp:
1898         * DumpRenderTree/win/UIDelegate.h:
1899         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1900
1901 2008-02-10  Dan Bernstein  <mitz@apple.com>
1902
1903         Reviewed by Oliver Hunt.
1904
1905         - fix a memory leak
1906
1907         * DumpRenderTree/cg/ImageDiffCG.cpp:
1908         (getDifferenceBitmap): Use a static CFMutableData instead of allocating
1909         and leaking the buffer each time.
1910
1911 2008-02-07  Adam Roben  <aroben@apple.com>
1912
1913         Fix error in bisect-builds when responding "broken" for the first
1914         build
1915
1916         Reviewed by Dave Kilzer.
1917
1918         * Scripts/bisect-builds: Only try to test the build if the nightly
1919         info for the current index has not been deleted.
1920
1921 2008-02-07  Geoffrey Garen  <ggaren@apple.com>
1922
1923         Reviewed by Alexey Proskuryakov.
1924
1925         Fixed two minor typos in the --root option, to get it working.
1926
1927         * Scripts/run-sunspider:
1928             1. Actually assign the function argument to our local variable.
1929             2. Actually set the $root variable, so we don't try to build later.
1930
1931 2008-02-05  Oliver Hunt  <oliver@apple.com>
1932
1933         RS=Eric.
1934
1935         Re-enable foreignObject by default as it is needed for a number of non-fO
1936         related SVG tests and none of the old known crashes occur anymore.
1937
1938         * Scripts/build-webkit:
1939
1940 2008-02-05  Steve Falkenburg  <sfalken@apple.com>
1941
1942         Build fix.  Don't override intermediate directory.
1943
1944         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1945
1946 2008-02-05  Holger Hans Peter Freyther  <zecke@selfish.org>
1947
1948         Build fix for Windows. willCloseFrame is a pure virtual and we are
1949         forced to have an implementation.
1950         
1951         This partially reverts r30014.
1952
1953         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1954         (FrameLoadDelegate::willCloseFrame):
1955         * DumpRenderTree/win/FrameLoadDelegate.h:
1956
1957 2008-02-05  Nikolas Zimmermann  <zimmermann@kde.org>
1958
1959         Reviewed by Holger.
1960
1961         Don't build wrapper for SVGTestCase.js (special file for svg/dynamic-updates)
1962
1963         * Scripts/make-js-test-wrappers:
1964
1965 2008-02-05  Holger Freyther  <zecke@selfish.org>
1966
1967         Reviewed by Darin.
1968
1969         In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
1970         the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
1971         depends on the order the tests are executed.
1972         
1973         Propose to remove willCloseFrame and didlCearWindowObject output from the
1974         FrameLoadDelegate and update the test results. The output of didClearWindowObject
1975         is not interesting for any of the current tests and we have other ways to find
1976         out if a frame was closed or not.
1977
1978         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1979         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1980         (FrameLoadDelegate::didClearWindowObject):
1981         * DumpRenderTree/win/FrameLoadDelegate.h:
1982
1983 2008-02-04  Mark Rowe  <mrowe@apple.com>
1984
1985         Reviewed by Oliver Hunt.
1986
1987         Workaround for http://bugs.webkit.org/show_bug.cgi?id=16842
1988         Bug 16842: Hang in DRT in leaks mode due to signal handler doing unsafe things
1989
1990         Don't install the signal handler unless we are running the pixel tests.
1991         It is currently only used to restore the color profile, but by catching
1992         signals we can trigger a deadlock in DRT while running leak tests.
1993         The deadlock is tracked by http://bugs.webkit.org/show_bug.cgi?id=16842,
1994         and a more complete fix will need to be developed to address this for
1995         pixel tests as well.
1996
1997         * DumpRenderTree/mac/DumpRenderTree.mm:
1998         (dumpRenderTree):
1999
2000 2008-02-04  Mark Rowe  <mrowe@apple.com>
2001
2002        Gtk qmake build fix.
2003
2004         * Scripts/webkitdirs.pm:  Fix perl's complaint about an odd number of elements in anonymous hash.
2005
2006 2008-02-04  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
2007
2008         Reviewed by Alp Toker and Mark Rowe.
2009
2010         http://bugs.webkit.org/show_bug.cgi?id=16618
2011         [GTK] build-webkit and run-webkit-tests autootools support
2012
2013         * Scripts/build-webkit: added --database and --icon-database options
2014         * Scripts/run-launcher:
2015         * Scripts/run-webkit-tests:
2016         * Scripts/webkitdirs.pm:
2017
2018 2008-02-04  Oliver Hunt  <oliver@apple.com>
2019
2020         Reviewed by Steve F.
2021
2022         Partial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT
2023
2024         Implement required DRT functionality to allow majority of Drag and Drop testcases to work.
2025         Issues include:
2026           * Uses Sleep() to implement leapForward reliably.
2027           * 3 DND tests still fail for reasons that i have not yet determined
2028           * Has to explicitly ignore an extraneous WM_MOUSELEAVE that i am at a loss to explain 
2029
2030         * DumpRenderTree/win/EventSender.cpp:
2031         (leapForwardCallback):
2032         (mouseDownCallback):
2033         (doMouseUp):
2034         (mouseUpCallback):
2035         (doMouseMove):
2036         (mouseMoveToCallback):
2037           Minor updates to these functions to handle the different message queue structure.
2038
2039         (replaySavedEvents):
2040           More complicated now.  Where possible we just use the old while-loop model of execution,
2041           but when leapForward has been used we have to jump through some hoops and set up an 
2042           inner event loop so that we can ensure messages get the correct time stamp.
2043
2044         * DumpRenderTree/win/UIDelegate.cpp:
2045         (UIDelegate::doDragDrop):
2046           Call replaySavedEvents directly to force synchronous handling of drag and drop.
2047
2048 2008-02-04  Rodney Dawes  <dobey@wayofthemonkey.com>
2049
2050         Reviewed by Alp Toker and Mark Rowe.
2051
2052         Fix http://bugs.webkit.org/show_bug.cgi?id=17175.
2053         Bug 17175: Use of C++ compiler flags in CFLAGS
2054
2055         * GNUmakefile.am: Use global_cxxflags as well as global_cflags in CXXFLAGS.
2056
2057 2008-02-04  Darin Adler  <darin@apple.com>
2058
2059         Reviewed by Geoff.
2060
2061         * Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast
2062         and svg subdirectories. Added some more exceptions for the benefit of the fast/dom
2063         subdirectory.
2064
2065 2008-02-04  Adam Roben  <aroben@apple.com>
2066
2067         Windows Apple-only build fix
2068
2069         * DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include
2070         directory.
2071
2072 2008-02-04  Alp Toker  <alp@atoker.com>
2073
2074         Rubber-stamped by Mark Rowe.
2075
2076         Remove all trailing whitespace in the GTK+ port and related
2077         components.
2078
2079         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2080         * DumpRenderTree/gtk/GCControllerGtk.cpp:
2081         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2082         * GNUmakefile.am:
2083
2084 2008-02-01  Eric Seidel  <eric@webkit.org>
2085
2086         Reviewed by Oliver.
2087
2088         Also search LayoutTests/svg for js-based tests.
2089
2090         * Scripts/make-js-test-wrappers:
2091
2092 2008-01-31  Alp Toker  <alp@atoker.com>
2093
2094         Rubber-stamped by Adam Roben.
2095
2096         http://bugs.webkit.org/show_bug.cgi?id=17006
2097         [GTK] Header path should be webkit/webkit.h
2098
2099         Move the GTK+ API sources as needed and update the build systems.
2100
2101         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2102         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2103         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2104         * GNUmakefile.am:
2105         * GtkLauncher/main.c:
2106
2107 2008-01-30  Stephanie  <slewis@apple.com>
2108
2109         Reviewed by Geoff.
2110
2111         Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth.  This should make it easier for the buildbots to track new leaks.
2112
2113         * Scripts/run-webkit-tests:
2114
2115 2008-01-30  Alexey Proskuryakov  <ap@webkit.org>
2116
2117         Reviewed by Adam Roben.
2118
2119         One more debug (external) fix.
2120
2121         * DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal
2122         and Debug configurations. 
2123
2124 2008-01-29  Geoffrey Garen  <ggaren@apple.com>
2125
2126         Reviewed by Sam Weinig. Sam Weinig.
2127         
2128         Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
2129         fails when run after fast/dom/Window/window-property-shadowing.html (16902)
2130
2131         Modified our policy delegates not to output window.name. Since a
2132         previous test may have explicitly set window.name, we can't rely on its
2133         implicit value in test results.
2134
2135         * DumpRenderTree/mac/PolicyDelegate.mm:
2136         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2137
2138         * DumpRenderTree/win/PolicyDelegate.cpp:
2139         (PolicyDelegate::decidePolicyForNavigationAction):
2140
2141 2008-01-29  Mark Rowe  <mrowe@apple.com>
2142
2143         Reviewed by Tim Hatcher.
2144
2145         <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).
2146
2147         * Scripts/build-webkit: Copy SQLite static library and headers into the build directory.
2148
2149 2008-01-29  David Kilzer  <ddkilzer@apple.com>
2150
2151         Refactor ChangeLog path code
2152
2153         Reviewed by Adam.
2154
2155         * Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract
2156         duplicate code in another foreach() loop.
2157
2158 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
2159
2160         Reviewed by Darin.
2161
2162         <rdar://problem/5710692> All storage tests fail/crash
2163
2164         * DumpRenderTree/mac/UIDelegate.mm:
2165         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an
2166         arbitrary quota of 5 megabytes.
2167
2168         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2169         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
2170         Removed unused (I think) code.
2171         
2172         * DumpRenderTree/win/UIDelegate.cpp:
2173         (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported.
2174         (UIDelegate::webViewPainted): A stub implementation.
2175         (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
2176         * DumpRenderTree/win/UIDelegate.h:
2177
2178 2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
2179
2180         GTK+ DRT build fix for breakage introduced in r29822.
2181
2182         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2183         (LayoutTestController::setPersistentUserStyleSheetLocation):
2184         (LayoutTestController::clearPersistentUserStyleSheet):
2185
2186 2008-01-27  Dan Bernstein  <mitz@apple.com>
2187
2188         Reviewed by Darin Adler.
2189
2190         - add support for directory prologues and epilogues to run-webkit-tests
2191         - allow setting a persistent user style sheet in DumpRenderTree
2192         - activate the WebKit Layout Tests font in Windows DumpRenderTree
2193
2194         * DumpRenderTree/LayoutTestController.cpp:
2195         (clearPersistentUserStyleSheetCallback): Added.
2196         (setPersistentUserStyleSheetLocationCallback): Added.
2197         (LayoutTestController::staticFunctions): Added.
2198         clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
2199         * DumpRenderTree/LayoutTestController.h:
2200         * DumpRenderTree/mac/DumpRenderTree.mm:
2201         (setPersistentUserStyleSheetLocation): Added.
2202         (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
2203         to the set of things this function resets. Now it either disables the
2204         user style sheet or sets it to the persistent user style sheet and
2205         enables it.
2206         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2207         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2208         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
2209         (LayoutTestController::clearPersistentUserStyleSheet): Added.
2210         * DumpRenderTree/win/DumpRenderTree.cpp:
2211         (setPersistentUserStyleSheetLocation): Added.
2212         (initialize): Added the WebKit Layout Tests font to the set of fonts to
2213         install.
2214         (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
2215         * DumpRenderTree/win/DumpRenderTreeWin.h:
2216         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2217         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
2218         (LayoutTestController::clearPersistentUserStyleSheet): Added.
2219         * Scripts/run-webkit-tests: Changed to look for, and if found process in
2220         DumpRenderTree, files named run-webkit-tests-prologue.html and
2221         run-webkit-tests-epilogue.html in the resources subdirectory of any
2222         test directory and platform test results directory. The prologues are
2223         processed before the first test from the directory (and its
2224         subdirectories) is run, and the epilogues are processed after the last
2225         test from the directory is run. Platform-specific prologues and
2226         epilogues are processed in order of specificity.
2227
2228 2008-01-25  Alexey Proskuryakov  <ap@webkit.org>
2229
2230         Reviewed by Mark Rowe.
2231
2232         <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing
2233
2234         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
2235         (matching Mac DRT).
2236         * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
2237
2238 2008-01-24  Sam Weinig  <sam@webkit.org>
2239
2240         Reviewed by Ada Chan.
2241
2242         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
2243
2244         - Adds simplified UndoManager to windows DRT to allow testing the
2245           undo/redo code paths in WebCore and WebKit.  This is a temporary
2246           solution to an issue that should eventually be solved by having a
2247           shared UndoManager in WebKit.
2248
2249         * DumpRenderTree/win/DumpRenderTree.cpp:
2250         (runTest):
2251         * DumpRenderTree/win/UIDelegate.cpp:
2252         (DRTUndoObject::DRTUndoObject):
2253         (DRTUndoObject::invoke):
2254         (DRTUndoStack::~DRTUndoStack):
2255         (DRTUndoStack::isEmpty):
2256         (DRTUndoStack::clear):
2257         (DRTUndoStack::push):
2258         (DRTUndoStack::pop):
2259         (DRTUndoManager::canRedo):
2260         (DRTUndoManager::canUndo):
2261         (DRTUndoManager::DRTUndoManager):
2262         (DRTUndoManager::removeAllActions):
2263         (DRTUndoManager::registerUndoWithTarget):
2264         (DRTUndoManager::redo):
2265         (DRTUndoManager::undo):
2266         (UIDelegate::UIDelegate):
2267         (UIDelegate::resetUndoManager):
2268         (UIDelegate::registerUndoWithTarget):
2269         (UIDelegate::removeAllActionsWithTarget):
2270         (UIDelegate::setActionTitle):
2271         (UIDelegate::undo):
2272         (UIDelegate::redo):
2273         (UIDelegate::canUndo):
2274         (UIDelegate::canRedo):
2275         * DumpRenderTree/win/UIDelegate.h:
2276
2277 2008-01-23  Adam Roben  <aroben@apple.com>
2278
2279         Allow directories containing ChangeLogs to be passed to
2280         resolve-ChangeLogs
2281
2282         Reviewed by David Kilzer.
2283
2284         * Scripts/resolve-ChangeLogs:
2285         (sub findChangeLog): Return a ChangeLog contained within the specified
2286         directory if one exists.
2287
2288 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
2289
2290         <rdar://problem/5698732> Copyright strings should include 2008
2291
2292         Reviewed by Sam.
2293
2294         * Drosera/win/Drosera.vcproj/Drosera.rc:
2295         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
2296
2297 2008-01-23  Alp Toker  <alp@atoker.com>
2298
2299         Rubber-stamped by Mark Rowe.
2300
2301         Remove whitespace after -I in automake include lists.
2302
2303         * GNUmakefile.am:
2304
2305 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
2306
2307         Reviewed by Lars Knoll <lars@trolltech.com>.
2308
2309         Reworked the JavaScriptCore Qt bindings:
2310         
2311         * Update JS DRT controller for Qt JS binding changes.
2312         There were two functions that needed some changes
2313         so that the layout tests would work, so this makes
2314         a few tests pass again.
2315         
2316         * Bump the timeout for layout tests up to 11s.
2317         At least some tests have an internal timeout of
2318         10 seconds, so make the waitUntilDone approach
2319         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
2320         is one of these - now the failure message is more
2321         accurate.
2322         
2323
2324         * DumpRenderTree/qt/jsobjects.cpp:
2325         (LayoutTestController::waitUntilDone):
2326         * DumpRenderTree/qt/jsobjects.h:
2327
2328 2008-01-22  Anders Carlsson  <andersca@apple.com>
2329
2330         Reviewed by Darin and Adam.
2331
2332         <rdar://problem/5688975>
2333         div element on microsoft site has wrong left offset.
2334         
2335         Add new method for testing the return vale of NPN_GetProperty.
2336         
2337         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2338         (pluginInvoke):
2339
2340 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
2341
2342         Reviewed by Adam Roben.
2343
2344         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
2345
2346         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
2347
2348 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
2349
2350         Reviewed by Alp Toker.
2351
2352         http://bugs.webkit.org/show_bug.cgi?id=16955
2353         Get errors when cross-compile webkit-gtk
2354
2355         * GNUmakefile.am: Removed ICU_CFLAGS 
2356
2357 2008-01-21  Darin Adler  <darin@apple.com>
2358
2359         Reviewed by Mitz and Adam.
2360
2361         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
2362         sorting speed by doing all sort criteria in a single pass instead of three sorts.
2363
2364 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
2365
2366         Reviewed by Holger.
2367
2368         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
2369         
2370         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
2371         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
2372         and make the return value depend on whether we successfully determined a focusable
2373         node or not.
2374         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
2375         if we could not handle the focus chain ourselves.
2376         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
2377         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
2378         used to control the situation of stepping out of the focus chain inside the page.
2379         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
2380         The layout tests expect this to be disabled but for the user it seems sensible to have it
2381         on by default, hence the default in qwebsettings.cpp
2382         
2383
2384         * DumpRenderTree/qt/DumpRenderTree.cpp:
2385         (WebCore::WebPage::WebPage):
2386
2387 2008-01-19  Mark Rowe  <mrowe@apple.com>
2388
2389         Reviewed by Alp Toker.
2390
2391         Allow the --http flag to run-webkit-tests to override
2392         the default behaviour of disabling HTTP tests for Qt,
2393         Gtk and Wx.
2394
2395         * Scripts/run-webkit-tests:
2396
2397 2008-01-19  David Kilzer  <ddkilzer@apple.com>
2398
2399         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
2400
2401         Reviewed by Darin.
2402
2403         We now touch a check-for-global-initializers.timestamp file in
2404         the TARGET_TEMP_DIR directory to determine when new object files
2405         have been compiled and thus need to be checked.  If the timestamp
2406         file doesn't exist, all object files will be checked.
2407
2408         Previously the modification time of the "executable" (the
2409         framework binary, e.g., WebKit.framework/WebKit) was used, but
2410         since this was the last file modified at the end of the compile
2411         phase, no object files would ever get checked!
2412
2413         Also added JSCustomSQLTransactionCallback.o to the list of files
2414         since it has static initializers in Debug builds of WebCore.
2415
2416         * Scripts/check-for-global-initializers:
2417
2418 2008-01-18  Adam Roben  <aroben@apple.com>
2419
2420         Build fix
2421
2422         * Scripts/build-webkit:
2423
2424 2008-01-18  Beth Dakin  <bdakin@apple.com>
2425
2426         Reviewed by Oliver.
2427
2428         Update build-webkit to account for foreign-object being disabled by 
2429         default.
2430
2431         * Scripts/build-webkit:
2432
2433 2008-01-18  Adam Roben  <aroben@apple.com>
2434
2435         Updated for method renames
2436
2437         Reviewed by Adele.
2438
2439         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2440         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2441         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2442         (LayoutTestController::setMainFrameIsFirstResponder):
2443         (LayoutTestController::setWindowIsKey):
2444         * DumpRenderTree/mac/UIDelegate.mm:
2445         (-[UIDelegate webViewFocus:]):
2446         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2447         (FrameLoadDelegate::didCommitLoadForFrame):
2448
2449 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
2450
2451         Reviewed by Adam Roben.
2452
2453         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
2454         between DRT and TestNetscapePlugin.
2455
2456         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
2457         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
2458
2459 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
2460
2461         Reviewed by Holger.
2462
2463         Fix fast/dom/Window/window-resize.html
2464         
2465         In DRT connect the page's geometryChangeRequest signal to a slot that
2466         sets the geometry of the view widget.
2467         
2468
2469         * DumpRenderTree/qt/DumpRenderTree.cpp:
2470         (WebCore::WebPage::setViewGeometry):
2471         (WebCore::WebPage::WebPage):
2472
2473 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
2474
2475         Build fix.
2476
2477         * Drosera/DroseraWin.make:
2478
2479 2008-01-17  Darin Adler  <darin@apple.com>
2480
2481         * Scripts/run-webkit-tests: Fixed a bug number.
2482
2483 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
2484
2485         Reviewed by Adam Roben.
2486
2487         http://bugs.webkit.org/show_bug.cgi?id=16908
2488         run-webkit-tests complains about missing FindSafari.exe
2489
2490         * Scripts/webkitdirs.pm: Append _debug as appropriate.
2491
2492 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
2493
2494         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
2495         
2496         Rubber-stamped by Jon Honeycutt.
2497
2498         * DumpRenderTree/win/DumpRenderTree.vcproj:
2499
2500 2008-01-16  Alp Toker  <alp@atoker.com>
2501
2502         Reviewed by Mark Rowe.
2503
2504         http://bugs.webkit.org/show_bug.cgi?id=16218
2505         [GTK] API: Should this entry point be called go_back rather than go_backward?
2506
2507         Track back/forward API changes in the tools.
2508
2509         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2510         (BackForwardItem::invoke):
2511         * GtkLauncher/main.c:
2512         (go_back_cb):
2513
2514 2008-01-16  Adam Roben  <aroben@apple.com>
2515
2516         Windows build fix after r29488
2517
2518         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2519         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
2520         expects to find the plugin.
2521
2522 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
2523
2524         Reviewed by Sam Weinig.
2525         
2526         Fixed the waitUntilDone watchdog timer -- the old code never added the
2527         timer to the run loop, so it didn't do anything.
2528
2529         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2530         (LayoutTestController::setWaitToDump):
2531         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2532         (LayoutTestController::setWaitToDump):
2533
2534 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
2535
2536         Use shared vsprops for most vcproj properties.
2537         
2538         Reviewed by Darin.
2539
2540         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2541         * DumpRenderTree/win/DumpRenderTree.vcproj:
2542         * DumpRenderTree/win/ImageDiff.vcproj:
2543         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2544         * FindSafari/FindSafari.vcproj:
2545
2546 2008-01-14  Stephanie  <slewis@apple.com>
2547
2548        Reviewed by NOBODY.
2549   
2550        revert accidental character.
2551
2552        * Scripts/run-webkit-tests:
2553
2554 2008-01-14  Stephanie  <slewis@apple.com>
2555
2556         RS=Oliver
2557
2558         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
2559
2560         * Scripts/run-webkit-tests:
2561
2562 2008-01-14  Darin Adler  <darin@apple.com>
2563
2564         * Scripts/do-webcore-rename: Queue up another rename.
2565
2566 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
2567
2568         Reviewed by Darin.
2569
2570         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
2571         the tests were ran.
2572         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
2573
2574         * Scripts/run-webkit-tests:
2575
2576 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
2577
2578         Reviewed by Darin.
2579
2580         * Randomize tests array to spot test cases where the results depends on the order
2581         the tests are ran.
2582         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
2583
2584         * Scripts/run-webkit-tests:
2585
2586 2008-01-14  Darin Adler  <darin@apple.com>
2587
2588         * Scripts/run-webkit-tests: More ignore list tweaking.
2589
2590 2008-01-14  Darin Adler  <darin@apple.com>
2591
2592         * Scripts/run-webkit-tests: Add another leak to the ignore list.
2593
2594 2008-01-14  Dan Bernstein  <mitz@apple.com>
2595
2596         Reviewed by Adam Roben.
2597
2598         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
2599           build bots
2600
2601         * DumpRenderTree/win/DumpRenderTree.cpp:
2602         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
2603
2604 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
2605
2606         Share common files across projects.
2607         
2608         Unify vsprops files
2609         Debug:          common.vsprops, debug.vsprops
2610         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
2611         Release:        common.vsprops, release.vsprops
2612         
2613         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
2614         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
2615
2616         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
2617
2618         Reviewed by Adam Roben.
2619
2620         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2621         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
2622         * Drosera/win/Drosera.vcproj/VERSION: Removed.
2623         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
2624         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
2625         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
2626         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
2627         * DumpRenderTree/win/DumpRenderTree.vcproj:
2628         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2629         * DumpRenderTree/win/debug.vsprops: Removed.
2630         * DumpRenderTree/win/debug_internal.vsprops: Removed.
2631         * DumpRenderTree/win/release.vsprops: Removed.
2632
2633 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
2634
2635         Reviewed by Maciej.
2636
2637         - http://bugs.webkit.org/show_bug.cgi?id=16314
2638           Script to launch Drosera
2639
2640         * Scripts/gdb-drosera: Added.
2641         * Scripts/run-drosera: Added.
2642         * Scripts/run-drosera-nightly.cmd: Added.
2643         * Scripts/webkitdirs.pm: Added runDrosera function.
2644
2645 2008-01-13  Dan Bernstein  <mitz@apple.com>
2646
2647         - fix breakage due to last-minute change
2648
2649         * DumpRenderTree/win/DumpRenderTree.cpp:
2650         (runTest): Declare the loop variable.
2651
2652 2008-01-13  Dan Bernstein  <mitz@apple.com>
2653
2654         Reviewed by Adam Roben.
2655
2656         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
2657
2658         * DumpRenderTree/win/DumpRenderTree.cpp:
2659         (DumpRenderTreeWndProc):
2660         (initialize):
2661         (dumpBackForwardList):
2662         (dumpBackForwardListForAllWindows):
2663         (dump):
2664         (resetWebViewToConsistentStateBeforeTesting): Factored out of
2665         runTest().
2666         (runTest):
2667         (allWindows): Added. Returns a vector of all open windows.
2668         (windowToWebViewMap): Added. Returns a map from open windows to their
2669         WebViews.
2670         (createWebViewAndOffscreenWindow): Factored out of main() to be
2671         reusable for creating extra windows.
2672         (main):
2673         * DumpRenderTree/win/DumpRenderTreeWin.h:
2674         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2675         (LayoutTestController::windowCount): Implemented.
2676         * DumpRenderTree/win/UIDelegate.cpp:
2677         (UIDelegate::createWebViewWithRequest): Implemented.
2678         (UIDelegate::webViewClose): Implemented.
2679         * DumpRenderTree/win/UIDelegate.h:
2680
2681 2008-01-12  Alp Toker  <alp@atoker.com>
2682
2683         Reviewed by Mark Rowe.
2684
2685         Hide non-public symbols in GTK+/autotools release builds.
2686
2687         * GNUmakefile.am:
2688
2689 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
2690
2691         Reviewed by Ap.
2692
2693         * Make launching of the WebKit httpd work on GNU/Debian/Linux
2694         
2695         The configuration of Apache2 and installation does not depend on
2696         the kernel but on the distribution policy. Make launching of httpd
2697         work for Debian derived distributions.
2698
2699         * Scripts/run-webkit-httpd:
2700         * Scripts/run-webkit-tests:
2701         * Scripts/webkitdirs.pm:
2702
2703 2008-01-12  Mark Rowe  <mrowe@apple.com>
2704
2705         Reviewed by Maciej Stachowiak.
2706
2707         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
2708
2709         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
2710         match the callers expectations that it can take ownership of the string.
2711
2712 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
2713
2714         Reviewed by Adam Roben.
2715
2716         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
2717
2718         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
2719         as these are only posted because the test window is not a normal visible one, and
2720         they confuse drag&drop machinery.
2721
2722 2008-01-11  Adam Roben  <aroben@apple.com>
2723
2724         Fix a crash when pathToLocalResource fails and a leak
2725
2726         Reviewed by Darin.
2727
2728         * DumpRenderTree/LayoutTestController.cpp:
2729         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
2730         sure not to pass null to JSValueMakeString.
2731         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2732         (LayoutTestController::pathToLocalResource): Print an error message if
2733         the conversion fails so it's clear what happened.
2734
2735 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
2736
2737         Reviewed by John Sullivan.
2738
2739         * DumpRenderTree/mac/GCControllerMac.mm:
2740         (GCController::collectOnAlternateThread): Updated for name change.
2741
2742 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
2743
2744         wx build fix. Don't build dftables any longer since it's now a Perl
2745         script.
2746
2747         * wx/build-wxwebkit:
2748
2749 2008-01-10  Sam Weinig  <sam@webkit.org>
2750
2751         Reviewed by Anders Carlsson.
2752
2753         Make DRT track open windows instead of allocated windows so that
2754         we can avoid ASSERTION due to late deallocs out of our control.
2755
2756         * DumpRenderTree/mac/DumpRenderTree.mm:
2757         (dumpBackForwardListForAllWindows):
2758         (runTest):
2759         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2760         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2761         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2762         (+[DumpRenderTreeWindow openWindows]):
2763         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2764         (-[DumpRenderTreeWindow close]):
2765         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2766         (LayoutTestController::windowCount):
2767
2768 2008-01-10  Ada Chan  <adachan@apple.com>
2769
2770         Meta key is not the same as Alt key on windows.
2771
2772         Reviewed by Darin.
2773
2774         * DumpRenderTree/win/EventSender.cpp:
2775         (keyDownCallback):
2776
2777 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
2778
2779         Reviewed by Darin, Sam and Adam.
2780
2781         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
2782         link in gmail message displays JavaScript alert falsely complaining
2783         about pop-up blocking.
2784         - Added the ability to enable the pop-up blocker via the
2785         LayoutTestController.
2786
2787         * DumpRenderTree/LayoutTestController.cpp:
2788         (setPopupBlockingEnabledCallback):
2789         (LayoutTestController::staticFunctions):
2790         * DumpRenderTree/LayoutTestController.h:
2791         * DumpRenderTree/mac/DumpRenderTree.mm:
2792         (setDefaultsToConsistentValuesForTesting):
2793         (resetWebViewToConsistentStateBeforeTesting):
2794         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2795         (LayoutTestController::setPopupBlockingEnabled):
2796
2797 2008-01-10  Lars Knoll  <lars@trolltech.com>
2798
2799         Reviewed by Simon.
2800
2801         rename QWebPageHistory to QWebHistory.
2802         
2803
2804         * DumpRenderTree/qt/jsobjects.cpp:
2805
2806 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
2807
2808         Reviewed by Darin.
2809         
2810         - add some more renames, adjust some
2811
2812         * Scripts/do-webcore-rename:
2813
2814 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
2815
2816         Reviewed by Oliver.
2817
2818         Enable SVG Fonts support by default.
2819
2820         * Scripts/build-webkit:
2821
2822 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
2823
2824         Reviewed by Adam.
2825
2826         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
2827         DRT doesn't handle platform specific pixel test results correctly.
2828
2829         <test>-expected.txt files and <test>-expected.png files may now live
2830         in different directories (ie. a cross-platform <test>-expected.txt file
2831         and a platform-specific <test>-expected.png file).
2832
2833         * Scripts/run-webkit-tests:
2834
2835 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
2836
2837         Reviewed by Darin.
2838
2839         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
2840         DRT did not correctly handle printing the '\0' char.  Now it does.
2841
2842         * DumpRenderTree/win/DumpRenderTree.cpp:
2843         (dumpFramesAsText):
2844         (dump):
2845
2846 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
2847
2848         Reviewed by Lars.
2849
2850         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
2851         
2852
2853         * DumpRenderTree/qt/main.cpp:
2854         * DumpRenderTree/qt/testplugin.cpp:
2855         * DumpRenderTree/qt/testplugin.h:
2856
2857 2008-01-05  Mark Rowe  <mrowe@apple.com>
2858
2859         Reviewed by Alp Toker.
2860
2861         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
2862
2863         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2864         (processWork): Process pending work.
2865         (webViewLoadFinished): Schedule processing of pending work.
2866         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
2867
2868 2008-01-05  Darin Adler  <darin@apple.com>
2869
2870         * Scripts/do-webcore-rename: Some more renaming plans.
2871
2872 2008-01-04  Alice Liu  <alice.liu@apple.com>
2873
2874         Reviewed by Alexey and Darin.
2875
2876         Adding "home" and "end" to DRT's keydown since
2877         DOM key events can't handle keyIdentifiers at this point. 
2878
2879         * DumpRenderTree/mac/EventSendingController.mm:
2880         (-[EventSendingController keyDown:withModifiers:]):
2881         * DumpRenderTree/win/EventSender.cpp:
2882         (keyDownCallback):
2883
2884 2008-01-04  Lars Knoll  <lars@trolltech.com>
2885
2886         Reviewed by Simon.
2887
2888         fix DRT after the changes to QWebPage.
2889         
2890         The great thing is that we actually don't have
2891         any regressions from the QWebPage change :)
2892         
2893
2894         * DumpRenderTree/qt/DumpRenderTree.cpp:
2895         (WebCore::DumpRenderTree::DumpRenderTree):
2896
2897 2008-01-04  Lars Knoll  <lars@trolltech.com>
2898
2899         Reviewed by Simon.
2900
2901         make QWebPage a QObject and get things to compile.
2902         
2903         Nothing works currently though.
2904         
2905
2906         * DumpRenderTree/qt/DumpRenderTree.cpp:
2907         (WebCore::DumpRenderTree::DumpRenderTree):
2908
2909 2008-01-04  Lars Knoll  <lars@trolltech.com>
2910
2911         Reviewed by Simon.
2912
2913         take a QString as identifier in QWebFrame::addToJSWindowObject.
2914
2915         * DumpRenderTree/qt/DumpRenderTree.cpp:
2916         (WebCore::DumpRenderTree::initJSObjects):
2917
2918 2008-01-04  Alp Toker  <alp@atoker.com>
2919
2920         GTK+ DRT build fix for breakage introduced in r29149.
2921
2922         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2923         (LayoutTestController::execCommand):
2924
2925 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
2926
2927         Reviewed by Darin.
2928
2929         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
2930
2931         Added layoutTestController.execCommand to access editor commands that are not available
2932         via document.execCommand.
2933
2934         * DumpRenderTree/LayoutTestController.cpp:
2935         (execCommandCallback):
2936         (LayoutTestController::staticFunctions):
2937         * DumpRenderTree/LayoutTestController.h:
2938         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2939         (LayoutTestController::execCommand):
2940         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2941         (LayoutTestController::queueLoad):
2942         (LayoutTestController::execCommand):
2943
2944 2008-01-03  Alice Liu  <alice.liu@apple.com>
2945
2946         Reviewed by Darin, Mitz.
2947
2948         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
2949
2950         the clickcount should not increase if the last click was at a different location.  it's a new click.
2951
2952         * DumpRenderTree/mac/DumpRenderTree.mm:
2953         (runTest):
2954         * DumpRenderTree/mac/EventSendingController.h:
2955         * DumpRenderTree/mac/EventSendingController.mm:
2956         (-[EventSendingController mouseDown]):
2957         (-[EventSendingController mouseUp]):
2958
2959 2008-01-03  Darin Adler  <darin@apple.com>
2960
2961         Reviewed by Adam.
2962
2963         * Scripts/update-webkit: Make this work a little better for the people at Apple
2964         who have a directory named Internal.
2965
2966 2008-01-03  Adam Roben  <aroben@apple.com>
2967
2968         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
2969
2970         Rubberstamped by Mark.
2971
2972         * Scripts/update-webkit-auxiliary-libs:
2973
2974 2008-01-03  Adam Roben  <aroben@apple.com>
2975
2976         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
2977
2978         http://bugs.webkit.org/show_bug.cgi?id=15663
2979
2980         Added a fuzz factor into the Last-Modified comparison for downloading
2981         WebKitAuxiliaryLibrary.zip.
2982
2983         The zip file is served from a set of mirrors who give Last-Modified
2984         times that are off by 1-3 seconds from each other. This was causing
2985         the build bots to redownload WebKitAuxiliaryLibrary for every build,
2986         which would then cause all of WebCore to rebuild each time.
2987
2988         Reviewed by Mark.
2989
2990         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
2991         at least 30 seconds newer than the old one -- otherwise we assume that
2992         the difference in time is due to the mirrors being slightly offset
2993         from each other.
2994         (sub lastModifiedToUnixTime): Added.
2995
2996 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
2997
2998         Windows build fix.
2999
3000         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
3001
3002 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
3003
3004         Reviewed by Lars.
3005
3006         Moved QWebPage::open to QWebFrame::load and added setHtml.
3007         
3008
3009         * DumpRenderTree/qt/DumpRenderTree.cpp:
3010         (WebCore::DumpRenderTree::open):
3011
3012 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
3013
3014         Reviewed by Lars.
3015
3016         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
3017         
3018
3019         * DumpRenderTree/qt/DumpRenderTree.cpp:
3020         (WebCore::DumpRenderTree::DumpRenderTree):
3021
3022 2008-01-02  Sam Weinig  <sam@webkit.org>
3023
3024         * Scripts/do-webcore-rename: Yet more renaming ideas.
3025
3026 2008-01-02  Darin Adler  <darin@apple.com>
3027
3028         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
3029
3030 2008-01-02  Alice Liu  <alice.liu@apple.com>
3031
3032         Reviewed by Sam Weinig.
3033
3034         fixing assertion hit with editing/selection/move-begin-end.html
3035
3036         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
3037         * DumpRenderTree/win/DumpRenderTree.vcproj:
3038         * DumpRenderTree/win/EventSender.cpp:
3039         (keyDownCallback):
3040         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
3041
3042 2008-01-02  Darin Adler  <darin@apple.com>
3043
3044         * Scripts/do-webcore-rename: Some more name change plans.
3045
3046 2008-01-02  Alice Liu  <alice.liu@apple.com>
3047
3048         Reviewed by Maciej.
3049
3050         Added handling for page up and page down in EventSender
3051
3052         * DumpRenderTree/mac/EventSendingController.mm:
3053         (-[EventSendingController keyDown:withModifiers:]):
3054         * DumpRenderTree/win/EventSender.cpp:
3055         (keyDownCallback):
3056
3057 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
3058
3059         Reviewed by Darin.
3060
3061         Fix fast/events/arrow-keys-on-body.html for real.
3062
3063         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
3064
3065 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
3066
3067         Reviewed by Darin.
3068
3069         http://bugs.webkit.org/show_bug.cgi?id=16674
3070         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
3071
3072         * Scripts/run-launcher:
3073
3074 2007-12-31  Darin Adler  <darin@apple.com>
3075
3076         Suggested by Antti.
3077
3078         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
3079         we get it installed on the build bots.
3080
3081 2007-12-30  Eric Seidel  <eric@webkit.org>
3082
3083         Reviewed by Sam.
3084
3085         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
3086
3087 2007-12-29  Darin Adler  <darin@apple.com>
3088
3089         Reviewed by Oliver.
3090
3091         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
3092           leak bot shows createCStringFromNPVariant result leaking
3093
3094         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3095         (pluginInvoke): Added a missing free.
3096
3097 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
3098
3099         Reviewed by Alp Toker.
3100
3101         http://bugs.webkit.org/show_bug.cgi?id=16390
3102         Use autotools or GNU make as the build system for the GTK port
3103
3104         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
3105         * GNUmakefile.am: Added.
3106
3107 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
3108
3109         Reviewed by Oliver.
3110
3111         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
3112
3113         * DumpRenderTree/win/EventSender.cpp:
3114         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
3115         of 1, even though WebKit currently ignores it.
3116
3117 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
3118
3119         wx buildbot fix. Update libpng dl script to the latest version.
3120
3121         * wx/install-unix-extras:
3122
3123 2007-12-22  Antti Koivisto  <antti@apple.com>
3124
3125         Fix a typo.
3126
3127         * Scripts/webkitdirs.pm:
3128
3129 2007-12-21  Sam Weinig  <sam@webkit.org>
3130
3131         Reviewed by Mark Rowe.
3132
3133         - Disable the back/forward cache using the new WebPreferences API
3134           instead of through the BackForwardList.  This makes us match what
3135           we do on Windows.
3136
3137         * DumpRenderTree/mac/DumpRenderTree.mm:
3138         (createWebViewAndOffscreenWindow):
3139         (setDefaultsToConsistentValuesForTesting):
3140
3141 2007-12-21  Dan Bernstein  <mitz@apple.com>
3142
3143         Reviewed by Mark Rowe.
3144
3145         - disable the back/forward cache in Windows DumpRenderTree. It is
3146           already disabled in Mac DumpRenderTree.
3147
3148         * DumpRenderTree/win/DumpRenderTree.cpp:
3149         (initializePreferences):
3150
3151 2007-12-13  Antti Koivisto  <antti@apple.com>
3152
3153         Reviewed by Darin and Steve.
3154         
3155         - check for QuickTime SDK on Windows.
3156         - build media support on Windows by default
3157
3158         * Scripts/build-webkit:
3159         * Scripts/webkitdirs.pm:
3160
3161 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
3162
3163         Build script fix for buildbot.
3164
3165         * wx/build-wxwebkit:
3166
3167 2007-12-20  Eric Seidel  <eric@webkit.org>
3168
3169         Reviewed by mjs.
3170
3171         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
3172
3173 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
3174
3175         Reviewed by Steve.
3176
3177         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
3178         WebKit.
3179
3180         - Drosera and Safari need to use the same ProgIDs in order for
3181         CoCreateInstance to work properly.  The most robust way to do this is
3182         for WebKit to dynamically publish those ProgIDs.
3183
3184         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
3185         (DebuggerClient::createWebViewWithRequest):
3186         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
3187         statics.
3188         (Drosera::initUI):
3189         (Drosera::attach):
3190         (Drosera::attemptToCreateServerConnection):
3191         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
3192         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
3193         make use of the published ProgIDs.
3194         (ServerConnection::attemptToCreateServerConnection):
3195
3196 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
3197
3198         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
3199         - Build bot and leak fix.
3200
3201         * DumpRenderTree/LayoutTestController.cpp:
3202         (pathToLocalResourceCallback):
3203
3204 2007-12-19  David Kilzer  <ddkilzer@apple.com>
3205
3206         Make svn-apply/svn-unapply work with patches from git-format-patch.
3207
3208         Reviewed by Darin.
3209
3210         * Scripts/svn-apply:
3211         (patch): If 'Index:' can't be found in the text passed in, print it
3212         out with a warning and return early.
3213         * Scripts/svn-unapply:
3214         (patch): Ditto.
3215
3216 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
3217
3218         Reviewed by Alp Toker.
3219
3220         Build related fixes.
3221
3222         * wx/build-wxwebkit:
3223         - Check to make sure the user is running a supported wx port
3224         - More robust checks for Cygwin
3225         - Only run install-unix-extras on Mac, it's not the right solution
3226           for Linux distros.
3227         - Remove outdated Linux instructions after successful build
3228         - Clean Bakefile-generated files during a clean operation
3229
3230 2007-12-18  Darin Adler  <darin@apple.com>
3231
3232         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
3233
3234 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
3235
3236         Add script to run Drosera as part of the nightly.
3237         
3238         Reviewed by Kevin M.
3239
3240         * Scripts/run-drosera.cmd: Added.
3241
3242 2007-12-18  Darin Adler  <darin@apple.com>
3243
3244         * Scripts/do-webcore-rename: Remove a stray K.
3245
3246 2007-12-18  Darin Adler  <darin@apple.com>
3247
3248         * Scripts/do-webcore-rename: Plan more renaming.
3249
3250 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
3251
3252         Reviewed by Alp Toker.
3253
3254         http://bugs.webkit.org/show_bug.cgi?id=16042
3255         [GTK] Eliminate webkit_init()
3256
3257         Moving webkit initialization to WebView class init.
3258
3259         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3260         (main):
3261         * GtkLauncher/main.c:
3262         (main):
3263
3264 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
3265
3266         Reviewed by Alp Toker.
3267
3268         http://bugs.webkit.org/show_bug.cgi?id=13542
3269         gdklauncher doesnt change URL in adress GTKEntry.
3270
3271         * GtkLauncher/main.c:
3272         (load_commit_cb): added
3273         (title_change_cb):
3274         (create_browser):
3275
3276 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
3277
3278         Reviewed by Adam Roben.
3279
3280         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
3281
3282         * FindSafari/FindSafari.cpp:
3283         (_tmain):
3284
3285 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
3286
3287         Reviewed by Adam Roben.
3288
3289         http://bugs.webkit.org/show_bug.cgi?id=16315
3290         FindSafari needs a path-only option.
3291
3292         * FindSafari/FindSafari.cpp:
3293         (_tmain):
3294
3295 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
3296
3297         Reviewed by Darin.
3298
3299         http://bugs.webkit.org/show_bug.cgi?id=16462
3300         REGRESSION: access keys broken on Windows
3301
3302         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
3303         if Alt is pressed.
3304
3305 2007-12-15  Sam Weinig  <sam@webkit.org>
3306
3307         Reviewed by Mark Rowe.
3308
3309         Fix urlSuitableForTestResult to correctly identify wstring::npos as
3310         the case when wstring.find doesn't find anything.
3311
3312         * DumpRenderTree/win/DumpRenderTree.cpp:
3313         (urlSuitableForTestResult):
3314
3315 2007-12-15  Alp Toker  <alp@atoker.com>
3316
3317         GTK+ DRT build fix for GLib < 2.14.
3318
3319         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3320         (LayoutTestController::setWaitToDump):
3321
3322 2007-12-05  Mark Rowe  <mrowe@apple.com>
3323
3324         Reviewed by Alp Toker.
3325
3326         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
3327         many layout tests from hanging while waiting on user responses to dialogs.
3328
3329         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3330         (invalidateAnyPreviousWaitToDumpWatchdog):
3331         (webViewScriptAlert):
3332         (webViewScriptPrompt):
3333         (webViewScriptConfirm):
3334         (main):
3335         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3336         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3337         (waitToDumpWatchdogFired):
3338         (LayoutTestController::setWaitToDump):
3339
3340 2007-12-05  Mark Rowe  <mrowe@apple.com>
3341
3342         Reviewed by Alp Toker.
3343
3344         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
3345
3346         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3347         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
3348         (dump):
3349         (runTest):
3350         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
3351         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
3352         work queue is empty.
3353         (webViewWindowObjectCleared): Set up window.layoutTestController.
3354         (webViewConsoleMessage): Match the console message format expected by the layout test results.
3355         (main): Hook up the new signals.
3356         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3357         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
3358         dumping multiple times.
3359         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
3360         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
3361
3362 2007-12-14  Anders Carlsson  <andersca@apple.com>
3363
3364         Reviewed by Brady.
3365
3366         Assert that a web frame that's loading a resource always has either a data source or 
3367         a provisional data source.
3368         
3369         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3370         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3371
3372 2007-12-14  Darin Adler  <darin@apple.com>
3373
3374         - fix mistake causing nearly all tests to fail on Windows
3375
3376         * DumpRenderTree/win/UIDelegate.cpp:
3377         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
3378         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
3379
3380         * DumpRenderTree/mac/UIDelegate.mm:
3381         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
3382         than passing the entire message.
3383
3384 2007-12-14  Darin Adler  <darin@apple.com>
3385
3386         - fix Tiger build
3387
3388         * DumpRenderTree/mac/UIDelegate.mm:
3389         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
3390         new-to-Leopard methods.
3391
3392 2007-12-14  Darin Adler  <darin@apple.com>
3393
3394         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
3395         since it now triggers unwanted icon loading. We only had it because we implemented "all"
3396         delegate methods here.
3397
3398 2007-12-14  Anders Carlsson  <andersca@apple.com>
3399
3400         Reviewed by Darin and Geoff.
3401
3402         <rdar://problem/5619295> 
3403         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
3404         
3405         Add property getting methods to the plug-in.
3406         
3407         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3408         (pluginInvoke):
3409
3410 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
3411
3412         Reviewed by Darin.
3413
3414         - Layout test fix for mac. When dumped to the console local file paths
3415         now only show the name of the resource not the whole path.  This is to
3416         make the results machine and OS independent.
3417
3418         * DumpRenderTree/mac/UIDelegate.mm:
3419         (-[UIDelegate webView:addMessageToConsole:]):
3420
3421 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
3422
3423         Reviewed by Adam.
3424
3425         - Layout tests fix.  We need a way to remove machine-dependent
3426         information from paths in layout test results. The UIDelegate now does
3427         this.
3428
3429         * DumpRenderTree/DumpRenderTree.h:
3430         * DumpRenderTree/win/DumpRenderTree.cpp:
3431         (urlSuitableForTestResult):
3432         * DumpRenderTree/win/DumpRenderTreeWin.h:
3433         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3434         * DumpRenderTree/win/UIDelegate.cpp:
3435         (UIDelegate::webViewAddMessageToConsole):
3436
3437 2007-12-13  Alp Toker  <alp@atoker.com>
3438
3439         Build fix for DRT breakage introduced in r28690.
3440
3441         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3442         (LayoutTestController::pathToLocalResource):
3443
3444 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
3445
3446         Reviewed by Alice and Sam.
3447
3448         - <rdar://5621435> Need a way to specify local resources (being loaded
3449         from HTTP tests) on Windows.
3450         - Implemented pathToLocalResource which exposes the functionality of
3451         converting a given unix path to the correct location on Windows.
3452
3453         * DumpRenderTree/LayoutTestController.cpp:
3454         (pathToLocalResourceCallback):
3455         (LayoutTestController::staticFunctions):
3456         * DumpRenderTree/LayoutTestController.h:
3457         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3458         (LayoutTestController::pathToLocalResource):
3459         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3460         (LayoutTestController::pathToLocalResource):
3461
3462 2007-12-12  Anders Carlsson  <andersca@apple.com>
3463
3464         Reviewed by Sam.
3465
3466         <rdar://problem/5132003>
3467         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
3468
3469         * DumpRenderTree/win/DumpRenderTree.cpp:
3470         (main):
3471         Set the resource load delegate.
3472         
3473         * DumpRenderTree/win/DumpRenderTree.vcproj:
3474         
3475         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
3476         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
3477
3478 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
3479
3480         Reviewed by Adam Roben.
3481
3482         Fix conversion from double to LPARAM in dispatchMessage().
3483
3484         * DumpRenderTree/win/EventSender.cpp:
3485         (dispatchMessageCallback):
3486
3487 2007-12-11  Dan Bernstein  <mitz@apple.com>
3488
3489         Reviewed by Mark Rowe and Sam Weinig too!
3490
3491         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
3492           fonts DumpRenderTree registers.
3493
3494         * DumpRenderTree/win/DumpRenderTree.cpp:
3495         (initialize):
3496
3497 2007-12-11  Brady Eidson  <beidson@apple.com>
3498
3499         Reviewed by Anders
3500
3501         Make DumpRenderTree on mac use its own path for Databases testing
3502
3503         * DumpRenderTree/mac/DumpRenderTree.mm:
3504         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
3505           for future DRT-only use, then use it to construct the Databases path and set that default
3506
3507 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
3508
3509         Reviewed by Darin.
3510
3511         <rdar://problem/5535636>
3512         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
3513
3514         http://bugs.webkit.org/show_bug.cgi?id=13916
3515         JavaScript detects Tab as a character input on a textfield validation
3516
3517         * DumpRenderTree/mac/EventSendingController.mm:
3518         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
3519         Dispatch a keyup to better match what happens when a key is physically pressed.
3520
3521         * DumpRenderTree/win/EventSender.cpp:
3522         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
3523         returning from keyDown().
3524         (getConstantCallback): Fixed a couple copy/paste mistakes.
3525
3526 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
3527
3528         Reviewed by Oliver.
3529
3530         - <rdar://5599845> Drosera: Does not show loal files in the file list
3531         on the left side.
3532
3533         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
3534         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
3535         so the open source community can build.
3536
3537 2007-12-10  Brady Eidson  <beidson@apple.com>
3538
3539         Rubberstamped by Sam Weinig
3540
3541         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
3542
3543         * DumpRenderTree/mac/UIDelegate.mm:
3544         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
3545         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
3546
3547 2007-12-08  Oliver Hunt  <oliver@apple.com>
3548
3549         Reviewed by Sam W.
3550
3551         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
3552         
3553         Fixes <rdar://problem/5620249> Must disable SVG animation
3554         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
3555         
3556         In order to allow finer grained control over the set of SVG features
3557         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
3558         distinct flags:
3559         ENABLE_SVG_ANIMATION
3560         ENABLE_SVG_FILTERS
3561         ENABLE_SVG_FONTS
3562         ENABLE_SVG_AS_IMAGE
3563         ENABLE_SVG_USE
3564         
3565         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
3566         
3567         Script handles all the new build flags, and allows --svg-experimental
3568         to automatically enable all features.
3569
3570         * Scripts/build-webkit:
3571
3572 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
3573
3574         Fix version parsing.
3575
3576         Rubber-stamped by Oliver.
3577
3578         * Drosera/win/Drosera.vcproj/auto-version.sh:
3579
3580 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
3581
3582         Build modifications for Drosera.
3583
3584         Reviewed by Adam.
3585
3586         * Drosera/DroseraWin.make: Added.
3587         * Drosera/win/Drosera.vcproj/Drosera.rc:
3588         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3589         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
3590         * Drosera/win/Drosera.vcproj/VERSION: Added.
3591         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
3592
3593 2007-12-06  Adam Roben  <aroben@apple.com>
3594
3595         Explicitly turn on the Mac font ascent hack on Windows
3596
3597         This keeps our font metrics matching those from Mac.
3598
3599         Reviewed by Hyatt.
3600
3601         * DumpRenderTree/win/DumpRenderTree.cpp:
3602         (main):
3603
3604 2007-12-06  Anders Carlsson  <andersca@apple.com>
3605
3606         Rename main.c to main.cpp here too.
3607         
3608         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
3609
3610 2007-12-06  Sam Weinig  <sam@webkit.org>
3611
3612         Rubber stamped by Geoff.
3613
3614         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
3615
3616 2007-12-06  Darin Adler  <darin@apple.com>
3617
3618         * Scripts/do-webcore-rename: Some more renaming plans.
3619
3620 2007-12-06  Anders Carlsson  <andersca@apple.com>
3621
3622         Restore implementation of testGetIntIdentifier that was accidentally
3623         removed somehow (possibly when I made PluginObject be a cpp file).
3624         
3625         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3626         (pluginInvoke):
3627
3628 2007-12-05  Anders Carlsson  <andersca@apple.com>
3629
3630         Make the entry points extern "C".
3631         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3632         
3633 2007-12-05  Anders Carlsson  <andersca@apple.com>
3634
3635         C++ warning fixes.
3636         
3637         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3638         (NPP_New):
3639         (NPP_Destroy):
3640         (NPP_SetWindow):
3641         (NPP_NewStream):
3642         (NPP_HandleEvent):
3643         (NPP_URLNotify):
3644         (NPP_GetValue):
3645
3646 2007-12-05  Anders Carlsson  <andersca@apple.com>
3647
3648         Add the .cpp files to the TestNetscapePlugIn target.
3649
3650         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3651
3652 2007-12-05  Anders Carlsson  <andersca@apple.com>
3653
3654         Reviewed by Geoff.
3655         
3656         Rename the TestNetscapePlugIn .c files to be .cpp.
3657
3658         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3659         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
3660         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
3661         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
3662         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
3663         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
3664         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
3665         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3666
3667 2007-12-05  Adam Roben  <aroben@apple.com>
3668
3669         Fix case of keypresses from the Windows implementation of eventSender.keyDown
3670
3671         This fixes several regression tests.
3672
3673         Reviewed by Alice.
3674
3675         * DumpRenderTree/win/EventSender.cpp:
3676         (keyDownCallback): Virtual keycodes for ASCII characters are always
3677         uppercase, so we need to check the case of the original character
3678         passed in to eventSender.keyDown.
3679
3680 2007-12-05  Adam Roben  <aroben@apple.com>
3681
3682         Learn from Tim's mistakes
3683