2010-07-13 Andreas Kling <andreas.kling@nokia.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-07-13  Andreas Kling  <andreas.kling@nokia.com>
2
3         Unreviewed. Adding myself as committer.
4
5         * Scripts/webkitpy/common/config/committers.py:
6
7 2010-07-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
8
9         Reviewed by Darin Adler.
10
11         Prevent assertion/duplicate loads for non-deferred subtitute-data loads
12
13         https://bugs.webkit.org/show_bug.cgi?id=30879
14
15         MainResourceLoader uses the member m_initialRequest to store requests for future
16         deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
17         have to clear this request so that subsequent entries into the loader will not
18         start yet another load.
19
20         This can happen as a result of a PageGroupLoadDeferrer going out of scope when
21         returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
22         but only in the case of using both substitute-data and non-deferred main resource
23         load together. That's why two new DRT functions were added:
24
25          * queueLoadHTMLString()
26          * setDeferMainResourceLoad()
27
28         The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
29         and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
30         added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
31
32         * DumpRenderTree/LayoutTestController.cpp:
33         (LayoutTestController::LayoutTestController):
34         (queueLoadHTMLStringCallback):
35         (setDeferMainResourceDataLoadCallback):
36         (LayoutTestController::staticFunctions):
37         (LayoutTestController::queueLoadHTMLString):
38         * DumpRenderTree/LayoutTestController.h:
39         (LayoutTestController::deferMainResourceDataLoad):
40         (LayoutTestController::setDeferMainResourceDataLoad):
41         * DumpRenderTree/WorkQueueItem.h:
42         (LoadHTMLStringItem::LoadHTMLStringItem):
43         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
44         (LoadHTMLStringItem::invoke):
45         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
46         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
47         * DumpRenderTree/mac/WorkQueueItemMac.mm:
48         (LoadHTMLStringItem::invoke):
49         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
50         (LayoutTestController::reset):
51         (LayoutTestController::setDeferMainResourceDataLoad):
52         (LayoutTestController::queueLoadHTMLString):
53         * DumpRenderTree/qt/LayoutTestControllerQt.h:
54         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
55         (LoadHTMLStringItem::invoke):
56         * DumpRenderTree/qt/WorkQueueItemQt.h:
57         (LoadHTMLStringItem::LoadHTMLStringItem):
58         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
59         (ResourceLoadDelegate::willSendRequest):
60         * DumpRenderTree/win/WorkQueueItemWin.cpp:
61         (LoadHTMLStringItem::invoke):
62         * DumpRenderTree/wx/WorkQueueItemWx.cpp:
63         (LoadHTMLStringItem::invoke):
64
65 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
66
67         Reviewed by Nikolas Zimmermann.
68
69         Activate test fonts for layout tests in WebKitTestRunner (on Mac)
70         https://bugs.webkit.org/show_bug.cgi?id=42153
71
72         * WebKitTestRunner/InjectedBundle/ActivateFonts.h: Added.
73         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
74         (WTR::InjectedBundle::initialize): Activate fonts on startup.
75         * WebKitTestRunner/InjectedBundle/mac: Added.
76         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: Added.
77         (WTR::activateFonts): Activate our fonts.
78         * WebKitTestRunner/InjectedBundle/win: Added.
79         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Added.
80         (WTR::activateFonts): Dummy version.
81         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Copy fonts to bundle;
82         add more files.
83         * WebKitTestRunner/fonts: Added.
84         * WebKitTestRunner/fonts/AHEM____.TTF: Added.
85         * WebKitTestRunner/fonts/ColorBits-A.png: Added.
86         * WebKitTestRunner/fonts/ColorBits.ttf: Added.
87         * WebKitTestRunner/fonts/WebKit Layout Tests 2.ttf: Added.
88         * WebKitTestRunner/fonts/WebKit Layout Tests.ttf: Added.
89         * WebKitTestRunner/fonts/WebKitWeightWatcher100.ttf: Added.
90         * WebKitTestRunner/fonts/WebKitWeightWatcher200.ttf: Added.
91         * WebKitTestRunner/fonts/WebKitWeightWatcher300.ttf: Added.
92         * WebKitTestRunner/fonts/WebKitWeightWatcher400.ttf: Added.
93         * WebKitTestRunner/fonts/WebKitWeightWatcher500.ttf: Added.
94         * WebKitTestRunner/fonts/WebKitWeightWatcher600.ttf: Added.
95         * WebKitTestRunner/fonts/WebKitWeightWatcher700.ttf: Added.
96         * WebKitTestRunner/fonts/WebKitWeightWatcher800.ttf: Added.
97         * WebKitTestRunner/fonts/WebKitWeightWatcher900.ttf: Added.
98
99 2010-07-13  Dumitru Daniliuc  <dumi@chromium.org>
100
101         Reviewed by Eric Seidel.
102
103         Remove check-header-includes, as it didn't turn out to be very useful.
104         https://bugs.webkit.org/show_bug.cgi?id=41970
105
106         * Scripts/check-header-includes: Removed.
107
108 2010-07-12  Steve Falkenburg  <sfalken@apple.com>
109
110         Reviewed by Maciej Stachowiak.
111
112         Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
113         https://bugs.webkit.org/show_bug.cgi?id=40922
114         
115         Always build WebKit2 on Windows. Necessary since our WebKit build on
116         Windows is packaged into a DLL with WebKit2.
117
118         * Scripts/build-webkit: Always build WebKit2 on Windows.
119
120 2010-07-12  Brian Weinstein  <bweinstein@apple.com>
121
122         Reviewed by Steve Falkenburg.
123
124         One http test timing out on Windows can cause all future tests to time out
125         https://bugs.webkit.org/show_bug.cgi?id=42146
126         
127         There have been multiple times on the Windows bots where one http test timing out causes all future
128         http tests to time out. This is because the httpd process becomes unresponsive. When an http test
129         times out, we should restart httpd on Cygwin to prevent this.
130
131         * Scripts/old-run-webkit-tests: If an http test timed out on Cygwin, close httpd and restart it.
132         * Scripts/webkitperl/httpd.pm: Add additional logic to closeHTTPD to teach it about taskkill if
133             using kill fails.
134
135 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
136
137         Reviewed by Dan Bernstein.
138
139         Remove use of auto_ptr in WebKitTestRunner
140         https://bugs.webkit.org/show_bug.cgi?id=42134
141         
142         Replaced auto_ptr with PassOwnPtr / OwnPtr.
143
144         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
145         (WTR::WKStringToUTF8):
146         (WTR::InjectedBundlePage::dump):
147         (WTR::InjectedBundlePage::addMessageToConsole):
148         * WebKitTestRunner/TestInvocation.cpp:
149         (WTR::WKStringToUTF8):
150         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
151
152 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
153
154         Reviewed by Sam Weinig.
155
156         Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it)
157         https://bugs.webkit.org/show_bug.cgi?id=42132
158
159         * Scripts/old-run-webkit-tests: In --webkit-test-runner mode, add mac-wk2 to list of
160         platform directories.
161
162 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
163
164         Reviewed by Anders Carlsson.
165
166         Make WebKitTestRunner resize the view specially for the W3C SVG tests.
167         https://bugs.webkit.org/show_bug.cgi?id=42126
168
169         * WebKitTestRunner/PlatformWebView.h:
170         * WebKitTestRunner/TestInvocation.cpp:
171         (WTR::TestInvocation::TestInvocation): Store the path as a C
172         string for later use.
173         (WTR::TestInvocation::~TestInvocation):
174         (WTR::sizeWebViewForCurrentTest): Resize the WebView to the proper
175         size, depending on whether this is a W3C SVG test.
176         (WTR::TestInvocation::invoke): Call the size function.
177         * WebKitTestRunner/TestInvocation.h:
178         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
179         (WTR::PlatformWebView::resizeTo): Implement.
180         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
181         (WTR::PlatformWebView::resizeTo): Placeholder.
182
183 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
184
185         Reviewed by Xan Lopez.
186
187         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
188         https://bugs.webkit.org/show_bug.cgi?id=38648
189
190         Add the GTK_MODULES envvar (set to "gail") to the clean
191         environment when running DRT for the Gtk+ port
192
193         * Scripts/old-run-webkit-tests:
194
195 2010-07-12  Martin Robinson  <mrobinson@igalia.com>
196
197         Reviewed by Dirk Schulze.
198
199         [GTK] Support pixel tests
200         https://bugs.webkit.org/show_bug.cgi?id=31518
201
202         Finish support for pixel tests on GTK+.
203
204         * DumpRenderTree/PixelDumpSupport.cpp: Remove unecessary RetainPtr include (only
205         works on CoreFoundation systems) and add missing cstdio include.
206         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Switch to using the MD5 support found
207         in JSC library. MD5.cpp and MD5.h are only available for the Windows build.
208         (computeMD5HashStringForBitmapContext): The number of bytes per row should be the row stride
209         of the image, not the row stride multiplied by the width. Use JSC MD5 implementation to calculate
210         the MD5 hash here. According to glibc manpages, using snprintf to build a string in unsupported
211         by the ANSI standard and this fails on Linux, so unroll the loop here.
212         * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Correct some constructor misbehavior.
213         (BitmapContext::BitmapContext): There is no reason to check the value of the
214         m_context member in the constructor and it certainly should not be freed. Instead
215         just initialize it with the incoming value.
216         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the order of includes.
217         (dump): Actually call dumpWebViewAsPixelsAndCompareWithExpected when it is time to
218         dump pixels.
219         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Added.
220         (createBitmapContextFromWebView):
221         * GNUmakefile.am: Add new files to the build.
222
223 2010-07-12  Adam Barth  <abarth@webkit.org>
224
225         Unreviewed.
226
227         Remove stray "raise e" that got included in a previous patch.  This
228         caused the EWS bots to turn red instead of purple when a patch failed
229         to apply.
230
231         * Scripts/webkitpy/tool/commands/stepsequence.py:
232
233 2010-07-12  Sheriff Bot  <webkit.review.bot@gmail.com>
234
235         Unreviewed, rolling out r63101.
236         http://trac.webkit.org/changeset/63101
237         https://bugs.webkit.org/show_bug.cgi?id=42103
238
239         Broke one API test (Requested by xan_ on #webkit).
240
241         * Scripts/old-run-webkit-tests:
242
243 2010-07-12  Alexey Proskuryakov  <ap@apple.com>
244
245         Reviewed by Adam Roben.
246
247         https://bugs.webkit.org/show_bug.cgi?id=13075
248         XMLHttpRequest with failed authentication should set status to 401
249
250         https://bugs.webkit.org/show_bug.cgi?id=6871
251         <rdar://problem/3363403> 401 error page is never shown
252
253         Fix crashes in Windows DumpRenderTree.
254
255         * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
256         If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge()
257         again on a destroyed sender.
258
259 2010-07-12  Adam Roben  <aroben@apple.com>
260
261         Windows failure-to-launch fix
262
263         * DumpRenderTree/win/DumpRenderTree.vcproj: Copy CoreVideo.dll and
264         CoreVideo.pdb into WebKitOutputDir in the post-build event, too, like
265         we already do for CoreFoundation, CFNetwork, etc.
266
267 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
268
269         Reviewed by Xan Lopez.
270
271         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
272         https://bugs.webkit.org/show_bug.cgi?id=38648
273
274         Add the GTK_MODULES envvar (set to "gail") to the clean
275         environment when running DRT for the Gtk+ port
276
277         * Scripts/old-run-webkit-tests:
278
279 2010-07-09  Alexey Proskuryakov  <ap@apple.com>
280
281         Reviewed by Darin Adler.
282
283         https://bugs.webkit.org/show_bug.cgi?id=13075
284         XMLHttpRequest with failed authentication should set status to 401
285
286         https://bugs.webkit.org/show_bug.cgi?id=6871
287         <rdar://problem/3363403> 401 error page is never shown
288
289         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
290         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
291         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
292         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
293         Do respond even if handlesAuthenticationChallenges() is false. Pretend that the user pressed
294         the Cancel button.
295
296 2010-07-12  Andreas Kling  <andreas.kling@nokia.com>
297
298         Reviewed by Tor Arne Vestbø.
299
300         [Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser
301         https://bugs.webkit.org/show_bug.cgi?id=42082
302
303         * QtTestBrowser/main.cpp:
304         (LauncherWindow::createChrome):
305         * QtTestBrowser/mainwindow.cpp:
306         (MainWindow::openLocation):
307         * QtTestBrowser/mainwindow.h:
308
309 2010-07-12  Adam Roben  <aroben@apple.com>
310
311         Make the Python autoinstaller not use a dead SourceForge server
312
313         Fixes <http://webkit.org/b/42080> webkit-patch is broken due to
314         offline SourceForge server
315
316         Reviewed by Anders Carlsson.
317
318         * Scripts/webkitpy/thirdparty/__init__.py: Use
319         surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net,
320         which seems to be down.
321
322 2010-07-12  Adam Roben  <aroben@apple.com>
323
324         Make run-webkit-tests print how many tests timed out when exiting
325         early
326
327         The number of timed-out tests is taken into account when deciding
328         whether to exit early. Leaving it out of the output just makes the
329         script look buggy (because it might say something like "Exiting early
330         after 0 crashes.").
331
332         Fixes <http://webkit.org/b/42077> run-webkit-tests prints confusing
333         messages when exiting early due to crashes and time-outs
334
335         Reviewed by Anders Carlsson.
336
337         * Scripts/old-run-webkit-tests:
338         (stopRunningTestsEarlyIfNeeded): When stopping, print the number of
339         timed-out tests, too.
340
341 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
342
343         Reviewed by Dan Bernstein.
344
345         Implement animation-related methods for WebKitTestRunner
346         https://bugs.webkit.org/show_bug.cgi?id=42053
347         
348         Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
349         animation tests were hanging otherwise.
350
351         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
352         (WTR::LayoutTestController::numberOfActiveAnimations):
353         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
354         (WTR::numberOfActiveAnimationsCallback):
355         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
356         (WTR::LayoutTestController::staticFunctions):
357         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
358
359 2010-07-11  Daniel Bates  <dbates@rim.com>
360
361         Reviewed by David Kilzer.
362
363         Enable executable support for svn-apply and svn-unapply
364         https://bugs.webkit.org/show_bug.cgi?id=39409
365
366         Connect up the Git and SVN executable bit support in parseDiff() so that
367         executable bit changes are propagated via the returned diff hash to the
368         patch function in svn-apply and svn-unapply.
369
370         * Scripts/VCSUtils.pm:
371           - Modified parseDiff() to call parseSvnDiffProperties when
372             it finds the start of an SVN property change diff.
373           - Removed FIXME comment above parseSvnDiffProperties() since
374             it is now being used by parseDiff().
375           - Export method scmToggleExecutableBit() now that we added the
376             executableBitDelta hash key. (This should have been exported
377             when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
378         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
379           - Updated results for:
380             "rename (with executable bit change)"
381               - Test value of executableBitDelta (now that we have support).
382             "SVN: binary file (isBinary true)"
383               - Remove the property change diff from svnConvertedText. We plan
384                 to remove svnConvertedText in the future. So, we decided
385                 against adding such support to any new code, such as the
386                 property parsing routines. Therefore, we do not keep SVN
387                 converted text for property change diffs.
388           - Added unit tests:
389             "SVN: file change diff with property change diff"
390             "SVN: file change diff, followed by property change diff on different file"
391             "SVN: property diff, followed by file change diff"
392             "SVN: copied file with property change"
393             "SVN: two consecutive property diffs"
394             "SVN: binary file with executable bit change"
395             "SVN: binary file followed by property change on different file"
396             "SVN: binary file followed by file change on different file"
397             "SVN: file change diff with property change, followed by property change diff"
398             "SVN: file change diff with property change, followed by file change diff"
399
400 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
401
402         Reviewed by Dan Bernstein.
403
404         Implement waitUntilDone and notifyDone for WebKitTestRunner
405         https://bugs.webkit.org/show_bug.cgi?id=42049
406
407         With this fix, most of the DOM tests pass.
408         
409         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
410         (WTR::InjectedBundle::didCreatePage): Track the main page. Not
411         a great way to do it in the future case where we may get multiple
412         pages - we really need a way to send it over from the ui process.
413         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
414         (WTR::InjectedBundle::page): A way to get the main page.
415         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
416         (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
417         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
418         are loading.
419         (WTR::InjectedBundlePage::dump): Factor into a method so this can be
420         called by the layout test controller. Also, cancel any pending watchdogs.
421         (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
422         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
423         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
424         (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
425         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
426         (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
427         to false.
428         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate 
429         the watchdog.
430         (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
431         (WTR::LayoutTestController::setWaitToDump): Set the flag.
432         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
433         where waitUntilDone times out.
434         (WTR::LayoutTestController::notifyDone): Dump, if loading is done.
435         (WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
436         (WTR::notifyDoneCallback): JS glue for notifyDone.
437         (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
438         to the layoutController.
439         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
440         (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
441
442 2010-07-09  Brian Weinstein  <bweinstein@apple.com>
443
444         Rubber-stamped by Dan Bernstein.
445
446         Windows testers running Windows 7 were hanging during test_kill_process. Changing the
447         number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
448         slow down the tests).
449
450         * Scripts/webkitpy/common/system/executive.py:
451
452 2010-07-09  Luiz Agostini  <luiz.agostini@openbossa.org>
453
454         Reviewed by Kenneth Rohde Christiansen.
455
456         [Qt] Mac build fix
457         https://bugs.webkit.org/show_bug.cgi?id=41967
458
459         Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
460
461         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
462
463 2010-07-09  Diego Gonzalez  <diegohcg@webkit.org>
464
465         Reviewed by Antonio Gomes.
466
467         [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
468         https://bugs.webkit.org/show_bug.cgi?id=41966
469
470         * MiniBrowser/qt/BrowserWindow.cpp:
471         (BrowserWindow::BrowserWindow):
472
473 2010-07-09  Leon Clarke  <leonclarke@google.com>
474
475         Reviewed by Adam Barth.
476
477         add support for link prefetching
478         https://bugs.webkit.org/show_bug.cgi?id=3652
479
480         * Scripts/build-webkit:
481
482 2010-07-09  Ojan Vafai  <ojan@chromium.org>
483
484         Reviewed by Adam Barth.
485
486         r63004 broke some python tests
487         https://bugs.webkit.org/show_bug.cgi?id=42007
488
489         AbstractStep now checks options.no_squash and options.squash, so
490         they needed to have real values. Mock would return an object for those,
491         which would then act as if the values were True.
492
493         * Scripts/webkitpy/tool/commands/commandtest.py:
494         * Scripts/webkitpy/tool/commands/download_unittest.py:
495         * Scripts/webkitpy/tool/commands/stepsequence.py:
496         * Scripts/webkitpy/tool/commands/upload_unittest.py:
497         * Scripts/webkitpy/tool/mocktool.py:
498         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
499         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
500         * Scripts/webkitpy/tool/steps/steps_unittest.py:
501         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
502         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
503
504 2010-07-09  Ojan Vafai  <ojan@chromium.org>
505
506         Reviewed by Adam Barth.
507
508         --squash should go away and become the default
509         https://bugs.webkit.org/show_bug.cgi?id=39624
510
511         If there are local commits and working copy changes, then prompt the user
512         whether to continue. Setting git config webkit-patch.commit_should_always_squash
513         true bypasses the prompt.
514
515         --git-commit=HEAD.. operates on working copy changes only.
516         --git-commit=committish operates on a range of commits as a single commit.
517             e.g. --git-commit=HEAD only operates on the HEAD commit.
518             --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
519
520         --no-squash and --squash are left in with descriptive error messages if used.
521
522         * Scripts/check-webkit-style:
523         * Scripts/webkitpy/common/checkout/api.py:
524         * Scripts/webkitpy/common/checkout/api_unittest.py:
525         * Scripts/webkitpy/common/checkout/scm.py:
526         * Scripts/webkitpy/common/checkout/scm_unittest.py:
527         * Scripts/webkitpy/common/net/rietveld.py:
528         * Scripts/webkitpy/common/system/user.py:
529         * Scripts/webkitpy/style/optparser.py:
530         * Scripts/webkitpy/style_references.py:
531         * Scripts/webkitpy/tool/commands/download.py:
532         * Scripts/webkitpy/tool/commands/upload.py:
533         * Scripts/webkitpy/tool/mocktool.py:
534         * Scripts/webkitpy/tool/steps/abstractstep.py:
535         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
536         * Scripts/webkitpy/tool/steps/checkstyle.py:
537         * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
538         * Scripts/webkitpy/tool/steps/commit.py:
539         * Scripts/webkitpy/tool/steps/options.py:
540         * Scripts/webkitpy/tool/steps/preparechangelog.py:
541         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
542         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
543         * Scripts/webkitpy/tool/steps/validatereviewer.py:
544
545 2010-07-09  Mark Rowe  <mrowe@apple.com>
546
547         Add two new Windows test build slaves.
548
549         * BuildSlaveSupport/build.webkit.org-config/config.json:
550
551 2010-07-09  Albert J. Wong  <ajwong@chromium.org>
552
553         Reviewed by David Levin.
554
555         rebaseline_chromium_webkit_tests missing --use_drt option on linux
556         https://bugs.webkit.org/show_bug.cgi?id=41985
557
558         This adds in the --use_drt option for rebaseline_chromium_webkit_tests
559         so that it works on linux. This is essentially a "compile-fix" for the
560         script.
561
562         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
563
564 2010-07-09  Nico Weber  <thakis@chromium.org>
565
566         Unreviewed. Adding myself as committer.
567
568         * Scripts/webkitpy/common/config/committers.py:
569
570 2010-07-09  David Kilzer  <ddkilzer@apple.com>
571
572         Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"
573
574         This reverts commit r62692.
575
576         * Scripts/commit-log-editor:
577
578 2010-07-08  Kinuko Yasuda  <kinuko@chromium.org>
579
580         Reviewed by Ojan Vafai.
581
582         cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
583         https://bugs.webkit.org/show_bug.cgi?id=38693
584
585         Introduced a new base class JSONResultsGeneratorBase that doesn't
586         have any dependency on layout_tests packages.
587         Turned JSONResultsGenerator into a wrapper class of the base class
588         so that the old code can work with it during the cleanup.
589
590         Added json_results_generator_unittest.py.
591
592         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
593         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
594         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
595
596 2010-07-09  Abhishek Arya  <inferno@chromium.org>
597
598         Unreviewed.
599
600         Marking myself as a committer.
601
602         * Scripts/webkitpy/common/config/committers.py:
603
604 2010-07-09  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
605
606         Reviewed by Antti Koivisto.
607
608         Implement MiniBrowser for Qt.
609         https://bugs.webkit.org/show_bug.cgi?id=40233
610
611         * MiniBrowser/qt/BrowserWindow.cpp: Added.
612         (createNewPage):
613         (BrowserView::BrowserView):
614         (BrowserView::resizeEvent):
615         (BrowserView::load):
616         (BrowserView::view):
617         (BrowserWindow::BrowserWindow):
618         (BrowserWindow::load):
619         (BrowserWindow::changeLocation):
620         (BrowserWindow::~BrowserWindow):
621         * MiniBrowser/qt/BrowserWindow.h: Added.
622         (BrowserView::~BrowserView):
623         * MiniBrowser/qt/MiniBrowser.pro: Added.
624         * MiniBrowser/qt/main.cpp: Added.
625         (main):
626
627 2010-07-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
628
629         Reviewed by Simon Hausmann.
630
631         Introduce the Qt autotest launcher.
632
633         Qt autotests should be executed more frequently, ideally by the Qt
634         build bot. This is the first step to provide the tests more accessible.
635
636         [Qt] It should be easier to run all Qt's autotests.
637         https://bugs.webkit.org/show_bug.cgi?id=31625
638
639         * Scripts/run-qtwebkit-tests: Added.
640
641 2010-07-09  Adam Barth  <abarth@webkit.org>
642
643         Reviewed by Eric Seidel.
644
645         commit-queue should merge to TOT when checkout needs update
646         https://bugs.webkit.org/show_bug.cgi?id=41944
647
648         There are a bunch of different designs that are possible here.  This
649         one merges to top of tree by cleaning out the working copy and
650         re-applying the patch.  Once you decide to merge that way, you need to
651         decide who's going to retry.  In this patch, we retry in the child
652         process instead of plumbing the failure reason to the master process.
653
654         This patch is difficult to test end-to-end, but hopefully it will work.
655         :)
656
657         * Scripts/webkitpy/tool/commands/queues.py:
658         * Scripts/webkitpy/tool/commands/stepsequence.py:
659         * Scripts/webkitpy/tool/multicommandtool.py:
660         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
661
662 2010-07-09  Dumitru Daniliuc  <dumi@chromium.org>
663
664         Reviewed by Darin Adler.
665
666         Add a script to check for unnecessary includes in header files.
667         https://bugs.webkit.org/show_bug.cgi?id=41894
668
669         * Scripts/check-header-includes: Added.
670
671 2010-07-09  Adam Barth  <abarth@webkit.org>
672
673         Reviewed by Eric Seidel.
674
675         Add --html5-treebuilder option to run-webkit-tests
676         https://bugs.webkit.org/show_bug.cgi?id=41922
677
678         We're down to one or two regressions in the HTML5lib test suite.  It's
679         getting to be time to look at fixing LayoutTests.
680
681         * Scripts/old-run-webkit-tests:
682
683 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
684
685         Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting
686         in the drawing model never getting set on Tiger.
687
688         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
689         (NPP_New):
690
691 2010-07-08  Aaron Boodman  <aa@chromium.org>
692
693         Reviewed by Timothy Hatcher.
694
695         Add the ability for user scripts and user styles to affect just the top frame.
696
697         https://bugs.webkit.org/show_bug.cgi?id=41529
698
699         * DumpRenderTree/LayoutTestController.h: Added new allFrames param.
700         * DumpRenderTree/LayoutTestController.cpp: Ditto.
701         (addUserScriptCallback):
702         (addUserStyleSheetCallback):
703         * DumpRenderTree/chromium/LayoutTestController.cpp: Ditto.
704         (LayoutTestController::addUserScript):
705         (LayoutTestController::addUserStyleSheet):
706         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
707         (LayoutTestController::addUserScript):
708         (LayoutTestController::addUserStyleSheet):
709         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
710         (LayoutTestController::addUserScript):
711         (LayoutTestController::addUserStyleSheet):
712         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto.
713         (LayoutTestController::addUserScript):
714         (LayoutTestController::addUserStyleSheet):
715         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto.
716         (LayoutTestController::addUserScript):
717         (LayoutTestController::addUserStyleSheet):
718
719 2010-07-08  Adele Peterson  <adele@apple.com>
720
721         Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
722
723         Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721
724         <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
725
726         Log when the missing plugin button is pressed.
727
728         * DumpRenderTree/mac/UIDelegate.mm:
729         (-[UIDelegate webView:didPressMissingPluginButton:]):
730         * DumpRenderTree/win/UIDelegate.cpp:
731         (UIDelegate::QueryInterface):
732         (UIDelegate::createWebViewWithRequest):
733         (UIDelegate::drawBackground):
734         (UIDelegate::decidePolicyForGeolocationRequest):
735         (UIDelegate::didPressMissingPluginButton):
736         * DumpRenderTree/win/UIDelegate.h:
737
738 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
739
740         Fix the Tiger build.
741
742         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
743         (NPP_New):
744
745 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
746
747         Fix windows build.
748
749         #ifdef code for Mac.
750
751         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
752         (NPP_New):
753
754 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
755
756         Reviewed by Anders Carlsson.
757
758         Allow the TestPlugin to use Core Animation rendering for testing
759         https://bugs.webkit.org/show_bug.cgi?id=41872
760         
761         Add the ability for the TestPlugin to use the CoreAnimation rendering model
762         when available, based on the "drawingmodel" attribute of the embed tag:
763             drawingmodel="coreanimation"
764
765         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm
766         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect
767         when building on Tiger. Add a void* coreAnimationLayer member.
768         
769         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added.
770         (createCoreAnimationLayer): Obj-C method to create the CALayer.
771         
772         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
773         (NPP_New): Look for the drawingmodel attribute to decide which drawing
774         model to use.
775         (NPP_Destroy): Release the CALayer if we have one.
776         (NPP_GetValue): Return the retained CALayer.
777
778 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
779
780         Reviewed by Xan Lopez.
781
782         [GTK] Support pixel tests
783         https://bugs.webkit.org/show_bug.cgi?id=31518
784
785         Convert this file from CRLF to NL line endings. It will soon
786         be used on more than just the WinCairo platform.
787
788         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
789         (writeFunction):
790         (printPNG):
791         (computeMD5HashStringForBitmapContext):
792         (dumpBitmap):
793
794 2010-07-08  Steve Falkenburg  <sfalken@apple.com>
795
796         Reviewed by Darin Adler.
797
798         Enable Data Execution Prevention for our test harnesses on Windows
799         https://bugs.webkit.org/show_bug.cgi?id=41882
800
801         * DumpRenderTree/win/DumpRenderTree.vcproj:
802         * DumpRenderTree/win/ImageDiff.vcproj:
803         * WebKitAPITest/WebKitAPITest.vcproj:
804         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
805
806 2010-07-07  Robert Hogan  <robert@webkit.org>
807
808         Reviewed by Kenneth Rohde Christiansen.
809
810         [Qt] Add DRT support for pageProperty etc.
811
812         https://bugs.webkit.org/show_bug.cgi?id=41584
813
814         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
815         (LayoutTestController::isPageBoxVisible):
816         (LayoutTestController::pageSizeAndMarginsInPixels):
817         (LayoutTestController::pageProperty):
818         (LayoutTestController::addUserStyleSheet):
819         * DumpRenderTree/qt/LayoutTestControllerQt.h:
820
821 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
822
823         Reviewed by Xan Lopez.
824
825         Remove a warnings from the ImageDiff build by using the proper
826         printf format string for the gsize data type.
827
828         * DumpRenderTree/gtk/ImageDiff.cpp:
829         (printImage): Use the proper printf format string for the gsize data type.
830
831 2010-07-08  Alice Liu  <alice.liu@apple.com>
832
833         Reviewed by Sam Weinig.
834
835         https://bugs.webkit.org/show_bug.cgi?id=41653
836         Add new WebKitTestRunner project for Windows
837
838         * WebKitTestRunner/WebKitTestRunnerPrefix.h: 
839         Similar to how it's done in DumpRenderTree, define max and min early
840         on so that they don't get replaced by a macro requiring 2 arguments.
841
842         * WebKitTestRunner/win: Added.
843         * WebKitTestRunner/win/WebKitTestRunner.sln: Added.
844         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added.
845         * WebKitTestRunner/win/main.cpp: Added.
846         (main): Implemented
847
848         Added these files with stubbed out functions:
849         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
850         (WTR::PlatformWebView::PlatformWebView):
851         (WTR::PlatformWebView::~PlatformWebView):
852         (WTR::PlatformWebView::page):
853         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
854         (WTR::TestController::initializeInjectedBundlePath):
855         * WebKitTestRunner/win/TestInvocationWin.cpp: Added.
856         (WTR::TestInvocation::runUntil):
857
858 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
859
860         Reviewed by Gustavo Noronha Silva.
861
862         [GTK] Implement ImageDiff and add it to the build system
863         https://bugs.webkit.org/show_bug.cgi?id=41779
864
865         Add the initial implementation of the ImageDiff tool for the GTK+
866         port. This is an essential tool for doing pixel tests. The implementation
867         is based on the Mac and Chromium ports.
868
869         * DumpRenderTree/gtk/ImageDiff.cpp: Added.
870         (readPixbufFromStdin): Added.
871         (differenceImageFromDifferenceBuffer): Ditto.
872         (calculateDifference): Ditto.
873         (printImage): Ditto.
874         (printImageDifferences): Ditto.
875         (main): Ditto.
876         * GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts.
877
878 2010-07-08  Jay Civelli  <jcivelli@chromium.org>
879
880         Unreviewed. Adding myself as a committer.
881
882         * Scripts/webkitpy/common/config/committers.py:
883
884 2010-07-08  Adam Roben  <aroben@apple.com>
885
886         Make Windows stop running tests from platform/mac
887
888         r62742 made a change (at my suggestion!) that caused us to start
889         looking for tests in platform/mac, rather than just looking for
890         expected results in platform/mac. This patch just undoes that part of
891         r62742.
892
893         Fixes <http://webkit.org/b/41855> REGRESSION (r62742): Windows runs
894         tests from platform/mac, but shouldn't
895
896         Reviewed by Antti Koivisto and Anders Carlsson.
897
898         * Scripts/old-run-webkit-tests:
899         (top level): Removed "mac-snowleopard" and "mac" from @winPlatforms,
900         so we won't look in those directories for tests to run.
901         (expectedDirectoryForTest): Added back code from pre-r62742 to look in
902         platform/mac-snowleopard and platform/mac for expected results.
903
904 2010-07-08  Antonio Gomes  <tonikitoo@webkit.org>
905
906         Unreviewed. Adding myself as a reviewer.
907
908         * Scripts/webkitpy/common/config/committers.py:
909
910 2010-07-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
911
912         Update my e-mail in committers.py
913
914         * Scripts/webkitpy/common/config/committers.py:
915
916 2010-07-07  Daniel Bates  <dbates@rim.com>
917
918         Reviewed by Dumitru Daniliuc.
919
920         VCSUtils.pm complains about uninitialized value $newLine
921         https://bugs.webkit.org/show_bug.cgi?id=41333
922
923         Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of
924         an array when fixing a change log entry that overlaps with an earlier
925         entry. In particular, when a patch contains a change log entry inserted
926         earlier in the change log file, but after an entry with the same author
927         and date.
928
929         * Scripts/VCSUtils.pm:
930             - Added for-loop constraint to fixChangeLogPatch() so that it does not
931               read off the end of the @overlappingLines array.
932         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test.
933
934 2010-07-07  Anders Carlsson  <andersca@apple.com>
935
936         Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard.
937
938         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
939         (NPP_New):
940
941 2010-07-07  Kent Tamura  <tkent@chromium.org>
942
943         Reviewed by Adam Barth.
944
945         [DRT/Chromium] Support for indeterminate checkbox
946         https://bugs.webkit.org/show_bug.cgi?id=41747
947
948         Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499
949
950         * DumpRenderTree/chromium/WebThemeControlDRT.cpp:
951         (WebThemeControlDRT::draw):
952         * DumpRenderTree/chromium/WebThemeControlDRT.h:
953         (WebThemeControlDRT::):
954         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
955         (WebThemeEngineDRT::paintButton):
956
957 2010-07-07  Sam Weinig  <sam@webkit.org>
958
959         Reviewed by Mark Rowe.
960
961         Clean up MiniBrowser Xcode project.
962
963         - Use xcconfig files.
964         - Rename plists to canonical Info.plist
965         - Remove localizations.
966
967         * MiniBrowser/Configurations: Added.
968         * MiniBrowser/Configurations/Base.xcconfig: Added.
969         * MiniBrowser/Configurations/DebugRelease.xcconfig: Added.
970         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Added.
971         * MiniBrowser/Configurations/WebBundle.xcconfig: Added.
972         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
973         * MiniBrowser/WebBundle-Info.plist: Removed.
974         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
975         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
976         * MiniBrowser/mac/BrowserWindow.xib: Added.
977         * MiniBrowser/mac/BrowserWindowController.m:
978         (-[BrowserWindowController initWithPageNamespace:]):
979         * MiniBrowser/mac/English.lproj: Removed.
980         * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed.
981         * MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed.
982         * MiniBrowser/mac/English.lproj/MainMenu.xib: Removed.
983         * MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist.
984         * MiniBrowser/mac/MainMenu.xib: Added.
985         * MiniBrowser/mac/MiniBrowser-Info.plist: Removed.
986         * MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist.
987
988 2010-07-07  Kent Tamura  <tkent@chromium.org>
989
990         Reviewed by Dimitri Glazkov.
991
992         [DRT/Chromium] Fix two regressions
993         https://bugs.webkit.org/show_bug.cgi?id=41745
994
995         * DumpRenderTree/chromium/WebViewHost.cpp:
996         (WebViewHost::paintInvalidatedRegion):
997          Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
998          and svg/custom/use-on-g-containing-foreignObject-and-image.svg
999          though test_shell does it twice. Probably DRT needs it because
1000          DRT delays painting as possible.
1001
1002 2010-07-07  Anders Carlsson  <andersca@apple.com>
1003
1004         Try to fix build.
1005
1006         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1007         (webkit_test_plugin_destroy_stream):
1008
1009 2010-07-07  Anders Carlsson  <andersca@apple.com>
1010
1011         Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp
1012
1013         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1014         (webkit_test_plugin_new_stream):
1015         (webkit_test_plugin_destroy_stream):
1016         (webkit_test_plugin_write_ready):
1017         (webkit_test_plugin_write):
1018
1019 2010-07-07  Sam Weinig  <sam@webkit.org>
1020
1021         Reviewed by Mark Rowe.
1022
1023         Don't hard code the Mac OS X 10.6 SDK for MiniBrowser. 
1024
1025         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1026
1027 2010-07-07  Anders Carlsson  <andersca@apple.com>
1028
1029         Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms.
1030
1031         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1032         (NPP_New):
1033         (NPP_HandleEvent):
1034
1035 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
1036
1037         Reviewed by Adam Roben.
1038
1039         Need to have a way to specify different results for Windows XP and 7
1040         https://bugs.webkit.org/show_bug.cgi?id=41776
1041         
1042         Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7
1043         subdirectories, so we can have different results for tests on Windows XP, Windows
1044         Vista, and Windows 7.
1045
1046         Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac.
1047         Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac.
1048         Windows 7 will try the order: win-7, win, mac-snowleopard, mac.
1049
1050         This matches the behavior of the mac.
1051
1052         * Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP
1053             or Vista, try looking in other win-* subdirectories before win.
1054         * Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows
1055             we are running.
1056
1057 2010-07-07  Kent Tamura  <tkent@chromium.org>
1058
1059         Reviewed by Dimitri Glazkov.
1060
1061         [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
1062         https://bugs.webkit.org/show_bug.cgi?id=41753
1063
1064         The original code of the following functions in
1065         test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
1066         ASSERT_NOT_REACHED(). The program shouldn't stop at these
1067         functions.
1068
1069         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1070         (DRTDevToolsClient::activateWindow):
1071         (DRTDevToolsClient::closeWindow):
1072         (DRTDevToolsClient::dockWindow):
1073         (DRTDevToolsClient::undockWindow):
1074
1075 2010-07-07  Anders Carlsson  <andersca@apple.com>
1076
1077         Reviewed by Sam Weinig.
1078
1079         Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
1080         https://bugs.webkit.org/show_bug.cgi?id=41821
1081
1082         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1083         (pluginGetProperty):
1084         (pluginSetProperty):
1085         (pluginAllocate):
1086         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1087         Add and initialize the returnNegativeOneFromWrite property.
1088
1089         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1090         (NPP_NewStream):
1091         Set the stream type to NP_NORMAL so we'll get write callbacks.
1092
1093         (NPP_DestroyStream):
1094         Treat the onstreamdestroy attribute as a function name and not a string.
1095
1096         (NPP_WriteReady):
1097         Have this return a nonzero value.
1098
1099         (NPP_Write):
1100         If returnNegativeOneFromWrite is true return -1.
1101
1102 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
1103
1104         [wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
1105         latest version is selected by default, and allows the version to be specified.
1106
1107         * wx/build/settings.py:
1108
1109 2010-07-07  Chris Fleizach  <cfleizach@apple.com>
1110
1111         Reviewed by Darin Adler.
1112
1113         AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
1114         https://bugs.webkit.org/show_bug.cgi?id=41810
1115
1116         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1117         (AccessibilityUIElement::selectedTextRange):
1118
1119 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
1120
1121         Unreviewed.
1122
1123         Build fix after r62700.
1124
1125         * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
1126         source file locations.
1127
1128 2010-07-07  Ojan Vafai  <ojan@chromium.org>
1129
1130         Reviewed by David Levin.
1131
1132         change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts
1133         https://bugs.webkit.org/show_bug.cgi?id=41814
1134
1135         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1136         * Scripts/old-run-webkit-tests:
1137
1138 2010-07-07  Ojan Vafai  <ojan@chromium.org>
1139
1140         Reviewed by David Levin.
1141
1142         add --exit-after-n-crashes to run-webkit-tests
1143         https://bugs.webkit.org/show_bug.cgi?id=41811
1144
1145         Change the bots at build.webkit.org to use --exit-after-n-crashes
1146         instead of --exit-after-n-failures since we want to be able to have
1147         more than 20 failures on those bots, but more than 20 crashes means
1148         something should be rolled out.
1149
1150         * Scripts/old-run-webkit-tests:
1151         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1152
1153 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
1154
1155         Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
1156         TestNetscapePlugin project, because this was removed from the tree.
1157
1158         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1159
1160 2010-07-07  Anders Carlsson  <andersca@apple.com>
1161
1162         Reviewed by Simon Fraser.
1163
1164         Unify Mac and Windows TestNetscapePlugin main.cpp files
1165         https://bugs.webkit.org/show_bug.cgi?id=41798
1166         
1167         * DumpRenderTree/DumpRenderTree.sln:
1168         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1169         (strcasecmp):
1170         (NP_Initialize):
1171         (NP_GetEntryPoints):
1172         (NP_Shutdown):
1173         (NPP_New):
1174         (NPP_Destroy):
1175         (NPP_HandleEvent):
1176         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1177         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.
1178
1179 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
1180
1181         [wx] Build fix. pageProperty needs to return a value.
1182
1183         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1184         (LayoutTestController::pageProperty):
1185
1186 2010-07-07  David Kilzer  <ddkilzer@apple.com>
1187
1188         <http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git
1189
1190         Reviewed by Anders Carlsson.
1191
1192         For both svn and git, commit-log-editor is invoked from the root
1193         of the working directory.  Unlike svn, git returns a list of
1194         changed files that are relative to the directory where the
1195         command was invoked.  This caused the ChangeLog file in the root
1196         directory to be read instead of the ChangeLog in the current
1197         directory.
1198
1199         The fix is to use $ENV{PWD} as the base directory when fixing
1200         the path to the ChangeLog files.  With svn, this has no net
1201         effect since $ENV{PWD} is the root of the working directory and
1202         the ChangeLog paths are already relative to that directory.
1203         With git, $ENV{PWD} is the directory that the commit was invoked
1204         from, which fixes the ChangeLog paths so that the correct files
1205         are read when creating the commit log entry.
1206
1207         Note that the call to makeFilePathRelative() was supposed to
1208         address this issue, but it doesn't because (a) it does nothing
1209         with svn working directories by design, and (b) it does nothing
1210         with git working directories because it's invoked when the
1211         current directory is the root of the working directory, thus
1212         giving no relative path.
1213
1214         * Scripts/commit-log-editor: Removed call to
1215         makeFilePathRelative() since since it does nothing.  Moved code
1216         to fix up $changeLog path so that it's fixed before trying to
1217         open the file, and use $ENV{PWD} as the base path.  Also use
1218         canonicalizePath() to clean up paths with "../" in them.
1219
1220 2010-07-07  Anders Carlsson  <andersca@apple.com>
1221
1222         Another attempt at fixing the Qt build.
1223
1224         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1225
1226 2010-07-07  Anders Carlsson  <andersca@apple.com>
1227
1228         Try to fix Qt build.
1229
1230         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1231
1232 2010-07-07  Anders Carlsson  <andersca@apple.com>
1233
1234         Reviewed by Simon Fraser.
1235
1236         Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
1237         https://bugs.webkit.org/show_bug.cgi?id=41781
1238
1239         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1240         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
1241         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
1242         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
1243         * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
1244         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
1245         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
1246         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
1247         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
1248         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
1249         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
1250         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
1251         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
1252
1253 2010-07-07  Andras Becsi  <abecsi@webkit.org>
1254
1255         Unreviewed trivial fix.
1256
1257         Remove DUMPRENDERTREE_TEMP environment variable from NRWT
1258         which was checked in accidentally in r62635.
1259
1260         * Scripts/webkitpy/layout_tests/port/webkit.py:
1261
1262 2010-07-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1263
1264         Reviewed by Eric Seidel.
1265
1266         Pass port specific environment to server process.
1267         https://bugs.webkit.org/show_bug.cgi?id=41593
1268
1269         * Scripts/webkitpy/layout_tests/port/qt.py:
1270         * Scripts/webkitpy/layout_tests/port/webkit.py:
1271
1272 2010-07-06  Kent Tamura  <tkent@chromium.org>
1273
1274         Reviewed by Shinichiro Hamaji.
1275
1276         Fix a wrong dup detection of rebaseline-chromium-webkit-tests
1277         https://bugs.webkit.org/show_bug.cgi?id=41644
1278
1279         rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
1280         tolerance. We don't need tolerance for rebaseline.
1281
1282         * Scripts/webkitpy/layout_tests/port/base.py:
1283           Add optional tolerance parameter to diff_image().
1284         * Scripts/webkitpy/layout_tests/port/test.py:
1285           Add optional tolerance parameter to diff_image().
1286         * Scripts/webkitpy/layout_tests/port/webkit.py:
1287           Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
1288         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1289           diff_files() always calls diff_image() with tolerance=0.
1290           diff_files() is used only by rebaseline-chromium-webkit-tests.
1291
1292 2010-07-06  Sam Weinig  <sam@webkit.org>
1293
1294         Fix MiniBrowser build.
1295
1296         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1297
1298 2010-07-06  Sam Weinig  <sam@webkit.org>
1299
1300         Reviewed by Anders Carlsson.
1301
1302         Add support for dumping the contents of messages to the console to WebKitTestRunner
1303
1304         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1305         (WTR::InjectedBundlePage::InjectedBundlePage):
1306         (WTR::InjectedBundlePage::_addMessageToConsole):
1307         (WTR::InjectedBundlePage::addMessageToConsole):
1308         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1309
1310 2010-07-06  Sam Weinig  <sam@webkit.org>
1311
1312         Reviewed by Anders Carlsson.
1313
1314         Patch for https://bugs.webkit.org/show_bug.cgi?id=41708
1315         Add dumpAsText support for WebKitTestRunner
1316
1317         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1318         (WTR::InjectedBundle::InjectedBundle):
1319         (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.
1320         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1321         (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
1322         API to dump the main frames text.
1323
1324 2010-07-06  Darin Adler  <darin@apple.com>
1325
1326         Fix Chromium build.
1327
1328         * DumpRenderTree/chromium/WebViewHost.cpp:
1329         (WebViewHost::didCreateDataSource): Call leakPtr instead of release.
1330         (WebViewHost::didNavigateWithinPage): Ditto.
1331         (WebViewHost::updateURL): Ditto.
1332
1333 2010-07-06  Martin Robinson  <mrobinson@igalia.com>
1334
1335         Reviewed by Xan Lopez.
1336
1337         [GTK] build-webkit should not run autogen.sh unconditionally
1338         https://bugs.webkit.org/show_bug.cgi?id=41704
1339
1340         * Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile
1341         doesn't exist. Autotools should re-run autogen.sh when necessary. Also do
1342         some very minor cleanup.
1343
1344 2010-07-06  Darin Adler  <darin@apple.com>
1345
1346         Try to fix Chromium build.
1347
1348         * DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h.
1349
1350 2010-07-06  Darin Adler  <darin@apple.com>
1351
1352         Fix build.
1353
1354         * WebKitAPITest/TestsController.cpp:
1355         (WebKitAPITest::TestsController::addTest): Use leakPtr instead of release.
1356
1357 2010-07-06  Roland Steiner  <rolandsteiner@chromium.org>
1358
1359         Reviewed by Kent Tamura.
1360
1361         Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
1362         https://bugs.webkit.org/show_bug.cgi?id=40558
1363
1364         Upstream DevTools for Chromium DRT.
1365         (original Chromium files rev. 51287)
1366
1367         * DumpRenderTree/DumpRenderTree.gypi:
1368         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added.
1369         (DRTDevToolsAgent::DRTDevToolsAgent):
1370         (DRTDevToolsAgent::setWebView):
1371         (DRTDevToolsAgent::sendMessageToFrontend):
1372         (DRTDevToolsAgent::forceRepaint):
1373         (DRTDevToolsAgent::runtimeFeatureStateChanged):
1374         (DRTDevToolsAgent::injectedScriptSource):
1375         (DRTDevToolsAgent::injectedScriptDispatcherSource):
1376         (DRTDevToolsAgent::debuggerScriptSource):
1377         (DRTDevToolsAgent::asyncCall):
1378         (DRTDevToolsAgent::call):
1379         (DRTDevToolsAgent::webDevToolsAgent):
1380         (DRTDevToolsAgent::attach):
1381         (DRTDevToolsAgent::detach):
1382         (DRTDevToolsAgent::setTimelineProfilingEnabled):
1383         (DRTDevToolsAgent::evaluateInWebInspector):
1384         (DRTDevToolsAgent::dispatchMessageLoop):
1385         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added.
1386         (DRTDevToolsAgent::~DRTDevToolsAgent):
1387         (DRTDevToolsAgent::hostIdentifier):
1388         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
1389         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
1390         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
1391         (DRTDevToolsCallArgs::~DRTDevToolsCallArgs):
1392         (DRTDevToolsCallArgs::callsCount):
1393         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added.
1394         (DRTDevToolsClient::DRTDevToolsClient):
1395         (DRTDevToolsClient::~DRTDevToolsClient):
1396         (DRTDevToolsClient::sendMessageToAgent):
1397         (DRTDevToolsClient::sendDebuggerCommandToAgent):
1398         (DRTDevToolsClient::activateWindow):
1399         (DRTDevToolsClient::closeWindow):
1400         (DRTDevToolsClient::dockWindow):
1401         (DRTDevToolsClient::undockWindow):
1402         (DRTDevToolsClient::asyncCall):
1403         (DRTDevToolsClient::call):
1404         (DRTDevToolsClient::allMessagesProcessed):
1405         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1406         * DumpRenderTree/chromium/EventSender.cpp:
1407         * DumpRenderTree/chromium/LayoutTestController.cpp:
1408         (LayoutTestController::LayoutTestController):
1409         (LayoutTestController::closeWebInspector):
1410         (LayoutTestController::setTimelineProfilingEnabled):
1411         (LayoutTestController::evaluateInWebInspector):
1412         * DumpRenderTree/chromium/LayoutTestController.h:
1413         * DumpRenderTree/chromium/TestShell.cpp:
1414         (TestShell::TestShell):
1415         (TestShell::~TestShell):
1416         (TestShell::createDRTDevToolsClient):
1417         (TestShell::showDevTools):
1418         (TestShell::closeDevTools):
1419         (TestShell::runFileTest):
1420         (TestShell::createNewWindow):
1421         * DumpRenderTree/chromium/TestShell.h:
1422         (TestShell::drtDevToolsAgent):
1423         (TestShell::drtDevToolsClient):
1424         * DumpRenderTree/chromium/config.h:
1425
1426 2010-07-06  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1427
1428         Reviewed by Eric Seidel.
1429
1430         Don't pass image hash to DRT when pixel tests are disabled.
1431         https://bugs.webkit.org/show_bug.cgi?id=41597
1432
1433         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1434
1435 2010-07-05  Csaba Osztrogonác  <ossy@webkit.org>
1436
1437         Reviewed by Eric Seidel.
1438
1439         REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
1440         https://bugs.webkit.org/show_bug.cgi?id=41612
1441
1442         * Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
1443
1444 2010-07-05  Adam Barth  <abarth@webkit.org>
1445
1446         Reviewed by Eric Seidel.
1447
1448         We should be able to specify a bug to block for webkit-patch upload
1449         https://bugs.webkit.org/show_bug.cgi?id=41648
1450
1451         This will be useful for working on the HTML5 parser.
1452
1453         * Scripts/webkitpy/tool/steps/createbug.py:
1454         * Scripts/webkitpy/tool/steps/options.py:
1455
1456 2010-07-05  Martin Robinson  <mrobinson@igalia.com>
1457
1458         Reviewed by Oliver Hunt.
1459
1460         The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
1461         https://bugs.webkit.org/show_bug.cgi?id=41017
1462
1463         * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
1464         * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
1465
1466 2010-07-04  MORITA Hajime  <morrita@google.com>
1467
1468         rebaseline-chromium-webkit-tests: UnicodeDecodeError
1469         https://bugs.webkit.org/show_bug.cgi?id=41589
1470
1471         * run() method can result non-utf-8 bytes, that causes utf-8
1472           decoding fail.  Fixed to disable decoding.
1473         * Fixed Git.find_checkout_root() to make a test pass.
1474
1475         * Scripts/webkitpy/common/checkout/scm.py:
1476         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1477
1478 2010-07-03  Patrick Gansterer  <paroga@paroga.com>
1479
1480         Reviewed by Simon Hausmann.
1481
1482         [Qt] Fix DumpRenderTree userStyleSheet handling.
1483         https://bugs.webkit.org/show_bug.cgi?id=41570
1484
1485         DumpRenderTree did only set the userStyleSheet at
1486         layoutTestController.setUserStyleSheetEnabled().
1487
1488         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1489         (LayoutTestController::reset):
1490         (LayoutTestController::setUserStyleSheetLocation):
1491         (LayoutTestController::setUserStyleSheetEnabled):
1492         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1493
1494 2010-07-03  Robert Hogan  <robert@webkit.org>
1495
1496         Reviewed by Kenneth Rohde Christiansen.
1497
1498         [Qt] support dumpChildFrameScrollPositions
1499
1500         https://bugs.webkit.org/show_bug.cgi?id=41088
1501
1502         Unskip:
1503
1504         http/tests/navigation/anchor-subframeload.html
1505         http/tests/navigation/relativeanchor-frames.html
1506
1507         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1508         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
1509         (WebCore::DumpRenderTree::dump):
1510         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1511         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1512         (LayoutTestController::reset):
1513         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1514         (LayoutTestController::shouldDumpChildFrameScrollPositions):
1515         (LayoutTestController::dumpChildFrameScrollPositions):
1516
1517 2010-07-02  Sam Weinig  <sam@webkit.org>
1518
1519         Reviewed by Anders Carlsson.
1520
1521         Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.
1522
1523         * Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
1524         * Scripts/debug-webkittestrunner: Removed.
1525         * Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
1526         * Scripts/run-webkittestrunner: Removed.
1527
1528 2010-07-02  Brian Weinstein  <bweinstein@apple.com>
1529
1530         Reviewed by Steve Falkenburg.
1531
1532         Some http tests fail on Windows with Cygwin 1.7
1533         https://bugs.webkit.org/show_bug.cgi?id=41537
1534         
1535         With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/
1536         doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
1537         just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup.
1538
1539         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1540         (resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if 
1541             SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work.
1542
1543 2010-06-23  Martin Robinson  <mrobinson@igalia.com>
1544
1545         Reviewed by Gustavo Noronha Silva.
1546
1547         [GTK] Separate DerivedSources per-project
1548         https://bugs.webkit.org/show_bug.cgi?id=41109
1549
1550         The JavaScriptCore cppflags used to include the top-level DerivedSources directory
1551         allowing the tools to build as a side-effect. Now that the top-level directory
1552         is no longer in the list of JavaScriptCore includes, include it explicitly.
1553
1554         * GNUmakefile.am:
1555
1556 2010-07-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1557
1558         Reviewed by Kenneth Rohde Christiansen.
1559
1560         [Qt] Make context menus show up in the right place in QTestBrowser
1561
1562         Context menus were shown at scene-relative coordinates for
1563         QGraphicsWebView while QMenu expects them to be global. The
1564         change to the QWidget case was to get rid of the mapToGlobal.
1565
1566         * QtTestBrowser/webview.cpp:
1567
1568 2010-07-01  Robert Hogan <robert@webkit.org>
1569
1570         Reviewed by Kenneth Rohde Christiansen.
1571
1572         [Qt] dump frames in ascending alphabetical order of title
1573
1574         https://bugs.webkit.org/show_bug.cgi?id=41261
1575
1576         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1577         (WebCore::dumpHistoryItem):
1578
1579 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1580
1581         Unreviewed. 
1582
1583         Fix the GTK+ build after r62278.
1584
1585         * Scripts/webkitdirs.pm: If the make arguments have already been specified,
1586         let them override the automatic CPU detection for autotools builds.
1587
1588 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1589
1590         Unreviewed.
1591
1592         Fix the Windows build after r62278.
1593
1594         * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
1595
1596 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1597
1598         Reviewed by Gustavo Noronha Silva.
1599
1600         [GTK] build-webkit does not detect the number of CPUs
1601         https://bugs.webkit.org/show_bug.cgi?id=41469
1602
1603         Pass the appropriate -j<#> flag to make when building autotools builds.
1604         This causes make to spawn that many number of child processes for doing
1605         parallel builds.
1606
1607         * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number
1608         of CPUs. This makes the script work across more platforms.
1609         * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the
1610         number of CPUs across several platforms. Use this new function to determine the appropriate
1611         arguments to pass to make for doing parallel builds with autotools build files.
1612
1613 2010-07-01  Simon Hausmann  <simon.hausmann@nokia.com>
1614
1615         Rubber-stamped by Laszlo Gombos.
1616
1617         [Qt][Symbian] Bumped up the maximum heap size to 96MB
1618
1619         * QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration
1620         and use the one from WebKit.pri instead.
1621
1622 2010-07-01  Adam Barth  <abarth@webkit.org>
1623
1624         Reviewed by Eric Seidel.
1625
1626         Promote webkit-patch land-safely to main help
1627         https://bugs.webkit.org/show_bug.cgi?id=41446
1628
1629         I've been using this command a bunch and recommending it to folks.  We
1630         should show it in main help as it's past the experimental phase.
1631
1632         * Scripts/webkitpy/tool/commands/upload.py:
1633
1634 2010-06-28  MORITA Hajime  <morrita@google.com>
1635
1636         Reviewed by Shinichiro Hamaji.
1637
1638         rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
1639         https://bugs.webkit.org/show_bug.cgi?id=38775
1640
1641         - Introduced SCM.show_head() and SCM.diff_for_file().
1642         - Replaced direct svn invocations with newly implement SCM methods.
1643
1644         * Scripts/webkitpy/common/checkout/scm.py:
1645         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1646         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1647
1648 2010-06-30  Simon Fraser  <simon.fraser@apple.com>
1649
1650         Reviewed by Sam Weinig.
1651
1652         Allow MiniBrowser to open local files
1653         https://bugs.webkit.org/show_bug.cgi?id=41104
1654
1655         Wire up the openDocument: message with an NSOpenPanel, so we can open
1656         local files.
1657         
1658         Also change the xib so that the window remembers its size.
1659         
1660         * MiniBrowser/mac/AppDelegate.m:
1661         (-[BrowserAppDelegate frontmostBrowserWindowController]):
1662         (-[BrowserAppDelegate openDocument:]):
1663         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
1664         * MiniBrowser/mac/English.lproj/BrowserWindow.xib:
1665
1666 2010-06-30  Sam Weinig  <sam@webkit.org>
1667
1668         Rubber-stamped by Anders Carlsson.
1669
1670         Add debug-webkittestrunner and cleanup related scripts.
1671
1672         * Scripts/debug-webkittestrunner: Added.
1673         * Scripts/run-webkittestrunner:
1674         * Scripts/webkitdirs.pm:
1675
1676 2010-06-30  Kevin Ollivier  <kevino@theolliviers.com>
1677
1678         [wx] Build fix after recent changes to LayoutTestController.
1679
1680         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1681         (LayoutTestController::pageSizeAndMarginsInPixels):
1682
1683 2010-06-29  Sam Weinig  <sam@webkit.org>
1684
1685         Reviewed by Anders Carlsson.
1686
1687         Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
1688         Make WebKitTestRunner work with more than one test at a time.
1689
1690         This converts WebKitTestRunner to a similar model as DumpRenderTree,
1691         where there is a single WKView and each test is run it, rather than
1692         the design I was using where each test got its own WKView.
1693
1694         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1695         (WTR::InjectedBundle::didRecieveMessage):
1696         (WTR::InjectedBundle::reset):
1697         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1698         * WebKitTestRunner/TestController.cpp:
1699         (WTR::TestController::initialize):
1700         (WTR::TestController::runTest):
1701         (WTR::TestController::_didRecieveMessageFromInjectedBundle):
1702         (WTR::TestController::didRecieveMessageFromInjectedBundle):
1703         * WebKitTestRunner/TestController.h:
1704         (WTR::TestController::mainWebView):
1705         (WTR::TestController::pageNamespace):
1706         (WTR::TestController::context):
1707         * WebKitTestRunner/TestInvocation.cpp:
1708         (WTR::TestInvocation::TestInvocation):
1709         (WTR::TestInvocation::~TestInvocation):
1710         (WTR::TestInvocation::invoke):
1711         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1712         * WebKitTestRunner/TestInvocation.h:
1713
1714 2010-06-30  Simon Hausmann  <simon.hausmann@nokia.com>
1715
1716         Reviewed by Laszlo Gombos.
1717
1718         [Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
1719         https://bugs.webkit.org/show_bug.cgi?id=40446
1720
1721         We quickly run out of memory on Symbian when loading web pages. This is
1722         caused by the default heap size, which is not suited for a web browser.
1723
1724         This change bumps the max heap size to 32MB.
1725
1726         * QtTestBrowser/QtTestBrowser.pro:
1727
1728 2010-06-30  Eric Seidel  <eric@webkit.org>
1729
1730         Reviewed by Adam Barth.
1731
1732         webkit-patch land allow the user to continue even if the builders are red
1733         https://bugs.webkit.org/show_bug.cgi?id=41395
1734
1735         I don't think it's good that we've been teaching people
1736         to always pass --ignore-builders.  At least land is now
1737         useable w/o --ignore-builders.
1738
1739         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1740
1741 2010-06-29  Robert Hogan  <robert@webkit.org>
1742
1743         Reviewed by Kenneth Rohde Christiansen.
1744
1745         [Qt] support dumpResourceResponseMIMETypes
1746         https://bugs.webkit.org/show_bug.cgi?id=41260
1747
1748         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1749         (LayoutTestController::reset):
1750         (LayoutTestController::dumpResourceResponseMIMETypes):
1751         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1752
1753 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1754
1755         Reviewed by Kenneth Rohde Christiansen.
1756
1757         [Qt] Resize scene when Qt DRT WebPage receives a geometry change request
1758         https://bugs.webkit.org/show_bug.cgi?id=41173
1759
1760         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1761         (WebCore::WebPage::setViewGeometry):
1762         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1763
1764 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1765
1766         Reviewed by Simon Hausmann.
1767
1768         [Qt] Deal with postEvent in case of graphics based DRT
1769         https://bugs.webkit.org/show_bug.cgi?id=41174
1770
1771         QGraphicsScene does not have a postEvent method, so make scene
1772         send the event, in case of graphics based DRT, and delete it after that.
1773
1774         * DumpRenderTree/qt/EventSenderQt.cpp:
1775         (EventSender::scheduleAsynchronousClick):
1776         (EventSender::replaySavedEvents):
1777         (EventSender::postEvent):
1778         * DumpRenderTree/qt/EventSenderQt.h:
1779
1780 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1781
1782         Reviewed by Kenneth Rohde Christiansen.
1783
1784         [Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
1785         https://bugs.webkit.org/show_bug.cgi?id=41172
1786
1787         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1788         (WebCore::DumpRenderTree::switchFocus):
1789
1790 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1791
1792         Reviewed by Xan Lopez.
1793
1794         [Gtk] Make DRT more coherent with other ports to allow reusing more tests
1795         https://bugs.webkit.org/show_bug.cgi?id=40009
1796
1797         Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
1798         are used when returning those values, for coherency with other ports.
1799
1800         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1801         (AccessibilityUIElement::role):
1802         (AccessibilityUIElement::title):
1803         (AccessibilityUIElement::description):
1804
1805 2010-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1806
1807         Unreviewed, rolling out r62106.
1808         http://trac.webkit.org/changeset/62106
1809         https://bugs.webkit.org/show_bug.cgi?id=41346
1810
1811         "Broke editing tests" (Requested by xan_ on #webkit).
1812
1813         * Scripts/old-run-webkit-tests:
1814
1815 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1816
1817         Reviewed by Xan Lopez.
1818
1819         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
1820         https://bugs.webkit.org/show_bug.cgi?id=38648
1821
1822         Add the GTK_MODULES envvar (set to "gail") to the clean
1823         environment when running DRT for the Gtk+ port
1824
1825         * Scripts/old-run-webkit-tests:
1826
1827 2010-06-28  Adam Barth  <abarth@webkit.org>
1828
1829         Unreviewed.
1830
1831         Switch test-html5-parser back to using runner.html.
1832
1833         * Scripts/test-html5-parser:
1834
1835 2010-06-28  Adam Barth  <abarth@webkit.org>
1836
1837         Reviewed by Eric Seidel.
1838
1839         Restore webkit-runner.html for use with new tree builder
1840         https://bugs.webkit.org/show_bug.cgi?id=41317
1841
1842         For now, we just want to run webkit-runner when we test-html5-parser.
1843
1844         * Scripts/test-html5-parser:
1845
1846 2010-06-23  John Gregg  <johnnyg@google.com>
1847
1848         Reviewed by Kent Tamura.
1849
1850         add ENABLE_DIRECTORY_UPLOAD build support
1851         https://bugs.webkit.org/show_bug.cgi?id=41100
1852
1853         * Scripts/build-webkit:
1854
1855 2010-06-28  Gustavo Noronha Silva  <gns@gnome.org>
1856
1857         Rubber-stamped by Xan Lopez.
1858
1859         Update webkitdirs's knowledge of our library's name.
1860
1861         * Scripts/webkitdirs.pm:
1862
1863 2010-06-28  Sam Weinig  <sam@webkit.org>
1864
1865         Reviewed by Anders Carlsson.
1866
1867         Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
1868         Build up WebKitTestRunner output in the InjectedBundle
1869
1870         Simplify WebKitTestRunner by building up the output in the InjectedBundle
1871         and sending it over postMessage when done, instead of using the async
1872         WKPageRenderTreeExternalRepresentation.
1873
1874         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1875         (WTR::InjectedBundle::done):
1876         (WTR::InjectedBundle::didRecieveMessage):
1877         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1878         (WTR::InjectedBundle::os):
1879         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1880         (WTR::WKStringToUTF8):
1881         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1882         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1883         * WebKitTestRunner/TestInvocation.cpp:
1884         (WTR::WKStringToUTF8):
1885         (WTR::TestInvocation::TestInvocation):
1886         (WTR::TestInvocation::invoke):
1887         (WTR::TestInvocation::initializeMainWebView):
1888         (WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
1889         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1890         * WebKitTestRunner/TestInvocation.h:
1891
1892 2010-06-28  Robert Hogan  <robert@webkit.org>
1893
1894         Unreviewed, rolling out r62021.
1895         http://trac.webkit.org/changeset/62021
1896         https://bugs.webkit.org/show_bug.cgi?id=41261
1897
1898         Broke http/navigation tests among other
1899
1900         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1901         (WebCore::DumpRenderTree::dumpFramesAsText):
1902
1903 2010-06-28  Sam Weinig  <sam@webkit.org>
1904
1905         Reviewed by Anders Carlsson.
1906
1907         Add run-webkittestrunner to run WebKitTestRunner with the appropriate
1908         environment.
1909
1910         * Scripts/run-webkittestrunner: Added.
1911         * Scripts/webkitdirs.pm:
1912
1913 2010-06-28  Robert Hogan  <robert@webkit.org>
1914
1915         Reviewed by Kenneth Rohde Christiansen.
1916
1917         [Qt] dump frames in ascending alphabetical order of title
1918
1919         https://bugs.webkit.org/show_bug.cgi?id=41261
1920
1921         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1922         (WebCore::DumpRenderTree::dumpFramesAsText):
1923
1924 2010-06-28  Robert Hogan  <robert@webkit.org>
1925
1926         Reviewed by Kenneth Rohde Christiansen.
1927
1928         [Qt] dump bf history of child windows
1929
1930         https://bugs.webkit.org/show_bug.cgi?id=41266
1931
1932         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1933         (WebCore::DumpRenderTree::dumpBackForwardList):
1934         (WebCore::DumpRenderTree::dump):
1935         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1936
1937 2010-06-28  Sam Weinig  <sam@webkit.org>
1938
1939         Reviewed by Anders Carlsson.
1940
1941         Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
1942         WebKit2: Add frame API for InjectedBundle code
1943
1944         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1945         (_didClearWindowForFrame):
1946
1947 2010-06-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1948
1949         Reviewed by Kenneth Rohde Christiansen.
1950
1951         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
1952         https://bugs.webkit.org/show_bug.cgi?id=38597
1953
1954         Fix behavior so reload button really acts as a load and a reload button.
1955
1956         * QtTestBrowser/mainwindow.cpp:
1957         (MainWindow::changeLocation):
1958
1959 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1960
1961         Reviewed by Gustavo Noronha.
1962
1963         [GTK] Does not compile with -DGSEAL_ENABLE
1964         https://bugs.webkit.org/show_bug.cgi?id=37851
1965
1966         Fix build with GSEAL enabled.
1967
1968         * DumpRenderTree/gtk/EventSender.cpp:
1969         (gtk_widget_get_window):
1970         (prepareMouseButtonEvent):
1971         (mouseMoveToCallback):
1972         (mouseWheelToCallback):
1973         (keyDownCallback):
1974
1975 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1976
1977         Reviewed by Gustavo Noronha.
1978
1979         [GTK] Add support for GTK+3
1980         https://bugs.webkit.org/show_bug.cgi?id=41253
1981
1982         Adapt build system for 3.x support.
1983
1984         * GNUmakefile.am:
1985
1986 2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1987
1988         Reviewed by Simon Hausmann.
1989
1990         [QT][S60] build-webkit scripts picks wrong make spec for windows build
1991         https://bugs.webkit.org/show_bug.cgi?id=41198
1992
1993         Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 
1994
1995         * Scripts/webkitdirs.pm:
1996         (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
1997
1998 2010-06-28  Eric Seidel  <eric@webkit.org>
1999
2000         Reviewed by Adam Barth.
2001
2002         Make it possible to test the new HTML5 TreeBuilder
2003         https://bugs.webkit.org/show_bug.cgi?id=41276
2004
2005         Adam was concerned that someone might make their port
2006         depend on this setting (I guess we had some trouble with that
2007         with the HTML5Parser setting), so I littered the code with warnings.
2008
2009         test-html5-parser now tests this code path.
2010
2011         * DumpRenderTree/mac/DumpRenderTree.mm:
2012         (resetDefaultsToConsistentValues):
2013         (initializeGlobalsFromCommandLineOptions):
2014         * Scripts/test-html5-parser:
2015
2016 2010-06-27  MORITA Hajime  <morrita@google.com>
2017
2018         Unreviewed. 
2019         
2020         Some never-called @staticmethods touched self. 
2021         Fixed it to replace these self with a class.
2022
2023         * Scripts/webkitpy/common/checkout/scm.py:
2024
2025 2010-06-27  MORITA Hajime  <morrita@google.com>
2026
2027         Unreviewed.
2028         
2029         Fixed exception raising syntax that is pointed out at
2030         https://bugs.webkit.org/show_bug.cgi?id=41153
2031
2032         * Scripts/webkitpy/common/checkout/scm.py:
2033         * Scripts/webkitpy/common/checkout/scm_unittest.py: 
2034           Removed a bad line that I accidentally checked-in at last revision.
2035
2036 2010-06-24  MORITA Hajime  <morrita@google.com>
2037
2038         Reviewed by Eric Seidel.
2039
2040         rebaseline-chromium-webkit-tests should add or remove files to local git repository
2041         https://bugs.webkit.org/show_bug.cgi?id=41153
2042
2043         - Added SCM.add() and SCM.remove()
2044         - Replaced "svn add" and "svn remove"
2045           rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
2046         - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py
2047           for debugging purpose.
2048
2049         * Scripts/webkitpy/common/checkout/scm.py:
2050         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2051         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2052
2053 2010-06-25  Yuzo Fujishima  <yuzo@google.com>
2054
2055         Reviewed by Shinichiro Hamaji.
2056
2057         Improve default value handling for page format properties.
2058         https://bugs.webkit.org/show_bug.cgi?id=41150
2059
2060         * DumpRenderTree/LayoutTestController.cpp:
2061         (parsePageNumber):
2062         (parsePageNumberSizeMarings):
2063         (pageSizeAndMarginsInPixelsCallback):
2064         (LayoutTestController::staticFunctions):
2065         * DumpRenderTree/LayoutTestController.h:
2066         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2067         (LayoutTestController::pageSizeAndMarginsInPixels):
2068         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2069         (LayoutTestController::pageSizeAndMarginsInPixels):
2070         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2071         (LayoutTestController::pageSizeAndMarginsInPixels):
2072
2073 2010-06-21  Robert Hogan  <robert@webkit.org>
2074
2075         Reviewed by Kenneth Rohde Christiansen.
2076
2077         [Qt] DRT Support for setCustomPolicyDelegate
2078
2079         https://bugs.webkit.org/show_bug.cgi?id=39564
2080
2081         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2082         (LayoutTestController::setCustomPolicyDelegate):
2083         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2084
2085 2010-06-26  Robert Hogan  <robert@webkit.org>
2086
2087         Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879
2088         
2089         Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
2090         exported.
2091
2092         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2093
2094 2010-06-26  Tony Gentilcore  <tonyg@chromium.org>
2095
2096         Reviewed by Dimitri Glazkov.
2097
2098         Add a build-webkit option for enabling Web Timing support.
2099         https://bugs.webkit.org/show_bug.cgi?id=38924
2100
2101         * Scripts/build-webkit:
2102
2103 2010-06-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2104
2105         Reviewed by Kenneth Rohde Christiansen.
2106
2107         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
2108         https://bugs.webkit.org/show_bug.cgi?id=38597
2109
2110         Make the reload button act as a load button as well.
2111
2112         * QtTestBrowser/mainwindow.cpp:
2113         (MainWindow::buildUI):
2114         (MainWindow::changeLocation):
2115
2116 2010-06-25  Prasad Tammana  <prasadt@chromium.org>
2117
2118         Reviewed by Dmitry Titov.
2119
2120         Add empty abortModal() method to all platforms.
2121         https://bugs.webkit.org/show_bug.cgi?id=40864
2122
2123         Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
2124         platform independent LayoutTestController code.  Without this change, layout tests using LayoutTestController tests
2125         that use abortModal will become mac specific which is not desirable.
2126
2127         * DumpRenderTree/LayoutTestController.cpp:
2128         (abortModalCallback):
2129         (LayoutTestController::staticFunctions):
2130         * DumpRenderTree/LayoutTestController.h:
2131         * DumpRenderTree/chromium/LayoutTestController.cpp:
2132         (LayoutTestController::LayoutTestController):
2133         (LayoutTestController::abortModal):
2134         * DumpRenderTree/chromium/LayoutTestController.h:
2135         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2136         (LayoutTestController::abortModal):
2137         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2138         (LayoutTestController::abortModal):
2139         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2140         (LayoutTestController::abortModal):
2141         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2142         (LayoutTestController::abortModal):
2143
2144 2010-06-25  Sam Weinig  <sam@webkit.org>
2145
2146         Reviewed by Anders Carlsson.
2147
2148         Patch for https://bugs.webkit.org/show_bug.cgi?id=41226
2149         Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.
2150
2151         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.
2152         (WTR::InjectedBundle::shared):
2153         (WTR::InjectedBundle::InjectedBundle):
2154         (WTR::InjectedBundle::_didCreatePage):
2155         (WTR::InjectedBundle::_willDestroyPage):
2156         (WTR::InjectedBundle::_didRecieveMessage):
2157         (WTR::InjectedBundle::initialize):
2158         (WTR::InjectedBundle::didCreatePage):
2159         (WTR::InjectedBundle::willDestroyPage):
2160         (WTR::InjectedBundle::didRecieveMessage):
2161         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.
2162         (WTR::InjectedBundle::layoutTestController):
2163         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2164         (WKBundleInitialize):
2165         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.
2166         (WTR::InjectedBundlePage::InjectedBundlePage):
2167         (WTR::InjectedBundlePage::~InjectedBundlePage):
2168         (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
2169         (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
2170         (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
2171         (WTR::InjectedBundlePage::_didCommitLoadForFrame):
2172         (WTR::InjectedBundlePage::_didFinishLoadForFrame):
2173         (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
2174         (WTR::InjectedBundlePage::_didReceiveTitleForFrame):
2175         (WTR::InjectedBundlePage::_didClearWindowForFrame):
2176         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2177         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2178         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2179         (WTR::InjectedBundlePage::didCommitLoadForFrame):
2180         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2181         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2182         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2183         (WTR::InjectedBundlePage::didClearWindowForFrame):
2184         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.
2185         (WTR::InjectedBundlePage::page):
2186         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.
2187         (WTR::LayoutTestController::create):
2188         (WTR::LayoutTestController::LayoutTestController):
2189         (WTR::LayoutTestController::~LayoutTestController):
2190         (WTR::dumpAsTextCallback):
2191         (WTR::layoutTestControllerObjectFinalize):
2192         (WTR::LayoutTestController::makeWindowObject):
2193         (WTR::LayoutTestController::getJSClass):
2194         (WTR::LayoutTestController::staticFunctions):
2195         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.
2196         (WTR::LayoutTestController::dumpAsText):
2197         (WTR::LayoutTestController::setDumpAsText):
2198         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2199
2200 2010-06-25  Sam Weinig  <sam@webkit.org>
2201
2202         Reviewed by Anders Carlsson.
2203
2204         Make WebKitTestRunner really work with run-webkit-tests. 
2205
2206         - Add Forwarding headers to allow some cleanup.
2207
2208         * WebKitTestRunner/ForwardingHeaders: Added.
2209         * WebKitTestRunner/ForwardingHeaders/wtf: Added.
2210         * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
2211         * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
2212         * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
2213         * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
2214         * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
2215         * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
2216         * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
2217         * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
2218         * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
2219         * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
2220         * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
2221         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
2222         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
2223         * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
2224         * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
2225         * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
2226         * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
2227         * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
2228         * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
2229         * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
2230         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
2231         * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
2232         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
2233         * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
2234         * WebKitTestRunner/TestInvocation.cpp:
2235         (WTR::TestInvocation::dump): Dump the right number of #EOFs.
2236         * WebKitTestRunner/TestInvocation.h:
2237
2238 2010-06-25  Sam Weinig  <sam@webkit.org>
2239
2240         Reviewed by Mark Rowe.
2241
2242         Add support for WebKitTestRunner to old-run-webkit-tests
2243
2244         - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
2245
2246         * Scripts/build-webkittestrunner: Added.
2247         * Scripts/old-run-webkit-tests:
2248
2249 2010-06-25  Adam Barth  <abarth@webkit.org>
2250
2251         Reviewed by David Levin.
2252
2253         Incremental build failed on Chromium ews
2254         https://bugs.webkit.org/show_bug.cgi?id=41011
2255
2256         The division of responsibility between update-webkit --chromium and
2257         build-webkit --chromium is slightly unclear.  In this patch, we make
2258         build-webkit --chromium also update DEPS and re-run GYP in case the
2259         developer has changed either since they updated.
2260
2261         This change is also helpful for the EWS, which wants to update DEPS and
2262         re-run GYP after applying patches, but the EWS doesn't want to run
2263         update-webkit --chromium because it has a dirty working copy.
2264
2265         * Scripts/webkitdirs.pm:
2266
2267 2010-06-25  Robert Hogan  <robert@webkit.org>
2268
2269         Reviewed by Simon Hausmann.
2270
2271         [Qt] Support evaluateScriptInIsolatedWorld()
2272
2273         https://bugs.webkit.org/show_bug.cgi?id=40079
2274
2275         Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
2276         Remove QWebScriptWorld from exported headers.
2277         Confine support to DumpRenderTreeSupportQt so that the tests can pass.
2278
2279         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2280         (LayoutTestController::reset):
2281         (LayoutTestController::evaluateScriptInIsolatedWorld):
2282         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2283
2284 2010-06-25  Anders Carlsson  <andersca@apple.com>
2285
2286         Revert accidental part and add a newline.
2287
2288         * MiniBrowser/mac/AppDelegate.m:
2289         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2290
2291 2010-06-25  Anders Carlsson  <andersca@apple.com>
2292
2293         Rubber-stamped by Dan Bernstein.
2294
2295         Add a LOG macro that expands to a no-op by default.
2296
2297         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2298         * MiniBrowser/mac/AppDelegate.m:
2299         (_didRecieveMessageFromInjectedBundle):
2300         * MiniBrowser/mac/BrowserWindowController.m:
2301         (-[BrowserWindowController windowShouldClose:]):
2302         (_didStartProvisionalLoadForFrame):
2303         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2304         (_didFailProvisionalLoadWithErrorForFrame):
2305         (_didCommitLoadForFrame):
2306         (_didFinishLoadForFrame):
2307         (_didFailLoadWithErrorForFrame):
2308         (_didReceiveTitleForFrame):
2309         (_didFirstLayoutForFrame):
2310         (_didFirstVisuallyNonEmptyLayoutForFrame):
2311         (_didBecomeUnresponsive):
2312         (_didBecomeResponsive):
2313         (_decidePolicyForNavigationAction):
2314         (_decidePolicyForNewWindowAction):
2315         (_createNewPage):
2316         (_showPage):
2317         (_closePage):
2318         (_didNavigateWithNavigationData):
2319         (_didPerformClientRedirect):
2320         (_didPerformServerRedirect):
2321         (_didUpdateHistoryTitle):
2322         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2323         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2324         (_didClearWindowForFrame):
2325         (_didCreatePage):
2326         (_willDestroyPage):
2327         (_didRecieveMessage):
2328
2329 2010-06-24  Adam Barth  <abarth@webkit.org>
2330
2331         Reviewed by Eric Seidel.
2332
2333         commit-queue is taking too long to land patches because of red trees
2334         https://bugs.webkit.org/show_bug.cgi?id=41194
2335
2336         Instead of checking for the tree to be green, we'll just spin hot
2337         trying to land patches.  This is probably too extreme in ignoring the
2338         tree, but I think we should try it for a while to see if we have
2339         trouble.  That will help us find the right balance.
2340
2341         * Scripts/webkitpy/tool/commands/queues.py:
2342         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2343
2344 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2345
2346         Reviewed by Xan Lopez.
2347
2348         [GTK] Clean up the use of gdk_window_get_root_coords in EventSender
2349         https://bugs.webkit.org/show_bug.cgi?id=40843
2350
2351         Define the version for old GTK+s in a way that is forward-compatible
2352         and clean up the logic a bit.
2353
2354         * DumpRenderTree/gtk/EventSender.cpp:
2355         (gdk_window_get_root_coords): Renamed and cleaned up.
2356         (prepareMouseButtonEvent): Remove #ifdefs.
2357         (mouseMoveToCallback): Remove #ifdefs.
2358
2359 2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>
2360
2361         Reviewed by Eric Seidel.
2362
2363         Fix NewRunWebKitTests to work on Windows.
2364         https://bugs.webkit.org/show_bug.cgi?id=41180
2365
2366         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,
2367             because Windows fails to understand what we're asking of it.
2368
2369 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2370
2371         Reviewed by Xan Lopez.
2372
2373         [GTK] The url passed to the WebView during layout tests is invalid
2374         https://bugs.webkit.org/show_bug.cgi?id=40832
2375
2376         Set the test URL to the full real file URL and do a small cleanup.
2377         Previously a URL like file://relative/path/to/test.html was passed
2378         to the WebView. This malformed file URL would be returned by
2379         webkit_web_view_get_url and webkit_web_frame_get_url.
2380
2381         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2382         (shouldLogFrameLoadDelegates): Change to take a const string& as the argument.
2383         (shouldOpenWebInspector): Change to take a const string& as the argument.
2384         (shouldEnableDeveloperExtras): Change to take a const string& as the argument.
2385         (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable.
2386
2387 2010-06-24  Sam Weinig  <sam@webkit.org>
2388
2389         Reviewed by Anders Carlsson.
2390
2391         Fix WebKitTestRunner Makefile typos.
2392
2393         * WebKitTestRunner/Makefile:
2394
2395 2010-06-24  Adele Peterson  <adele@apple.com>
2396
2397         Reviewed by Eric Carlson.
2398
2399         DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
2400         https://bugs.webkit.org/show_bug.cgi?id=41085
2401
2402         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
2403         Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.
2404
2405 2010-06-23  Sam Weinig  <sam@webkit.org>
2406
2407         Reviewed by Anders Carlsson.
2408
2409         Patch for https://bugs.webkit.org/show_bug.cgi?id=41086
2410         Add new WebKitTestRunner project (ie. DRT for WebKit2).
2411
2412         - Mac only.
2413         - run-webkit-tests has not been modified to call it yet.
2414         - Only dumps the render tree at this time. 
2415
2416         * WebKitTestRunner: Added.
2417         * WebKitTestRunner/Configurations: Added.
2418         * WebKitTestRunner/Configurations/Base.xcconfig: Added.
2419         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
2420         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
2421         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
2422         * WebKitTestRunner/InjectedBundle: Added.
2423         * WebKitTestRunner/InjectedBundle-Info.plist: Added.
2424         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.
2425         (_didStartProvisionalLoadForFrame):
2426         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2427         (_didFailProvisionalLoadWithErrorForFrame):
2428         (_didCommitLoadForFrame):
2429         (_didFinishLoadForFrame):
2430         (_didFailLoadWithErrorForFrame):
2431         (_didReceiveTitleForFrame):
2432         (_didClearWindow):
2433         (_didCreatePage):
2434         (_willDestroyPage):
2435         (_didRecieveMessage):
2436         (WKBundleInitialize):
2437         * WebKitTestRunner/Makefile: Added.
2438         * WebKitTestRunner/PlatformWebView.h: Added.
2439         (WTR::PlatformWebView::platformView):
2440         * WebKitTestRunner/TestController.cpp: Added.
2441         (WTR::TestController::shared):
2442         (WTR::TestController::TestController):
2443         (WTR::TestController::initialize):
2444         (WTR::TestController::runTest):
2445         (WTR::TestController::runTestingServerLoop):
2446         (WTR::TestController::run):
2447         * WebKitTestRunner/TestController.h: Added.
2448         (WTR::TestController::verbose):
2449         (WTR::TestController::injectedBundlePath):
2450         * WebKitTestRunner/TestInvocation.cpp: Added.
2451         (WTR::createWKURL):
2452         (WTR::TestInvocation::TestInvocation):
2453         (WTR::TestInvocation::~TestInvocation):
2454         (WTR::TestInvocation::invoke):
2455         (WTR::TestInvocation::dump):
2456         (WTR::TestInvocation::initializeMainWebView):
2457         (WTR::TestInvocation::didStartProvisionalLoadForFrame):
2458         (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
2459         (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
2460         (WTR::TestInvocation::didCommitLoadForFrame):
2461         (WTR::TestInvocation::didFinishLoadForFrame):
2462         (WTR::TestInvocation::didFailLoadForFrame):
2463         (WTR::TestInvocation::renderTreeExternalRepresentationFunction):
2464         (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):
2465         * WebKitTestRunner/TestInvocation.h: Added.
2466         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
2467         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
2468         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
2469         * WebKitTestRunner/mac: Added.
2470         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.
2471         (WTR::PlatformWebView::PlatformWebView):
2472         (WTR::PlatformWebView::~PlatformWebView):
2473         (WTR::PlatformWebView::page):
2474         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
2475         (WTR::TestInvocation::runUntil):
2476         * WebKitTestRunner/mac/main.mm: Added.
2477         (main):
2478
2479 2010-06-24  Luiz Agostini  <luiz.agostini@openbossa.org>
2480
2481         Unreviewed. Adding myself to the committers list.
2482
2483         * Scripts/webkitpy/common/config/committers.py:
2484
2485 2010-06-23  Kevin Ollivier  <kevino@theolliviers.com>
2486
2487         [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.
2488
2489         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2490         (LayoutTestController::isPageBoxVisible):
2491         (LayoutTestController::pageAreaRectInPixels):
2492         (LayoutTestController::preferredPageSizeInPixels):
2493         * wx/build/settings.py:
2494
2495 2010-06-23  James Robinson  <jamesr@chromium.org>
2496
2497         Unreviewed.  Add my IRC handle to committers.py so the sheriffbot can yell at me.
2498
2499         * Scripts/webkitpy/common/config/committers.py:
2500
2501 2010-06-23  Kent Tamura  <tkent@chromium.org>
2502
2503         Reviewed by Dimitri Glazkov.
2504
2505         Correct Chromium test configuration
2506         https://bugs.webkit.org/show_bug.cgi?id=41057
2507
2508         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2509          - Add "--use-drt" option for NRWT. It is required for Chromium and
2510            ignored for other platforms.
2511          - Skip JSC test on Chromium
2512         * BuildSlaveSupport/test-result-archive:
2513           Add Chromium support.
2514
2515 2010-06-23  Sam Weinig  <sam@webkit.org>
2516
2517         Reviewed by Anders Carlsson.
2518
2519         Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
2520         WebKit2: Flesh out more of the InjectedBundle client API
2521
2522         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2523         (_didStartProvisionalLoadForFrame):
2524         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2525         (_didFailProvisionalLoadWithErrorForFrame):
2526         (_didCommitLoadForFrame):
2527         (_didFinishLoadForFrame):
2528         (_didFailLoadWithErrorForFrame):
2529         (_didReceiveTitleForFrame):
2530         (_didClearWindowForFrame):
2531         (_didCreatePage):
2532         (_willDestroyPage):
2533         (WKBundleInitialize):
2534
2535 2010-06-23  Yuzo Fujishima  <yuzo@google.com>
2536
2537         Reviewed by Shinichiro Hamaji.
2538
2539         Implement page format data programming interface.
2540         Add methods for testing.
2541         https://bugs.webkit.org/show_bug.cgi?id=37538
2542
2543         * DumpRenderTree/LayoutTestController.cpp:
2544         (parsePageNumber):
2545         (isPageBoxVisibleCallback):
2546         (pageAreaRectInPixelsCallback):
2547         (preferredPageSizeInPixelsCallback):
2548         (LayoutTestController::staticFunctions):
2549         * DumpRenderTree/LayoutTestController.h:
2550         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2551         (LayoutTestController::isPageBoxVisible):
2552         (LayoutTestController::pageAreaRectInPixels):
2553         (LayoutTestController::preferredPageSizeInPixels):
2554         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2555         (LayoutTestController::isPageBoxVisible):
2556         (LayoutTestController::pageAreaRectInPixels):
2557         (LayoutTestController::preferredPageSizeInPixels):
2558         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2559         (LayoutTestController::isPageBoxVisible):
2560         (LayoutTestController::pageAreaRectInPixels):
2561         (LayoutTestController::preferredPageSizeInPixels):
2562
2563 2010-06-23  Sam Magnuson  <smagnuson@netflix.com>
2564
2565         Reviewed by Shinichiro Hamaji.
2566
2567         Follow proper convention for if/switch/while as I've discovered
2568         them to be through my review processes.
2569         https://bugs.webkit.org/show_bug.cgi?id=40723
2570
2571         Modified test so that if( foo ) is not allowed as it appears not
2572         to be the accepted convention.
2573
2574         * Scripts/webkitpy/style/checkers/cpp.py:
2575         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2576
2577 2010-06-22  Eric Seidel  <eric@webkit.org>
2578
2579         Reviewed by Adam Barth.
2580
2581         Run clean-header-guards to fix some header guards
2582         https://bugs.webkit.org/show_bug.cgi?id=41044
2583
2584         No functional changes, thus no tests.
2585
2586         This entire change was generated by running
2587         clean-header-guards, and then reverting changes
2588         to files which shouldn't be changed.  Those which
2589         are left all should be updated.
2590
2591         Some of these changes are just fixing 755 permissions
2592         to be 644, since it seems various files have the wrong
2593         execute bit which don't need it.  clean-header-guards
2594         made those (welcome) permission fixes unintentionally.
2595
2596         * DumpRenderTree/chromium/WebThemeControlDRT.h:
2597         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2598         * QtTestBrowser/fpstimer.h:
2599
2600 2010-06-22  Adam Barth  <abarth@webkit.org>
2601
2602         Reviewed by Eric Seidel.
2603
2604         Rename HTMLDocumentParser to LegacyHTMLDocumentParser
2605         https://bugs.webkit.org/show_bug.cgi?id=41043
2606
2607         Update the hash.
2608
2609         * Scripts/do-webcore-rename:
2610
2611 2010-06-22  Sam Magnuson  <smagnuson@netflix.com>
2612
2613         Reviewed by Shinichiro Hamaji.
2614
2615         Follow proper convention for variable declaration spacing.
2616         https://bugs.webkit.org/show_bug.cgi?id=40724
2617
2618         Modified test so that 'int   a;' is not allowed.
2619
2620         * Scripts/webkitpy/style/checkers/cpp.py:
2621         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2622
2623 2010-06-22  Eric Seidel  <eric@webkit.org>
2624
2625         Unreviewed.  Add Tony Gentilcore now that he's a committer.
2626
2627         * Scripts/webkitpy/common/config/committers.py:
2628
2629 2010-06-22  Eric Seidel  <eric@webkit.org>
2630
2631         Reviewed by Adam Barth.
2632
2633         Remove Gtk 64-Release bot from core since it's broken
2634         https://bugs.webkit.org/show_bug.cgi?id=41022
2635
2636         This bot alone has been responsible for more than 72 hours of
2637         commit-queue blockage in the last week.  The bot is broken -- keeps
2638         losing its display server or similar.  Until the Gtk folks can fix the
2639         bot, we need to remove it from core.  The WebKit community can't keep
2640         it green as is.
2641
2642         * Scripts/webkitpy/common/net/buildbot.py:
2643         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2644
2645 2010-06-21  Dumitru Daniliuc  <dumi@chromium.org>
2646
2647         Reviewed by Eric Seidel.
2648
2649         Fix the Windows build.
2650         https://bugs.webkit.org/show_bug.cgi?id=40972
2651
2652         * DumpRenderTree/win/ImageDiff.vcproj:
2653
2654 2010-06-21  Prasad Tammana  <prasadt@chromium.org>
2655
2656         Reviewed by Darin Adler, Dmitry Titov.
2657
2658         DumpRenderTree should allow tests with modal dialogs
2659         https://bugs.webkit.org/show_bug.cgi?id=35350
2660
2661         * DumpRenderTree/LayoutTestController.cpp:
2662         (abortModalCallback):
2663         (LayoutTestController::staticFunctions):
2664         * DumpRenderTree/LayoutTestController.h:
2665         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2666         (LayoutTestController::abortModal):
2667         Add abortModal method to LayoutTestController and make it available from script.
2668
2669         * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.
2670         (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
2671         abortModal from when modal window closes.
2672         (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.
2673
2674 2010-06-21  Simon Fraser  <simon.fraser@apple.com>
2675
2676         Reviewed by Anders Carlsson.
2677         
2678         Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
2679         https://bugs.webkit.org/show_bug.cgi?id=40948
2680         
2681         Have the script look in WebKit2.
2682
2683         * Scripts/do-webcore-rename:
2684
2685 2010-06-21  Robert Hogan  <robert@webkit.org>
2686
2687         Reviewed by Kenneth Rohde Christiansen.
2688
2689         [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html
2690
2691         It's a Mac-specific test so just add the required LayoutTestController
2692         function as a no-op to avoid failing. Similar approach adopted by other
2693         ports.
2694
2695         https://bugs.webkit.org/show_bug.cgi?id=33344
2696
2697         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2698         (LayoutTestController::addDisallowedURL):
2699
2700 2010-06-21  Sam Weinig  <sam@webkit.org>
2701
2702         Reviewed by Anders Carlsson.
2703
2704         Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
2705         Add message passing support to the WebKit2 API.
2706
2707         - Add some test messages.
2708
2709         * MiniBrowser/mac/AppDelegate.m:
2710         (_didRecieveMessageFromInjectedBundle):
2711         (-[BrowserAppDelegate init]):
2712         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2713         (_didClearWindow):
2714         (_didCreatePage):
2715         (_didRecieveMessage):
2716         (WKBundleInitialize):
2717
2718 2010-06-21  Drew Wilson  <atwilson@chromium.org>
2719
2720         Unreviewed.
2721
2722         Rolling back 61551 and 61555 due to test failures.
2723
2724         * DumpRenderTree/LayoutTestController.cpp:
2725         (LayoutTestController::staticFunctions):
2726         * DumpRenderTree/LayoutTestController.h:
2727         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2728         (LayoutTestController::setEditingBehavior):
2729         * DumpRenderTree/mac/UIDelegate.mm:
2730
2731 2010-06-21  Anders Carlsson  <andersca@apple.com>
2732
2733         Reviewed by Sam Weinig.
2734
2735         Make DumpRenderTree build with clang++
2736
2737         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2738         (-[LocalPasteboard setPropertyList:forType:]):
2739         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2740         (-[DumpRenderTreeWindow keyDown:]):
2741         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2742         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2743         (LayoutTestController::isCommandEnabled):
2744
2745 2010-06-21  Satish Sampath  <satish@chromium.org>
2746
2747         Reviewed by Steve Block.
2748
2749         Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
2750         https://bugs.webkit.org/show_bug.cgi?id=40878
2751
2752         * Scripts/build-webkit:
2753
2754 2010-06-21  Kent Tamura  <tkent@chromium.org>
2755
2756         Reviewed by Dimitri Glazkov.
2757
2758         [DRT/Chromium] Initialization for http/tests/loading/
2759         https://bugs.webkit.org/show_bug.cgi?id=40902
2760
2761         * DumpRenderTree/chromium/TestShell.cpp:
2762         (TestShell::runFileTest):
2763
2764 2010-06-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2765
2766         Unreviewed.
2767
2768         Adding myself to the committers list.
2769
2770         * Scripts/webkitpy/common/config/committers.py:
2771
2772 2010-06-20  Kent Tamura  <tkent@chromium.org>
2773
2774         Reviewed by Dimitri Glazkov.
2775
2776         [DRT/Chromium] Add --allow-external-pages option
2777         https://bugs.webkit.org/show_bug.cgi?id=40762
2778
2779         Add --allow-external-pages introduced by Chromium r45403.
2780         http://src.chromium.org/viewvc/chrome?view=rev&revision=45403
2781
2782         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2783         (main):
2784         * DumpRenderTree/chromium/TestShell.cpp:
2785         (TestShell::TestShell):
2786         * DumpRenderTree/chromium/TestShell.h:
2787         (TestShell::allowExternalPages):
2788         (TestShell::setAllowExternalPages):
2789         * DumpRenderTree/chromium/WebViewHost.cpp:
2790         (WebViewHost::willSendRequest):
2791
2792 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2793
2794         Reviewed by Adam Barth.
2795
2796         Sheriffbot: Should allow "r" in SVN_REVISION
2797         https://bugs.webkit.org/show_bug.cgi?id=40889
2798
2799         * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
2800         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
2801
2802 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2803
2804         Reviewed by Dimitri Glazkov.
2805
2806         Python Tests Fail after r61508
2807         https://bugs.webkit.org/show_bug.cgi?id=40891
2808
2809         Test's regex list needed to be updated to match the new
2810         regex list in the source code. Added new bots to the
2811         example_buildbots list.
2812
2813         Regex list fixed in r61512. Updated bot list.
2814
2815         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2816
2817 2010-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
2818
2819         Unreviewed, build fix.
2820
2821         Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.
2822
2823         * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
2824
2825 2010-06-19  Justin Schuh  <jschuh@chromium.org>
2826
2827         Unreviewed.
2828
2829         Adding myself to the committers list.
2830
2831         * Scripts/webkitpy/common/config/committers.py:
2832
2833 2010-06-19  Sam Weinig  <sam@webkit.org>
2834
2835         Reviewed by Anders Carlsson.
2836
2837         Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
2838         Add ability to have a WebProcess per WebContext.
2839
2840         Move to use new shared contexts API.
2841
2842         * MiniBrowser/mac/AppDelegate.h:
2843         * MiniBrowser/mac/AppDelegate.m:
2844         (-[BrowserAppDelegate init]):
2845         (-[BrowserAppDelegate getCurrentPageNamespace]):
2846         (-[BrowserAppDelegate validateMenuItem:]):
2847         (-[BrowserAppDelegate _setProcessModel:]):
2848         (-[BrowserAppDelegate setSharedProcessProcessModel:]):
2849         (-[BrowserAppDelegate setSharedThreadProcessModel:]):
2850         * MiniBrowser/win/BrowserView.cpp:
2851         (BrowserView::create):
2852
2853 2010-06-02  Robert Hogan  <robert@webkit.org>
2854
2855         Reviewed by Adam Barth.
2856
2857         [Qt] Support evaluateScriptInIsolatedWorld()
2858
2859         https://bugs.webkit.org/show_bug.cgi?id=40079
2860
2861         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2862         (LayoutTestController::evaluateScriptInIsolatedWorld):
2863         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2864
2865 2010-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
2866
2867         Reviewed by Darin Adler.
2868
2869         Add three more non-core Chromium builders to start testing DumpRenderTree.
2870         https://bugs.webkit.org/show_bug.cgi?id=40335
2871
2872         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
2873
2874 2010-06-18  Drew Wilson  <atwilson@chromium.org>
2875
2876         Reviewed by Darin Fisher.
2877
2878         [Chromium] Plumbing for top-level frame names
2879         https://bugs.webkit.org/show_bug.cgi?id=40430
2880
2881         * DumpRenderTree/chromium/WebViewHost.cpp:
2882         (WebViewHost::reset):
2883         Changed obsolete call to clearName() to use setName(WebString()) instead.
2884
2885 2010-06-18  Sam Weinig  <weinig@apple.com>
2886
2887         Rolling http://trac.webkit.org/changeset/61297 back in.
2888
2889         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2890         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
2891         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
2892         (_didClearWindow):
2893         (_didCreatePage):
2894         (WKBundleInitialize):
2895
2896 2010-06-18  Alexey Proskuryakov  <ap@apple.com>
2897
2898         Reviewed by Darin Adler.
2899
2900         https://bugs.webkit.org/show_bug.cgi?id=40803
2901         TestNetscapePlugin has an incorrect implementation of "property" property
2902
2903         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
2904         pass a static string back, it's going to be released by NPAPI implementation.
2905
2906 2010-06-18  Leandro Pereira  <leandro@profusion.mobi>
2907
2908         Unreviewed.
2909
2910         Adding myself to the committers list.
2911
2912         * Scripts/webkitpy/common/config/committers.py:
2913
2914 2010-06-17  Tony Chang  <tony@chromium.org>
2915
2916         Reviewed by Kent Tamura.
2917
2918         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
2919         https://bugs.webkit.org/show_bug.cgi?id=40615
2920
2921         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
2922
2923 2010-06-17  Ada Chan  <adachan@apple.com>
2924
2925         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
2926
2927         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2928         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
2929         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2930
2931 2010-06-17  Darin Adler  <darin@apple.com>
2932
2933         One more try at fix for Chromium build.
2934
2935         * DumpRenderTree/chromium/TestShell.cpp:
2936         (TestShell::TestShell): Use set again instead of =.
2937
2938 2010-06-17  Darin Adler  <darin@apple.com>
2939
2940         Fix Chromium build.
2941
2942         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
2943         code with all the other platforms! Wow, that should be fixed at some point.
2944
2945         * DumpRenderTree/chromium/TestShell.cpp:
2946         (TestShell::TestShell): Changed back to using "new".
2947         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
2948
2949 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
2950
2951         Unreviewed Qt build fix.
2952
2953         LayoutTestController in the Qt DRT is not using refs :)
2954
2955         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2956         (WebCore::DumpRenderTree::DumpRenderTree):
2957
2958 2010-06-17  Darin Adler  <darin@apple.com>
2959
2960         Reviewed by Sam Weinig.
2961
2962         Use adoptRef and create functions in more code paths
2963         https://bugs.webkit.org/show_bug.cgi?id=40760
2964
2965         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
2966
2967         * DumpRenderTree/LayoutTestController.cpp:
2968         (LayoutTestController::create): Added.
2969         * DumpRenderTree/LayoutTestController.h: Declare the create function.
2970
2971         * DumpRenderTree/chromium/TestShell.cpp:
2972         (TestShell::TestShell): Use create instead of new.
2973         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
2974
2975         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2976         (runTest): Use RefPtr and create instead of OwnPtr and new.
2977
2978         * DumpRenderTree/mac/DumpRenderTree.mm:
2979         (runTest): Use RefPtr and create instead of OwnPtr and new.
2980
2981         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2982         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
2983         instead of new.
2984
2985         * DumpRenderTree/win/DumpRenderTree.cpp:
2986         (runTest): Use RefPtr and create instead of OwnPtr and new.
2987
2988         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2989         (runTest): Use RefPtr and create instead of OwnPtr and new.
2990         (MyApp::OnInit): Removed unneeded code to delete the layout
2991         test controller. This is done during each test.
2992
2993 2010-06-17  Kent Tamura  <tkent@chromium.org>
2994
2995         Reviewed by Shinichiro Hamaji.
2996
2997         [DRT/Chromium] Fix a bug of Windows pixel tests
2998         https://bugs.webkit.org/show_bug.cgi?id=40763
2999
3000         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3001         (TestShellPrinter::handleImage):
3002
3003 2010-06-16  Kent Tamura  <tkent@chromium.org>
3004
3005         Reviewed by Shinichiro Hamaji.
3006
3007         [DRT/Chromium] Fix crash on Mac Release
3008         https://bugs.webkit.org/show_bug.cgi?id=40759
3009
3010         * DumpRenderTree/chromium/WebViewHost.cpp:
3011         (WebViewHost::paintRect): We should not use m_canvas directly because
3012           it is created lazily in canvas().
3013
3014 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
3015
3016         [wx] Build fix after new method addition.
3017
3018         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3019         (LayoutTestController::pageProperty):
3020
3021 2010-06-16  Kent Tamura  <tkent@chromium.org>
3022
3023         Reviewed by Dimitri Glazkov.
3024
3025         [DRT/Chromium] Set current working directory for each of tests
3026         https://bugs.webkit.org/show_bug.cgi?id=40668
3027
3028         This change fixes tests with eventSender.beginDragWithFiles().
3029
3030         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3031         (runTest):
3032
3033 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
3034
3035         Reviewed by Gustavo Noronha Silva.
3036
3037         [GTK] r60803 broke media/controls-drag-timebar.html
3038         https://bugs.webkit.org/show_bug.cgi?id=40269
3039
3040         Only queue events while the mouse button is down, if drag mode is enabled. Some
3041         tests may disable drag mode, to prevent the queuing of events in this situation.
3042
3043         * DumpRenderTree/gtk/EventSender.cpp:
3044         (sendOrQueueEvent): Only queue events here if dragMode is true.
3045
3046 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
3047
3048         Reviewed by Gustavo Noronha Silva.
3049
3050         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
3051         https://bugs.webkit.org/show_bug.cgi?id=40600
3052
3053         * DumpRenderTree/gtk/EventSender.cpp:
3054         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
3055
3056 2010-06-16  Adam Barth  <abarth@webkit.org>
3057
3058         Reviewed by Dimitri Glazkov.
3059
3060         Add a hidden land-cowboy command to webkit-patch to help land quick
3061         build fixes.
3062
3063         * Scripts/webkitpy/tool/commands/download.py:
3064         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3065
3066 2010-06-16  Adam Roben  <aroben@apple.com>
3067
3068         Convert console messages to UTF-8 before printing them
3069
3070         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
3071         http/tests/security/xssAuditor/embed-tag-null-char.html and
3072         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
3073         Windows. (I can't test the fix because Apache is crashing on my
3074         computer.)
3075
3076         Reviewed by Alexey Proskuryakov.
3077
3078         * DumpRenderTree/win/DumpRenderTree.cpp:
3079         (toUTF8): Extracted the code into an overload that takes a wide string
3080         and a length, then added an overload that takes a wstring.
3081
3082         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
3083         overload.
3084
3085         * DumpRenderTree/win/UIDelegate.cpp:
3086         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
3087         UTF-8 instead of letting printf convert to the current code page.
3088
3089 2010-06-16  Drew Wilson  <atwilson@chromium.org>
3090
3091         Reviewed by Kent Tamura.
3092
3093         [Chromium] Plumbing for top-level frame names
3094         https://bugs.webkit.org/show_bug.cgi?id=40430
3095
3096         * DumpRenderTree/chromium/WebViewHost.cpp:
3097         (WebViewHost::createView):
3098         Migrate to new createView() API.
3099         * DumpRenderTree/chromium/WebViewHost.h:
3100         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
3101
3102 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
3103
3104         Reviewed by Kenneth Rohde Christiansen.
3105
3106         [Qt] Scroll wheel event support to graphics based DRT
3107         https://bugs.webkit.org/show_bug.cgi?id=40577
3108
3109         * DumpRenderTree/qt/EventSenderQt.cpp:
3110         (EventSender::continuousMouseScrollBy):
3111         (EventSender::createGraphicsSceneWheelEvent):
3112         * DumpRenderTree/qt/EventSenderQt.h:
3113
3114 2010-06-16  Adam Roben  <aroben@apple.com>
3115
3116         Remove a stray newline from the Windows version of TestNetscapePlugin
3117
3118         Reviewed by Alexey Proskuryakov.
3119
3120         Fixes <http://webkit.org/b/40728>
3121         plugins/geturlnotify-during-document-teardown.html fails on Windows
3122
3123         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3124         (NPP_Destroy): Removed extra newline that the Mac version doesn't
3125         have.
3126
3127 2010-06-16  Adam Roben  <aroben@apple.com>
3128
3129         Respect LayoutTestController::isPrinting on Windows
3130
3131         This gets some printing tests closer to passing (like
3132         printing/page-rule-in-media-query.html).
3133
3134         Fixes <http://webkit.org/b/40727>.
3135
3136         Reviewed by Dan Bernstein.
3137
3138         * DumpRenderTree/win/DumpRenderTree.cpp:
3139         (dump): Pass LayoutTestController::isPrinting to
3140         IWebFramePrivate::renderTreeAsExternalRepresentation.
3141
3142 2010-06-15  Adam Barth  <abarth@webkit.org>
3143
3144         Reviewed by Eric Seidel.
3145
3146         Enable HTML5 lexer
3147         https://bugs.webkit.org/show_bug.cgi?id=40650
3148
3149         * DumpRenderTree/mac/DumpRenderTree.mm:
3150         (initializeGlobalsFromCommandLineOptions):
3151
3152 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
3153
3154         Reviewed by Shinichiro Hamaji.
3155
3156         Implement render style selection for pages to support CSS3 Paged Media.
3157         https://bugs.webkit.org/show_bug.cgi?id=35961
3158
3159         * DumpRenderTree/LayoutTestController.cpp:
3160         (parsePagePropertyParameters):
3161         (pagePropertyCallback):
3162         (LayoutTestController::staticFunctions):
3163         * DumpRenderTree/LayoutTestController.h:
3164         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3165         (LayoutTestController::pageProperty):
3166         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3167         (LayoutTestController::pageProperty):
3168         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3169         (LayoutTestController::pageProperty):
3170
3171 2010-06-15  Sam Weinig  <sam@webkit.org>
3172
3173         Reviewed by Anders Carlsson.
3174
3175         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
3176         WebKit2: Add mechanism to inject code into the WebProcess on startup
3177
3178         Add initial InjectedBundle support.
3179
3180         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3181         * MiniBrowser/WebBundle-Info.plist: Added.
3182         Add test InjectedBundle to the project.
3183
3184         * MiniBrowser/mac/AppDelegate.m:
3185         (-[BrowserAppDelegate init]):
3186         Get the path to the WebBundle from the the main bundle and pass it to the new
3187         WKContextCreateWithInjectedBundlePath function.
3188
3189         * MiniBrowser/mac/BrowserWindowController.m:
3190         (_didChangeProgress):
3191         Fix the build.  This has been broken for a while.
3192
3193         * MiniBrowser/mac/WebBundle: Added.
3194         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
3195         (_didCreatePage):
3196         (WKBundleInitialize):
3197         Add really basic InjectedBundle.
3198
3199         * MiniBrowser/win/BrowserView.cpp:
3200         (BrowserView::create):
3201         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
3202
3203 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
3204
3205         Reviewed by Darin Adler.
3206
3207         Adding myself to the reviewers list.
3208         https://bugs.webkit.org/show_bug.cgi?id=40693
3209
3210         * Scripts/webkitpy/common/config/committers.py:
3211
3212 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
3213
3214         Reviewed by Xan Lopez.
3215
3216         Switch to using GIO methods instead of realpath in GtkLauncher to determine
3217         the file URI. This should remove warnings about realpath being undefined
3218         when compiling with '-ansi'.
3219
3220         * GtkLauncher/main.c:
3221         (filenameToURL): Use GIO instead of realpath to determine file URI.
3222
3223 2010-06-15  Adam Roben  <aroben@apple.com>
3224
3225         Remove the redundant set-apple-windows-environment-variables script
3226
3227         Apparently update-webkit does this for you these days.
3228
3229         Rubber-stamped by Steve Falkenburg.
3230
3231         * Scripts/set-apple-windows-environment-variables: Removed.
3232
3233 2010-06-14  Adam Roben  <aroben@apple.com>
3234
3235         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
3236         environment variables
3237
3238         Fixes <http://webkit.org/b/40595>.
3239
3240         Reviewed by Steve Falkenburg.
3241
3242         * Scripts/set-apple-windows-environment-variables: Added.
3243         (to_windows_path): Passes the passed-in path through cygpath to
3244         generate a Windows-style path.
3245         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
3246         variables to their defaults, if they aren't already set.
3247
3248 2010-06-14  Adam Roben  <aroben@apple.com>
3249
3250         Speed up run-safari/debug-safari on Windows
3251
3252         Fixes <http://webkit.org/b/40586>.
3253
3254         Reviewed by Steve Falkenburg.
3255
3256         * Scripts/webkitdirs.pm:
3257         (runSafari): When debugging, set up the environment to run Safari
3258         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
3259         actually launch the debugger. When not debugging, just run WebKit.exe
3260         and it will do the rest for us.
3261
3262 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
3263
3264         Reviewed by Kenneth Rohde Christiansen.
3265
3266         [Qt] DRT EventSender support to graphics context events
3267         https://bugs.webkit.org/show_bug.cgi?id=40324
3268
3269         * DumpRenderTree/qt/EventSenderQt.cpp:
3270         (EventSender::contextClick):
3271
3272 2010-06-14  Tony Chang  <tony@chromium.org>
3273
3274         Reviewed by Darin Fisher.
3275
3276         [chromium] checkout chromium third_party directly
3277         https://bugs.webkit.org/show_bug.cgi?id=40556
3278
3279         * Scripts/update-webkit-chromium: some migration code for the bots
3280
3281 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
3282
3283         Chromium build fix.
3284
3285         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
3286         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
3287
3288 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
3289
3290         Reviewed by Darin Adler.
3291
3292         https://bugs.webkit.org/show_bug.cgi?id=40529
3293         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
3294
3295         * DumpRenderTree/mac/EventSendingController.mm:
3296         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
3297         event for "delete" - it had virtual key code from forward delete, and text from backspace.
3298         Fixed "delete" to mean forward delete.
3299
3300         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
3301         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
3302         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3303         Mac DRT confusion has propagated to other platforms, fixing those.
3304
3305 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
3306
3307         Reviewed by Xan Lopez.
3308
3309         Small GtkLauncher build fix for some systems.
3310
3311         * GtkLauncher/main.c: Add <limit.h> include.
3312
3313 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3314
3315         Reviewed by Laszlo Gombos.
3316
3317         [Qt] navigator.geolocation support for Qt port
3318         https://bugs.webkit.org/show_bug.cgi?id=39724
3319
3320         Implementation for geolocation cases to DumpRenderTreeQt
3321
3322         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3323         (WebCore::WebPage::allowGeolocationRequest):
3324         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3325         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3326         (LayoutTestController::setGeolocationPermission):
3327         (LayoutTestController::setMockGeolocationError):
3328         (LayoutTestController::setMockGeolocationPosition):
3329         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3330         (LayoutTestController::isGeolocationPermissionSet):
3331         (LayoutTestController::geolocationPermission):
3332
3333 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
3334
3335         Reviewed by Darin Adler.
3336
3337         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
3338         be a way of overwriting the Xcode system path.  Making
3339         $WEBKITOUTPUTDIR take precedence over the system default would make
3340         this possible.
3341
3342         * Scripts/webkitdirs.pm:
3343
3344 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
3345
3346         Reviewed by Darin Adler.
3347
3348         AX: link won't return linked element if URL contains #
3349         https://bugs.webkit.org/show_bug.cgi?id=40192
3350
3351         * DumpRenderTree/AccessibilityUIElement.cpp:
3352         (linkedUIElementAtIndexCallback):
3353         (AccessibilityUIElement::getJSClass):
3354         * DumpRenderTree/AccessibilityUIElement.h:
3355         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3356         (AccessibilityUIElement::linkedUIElementAtIndex):
3357         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3358         (AccessibilityUIElement::linkedUIElementAtIndex):
3359         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3360         (AccessibilityUIElement::linkedUIElementAtIndex):
3361
3362 2010-06-13  Adam Barth  <abarth@webkit.org>
3363
3364         Reviewed by Darin Adler.
3365
3366         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
3367         https://bugs.webkit.org/show_bug.cgi?id=39550
3368
3369         This can cause an extra request to bugs.webkit.org durig upload, but it
3370         shouldn't be too bad.  Also, this won't work if you remove the
3371         boilerplate created by prepare-ChangeLog.
3372
3373         * Scripts/webkitpy/common/checkout/changelog.py:
3374         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3375         * Scripts/webkitpy/common/net/bugzilla.py:
3376         * Scripts/webkitpy/tool/steps/abstractstep.py:
3377         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3378         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
3379
3380 2010-06-08  Robert Hogan  <robert@webkit.org>
3381
3382         Reviewed by Eric Seidel.
3383
3384         [Qt] Add support for callShouldCloseOnWebView() to DRT
3385         https://bugs.webkit.org/show_bug.cgi?id=40330
3386
3387         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3388         (LayoutTestController::callShouldCloseOnWebView):
3389         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3390         (LayoutTestController::setCallCloseOnWebViews):
3391
3392 2010-06-12  Eric Seidel  <eric@webkit.org>
3393
3394         Reviewed by Daniel Bates.
3395
3396         do-webcore-rename should have a --verbose option
3397         https://bugs.webkit.org/show_bug.cgi?id=40497
3398
3399         * Scripts/do-webcore-rename:
3400          - Unified how we handle skipping files/directories
3401            this will allow us to "black list" certain files and
3402            directories when performing renames.
3403          - Made do-webcore-rename log what it's skipping when passed --verbose.
3404
3405 2010-06-12  Darin Adler  <darin@apple.com>
3406
3407         * Scripts/run-bindings-tests: Fixed a typo in a message.
3408
3409 2010-06-12  Kent Tamura  <tkent@chromium.org>
3410
3411         Reviewed by Dimitri Glazkov.
3412
3413         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
3414         https://bugs.webkit.org/show_bug.cgi?id=40402
3415
3416         _build_path() of each Chromium port check existence of build path
3417         of Chromium checkout first, then check existence of build path of
3418         WebKit-only checkout.
3419
3420         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3421         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3422         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3423
3424 2010-06-12  Robert Hogan  <robert@webkit.org>
3425
3426         Reviewed by Kenneth Rohde Christiansen.
3427
3428         [Qt] Back-forward list dumping is incorrect
3429
3430         https://bugs.webkit.org/show_bug.cgi?id=36392
3431
3432         Support dumping child history items in DRT.
3433
3434         Unskip:
3435
3436         fast/loader/frame-src-change-added-to-history.html
3437         fast/loader/frame-src-change-not-added-to-history.html
3438         fast/loader/frame-location-change-not-added-to-history.html
3439
3440         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3441         (WebCore::dumpHistoryItem):
3442
3443 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3444
3445         Reviewed by Eric Seidel.
3446
3447         upload all patches that lack in-rietveld to rietveld
3448         https://bugs.webkit.org/show_bug.cgi?id=40444
3449
3450         If it's a patch, then we'll try to upload it as long as it
3451         doesn't have in-rietveld set. No longer set in-rietveld? since
3452         it's not needed.
3453
3454         * Scripts/webkitpy/common/net/bugzilla.py:
3455
3456 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3457
3458         Reviewed by Darin Fisher.
3459
3460         Fix rietveld upload when message length > 100 characters
3461         https://bugs.webkit.org/show_bug.cgi?id=40457
3462
3463         * Scripts/webkitpy/common/net/rietveld.py:
3464
3465 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
3466
3467         Reviewed by Laszlo Gombos.
3468
3469         [Qt] There should be a way to enable popups in QtTestBrowser
3470         https://bugs.webkit.org/show_bug.cgi?id=40427
3471
3472         * QtTestBrowser/main.cpp:
3473         (LauncherWindow::toggleJavascriptCanOpenWindows):
3474         (LauncherWindow::createChrome):
3475
3476 2010-06-10  Adam Barth  <abarth@webkit.org>
3477
3478         Reviewed by Daniel Bates.
3479
3480         Make SheriffBot more chatty
3481         https://bugs.webkit.org/show_bug.cgi?id=40463
3482
3483         People seem to like to talk to SheriffBot, so let's make him chat back.
3484
3485         * Scripts/webkitpy/thirdparty/__init__.py:
3486         * Scripts/webkitpy/tool/bot/irc_command.py:
3487         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
3488         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
3489         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3490
3491 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
3492
3493         Reviewed by Darin Adler.
3494
3495         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
3496         
3497         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
3498         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
3499         WEXITSTATUS on $result instead of just comparing $result to 0.
3500
3501         * Scripts/update-webkit-auxiliary-libs:
3502
3503 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3504
3505         Reviewed by Alexey Proskuryakov.
3506
3507         don't use Exception.message as it's deprecated in python 2.6+
3508         https://bugs.webkit.org/show_bug.cgi?id=40449
3509
3510         * Scripts/webkitpy/tool/commands/queues.py:
3511
3512 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3513
3514         Reviewed by Adam Barth.
3515
3516         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
3517         https://bugs.webkit.org/show_bug.cgi?id=40436
3518
3519         * Scripts/webkitpy/common/system/outputcapture.py:
3520         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3521         * Scripts/webkitpy/tool/commands/queues.py:
3522         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3523         * Scripts/webkitpy/tool/commands/queuestest.py:
3524         * Scripts/webkitpy/tool/mocktool.py:
3525
3526 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
3527
3528         Reviewed by Simon Hausmann.
3529
3530         [Qt] *All* WebGL layout tests fail!
3531         https://bugs.webkit.org/show_bug.cgi?id=40296
3532
3533         Added test for WebKitWebGLEnabled to
3534         LayoutTestController::overridePreference().
3535
3536         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3537         (LayoutTestController::overridePreference):
3538
3539 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
3540
3541         Reviewed by Kenneth Rohde Christiansen.
3542
3543         [Qt] DRT EventSender support to graphics mouse events activation
3544         https://bugs.webkit.org/show_bug.cgi?id=40017
3545
3546         * DumpRenderTree/qt/EventSenderQt.cpp:
3547         (EventSender::mouseDown):
3548         (EventSender::mouseUp):
3549         (EventSender::mouseMoveTo):
3550         (EventSender::keyDown):
3551         (EventSender::contextClick):
3552         (EventSender::sendTouchEvent):
3553         (EventSender::sendOrQueueEvent):
3554         (EventSender::eventFilter):
3555         (EventSender::createGraphicsSceneMouseEvent):
3556         (EventSender::sendEvent):
3557         * DumpRenderTree/qt/EventSenderQt.h:
3558         (EventSender::isGraphicsBased):
3559
3560 2010-06-09  Adam Barth  <abarth@webkit.org>
3561
3562         Reviewed by Ojan Vafai.
3563
3564         webkit-patch upload fails for security bugs because there's no rietveld flag
3565         https://bugs.webkit.org/show_bug.cgi?id=40309
3566
3567         There's probably a more elegant way of seeing whether the form control
3568         exists, but this seems to work.
3569
3570         * Scripts/webkitpy/common/net/bugzilla.py:
3571
3572 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3573
3574         Reviewed by Adam Barth.
3575
3576         make rietveld upload faster and avoid posting to bug on errors
3577         https://bugs.webkit.org/show_bug.cgi?id=40389
3578
3579         Only grab the first item of the upload queue instead of trying
3580         to compute the whole list upfront (which is O(n) bugzilla lookups!).
3581
3582         Also, don't post comments to the bug when uploading fails.
3583
3584         * Scripts/webkitpy/common/net/bugzilla.py:
3585         * Scripts/webkitpy/tool/commands/queues.py:
3586         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3587         * Scripts/webkitpy/tool/commands/stepsequence.py:
3588         * Scripts/webkitpy/tool/mocktool.py:
3589
3590 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3591
3592         Reviewed by Adam Barth.
3593
3594         Rietveld upload queue fails when setting in-rietveld flag
3595         https://bugs.webkit.org/show_bug.cgi?id=40371
3596
3597         Make the comment arguments to set_flag_on_attachment optional
3598         and add it to the MockBugzilla.
3599
3600         * Scripts/webkitpy/common/net/bugzilla.py:
3601         * Scripts/webkitpy/tool/bot/queueengine.py:
3602         * Scripts/webkitpy/tool/commands/download_unittest.py:
3603         * Scripts/webkitpy/tool/commands/queues.py:
3604         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3605         * Scripts/webkitpy/tool/mocktool.py:
3606
3607 2010-06-09  Kenneth Russell  <kbr@google.com>
3608
3609         Reviewed by Dimitri Glazkov.
3610
3611         Rename FloatArray to Float32Array
3612         https://bugs.webkit.org/show_bug.cgi?id=40323
3613
3614         Used do-webcore-rename to perform renaming. Manually undid
3615         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
3616         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
3617         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran