e9111698fa6b79d54afa37dd7fd129f1de8ce116
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2
3         Reviewed by Ariya Hidayat.
4
5         [Qt] QtTestBrowser: proper set scene rect
6
7         When resizesToContents is ON scene's rect is set to the boundary of
8         the mainFrame. However, navigating to other web page should keep resizing
9         scene's rect according to the new document loaded. Patch addresses this issue.
10
11         Now resizesToContents and scrolling properly work on QtTestBrowser.
12
13         * QtTestBrowser/webview.cpp:
14         (WebViewGraphicsBased::setPage):
15         (WebViewGraphicsBased::contentsSizeChanged):
16         (WebViewGraphicsBased::setResizesToContents):
17         (WebViewGraphicsBased::resizeEvent):
18         * QtTestBrowser/webview.h:
19
20 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
21
22         Reviewed by Ariya Hidayat.
23
24         [Qt] QtTestBrowser: Clean up LauncherWindow code.
25
26         * QtTestBrowser/launcherwindow.cpp:
27         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
28         (LauncherWindow::init): Fixed comments.
29         (LauncherWindow::applyPrefs): Move the method around.
30         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
31
32 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
33
34         Reviewed by Ariya Hidayat.
35
36         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
37
38         It gets control+0 the same visual effect as control++ or control-.
39
40         * QtTestBrowser/launcherwindow.cpp:
41         (LauncherWindow::toggleZoomTextOnly):
42
43 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
44
45         Reviewed by Ariya Hidayat.
46
47         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
48
49         Not all instances of LauncherWindow need its own m_zoomLevel.
50
51         * QtTestBrowser/launcherwindow.cpp:
52         * QtTestBrowser/launcherwindow.h:
53
54 2010-08-09  Sam Weinig  <sam@webkit.org>
55
56         Reviewed by Geoffrey Garen.
57
58         Add zoom support for injected bundle
59         https://bugs.webkit.org/show_bug.cgi?id=43759
60
61         Use zoom factor SPI to implement zoom related eventSender functions.
62
63         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
64         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
65         (WTR::EventSendingController::textZoomIn):
66         (WTR::EventSendingController::textZoomOut):
67         (WTR::EventSendingController::zoomPageIn):
68         (WTR::EventSendingController::zoomPageOut):
69         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
70         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
71         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
72
73 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
74
75         Speculative chromium build fix III.
76
77         * DumpRenderTree/chromium/MockSpellCheck.h:
78         * DumpRenderTree/chromium/NotificationPresenter.h:
79         * DumpRenderTree/chromium/WebViewHost.h:
80         (WebViewHost::addClearHeader):
81         (WebViewHost::clearHeaders):
82
83 2010-08-09  Ojan Vafai  <ojan@chromium.org>
84
85         Reviewed by Tony Chang.
86
87         increase the number of test results that we save
88         https://bugs.webkit.org/show_bug.cgi?id=43763
89
90         Now that we do incremental uploads, we can increase the number of
91         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
92
93         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
94
95 2010-08-09  Evan Martin  <evan@chromium.org>
96
97         Reviewed by Tony Chang.
98
99         [chromium] DRT error print statement incorrectly tries to print a FILE*
100         https://bugs.webkit.org/show_bug.cgi?id=43747
101
102         * DumpRenderTree/chromium/ImageDiff.cpp:
103         (writeFile): pass the correct pointer.
104
105 2010-08-09  Victor Wang  <victorw@chromium.org>
106
107         Reviewed by Ojan Vafai.
108
109         Upload incremental test results json to server by default.
110
111         https://bugs.webkit.org/show_bug.cgi?id=43743
112
113         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
114
115 2010-08-09  Eric Seidel  <eric@webkit.org>
116
117         Reviewed by Adam Barth.
118
119         EWS bots wait 2 minutes between patches
120         https://bugs.webkit.org/show_bug.cgi?id=43731
121
122         * Scripts/webkitpy/tool/bot/queueengine.py:
123          - Don't sleep after failures.  This was a hold-over from
124            an earlier design.
125         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
126          - EWS bots were not properly reporting true/false from process_work_item.
127            They were always returning None, thus false, thus always logging
128            as a failure and sleeping 2 minutes after each patch.
129
130 2010-08-09  Sam Weinig  <sam@webkit.org>
131
132         Reviewed by Anders Carlsson.
133
134         Stub out EventSender for WebKitTestRunner
135         https://bugs.webkit.org/show_bug.cgi?id=43703
136
137         * WebKitTestRunner/DerivedSources.make:
138         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
139         Add ability to pass javascript arguments to the wrapped object.
140
141         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
142         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
143         (WTR::EventSendingController::create):
144         (WTR::EventSendingController::EventSendingController):
145         (WTR::EventSendingController::~EventSendingController):
146         (WTR::EventSendingController::wrapperClass):
147         (WTR::setExceptionForString):
148         (WTR::EventSendingController::mouseDown):
149         (WTR::EventSendingController::mouseUp):
150         (WTR::EventSendingController::mouseMoveTo):
151         (WTR::EventSendingController::keyDown):
152         (WTR::EventSendingController::contextClick):
153         (WTR::EventSendingController::leapForward):
154         (WTR::EventSendingController::textZoomIn):
155         (WTR::EventSendingController::textZoomOut):
156         (WTR::EventSendingController::zoomPageIn):
157         (WTR::EventSendingController::zoomPageOut):
158         (WTR::EventSendingController::makeWindowObject):
159         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
160         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
161         (WTR::InjectedBundle::reset):
162         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
163         (WTR::InjectedBundle::eventSendingController):
164         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
165         (WTR::InjectedBundlePage::didClearWindowForFrame):
166         Add stubbed out EventSenderController.
167
168         * WebKitTestRunner/InjectedBundle/GCController.h:
169         Remove incorrect comment.
170
171         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
172         * WebKitTestRunner/win/InjectedBundle.vcproj:
173         Add new files.
174
175 2010-08-08  Kent Tamura  <tkent@chromium.org>
176
177         Unreviewed, trivial fix.
178
179         Fix "WindowsError: [Error 32] The process cannot access the file
180         because it is being used by another process" introduced by r64959.
181
182         * BuildSlaveSupport/test-result-archive:
183
184 2010-08-08  Kent Tamura  <tkent@chromium.org>
185
186         Reviewed by Tony Chang.
187
188         Chromium buildbot: Avoid "zip" command dependency
189         https://bugs.webkit.org/show_bug.cgi?id=43470
190
191         * BuildSlaveSupport/test-result-archive:
192          For Chromium port, creates a zip archive with zipfile package of Python
193          instead of external "zip" command. We'd like to avoid additional
194          command installation.
195
196 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
197
198         WebKitTestRunner should add the QuickTime dir to the PATH environment
199         variable
200         https://bugs.webkit.org/show_bug.cgi?id=43686
201
202         Reviewed by Dan Bernstein.
203
204         * WebKitTestRunner/win/TestControllerWin.cpp:
205         (WTR::addQTDirToPATH):
206         Copied from DRT.
207         (WTR::TestController::platformInitialize):
208         Call addQTDirToPath().
209         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
210         Link to shlwapi.lib for SHGetValue.
211
212 2010-08-07  Sam Weinig  <sam@webkit.org>
213
214         Reviewed by Maciej Stachowiak.
215
216         WebKitTestRunner needs layoutTestController.dumpTitleChanges
217         <rdar://problem/8213861>
218         https://bugs.webkit.org/show_bug.cgi?id=42683
219
220         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
221         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
222         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
223         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
224         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
225         (WTR::LayoutTestController::LayoutTestController):
226         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
227         (WTR::LayoutTestController::dumpTitleChanges):
228         (WTR::LayoutTestController::shouldDumpTitleChanges):
229
230 2010-08-07  Sam Weinig  <sam@webkit.org>
231
232         Reviewed by Anders Carlsson.
233
234         WebKitTestRunner needs to print onunload handler information
235         <rdar://problem/8213831>
236         https://bugs.webkit.org/show_bug.cgi?id=42703
237
238         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
239         (WTR::operator<<):
240         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
241
242 2010-08-07  Sam Weinig  <sam@webkit.org>
243
244         Reviewed by Anders Carlsson.
245
246         Add additional loader client functions need to complete WebKitTestRunner
247         https://bugs.webkit.org/show_bug.cgi?id=43684
248
249         Remove unnecessary and jarring underscores as well.
250
251         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
252         (didClearWindowObjectForFrame):
253         (didCreatePage):
254         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
255         (WTR::InjectedBundlePage::InjectedBundlePage):
256         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
257         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
258         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
259         (WTR::InjectedBundlePage::didCommitLoadForFrame):
260         (WTR::InjectedBundlePage::didFinishLoadForFrame):
261         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
262         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
263         (WTR::InjectedBundlePage::didClearWindowForFrame):
264         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
265         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
266         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
267         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
268         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
269         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
270         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
271         (WTR::InjectedBundlePage::willAddMessageToConsole):
272         (WTR::InjectedBundlePage::willSetStatusbarText):
273         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
274         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
275         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
276         (WTR::InjectedBundlePage::shouldBeginEditing):
277         (WTR::InjectedBundlePage::shouldEndEditing):
278         (WTR::InjectedBundlePage::shouldInsertNode):
279         (WTR::InjectedBundlePage::shouldInsertText):
280         (WTR::InjectedBundlePage::shouldDeleteRange):
281         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
282         (WTR::InjectedBundlePage::shouldApplyStyle):
283         (WTR::InjectedBundlePage::didBeginEditing):
284         (WTR::InjectedBundlePage::didEndEditing):
285         (WTR::InjectedBundlePage::didChange):
286         (WTR::InjectedBundlePage::didChangeSelection):
287         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
288
289 2010-08-07  Dan Bernstein  <mitz@apple.com>
290
291         Build fix.
292
293         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
294         to JSGCController.{cpp,h} relative to the build root.
295
296 2010-08-07  Sam Weinig  <sam@webkit.org>
297
298         Reviewed by Anders Carlsson.
299
300         WebKitTestRunner needs GCController
301         <rdar://problem/8213834>
302         https://bugs.webkit.org/show_bug.cgi?id=42701
303
304         * WebKitTestRunner/DerivedSources.make:
305         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
306         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
307         (WTR::setProperty):
308         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
309         (WTR::GCController::create):
310         (WTR::GCController::GCController):
311         (WTR::GCController::~GCController):
312         (WTR::GCController::wrapperClass):
313         (WTR::GCController::collect):
314         (WTR::GCController::collectOnAlternateThread):
315         (WTR::GCController::getJSObjectCount):
316         (WTR::GCController::makeWindowObject):
317         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
318         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
319         (WTR::InjectedBundle::reset):
320         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
321         (WTR::InjectedBundle::bundle):
322         (WTR::InjectedBundle::gcController):
323         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
324         (WTR::InjectedBundlePage::didClearWindowForFrame):
325         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
326         (WTR::LayoutTestController::keepWebHistory):
327         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
328         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
329         * WebKitTestRunner/win/InjectedBundle.vcproj:
330
331 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
332
333         WebKitTestRunner needs to be able to set the font smoothing type
334         https://bugs.webkit.org/show_bug.cgi?id=43406
335
336         Reviewed by Adam Roben.
337
338         * WebKitTestRunner/TestInvocation.cpp:
339         (WTR::TestInvocation::resetPreferencesToConsistentValues):
340         Set the font smoothing level to
341         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
342
343 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
344
345         Fix a missed variable rename.
346
347         Unreviewed.
348
349         * Scripts/old-run-webkit-tests:
350
351 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
352
353         mac-wk2/Skipped should be used on Windows when running regression tests
354         https://bugs.webkit.org/show_bug.cgi?id=43494
355
356         Reviewed by Adam Roben.
357
358         * Scripts/old-run-webkit-tests:
359         If the platform is win-wk2, also read the mac-wk2 skipped list.
360
361 2010-08-06  Kent Tamura  <tkent@chromium.org>
362
363         Reviewed by Dimitri Glazkov.
364
365         [DRT/Chromium] Should revoke scheduled tasks
366         https://bugs.webkit.org/show_bug.cgi?id=43560
367
368         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
369         (DRTDevToolsAgent::reset): Calls RevokeAll().
370         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
371         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
372         (DRTDevToolsClient::reset): Calls RevokeAll().
373         * DumpRenderTree/chromium/DRTDevToolsClient.h:
374         * DumpRenderTree/chromium/EventSender.cpp:
375         (EventSender::reset): Calls RevokeAll().
376         * DumpRenderTree/chromium/LayoutTestController.cpp:
377         (LayoutTestController::reset): Calls RevokeAll().
378         * DumpRenderTree/chromium/TestShell.cpp:
379         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
380
381 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
382
383         Reviewed by Antonio Gomes.
384
385         [Qt] Fix the DRT build on Mac OS X
386
387         * DumpRenderTree/qt/DumpRenderTree.pro:
388
389 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
390
391         Reviewed by Pavel Feldman.
392
393         Rietvield's upload.py moved to a different location.
394         https://bugs.webkit.org/show_bug.cgi?id=43613
395
396         * Scripts/webkitpy/thirdparty/__init__.py:
397
398 2010-05-23  Eric Seidel  <eric@webkit.org>
399
400         Reviewed by Adam Barth.
401
402         QueueStatusServer needs better queue-status pages
403         https://bugs.webkit.org/show_bug.cgi?id=39562
404
405         The primary goal of this patch is to display queue
406         positions somewhere on the site so that it's easier
407         for commit-queue users to know when their pach will
408         be landed.  I also tried to improve the root page
409         to be more useful than the previous wall of status text.
410
411         * QueueStatusServer/handlers/recentstatus.py:
412         * QueueStatusServer/main.py:
413         * QueueStatusServer/model/queues.py:
414         * QueueStatusServer/templates/recentstatus.html:
415
416 2010-08-05  Victor Wang  <victorw@chromium.org>
417
418         Reviewed by Ojan Vafai.
419
420         Add option to generate/upload incremental json results to test result server.
421         Also refactor the json results generator unittest code to test
422         incremental and aggregated json results.
423
424         https://bugs.webkit.org/show_bug.cgi?id=43519
425
426         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
427         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
428         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
429         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
430
431 2010-08-05  Jian Li  <jianli@chromium.org>
432
433         Reviewed by David Levin.
434
435         Unify blob related feature defines to ENABLE(BLOB).
436         https://bugs.webkit.org/show_bug.cgi?id=43081
437
438         * Scripts/build-webkit:
439
440 2010-08-05  Satish Sampath  <satish@chromium.org>
441
442         Reviewed by Jeremy Orlow.
443
444         Add speech input controller mock in WebKit and a layout test.
445         https://bugs.webkit.org/show_bug.cgi?id=43477
446
447         Added LayoutTestController::setMockSpeechInputResultCallback method.
448
449         * DumpRenderTree/LayoutTestController.cpp:
450         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
451         (LayoutTestController::staticFunctions):
452         * DumpRenderTree/LayoutTestController.h:
453         * DumpRenderTree/chromium/LayoutTestController.cpp:
454         (LayoutTestController::LayoutTestController):
455         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
456         (LayoutTestController::speechInputController): Creates the mock controller.
457         * DumpRenderTree/chromium/LayoutTestController.h:
458         * DumpRenderTree/chromium/WebViewHost.cpp:
459         (WebViewHost::speechInputController): Creates the mock controller.
460         * DumpRenderTree/chromium/WebViewHost.h:
461         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
462         (LayoutTestController::setMockSpeechInputResult): dummy method.
463         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
464         (LayoutTestController::setMockSpeechInputResult): dummy method.
465         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
466         (LayoutTestController::setMockSpeechInputResult): dummy method.
467         * DumpRenderTree/qt/LayoutTestControllerQt.h:
468         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
469         (LayoutTestController::setMockSpeechInputResult):
470         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
471         (LayoutTestController::setMockSpeechInputResult):
472
473 2010-08-04  Adam Roben  <aroben@apple.com>
474
475         Fix the path to TestNetscapePlugin's directory on Windows
476
477         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
478         load TestNetscapePlugin
479
480         Reviewed by Jon Honeycutt.
481
482         * WebKitTestRunner/win/TestControllerWin.cpp:
483         (WTR::TestController::initializeTestPluginDirectory):
484         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
485         next to WebKitTestRunner.exe. Previously we were passing the directory
486         that contains WebKitTestRunner.exe. Also fixed some leaks.
487
488 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
489
490         Reviewed by Shinichiro Hamaji.
491
492         check-webkit-style returns non-zero when patch is entirely minus lines.
493         https://bugs.webkit.org/show_bug.cgi?id=38169
494
495         * Scripts/check-webkit-style:
496         Check whether a patch contains modified files that are entirely minus lines.
497         * Scripts/webkitpy/style/filereader.py:
498         Add a variable that holds number of files that contain only deleted lines.
499         * Scripts/webkitpy/style/patchreader.py:
500         Count up modified files that contain only deleted lines.
501
502 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
503
504         Reviewed by Yury Semikhatsky.
505
506         DevTools: get rid of delayed command dispatching on front-end side.
507
508         https://bugs.webkit.org/show_bug.cgi?id=43479
509
510         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
511         (DRTDevToolsAgent::detach):
512         (DRTDevToolsAgent::frontendLoaded):
513         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
514         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
515         (DRTDevToolsClient::~DRTDevToolsClient):
516         (DRTDevToolsClient::sendFrontendLoaded):
517         * DumpRenderTree/chromium/DRTDevToolsClient.h:
518
519 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
520
521         Reviewed by Shinichiro Hamaji.
522
523         Fixes check-webkit-style false positive on "new uint32_t."
524         https://bugs.webkit.org/show_bug.cgi?id=43077
525
526         * Scripts/webkitpy/style/checkers/cpp.py:
527         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
528
529 2010-08-04  Kent Tamura  <tkent@chromium.org>
530
531         Reviewed by Dimitri Glazkov.
532
533         [DRT/Chromium] Remove base/linked_ptr.h dependency
534         https://bugs.webkit.org/show_bug.cgi?id=43472
535
536         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
537         We need to use RefPtr<> because m_pendingEntry points an object in
538         m_entries or not in m_entries.
539
540         * DumpRenderTree/chromium/TestNavigationController.cpp:
541         (TestNavigationEntry::create): Added.
542         (TestNavigationController::activeEntry):
543         (TestNavigationController::didNavigateToEntry):
544         (TestNavigationController::discardPendingEntry):
545         (TestNavigationController::insertEntry):
546         (TestNavigationController::navigateToPendingEntry):
547         * DumpRenderTree/chromium/TestNavigationController.h:
548         * DumpRenderTree/chromium/WebViewHost.cpp:
549         (WebViewHost::loadURLForFrame):
550          Use TestNavigationEntry::create().
551         (WebViewHost::updateURL):
552          Use RefPtr<>.
553         (WebViewHost::updateSessionHistory):
554          Remove unnecessary static_cast<>.
555
556 2010-08-04  Kent Tamura  <tkent@chromium.org>
557
558         Reviewed by Dimitri Glazkov.
559
560         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
561         https://bugs.webkit.org/show_bug.cgi?id=43333
562
563         * BuildSlaveSupport/test-result-archive:
564           - Make layoutTestResultsDir local and pass it to archiveTestResults()
565           - Adjust layoutTestResultsDir for Chromium
566
567 2010-08-04  Kent Tamura  <tkent@chromium.org>
568
569         Reviewed by Dimitri Glazkov.
570
571         NRWT: websocket_server startup detection failure
572         https://bugs.webkit.org/show_bug.cgi?id=43466
573
574         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
575          Increase timeout value: 5 second -> 10 second
576
577 2010-08-04  Victor Wang  <victorw@chromium.org>
578
579         Reviewed by Ojan Vafai.
580
581         -. Add result.json incremental merging functionality to test results app engine.
582         -. blobstore is not suitable for AE data merging and there is no API to
583            programatically edit existing blob or write a new one yet, so replace blobstore
584            with datastore. If file is oversize (>1000*1000 bytes), store file data in
585            multiple datastore entries.
586         -. Fix styles.
587
588         Test: jsonresults_unittest to test merging logics.
589
590         https://bugs.webkit.org/show_bug.cgi?id=38599
591
592         * TestResultServer/handlers/dashboardhandler.py:
593         * TestResultServer/handlers/menu.py:
594         * TestResultServer/handlers/testfilehandler.py:
595         * TestResultServer/main.py:
596         * TestResultServer/model/dashboardfile.py:
597         * TestResultServer/model/datastorefile.py: Added.
598         * TestResultServer/model/jsonresults.py: Added.
599         * TestResultServer/model/jsonresults_unittest.py: Added.
600         * TestResultServer/model/testfile.py:
601         * TestResultServer/templates/uploadform.html:
602
603 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
604
605         Reviewed by Kenneth Christiansen.
606
607         [Qt] [QtTestBrowser] Remove unneeded QAction class members
608         https://bugs.webkit.org/show_bug.cgi?id=43518
609
610         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
611         m_flipYAnimated. Also, in initializeView method there are some dead code block
612         trying to connect them at the wrong time, when they have not been instanciated.
613
614         This patch:
615
616         - removes the two cited class members in favor of local variables in createChrome method;
617         - removes the dead code block.
618
619         * QtTestBrowser/launcherwindow.cpp:
620         (LauncherWindow::LauncherWindow):
621         (LauncherWindow::initializeView):
622         (LauncherWindow::createChrome):
623         * QtTestBrowser/launcherwindow.h:
624
625 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
626
627         Reviewed by Simon Hausmann and Kenneth Christiansen.
628
629         [Qt] [QtTestBrowser] Clean up static and global menu state controls
630         https://bugs.webkit.org/show_bug.cgi?id=43448
631
632         After LauncherWindow class was refactored out of from main.cpp, all global variables that
633         were hanging in main.cpp became temporarily public static class members of newly added
634         LauncherWindow class. This design was not properly handling the initial purpose of the
635         global variables: newly created launcher windows should inherit the settings of the originating
636         one.
637
638         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
639         comprises all data needed to handling the goal described above.
640
641         * QtTestBrowser/launcherwindow.cpp:
642         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
643                                           holding all user settings configured in the menus and command line.
644                                           It also receices an optional QGraphicsScene points in case we are doing
645                                           a "Clone Window".
646         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
647                                 value.
648         (LauncherWindow::initializeView): Ditto.
649         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
650         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
651                                       apply the preferences is provided by m_userData.
652         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
653         (LauncherWindow::toggleResizesToContents): Ditto.
654         (LauncherWindow::toggleWebGL): Ditto.
655         (LauncherWindow::toggleFrameFlattening): Ditto.
656         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
657         (LauncherWindow::changeViewportUpdateMode): Ditto.
658         (LauncherWindow::showFPS): Ditto.
659         (LauncherWindow::newWindow): Changed to pass the userData.
660         (LauncherWindow::cloneWindow): Ditto.
661         * QtTestBrowser/launcherwindow.h:
662         (WindowOptions::WindowOptions):
663         * QtTestBrowser/main.cpp:
664         (requiresGraphicsView):
665         (LauncherApplication::handleUserOptions):
666         (main):
667
668 2010-08-04  Kevin Ollivier  <kevino@theolliviers.com>
669
670         [wx] Build fix for gcc not importing all symbols from convenience libraries.
671         Works on 10.6 only for Mac until the build system is reworked. 
672
673         * wx/build/settings.py:
674
675 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
676
677         Reviewed by Simon Hausmann.
678
679         [Qt] Change wording in QtTestBrowser
680         https://bugs.webkit.org/show_bug.cgi?id=43241
681
682         * QtTestBrowser/launcherwindow.cpp:
683         (LauncherWindow::createChrome):
684
685 2010-08-04  Aaron Boodman  <aa@chromium.org>
686
687         Reviewed by Eric Seidel.
688
689         prepare-ChangeLog fails mysteriously if curl doesn't support ssl
690         https://bugs.webkit.org/show_bug.cgi?id=43460
691
692         * Scripts/prepare-ChangeLog:
693
694 2010-08-03  MORITA Hajime  <morrita@google.com>
695
696         Reviewed by Tony Chang.
697
698         [DRT] Assertion failed when drag and move a draggable element.
699         https://bugs.webkit.org/show_bug.cgi?id=41695
700
701         mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
702         But Cocoa doesn't call mouseDragged() until dragging is done.
703         Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
704         on UIDelegate failed when mouseDragged() is called during dragging.
705         This change eliminated the mouseDragged() call when dragging begins,
706         which is implicated by draggingInfo instance.
707         
708         * DumpRenderTree/mac/EventSendingController.mm:
709         (-[EventSendingController mouseMoveToX:Y:]):
710
711         Test: fast/events/dragging-mouse-moves.html
712         
713 2010-08-02  Steve Block  <steveblock@google.com>
714
715         Reviewed by Alexey Proskuryakov.
716
717         Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
718         https://bugs.webkit.org/show_bug.cgi?id=40002
719
720         The code in LayoutTestController::setGeolocationPermission() was moved to
721         setGeolocationPermissionCommon() to allow each port to provide its own
722         implementation of setGeolocationPermission().
723
724         For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
725         new permission, so it can call back to WebCore if permission requests are in
726         progress and are waiting for a response. A minor fix to the Mac
727         MockGeolocationProvider was also required to make sure that the mock provider
728         calls back to WebCore when it is first started.
729
730         For other ports, LayoutTestController::setGeolocationPermission() is not
731         implemented.
732
733         * DumpRenderTree/LayoutTestController.cpp:
734         (LayoutTestController::setGeolocationPermissionCommon):
735         * DumpRenderTree/LayoutTestController.h:
736         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
737         (LayoutTestController::setGeolocationPermission):
738         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
739         (LayoutTestController::setGeolocationPermission):
740         * DumpRenderTree/mac/MockGeolocationProvider.mm:
741         (-[MockGeolocationProvider registerWebView:]):
742         * DumpRenderTree/mac/UIDelegate.h:
743         * DumpRenderTree/mac/UIDelegate.mm:
744         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
745         (-[UIDelegate setGeolocationPermission:]):
746         (-[UIDelegate dealloc]):
747         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
748         (LayoutTestController::setGeolocationPermission):
749         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
750         (LayoutTestController::setGeolocationPermission):
751
752 2010-08-03  Kent Tamura  <tkent@chromium.org>
753
754         Reviewed by Dimitri Glazkov.
755
756         [DRT/Chromium] Implement --testshell-startup-dialog
757         https://bugs.webkit.org/show_bug.cgi?id=40616
758
759         * DumpRenderTree/chromium/DumpRenderTree.cpp:
760         (main): Check --testshell-startup-dialog, and call openStartUpDialog()
761         if it is specfied.
762         * DumpRenderTree/chromium/TestShell.h:
763           Declare openStartUpDialog().
764         * DumpRenderTree/chromium/TestShellGtk.cpp:
765         (openStartupDialog):
766         * DumpRenderTree/chromium/TestShellMac.mm:
767         (openStartupDialog):
768         * DumpRenderTree/chromium/TestShellWin.cpp:
769         (openStartupDialog):
770
771 2010-08-03  Kent Tamura  <tkent@chromium.org>
772
773         Reviewed by Dimitri Glazkov.
774
775         [DRT/Chromium] Remove dependency of base/md5.h
776         https://bugs.webkit.org/show_bug.cgi?id=43403
777
778         * DumpRenderTree/chromium/TestShell.cpp:
779         (TestShell::dumpImage): Use wtf/MD5.h
780
781 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
782
783         Reviewed by David Kilzer.
784
785         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
786         https://bugs.webkit.org/show_bug.cgi?id=40627
787
788         Part 6 - LayoutTest and Cleanup
789
790           Allow tests to delete application caches and set application cache
791           origin quotas, so they can be tested.
792
793         * DumpRenderTree/LayoutTestController.cpp:
794         (LayoutTestController::LayoutTestController):
795         (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller.
796         (clearAllApplicationCachesCallback): should delete all application caches.
797         (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests.
798         (LayoutTestController::staticFunctions):
799         * DumpRenderTree/LayoutTestController.h:
800         (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output.
801         (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
802
803           Mac implementation.
804
805         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
806         (LayoutTestController::clearAllApplicationCaches): delete application caches.
807         (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
808         * DumpRenderTree/mac/UIDelegate.mm:
809         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix.
810         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
811
812           Stub implementations for other platforms.
813
814         * DumpRenderTree/chromium/LayoutTestController.cpp:
815         (LayoutTestController::LayoutTestController):
816         (LayoutTestController::clearAllApplicationCaches):
817         (LayoutTestController::setApplicationCacheOriginQuota):
818         * DumpRenderTree/chromium/LayoutTestController.h:
819         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
820         (LayoutTestController::clearAllApplicationCaches):
821         (LayoutTestController::setApplicationCacheOriginQuota):
822         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
823         (LayoutTestController::clearAllApplicationCaches):
824         (LayoutTestController::setApplicationCacheOriginQuota):
825         * DumpRenderTree/qt/LayoutTestControllerQt.h:
826         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
827         (LayoutTestController::clearAllApplicationCaches):
828         (LayoutTestController::setApplicationCacheOriginQuota):
829         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
830         (LayoutTestController::clearAllApplicationCaches):
831         (LayoutTestController::setApplicationCacheOriginQuota):
832
833 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
834
835         Reviewed by David Kilzer.
836
837         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
838         https://bugs.webkit.org/show_bug.cgi?id=40627
839
840         Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
841
842           Change old style calls to make use of the managers.
843
844         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
845         (LayoutTestController::setDatabaseQuota):
846         * DumpRenderTree/mac/UIDelegate.mm:
847         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
848
849 2010-08-03  Mark Rowe  <mrowe@apple.com>
850
851         Add a new Leopard build slave to run the release tests.
852
853         * BuildSlaveSupport/build.webkit.org-config/config.json:
854
855 2010-08-03  Jon Honeycutt  <jhoneycutt@apple.com>
856
857         WebKitTestRunner needs to activate the Mac font ascent hack
858         https://bugs.webkit.org/show_bug.cgi?id=43404
859
860         Reviewed by Darin Adler.
861
862         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
863         (WTR::InjectedBundle::initialize):
864         Call WKBundleActivateMacFontAscentHack().
865
866 2010-08-03  Alex Milowski  <alex@milowski.com>
867
868         Reviewed by Beth Dakin.
869
870         Changed the default for MathML support so that is is enabled by default.
871
872         * Scripts/build-webkit:
873
874 2010-08-03  Sam Weinig  <sam@webkit.org>
875
876         Roll r64566 back in this time with all the overloads in place..
877
878         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
879         (WTR::InjectedBundlePage::shouldInsertNode):
880         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
881         * WebKitTestRunner/StringFunctions.h:
882         * WebKitTestRunner/TestInvocation.cpp:
883         (WTR::TestInvocation::resetPreferencesToConsistentValues):
884         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
885         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
886
887 2010-08-03  Sam Weinig  <sam@webkit.org>
888
889         Rollout r64566. It broke all the WebKit2 tests.
890
891         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
892         (WTR::operator<<):
893         (WTR::InjectedBundlePage::shouldInsertNode):
894         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
895         * WebKitTestRunner/StringFunctions.h: Removed.
896         * WebKitTestRunner/TestInvocation.cpp:
897         (WTR::createWKURL):
898         (WTR::WKStringToUTF8):
899         (WTR::TestInvocation::resetPreferencesToConsistentValues):
900         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
901         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
902
903 2010-08-03  Sam Weinig  <sam@webkit.org>
904
905         Reviewed by Anders Carlsson.
906
907         WTR: Move all the utility functions for working with strings to a shared header.
908         https://bugs.webkit.org/show_bug.cgi?id=43386
909
910         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
911         (WTR::InjectedBundlePage::shouldInsertNode):
912         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
913         * WebKitTestRunner/StringFunctions.h: Added.
914         * WebKitTestRunner/TestInvocation.cpp:
915         (WTR::TestInvocation::resetPreferencesToConsistentValues):
916         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
917         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
918
919 2010-08-02  Antonio Gomes  <tonikitoo@webkit.org>
920
921         Reviewed by Kenneth Christiansen.
922
923         [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
924         https://bugs.webkit.org/show_bug.cgi?id=43168
925
926         QGraphicsWebView resizesToContents property has to work together with QWebPage's
927         setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
928
929         * QtTestBrowser/launcherwindow.cpp:
930         (LauncherWindow::applyPrefs):
931         * QtTestBrowser/webview.cpp:
932         (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
933                                                       needed when toggle resizesToContents on/off.
934         (WebViewGraphicsBased::resizeEvent):
935         * QtTestBrowser/webview.h:
936         (WebViewGraphicsBased::setCustomLayoutSize): Setter helper.
937         (WebViewGraphicsBased::customLayoutSize): Getter helper.
938
939 2010-08-03  Jochen Eisinger  <jochen@chromium.org>
940
941         Unreviewed. Adding myself as committer.
942
943         * Scripts/webkitpy/common/config/committers.py:
944
945 2010-08-02  Pavel Feldman  <pfeldman@chromium.org>
946
947         Reviewed by Yury Semikhatsky.
948
949         Chromium DevTools: Get rid of DevTools RPC.
950
951         https://bugs.webkit.org/show_bug.cgi?id=43335
952
953         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
954         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
955         (DRTDevToolsAgent::call):
956         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
957         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
958         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
959         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
960         (DRTDevToolsClient::sendMessageToBackend):
961         (DRTDevToolsClient::call):
962         * DumpRenderTree/chromium/DRTDevToolsClient.h:
963
964 2010-08-02  Kent Tamura  <tkent@chromium.org>
965
966         Reviewed by Dimitri Glazkov.
967
968         [DRT/Chromium] Remove dependencies to some Chromium headers
969         https://bugs.webkit.org/show_bug.cgi?id=43396
970
971         * DumpRenderTree/chromium/CppVariant.h:
972          Remove base/basictypes.h because webkit_support.h contains it.
973         * DumpRenderTree/chromium/EventSender.cpp:
974         (getCurrentEventTimeSec): Use new wrapper function.
975         * DumpRenderTree/chromium/TestNavigationController.h:
976          Remove base/basictypes.h because webkit_support.h contains it.
977         * DumpRenderTree/chromium/TestShell.cpp:
978         (dumpHistoryItem): Use new wrapper function.
979         * DumpRenderTree/chromium/WebViewHost.cpp:
980         (WebViewHost::cancelledError): Use new wrapper function.
981         (WebViewHost::didFailResourceLoad): Use new wrapper function.
982
983 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
984
985         Reviewed by Xan Lopez.
986
987         [GTK] DRT implement execCommand()
988         https://bugs.webkit.org/show_bug.cgi?id=35351
989
990         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
991         (LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name.
992         (LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled.
993         (LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled.
994
995 2010-08-02  Sam Weinig  <sam@webkit.org>
996
997         Reviewed by Anders Carlsson.
998
999         Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2).
1000
1001         * Scripts/old-run-webkit-tests:
1002
1003 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
1004
1005         WebKitTestRunner needs to support loading custom fonts (via the
1006         WEBKIT_TESTFONTS environment variable)
1007         https://bugs.webkit.org/show_bug.cgi?id=42782
1008
1009         Reviewed by Adam Roben.
1010
1011         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
1012         (WTR::fontsPath):
1013         Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
1014         as this directory doesn't appear to be created anymore.
1015         (WTR::activateFonts):
1016         Loop through the fonts, and call AddFontResourceExW() for each.
1017
1018 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
1019
1020         Restore the WebKitTestRunner.sln that was removed, and remove the
1021         correct one.
1022
1023         Rubber-stamped by Sam Weinig.
1024
1025         * WebKitTestRunner/WebKitTestRunner.sln: Added.
1026         * WebKitTestRunner/win/WebKitTestRunner.sln: Removed.
1027
1028 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
1029
1030         Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
1031
1032         Remove the unused WebKitTestRunner.sln.
1033
1034         Reviewed by Sam Weinig.
1035
1036         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1037         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed.
1038         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
1039         * WebKitTestRunner/win/InjectedBundle.vcproj: Added.
1040         * WebKitTestRunner/win/WebKitTestRunner.sln:
1041
1042 2010-08-02  Sam Weinig  <sam@webkit.org>
1043
1044         Fix the windows build.
1045
1046         * WebKitTestRunner/win/main.cpp:
1047
1048 2010-07-29  Jon Honeycutt  <jhoneycutt@apple.com>
1049
1050         Add a Skipped list on Windows, and have run-webkit-tests respect it.
1051
1052         Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
1053         there are zero tests failing
1054         https://bugs.webkit.org/show_bug.cgi?id=43374
1055
1056         Reviewed by Adam Roben.
1057
1058         * Scripts/old-run-webkit-tests:
1059         If using WebKitTestRunner and Apple Windows WebKit, set the platform to
1060         win-wk2. When building the result hierarchy, if the platform is win-wk2,
1061         add it first to the list of platforms.
1062
1063 2010-08-02  Darin Adler  <darin@apple.com>
1064
1065         Reviewed by Sam Weinig.
1066
1067         WebKitTestRunner needs layoutTestController.setCanOpenWindows
1068         https://bugs.webkit.org/show_bug.cgi?id=42321
1069
1070         WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
1071         https://bugs.webkit.org/show_bug.cgi?id=42779
1072
1073         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added
1074         setCanOpenWindows, setCloseRemainingWindowsWhenComplete, and windowCount
1075
1076         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1077         (WTR::InjectedBundle::InjectedBundle): Initialize m_mainPage to 0 instead of
1078         waiting for the first call to didCreatePage.
1079         (WTR::InjectedBundle::didCreatePage): Set m_mainPage only when the first page
1080         is created. Put other pages into a map.
1081         (WTR::InjectedBundle::willDestroyPage): Added code to handle the destruction
1082         of the main page.
1083         (WTR::InjectedBundle::closeOtherPages): Added. Closes all the pages other than
1084         the main page.
1085         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added pageCount and
1086         closeOtherPages functions.
1087
1088         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1089         (WTR::InjectedBundlePage::didFinishLoadForFrame): Don't let pages other than
1090         the main page affect dumping.
1091         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
1092
1093         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1094         (WTR::LayoutTestController::LayoutTestController): Initialize the new
1095         m_shouldCloseExtraWindows member.
1096         (WTR::LayoutTestController::setCanOpenWindows): Added. Empty for now.
1097         (WTR::LayoutTestController::windowCount): Added.
1098
1099         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1100         Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete,
1101         windowCount, shouldCloseExtraWindowsAfterRunningTest, and
1102         m_shouldCloseExtraWindows.
1103
1104         * WebKitTestRunner/TestController.cpp:
1105         (WTR::TestController::shared): Return a pointer to the shared copy, but
1106         don't allocate and leak it. This seemed cleaner than adding an explicit
1107         finalize call to go along with the explicit initialize call.
1108         (WTR::TestController::TestController): Added calls to the initialize and
1109         run function, which are now done automatically.
1110         (WTR::TestController::~TestController): Added, since it's called now.
1111         (WTR::closeOtherPage): Added. Used to close pages other than the main page.
1112         (WTR::createOtherPage): Added. Used to create pages other than the main page.
1113         (WTR::TestController::initialize): Added code to set up createOtherPage.
1114         (WTR::TestController::run): Removed unused return value.
1115         * WebKitTestRunner/TestController.h: Made constructor and destructor public,
1116         and initialize and run private. Changed m_mainWebView to be an OwnPtr.
1117
1118         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1119         (WTR::PlatformWebView::PlatformWebView): Added a call to setReleasedWhenClosed
1120         to avoid releasing the window twice. Another way to handle it would be to
1121         remove the release, but this approach is slightly more robust because it works
1122         even if some other code calls the close method an extra time.
1123
1124         * WebKitTestRunner/mac/main.mm:
1125         (main): Use a stack-allocated TestController object instead of calling
1126         initalize and run on a globally allocated one.
1127
1128 2010-08-02  Tony Chang  <tony@chromium.org>
1129
1130         Reviewed by David Levin.
1131
1132         add myself to the reviewers list
1133         https://bugs.webkit.org/show_bug.cgi?id=43366
1134
1135         * Scripts/webkitpy/common/config/committers.py:
1136
1137 2010-08-02  Anders Carlsson  <andersca@apple.com>
1138
1139         Reviewed by Sam Weinig.
1140
1141         Cache JSNPObjects and fix bugs in the object map
1142         https://bugs.webkit.org/show_bug.cgi?id=43368
1143
1144         Test that we correctly throw exceptions when trying to do things to a JSObject that used to
1145         wrap an NPObject that came from a plug-in that is now destroyed.
1146
1147         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1148         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1149         (PluginTest::Object::getProperty):
1150         (PluginTest::Object::NP_GetProperty):
1151         (PluginTest::Object::npClass):
1152         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp: Added.
1153         (NPRuntimeObjectFromDestroyedPlugin::NPRuntimeObjectFromDestroyedPlugin):
1154         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
1155         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::getProperty):
1156         (NPRuntimeObjectFromDestroyedPlugin::NPP_GetValue):
1157         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1158         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1159         * GNUmakefile.am:
1160
1161 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
1162
1163         Reviewed by Xan Lopez.
1164
1165         [Gtk] DOM listeners get wrong keycodes for some keys
1166         https://bugs.webkit.org/show_bug.cgi?id=35170
1167
1168         Add support to all event senders for simulating keypad insert
1169         and print screen keys.
1170
1171         * DumpRenderTree/chromium/EventSender.cpp:
1172         (EventSender::keyDown): Add support for generating keypad insert and print screen.
1173         * DumpRenderTree/gtk/EventSender.cpp:
1174         (keyDownCallback): Ditto.
1175         * DumpRenderTree/mac/EventSendingController.mm:
1176         (-[EventSendingController keyDown:withModifiers:withLocation:]): Ditto.
1177         * DumpRenderTree/qt/EventSenderQt.cpp:
1178         (EventSender::keyDown): Ditto.
1179         * DumpRenderTree/win/EventSender.cpp:
1180         (keyDownCallback): Ditto.
1181
1182 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
1183
1184         Build fix for building against development versions of GTK+. GTK 2.22
1185         has not yet been released, so these function definitions must be conditionalized
1186         on the development version.
1187
1188         * DumpRenderTree/gtk/EventSender.cpp: Fix GTK+ 2.21 build.
1189
1190 2010-08-02  Tony Chang  <tony@chromium.org>
1191
1192         Reviewed by Kent Tamura.
1193
1194         [chromium] use ChromiumDriver on Linux when running webkit tests
1195         https://bugs.webkit.org/show_bug.cgi?id=43273
1196
1197         * Scripts/webkitpy/layout_tests/port/chromium.py:
1198
1199 2010-08-02  Kent Tamura  <tkent@chromium.org>
1200
1201         Reviewed by Dimitri Glazkov.
1202
1203         [DRT/Chromium] Always initialize GTK
1204         https://bugs.webkit.org/show_bug.cgi?id=43327
1205
1206         Call gtk_init() in order to fix plugin test crash.
1207
1208         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1209         (main): Pass argc/argv to platformInit().
1210         * DumpRenderTree/chromium/TestShell.h:
1211         * DumpRenderTree/chromium/TestShellGtk.cpp:
1212         (platformInit): Update parameters, call gtk_init().
1213         * DumpRenderTree/chromium/TestShellMac.mm:
1214         (platformInit): Update parameters.
1215         * DumpRenderTree/chromium/TestShellWin.cpp:
1216         (platformInit): Update parameters.
1217
1218 2010-08-02  Balazs Kelemen  <kb@inf.u-szeged.hu>
1219
1220         Reviewed by Simon Hausmann.
1221
1222         [Qt] Generate forwarding headers for WebKit2
1223
1224         https://bugs.webkit.org/show_bug.cgi?id=43336
1225
1226         * Scripts/webkitdirs.pm: Call make on WebKit2/Makefile.DerivedSources.
1227
1228 2010-08-02  Fumitoshi Ukai  <ukai@chromium.org>
1229
1230         Reviewed by Kent Tamura.
1231
1232         WebSocket server should start with SO_REUSEADDR
1233         https://bugs.webkit.org/show_bug.cgi?id=43329
1234
1235         Pulls in pywebsocket-0.5.2.
1236         pywebsocket-0.5.2 includes a small fix to start server with SO_REUSE_ADDR.
1237         http://code.google.com/p/pywebsocket/source/detail?r=273
1238
1239         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version
1240
1241 2010-08-01  Kent Tamura  <tkent@chromium.org>
1242
1243         Reviewed by Dimitri Glazkov.
1244
1245         [DRT/Chromium] Remove string_util.h dependency
1246         https://bugs.webkit.org/show_bug.cgi?id=43312
1247
1248         * DumpRenderTree/chromium/LayoutTestController.cpp:
1249         (LayoutTestController::pathToLocalResource):
1250          Use string::find() instead of StartsWithASCII().
1251         (LayoutTestController::cppVariantToInt32):
1252          Use strtol() instead of StringToNumber().
1253
1254 2010-08-01  Sam Weinig  <sam@webkit.org>
1255
1256         Reviewed by Anders Carlsson.
1257
1258         Add ability to reset frame names for WebKitTestRunner
1259         https://bugs.webkit.org/show_bug.cgi?id=43316
1260
1261         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1262         (WTR::InjectedBundle::reset):
1263         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1264         (WTR::InjectedBundlePage::reset):
1265         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1266
1267 2010-08-01  Anders Carlsson  <andersca@apple.com>
1268
1269         Reviewed by Sam Weinig.
1270
1271         Implement NPN_RemoveProperty
1272         https://bugs.webkit.org/show_bug.cgi?id=43315
1273
1274         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1275         Add NPRuntimeRemoveProperty.cpp
1276         
1277         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1278         (PluginTest::NPN_GetStringIdentifier):
1279         (PluginTest::NPN_GetIntIdentifier):
1280         (PluginTest::NPN_RemoveProperty):
1281         Add NPN_ helpers.
1282
1283         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1284         Support more NPClass functions.
1285
1286         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: Added.
1287         (NPRuntimeRemoveProperty::NPRuntimeRemoveProperty):
1288         Test for NPN_RemoveProperty.
1289
1290         (NPRuntimeRemoveProperty::TestObject::hasMethod):        
1291         (NPRuntimeRemoveProperty::TestObject::invoke):
1292         Add a testRemoveProperty method.
1293
1294         (NPRuntimeRemoveProperty::NPP_GetValue):
1295         Return the test object.
1296
1297         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1298         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1299         * GNUmakefile.am:
1300         Add NPRuntimeRemoveProperty.cpp
1301
1302 2010-07-30  Anders Carlsson  <andersca@apple.com>
1303
1304         Reviewed by Sam Weinig.
1305
1306         Add an NPObject class template helper to TestNetscapePlugin
1307         https://bugs.webkit.org/show_bug.cgi?id=43288
1308
1309         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1310         Add some template magic to be able to figure out if a class has a member function of a given type.
1311
1312         (PluginTest::Object::create):
1313         Create an object.
1314
1315         (PluginTest::Object::invokeDefault):
1316         Add dummy function, this should never be called.
1317
1318         (PluginTest::Object::Object):
1319         Initialize m_pluginTest to 0.
1320
1321         (PluginTest::Object::~Object):
1322         Add virtual destructor.
1323
1324         (PluginTest::Object::NP_Allocate):
1325         Create a new object.
1326
1327         (PluginTest::Object::NP_Deallocate):
1328         Delete the object.
1329
1330         (PluginTest::Object::NP_InvokeDefault):
1331         Call invokeDefault.
1332
1333         (PluginTest::Object::npClass):
1334         Initialize the NPClass struct.
1335
1336         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
1337         (DocumentOpenInDestroyStream::NPP_DestroyStream):
1338         Move this inline.
1339
1340         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
1341         (PluginScriptableNPObjectInvokeDefault::NPObjectWithInvokeDefault::invokeDefault):
1342         (PluginScriptableNPObjectInvokeDefault::NPP_GetValue):
1343         Use the PluginTest::Object class template.
1344
1345 2010-07-31  Sam Weinig  <sam@webkit.org>
1346
1347         Reviewed by Dan Bernstein.
1348
1349         Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
1350         Add back WKBundleFrameCopyInnerText to fix ~50 test failures
1351         due to SVGElements not having the innerText function.
1352
1353         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1354         (WTR::dumpFrameText):
1355
1356 2010-07-30  Sam Weinig  <sam@webkit.org>
1357
1358         Reviewed by Maciej Stachowiak.
1359
1360         Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
1361         Add structured message passing from the injected bundle to UIProcess
1362
1363         * MiniBrowser/mac/AppDelegate.m:
1364         (didRecieveMessageFromInjectedBundle):
1365         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1366         (didClearWindowForFrame):
1367         (didRecieveMessage):
1368         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1369         (WTR::InjectedBundle::done):
1370         (WTR::InjectedBundle::didReceiveMessage):
1371         * WebKitTestRunner/TestController.cpp:
1372         (WTR::TestController::initialize):
1373         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1374         * WebKitTestRunner/TestController.h:
1375         * WebKitTestRunner/TestInvocation.cpp:
1376         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1377         * WebKitTestRunner/TestInvocation.h:
1378         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1379
1380 2010-07-30  Sam Weinig  <sam@webkit.org>
1381
1382         Reviewed by Anders Carlsson.
1383
1384         Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
1385         Make WKArrayRef more usable.
1386
1387         Remove now unnecessary const_casts.
1388
1389         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1390         (WTR::dumpDescendantFrameScrollPositions):
1391         (WTR::dumpDescendantFramesText):
1392
1393 2010-07-30  Sam Weinig  <sam@webkit.org>
1394
1395         Reviewed by Anders Carlsson.
1396
1397         Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
1398         Add first pass of structured message passing.
1399
1400         Update Minibrowser and WebKitTestRunner to work with the new post message
1401         function.
1402
1403         * MiniBrowser/mac/AppDelegate.m:
1404         (didRecieveMessageFromInjectedBundle):
1405         (-[BrowserAppDelegate init]):
1406         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1407         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1408         (didStartProvisionalLoadForFrame):
1409         (didReceiveServerRedirectForProvisionalLoadForFrame):
1410         (didFailProvisionalLoadWithErrorForFrame):
1411         (didCommitLoadForFrame):
1412         (didFinishLoadForFrame):
1413         (didFailLoadWithErrorForFrame):
1414         (didReceiveTitleForFrame):
1415         (didClearWindowForFrame):
1416         (didCreatePage):
1417         (willDestroyPage):
1418         (didRecieveMessage):
1419         (WKBundleInitialize):
1420         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1421         (WTR::InjectedBundle::_didReceiveMessage):
1422         (WTR::InjectedBundle::didReceiveMessage):
1423         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1424         * WebKitTestRunner/TestInvocation.cpp:
1425         (WTR::TestInvocation::invoke):
1426         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1427
1428 2010-07-30  Anders Carlsson  <andersca@apple.com>
1429
1430         Try to fix the layout test failures.
1431
1432         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1433         (webkit_test_plugin_get_value):
1434
1435 2010-07-29  Anders Carlsson  <andersca@apple.com>
1436
1437         Reviewed by Adam Roben.
1438
1439         Replace plugins/npruntime/bindings-test.html with a more sophisticated test
1440         https://bugs.webkit.org/show_bug.cgi?id=43232
1441
1442         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1443         Add PluginScriptableNPObjectInvokeDefault.cpp.
1444
1445         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1446         Remove invokeDefault callback function.
1447
1448         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1449         (PluginTest::create):
1450         Move this to the top of the file.
1451
1452         (PluginTest::NPP_GetValue):
1453         Add default implementation.
1454
1455         (PluginTest::NPN_CreateObject):
1456         Add NPN_ wrapper.
1457
1458         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1459         (PluginTest::identifier):
1460         Add identifier getter.
1461
1462         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
1463         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
1464         Add "using namespace std".
1465
1466         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1467         (NPP_GetValue):
1468         Give PluginTest a chance to return a value.
1469
1470         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1471         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1472         * GNUmakefile.am:
1473         Add PluginScriptableNPObjectInvokeDefault.cpp.
1474         
1475         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1476         (webkit_test_plugin_get_value):
1477         Give PluginTest a chance to return a value.
1478
1479 2010-07-30  Steve Block  <steveblock@google.com>
1480
1481         Reviewed by Steve Block.
1482
1483         Add LayoutTestController methods to test DeviceOrientation
1484         https://bugs.webkit.org/show_bug.cgi?id=39589
1485
1486         * DumpRenderTree/LayoutTestController.cpp:
1487         (setMockDeviceOrientationCallback):
1488         (LayoutTestController::staticFunctions):
1489         * DumpRenderTree/LayoutTestController.h:
1490         * DumpRenderTree/chromium/LayoutTestController.cpp:
1491         (LayoutTestController::LayoutTestController):
1492         (LayoutTestController::setMockDeviceOrientation):
1493         * DumpRenderTree/chromium/LayoutTestController.h:
1494         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1495         (LayoutTestController::setMockDeviceOrientation):
1496         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1497         (LayoutTestController::setMockDeviceOrientation):
1498         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1499         (LayoutTestController::setMockDeviceOrientation):
1500         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1501         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1502         (LayoutTestController::setMockDeviceOrientation):
1503         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1504         (LayoutTestController::setMockDeviceOrientation):
1505         * Scripts/build-webkit:
1506
1507 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
1508
1509         Reviewed by Kenneth Christiansen.
1510
1511         [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
1512         https://bugs.webkit.org/show_bug.cgi?id=43209
1513
1514         When -resizes-to-content was being passed as a command line parameter it was simply
1515         not being set (although the corresponding menu item was marked as ON).
1516         User had to toggle the menu OFF and then ON again for it to take place.
1517
1518         Reason: LauncherWindow::applyPrefs method sets many user options passed in from
1519         the command line, but not resizesToContents. Patch addresses that.
1520
1521         * QtTestBrowser/launcherwindow.cpp:
1522         (LauncherWindow::createChrome):
1523         (LauncherWindow::applyPrefs):
1524         (LauncherWindow::toggleResizesToContents):
1525         * QtTestBrowser/webview.h:
1526         (WebViewGraphicsBased::resizesToContents):
1527
1528 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
1529
1530         Rubber-stamped by Simon Fraser.
1531
1532         [Qt] QtTestBrowser: more method grouping and clean ups.
1533
1534         Moving blocks of code around. Basically grouping related methods close to each.
1535
1536         * QtTestBrowser/launcherwindow.cpp:
1537         (LauncherWindow::initializeView):
1538         (LauncherWindow::createChrome):
1539         (LauncherWindow::changeViewportUpdateMode):
1540         (LauncherWindow::showFPS):
1541         (LauncherWindow::newWindow):
1542         (LauncherWindow::cloneWindow):
1543         * QtTestBrowser/launcherwindow.h:
1544
1545 2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1546
1547         Reviewed by Tor Arne Vestbø.
1548
1549         [QT][Symbian] QtTestBrowser missing location capabilities
1550         https://bugs.webkit.org/show_bug.cgi?id=43235
1551
1552         QtTestBrowser missing capabilities to use QtMobility::QLocation. 
1553
1554         * QtTestBrowser/QtTestBrowser.pro:
1555
1556 2010-07-29  Anders Carlsson  <andersca@apple.com>
1557
1558         Add PluginTest.cpp
1559
1560         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1561
1562 2010-07-29  Dirk Pranke  <dpranke@chromium.org>
1563
1564         Reviewed by Eric Seidel.
1565
1566         Update download URLs for python irclib package; the old URLs 
1567         pointed at a specific mirror host and not the general sourceforge
1568         URLs.
1569
1570         https://bugs.webkit.org/show_bug.cgi?id=43228
1571
1572         * Scripts/webkitpy/thirdparty/__init__.py:
1573
1574 2010-07-29  Anders Carlsson  <andersca@apple.com>
1575
1576         Fix typo.
1577
1578         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1579
1580 2010-07-29  Anders Carlsson  <andersca@apple.com>
1581
1582         Another attempt at fixing the Qt and GTK+ build.
1583
1584         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1585         (webkit_test_plugin_new_instance):
1586         (webkit_test_plugin_destroy_stream):
1587
1588 2010-07-29  Anders Carlsson  <andersca@apple.com>
1589
1590         Another build fix attempt.
1591
1592         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1593         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1594         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1595         (webkit_test_plugin_new_instance):
1596         * GNUmakefile.am:
1597
1598 2010-07-29  Anders Carlsson  <andersca@apple.com>
1599
1600         Try to fix Windows and Unix builds.
1601
1602         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1603         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1604         (webkit_test_plugin_new_instance):
1605         (webkit_test_plugin_destroy_stream):
1606
1607 2010-07-29  Anders Carlsson  <andersca@apple.com>
1608
1609         Reviewed by Sam Weinig.
1610
1611         Refactor TestNetscapePlugin so tests can be split in separate files
1612         https://bugs.webkit.org/show_bug.cgi?id=43220
1613
1614         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1615         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
1616
1617         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1618         (pluginAllocate):
1619         Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream.
1620
1621         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1622         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added.
1623         (PluginTest::PluginTest):
1624         Initialize m_npp and the test identifier.
1625         
1626         (PluginTest::createTestFunctions):
1627         Return the map from identifiers to createTest functions.
1628
1629         (PluginTest::registerCreateTestFunction):
1630         Insert the identifier and create function pair in the map.
1631
1632         (PluginTest::create):
1633         Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object.
1634
1635         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added.
1636         (PluginTest::Register::Register):
1637         Helper class template for registering plug-in tests.
1638         
1639         (PluginTest::Register::create):
1640         Create a new test of the given type.
1641
1642         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added.
1643         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
1644         Add a test that calls testDocumentOpen from its NPP_DestroyStream callback.
1645
1646         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1647         (NPP_New):
1648         Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream".
1649
1650         (NPP_DestroyStream):
1651         Call the plug-in test NPP_DestroyStream member function.
1652
1653         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1654         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
1655
1656 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
1657
1658         Unreviewed build fix.
1659
1660         Add missing second argument to assert_lint in new style checker tests.
1661
1662         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1663
1664 2010-07-29  Anders Carlsson  <andersca@apple.com>
1665
1666         Reviewed by Adam Roben.
1667
1668         check-webkit-style shouldn't complain about NPAPI functions
1669         https://bugs.webkit.org/show_bug.cgi?id=43211
1670
1671         Allow underscores in functions that start with NPN_, NPP_ or NP_.
1672
1673         * Scripts/webkitpy/style/checkers/cpp.py:
1674         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1675
1676 2010-07-29  Victor Wang  <victorw@chromium.org>
1677
1678         Unreviewed, rolling out r64270.
1679         http://trac.webkit.org/changeset/64270
1680         https://bugs.webkit.org/show_bug.cgi?id=39589
1681
1682         The patch breaks chromium webkit unittest
1683
1684         * DumpRenderTree/LayoutTestController.cpp:
1685         (LayoutTestController::staticFunctions):
1686         * DumpRenderTree/LayoutTestController.h:
1687         * DumpRenderTree/chromium/LayoutTestController.cpp:
1688         (LayoutTestController::LayoutTestController):
1689         * DumpRenderTree/chromium/LayoutTestController.h:
1690         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1691         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1692         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1693         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1694         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1695         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1696         * Scripts/build-webkit:
1697
1698 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
1699
1700         Reviewed by Kenneth Christiansen.
1701
1702         [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp
1703         https://bugs.webkit.org/show_bug.cgi?id=43199
1704
1705         There is no sense in keeping WebPage method definitions in main.cpp once
1706         webpage.cpp already exists.
1707
1708         No behavior change.
1709
1710         * QtTestBrowser/main.cpp:
1711         * QtTestBrowser/webpage.cpp:
1712         (WebPage::createWindow):
1713         (WebPage::createPlugin):
1714
1715 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
1716
1717         Reviewed by Kenneth Christiansen.
1718
1719         [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)
1720         https://bugs.webkit.org/show_bug.cgi?id=43170
1721
1722         Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:
1723         launcherwindow.{cpp|h}
1724
1725         No behavior change.
1726
1727         Also changed all global static variables (named "gXXX") from main.cpp to
1728         static public variables of the LauncherWindow class.
1729
1730         * QtTestBrowser/QtTestBrowser.pro:
1731         * QtTestBrowser/launcherwindow.cpp: Added.
1732         * QtTestBrowser/launcherwindow.h: Added.
1733         * QtTestBrowser/main.cpp:
1734         (LauncherApplication::handleUserOptions):
1735         (main):
1736
1737 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
1738
1739         Reviewed by Xan Lopez.
1740
1741         Build fix for building against GTK+ 3.x. GSEAL requires that we
1742         access internals of the GdkDragContext via methods. For older versions
1743         of GTK+, define those methods.
1744
1745         * DumpRenderTree/gtk/EventSender.cpp:
1746         (gdk_drag_context_get_selected_action): Added.
1747         (gdk_drag_context_get_actions): Added.
1748         (dispatchEvent): Use the two new accessor methods.
1749
1750 2010-07-29  Adam Roben  <aroben@apple.com>
1751
1752         Always say "plugins directory" when referring to a directory
1753         containing one or more plugins
1754
1755         Fixes <http://webkit.org/b/43197> WebKit2 often says "plugin
1756         directory" when it means "plugins directory"
1757
1758         Reviewed by John Sullivan.
1759
1760         * WebKitTestRunner/TestController.cpp:
1761         (WTR::TestController::initialize): Updated for rename.
1762
1763 2010-07-29  Adam Roben  <aroben@apple.com>
1764
1765         Always say "directory" when referring to a plugin directory
1766
1767         Fixes <http://webkit.org/b/43195> WebKit2 often says "plugin path"
1768         when it means "plugin directory"
1769
1770         Reviewed by John Sullivan.
1771
1772         * WebKitTestRunner/TestController.cpp:
1773         (WTR::TestController::initialize): Updated for renames.
1774
1775         * WebKitTestRunner/TestController.h: Renamed m_testPluginPath to
1776         m_testPluginDirectory.
1777         (WTR::TestController::testPluginDirectory): Renamed from
1778         testPluginPath.
1779
1780         * WebKitTestRunner/mac/TestControllerMac.mm:
1781         (WTR::TestController::initializeTestPluginDirectory):
1782         * WebKitTestRunner/win/TestControllerWin.cpp:
1783         (WTR::TestController::initializeTestPluginDirectory):
1784         Renamed from initializeTestPluginPath and updated for rename.
1785
1786 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
1787
1788          Reviewed by Antonio Gomes.
1789
1790          Initialize all members of NPClass struct.
1791          https://bugs.webkit.org/show_bug.cgi?id=43193
1792
1793          * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1794
1795 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
1796
1797         Reviewed by Antonio Gomes.
1798
1799         Warning fix on platforms where XP_MACOSX is undefined.
1800         https://bugs.webkit.org/show_bug.cgi?id=43192
1801
1802         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1803         Use #if defined(XP_MACOSX) instead of #if XP_MACOSX .
1804
1805 2010-07-29  Adam Roben  <aroben@apple.com>
1806
1807         Give find-included-framework-headers our standard license
1808
1809         * Scripts/find-included-framework-headers: Used the license from
1810         WebCore/LICENSE-APPLE.
1811
1812 2010-07-29  Adam Roben  <aroben@apple.com>
1813
1814         Speed up find-included-framework-headers
1815
1816         We only do one invocation of find now, no longer pipe to grep, and
1817         replace uniq with sort -u.
1818
1819         Also added a license header.
1820
1821         * Scripts/find-included-framework-headers:
1822
1823 2010-07-29  Steve Block  <steveblock@google.com>
1824
1825         Reviewed by Jeremy Orlow.
1826
1827         Add LayoutTestController methods to test DeviceOrientation
1828         https://bugs.webkit.org/show_bug.cgi?id=39589
1829
1830         * DumpRenderTree/LayoutTestController.cpp:
1831         (setMockDeviceOrientationCallback):
1832         (LayoutTestController::staticFunctions):
1833         * DumpRenderTree/LayoutTestController.h:
1834         * DumpRenderTree/chromium/LayoutTestController.cpp:
1835         * DumpRenderTree/chromium/LayoutTestController.h:
1836         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1837         (LayoutTestController::setMockDeviceOrientation):
1838         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1839         (LayoutTestController::setMockDeviceOrientation):
1840         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1841         (LayoutTestController::setMockDeviceOrientation):
1842         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1843         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1844         (LayoutTestController::setMockDeviceOrientation):
1845         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1846         (LayoutTestController::setMockDeviceOrientation):
1847         * Scripts/build-webkit:
1848
1849 2010-07-28  Kenichi Ishibashi  <bashi@google.com>
1850
1851         Reviewed by Shinichiro Hamaji.
1852
1853         Fixed <https://bugs.webkit.org/show_bug.cgi?id=33814>
1854         check-webkit-style gives false positives in single-line functions.
1855
1856         * Scripts/webkitpy/style/checkers/cpp.py:
1857         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1858
1859 2010-07-28  Darin Adler  <darin@apple.com>
1860
1861         Reviewed by Sam Weinig.
1862
1863         WebKitTestRunner needs to support layoutTestController.execCommand
1864         <https://bugs.webkit.org/show_bug.cgi?id=42538>
1865
1866         WebKitTestRunner needs layoutTestController.isCommandEnabled
1867         <https://bugs.webkit.org/show_bug.cgi?id=42671>
1868
1869         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1870         Added execCommand and isCommandEnabled.
1871         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1872         (WTR::LayoutTestController::execCommand): Added.
1873         (WTR::LayoutTestController::isCommandEnabled): Added.
1874         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
1875
1876 2010-07-28  Kent Tamura  <tkent@chromium.org>
1877
1878         Reviewed by Dimitri Glazkov.
1879
1880         [DRT/Chromium] Introduce drt_expectations.txt for NRWT
1881         https://bugs.webkit.org/show_bug.cgi?id=43123
1882
1883         Introduce LayoutTests/platform/chromium/drt_expectations.txt,
1884         which overrides test expectations only for DumpRenderTree, in
1885         order to manage what problems are investigated.
1886         This change will be reverted when we switch to DRT completely.
1887
1888         * Scripts/webkitpy/layout_tests/port/chromium.py:
1889          Add drt_expectations.txt content to the result of
1890          test_expectations_overrides() if --use-drt is specified.
1891
1892 2010-07-28  Brady Eidson  <beidson@apple.com>
1893
1894         Reviewed by Darin Adler.
1895
1896         First pass at visited link support for WK2
1897         https://bugs.webkit.org/show_bug.cgi?id=43157
1898
1899         * MiniBrowser/mac/AppDelegate.m:
1900         (didNavigateWithNavigationData):
1901         (didPerformClientRedirect):
1902         (didPerformServerRedirect):
1903         (didUpdateHistoryTitle):
1904         (populateVisitedLinks): Added for the new version of the HistoryClient.
1905         (-[BrowserAppDelegate init]): Set the HistoryClient right after creating the context(s)
1906         
1907         * MiniBrowser/mac/BrowserWindowController.m:
1908         (-[BrowserWindowController awakeFromNib]):
1909
1910 2010-07-28  Robin Dunn  <robin@alldunn.com>
1911
1912         Reviewed by Kevin Ollivier.
1913
1914         Add DOM bindings support for wx port.
1915
1916         * DumpRenderTree/wscript:
1917         * wx/browser/wscript:
1918         * wx/build/settings.py:
1919
1920 2010-07-28  Tony Chang  <tony@chromium.org>
1921
1922         Reviewed by Kent Tamura.
1923
1924         [chromium] cleanup temp files left by Linux DRT
1925         https://bugs.webkit.org/show_bug.cgi?id=43062
1926
1927         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
1928         * BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left
1929             by crashed DRTs
1930
1931 2010-07-28  Antonio Gomes  <tonikitoo@webkit.org>
1932
1933         Rubber-stamped by Kenneth Christiansen.
1934
1935         More Developer menu items reordering.
1936
1937         Grouping related menu items together, visually and logically (in the code).
1938
1939         No behavior change.
1940
1941         * QtTestBrowser/main.cpp:
1942         (LauncherWindow::createChrome):
1943
1944 2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>
1945
1946         Reviewed by Ojan Vafai.
1947
1948         Add FILE_SYSTEM build flag for FileSystem API
1949         https://bugs.webkit.org/show_bug.cgi?id=42915
1950
1951         * Scripts/build-webkit:
1952
1953 2010-07-27  Martin Robinson  <mrobinson@igalia.com>
1954
1955         Reviewed by David Levin.
1956
1957         Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to
1958         https://bugs.webkit.org/show_bug.cgi?id=43090
1959
1960         * Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods.
1961         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior.
1962
1963 2010-07-27  Kent Tamura  <tkent@chromium.org>
1964
1965         Unreviewed, trivial typo fix.
1966
1967         * Scripts/webkitpy/layout_tests/port/chromium.py:
1968           Fix a wrong method name committed by r64109.
1969
1970 2010-07-27  Sam Weinig  <sam@webkit.org>
1971
1972         Reviewed by Anders Carlsson.
1973
1974         Patch for https://bugs.webkit.org/show_bug.cgi?id=43087
1975         Clean up handling of strings at the WebKit2 API layer.
1976
1977         * MiniBrowser/mac/BrowserWindowController.m:
1978         (runJavaScriptAlert):
1979         (runJavaScriptConfirm):
1980         (runJavaScriptPrompt):
1981         (didNavigateWithNavigationData):
1982         (-[BrowserWindowController updateProvisionalURLForFrame:]):
1983         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1984         (_didClearWindowForFrame):
1985
1986 2010-07-27  Ojan Vafai  <ojan@chromium.org>
1987
1988         Reviewed by Eric Seidel.
1989
1990         webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'
1991         https://bugs.webkit.org/show_bug.cgi?id=42984
1992
1993         squash and no_squash have been intentionally erroring for a couple weeks now.
1994         But post-commits was just broken. Just remove squash/no_squash.
1995
1996         * Scripts/webkitpy/tool/steps/abstractstep.py:
1997         * Scripts/webkitpy/tool/steps/options.py:
1998
1999 2010-07-27  Kevin Ollivier  <kevino@theolliviers.com>
2000
2001         [wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.
2002
2003         * wx/build/settings.py:
2004
2005 2010-07-27  Adam Roben  <aroben@apple.com>
2006
2007         Mac build fix
2008
2009         * MiniBrowser/mac/BrowserWindowController.m:
2010         (processDidExit):
2011         (-[BrowserWindowController awakeFromNib]):
2012         Added processDidExit support.
2013
2014 2010-07-26  Antonio Gomes  <tonikitoo@webkit.org>
2015
2016         Rubber-stamped by Simon Hausmann.
2017
2018         [Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible.
2019
2020         Move some less useful menu items on Developers menu from the top to the bottom, so
2021         QGraphicsView menu goes to the top, and becomes more quickly accessible.
2022
2023         * QtTestBrowser/main.cpp:
2024         (LauncherWindow::createChrome):
2025
2026 2010-07-26  Adam Roben  <aroben@apple.com>
2027
2028         Fix the path to InjectedBundle.dll in Debug_Internal builds
2029
2030         Fixes <http://webkit.org/b/42994> WebKitTestRunner fails to load
2031         InjectedBundle.dll in the Debug_Internal configuration
2032
2033         Reviewed by Anders Carlsson.
2034
2035         * WebKitTestRunner/win/TestControllerWin.cpp:
2036         (WTR::TestController::initializeInjectedBundlePath): Add the _debug
2037         suffix only in Debug_All builds.
2038
2039 2010-07-25  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2040
2041         Reviewed by Darin Adler.
2042
2043         https://bugs.webkit.org/show_bug.cgi?id=42947
2044         Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw 
2045         error. Without which dumpRenderTree crashes.
2046
2047         * Scripts/old-run-webkit-tests:
2048
2049 2010-07-27  Kent Tamura  <tkent@chromium.org>
2050
2051         Reviewed by Dimitri Glazkov.
2052
2053         https://bugs.webkit.org/show_bug.cgi?id=42956
2054         [DRT/Chromium] Fix "out of sync" assertion error
2055
2056         Fix an assertion error on Windows like the following:
2057         100721 20:16:46 chromium.py:386  CRITICAL Test got out of sync:
2058         |file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
2059         |file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
2060
2061         * Scripts/webkitpy/layout_tests/port/chromium.py:
2062         If the url matches with "file:///[a-z]:", does case-ignore comparison.
2063         GURL capitalize the driver letter of a file: URL.
2064
2065 2010-07-26  Darin Adler  <darin@apple.com>
2066
2067         Reviewed by Sam Weinig.
2068
2069         WebKitTestRunner needs to support layoutTestController.counterValueForElementById
2070         https://bugs.webkit.org/show_bug.cgi?id=42537
2071
2072         WebKitTestRunner needs layoutTestController.markerTextForListItem
2073         https://bugs.webkit.org/show_bug.cgi?id=42549
2074
2075         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2076         Fixed _paramterExpression typo. Improved support for string type as a
2077         return value, so we don't try to include DOMString.h and we can convert
2078         the string to a JSValue by calling JSValueMakeStringOrNull.
2079
2080         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
2081         Added JSValueMakeStringOrNull, used by the code generator.
2082
2083         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2084         Added counterValueForElementById and markerTextForListItem.
2085
2086         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2087         Moved constant to the top of the file.
2088         (WTR::toCF): Added. Converts strings to CFStringRef.
2089         (WTR::toWK): Added. Converts strings to WKStringRef.
2090         (WTR::toJS): Added. Converts strings to JSStringRef.
2091         (WTR::setProperty): Moved this function to the top of the file
2092         rather than having it down where it's used inside the class. Also
2093         renamed it so it's a separate function rather than an overload of
2094         JSObjectSetProperty.
2095         (WTR::propertyValue): Copied this here from InjectedBundlePage.cpp.
2096         Should move it somewhere we can share it.
2097         (WTR::propertyObject): Ditto.
2098         (WTR::getElementById): Added. Calls getElementById through the magic
2099         of JavaScript.
2100         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2101         Chagned to use toWK instead of four local variables.
2102         (WTR::LayoutTestController::counterValueForElementById): Added.
2103         Calls WKBundleFrameCopyCounterValue.
2104         (WTR::LayoutTestController::markerTextForListItem): Added.
2105         Calls WKBundleFrameCopyMarkerText.
2106
2107         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2108         Added counterValueForElementById and markerTextForListItem.
2109
2110 2010-07-26  Martin Robinson  <mrobinson@igalia.com>
2111
2112         Reviewed by Gustavo Noronha Silva.
2113
2114         [GTK] The EventSender should support simulating drop events
2115         https://bugs.webkit.org/show_bug.cgi?id=39844
2116
2117         Add initial dropping support to the GTK+ EventSender.
2118
2119         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2120         (createWebView): Listen for some new drag-and-drop signals.
2121         * DumpRenderTree/gtk/EventSender.cpp: Add currentDragSourceContext.
2122         (dispatchEvent):
2123         Detect situations where a drag is either starting or ending and massage
2124         GTK+ into sending the appropriate signals to the WebView.
2125         (replaySavedEvents): Remove comment.
2126         (makeEventSender): Clear the currentDragSourceContext when creating a new EventSender.
2127         (dragBeginCallback): Capture the new currentDragSourceContext when a drag begins.
2128         (dragEndCallback): Clear the currentDragSourceContext when a drag ends.
2129         (dragFailedCallback): Disable the GTK+ drag failed animation.
2130         * DumpRenderTree/gtk/EventSender.h: Add declarations for new signal callbacks.
2131
2132 2010-07-26  Daniel Bates  <dbates@rim.com>
2133
2134         Reviewed by Darin Adler.
2135
2136         svn-unapply warns of uninitialized variable when unapplying
2137         a patch that describes an svn move operation
2138         https://bugs.webkit.org/show_bug.cgi?id=42036
2139
2140         Fixes Perl uninitialized variable warnings when un-applying
2141         a patch that moves a file.
2142
2143         * Scripts/svn-unapply:
2144           - Modified patch() so that it initializes $patch to the empty
2145             string when we don't have svnConvertedText (such as when
2146             reversing a diff that represents a svn copy/move operation).
2147
2148 2010-07-26  Sam Weinig  <sam@webkit.org>
2149
2150         Reviewed by Anders Carlsson.
2151
2152         Move some non-APIish functions into private headers.
2153
2154         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2155         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2156
2157 2010-07-26  Sam Weinig  <sam@webkit.org>
2158
2159         Reviewed by Anders Carlsson.
2160
2161         Fix for https://bugs.webkit.org/show_bug.cgi?id=42986
2162         Add prompt and confirm client functions to WebKit2
2163
2164         * MiniBrowser/mac/BrowserWindowController.m:
2165         (-[BrowserWindowController awakeFromNib]):
2166
2167 2010-07-26  Adam Roben  <aroben@apple.com>
2168
2169         Windows build fix
2170
2171         * MiniBrowser/MiniBrowser.vcproj:
2172         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
2173         Removed empty attributes so the values will be picked up from the
2174         vsprops files. (Also removed a couple of attributes that accidentally
2175         duplicated values from the vsprops files.)
2176
2177 2010-07-26  Brian Weinstein  <bweinstein@apple.com>
2178
2179         Rubber-stamped by Adam Roben.
2180         
2181         Touch MiniBrowser's stdafx to fix the build.
2182
2183         * MiniBrowser/win/stdafx.h:
2184
2185 2010-07-26  Hayato Ito  <hayato@chromium.org>
2186
2187         Reviewed by Shinichiro Hamaji.
2188
2189         Add pretty printer of WTF::Vector for GDB 7.
2190
2191         https://bugs.webkit.org/show_bug.cgi?id=40909
2192
2193         * gdb/wtf.py: Added.
2194
2195 2010-07-26  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2196
2197         Reviewed by Simon Hausmann.
2198
2199         [Qt] Fix feature detection regexp
2200
2201         We were missing the last feature
2202
2203         * Scripts/webkitdirs.pm:
2204
2205 2010-07-25  Darin Adler  <darin@apple.com>
2206
2207         Reviewed by Dan Bernstein.
2208
2209         WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
2210         https://bugs.webkit.org/show_bug.cgi?id=42326
2211
2212         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2213         Added dumpSelectionRect.
2214
2215         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2216         (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
2217         does nothing because its purpose is to change pixel test output and
2218         we do not have pixel tests implemented yet.
2219
2220 2010-07-25  Darin Adler  <darin@apple.com>
2221
2222         Reviewed by Maciej Stachowiak.
2223
2224         WebKitTestRunner needs to support layoutTestController.keepWebHistory
2225         https://bugs.webkit.org/show_bug.cgi?id=42323
2226
2227         Added keepWebHistory and computedStyleIncludingVisitedInfo.
2228
2229         Also fixed misspellings of the word "receive".
2230
2231         Also tweaked the names of some of the LayoutTestController members.
2232
2233         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2234         Added support for a type named "object" that is passed and returns as
2235         a JSValueRef.
2236
2237         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2238         Added keepWebHistory and computedStyleIncludingVisitedInfo. Also
2239         put setAcceptsEditing up nearer the top.
2240
2241         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2242         (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive.
2243         (WTR::InjectedBundle::initialize): Ditto.
2244         (WTR::InjectedBundle::didReceiveMessage): Ditto.
2245         (WTR::InjectedBundle::reset): Reset the state of visited links between
2246         tests. Also eliminated the unused argument to the LayoutTestController
2247         create function.
2248         (WTR::InjectedBundle::setShouldTrackVisitedLinks): Added.
2249         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
2250
2251         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2252         (WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing
2253         instead of acceptsEditing.
2254         (WTR::InjectedBundlePage::shouldEndEditing): Ditto.
2255         (WTR::InjectedBundlePage::shouldInsertNode): Ditto.
2256         (WTR::InjectedBundlePage::shouldInsertText): Ditto.
2257         (WTR::InjectedBundlePage::shouldDeleteRange): Ditto.
2258         (WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto.
2259         (WTR::InjectedBundlePage::shouldApplyStyle): Ditto.
2260
2261         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2262         (WTR::LayoutTestController::create): Removed uneeded argument.
2263         (WTR::LayoutTestController::LayoutTestController): Removed unneeded
2264         argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing.
2265         (WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs
2266         about the fact that this works on the main frame.
2267         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
2268         (WTR::LayoutTestController::keepWebHistory): Added.
2269         (WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added.
2270         (WTR::JSObjectSetProperty): Added. Helper to make the function below
2271         cleaner.
2272         (WTR::LayoutTestController::makeWindowObject): Changed to use the
2273         overload of JSObjectSetProperty above.
2274
2275         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to
2276         match above.
2277
2278         * WebKitTestRunner/TestController.cpp:
2279         (WTR::TestController::initialize): Fixed mispellings of receive.
2280         (WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto.
2281         (WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto.
2282         * WebKitTestRunner/TestController.h: Ditto.
2283         * WebKitTestRunner/TestInvocation.cpp:
2284         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto.
2285         * WebKitTestRunner/TestInvocation.h: Ditto.
2286
2287 2010-07-25  Alexey Proskuryakov  <ap@apple.com>
2288
2289         Reviewed by Sam Weinig.
2290
2291         https://bugs.webkit.org/show_bug.cgi?id=42193
2292         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
2293
2294         Step 2 - add the rest of editing delegates.
2295
2296         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2297         (WTR::operator<<): Fixed to not crash when range is null.
2298         (WTR::InjectedBundlePage::InjectedBundlePage):
2299         (WTR::InjectedBundlePage::_shouldEndEditing):
2300         (WTR::InjectedBundlePage::_shouldInsertNode):
2301         (WTR::InjectedBundlePage::_shouldInsertText):
2302         (WTR::InjectedBundlePage::_shouldDeleteRange):
2303         (WTR::InjectedBundlePage::_shouldChangeSelectedRange):
2304         (WTR::InjectedBundlePage::_shouldApplyStyle):
2305         (WTR::InjectedBundlePage::_didBeginEditing):
2306         (WTR::InjectedBundlePage::_didEndEditing):
2307         (WTR::InjectedBundlePage::_didChange):
2308         (WTR::InjectedBundlePage::_didChangeSelection):
2309         (WTR::InjectedBundlePage::shouldEndEditing):
2310         (WTR::InjectedBundlePage::shouldInsertNode):
2311         (WTR::InjectedBundlePage::shouldInsertText):
2312         (WTR::InjectedBundlePage::shouldDeleteRange):
2313         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2314         (WTR::InjectedBundlePage::shouldApplyStyle):
2315         (WTR::InjectedBundlePage::didBeginEditing):
2316         (WTR::InjectedBundlePage::didEndEditing):
2317         (WTR::InjectedBundlePage::didChange):
2318         (WTR::InjectedBundlePage::didChangeSelection):
2319         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2320
2321 2010-07-24  Chris Fleizach  <cfleizach@apple.com>
2322
2323         Reviewed by David Kilzer.
2324
2325         AX: need a layout test testing misspelled words in attributed strings
2326         https://bugs.webkit.org/show_bug.cgi?id=42899
2327
2328         * DumpRenderTree/AccessibilityUIElement.cpp:
2329         (attributedStringForRangeCallback):
2330         (attributedStringRangeIsMisspelledCallback):
2331         (AccessibilityUIElement::getJSClass):
2332         * DumpRenderTree/AccessibilityUIElement.h:
2333         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2334         (AccessibilityUIElement::attributedStringForRange):
2335         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2336         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2337         (AccessibilityUIElement::attributedStringForRange):
2338         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2339         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2340         (AccessibilityUIElement::attributedStringForRange):
2341         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2342
2343 2010-07-23  David Kilzer  <ddkilzer@apple.com>
2344
2345         <http://webkit.org/b/42911> Update ruby tools to work with shallow framework bundles
2346
2347         Reviewed by Mark Rowe.
2348
2349         * Scripts/check-for-inappropriate-files-in-framework: Added
2350         check for the SHALLOW_BUNDLE environment variable so that the
2351         script will work with iOS WebKit builds.
2352         * Scripts/check-for-webkit-framework-include-consistency: Ditto.
2353
2354 2010-07-22  Darin Adler  <darin@apple.com>
2355
2356         Reviewed by Sam Weinig.
2357
2358         Eliminate unneeded WKBundleFrameCopyInnerText function from WebKit2
2359         https://bugs.webkit.org/show_bug.cgi?id=42847
2360
2361         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2362         (WTR::operator<<): Replaced the WKStringToUTF8 function with
2363         a set of overloaded stream operators.
2364         (WTR::dumpPath): Changed to use ostringstream and return a string.
2365         (WTR::propertyValue): Added.
2366         (WTR::propertyObject): Added.
2367         (WTR::propertyString): Added.
2368         (WTR::numericWindowPropertyValue): Changed to call propertyValue.
2369         (WTR::dumpFrameScrollPosition): Removed now unneeded WKStringToUTF8 sequence
2370         since we now have suitable streaming functions.
2371         (WTR::dumpFrameText): Use propertyObject and propertyString instead of
2372         WKBundleFrameCopyInnerText.
2373         (WTR::dumpDescendantFramesText): Removed now unneeded WKStringToUTF8 sequence
2374         since we now have suitable streaming functions.
2375         (WTR::InjectedBundlePage::dump): Ditto.
2376         (WTR::InjectedBundlePage::willAddMessageToConsole): Ditto.
2377         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
2378         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
2379         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
2380         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
2381
2382 2010-07-22  Alexey Proskuryakov  <ap@apple.com>
2383
2384         Reviewed by Sam Weinig and Darin Adler.
2385
2386         https://bugs.webkit.org/show_bug.cgi?id=42193
2387         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
2388
2389         Step 1: Add the method, and implement one actual delegate call as proof of concept. No tests
2390         fixed, but this makes difference one line smaller on many editing tests.
2391
2392         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2393         Added dumpEditingCallbacks() and setAcceptsEditing().
2394
2395         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2396         (WTR::dumpPath): Dump path to a node in a format that's compatible with DumpRenderTree.
2397         (WTR::operator<<): Print a range.
2398         (WTR::InjectedBundlePage::InjectedBundlePage): Set editor client in addition to existing
2399         clients.
2400         (WTR::InjectedBundlePage::_shouldBeginEditing): The only client method implemented so far.
2401         (WTR::InjectedBundlePage::shouldBeginEditing): Ditto.
2402         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added a section for editor client
2403         calls.
2404
2405         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2406         (WTR::LayoutTestController::LayoutTestController):
2407         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2408         (WTR::LayoutTestController::dumpEditingCallbacks):
2409         (WTR::LayoutTestController::setAcceptsEditing):
2410         (WTR::LayoutTestController::acceptsEditing):
2411         (WTR::LayoutTestController::shouldDumpEditingCallbacks):
2412         Store m_acceptsEditing and m_dumpEditingCallbacks.
2413
2414 2010-07-22  Yael Aharon  <yael.aharon@nokia.com>
2415
2416         Reviewed by Laszlo Gombos.
2417
2418         [Qt] QtWebKit needs public API for Notifications.
2419         https://bugs.webkit.org/show_bug.cgi?id=41413
2420
2421         Update DumpRenderTree and QtTestBrowser to use the new API.
2422         Add new DRT API to flag that notifications permission requests should be ignored.
2423
2424         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2425         (WebCore::WebPage::WebPage):
2426         (WebCore::WebPage::requestPermission):
2427         (WebCore::WebPage::checkPermission):
2428         (WebCore::WebPage::cancelRequestsForPermission):
2429         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2430         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2431         (LayoutTestController::reset):
2432         (LayoutTestController::ignoreDesktopNotificationPermissionRequests):
2433         (LayoutTestController::checkDesktopNotificationPermission):
2434         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2435         (LayoutTestController::ignoreReqestForPermission):
2436         * QtTestBrowser/main.cpp:
2437         (LauncherWindow::LauncherWindow):
2438         * QtTestBrowser/webpage.cpp:
2439         (WebPage::WebPage):
2440         (WebPage::requestPermission):
2441         (WebPage::checkPermission):
2442         (WebPage::cancelRequestsForPermission):
2443         * QtTestBrowser/webpage.h:
2444
2445 2010-07-22  Darin Adler  <darin@apple.com>
2446
2447         Reviewed by Sam Weinig.
2448
2449         WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
2450         https://bugs.webkit.org/show_bug.cgi?id=42325
2451
2452         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2453         Added dumpChildFramesAsText.
2454
2455         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2456         (WTR::dumpFrameText): Added.
2457         (WTR::dumpDescendantFramesText): Added.
2458         (WTR::InjectedBundlePage::dumpAllFramesText): Added.
2459         (WTR::InjectedBundlePage::dump): Changed to use the new whatToDump function
2460         instead of the shouldDumpAsText function, and added a case for AllFramesText.
2461
2462         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpAllFramesText.
2463
2464         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2465         (WTR::LayoutTestController::LayoutTestController): Replaced m_dumpAsText with
2466         m_whatToDump.
2467
2468         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added
2469         dumpChildFramesAsText. Removed shouldDumpAsText, shouldDumpDOMAsWebArchive,
2470         and shouldDumpSourceAsWebArchive. Added whatToDump.
2471
2472 2010-07-22  Adam Roben  <aroben@apple.com>
2473
2474         Windows build fix
2475
2476         Inspired by r63881.
2477
2478         * MiniBrowser/MiniBrowser.vcproj:
2479         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
2480         Removed pre- and post-build events so they will be inherited from the
2481         vsprops files.
2482
2483 2010-07-21  Darin Adler  <darin@apple.com>
2484
2485         Reviewed by Sam Weinig.
2486
2487         WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
2488         https://bugs.webkit.org/show_bug.cgi?id=42548
2489
2490         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2491         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2492         (WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file.
2493         (WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name.
2494         Changed to a file-internal function instead of a member function.
2495         (WTR::dumpDescendantFrameScrollPositions): Added.
2496         (WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added.
2497         (WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when
2498         appropriate. Also streamlined all the WKStringToUTF8 call sites.
2499         (WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8.
2500         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
2501         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
2502         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
2503         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
2504
2505         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.
2506
2507         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2508         (WTR::LayoutTestController::LayoutTestController): Initialize
2509         m_shouldDumpAllFrameScrollPositions.
2510         (WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from
2511         shouldDumpFrameScrollPositions.
2512
2513         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a
2514         bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions,
2515         and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.
2516
2517 2010-07-21  Darin Adler  <darin@apple.com>
2518
2519         Reviewed by Sam Weinig.
2520
2521         WebKitTestRunner needs to support dumping of scroll position
2522         https://bugs.webkit.org/show_bug.cgi?id=42514
2523
2524         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2525         (_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
2526
2527         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2528         (WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef
2529         instead of JSContextRef.
2530         (WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate.
2531         (WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition.
2532         (WTR::InjectedBundlePage::dumpFrameScrollPosition): Added.
2533         (WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef
2534         instead of JSContextRef.
2535
2536         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from
2537         arguments that simply repeat the argument type. Added dumpFrameScrollPosition.
2538
2539         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2540         (WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently
2541         returns false.
2542         (WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently
2543         returns false.
2544         (WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches
2545         the logic in DumpRenderTree.
2546
2547         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes.
2548
2549         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore.
2550
2551 2010-07-21  Kevin Ollivier  <kevino@theolliviers.com>
2552
2553         [wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.
2554
2555         * wx/build/settings.py:
2556
2557 2010-07-21  Sam Weinig  <sam@webkit.org>
2558
2559         Reviewed by Anders Carlsson.
2560
2561         Patch for https://bugs.webkit.org/show_bug.cgi?id=42539
2562         WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages
2563
2564         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2565         (WTR::InjectedBundlePage::InjectedBundlePage):
2566         (WTR::InjectedBundlePage::_willAddMessageToConsole):
2567         (WTR::InjectedBundlePage::_willSetStatusbarText):
2568         (WTR::InjectedBundlePage::_willRunJavaScriptAlert):
2569         (WTR::InjectedBundlePage::_willRunJavaScriptConfirm):
2570         (WTR::InjectedBundlePage::_willRunJavaScriptPrompt):
2571         (WTR::InjectedBundlePage::willAddMessageToConsole):
2572         (WTR::InjectedBundlePage::willSetStatusbarText):
2573         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
2574         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
2575         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
2576         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2577
2578 2010-07-21  Adam Roben  <aroben@apple.com>
2579
2580         Give InjectedBundle our standard set of configurations (minus the
2581         *_Cairo variants)
2582
2583         InjectedBundle's Debug_All configuration was the same as is Debug
2584         configuration, and it was missing a Debug_Internal configuration.
2585
2586         Fixes <http://webkit.org/b/42749> InjectedBundle's build
2587         configurations are screwy
2588
2589         Reviewed by Darin Adler.
2590
2591         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added
2592         debug_internal.vsprops and debug_all.vsprops to the Debug_All
2593         configuration. Added a Debug_Internal configuration.
2594
2595         * WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal
2596         variant of InjectedBundle when we're using the Debug_Internal solution
2597         configuration.
2598
2599 2010-07-21  Adam Roben  <aroben@apple.com>
2600
2601         Move InjectedBundle's settings to a vsprops file
2602
2603         This will make it easier to change settings for all configurations,
2604         and to add new configurations.
2605
2606         Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops
2607         files
2608
2609         Reviewed by Darin Adler.
2610
2611         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added.
2612         Moved settings here...
2613         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: ...from
2614         here.
2615
2616 2010-07-21  Adam Roben  <aroben@apple.com>
2617
2618         Give MiniBrowser our standard set of configurations (minus the *_Cairo
2619         variants)
2620
2621         MiniBrowser already had a configuration called "Release", but it was
2622         using mostly the same settings as Debug. And its Debug configuration
2623         was using the settings that Debug_Internal should be using.
2624
2625         Fixes <http://webkit.org/b/42746> MiniBrowser's build configurations
2626         are screwy
2627
2628         Reviewed by Darin Adler.
2629
2630         * MiniBrowser/MiniBrowser.vcproj: Removed debug_internal.vsprops from
2631         the Debug configuration. Remove debug.vsprops and
2632         debug_internal.vsprops from the Release configuration and replace them
2633         with release.vsprops. Added Debug_Internal and Debug_All
2634         configurations.
2635
2636 2010-07-21  Adam Roben  <aroben@apple.com>
2637
2638         Move MiniBrowser's settings to a vsprops file
2639
2640         This will make it easier to change settings for all configurations,
2641         and to add new configurations.
2642
2643         MiniBrowser should use vsprops files
2644         https://bugs.webkit.org/show_bug.cgi?id=42745
2645
2646         Reviewed by Darin Adler.
2647
2648         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added. Moved
2649         settings here...
2650         * MiniBrowser/MiniBrowser.vcproj: ...from here.
2651
2652 2010-07-21  Adam Roben  <aroben@apple.com>
2653
2654         Fix compiler warnings when building MiniBrowser
2655
2656         Also cleaned up the .vcproj a bit.
2657
2658         Fixes <http://webkit.org/b/42743>.
2659
2660         Reviewed by Darin Adler.
2661
2662         * MiniBrowser/MiniBrowser.vcproj: Removed all settings that are
2663         already defined in .vsprops files. This also fixes a warning about
2664         /EDITANDCONTINUE being incompatible with /SAFESEH.
2665
2666         * MiniBrowser/win/MiniBrowser.rc: Replaced afxres.h with winresrc.h so
2667         that we stop getting warnings about ID_FILE_OPEN and ID_FILE_CLOSE
2668         being redefined. (I think this will also get us closer to building
2669         with VC++ Express.)
2670
2671 2010-07-20  Sam Weinig  <sam@webkit.org>
2672
2673         Reviewed by Jon Honeycutt.
2674
2675         Fix obvious typo.
2676
2677         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2678         (WTR::InjectedBundlePage::setStatusbarText): Need to call ->data() to actually get the string value.
2679
2680 2010-07-20  Tony Chang  <tony@chromium.org>
2681
2682         Reviewed by Kent Tamura.
2683
2684         [chromium] by default, dumpAsText should disable pixel results
2685         https://bugs.webkit.org/show_bug.cgi?id=42715
2686
2687         * DumpRenderTree/chromium/LayoutTestController.cpp:
2688         (LayoutTestController::dumpAsText): disable pixel results, but allow JS to override
2689
2690 2010-07-20  Adam Roben  <aroben@apple.com>
2691
2692         Windows build fix
2693
2694         * MiniBrowser/MiniBrowser.vcproj: Link against the new, shiny
2695         WebKit.lib instead of the old, dusty WebKit2.lib.
2696
2697 2010-07-20  Adam Roben  <aroben@apple.com>
2698
2699         Stop linking WebKitTestRunner against getopt
2700
2701         Use of getopt was removed in r63700.
2702
2703         Fixes <http://webkit.org/b/42714> WebKitTestRunner links against
2704         getopt, but doesn't need to
2705
2706         Reviewed by Sam Weinig.
2707
2708         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed getopt.lib
2709         from all configurations.
2710
2711 2010-07-20  Adam Roben  <aroben@apple.com>
2712
2713         Make run-webkit-tests --webkit-test-runner "work" on Windows
2714
2715         WebKitTestRunner crashes on launch, but at least the scripts build and
2716         launch it!
2717
2718         Fixes <http://webkit.org/b/42709> run-webkit-tests
2719         --webkit-test-runner bails with an error on Windows
2720
2721         Reviewed by Anders Carlsson.
2722
2723         * Scripts/build-webkittestrunner: Build WebKitTestRunner.sln on
2724         Windows.
2725         * WebKitTestRunner/WebKitTestRunner.sln: Added. Contains the following
2726         projects (from first-built to last-built): FindSafari, ImageDiff,
2727         InjectedBundleGenerated, InjectedBundle, WebKitTestRunner.
2728
2729 2010-07-20  Adam Roben  <aroben@apple.com>
2730
2731         Change build-webkit back to building WebKit.sln on Windows
2732
2733         WebKit.sln builds all the same projects as WebKit2.sln, and the latter
2734         is being removed.
2735
2736         Rubber-stamped in advance by Steve Falkenburg.
2737
2738         * Scripts/build-webkit:
2739
2740 2010-07-20  Adam Roben  <aroben@apple.com>
2741
2742         Windows build fix
2743
2744         * MiniBrowser/win/BrowserWindow.cpp: Added missing #include.
2745
2746 2010-07-20  Joseph Pecoraro  <joepeck@webkit.org>
2747
2748         Reviewed by Geoffrey Garen.
2749
2750         WebScriptObject Should Allow Safely Checking For Key Existence
2751         https://bugs.webkit.org/show_bug.cgi?id=42613
2752
2753         Normal ObjCController workflow for a WebScriptObject test.
2754
2755         * DumpRenderTree/mac/ObjCController.m:
2756         (+[ObjCController isSelectorExcludedFromWebScript:]):
2757         (+[ObjCController webScriptNameForSelector:]):
2758         (-[ObjCController testHasWebScriptKey:]):
2759
2760 2010-07-20  Chris Marrin  <cmarrin@apple.com>
2761
2762         Reviewed by Simon Fraser.
2763
2764         https://bugs.webkit.org/show_bug.cgi?id=42118
2765         Disable compositing/webgl tests if WebGL is not enabled
2766
2767         * Scripts/old-run-webkit-tests:
2768
2769 2010-07-20  Anton Muhin  <antonm@chromium.org>
2770
2771         Reviewed by Darin Adler.
2772
2773         Print additional information about exception if failed to connect to apache (in verbose mode).
2774         https://bugs.webkit.org/show_bug.cgi?id=42627
2775
2776         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2777
2778 2010-07-20  Tony Chang  <tony@chromium.org>
2779
2780         Reviewed by David Levin.
2781
2782         [chromium] only pass --force to gclient sync if explicitly stated
2783         https://bugs.webkit.org/show_bug.cgi?id=42581
2784
2785         * BuildSlaveSupport/build.webkit.org-config/master.cfg: bots should
2786               always pass --force since it's hard to do manual cleanups
2787         * Scripts/update-webkit-chromium: only pass --force if --force is
2788               passed in
2789
2790 2010-07-19  Anders Carlsson  <andersca@apple.com>
2791
2792         Fix build.
2793
2794         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2795         Paths of generated files should be relative to the build product.
2796
2797 2010-07-19  Daniel Bates  <dbates@rim.com>
2798
2799         Reviewed by Adam Roben.
2800
2801         [Win] Implement LayoutTestController::markerTextForListItem()
2802         https://bugs.webkit.org/show_bug.cgi?id=37930
2803
2804         Implements DRT support for markerTextForListItem in the Windows port.
2805
2806         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2807         (LayoutTestController::markerTextForListItem): Implemented.
2808
2809 2010-07-19  Jessie Berlin  <jberlin@apple.com>
2810
2811         Windows build fix. Unreviewed.
2812
2813         * WebKitTestRunner/win/TestControllerWin.cpp:
2814         (WTR::TestController::initializeTestPluginPath):
2815
2816 2010-07-19  Sam Weinig  <sam@webkit.org>
2817
2818         Reviewed by Jon Honeycutt.
2819
2820         Remove dependency on getopt from WebKitTestRunner.
2821
2822         - Simplify options parsing and eliminate unused options.
2823
2824         * WebKitTestRunner/TestController.cpp:
2825         (WTR::TestController::TestController):
2826         (WTR::TestController::initialize):
2827         * WebKitTestRunner/TestController.h:
2828         (WTR::TestController::testPluginPath):
2829         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2830         * WebKitTestRunner/mac/TestControllerMac.mm:
2831         (WTR::TestController::platformInitialize):
2832         (WTR::TestController::initializeTestPluginPath):
2833         * WebKitTestRunner/win/TestControllerWin.cpp:
2834         (WTR::TestController::platformInitialize):
2835         (WTR::TestController::initializeTestPluginPath):
2836
2837 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
2838
2839         Reviewed by Antonio Gomes.
2840
2841         [Qt] MiniBrowser: Progress indication at address bar
2842         https://bugs.webkit.org/show_bug.cgi?id=42565
2843
2844         Make possible to see load progress at address bar based on
2845         QtTestBrowser solution
2846
2847         * MiniBrowser/qt/BrowserWindow.cpp:
2848         (BrowserWindow::BrowserWindow):
2849         (BrowserWindow::loadProgress):
2850         * MiniBrowser/qt/BrowserWindow.h:
2851
2852 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
2853
2854         Reviewed by Antonio Gomes.
2855
2856         [Qt] Add MiniBrowser features: urlChanged, titleChanged and from user input load
2857         https://bugs.webkit.org/show_bug.cgi?id=42564
2858
2859         * MiniBrowser/qt/BrowserWindow.cpp:
2860         (BrowserView::load):
2861         (BrowserWindow::BrowserWindow):
2862         (BrowserWindow::titleChanged):
2863         (BrowserWindow::urlChanged):
2864         * MiniBrowser/qt/BrowserWindow.h:
2865
2866 2010-07-19  Sam Weinig  <weinig@apple.com>
2867
2868         Reviewed by Adam Roben.
2869
2870         Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
2871         Auto-generate the JS bindings for WebKitTestRunner's script objects.
2872
2873         * WebKitTestRunner/Configurations/Base.xcconfig:
2874         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2875         * WebKitTestRunner/DerivedSources.make: Added.
2876         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
2877         * WebKitTestRunner/InjectedBundle/Bindings: Added.
2878         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
2879         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
2880         (WTR::JSWrappable::~JSWrappable):
2881         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
2882         (WTR::JSWrapper::wrap):
2883         (WTR::JSWrapper::unwrap):
2884         (WTR::unwrapObject):
2885         (WTR::JSWrapper::initialize):
2886         (WTR::JSWrapper::finalize):
2887         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
2888         (WTR::toJS):
2889         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
2890         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2891         (WTR::InjectedBundlePage::dump):
2892         (WTR::InjectedBundlePage::setStatusbarText):
2893         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2894         (WTR::LayoutTestController::wrapperClass):
2895         (WTR::LayoutTestController::waitUntilDone):
2896         (WTR::LayoutTestController::makeWindowObject):
2897         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2898         (WTR::LayoutTestController::shouldDumpAsText):
2899         (WTR::LayoutTestController::dumpAsText):
2900         (WTR::LayoutTestController::shouldDumpStatusCallbacks):
2901         (WTR::LayoutTestController::dumpStatusCallbacks):
2902         (WTR::LayoutTestController::waitToDump):
2903         (WTR::LayoutTestController::testRepaint):
2904         (WTR::LayoutTestController::repaintSweepHorizontally):
2905         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
2906         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2907         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added.
2908         * WebKitTestRunner/win/build-generated-files.sh: Added.
2909
2910 2010-07-19  Mark Rowe  <mrowe@apple.com>
2911
2912         Clean up the buildbot configuration a little.
2913
2914         * BuildSlaveSupport/build.webkit.org-config/config.json:
2915
2916 2010-07-19  Chris Marrin  <cmarrin@apple.com>
2917
2918         Reviewed by Darin Adler.
2919
2920         https://bugs.webkit.org/show_bug.cgi?id=42118
2921         Disable WebGL on Leopard for now. 
2922
2923         LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
2924         GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
2925         SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
2926         software OpenGL driver on machines without this support.
2927
2928         * Scripts/build-webkit:
2929
2930 2010-07-19  Simon Fraser  <simon.fraser@apple.com>
2931
2932         Reviewed by Brady Eidson.
2933
2934         Fix MiniBrowser to update URL as you browse
2935         https://bugs.webkit.org/show_bug.cgi?id=42591
2936         
2937         Hook up various loading notifications to update the URL bar in MiniBrowser.
2938
2939         * MiniBrowser/mac/BrowserWindowController.m:
2940         (_didStartProvisionalLoadForFrame):
2941         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2942         (_didFailProvisionalLoadWithErrorForFrame):
2943         (_didCommitLoadForFrame):
2944         (_didFailLoadWithErrorForFrame):
2945         (-[BrowserWindowController updateProvisionalURLForFrame:]):
2946         (-[BrowserWindowController didStartProvisionalLoadForFrame:]):
2947         (-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
2948         (-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
2949         (-[BrowserWindowController didFailLoadWithErrorForFrame:]):
2950         (-[BrowserWindowController didCommitLoadForFrame:]):
2951
2952 2010-07-19  Alexey Proskuryakov  <ap@apple.com>
2953
2954         Reviewed by Darin Adler.
2955
2956         https://bugs.webkit.org/show_bug.cgi?id=42586
2957         Log all canceled authentication attempts in DumpRenderTree
2958
2959         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2960         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2961         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2962         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2963         It's important to know whether an auth sheet appeared. Added logging to "no preset credentials"
2964         case.
2965
2966 2010-07-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2967
2968         Unreviewed, rolling out r63671.
2969         http://trac.webkit.org/changeset/63671
2970         https://bugs.webkit.org/show_bug.cgi?id=42575
2971
2972         broke windows (Requested by weinig on #webkit).
2973
2974         * WebKitTestRunner/Configurations/Base.xcconfig:
2975         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2976         * WebKitTestRunner/DerivedSources.make: Removed.
2977         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Removed.
2978         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Removed.
2979         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Removed.
2980         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Removed.
2981         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Removed.
2982         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
2983         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2984         (WTR::InjectedBundlePage::dump):
2985         (WTR::InjectedBundlePage::setStatusbarText):
2986         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2987         (WTR::LayoutTestController::setWaitToDump):
2988         (WTR::displayCallback):
2989         (WTR::dumpAsTextCallback):
2990         (WTR::dumpStatusCallbacksCallback):
2991         (WTR::waitUntilDoneCallback):
2992         (WTR::notifyDoneCallback):
2993         (WTR::numberOfActiveAnimationsCallback):
2994         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
2995         (WTR::repaintSweepHorizontallyCallback):
2996         (WTR::testRepaintCallback):
2997         (WTR::layoutTestControllerObjectFinalize):
2998         (WTR::LayoutTestController::makeWindowObject):
2999         (WTR::LayoutTestController::getJSClass):
3000         (WTR::LayoutTestController::staticFunctions):
3001         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3002         (WTR::LayoutTestController::dumpAsText):
3003         (WTR::LayoutTestController::setDumpAsText):
3004         (WTR::LayoutTestController::dumpStatusCallbacks):
3005         (WTR::LayoutTestController::setDumpStatusCallbacks):
3006         (WTR::LayoutTestController::setTestRepaint):
3007         (WTR::LayoutTestController::setTestRepaintSweepHorizontally):
3008         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3009
3010 2010-07-19  Sam Weinig  <sam@webkit.org>
3011
3012         Reviewed by Adam Roben.
3013
3014         Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
3015         Auto-generate the JS bindings for WebKitTestRunner's script objects.
3016
3017         * WebKitTestRunner/Configurations/Base.xcconfig:
3018         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3019         * WebKitTestRunner/DerivedSources.make: Added.
3020         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
3021         * WebKitTestRunner/InjectedBundle/Bindings: Added.
3022         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
3023         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
3024         (WTR::JSWrappable::~JSWrappable):
3025         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
3026         (WTR::JSWrapper::wrap):
3027         (WTR::JSWrapper::unwrap):
3028         (WTR::unwrapObject):
3029         (WTR::JSWrapper::initialize):
3030         (WTR::JSWrapper::finalize):
3031         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
3032         (WTR::toJS):
3033         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
3034         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3035         (WTR::InjectedBundlePage::dump):
3036         (WTR::InjectedBundlePage::setStatusbarText):
3037         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3038         (WTR::LayoutTestController::wrapperClass):
3039         (WTR::LayoutTestController::waitUntilDone):
3040         (WTR::LayoutTestController::makeWindowObject):
3041         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3042         (WTR::LayoutTestController::shouldDumpAsText):
3043         (WTR::LayoutTestController::dumpAsText):
3044         (WTR::LayoutTestController::shouldDumpStatusCallbacks):
3045         (WTR::LayoutTestController::dumpStatusCallbacks):
3046         (WTR::LayoutTestController::waitToDump):
3047         (WTR::LayoutTestController::testRepaint):
3048         (WTR::LayoutTestController::repaintSweepHorizontally):
3049         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3050
3051 2010-07-19  Tony Chang  <tony@chromium.org>
3052
3053         Reviewed by David Levin.
3054
3055         fix chromium linux compile on ubuntu maverick
3056         https://bugs.webkit.org/show_bug.cgi?id=42528
3057
3058         * Scripts/webkitdirs.pm: add a chomp to eat a newline that breaks the make command line
3059
3060 2010-07-19  Adam Roben  <aroben@apple.com>
3061
3062         When dumping a response's MIME type, print its URL's last path
3063         component rather than its suitable-for-test-result form
3064
3065         This matches the Mac behavior.
3066
3067         Fixes <http://webkit.org/b/42276>
3068         http/tests/loading/preload-slow-loading.php and
3069         http/tests/mime/uppercase-mime-type.html fail on Windows
3070
3071         Reviewed by Anders Carlsson.
3072
3073         * DumpRenderTree/win/DumpRenderTree.cpp:
3074         (urlSuitableForTestResult): Moved code to actually extract the last
3075         path component from here...
3076         (lastPathComponent): ...to here.
3077
3078         * DumpRenderTree/win/DumpRenderTreeWin.h: Added lastPathComponent.
3079
3080         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3081         (ResourceLoadDelegate::didReceiveResponse): Use the URL's last path
3082         component, rather than its suitable-for-test-result form, to match
3083         Mac.
3084
3085 2010-07-19  Anders carlsson  <andersca@apple.com>
3086
3087         Reviewed by Adam Roben.
3088
3089         WebKit2 does not have application cache
3090         https://bugs.webkit.org/show_bug.cgi?id=42552
3091
3092         * WebKitTestRunner/TestInvocation.cpp:
3093         (WTR::TestInvocation::resetPreferencesToConsistentValues):
3094         Set up default preferences. Right now just enables the web application cache.
3095
3096         (WTR::TestInvocation::invoke):
3097         Call resetPreferencesToConsistentValues.
3098
3099         * WebKitTestRunner/TestInvocation.h:
3100
3101 2010-07-19  Kent Tamura  <tkent@chromium.org>
3102
3103         Reviewed by Adam Roben.
3104
3105         Fix NewRunWebKitTests to work on Windows.
3106         https://bugs.webkit.org/show_bug.cgi?id=41180
3107
3108         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3109           Specifying python explicitly.
3110
3111 2010-07-18  Anders Carlsson  <andersca@apple.com>
3112
3113         Reviewed by Dan Bernstein.
3114
3115         Add dumping of statusbar text to WebKitTestRunner
3116         https://bugs.webkit.org/show_bug.cgi?id=42516
3117
3118         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3119         (WTR::InjectedBundlePage::InjectedBundlePage):
3120         (WTR::InjectedBundlePage::_setStatusbarText):
3121         (WTR::InjectedBundlePage::setStatusbarText):
3122         Dump the statusbar text.
3123
3124         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3125         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3126         (WTR::LayoutTestController::LayoutTestController):
3127         Initialize m_dumpStatusCallbacks to false.
3128
3129         (WTR::dumpStatusCallbacksCallback):
3130         Implement JSC callback.
3131
3132         (WTR::LayoutTestController::staticFunctions):
3133         Add dumpStatusCallbacks.
3134
3135         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3136         (WTR::LayoutTestController::dumpStatusCallbacks):
3137         (WTR::LayoutTestController::setDumpStatusCallbacks):
3138         Add setter and getter for m_dumpStatusCallbacks.
3139
3140 2010-07-17  Anders Carlsson  <andersca@apple.com>
3141
3142         Reviewed by Maciej Stachowiak.
3143
3144         * WebKitTestRunner/TestController.cpp:
3145         (WTR::TestController::initialize):
3146         Get the test plug-in path and set it on the context.
3147
3148         * WebKitTestRunner/TestController.h:
3149         * WebKitTestRunner/mac/TestControllerMac.mm:
3150         (WTR::TestController::initializeInjectedBundlePath):
3151         Simplify this code by using NSBundle.
3152
3153         (WTR::TestController::testPluginPath):
3154         Return the test plug-in path.
3155
3156         * WebKitTestRunner/win/TestControllerWin.cpp:
3157         (WTR::TestController::testPluginPath):
3158         Ditto.
3159
3160 2010-07-16  Adam Barth  <abarth@webkit.org>
3161
3162         Reviewed by Eric Seidel.
3163
3164         Teach webkitpy about queues.webkit.org
3165         https://bugs.webkit.org/show_bug.cgi?id=42492
3166
3167         * Scripts/webkitpy/common/net/statusserver.py:
3168
3169 2010-07-16  Ada Chan  <adachan@apple.com>
3170
3171         Reviewed by Alice Liu.
3172
3173         Fix Windows build.
3174
3175         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
3176
3177 2010-07-16  Sam Weinig  <sam@webkit.org>
3178
3179         Reviewed by Anders Carlsson.
3180
3181         Fix for https://bugs.webkit.org/show_bug.cgi?id=42482
3182         <rdar://problem/8197701>
3183         Add notification of when the BackForwardList changes
3184         to aid invalidation of Back/Forward related UI elements.
3185
3186         * MiniBrowser/mac/BrowserWindowController.m:
3187         (_didStartProvisionalLoadForFrame):
3188         (_didCommitLoadForFrame):
3189         (_didFailLoadWithErrorForFrame):
3190         (_didChangeBackForwardList):
3191         (-[BrowserWindowController awakeFromNib]):
3192         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3193
3194 2010-07-16  Kent Tamura  <tkent@chromium.org>
3195
3196         Reviewed by Darin Fisher.
3197
3198         [Chromium] <input type=number> UI implementation for Windows
3199         https://bugs.webkit.org/show_bug.cgi?id=42259
3200
3201         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
3202         (WebThemeEngineDRT::paintSpinButton):
3203          Added. Check state consistency and use existing arrow painting code.
3204         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
3205
3206 2010-07-16  Alice Liu  <alice.liu@apple.com>
3207
3208         Reviewed by Sam Weinig.
3209
3210         https://bugs.webkit.org/show_bug.cgi?id=42430
3211         Make WebKitTestRunner on Windows actually load and run a test
3212
3213         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Export WKBundleInitialize.
3214         (WKBundleInitialize):
3215         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added.  Output is a dll.
3216         * WebKitTestRunner/TestInvocation.cpp: Create a Windows-style path on Windows
3217         (WTR::createWKURL):
3218         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Change check for Windows platform to match
3219         other existing checks, and avoid including Platform.h
3220         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3221         (WTR::registerWindowClass): Added.
3222         (WTR::PlatformWebView::PlatformWebView): Implemented.
3223         (WTR::PlatformWebView::~PlatformWebView): Implemented.
3224         (WTR::PlatformWebView::page): Implemented.
3225         * WebKitTestRunner/win/TestControllerWin.cpp:
3226         (WTR::TestController::initializeInjectedBundlePath): Implemented. Provide build 
3227         configuration specific path to InjectedBundle.dll.
3228         * WebKitTestRunner/win/TestInvocationWin.cpp:
3229         (WTR::TestInvocation::runUntil): Implemented.
3230         * WebKitTestRunner/win/WebKitTestRunner.sln: Added InjectedBundle project.
3231         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Cleaned up unnecessary dependencies.
3232
3233 2010-07-16  Brady Eidson  <beidson@apple.com>
3234
3235         Reviewed by Sam Weinig.
3236
3237         Make revalidation of back/forward work a little better with page loads
3238         https://bugs.webkit.org/show_bug.cgi?id=42470
3239
3240         * MiniBrowser/mac/BrowserWindow.xib:
3241         * MiniBrowser/mac/BrowserWindowController.h:
3242         * MiniBrowser/mac/BrowserWindowController.m:
3243         (-[BrowserWindowController validateToolbar]):
3244         (_didStartProvisionalLoadForFrame):
3245         (_didCommitLoadForFrame):
3246         (_didFailLoadWithErrorForFrame):
3247
3248 2010-07-16  Nikolas Zimmermann  <nzimmermann@rim.com>
3249
3250         Reviewed by Dirk Schulze.
3251
3252         Add possibility to dumpAsText and generate a pixel test result
3253         https://bugs.webkit.org/show_bug.cgi?id=42374
3254
3255         Add optional parameter to setDumpAsText() to allow generating a pixel test result even if dumpAsText mode.
3256         setDumpAsText(true) will also generate a pixel test result now, when running run-webkit-tests --pixel-tests.
3257
3258         This is needed for the svg/dynamic-updates tests, which don't want render tree dumps but text dumps + a pixel test result.
3259         At some point DRT changed to not generate pixel test results when using dumpAsText - which makes sense, but breaks the svg/dynamic-updates test.
3260
3261         Implemented for all DRT platforms, except Qt, as it's not clear how arguments to functions like "setDumpAsText" are handled.
3262         (Qt always dumps pixel tests when using --pixel-tests mode, so it does not break anything)
3263
3264         * DumpRenderTree/LayoutTestController.cpp:
3265         (LayoutTestController::LayoutTestController):
3266         (dumpAsTextAndPixelsCallback):
3267         (LayoutTestController::staticFunctions):
3268         * DumpRenderTree/LayoutTestController.h:
3269         (LayoutTestController::dumpAsTextAndPixels):
3270         (LayoutTestController::setDumpAsTextAndPixels):
3271         * DumpRenderTree/chromium/LayoutTestController.cpp:
3272         (LayoutTestController::LayoutTestController):
3273         (LayoutTestController::dumpAsTextAndPixels):
3274         (LayoutTestController::reset):
3275         * DumpRenderTree/chromium/LayoutTestController.h:
3276         (LayoutTestController::shouldDumpAsTextAndPixels):
3277         * DumpRenderTree/chromium/TestShell.cpp:
3278         (TestShell::dump):
3279         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3280         (dump):
3281         * DumpRenderTree/mac/DumpRenderTree.mm:
3282         (dump):
3283         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3284         (WebCore::DumpRenderTree::dump):
3285         * DumpRenderTree/win/DumpRenderTree.cpp:
3286         (dump):
3287         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3288         (dump):
3289
3290 2010-07-16  Kent Hansen  <kent.hansen@nokia.com>
3291
3292         Unreviewed. Adding myself as committer.
3293
3294         * Scripts/webkitpy/common/config/committers.py:
3295
3296 2010-07-16  Shinichiro Hamaji  <hamaji@chromium.org>
3297
3298         Another uneviewed attempt to fix build.
3299
3300         Printing test results differ between machines, we should use ImageDiff instead
3301         https://bugs.webkit.org/show_bug.cgi?id=20011
3302
3303         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3304         (createPagedBitmapContext):
3305
3306 2010-07-16  Shinichiro Hamaji  <hamaji@chromium.org>
3307
3308         Unreviewed tiger build fix.
3309
3310         Printing test results differ between machines, we should use ImageDiff instead
3311         https://bugs.webkit.org/show_bug.cgi?id=20011
3312
3313         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3314         (createBitmapContext):
3315         (createBitmapContextFromWebView):
3316
3317 2010-07-15  Shinichiro Hamaji  <hamaji@chromium.org>
3318
3319         Unreviewed build fix.
3320
3321         Printing test results differ between machines, we should use ImageDiff instead
3322         https://bugs.webkit.org/show_bug.cgi?id=20011
3323
3324         * DumpRenderTree/PixelDumpSupport.cpp:
3325         (dumpWebViewAsPixelsAndCompareWithExpected):
3326
3327 2010-07-15  Shinichiro Hamaji  <hamaji@chromium.org>
3328
3329         Reviewed by Darin Adler.
3330
3331         Printing test results differ between machines, we should use ImageDiff instead
3332         https://bugs.webkit.org/show_bug.cgi?id=20011
3333
3334         * DumpRenderTree/PixelDumpSupport.cpp:
3335         (dumpWebViewAsPixelsAndCompareWithExpected):
3336         * DumpRenderTree/PixelDumpSupport.h:
3337         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3338         (createBitmapContext): This function was added to share bitmap context creation code.
3339         (createBitmapContextFromWebView):
3340         (createPagedBitmapContext):
3341
3342 2010-07-15  Yuta Kitamura  <yutak@chromium.org>
3343
3344         Reviewed by Kent Tamura.
3345
3346         Pull in pywebsocket-0.5.1
3347         https://bugs.webkit.org/show_bug.cgi?id=42353
3348
3349         pywebsocket-0.5.1 contains a small bug fix (*) that should fix a worker test
3350         in Chromium. There is no other functional change.
3351
3352         (*) http://code.google.com/p/pywebsocket/source/detail?r=265
3353
3354         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version to 0.5.1.
3355
3356 2010-07-15  Brady Eidson  <beidson@apple.com>
3357
3358         Reviewed by Sam Weinig.
3359
3360         Add toolbar and toolbar item validation for MiniBrowser
3361         https://bugs.webkit.org/show_bug.cgi?id=42422
3362
3363         * MiniBrowser/MBToolbarItem.h: Added.
3364         * MiniBrowser/MBToolbarItem.m: Added.
3365         (-[MBToolbarItem validate]):
3366
3367         * MiniBrowser/mac/BrowserWindowController.m:
3368         (-[BrowserWindowController validateUserInterfaceItem:]):
3369
3370         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3371         * MiniBrowser/mac/BrowserWindow.xib:
3372
3373 2010-07-15  Victor Wang  <victorw@chromium.org>
3374
3375         Unreviewed, add victorw irc nickname to committer list.
3376
3377         * Scripts/webkitpy/common/config/committers.py:
3378
3379 2010-07-15  Adam Roben  <aroben@apple.com>
3380
3381         Make killing Apache more reliable (on both Mac and Windows)
3382
3383         We previously had two ways of determining whether we had succeeded in
3384         killing Apache:
3385           1) checking the return value of kill(0, $apachePID)
3386           2) checking whether Apache's PID file still exists
3387
3388         On Cygwin, Apache doesn't always delete its PID file when it exits,
3389         making (2) unreliable. We unfortunately misdiagnosed this as an
3390         impotency of Perl's kill function, which led to r63177 and r63355.
3391
3392         Now that we know that the real problem is that Apache doesn't always
3393         delete its PID file on Windows, we can make a much better fix: always
3394         use method (1) to determine whether we've killed Apache.
3395
3396         Fixes <http://webkit.org/b/42415> Killing Apache is unreliable,
3397         leading to regression test failures (and general annoyance).
3398
3399         Reviewed by Anders Carlsson.
3400
3401         * Scripts/webkitperl/httpd.pm:
3402         (openHTTPD): Moved killing code from here to killHTTPD. Added a call
3403         to delete the PID file in case Apache doesn't do this itself when
3404         killed. Our later logic relies on the PID file being deleted after
3405         this point.
3406         (closeHTTPD): Removed killing logic and changed to just call killHTTPD
3407         instead. killHTTPD's logic is a bit different from the logic we had
3408         here, for the reasons stated above.
3409         (killHTTPD): Added. Code came from openHTTPD.
3410         (handleInterrupt): Bonus fix for Mac: don't hang when pressing Ctrl-C!
3411         On Mac, don't try to kill Apache when we receive a signal, as Apache
3412         will already have been killed by this point (though for some reason
3413         this isn't detected by our killing logic in killHTTPD). On Cygwin, we
3414         still need to kill Apache manually.
3415
3416 2010-07-15  Sam Weinig  <sam@webkit.org>
3417
3418         Reviewed by Anders Carlsson.
3419
3420         Patch for https://bugs.webkit.org/show_bug.cgi?id=42399
3421         Update MiniBrowser for WKFrameNavigationType 
3422
3423         * MiniBrowser/mac/BrowserWindowController.m:
3424         (_decidePolicyForNavigationAction):
3425         (_decidePolicyForNewWindowAction):
3426
3427 2010-07-15  Stephanie Lewis  <slewis@apple.com>
3428
3429         Reviewed by Geoff Garen.
3430
3431         http://bugs.webkit.org/show_bug.cgi?id=42406
3432         Make SunSpider work better with roots.
3433
3434         * Scripts/sunspider-compare-results: fix argument bug
3435         * Scripts/webkitdirs.pm: look inside JavaScriptCore if jsc isn't top-level.
3436
3437 2010-07-15  Brady Eidson  <beidson@apple.com>
3438
3439         Reviewed by Sam Weinig.
3440
3441         Hook up back/forward in MiniBrowser
3442         https://bugs.webkit.org/show_bug.cgi?id=42397
3443
3444         * MiniBrowser/mac/BrowserWindow.xib:
3445         * MiniBrowser/mac/BrowserWindowController.h:
3446         * MiniBrowser/mac/BrowserWindowController.m:
3447         (-[BrowserWindowController goBack:]):
3448         (-[BrowserWindowController goForward:]):
3449
3450 2010-07-15  Daniel Bates  <dbates@rim.com>
3451
3452         Reviewed by Darin Adler.
3453
3454         [Mac] Implement LayoutTestController::markerTextForListItem()
3455         https://bugs.webkit.org/show_bug.cgi?id=37929
3456
3457         Implements DRT support for markerTextForListItem in the Mac port.
3458
3459         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3460         (LayoutTestController::markerTextForListItem): Implemented.
3461
3462 2010-07-15  Adam Barth  <abarth@webkit.org>
3463
3464         Unreviewed.
3465
3466         Update the port names to be more specific.  Before this patch,
3467         port-specific results for Mac would end up in the wrong place.
3468
3469         * Scripts/webkitpy/tool/commands/rebaseline.py:
3470         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3471
3472 2010-07-14  Eric Seidel  <eric@webkit.org>
3473
3474         Reviewed by Adam Barth.
3475
3476         WebKit needs a rebaselining tool (finally)
3477         https://bugs.webkit.org/show_bug.cgi?id=42339
3478
3479         This is a very basic rebaselining tool.  It's not
3480         quite as fancy as chromium's as it will only handle
3481         updating failing results.  It cannot yet handle adding new
3482         results, or updating results where the results should not
3483         replace existing results.
3484
3485         * Scripts/webkitpy/layout_tests/port/base.py:
3486         * Scripts/webkitpy/tool/commands/__init__.py:
3487         * Scripts/webkitpy/tool/commands/queries.py:
3488         * Scripts/webkitpy/tool/commands/rebaseline.py: Added.
3489         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added.
3490
3491 2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3492
3493         Unreviewed, rolling out r63352.
3494         http://trac.webkit.org/changeset/63352
3495         https://bugs.webkit.org/show_bug.cgi?id=42341
3496
3497         Broke plugin-initiate-popup-window.html and plugin-javascript-
3498         access.html on snow leopard (Requested by abarth on #webkit).
3499
3500         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3501         (pluginAllocate):
3502         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3503         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3504         (NPP_New):
3505         (handleEventCarbon):
3506         (handleEventCocoa):
3507
3508 2010-07-14  Maciej Stachowiak  <mjs@apple.com>
3509
3510         Reviewed by Mark Rowe.
3511
3512         Lower WebKitTestRunner notifyDone timeout to 6.0 for now, to make it easier to grind through the failures.
3513
3514         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3515
3516 2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3517
3518         Unreviewed, rolling out r63346.
3519         http://trac.webkit.org/changeset/63346
3520         https://bugs.webkit.org/show_bug.cgi?id=42295
3521
3522         Broke lots of tests, some of which probably just need new
3523         results (Requested by aroben on #webkit).
3524
3525         * DumpRenderTree/win/DumpRenderTree.cpp:
3526         (urlSuitableForTestResult):
3527
3528 2010-07-14  Adam Roben  <aroben@apple.com>
3529
3530         Speed up killing of Apache on Windows
3531
3532         Fixes <http://webkit.org/b/42289> Killing Apache (and thus quitting
3533         run-webkit-tests) takes a long time on Windows
3534
3535         Reviewed by Darin Adler and Jon Honeycutt.
3536
3537         * Scripts/webkitperl/httpd.pm:
3538         (closeHTTPD): Use taskkill to kill Apache and its child processes.
3539         Perl's kill seems ineffectual. We were already using taskkill, but
3540         only after trying kill 20 times. Since kill never works, let's just
3541         skip it entirely.
3542
3543 2010-07-14  Johnny Ding  <jnd@chromium.org>
3544
3545         Reviewed by Adam Barth.
3546
3547         https://bugs.webkit.org/show_bug.cgi?id=41292
3548         Add a new parameter to the test plugin to allow to specify a script and a
3549         mouse/keyboard event. The specified script will be evaluated in the browser
3550         when the specified event is received by the plugin.
3551
3552         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3553         (pluginAllocate):
3554         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3555         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3556         (NPP_New):
3557         (handleEventCarbon):
3558         (handleEventCocoa):
3559
3560 2010-07-14  Adam Roben  <aroben@apple.com>
3561
3562         Make urlSuitableForTestResult work for http: URLs, too
3563
3564         Fixes <http://webkit.org/b/42276>
3565         http/tests/loading/preload-slow-loading.php and
3566         http/tests/mime/uppercase-mime-type.html fail on Windows.
3567
3568         Reviewed by Darin Adler.
3569
3570         * DumpRenderTree/win/DumpRenderTree.cpp:
3571         (urlSuitableForTestResult): Don't bail if the URL starts with http://.
3572         We want this function to work for those URLs, too!
3573
3574 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
3575
3576         Reviewed by Oliver Hunt.
3577
3578         Add placebo versions of some repaint test functions to WebKitTestRunner - good enough for non-pixel tests
3579         https://bugs.webkit.org/show_bug.cgi?id=42227
3580
3581         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3582         (WTR::LayoutTestController::LayoutTestController): Initialize new bool
3583         members.
3584         (WTR::LayoutTestController::display): Dummy method.
3585         (WTR::displayCallback): Call the dummy.
3586         (WTR::repaintSweepHorizontallyCallback): ditto
3587         (WTR::testRepaintCallback): ditto
3588         (WTR::LayoutTestController::staticFunctions): Expose new methods.
3589         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3590         (WTR::LayoutTestController::setTestRepaint): Set the flag (which currently does
3591         nothing).
3592         (WTR::LayoutTestController::setTestRepaintSweepHorizontally): ditto
3593
3594 2010-07-13  Andreas Kling  <andreas.kling@nokia.com>
3595
3596         Unreviewed. Adding myself as committer.
3597
3598         * Scripts/webkitpy/common/config/committers.py:
3599
3600 2010-07-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3601
3602         Reviewed by Darin Adler.
3603
3604         Prevent assertion/duplicate loads for non-deferred subtitute-data loads
3605
3606         https://bugs.webkit.org/show_bug.cgi?id=30879
3607
3608         MainResourceLoader uses the member m_initialRequest to store requests for future
3609         deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
3610         have to clear this request so that subsequent entries into the loader will not
3611         start yet another load.
3612
3613         This can happen as a result of a PageGroupLoadDeferrer going out of scope when
3614         returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
3615         but only in the case of using both substitute-data and non-deferred main resource
3616         load together. That's why two new DRT functions were added:
3617
3618          * queueLoadHTMLString()
3619          * setDeferMainResourceLoad()
3620
3621         The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
3622         and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
3623         added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
3624
3625         * DumpRenderTree/LayoutTestController.cpp:
3626         (LayoutTestController::LayoutTestController):
3627         (queueLoadHTMLStringCallback):
3628         (setDeferMainResourceDataLoadCallback):
3629         (LayoutTestController::staticFunctions):
3630         (LayoutTestController::queueLoadHTMLString):
3631         * DumpRenderTree/LayoutTestController.h:
3632         (LayoutTestController::deferMainResourceDataLoad):
3633         (LayoutTestController::setDeferMainResourceDataLoad):
3634         * DumpRenderTree/WorkQueueItem.h:
3635         (LoadHTMLStringItem::LoadHTMLStringItem):
3636         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
3637         (LoadHTMLStringItem::invoke):
3638         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3639         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3640         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3641         (LoadHTMLStringItem::invoke):
3642         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3643         (LayoutTestController::reset):
3644         (LayoutTestController::setDeferMainResourceDataLoad):
3645         (LayoutTestController::queueLoadHTMLString):
3646         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3647         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
3648         (LoadHTMLStringItem::invoke):
3649         * DumpRenderTree/qt/WorkQueueItemQt.h:
3650         (LoadHTMLStringItem::LoadHTMLStringItem):
3651         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3652         (ResourceLoadDelegate::willSendRequest):
3653         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3654         (LoadHTMLStringItem::invoke):
3655         * DumpRenderTree/wx/WorkQueueItemWx.cpp:
3656         (LoadHTMLStringItem::invoke):
3657
3658 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
3659
3660         Reviewed by Nikolas Zimmermann.
3661
3662         Activate test fonts for layout tests in WebKitTestRunner (on Mac)
3663         https://bugs.webkit.org/show_bug.cgi?id=42153
3664
3665         * WebKitTestRunner/InjectedBundle/ActivateFonts.h: Added.
3666         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3667         (WTR::InjectedBundle::initialize): Activate fonts on startup.
3668         * WebKitTestRunner/InjectedBundle/mac: Added.
3669         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: Added.
3670         (WTR::activateFonts): Activate our fonts.
3671         * WebKitTestRunner/InjectedBundle/win: Added.
3672         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Added.
3673         (WTR::activateFonts): Dummy version.
3674         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Copy fonts to bundle;
3675         add more files.
3676         * WebKitTestRunner/fonts: Added.
3677         * WebKitTestRunner/fonts/AHEM____.TTF: Added.
3678         * WebKitTestRunner/fonts/ColorBits-A.png: Added.
3679         * WebKitTestRunner/fonts/ColorBits.ttf: Added.
3680         * WebKitTestRunner/fonts/WebKit Layout Tests 2.ttf: Added.
3681         * WebKitTestRunner/fonts/WebKit Layout Tests.ttf: Added.
3682         * WebKitTestRunner/fonts/WebKitWeightWatcher100.ttf: Added.
3683         * WebKitTestRunner/fonts/WebKitWeightWatcher200.ttf: Added.
3684         * WebKitTestRunner/fonts/WebKitWeightWatcher300.ttf: Added.
3685         * WebKitTestRunner/fonts/WebKitWeightWatcher400.ttf: Added.
3686         * WebKitTestRunner/fonts/WebKitWeightWatcher500.ttf: Added.
3687         * WebKitTestRunner/fonts/WebKitWeightWatcher600.ttf: Added.
3688         * WebKitTestRunner/fonts/WebKitWeightWatcher700.ttf: Added.
3689         * WebKitTestRunner/fonts/WebKitWeightWatcher800.ttf: Added.
3690         * WebKitTestRunner/fonts/WebKitWeightWatcher900.ttf: Added.
3691
3692 2010-07-13  Dumitru Daniliuc  <dumi@chromium.org>
3693
3694         Reviewed by Eric Seidel.
3695
3696         Remove check-header-includes, as it didn't turn out to be very useful.
3697         https://bugs.webkit.org/show_bug.cgi?id=41970
3698
3699         * Scripts/check-header-includes: Removed.
3700
3701 2010-07-12  Steve Falkenburg  <sfalken@apple.com>
3702
3703         Reviewed by Maciej Stachowiak.
3704
3705         Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
3706         https://bugs.webkit.org/show_bug.cgi?id=40922
3707         
3708         Always build WebKit2 on Windows. Necessary since our WebKit build on
3709         Windows is packaged into a DLL with WebKit2.
3710
3711         * Scripts/build-webkit: Always build WebKit2 on Windows.
3712
3713 2010-07-12  Brian Weinstein  <bweinstein@apple.com>
3714
3715         Reviewed by Steve Falkenburg.
3716
3717         One http test timing out on Windows can cause all future tests to time out
3718         https://bugs.webkit.org/show_bug.cgi?id=42146
3719         
3720         There have been multiple times on the Windows bots where one http test timing out causes all future
3721         http tests to time out. This is because the httpd process becomes unresponsive. When an http test
3722         times out, we should restart httpd on Cygwin to prevent this.
3723
3724         * Scripts/old-run-webkit-tests: If an http test timed out on Cygwin, close httpd and restart it.
3725         * Scripts/webkitperl/httpd.pm: Add additional logic to closeHTTPD to teach it about taskkill if
3726             using kill fails.
3727
3728 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
3729
3730         Reviewed by Dan Bernstein.
3731
3732         Remove use of auto_ptr in WebKitTestRunner
3733         https://bugs.webkit.org/show_bug.cgi?id=42134
3734         
3735         Replaced auto_ptr with PassOwnPtr / OwnPtr.
3736
3737         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3738         (WTR::WKStringToUTF8):
3739         (WTR::InjectedBundlePage::dump):
3740         (WTR::InjectedBundlePage::addMessageToConsole):
3741         * WebKitTestRunner/TestInvocation.cpp:
3742         (WTR::WKStringToUTF8):
3743         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
3744
3745 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
3746
3747         Reviewed by Sam Weinig.
3748
3749         Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it)
3750         https://bugs.webkit.org/show_bug.cgi?id=42132
3751
3752         * Scripts/old-run-webkit-tests: In --webkit-test-runner mode, add mac-wk2 to list of
3753         platform directories.
3754
3755 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
3756
3757         Reviewed by Anders Carlsson.
3758
3759         Make WebKitTestRunner resize the view specially for the W3C SVG tests.
3760         https://bugs.webkit.org/show_bug.cgi?id=42126
3761
3762         * WebKitTestRunner/PlatformWebView.h:
3763         * WebKitTestRunner/TestInvocation.cpp:
3764         (WTR::TestInvocation::TestInvocation): Store the path as a C
3765         string for later use.
3766         (WTR::TestInvocation::~TestInvocation):
3767         (WTR::sizeWebViewForCurrentTest): Resize the WebView to the proper
3768         size, depending on whether this is a W3C SVG test.
3769         (WTR::TestInvocation::invoke): Call the size function.
3770         * WebKitTestRunner/TestInvocation.h:
3771         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3772         (WTR::PlatformWebView::resizeTo): Implement.
3773         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3774         (WTR::PlatformWebView::resizeTo): Placeholder.
3775
3776 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
3777
3778         Reviewed by Xan Lopez.
3779
3780         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
3781         https://bugs.webkit.org/show_bug.cgi?id=38648
3782
3783         Add the GTK_MODULES envvar (set to "gail") to the clean
3784         environment when running DRT for the Gtk+ port
3785
3786         * Scripts/old-run-webkit-tests:
3787
3788 2010-07-12  Martin Robinson  <mrobinson@igalia.com>
3789
3790         Reviewed by Dirk Schulze.
3791
3792         [GTK] Support pixel tests
3793         https://bugs.webkit.org/show_bug.cgi?id=31518
3794
3795         Finish support for pixel tests on GTK+.
3796
3797         * DumpRenderTree/PixelDumpSupport.cpp: Remove unecessary RetainPtr include (only
3798         works on CoreFoundation systems) and add missing cstdio include.
3799         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Switch to using the MD5 support found
3800         in JSC library. MD5.cpp and MD5.h are only available for the Windows build.
3801         (computeMD5HashStringForBitmapContext): The number of bytes per row should be the row stride
3802         of the image, not the row stride multiplied by the width. Use JSC MD5 implementation to calculate
3803         the MD5 hash here. According to glibc manpages, using snprintf to build a string in unsupported
3804         by the ANSI standard and this fails on Linux, so unroll the loop here.
3805         * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Correct some constructor misbehavior.
3806         (BitmapContext::BitmapContext): There is no reason to check the value of the
3807         m_context member in the constructor and it certainly should not be freed. Instead
3808         just initialize it with the incoming value.
3809         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the order of includes.
3810         (dump): Actually call dumpWebViewAsPixelsAndCompareWithExpected when it is time to
3811         dump pixels.
3812         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Added.
3813         (createBitmapContextFromWebView):
3814         * GNUmakefile.am: Add new files to the build.
3815
3816 2010-07-12  Adam Barth  <abarth@webkit.org>
3817
3818         Unreviewed.
3819
3820         Remove stray "raise e" that got included in a previous patch.  This
3821         caused the EWS bots to turn red instead of purple when a patch failed
3822         to apply.
3823
3824         * Scripts/webkitpy/tool/commands/stepsequence.py:
3825
3826 2010-07-12  Sheriff Bot  <webkit.review.bot@gmail.com>
3827
3828         Unreviewed, rolling out r63101.
3829         http://trac.webkit.org/changeset/63101
3830         https://bugs.webkit.org/show_bug.cgi?id=42103
3831
3832         Broke one API test (Requested by xan_ on #webkit).
3833
3834         * Scripts/old-run-webkit-tests:
3835
3836 2010-07-12  Alexey Proskuryakov  <ap@apple.com>
3837
3838         Reviewed by Adam Roben.
3839
3840         https://bugs.webkit.org/show_bug.cgi?id=13075
3841         XMLHttpRequest with failed authentication should set status to 401
3842
3843         https://bugs.webkit.org/show_bug.cgi?id=6871
3844         <rdar://problem/3363403> 401 error page is never shown
3845
3846         Fix crashes in Windows DumpRenderTree.
3847
3848         * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3849         If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge()
3850         again on a destroyed sender.
3851
3852 2010-07-12  Adam Roben  <aroben@apple.com>
3853
3854         Windows failure-to-launch fix
3855
3856         * DumpRenderTree/win/DumpRenderTree.vcproj: Copy CoreVideo.dll and
3857         CoreVideo.pdb into WebKitOutputDir in the post-build event, too, like
3858         we already do for CoreFoundation, CFNetwork, etc.
3859
3860 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
3861
3862         Reviewed by Xan Lopez.
3863
3864         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
3865         https://bugs.webkit.org/show_bug.cgi?id=38648
3866
3867         Add the GTK_MODULES envvar (set to "gail") to the clean
3868         environment when running DRT for the Gtk+ port
3869
3870         * Scripts/old-run-webkit-tests:
3871
3872 2010-07-09  Alexey Proskuryakov  <ap@apple.com>
3873
3874         Reviewed by Darin Adler.
3875
3876         https://bugs.webkit.org/show_bug.cgi?id=13075
3877         XMLHttpRequest with failed authentication should set status to 401
3878
3879         https://bugs.webkit.org/show_bug.cgi?id=6871
3880         <rdar://problem/3363403> 401 error page is never shown
3881
3882         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3883         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
3884         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3885         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3886         Do respond even if handlesAuthenticationChallenges() is false. Pretend that the user pressed
3887         the Cancel button.
3888
3889 2010-07-12  Andreas Kling  <andreas.kling@nokia.com>
3890
3891         Reviewed by Tor Arne Vestbø.
3892
3893         [Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser
3894         https://bugs.webkit.org/show_bug.cgi?id=42082
3895
3896         * QtTestBrowser/main.cpp:
3897         (LauncherWindow::createChrome):
3898         * QtTestBrowser/mainwindow.cpp:
3899         (MainWindow::openLocation):
3900         * QtTestBrowser/mainwindow.h:
3901
3902 2010-07-12  Adam Roben  <aroben@apple.com>
3903
3904         Make the Python autoinstaller not use a dead SourceForge server
3905
3906         Fixes <http://webkit.org/b/42080> webkit-patch is broken due to
3907         offline SourceForge server
3908
3909         Reviewed by Anders Carlsson.
3910
3911         * Scripts/webkitpy/thirdparty/__init__.py: Use
3912         surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net,
3913         which seems to be down.
3914
3915 2010-07-12  Adam Roben  <aroben@apple.com>
3916
3917         Make run-webkit-tests print how many tests timed out when exiting
3918         early
3919
3920         The number of timed-out tests is taken into account when deciding
3921         whether to exit early. Leaving it out of the output just makes the
3922         script look buggy (because it might say something like "Exiting early
3923         after 0 crashes.").
3924
3925         Fixes <http://webkit.org/b/42077> run-webkit-tests prints confusing
3926         messages when exiting early due to crashes and time-outs
3927
3928         Reviewed by Anders Carlsson.
3929
3930         * Scripts/old-run-webkit-tests:
3931         (stopRunningTestsEarlyIfNeeded): When stopping, print the number of
3932         timed-out tests, too.
3933
3934 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
3935
3936         Reviewed by Dan Bernstein.
3937
3938         Implement animation-related methods for WebKitTestRunner
3939         https://bugs.webkit.org/show_bug.cgi?id=42053
3940         
3941         Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
3942         animation tests were hanging otherwise.
3943
3944         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3945         (WTR::LayoutTestController::numberOfActiveAnimations):
3946         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3947         (WTR::numberOfActiveAnimationsCallback):
3948         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
3949         (WTR::LayoutTestController::staticFunctions):
3950         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3951
3952 2010-07-11  Daniel Bates  <dbates@rim.com>
3953
3954         Reviewed by David Kilzer.
3955
3956         Enable executable support for svn-apply and svn-unapply
3957         https://bugs.webkit.org/show_bug.cgi?id=39409
3958
3959         Connect up the Git and SVN executable bit support in parseDiff() so that
3960         executable bit changes are propagated via the returned diff hash to the
3961         patch function in svn-apply and svn-unapply.
3962
3963         * Scripts/VCSUtils.pm:
3964           - Modified parseDiff() to call parseSvnDiffProperties when
3965             it finds the start of an SVN property change diff.
3966           - Removed FIXME comment above parseSvnDiffProperties() since
3967             it is now being used by parseDiff().
3968           - Export method scmToggleExecutableBit() now that we added the
3969             executableBitDelta hash key. (This should have been exported
3970             when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
3971         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
3972           - Updated results for:
3973             "rename (with executable bit change)"
3974               - Test value of executableBitDelta (now that we have support).
3975             "SVN: binary file (isBinary true)"
3976               - Remove the property change diff from svnConvertedText. We plan
3977                 to remove svnConvertedText in the future. So, we decided
3978                 against adding such support to any new code, such as the
3979                 property parsing routines. Therefore, we do not keep SVN
3980                 converted text for property change diffs.
3981           - Added unit tests:
3982             "SVN: file change diff with property change diff"
3983             "SVN: file change diff, followed by property change diff on different file"
3984             "SVN: property diff, followed by file change diff"
3985             "SVN: copied file with property change"
3986             "SVN: two consecutive property diffs"
3987             "SVN: binary file with executable bit change"
3988             "SVN: binary file followed by property change on different file"
3989             "SVN: binary file followed by file change on different file"
3990             "SVN: file change diff with property change, followed by property change diff"
3991             "SVN: file change diff with property change, followed by file change diff"
3992
3993 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
3994
3995         Reviewed by Dan Bernstein.
3996
3997         Implement waitUntilDone and notifyDone for WebKitTestRunner
3998         https://bugs.webkit.org/show_bug.cgi?id=42049
3999
4000         With this fix, most of the DOM tests pass.
4001         
4002         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4003         (WTR::InjectedBundle::didCreatePage): Track the main page. Not
4004         a great way to do it in the future case where we may get multiple
4005         pages - we really need a way to send it over from the ui process.
4006         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4007         (WTR::InjectedBundle::page): A way to get the main page.
4008         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4009         (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
4010         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
4011         are loading.
4012         (WTR::InjectedBundlePage::dump): Factor into a method so this can be
4013         called by the layout test controller. Also, cancel any pending watchdogs.
4014         (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
4015         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
4016         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4017         (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
4018         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4019         (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
4020         to false.
4021         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate 
4022         the watchdog.
4023         (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
4024         (WTR::LayoutTestController::setWaitToDump): Set the flag.
4025         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
4026         where waitUntilDone times out.
4027         (WTR::LayoutTestController::notifyDone): Dump, if loading is done.
4028         (WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
4029         (WTR::notifyDoneCallback): JS glue for notifyDone.
4030         (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
4031         to the layoutController.
4032         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4033         (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
4034
4035 2010-07-09  Brian Weinstein  <bweinstein@apple.com>
4036
4037         Rubber-stamped by Dan Bernstein.
4038
4039         Windows testers running Windows 7 were hanging during test_kill_process. Changing the
4040         number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
4041         slow down the tests).
4042
4043         * Scripts/webkitpy/common/system/executive.py:
4044
4045 2010-07-09  Luiz Agostini  <luiz.agostini@openbossa.org>
4046
4047         Reviewed by Kenneth Rohde Christiansen.
4048
4049         [Qt] Mac build fix
4050         https://bugs.webkit.org/show_bug.cgi?id=41967
4051
4052         Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
4053
4054         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4055
4056 2010-07-09  Diego Gonzalez  <diegohcg@webkit.org>
4057
4058         Reviewed by Antonio Gomes.
4059
4060         [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
4061         https://bugs.webkit.org/show_bug.cgi?id=41966
4062
4063         * MiniBrowser/qt/BrowserWindow.cpp:
4064         (BrowserWindow::BrowserWindow):
4065
4066 2010-07-09  Leon Clarke  <leonclarke@google.com>
4067
4068         Reviewed by Adam Barth.
4069
4070         add support for link prefetching
4071         https://bugs.webkit.org/show_bug.cgi?id=3652
4072
4073         * Scripts/build-webkit:
4074
4075 2010-07-09  Ojan Vafai  <ojan@chromium.org>
4076
4077         Reviewed by Adam Barth.
4078
4079         r63004 broke some python tests
4080         https://bugs.webkit.org/show_bug.cgi?id=42007
4081
4082         AbstractStep now checks options.no_squash and options.squash, so
4083         they needed to have real values. Mock would return an object for those,
4084         which would then act as if the values were True.
4085
4086         * Scripts/webkitpy/tool/commands/commandtest.py:
4087         * Scripts/webkitpy/tool/commands/download_unittest.py:
4088         * Scripts/webkitpy/tool/commands/stepsequence.py:
4089         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4090         * Scripts/webkitpy/tool/mocktool.py:
4091         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
4092         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
4093         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4094         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
4095         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
4096
4097 2010-07-09  Ojan Vafai  <ojan@chromium.org>
4098
4099         Reviewed by Adam Barth.
4100
4101         --squash should go away and become the default
4102         https://bugs.webkit.org/show_bug.cgi?id=39624
4103
4104         If there are local commits and working copy changes, then prompt the user
4105         whether to continue. Setting git config webkit-patch.commit_should_always_squash
4106         true bypasses the prompt.
4107
4108         --git-commit=HEAD.. operates on working copy changes only.
4109         --git-commit=committish operates on a range of commits as a single commit.
4110             e.g. --git-commit=HEAD only operates on the HEAD commit.
4111             --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
4112
4113         --no-squash and --squash are left in with descriptive error messages if used.
4114
4115         * Scripts/check-webkit-style:
4116         * Scripts/webkitpy/common/checkout/api.py:
4117         * Scripts/webkitpy/common/checkout/api_unittest.py:
4118         * Scripts/webkitpy/common/checkout/scm.py:
4119         * Scripts/webkitpy/common/checkout/scm_unittest.py:
4120         * Scripts/webkitpy/common/net/rietveld.py:
4121         * Scripts/webkitpy/common/system/user.py:
4122         * Scripts/webkitpy/style/optparser.py:
4123         * Scripts/webkitpy/style_references.py:
4124         * Scripts/webkitpy/tool/commands/download.py:
4125         * Scripts/webkitpy/tool/commands/upload.py:
4126         * Scripts/webkitpy/tool/mocktool.py:
4127         * Scripts/webkitpy/tool/steps/abstractstep.py:
4128         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
4129         * Scripts/webkitpy/tool/steps/checkstyle.py:
4130         * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
4131         * Scripts/webkitpy/tool/steps/commit.py:
4132         * Scripts/webkitpy/tool/steps/options.py:
4133         * Scripts/webkitpy/tool/steps/preparechangelog.py:
4134         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4135         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
4136         * Scripts/webkitpy/tool/steps/validatereviewer.py:
4137
4138 2010-07-09  Mark Rowe  <mrowe@apple.com>
4139
4140         Add two new Windows test build slaves.
4141
4142         * BuildSlaveSupport/build.webkit.org-config/config.json:
4143
4144 2010-07-09  Albert J. Wong  <ajwong@chromium.org>
4145
4146         Reviewed by David Levin.
4147
4148         rebaseline_chromium_webkit_tests missing --use_drt option on linux
4149         https://bugs.webkit.org/show_bug.cgi?id=41985
4150
4151         This adds in the --use_drt option for rebaseline_chromium_webkit_tests
4152         so that it works on linux. This is essentially a "compile-fix" for the
4153         script.
4154
4155         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
4156
4157 2010-07-09  Nico Weber  <thakis@chromium.org>
4158
4159         Unreviewed. Adding myself as committer.
4160
4161         * Scripts/webkitpy/common/config/committers.py:
4162
4163 2010-07-09  David Kilzer  <ddkilzer@apple.com>
4164
4165         Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"
4166
4167         This reverts commit r62692.
4168
4169         * Scripts/commit-log-editor:
4170
4171 2010-07-08  Kinuko Yasuda  <kinuko@chromium.org>
4172
4173         Reviewed by Ojan Vafai.
4174
4175         cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
4176         https://bugs.webkit.org/show_bug.cgi?id=38693
4177
4178         Introduced a new base class JSONResultsGeneratorBase that doesn't
4179         have any dependency on layout_tests packages.
4180         Turned JSONResultsGenerator into a wrapper class of the base class
4181         so that the old code can work with it during the cleanup.
4182
4183         Added json_results_generator_unittest.py.
4184
4185         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
4186         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4187         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
4188
4189 2010-07-09  Abhishek Arya  <inferno@chromium.org>
4190
4191         Unreviewed.
4192
4193         Marking myself as a committer.
4194
4195         * Scripts/webkitpy/common/config/committers.py:
4196
4197 2010-07-09  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
4198
4199         Reviewed by Antti Koivisto.
4200
4201         Implement MiniBrowser for Qt.
4202         https://bugs.webkit.org/show_bug.cgi?id=40233
4203
4204         * MiniBrowser/qt/BrowserWindow.cpp: Added.
4205         (createNewPage):
4206         (BrowserView::BrowserView):
4207         (BrowserView::resizeEvent):
4208         (BrowserView::load):
4209         (BrowserView::view):
4210         (BrowserWindow::BrowserWindow):
4211         (BrowserWindow::load):
4212         (BrowserWindow::changeLocation):
4213         (BrowserWindow::~BrowserWindow):
4214         * MiniBrowser/qt/BrowserWindow.h: Added.
4215         (BrowserView::~BrowserView):
4216         * MiniBrowser/qt/MiniBrowser.pro: Added.
4217         * MiniBrowser/qt/main.cpp: Added.
4218         (main):
4219
4220 2010-07-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
4221