2010-05-01 Daniel Bates <dbates@rim.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-05-01  Daniel Bates  <dbates@rim.com>
2
3         Reviewed by Chris Jerdonek.
4
5         https://bugs.webkit.org/show_bug.cgi?id=38423
6
7         Adds infrastructure to change the file mode of a file using
8         the appropriate SCM-specific routines.
9
10         No functionality was changed, so no new tests.
11
12         * Scripts/VCSUtils.pm: Added subroutines scmToggleExecutableBit,
13         scmAddExecutableBit, and scmRemoveExecutableBit.
14         * Scripts/svn-apply: Check for the hash key executableBitDelta
15         and toggle the executable bit.
16         * Scripts/svn-unapply: Ditto.
17
18 2010-04-30  Chris Marrin  <cmarrin@apple.com>
19
20         Reviewed by Simon Fraser.
21
22         Enabled accelerated compositing in DRT for Windows
23         https://bugs.webkit.org/show_bug.cgi?id=38404
24
25         * DumpRenderTree/win/DumpRenderTree.cpp:
26         (main):
27
28 2010-04-30  Anders Carlsson  <andersca@apple.com>
29
30         Try to fix GTK+ build.
31
32         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
33         (webkit_test_plugin_new_stream):
34
35 2010-04-30  Anders Carlsson  <andersca@apple.com>
36
37         Fix build.
38
39         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
40
41 2010-04-30  Anders Carlsson  <andersca@apple.com>
42
43         Reviewed by Timothy Hatcher.
44
45         Next step towards fixing
46         
47         https://bugs.webkit.org/show_bug.cgi?id=20784
48         move npapi.h to C99 integer types
49
50         Use the C99 types everywhere. The "old" types are still around but will be removed
51         in a subsequent commit.
52
53         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
54         (int32VariantToIdentifier):
55         (doubleVariantToIdentifier):
56         (testIdentifierToInt):
57         (testGetIntIdentifier):
58         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
59         (NPP_New):
60         (NPP_NewStream):
61         (NPP_WriteReady):
62         (NPP_Write):
63         (NPP_HandleEvent):
64         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
65         (NPP_New):
66         (NPP_NewStream):
67         (NPP_WriteReady):
68         (NPP_Write):
69         (NPP_HandleEvent):
70
71 2010-04-30  Steve Block  <steveblock@google.com>
72
73         Reviewed by Jeremy Orlow.
74
75         Changed Steve Block from committer to reviewer.
76
77         * Scripts/webkitpy/common/config/committers.py:
78
79 2010-04-28  Ojan Vafai  <ojan@chromium.org>
80
81         Reviewed by Eric Seidel.
82
83         webkit-patch doesn't work if a git repo is tracking multiple svn repos
84         https://bugs.webkit.org/show_bug.cgi?id=38290
85         
86         Getting the tests to pass required getting our SVN repo to more closely
87         match the real svn.webkit.org repo by having a trunk directory.
88         That involved adding an extra commit at the beginning and thus changing
89         all the commit numbers in the tests.
90
91         * Scripts/webkitpy/common/checkout/scm.py:
92
93 2010-04-29  Eric Seidel  <eric@webkit.org>
94
95         Reviewed by Adam Barth.
96
97         new-run-webkit-tests can deadlock with Chromium's TestShell
98         https://bugs.webkit.org/show_bug.cgi?id=38298
99
100         Fix _write_command_and_read_line to never send unicode() to
101         test_shell, instead to always encode as utf-8.  This was causing
102         random hangs because if test_shell ever encounters a \0 in the
103         stream it can deadlock with NRWT.
104
105         There is still a deadlock bug to fix in NRWT/test_shell design, however
106         this fix should make the deadlock occur less often.
107
108         * Scripts/webkitpy/layout_tests/port/chromium.py:
109         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
110
111 2010-04-29  Chris Jerdonek  <cjerdonek@webkit.org>
112
113         Reviewed by Eric Seidel.
114
115         Refactored svn-apply and svn-unapply to use the new
116         parsePatch() subroutine.
117
118         https://bugs.webkit.org/show_bug.cgi?id=34033
119
120         * Scripts/VCSUtils.pm:
121           - Consolidated %diffHash documentation.
122           - Added prepareParsedPatch().
123
124         * Scripts/svn-apply:
125           - Replaced main while loop with calls to parsePatch() and
126             prepareParsedPatch().
127
128         * Scripts/svn-unapply:
129           - Replaced main while loop with calls to parsePatch() and
130             prepareParsedPatch().
131
132         * Scripts/test-webkitperl:
133           - Changed to render relative test paths rather than absolute
134             test paths.
135
136         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl: Added.
137           - Added unit tests for prepareParsedPatch().
138
139 2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>
140
141         Reviewed by Eric Seidel.
142
143         Added to VCSUtils's parseDiffHeader() support for binary patches.
144
145         https://bugs.webkit.org/show_bug.cgi?id=38094
146
147         The parseDiffHeader() function is part of new patch-parsing code
148         for svn-apply and svn-unapply that will go live in a subsequent
149         revision.
150
151         * Scripts/VCSUtils.pm:
152           - Added logic to parseDiffHeader() to recognize the ending of
153             the header portion of a binary diff.
154
155         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
156           - Added unit test cases for SVN and Git binary diffs.
157
158 2010-04-28  Eric Seidel  <eric@webkit.org>
159
160         Reviewed by David Levin.
161
162         Document that subprocess.poll/wait are not threadsafe
163         https://bugs.webkit.org/show_bug.cgi?id=38289
164
165         * Scripts/webkitpy/common/system/executive.py:
166         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
167         * Scripts/webkitpy/layout_tests/port/chromium.py:
168         * Scripts/webkitpy/layout_tests/port/http_server.py:
169         * Scripts/webkitpy/layout_tests/port/server_process.py:
170         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
171
172 2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>
173
174         Reviewed by Daniel Bates.
175
176         Removed the dividing line (i.e. "====...") logic from the code
177         called by svn-apply and svn-unapply.
178
179         https://bugs.webkit.org/show_bug.cgi?id=38093
180
181         The dividing line logic is unnecessary.  Removing it simplifies the
182         code and makes some subsequent changes easier.
183
184         * Scripts/VCSUtils.pm:
185           - Removed the logic in gitdiff2svndiff() to convert the git
186             "index" line to an SVN dividing line.
187           - Adjusted the logic similarly in parseDiffHeader().
188
189         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
190           - Updated the unit tests as necessary.
191
192         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
193           - Updated the unit tests as necessary.
194           - Corrected an error in the unit tests whereby all elements
195             of an array were referencing the same element rather than
196             distinct elements -- causing unit test failures to be masked.
197
198         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
199           - Updated the unit tests as necessary.
200           - Made the same unit test correction as above for parseDiff.pl.
201
202 2010-04-28  Evan Stade  <estade@chromium.org>
203
204         Unreviewed.
205
206         * Scripts/webkitpy/common/config/committers.py: adding myself as a committer
207
208 2010-04-28  Sam Weinig  <sam@webkit.org>
209
210         Reviewed by Mark Rowe.
211
212         Add MiniBrowser to the lists of modules to build and only build it on
213         SnowLeopard and later.
214
215         * Makefile:
216         * MiniBrowser/Makefile:
217
218 2010-04-28  Sam Weinig  <sam@webkit.org>
219
220         Reviewed by Mark Rowe.
221
222         Make running MiniBrowser.app without explicitly setting DYLD_FRAMEWORK_PATH.
223
224         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
225         * MiniBrowser/mac/make-launchable.sh: Added.
226
227 2010-04-28  Eric Seidel  <eric@webkit.org>
228
229         Reviewed by David Levin.
230
231         Audit all uses of subprocess in webkitpy
232         https://bugs.webkit.org/show_bug.cgi?id=38284
233
234         After further discussions with Jeffrey Yasskin
235         about http://bugs.python.org/issue2320
236         and related issues of using subprocess from
237         multiple threads, I have learned that subprocess
238         is known to be non-threadsafe through recent
239         Python 2.7 builds.
240
241         I'm attempting to lessen our exposure to these
242         subprocess bugs by auditing each use of subprocess
243         in webkitpy.  I did not find any unsafe calls
244         in my audit, but I did remove numerous unneeded
245         import subprocess lines.
246
247         * Scripts/webkitpy/common/checkout/api.py:
248         * Scripts/webkitpy/common/net/bugzilla.py:
249         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
250         * Scripts/webkitpy/common/system/user.py:
251         * Scripts/webkitpy/layout_tests/port/base.py:
252         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
253         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
254         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Added.
255         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
256         * Scripts/webkitpy/layout_tests/port/gtk.py:
257         * Scripts/webkitpy/layout_tests/port/mac.py:
258         * Scripts/webkitpy/layout_tests/port/qt.py:
259         * Scripts/webkitpy/layout_tests/port/webkit.py:
260         * Scripts/webkitpy/layout_tests/port/win.py:
261
262 2010-04-28  Darin Adler  <darin@apple.com>
263
264         Ignore a directory the Python tools creates.
265
266         * Scripts/webkitpy/style: Modified property svn:ignore.
267
268 2010-04-28  Darin Adler  <darin@apple.com>
269
270         * Scripts/extract-localizable-strings: Fix minor mistake in
271         argument checking.
272
273 2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>
274
275         Reviewed by Kenneth Rohde Christiansen.
276
277         [Qt] QWebPage viewMode property
278         https://bugs.webkit.org/show_bug.cgi?id=38119
279
280         Replacing method qt_wrt_setViewMode by wrt_viewMode property.
281
282         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
283         (LayoutTestController::setViewModeMediaFeature):
284
285 2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>
286
287         Reviewed by Shinichiro Hamaji.
288
289         Adjusted check-webkit-style so that files with file type NONE
290         are automatically skipped without warning.
291
292         https://bugs.webkit.org/show_bug.cgi?id=38197
293
294         This change simplifies configuring which files to skip.  It also
295         addresses an issue whereby check-webkit-style was unintentionally
296         checking .vcproj files for carriage returns.
297
298         * Scripts/webkitpy/style/checker.py:
299           - Moved the C++, Python, and text file extensions to new
300             module-level configuration variables.
301           - Removed .pyc from the _SKIPPED_FILES_WITHOUT_WARNING configuration
302             variable.
303           - Changed the numeric values of the FileType enum so that
304             FileType.NONE evaluates to False.
305           - For ProcessorDispatcher.should_skip_without_warning():
306             - Changed the method to return True for FileType.NONE files.
307             - Made ChangeLog files an exception to getting skipped.
308           - Changed the StyleProcessor.process() method to raise an
309             exception if given a file path that should not be processed.
310
311         * Scripts/webkitpy/style/checker_unittest.py:
312           - Updated the unit tests and added more test cases as necessary.
313
314 2010-04-28  Eric Seidel  <eric@webkit.org>
315
316         Reviewed by Jeremy Orlow.
317
318         webkitpy: ScriptError('Failed to run "[u\'taskkill.exe\', u\'/f\', u\'/im\', u\'httpd.exe\']" exit_code: 128',)
319         https://bugs.webkit.org/show_bug.cgi?id=38248
320
321         The previous code did not check the return code of taskkill.
322         When I moved that callsite from using subprocess.call to
323         Executive.run_command having a non-zero return code became an error.
324
325         In this change I've centralized our killall handling in executive,
326         and added tests for it to make sure it works.
327
328         Currently kill_process and kill_all swallow exceptions in the cases
329         where the process(es) to be killed do(es) not exist.
330
331         * Scripts/webkitpy/common/system/executive.py:
332         * Scripts/webkitpy/common/system/executive_unittest.py:
333         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
334         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
335         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
336         * Scripts/webkitpy/layout_tests/port/gtk.py:
337         * Scripts/webkitpy/layout_tests/port/mac.py:
338         * Scripts/webkitpy/layout_tests/port/qt.py:
339         * Scripts/webkitpy/layout_tests/port/win.py:
340
341 2010-04-28  Eric Seidel  <eric@webkit.org>
342
343         Reviewed by Shinichiro Hamaji.
344
345         wdiff_text throws ScriptError because wdiff returns non-zero when files differ
346         https://bugs.webkit.org/show_bug.cgi?id=38246
347
348         wdiff returns 0 when files are the same, 1 when they differ.
349         run_command by default raises ScriptError if the return code is non-zero.
350         Fixed this by adding a custom error handler which only raises if the
351         return code is not 1.
352
353         I broke up the huge wdiff_text() method into little pieces
354         for easier unit testing.  There is only one functional change here
355         and that is the addition of the custom error handler.
356
357         * Scripts/webkitpy/layout_tests/port/base.py:
358         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
359
360 2010-04-28  Fumitoshi Ukai  <ukai@chromium.org>
361
362         Unreviewed build fix.
363
364         * DumpRenderTree/chromium/TestShell.cpp:
365         (TestShell::dumpImage): format '%u' expects type 'unsigned int', but argument 2 has type 'size_t'.
366         * DumpRenderTree/chromium/WebViewHost.cpp:
367         (WebViewHost::willSendRequest): too few arguments for format.
368
369 2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>
370
371         Reviewed by Darin Adler and Eric Seidel.
372
373         Add layoutTestController.setPrinting()
374         https://bugs.webkit.org/show_bug.cgi?id=37203
375
376         * DumpRenderTree/LayoutTestController.cpp:
377         (LayoutTestController::LayoutTestController):
378         (setPrintingCallback):
379         (LayoutTestController::staticFunctions):
380         * DumpRenderTree/LayoutTestController.h:
381         (LayoutTestController::isPrinting):
382         (LayoutTestController::setIsPrinting):
383         * DumpRenderTree/mac/DumpRenderTree.mm:
384         (dump):
385
386 2010-04-27  Michael Nordman  <michaeln@google.com>
387
388         Reviewed by Dmitry Titov.
389
390         [Chromium] Add two things to the webkit API to support appcaches in workers.
391         1) WebURLRequest TargetTypes for worker and shared worker main resources.
392         2) Factory method on class WebCommonWorkerClient to
393            createApplicationCacheHost() for the associated worker.
394
395         https://bugs.webkit.org/show_bug.cgi?id=38147
396
397         * DumpRenderTree/chromium/TestWebWorker.h add a stub impl of the factory method 
398         (TestWebWorker::createApplicationCacheHost):
399
400 2010-04-27  Adam Barth  <abarth@webkit.org>
401
402         Reviewed by Eric Seidel.
403
404         run-bindings-tests doesn't work in an SVN checkout
405         https://bugs.webkit.org/show_bug.cgi?id=38225
406
407         Previously detect_scm_system needed an absolute path for SVN.  Now we
408         accept a relative path.
409
410         * Scripts/webkitpy/common/checkout/scm.py:
411         * Scripts/webkitpy/common/checkout/scm_unittest.py:
412
413 2010-04-27  Sam Weinig  <sam@webkit.org>
414
415         Reviewed by Stephanie Lewis.
416
417         Always build WebKit2 when building on SnowLeopard and later. 
418
419         * Scripts/build-webkit:
420
421 2010-04-27  Sam Weinig  <sam@webkit.org>
422
423         Reviewed by Maciej Stachowiak.
424
425         Fix for https://bugs.webkit.org/show_bug.cgi?id=38238
426         Allow both WebKit and WebKit2 to link to the same WebCore.framework
427
428         * Scripts/build-webkit: Remove the UMBRELLA_LDFLAGS override when building
429         WebCore for WebKit2, it is no longer necessary.
430
431 2010-04-27  James Robinson  <jamesr@chromium.org>
432
433         Reviewed by David Levin.
434
435         Fix a typo in chromium.py that causes NRWT to fail in --verbose
436         mode in a Chromium checkout.
437         https://bugs.webkit.org/show_bug.cgi?id=38234
438
439         * Scripts/webkitpy/layout_tests/port/chromium.py:
440
441 2010-04-27  Darin Fisher  <darin@chromium.org>
442
443         Reviewed by Dimitri Glazkov.
444
445         [Chromium] Remove deprecated form of didChangeLocationWithinPage
446         https://bugs.webkit.org/show_bug.cgi?id=38178
447
448         Switch over to implementing didNavigateWithinPage.
449
450         * DumpRenderTree/chromium/WebViewHost.cpp:
451         (TestWebViewDelegate::didNavigateWithinPage):
452         (WebViewHost::didChangeLocationWithinPage):
453         * DumpRenderTree/chromium/WebViewHost.h:
454
455 2010-04-27  Evan Martin  <evan@chromium.org>
456
457         Unreviewed.
458
459         Adding myself to commmitters list.
460
461         * Scripts/webkitpy/common/config/committers.py:
462
463 2010-04-27  Adam Barth  <abarth@webkit.org>
464
465         Reviewed by Darin Adler.
466
467         run-bindings-tests should use --reset-results instead of --overwrite
468         https://bugs.webkit.org/show_bug.cgi?id=38200
469
470         As requested by Ojan.
471
472         * Scripts/run-bindings-tests:
473
474 2010-04-27  Adam Barth  <abarth@webkit.org>
475
476         Reviewed by Eric Seidel.
477
478         REGRESSION(r58261): webkit-patch edit-changelogs is broken
479         https://bugs.webkit.org/show_bug.cgi?id=38204
480
481         In 58261, we added code to abstract step that interrogates the squash
482         and git_commit options, but it doesn't declare that it uses those
483         options.  That means any command that doesn't happen to declare those
484         options might be broken if it uses the cached_lookup mechanism.
485
486         * Scripts/webkitpy/tool/steps/abstractstep.py:
487         * Scripts/webkitpy/tool/steps/applypatch.py:
488         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
489         * Scripts/webkitpy/tool/steps/build.py:
490         * Scripts/webkitpy/tool/steps/checkstyle.py:
491         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
492         * Scripts/webkitpy/tool/steps/closebug.py:
493         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
494         * Scripts/webkitpy/tool/steps/commit.py:
495         * Scripts/webkitpy/tool/steps/confirmdiff.py:
496         * Scripts/webkitpy/tool/steps/createbug.py:
497         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
498         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
499         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
500         * Scripts/webkitpy/tool/steps/postcodereview.py:
501         * Scripts/webkitpy/tool/steps/postdiff.py:
502         * Scripts/webkitpy/tool/steps/preparechangelog.py:
503         * Scripts/webkitpy/tool/steps/runtests.py:
504         * Scripts/webkitpy/tool/steps/update.py:
505         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
506         * Scripts/webkitpy/tool/steps/validatereviewer.py:
507
508 2010-04-27  Eric Seidel  <eric@webkit.org>
509
510         Reviewed by David Levin.
511
512         prepare-ChangeLog --bug fails on some CYGWIN installs due to missing certs
513         https://bugs.webkit.org/show_bug.cgi?id=38212
514
515         * Scripts/prepare-ChangeLog:
516          - Pass --insecure to curl to work around CYGWIN missing certs.
517
518 2010-04-27  Sam Weinig  <sam@webkit.org>
519
520         Rubber-stamped by Beth Dakin.
521
522         It is no longer necessary to set ENABLE_EXPERIMENTAL_SINGLE_VIEW_MODE
523         or WTF_USE_WEB_THREAD. Remove them.
524
525         * Scripts/build-webkit:
526
527 2010-04-27  Chris Jerdonek  <cjerdonek@webkit.org>
528
529         Reviewed by David Levin.
530
531         Changed Chris Jerdonek from committer to reviewer.
532
533         * Scripts/webkitpy/common/config/committers.py:
534
535 2010-04-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
536
537         Reviewed by Kenneth Rohde Christiansen.
538
539         [Qt] QGraphicsWebView: Arrow keys scroll the graphics-view instead of the web-page
540         https://bugs.webkit.org/show_bug.cgi?id=35834
541
542         The scene should always have the size of the web view otherwhise it is
543         possible to scroll the graphics view.
544
545         * QtLauncher/webview.cpp:
546         (WebViewGraphicsBased::resizeEvent):
547
548 2010-04-27  Diego Gonzalez  <diegohcg@webkit.org>
549
550         Unreviewed.
551
552         Adding myself to committers.py
553
554         * Scripts/webkitpy/common/config/committers.py:
555
556 2010-04-27  Eric Seidel  <eric@webkit.org>
557
558         Reviewed by Adam Barth.
559
560         [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
561         https://bugs.webkit.org/show_bug.cgi?id=37987
562
563         After further research, I believe the hang is caused by:
564         http://bugs.python.org/issue2320
565         Basically Popen() is not reentrant.
566         The workaround is to pass close_fds=True to Popen() on Mac/Linux.
567
568         I fixed our main Popen wrapper "Executive.run_command" to use close_fds=True
569         when appropriate.
570
571         I audited all places we call Popen() and either moved them to run_command
572         or left a FIXME that they are not thread safe.  A few places I added the
573         close_fds workaround there and left an explanitory note.
574
575         * Scripts/webkitpy/common/checkout/scm_unittest.py:
576          - Added note that this Popen use is not threadsafe.
577         * Scripts/webkitpy/common/system/executive.py:
578          - Fixed our Executive.run_* to workaround python bug 2320.
579         * Scripts/webkitpy/common/system/user.py:
580          _ Added note that this Popen use is not threadsafe.
581         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: ditto.
582         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: ditto.
583         * Scripts/webkitpy/layout_tests/port/base.py:
584          - Change wdiff back to using run_command now that we believe it
585            to be threadsafe.
586         * Scripts/webkitpy/layout_tests/port/chromium.py:
587          - Fix to use Executive in places.
588          - Pass self._executive down to the Driver for easier unit testing.
589         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
590          - Re-factor to use a _kill_all method.
591          - Made the _kill_all method use run_command to be threadsafe.
592         * Scripts/webkitpy/layout_tests/port/http_server.py:
593          - Add FIXME about using Executive.
594         * Scripts/webkitpy/layout_tests/port/server_process.py:
595          - Use Executive to be threadsafe.
596         * Scripts/webkitpy/layout_tests/port/webkit.py:
597          - Pass self._executive down to the Driver.
598         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
599          - Add note about Popen not being threadsafe.
600         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
601          - Move one caller to run_command add notes about moving others.
602
603 2010-04-27  Adam Barth  <abarth@webkit.org>
604
605         Reviewed by Maciej Stachowiak.
606
607         REGRESSION(r58261): webkit-patch upload does not work in an SVN checkout.
608         https://bugs.webkit.org/show_bug.cgi?id=38186
609
610         Unfortunately, we don't have a good way of testing this change because
611         our test coverage of the scm.py API is poor...
612
613         * Scripts/webkitpy/common/checkout/scm.py:
614         * Scripts/webkitpy/tool/steps/preparechangelog.py:
615
616 2010-04-26  Eric Seidel  <eric@webkit.org>
617
618         Reviewed by Adam Barth.
619
620         Remove unused code from text_diff.py
621         https://bugs.webkit.org/show_bug.cgi?id=38170
622
623         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
624          - Remove is_render_tree_dump which appears unused.
625
626 2010-04-26  Adam Barth  <abarth@webkit.org>
627
628         Reviewed by Eric Seidel.
629
630         webkit-patch pretty-diff is broken
631         https://bugs.webkit.org/show_bug.cgi?id=38172
632
633         We need to register for these options because they're used when we look
634         up the diff.
635
636         * Scripts/webkitpy/tool/steps/confirmdiff.py:
637
638 2010-04-26  Adam Barth  <abarth@webkit.org>
639
640         Reviewed by Eric Seidel.
641
642         Add ObjC and GObject to run-bindings-test
643         https://bugs.webkit.org/show_bug.cgi?id=38168
644
645         * Scripts/run-bindings-tests:
646
647 2010-04-26  Adam Barth  <abarth@webkit.org>
648
649         Reviewed by Eric Seidel.
650
651         Add testing infrastructure for JSC bindings generator
652         https://bugs.webkit.org/show_bug.cgi?id=38167
653
654         Add support for testing more than one bindings.  Also, converted the
655         script to PEP8 style.
656
657         * Scripts/run-bindings-tests:
658
659 2010-04-26  Eric Seidel  <eric@webkit.org>
660
661         Reviewed by Adam Barth.
662
663         Refactor results.html generation out into a new method and test it
664         https://bugs.webkit.org/show_bug.cgi?id=38164
665
666         Hopefully this results in no change in functionality.
667
668         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
669         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
670
671 2010-04-26  Adam Barth  <abarth@webkit.org>
672
673         Unreviewed, rolling out r58265.
674         http://trac.webkit.org/changeset/58265
675         https://bugs.webkit.org/show_bug.cgi?id=38021
676
677         This change prevents me from uploading patches.  It also breaks sheriff-bot.
678
679         * Scripts/webkitpy/tool/steps/options.py:
680
681 2010-04-26  Eric Seidel  <eric@webkit.org>
682
683         Reviewed by Adam Barth.
684
685         [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
686         https://bugs.webkit.org/show_bug.cgi?id=37987
687
688         Rolled out:
689         http://trac.webkit.org/changeset/58062
690         http://trac.webkit.org/changeset/58060
691         http://trac.webkit.org/changeset/58059
692         http://trac.webkit.org/changeset/58055
693         http://trac.webkit.org/changeset/58054
694         and parts of:
695         http://trac.webkit.org/changeset/58050
696
697         I also wrote some new comments and a tiny amount of new
698         code to help make ChromiumDriver.run_test easier to read.
699
700         In order to unit-test my new code, I had to change ChromiumDriver
701         to not automatically start itself when created.  That ended up
702         being a lot of plumbing, but is hopefully easier to understand now.
703
704         There are no tests for the (restored) wdiff code.  wdiff does not
705         exist on all systems, so for now we will assume it worked since
706         it is just old code being reverted.
707
708          * Scripts/webkitpy/layout_tests/driver_test.py:
709           - Use create_driver instead of start_driver, and be sure to call .stop()
710          * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
711           - Use create_driver instead of start_driver
712          * Scripts/webkitpy/layout_tests/port/base.py:
713           - Added a comment to explain that diffs are binary files.
714           - Various patch reverts relating to wdiff
715           - Add Driver._command_wrapper to share code between WebKitDriver and ChromiumDriver.
716           - Made _command_wrapper use shlex.split to get rid of the FIXME.
717          * Scripts/webkitpy/layout_tests/port/base_unittest.py: Added.
718           - test the new _command_wrapper
719          * Scripts/webkitpy/layout_tests/port/chromium.py:
720          - Use _command_wrapper to get rid of a bunch of ugly code.
721          - Make __init__ stop auto-starting.
722          - Rename create_driver to start_driver.
723          - Added _write_command_and_read_line to make it possible to
724            put a FIXME next to read_line() w/o having to put it in two places.
725          - Moved test_shell command building into _test_shell_command and tested it.
726          - Fix comments to say test_shell since ChromiumDriver is test_shell only.
727          * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Added.
728           - Test the new test_shell_command method.
729          * Scripts/webkitpy/layout_tests/port/dryrun.py:
730           - Rename create_driver to start_driver.
731          * Scripts/webkitpy/layout_tests/port/test.py:
732           - Rename create_driver to start_driver.
733          * Scripts/webkitpy/layout_tests/port/webkit.py:
734           - Rename create_driver to start_driver.
735           - Treat output as binary arrays.
736          * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
737           - Treat diff files as binary.
738          * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
739           - Treat diff files as binary.
740
741 2010-04-26  Adam Barth  <abarth@webkit.org>
742
743         Reviewed by Eric Seidel.
744
745         Move bindings test directory into the scripts directory
746         https://bugs.webkit.org/show_bug.cgi?id=38161
747
748         Change script to point to the new location of these data files.
749
750         * Scripts/run-bindings-tests:
751
752 2010-04-26  Adam Barth  <abarth@webkit.org>
753
754         Unreviewed.  Mark run-bindings-tests executable so we can execute it.
755
756         * Scripts/run-bindings-tests:
757
758 2010-04-26  Tony Chang  <tony@chromium.org>
759
760         Reviewed by David Levin.
761
762         [chromium] build-webkit --chromium should build release by default
763         https://bugs.webkit.org/show_bug.cgi?id=38028
764
765         * Scripts/build-dumprendertree: Also should build release by default
766         * Scripts/build-webkit: Make sure to pass command line args through
767         * Scripts/webkitdirs.pm: Build the right configuration
768
769 2010-04-26  Ojan Vafai  <ojan@chromium.org>
770
771         Reviewed by Eric Seidel.
772
773         complete rietveld bugzilla integration
774         https://bugs.webkit.org/show_bug.cgi?id=38021
775
776         Makes --fancy-review the default. All this means is that the patch will
777         be uploaded to rietveld in addition to bugs.webkit.org. 
778
779         * Scripts/webkitpy/tool/steps/options.py:
780
781 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
782
783         Reviewed by Shinichiro Hamaji.
784
785         For check-webkit-style, renamed the style/processors/ directory
786         to style/checkers/.
787
788         https://bugs.webkit.org/show_bug.cgi?id=38122
789
790         * Scripts/webkitpy/style/checker.py:
791           - Updated import statements.
792
793         * Scripts/webkitpy/style/checker_unittest.py:
794           - Updated import statements.
795
796         * Scripts/webkitpy/style/checkers: Copied from WebKitTools/Scripts/webkitpy/style/processors.
797         * Scripts/webkitpy/style/processors: Removed.
798         * Scripts/webkitpy/style/processors/__init__.py: Removed.
799         * Scripts/webkitpy/style/processors/common.py: Removed.
800         * Scripts/webkitpy/style/processors/common_unittest.py: Removed.
801         * Scripts/webkitpy/style/processors/cpp.py: Removed.
802         * Scripts/webkitpy/style/processors/cpp_unittest.py: Removed.
803         * Scripts/webkitpy/style/processors/python.py: Removed.
804         * Scripts/webkitpy/style/processors/python_unittest.py: Removed.
805         * Scripts/webkitpy/style/processors/python_unittest_input.py: Removed.
806         * Scripts/webkitpy/style/processors/text.py: Removed.
807         * Scripts/webkitpy/style/processors/text_unittest.py: Removed.
808
809 2010-04-06  Ojan Vafai  <ojan@chromium.org>
810
811         Reviewed by Adam Barth.
812
813         Include git commits in the diff for webkit-patch upload/land.
814         https://bugs.webkit.org/show_bug.cgi?id=36394
815
816         Adds --squash, --no-squash and --git-commit.
817
818         --git-commit will use a specific local commit for land/upload.
819         If a commit-range is specified, then that range is treated as
820         a single squashed commit.
821
822         --squash will squash all local changes including working copy changes
823         into a single patch.
824
825         --no-squash is the legacy behavior (upload only considers the working copy,
826         land commits the working copy and then each local commit separately to SVN)
827
828         If neither is specified, then an informative error is raised if there is
829         more than one local commit or when there are local commit(s) and working
830         copy changes.
831
832         If the webkit-patch.squash git config parameter is set, then
833         that will be respected instead of raising an error.
834
835         * Scripts/check-webkit-style:
836         * Scripts/webkitpy/common/checkout/api.py:
837         * Scripts/webkitpy/common/checkout/api_unittest.py:
838         * Scripts/webkitpy/common/checkout/scm.py:
839         * Scripts/webkitpy/common/checkout/scm_unittest.py:
840         * Scripts/webkitpy/style/optparser.py:
841         --git-since is removed and --git-commit no longer implies commit_id..
842         Instead, it treats that individual commit, but also supports commit ranges
843         (e.g. commit_id..) as arguments.
844         * Scripts/webkitpy/style/optparser_unittest.py:
845         * Scripts/webkitpy/style_references.py:
846         * Scripts/webkitpy/tool/commands/download.py:
847         * Scripts/webkitpy/tool/commands/upload.py:
848         * Scripts/webkitpy/tool/main.py:
849         * Scripts/webkitpy/tool/mocktool.py:
850         * Scripts/webkitpy/tool/steps/abstractstep.py:
851         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
852         * Scripts/webkitpy/tool/steps/checkstyle.py:
853         * Scripts/webkitpy/tool/steps/commit.py:
854         * Scripts/webkitpy/tool/steps/options.py:
855         * Scripts/webkitpy/tool/steps/postdiff.py:
856         * Scripts/webkitpy/tool/steps/preparechangelog.py:
857         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
858         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
859         * Scripts/webkitpy/tool/steps/validatereviewer.py:
860
861 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
862
863         Reviewed by Shinichiro Hamaji.
864
865         Deleted the StyleChecker-related classes that are no longer
866         being used.
867
868         https://bugs.webkit.org/show_bug.cgi?id=38118
869
870         * Scripts/webkitpy/style/checker.py:
871           - Deleted the DeprecatedStyleChecker class.
872
873         * Scripts/webkitpy/style/checker_unittest.py:
874           - Deleted the StyleCheckerTest, StyleCheckerCheckFileBase,
875             StyleCheckerCheckFileTest, and StyleCheckerCheckPathsTest classes.
876
877 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
878
879         Reviewed by Shinichiro Hamaji.
880
881         Changed the StyleChecker class to use the new TextFileReader class.
882
883         https://bugs.webkit.org/show_bug.cgi?id=37066
884
885         This revision separates the code responsible for reading and iterating
886         over text files from the rest of check-webkit-style.
887
888         * Scripts/check-webkit-style:
889           - Changed the script to use the new StyleProcessor and
890             TextFileReader classes instead of the StyleChecker class.
891
892         * Scripts/webkitpy/style/checker.py:
893           - Added a FIXME to rename many of uses of the word "processor" to
894             "checker".  We did this to clarify the difference between
895             ProcessorBase instances passed to the TextFileReader and
896             classes that process and check lines for style.
897           - Added a FIXME to remove FileType.NONE as a possible return value
898             of ProcessorDispatcher._file_type().  This will better consolidate
899             the logic of which files should be skipped.
900           - Added a FIXME to delete the StyleChecker class.
901           - Added the StyleProcessor class which implements ProcessorBase.
902             This class is responsible for processing lines to check style
903             (but not for reading files).  For each file, this class creates
904             creates both a carriage-return checker and a format-specific
905             style checker (e.g. one of C++, Python, etc).
906           - Updated the PatchChecker class to use a TextFileReader instance
907             instead of a StyleChecker.
908
909         * Scripts/webkitpy/style/checker_unittest.py:
910           - Added the StyleProcessor_EndToEndTest class to do "end-to-end"
911             tests of the StyleProcessor class.
912           - Added the StyleProcessor_CodeCoverageTest to test the
913             StyleProcessor class with more complete code coverage.
914             Unlike the StyleProcessor_EndToEndTest class, this class makes
915             heavy use of mock parameters.
916           - Added FIXME's to delete the unit test classes that are no
917             longer needed.
918           - Updated the PatchCheckerTest class to use a MockTextFileReader
919             instead of a MockStyleChecker.
920
921         * Scripts/webkitpy/style/filereader.py:
922           - Updated the TextFileReader class to use the preferred logic
923             of checking file existence at the beginning of the process_file()
924             method instead of in the except block, per
925             https://bugs.webkit.org/show_bug.cgi?id=37122
926
927         * Scripts/webkitpy/style/filereader_unittest.py:
928           - In the TextFileReaderTest class:
929             - Moved the test_process_file__should_not_process() method.
930             - Added a test_process_file__file_stdin() method to test
931               the file path "-".
932
933 2010-04-20  Robert Hogan  <robert@webkit.org>
934
935         Reviewed by Simon Hausmann.
936
937         [Qt] Add more support for textInputController
938
939         Add support for selectedRange(), setMarkedText(), insertText(),
940         and firstRectForCharacterRange().
941
942         Unskip tests:
943
944         fast/forms/input-maxlength-ime-preedit.html
945         fast/forms/input-maxlength-ime-completed.html
946         fast/text/international/thai-cursor-position.html
947         fast/events/ime-composition-events-001.html
948         editing/selection/5825350-1.html
949         editing/selection/5825350-2.html
950         editing/selection/mixed-editability-10.html
951
952         https://bugs.webkit.org/show_bug.cgi?id=35702
953
954         * DumpRenderTree/qt/TextInputControllerQt.cpp:
955         (TextInputController::setMarkedText):
956         (TextInputController::insertText):
957         (TextInputController::selectedRange):
958         (TextInputController::firstRectForCharacterRange):
959         * DumpRenderTree/qt/TextInputControllerQt.h:
960
961 2010-04-23  Eric Seidel  <eric@webkit.org>
962
963         Reviewed by Adam Barth.
964
965         check-webkit-style complains about non-utf8 data in layout test result
966         https://bugs.webkit.org/show_bug.cgi?id=38027
967
968         The problem was we were assuming patch files/diff output as utf-8.
969         Turns out they're not.  We have to treat them as binary data because
970         a single patch may have multiple text files in it with conflicting encodings!
971
972         * Scripts/webkitpy/common/checkout/api.py:
973          - contents_at_revision returns a byte array, so decode it to unicode
974            before passing it to parse_latest_entry_from_file
975         * Scripts/webkitpy/common/checkout/api_unittest.py:
976          - Update our mock mock_contents_at_revision to match the encoding
977            semantics of the real one.
978         * Scripts/webkitpy/common/checkout/scm.py:
979          - Be careful not to decode output which may contain file contents
980            (like diff, cat or show) as the encoding for that content is unknown.
981         * Scripts/webkitpy/common/checkout/scm_unittest.py:
982          - Update our tests to use both latin1 and utf-8 encoded data.
983         * Scripts/webkitpy/common/net/bugzilla.py:
984          - _fill_attachment_form should not assume unicode data.  Callers
985            may wish to attach other types of files to bugs.
986         * Scripts/webkitpy/common/prettypatch.py:
987          - Diffs are byte arrays, deal with them as such.
988         * Scripts/webkitpy/common/prettypatch_unittest.py:
989          - Test to make sure we handle diffs with multiple conflicting encodings.
990         * Scripts/webkitpy/common/system/executive_unittest.py:
991          - Make sure that our unicode support does not break our
992            byte array input support for run_command.
993
994 2010-04-23  Sam Weinig  <sam@webkit.org>
995
996         Reviewed by David Levin.
997
998         Fix for https://bugs.webkit.org/show_bug.cgi?id=38060
999         Split up Threading.h
1000
1001         Add necessary forwarding headers.
1002
1003         * DumpRenderTree/ForwardingHeaders/wtf/Atomics.h: Added.
1004         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
1005         * DumpRenderTree/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
1006
1007 2010-04-23  Xiaomei Ji  <xji@chromium.org>
1008
1009         No need to review.
1010
1011         Add xji as committer.
1012
1013         * Scripts/webkitpy/common/config/committers.py:
1014
1015 2010-04-23  Kevin Ollivier  <kevino@theolliviers.com>
1016
1017         [wx] Build fix, add platform stub for new LayoutTestController method.
1018
1019         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1020         (LayoutTestController::markerTextForListItem):
1021
1022 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
1023
1024         Reviewed by Adam Barth.
1025
1026         new-run-webkit-tests: add a "--retry-failures" flag and a
1027         "--no-retry-failures" flag (the former is the default). Also, rename
1028         "--print-unexpected-results" and "--retry-unexpected-results" to
1029         "--print-last-failures" and "--retry-last-failures" because the
1030         retry flag was confusing. The new flag names aren't great, but
1031         hopefully they're less confusing.
1032
1033         https://bugs.webkit.org/show_bug.cgi?id=37838
1034
1035         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1036
1037 2010-04-22  Sam Weinig  <sam@webkit.org>
1038
1039         Reviewed by Anders Carlsson.
1040
1041         Fix for https://bugs.webkit.org/show_bug.cgi?id=38022
1042         Move isMainThread predicate function to MainThread.h
1043
1044         Added forwarding header for MainThread.h
1045
1046         * DumpRenderTree/ForwardingHeaders/wtf/MainThread.h: Added.
1047
1048 2010-04-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1049
1050         Reviewed by Kenneth Rohde Christiansen.
1051
1052         [Qt] Disable Netscape plugin support for minimal configuration
1053         https://bugs.webkit.org/show_bug.cgi?id=38026
1054
1055         Pass the minimal configuration option to Qt build system 
1056         as part of the CONFIG variable.
1057
1058         * Scripts/build-webkit:
1059
1060 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1061
1062         Unreviewed fix.
1063
1064         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
1065
1066 2010-04-22  James Robinson  <jamesr@chromium.org>
1067
1068         Reviewed by Adam Barth.
1069
1070         Revert 58077 and follow-ups.  It's broken.
1071         https://bugs.webkit.org/show_bug.cgi?id=37664
1072
1073         * Scripts/new-run-webkit-httpd:
1074         * Scripts/new-run-webkit-websocketserver:
1075         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1076         * Scripts/webkitpy/layout_tests/port/http_server.py:
1077         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1078
1079 2010-04-22  Yaar Schnitman  <yaar@chromium.org>
1080
1081         Reviewed by Adam Barth.
1082
1083         Integrate v8 testing utility with webkit tests
1084         https://bugs.webkit.org/show_bug.cgi?id=37731
1085
1086         * Scripts/run-bindings-tests: Added.
1087
1088 2010-04-22  Eric Seidel  <eric@webkit.org>
1089
1090         Reviewed by Dimitri Glazkov.
1091
1092         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
1093         https://bugs.webkit.org/show_bug.cgi?id=37794
1094
1095         * Scripts/webkitpy/layout_tests/port/webkit.py:
1096          - Remove the assert() since our ServerProcess code does not always
1097            seem to be reading the full stderr output (or we're not waiting for it to).
1098
1099 2010-04-22  Eric Seidel  <eric@webkit.org>
1100
1101         Reviewed by Adam Barth.
1102
1103         Add code to help debug new-run-webkit-test hangs on the Chromium bots
1104         https://bugs.webkit.org/show_bug.cgi?id=38011
1105
1106         I can see no reasonable way to test this change.
1107         Stubbing out sys._current_frames() and traceback.extract_stack
1108         seems folly.  Dumping real data would have line number
1109         (and possibly other call stack) variance between runs.
1110
1111         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1112          - Add _dump_thread_states and _dump_thread_states_if_necessary
1113            to have our main thread dump the states of all threads every
1114            60 seconds when running in verbose mode.
1115          - Better document what is going on in our main loop.
1116
1117 2010-04-22  Sam Weinig  <sam@webkit.org>
1118
1119         Reviewed by Anders Carlsson.
1120
1121         Fix for https://bugs.webkit.org/show_bug.cgi?id=38002
1122         Add rudimentary statistics gathering for WebKit2
1123
1124         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1125         * MiniBrowser/mac/AppDelegate.h:
1126         * MiniBrowser/mac/AppDelegate.m:
1127         (-[BrowserAppDelegate init]):
1128         (-[BrowserAppDelegate newWindow:]):
1129         (-[BrowserAppDelegate getCurrentPageNamespace]):
1130         (-[BrowserAppDelegate _setProcessModel:]):
1131         (-[BrowserAppDelegate showStatisticsWindow:]):
1132         (-[BrowserAppDelegate applicationWillTerminate:]):
1133         * MiniBrowser/mac/BrowserStatisticsWindow.xib: Added.
1134         * MiniBrowser/mac/BrowserStatisticsWindowController.h: Added.
1135         * MiniBrowser/mac/BrowserStatisticsWindowController.m: Added.
1136         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
1137         (-[BrowserStatisticsWindowController dealloc]):
1138         (-[BrowserStatisticsWindowController windowDidLoad]):
1139         (-[BrowserStatisticsWindowController refreshStatistics:]):
1140         * MiniBrowser/mac/BrowserWindowController.h:
1141         * MiniBrowser/mac/English.lproj/MainMenu.xib:
1142         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1143
1144 2010-04-22  Dave Moore  <davemoore@chromium.org>
1145
1146         Reviewed by Dimitri Glazkov.
1147
1148         Add test support for icon changes.
1149
1150         https://bugs.webkit.org/show_bug.cgi?id=33812
1151
1152         * DumpRenderTree/LayoutTestController.cpp:
1153         (LayoutTestController::LayoutTestController):
1154         (dumpIconChangesCallback):
1155         (LayoutTestController::staticFunctions):
1156         * DumpRenderTree/LayoutTestController.h:
1157         (LayoutTestController::dumpIconChanges):
1158         (LayoutTestController::setDumpIconChanges):
1159         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1160         (FrameLoadDelegate::didChangeIcons):
1161         * DumpRenderTree/win/FrameLoadDelegate.h:
1162         * WinLauncher/WinLauncher.h:
1163         (WinLauncherWebHost::didChangeIcons):
1164
1165 2010-04-22  Eric Seidel  <eric@webkit.org>
1166
1167         Unreviewed.  Script fix.  Will ask dpranke to look tomorrow.
1168
1169         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
1170         https://bugs.webkit.org/show_bug.cgi?id=37794
1171
1172         The bots are seeing cases where .error is sometimes empty.
1173         Lets make the code not crash in that case for now.
1174
1175         * Scripts/webkitpy/layout_tests/port/webkit.py:
1176
1177 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1178
1179         Unreviewed fix.
1180
1181         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
1182
1183 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1184
1185         Unreviewed fix.
1186
1187         * Scripts/new-run-webkit-websocketserver: PyWebSocket no longer takes keyword argument 'register_cygwin'.
1188
1189 2010-04-22  Eric Seidel  <eric@webkit.org>
1190
1191         Unreviewed.  Restore the Leopard bots to using
1192         old-run-webkit-tests for now.
1193
1194         * Scripts/run-webkit-tests:
1195
1196 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1197
1198         Unreviewed fix.
1199
1200         * Scripts/webkitpy/layout_tests/port/http_server.py: fix NameError: global name 'env' is not defined.
1201
1202 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1203
1204         Unreviewed fix.
1205
1206         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'env' is not defined.
1207
1208 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1209
1210         Reviewed by Adam Barth.
1211
1212         Chromium: Add --chromium option to new-run-webkit-websocketserver
1213         https://bugs.webkit.org/show_bug.cgi?id=37664
1214
1215         Move cygwin setup logic in chromium_win.py.
1216
1217         * Scripts/new-run-webkit-httpd: remove register_cygwin parameter to pass http_server.
1218         * Scripts/new-run-webkit-websocketserver: add --chromium flag
1219         * Scripts/webkitpy/layout_tests/port/chromium_win.py: setup for cygwin
1220         * Scripts/webkitpy/layout_tests/port/http_server.py: remove cygwin setup logic
1221         * Scripts/webkitpy/layout_tests/port/websocket_server.py: remove cygwin setup logic
1222
1223 2010-04-22  Eric Seidel  <eric@webkit.org>
1224
1225         Reviewed by Adam Barth.
1226
1227         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
1228         https://bugs.webkit.org/show_bug.cgi?id=37794
1229
1230         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1231          - Fix the log message to explain that this is stderr output, not test output.
1232         * Scripts/webkitpy/layout_tests/port/webkit.py:
1233          - Be sure to reset the server_process.error after reading (seems like the wrong
1234            place to do this, but at least this fixes the bug and dpranke and I can talk
1235            about better designs later).
1236          - Also remove the #EOF from the stderr output before returning it.
1237
1238 2010-04-22  Eric Seidel  <eric@webkit.org>
1239
1240         Unreviewed.  Fixing new-run-webkit-tests on the bots.
1241
1242         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1243          - Fixing _compat_shim_option to take variable keyword args.
1244          - Turns out that nargs + callback is ignored unless type is specified.
1245            So I added the type so that the option was properly consumed.
1246            This was why new-run-webkit-tests couldn't find any tests, it
1247            was looking for them under "20" because that was the argument
1248            which should have been consumed by --exit-after-n-failures.
1249
1250 2010-04-22  Tony Chang  <tony@chromium.org>
1251
1252         Not reviewed, build fix for chromium Windows.
1253
1254         [chromium] fix ImageDiff compile on windows
1255         https://bugs.webkit.org/show_bug.cgi?id=37979
1256
1257         * DumpRenderTree/chromium/ImageDiff.cpp:
1258
1259 2010-04-22  Adam Barth  <abarth@webkit.org>
1260
1261         Unreviewed, rolling out r58069.
1262         http://trac.webkit.org/changeset/58069
1263         https://bugs.webkit.org/show_bug.cgi?id=27751
1264
1265         Broke compile on Windows.
1266
1267         * DumpRenderTree/LayoutTestController.cpp:
1268         (LayoutTestController::staticFunctions):
1269         * DumpRenderTree/LayoutTestController.h:
1270         * DumpRenderTree/chromium/LayoutTestController.cpp:
1271         (LayoutTestController::LayoutTestController):
1272         (LayoutTestController::overridePreference):
1273         * DumpRenderTree/chromium/LayoutTestController.h:
1274         * DumpRenderTree/chromium/TestShell.cpp:
1275         (TestShell::resetWebSettings):
1276         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1277         * DumpRenderTree/mac/DumpRenderTree.mm:
1278         (resetDefaultsToConsistentValues):
1279         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1280         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1281         (WebCore::WebPage::WebPage):
1282         (WebCore::WebPage::resetSettings):
1283         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1284         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1285         * DumpRenderTree/win/DumpRenderTree.cpp:
1286         (resetDefaultsToConsistentValues):
1287         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1288         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1289
1290 2010-04-22  Eric Seidel  <eric@webkit.org>
1291
1292         Unreviewed.  Just adding logging.
1293
1294         Adding logging to help debug why the Leopard Bot
1295         can't find any tests to run.
1296
1297         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
1298         * Scripts/webkitpy/layout_tests/port/base.py:
1299         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1300          - Make it a fatal error to have no tests to run.
1301
1302 2010-04-22  Abhishek Arya  <inferno@chromium.org>
1303
1304         Reviewed by Adam Barth.
1305
1306         Add support for controlling clipboard access from javascript.
1307         Clipboard access from javascript is enabled in test framework.
1308         https://bugs.webkit.org/show_bug.cgi?id=27751
1309
1310         * DumpRenderTree/LayoutTestController.cpp:
1311         (setJavaScriptCanAccessClipboardCallback):
1312         (LayoutTestController::staticFunctions):
1313         * DumpRenderTree/LayoutTestController.h:
1314         * DumpRenderTree/chromium/LayoutTestController.cpp:
1315         (LayoutTestController::LayoutTestController):
1316         (LayoutTestController::setJavaScriptCanAccessClipboard):
1317         (LayoutTestController::overridePreference):
1318         * DumpRenderTree/chromium/LayoutTestController.h:
1319         * DumpRenderTree/chromium/TestShell.cpp:
1320         (TestShell::resetWebSettings):
1321         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1322         (LayoutTestController::setJavaScriptCanAccessClipboard):
1323         * DumpRenderTree/mac/DumpRenderTree.mm:
1324         (resetDefaultsToConsistentValues):
1325         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1326         (LayoutTestController::setJavaScriptCanAccessClipboard):
1327         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1328         (WebCore::WebPage::WebPage):
1329         (WebCore::WebPage::resetSettings):
1330         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1331         (LayoutTestController::setJavaScriptCanAccessClipboard):
1332         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1333         * DumpRenderTree/win/DumpRenderTree.cpp:
1334         (resetDefaultsToConsistentValues):
1335         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1336         (LayoutTestController::setJavaScriptCanAccessClipboard):
1337         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1338         (LayoutTestController::setJavaScriptCanAccessClipboard):
1339
1340 2010-04-21  Adam Barth  <abarth@webkit.org>
1341
1342         Reviewed by Eric Seidel.
1343
1344         webkit-patch can't fetch attachments on security bugs
1345         https://bugs.webkit.org/show_bug.cgi?id=37975
1346
1347         Instead of calling CURL, we just need to use our Mechanize object,
1348         which understand bugs.webkit.org authentication.
1349
1350         * Scripts/webkitpy/common/checkout/api.py:
1351         * Scripts/webkitpy/common/net/bugzilla.py:
1352
1353 2010-04-21  Eric Seidel  <eric@webkit.org>
1354
1355         Unreviewed.  Temporary commit, will roll-out before morning.
1356
1357         Turning on new-run-webkit-tests for the Leopard build bot
1358         for testing of the harness.
1359         Users should not noctice (except for the results.html difference).
1360
1361         * Scripts/run-webkit-tests:
1362
1363 2010-04-21  Eric Seidel  <eric@webkit.org>
1364
1365         Unreviewed.  Fix typo in my previous fix attempt.
1366
1367         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1368         https://bugs.webkit.org/show_bug.cgi?id=37765
1369
1370         More on-the-bot debugging, sigh.  I wish I had a local build.
1371
1372         * Scripts/webkitpy/layout_tests/port/base.py:
1373
1374 2010-04-21  Eric Seidel  <eric@webkit.org>
1375
1376         Unreviewed.  Fix typo in my previous fix attempt.
1377
1378         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1379         https://bugs.webkit.org/show_bug.cgi?id=37765
1380
1381         * Scripts/webkitpy/layout_tests/port/base.py:
1382          - Add self. to class variable access.
1383
1384 2010-04-21  Eric Seidel  <eric@webkit.org>
1385
1386         Unreviewed.  Another attempt to fix NRWT for chromium.
1387
1388         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1389         https://bugs.webkit.org/show_bug.cgi?id=37765
1390
1391         * Scripts/webkitpy/layout_tests/port/base.py:
1392          - wdiff_text was returning a byte array instead of a
1393            unicode string.  The simple fix was to just decode
1394            the result.  However, seeing so much duplicated code
1395            with Executive made me cry, so I re-wrote the function
1396            to be more like pretty_patch_text and use run_command
1397            (which already knows how to handle unicode).
1398
1399 2010-04-21  Adam Barth  <abarth@webkit.org>
1400
1401         Reviewed by Eric Seidel.
1402
1403         Windows tests buildbots are too slow to be core builders
1404         https://bugs.webkit.org/show_bug.cgi?id=37970
1405
1406         It's 10:45.  The Windows test bots are still hours behind.  They're too
1407         slow to be core builders.  When they get fast, we can add them back.
1408
1409         * Scripts/webkitpy/common/net/buildbot.py:
1410         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1411
1412 2010-04-21  Eric Seidel  <eric@webkit.org>
1413
1414         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1415
1416         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1417         https://bugs.webkit.org/show_bug.cgi?id=37765
1418
1419         I'm debugging in the blind because I don't have a chromium
1420         build on this laptop.
1421
1422         * Scripts/webkitpy/layout_tests/port/chromium.py:
1423          - Apply the previous fix to a second caller.
1424
1425 2010-04-21  Eric Seidel  <eric@webkit.org>
1426
1427         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1428
1429         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1430         https://bugs.webkit.org/show_bug.cgi?id=37765
1431
1432         * Scripts/webkitpy/layout_tests/port/chromium.py:
1433          - Fix handling of test_shell output so that we always
1434            decode it as utf-8.
1435            Unlike DumpRenderTree test_shell does not ever return
1436            pixel data.  It spits out the pixel dumps in a separate
1437            file, thus all output over stdout is utf-8 text.
1438
1439 2010-04-21  Eric Seidel  <eric@webkit.org>
1440
1441         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1442
1443         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1444         https://bugs.webkit.org/show_bug.cgi?id=37765
1445
1446         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1447          - Pass encoding to _save_baseline_data and write_output_files
1448         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1449          - Make _save_baseline_data and write_output_files take an encoding.
1450         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1451         - Pass encoding to _save_baseline_data and write_output_files
1452
1453 2010-04-21  No'am Rosenthal  <noam.rosenthal@nokia.com>
1454
1455         Reviewed by Kenneth Rohde Christiansen.
1456
1457         [Qt] QtLauncher: make FPS measurement accurate
1458         https://bugs.webkit.org/show_bug.cgi?id=37934
1459
1460         Instead of counting paints, which are not interchangeable with frames that
1461         the user sees, we now set an arbitrary timer for FPS measurements. The idea is
1462         that if the main thread is delayed for any reason, that timer would be delayed
1463         as well.
1464
1465         * QtLauncher/QtLauncher.pro:
1466         * QtLauncher/fpstimer.cpp: Added.
1467         (FpsTimer::FpsTimer):
1468         (FpsTimer::numFrames):
1469         (FpsTimer::start):
1470         (FpsTimer::stop):
1471         (FpsTimer::timerEvent):
1472         * QtLauncher/fpstimer.h: Added.
1473         * QtLauncher/webview.cpp:
1474         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
1475         (WebViewGraphicsBased::updateFrameRate):
1476         (WebViewGraphicsBased::paintEvent):
1477         * QtLauncher/webview.h:
1478
1479 2010-04-21  Eric Seidel  <eric@webkit.org>
1480
1481         Unreviewed, just adding missing ":" in python file.
1482
1483         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1484         https://bugs.webkit.org/show_bug.cgi?id=37765
1485
1486         new-run-webkit-tests --chromium was borked.
1487
1488         * Scripts/webkitpy/layout_tests/port/chromium.py:
1489
1490 2010-04-21  Eric Seidel  <eric@webkit.org>
1491
1492         Reviewed by Adam Barth.
1493
1494         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1495         https://bugs.webkit.org/show_bug.cgi?id=37765
1496
1497         Third time is the charm.  I've fixed all the
1498         new-run-webkit-tests regressions from previous attempts.
1499
1500         I fixed the queue to not ignore Tor as a reviwer in r57531,
1501         but instead it throws an exception every time his name is in a patch.
1502
1503         This fixes our Executive.run_command code to work around a Popen
1504         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
1505         do not correctly handle unicode objects as input or output to
1506         Popen.communicate.
1507
1508         Following the advice of:
1509         http://farmdev.com/talks/unicode/
1510         I have changed all of webkitpy to use unicode() objects as strings
1511         instead of str objects (which in Python 3 are renamed "bytes").
1512
1513         String literals were left as "foo" instead of converting to u"foo"
1514         as u"foo" is only required if the string has a non-ascii code point.
1515         Python is smart about comparing str() and unicode() values and will
1516         log an error to the console if the comparison is ever invalid.
1517
1518         Executive.run* now correctly accept and return unicode() objects.
1519         I attempted to fix all the places that we call .write() to make sure we
1520         encode any unicode() objects into utf-8.
1521
1522         I removed several uses of StringIO.  StringIO should generally always be
1523         passed a unicode() value.
1524
1525         Likewise I replaced most calls to open() with codecs.open().
1526         codecs.open() matches Python 3 open semantics in requiring an encoding
1527         parameter.  Files opened with codecs.open() with a unicode-compatible
1528         encoding will vend unicode() objects from their read() calls, like how
1529         StringIO created with a unicode() object will do.
1530
1531         I also deployed "with" statements wider (now that the project has
1532         settled on Python 2.5) to close a bunch of file descriptor leaks.
1533
1534         * Scripts/webkitpy/common/checkout/api_unittest.py:
1535          - Read/write utf-8 files instead of ascii.
1536          - Update the tests to use test for proper unicode() handling.
1537         * Scripts/webkitpy/common/checkout/changelog.py:
1538          - Document that parse_latest_entry_from_file expects
1539            file-like objects which return unicode strings.
1540         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1541          - Use unicode() strings instead of str() byte arrays.
1542          - Deploy "with" to close file descriptor leaks.
1543         * Scripts/webkitpy/common/checkout/commitinfo.py:
1544          - Remove unneeded import.
1545         * Scripts/webkitpy/common/checkout/scm.py:
1546          - Remove use of str().
1547         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1548          - Read/write utf-8 files and use unicode() strings in testing.
1549         * Scripts/webkitpy/common/config/committers.py:
1550          - Use \u instead of \x to make slightly clearer what we're doing.
1551         * Scripts/webkitpy/common/net/bugzilla.py:
1552          - Add a new _string_contents() method and explain why
1553             we have to call unicode() on the result of soup.string
1554             and why it's safe to do so w/o needing to pass a codec name.
1555           - Remove the (unused) support for passing a file object to add_patch_to_bug().
1556         * Scripts/webkitpy/common/net/buildbot.py:
1557          - Use unicode() instead of str() when needing to coax a
1558             NavigableString object into a unicode() object.
1559         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1560          - Add a test which contains a unicode builder name.
1561         * Scripts/webkitpy/common/net/statusserver.py:
1562          - Remove use of str()
1563         * Scripts/webkitpy/common/prettypatch.py:
1564          - Write out the patch file as utf-8.
1565         * Scripts/webkitpy/common/system/autoinstall.py:
1566          - Write out files with a explicit encodings.
1567          - Deploy "with" to close file descriptor leaks.
1568         * Scripts/webkitpy/common/system/deprecated_logging.py:
1569          - Write out log files as utf-8.
1570         * Scripts/webkitpy/common/system/executive.py:
1571          - Make run* properly take and return unicode() objects.
1572          - Cleaned up input handling in run_command a little by adding
1573            a _compute_input() method which can return early instead of having
1574            such a long/cluttered if-block.
1575         * Scripts/webkitpy/common/system/executive_unittest.py:
1576          - Added a unit test to make sure we don't break Tor again!
1577         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1578          - Write out the test list as utf-8.
1579         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1580          - Write out json files as utf-8.
1581         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1582          - Deploy "with" to close file descriptor leaks.
1583         * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
1584         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
1585         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
1586         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
1587         * Scripts/webkitpy/layout_tests/port/mac.py: ditto.
1588         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1589          - Make the skipped file parsing test unicode.
1590         * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
1591         * Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
1592         * Scripts/webkitpy/layout_tests/port/webkit.py:
1593          - Deploy "with" to close file descriptor leaks.
1594         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1595          - Make explicit the encodings of log files and pid files.
1596         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1597          - Make encodings explicit and deploy "with".
1598         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
1599         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
1600         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
1601         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
1602         * Scripts/webkitpy/style/filereader_unittest.py: ditto.
1603         * Scripts/webkitpy/thirdparty/__init__.py: ditto.
1604         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1605          - Removed extra import.
1606         * Scripts/webkitpy/tool/commands/queues.py:
1607          - No need to map args to strings now that run_command does.
1608          - Update test results to match args changes.
1609          - Document our global argument hacks.
1610         * Scripts/webkitpy/tool/commands/upload.py:
1611          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1612         * Scripts/webkitpy/tool/mocktool.py:
1613          - Rename add_patch_to_bug argument to match bugzilla.py
1614         * Scripts/webkitpy/tool/steps/abstractstep.py:
1615          - Executive.run_* now require lists instead of strings.
1616            The lack of this change was what broke webkit-patch
1617            for svn users the first time this was landed.
1618         * Scripts/webkitpy/tool/steps/postdiff.py:
1619          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1620         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
1621         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
1622         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1623          - Fixed spurious logging seen when running test-webkitpy
1624
1625 2010-04-21  Chris Fleizach  <cfleizach@apple.com>
1626
1627         Reviewed by Alexey Proskuryakov.
1628
1629         aria-liveregion-notifications.html fails on leopard release bot
1630         https://bugs.webkit.org/show_bug.cgi?id=37112
1631
1632         Change the way that notifications are listened for by forcing clients
1633         to call a remove listener as well to match the add listener. DRT will
1634         assert if those are not done in the correct order. 
1635
1636         * DumpRenderTree/AccessibilityUIElement.cpp:
1637         (removeNotificationListenerCallback):
1638         (AccessibilityUIElement::getJSClass):
1639         * DumpRenderTree/AccessibilityUIElement.h:
1640         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1641         (AccessibilityUIElement::removeNotificationListener):
1642         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1643         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
1644         (-[AccessibilityNotificationHandler dealloc]):
1645         (-[AccessibilityNotificationHandler _notificationReceived:]):
1646         (-[AccessibilityNotificationHandler setCallback:]):
1647         (AccessibilityUIElement::AccessibilityUIElement):
1648         (AccessibilityUIElement::~AccessibilityUIElement):
1649         (AccessibilityUIElement::addNotificationListener):
1650         (AccessibilityUIElement::removeNotificationListener):
1651         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1652         (AccessibilityUIElement::removeNotificationListener):
1653
1654 2010-04-21  Anders Carlsson  <andersca@apple.com>
1655
1656         Reviewed by Sam Weinig.
1657
1658         Add debug menu items to show/hide the Web View.
1659         https://bugs.webkit.org/show_bug.cgi?id=37958
1660
1661         * MiniBrowser/mac/BrowserWindowController.h:
1662         * MiniBrowser/mac/BrowserWindowController.m:
1663         (-[BrowserWindowController showHideWebView:]):
1664         (-[BrowserWindowController removeReinsertWebView:]):
1665         (-[BrowserWindowController validateMenuItem:]):
1666         * MiniBrowser/mac/English.lproj/MainMenu.xib:
1667
1668 2010-04-21  Eric Seidel  <eric@webkit.org>
1669
1670         Unreviewed.  Rolling out unicode() changes as they broke NRWT for chromium.
1671         Rolling out:
1672         http://trac.webkit.org/changeset/58014
1673         http://trac.webkit.org/changeset/58016
1674         http://trac.webkit.org/changeset/58020
1675
1676         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbo
1677         https://bugs.webkit.org/show_bug.cgi?id=37765
1678
1679         * Scripts/webkitpy/common/checkout/api_unittest.py:
1680         * Scripts/webkitpy/common/checkout/changelog.py:
1681         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1682         * Scripts/webkitpy/common/checkout/commitinfo.py:
1683         * Scripts/webkitpy/common/checkout/scm.py:
1684         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1685         * Scripts/webkitpy/common/config/committers.py:
1686         * Scripts/webkitpy/common/net/bugzilla.py:
1687         * Scripts/webkitpy/common/net/buildbot.py:
1688         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1689         * Scripts/webkitpy/common/net/statusserver.py:
1690         * Scripts/webkitpy/common/prettypatch.py:
1691         * Scripts/webkitpy/common/system/autoinstall.py:
1692         * Scripts/webkitpy/common/system/deprecated_logging.py:
1693         * Scripts/webkitpy/common/system/executive.py:
1694         * Scripts/webkitpy/common/system/executive_unittest.py:
1695         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1696         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1697         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1698         * Scripts/webkitpy/layout_tests/port/chromium.py:
1699         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1700         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1701         * Scripts/webkitpy/layout_tests/port/gtk.py:
1702         * Scripts/webkitpy/layout_tests/port/mac.py:
1703         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1704         * Scripts/webkitpy/layout_tests/port/qt.py:
1705         * Scripts/webkitpy/layout_tests/port/server_process.py:
1706         * Scripts/webkitpy/layout_tests/port/webkit.py:
1707         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1708         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1709         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1710         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1711         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1712         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1713         * Scripts/webkitpy/style/filereader_unittest.py:
1714         * Scripts/webkitpy/thirdparty/__init__.py:
1715         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1716         * Scripts/webkitpy/tool/commands/queues.py:
1717         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1718         * Scripts/webkitpy/tool/commands/upload.py:
1719         * Scripts/webkitpy/tool/mocktool.py:
1720         * Scripts/webkitpy/tool/steps/abstractstep.py:
1721         * Scripts/webkitpy/tool/steps/postdiff.py:
1722         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
1723         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1724         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1725
1726 2010-04-21  Eric Seidel  <eric@webkit.org>
1727
1728         Unreviewed, fixing NRWT for real this time.
1729
1730         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1731         https://bugs.webkit.org/show_bug.cgi?id=37765
1732
1733         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1734          - Add a hack to fix new-run-webkit-tests
1735            my understanding of codecs.open(encoding=None)
1736            must have been wrong.
1737
1738 2010-04-21  Eric Seidel  <eric@webkit.org>
1739
1740         Unreviewed, just fixing exception seen on builders.
1741
1742         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1743         https://bugs.webkit.org/show_bug.cgi?id=37765
1744
1745         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1746          - Pass and encoding to _write_into_file_at_path
1747
1748 2010-04-21  Eric Seidel  <eric@webkit.org>
1749
1750         Reviewed by Adam Barth.
1751
1752         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1753         https://bugs.webkit.org/show_bug.cgi?id=37765
1754
1755         I fixed the queue to not ignore Tor as a reviwer in r57531,
1756         but instead it throws an exception every time his name is in a patch.
1757
1758         This fixes our Executive.run_command code to work around a Popen
1759         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
1760         do not correctly handle unicode objects as input or output to
1761         Popen.communicate.
1762
1763         Following the advice of:
1764         http://farmdev.com/talks/unicode/
1765         I have changed all of webkitpy to use unicode() objects as strings
1766         instead of str objects (which in Python 3 are renamed "bytes").
1767
1768         String literals were left as "foo" instead of converting to u"foo"
1769         as u"foo" is only required if the string has a non-ascii code point.
1770         Python is smart about comparing str() and unicode() values and will
1771         log an error to the console if the comparison is ever invalid.
1772
1773         Executive.run* now correctly accept and return unicode() objects.
1774         I attempted to fix all the places that we call .write() to make sure we
1775         encode any unicode() objects into utf-8.
1776
1777         I removed several uses of StringIO.  StringIO should generally always be
1778         passed a unicode() value.
1779
1780         Likewise I replaced most calls to open() with codecs.open().
1781         codecs.open() matches Python 3 open semantics in requiring an encoding
1782         parameter.  Files opened with codecs.open() with a unicode-compatible
1783         encoding will vend unicode() objects from their read() calls, like how
1784         StringIO created with a unicode() object will do.
1785
1786         I also deployed "with" statements wider (now that the project has
1787         settled on Python 2.5) to close a bunch of file descriptor leaks.
1788
1789         * Scripts/webkitpy/common/checkout/api_unittest.py:
1790          - Read/write utf-8 files instead of ascii.
1791          - Update the tests to use test for proper unicode() handling.
1792         * Scripts/webkitpy/common/checkout/changelog.py:
1793          - Document that parse_latest_entry_from_file expects
1794            file-like objects which return unicode strings.
1795         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1796          - Use unicode() strings instead of str() byte arrays.
1797          - Deploy "with" to close file descriptor leaks.
1798         * Scripts/webkitpy/common/checkout/commitinfo.py:
1799          - Remove unneeded import.
1800         * Scripts/webkitpy/common/checkout/scm.py:
1801          - Remove use of str().
1802         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1803          - Read/write utf-8 files and use unicode() strings in testing.
1804         * Scripts/webkitpy/common/config/committers.py:
1805          - Use \u instead of \x to make slightly clearer what we're doing.
1806         * Scripts/webkitpy/common/net/bugzilla.py:
1807          - Add a new _string_contents() method and explain why
1808             we have to call unicode() on the result of soup.string
1809             and why it's safe to do so w/o needing to pass a codec name.
1810           - Remove the (unused) support for passing a file object to add_patch_to_bug().
1811         * Scripts/webkitpy/common/net/buildbot.py:
1812          - Use unicode() instead of str() when needing to coax a
1813             NavigableString object into a unicode() object.
1814         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1815          - Add a test which contains a unicode builder name.
1816         * Scripts/webkitpy/common/net/statusserver.py:
1817          - Remove use of str()
1818         * Scripts/webkitpy/common/prettypatch.py:
1819          - Write out the patch file as utf-8.
1820         * Scripts/webkitpy/common/system/autoinstall.py:
1821          - Write out files with a explicit encodings.
1822          - Deploy "with" to close file descriptor leaks.
1823         * Scripts/webkitpy/common/system/deprecated_logging.py:
1824          - Write out log files as utf-8.
1825         * Scripts/webkitpy/common/system/executive.py:
1826          - Make run* properly take and return unicode() objects.
1827          - Cleaned up input handling in run_command a little by adding
1828            a _compute_input() method which can return early instead of having
1829            such a long/cluttered if-block.
1830         * Scripts/webkitpy/common/system/executive_unittest.py:
1831          - Added a unit test to make sure we don't break Tor again!
1832         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1833          - Write out the test list as utf-8.
1834         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1835          - Write out json files as utf-8.
1836         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1837          - Deploy "with" to close file descriptor leaks.
1838         * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
1839         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
1840         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
1841         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
1842         * Scripts/webkitpy/layout_tests/port/mac.py: ditto.
1843         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1844          - Make the skipped file parsing test unicode.
1845         * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
1846         * Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
1847         * Scripts/webkitpy/layout_tests/port/webkit.py:
1848          - Deploy "with" to close file descriptor leaks.
1849         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1850          - Make explicit the encodings of log files and pid files.
1851         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1852          - Make encodings explicit and deploy "with".
1853         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
1854         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
1855         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
1856         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
1857         * Scripts/webkitpy/style/filereader_unittest.py: ditto.
1858         * Scripts/webkitpy/thirdparty/__init__.py: ditto.
1859         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1860          - Removed extra import.
1861         * Scripts/webkitpy/tool/commands/queues.py:
1862          - No need to map args to strings now that run_command does.
1863          - Update test results to match args changes.
1864          - Document our global argument hacks.
1865         * Scripts/webkitpy/tool/commands/upload.py:
1866          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1867         * Scripts/webkitpy/tool/mocktool.py:
1868          - Rename add_patch_to_bug argument to match bugzilla.py
1869         * Scripts/webkitpy/tool/steps/abstractstep.py:
1870          - Executive.run_* now require lists instead of strings.
1871            The lack of this change was what broke webkit-patch
1872            for svn users the first time this was landed.
1873         * Scripts/webkitpy/tool/steps/postdiff.py:
1874          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1875         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
1876         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
1877         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1878          - Fixed spurious logging seen when running test-webkitpy
1879
1880 2010-04-21  Kinuko Yasuda  <kinuko@chromium.org>
1881
1882         Unreviewed.
1883
1884         Add myself in committers.py.
1885
1886         * Scripts/webkitpy/common/config/committers.py:
1887
1888 2010-04-21  Dirk Pranke  <dpranke@chromium.org>
1889
1890         Reviewed by Dimitri Glazkov.
1891
1892         new-run-webkit-tests: fix a bug in the Chromium port where we would
1893         try to talk to a crashed test_shell and raise exceptions that weren't
1894         being caught.
1895
1896         https://bugs.webkit.org/show_bug.cgi?id=37941
1897
1898         * Scripts/webkitpy/layout_tests/port/chromium.py:
1899
1900 2010-04-21  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1901
1902         Unreviewed.
1903
1904         [Qt] [Symbian] Build fix.
1905
1906         Work around a Qt quirk. Some versions of Symbian port Qt
1907         QFontDatabase::removeAllApplicationFonts symbol is not available.
1908
1909         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1910         (WebCore::DumpRenderTree::open):
1911
1912 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
1913
1914         Unreviewed.
1915
1916         https://bugs.webkit.org/show_bug.cgi?id=37933
1917         <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
1918
1919         Adding stub implementation of authenticateSession(). Depending on platform loader behavior,
1920         a real implementation may or may not be necessary for the one test that currently uses it
1921         to pass.
1922
1923         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1924         (LayoutTestController::authenticateSession):
1925         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1926
1927 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
1928
1929         Reviewed by Brady Eidson.
1930
1931         https://bugs.webkit.org/show_bug.cgi?id=37933
1932         <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
1933
1934         Adding authenticateSession() method that adds credentials to per-process credential storage
1935         (for platforms that even have such). No Windows implementation, because writing another
1936         loader for DRT is painful.
1937
1938         * DumpRenderTree/LayoutTestController.cpp:
1939         (authenticateSessionCallback):
1940         (LayoutTestController::staticFunctions):
1941         * DumpRenderTree/LayoutTestController.h:
1942         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1943         (-[SynchronousLoader dealloc]):
1944         (-[SynchronousLoader connectionShouldUseCredentialStorage:]):
1945         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
1946         (-[SynchronousLoader connection:didFailWithError:]):
1947         (-[SynchronousLoader connectionDidFinishLoading:]):
1948         (+[SynchronousLoader makeRequest:withUsername:password:]):
1949         (LayoutTestController::authenticateSession):
1950
1951         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1952         (LayoutTestController::authenticateSession):
1953         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1954         (LayoutTestController::authenticateSession):
1955         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1956         (LayoutTestController::authenticateSession):
1957         Stub implementations.
1958
1959 2010-04-21  Kent Tamura  <tkent@chromium.org>
1960
1961         Reviewed by Dimitri Glazkov.
1962
1963         [DRT/Chromium] Make DRT compilable in Chromium tree
1964         https://bugs.webkit.org/show_bug.cgi?id=37923
1965
1966         We need to use different GYPs in a case of WebKit-only checkout
1967         and a case of whole Chromium checkout because the relative paths
1968         from webkit/ to WebKit/chromium/features.gypi are different in
1969         these cases and we can't use 'conditions' for 'includes' in GYPs.
1970
1971         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1972
1973 2010-04-21  Jakub Wieczorek  <jwieczorek@webkit.org>
1974
1975         Reviewed by Darin Adler.
1976
1977         List item markers are not always updated after changes in the DOM.
1978         https://bugs.webkit.org/show_bug.cgi?id=37060
1979
1980         * DumpRenderTree/LayoutTestController.cpp:
1981         (markerTextForListItemCallback): A function that returns the marker text for a given list item.
1982         (LayoutTestController::staticFunctions):
1983         * DumpRenderTree/LayoutTestController.h:
1984         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1985         (LayoutTestController::markerTextForListItem): Implement it in the GTK port.
1986         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1987         (LayoutTestController::markerTextForListItem): Add a stub.
1988         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1989         (LayoutTestController::LayoutTestController):
1990         (LayoutTestController::markerTextForListItem): Implement it in the Qt port.
1991         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1992         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1993         (LayoutTestController::markerTextForListItem): Add a stub.
1994
1995 2010-04-21  Adam Roben  <aroben@apple.com>
1996
1997         Exclude leaks in CGGradientCreateWithColorComponents from
1998         run-webkit-tests leaks output
1999
2000         The leak in CG is covered by <rdar://problem/7888492>.
2001
2002         Fixes <http://webkit.org/b/37927>.
2003
2004         Reviewed by Eric Carlson.
2005
2006         * Scripts/old-run-webkit-tests:
2007         (sub countAndPrintLeaks): Exclude leaks in
2008         CGGradientCreateWithColorComponents on certain OSs.
2009
2010 2010-04-21  Kent Tamura  <tkent@chromium.org>
2011
2012         Reviewed by Shinichiro Hamaji.
2013
2014         [DRT/Chromium] Import MockSpellCheck from Chromium
2015         https://bugs.webkit.org/show_bug.cgi?id=37910
2016
2017         Import webkit/tools/test_shell/mock_spellcheck.{cc,h} rev.37241 of Chromium.
2018
2019         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2020           Add ICU explicitly because WTFString.h includes ICU headers.
2021           Add MockSpellCheck.{cpp,h}.
2022         * DumpRenderTree/chromium/MockSpellCheck.cpp: Added.
2023         * DumpRenderTree/chromium/MockSpellCheck.h: Added.
2024         * DumpRenderTree/chromium/WebViewHost.cpp:
2025         (WebViewHost::spellCheck):
2026         * DumpRenderTree/chromium/WebViewHost.h:
2027         * DumpRenderTree/chromium/config.h: Define JS_EXPORTDATA, which is used
2028           by wtf/text/AtomicString.h included by wtf/text/WTFString.h.
2029
2030 2010-04-21  Adam Barth  <abarth@webkit.org>
2031
2032         Reviewed by Eric Seidel.
2033
2034         Add webkit-patch pretty-diff
2035         https://bugs.webkit.org/show_bug.cgi?id=37892
2036
2037         This is slightly lame because it asks you whether the diff is correct,
2038         but it's a starting point.
2039
2040         * Scripts/webkitpy/tool/commands/__init__.py:
2041         * Scripts/webkitpy/tool/commands/prettydiff.py: Added.
2042         * Scripts/webkitpy/tool/main.py:
2043
2044 2010-04-21  Adam Barth  <abarth@webkit.org>
2045
2046         Reviewed by Darin Adler.
2047
2048         Remove mention of non-existant --no-build option
2049         https://bugs.webkit.org/show_bug.cgi?id=37893
2050
2051         The option doesn't exist!
2052
2053         * Scripts/webkitpy/tool/commands/stepsequence.py:
2054
2055 2010-04-21  Balazs Kelemen  <kb@inf.u-szeged.hu>
2056
2057         Reviewed by Kenneth Rohde Christiansen.
2058
2059         [Qt] Interrupting JavaScript is cumbersome when you use QtLaucher for testing or profiling.
2060         https://bugs.webkit.org/show_bug.cgi?id=37198
2061
2062         * QtLauncher/main.cpp:
2063         (LauncherWindow::toggleInterruptingJavaScriptEnabled):
2064         (LauncherWindow::newWindow):
2065         (LauncherWindow::cloneWindow):
2066         (LauncherWindow::createChrome):
2067         (main):
2068         * QtLauncher/webpage.cpp:
2069         (WebPage::WebPage):
2070         (WebPage::shouldInterruptJavaScript):
2071         * QtLauncher/webpage.h:
2072         (WebPage::setInterruptingJavaScriptEnabled):
2073
2074 2010-04-21  Eric Seidel  <eric@webkit.org>
2075
2076         Unreviewed, rolling out r57963.
2077         http://trac.webkit.org/changeset/57963
2078         https://bugs.webkit.org/show_bug.cgi?id=37759
2079
2080         Three tests started crashing on the Qt bot.
2081
2082         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2083         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2084
2085 2010-04-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2086
2087         Reviewed by Eric Seidel.
2088
2089         Make new-run-webkit-tests work for the Qt port
2090         https://bugs.webkit.org/show_bug.cgi?id=37588
2091
2092         * Scripts/webkitpy/layout_tests/port/qt.py:
2093
2094 2010-04-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2095
2096         Reviewed by Eric Seidel.
2097
2098         new-run-webkit-tests: try to detect alternate apache path
2099         https://bugs.webkit.org/show_bug.cgi?id=37587
2100
2101         _check_port_build() also needs to return true in the
2102         base implementation to not fail the check_build step.
2103
2104         * Scripts/webkitpy/layout_tests/port/webkit.py:
2105
2106 2010-04-21  Yi Shen  <yi.4.shen@nokia.com>
2107
2108         Reviewed by Simon Hausmann.
2109
2110         [Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
2111         https://bugs.webkit.org/show_bug.cgi?id=37759
2112
2113         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2114         (LayoutTestController::computedStyleIncludingVisitedInfo):
2115         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2116
2117 2010-04-21  Eric Seidel  <eric@webkit.org>
2118
2119         Unreviewed, test fix only.
2120
2121         new-run-webkit-tests: implement a --log trace message to be able to display detailed output of an individual test run
2122         https://bugs.webkit.org/show_bug.cgi?id=37726
2123
2124         This change seems to have broken a test.
2125         Attempting to handle the case where we don't have any
2126         timing information.  Dirk may have to correct this change.
2127
2128         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2129
2130 2010-04-19  Eric Seidel  <eric@webkit.org>
2131
2132         Reviewed by Adam Barth.
2133
2134         new-run-webkit-tests has much higher startup latency than run-webkit-tests
2135         https://bugs.webkit.org/show_bug.cgi?id=37643
2136
2137         I got rid of the -expected.checksum reads during startup.
2138         This makes startup noticably better on my laptop.
2139
2140         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2141          - Use image_hash() instead of .image_hash now that expected.checksum
2142            file reads are done lazily.
2143         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2144          - Add debug logging for this sleep call.
2145            In my testing I never saw this sleep() hit.
2146         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2147          - Sleep a shorter interval to make websocket server
2148            startup more responsive.  On my machine startup was
2149            taking around 1 second.
2150          - Remove the unconditional .5s delay on startup.
2151         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2152          - Make image_hash file reads done lazily in a new image_hash() function.
2153          - Add a "Starting testing ..." meter update after DRT threads have
2154            been started, but before we get updates from the first one.
2155          - Rename variable "t" to a full english name to match WebKit style.
2156
2157 2010-04-20  Daniel Bates  <dbates@rim.com>
2158
2159         Reviewed by Eric Seidel.
2160
2161         https://bugs.webkit.org/show_bug.cgi?id=37748
2162
2163         Make Sheriffbot more inspirational.
2164
2165         * Scripts/webkitpy/common/net/bugzilla.py:
2166         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2167         * Scripts/webkitpy/tool/bot/irc_command.py:
2168         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2169         * Scripts/webkitpy/tool/mocktool.py:
2170
2171 2010-04-20  Kent Tamura  <tkent@chromium.org>
2172
2173         Reviewed by Dimitri Glazkov.
2174
2175         [DRT/Chromium] Import Chromium image_diff as ImageDiff
2176         https://bugs.webkit.org/show_bug.cgi?id=37790
2177
2178         ImageDiff.cpp is based on tools/imagediff/image_diff.cc r41911 of Chromium.
2179
2180         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2181         * DumpRenderTree/chromium/ImageDiff.cpp: Added.
2182         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2183
2184 2010-04-20  Dirk Pranke <dpranke@chromium.org>
2185
2186         This patch to new-run-webkit-tests adds a --log 'trace' option
2187         that prints out detailed info about a given test as it executes
2188         (where the baselines are, what the expectation is, what we got,
2189         how long it took).
2190
2191         https://bugs.webkit.org/show_bug.cgi?id=37726
2192
2193         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2194           - use the newly exposed TestResult class and implement
2195             --log trace
2196         * Scripts/webkitpy/layout_tests/layout_package/dump_render_thread.py:
2197           - rename TestStats to TestResult and make it more public, resulting
2198             in cleaner code
2199         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2200           - add expectation_to_string() as a separate callable function
2201
2202 2010-04-20  Eric Seidel  <eric@webkit.org>
2203
2204         Unreviewed, rolling out r57907.
2205         http://trac.webkit.org/changeset/57907
2206         https://bugs.webkit.org/show_bug.cgi?id=37765
2207
2208         Appears to have broken MacEWS and possibly webkit-patch upload
2209         for svn users.  Needs further investigation.
2210
2211         * Scripts/webkitpy/common/checkout/api.py:
2212         * Scripts/webkitpy/common/checkout/api_unittest.py:
2213         * Scripts/webkitpy/common/checkout/changelog.py:
2214         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2215         * Scripts/webkitpy/common/checkout/commitinfo.py:
2216         * Scripts/webkitpy/common/checkout/scm.py:
2217         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2218         * Scripts/webkitpy/common/config/committers.py:
2219         * Scripts/webkitpy/common/net/bugzilla.py:
2220         * Scripts/webkitpy/common/net/buildbot.py:
2221         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2222         * Scripts/webkitpy/common/net/statusserver.py:
2223         * Scripts/webkitpy/common/prettypatch.py:
2224         * Scripts/webkitpy/common/system/autoinstall.py:
2225         * Scripts/webkitpy/common/system/deprecated_logging.py:
2226         * Scripts/webkitpy/common/system/executive.py:
2227         * Scripts/webkitpy/common/system/executive_unittest.py:
2228         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2229         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2230         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2231         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2232         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2233         * Scripts/webkitpy/tool/commands/queues.py:
2234         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2235         * Scripts/webkitpy/tool/commands/upload.py:
2236         * Scripts/webkitpy/tool/mocktool.py:
2237         * Scripts/webkitpy/tool/steps/abstractstep.py:
2238         * Scripts/webkitpy/tool/steps/postdiff.py:
2239         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
2240         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2241         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2242
2243 2010-04-20  Nate Chapin  <japhet@chromium.org>
2244
2245         Unreviewed.
2246
2247         Update my irc handle in committers.py (natechapin -> japhet).
2248
2249         * Scripts/webkitpy/common/config/committers.py:
2250
2251 2010-04-20  Eric Seidel  <eric@webkit.org>
2252
2253         Reviewed by Adam Barth.
2254
2255         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
2256         https://bugs.webkit.org/show_bug.cgi?id=37765
2257
2258         I fixed the queue to not ignore Tor as a reviwer in r57531,
2259         but instead it throws an exception every time his name is in a patch.
2260
2261         This fixes our Executive.run_command code to work around a Popen
2262         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
2263         do not correctly handle unicode objects as input or output to
2264         Popen.communicate.
2265
2266         Following the advice of:
2267         http://farmdev.com/talks/unicode/
2268         I'm attempting to take the python unicode plunge and use unicode()
2269         objects as strings instead of str() objects everywhere in webkitpy.
2270
2271         We do not have to use u"" instead of "" because u"a" == "a" as expected
2272         in Python.  Python will generate a warning to the console in cases where
2273         a unicode() == str() operation cannot be performed.
2274
2275         I also cleaned up the input handling in run_command a little by adding
2276         a new _compute_input() method which can return early instead of having
2277         such a long/cluttered if-block.
2278
2279         Executive.run* now correctly accept and return unicode() objects.
2280         I attempted to fix all the places that we call .write() to make sure we
2281         encode any unicode() objects into utf-8.
2282
2283         All places which use StringIO need to be sure to pass StringIO a
2284         pre-encoded byte-array (str object) instead of unicode so that
2285         clients which read from the StringIO don't have encoding exceptions.
2286         To make this easier, I removed the patch_file_object support from
2287         add_patch_to_bug, and changed the 4 places which previously used
2288         StringIO to create a fake patch file.
2289
2290         I attempted to document any places where we are not correctly converting
2291         to/from bytes (str() objects) to strings (unicode() objects).
2292
2293         * Scripts/webkitpy/common/checkout/api_unittest.py:
2294          - Read/write utf-8 files instead of ascii.
2295          - Update the tests to use test for proper unicode() handling.
2296         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2297          - Use unicode() strings instead of str() byte arrays.
2298         * Scripts/webkitpy/common/checkout/scm.py:
2299          - Remove use of str().
2300         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2301          - Read/write utf-8 files and use unicode() strings in testing.
2302         * Scripts/webkitpy/common/config/committers.py:
2303          - Use \u instead of \x to make slightly clearer what we're doing.
2304         * Scripts/webkitpy/common/net/bugzilla.py:
2305          - Add a new _string_contents() method and explain why
2306            we have to call unicode() on the result of soup.string
2307            and why it's safe to do so w/o needing to pass a codec name.
2308          - Remove the (unused) support for passing a file object to add_patch_to_bug().
2309         * Scripts/webkitpy/common/net/buildbot.py:
2310          - Use unicode() instead of str() when needing to coax a
2311            NavigableString object into a unicode() object.
2312         * Scripts/webkitpy/common/net/statusserver.py:
2313          - Remove use of str()
2314         * Scripts/webkitpy/common/prettypatch.py:
2315          - Write out the patch file as utf-8.
2316         * Scripts/webkitpy/common/system/autoinstall.py:
2317          - Add a FIXME about encoding.
2318         * Scripts/webkitpy/common/system/deprecated_logging.py:
2319          - Document that tee() works on bytes, not strings.
2320         * Scripts/webkitpy/common/system/executive.py:
2321          - Make run* properly take and return unicode() objects.
2322         * Scripts/webkitpy/common/system/executive_unittest.py:
2323          - Added a unit test to make sure we don't break Tor again!
2324         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2325          - Write out the test list as utf-8.
2326         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2327          - Write out json files as utf-8.
2328         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2329          - Add FIXME about encoding handling.
2330         * Scripts/webkitpy/tool/commands/upload.py:
2331          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
2332         * Scripts/webkitpy/tool/mocktool.py:
2333          - Rename add_patch_to_bug argument to match bugzilla.py
2334         * Scripts/webkitpy/tool/steps/postdiff.py:
2335          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
2336         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto.
2337         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto.
2338         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2339          - Fixed spurious logging seen when running test-webkitpy
2340
2341 2010-04-20  Chris Jerdonek  <cjerdonek@webkit.org>
2342
2343         Reviewed by Shinichiro Hamaji.
2344
2345         For check-webkit-style, implemented __eq__() and __ne__() (the
2346         built-in equality and inequality methods) for the
2347         DefaultStyleErrorHandler class.
2348
2349         https://bugs.webkit.org/show_bug.cgi?id=37850
2350
2351         This will facilitate unit-testing for a subsequent patch,
2352         namely for https://bugs.webkit.org/show_bug.cgi?id=37850
2353
2354         * Scripts/webkitpy/style/error_handlers.py:
2355           - Added __eq__() and __ne__() to the DefaultStyleErrorHandler
2356             class.
2357
2358         * Scripts/webkitpy/style/error_handlers_unittest.py:
2359           - Added unit tests for __eq__() and __ne__().
2360           - Also included a minor clean-up refactoring of combining the
2361             StyleErrorHandlerTestBase class (which has not needed to
2362             be separate due to previous changes) into the
2363             DefaultStyleErrorHandlerTest class.
2364
2365 2010-04-20  Jakub Wieczorek  <jwieczorek@webkit.org>
2366
2367         Unreviewed.
2368
2369         Add my IRC nick to the committers.py list.
2370
2371         * Scripts/webkitpy/common/config/committers.py:
2372
2373 2010-04-20  Kim Grönholm  <kim.gronholm@nomovok.com>
2374
2375         Reviewed by Simon Hausmann.
2376
2377         [Qt] Multitouch mocking in QtLauncher doesn't work with QGraphicsView
2378         https://bugs.webkit.org/show_bug.cgi?id=37816
2379         
2380         Fix multi-touch mocking in QtLauncher when using QGraphicsView.
2381         Test: https://bug-32434-attachments.webkit.org/attachment.cgi?id=44955
2382
2383         * QtLauncher/main.cpp:
2384         (LauncherWindow::eventFilter):
2385         (LauncherWindow::initializeView):
2386
2387 2010-04-20  MORITA Hajime <morrita@google.com>
2388
2389         Unreviewed, add myself to the committers list.
2390
2391         * Scripts/webkitpy/common/config/committers.py:
2392
2393 2010-04-20  Kent Tamura  <tkent@chromium.org>
2394
2395         Reviewed by Shinichiro Hamaji.
2396
2397         [DRT/Chromium] Fix some unexpected results of editing
2398         https://bugs.webkit.org/show_bug.cgi?id=37843
2399
2400         This change fixes about 70 unexpected results.
2401         The original test_webview_delegate.cc doesn't have this bug.
2402         The bug was introduced when I ported it to WebKit tree.
2403
2404         * DumpRenderTree/chromium/WebViewHost.cpp:
2405         (printRangeDescription): Replace the latter startContainer() with endContainer().
2406
2407 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2408
2409         Unreviewed, build fix.
2410
2411         Turn off some unit tests for now - the new-run-webkit-tests dryrun
2412         tests for chromium won't work if you don't have a chromium checkout.
2413
2414         https://bugs.webkit.org/show_bug.cgi?id=37841
2415
2416         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2417
2418 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2419
2420         Unreviewed, build fix.
2421
2422         (Re-)add dryrun.py; this was renamed from passing.py in the previous
2423         CL but apparently somehow didn't get checked in.
2424
2425         https://bugs.webkit.org/show_bug.cgi?id=37841
2426
2427         * Scripts/webkitpy/layout_tests/port/dryrun.py: Added.
2428
2429 2010-04-19  Shinichiro Hamaji  <hamaji@chromium.org>
2430
2431         Reviewed by David Levin.
2432
2433         check-webkit-style: exits when encountering a deleted file
2434         https://bugs.webkit.org/show_bug.cgi?id=37122
2435
2436         This reverts the quick fix done by r57119 and makes check_patch
2437         not call check_file for deleted files.
2438
2439         Also this change fixes the behavior for "-", which should mean
2440         stdin.  Before this change, the style checker just ignored "-"
2441         with a warning message.
2442
2443         * Scripts/webkitpy/style/checker.py:
2444         * Scripts/webkitpy/style/checker_unittest.py:
2445
2446 2010-04-19  Daniel Bates  <dbates@rim.com>
2447
2448         No review, rolling out 57868.
2449         http://trac.webkit.org/changeset/57868
2450         https://bugs.webkit.org/show_bug.cgi?id=37748
2451
2452         Sheriffbot wasn't very inspirational after this patch.
2453         Instead, he was silent when you said hi :-(. Rolling
2454         out this patch so that I can debug/test this some more.
2455
2456         * Scripts/webkitpy/common/net/bugzilla.py:
2457         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2458         * Scripts/webkitpy/tool/bot/irc_command.py:
2459         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2460         * Scripts/webkitpy/tool/mocktool.py:
2461
2462 2010-04-19  Daniel Bates  <dbates@rim.com>
2463
2464         Reviewed by Adam Barth.
2465
2466         https://bugs.webkit.org/show_bug.cgi?id=37748
2467
2468         Make Sheriffbot more inspirational.
2469
2470         * Scripts/webkitpy/common/net/bugzilla.py:
2471         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2472         * Scripts/webkitpy/tool/bot/irc_command.py:
2473         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2474         * Scripts/webkitpy/tool/mocktool.py:
2475
2476 2010-04-19  Kevin Ollivier  <kevino@theolliviers.com>
2477
2478         [wx] Build fix, add missing header.
2479
2480         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2481
2482 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2483  
2484          Reviewed by Adam Barth.
2485  
2486          new-run-webkit-tests - repurpose the "Passing" port as "Dryrun" port
2487          that can be used to test platforms other than the one you are running
2488          on. This can be useful for checking baselines and testing code
2489          coverage.
2490  
2491          Note that running the code on the "wrong" port requires each
2492          port-specific implementation to actually not require any
2493          platform-specific python code (e.g., the chromium-win port must
2494          test for the existence of windows functions before calling them).
2495  
2496          https://bugs.webkit.org/show_bug.cgi?id=37782
2497  
2498          * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2499          * Scripts/webkitpy/layout_tests/port/dryrun.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/port/passing.py.
2500          * Scripts/webkitpy/layout_tests/port/factory.py:
2501          * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2502
2503 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2504
2505         Reviewed by Eric Seidel.
2506
2507         new-run-webkit-tests: add --build (default) and --no-build
2508         options to make that step optional. This flag modifies what happens
2509         in port.check_build().
2510
2511         https://bugs.webkit.org/show_bug.cgi?id=37786
2512
2513         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2514         * Scripts/webkitpy/layout_tests/port/chromium.py:
2515         * Scripts/webkitpy/layout_tests/port/webkit.py:
2516
2517 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2518
2519         Unreviewed, build fix.
2520
2521         new-run-webkit-tests - fix a typo in r57480 that caused us to stop
2522         logging the actual list of unexpected results.
2523
2524         https://bugs.webkit.org/show_bug.cgi?id=37831
2525
2526         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2527
2528 2010-04-19  Dirk Pranke <dpranke@chromium.org>
2529
2530         Reviewed by Adam Barth.
2531
2532         From a patch by Tor Arne Vestbo  <tor.arne.vestbo@nokia.com>
2533
2534         new-run-webkit-tests: make the retry step more explicit
2535         https://bugs.webkit.org/show_bug.cgi?id=37606
2536
2537         It might be confusing to see the test and percent counters
2538         reset without any notice of what's going on, so we make the
2539         message that a retry-run is started explicit.
2540
2541         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2542
2543 2010-04-19  Sam Weinig  <weinig@apple.com>
2544
2545         Reviewed by Anders Carlsson.
2546
2547         Add support for opening a new window (File->New Window) to
2548         Windows MiniBrowser. Accelerator doesn't work.
2549
2550         * MiniBrowser/win/BrowserView.cpp:
2551         (createNewPage): Use BrowserView::create.
2552         * MiniBrowser/win/BrowserWindow.cpp:
2553         (BrowserWindow::onCommand): Respond to ID_FILE_NEW_WINDOW
2554         by creating a new window.
2555         * MiniBrowser/win/BrowserWindow.h:
2556         (BrowserWindow::create): Added. Don't allow creating
2557         BrowserWindows on the stack by making constructor
2558         private and exposing the create function.
2559         * MiniBrowser/win/MiniBrowser.cpp:
2560         (MiniBrowser::createNewWindow): Move new window creation
2561         logic here.
2562         * MiniBrowser/win/MiniBrowser.h:
2563         * MiniBrowser/win/MiniBrowser.rc: 
2564         * MiniBrowser/win/main.cpp:
2565         (_tWinMain): Use the new MiniBrowser::createNewWindow().
2566
2567 2010-04-19  Chris Fleizach  <cfleizach@apple.com>
2568
2569         Reviewed by Beth Dakin.
2570
2571         AX: aria-haspopup needs to be exposed
2572         https://bugs.webkit.org/show_bug.cgi?id=37808
2573
2574         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2575         (AccessibilityUIElement::hasPopup):
2576
2577 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2578
2579         Reviewed by Eric Seidel.
2580
2581         Submit a better workaround for r57806 than the one in r57831 - log
2582         an error and exit if you try to run new-run-webkit-tests with --use-drt
2583         on Windows.
2584
2585         https://bugs.webkit.org/show_bug.cgi?id=37822
2586
2587         * Scripts/webkitpy/layout_tests/port/chromium.py:
2588
2589 2010-04-19  Jesus Sanchez-Palencia  <jesus@webkit.org>
2590
2591         Unreviewed.
2592
2593         Just adding myself as a committer.
2594
2595         * Scripts/webkitpy/common/config/committers.py:
2596
2597 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2598
2599         Reviewed by Eric Seidel.
2600
2601         Add slightly better logging to the websocket python wrapper script,
2602         including a --verbose flag for debug output.
2603
2604         https://bugs.webkit.org/show_bug.cgi?id=37233
2605
2606         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2607         * Scripts/new-run-webkit-websocketserver:
2608
2609 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2610
2611         Reviewed by Eric Seidel.
2612
2613         new-run-webkit-tests: add a way (--print-unexpected-results) to
2614         (re-)print out the tests that produced unexpected results in the
2615         last run. Also add a way (--retry-unexpected-results) to
2616         automatically re-test them.
2617
2618         https://bugs.webkit.org/show_bug.cgi?id=37783
2619
2620         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2621
2622 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2623
2624         Reviewed by Eric Seidel.
2625
2626         Restructure the logging in new-run-webkit-tests so that many of log
2627         messages that were logged to the MeteredStream also get logged in
2628         --verbose mode.
2629
2630         https://bugs.webkit.org/show_bug.cgi?id=37780
2631
2632         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2633         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2634
2635 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2636
2637         Reviewed by Eric Seidel.
2638
2639         new-run-webkit-tests: add 'summary' and 'unexpected-results' options
2640         to the --log flag. Also add a 'progress' flag to enable the regular
2641         progress bar (as opposed to 'detailed-progress', which enables the
2642         dots). Also add a 'nothing' flag to allow you to be explicit that
2643         you don't want any logging on the command line.
2644
2645         The default is
2646         '--log detailed-progress,summary,unexpected,unexpected-results'
2647
2648         (The default logging is unchanged by this patch, this just makes things
2649         properly configurable).
2650
2651         Note that 'nothing' doesn't work properly yet; I need a couple other
2652         patches to land to avoid rewriting things several different ways.
2653
2654         https://bugs.webkit.org/show_bug.cgi?id=37785
2655
2656         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2657
2658 2010-04-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2659
2660         Reviewed by Simon Hausmann.
2661
2662         Make the URL change on committed load.
2663
2664         * QtLauncher/mainwindow.cpp:
2665         (MainWindow::buildUI):
2666         (MainWindow::setAddressUrl):
2667         * QtLauncher/mainwindow.h:
2668
2669 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2670
2671         Reviewed by Eric Seidel.
2672
2673         Fix a typo in the rebaselining tool that causes us to use "debug"
2674         instead of "Debug" in a directory path, which fails on platforms with
2675         case-sensitive filesystems.
2676
2677         https://bugs.webkit.org/show_bug.cgi?id=37819
2678
2679         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2680
2681 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2682
2683         Unreviewed, build fix.
2684
2685         Fix breakage of chromium-win canary bots caused by r57806. That patch
2686         introduced the option of using Chrome's new port of DumpRenderTree,
2687         but unfortunately that port relies on the webkit.py class
2688         implementation which uses non-blocking I/O that isn't available on
2689         Windows. This patch turns off that option and doesn't import the
2690         class if we're running on Windows.
2691
2692         https://bugs.webkit.org/show_bug.cgi?id=37817
2693
2694         * Scripts/webkitpy/layout_tests/port/chromium.py:
2695
2696 2010-04-19  James Robinson  <jamesr@chromium.org>
2697
2698         Reviewed by abarth.
2699
2700         Fix a typo
2701
2702         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2703
2704 2010-04-19  Adam Roben  <aroben@apple.com>
2705
2706         Fix run-webkit-tests when there are spaces in the path
2707
2708         Fixes <http://webkit.org/b/37809>
2709
2710         Reviewed by Adam Barth.
2711
2712         * Scripts/run-webkit-tests: Use an "indirect object" to specify the
2713         path to the harness to exec(). According to perldoc, this usage will
2714         prohibit perl from parsing the arguments to exec() via the shell,
2715         which would incorrectly split paths with spaces in them, etc.
2716
2717 2010-04-19  Dimitri Glazkov  <dglazkov@chromium.org>
2718
2719         Reviewed by Adam Roben.
2720
2721         WinLauncher.h should use LF line-endings and use native line-endings style.
2722         https://bugs.webkit.org/show_bug.cgi?id=37807
2723
2724         * WinLauncher/WinLauncher.h: Added property svn:eol-style, converted to LF line-endings.
2725
2726 2010-04-19  Kent Tamura  <tkent@chromium.org>
2727
2728         Reviewed by Shinichiro Hamaji.
2729
2730         [DRT/Chromium] Fix a test initialization problem
2731         https://bugs.webkit.org/show_bug.cgi?id=37791
2732
2733         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2734         (runTest): Call resetTestController() before runFileTest(). Some
2735           controllers initialize their fields in reset() and not in their
2736           constructors.
2737
2738 2010-04-19  Kent Tamura  <tkent@chromium.org>
2739
2740         Reviewed by Eric Seidel.
2741
2742         [Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt
2743         https://bugs.webkit.org/show_bug.cgi?id=37793
2744
2745         We need to use WebKitDriver instead of ChromiumDriver for Chromium
2746         DRT because its interface is different from test_shell.
2747
2748         Chromium DRT has no UI.  So we can't use it to show test results.
2749
2750         * Scripts/webkitpy/layout_tests/port/chromium.py:
2751
2752 2010-04-18  Eric Seidel  <eric@webkit.org>
2753
2754         Reviewed by Adam Roben.
2755
2756         Make failure-reason more forgiving
2757         https://bugs.webkit.org/show_bug.cgi?id=37525
2758
2759         Removed search_limit, which wasn't very useful anyway.
2760         Added a log about the long load time loading from the builders.
2761         Prompt the user for what revision to start walking from (makes it easy to restart upon failure).
2762
2763         * Scripts/webkitpy/common/net/buildbot.py:
2764         * Scripts/webkitpy/tool/commands/queries.py:
2765
2766 2010-04-18  Chris Jerdonek  <cjerdonek@webkit.org>
2767
2768         Reviewed by Shinichiro Hamaji.
2769
2770         Created a class for check-webkit-style that encapsulates iterating
2771         over text files and reading them.
2772
2773         https://bugs.webkit.org/show_bug.cgi?id=37754
2774
2775         This revision is an intermediate step towards separating our
2776         style-checking code from the logic of iterating over files and
2777         reading them.
2778
2779         * Scripts/webkitpy/common/system/logtesting.py:
2780           - Added a logMessages() method to the LoggingTestCase class.
2781             This method provides unit tests with access to the raw list
2782             of log messages in case the tester needs to do something more
2783             than simply assert the list of existing messages.
2784
2785         * Scripts/webkitpy/style/checker.py:
2786           - Added a ProcessorBase class that processors of lists of lines
2787             should eventually inherit from.
2788           - Also added a FIXME to use the ProcessorBase class and the
2789             TextFileReader class added below.
2790
2791         * Scripts/webkitpy/style/filereader.py: Added.
2792           - Created a TextFileReader class that encapsulates reading
2793             and iterating over text files.
2794
2795         * Scripts/webkitpy/style/filereader_unittest.py: Added.
2796           - Added a TextFileReaderTest class to unit-test the
2797             new TextFileReader class.
2798
2799 2010-04-15  Tony Chang  <tony@chromium.org>
2800
2801         Reviewed by Adam Barth.
2802
2803         [chromium] new-run-webkit-tests should be able to use chromium DRT
2804         https://bugs.webkit.org/show_bug.cgi?id=37645
2805
2806         Make sure that the lack of a chromium checkout doesn't cause the script to
2807         fail.
2808
2809         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2810         * Scripts/webkitpy/layout_tests/port/chromium.py:
2811         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths
2812             to be relative to an upstream output dir.
2813         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag.
2814
2815 2010-04-18  Eric Seidel  <eric@webkit.org>
2816
2817         Unreviewed, fixing the Qt bot.
2818
2819         Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
2820         https://bugs.webkit.org/show_bug.cgi?id=37632
2821
2822         * Scripts/run-webkit-tests:
2823          - Exit non-zero of launching the harness fails.
2824
2825 2010-04-18  Eric Seidel  <eric@webkit.org>
2826
2827         Unreviewed, fixing the Qt bot.
2828
2829         Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
2830         https://bugs.webkit.org/show_bug.cgi?id=37632
2831
2832         * Scripts/run-webkit-tests:
2833          - Fix the wrapper to work for users who do not
2834            have WebKitTools/Scripts in their path.
2835
2836 2010-04-14  Eric Seidel  <eric@webkit.org>
2837
2838         Reviewed by Adam Barth.
2839
2840         Add a layer of indirection when calling run-webkit-tests to
2841         allow testing new-run-webkit-tests on various platforms.
2842         https://bugs.webkit.org/show_bug.cgi?id=37632
2843
2844         This will let us test and fix bugs in new-run-webkit-tests
2845         without needing to restart the buildbot master between tests.
2846
2847         Currently this change leaves run-webkit-tests as-is, but once
2848         its landed we will easily be able to turn on/off
2849         new-run-webkit-tests for various ports/configurations.
2850
2851         I will send a note out to webkit-dev about how we will
2852         be using this launcher script to test on the bots.
2853
2854         * Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests.
2855         * Scripts/run-webkit-tests:
2856          - A new script which decides whether to run new- or old-
2857            run-webkit-tests based on the platform.
2858         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2859          - Add some dummy argument handling for arguments which
2860            old-run-webkit-tests supports but new-run-webkit-tests
2861            does not yet.
2862
2863 2010-04-18  Eric Seidel  <eric@webkit.org>
2864
2865         Reviewed by Adam Barth.
2866
2867         Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
2868         https://bugs.webkit.org/show_bug.cgi?id=33295
2869
2870         The Gtk builders have been green every time I've looked
2871         at them in the last 5 days or so.  It would appear webkit
2872         is now keeping them green and we should update the core
2873         builder list to match reality.
2874
2875         * Scripts/webkitpy/common/net/buildbot.py:
2876         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2877
2878 2010-04-18  Robert Hogan  <robert@webkit.org>
2879
2880         Reviewed by Simon Hausmann.
2881
2882         [Qt] Add support for LayoutTestController commands:
2883                    setSmartInsertDeleteEnabled
2884                    setSelectTrailingWhitespaceEnabled
2885                    execCommand
2886                    isCommandEnabled
2887
2888         https://bugs.webkit.org/show_bug.cgi?id=35844
2889
2890         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2891         (WebCore::WebPage::resetSettings):
2892         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2893         (LayoutTestController::setSmartInsertDeleteEnabled):
2894         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
2895         (LayoutTestController::execCommand):
2896         (LayoutTestController::isCommandEnabled):
2897         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2898
2899 2010-04-17  Adam Barth  <abarth@webkit.org>
2900
2901         Reviewed by Eric Seidel.
2902
2903         Remove steps_references and commands_references
2904         https://bugs.webkit.org/show_bug.cgi?id=37758
2905
2906         We tried using the mumble_references convention to manage our
2907         dependencies, but it doesn't seem to be providing much value for the
2908         steps and commands module because these modules are small pieces of the
2909         larger tool module.  In this patch, I've removed the references file
2910         for these modules.
2911  
2912         I've left the style_references file for the style module because that
2913         module seems better isolated from the rest of webkitpy and the
2914         style_references file appears to be providing some value.
2915
2916         * Scripts/webkitpy/tool/commands/commandtest.py:
2917         * Scripts/webkitpy/tool/commands/download_unittest.py:
2918         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2919         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2920         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2921         * Scripts/webkitpy/tool/commands/queuestest.py:
2922         * Scripts/webkitpy/tool/commands/upload.py:
2923         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2924         * Scripts/webkitpy/tool/commands_references.py: Removed.
2925         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2926         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2927         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2928         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
2929         * Scripts/webkitpy/tool/steps_references.py: Removed.
2930
2931 2010-04-17  Eric Seidel  <eric@webkit.org>
2932
2933         Reviewed by Adam Barth.
2934
2935         WebKit needs a Chromium Mac EWS Builder
2936         https://bugs.webkit.org/show_bug.cgi?id=37742
2937
2938         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2939
2940 2010-04-17  Adam Barth  <abarth@webkit.org>
2941
2942         Fix expected results for unit test broken by
2943         http://trac.webkit.org/changeset/57772
2944
2945         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2946
2947 2010-04-17  Sam Weinig  <weinig@apple.com>
2948
2949         Reviewed by Adam Roben.
2950
2951         Teach windows MiniBrowser how to work with window.open()
2952         and targeted links.
2953
2954         * MiniBrowser/win/BrowserView.cpp:
2955         (createNewPage): Create a new BrowserWindow and return its page.
2956         (showPage): Show the page.
2957         (closePage): Empty implementation.
2958         (runJavaScriptAlert): Empty implementation.
2959         (BrowserView::create): Register a UIClient.
2960         * MiniBrowser/win/BrowserView.h:
2961         (BrowserView::webView): Added.
2962         Change create to take a BrowserWindow instead of an HWND.
2963
2964         * MiniBrowser/win/BrowserWindow.cpp:
2965         (BrowserWindow::wndProc): Respond to WM_NCDESTROY.
2966         (BrowserWindow::goToURL): Added. Forwards to BrowserView.
2967         (BrowserWindow::onCreate): Don't always go to the default
2968         url. Let the caller do this.
2969         (BrowserWindow::onNCDestroy): Delete the window.
2970         * MiniBrowser/win/BrowserWindow.h:
2971         (BrowserWindow::view): Added.
2972         (BrowserWindow::window): Added.
2973
2974         * MiniBrowser/win/main.cpp:
2975         (_tWinMain):
2976         Go to the default URL for the initial page. Allocate the initial
2977         window on the heap for correctness.
2978
2979 2010-04-16  Adam Roben  <aroben@apple.com>
2980
2981         Add the Windows Debug (Test) builder to the list of core builders
2982
2983         It's been green for a few days now, and all the known Windows
2984         flakiness is Release-only.
2985
2986         Rubber-stamped by Mark Rowe.
2987
2988         * Scripts/webkitpy/common/net/buildbot.py:
2989         (BuildBot.core_builder_name_regexps): Added a regular expression to
2990         match the "Windows Debug (Test)" builder.
2991
2992 2010-04-16  Sam Weinig  <sam@webkit.org>
2993
2994         Reviewed by Anders Carlsson.
2995
2996         Fix window.open() and targeted links.
2997
2998         * MiniBrowser/mac/BrowserWindowController.m:
2999         (_createNewPage): Use the correct initializer to and load the window.
3000
3001 2010-04-16  Adam Roben  <aroben@apple.com>
3002
3003         Fix links to layout test results from build status pages
3004
3005         Reviewed by Mark Rowe.
3006
3007         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3008         (ExtractTestResults.finished): Prepend "/" on the URL of the test
3009         results page so that it is treated as an absolute URL.
3010
3011 2010-04-16  Tony Chang  <tony@chromium.org>
3012
3013         Reviewed by Dimitri Glazkov.
3014
3015         [chromium] build DRT on Linux
3016         https://bugs.webkit.org/show_bug.cgi?id=37690
3017
3018         * Scripts/build-dumprendertree: Add support for win and linux
3019
3020 2010-04-16  Sam Weinig  <weinig@apple.com>
3021
3022         Reviewed by Adam Roben.
3023
3024         Use the threaded process model for MiniBrowser if holding down
3025         the shift key on startup.
3026
3027         * MiniBrowser/win/BrowserView.cpp:
3028         (BrowserView::create): 
3029
3030 2010-04-15  Tony Chang  <tony@chromium.org>
3031
3032         Reviewed by Dimitri Glazkov.
3033
3034         [chromium] Add TestShellGtk.cpp so we can link on Linux
3035         https://bugs.webkit.org/show_bug.cgi?id=37561
3036
3037         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add new file and
3038             add platform file exceptions.
3039         * DumpRenderTree/chromium/TestShellGtk.cpp: Added.
3040         (AlarmHandler):
3041         (TestShell::waitTestFinished):
3042
3043 2010-04-15  Tony Chang  <tony@chromium.org>
3044
3045         Reviewed by Dimitri Glazkov.
3046
3047         build DRT on chromium mac
3048         https://bugs.webkit.org/show_bug.cgi?id=37639
3049
3050         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3051         * Scripts/build-dumprendertree: enable build-dumprendertree --chromium
3052
3053 2010-04-15  Kent Tamura  <tkent@chromium.org>
3054
3055         Reviewed by Dimitri Glazkov.
3056
3057         [DRT/Chromium] Add LayoutTestHelper for Mac
3058         https://bugs.webkit.org/show_bug.cgi?id=37668
3059
3060         LayouTestHelper.mm is based on webkit/tools/test_shell/mac/layout_test_helper.mm
3061         of Chromium.
3062
3063         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3064         * DumpRenderTree/chromium/LayoutTestHelper.mm: Added.
3065
3066 2010-04-15  Alexey Proskuryakov  <ap@apple.com>
3067
3068         Reviewed by Geoff Garen.
3069
3070         https://bugs.webkit.org/show_bug.cgi?id=37494
3071         <rdar://problem/7857060> REGRESSION (r57340): fast/events/mouse-drag-from-frame-to-other-frame.html
3072         fails on Windows
3073
3074         * DumpRenderTree/win/EventSender.cpp: (makeEventSender):
3075         * DumpRenderTree/win/EventSender.h:
3076         Tell EventSender if it's being created for a top frame.
3077         
3078         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3079         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): We only want to reset
3080         EventSender machinery when a new test is loaded, not when an iframe (or just its global
3081         object) is created.
3082
3083 2010-04-15  Adam Roben  <aroben@apple.com>
3084
3085         Fix Windows WebKit2 build.
3086
3087         * MiniBrowser/win/MiniBrowser.cpp:
3088
3089 2010-04-15  Ojan Vafai  <ojan@chromium.org>
3090
3091         Reviewed by Adam Barth.
3092
3093         Include codereview issue number in patch description
3094         https://bugs.webkit.org/show_bug.cgi?id=37677
3095
3096         This lets us know which rietveld issue this patch is tied to.
3097
3098         Also, make it so that --fancy-review overrides --no-review.
3099
3100         * Scripts/webkitpy/tool/steps/postcodereview.py:
3101         * Scripts/webkitpy/tool/steps/postdiff.py:
3102
3103 2010-04-15  Adam Roben  <aroben@apple.com>
3104
3105         Make --exit-after-n-failures work when all tests are timing out or crashing
3106
3107         Fixes <http://webkit.org/b/37679>.
3108
3109         Reviewed by Jon Honeycutt.
3110
3111         * Scripts/run-webkit-tests:
3112         (top level): When a test crashes or times out, break out of the main loop if
3113         stopRunningTestsEarlyIfNeeded returns true. Moved some code from the bottom of the main loop
3114         from here...
3115         (stopRunningTestsEarlyIfNeeded): ...to here.
3116
3117 2010-04-15  Sam Weinig  <sam@webkit.org>
3118
3119         Reviewed by Anders Carlsson.
3120
3121         Add WebHistoryClient support.
3122         https://bugs.webkit.org/show_bug.cgi?id=37671
3123
3124         Add HistoryClient logging.
3125
3126         * MiniBrowser/mac/BrowserWindowController.m:
3127         (_didNavigateWithNavigationData):
3128         (_didPerformClientRedirect):
3129         (_didPerformServerRedirect):
3130         (_didUpdateHistoryTitle):
3131         (-[BrowserWindowController awakeFromNib]):
3132
3133 2010-04-15  Anders Carlsson  <andersca@apple.com>
3134
3135         Reviewed by Sam Weinig.
3136
3137         Start the mini browser in threaded mode if shift is pressed during startup.
3138         https://bugs.webkit.org/show_bug.cgi?id=37670
3139
3140         * MiniBrowser/mac/AppDelegate.m:
3141         (-[BrowserAppDelegate init]):
3142
3143 2010-04-15  Chris Fleizach  <cfleizach@apple.com>
3144
3145         Reviewed by Beth Dakin.
3146
3147         AXHelp is being appended from ancestors incorrectly
3148         https://bugs.webkit.org/show_bug.cgi?id=37659
3149
3150         * DumpRenderTree/AccessibilityUIElement.cpp:
3151         (getHelpTextCallback):
3152         (AccessibilityUIElement::getJSClass):
3153         * DumpRenderTree/AccessibilityUIElement.h:
3154         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3155         (AccessibilityUIElement::helpText):
3156         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3157         (AccessibilityUIElement::helpText):
3158         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3159         (AccessibilityUIElement::helpText):
3160
3161 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
3162
3163         Reviewed by Adam Barth.
3164
3165         Re-format run-webkit-tests to fit in 80-columns for PEP-8 compliance.
3166         (broken by r57463 and r57381, at least). I've also filed bug 37477
3167         to fix check-webkit-style to catch these things.
3168
3169         https://bugs.webkit.org/show_bug.cgi?id=38586
3170
3171         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3172
3173 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
3174
3175         Reviewed by Dimitri Glazkov.
3176
3177         Add a way to override the user-visible name for the test binary since
3178         some ports don't call it DumpRenderTree (e.g., Chromium Win uses
3179         test_shell, Chromium Mac uses TestShell) by adding a driver_name()
3180         method to the Port interface.
3181
3182         https://bugs.webkit.org/show_bug.cgi?id=37631
3183
3184         * Scripts/webkitpy/layout_tests/port/base.py:
3185         * Scripts/webkitpy/layout_tests/port/chromium.py:
3186         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3187         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3188
3189 2010-04-14  Anders Carlsson  <andersca@apple.com>
3190
3191         Reviewed by Adam Roben.
3192
3193         Add "Force Repaint" to debug menu.
3194         https://bugs.webkit.org/show_bug.cgi?id=37627
3195
3196         * MiniBrowser/mac/BrowserWindowController.h:
3197         * MiniBrowser/mac/BrowserWindowController.m:
3198         (-[BrowserWindowController forceRepaint:]):
3199         * MiniBrowser/mac/English.lproj/MainMenu.xib:
3200
3201 2010-04-15  Sam Weinig  <sam@webkit.org>
3202
3203         Reviewed by Adam Roben.
3204
3205         Add debug-minibrowser script.
3206
3207         * Scripts/debug-minibrowser: Copied from Scripts/run-minibrowser.
3208         * Scripts/webkitdirs.pm:
3209
3210 2010-04-15  Roland Steiner  <rolandsteiner@chromium.org>
3211  
3212         Reviewed by Dimitri Glazkov.
3213
3214         Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
3215         https://bugs.webkit.org/show_bug.cgi?id=37636
3216  
3217         Second patch: add Windows-specific implementation parts
3218         of TestShell.
3219
3220         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3221         * DumpRenderTree/chromium/TestShell.h:
3222         (TestShell::finishedEvent):
3223         * DumpRenderTree/chromium/TestShellWin.cpp:
3224         (watchDogThread):
3225         (TestShell::waitTestFinished):
3226
3227 2010-04-15  Roland Steiner  <rolandsteiner@chromium.org>
3228
3229         Reviewed by Dimitri Glazkov.
3230
3231         Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
3232         https://bugs.webkit.org/show_bug.cgi?id=37636
3233
3234         First patch: fix compiler errors.
3235
3236         * DumpRenderTree/chromium/EventSender.cpp:
3237         (EventSender::reset):
3238         (EventSender::dispatchMessage):
3239         * DumpRenderTree/chromium/LayoutTestController.cpp:
3240         (LayoutTestController::pathToLocalResource):
3241         * DumpRenderTree/chromium/TestWebWorker.h:
3242         * DumpRenderTree/chromium/TextInputController.cpp:
3243         * DumpRenderTree/chromium/WebViewHost.h:
3244         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3245
3246 2010-04-14  Luiz Agostini  <luiz.agostini@openbossa.org>
3247
3248         Reviewed by Simon Hausmann.
3249
3250         [Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
3251         https://bugs.webkit.org/show_bug.cgi?id=37622
3252
3253         Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
3254         (bug 35844). Moving it back.
3255
3256         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3257         (LayoutTestController::setViewModeMediaFeature):
3258
3259 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
3260
3261         Reviewed by Adam Barth.
3262
3263         Add some very minimal unit tests for new-run-webkit-tests. This should
3264         be enough to catch egregious brokenness like syntax errors and import
3265         declaration issues.
3266
3267         https://bugs.webkit.org/show_bug.cgi?id=37432
3268
3269         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3270         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Added.
3271
3272 2010-04-14  Brian Weinstein  <bweinstein@apple.com>
3273
3274         Reviewed by Adam Roben.
3275
3276         Add a way for the buildbot to kill any old processes that are running. This
3277         is useful because the Windows bots can get in states where a process remains
3278         running (httpd.exe, DumpRenderTree.exe), which causes the bots to get in a red
3279         state, and the processes must be killed manually.
3280
3281         * BuildSlaveSupport/build.webkit.org-config/master.cfg: If we are on Windows, kill
3282             the old processes that might be running.
3283         * BuildSlaveSupport/win/kill-old-processes: Added.
3284
3285 2010-04-14  Sam Weinig  <sam@webkit.org>
3286
3287         Reviewed by Anders Carlsson.
3288
3289         Tear down WebKit more completely on window closing and application
3290         termination. We still don't block application termination for pending
3291         close, but this is a step in the right direction.
3292
3293         * MiniBrowser/mac/AppDelegate.m:
3294         (-[BrowserAppDelegate applicationWillTerminate:]):
3295         * MiniBrowser/mac/BrowserWindowController.h:
3296         * MiniBrowser/mac/BrowserWindowController.m:
3297         (-[BrowserWindowController dealloc]):
3298         (-[BrowserWindowController windowWillClose:]):
3299         (-[BrowserWindowController applicationTerminating]):
3300
3301 2010-04-14  Adam Barth  <abarth@webkit.org>
3302
3303         Reviewed by Eric Seidel.
3304
3305         Use pretty patch for confirming webkit-patch diffs
3306         https://bugs.webkit.org/show_bug.cgi?id=37489
3307
3308         * Scripts/webkitpy/common/prettypatch.py: Added.
3309         * Scripts/webkitpy/tool/commands/download_unittest.py:
3310         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3311         * Scripts/webkitpy/tool/mocktool.py:
3312         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3313
3314 2010-04-14  Eric Seidel  <eric@webkit.org>
3315
3316         Reviewed by Adam Barth.
3317
3318         Teach webkit-patch how to handle revisions missing ChangeLogs
3319         https://bugs.webkit.org/show_bug.cgi?id=37519
3320
3321         Make commit_info_for_revision return None when revision
3322         is missing a ChangeLog.  Previously we would throw an array index
3323         exception.
3324         Teach callers how to handle None.
3325
3326         * Scripts/webkitpy/common/checkout/api.py:
3327         * Scripts/webkitpy/common/checkout/api_unittest.py:
3328         * Scripts/webkitpy/tool/commands/download.py:
3329         * Scripts/webkitpy/tool/commands/queries.py:
3330         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3331
3332 2010-04-13  Eric Seidel  <eric@webkit.org>
3333
3334         Reviewed by Adam Roben.
3335
3336         Add Qt Bot to the list of "core builders" (builders which block the commit-queue when red)
3337         https://bugs.webkit.org/show_bug.cgi?id=33297
3338
3339         This is an experiment.  The bots have been green for
3340         a while.  We'll see if adding them under sheriff-bot protection
3341         will keep them green.
3342
3343         * Scripts/webkitpy/common/net/buildbot.py:
3344         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3345
3346 2010-04-13  Eric Seidel  <eric@webkit.org>
3347
3348         Unreviewed, just fixing a constant in the Rietveld unit test.
3349
3350         * Scripts/webkitpy/common/net/rietveld_unittest.py
3351
3352 2010-04-13  Eric Seidel  <eric@webkit.org>
3353
3354         Unreviewed, just adding missing Mock to fix python tests.
3355
3356         * Scripts/webkitpy/tool/mocktool.py:
3357
3358 2010-04-13  Ojan Vafai  <ojan@chromium.org>
3359
3360         Reviewed by David Levin.
3361
3362         Add experimental prototype Rietveld integration to webkit-patch upload
3363         https://bugs.webkit.org/show_bug.cgi?id=37418
3364
3365         This patch adds bare-bones integration with Rietveld for code reviews.
3366         The behavior is hidden behind the --fancy-review command line flag.
3367         Currently, there's no support for uploading more than one patch per
3368         issue (which is a nice feature of Rietveld).  The plan is to play with
3369         this for a bit and see if it's useful.
3370
3371         Modified from Adam's original patch to autoinstall the rietveld upload script.
3372
3373         * Scripts/webkitpy/common/config/__init__.py:
3374         * Scripts/webkitpy/common/net/rietveld.py: Added.
3375         * Scripts/webkitpy/common/net/rietveld_unitttest.py: Added.
3376         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3377         * Scripts/webkitpy/tool/commands/upload.py:
3378         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3379         * Scripts/webkitpy/tool/main.py:
3380         * Scripts/webkitpy/tool/mocktool.py:
3381         * Scripts/webkitpy/tool/steps/__init__.py:
3382         * Scripts/webkitpy/tool/steps/options.py:
3383         * Scripts/webkitpy/tool/steps/postcodereview.py: Added.
3384         * Scripts/webkitpy/tool/steps/postdiff.py:
3385
3386 2010-04-13  Sam Weinig  <sam@webkit.org>
3387
3388         Rubber-stamped by Mark Rowe.
3389
3390         Add Makefile to MiniBrowser.
3391
3392         * MiniBrowser/Makefile: Added.
3393
3394 2010-04-13  Eric Seidel  <eric@webkit.org>
3395
3396         Unreviewed, just adding a sanity check.
3397
3398         Add check to make sure commit-queue can never commit too short a message
3399         https://bugs.webkit.org/show_bug.cgi?id=37528
3400
3401         The commit-queue made bogus messages here:
3402         http://trac.webkit.org/changeset/57532
3403         http://trac.webkit.org/changeset/57534
3404
3405         This was a regression caused by adding unicode parsing for
3406         our ChangeLog files.  Popen does not seem to play nice with
3407         unicode strings.
3408
3409         I'm also adding an "assert" to make sure short ChangeLogs never happen again.
3410
3411         * Scripts/webkitpy/common/system/executive.py:
3412          - Cast input to strings before passing to POpen
3413         * Scripts/webkitpy/tool/steps/commit.py:
3414          - Validate that commit messages are not to short.
3415
3416 2010-04-13  Adam Roben  <aroben@apple.com>
3417
3418         Robustify new-run-webkit-tests against paths with spaces in them
3419
3420         Reviewed by Eric Seidel.
3421
3422         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3423         (LayoutTestApacheHttpd.__init__): Quote all paths that we pass to
3424         Apache to ensure that paths with spaces in them are interpreted
3425         correctly.
3426
3427 2010-04-13  Csaba Osztrogonác  <ossy@webkit.org>
3428
3429         Unreviewed buildfix after r57537.
3430
3431         * DumpRenderTree/qt/LayoutTestControllerQt.h: Declaration of removeOriginAccessWhitelistEntry() added.
3432
3433 2010-04-13  Sam Weinig  <sam@webkit.org>
3434
3435         Reviewed by Maciej Stachowiak.
3436
3437         Make building new webkit API and MiniBrowser a little easier.
3438
3439         * Scripts/build-webkit: Make building with --webkit2 build the 
3440         MiniBrowser as well and tell you how to use it.
3441         * Scripts/run-minibrowser: Copied from Scripts/run-safari.
3442         * Scripts/webkitdirs.pm: Add runMiniBrowser function.
3443
3444 2010-04-12  Timothy Hatcher  <timothy@apple.com>
3445
3446         SecurityOrigin needs a way to remove individual OriginAccessEntries
3447         https://bugs.webkit.org/show_bug.cgi?id=37449
3448
3449         Reviewed by Dave Hyatt.
3450
3451         * DumpRenderTree/LayoutTestController.cpp:
3452         (removeOriginAccessWhitelistEntryCallback): Added. Call LayoutTestController::removeOriginAccessWhitelistEntry.
3453         (LayoutTestController::staticFunctions): Added removeOriginAccessWhitelistEntry.
3454         * DumpRenderTree/LayoutTestController.h:
3455         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3456         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3457         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3458         (LayoutTestController::removeOriginAccessWhitelistEntry): Added.
3459         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3460         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3461         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3462         (LayoutTestController::removeOriginAccessWhitelistEntry): Added.
3463         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3464         (LayoutTestController::whiteListAccessFromOrigin): FIXME to implement.
3465         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3466
3467 2010-04-13  Timothy Hatcher  <timothy@apple.com>
3468
3469         Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
3470         And LayoutTestController.whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
3471         And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
3472
3473         SecurityOrigin needs a way to remove individual OriginAccessEntries
3474         https://bugs.webkit.org/show_bug.cgi?id=37449
3475
3476         Reviewed by Dave Hyatt.
3477
3478         * DumpRenderTree/LayoutTestController.cpp:
3479         (addOriginAccessWhitelistEntryCallback):
3480         (LayoutTestController::staticFunctions):
3481         * DumpRenderTree/LayoutTestController.h:
3482         * DumpRenderTree/chromium/LayoutTestController.cpp:
3483         (LayoutTestController::LayoutTestController):
3484         (LayoutTestController::addOriginAccessWhitelistEntry):
3485         * DumpRenderTree/chromium/LayoutTestController.h:
3486         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3487         (LayoutTestController::addOriginAccessWhitelistEntry):
3488         * DumpRenderTree/mac/DumpRenderTree.mm:
3489         (resetWebViewToConsistentStateBeforeTesting):
3490         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3491         (LayoutTestController::addOriginAccessWhitelistEntry):
3492         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3493         (LayoutTestController::addOriginAccessWhitelistEntry):
3494         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3495         * DumpRenderTree/win/DumpRenderTree.cpp:
3496         (resetWebViewToConsistentStateBeforeTesting):
3497         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3498         (LayoutTestController::addOriginAccessWhitelistEntry):
3499         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3500         (LayoutTestController::addOriginAccessWhitelistEntry):
3501
3502 2010-04-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3503
3504         Reviewed by Eric Seidel.
3505
3506         Remove duplicate function for new-run-webkit-tests
3507         https://bugs.webkit.org/show_bug.cgi?id=37517
3508
3509         The version() function was already implemented.
3510
3511         * Scripts/webkitpy/layout_tests/port/webkit.py:
3512
3513 2010-04-13  Eric Seidel  <eric@webkit.org>
3514
3515         Reviewed by David Levin.
3516
3517         the commit-queue hates Tor Arne Vestbø
3518         https://bugs.webkit.org/show_bug.cgi?id=37511
3519
3520         We were failing to read reviewers out of ChangeLogs
3521         when the reviewer has unicode characters in his/her name.
3522         I fixed this by explicitly decoding from utf8 every time we
3523         read in a ChangeLog file (they are always UTF8).
3524
3525         * Scripts/webkitpy/common/checkout/changelog.py:
3526         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3527
3528 2010-04-13  Adam Roben  <aroben@apple.com>
3529
3530         Fix run-webkit-tests on Windows with spaces in the path
3531
3532         Fixes <http://webkit.org/b/37509>.
3533
3534         Reviewed by Steve Falkenburg.
3535
3536         * Scripts/run-webkit-tests:
3537         (convertPathUsingCygpath): Remove spaces from the path before passing
3538         them to cygpath, then add them back in after conversion, as some
3539         versions of cygpath seem to convert spaces into newlines.
3540
3541 2010-04-13  Adam Barth  <abarth@webkit.org>
3542