e62ab7b2e523aa822231b1086bbaa0cd5a875489
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-03-26  Kent Tamura  <tkent@chromium.org>
2
3         Reviewed by Dimitri Glazkov.
4
5         [DRT/Chromium] Add TestNavigationController and TestWebWorker
6         https://bugs.webkit.org/show_bug.cgi?id=36520
7
8         Add LayoutTestController class, which is going to be used by
9         DumpRenderTree Chromium port. These files are based on:
10         - src/webkit/tools/test_shell/layout_test_controller.cc
11         - src/webkit/tools/test_shell/layout_test_controller.h
12         of Chromium rev.40492.
13
14         * DumpRenderTree/chromium/LayoutTestController.cpp: Added.
15         * DumpRenderTree/chromium/LayoutTestController.h: Added.
16
17 2010-03-25  Charlie Reis  <creis@chromium.org>
18
19         Reviewed by Adam Barth.
20
21         onbeforeunload not called at window close + frame or iframe focused
22         https://bugs.webkit.org/show_bug.cgi?id=27481
23
24         Adds a callShouldCloseOnWebView method to LayoutTestController,
25         to allow automated testing for bug 27481.
26
27         * DumpRenderTree/LayoutTestController.cpp:
28         (callShouldCloseOnWebViewCallback):
29         (LayoutTestController::staticFunctions):
30         * DumpRenderTree/LayoutTestController.h:
31         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
32         (LayoutTestController::callShouldCloseOnWebView):
33         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
34         (LayoutTestController::callShouldCloseOnWebView):
35         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
36         (LayoutTestController::callShouldCloseOnWebView):
37         * DumpRenderTree/qt/LayoutTestControllerQt.h:
38         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
39         (LayoutTestController::callShouldCloseOnWebView):
40
41 2010-03-25  Eric Seidel  <eric@webkit.org>
42
43         Reviewed by Adam Barth.
44
45         Add webkit-patch lkgr for finding last known good revision
46         https://bugs.webkit.org/show_bug.cgi?id=36626
47
48         This is rather slow for now because the command
49         has to compute this information from the buildbot.
50         A better long-term solution would be to have a server
51         somewhere store a pre-computed LKGR and then any
52         script (like webkit-patch) could just fetch it.
53
54         * Scripts/webkitpy/common/net/buildbot.py:
55         * Scripts/webkitpy/tool/commands/queries.py:
56
57 2010-03-25  Adam Barth  <abarth@webkit.org>
58
59         Reviewed by Eric Seidel.
60
61         Move modified_changelogs (and friends) from scm to checkout
62         https://bugs.webkit.org/show_bug.cgi?id=36636
63
64         These functions know about ChangeLogs, which is forbidden knowledge in
65         scm.py.
66
67         * Scripts/webkitpy/common/checkout/api.py:
68         * Scripts/webkitpy/common/checkout/changelog.py:
69         * Scripts/webkitpy/common/checkout/scm.py:
70         * Scripts/webkitpy/tool/mocktool.py:
71         * Scripts/webkitpy/tool/steps/abstractstep.py:
72         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
73         * Scripts/webkitpy/tool/steps/revertrevision.py:
74         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
75         * Scripts/webkitpy/tool/steps/validatereviewer.py:
76
77 2010-03-25  Adam Barth  <abarth@webkit.org>
78
79         Reviewed by Eric Seidel.
80
81         Move apply_patch from scm to checkout
82         https://bugs.webkit.org/show_bug.cgi?id=36635
83
84         SCM shouldn't have any knowledge of WebKit scripts.
85
86         * Scripts/webkitpy/common/checkout/api.py:
87         * Scripts/webkitpy/common/checkout/scm.py:
88         * Scripts/webkitpy/common/checkout/scm_unittest.py:
89         * Scripts/webkitpy/tool/mocktool.py:
90         * Scripts/webkitpy/tool/steps/applypatch.py:
91
92 2010-03-25  Eric Seidel  <eric@webkit.org>
93
94         Unreviewed build fix to un-break webkit-patch land.
95         Test-case coming in follow-up commit.
96
97         Move commit_message_for_this_commit from scm to checkout
98         https://bugs.webkit.org/show_bug.cgi?id=36629
99
100         * Scripts/webkitpy/common/checkout/api.py: import scm.CommitMessage
101
102 2010-03-25  Dan Bernstein  <mitz@apple.com>
103
104         Reviewed by Darin Adler.
105
106         <rdar://problem/7728903> Support color bitmap fonts
107
108         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added ColorBits.ttf
109         and ColorBits-A.png.
110         * DumpRenderTree/fonts/ColorBits-A.png: Copied from WebCore/inspector/front-end/Images/successGreenDot.png.
111         * DumpRenderTree/fonts/ColorBits.ttf: Added.
112         * DumpRenderTree/mac/DumpRenderTree.mm:
113         (activateFonts): Activate ColorBits.ttf.
114
115 2010-03-25  Mark Rowe  <mrowe@apple.com>
116
117         Remove a printf that was causing commit-log-editor to spew the name of the editor
118         to the terminal many times during a commit.
119
120         * Scripts/commit-log-editor:
121
122 2010-03-25  Adam Barth  <abarth@webkit.org>
123
124         Reviewed by Eric Seidel.
125
126         Move commit_message_for_this_commit from scm to checkout
127         https://bugs.webkit.org/show_bug.cgi?id=36629
128
129         This function requires knowledge of ChangeLogs, but scm shouldn't know
130         about ChangeLogs.
131
132         * Scripts/webkitpy/common/checkout/api.py:
133         * Scripts/webkitpy/common/checkout/scm.py:
134         * Scripts/webkitpy/tool/commands/upload.py:
135         * Scripts/webkitpy/tool/commands/upload_unittest.py:
136         * Scripts/webkitpy/tool/mocktool.py:
137         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
138         * Scripts/webkitpy/tool/steps/commit.py:
139
140 2010-03-25  Adam Barth  <abarth@webkit.org>
141
142         Reviewed by Eric Seidel.
143
144         REGRESSION: webkit-patch land can't land "rubber-stamped" patches
145         https://bugs.webkit.org/show_bug.cgi?id=36582
146
147         Allow a "-" in rubber stamped.
148
149         * Scripts/webkitpy/tool/steps/validatereviewer.py:
150
151 2010-03-25  Adam Barth  <abarth@webkit.org>
152
153         Unreviewed.  Fix some copyright lines to remove extraneous comma and
154         python directive.
155
156         * Scripts/webkitpy/tool/bot/patchcollection.py:
157         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py:
158         * Scripts/webkitpy/tool/bot/queueengine.py:
159         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
160         * Scripts/webkitpy/tool/commands/download.py:
161         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
162         * Scripts/webkitpy/tool/commands/queries.py:
163         * Scripts/webkitpy/tool/commands/queues.py:
164         * Scripts/webkitpy/tool/commands/sheriffbot.py:
165         * Scripts/webkitpy/tool/comments.py:
166         * Scripts/webkitpy/tool/grammar.py:
167         * Scripts/webkitpy/tool/multicommandtool.py:
168         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
169
170 2010-03-25  Simon Fraser  <simon.fraser@apple.com>
171
172         Reviewed by Darin Adler, Alexey Proskuryakov.
173
174         https://bugs.webkit.org/show_bug.cgi?id=36631
175         Allow the test plugin to run scripts in response to NPP_SetWindow calls
176         
177         Hook up the ability for the TestNetscapePlugIn to run JavaScript in
178         response to NPP_SetWindow.
179         
180         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
181         (pluginAllocate):
182         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
183         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
184         (NPP_New):
185         (NPP_Destroy):
186         (NPP_SetWindow):
187
188 2010-03-25  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
189
190         Unreviewed, build fix.
191
192         [Qt] Fix QtLauncher guards.
193
194         * QtLauncher/main.cpp:
195         (LauncherWindow::showFPS):
196         (LauncherWindow::updateFPS):
197
198 2010-03-25  Yury Semikhatsky  <yurys@chromium.org>
199
200         Reviewed by Pavel Feldman.
201
202         Allow running tests with enabled developer extras and closed Web Inspector. Tests that have inspector-enabled/ in their path/url will have developer extras enabled.
203
204         https://bugs.webkit.org/show_bug.cgi?id=36610
205
206         * DumpRenderTree/LayoutTestController.h:
207         * DumpRenderTree/gtk/DumpRenderTree.cpp:
208         (shouldEnableDeveloperExtras):
209         (runTest):
210         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
211         (LayoutTestController::setJavaScriptProfilingEnabled):
212         (LayoutTestController::setDeveloperExtrasEnabled):
213         (LayoutTestController::showWebInspector):
214         (LayoutTestController::closeWebInspector):
215         * DumpRenderTree/mac/DumpRenderTree.mm:
216         (shouldEnableDeveloperExtras):
217         (runTest):
218         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
219         (LayoutTestController::setJavaScriptProfilingEnabled):
220         (LayoutTestController::setDeveloperExtrasEnabled):
221         (LayoutTestController::showWebInspector):
222         (LayoutTestController::closeWebInspector):
223         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
224         (WebCore::shouldEnableDeveloperExtras):
225         (WebCore::DumpRenderTree::open):
226         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
227         (LayoutTestController::closeWebInspector):
228         (LayoutTestController::setDeveloperExtrasEnabled):
229         (LayoutTestController::showWebInspector):
230         (LayoutTestController::setJavaScriptProfilingEnabled):
231         * DumpRenderTree/win/DumpRenderTree.cpp:
232         (shouldEnableDeveloperExtras):
233         (runTest):
234         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
235         (LayoutTestController::setJavaScriptProfilingEnabled):
236         (LayoutTestController::setDeveloperExtrasEnabled):
237         (LayoutTestController::showWebInspector):
238         (LayoutTestController::closeWebInspector):
239
240 2010-03-25  Adam Barth  <abarth@webkit.org>
241
242         Rubber stamped by Eric Seidel.
243
244         Tweaks to sheriffbot to improve latency by keeping the working copy up
245         to date even when there's no build break.  Also, officially move
246         sheriffbot to #webkit.
247
248         (Also teach ValidateReviewer to understand rubber stamps.)
249
250         * Scripts/webkitpy/common/net/irc/ircbot.py:
251         * Scripts/webkitpy/tool/commands/sheriffbot.py:
252         * Scripts/webkitpy/tool/steps/validatereviewer.py:
253
254 2010-03-22  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
255
256         Reviewed by Simon Hausmann.
257
258         Not displaying FPS info on the terminal. On S60 and Maemo the
259         Window title will be used and Status bar will used on desktop.
260
261         [Qt] QtLauncher's FPS info should not be displayed on the terminal
262         https://bugs.webkit.org/show_bug.cgi?id=36244
263
264         * QtLauncher/main.cpp:
265         (LauncherWindow::initializeView):
266         (LauncherWindow::showFPS):
267         (LauncherWindow::updateFPS):
268         * QtLauncher/webview.cpp:
269         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
270         (WebViewGraphicsBased::updateFrameRate):
271         * QtLauncher/webview.h:
272         (WebViewGraphicsBased::frameRateMeasurementEnabled):
273
274 2010-03-25  Diego Gonzalez  <diego.gonzalez@openbossa.org>
275
276         Reviewed by Kenneth Christiansen.
277
278         Added missing frame flattening activation on
279         fast/frames/flattening/frameset-flattening-grid.html;
280         removed unnecessary CONSOLE MESSAGE from the expected file;
281         reset the setFrameSetFlatteningEnabled for each test.
282
283         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
284         (WebCore::WebPage::resetSettings):
285
286 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
287
288         Reviewed by Adam Barth.
289
290         Moved deprecated_logging unit test import statement from
291         webkitpy/unittests.py to webkitpy/common/system/unittests.py.
292
293         https://bugs.webkit.org/show_bug.cgi?id=36093
294
295         This is part of the master bug to reorganize webkitpy.
296
297         * Scripts/webkitpy/common/system/unittests.py:
298         * Scripts/webkitpy/unittests.py:
299
300 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
301
302         Reviewed by Adam Barth.
303
304         Moved webkit_logging.py to common/system/deprecated_logging.py
305         inside webkitpy.
306
307         https://bugs.webkit.org/show_bug.cgi?id=36093
308
309         This is part of the master bug to reorganize webkitpy.
310
311         * Scripts/validate-committer-lists:
312         * Scripts/webkitpy/common/checkout/changelog.py:
313         * Scripts/webkitpy/common/checkout/scm.py:
314         * Scripts/webkitpy/common/net/bugzilla.py:
315         * Scripts/webkitpy/common/net/buildbot.py:
316         * Scripts/webkitpy/common/net/credentials.py:
317         * Scripts/webkitpy/common/net/irc/ircproxy.py:
318         * Scripts/webkitpy/common/net/networktransaction.py:
319         * Scripts/webkitpy/common/net/statusserver.py:
320         * Scripts/webkitpy/common/system/deprecated_logging.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging.py.
321         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging_unittest.py.
322         * Scripts/webkitpy/common/system/executive.py:
323         * Scripts/webkitpy/tool/bot/queueengine.py:
324         * Scripts/webkitpy/tool/commands/download.py:
325         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
326         * Scripts/webkitpy/tool/commands/openbugs.py:
327         * Scripts/webkitpy/tool/commands/queries.py:
328         * Scripts/webkitpy/tool/commands/queues.py:
329         * Scripts/webkitpy/tool/commands/sheriffbot.py:
330         * Scripts/webkitpy/tool/commands/stepsequence.py:
331         * Scripts/webkitpy/tool/commands/upload.py:
332         * Scripts/webkitpy/tool/main.py:
333         * Scripts/webkitpy/tool/mocktool.py:
334         * Scripts/webkitpy/tool/multicommandtool.py:
335         * Scripts/webkitpy/tool/steps/abstractstep.py:
336         * Scripts/webkitpy/tool/steps/applypatch.py:
337         * Scripts/webkitpy/tool/steps/build.py:
338         * Scripts/webkitpy/tool/steps/checkstyle.py:
339         * Scripts/webkitpy/tool/steps/closebug.py:
340         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
341         * Scripts/webkitpy/tool/steps/confirmdiff.py:
342         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
343         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
344         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
345         * Scripts/webkitpy/tool/steps/preparechangelog.py:
346         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
347         * Scripts/webkitpy/tool/steps/runtests.py:
348         * Scripts/webkitpy/tool/steps/update.py:
349         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
350         * Scripts/webkitpy/tool/steps/validatereviewer.py:
351         * Scripts/webkitpy/unittests.py:
352         * Scripts/webkitpy/webkit_logging.py: Removed.
353         * Scripts/webkitpy/webkit_logging_unittest.py: Removed.
354
355 2010-03-25  Julien Chaffraix  <jchaffraix@webkit.org>
356
357         Reviewed by Kenneth Rohde Christiansen.
358
359         commit-log-editor can call itself in an infinite loop
360         https://bugs.webkit.org/show_bug.cgi?id=35291
361
362         if $editor ends up being commit-log-editor, the script will exec itself
363         in an infinite loop.
364
365         To avoid this, we now check that the $editor variable is not
366         commit-log-editor to avoid this case.
367
368         * Scripts/commit-log-editor: Added an isCommitLogEditor method and
369         reworked the $editor setting to add this check.
370
371 2010-03-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
372
373         Reviewed by Kenneth Rohde Christiansen.
374
375         Add a Toggle Frame Flattening option to QtLauncher.
376         It will be enabled by default on Maemo5 and S60 platforms.
377
378         [Qt] Add enable/disable Frame Flattening option to QtLauncher
379         https://bugs.webkit.org/show_bug.cgi?id=36558
380
381         * QtLauncher/main.cpp:
382         (LauncherWindow::applyPrefs):
383         (LauncherWindow::toggleFrameFlattening):
384         (LauncherWindow::createChrome):
385
386 2010-03-25  Zoltan Horvath  <zoltan@webkit.org>
387
388         Reviewed by Eric Seidel.
389
390         svn-create-patch prints a warning for large patches
391         https://bugs.webkit.org/show_bug.cgi?id=32582
392
393         svn-create-patch prints a warning message for larger patches than 20k.
394
395         * Scripts/svn-create-patch:
396
397 2010-03-25  Adam Barth  <abarth@webkit.org>
398
399         Unreviewed.  Renamed early_warning_system.py to earlywarningsystem.py.
400         https://bugs.webkit.org/show_bug.cgi?id=36093
401
402         * Scripts/webkitpy/tool/commands/early_warning_system.py: Removed.
403         * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py: Removed.
404         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system.py.
405         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system_unittest.py.
406         * Scripts/webkitpy/tool/main.py:
407         * Scripts/webkitpy/tool/unittests.py:
408
409 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
410
411         Reviewed by Adam Barth.
412
413         In webkitpy, pushed the unit test import statements in
414         webkitpy/unittests.py into appropriate unittests.py files in the
415         new root-level packages beneath webkitpy.
416
417         https://bugs.webkit.org/show_bug.cgi?id=36093
418
419         This is part of the master bug to reorganize webkitpy.
420
421         * Scripts/webkitpy/common/system/unittests.py:
422         * Scripts/webkitpy/common/unittests.py: Added.
423         * Scripts/webkitpy/python24/unittests.py: Added.
424         * Scripts/webkitpy/tool/unittests.py: Added.
425         * Scripts/webkitpy/unittests.py:
426
427 2010-03-25  Adam Barth  <abarth@webkit.org>
428
429         Unreviewed.  Move WebKitCheckout into the webkitpy.common.checkout
430         package.
431         https://bugs.webkit.org/show_bug.cgi?id=36093
432
433         * Scripts/webkitpy/common/checkout/api.py: Copied from Scripts/webkitpy/webkitcheckout.py.
434         * Scripts/webkitpy/tool/main.py:
435         * Scripts/webkitpy/tool/mocktool.py:
436         * Scripts/webkitpy/webkitcheckout.py: Removed.
437
438 2010-03-25  Adam Barth  <abarth@webkit.org>
439
440         Unreviewed.  Move OutputCapture to webkitpy.common.system.
441         https://bugs.webkit.org/show_bug.cgi?id=36093
442
443         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
444         * Scripts/webkitpy/common/net/credentials_unittest.py:
445         * Scripts/webkitpy/common/system/outputcapture.py: Copied from Scripts/webkitpy/outputcapture.py.
446         * Scripts/webkitpy/outputcapture.py: Removed.
447         * Scripts/webkitpy/tool/commands/commandtest.py:
448         * Scripts/webkitpy/tool/commands/queues_unittest.py:
449         * Scripts/webkitpy/tool/commands/queuestest.py:
450         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
451         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
452         * Scripts/webkitpy/tool/steps/steps_unittest.py:
453         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
454
455 2010-03-25  Adam Barth  <abarth@webkit.org>
456
457         Unreviewed.  Move user.py to webkitpy.common.system.
458
459         * Scripts/webkitpy/common/checkout/scm.py:
460         * Scripts/webkitpy/common/net/bugzilla.py:
461         * Scripts/webkitpy/common/net/credentials.py:
462         * Scripts/webkitpy/common/system/user.py: Copied from Scripts/webkitpy/user.py.
463         * Scripts/webkitpy/common/system/user_unittest.py: Copied from Scripts/webkitpy/user_unittest.py.
464         * Scripts/webkitpy/tool/commands/upload.py:
465         * Scripts/webkitpy/tool/main.py:
466         * Scripts/webkitpy/unittests.py:
467         * Scripts/webkitpy/user.py: Removed.
468         * Scripts/webkitpy/user_unittest.py: Removed.
469
470 2010-03-25  Adam Barth  <abarth@webkit.org>
471
472         Unreviewed.  Move executive.py to webkitpy.common.system.
473         https://bugs.webkit.org/show_bug.cgi?id=36093
474
475         * Scripts/webkitpy/common/checkout/scm.py:
476         * Scripts/webkitpy/common/checkout/scm_unittest.py:
477         * Scripts/webkitpy/common/config/ports.py:
478         * Scripts/webkitpy/common/config/ports_unittest.py:
479         * Scripts/webkitpy/common/net/credentials.py:
480         * Scripts/webkitpy/common/net/credentials_unittest.py:
481         * Scripts/webkitpy/common/system/executive.py: Copied from Scripts/webkitpy/executive.py.
482         * Scripts/webkitpy/common/system/executive_unittest.py: Copied from Scripts/webkitpy/executive_unittest.py.
483         * Scripts/webkitpy/executive.py: Removed.
484         * Scripts/webkitpy/executive_unittest.py: Removed.
485         * Scripts/webkitpy/layout_tests/port/mac.py:
486         * Scripts/webkitpy/tool/bot/queueengine.py:
487         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
488         * Scripts/webkitpy/tool/commands/download.py:
489         * Scripts/webkitpy/tool/commands/early_warning_system.py:
490         * Scripts/webkitpy/tool/commands/queues.py:
491         * Scripts/webkitpy/tool/commands/stepsequence.py:
492         * Scripts/webkitpy/tool/main.py:
493         * Scripts/webkitpy/tool/steps/checkstyle.py:
494         * Scripts/webkitpy/tool/steps/preparechangelog.py:
495         * Scripts/webkitpy/unittests.py:
496         * Scripts/webkitpy/webkit_logging_unittest.py:
497
498 2010-03-25  Adam Barth  <abarth@webkit.org>
499
500         Unreviewed.  Move grammary.py into webkitpy.tool.
501         https://bugs.webkit.org/show_bug.cgi?id=36093
502
503         * Scripts/webkitpy/grammar.py: Removed.
504         * Scripts/webkitpy/grammar_unittest.py: Removed.
505         * Scripts/webkitpy/tool/commands/download.py:
506         * Scripts/webkitpy/tool/commands/queries.py:
507         * Scripts/webkitpy/tool/commands/queues.py:
508         * Scripts/webkitpy/tool/commands/upload.py:
509         * Scripts/webkitpy/tool/grammar.py: Copied from Scripts/webkitpy/grammar.py.
510         * Scripts/webkitpy/tool/grammar_unittest.py: Copied from Scripts/webkitpy/grammar_unittest.py.
511         * Scripts/webkitpy/tool/multicommandtool.py:
512         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
513         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
514         * Scripts/webkitpy/unittests.py:
515
516 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
517
518         Reviewed by Adam Barth.
519
520         In webkitpy, moved init/ to common/system/.
521
522         https://bugs.webkit.org/show_bug.cgi?id=36093
523
524         This is part of the master bug to reorganize webkitpy.
525
526         * Scripts/webkitpy/common/system: Copied from WebKitTools/Scripts/webkitpy/init.
527         * Scripts/webkitpy/common/system/logutils.py:
528         * Scripts/webkitpy/common/system/logutils_unittest.py:
529         * Scripts/webkitpy/init: Removed.
530         * Scripts/webkitpy/init/__init__.py: Removed.
531         * Scripts/webkitpy/init/logtesting.py: Removed.
532         * Scripts/webkitpy/init/logutils.py: Removed.
533         * Scripts/webkitpy/init/logutils_unittest.py: Removed.
534         * Scripts/webkitpy/init/unittests.py: Removed.
535         * Scripts/webkitpy/python24/versioning_unittest.py:
536         * Scripts/webkitpy/style_references.py:
537         * Scripts/webkitpy/unittests.py:
538
539 2010-03-25  Adam Barth  <abarth@webkit.org>
540
541         Unreviewed.  Move stepsequence to webkitpy.tool.commands.
542         https://bugs.webkit.org/show_bug.cgi?id=36093
543
544         * Scripts/webkitpy/stepsequence.py: Removed.
545         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
546         * Scripts/webkitpy/tool/commands/download.py:
547         * Scripts/webkitpy/tool/commands/queues.py:
548         * Scripts/webkitpy/tool/commands/stepsequence.py: Copied from Scripts/webkitpy/stepsequence.py.
549
550 2010-03-25  Adam Barth  <abarth@webkit.org>
551
552         Unreviewed.  Create webkitpy.common.checkout as described in
553         https://bugs.webkit.org/show_bug.cgi?id=36093
554
555         * Scripts/webkitpy/changelogs.py: Removed.
556         * Scripts/webkitpy/changelogs_unittest.py: Removed.
557         * Scripts/webkitpy/commitinfo.py: Removed.
558         * Scripts/webkitpy/commitinfo_unittest.py: Removed.
559         * Scripts/webkitpy/common/checkout: Added.
560         * Scripts/webkitpy/common/checkout/__init__.py: Copied from Scripts/webkitpy/common/__init__.py.
561         * Scripts/webkitpy/common/checkout/changelog.py: Copied from Scripts/webkitpy/changelogs.py.
562         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Copied from Scripts/webkitpy/changelogs_unittest.py.
563         * Scripts/webkitpy/common/checkout/commitinfo.py: Copied from Scripts/webkitpy/commitinfo.py.
564         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: Copied from Scripts/webkitpy/commitinfo_unittest.py.
565         * Scripts/webkitpy/common/checkout/diff_parser.py: Copied from Scripts/webkitpy/diff_parser.py.
566         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Copied from Scripts/webkitpy/diff_parser_unittest.py.
567         * Scripts/webkitpy/common/checkout/scm.py: Copied from Scripts/webkitpy/scm.py.
568         * Scripts/webkitpy/common/checkout/scm_unittest.py: Copied from Scripts/webkitpy/scm_unittest.py.
569         * Scripts/webkitpy/common/net/credentials.py:
570         * Scripts/webkitpy/diff_parser.py: Removed.
571         * Scripts/webkitpy/diff_parser_unittest.py: Removed.
572         * Scripts/webkitpy/layout_tests/port/base.py:
573         * Scripts/webkitpy/scm.py: Removed.
574         * Scripts/webkitpy/scm_unittest.py: Removed.
575         * Scripts/webkitpy/stepsequence.py:
576         * Scripts/webkitpy/style_references.py:
577         * Scripts/webkitpy/tool/commands/download.py:
578         * Scripts/webkitpy/tool/commands/queries.py:
579         * Scripts/webkitpy/tool/comments.py:
580         * Scripts/webkitpy/tool/main.py:
581         * Scripts/webkitpy/tool/mocktool.py:
582         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
583         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
584         * Scripts/webkitpy/tool/steps/validatereviewer.py:
585         * Scripts/webkitpy/unittests.py:
586         * Scripts/webkitpy/webkitcheckout.py:
587
588 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
589
590         Reviewed by Adam Barth.
591
592         In webkitpy, moved init/versioning.py to python24/.
593
594         https://bugs.webkit.org/show_bug.cgi?id=36093
595
596         This is part of the master bug to reorganize webkitpy.
597
598         * Scripts/test-webkitpy:
599         * Scripts/webkit-patch:
600         * Scripts/webkitpy/init/unittests.py:
601         * Scripts/webkitpy/init/versioning.py: Removed.
602         * Scripts/webkitpy/init/versioning_unittest.py: Removed.
603         * Scripts/webkitpy/python24: Added.
604         * Scripts/webkitpy/python24/__init__.py: Copied from WebKitTools/Scripts/webkitpy/tool/__init__.py.
605         * Scripts/webkitpy/python24/versioning.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning.py.
606         * Scripts/webkitpy/python24/versioning_unittest.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning_unittest.py.
607         * Scripts/webkitpy/unittests.py:
608
609 2010-03-25  Adam Barth  <abarth@webkit.org>
610
611         Unreviewed.
612
613         Create webkitpy.common.net as described in
614         https://bugs.webkit.org/show_bug.cgi?id=36093
615
616         * Scripts/webkitpy/bugzilla.py: Removed.
617         * Scripts/webkitpy/bugzilla_unittest.py: Removed.
618         * Scripts/webkitpy/buildbot.py: Removed.
619         * Scripts/webkitpy/buildbot_unittest.py: Removed.
620         * Scripts/webkitpy/commitinfo.py:
621         * Scripts/webkitpy/common/net: Added.
622         * Scripts/webkitpy/common/net/__init__.py: Added.
623         * Scripts/webkitpy/common/net/bugzilla.py: Copied from Scripts/webkitpy/bugzilla.py.
624         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Copied from Scripts/webkitpy/bugzilla_unittest.py.
625         * Scripts/webkitpy/common/net/buildbot.py: Copied from Scripts/webkitpy/buildbot.py.
626         * Scripts/webkitpy/common/net/buildbot_unittest.py: Copied from Scripts/webkitpy/buildbot_unittest.py.
627         * Scripts/webkitpy/common/net/credentials.py: Copied from Scripts/webkitpy/credentials.py.
628         * Scripts/webkitpy/common/net/credentials_unittest.py: Copied from Scripts/webkitpy/credentials_unittest.py.
629         * Scripts/webkitpy/common/net/irc: Copied from Scripts/webkitpy/irc.
630         * Scripts/webkitpy/common/net/irc/ircbot.py:
631         * Scripts/webkitpy/common/net/irc/ircproxy.py:
632         * Scripts/webkitpy/common/net/irc/messagepump_unittest.py:
633         * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py:
634         * Scripts/webkitpy/common/net/irc/unittests.py:
635         * Scripts/webkitpy/common/net/networktransaction.py: Copied from Scripts/webkitpy/networktransaction.py.
636         * Scripts/webkitpy/common/net/networktransaction_unittest.py: Copied from Scripts/webkitpy/networktransaction_unittest.py.
637         * Scripts/webkitpy/common/net/statusserver.py: Copied from Scripts/webkitpy/statusserver.py.
638         * Scripts/webkitpy/credentials.py: Removed.
639         * Scripts/webkitpy/credentials_unittest.py: Removed.
640         * Scripts/webkitpy/irc: Removed.
641         * Scripts/webkitpy/irc/__init__.py: Removed.
642         * Scripts/webkitpy/irc/ircbot.py: Removed.
643         * Scripts/webkitpy/irc/ircproxy.py: Removed.
644         * Scripts/webkitpy/irc/messagepump.py: Removed.
645         * Scripts/webkitpy/irc/messagepump_unittest.py: Removed.
646         * Scripts/webkitpy/irc/threadedmessagequeue.py: Removed.
647         * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Removed.
648         * Scripts/webkitpy/irc/unittests.py: Removed.
649         * Scripts/webkitpy/networktransaction.py: Removed.
650         * Scripts/webkitpy/networktransaction_unittest.py: Removed.
651         * Scripts/webkitpy/scm_unittest.py:
652         * Scripts/webkitpy/statusserver.py: Removed.
653         * Scripts/webkitpy/tool/bot/queueengine.py:
654         * Scripts/webkitpy/tool/commands/download.py:
655         * Scripts/webkitpy/tool/commands/queries.py:
656         * Scripts/webkitpy/tool/commands/queries_unittest.py:
657         * Scripts/webkitpy/tool/commands/queues.py:
658         * Scripts/webkitpy/tool/commands/queues_unittest.py:
659         * Scripts/webkitpy/tool/commands/queuestest.py:
660         * Scripts/webkitpy/tool/commands/upload.py:
661         * Scripts/webkitpy/tool/main.py:
662         * Scripts/webkitpy/tool/mocktool.py:
663         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
664         * Scripts/webkitpy/unittests.py:
665
666 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
667
668         Reviewed by Adam Barth.
669
670         In webkitpy, renamed MockBugzillaTool to MockTool.
671
672         * Scripts/webkitpy/tool/commands/commandtest.py:
673         * Scripts/webkitpy/tool/commands/queries_unittest.py:
674         * Scripts/webkitpy/tool/commands/queues_unittest.py:
675         * Scripts/webkitpy/tool/commands/queuestest.py:
676         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
677         * Scripts/webkitpy/tool/commands/upload_unittest.py:
678         * Scripts/webkitpy/tool/mocktool.py:
679         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
680         * Scripts/webkitpy/tool/steps/steps_unittest.py:
681         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
682
683 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
684
685         Reviewed by Adam Barth.
686
687         In Scripts/webkitpy, moved webkitport.py and committers.py into
688         common/config/ (also creating common/config/).
689
690         https://bugs.webkit.org/show_bug.cgi?id=36093
691
692         This is part of the master bug to reorganize webkitpy.
693
694         * Scripts/validate-committer-lists:
695         * Scripts/webkitpy/bugzilla.py:
696         * Scripts/webkitpy/bugzilla_unittest.py:
697         * Scripts/webkitpy/changelogs.py:
698         * Scripts/webkitpy/commitinfo.py:
699         * Scripts/webkitpy/commitinfo_unittest.py:
700         * Scripts/webkitpy/committers.py: Removed.
701         * Scripts/webkitpy/committers_unittest.py: Removed.
702         * Scripts/webkitpy/common: Added.
703         * Scripts/webkitpy/common/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py.
704         * Scripts/webkitpy/common/config: Added.
705         * Scripts/webkitpy/common/config/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py.
706         * Scripts/webkitpy/common/config/committers.py: Copied from WebKitTools/Scripts/webkitpy/committers.py.
707         * Scripts/webkitpy/common/config/committers_unittest.py: Copied from WebKitTools/Scripts/webkitpy/committers_unittest.py.
708         * Scripts/webkitpy/common/config/ports.py: Copied from WebKitTools/Scripts/webkitpy/webkitport.py.
709         * Scripts/webkitpy/common/config/ports_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkitport_unittest.py.
710         * Scripts/webkitpy/mock_bugzillatool.py:
711         * Scripts/webkitpy/tool/commands/early_warning_system.py:
712         * Scripts/webkitpy/tool/commands/queries.py:
713         * Scripts/webkitpy/tool/commands/sheriffbot.py:
714         * Scripts/webkitpy/tool/commands/upload.py:
715         * Scripts/webkitpy/tool/steps/abstractstep.py:
716         * Scripts/webkitpy/unittests.py:
717         * Scripts/webkitpy/webkitport.py: Removed.
718         * Scripts/webkitpy/webkitport_unittest.py: Removed.
719
720 2010-03-25  Adam Barth  <abarth@webkit.org>
721
722         Unreviewed.  Move mock_bugzillatool.py to tool/mocktool.py.
723
724         * Scripts/webkitpy/mock_bugzillatool.py: Removed.
725         * Scripts/webkitpy/tool/commands/commandtest.py:
726         * Scripts/webkitpy/tool/commands/queries_unittest.py:
727         * Scripts/webkitpy/tool/commands/queues_unittest.py:
728         * Scripts/webkitpy/tool/commands/queuestest.py:
729         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
730         * Scripts/webkitpy/tool/commands/upload_unittest.py:
731         * Scripts/webkitpy/tool/mocktool.py: Copied from Scripts/webkitpy/mock_bugzillatool.py.
732         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
733         * Scripts/webkitpy/tool/steps/steps_unittest.py:
734         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
735
736 2010-03-24  Adam Barth  <abarth@webkit.org>
737
738         Unreviewed.  Move comments.py and multicommandtool.py to their new
739         home.
740
741         * Scripts/webkitpy/comments.py: Removed.
742         * Scripts/webkitpy/multicommandtool.py: Removed.
743         * Scripts/webkitpy/multicommandtool_unittest.py: Removed.
744         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
745         * Scripts/webkitpy/tool/commands/download.py:
746         * Scripts/webkitpy/tool/commands/openbugs.py:
747         * Scripts/webkitpy/tool/commands/queries.py:
748         * Scripts/webkitpy/tool/commands/queues.py:
749         * Scripts/webkitpy/tool/commands/upload.py:
750         * Scripts/webkitpy/tool/comments.py: Copied from Scripts/webkitpy/comments.py.
751         * Scripts/webkitpy/tool/main.py:
752         * Scripts/webkitpy/tool/multicommandtool.py: Copied from Scripts/webkitpy/multicommandtool.py.
753         * Scripts/webkitpy/tool/multicommandtool_unittest.py: Copied from Scripts/webkitpy/multicommandtool_unittest.py.
754         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
755         * Scripts/webkitpy/tool/steps/closepatch.py:
756         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
757         * Scripts/webkitpy/unittests.py:
758
759 2010-03-24  Adam Barth  <abarth@webkit.org>
760
761         Unreviewed.  Fixup one import statement I didn't find because the .pyc
762         masked the error.
763
764         * Scripts/webkitpy/stepsequence.py:
765
766 2010-03-24  Adam Barth  <abarth@webkit.org>
767
768         Unreviewed.  Move queueengine.py to its new home.
769
770         * Scripts/webkitpy/queueengine.py: Removed.
771         * Scripts/webkitpy/queueengine_unittest.py: Removed.
772         * Scripts/webkitpy/tool/bot/queueengine.py: Copied from Scripts/webkitpy/queueengine.py.
773         * Scripts/webkitpy/tool/bot/queueengine_unittest.py: Copied from Scripts/webkitpy/queueengine_unittest.py.
774         * Scripts/webkitpy/tool/commands/early_warning_system.py:
775         * Scripts/webkitpy/tool/commands/queues.py:
776         * Scripts/webkitpy/unittests.py:
777
778 2010-03-24  Adam Barth  <abarth@webkit.org>
779
780         Unreviewed.  Move patchcollection.py to its new home.
781
782         * Scripts/webkitpy/patchcollection.py: Removed.
783         * Scripts/webkitpy/patchcollection_unittest.py: Removed.
784         * Scripts/webkitpy/tool/bot: Added.
785         * Scripts/webkitpy/tool/bot/__init__.py: Added.
786         * Scripts/webkitpy/tool/bot/patchcollection.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection.py.
787         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection_unittest.py.
788         * Scripts/webkitpy/tool/commands/queues.py:
789         * Scripts/webkitpy/unittests.py:
790
791 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
792
793         Reviewed by Adam Barth.
794
795         In Scripts/webkitpy, moved steps_references.py and the steps
796         folder into webkitpy/patch.
797
798         https://bugs.webkit.org/show_bug.cgi?id=36093
799
800         * Scripts/webkitpy/steps: Removed.
801         * Scripts/webkitpy/steps/__init__.py: Removed.
802         * Scripts/webkitpy/steps/abstractstep.py: Removed.
803         * Scripts/webkitpy/steps/applypatch.py: Removed.
804         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Removed.
805         * Scripts/webkitpy/steps/build.py: Removed.
806         * Scripts/webkitpy/steps/checkstyle.py: Removed.
807         * Scripts/webkitpy/steps/cleanworkingdirectory.py: Removed.
808         * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Removed.
809         * Scripts/webkitpy/steps/closebug.py: Removed.
810         * Scripts/webkitpy/steps/closebugforlanddiff.py: Removed.
811         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Removed.
812         * Scripts/webkitpy/steps/closepatch.py: Removed.
813         * Scripts/webkitpy/steps/commit.py: Removed.
814         * Scripts/webkitpy/steps/confirmdiff.py: Removed.
815         * Scripts/webkitpy/steps/createbug.py: Removed.
816         * Scripts/webkitpy/steps/editchangelog.py: Removed.
817         * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Removed.
818         * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Removed.
819         * Scripts/webkitpy/steps/metastep.py: Removed.
820         * Scripts/webkitpy/steps/obsoletepatches.py: Removed.
821         * Scripts/webkitpy/steps/options.py: Removed.
822         * Scripts/webkitpy/steps/postdiff.py: Removed.
823         * Scripts/webkitpy/steps/postdiffforcommit.py: Removed.
824         * Scripts/webkitpy/steps/postdiffforrevert.py: Removed.
825         * Scripts/webkitpy/steps/preparechangelog.py: Removed.
826         * Scripts/webkitpy/steps/preparechangelogforrevert.py: Removed.
827         * Scripts/webkitpy/steps/promptforbugortitle.py: Removed.
828         * Scripts/webkitpy/steps/reopenbugafterrollout.py: Removed.
829         * Scripts/webkitpy/steps/revertrevision.py: Removed.
830         * Scripts/webkitpy/steps/runtests.py: Removed.
831         * Scripts/webkitpy/steps/steps_unittest.py: Removed.
832         * Scripts/webkitpy/steps/update.py: Removed.
833         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Removed.
834         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Removed.
835         * Scripts/webkitpy/steps/validatereviewer.py: Removed.
836         * Scripts/webkitpy/steps_references.py: Removed.
837         * Scripts/webkitpy/stepsequence.py:
838         * Scripts/webkitpy/tool/commands/download.py:
839         * Scripts/webkitpy/tool/commands/upload.py:
840         * Scripts/webkitpy/tool/steps: Copied from WebKitTools/Scripts/webkitpy/steps.
841         * Scripts/webkitpy/tool/steps/__init__.py:
842         * Scripts/webkitpy/tool/steps/applypatch.py:
843         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
844         * Scripts/webkitpy/tool/steps/build.py:
845         * Scripts/webkitpy/tool/steps/checkstyle.py:
846         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
847         * Scripts/webkitpy/tool/steps/cleanworkingdirectorywithlocalcommits.py:
848         * Scripts/webkitpy/tool/steps/closebug.py:
849         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
850         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
851         * Scripts/webkitpy/tool/steps/closepatch.py:
852         * Scripts/webkitpy/tool/steps/commit.py:
853         * Scripts/webkitpy/tool/steps/confirmdiff.py:
854         * Scripts/webkitpy/tool/steps/createbug.py:
855         * Scripts/webkitpy/tool/steps/editchangelog.py:
856         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
857         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
858         * Scripts/webkitpy/tool/steps/metastep.py:
859         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
860         * Scripts/webkitpy/tool/steps/postdiff.py:
861         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
862         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
863         * Scripts/webkitpy/tool/steps/preparechangelog.py:
864         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
865         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
866         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
867         * Scripts/webkitpy/tool/steps/revertrevision.py:
868         * Scripts/webkitpy/tool/steps/runtests.py:
869         * Scripts/webkitpy/tool/steps/steps_unittest.py:
870         * Scripts/webkitpy/tool/steps/update.py:
871         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
872         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
873         * Scripts/webkitpy/tool/steps/validatereviewer.py:
874         * Scripts/webkitpy/tool/steps_references.py: Copied from WebKitTools/Scripts/webkitpy/steps_references.py.
875         * Scripts/webkitpy/unittests.py:
876
877 2010-03-24  Eric Seidel  <eric@webkit.org>
878
879         Unreviewed, build fix only.
880
881         Abstract LayoutTestResults logic for easier reuse
882         https://bugs.webkit.org/show_bug.cgi?id=36579
883
884         * Scripts/webkitpy/buildbot_unittest.py: Add a missing import.
885
886 2010-03-24  Adam Barth  <abarth@webkit.org>
887
888         Unreviewed.  Fix a stray comma to test landing an patch without review.
889
890         * Scripts/webkitpy/commitinfo.py:
891
892 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
893
894         Reviewed by Adam Barth.
895
896         In Scripts/webkitpy, moved commands_references.py and the commands
897         folder into webkitpy/patch.
898
899         https://bugs.webkit.org/show_bug.cgi?id=36483
900
901         This is part of master bug 36093 to organize webkitpy.
902
903         * Scripts/webkitpy/commands: Removed.
904         * Scripts/webkitpy/commands/__init__.py: Removed.
905         * Scripts/webkitpy/commands/abstractsequencedcommand.py: Removed.
906         * Scripts/webkitpy/commands/commandtest.py: Removed.
907         * Scripts/webkitpy/commands/download.py: Removed.
908         * Scripts/webkitpy/commands/download_unittest.py: Removed.
909         * Scripts/webkitpy/commands/early_warning_system.py: Removed.
910         * Scripts/webkitpy/commands/early_warning_system_unittest.py: Removed.
911         * Scripts/webkitpy/commands/openbugs.py: Removed.
912         * Scripts/webkitpy/commands/openbugs_unittest.py: Removed.
913         * Scripts/webkitpy/commands/queries.py: Removed.
914         * Scripts/webkitpy/commands/queries_unittest.py: Removed.
915         * Scripts/webkitpy/commands/queues.py: Removed.
916         * Scripts/webkitpy/commands/queues_unittest.py: Removed.
917         * Scripts/webkitpy/commands/queuestest.py: Removed.
918         * Scripts/webkitpy/commands/sheriffbot.py: Removed.
919         * Scripts/webkitpy/commands/sheriffbot_unittest.py: Removed.
920         * Scripts/webkitpy/commands/upload.py: Removed.
921         * Scripts/webkitpy/commands/upload_unittest.py: Removed.
922         * Scripts/webkitpy/commands_references.py: Removed.
923         * Scripts/webkitpy/tool/commands: Copied from WebKitTools/Scripts/webkitpy/commands.
924         * Scripts/webkitpy/tool/commands/commandtest.py:
925         * Scripts/webkitpy/tool/commands/download.py:
926         * Scripts/webkitpy/tool/commands/download_unittest.py:
927         * Scripts/webkitpy/tool/commands/early_warning_system.py:
928         * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py:
929         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
930         * Scripts/webkitpy/tool/commands/queries_unittest.py:
931         * Scripts/webkitpy/tool/commands/queues_unittest.py:
932         * Scripts/webkitpy/tool/commands/queuestest.py:
933         * Scripts/webkitpy/tool/commands/sheriffbot.py:
934         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
935         * Scripts/webkitpy/tool/commands/upload.py:
936         * Scripts/webkitpy/tool/commands/upload_unittest.py:
937         * Scripts/webkitpy/tool/commands_references.py: Copied from WebKitTools/Scripts/webkitpy/commands_references.py.
938         * Scripts/webkitpy/tool/main.py:
939         * Scripts/webkitpy/unittests.py:
940
941 2010-03-24  Adam Barth  <abarth@webkit.org>
942
943         Reviewed by Eric Seidel.
944
945         Rename webkitpy.patch to webkitpy.tool
946         https://bugs.webkit.org/show_bug.cgi?id=36580
947
948         This is in preparation for the great webkitpy naming cleanup.
949
950         * Scripts/webkit-patch:
951         * Scripts/webkitpy/patch: Removed.
952         * Scripts/webkitpy/patch/__init__.py: Removed.
953         * Scripts/webkitpy/patch/patcher.py: Removed.
954         * Scripts/webkitpy/tool: Copied from WebKitTools/Scripts/webkitpy/patch.
955         * Scripts/webkitpy/tool/main.py: Copied from WebKitTools/Scripts/webkitpy/patch/patcher.py.
956         * Scripts/webkitpy/tool/patcher.py: Removed.
957
958 2010-03-24  Eric Seidel  <eric@webkit.org>
959
960         Reviewed by Adam Barth.
961
962         Abstract LayoutTestResults logic for easier reuse
963         https://bugs.webkit.org/show_bug.cgi?id=36579
964
965         * Scripts/webkitpy/buildbot.py:
966          - Split out logic into new LayoutTestResults class.
967         * Scripts/webkitpy/buildbot_unittest.py:
968          - Rename the testing class to match.
969         * Scripts/webkitpy/commands/queries.py:
970          - Use the new LayoutTestResults class.
971
972 2010-03-24  Eric Seidel  <eric@webkit.org>
973
974         Reviewed by Eric Seidel.
975
976         Move Bugzilla.prompt_for_component to User.prompt_with_list for re-use
977         https://bugs.webkit.org/show_bug.cgi?id=36577
978
979         * Scripts/webkitpy/bugzilla.py:
980          - Move prompt_for_component to User
981         * Scripts/webkitpy/commands/queries.py:
982          - Add a missing argument_names declaration.
983         * Scripts/webkitpy/user.py:
984          - Add prompt_with_list
985          - Make staticmethods classmethods for easier mocking
986
987 2010-03-24  David Kilzer  <ddkilzer@apple.com>
988
989         <http://webkit.org/b/36572> commit-log-editor: thinks mergeChangeLogs.pl is a ChangeLog file
990
991         Reviewed by Eric Seidel.
992
993         Fixes the following error when committing a file with
994         "ChangeLog" in the name that isn't a ChangeLog (like
995         mergeChangeLogs.pl from r56471 and r56472):
996
997             $ git commit .
998             Can't open WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLog at commit-log-editor line 132.
999             error: There was a problem with the editor 'commit-log-editor'.
1000             Please supply the message using either -m or -F option.
1001
1002         * Scripts/commit-log-editor: Added '$' to anchor "ChangeLog" to
1003         the end of the file name when searching for ChangeLog files in a
1004         commit.
1005
1006 2010-03-24  David Kilzer  <ddkilzer@apple.com>
1007
1008         <http://webkit.org/b/36570> resolve-ChangeLogs: fall back to git-merge-file if ChangeLog can't be merged
1009
1010         Reviewed by Eric Seidel.
1011
1012         * Scripts/resolve-ChangeLogs: Switched to exec git-merge-file if
1013         the merge attempt fails.
1014
1015 2010-03-24  Adam Barth  <abarth@webkit.org>
1016
1017         Reviewed by Eric Seidel.
1018
1019         webkit-patch or pre-commit hook should validate reviewer lines before committing
1020         https://bugs.webkit.org/show_bug.cgi?id=26927
1021
1022         Validate that patches have valid reivewers listed in their ChangeLogs
1023         before landing.  For patches without reviewers can be landed if their
1024         ChangeLogs state that they are unreviewed.
1025
1026         * Scripts/webkitpy/changelogs.py:
1027         * Scripts/webkitpy/commands/download.py:
1028         * Scripts/webkitpy/commitinfo.py:
1029         * Scripts/webkitpy/commitinfo_unittest.py:
1030         * Scripts/webkitpy/mock_bugzillatool.py:
1031         * Scripts/webkitpy/steps/__init__.py:
1032         * Scripts/webkitpy/steps/validatereviewer.py: Added.
1033
1034 2010-03-19  Holger Hans Peter Freyther  <zecke@selfish.org>
1035
1036         Reviewed by David Levin.
1037
1038         Undefined names reported by pyflakes in python scripts
1039         https://bugs.webkit.org/show_bug.cgi?id=36403
1040
1041         Attempt to use names that exist or can exist in the lexical
1042         scope instead of not being available at all.
1043
1044         * Scripts/webkitpy/changelogs.py: Use self._content.
1045         * Scripts/webkitpy/layout_tests/port/base.py: Use os.stat
1046         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Use self._port
1047         * Scripts/webkitpy/style/processors/cpp_unittest.py: Use expected_message_re
1048
1049 2010-03-24  David Kilzer  <ddkilzer@apple.com>
1050
1051         <http://webkit.org/b/36560> resolve-ChangeLogs: git-rebase fails when resolve-ChangeLogs can't merge
1052
1053         Reviewed by Eric Seidel.
1054
1055         When resolve-ChangeLogs fails to merge a patch while running as
1056         a git merge driver, it deletes the original file, which causes
1057         an internal failure and stops git mid-merge:
1058
1059             fatal: Failed to execute internal merge
1060
1061         The fix is to use the --force switch with patch so that it will
1062         always attempt to apply the patch.  (The change in
1063         mergeChangeLogs() for the previous commit also fixed this, but
1064         adding --force also prevents any potential user interaction that
1065         patch may want to display.)
1066
1067         * Scripts/VCSUtils.pm:
1068         (mergeChangeLogs): Added --force switch to patch command.  Also
1069         changed to use the exit status from the patch command to
1070         determine the return value for this method.
1071         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added
1072         test to cover this bug.
1073
1074 2010-03-24  David Kilzer  <ddkilzer@apple.com>
1075
1076         <http://webkit.org/b/36560> resolve-ChangeLogs: move mergeChanges() into VCSUtils package
1077
1078         Reviewed by Eric Seidel.
1079
1080         * Scripts/VCSUtils.pm:
1081         (mergeChangeLogs): Copied from mergeChanges() in
1082         resolve-ChangeLogs and renamed.  Added method documentation.
1083         Fixed bug found by new tests where the original file to be
1084         patched was deleted when cleaning up after a traditinal rejected
1085         patch failed to apply.
1086         * Scripts/resolve-ChangeLogs: Switched to using
1087         mergeChangeLogs().
1088         (mergeChanges): Moved to VCSUtils.pm and renamed to
1089         mergeChangeLogs().
1090         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added.
1091
1092 2010-03-24  Eric Seidel  <eric@webkit.org>
1093
1094         Reviewed by Adam Barth.
1095
1096         Add support for qt's unassigned list to webkit-patch assign-to-committer
1097         https://bugs.webkit.org/show_bug.cgi?id=36559
1098
1099         * Scripts/webkitpy/bugzilla.py:
1100          - Move Bugzilla.unassigned_email into Bug and make it a set.
1101         * Scripts/webkitpy/bugzilla_unittest.py:
1102          - Test the new Bug.is_unassigned method
1103         * Scripts/webkitpy/commands/upload.py:
1104          - Use the new Bug.is_unassigned method instead of an explicit ==
1105         * Scripts/webkitpy/mock_bugzillatool.py:
1106          - Bugzilla.unassigned_email no longer needs mocking
1107
1108 2010-03-24  Kent Hansen  <kent.hansen@nokia.com>
1109
1110         Reviewed by Simon Hausmann.
1111
1112         [Qt] Rename QWebSettings::XSSAuditorEnabled to XSSAuditingEnabled
1113         https://bugs.webkit.org/show_bug.cgi?id=36522
1114
1115         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1116         (LayoutTestController::setXSSAuditorEnabled): Use the new name.
1117
1118 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
1119
1120         Reviewed by Shinichiro Hamaji.
1121
1122         Added to check-webkit-style support for a --debug flag.
1123
1124         https://bugs.webkit.org/show_bug.cgi?id=36100
1125
1126         The --debug flag adjusts the logging level to DEBUG and
1127         includes the logger name and level in each log message.
1128
1129         * Scripts/check-webkit-style:
1130           - Changed the code to check for the --debug flag and pass
1131             the result to the configure_logging() method.
1132         * Scripts/webkitpy/style/checker.py:
1133           - Added an is_debug parameter to configure_logging().
1134           - Refactored configure_logging() by adding calls to
1135             the following two methods: _create_log_handlers() and
1136             _create_debug_log_handlers().
1137         * Scripts/webkitpy/style/checker_unittest.py:
1138           - Added unit tests for configure_logging() with is_debug True
1139             by splitting the ConfigureLoggingTest class into
1140             ConfigureLoggingTest and ConfigureLoggingTestBase, and
1141             adding ConfigureLoggingDebugTest.
1142         * Scripts/webkitpy/style/optparser.py:
1143           - Updated the usage string.
1144           - Added an is_debug data attribute to the CommandOptionValues
1145             class.
1146           - Added support for the --debug flag to the ArgumentParser.parse()
1147             method.
1148           - Also added extra error information to the parse() method in
1149             the case of an invalid flag.
1150         * Scripts/webkitpy/style/optparser_unittest.py:
1151           - Updated the unit tests as necessary.
1152           - Also fixed an issue with the CommandOptionValuesTest.test_eq()
1153             unit test.
1154
1155 2010-03-23  Kent Tamura  <tkent@chromium.org>
1156
1157         Reviewed by Dimitri Glazkov.
1158
1159         [DRT/Chromium] Add TestNavigationController and TestWebWorker
1160         https://bugs.webkit.org/show_bug.cgi?id=36489
1161
1162         Add TestNavigationController and TestWebWorker classes, which are
1163         going to be used by DumpRenderTree Chromium port. These files are
1164         based on:
1165         - src/webkit/tools/test_shell/test_navigation_controller.{cc,h}
1166         - src/webkit/tools/test_shell/test_web_worker.h
1167         of Chromium rev.40492.
1168
1169         TestNavigationController has non-style changes.
1170         - Change ContentState type: binary string -> WebHistoryItem
1171         - Remove TestShell dependency by introducing NavigationHost interface.
1172
1173         * DumpRenderTree/chromium/TestNavigationController.cpp: Added.
1174         * DumpRenderTree/chromium/TestNavigationController.h: Added.
1175         * DumpRenderTree/chromium/TestWebWorker.h: Added.
1176
1177 2010-03-23  Eric Seidel  <eric@webkit.org>
1178
1179         Reviewed by Adam Barth.
1180
1181         Add support for revision -> build lookup in buildbot.py and layout test result parsing
1182         https://bugs.webkit.org/show_bug.cgi?id=36474
1183
1184         * Scripts/webkitpy/bugzilla_unittest.py: Added a FIXME about sharing code.
1185         * Scripts/webkitpy/buildbot.py: 
1186          - Add support for looking up builds by revision number.
1187          - Add support for fetching and parsing results.html files from buildbot.
1188          - build_for_revision has an allow_failed_lookups option to work around the fact that
1189            our buildbot's xmlrpc calls return failure on old revision numbers.
1190          - Add parsing support for twisted directory listings.
1191         * Scripts/webkitpy/buildbot_unittest.py:
1192          - Unit test all the new code.
1193         * Scripts/webkitpy/commands/queries.py:
1194          - Add a new results-for command which prints all the results for a given revision (very slow due to slow revision lookup)
1195
1196 2010-03-23  Daniel Bates  <dbates@rim.com>
1197
1198         Reviewed by Adam Roben.
1199
1200         https://bugs.webkit.org/show_bug.cgi?id=36048
1201
1202         Detect if the Windows Platform SDK is missing when building with
1203         Visual C++ Express Edition and inform the user to download it.
1204
1205         * Scripts/webkitdirs.pm:
1206
1207 2010-03-23  Darin Adler  <darin@apple.com>
1208
1209         Tell Subversion about more directories that expect to have .pyc files.
1210
1211         * Scripts/webkitpy: Modified property svn:ignore.
1212         * Scripts/webkitpy/irc: Added property svn:ignore.
1213
1214 2010-03-23  Daniel Bates  <dbates@rim.com>
1215
1216         Reviewed by Adam Barth.
1217
1218         https://bugs.webkit.org/show_bug.cgi?id=36149
1219
1220         Import the GNU readline interface to modify the behavior
1221         of raw_input so as to provide line editing support. In
1222         particular this will prevent "delete" characters from
1223         appearing in the returned value for function raw_input.
1224
1225         * Scripts/webkitpy/user.py:
1226
1227 2010-03-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1228
1229         Reviewed by Kenneth Rohde Christiansen.
1230
1231         [Qt] Remove support for Qt v4.4
1232         https://bugs.webkit.org/show_bug.cgi?id=36389
1233
1234         * DumpRenderTree/qt/main.cpp:
1235         (main):
1236         * QtLauncher/mainwindow.cpp:
1237         (MainWindow::MainWindow):
1238
1239 2010-03-22  Csaba Osztrogonác  <ossy@webkit.org>
1240
1241         Reviewed by Adam Barth.
1242
1243         Make build_webkit_command() pass MAKEFLAGS environment variable to make.
1244         https://bugs.webkit.org/show_bug.cgi?id=36440
1245
1246         * Scripts/webkitpy/webkitport.py:
1247         * Scripts/webkitpy/webkitport_unittest.py:
1248
1249 2010-03-22  Dirk Pranke  <dpranke@chromium.org>
1250
1251         Reviewed by Dimitri Glazkov.
1252
1253         Change baseline_path() to point to the upstream locations for the
1254         Chromium ports. Also change the reabselining scripts to use the
1255         correct functions to get the baseline directories, and fix the
1256         script's sys.path to pull in simplejson correctly.
1257
1258         https://bugs.webkit.org/show_bug.cgi?id=36417
1259
1260         * Scripts/rebaseline-chromium-webkit-tests:
1261           - fix sys.path to pick up simplejson properly
1262         * Scripts/webkitpy/layout_tests/port/chromium.py:
1263           - change baseline_path() to use webkit_baseline_path()
1264           - error out correctly if we can't find the chromium base dir
1265         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1266           - call baseline_path(), not chromium_baseline_path()
1267
1268 2010-03-22  Chris Jerdonek  <cjerdonek@webkit.org>
1269
1270         Reviewed by Adam Barth.
1271
1272         Refactored the cpu_count() code in executive.py.
1273
1274         https://bugs.webkit.org/show_bug.cgi?id=36437
1275
1276         * Scripts/webkitpy/executive.py:
1277           - Moved the import of the multiprocessing module to the top
1278             of the file rather than importing from within a function.
1279
1280 2010-03-22 Antonio Gomes <tonikitoo@webkit.org>
1281
1282         Unreviewed.
1283
1284         Rolling out r56183: http://trac.webkit.org/changeset/56183
1285
1286         https://bugs.webkit.org/show_bug.cgi?id=36244
1287
1288         Need to roll out because this patch will be re-worked by the author
1289         and other reviewers agreed on it.
1290
1291 2010-03-22  Chris Jerdonek  <cjerdonek@webkit.org>
1292
1293         Reviewed by Adam Barth.
1294
1295         Created a function for getting a module-specific logging.logger
1296         based on the __file__ value of the module.
1297
1298         https://bugs.webkit.org/show_bug.cgi?id=35821
1299
1300         This function allows us to get the module-specific logger for
1301         a module without having to hard-code the fully-qualified name
1302         of the module in the module itself.  The code can be the same
1303         in every case: "_log = logutils.get_logger(__file__)".
1304
1305         * Scripts/webkitpy/init/logutils.py: Added.
1306           - Added a module with a get_logger() function to return
1307             a module-specific logger based on the module's __file__
1308             variable.
1309
1310         * Scripts/webkitpy/init/logutils_unittest.py: Added.
1311           - Added unit tests for logutils.py.
1312
1313         * Scripts/webkitpy/init/unittests.py:
1314           - Added logutils_unittest to the list of imports.
1315
1316 2010-03-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1317
1318         Reviewed by Simon Hausmann.
1319
1320         [Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
1321         https://bugs.webkit.org/show_bug.cgi?id=36386
1322
1323         Fix the regression by implementing a null printer for Qt DRT.
1324
1325         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1326         (WebCore::NullPrinter::NullPaintEngine::begin):
1327         (WebCore::NullPrinter::NullPaintEngine::end):
1328         (WebCore::NullPrinter::NullPaintEngine::type):
1329         (WebCore::NullPrinter::NullPaintEngine::drawPixmap):
1330         (WebCore::NullPrinter::NullPaintEngine::updateState):
1331         (WebCore::NullPrinter::paintEngine):
1332         (WebCore::DumpRenderTree::dryRunPrint):
1333
1334 2010-03-20  Martin Robinson  <mrobinson@webkit.org>
1335
1336         Reviewed by Xan Lopez.
1337
1338         [GTK] eventSender.zoomPageOut() bug?
1339         https://bugs.webkit.org/show_bug.cgi?id=30575
1340
1341         Make zoomPage{In/Out}Callback respect the 1.2f zoom factor that DRT should be using.
1342
1343         * DumpRenderTree/gtk/EventSender.cpp:
1344         (zoomIn): Added.
1345         (zoomOut): Added.
1346         (textZoomInCallback): Use zoomIn helper function.
1347         (textZoomOutCallback): Use zoomOut helper function.
1348         (zoomPageInCallback): Use zoomIn helper function, which respects zoom factor.
1349         (zoomPageOutCallback): Use zoomOut helper function, which respects zoom factor.
1350
1351 2010-03-20  Kevin Ollivier  <kevino@theolliviers.com>
1352
1353         [wx] Build fix after recent database API change.
1354
1355         * wx/browser/browser.cpp:
1356         (MyApp::OnInit):
1357
1358 2010-03-20  Chris Jerdonek  <cjerdonek@webkit.org>
1359
1360         Reviewed by Adam Barth.
1361
1362         Renamed UnitTestLogStream to TestLogStream in webkitpy.
1363
1364         https://bugs.webkit.org/show_bug.cgi?id=36099
1365
1366         TestLogStream is more concise and more consistent with the name of
1367         the module (logtesting rather than logunittesting) and its main
1368         class (LogTesting rather than LogUnitTesting).
1369
1370         * Scripts/webkitpy/init/logtesting.py:
1371           - Renamings.
1372
1373         * Scripts/webkitpy/style/checker_unittest.py:
1374           - Renamings.
1375
1376         * Scripts/webkitpy/style_references.py:
1377           - Renamings.
1378
1379 2010-03-20  Kevin Ollivier  <kevino@theolliviers.com>
1380
1381         [wx] Build fixes for new method in LayoutTestController.
1382
1383         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1384         (LayoutTestController::setSpatialNavigationEnabled):
1385         * wx/build/settings.py:
1386
1387 2010-03-20  Dimitri Glazkov  <dglazkov@chromium.org>
1388
1389         Unreviewed, tool fix.
1390
1391         Remove vestiges of downstream directory names to unbreak rebaselining tool.
1392
1393         * Scripts/webkitpy/layout_tests/port/chromium.py: Changed paths to use WebKit repo.
1394
1395 2010-03-20  Dirk Pranke  <dpranke@chromium.org>
1396
1397         Reviewed by Dimitri Glazkov.
1398
1399         Re-enable the downstream test_expectations overrides file that was
1400         disabled in bug 36396 / r56287.
1401
1402         https://bugs.chromium.org/show_bug.cgi?id=36401
1403
1404         * Scripts/webkitpy/layout_tests/port/chromium.py:
1405
1406 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
1407
1408         Reviewed by Dimitri Glazkov.
1409
1410         Disable the downstream override expectations temporarily to allow
1411         us to test that we've upstreamed everything correctly. Also, stop
1412         looking at the downstream baselines at all (now you will only be
1413         able to update baselines upstream). In theory this should work, but
1414         if we need to we can always add the downstream dirs back in.
1415
1416         https://bugs.webkit.org/show_bug.cgi?id=36396
1417
1418         * Scripts/webkitpy/layout_tests/port/chromium.py:
1419         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1420         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1421         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1422
1423 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
1424
1425         Reviewed by Dimitri Glazkov.
1426
1427         fix typo in chromium test expectations overrides routine
1428         https://bugs.webkit.org/show_bug.cgi?id=36397
1429
1430         * Scripts/webkitpy/layout_tests/port/chromium.py:
1431
1432 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
1433
1434         Reviewed by Dimitri Glazkov.
1435
1436         Flip the Chromium ports to look first for the test expectations
1437         in LayoutTests/platform/chromium and only afterwards look in the
1438         Chromium repo downstream for overrides.
1439
1440         https://bugs.webkit.org/show_bug.cgi?id=36326
1441
1442         * Scripts/webkitpy/layout_tests/port/chromium.py:
1443
1444 2010-03-19  James Hawkins  <jhawkins@chromium.org>
1445
1446         Unreviewed.
1447
1448         Add myself to the committers list.
1449
1450         * Scripts/webkitpy/committers.py:
1451
1452 2010-03-19  Adam Barth  <abarth@webkit.org>
1453
1454         Unreviewed.
1455
1456         Fix SheriffBot exception lock when we can't retrieve the first build
1457         from buildbot.  (I'll ask Eric to review this change after the fact,
1458         but he's at lunch and I want to get the bot unlocked.)
1459
1460         * Scripts/webkitpy/buildbot.py:
1461         * Scripts/webkitpy/buildbot_unittest.py:
1462
1463 2010-03-19  Alexey Proskuryakov  <ap@apple.com>
1464
1465         Reviewed by Darin Adler.
1466
1467         https://bugs.webkit.org/show_bug.cgi?id=36380
1468         websocket/tests/frame-lengths.html times out on Tiger bot
1469
1470         https://bugs.webkit.org/show_bug.cgi?id=35041
1471         websocket/tests/frame-lengths.html / websocket/tests/simple-stress.html fail on Windows bot
1472
1473         Double the timeout (from 15 seconds to 30 seconds). We can increase it more, if necessary -
1474         sampling the DRT process on Mac OS X takes much longer anyway, so it's better to avoid
1475         timing out than to detect it early.
1476
1477         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1478         (LayoutTestController::setWaitToDump):
1479         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1480         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1481         (LayoutTestController::waitUntilDone):
1482         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1483         * Scripts/run-webkit-tests:
1484
1485 2010-03-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1486
1487         Unreviewed.
1488
1489         Buildfix for Qt v4.5.
1490
1491         * QtLauncher/main.cpp:
1492         (LauncherWindow::LauncherWindow):
1493         (LauncherWindow::applyZoom):
1494
1495 2010-03-19  Adam Barth  <abarth@webkit.org>
1496
1497         Reviewed by Eric Seidel.
1498
1499         Operational tweaks to SheriffBot
1500         https://bugs.webkit.org/show_bug.cgi?id=36385
1501
1502         These changes aren't pretty, but they're helpful to make SheriffBot
1503         work operationally.  I plan to iterate in these areas, but I wanted to
1504         get this patch landed so I could be running the bot against TOT.
1505
1506         * Scripts/webkitpy/commands/sheriffbot.py:
1507         * Scripts/webkitpy/irc/ircbot.py:
1508         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py:
1509
1510 2010-03-19  Eric Seidel  <eric@webkit.org>
1511
1512         Reviewed by Adam Barth.
1513
1514         Help sheriff-bot avoid warning about flaky tests (and add more unit testing)
1515         https://bugs.webkit.org/show_bug.cgi?id=36354
1516
1517         * Scripts/webkitpy/buildbot.py:
1518          - Make Build creation easier to Mock and test
1519         * Scripts/webkitpy/buildbot_unittest.py:
1520          - Test finding green to red transitions and suspect revisions
1521         * Scripts/webkitpy/commands/queries.py:
1522          - Make what-broke note when builders have only failed once.
1523
1524 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
1525
1526         Reviewed by Dimitri Glazkov.
1527
1528         Fix the rebaselining tool, which was broken by r36324 when I
1529         added the concept of overridding expectations.
1530
1531         https://bugs.webkit.org/show_bug.cgi?id=36374
1532
1533         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1534
1535 2010-03-19  Adam Barth  <abarth@webkit.org>
1536
1537         Reviewed by Eric Seidel.
1538
1539         Misc bug fixes to make the SheriffBot actually work
1540         https://bugs.webkit.org/show_bug.cgi?id=36355
1541
1542         With these changes, I can actually run the sheriff-bot from start to
1543         finish.
1544
1545         * Scripts/webkitpy/irc/ircproxy.py:
1546         * Scripts/webkitpy/patch/patcher.py:
1547         * Scripts/webkitpy/statusserver.py:
1548
1549 2010-03-19  Adam Barth  <abarth@webkit.org>
1550
1551         Unreviewed.
1552
1553         Actually import the sheriff-bot command so we can run it.  Also, move
1554         the bot to #webkit-test so it doesn't cause a ruckus while we test it.
1555
1556         * Scripts/webkitpy/patch/patcher.py:
1557         * Scripts/webkitpy/irc/ircbot.py:
1558
1559 2010-03-19  Adam Barth  <abarth@webkit.org>
1560
1561         Reviewed by Eric Seidel.
1562
1563         Second cut at SheriffBot
1564         https://bugs.webkit.org/show_bug.cgi?id=36353
1565
1566         This patch should contain a complete SheriffBot that's capable of
1567         saying reasonable things on IRC.  I had to refactor the use of
1568         CommitInfo to make the SheriffBot testable, but I did the minimum
1569         necessary.  We should grow webkitcheckout over time to contain the
1570         knowledge of ChangeLogs from scm.
1571
1572         * Scripts/webkitpy/commands/sheriffbot.py:
1573         * Scripts/webkitpy/commands/sheriffbot_unittest.py:
1574         * Scripts/webkitpy/mock_bugzillatool.py:
1575         * Scripts/webkitpy/patch/patcher.py:
1576         * Scripts/webkitpy/webkitcheckout.py: Added.
1577
1578 2010-03-19  Adam Barth  <abarth@webkit.org>
1579
1580         Unreviewed.
1581
1582         Fix Hyatt's IRC nickname.
1583
1584         * Scripts/webkitpy/committers.py:
1585
1586 2010-03-19  Adam Barth  <abarth@webkit.org>
1587
1588         Unreviewed.
1589
1590         Add IRC nicknames for the non-reviewer committers.
1591
1592         * Scripts/webkitpy/committers.py:
1593
1594 2010-03-19  Adam Barth  <abarth@webkit.org>
1595
1596         Unreviewed.
1597
1598         More reviewer IRC nicknames.
1599
1600         * Scripts/webkitpy/committers.py:
1601
1602 2010-03-19  Adam Barth  <abarth@webkit.org>
1603
1604         Unreviewed.
1605
1606         Add a bunch of IRC nicknames for reviewers.
1607
1608         * Scripts/webkitpy/committers.py:
1609
1610 2010-03-19  Zoltan Horvath  <zoltan@webkit.org>
1611
1612         Reviewed by Oliver Hunt.
1613
1614         Added USE_SYSTEM_MALLOC flag to build-webkit
1615         https://bugs.webkit.org/show_bug.cgi?id=21272
1616
1617         Add system-alloc flag to build-webkit. It makes easy to switch
1618         between system allocator and TCmalloc.
1619
1620         * Scripts/build-webkit:
1621
1622 2010-03-19  Adam Barth  <abarth@webkit.org>
1623
1624         Unreviewed "build" fix.
1625
1626         Of course, I caused a regression in the file that isn't tested.  :(
1627
1628         * Scripts/webkitpy/statusserver.py:
1629
1630 2010-03-19  Eric Seidel  <eric@webkit.org>
1631
1632         Reviewed by Adam Barth.
1633
1634         Add basic "who-broke-it" command and revision -> broken builder association code
1635         https://bugs.webkit.org/show_bug.cgi?id=36352
1636
1637         The "what-broke" command prints builders and what revisions we suspect
1638         broke them.  who-broke-it prints revisions and what builders we suspect
1639         they broke.  The sheriff-bot needs this revision to broken builder mapping
1640         so this change adds it!
1641
1642         * Scripts/webkitpy/buildbot.py:
1643         * Scripts/webkitpy/commands/queries.py:
1644
1645 2010-03-19  Eric Seidel  <eric@webkit.org>
1646
1647         Reviewed by Adam Barth.
1648
1649         Simplify BuildBot core builder code for easier re-use
1650         https://bugs.webkit.org/show_bug.cgi?id=36350
1651
1652         I simply couldn't see anything through all this Yak-hair.
1653
1654         * Scripts/webkitpy/buildbot.py:
1655         * Scripts/webkitpy/commands/queries.py:
1656
1657 2010-03-19  Adam Barth  <abarth@webkit.org>
1658
1659         Reviewed by Eric Seidel.
1660
1661         committers.py should know IRC nicknames
1662         https://bugs.webkit.org/show_bug.cgi?id=36349
1663
1664         I'll add the actual nicknames in another patch.
1665
1666         * Scripts/webkitpy/committers.py:
1667         * Scripts/webkitpy/committers_unittest.py:
1668
1669 2010-03-18  Anders Bakken  <agbakken@gmail.com>
1670
1671         Reviewed by Simon Hausmann.
1672
1673         https://bugs.webkit.org/show_bug.cgi?id=36318
1674
1675         QtLauncher runs as a GuiClient by default in Qt Embedded which will
1676         make it try to connect to an existing GuiServer. This patch makes it
1677         run like a stand-alone app.
1678
1679         * QtLauncher/main.cpp:
1680         (LauncherApplication::LauncherApplication):
1681
1682 2010-03-19  Eric Seidel  <eric@webkit.org>
1683
1684         Reviewed by Adam Barth.
1685
1686         Move find_green_to_red_transition out of "what-broke" onto Builder for easier re-use
1687         https://bugs.webkit.org/show_bug.cgi?id=36345
1688
1689         * Scripts/webkitpy/buildbot.py:
1690         * Scripts/webkitpy/commands/queries.py:
1691
1692 2010-03-19  Adam Barth  <abarth@webkit.org>
1693
1694         Reviewed by Adam Barth.
1695
1696         Actually pass the IRC password to the IRC object
1697         https://bugs.webkit.org/show_bug.cgi?id=36346
1698
1699         I wanted to do this before, but both patches were in flight.  This
1700         patch finally closes the loop and makes the IRCProxy system complete.
1701
1702         * Scripts/webkitpy/patch/patcher.py:
1703
1704 2010-03-18  Adam Barth  <abarth@webkit.org>
1705
1706         Reviewed by Eric Seidel.
1707
1708         Add a StatusServer front end to the SVNRevision table on QueueStatusServer
1709         https://bugs.webkit.org/show_bug.cgi?id=36344
1710
1711         No test because Browser was too hard to mock.  :(  I couldn't figure
1712         out how to make Mock be a dictionary as well as an object.
1713
1714         * Scripts/webkitpy/statusserver.py:
1715
1716 2010-03-18  Eric Seidel  <eric@webkit.org>
1717
1718         Reviewed by Adam Barth.
1719
1720         Split out CommitInfo class and add unit tests
1721         https://bugs.webkit.org/show_bug.cgi?id=36343
1722
1723         Move more logic out of "what-broke" into a shared CommitInfo
1724         class so that it can be used by other commands and unit tested.
1725
1726         * Scripts/webkitpy/commands/queries.py:
1727         * Scripts/webkitpy/commitinfo.py: Added.
1728         * Scripts/webkitpy/commitinfo_unittest.py: Added.
1729         * Scripts/webkitpy/unittests.py:
1730
1731 2010-03-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1732
1733         Reviewed by Kenneth Rohde Christiansen.
1734
1735         [Qt] Fix LayoutTests/http/tests/appcache/max-size.html
1736         https://bugs.webkit.org/show_bug.cgi?id=36207
1737
1738         Implement setAppCacheMaximumSize() for Qt.
1739
1740         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1741         (LayoutTestController::setAppCacheMaximumSize):
1742         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1743
1744 2010-03-18  Adam Barth  <abarth@webkit.org>
1745
1746         Reviewed by Eric Seidel.
1747
1748         QueueStatusServer should be able to log broken bots
1749         https://bugs.webkit.org/show_bug.cgi?id=36341
1750
1751         We need to add a new table to the QueueStatusServer to store persistent
1752         information for the SheriffBot.  The new table will keep track of which
1753         bots each SVN revision broke.
1754
1755         * QueueStatusServer/handlers/__init__.py:
1756         * QueueStatusServer/handlers/svnrevision.py: Added.
1757         * QueueStatusServer/handlers/updatebase.py: Added.
1758         * QueueStatusServer/handlers/updatestatus.py:
1759         * QueueStatusServer/handlers/updatesvnrevision.py: Added.
1760         * QueueStatusServer/index.yaml:
1761         * QueueStatusServer/main.py:
1762         * QueueStatusServer/model/__init__.py:
1763         * QueueStatusServer/model/svnrevision.py: Added.
1764         * QueueStatusServer/templates/updatesvnrevision.html: Added.
1765
1766 2010-03-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1767
1768         Reviewed by Darin Adler.
1769
1770         Add a new method to the Qt LayoutTestController for
1771         changing media type and make the DRT support dry-run printing.
1772
1773         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1774         (WebCore::DumpRenderTree::DumpRenderTree):
1775         (WebCore::DumpRenderTree::dryRunPrint):
1776         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1777         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1778         (LayoutTestController::setMediaType):
1779         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1780
1781 2010-03-18  Dirk Pranke  <dpranke@chromium.org>
1782
1783         Reviewed by Dimitri Glazkov.
1784
1785         Add upstream LayoutTests/platform/chromium* directories to the
1786         baseline search path for new-run-webkit-tests in preparation for
1787         upstreaming all of the Chromium baselines. Note that this does
1788         not actually create the directories themselves, but that's okay.
1789
1790         https://bugs.webkit.org/show_bug.cgi?id=36324
1791
1792         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1793         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1794         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1795
1796 2010-03-18  Alexey Proskuryakov  <ap@apple.com>
1797
1798         Reviewed by Anders Carlsson.
1799
1800         https://bugs.webkit.org/show_bug.cgi?id=36327
1801         Test that a plug-in can override Node methods of its element
1802
1803         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1804         (normalizeOverride):
1805         (pluginInvoke):
1806         Override "normalize", and call back to let a test know that the plug-in was called.
1807
1808 2010-03-17  Dirk Pranke  <dpranke@chromium.org>
1809
1810         Reviewed by Dimitri Glazkov.
1811
1812         Add the concept of an "overrides" file for expectations so that we
1813         can store test_expectations both upstream and downstream for a port
1814         that runs both in webkit.org and in a separate repository (like
1815         Chromium). Also add some unit tests for the expectations module.
1816
1817         https://bugs.webkit.org/show_bug.cgi?id=36249
1818
1819         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1820         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py: Added.
1821         * Scripts/webkitpy/layout_tests/port/base.py:
1822         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1823
1824 2010-03-18  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1825
1826         Reviewed by Kenneth Rohde Christiansen.
1827
1828         Add an overlay QGraphicsTextItem to QtLauncher so we can display FPS info
1829         on the launcher and not on the terminal anymore.
1830
1831         [Qt] QtLauncher's FPS info should be displayed on an overlay text item
1832         https://bugs.webkit.org/show_bug.cgi?id=36244
1833
1834         * QtLauncher/webview.cpp:
1835         (WebViewGraphicsBased::WebViewGraphicsBased):
1836         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
1837         (WebViewGraphicsBased::updateFrameRate):
1838         * QtLauncher/webview.h:
1839
1840 2010-03-18  Adam Barth  <abarth@webkit.org>
1841
1842         Reviewed by Eric Seidel.
1843
1844         First cut at SheriffBot
1845         https://bugs.webkit.org/show_bug.cgi?id=36253
1846
1847         This patch contains a first attempt at writing a sheriff bot.
1848         Currently, we're missing the logic that actually finds the SVN revision
1849         numbers to complain about, but once we have that, we'll have the rest
1850         of the infrustructure to ping IRC and to file bugs.
1851
1852         There's a lot to fill in for the SheriffBot, but this patch give us the
1853         framework in which to do it.
1854
1855         This patch required a bit of refactoring of AbstractQueue because
1856         SheriffBot is the first bot that doesn't process patches (it processes
1857         SVN revisions).  Accordingly, I've factored out AbstractPatchQueue to
1858         hold the parts of AbstractQueue that are specific to dealing with
1859         patches.  Some of the choices here might not be obvious yet, but we can
1860         tweak them as our needs become clearer.
1861
1862         * Scripts/webkitpy/commands/queues.py:
1863         * Scripts/webkitpy/commands/queues_unittest.py:
1864         * Scripts/webkitpy/commands/sheriffbot.py: Added.
1865         * Scripts/webkitpy/commands/sheriffbot_unittest.py: Added.
1866         * Scripts/webkitpy/mock_bugzillatool.py:
1867             Added a MockIRC object to the mock tool.
1868         * Scripts/webkitpy/multicommandtool.py:
1869             Added a finalize method so the tool can disconnect from IRC
1870             cleanly instead of just droping the socket.
1871         * Scripts/webkitpy/multicommandtool_unittest.py:
1872         * Scripts/webkitpy/patch/patcher.py:
1873             Added support for talking to IRC.
1874         * Scripts/webkitpy/unittests.py:
1875             We should add a commands/unittests.py file at some point to make
1876             the commands module more self-contained.
1877
1878 2010-03-18  Antti Koivisto  <koivisto@iki.fi>
1879
1880         Reviewed by Kenneth Rohde Christiansen.
1881
1882         https://bugs.webkit.org/show_bug.cgi?id=36102
1883         [Qt] Scaling control API for tiled backing store
1884         
1885         Add animated smooth zooming to Qt launcher when in tiled mode.
1886
1887         * QtLauncher/main.cpp:
1888         (LauncherWindow::LauncherWindow):
1889         (LauncherWindow::zoomAnimationFinished):
1890         (LauncherWindow::applyZoom):
1891         (LauncherWindow::zoomIn):
1892         (LauncherWindow::zoomOut):
1893         * QtLauncher/webview.h:
1894         (WebViewGraphicsBased::graphicsWebView):
1895
1896 2010-03-18  Adam Barth  <abarth@webkit.org>
1897
1898         Reviewed by Eric Seidel.
1899
1900         Support using IRC accounts with a password
1901         https://bugs.webkit.org/show_bug.cgi?id=36287
1902
1903         Add a global option to specify an IRC password so we can use the
1904         sheriffbot account (which needs a password).
1905
1906         * Scripts/webkitpy/irc/ircbot.py:
1907         * Scripts/webkitpy/irc/ircproxy.py:
1908         * Scripts/webkitpy/patch/patcher.py:
1909
1910 2010-03-18  Eric Seidel  <eric@webkit.org>
1911
1912         Just fixing missing parenthesis typo, no review.
1913
1914         * Scripts/webkitpy/commands/queries.py: '%' has higher precedence than 'or', use parentheses.
1915
1916 2010-03-18  Alexey Proskuryakov  <ap@apple.com>
1917
1918         Reviewed by Adam Roben and Anders Carlsson.
1919
1920         https://bugs.webkit.org/show_bug.cgi?id=36210
1921         plugins/resize-from-plugin.html fails on some platforms
1922
1923         Turns out that most platforms don't use "cross-platform" main.cpp. Copied code added for
1924         the test to their versions of the file.
1925
1926         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1927         (webkit_test_plugin_set_window):
1928         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1929         (NPP_SetWindow):
1930
1931 2010-03-18  Leandro Pereira  <leandro@profusion.mobi>
1932
1933         Reviewed by Kenneth Rohde Christiansen.
1934
1935         Add support to run-launcher to open the EFL example browser.
1936         http://webkit.org/b/36181
1937
1938         * Scripts/webkitdirs.pm:
1939         * Scripts/run-launcher:
1940
1941 2010-03-18  Sergio Villar Senin  <svillar@igalia.com>
1942
1943         Reviewed by Xan Lopez.
1944
1945         [GTK] Failing tests http/tests/misc/image-blocked-src-change.html
1946         & http/tests/misc/image-blocked-src-no-change.html
1947         https://bugs.webkit.org/show_bug.cgi?id=36227
1948
1949         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1950         (webViewConsoleMessage): print only the file name instead of the
1951         whole URI when printing messages with local URI's
1952
1953 2010-03-18  Eric Seidel  <eric@webkit.org>
1954
1955         Reviewed by Adam Barth.
1956
1957         Teach what-broke how to look up reviewer and author Committer objects by name
1958         https://bugs.webkit.org/show_bug.cgi?id=36264
1959
1960         * Scripts/webkitpy/commands/queries.py:
1961          - Add committer_by_name lookups for both reviewer and author
1962          - Improve printing in the cases where lookups fail.
1963         * Scripts/webkitpy/committers.py:
1964          - Add committer_by_name
1965         * Scripts/webkitpy/committers_unittest.py:
1966          - Test committer_by_name
1967
1968 2010-03-17  Adam Barth  <abarth@webkit.org>
1969
1970         Reviewed by Eric Seidel.
1971
1972         create-rollout should actually fill out the description
1973         https://bugs.webkit.org/show_bug.cgi?id=36261
1974
1975         * Scripts/webkitpy/commands/download.py:
1976             The % operator was applied to the wrong string.
1977         * Scripts/webkitpy/commands/download_unittest.py:
1978         * Scripts/webkitpy/commands/upload_unittest.py:
1979         * Scripts/webkitpy/mock_bugzillatool.py:
1980             Add support for seeing what we actually do with create_bug.
1981
1982 2010-03-17  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1983
1984         Reviewed by Kenneth Rohde Christiansen.
1985
1986         Accelerated Compositing is now default on QtWebKit so the option
1987         in QtLauncher must be true as default.
1988
1989         [Qt] QtLauncher's Accelerated Compositing option must be true as default
1990         https://bugs.webkit.org/show_bug.cgi?id=36234
1991
1992         * QtLauncher/main.cpp:
1993         (LauncherWindow::applyPrefs):
1994         (LauncherWindow::toggleAcceleratedCompositing):
1995         (LauncherApplication::handleUserOptions):
1996
1997 2010-03-17  Adam Barth  <abarth@webkit.org>
1998
1999         Reviewed by Eric Seidel.
2000
2001         Commit queue should ignore (probably red) builders when landing rollouts
2002         https://bugs.webkit.org/show_bug.cgi?id=36169
2003
2004         When landing a rollout, the builders are probably red, so we need to
2005         ignore them in the subprocess too.  Also, we might as well update the
2006         working copy because we haven't validated anything about the current
2007         revision prior to trying to land.
2008
2009         This change is testable, but it requires changing the mock executive to
2010         log its arguments.  That will generate a lot of expectation changes, so
2011         I'd like to do that in a separate patch.
2012
2013         * Scripts/webkitpy/commands/queues.py:
2014
2015 2010-03-17  Chang Shu  <chang.shu@nokia.com>
2016
2017         Reviewed by Laszlo Gombos.
2018
2019         https://bugs.webkit.org/show_bug.cgi?id=36139
2020         [Qt] Clean up cache each time DumpRenderTree starts. This behavior 
2021         matches other platforms, such as mac and gtk.
2022
2023         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2024         (WebCore::DumpRenderTree::DumpRenderTree):
2025
2026 2010-03-17  Adam Barth  <abarth@webkit.org>
2027
2028         Unreviewed.
2029
2030         Turns out this needs to be a string.
2031
2032         * Scripts/webkitpy/bugzilla.py:
2033
2034 2010-03-17  Eric Seidel  <eric@webkit.org>
2035
2036         Reviewed by Adam Barth.
2037
2038         Add more infrastructure for sheriff-bot, including making what-broke more awesome
2039         https://bugs.webkit.org/show_bug.cgi?id=36254
2040
2041         * Scripts/webkitpy/bugzilla.py:
2042          - Made the various URL methods return None when passed None.
2043         * Scripts/webkitpy/bugzilla_unittest.py:
2044          - Test that the url methods work as expected.
2045         * Scripts/webkitpy/buildbot.py:
2046          - Add a static Build.build_url so that its possible to generate a build url without a Build object.
2047          - Give users a URL in _fetch_xmlrpc_build_dictionary error message.
2048         * Scripts/webkitpy/changelogs.py:
2049          - Add a new ChangeLogEntry class to encapsulate entry-parsing logic.
2050          - Add is_path_to_changelog to greatly simplify SCM.modified_changelogs code.
2051          - Make ChangeLog.parse_latest_entry_from_file a public method.
2052         * Scripts/webkitpy/changelogs_unittest.py:
2053          - Add tests for new ChangeLog entry parsing.
2054         * Scripts/webkitpy/commands/queries.py:
2055          - Make "what-broke" not print "ok" builders, only failing ones.
2056          - Print much more information on failing builders, including links and authorship/reviewer information.
2057         * Scripts/webkitpy/commands/queues_unittest.py:
2058          - Use a fake_checkout path since fixing the cwd (as part of fixing scm_unittests.py) was breaking tests.
2059         * Scripts/webkitpy/mock_bugzillatool.py:
2060          - Move MockSCM away from using os.getcwd() as that was fragile (and wrong).
2061         * Scripts/webkitpy/patch/patcher.py:
2062          - Remove code which was broken now that this file has moved.
2063          - Code was also redundant now that SCM.find_checkout_root() exists.
2064         * Scripts/webkitpy/scm.py:
2065          - Greatly simplify modified_changelogs now that I understand list comprehensions.
2066          - Expect ChangeLogEntry objects instead of raw strings.
2067          - Add changed_files_for_revision, committer_email_for_revision and contents_at_revision
2068          - Add commit_with_message argument to all sites since someone half-added it before. :(
2069          - Get rid of copy/paste code using _status_regexp()
2070         * Scripts/webkitpy/scm_unittest.py:
2071          - Fix these tests!
2072          - Add new tests for new scm code.
2073          - Fix spelling of "awsome" to "awesome".
2074
2075 2010-03-17  Daniel Bates  <dbates@rim.com>
2076
2077         Rubber-stamped by David Levin.
2078
2079         Add myself to the list of reviewers.
2080
2081         * Scripts/webkitpy/committers.py:
2082
2083 2010-03-17  Adam Barth  <abarth@webkit.org>
2084
2085         Reviewed by Eric Seidel.
2086
2087         Change post-rollout to create-rollout and have it make a new bug
2088         instead of posting the rollout to the old bug.
2089         https://bugs.webkit.org/show_bug.cgi?id=36250
2090
2091         The new bug blocks the old bug instead of adding more complexity to the
2092         old bug.  One tricky question is whether to create the bug if we're
2093         unable to create a rollout patch.  In this patch, we do create the bug,
2094         but we might revist this question in the future.
2095
2096         * Scripts/webkitpy/bugzilla.py:
2097         * Scripts/webkitpy/commands/download.py:
2098         * Scripts/webkitpy/commands/download_unittest.py:
2099         * Scripts/webkitpy/steps/createbug.py:
2100
2101 2010-03-17  Adam Barth  <abarth@webkit.org>
2102
2103         Reviewed by Eric Seidel.
2104
2105         Add a way for the bots to send messages to IRC
2106         https://bugs.webkit.org/show_bug.cgi?id=36235
2107
2108         We'll use these classes to notify #webkit about bad SVN revisions.
2109         This patch just has some skeleton code for us to play with.
2110
2111         * Scripts/webkitpy/irc/__init__.py: Added.
2112         * Scripts/webkitpy/irc/ircbot.py: Added.
2113             A bot that knows how to talk to IRC.
2114         * Scripts/webkitpy/irc/ircproxy.py: Added.
2115             We need to run the bot on its own thread because the irclib needs
2116             its own mainloop.  This class provides an abstraction of the
2117             threading.
2118         * Scripts/webkitpy/irc/messagepump.py: Added.
2119         * Scripts/webkitpy/irc/messagepump_unittest.py: Added.
2120         * Scripts/webkitpy/irc/threadedmessagequeue.py: Added.
2121             A thread-safe message queue for sending messages from the main
2122             thread to the IRC thread.
2123         * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Added.
2124         * Scripts/webkitpy/irc/unittests.py: Added.
2125         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py:
2126             Autoinstall irclib
2127         * Scripts/webkitpy/unittests.py:
2128
2129 2010-03-17  Victor Wang  <victorw@chromium.org>
2130
2131         Reviewed by Dimitri Glazkov.
2132
2133         Fix image_diff syntax in webkitpy/port/base.py.
2134         The syntax is wrong if diff_filename is specified.
2135
2136         https://bugs.webkit.org/show_bug.cgi?id=36230
2137
2138         * Scripts/webkitpy/layout_tests/port/base.py:
2139
2140 2010-03-16  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2141
2142         Reviewed by Kenneth Christiansen.
2143
2144         Provide to QtLauncher a way to change the ViewportUpdateMode
2145         when it's in graphics based mode.
2146
2147         [Qt] Make QtLaucher able to select the ViewportUpdateMode
2148         https://bugs.webkit.org/show_bug.cgi?id=36175
2149
2150         * QtLauncher/main.cpp:
2151         (LauncherWindow::selectViewportUpdateMode):
2152         (LauncherWindow::createChrome):
2153
2154 2010-03-17  Zoltan Horvath  <zoltan@webkit.org>
2155
2156         Reviewed by Darin Adler.
2157
2158         Ambiguous error message when building for unspecified platform
2159         https://bugs.webkit.org/show_bug.cgi?id=30203
2160
2161         Add an extra line information to the error message.
2162
2163         * Scripts/webkitdirs.pm:
2164
2165 2010-03-16  Adam Barth  <abarth@webkit.org>
2166
2167         No review, rolling out r56044.
2168         http://trac.webkit.org/changeset/56044
2169         https://bugs.webkit.org/show_bug.cgi?id=36048
2170
2171         This patch broke Windows Debug (Tests)
2172
2173         * Scripts/webkitdirs.pm:
2174
2175 2010-03-16  John Abd-El-Malek  <jam@chromium.org>
2176
2177         Reviewed by Darin Fisher.
2178
2179         Give keyboard focus to PluginDocuments by default
2180         https://bugs.webkit.org/show_bug.cgi?id=36147
2181
2182         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2183         (pluginAllocate):
2184         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2185         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2186         (NPP_New):
2187         (NPP_SetWindow):
2188         (handleEventCarbon):
2189         (handleEventCocoa):
2190
2191 2010-03-16  Sam Weinig  <sam@webkit.org>
2192
2193         Reviewed by Mark Rowe.
2194
2195         Fix run-webkit-httpd on Windows.
2196
2197         * Scripts/webkitperl/httpd.pm:
2198
2199 2010-03-16  Alexey Proskuryakov  <ap@apple.com>
2200
2201         Tiger build fix.
2202
2203         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty):
2204         Added more type casts to shut down warnings.
2205
2206 2010-03-16  Alexey Proskuryakov  <ap@apple.com>
2207
2208         Reviewed by Darin Adler.
2209
2210         https://bugs.webkit.org/show_bug.cgi?id=36184
2211         YouTube video resizing doesn't work with OOP plug-ins
2212
2213         Added a resizeTo() method, which calls resizePlugin() in JS with the same arguments,
2214         and a lastSetWindowArguments property, which returns a string describing the last NPWindow
2215         passed to NPN_SetWindow.
2216
2217         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2218         (pluginGetProperty):
2219         (testResizeTo):
2220         (pluginInvoke):
2221         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2222         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2223         (NPP_SetWindow):
2224
2225 2010-03-16  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2226
2227         Reviewed by Xan Lopez.
2228
2229         https://bugs.webkit.org/show_bug.cgi?id=35504
2230         [Gtk] Evaluate and fix AtkTable for layout tables
2231
2232         Implements rowCount and columnCount for Gtk in DRT.
2233
2234         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2235         (AccessibilityUIElement::rowCount):
2236         (AccessibilityUIElement::columnCount):
2237
2238 2010-03-15  Eric Seidel  <eric@webkit.org>
2239
2240         Reviewed by Adam Barth.
2241
2242         Add "what-broke" command for debugging when the tree broke
2243         https://bugs.webkit.org/show_bug.cgi?id=36157
2244
2245         This is another step towards automated sheriffing of the webkit tree.
2246         With this logic our scripts are able to determine what revision broke the
2247         tree.  Buildbot should do this for us, but unfortunately buildbot doesn't
2248         expose this kind of aggregate information.
2249
2250         * Scripts/webkitpy/buildbot.py:
2251          - Add new Builder and Build classes (which will eventually replace the custom dictionaries previously used).
2252          - Split out more network logic into _fetch methods which will eventually be their own class for mocking.
2253          - Use XMLRPC to communicate with the buildbot master instead of scraping build pages.
2254         * Scripts/webkitpy/buildbot_unittest.py:
2255          - Test the newly added buildbot classes.
2256         * Scripts/webkitpy/commands/queries.py:
2257          - Add an experimental what-broke command.
2258
2259 2010-03-15  Daniel Bates  <dbates@rim.com>
2260
2261         Reviewed by Eric Seidel.
2262
2263         https://bugs.webkit.org/show_bug.cgi?id=36048
2264
2265         Detect if the Windows Platform SDK is missing when building with
2266         Visual C++ Express Edition and inform the user to download it.
2267
2268         * Scripts/webkitdirs.pm:
2269
2270 2010-03-15  Adam Barth  <abarth@webkit.org>
2271
2272         Reviewed by Eric Seidel.
2273
2274         Let commit-queue land rollout patches even when the tree is red
2275         https://bugs.webkit.org/show_bug.cgi?id=36155
2276
2277         Now the commit-queue will land patches whose name begins with "ROLLOUT "
2278         even if the tree is red.  The patches still go through the usual build
2279         and test process, but they can be landed while the tree is on fire.
2280
2281         * Scripts/webkitpy/bugzilla.py:
2282         * Scripts/webkitpy/commands/queues.py:
2283         * Scripts/webkitpy/commands/queues_unittest.py:
2284         * Scripts/webkitpy/commands/queuestest.py:
2285         * Scripts/webkitpy/mock_bugzillatool.py:
2286
2287 2010-03-15  Adam Barth  <abarth@webkit.org>
2288
2289         Reviewed by Eric Seidel.
2290
2291         Add webkit-patch post-rollout to upload rollouts to bugs.webkit.org for easy committing
2292         https://bugs.webkit.org/show_bug.cgi?id=36154
2293
2294         This new command is a mashup of prepare-rollout and post.  This command
2295         will be used by an experimental bot to post rollouts of patches that
2296         break things to bugs.webkit.org where they can be landed with the
2297         greatest of ease.
2298
2299         * Scripts/webkitpy/commands/download.py:
2300         * Scripts/webkitpy/commands/download_unittest.py:
2301         * Scripts/webkitpy/steps/__init__.py:
2302         * Scripts/webkitpy/steps/postdiffforrevert.py: Added.
2303
2304 2010-03-15  Adam Barth  <abarth@webkit.org>
2305
2306         Reviewed by Eric Seidel.
2307
2308         webkit-patch rollout should error out on conflicts
2309         https://bugs.webkit.org/show_bug.cgi?id=36151
2310
2311         Instead of blindingly plowing ahead, we now throw an exception if there
2312         are conflicts after applying a reverse diff.
2313
2314         * Scripts/webkitpy/scm.py:
2315
2316 2010-03-15  Chris Fleizach  <cfleizach@apple.com>
2317
2318         Unreviewed layout test fix.
2319
2320         VO not able to perform a VO-spacebar on facebook links
2321         https://bugs.webkit.org/show_bug.cgi?id=36132
2322
2323         GTK needs to implement press for this test to work.
2324      
2325         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2326         (AccessibilityUIElement::press):
2327
2328 2010-03-15  Chris Fleizach  <cfleizach@apple.com>
2329
2330         Unreviewed layout test fix.
2331
2332         VO not able to perform a VO-spacebar on facebook links
2333         https://bugs.webkit.org/show_bug.cgi?id=36132
2334
2335         Windows needs to implement press in DRT.
2336
2337         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2338         (AccessibilityUIElement::press):
2339
2340 2010-03-15  Chris Fleizach  <cfleizach@apple.com>
2341
2342         Unreviewed. Fix break of layout tests on win and gtk.
2343
2344         VO not able to perform a VO-spacebar on facebook links
2345         https://bugs.webkit.org/show_bug.cgi?id=36132
2346
2347         Attempting to implement press action for windows and gtk.
2348
2349         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2350         (AccessibilityUIElement::press):
2351         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2352         (AccessibilityUIElement::press):
2353
2354 2010-03-15  Chris Fleizach  <cfleizach@apple.com>
2355
2356         Reviewed by Beth Dakin.
2357
2358         VO not able to perform a VO-spacebar on facebook links
2359         https://bugs.webkit.org/show_bug.cgi?id=36132
2360
2361         * DumpRenderTree/AccessibilityUIElement.cpp:
2362         (pressCallback):
2363         (AccessibilityUIElement::getJSClass):
2364         * DumpRenderTree/AccessibilityUIElement.h:
2365         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2366         (AccessibilityUIElement::press):
2367         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2368         (AccessibilityUIElement::press):
2369         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2370         (AccessibilityUIElement::press):
2371
2372 2010-03-15  Mark Rowe  <mrowe@apple.com>
2373
2374         Add a new build slave to replace the existing SnowLeopard Leaks build slave which
2375         appears to be suffering a slow and painful death at the hands of its graphics hardware.
2376
2377         * BuildSlaveSupport/build.webkit.org-config/config.json:
2378
2379 2010-03-15  Dirk Pranke  <dpranke@chromium.org>
2380
2381         Reviewed by Alexey Proskuryakov.
2382
2383         Fix a minor case where we'd deference a null pointer if we tried
2384         to run new-run-webkit-tests on an unsupported platform (e.g.
2385         Cygwin's python version).
2386
2387         https://bugs.webkit.org/show_bug.cgi?id=36076
2388
2389         * Scripts/webkitpy/layout_tests/port/factory.py:
2390
2391 2010-03-15  Darin Adler  <darin@apple.com>
2392
2393         Tell Subversion about more directories that expect to have .pyc files.
2394
2395         * Scripts/webkitpy/layout_tests: Added property svn:ignore.
2396         * Scripts/webkitpy/layout_tests/port: Added property svn:ignore.
2397
2398 2010-03-15  Adam Barth  <abarth@webkit.org>
2399
2400         Reviewed by Darin Adler.
2401
2402         Operational scripts from running the EWS
2403         https://bugs.webkit.org/show_bug.cgi?id=36097
2404
2405         These are the scripts I use to manage the EWS on EC2.  If someone other
2406         than me wants to run the EWS, these scripts might be helpful.
2407
2408         * EWSTools/boot.sh: Added.
2409         * EWSTools/create-webkit-git: Added.
2410         * EWSTools/screen-config: Added.
2411         * EWSTools/start-queue.sh: Added.
2412
2413 2010-03-14  Adam Barth  <abarth@webkit.org>
2414
2415         Unreviewed.
2416
2417         Fix the webkit-patch bots.  Turns out they need the path of the main
2418         script to run properly.
2419
2420         * Scripts/webkit-patch:
2421         * Scripts/webkitpy/patch/patcher.py:
2422
2423 2010-03-14  Darin Adler  <darin@apple.com>
2424
2425         Tell Subversion about more directories that expect to have .pyc files.
2426
2427         * Scripts/webkitpy/init: Added property svn:ignore.
2428         * Scripts/webkitpy/patch: Added property svn:ignore.
2429         * Scripts/webkitpy/thirdparty: Added property svn:ignore.
2430         * Scripts/webkitpy/thirdparty/autoinstalled: Added property svn:ignore.
2431
2432 2010-03-14  Antti Koivisto  <koivisto@iki.fi>
2433
2434         Reviewed by Simon Hausmann.
2435
2436         https://bugs.webkit.org/show_bug.cgi?id=35146
2437         Support tiled backing store
2438
2439         QtLauncher support and build flag in build-webkit.
2440
2441         * QtLauncher/main.cpp:
2442         (LauncherWindow::applyPrefs):
2443         (LauncherWindow::toggleTiledBackingStore):
2444         (LauncherWindow::toggleResizesToContents):
2445         (LauncherWindow::createChrome):
2446         (LauncherApplication::handleUserOptions):
2447         * QtLauncher/webview.cpp:
2448         (WebViewGraphicsBased::WebViewGraphicsBased):
2449         (WebViewGraphicsBased::setResizesToContents):
2450         (WebViewGraphicsBased::resizeEvent):
2451         * QtLauncher/webview.h:
2452         * Scripts/build-webkit:
2453
2454 2010-03-13  Chris Jerdonek  <cjerdonek@webkit.org>
2455
2456         Reviewed by Adam Barth.
2457
2458         The webkit-patch script now displays a warning if run using
2459         a version of Python less than 2.5.  This will help users
2460         understand why webkit-patch is erroring out if they are
2461         using Python 2.4, for example.
2462
2463         https://bugs.webkit.org/show_bug.cgi?id=31533
2464
2465         * Scripts/webkit-patch:
2466           - Moved most of the file contents to webkitpy/patch/patcher.py
2467             so the Python version can be checked before interpreting
2468             any code that can cause the script to error out.
2469           - Added a configure_logging() method to enable any version
2470             warnings to show up.
2471           - Added a main() method with calls to configure_logging(),
2472             check_version(), and the main webkit patch method.
2473
2474         * Scripts/webkitpy/patch/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
2475           - This file is required to make a folder a package.
2476
2477         * Scripts/webkitpy/patch/patcher.py: Added.
2478           - Moved code from Scripts/webkit-patch.
2479
2480 2010-03-13  Chris Jerdonek  <cjerdonek@webkit.org>
2481
2482         Reviewed by Adam Barth.
2483
2484         Changed test-webkitpy so that messages logged as a side-effect
2485         of unit-testing code do not get displayed to the screen.  These
2486         messages clutter up the unit test results if not filtered out.
2487
2488         https://bugs.webkit.org/show_bug.cgi?id=35835
2489
2490         * Scripts/test-webkitpy:
2491           - Adjusted the configure_logging() method to filter out any
2492             log messages from webkitpy.
2493           - Also added an INFO message stating that most console logging
2494             is getting suppressed.
2495
2496         * Scripts/webkitpy/init/versioning.py:
2497           - Added a log parameter to the check_version() method.
2498
2499         * Scripts/webkitpy/init/versioning_unittest.py:
2500           - Qualified a call to check_version() with the parameter names.
2501
2502 2010-03-13  Chris Jerdonek  <cjerdonek@webkit.org>
2503
2504         Reviewed by Adam Barth.
2505
2506         The test-webkitpy script now warns the user if the script is
2507         being run using a Python version different from the minimum
2508         version the webkitpy package was meant to support.
2509
2510         https://bugs.webkit.org/show_bug.cgi?id=35788
2511
2512         Warning developers if their Python version is too low will help
2513         them understand why test-webkitpy is failing.  Secondly, warning
2514         developers if their Python version is higher than the minimum will
2515         help them understand that their changes may not be okay for the
2516         minimum supported version, even if test-webkitpy is passing.
2517
2518         * Scripts/test-webkitpy:
2519           - Moved the "from ..._unittest import *" lines to the new
2520             file Scripts/webkitpy/unittests.py.  This will allow the
2521             version-check warning to be displayed even if an error occurs
2522             while interpreting (i.e. importing) the unit test code.
2523           - Added configure_logging() to configur logging for test-webkitpy.
2524           - Added an init() method to configure logging and check the
2525             current Python version.
2526
2527         * Scripts/webkitpy/init/unittests.py: Added.
2528           - Added a file to import all unit test modules in the
2529             webkitpy.init package.
2530
2531         * Scripts/webkitpy/init/versioning.py: Added.
2532           - Added a _MINIMUM_SUPPORTED_PYTHON_VERSION variable and set
2533             it equal to 2.5.
2534           - Added a compare_version() method to compare the current Python
2535             version against a target version.
2536           - Added a check_version() method to check the current Python
2537             version against the current minimum supported version, and to
2538             log a warning message if the check fails.
2539
2540         * Scripts/webkitpy/init/versioning_unittest.py: Added.
2541           - Added unit tests for the functions in versioning.py.
2542
2543         * Scripts/webkitpy/style/unittests.py:
2544           - Fixed/updated a code comment.
2545
2546         * Scripts/webkitpy/unittests.py: Added.
2547           - Moved the "from ..._unittest import *" lines from test-webkitpy.
2548
2549 2010-03-13  Chris Jerdonek  <cjerdonek@webkit.org>
2550
2551         Reviewed by Adam Barth.
2552
2553         Moved all code in webkitpy/__init__.py to another location.
2554
2555         https://bugs.webkit.org/show_bug.cgi?id=35828
2556
2557         Keeping webkitpy/__init__.py free of non-trivial code allows
2558         calling code to import initialization code from webkitpy
2559         before any errors or log messages occur due to code in
2560         __init__.py.  Such initialization code can include things like
2561         version checking code and logging configuration code.  This
2562         also lets us move the autoinstall initialization code to a
2563         location where it only executes if it is needed -- something
2564         we have done in this patch.
2565
2566         * Scripts/webkitpy/__init__.py:
2567           - Moved all executable code to the following location:
2568             webkitpy/thirdparty/autoinstalled/__init__.py
2569           - Added a code comment to keep this file free of non-trivial
2570             code.
2571
2572         * Scripts/webkitpy/bugzilla.py:
2573           - Updated mechanize import statement.
2574
2575         * Scripts/webkitpy/networktransaction.py:
2576           - Updated mechanize import statement.
2577
2578         * Scripts/webkitpy/networktransaction_unittest.py:
2579           - Updated mechanize import statement.
2580
2581         * Scripts/webkitpy/statusserver.py:
2582           - Updated mechanize import statement.
2583
2584         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: Added.
2585           - Copied the code from webkitpy/__init__.py and updated it
2586             as necessary.
2587
2588 2010-03-13  Chris Jerdonek  <cjerdonek@webkit.org>
2589
2590         Reviewed by Adam Barth.
2591
2592         Moved webkitpy/mock.py into webkitpy/thirdparty since it is
2593         third-party code.
2594
2595         https://bugs.webkit.org/show_bug.cgi?id=35499
2596
2597         Updated the import statement in all of the below except where noted.
2598
2599         * Scripts/webkitpy/bugzilla_unittest.py:
2600         * Scripts/webkitpy/commands/commandtest.py:
2601         * Scripts/webkitpy/commands/download_unittest.py:
2602         * Scripts/webkitpy/commands/early_warning_system_unittest.py:
2603         * Scripts/webkitpy/commands/queries_unittest.py:
2604         * Scripts/webkitpy/commands/queues_unittest.py:
2605         * Scripts/webkitpy/commands/queuestest.py:
2606         * Scripts/webkitpy/commands/upload.py:
2607         * Scripts/webkitpy/commands/upload_unittest.py:
2608         * Scripts/webkitpy/commands_references.py: Added.
2609           - Added a file containing an absolute import of Mock so that
2610             the imports in the commands folder can import from this file
2611             (similar to style_references.py).  This helps limit the
2612             number of affected files in future refactorings.
2613
2614         * Scripts/webkitpy/credentials_unittest.py:
2615         * Scripts/webkitpy/mock.py: Removed.
2616           - Moved to Scripts/webkitpy/thirdparty.
2617
2618         * Scripts/webkitpy/mock_bugzillatool.py:
2619         * Scripts/webkitpy/patchcollection_unittest.py:
2620         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
2621         * Scripts/webkitpy/steps/steps_unittest.py:
2622         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
2623         * Scripts/webkitpy/steps_references.py: Added.
2624           - Added a file containing an absolute import of Mock so that
2625             the imports in the steps folder can import from this file
2626             (similar to style_references.py).  This helps limit the
2627             number of affected files in future refactorings.
2628
2629         * Scripts/webkitpy/thirdparty/mock.py: Copied from WebKitTools/Scripts/webkitpy/mock.py.
2630           - Also eliminated trailing white space and carriage returns.
2631
2632 2010-03-12  Robert Hogan  <robert@webkit.org>
2633
2634         Reviewed by Adam Barth.
2635
2636         Amend incorrect typo patch for QtLauncher.
2637
2638         https://bugs.webkit.org/show_bug.cgi?id=35877
2639
2640         * QtLauncher/webview.cpp:
2641         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
2642
2643 2010-03-13  Victor Wang  <victorw@chromium.org>
2644
2645         Add appengine app to host and serve webkit layout test results.
2646
2647         The app allows you post test result files (json) and serve them up.
2648         Chromium flakiness dashboard will first use this app to host results.json
2649         and expectations.json, but the files hosted by this app are not limited
2650         to chromium results or json files. It can be used to host other files if needed.
2651
2652         https://bugs.webkit.org/show_bug.cgi?id=35944
2653
2654         * TestResultServer: Added.
2655         * TestResultServer/app.yaml: Added.
2656         * TestResultServer/handlers: Added.
2657         * TestResultServer/handlers/__init__.py: Added.
2658         * TestResultServer/handlers/menu.py: Added.
2659         * TestResultServer/handlers/testfilehandler.py: Added.
2660         * TestResultServer/index.yaml: Added.
2661         * TestResultServer/main.py: Added.
2662         * TestResultServer/model: Added.
2663         * TestResultServer/model/__init__.py: Added.
2664         * TestResultServer/model/testfile.py: Added.
2665         * TestResultServer/stylesheets: Added.
2666         * TestResultServer/stylesheets/form.css: Added.
2667         * TestResultServer/stylesheets/menu.css: Added.
2668         * TestResultServer/stylesheets/testfile.css: Added.
2669         * TestResultServer/templates: Added.
2670         * TestResultServer/templates/menu.html: Added.
2671         * TestResultServer/templates/showfilelist.html: Added.
2672         * TestResultServer/templates/uploadform.html: Added.
2673
2674 2010-03-13  Dimitri Glazkov  <dglazkov@chromium.org>
2675
2676         Reviewed by David Levin.
2677
2678         new-run-webkit-tests fails with --debug option.
2679         https://bugs.webkit.org/show_bug.cgi?id=36067
2680
2681         * Scripts/webkitpy/layout_tests/port/mac.py:
2682
2683 2010-03-13  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2684
2685         Reviewed by Kenneth Rohde Christiansen.
2686
2687         Add "Show FPS" menu option to QtLauncher.
2688
2689         [Qt] QtLauncher need a menu option to show/hide FPS
2690         https://bugs.webkit.org/show_bug.cgi?id=35794
2691
2692         * QtLauncher/main.cpp:
2693         (LauncherWindow::showFPS):
2694         (LauncherWindow::createChrome):
2695
2696 2010-03-13  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2697
2698         Reviewed by Kenneth Rohde Christiansen.
2699
2700         Add a "Toggle FullScreen" option to QtLauncher Menu.
2701
2702         [Qt] QtLauncher needs an option to toggle FullScreen Mode
2703         https://bugs.webkit.org/show_bug.cgi?id=35755
2704
2705         * QtLauncher/main.cpp:
2706         (LauncherWindow::init):
2707         (LauncherWindow::eventFilter):
2708         (LauncherWindow::initializeView):
2709         (LauncherWindow::toggleFullScreenMode):
2710         (LauncherWindow::createChrome):
2711
2712 2010-03-12  Dirk Pranke  <dpranke@chromium.org>
2713
2714         Reviewed by Dimitri Glazkov.
2715
2716         Fix typo in websocket_server (path_from_base instead of 
2717         path_from_chromium_base).
2718
2719         https://bugs.webkit.org/show_bug.cgi?id=36074
2720
2721         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2722
2723 2010-03-12  Dirk Pranke  <dpranke@chromium.org>
2724
2725         Reviewed by Adam Barth.
2726
2727         new-run-webkit-tests --new-baseline doesn't work at all.
2728
2729         It attempts to call a method that isn't defined. To fix it, I
2730         removed the unnecessary and unnecessarily confusing 'platform'
2731         argument to the test_type constructor and use the Port object that
2732         is passed in instead, since we are only ever generating a baseline
2733         from the port that is currently executing.
2734
2735         https://bugs.webkit.org/show_bug.cgi?id=36046
2736
2737         * Scripts/webkitpy/layout_tests/port/mac.py:
2738         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2739         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2740         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2741
2742 2010-03-12  Dirk Pranke  <dpranke@chromium.org>
2743
2744         Reviewed by Adam Barth.
2745
2746         Fix new-run-webkit-tests --run-singly
2747
2748         This script option is currently broken - the script attempts to
2749         dereference methods and variables that don't exist, which causes
2750         the Chromium Linux valgrind bot to be quite unhappy. This has been
2751         broken since r54449 when I renamed Port.start_test_driver to
2752         Port.start_driver.
2753
2754         https://bugs.webkit.org/show_bug.cgi?id=36042
2755
2756         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2757
2758 2010-03-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2759
2760         Fix critical being printed to stderr on every test. This is
2761         because the jar is only being created when soup hits the HTTP
2762         path. We should reconsider the time of its creation.
2763
2764         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2765         (resetDefaultsToConsistentValues):
2766
2767 2010-03-12  Adam Roben  <aroben@apple.com>
2768
2769         Teach prepare-ChangeLog to find modified selectors in CSS files
2770
2771         Reviewed by Tim Hatcher.
2772
2773         Fixes <http://webkit.org/b/36064> prepare-ChangeLog should extract
2774         modified selectors from CSS files
2775
2776         * Scripts/prepare-ChangeLog:
2777         (get_function_line_ranges): Call get_selector_line_ranges_for_css for
2778         .css files.
2779         (get_selector_line_ranges_for_css): Added. Finds selectors and their
2780         line ranges and returns them.
2781
2782 2010-03-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2783
2784         Build fix (for EWS). Make sure the new code builds on older soup.
2785
2786         Thanks to Dan Winship.
2787
2788         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2789         (resetDefaultsToConsistentValues):
2790         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2791         (LayoutTestController::setAlwaysAcceptCookies):
2792
2793 2010-03-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2794
2795         Reviewed by Eric Carlson.
2796
2797         [GTK] DRT does not handle cookie policy setting
2798         https://bugs.webkit.org/show_bug.cgi?id=36056
2799
2800         Implement cookie accept policy setting for GTK+'s LayoutTestController.
2801
2802         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2803         (resetDefaultsToConsistentValues):
2804         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2805         (LayoutTestController::setAlwaysAcceptCookies):
2806
2807 2010-03-12  Adam Langley  <agl@chromium.org>
2808
2809         Reviewed by Dimitri Glazkov.
2810
2811         [chromium]: update Linux layout test scripts for RedHat like systems.
2812
2813         (Tested on Fedora 12.)
2814
2815         https://bugs.webkit.org/show_bug.cgi?id=35867
2816
2817         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2818
2819 2010-03-12  Adam Roben  <aroben@apple.com>
2820
2821         Make svn-create-patch's diffs of ObjC header files more readable
2822
2823         Fixes <http://webkit.org/b/36055>.
2824
2825         Reviewed by John Sullivan.
2826
2827         * Scripts/svn-create-patch:
2828         (diffOptionsForFile): Added. Returns the options that should be passed
2829         to diff for the given file. All the options are the same for all
2830         files, except for the option to specify which lines should be used as
2831         hunk headers.
2832         (generateDiff): Use diffOptionsForFile to get the options to pass to
2833         diff.
2834         (hunkHeaderLineRegExForFile): Added. Returns the regular expression
2835         that should be used by diff to identify lines that should be included
2836         after the "@@" in the hunk header lines of the diff. For ObjC[++]
2837         source files, we use any lines starting with -, +, or
2838         @implementation/@interface/@protocol. For ObjC[++] header files (which
2839         we assume to be any .h files in a mac/ or objc/ directory), we use any
2840         lines starting with @implementation/@interface/@protocol.
2841
2842 2010-03-12  Jochen Eisinger  <jochen@chromium.org>
2843
2844         Reviewed by Jeremy Orlow.
2845
2846         Introduce setWillSendRequestClearHeader to LayoutTestController to selectively remove headers in willSendRequest. Used in http/tests/security/no-referrer.html
2847         https://bugs.webkit.org/show_bug.cgi?id=35920
2848
2849         * DumpRenderTree/LayoutTestController.cpp:
2850         (setWillSendRequestClearHeaderCallback):
2851         (LayoutTestController::staticFunctions):
2852         * DumpRenderTree/LayoutTestController.h:
2853         (LayoutTestController::willSendRequestClearHeaders):
2854         (LayoutTestController::setWillSendRequestClearHeader):
2855         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2856         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2857         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2858         (ResourceLoadDelegate::willSendRequest):
2859
2860 2010-03-11  Fumitoshi Ukai  <ukai@chromium.org>
2861
2862         Unreviewed.
2863
2864         Fix typo in websocket_server.py
2865
2866         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2867
2868 2010-03-11  Garret Kelly  <gdk@chromium.org>
2869
2870         Reviewed by Darin Adler.
2871
2872         Fixing minor typo in the commit queue status page.
2873         https://bugs.webkit.org/show_bug.cgi?id=35979
2874
2875         * Scripts/webkitpy/commands/queues.py:
2876
2877 2010-03-11  Fumitoshi Ukai  <ukai@chromium.org>
2878
2879         Unreviewed.
2880
2881         Fix for WebSocket layout test runner on chromium/win port.
2882
2883         * Scripts/webkitpy/layout_tests/port/websocket_server.py: register_cygwin and set CYGWIN_PATH
2884
2885 2010-03-11  Mark Rowe  <mrowe@apple.com>
2886
2887         Reviewed by David Kilzer.
2888
2889         <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
2890
2891         Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version.
2892
2893         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2894
2895 2010-03-11  Victor Wang  <victorw@chromium.org>
2896
2897         Reviewed by dglazkov@chromium.org.
2898
2899         rebaseline_chromium_webkit_tests can generate new baselines for
2900         all platforms so it needs to know two ports in order to work correctly:
2901         the port that the script is running on and the port that it generates
2902         new baselines for. Update rebaselining tool to handle both port correctly.
2903
2904         https://bugs.webkit.org/show_bug.cgi?id=36032
2905
2906         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2907
2908 2010-03-11  Mark Rowe  <mrowe@apple.com>
2909
2910         Reviewed by Tim Hatcher.
2911
2912         <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
2913
2914         Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted.  It defaults to the
2915         current Mac OS X version unless otherwise specified.
2916
2917         Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR.
2918
2919         Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice
2920         may not be usable when targetting a different Mac OS X version.
2921
2922         Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off
2923         MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used.
2924
2925         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2926         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2927         * DumpRenderTree/mac/DumpRenderTree.mm: Wrap the include of mach-o/getsect.h in 'extern "C"' as some versions of the
2928         header in older SDKs do not do this inside the header.
2929
2930 2010-03-11  Alexey Proskuryakov  <ap@apple.com>
2931
2932         Reviewed by Geoff Garen.
2933
2934         https://bugs.webkit.org/show_bug.cgi?id=35965
2935         <rdar://problem/7742771> Crash when passing an object returned from plug-in back to the plug-in
2936
2937         Made rememberedObject a member of PluginObject. A plug-in must not use its references
2938         to browser NPObjects after being destroyed, but this wasn't the case with static variable.
2939
2940         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2941         (pluginInvoke):
2942         (pluginInvalidate):
2943         (pluginAllocate):
2944         (pluginDeallocate):
2945         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2946
2947 2010-03-11  Simon Fraser  <simon.fraser@apple.com>
2948
2949         Reviewed by Oliver Hunt.
2950
2951         https://bugs.webkit.org/show_bug.cgi?id=35905
2952         REGRESSION(55699?): media/video-no-autoplay.html times out on Leopard Commit Bot
2953
2954         Make sure we reset the WebGL preference, so that WebGL doesn't get left
2955         on after being enabled via layoutTestController.overridePreference(),
2956         which in turn causes accelerated compositing to be enabled on Leopard
2957         when we don't want it to be.
2958         
2959         * DumpRenderTree/mac/DumpRenderTree.mm:
2960         (resetDefaultsToConsistentValues):
2961
2962 2010-03-10  Dirk Pranke  <dpranke@chromium.org>
2963
2964         Reviewed by Dimitri Glazkov.
2965
2966         rebaseline_chromium_webkit_tests doesn't handle other plaforms
2967         correctly (e.g., if you run on the Mac platform and try to
2968         rebaseline the WIN results, the result gets written into
2969         platform/mac instead of platform/chromium-win). Also, this script
2970         doesn't work on non-Chromium ports, so we need to fix that at some
2971         point.
2972
2973         https://bugs.webkit.org/show_bug.cgi?id=35982
2974
2975         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2976
2977 2010-03-10  Daniel Bates  <dbates@rim.com>
2978
2979         Reviewed by Simon Hausmann.
2980
2981         https://bugs.webkit.org/show_bug.cgi?id=35840
2982
2983         Updates the subroutine builtDylibPathForName() so that it adds the "d" suffix to
2984         the QtWebKit library name on Windows. This change makes run-launcher work again
2985         under Windows. Moreover, this change corresponds to the change made in change-
2986         set 53924 <http://trac.webkit.org/changeset/53924>.
2987
2988         * Scripts/webkitdirs.pm:
2989
2990 2010-03-10  Adam Roben  <aroben@apple.com>
2991
2992         Roll out the prepare-ChangeLog part of r55870
2993
2994         This change wasn't needed (prepare-ChangeLog calls svn-create-patch
2995         when it's asked to print out diffs for the user) and was screwing up
2996         its ability to find changed function names.
2997
2998         * Scripts/prepare-ChangeLog:
2999         (diffCommand): Change the options we pass to svn-diff back to their
3000         pre-r55870 form.
3001
3002 2010-03-10  Robert Hogan  <robert@webkit.org>
3003
3004         Reviewed by Simon Hausmann.
3005
3006         [Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT
3007
3008         Unskip test fast/events/multiline-link-arrow-navigation.html
3009
3010         https://bugs.webkit.org/show_bug.cgi?id=35593
3011
3012         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3013         (WebCore::WebPage::resetSettings):
3014         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3015         (LayoutTestController::overridePreference):
3016         (LayoutTestController::setCaretBrowsingEnabled):
3017         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3018
3019 2010-03-10  Robert Hogan  <robert@webkit.org>
3020
3021         Reviewed by Holger Freyther.
3022
3023         QtLauncher: Fix typo in conditional statement in
3024                     WebViewGraphicsBased::setFrameRateMeasurementEnabled.
3025
3026         '=' should be '=='!
3027
3028         https://bugs.webkit.org/show_bug.cgi?id=35877
3029
3030         * QtLauncher/webview.cpp:
3031         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
3032
3033 2010-03-10  Chris Jerdonek  <cjerdonek@webkit.org>
3034
3035         Reviewed by Shinichiro Hamaji.
3036
3037         Refactored and cleaned up the code for unit-testing logging.
3038
3039         https://bugs.webkit.org/show_bug.cgi?id=35845
3040
3041         * Scripts/webkitpy/init/logtesting.py:
3042           - Added more information to the module docstring.
3043           - Added an assertMessages() method to the UnitTestLogStream
3044             class.  This simplifies the calling code.
3045           - Renamed the UnitTestLog class to LogTesting, and reformulated
3046             it as follows:
3047               - Moved the logging configuration code from the __init__
3048                 method to a new static setUp() method.
3049               - Documented the __init__ method to be private.
3050               - Improved the code so that the root logger does not have
3051                 its logging level changed.  Instead we set the handler's
3052                 level.  This makes the unit testing more unintrusive.
3053               - Updated the assertMessages() method to call the
3054                 UnitTestLogStream class's assertMessages() method.
3055               - More fully documented the class.
3056
3057         * Scripts/webkitpy/style/checker.py:
3058           - Added a logger parameter to the configure_logging() method.
3059             This allows us to prevent test messages from being sent
3060             to the root logger during unit testing, which may be
3061             rendering to the screen, etc.
3062           - Simplified the code by removing the _LevelLoggingFilter class.
3063           - Replaced the _LevelLoggingFilter class with a one-line lambda
3064             expression in configure_logging().
3065
3066         * Scripts/webkitpy/style/checker_unittest.py:
3067           - Changed relative imports to absolute to comply more with PEP8.
3068           - In the ConfigureLoggingTest class:
3069             - Changed the setUp() method to prevent test messages from
3070               being propagated to the root logger.
3071             - Changed the _log() method to a data attribute.
3072             - Updated to accommodate changes to logtesting.py.
3073
3074         * Scripts/webkitpy/style_references.py:
3075           - Updated an import statement.
3076
3077 2010-03-10  Evan Martin  <evan@chromium.org>
3078
3079         Reviewed by Darin Adler.
3080
3081         Python code for GDB 7 to support native printing of some WebCore types.
3082
3083         * gdb/webcore.py: Added.
3084
3085 2010-03-10  Adam Roben  <aroben@apple.com>
3086
3087         Make svn-create-patch and prepare-ChangeLog show better section
3088         headings for ObjC files
3089
3090         This makes the text at the end of each "@@" line in a diff actually
3091         show the ObjC method or interface that contains the change, rather
3092         than whatever the most-recently-defined C function was.
3093
3094         Fixes <http://webkit.org/b/35970>.
3095
3096         Reviewed by John Sullivan.
3097
3098         * Scripts/svn-create-patch: Pass -F'^[-+@]' to diff so that it will
3099         treat any lines starting with -, +, or @ as section heading lines.
3100         This works well for ObjC files, and shouldn't affect other types of
3101         files.
3102
3103         * Scripts/prepare-ChangeLog: Changed the options passed to diff to
3104         match those used in svn-create-patch.
3105
3106 2010-03-10  Simon Hausmann  <simon.hausmann@nokia.com>
3107
3108         Reviewed by Tor Arne Vestbø.
3109
3110         Link QtLauncher against the WebKit library using a relative rpath.
3111
3112         This makes the launcher and the lib relocatable.
3113
3114         * QtLauncher/QtLauncher.pro:
3115
3116 2010-03-10  Holger Hans Peter Freyther  <zecke@selfish.org>
3117
3118         Rubber-stamped by Simon Hausmann.
3119
3120         [iExploder] Add new CSS Properties and HTML Attributes
3121
3122         The update-iexploder-cssproperties script was used to update
3123         the various input files. The autobuffer HTML Attribute was removed
3124         from WebKit and I manually added it back to the htmlattrs.in like
3125         we have done it for other attributes in the past.
3126
3127         * iExploder/htdocs/cssproperties.in:
3128         * iExploder/htdocs/htmlattrs.in:
3129         * iExploder/htdocs/htmltags.in:
3130
3131 2010-03-09  Fumitoshi Ukai  <ukai@chromium.org>
3132
3133         Unreviewed.
3134
3135         Obvious fix for --cgi-paths of pywebsocket.
3136
3137         * Scripts/run-webkit-websocketserver:
3138         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3139
3140 2010-03-09  Jakub Wieczorek  <jwieczorek@webkit.org>
3141
3142         Unreviewed.
3143
3144         Adding myself to committers.py.
3145
3146         * Scripts/webkitpy/committers.py:
3147
3148 2010-03-09  Dirk Pranke  <dpranke@chromium.org>
3149
3150         Reviewed by Nate Chapin.
3151
3152         Fix --clobber-old-results in new-run-webkit-tests.
3153
3154         https://bugs.webkit.org/show_bug.cgi?id=35778
3155
3156         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3157
3158 2010-03-09  Andy Estes  <aestes@apple.com>
3159
3160         Reviewed by Adele Peterson.
3161
3162         Add the ability to dispatch scroll wheel events in DRT.  This was
3163         necessary in order to write a test for
3164         https://bugs.webkit.org/show_bug.cgi?id=34700.
3165
3166         * DumpRenderTree/mac/EventSendingController.mm: Add support for two
3167         new methods to EventSender: mouseScrollBy(x, y) and
3168         continuousMouseScrollBy(x, y).  The API to generate scroll events on
3169         the mac was added in 10.5, so these methods are NOOPs on Tiger.
3170         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3171         Regiester mouseScrollByX:andY: and continuousMouseScrollByX:andY:
3172         (+[EventSendingController webScriptNameForSelector:]): Map JavaScript
3173         method names to ObjC selectors.
3174         (-[EventSendingController mouseScrollByX:andY:continuously:]): Generate
3175         a scroll wheel event using CGEventCreateScrollWheelEvent() and dispatch
3176         it to WebKit.
3177         (-[EventSendingController continuousMouseScrollByX:andY:]): Generate a
3178         continuous scrolling event by x and y pixels.
3179         (-[EventSendingController mouseScrollByX:andY:]): Generate a notchy
3180         scrolling event by x and y lines.
3181
3182 2010-03-09  Chris Fleizach  <cfleizach@apple.com>
3183
3184         DRT build fix for Tiger. No review.
3185
3186         AX: hit testing a list box doesn't work anymore
3187         https://bugs.webkit.org/show_bug.cgi?id=35893
3188
3189         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3190         (AccessibilityController::elementAtPoint):
3191
3192 2010-03-09  Chris Fleizach  <cfleizach@apple.com>
3193
3194         Reviewed by Darin Adler.
3195
3196         AX: hit testing a list box doesn't work anymore
3197         https://bugs.webkit.org/show_bug.cgi?id=35893
3198
3199         * DumpRenderTree/AccessibilityController.cpp:
3200         (getElementAtPointCallback):
3201         (AccessibilityController::getJSClass):
3202         * DumpRenderTree/AccessibilityController.h:
3203         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3204         (AccessibilityController::elementAtPoint):
3205         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3206         (AccessibilityController::elementAtPoint):
3207         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3208         (AccessibilityController::elementAtPoint):
3209
3210 2010-03-03  Fumitoshi Ukai  <ukai@chromium.org>
3211
3212         Reviewed by Alexey Proskuryakov.
3213
3214         pywebsocket should support html and cgi in the same directory.
3215         https://bugs.webkit.org/show_bug.cgi?id=34879
3216
3217         Import pywebsocket 0.4.9.2
3218         Specify --server-host 127.0.0.1, so that it only binds listening socket
3219         to 127.0.0.1 to prevent access from non-localhost.
3220         Change --cgi-paths from /websocket/tests/cookies to /websocket/tests,
3221         because pywebsocket 0.4.9.2 supports html and cgi in the same directory
3222         and only executable (httponly-cookies.pl) will be handled as cgi
3223         script.
3224
3225         * Scripts/run-webkit-tests:
3226         * Scripts/run-webkit-websocketserver:
3227         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3228         * Scripts/webkitpy/thirdparty/pywebsocket/README.webkit:
3229         * Scripts/webkitpy/thirdparty/pywebsocket/example/echo_client.py:
3230         * Scripts/webkitpy/thirdparty/pywebsocket/example/handler_map.txt: Added.
3231         * Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/standalone.py:
3232         * Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/util.py:
3233         * Scripts/webkitpy/thirdparty/pywebsocket/setup.py:
3234         * Scripts/webkitpy/thirdparty/pywebsocket/test/test_util.py:
3235         * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/README: Added.
3236         * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/hello.pl: Added.
3237
3238 2010-03-09  Chris Jerdonek  <cjerdonek@webkit.org>
3239
3240         Reviewed by Shinichiro Hamaji.
3241
3242         Simplified check-webkit-style's argument parsing code by removing
3243         support for the vestigial "extra flag values" parameter.
3244
3245         https://bugs.webkit.org/show_bug.cgi?id=34677
3246
3247         The "extra flag values" parameter was needed before WebKit
3248         forked check-webkit-style from Google.  It was used to pass
3249         through the option parser those command-line flags that WebKit
3250         required but that Google's parser did not support (the --git-commit
3251         flag in particular).
3252             We can remove the parameter now because it is no longer
3253         needed and unnecessarily clutters the argument-parsing code.
3254
3255         * Scripts/webkitpy/style/optparser.py:
3256           - Removed the extra_flag_values parameter from the
3257             CommandOptionValues class's constructor.
3258           - Removed the extra_flags parameter from the ArgumentParser
3259             class's parse() method.
3260
3261         * Scripts/webkitpy/style/optparser_unittest.py:
3262           - Removed from the unit tests all references to the
3263             extra_flag_values variable.
3264
3265 2010-03-08  Kent Tamura  <tkent@chromium.org>
3266
3267         Reviewed by Dimitri Glazkov.
3268
3269         [DRT/Chromium] Add EventSender
3270         https://bugs.webkit.org/show_bug.cgi?id=35859
3271
3272         Add EventSender classes, which are going to be used by
3273         DumpRenderTree Chromium port. These files are based on:
3274         - src/webkit/tools/test_shell/event_sending_controller.cc
3275         - src/webkit/tools/test_shell/event_sending_controller.h
3276         of Chromium rev.40492.
3277
3278         * DumpRenderTree/chromium/EventSender.cpp: Added.
3279         * DumpRenderTree/chromium/EventSender.h: Added.
3280
3281 2010-03-08  Kent Tamura  <tkent@chromium.org>
3282
3283         Reviewed by Dimitri Glazkov.
3284
3285         [DRT/Chromium] Add PlainTextController and TextInputController
3286         https://bugs.webkit.org/show_bug.cgi?id=35852
3287
3288         Add PlainTextController and TextInputController classes, which are going
3289         to be used by DumpRenderTree Chromium port. These files are based on:
3290         - src/webkit/tools/test_shell/plain_text_controller.{cc,h} and
3291         - src/webkit/tools/test_shell/text_input_controller.{cc,h}
3292         of Chromium rev.40492.
3293
3294         * DumpRenderTree/chromium/PlainTextController.cpp: Added.
3295         * DumpRenderTree/chromium/PlainTextController.h: Added.
3296         * DumpRenderTree/chromium/TextInputController.cpp: Added.
3297         * DumpRenderTree/chromium/TextInputController.h: Added.
3298
3299 2010-03-08  Dumitru Daniliuc  <dumi@chromium.org>
3300
3301         Unreviewed, Chromium build fix.
3302
3303         Reverting r55689.
3304
3305         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3306
3307 2010-03-08  Fumitoshi Ukai  <ukai@chromium.org>
3308
3309         Reviewed by Adam Barth.
3310
3311         Fix webkit-patch post and land to work well with security bug
3312         https://bugs.webkit.org/show_bug.cgi?id=35733
3313
3314         Bugzilla requires authentication to access security bug page,
3315         so call authenticate() if it failed to fetch bug page.
3316
3317         * Scripts/webkitpy/bugzilla.py:
3318
3319 2010-03-04  Dirk Pranke  <dpranke@chromium.org>
3320
3321         Reviewed by Dimitry Glazkov.
3322
3323         Fix --clobber-old-results in new-run-webkit-tests.
3324
3325         https://bugs.webkit.org/show_bug.cgi?id=35778
3326
3327         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3328
3329 2010-03-08  Brady Eidson  <beidson@apple.com>
3330
3331         Reviewed by NOBODY (but suggested by Steve Falkenburg and fixing a boneheaded mistake on my part last week)
3332
3333         Followup to https://bugs.webkit.org/show_bug.cgi?id=35532
3334
3335         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3336         (LayoutTestController::apiTestGoToCurrentBackForwardItem): Can't pass in a null BOOL to WebKit APIs.
3337
3338 2010-03-08  Chris Jerdonek  <cjerdonek@webkit.org>
3339
3340         Unreviewed.
3341
3342         Fixed incorrect import statement in validate-committer-lists:
3343         webkitpy.BeautifulSoup -> webkitpy.thirdparty.BeautifulSoup.
3344
3345         * Scripts/validate-committer-lists:
3346
3347 2010-03-08  Jian Li  <jianli@chromium.org>
3348
3349         Reviewed by Dmitry Titov.
3350
3351         Blob.slice support.
3352         https://bugs.webkit.org/show_bug.cgi?id=32993
3353
3354         Add ENABLE_BLOB_SLICE feature define and  flag for build-webkit. It is
3355         currently only turned on for Mac.
3356
3357         * Scripts/build-webkit:
3358
3359 2010-03-08  Gustavo Noronha Silva  <gns@gnome.org>
3360
3361         No review, rolling out r55662.
3362         http://trac.webkit.org/changeset/55662
3363         https://bugs.webkit.org/show_bug.cgi?id=35863
3364
3365         Need to be coordinated with bots setup
3366
3367         * Scripts/run-webkit-tests:
3368
3369 2010-03-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3370
3371         Reviewed by Holger Freyther.
3372
3373         [GTK] Tests fail when running with ipv6 addresses available, on Debian systems
3374         https://bugs.webkit.org/show_bug.cgi?id=35863
3375
3376         If running on a Debian-based system, also listen on the ipv6 address.
3377
3378         * Scripts/run-webkit-tests:
3379
3380 2010-03-08  Holger Hans Peter Freyther  <zecke@selfish.org>
3381
3382         Reviewed by Darin Adler.
3383
3384         [iexploder] Automatically update htmltags.in and htmlattrs.in too
3385         https://bugs.webkit.org/show_bug.cgi?id=33755
3386
3387         Change the update-iexploder-cssproperites script to update
3388         the htmlattrs.in and htmltags.in of WebKitTools/iExploder/htdocs
3389         automatically as well.
3390
3391         Change the reading and writing code to work with parameters
3392         and extend the method that is parsing the .in files to handle
3393         the HTMLTagNames.in and the HTMLAttributeNames.in files.
3394
3395         Remove custom code to determine the revision of files with a
3396         utility of VCUtils.pm to determine the revision of the directory
3397         these files are located in. This will also work with git checkout.
3398
3399         * Scripts/update-iexploder-cssproperties:
3400
3401 2010-03-07  Shinichiro Hamaji  <hamaji@chromium.org>
3402
3403         Reviewed by Eric Seidel.
3404
3405         check-webkit-style: false positive for empty loop
3406         https://bugs.webkit.org/show_bug.cgi?id=35717
3407
3408         * Scripts/webkitpy/style/processors/cpp.py:
3409         * Scripts/webkitpy/style/processors/cpp_unittest.py:
3410
3411 2010-03-07  Kent Tamura  <tkent@chromium.org>
3412
3413         Reviewed by Dimitri Glazkov.
3414
3415         [DRT/Chromium] Add AccessibilityController and AccessibilityUIElement
3416         https://bugs.webkit.org/show_bug.cgi?id=35774
3417
3418         Add AccessibilityController and AccessibilityUIElement classes,
3419         which are going to be used by DumpRenderTree Chromium port. These
3420         files are based on:
3421         - src/webkit/tools/test_shell/accessibility_controller.{cc,h} and
3422         - src/webkit/tools/test_shell/accessibility_ui_element.{cc,h}
3423         of Chromium rev.40492.
3424
3425         * DumpRenderTree/chromium/AccessibilityController.cpp: Added.
3426         * DumpRenderTree/chromium/AccessibilityController.h: Added.
3427         * DumpRenderTree/chromium/AccessibilityUIElement.cpp: Added.
3428         * DumpRenderTree/chromium/AccessibilityUIElement.h: Added.
3429
3430 2010-03-06  Hironori Bono  <hbono@chromium.org>
3431
3432         Reviewed by Eric Seidel.
3433
3434         [Chromium] Typing into Flash with wmode = opaque|transparent and
3435         non-latin language active outputs as if US keyboard layout active
3436
3437         https://bugs.webkit.org/show_bug.cgi?id=34936
3438
3439         To test keyboard events on the test plugin, this change implements
3440         NPCocoaEventKeyDown and NPCocoaEventKeyUp handlers so the plugin
3441         can write log messages.
3442
3443         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3444         (handleEventCocoa): Implemented the event handlers for NPCocoaKeyDown
3445         and NPCocoaEventKeyUp.
3446
3447 2010-03-05  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3448
3449         Reviewed by Eric Seidel.
3450
3451         Fix Print option on QtLauncher by calling print directly from QWebFrame.
3452
3453         [Qt] QtLauncher Print option is not working on QGraphicsView mode
3454         https://bugs.webkit.org/show_bug.cgi?id=35769
3455
3456         * QtLauncher/main.cpp:
3457         (LauncherWindow::print):
3458
3459 2010-03-05  Chris Jerdonek  <cjerdonek@webkit.org>
3460
3461         Reviewed by Eric Seidel.
3462
3463         Changed the logging code for new-run-webkit-tests to use
3464         module-specific loggers rather than the root logger. This is
3465         a standard practice that allows logging specific to a package
3466         to be configured independently of other modules.
3467
3468         https://bugs.webkit.org/show_bug.cgi?id=35194
3469
3470         Added a line of the form "_log = logging.getLogger(<module>)"
3471         to each module below, where <module> is the fully-qualified
3472         name of the module, and updated the log lines to use the new
3473         _log logger.
3474
3475         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3476         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3477         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
3478         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3479         * Scripts/webkitpy/layout_tests/port/chromium.py:
3480         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3481         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3482         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3483         * Scripts/webkitpy/layout_tests/port/http_server.py:
3484         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3485         * Scripts/webkitpy/layout_tests/port/mac.py:
3486         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3487         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3488         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3489         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
3490         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3491         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3492         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3493
3494 2010-03-05  Dirk Pranke  <dpranke@chromium.org>
3495
3496         Reviewed by Eric Siedel.
3497
3498         Split the command-line invocation of the Chromium/python LigHTTPd
3499         server implementation out into its own top level script to make it
3500         a more "public" interface and to resolve some awkward layering
3501         issues. This script will be called directly by other test scripts in
3502         the Chromium tree.
3503
3504         At some point this script should be made to work with Apache-based
3505         implementations and on other ports. I have filed
3506         https://bugs.webkit.org/show_bug.cgi?id=35820 for this.
3507
3508         Also fix a bug in port/factory where options.chromium could be
3509         dereferenced even if it wasn't set, raising an exception.
3510
3511         https://bugs.webkit.org/show_bug.cgi?id=35812
3512
3513         * Scripts/webkitpy/layout_tests/port/factory.py:
3514         * Scripts/webkitpy/layout_tests/port/http_server.py:
3515         * Scripts/new-run-webkit-httpd: Added
3516
3517 2010-03-02  Antonio Gomes  <tonikitoo@webkit.org>
3518
3519         Reviewed by Holger Freyther
3520         Patch by Antonio Gomes <tonikitoo@webkit.org>
3521
3522         [Gtk] Implement setSpatialNavigationEnabled in DRT.
3523         https://bugs.webkit.org/show_bug.cgi?id=35705
3524
3525         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3526         (resetDefaultsToConsistentValues):
3527         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3528         (LayoutTestController::setSpatialNavigationEnabled):
3529
3530 2010-02-23  Antonio Gomes  <tonikitoo@webkit.org>
3531
3532         Reviewed by Kenneth Christiansen.
3533         Patch by Antonio Gomes <tonikitoo@webkit.org>
3534
3535         Add toggle on/off stub methods for Spatial Navigation in win, gtk and mac LayoutTestController class implementations.
3536         https://bugs.webkit.org/show_bug.cgi?id=35699
3537
3538         * DumpRenderTree/LayoutTestController.cpp:
3539         (setSpatialNavigationEnabledCallback):
3540         (LayoutTestController::staticFunctions):
3541         * DumpRenderTree/LayoutTestController.h:
3542         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3543         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3544         (LayoutTestController::setSpatialNavigationEnabled):
3545         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3546         (LayoutTestController::setSpatialNavigationEnabled):
3547         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3548         (LayoutTestController::setSpatialNavigationEnabled):
3549
3550 2010-02-18  Antonio Gomes  <tonikitoo@webkit.org>
3551
3552         Reviewed by Kenneth Christiansen.
3553         Patch by Antonio Gomes <tonikitoo@webkit.org>
3554
3555         Add toggle on/off mechanism for Spatial Navigation in QtLauncher.
3556
3557         * QtLauncher/main.cpp:
3558         (LauncherWindow::toggleSpatialNavigation):
3559         (LauncherWindow::setupUI):
3560
3561 2010-03-02  Antonio Gomes  <tonikitoo@webkit.org>
3562
3563         Reviewed by Simon Hausmann.
3564         Patch by Antonio Gomes <tonikitoo@webkit.org>
3565
3566         [Qt] Add setSpatialNavigationEnabled method DRT
3567         https://bugs.webkit.org/show_bug.cgi?id=33715
3568
3569         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3570         (WebCore::WebPage::WebPage):
3571         (WebCore::WebPage::resetSettings):
3572         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3573         (LayoutTestController::setSpatialNavigationEnabled):
3574         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3575
3576         Unskipped fast/events/spatialnavigation/
3577
3578 2010-03-04  Mark Rowe  <mrowe@apple.com>
3579
3580         Rubber-stamped by Alice Liu.
3581
3582         Find the framework relative to TARGET_BUILD_DIR as that has a more obvious value during production builds.
3583
3584         * Scripts/check-for-webkit-framework-include-consistency:
3585
3586 2010-03-04  Kent Tamura  <tkent@chromium.org>
3587
3588         Reviewed by Dimitri Glazkov.
3589
3590         [DRT/Chromium] Add CppVariant and CppBoundClass
3591         https://bugs.webkit.org/show_bug.cgi?id=35634
3592
3593         Add CppVariant and CppBoundClass classes, which are going to be
3594         used by DumpRenderTree Chromium port. These files are based on:
3595         - src/webkit/glue/cpp_variant.{cc,h} and
3596         - src/webkit/glue/cpp_bound_class.{cc,h}
3597         of Chromium rev.40492.
3598
3599         * DumpRenderTree/chromium/CppBoundClass.cpp: Added.
3600         * DumpRenderTree/chromium/CppBoundClass.h: Added.
3601         * DumpRenderTree/chromium/CppVariant.cpp: Added.
3602         * DumpRenderTree/chromium/CppVariant.h: Added.
3603
3604 2010-03-04  Mark Rowe  <mrowe@apple.com>
3605
3606         Build fix for older versions of Ruby.
3607
3608         * Scripts/check-for-webkit-framework-include-consistency:
3609
3610 2010-03-04  Mark Rowe  <mrowe@apple.com>
3611
3612         Reviewed by Sam Weinig.
3613
3614         Add a script to verify that WebKit framework headers are internally consistent.
3615
3616         This script detects the following problematic situations:
3617         * An exported WebKit header that includes a header from WebCore.
3618         * An exported WebKit header that includes a header that does not exist in the WebKit framework.
3619         * A public WebKit header that includes a private WebKit header.
3620
3621         * Scripts/check-for-webkit-framework-include-consistency: Added.
3622
3623 2010-03-04  Dumitru Daniliuc  <dumi@chromium.org>
3624
3625         Reviewed by Adam Roben.
3626
3627         Making sure that the correct path is set before invoking
3628         DumpRenderTree on cygwin.
3629
3630         https://bugs.webkit.org/show_bug.cgi?id=35768
3631
3632         * Scripts/run-webkit-tests:
3633
3634 2010-03-04  Simon Fraser  <simon.fraser@apple.com>
3635
3636         Revert the exceptions I just added, and make the error clearer.
3637
3638         * Scripts/check-for-global-initializers:
3639
3640 2010-03-04  Simon Fraser  <simon.fraser@apple.com>
3641
3642         Build fix: add exceptions to the check-for-global-initializers script
3643         for FocusController and SpatialNavigation, and improve the script
3644         to actually print out the globals found.
3645
3646         * Scripts/check-for-global-initializers:
3647
3648 2010-03-04  Dirk Pranke  <dpranke@chromium.org>
3649
3650         Reviewed by Dimitri Glazkov.
3651
3652         Fix dangling reference to "port" instead of "self._port_obj" that
3653         was preventing the http_server from starting on Windows.
3654
3655         * Scripts/webkitpy/layout_tests/port/http_server.py:
3656
3657 2010-03-04  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3658
3659         Reviewed by Simon Hausmann.
3660
3661         Make Qt DumpRenderTree EventSender able to send double click events
3662
3663         LayoutTests:
3664             fast/events/dblclick-addEventListener.html
3665
3666         [Qt] DRT: Send double click event from EventSender
3667         https://bugs.webkit.org/show_bug.cgi?id=35255
3668
3669         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3670         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3671         * DumpRenderTree/qt/EventSenderQt.cpp:
3672         (EventSender::EventSender):
3673         (EventSender::mouseDown):
3674         * DumpRenderTree/qt/EventSenderQt.h:
3675         (EventSender::resetClickCount):
3676
3677 2010-03-04  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3678
3679         Reviewed by Tor Arne Vestbø.
3680
3681         [Qt] Make the OUTPUT_DIR variable in qmake projects independent of build-webkit's logic.
3682
3683         This also allows shadow builds relying only on qmake to work properly.
3684
3685         * DumpRenderTree/qt/DumpRenderTree.pro:
3686         * DumpRenderTree/qt/ImageDiff.pro:
3687         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3688         * QtLauncher/QtLauncher.pro:
3689
3690 2010-03-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3691
3692         Reviewed by Kenneth Rohde Christiansen.
3693
3694         Enable to use built-product-archive on Qt platform.
3695
3696         * BuildSlaveSupport/built-product-archive:
3697
3698 2010-03-03  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3699
3700         Reviewed by Simon Hausmann.
3701
3702         Add a missing 'm_' to class variables names.
3703
3704         [Qt] QtLauncher is not respecting class variable names
3705         https://bugs.webkit.org/show_bug.cgi?id=35542
3706
3707         * QtLauncher/main.cpp:
3708         (LauncherWindow::LauncherWindow):
3709         (LauncherWindow::init):
3710         (LauncherWindow::sendTouchEvent):
3711         (LauncherWindow::eventFilter):
3712         (LauncherWindow::zoomIn):
3713         (LauncherWindow::zoomOut):
3714         (LauncherWindow::resetZoom):
3715         (LauncherWindow::setEditable):
3716         (LauncherWindow::setTouchMocking):
3717         (LauncherWindow::initializeView):
3718         (LauncherWindow::createChrome):
3719
3720 2010-03-03  Alexey Proskuryakov  <ap@apple.com>
3721
3722         Rubber-stamped by Mark Rowe.
3723
3724         Exclude leaks in Java that build bot complains about.
3725
3726         * Scripts/run-webkit-tests:
3727
3728 2010-03-03  Chris Marrin  <cmarrin@apple.com>
3729
3730         Reviewed by Simon Fraser.
3731
3732         Additional change to separate Accelerated Compositing test from 3D Rendering test
3733         https://bugs.webkit.org/show_bug.cgi?id=35610
3734         
3735         I am now using #if ENABLED(3D_RENDERING) to emit the 3DRendering string from
3736         DRT or not. This allows these flags to set independently. I also improved
3737         the code flow in run-webkit-tests a bit.
3738
3739         * DumpRenderTree/win/DumpRenderTree.cpp:
3740         (main):
3741         * Scripts/run-webkit-tests:
3742
3743 2010-03-03  Chris Marrin  <cmarrin@apple.com>
3744
3745         Reviewed by Simon Fraser.
3746
3747         Added ability to print supported features to console to DRT
3748         https://bugs.webkit.org/show_bug.cgi?id=35610
3749         
3750         This currently only prints whether or not Accelerated Compositing 
3751         and 3D Rendering are supported, which is the only way to tell if you 
3752         can run the compositing LayoutTests on Windows. But it can be expanded 
3753         to give more information as needed. Currently it prints that both
3754         AcceleratedCompositing and 3DRendering are available if accelerated compositing
3755         is enabled since both have to be turned on together. This allows me to maintain
3756         separate checks for them.
3757
3758         * DumpRenderTree/win/DumpRenderTree.cpp:Added --print-supported-features flag
3759         (main):
3760         * Scripts/run-webkit-tests:Runs DRT and enabled compositing tests if HW comp is available on Windows
3761
3762 2010-03-03  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3763
3764         Reviewed by Simon Hausmann.
3765
3766         Refactor QtLauncher so it respects command line arguments
3767         and inherits settings when you clone or create a new window.
3768
3769         Implemented with help of Kenneth Rohde Christiansen.
3770
3771         [Qt] QtLauncher must be refactored to fix command line arguments usage
3772         https://bugs.webkit.org/show_bug.cgi?id=35536
3773
3774         * QtLauncher/main.cpp:
3775         (LauncherWindow::LauncherWindow):
3776         (LauncherWindow::init):
3777         (LauncherWindow::isGraphicsBased):
3778         (applySetting):
3779         (LauncherWindow::applyPrefs):
3780         (LauncherWindow::initializeView):
3781         (LauncherWindow::newWindow):
3782         (LauncherWindow::cloneWindow):
3783         (LauncherWindow::createChrome):
3784         (main):
3785         * QtLauncher/webview.cpp:
3786         (WebViewGraphicsBased::WebViewGraphicsBased):
3787         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
3788         * QtLauncher/webview.h:
3789         (WebViewGraphicsBased::itemCacheMode):
3790         (WebViewGraphicsBased::frameRateMeasurementEnabled):
3791
3792 2010-03-02  Arno Renevier  <arno@renevier.net>
3793
3794         Reviewed by Gustavo Noronha Silva.
3795
3796         [Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
3797         https://bugs.webkit.org/show_bug.cgi?id=35210
3798
3799         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3800         (geolocationPolicyDecisionRequested):
3801         (createWebView):
3802
3803 2010-03-02  Dirk Pranke  <dpranke@chromium.org>
3804
3805         Reviewed by David Levin.
3806
3807         Revert r55339 - the Chromium codebase downstream had a temporary
3808         need for WebKitTools/pywebsocket to still exist after Chris Jerdonek
3809         had moved it (scripts still referenced the old location). Those
3810         scripts have been updated to the new location, so it should be safe
3811         to delete this now.
3812
3813         https://bugs.webkit.org/show_bug.cgi?id=35614
3814
3815         * pywebsocket/mod_pywebsocket/standalone.py: Removed.
3816
3817 2010-03-02  Dirk Pranke  <dpranke@chromium.org>
3818
3819         Reviewed by Dimitri Glazkov.
3820
3821         new-run-webkit-tests on chromium-linux tests to see if
3822         layout_test_helper exists, but we don't use layout_test_helper on
3823         linux. The test derefences a None object, and we crash. This fixes
3824         that.
3825
3826         https://bugs.webkit.org/show_bug.cgi?id=35602
3827
3828         * Scripts/webkitpy/layout_tests/port/chromium.py:
3829
3830  2010-03-02  Dirk Pranke  <dpranke@chromium.org>
3831
3832         Reviewed by Dimitri Glazkov.
3833
3834         r55388 (bug 35553) worked around a bug in Python's subprocess.Popen()
3835         that was causing DRT to hang on exit in new-run-webkit-tests.
3836         Unfortunately, that workaround doesn't work on chromium-win
3837         (and the script fails completely). The good news is that the check
3838         isn't actually necessary, and so this change makes it conditional.
3839
3840         https://bugs.webkit.org/show_bug.cgi?id=35601
3841
3842         * Scripts/webkitpy/layout_tests/port/chromium.py:
3843
3844 2010-03-02  Mark Rowe  <mrowe@apple.com>
3845
3846         Reviewed by Darin Adler.
3847
3848         Bug 35576: WebKit should tell plug-in instances when private browsing state changes
3849         <http://webkit.org/b/35576>
3850
3851         TestNetscapePlugin is another bit of plug-in code where copy-paste was heavily used
3852         when porting.  Update the Windows and UNIX implementations of NPP_New and NPP_SetValue
3853         to provide the expected behavior related to NPNVprivateModeBool.  Hopefully this code
3854         duplication can be cleaned up in the future.
3855
3856         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3857         (webkit_test_plugin_new_instance):
3858         (webkit_test_plugin_set_value):
3859         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3860         (NPP_New):
3861         (NPP_SetValue):
3862
3863 2010-03-02  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3864
3865         Reviewed by Alexey Proskuryakov.
3866
3867         Test plugin still has issues with releasing objects, and variants
3868         https://bugs.webkit.org/show_bug.cgi?id=35587
3869
3870         Fix the conditions for releasing the variants after calling
3871         invoke, and avoid having a number of objects leak.
3872
3873         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3874         (testDocumentOpen):
3875         (testWindowOpen):
3876
3877 2010-03-02  Chris Jerdonek  <cjerdonek@webkit.org>
3878
3879         Reviewed by Shinichiro Hamaji.
3880
3881         Refactored the StyleChecker class's file-processing method
3882         _process_file().  This will make it easier to add new
3883         file-processing capabilities to check-webkit-style.
3884
3885         https://bugs.webkit.org/show_bug.cgi?id=35490
3886
3887         * Scripts/webkitpy/style/checker.py:
3888           - Added a _read_lines() method to the StyleChecker class
3889             that extracts the lines from a file.
3890           - Replaced part of _process_file() with a call to the new
3891             _read_lines() method.
3892           - Replaced another part of _process_file() with a call
3893             to the new CarriageReturnProcessor.process() method.
3894
3895         * Scripts/webkitpy/style/processors/common.py:
3896           - Replaced the check_no_carriage_return() function with a
3897             new CarriageReturnProcessor class.
3898
3899         * Scripts/webkitpy/style/processors/common_unittest.py:
3900           - Renamed the CarriageReturnTest class to
3901             CarriageReturnProcessorTest and updated it as necessary.
3902
3903 2010-03-02  Chris Jerdonek  <cjerdonek@webkit.org>
3904
3905         Reviewed by Shinichiro Hamaji.
3906
3907         Started using the logging module in check-webkit-style.
3908         This provides more options for debugging and a more flexible,
3909         uniform way to report messages to the end-user.
3910
3911         https://bugs.webkit.org/show_bug.cgi?id=35484
3912
3913         Also included classes in a central location to facilitate
3914         the unit testing of logging code (setUp and tearDown of unit
3915         test logging configurations, etc).
3916
3917         * Scripts/check-webkit-style:
3918           - Added a call to configure_logging() in the beginning of main().
3919           - Replaced two calls to sys.stderr.write() with appropriate
3920             logging calls.
3921
3922         * Scripts/webkitpy/init/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
3923
3924         * Scripts/webkitpy/init/logtesting.py: Added.
3925           - Added a UnitTestLogStream class to capture log output
3926             during unit tests.
3927           - Added a UnitTestLog class that provides convenience methods
3928             for unit-testing logging code.
3929
3930         * Scripts/webkitpy/style/checker.py:
3931           - Added a configure_logging() method.
3932           - Added a _LevelLoggingFilter class to filter out log messages
3933             above a certain logging level.
3934           - Removed the _stderr_write() method from the StyleChecker class
3935             and replaced its use with appropriate logging calls.
3936
3937         * Scripts/webkitpy/style/checker_unittest.py:
3938           - Added a ConfigureLoggingTest class to unit test the
3939             configure_logging() method.
3940           - Updated the StyleCheckerCheckFileTest class as necessary.
3941
3942         * Scripts/webkitpy/style_references.py:
3943           - Added references to logtesting.UnitTestLog and
3944             logtesting.UnitTestLogStream.
3945
3946 2010-03-01  Chris Fleizach  <cfleizach@apple.com>
3947
3948         Fixing broken DRT on Leopard/Tiger. Second try.
3949
3950         AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
3951         https://bugs.webkit.org/show_bug.cgi?id=35514
3952
3953         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3954
3955 2010-03-01  Chris Fleizach  <cfleizach@apple.com>
3956
3957         Fixing broken DRT on Leopard/Tiger.
3958
3959         AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
3960         https://bugs.webkit.org/show_bug.cgi?id=35514
3961
3962         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3963
3964 2010-03-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3965
3966         Reviewed by Eric Seidel.
3967
3968         [GTK] plugins/setProperty.html fails on 64bit Release
3969         https://bugs.webkit.org/show_bug.cgi?id=35425
3970
3971         Check invoke's return code before releasing the variant, since
3972         there's a chance it won't be properly initialized, leading to
3973         memory corruption, in some cases.
3974
3975         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3976         (testCallback):
3977         (testEnumerate):
3978         (testDocumentOpen):
3979         (testWindowOpen):
3980         (handleCallback):
3981
3982 2010-03-01  Dirk Pranke  <dpranke@chromium.org>
3983
3984         Reviewed by nobody. Build bustage :(
3985
3986         Fix stupid typo that I committed even after David Levin pointed
3987         it out to me :(
3988
3989         https://bugs.webkit.org/show_bug.cgi?id=35553
3990
3991         * Scripts/webkitpy/layout_tests/port/mac.py:
3992
3993 2010-03-01  Chris Fleizach  <cfleizach@apple.com>
3994
3995         Reviewed by Darin Adler.
3996
3997         AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
3998         https://bugs.webkit.org/show_bug.cgi?id=35514
3999
4000         Add rowCount, columnCount for tables.
4001
4002         * DumpRenderTree/AccessibilityUIElement.cpp:
4003         (rowCountCallback):
4004         (columnCountCallback):
4005         (AccessibilityUIElement::getJSClass):
4006         * DumpRenderTree/AccessibilityUIElement.h:
4007         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4008         (AccessibilityUIElement::rowCount):
4009         (AccessibilityUIElement::columnCount):
4010         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4011         (AccessibilityUIElement::rowCount):
4012         (AccessibilityUIElement::columnCount):
4013         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4014         (AccessibilityUIElement::rowCount):
4015         (AccessibilityUIElement::columnCount):
4016
4017 2010-03-01  Dirk Pranke  <dpranke@chromium.org>
4018
4019         Reviewed by Eric Seidel.
4020
4021         Work around a bug in Python's subprocess.Popen() that keeps us from
4022         cleaning up DumpRenderTree / test_shell properly when we finish the
4023         tests in new-run-webkit-tests.
4024
4025         https://bugs.webkit.org/show_bug.cgi?id=35553
4026
4027         * Scripts/webkitpy/layout_tests/port/chromium.py:
4028         * Scripts/webkitpy/layout_tests/port/mac.py:
4029
4030 2010-03-01  Arno Renevier  <arno@renevier.net>
4031
4032         Reviewed by Xan Lopez.
4033
4034         webkit-build could pass unknown arguments to autogen.sh
4035         https://bugs.webkit.org/show_bug.cgi?id=35454
4036
4037         * Scripts/build-webkit:
4038
4039 2010-03-01  Dirk Pranke  <dpranke@chromium.org>
4040
4041         Rubber-stamped by Dimitri Glazkov.
4042
4043         Fix breakage from r55372.
4044
4045         https://bugs.webkit.org/show_bug.cgi?id=35549
4046
4047         * Scripts/webkitpy/layout_tests/port/chromium.py:
4048
4049 2010-03-01  Adam Barth  <abarth@webkit.org>
4050
4051         Reviewed by Eric Seidel.
4052
4053         EWS can hang for five hours when compile output is too big
4054         https://bugs.webkit.org/show_bug.cgi?id=35545
4055
4056         * Scripts/webkitpy/commands/queues.py: Limit uploads to 1MB instead of
4057         5MB.  AppEngine seems to not like 5MB uploads.  I'm not sure what the
4058         limit is.  Let's try 1MB for a while and see how it goes.
4059         * Scripts/webkitpy/networktransaction.py: Tune the default parameters
4060         to our exponential backoff.  I'm not sure why I picked five hours as
4061         the retry limit.  That seems way too large.
4062
4063 2010-03-01  Brady Eidson  <beidson@apple.com>
4064
4065         Reviewed by Sam Weinig.
4066
4067         REGRESSION: Telling a WebView to go to its current WebHistoryItem is broken.
4068         <rdar://problem/7699371> and https://bugs.webkit.org/show_bug.cgi?id=35532
4069
4070         * DumpRenderTree/LayoutTestController.cpp:
4071         (apiTestGoToCurrentBackForwardItemCallback):
4072         (LayoutTestController::staticFunctions):
4073         * DumpRenderTree/LayoutTestController.h:
4074         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4075         (LayoutTestController::apiTestGoToCurrentBackForwardItem):
4076
4077         Stubs for now:
4078         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4079         (LayoutTestController::apiTestGoToCurrentBackForwardItem):
4080         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4081         (LayoutTestController::apiTestGoToCurrentBackForwardItem):
4082         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4083         (LayoutTestController::apiTestGoToCurrentBackForwardItem):
4084
4085 2010-03-01  Dirk Pranke  <dpranke@chromium.org>
4086
4087         Reviewed by David Levin.
4088
4089         General cleanup of error handling in new-run-webkit-tests.
4090
4091         Add Port.check_build() call that is separate from Port.check_sys_deps()
4092         (and add a --nocheck-build flag to skip). This breaks a circular
4093         dependency where you would start the layout test helper before
4094         checking sys deps, but checking sys deps was the thing that told
4095         you if your binaries where there.
4096
4097         Also, made Port.check_sys_deps(), start_helper() and stop_helper()
4098         optional by providing default implementations in the base class
4099         rather than requiring ports to implement the routines regardless
4100         of whether or not they were needed.
4101
4102         Lastly, tweak a bunch of log messages to be cleaner, including
4103         changing messages in thirdparty/autoinstall.py to be silent at
4104         the default log level.
4105
4106         http://bugs.webkit.org/show_bug.cgi?id=35416
4107
4108         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
4109         * Scripts/webkitpy/layout_tests/port/base.py:
4110         * Scripts/webkitpy/layout_tests/port/chromium.py:
4111         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4112         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4113         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4114         * Scripts/webkitpy/layout_tests/port/mac.py:
4115         * Scripts/webkitpy/layout_tests/port/passing.py:
4116         * Scripts/webkitpy/layout_tests/port/test.py:
4117         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4118         * Scripts/webkitpy/thirdparty/autoinstall.py
4119
4120 2010-03-01  Dirk Pranke <dpranke@chromium.org>
4121
4122          Reviewed by David Levin.
4123
4124          new-chromium-webkit-tests --platform=mac-leopard diffs are backwards
4125          https://bugs.webkit.org/show_bug.cgi?id=35265
4126
4127          Some parts of the code passed arguments as
4128          "actual, expected" and some passed as "expected, actual".
4129          As you might imagine, this lead to great confusion and wrongness.
4130          Standardize on "expected, actual" as that's the order which is
4131          passed to the underlying diff tool.
4132
4133          Based on a patch by Eric Siedel <eric@webkit.org>.
4134
4135          * Scripts/webkitpy/layout_tests/port/base.py:
4136          * Scripts/webkitpy/layout_tests/port/chromium.py:
4137          * Scripts/webkitpy/layout_tests/port/test.py:
4138          * Scripts/webkitpy/layout_tests/test_types/image_diff.py
4139
4140 2010-03-01  Chris Jerdonek  <cjerdonek@webkit.org>
4141
4142         Unreviewed.
4143
4144         Rolling out: http://trac.webkit.org/changeset/55348
4145
4146         https://bugs.webkit.org/show_bug.cgi?id=35163
4147
4148         Rolling out since the changes to autoinstall do not work
4149         with Python 2.4. In particular, ZipFile.extractall() was
4150         added in Python 2.6.
4151
4152         * Scripts/webkitpy/__init__.py:
4153         * Scripts/webkitpy/bugzilla.py:
4154         * Scripts/webkitpy/init/__init__.py: Removed.
4155         * Scripts/webkitpy/init/autoinstall.py: Removed.
4156         * Scripts/webkitpy/networktransaction.py:
4157         * Scripts/webkitpy/networktransaction_unittest.py:
4158         * Scripts/webkitpy/statusserver.py:
4159         * Scripts/webkitpy/thirdparty/autoinstall.py: Added.
4160
4161 2010-03-01  Chris Jerdonek  <cjerdonek@webkit.org>
4162
4163         Unreviewed.
4164
4165         Rolling out r55350: http://trac.webkit.org/changeset/55350
4166
4167         https://bugs.webkit.org/show_bug.cgi?id=33639
4168
4169         Need to roll out because this patch (pep8) depends on the newly
4170         rewritten autoinstall.py (r55348), which is breaking for people
4171         with Python 2.4:
4172
4173         https://bugs.webkit.org/show_bug.cgi?id=35163#c21
4174
4175         That revision also needs to be rolled out and will be rolled out next.
4176
4177         * Scripts/webkitpy/style/checker.py:
4178         * Scripts/webkitpy/style/checker_unittest.py:
4179         * Scripts/webkitpy/style/processors/python.py: Removed.
4180         * Scripts/webkitpy/style/processors/python_unittest.py: Removed.
4181         * Scripts/webkitpy/style/processors/python_unittest_input.py: Removed.
4182         * Scripts/webkitpy/style/unittests.py:
4183         * Scripts/webkitpy/style_references.py:
4184
4185 2010-02-28  Chris Jerdonek  <cjerdonek@webkit.org>
4186
4187         Reviewed by Shinichiro Hamaji.
4188
4189         Exempted WebKitTools/Scripts/webkitpy/thirdparty from all
4190         style checks except for the whitespace/carriage_return check
4191         and the pep8 tab and trailing white space checks.
4192
4193         https://bugs.webkit.org/show_bug.cgi?id=35497
4194
4195         * Scripts/webkitpy/style/checker.py:
4196           - Adjusted the _PATH_RULES_SPECIFIER configuration as necessary.
4197           - Added enough pep8 categories to _all_categories() for the
4198             unit tests to pass.
4199
4200         * Scripts/webkitpy/style/checker_unittest.py:
4201           - Updated the test_path_rules_specifier() unit test.
4202
4203 2010-02-27  Chris Jerdonek  <cjerdonek@webkit.org>
4204
4205         Reviewed by David Levin.
4206