e60138b4672ca3f399ebbd2b0abf462a82f084af
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
2
3         Reviewed by Gustavo Noronha Silva.
4
5         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
6         https://bugs.webkit.org/show_bug.cgi?id=40600
7
8         * DumpRenderTree/gtk/EventSender.cpp:
9         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
10
11 2010-06-16  Adam Barth  <abarth@webkit.org>
12
13         Reviewed by Dimitri Glazkov.
14
15         Add a hidden land-cowboy command to webkit-patch to help land quick
16         build fixes.
17
18         * Scripts/webkitpy/tool/commands/download.py:
19         * Scripts/webkitpy/tool/steps/preparechangelog.py:
20
21 2010-06-16  Adam Roben  <aroben@apple.com>
22
23         Convert console messages to UTF-8 before printing them
24
25         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
26         http/tests/security/xssAuditor/embed-tag-null-char.html and
27         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
28         Windows. (I can't test the fix because Apache is crashing on my
29         computer.)
30
31         Reviewed by Alexey Proskuryakov.
32
33         * DumpRenderTree/win/DumpRenderTree.cpp:
34         (toUTF8): Extracted the code into an overload that takes a wide string
35         and a length, then added an overload that takes a wstring.
36
37         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
38         overload.
39
40         * DumpRenderTree/win/UIDelegate.cpp:
41         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
42         UTF-8 instead of letting printf convert to the current code page.
43
44 2010-06-16  Drew Wilson  <atwilson@chromium.org>
45
46         Reviewed by Kent Tamura.
47
48         [Chromium] Plumbing for top-level frame names
49         https://bugs.webkit.org/show_bug.cgi?id=40430
50
51         * DumpRenderTree/chromium/WebViewHost.cpp:
52         (WebViewHost::createView):
53         Migrate to new createView() API.
54         * DumpRenderTree/chromium/WebViewHost.h:
55         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
56
57 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
58
59         Reviewed by Kenneth Rohde Christiansen.
60
61         [Qt] Scroll wheel event support to graphics based DRT
62         https://bugs.webkit.org/show_bug.cgi?id=40577
63
64         * DumpRenderTree/qt/EventSenderQt.cpp:
65         (EventSender::continuousMouseScrollBy):
66         (EventSender::createGraphicsSceneWheelEvent):
67         * DumpRenderTree/qt/EventSenderQt.h:
68
69 2010-06-16  Adam Roben  <aroben@apple.com>
70
71         Remove a stray newline from the Windows version of TestNetscapePlugin
72
73         Reviewed by Alexey Proskuryakov.
74
75         Fixes <http://webkit.org/b/40728>
76         plugins/geturlnotify-during-document-teardown.html fails on Windows
77
78         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
79         (NPP_Destroy): Removed extra newline that the Mac version doesn't
80         have.
81
82 2010-06-16  Adam Roben  <aroben@apple.com>
83
84         Respect LayoutTestController::isPrinting on Windows
85
86         This gets some printing tests closer to passing (like
87         printing/page-rule-in-media-query.html).
88
89         Fixes <http://webkit.org/b/40727>.
90
91         Reviewed by Dan Bernstein.
92
93         * DumpRenderTree/win/DumpRenderTree.cpp:
94         (dump): Pass LayoutTestController::isPrinting to
95         IWebFramePrivate::renderTreeAsExternalRepresentation.
96
97 2010-06-15  Adam Barth  <abarth@webkit.org>
98
99         Reviewed by Eric Seidel.
100
101         Enable HTML5 lexer
102         https://bugs.webkit.org/show_bug.cgi?id=40650
103
104         * DumpRenderTree/mac/DumpRenderTree.mm:
105         (initializeGlobalsFromCommandLineOptions):
106
107 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
108
109         Reviewed by Shinichiro Hamaji.
110
111         Implement render style selection for pages to support CSS3 Paged Media.
112         https://bugs.webkit.org/show_bug.cgi?id=35961
113
114         * DumpRenderTree/LayoutTestController.cpp:
115         (parsePagePropertyParameters):
116         (pagePropertyCallback):
117         (LayoutTestController::staticFunctions):
118         * DumpRenderTree/LayoutTestController.h:
119         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
120         (LayoutTestController::pageProperty):
121         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
122         (LayoutTestController::pageProperty):
123         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
124         (LayoutTestController::pageProperty):
125
126 2010-06-15  Sam Weinig  <sam@webkit.org>
127
128         Reviewed by Anders Carlsson.
129
130         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
131         WebKit2: Add mechanism to inject code into the WebProcess on startup
132
133         Add initial InjectedBundle support.
134
135         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
136         * MiniBrowser/WebBundle-Info.plist: Added.
137         Add test InjectedBundle to the project.
138
139         * MiniBrowser/mac/AppDelegate.m:
140         (-[BrowserAppDelegate init]):
141         Get the path to the WebBundle from the the main bundle and pass it to the new
142         WKContextCreateWithInjectedBundlePath function.
143
144         * MiniBrowser/mac/BrowserWindowController.m:
145         (_didChangeProgress):
146         Fix the build.  This has been broken for a while.
147
148         * MiniBrowser/mac/WebBundle: Added.
149         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
150         (_didCreatePage):
151         (WKBundleInitialize):
152         Add really basic InjectedBundle.
153
154         * MiniBrowser/win/BrowserView.cpp:
155         (BrowserView::create):
156         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
157
158 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
159
160         Reviewed by Darin Adler.
161
162         Adding myself to the reviewers list.
163         https://bugs.webkit.org/show_bug.cgi?id=40693
164
165         * Scripts/webkitpy/common/config/committers.py:
166
167 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
168
169         Reviewed by Xan Lopez.
170
171         Switch to using GIO methods instead of realpath in GtkLauncher to determine
172         the file URI. This should remove warnings about realpath being undefined
173         when compiling with '-ansi'.
174
175         * GtkLauncher/main.c:
176         (filenameToURL): Use GIO instead of realpath to determine file URI.
177
178 2010-06-15  Adam Roben  <aroben@apple.com>
179
180         Remove the redundant set-apple-windows-environment-variables script
181
182         Apparently update-webkit does this for you these days.
183
184         Rubber-stamped by Steve Falkenburg.
185
186         * Scripts/set-apple-windows-environment-variables: Removed.
187
188 2010-06-14  Adam Roben  <aroben@apple.com>
189
190         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
191         environment variables
192
193         Fixes <http://webkit.org/b/40595>.
194
195         Reviewed by Steve Falkenburg.
196
197         * Scripts/set-apple-windows-environment-variables: Added.
198         (to_windows_path): Passes the passed-in path through cygpath to
199         generate a Windows-style path.
200         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
201         variables to their defaults, if they aren't already set.
202
203 2010-06-14  Adam Roben  <aroben@apple.com>
204
205         Speed up run-safari/debug-safari on Windows
206
207         Fixes <http://webkit.org/b/40586>.
208
209         Reviewed by Steve Falkenburg.
210
211         * Scripts/webkitdirs.pm:
212         (runSafari): When debugging, set up the environment to run Safari
213         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
214         actually launch the debugger. When not debugging, just run WebKit.exe
215         and it will do the rest for us.
216
217 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
218
219         Reviewed by Kenneth Rohde Christiansen.
220
221         [Qt] DRT EventSender support to graphics context events
222         https://bugs.webkit.org/show_bug.cgi?id=40324
223
224         * DumpRenderTree/qt/EventSenderQt.cpp:
225         (EventSender::contextClick):
226
227 2010-06-14  Tony Chang  <tony@chromium.org>
228
229         Reviewed by Darin Fisher.
230
231         [chromium] checkout chromium third_party directly
232         https://bugs.webkit.org/show_bug.cgi?id=40556
233
234         * Scripts/update-webkit-chromium: some migration code for the bots
235
236 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
237
238         Chromium build fix.
239
240         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
241         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
242
243 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
244
245         Reviewed by Darin Adler.
246
247         https://bugs.webkit.org/show_bug.cgi?id=40529
248         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
249
250         * DumpRenderTree/mac/EventSendingController.mm:
251         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
252         event for "delete" - it had virtual key code from forward delete, and text from backspace.
253         Fixed "delete" to mean forward delete.
254
255         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
256         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
257         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
258         Mac DRT confusion has propagated to other platforms, fixing those.
259
260 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
261
262         Reviewed by Xan Lopez.
263
264         Small GtkLauncher build fix for some systems.
265
266         * GtkLauncher/main.c: Add <limit.h> include.
267
268 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
269
270         Reviewed by Laszlo Gombos.
271
272         [Qt] navigator.geolocation support for Qt port
273         https://bugs.webkit.org/show_bug.cgi?id=39724
274
275         Implementation for geolocation cases to DumpRenderTreeQt
276
277         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
278         (WebCore::WebPage::allowGeolocationRequest):
279         * DumpRenderTree/qt/DumpRenderTreeQt.h:
280         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
281         (LayoutTestController::setGeolocationPermission):
282         (LayoutTestController::setMockGeolocationError):
283         (LayoutTestController::setMockGeolocationPosition):
284         * DumpRenderTree/qt/LayoutTestControllerQt.h:
285         (LayoutTestController::isGeolocationPermissionSet):
286         (LayoutTestController::geolocationPermission):
287
288 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
289
290         Reviewed by Darin Adler.
291
292         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
293         be a way of overwriting the Xcode system path.  Making
294         $WEBKITOUTPUTDIR take precedence over the system default would make
295         this possible.
296
297         * Scripts/webkitdirs.pm:
298
299 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
300
301         Reviewed by Darin Adler.
302
303         AX: link won't return linked element if URL contains #
304         https://bugs.webkit.org/show_bug.cgi?id=40192
305
306         * DumpRenderTree/AccessibilityUIElement.cpp:
307         (linkedUIElementAtIndexCallback):
308         (AccessibilityUIElement::getJSClass):
309         * DumpRenderTree/AccessibilityUIElement.h:
310         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
311         (AccessibilityUIElement::linkedUIElementAtIndex):
312         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
313         (AccessibilityUIElement::linkedUIElementAtIndex):
314         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
315         (AccessibilityUIElement::linkedUIElementAtIndex):
316
317 2010-06-13  Adam Barth  <abarth@webkit.org>
318
319         Reviewed by Darin Adler.
320
321         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
322         https://bugs.webkit.org/show_bug.cgi?id=39550
323
324         This can cause an extra request to bugs.webkit.org durig upload, but it
325         shouldn't be too bad.  Also, this won't work if you remove the
326         boilerplate created by prepare-ChangeLog.
327
328         * Scripts/webkitpy/common/checkout/changelog.py:
329         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
330         * Scripts/webkitpy/common/net/bugzilla.py:
331         * Scripts/webkitpy/tool/steps/abstractstep.py:
332         * Scripts/webkitpy/tool/steps/preparechangelog.py:
333         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
334
335 2010-06-08  Robert Hogan  <robert@webkit.org>
336
337         Reviewed by Eric Seidel.
338
339         [Qt] Add support for callShouldCloseOnWebView() to DRT
340         https://bugs.webkit.org/show_bug.cgi?id=40330
341
342         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
343         (LayoutTestController::callShouldCloseOnWebView):
344         * DumpRenderTree/qt/LayoutTestControllerQt.h:
345         (LayoutTestController::setCallCloseOnWebViews):
346
347 2010-06-12  Eric Seidel  <eric@webkit.org>
348
349         Reviewed by Daniel Bates.
350
351         do-webcore-rename should have a --verbose option
352         https://bugs.webkit.org/show_bug.cgi?id=40497
353
354         * Scripts/do-webcore-rename:
355          - Unified how we handle skipping files/directories
356            this will allow us to "black list" certain files and
357            directories when performing renames.
358          - Made do-webcore-rename log what it's skipping when passed --verbose.
359
360 2010-06-12  Darin Adler  <darin@apple.com>
361
362         * Scripts/run-bindings-tests: Fixed a typo in a message.
363
364 2010-06-12  Kent Tamura  <tkent@chromium.org>
365
366         Reviewed by Dimitri Glazkov.
367
368         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
369         https://bugs.webkit.org/show_bug.cgi?id=40402
370
371         _build_path() of each Chromium port check existence of build path
372         of Chromium checkout first, then check existence of build path of
373         WebKit-only checkout.
374
375         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
376         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
377         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
378
379 2010-06-12  Robert Hogan  <robert@webkit.org>
380
381         Reviewed by Kenneth Rohde Christiansen.
382
383         [Qt] Back-forward list dumping is incorrect
384
385         https://bugs.webkit.org/show_bug.cgi?id=36392
386
387         Support dumping child history items in DRT.
388
389         Unskip:
390
391         fast/loader/frame-src-change-added-to-history.html
392         fast/loader/frame-src-change-not-added-to-history.html
393         fast/loader/frame-location-change-not-added-to-history.html
394
395         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
396         (WebCore::dumpHistoryItem):
397
398 2010-06-10  Ojan Vafai  <ojan@chromium.org>
399
400         Reviewed by Eric Seidel.
401
402         upload all patches that lack in-rietveld to rietveld
403         https://bugs.webkit.org/show_bug.cgi?id=40444
404
405         If it's a patch, then we'll try to upload it as long as it
406         doesn't have in-rietveld set. No longer set in-rietveld? since
407         it's not needed.
408
409         * Scripts/webkitpy/common/net/bugzilla.py:
410
411 2010-06-10  Ojan Vafai  <ojan@chromium.org>
412
413         Reviewed by Darin Fisher.
414
415         Fix rietveld upload when message length > 100 characters
416         https://bugs.webkit.org/show_bug.cgi?id=40457
417
418         * Scripts/webkitpy/common/net/rietveld.py:
419
420 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
421
422         Reviewed by Laszlo Gombos.
423
424         [Qt] There should be a way to enable popups in QtTestBrowser
425         https://bugs.webkit.org/show_bug.cgi?id=40427
426
427         * QtTestBrowser/main.cpp:
428         (LauncherWindow::toggleJavascriptCanOpenWindows):
429         (LauncherWindow::createChrome):
430
431 2010-06-10  Adam Barth  <abarth@webkit.org>
432
433         Reviewed by Daniel Bates.
434
435         Make SheriffBot more chatty
436         https://bugs.webkit.org/show_bug.cgi?id=40463
437
438         People seem to like to talk to SheriffBot, so let's make him chat back.
439
440         * Scripts/webkitpy/thirdparty/__init__.py:
441         * Scripts/webkitpy/tool/bot/irc_command.py:
442         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
443         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
444         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
445
446 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
447
448         Reviewed by Darin Adler.
449
450         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
451         
452         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
453         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
454         WEXITSTATUS on $result instead of just comparing $result to 0.
455
456         * Scripts/update-webkit-auxiliary-libs:
457
458 2010-06-10  Ojan Vafai  <ojan@chromium.org>
459
460         Reviewed by Alexey Proskuryakov.
461
462         don't use Exception.message as it's deprecated in python 2.6+
463         https://bugs.webkit.org/show_bug.cgi?id=40449
464
465         * Scripts/webkitpy/tool/commands/queues.py:
466
467 2010-06-10  Ojan Vafai  <ojan@chromium.org>
468
469         Reviewed by Adam Barth.
470
471         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
472         https://bugs.webkit.org/show_bug.cgi?id=40436
473
474         * Scripts/webkitpy/common/system/outputcapture.py:
475         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
476         * Scripts/webkitpy/tool/commands/queues.py:
477         * Scripts/webkitpy/tool/commands/queues_unittest.py:
478         * Scripts/webkitpy/tool/commands/queuestest.py:
479         * Scripts/webkitpy/tool/mocktool.py:
480
481 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
482
483         Reviewed by Simon Hausmann.
484
485         [Qt] *All* WebGL layout tests fail!
486         https://bugs.webkit.org/show_bug.cgi?id=40296
487
488         Added test for WebKitWebGLEnabled to
489         LayoutTestController::overridePreference().
490
491         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
492         (LayoutTestController::overridePreference):
493
494 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
495
496         Reviewed by Kenneth Rohde Christiansen.
497
498         [Qt] DRT EventSender support to graphics mouse events activation
499         https://bugs.webkit.org/show_bug.cgi?id=40017
500
501         * DumpRenderTree/qt/EventSenderQt.cpp:
502         (EventSender::mouseDown):
503         (EventSender::mouseUp):
504         (EventSender::mouseMoveTo):
505         (EventSender::keyDown):
506         (EventSender::contextClick):
507         (EventSender::sendTouchEvent):
508         (EventSender::sendOrQueueEvent):
509         (EventSender::eventFilter):
510         (EventSender::createGraphicsSceneMouseEvent):
511         (EventSender::sendEvent):
512         * DumpRenderTree/qt/EventSenderQt.h:
513         (EventSender::isGraphicsBased):
514
515 2010-06-09  Adam Barth  <abarth@webkit.org>
516
517         Reviewed by Ojan Vafai.
518
519         webkit-patch upload fails for security bugs because there's no rietveld flag
520         https://bugs.webkit.org/show_bug.cgi?id=40309
521
522         There's probably a more elegant way of seeing whether the form control
523         exists, but this seems to work.
524
525         * Scripts/webkitpy/common/net/bugzilla.py:
526
527 2010-06-09  Ojan Vafai  <ojan@chromium.org>
528
529         Reviewed by Adam Barth.
530
531         make rietveld upload faster and avoid posting to bug on errors
532         https://bugs.webkit.org/show_bug.cgi?id=40389
533
534         Only grab the first item of the upload queue instead of trying
535         to compute the whole list upfront (which is O(n) bugzilla lookups!).
536
537         Also, don't post comments to the bug when uploading fails.
538
539         * Scripts/webkitpy/common/net/bugzilla.py:
540         * Scripts/webkitpy/tool/commands/queues.py:
541         * Scripts/webkitpy/tool/commands/queues_unittest.py:
542         * Scripts/webkitpy/tool/commands/stepsequence.py:
543         * Scripts/webkitpy/tool/mocktool.py:
544
545 2010-06-09  Ojan Vafai  <ojan@chromium.org>
546
547         Reviewed by Adam Barth.
548
549         Rietveld upload queue fails when setting in-rietveld flag
550         https://bugs.webkit.org/show_bug.cgi?id=40371
551
552         Make the comment arguments to set_flag_on_attachment optional
553         and add it to the MockBugzilla.
554
555         * Scripts/webkitpy/common/net/bugzilla.py:
556         * Scripts/webkitpy/tool/bot/queueengine.py:
557         * Scripts/webkitpy/tool/commands/download_unittest.py:
558         * Scripts/webkitpy/tool/commands/queues.py:
559         * Scripts/webkitpy/tool/commands/queues_unittest.py:
560         * Scripts/webkitpy/tool/mocktool.py:
561
562 2010-06-09  Kenneth Russell  <kbr@google.com>
563
564         Reviewed by Dimitri Glazkov.
565
566         Rename FloatArray to Float32Array
567         https://bugs.webkit.org/show_bug.cgi?id=40323
568
569         Used do-webcore-rename to perform renaming. Manually undid
570         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
571         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
572         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
573         all layout tests on Safari; built Chromium and ran selected WebGL
574         tests.
575
576         * Scripts/do-webcore-rename:
577
578 2010-06-08  Tony Chang  <tony@chromium.org>
579
580         Reviewed by David Levin.
581
582         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
583         https://bugs.webkit.org/show_bug.cgi?id=40285
584
585         * Scripts/webkitdirs.pm:
586         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
587
588 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
589
590         Reviewed by Tamura Kent.
591
592         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
593         https://bugs.webkit.org/show_bug.cgi?id=40052
594         
595         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
596
597         * DumpRenderTree/DumpRenderTree.gypi:
598         * DumpRenderTree/chromium/TestShellWin.cpp:
599         (platformInit):
600         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
601         (WebKit::):
602         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
603         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
604         (WebKit::WebThemeControlDRT::box):
605         (WebKit::WebThemeControlDRT::line):
606         (WebKit::WebThemeControlDRT::triangle):
607         (WebKit::WebThemeControlDRT::roundRect):
608         (WebKit::WebThemeControlDRT::oval):
609         (WebKit::WebThemeControlDRT::circle):
610         (WebKit::WebThemeControlDRT::nestedBoxes):
611         (WebKit::WebThemeControlDRT::markState):
612         (WebKit::WebThemeControlDRT::draw):
613         (WebKit::WebThemeControlDRT::drawTextField):
614         (WebKit::WebThemeControlDRT::drawProgressBar):
615         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
616         (WebKit::WebThemeControlDRT::):
617         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
618         (WebKit::):
619         (WebKit::WebThemeEngineDRT::paintButton):
620         (WebKit::WebThemeEngineDRT::paintMenuList):
621         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
622         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
623         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
624         (WebKit::WebThemeEngineDRT::paintTextField):
625         (WebKit::WebThemeEngineDRT::paintTrackbar):
626         (WebKit::WebThemeEngineDRT::paintProgressBar):
627         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
628         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
629
630 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
631
632         Unreviewed, rolling out r60878.
633         http://trac.webkit.org/changeset/60878
634         https://bugs.webkit.org/show_bug.cgi?id=40349
635
636         broke linux build (Requested by tony^work on #webkit).
637
638         * Scripts/webkitdirs.pm:
639         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
640
641 2010-06-08  Tony Chang  <tony@chromium.org>
642
643         Reviewed by David Levin.
644
645         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
646         https://bugs.webkit.org/show_bug.cgi?id=40285
647
648         * Scripts/webkitdirs.pm:
649         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
650
651 2010-06-08  Kenneth Russell  <kbr@google.com>
652
653         Unreviewed, build fix.
654
655         Fix build breakage from 38145
656         https://bugs.webkit.org/show_bug.cgi?id=40346
657
658         The fix for bug 38145 broke the Chromium Win build because
659         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
660         change log2(x) to log(x) / log(2). Built and ran WebGL layout
661         tests in Safari on Mac OS X. Changed download mirrors for
662         python-irclib to working ones.
663
664         * Scripts/webkitpy/thirdparty/__init__.py:
665
666 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
667
668         Reviewed by Eric Seidel.
669
670         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
671         https://bugs.webkit.org/show_bug.cgi?id=39058
672
673         * Scripts/old-run-webkit-tests:
674          use sourceDir() to find ensure-valid-python in checkPythonVersion()
675
676 2010-06-08  Andras Becsi  <abecsi@webkit.org>
677
678         Unreviewed buildfix after r60479.
679
680         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
681         versions other than 2.17.3.
682
683         * DumpRenderTree/gtk/EventSender.cpp:
684         (getRootCoords):
685
686 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
687
688         Reviewed by Oliver Hunt.
689
690         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
691         https://bugs.webkit.org/show_bug.cgi?id=40267
692
693         When a mouse button is down, automatically queue mouse motion events and
694         do not play them back until the mouse button is released. This matches the
695         behavior of other ports' EventSenders.
696
697         * DumpRenderTree/gtk/EventSender.cpp:
698         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
699         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
700
701 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
702
703         Reviewed by Sam Weinig.
704
705         Add CPP bindings generator
706         https://bugs.webkit.org/show_bug.cgi?id=38279
707
708         Integrate CPP bindings in run-bindings-tests.
709
710         * Scripts/run-bindings-tests:
711
712 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
713
714         Reviewed by Ojan Vafai.
715
716         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
717         https://bugs.webkit.org/show_bug.cgi?id=40183
718
719         * Scripts/webkitpy/tool/steps/preparechangelog.py:
720
721 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
722
723         Unreviewed.
724
725         Add my new email and IRC nick to committers.py.
726
727         * Scripts/webkitpy/common/config/committers.py:
728
729 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
730
731         Unreviewed.
732
733         Revert changes in json_results_generator.py's _get_svn_revision.
734
735         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
736
737 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
738
739         Reviewed by Xan Lopez.
740
741         [GTK] GtkLauncher should support relative file paths
742         https://bugs.webkit.org/show_bug.cgi?id=39944
743
744         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
745
746         * GtkLauncher/main.c:
747         (filename_to_url): Added.
748         (main): Try to resolve arguments as relative file URLs first.
749
750 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
751
752         Reviewed by Xan Lopez.
753
754         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
755         https://bugs.webkit.org/show_bug.cgi?id=40182
756
757         Instead of invoking signal handlers directly via g_signal_emit_by_name, call
758         gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
759         without breaking DRT.
760
761         * DumpRenderTree/gtk/EventSender.cpp:
762         (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
763         (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
764
765 2010-06-04  Anders Carlsson  <andersca@apple.com>
766
767         Reviewed by David Hyatt.
768
769         Make the editing/spelling/context-menu-suggestions.html test more robust
770         https://bugs.webkit.org/show_bug.cgi?id=40178
771
772         Change the contextClick method to return an array of strings describing the context menu items.
773
774         * DumpRenderTree/mac/EventSendingController.mm:
775         (+[EventSendingController isSelectorExcludedFromWebScript:]):
776         (+[EventSendingController webScriptNameForSelector:]):
777         (-[EventSendingController contextClick]):
778
779 2010-06-03  Kinuko Yasuda  <kinuko@chromium.org>
780
781         Reviewed by Shinichiro Hamaji.
782
783         Clean up chromium-specific code from json_results_generator.py.
784         https://bugs.webkit.org/show_bug.cgi?id=39665
785
786         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
787         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
788         * Scripts/webkitpy/layout_tests/port/base.py:
789         * Scripts/webkitpy/layout_tests/port/chromium.py:
790
791 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
792
793         Reviewed by Adam Barth.
794
795         Utilize new takeFirst() method where appropriate.
796         https://bugs.webkit.org/show_bug.cgi?id=40089
797
798         * DumpRenderTree/chromium/EventSender.cpp:
799         (EventSender::replaySavedEvents):
800         * DumpRenderTree/chromium/LayoutTestController.cpp:
801         (LayoutTestController::WorkQueue::processWork):
802         (LayoutTestController::WorkQueue::reset):
803
804 2010-06-04  Yael Aharon  <yael.aharon@nokia.com>
805
806         Reviewed by Simon Hausmann.
807
808         [Qt] QtTestLauncher should allow notifications by default.
809         https://bugs.webkit.org/show_bug.cgi?id=40078
810
811         * QtTestBrowser/main.cpp:
812         (NotificationsPermissionController::NotificationsPermissionController):
813         (NotificationsPermissionController::checkPermission):
814         (NotificationsPermissionController::requestPermission):
815         (LauncherWindow::LauncherWindow):
816
817 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
818
819         Reviewed by Adam Barth.
820
821         Detect whether the user's environment can open a browser.
822         https://bugs.webkit.org/show_bug.cgi?id=40136
823
824         Some environments like cygwin silently fail webbrowser.open() causing
825         webkit-patch upload not to display any diff. This detects environments
826         where webbrowser.open() would fail by testing if webbrowser.get()
827         raises an exception.
828
829         * Scripts/webkitpy/common/system/user.py:
830         * Scripts/webkitpy/tool/mocktool.py:
831         * Scripts/webkitpy/tool/steps/confirmdiff.py:
832
833 2010-06-03  Tony Gentilcore  <tonyg@chromium.org>
834
835         Reviewed by David Levin.
836
837         Add dependencies required to link with VS Express 2005.
838         https://bugs.webkit.org/show_bug.cgi?id=40038
839
840         Visual Studio implicitly links against these libs.
841         VC++ Express does not.
842
843         * WebKitAPITest/WebKitAPITestCommon.vsprops:
844         * WinLauncher/WinLauncher.vcproj:
845
846 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
847
848         Reviewed by David Levin.
849
850         bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
851         https://bugs.webkit.org/show_bug.cgi?id=40105
852
853         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
854         - kill pywebsocket process when url is not alive and the process is not
855           terminated, not to leave pywebsocket server running.
856         - fix codecs.open parameters.
857
858 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
859
860         Reviewed by Alexey Proskuryakov.
861
862         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
863         https://bugs.webkit.org/show_bug.cgi?id=39058
864
865         * Scripts/ensure-valid-python:
866           - Perl 5.8 doesn't have File::Temp->newdir().  Use File::Temp->tempdir() instead.
867           - Add --check-only and --help option.
868           - --check-only option only checks python version and don't try to install Python 2.5.
869           - Set executable bit.
870         * Scripts/old-run-webkit-tests:
871           - Check if it can run the websocket tests by calling ensure-valid-python --check-only.
872
873 2010-05-14  Ojan Vafai  <ojan@chromium.org>
874
875         Reviewed by Adam Barth.
876
877         add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
878         https://bugs.webkit.org/show_bug.cgi?id=38918
879
880         Patches with in-rietveld? get uploaded to rietveld and get marked
881         in-rietveld+. If the upload fails, they are marked in-rietveld-
882         and an error is logged to the bug, like the commit-queue.
883
884         Also, get rid of --fancy-review and the ability to upload to rietveld
885         using webkit-patch upload/post.
886
887         * Scripts/webkitpy/common/net/bugzilla.py:
888         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
889         * Scripts/webkitpy/tool/commands/download.py:
890         * Scripts/webkitpy/tool/commands/download_unittest.py:
891         * Scripts/webkitpy/tool/commands/queues.py:
892         * Scripts/webkitpy/tool/commands/queues_unittest.py:
893         * Scripts/webkitpy/tool/commands/upload.py:
894         * Scripts/webkitpy/tool/commands/upload_unittest.py:
895         * Scripts/webkitpy/tool/mocktool.py:
896         * Scripts/webkitpy/tool/steps/options.py:
897         * Scripts/webkitpy/tool/steps/postcodereview.py:
898
899 2010-05-24  Ojan Vafai  <ojan@chromium.org>
900
901         Reviewed by Chris Jerdonek.
902
903         many webkit-patch commands fail in a non-svn tracking git checkout
904         https://bugs.webkit.org/show_bug.cgi?id=38156
905
906         If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
907         If neither exists, then error out. This makes webkit-patch work
908         for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
909         to checkout webkit. The fallback to master is for people who don't
910         do the steps on that page for tracking svn.
911
912         * Scripts/webkitpy/common/checkout/scm.py:
913         * Scripts/webkitpy/common/checkout/scm_unittest.py:
914
915 2010-06-03  Mike Fenton  <mifenton@rim.com>
916
917         Unreviewed.
918
919         Reverse e-mail for myself in committers.py to correspond with bugzilla account.
920
921         * Scripts/webkitpy/common/config/committers.py:
922
923 2010-06-03  Pavel Feldman  <pfeldman@chromium.org>
924
925         Reviewed by Yury Semikhatsky.
926
927         Web Inspector: a number of fixes that make InspectorController
928         happy with null redirects.
929
930         https://bugs.webkit.org/show_bug.cgi?id=40109
931
932         * DumpRenderTree/gtk/DumpRenderTree.cpp:
933         (runTest):
934         * DumpRenderTree/mac/DumpRenderTree.mm:
935         (runTest):
936         * DumpRenderTree/win/DumpRenderTree.cpp:
937         (runTest):
938
939 2010-06-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>
940
941         Reviewed by Shinichiro Hamaji.
942
943         [Qt] Fix compilation with QT_NO_PROPERTIES
944         https://bugs.webkit.org/show_bug.cgi?id=38324
945
946         * QtTestBrowser/main.cpp:
947         (LauncherWindow::init):
948
949 2010-06-02  Diego Gonzalez  <diegohcg@webkit.org>
950
951         Reviewed by Kenneth Rohde Christiansen.
952
953         [Qt] Make possible run DRT with QGraphicsWebView
954         https://bugs.webkit.org/show_bug.cgi?id=40016
955
956         Make possible to use a environment variable for switching backend.
957         Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
958
959         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
960         (WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
961         (WebCore::DumpRenderTree::DumpRenderTree):
962         * DumpRenderTree/qt/DumpRenderTreeQt.h:
963         (WebCore::DumpRenderTree::setGraphicsBased):
964         (WebCore::DumpRenderTree::isGraphicsBased):
965         (WebCore::WebViewGraphicsBased::graphicsView):
966         (WebCore::WebViewGraphicsBased::setPage):
967         * Scripts/old-run-webkit-tests:
968
969 2010-06-02  Csaba Osztrogon√°c  <ossy@webkit.org>
970
971         Reviewed by Eric Seidel.
972
973         Slave lost shouldn't be recognized as build failed.
974         https://bugs.webkit.org/show_bug.cgi?id=39282
975
976         * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
977         * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
978
979 2010-06-01  Yael Aharon  <yael.aharon@nokia.com>
980
981         Reviewed by Kenneth Rohde Christiansen.
982
983         [Qt] Fix the lifecycle of notification objects
984         https://bugs.webkit.org/show_bug.cgi?id=40003
985
986         Remove the dependency of notifications on QWebPage.
987
988         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
989         (WebCore::requestPermissionCallback):
990         (WebCore::WebPage::WebPage):
991         (WebCore::DumpRenderTree::requestPermission):
992         * DumpRenderTree/qt/DumpRenderTreeQt.h:
993
994 2010-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
995
996         Unreviewed, rolling out r60559.
997         http://trac.webkit.org/changeset/60559
998         https://bugs.webkit.org/show_bug.cgi?id=40055
999
1000         It broke python unit test (Requested by Ossy on #webkit).
1001
1002         * Scripts/webkitpy/common/net/buildbot.py:
1003
1004 2010-06-02  Csaba Osztrogon√°c  <ossy@webkit.org>
1005
1006         Reviewed by Eric Seidel.
1007
1008         Slave lost shouldn't be recognized as build failed.
1009         https://bugs.webkit.org/show_bug.cgi?id=39282
1010
1011         * Scripts/webkitpy/common/net/buildbot.py:
1012
1013 2010-06-02  Tony Gentilcore  <tonyg@chromium.org>
1014
1015         Reviewed by Eric Seidel.
1016
1017         Fix crash caused when assigned_to is disabled
1018         https://bugs.webkit.org/show_bug.cgi?id=40039
1019
1020         * Scripts/webkitpy/common/net/bugzilla.py:
1021
1022 2010-06-02  Sterling Swigart  <sswigart@google.com>
1023
1024         Reviewed by David Levin.
1025
1026         Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
1027         https://bugs.webkit.org/show_bug.cgi?id=39906
1028
1029         * Scripts/build-webkit:
1030
1031 2010-06-01  Raine Makelainen  <raine.makelainen@nokia.com>
1032
1033         Reviewed by Simon Hausmann.
1034
1035         Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.
1036
1037         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1038         (WebCore::WebPage::WebPage):
1039         (WebCore::WebPage::resetSettings):
1040         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1041         (LayoutTestController::setJavaScriptCanAccessClipboard):
1042
1043 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1044
1045         Reviewed by Mark Rowe.
1046
1047         A nicer Tiger build fix.
1048
1049         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1050         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1051         Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
1052
1053 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1054
1055         A real Tiger build fix.
1056
1057         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS
1058         for all configurations, not just debug.
1059
1060 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1061
1062         Tiger build fix.
1063
1064         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
1065
1066 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1067
1068         Reviewed by Xan Lopez.
1069
1070         [GTK] Get more mouse tests passing
1071         https://bugs.webkit.org/show_bug.cgi?id=39040
1072
1073         Reproduce the logic from the Windows EventSender for mapping
1074         button numbers to GDK button numbers. Move this logic to the
1075         prepareMouseButtonEvent helper.
1076
1077         * DumpRenderTree/gtk/EventSender.cpp:
1078         (prepareMouseButtonEvent): Reproduce Windows logic.
1079         (contextClickCallback): Move mapping logic to prepareMouseButtonEvent.
1080         (mouseDownCallback): Ditto.
1081         (mouseUpCallback): Ditto.
1082
1083 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1084
1085         Reviewed by Sam Weinig.
1086
1087         https://bugs.webkit.org/show_bug.cgi?id=39434
1088         REGRESSION (r59811): Geolocation callbacks cannot be created
1089
1090         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider.
1091
1092         * DumpRenderTree/mac/DumpRenderTree.mm:
1093         (createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider. 
1094         (resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak
1095         into subsequent tests.
1096
1097         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1098         (LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider.
1099         (LayoutTestController::setMockGeolocationError): Ditto.
1100
1101         * DumpRenderTree/mac/MockGeolocationProvider.h: Added.
1102         * DumpRenderTree/mac/MockGeolocationProvider.mm: Added.
1103         (+[MockGeolocationProvider shared]):
1104         (-[MockGeolocationProvider dealloc]):
1105         (-[MockGeolocationProvider setPosition:]):
1106         (-[MockGeolocationProvider setError:]):
1107         (-[MockGeolocationProvider registerWebView:]):
1108         (-[MockGeolocationProvider unregisterWebView:]):
1109         (-[MockGeolocationProvider lastPosition]):
1110         (-[MockGeolocationProvider stopTimer]):
1111         (-[MockGeolocationProvider timerFired]):
1112
1113         * DumpRenderTree/mac/UIDelegate.mm:
1114         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1115         This delegate method must send a response. I'm not sure what the two-stage check is supposed
1116         to achieve, it seems unnecessary.
1117
1118 2010-05-12  Martin Robinson  <mrobinson@igalia.com>
1119
1120         Reviewed by Xan Lopez.
1121
1122         [GTK] Double clicks cause three button press events
1123         https://bugs.webkit.org/show_bug.cgi?id=38853
1124
1125         WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
1126         and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
1127         the GDK event queue entirely, we simply do not send the extra event.
1128
1129         * DumpRenderTree/gtk/EventSender.cpp:
1130         (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately.
1131         (dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
1132
1133 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1134
1135         Not reviewed. Build fix.
1136
1137         Fix GTK+ build caused by a bad merge.
1138
1139         * DumpRenderTree/gtk/EventSender.cpp: 
1140         (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
1141
1142 2010-06-01  Martin Robinson  <mrobinson@webkit.org>
1143
1144         Reviewed by Xan Lopez.
1145
1146         [GTK] Double clicks cause three button press events
1147         https://bugs.webkit.org/show_bug.cgi?id=38853
1148
1149         Small EventSender cleanups. Consolidate some common code. Style fixes.
1150
1151         * DumpRenderTree/gtk/EventSender.cpp:
1152         (prepareMouseButtonEvent): Added.
1153         (contextClickCallback): Use prepareMouseButtonEvent.
1154         (mouseDownCallback): Use prepareMouseButtonEvent.
1155         (mouseUpCallback): Use prepareMouseButtonEvent.
1156         (mouseMoveToCallback): Small style fix.
1157
1158 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1159
1160         Reviewed by Xan Lopez.
1161
1162         [GTK] Double clicks cause three button press events
1163         https://bugs.webkit.org/show_bug.cgi?id=38853
1164
1165         Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test
1166         to pause for a specified amount of time. It is used in the processing of drag-
1167         -and-drop data as well as to separate distinct mouse double-clicks in some tests.
1168         This patch enables tests that rely on the latter behavior to pass.
1169
1170         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1171         (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame.
1172         * DumpRenderTree/gtk/EventSender.cpp:
1173         (leapForwardCallback): Add support for adjusting the time offset on leapForward().
1174         (contextClickCallback): Use sendOrQueueEvent.
1175         (updateClickCount): Take the time offset into account when counting clicks.
1176         (mouseDownCallback): Use sendOrQueueEvent.
1177         (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton.
1178         (mouseUpCallback): Use sendOrQueueEvent.
1179         (mouseMoveToCallback): Ditto.
1180         (mouseWheelToCallback): Ditto.
1181         (sendOrQueueEvent): Added.
1182         (dispatchEvent): Added.
1183         (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent.
1184         (makeEventSender): Only initialize the EventSender when loading the top frame.
1185         * DumpRenderTree/gtk/EventSender.h: Ditto.
1186
1187 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1188
1189         Reviewed by Xan Lopez.
1190
1191         [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
1192         https://bugs.webkit.org/show_bug.cgi?id=39101
1193
1194         Work around timing issues for render tree dumps by pumping the
1195         main loop before doing the dump. Resize events are asynchronous
1196         in GTK+, so sometimes resize requests are still pending when DRT
1197         dumps the tree.
1198
1199         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1200         (dump): Pump the main loop before dumping the render tree.
1201
1202 2010-05-31  Kent Tamura  <tkent@chromium.org>
1203
1204         Reviewed by Dimitri Glazkov.
1205
1206         [DRT/Chromium] Fix crash of a test after another test with multiple windows
1207         https://bugs.webkit.org/show_bug.cgi?id=39942
1208
1209         If a test opens multiple windows, focuses on non-main window, and
1210         the focused window is closed, TestShell::m_focusedWidget points a
1211         deleted object.
1212
1213         * DumpRenderTree/chromium/TestShell.cpp:
1214         (TestShell::closeWindow): Clear m_focusedWidget.
1215
1216 2010-05-30  Kent Tamura  <tkent@chromium.org>
1217
1218         Reviewed by Dimitri Glazkov.
1219
1220         new-run-webkit-tests: Support DRT on Chromium-win
1221         https://bugs.webkit.org/show_bug.cgi?id=39810
1222
1223         Add --test-shell flag to DRT/Chromium, and it changes DRT so that
1224         it behaves like test_shell about command analysis, printing
1225         format, pixel dumping, and timeout handling.
1226
1227         chromium.py and chromium_win.py supports the --test-shell flag and
1228         DRT/Chromium-win binary names.
1229         
1230         * DumpRenderTree/DumpRenderTree.gypi: Add new files.
1231         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1232         (runTest): Support for test_shell-style command.
1233         (main): Introduce --test-shell.
1234         * DumpRenderTree/chromium/TestEventPrinter.cpp: Added.
1235         * DumpRenderTree/chromium/TestEventPrinter.h: Added.
1236           TestEventPrinter class manages stdio output and image output.
1237           TestEventPrinter.cpp has two implementations; DRTPrinter and
1238           TestShellPrinter.
1239         * DumpRenderTree/chromium/TestShell.cpp:
1240           Some changes for TestEventPrinter.
1241         (TestShell::TestShell):
1242         (TestShell::runFileTest):
1243         (TestShell::testTimedOut):
1244         (TestShell::dump):
1245         (TestShell::dumpImage):
1246         * DumpRenderTree/chromium/TestShell.h:
1247         (TestShell::printer):
1248         (TestShell::layoutTestTimeout):
1249         (TestShell::layoutTestTimeoutForWatchDog):
1250         (TestShell::setLayoutTestTimeout):
1251         * DumpRenderTree/chromium/TestShellWin.cpp:
1252         (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog().
1253         * Scripts/webkitpy/layout_tests/port/chromium.py:
1254         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1255
1256 2010-05-30  Robert Hogan  <robert@webkit.org>
1257
1258         Reviewed by Kenneth Rohde Christiansen.
1259
1260         [Qt] Enhance Qt DRT implementation to support platform scroll wheel events.
1261
1262         https://bugs.webkit.org/show_bug.cgi?id=36004
1263
1264         * DumpRenderTree/qt/EventSenderQt.cpp:
1265         (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match
1266                                     Scrollbar::pixelsPerLineStep() for DRT testing.
1267         (EventSender::mouseScrollBy): Added
1268         (EventSender::continuousMouseScrollBy): Added
1269         * DumpRenderTree/qt/EventSenderQt.h:
1270
1271 2010-05-28  Adam Barth  <abarth@webkit.org>
1272
1273         Reviewed by David Levin.
1274
1275         webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
1276         https://bugs.webkit.org/show_bug.cgi?id=39546
1277
1278         One sublty is that we want to wait for the user to finish editing the
1279         ChangeLog before moving on to the next step.  That means we want to pass
1280         -W to open.  However, if the user is using Xcode to edit the ChangeLog,
1281         we don't want them to have to exit the Xcode application.  For this reason,
1282         we create a new instance of the application with -n.
1283         
1284         Overall, xed seems like a better solution, so we recommend that too.
1285
1286         * Scripts/webkitpy/common/system/user.py:
1287         * Scripts/webkitpy/tool/mocktool.py:
1288         * Scripts/webkitpy/tool/steps/editchangelog.py:
1289
1290 2010-05-21  Dirk Pranke  <dpranke@chromium.org>
1291
1292         Reviewed by Ojan Vafai.
1293
1294         new-run-webkit-tests: fix handling of Ctrl-C to exit even if some
1295         threads are wedged. Also, the script will print the results of the
1296         tests completed when the interrupt occurs.
1297
1298         https://bugs.webkit.org/show_bug.cgi?id=33238
1299
1300         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1301         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1302         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1303         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1304
1305 2010-05-28  Darin Adler  <darin@apple.com>
1306
1307         Ignore more Python messiness.
1308
1309         * Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore.
1310         * Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore.
1311         * Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore.
1312         * Scripts/webkitpy/test: Added property svn:ignore.
1313         * Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore.
1314
1315 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
1316
1317         Reviewed by Beth Dakin.
1318
1319         Adding myself as a reviewer.
1320
1321         * Scripts/webkitpy/common/config/committers.py:
1322
1323 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
1324
1325         Build fix. No review.
1326
1327         AX: need to catch NSAccessibilityExceptions in DRT
1328         https://bugs.webkit.org/show_bug.cgi?id=39881
1329
1330         It looks like Tiger doesn't like seeing a NSMakeRange inside a @try.
1331
1332         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1333         (AccessibilityUIElement::rowIndexRange):
1334         (AccessibilityUIElement::columnIndexRange):
1335         (AccessibilityUIElement::selectedTextRange):
1336
1337 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
1338
1339         Reviewed by Darin Adler.
1340
1341         AX: need to catch NSAccessibilityExceptions in DRT
1342         https://bugs.webkit.org/show_bug.cgi?id=39881
1343
1344         Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but 
1345         because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions.
1346   
1347         So DRT should wrap exception handlers around its AX related calls.
1348
1349         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1350         (attributesOfElement):
1351         (AccessibilityUIElement::getLinkedUIElements):
1352         (AccessibilityUIElement::getDocumentLinks):
1353         (AccessibilityUIElement::getChildren):
1354         (AccessibilityUIElement::getChildrenWithRange):
1355         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1356         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1357         (AccessibilityUIElement::disclosedRowAtIndex):
1358         (AccessibilityUIElement::selectedRowAtIndex):
1359         (AccessibilityUIElement::titleUIElement):
1360         (AccessibilityUIElement::parentElement):
1361         (AccessibilityUIElement::disclosedByRow):
1362         (AccessibilityUIElement::stringAttributeValue):
1363         (AccessibilityUIElement::boolAttributeValue):
1364         (AccessibilityUIElement::isAttributeSettable):
1365         (AccessibilityUIElement::isAttributeSupported):
1366         (AccessibilityUIElement::role):
1367         (AccessibilityUIElement::subrole):
1368         (AccessibilityUIElement::roleDescription):
1369         (AccessibilityUIElement::title):
1370         (AccessibilityUIElement::description):
1371         (AccessibilityUIElement::orientation):
1372         (AccessibilityUIElement::stringValue):
1373         (AccessibilityUIElement::language):
1374         (AccessibilityUIElement::helpText):
1375         (AccessibilityUIElement::x):
1376         (AccessibilityUIElement::y):
1377         (AccessibilityUIElement::width):
1378         (AccessibilityUIElement::height):
1379         (AccessibilityUIElement::clickPointX):
1380         (AccessibilityUIElement::clickPointY):
1381         (AccessibilityUIElement::intValue):
1382         (AccessibilityUIElement::minValue):
1383         (AccessibilityUIElement::maxValue):
1384         (AccessibilityUIElement::valueDescription):
1385         (AccessibilityUIElement::insertionPointLineNumber):
1386         (AccessibilityUIElement::isActionSupported):
1387         (AccessibilityUIElement::isEnabled):
1388         (AccessibilityUIElement::isRequired):
1389         (AccessibilityUIElement::isSelected):
1390         (AccessibilityUIElement::isExpanded):
1391         (AccessibilityUIElement::hierarchicalLevel):
1392         (AccessibilityUIElement::ariaIsGrabbed):
1393         (AccessibilityUIElement::ariaDropEffects):
1394         (AccessibilityUIElement::lineForIndex):
1395         (AccessibilityUIElement::boundsForRange):
1396         (AccessibilityUIElement::stringForRange):
1397         (AccessibilityUIElement::attributesOfColumnHeaders):
1398         (AccessibilityUIElement::attributesOfRowHeaders):
1399         (AccessibilityUIElement::attributesOfColumns):
1400         (AccessibilityUIElement::attributesOfRows):
1401         (AccessibilityUIElement::attributesOfVisibleCells):
1402         (AccessibilityUIElement::attributesOfHeader):
1403         (AccessibilityUIElement::rowCount):
1404         (AccessibilityUIElement::columnCount):
1405         (AccessibilityUIElement::indexInTable):
1406         (AccessibilityUIElement::rowIndexRange):
1407         (AccessibilityUIElement::columnIndexRange):
1408         (AccessibilityUIElement::cellForColumnAndRow):
1409         (AccessibilityUIElement::selectedTextRange):
1410         (AccessibilityUIElement::setSelectedTextRange):
1411         (AccessibilityUIElement::increment):
1412         (AccessibilityUIElement::decrement):
1413         (AccessibilityUIElement::showMenu):
1414         (AccessibilityUIElement::press):
1415         (AccessibilityUIElement::url):
1416         (AccessibilityUIElement::hasPopup):
1417
1418 2010-05-28  Yael Aharon  <yael.aharon@nokia.com>
1419
1420         Reviewed by Laszlo Gombos.
1421
1422         [Qt] Pass all web notification layout tests
1423         https://bugs.webkit.org/show_bug.cgi?id=39146
1424
1425         Mimic Chromium's test_shell security model in Qt's DRT.
1426         It makes a list of origins which were granted permission to display
1427         notifications, and only those origins can display notifications.
1428
1429         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1430         (WebCore::checkPermissionCallback):
1431         (WebCore::requestPermissionCallback):
1432         (WebCore::WebPage::WebPage):
1433         (WebCore::DumpRenderTree::checkPermission):
1434         (WebCore::DumpRenderTree::requestPermission):
1435         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1436         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1437         (LayoutTestController::reset):
1438         (LayoutTestController::grantDesktopNotificationPermission):
1439         (LayoutTestController::checkDesktopNotificationPermission):
1440         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1441
1442 2010-05-27  Philippe Normand  <pnormand@igalia.com>
1443
1444         Reviewed by Shinichiro Hamaji.
1445
1446         check-webkit-style complains about use of NULL in GTK function calls that require sentinels
1447         https://bugs.webkit.org/show_bug.cgi?id=39372
1448
1449         Don't warn about NULL in g_*() calls. Zero can't be used instead
1450         for calls like g_build_filename and g_object_get/set.
1451
1452         * Scripts/webkitpy/style/checkers/cpp.py:
1453         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1454
1455 2010-05-27  Luiz Agostini  <luiz.agostini@openbossa.org>
1456
1457         Reviewed by Kenneth Rohde Christiansen.
1458
1459         [Qt] Platform plugin example
1460         https://bugs.webkit.org/show_bug.cgi?id=39489
1461
1462         Exempting directory WebKit/qt/examples/ from style guide.
1463
1464         * Scripts/webkitpy/style/checker.py:
1465
1466 2010-05-26  Philippe Normand  <pnormand@igalia.com>
1467
1468         Reviewed by David Levin.
1469
1470         [style] Allow usage of NULL in gst_*_many()
1471         https://bugs.webkit.org/show_bug.cgi?id=39740
1472
1473         Don't warn if NULL is used by gst_*_many() functions. Zero can't
1474         be used for the reason explained in Bug 32858.
1475
1476         * Scripts/webkitpy/style/checkers/cpp.py:
1477         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1478
1479 2010-05-27  Adam Barth  <abarth@webkit.org>
1480
1481         Reviewed by Eric Seidel.
1482
1483         Update script to run the normal version of the parser tests.
1484
1485         * Scripts/test-html5-parser:
1486
1487 2010-05-27  Adam Barth  <abarth@webkit.org>
1488
1489         Reviewed by Eric Seidel.
1490
1491         Add HTML5 parser support to run-webkit-tests
1492         https://bugs.webkit.org/show_bug.cgi?id=39815
1493
1494         * Scripts/old-run-webkit-tests:
1495
1496 2010-05-26  Adam Barth  <abarth@webkit.org>
1497
1498         Reviewed by Eric Seidel.
1499
1500         Make HTML5 lexer not ASSERT when resuming partial parses
1501         https://bugs.webkit.org/show_bug.cgi?id=39755
1502
1503         Add webkit-resumer.html to the HTML5 parser test suite.
1504
1505         * Scripts/test-html5-parser:
1506
1507 2010-05-24  Tony Chang  <tony@chromium.org>
1508
1509         Reviewed by Kent Tamura.
1510
1511         [chromium] setup fonts on chromium linux DRT
1512         https://bugs.webkit.org/show_bug.cgi?id=39644
1513
1514         * DumpRenderTree/chromium/TestShellGtk.cpp:
1515         (setupFontconfig):
1516         (platformInit):
1517         * DumpRenderTree/chromium/WebViewHost.cpp:
1518         (WebViewHost::paintRect):  Fix a bug where in release builds, we didn't initialize m_canvas.
1519         * DumpRenderTree/chromium/fonts.conf: Added.
1520
1521 2010-05-24  Dirk Pranke  <dpranke@chromium.org>
1522
1523         Reviewed by Dimitri Glazkov.
1524
1525         Re-commit r58765 - it had been rolled out to see if it was causing
1526         a perf regression (in r59787 and r59789), but that does not seem to
1527         have been the case.
1528
1529         https://bugs.webkit.org/show_bug.cgi?id=39605
1530
1531         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1532         (NotificationPresenter::show):
1533
1534 2010-05-25  Ojan Vafai  <ojan@chromium.org>
1535
1536         Reviewed by Chris Jerdonek.
1537
1538         remove suppression of rietveld logging
1539         https://bugs.webkit.org/show_bug.cgi?id=39693
1540
1541         Now that we only upload to rietveld explicitly, e.g. on the bot
1542         or via webkit-patch post-attachment-to-rietveld, we should print
1543         all the rietveld logging. It was suppressed before to avoid making
1544         webkit-patch upload too noisy.
1545
1546         * Scripts/webkitpy/common/net/rietveld.py:
1547
1548 2010-05-25  Antonio Gomes  <tonikitoo@webkit.org>
1549
1550         Reviewed by Ojan Vafai.
1551
1552         [Qt] Expose the editing behavior setting in DRT to test all editing code paths
1553         https://bugs.webkit.org/show_bug.cgi?id=39680
1554
1555         Implement LayoutTestController::setEditingBehavior in Qt's DRT.
1556
1557         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1558         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1559         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1560         (LayoutTestController::setEditingBehavior):
1561
1562 2010-05-25  Kevin Ollivier  <kevino@theolliviers.com>
1563
1564         [wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir. 
1565
1566         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1567         (LayoutTestController::setEditingBehavior):
1568         * wx/build/settings.py:
1569
1570 2010-05-24  Antonio Gomes  <tonikitoo@webkit.org>
1571
1572         Reviewed by Eric Seidel and Kent Tamura (for the Chromium part).
1573
1574         editingBehavior settings needs to be set back to a reasonable default between tests
1575         https://bugs.webkit.org/show_bug.cgi?id=39433
1576
1577         Similarly to r59861, hard code the default setting during reset for Gtk and Chromium,
1578         so that the serialized version of the setting stays in sync with expectations.
1579
1580         * DumpRenderTree/chromium/TestShell.cpp:
1581         (TestShell::resetWebSettings):
1582         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1583         (resetDefaultsToConsistentValues):
1584
1585 2010-05-24  Eric Seidel  <eric@webkit.org>
1586
1587         Reviewed by Adam Barth.
1588
1589         webkit-patch land calls scm.changed_files 4 times!
1590         https://bugs.webkit.org/show_bug.cgi?id=39584
1591
1592         * Scripts/webkitpy/tool/commands/download_unittest.py:
1593          - Assert that we don't call modified_changelogs too often.
1594         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1595          - Use cached changelogs list instead of calling modified_changelogs directly.
1596         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1597          - ditto.
1598
1599 2010-05-24  Kent Tamura  <tkent@chromium.org>
1600
1601         Reviewed by Dimitri Glazkov.
1602
1603         [DRT/Chromium] Import layout_test_helper for Windows
1604         https://bugs.webkit.org/show_bug.cgi?id=39581
1605
1606         Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp.
1607         http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc
1608
1609         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added.
1610
1611 2010-05-24  Kent Tamura  <tkent@chromium.org>
1612
1613         Reviewed by Dimitri Glazkov.
1614
1615         [DRT/Chromium] Reset frame name
1616         https://bugs.webkit.org/show_bug.cgi?id=39586
1617
1618         This change fixes about 70 unexpected results.
1619
1620         * DumpRenderTree/chromium/WebViewHost.cpp:
1621         (WebViewHost::reset):
1622
1623 2010-05-24  Marcus Bulach  <bulach@chromium.org>
1624
1625         Reviewed by Kent Tamura.
1626
1627         [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
1628         https://bugs.webkit.org/show_bug.cgi?id=39587
1629
1630         * DumpRenderTree/chromium/WebViewHost.cpp:
1631         (WebViewHost::geolocationService):
1632
1633 2010-05-24  Robert Hogan  <robert@webkit.org>
1634
1635         Reviewed by Laszlo Gombos.
1636
1637         [Qt] DRT Support for removeOriginAccessWhitelistEntry
1638
1639         Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html
1640
1641         [Qt] DRT Support for removeOriginAccessWhitelistEntry
1642         https://bugs.webkit.org/show_bug.cgi?id=39565
1643
1644         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1645         (LayoutTestController::removeOriginAccessWhitelistEntry):
1646
1647 2010-05-24  Marcus Bulach  <bulach@google.com>
1648
1649         Reviewed by Ojan Vafai.
1650
1651         _svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head.
1652         https://bugs.webkit.org/show_bug.cgi?id=39603
1653
1654         * Scripts/webkitpy/common/checkout/scm.py:
1655
1656 == Rolled over to ChangeLog-2010-05-24 ==