ddaf0ed298eb6224c93f4fdfb1392de9eac283ff
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-04  Sam Weinig  <sam@webkit.org>
2
3         Rubber stamped by Mark Rowe.
4
5         Define CF as platform for mac and revert r28409
6
7         * DumpRenderTree/DumpRenderTree.h:
8         * DumpRenderTree/mac/DumpRenderTreeMac.h:
9
10 2007-12-04  Sam Weinig  <sam@webkit.org>
11
12         Define CF as platform for windows.
13
14         Reviewed by Adam Roben.
15
16         * DumpRenderTree/win/DumpRenderTreeWin.h:
17
18 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
19
20         Reviewed by Adam and Darin.
21
22         - Removed a needless BSTR cleanup.
23
24         * Drosera/win/DebuggerDocumentPlatform.cpp:
25         (DebuggerDocument::getPlatformCurrentFunctionStack):
26
27 2007-11-27  Adam Roben  <aroben@apple.com>
28
29         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
30
31         Reviewed by Maciej.
32
33         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
34         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
35
36 2007-12-04  Alp Toker  <alp@atoker.com>
37
38         Prospective Win DRT build fix.
39
40         * DumpRenderTree/DumpRenderTree.h:
41
42 2007-12-04  Alp Toker  <alp@atoker.com>
43
44         Fix a clobbered copyright header.
45
46         * DumpRenderTree/gtk/DumpRenderTree.cpp:
47
48 2007-12-04  Xan Lopez  <xan@gnome.org>
49
50         Reviewed by Alp Toker.
51
52         http://bugs.webkit.org/show_bug.cgi?id=15561
53         GTK port needs DumpRenderTree implementation
54
55         Start work on the GTK+ DRT.
56
57         This does not work yet, and there are a few lingering style issues
58         (nothing major) but this patch has been stuck in the bug tracker for
59         too long already.
60
61         * DumpRenderTree/DumpRenderTree.h:
62         * DumpRenderTree/gtk: Added.
63         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
64         (autocorrectURL):
65         (shouldLogFrameLoadDelegates):
66         (dumpFrameScrollPosition):
67         (displayWebView):
68         (appendString):
69         (dumpFramesAsText):
70         (dumpRenderTreeAsText):
71         (dump):
72         (runTest):
73         (main):
74         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
75         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
76         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
77         (GCController::collect):
78         (GCController::collectOnAlternateThread):
79         (GCController::getJSObjectCount):
80         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
81         (LayoutTestController::~LayoutTestController):
82         (LayoutTestController::addDisallowedURL):
83         (LayoutTestController::clearBackForwardList):
84         (LayoutTestController::copyDecodedHostName):
85         (LayoutTestController::copyEncodedHostName):
86         (LayoutTestController::display):
87         (LayoutTestController::keepWebHistory):
88         (LayoutTestController::notifyDone):
89         (LayoutTestController::queueBackNavigation):
90         (LayoutTestController::queueForwardNavigation):
91         (LayoutTestController::queueLoad):
92         (LayoutTestController::queueReload):
93         (LayoutTestController::queueScript):
94         (LayoutTestController::setAcceptsEditing):
95         (LayoutTestController::setCustomPolicyDelegate):
96         (LayoutTestController::setMainFrameIsFirstResponder):
97         (LayoutTestController::setTabKeyCyclesThroughElements):
98         (LayoutTestController::setUseDashboardCompatibilityMode):
99         (LayoutTestController::setUserStyleSheetEnabled):
100         (LayoutTestController::setUserStyleSheetLocation):
101         (LayoutTestController::setWindowIsKey):
102         (LayoutTestController::setWaitToDump):
103         (LayoutTestController::windowCount):
104         (LayoutTestController::setPrivateBrowsingEnabled):
105         (LayoutTestController::setAuthorAndUserStylesEnabled):
106         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
107         (JSStringCopyUTF8CString):
108         (LoadItem::invoke):
109         (ReloadItem::invoke):
110         (ScriptItem::invoke):
111         (BackForwardItem::invoke):
112
113 2007-12-03  Sam Weinig  <sam@webkit.org>
114
115         Move JavaScriptCore thread testing code to pthread specific directory
116         and remove the dependance on CoreFoundation by using WTF::HashSet.
117
118         Reviewed by Geoff and Oliver.
119
120         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
121         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
122         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
123         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
124         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
125         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
126         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
127         * DumpRenderTree/pthreads: Added.
128         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
129         (javaScriptThreads):
130         (runJavaScriptThread):
131         (startJavaScriptThreads):
132         (stopJavaScriptThreads):
133
134 2007-12-03  Andrew Bonventre  <andybons@google.com>
135
136         Reviewed by Darin Adler.
137
138         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
139         Symbol lookup menu broken in debugger view
140
141         * Drosera/debugger.js: Fixed javascript error where document property
142         should have been used instead of contentDocument in switchFunction that
143         was breaking the select symbol dropdown menu.  This is because
144         window.frames will return a Window object and not a frame object like
145         the author was originally expecting.
146
147 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
148
149         Reviewed by Adam.
150
151         - <rdar://5618942> Drosera: Console window does not process everything
152         correctly.
153         - <rdar://5619005> Drosera: could be sped up by moving the 
154         WebScriptScope stuff into the WebScriptCallFrame.
155         - Now the console can correctly process objects and does not receive
156         notifications from JavaScriptCore about the JavaScript in Drosera's
157         own process.
158
159         * Drosera/win/DebuggerDocumentPlatform.cpp:
160         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
161         (DebuggerDocument::platformValueForScopeVariableNamed):
162
163 2007-12-03  Stephanie  <slewis@apple.com>
164
165         Reviewed by Darin.
166
167         Check to see if we are building a debug root
168
169         * Scripts/check-for-global-initializers: 
170
171 2007-12-03  Dan Bernstein  <mitz@apple.com>
172
173         Reviewed by Darin Adler.
174
175         - added a testGetIntIdentifier() method to TestNetscapePlugIn
176
177         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
178         (pluginInvoke):
179
180 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
181
182         Reviewed by Oliver.
183
184         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
185         in a more fine-grained manner than eventSender.keyDown().
186
187         * DumpRenderTree/win/EventSender.cpp:
188         (getConstantCallback):
189         (dispatchMessageCallback):
190
191 2007-12-02  Darin Adler  <darin@apple.com>
192
193         * Scripts/do-webcore-rename: More planned renaming.
194
195 2007-12-02  Sam Weinig  <sam@webkit.org>
196
197         Rubber stamped by Anders.
198
199         Use [NSURL absoluteString] instead of [NSURL description] in order to get
200         more uniform results cross platform.
201
202         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
203         (-[NSURL _drt_descriptionSuitableForTestResult]):
204
205 2007-12-02  Sam Weinig  <sam@webkit.org>
206
207         Rubber stamped by Niko.
208
209         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
210
211         * DumpRenderTree/win/DumpRenderTree.cpp:
212         * DumpRenderTree/win/DumpRenderTree.vcproj:
213         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
214         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
215         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
216         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
217
218 2007-12-01  Alp Toker  <alp@atoker.com>
219
220         Reviewed by Adam Roben.
221
222         Make use of the newly introduced webkit.h convenience header.
223
224         * GtkLauncher/main.c:
225
226 2007-12-01  Adam Treat  <treat@kde.org>
227
228         Reviewed by Simon.
229
230         * Check to see if the directory exists and exit if not.
231
232         * DumpRenderTree/qt/main.cpp:
233         (main):
234
235 2007-12-01  Adam Treat  <treat@kde.org>
236
237         Reviewed by Simon.
238
239         * Don't hide symbols when in Debug mode
240         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
241
242
243         * DumpRenderTree/qt/main.cpp:
244         (messageHandler):
245
246 2007-11-30  Alp Toker  <alp@atoker.com>
247
248         Reviewed by Adam Roben.
249
250         http://bugs.webkit.org/show_bug.cgi?id=15691
251         [GTK] Public API does not follow GTK+ conventions
252
253         Refactor the WebKit/GTK+ public API. Changes:
254           WebKitPage -> WebKitWebView
255           WebKitFrame -> WebKitWebFrame
256
257         Public API source and header names have been updated to mirror the API
258         changes.
259
260         The API is now kept in WebKit/gtk/WebView to match other ports in the
261         same class such as Mac and Win.
262
263         * GtkLauncher/main.c:
264         (activate_uri_entry_cb):
265         (link_hover_cb):
266         (title_change_cb):
267         (progress_change_cb):
268         (go_back_cb):
269         (go_forward_cb):
270         (create_browser):
271         (main):
272
273 2007-11-30  Adam Roben  <aroben@apple.com>
274
275         Hopefully the final build fix
276
277         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
278         pull in WTF's assertion/logging functions.
279
280 2007-11-30  Adam Roben  <aroben@apple.com>
281
282         Another build fix
283
284         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
285         WebKit.lib.
286
287 2007-11-30  Adam Roben  <aroben@apple.com>
288
289         Debug build fix
290
291         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
292         configuration.
293         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
294         projects.
295         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
296         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
297         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
298
299 2007-11-30  Sam Weinig  <sam@webkit.org>
300
301         Reviewed by Adam Roben.
302
303         Fix drawSelectionRect to actually draw the selection rect.
304
305         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
306         (drawSelectionRect):
307
308 2007-11-30  Darin Adler  <darin@apple.com>
309
310         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
311
312 2007-11-30  Darin Adler  <darin@apple.com>
313
314         * Scripts/do-webcore-rename: Get ready for some future renaming.
315
316 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
317
318         Reviewed by Adam.
319
320         - Removed some unnecessary functions and changed an unused return type. 
321
322         * Drosera/win/DebuggerClient.cpp:
323         (registerConsoleClass):
324         * Drosera/win/DebuggerClient.h:
325         * Drosera/win/Drosera.cpp:
326         (registerDroseraClass):
327
328 2007-11-28  Alp Toker  <alp@atoker.com>
329
330         Reviewed by Timothy Hatcher.
331
332         http://bugs.webkit.org/show_bug.cgi?id=16174
333         [GTK] Use "URI" not "URL" in public API
334
335         Replace use of the term "URL" with "URI" in public headers,
336         documentation and some internal code to match GLib/GTK+ convention.
337
338         This is now mentioned in the API guidelines:
339           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
340
341         * GtkLauncher/main.c:
342         (activate_uri_entry_cb):
343         (title_change_cb):
344         (create_toolbar):
345         (main):
346
347 2007-11-29  Anders Carlsson  <andersca@apple.com>
348
349         Reviewed by Sam.
350
351         <rdar://problem/5230478>
352         FrameLoadDelegate callbacks are not dumped in DRT.
353         
354         * DumpRenderTree/win/DumpRenderTree.cpp:
355         (shouldLogFrameLoadDelegates):
356         (runTest):
357         (main):
358         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
359         (BSTRtoString):
360         (descriptionSuitableForTestResult):
361         (FrameLoadDelegate::QueryInterface):
362         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
363         (FrameLoadDelegate::didFailProvisionalLoadWithError):
364         (FrameLoadDelegate::didCommitLoadForFrame):
365         (FrameLoadDelegate::didFinishLoadForFrame):
366         (FrameLoadDelegate::willCloseFrame):
367         (FrameLoadDelegate::didClearWindowObject):
368         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
369         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
370         * DumpRenderTree/win/FrameLoaderDelegate.h:
371         (FrameLoadDelegate::windowScriptObjectAvailable):
372         (FrameLoadDelegate::didFirstLayoutInFrame):
373
374 2007-11-29  Sam Weinig  <sam@webkit.org>
375
376         Reviewed by Anders.
377
378         Add database quota UIDelegates methods to DRT UIDelegate.
379
380         * DumpRenderTree/mac/UIDelegate.mm:
381         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
382         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
383
384 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
385
386         Reviewed by Sam.
387
388         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
389         dying and vice versa.
390         - This fix will allow Drosera and Safari to reconnect if either of them
391         closes correctly, but does not fix the case where one of them dies
392         silently.
393
394         * Drosera/win/ServerConnection.cpp:
395         (ServerConnection::attemptToCreateServerConnection): Added a safety
396         check, because it's possilbe to try to connect to a server that's dying.
397         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
398         the server has died.
399         * Drosera/win/ServerConnection.h: Added the new function and removed
400         an unnecessary member.
401
402 2007-11-29  Anders Carlsson  <andersca@apple.com>
403
404         * DumpRenderTree/win/DumpRenderTree.vcproj:
405         Add shlwapi.lib to all configurations.
406
407 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
408
409         - Build fix.  Added additional includes for VS Express to the Release
410         project.
411
412         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
413
414 2007-11-29  Anders Carlsson  <andersca@apple.com>
415
416         Reviewed by Adam.
417
418         <rdar://problem/5132005>
419         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
420         
421         * DumpRenderTree/win/DumpRenderTree.vcproj:
422         Add shlwapi.lib
423         
424         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
425         (LayoutTestController::setUserStyleSheetEnabled):
426         Implement this.
427         
428         (appendComponentToPath):
429         New method which wraps the Win32 API PathAppend.
430         
431         (followShortcuts):
432         New method which checks if a file points to a shortcut and
433         follows the shortcut.
434         
435         (resolveCygwinPath):
436         New method that takes a cygwin unix-style path and returns the Win32 path.
437         
438         (cfStringRefToWString):
439         
440         (LayoutTestController::setUserStyleSheetLocation):
441         Implement this.
442
443 2007-11-29  Alice Liu  <alice.liu@apple.com>
444
445         Reviewed by Adam.
446
447         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
448
449         * DumpRenderTree/win/EventSender.cpp:
450         (keyDownCallback):
451         uppercase letters were being sent as lowercase letters without the shift key down.
452
453 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
454
455         - Windows build fix. VS express needs some love.
456
457         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
458
459 2007-11-28  Darin Adler  <darin@apple.com>
460
461         Reviewed by Adam Roben.
462
463         * DumpRenderTree/mac/EventSendingController.mm:
464         (-[EventSendingController keyDown:withModifiers:]):
465         Send capital letters through as lowercase letters with the shift key down
466         rather than sending them as if they were highly unusual "capital letter keys".
467
468         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
469         where you need to update results and more tests are failing than before.
470
471 2007-11-28  Anders Carlsson  <andersca@apple.com>
472
473         Reviewed by Darin.
474
475         <rdar://problem/5132001>
476         contextClick is not implemented in DRT on Windows.
477         
478         * DumpRenderTree/win/EventSender.cpp:
479         (contextClickCallback):
480         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
481         by a WM_RBUTTONUP message.
482         
483         * DumpRenderTree/win/UIDelegate.cpp:
484         (UIDelegate::hasCustomMenuImplementation):
485         (UIDelegate::trackCustomPopupMenu):
486         * DumpRenderTree/win/UIDelegate.h:
487         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
488         menu from being shown (and causing the DRT to hang).
489
490 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
491
492         Reviewed by Darin.
493
494         Fix DumpRenderTree ObjC bug comparing strings.
495
496         * DumpRenderTree/mac/ObjCController.m:
497         (-[ObjCController identityIsEqual::]): Compare strings with string
498         equality instead of identiy equality.
499
500 2007-11-27  Timothy Hatcher  <timothy@apple.com>
501
502         Reviewed by Sam.
503
504         Reset the authorAndUserStylesEnabled preference
505         back to YES for each test. Fixes the broken tests.
506
507         * DumpRenderTree/mac/DumpRenderTree.mm:
508         (resetWebViewToConsistentStateBeforeTesting):
509
510 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
511
512         Reviewed by Adam.
513
514         - Drosera now displays the console window, although it cannot currently
515         process JavaScript.
516
517         * Drosera/win/DebuggerClient.cpp: Shows the console window.
518         (registerConsoleClass): Implemented.
519         (consoleWndProc): Implemented.
520         (DebuggerClient::onSize): Implemented.
521         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
522         new window.
523         * Drosera/win/DebuggerClient.h: Added needed method and members for 
524         creating and maintaining a new window.
525         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
526         lines of code to more appropriate places.
527         (Drosera::handleCommand):
528         (Drosera::initUI):
529         (Drosera::onSize):
530         (Drosera::attach):
531
532 2007-11-27  Timothy Hatcher  <timothy@apple.com>
533
534         Reviewed by Dave Hyatt.
535
536         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
537         
538         Add support for disabling author and user styles for testing.
539
540         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
541         * DumpRenderTree/LayoutTestController.cpp:
542         (setAuthorAndUserStylesEnabledCallback):
543         (LayoutTestController::staticFunctions):
544         * DumpRenderTree/LayoutTestController.h:
545         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
546         (LayoutTestController::setAuthorAndUserStylesEnabled):
547         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
548         (LayoutTestController::setAuthorAndUserStylesEnabled):
549
550 2007-11-26  Dan Bernstein  <mitz@apple.com>
551
552         - Tiger build fix.
553
554         * DumpRenderTree/mac/Configurations/Base.xcconfig:
555
556 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
557
558         Reviewed by Maciej.
559
560         - Implemented displaying variables for Drosera on Win.
561
562         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
563         that retrieve variables to not hold onto the return value since it's
564         not returned.  Also changed to use the new signatures of the retrieval
565         functions.
566         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
567         (DebuggerDocument::platformValueForScopeVariableNamed):
568         * Drosera/win/Drosera.cpp: Removed a needless TODO.
569         (droseraWndProc):
570
571 2007-11-26  Sam Weinig  <sam@webkit.org>
572
573         Cleanup names of painting and repainting functions.
574
575         Reviewed by Adam Roben.
576
577         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
578         (drawSelectionRect): was drawSelectionRectIntoContext.
579         (dumpWebViewAsPixelsAndCompareWithExpected):
580         * DumpRenderTree/cg/PixelDumpSupportCG.h:
581         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
582         (paintWebView): was drawWebViewIntoContext.
583         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
584
585 2007-11-26  Sam Weinig  <sam@webkit.org>
586
587         Reviewed by Dan Bernstein.
588
589         - Leopard build fix
590
591         * DumpRenderTree/mac/Configurations/Base.xcconfig:
592
593 2007-11-26  Sam Weinig  <sam@webkit.org>
594
595         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
596         Use shared PixelDumpSupport for Mac DRT
597
598         Reviewed by Adam Roben.
599
600         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
601         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
602         * DumpRenderTree/cg/ImageDiffCG.cpp:
603         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
604         (drawSelectionRectIntoContext):
605         (dumpWebViewAsPixelsAndCompareWithExpected):
606         * DumpRenderTree/cg/PixelDumpSupportCG.h:
607         * DumpRenderTree/mac/Configurations/Base.xcconfig:
608         * DumpRenderTree/mac/DumpRenderTree.mm:
609         (dump):
610         * DumpRenderTree/mac/ImageDiff.m: Removed.
611         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
612         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
613         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
614         (setDefaultColorProfileToRGB):
615         (getBitmapContextFromWebView):
616         (drawWebViewIntoContext):
617         (repaintWithVerticalSweep):
618         (repaintWithHorizontalSweep):
619         (getSelectionRect):
620         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
621
622 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
623
624         Bug 16052: prepare-ChangeLog doesn't report deleted files
625         <http://bugs.webkit.org/show_bug.cgi?id=16052>
626
627         Reviewed by Sam.
628
629         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
630
631 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
632
633         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
634         <http://bugs.webkit.org/show_bug.cgi?id=15864>
635
636         Reviewed by Adam.
637
638         Roll functionality of merge-changelog into resolve-ChangeLogs
639         script.  The script now checks for ChangeLog.rej and
640         ChangeLog.orig files first.  If it finds them, it uses the
641         ChangeLog.rej file as a patch (in old contextual diff format) to
642         apply with --fuzz=3.
643
644         * Scripts/merge-changelog: Removed.
645         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
646
647 2007-11-25  Sam Weinig  <sam@webkit.org>
648
649         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
650
651         Reviewed by Mark Rowe.
652
653         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
654         * DumpRenderTree/mac/Configurations/Base.xcconfig:
655         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
656         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
657         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
658
659 2007-11-25  Sam Weinig  <sam@webkit.org>
660
661         Convert DumpRenderTree to ues .xcconfig files.
662
663         Reviewed by Mark Rowe.
664
665         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
666         * DumpRenderTree/mac/Configurations: Added.
667         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
668         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
669         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
670
671 2007-11-25  Sam Weinig  <sam@webkit.org>
672
673         Add ForwardingHeaders to wtf for DumpRenderTree.
674
675         Reviewed by Mark Rowe.
676
677         * DumpRenderTree/DumpRenderTree.h:
678         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
679         * DumpRenderTree/ForwardingHeaders: Added.
680         * DumpRenderTree/ForwardingHeaders/wtf: Added.
681         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
682         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
683         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
684         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
685         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
686         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
687         * DumpRenderTree/LayoutTestController.cpp:
688         * DumpRenderTree/WorkQueue.cpp:
689         * DumpRenderTree/mac/DumpRenderTree.mm:
690         * DumpRenderTree/mac/FrameLoadDelegate.mm:
691         * DumpRenderTree/mac/JavaScriptThreading.cpp:
692         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
693         * DumpRenderTree/mac/ObjCController.m:
694         * DumpRenderTree/mac/UIDelegate.mm:
695         * DumpRenderTree/mac/WorkQueueItemMac.mm:
696
697 2007-11-25  Adam Roben  <aroben@apple.com>
698
699         Fix some test failures caused by r28019
700
701         Now that stdout is in binary mode, we need to always use printf
702         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
703         the output.
704
705         Reviewed by Sam.
706
707         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
708         printf.
709         (UIDelegate::runJavaScriptAlertPanelWithMessage):
710         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
711         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
712         (UIDelegate::webViewAddMessageToConsole):
713
714 2007-11-25  Adam Roben  <aroben@apple.com>
715
716         Set the font smoothing preference in DRT
717
718         This makes the pixel results on Windows closer to the Mac results.
719
720         Reviewed by Mitz.
721
722         * DumpRenderTree/win/DumpRenderTree.cpp:
723         (initializePreferences):
724
725 2007-11-25  Adam Roben  <aroben@apple.com>
726
727         Port ImageDiff to CG and C++
728
729         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
730         <rdar://5071708>
731
732         Reviewed by Sam.
733
734         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
735         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
736         (main):
737         (createImageFromStdin):
738         (compareImages):
739         (getDifferenceBitmap):
740         (computePercentageDifferent):
741         * DumpRenderTree/win/ImageDiff.vcproj: Added.
742
743 2007-11-25  Adam Roben  <aroben@apple.com>
744
745         Fix image diff link generation on Windows
746
747         Reviewed by Sam.
748
749         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
750         to toURL.
751
752 2007-11-25  Adam Roben  <aroben@apple.com>
753
754         Implement pixel dumping in Windows DRT
755
756         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
757         <rdar://5071708>
758
759         Reviewed by Sam.
760
761         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
762         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
763         Content-Length header.
764         (getMD5HashStringForBitmap):
765         (dumpWebViewAsPixelsAndCompareWithExpected):
766         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
767         * DumpRenderTree/win/DumpRenderTree.cpp:
768         (dump): Do a pixel dump if requested.
769         (main): Parse pixel test options.
770         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
771         the cg/ subdirectory to the include path.
772         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
773         available in a header or import library, so we have to go through this
774         LoadLibrary/GetProcAddress dance to use them.
775         (cryptDLL):
776         (init):
777         (update):
778         (final):
779         (MD5_Init):
780         (MD5_Update):
781         (MD5_Final):
782         * DumpRenderTree/win/MD5.h: Added.
783         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
784         moved up to the top level to share it with Mac eventually.
785         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
786         (getBitmapContextFromWebView): Forces the WebView to paint using a
787         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
788
789 2007-11-25  Adam Roben  <aroben@apple.com>
790
791         Clean up Windows DRT's option parsing a little bit
792
793         Reviewed by Sam.
794
795         * DumpRenderTree/win/DumpRenderTree.cpp:
796         (main): Put non-option arguments into a Vector.
797
798 2007-11-25  Adam Roben  <aroben@apple.com>
799
800         Make Windows DRT stop changing LF into CRLF
801
802         Reviewed by Sam.
803
804         * DumpRenderTree/win/DumpRenderTree.cpp:
805         (main): Put stdout in binary mode.
806         * Scripts/run-webkit-tests: Remove the CRLF hack.
807
808 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
809
810         Removed empty directory.
811
812         * Scripts/resources: Removed.
813
814 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
815
816         Fix bisect-builds to work with recent WebKit nightly builds.
817
818         Reviewed by Dan.
819
820         * Scripts/bisect-builds: Check for the 
821         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
822         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
823         to WebKit.app/Contents/Resources.
824
825 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
826
827         Reviewed by Maciej.
828
829         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
830         not closed (affects digg.com)
831
832         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
833         one after finishing with a test to avoid having its delayed onload handler firing when
834         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
835         but it helps somewhat.
836
837 2007-11-22  Mark Rowe  <mrowe@apple.com>
838
839         Reviewed by Alp Toker.
840
841         Fix build-webkit to propagate make's exit status if it fails.
842
843         * Scripts/webkitdirs.pm:
844
845 2007-11-22  Dan Bernstein  <mitz@apple.com>
846
847         Reviewed by Mark Rowe.
848
849         - fix crash when running pixel tests
850
851         * DumpRenderTree/mac/DumpRenderTree.mm:
852         (dumpRenderTree): Parse the command line options before setting up the
853         environment so that we know if we need to set up the pixel dump
854         machinery.
855
856 2007-11-21  Eric Seidel  <eric@webkit.org>
857
858         Speculative build fix for Tiger.
859
860         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
861
862 2007-11-21  Eric Seidel  <eric@webkit.org>
863
864         Reviewed by Tim Hatcher.
865
866         Break out more of DumpRenderTree.mm into individual files
867
868         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
869         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
870         (checkedMalloc):
871         (checkedRealloc):
872         (makeLargeMallocFailSilently):
873         * DumpRenderTree/mac/CheckedMalloc.h: Added.
874         * DumpRenderTree/mac/DumpRenderTree.mm:
875         (crashHandler):
876         (dump):
877         * DumpRenderTree/mac/DumpRenderTreeMac.h:
878         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
879         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
880         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
881         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
882         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
883         (javaScriptThreads):
884         (runJavaScriptThread):
885         (startJavaScriptThreads):
886         (stopJavaScriptThreads):
887         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
888         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
889         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
890         (restoreColorSpace):
891         (setDefaultColorProfileToRGB):
892         (initializeColorSpaceAndScreeBufferForPixelTests):
893         (md5HashStringForBitmap):
894         (dumpWebViewAsPixelsAndCompareWithExpected):
895
896 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
897
898         Move install-unix-extras to wx directory as it seems only to be used by that 
899         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
900         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
901         have install-unix-extras install into WebKitLibraries as per
902         convention.
903         
904         Reviewed by Mark Rowe.
905
906         * Scripts/install-unix-extras: Removed.
907         * wx/build-wxwebkit:
908         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
909
910 2007-11-21  Eric Seidel  <eric@webkit.org>
911
912         Reviewed by Adam.
913
914         More refactoring for greater code readability
915
916         * DumpRenderTree/mac/DumpRenderTree.mm:
917         (initializeGlobalsFromCommandLineOptions):
918         (initializeColorSpaceAndScreeBufferForPixelTests):
919         (addTestPluginsToPluginSearchPath):
920         (useLongRunningServerMode):
921         (runTestingServerLoop):
922         (prepareConsistentTestingEnvironment):
923         (dumpRenderTree):
924         (main):
925         (dumpFramesAsText):
926         (dumpBackForwardListForWebView):
927         (sizeWebViewForCurrentTest):
928         (methodNameStringForFailedTest):
929         (dumpBackForwardListForAllWindows):
930         (dumpWebViewAsPixelsAndCompareWithExpected):
931         (invalidateAnyPreviousWaitToDumpWatchdog):
932         (dump):
933         * DumpRenderTree/mac/DumpRenderTreeMac.h:
934         * DumpRenderTree/mac/UIDelegate.mm:
935         (-[UIDelegate webView:createWebViewWithRequest:]):
936
937 2007-11-21  Eric Seidel  <eric@webkit.org>
938
939         Reviewed by Tim Hatcher.
940
941         Abstract more of DRT into static methods
942
943         * DumpRenderTree/mac/DumpRenderTree.mm:
944         (setDefaultsToConsistentValuesForTesting):
945         (setupSignalHandlers):
946         (allocateGlobalControllers):
947         (releaseAndZero):
948         (releaseGlobalControllers):
949         (dumpRenderTree):
950         (shouldLogFrameLoadDelegates):
951         (createCFURLFromPathOrURL):
952         (resetWebViewToConsistentStateBeforeTesting):
953         (runTest):
954
955 2007-11-21  Eric Seidel  <eric@webkit.org>
956
957         Reviewed by Tim Hatcher.
958
959         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
960
961         * DumpRenderTree/DumpRenderTree.h:
962         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
963         * DumpRenderTree/mac/DumpRenderTree.mm:
964         (dumpRenderTree):
965         (dump):
966         (runTest):
967         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
968         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
969         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
970         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
971         (-[DumpRenderTreePasteboard declareType:owner:]):
972         (+[LocalPasteboard alloc]):
973         (-[LocalPasteboard init]):
974         (-[LocalPasteboard dealloc]):
975         (-[LocalPasteboard name]):
976         (-[LocalPasteboard releaseGlobally]):
977         (-[LocalPasteboard declareTypes:owner:]):
978         (-[LocalPasteboard addTypes:owner:]):
979         (-[LocalPasteboard changeCount]):
980         (-[LocalPasteboard types]):
981         (-[LocalPasteboard availableTypeFromArray:]):
982         (-[LocalPasteboard setData:forType:]):
983         (-[LocalPasteboard dataForType:]):
984         (-[LocalPasteboard setPropertyList:forType:]):
985         (-[LocalPasteboard setString:forType:]):
986         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
987         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
988         (+[DumpRenderTreeWindow allWindows]):
989         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
990         (-[DumpRenderTreeWindow dealloc]):
991         (-[DumpRenderTreeWindow isKeyWindow]):
992         (-[DumpRenderTreeWindow keyDown:]):
993
994 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
995
996         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
997         it indiscriminately copies any headers inside JavaScriptCore,
998         which includes Tiger ICU headers. 
999
1000         * wx/build-wxwebkit:
1001         Don't run WebCore/move-js-headers.sh any longer.
1002
1003 2007-11-20  Adam Treat  <treat@kde.org>
1004
1005         Reviewed by David Kilzer.
1006
1007         * Prepend git branch name to $baseProductDir
1008
1009         * Scripts/VCSUtils.pm:
1010         * Scripts/webkitdirs.pm:
1011
1012 2007-11-20  Mark Rowe  <mrowe@apple.com>
1013
1014         Reviewed by Simon Hausmann.
1015
1016         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1017         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1018         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1019         built product and generated Makefile's are removed.
1020
1021 2007-11-19  Alp Toker  <alp@atoker.com>
1022
1023         Reviewed by Mark Rowe.
1024
1025         http://bugs.webkit.org/show_bug.cgi?id=16040
1026         [GTK] GtkLauncher should be written in C
1027
1028         Port GtkLauncher to plain C.
1029
1030         Use a more conventional GTK+ coding style.
1031
1032         Use a toolbar instead of menus.
1033
1034         Various signature fixes and cleanups.
1035
1036         Add a license header. Assume all previous modifications were copyright
1037         assigned to Apple Inc. by default.
1038
1039         * GtkLauncher/GtkLauncher.pro:
1040         * GtkLauncher/main.c: Added.
1041         (activate_url_entry_cb):
1042         (update_title):
1043         (link_hover_cb):
1044         (title_change_cb):
1045         (progress_change_cb):
1046         (destroy_cb):
1047         (go_back_cb):
1048         (go_forward_cb):
1049         (create_browser):
1050         (create_statusbar):
1051         (create_toolbar):
1052         (create_window):
1053         (main):
1054         * GtkLauncher/main.cpp: Removed.
1055
1056 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1057
1058         Build script fixes to ensure they do the right thing for the 
1059         wx port, and update build-wxwebkit to reflect the way the
1060         build scripts now work.
1061
1062         Reviewed by Adam.
1063
1064         * Scripts/build-testkjs:
1065         * Scripts/build-webkit:
1066         * Scripts/run-javascriptcore-tests:
1067         * Scripts/webkitdirs.pm:
1068         * wx/build-wxwebkit:
1069
1070 2007-11-18  Eric Seidel  <eric@webkit.org>
1071
1072         Reviewed by Anders.
1073
1074         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1075
1076         * Scripts/run-javascriptcore-tests:
1077
1078 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1079
1080         Reviewed by Adam Roben.
1081
1082         Make run-webkit-tests work with Windows debug build.
1083
1084         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1085         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1086         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1087         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1088         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1089
1090 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1091
1092         Add wxWebKit sample and build script, and integrate it with 
1093         build-webkit. Also make build-webkit --clean work for all
1094         ports.
1095
1096         Reviewed by Darin Adler.
1097
1098         * Scripts/build-webkit:
1099         * Scripts/webkitdirs.pm:
1100         * wx: Added.
1101         * wx/browser: Added.
1102         * wx/browser/browser.bkl: Added.
1103         * wx/browser/browser.cpp: Added.
1104         * wx/build-wxwebkit: Added.
1105
1106 2007-11-17  Adam Roben  <aroben@apple.com>
1107
1108         Make it easy to run Safari in the debugger on Windows
1109
1110         I've added a new script, debug-safari, which launches Safari in the
1111         debugger. On OS X it just calls gdb-safari.
1112
1113         Reviewed by Mark Rowe.
1114
1115         * FindSafari/FindSafari.cpp:
1116         (_tmain): Added a /debugger flag, which in combination with
1117         /printSafariLauncher will print a script that launches Safari in the
1118         debugger.
1119         * Scripts/debug-safari: Added.
1120         * Scripts/run-safari: Changed to call runSafari().
1121         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1122         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1123         first argument along to FindSafari.
1124         * Scripts/webkitdirs.pm:
1125         (sub runSafari): Added.
1126
1127 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1128
1129         Reviewed by Adam Roben.
1130
1131         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1132
1133 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1134
1135         Reviewed by David Kilzer.
1136
1137         The git config command was renamed to repo-config at some point. This
1138         change tries git config and then git repo-config if the first fails.
1139
1140         * Scripts/prepare-ChangeLog:
1141         (gitConfig):
1142
1143 2007-11-16  Dan Bernstein  <mitz@apple.com>
1144
1145         Reviewed by Darin Adler and Sam Weinig.
1146
1147         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1148
1149         * DumpRenderTree/win/EventSender.cpp:
1150         (keyDownCallback): For characters that cannot be entered on the active
1151         keyboard layout, send a WM_CHAR message with the character along with
1152         a WM_KEYDOWN message with a virtual key code of 255.
1153
1154 2007-11-16  Mark Rowe  <mrowe@apple.com>
1155
1156         Reviewed by Tim Hatcher.
1157
1158         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1159
1160         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1161         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1162
1163 2007-11-15  Adam Roben  <aroben@apple.com>
1164
1165         Make run-safari actually work on Windows
1166
1167         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1168         chdir call.
1169
1170 2007-11-14  Adam Roben  <aroben@apple.com>
1171
1172         Updates to Safari launching now that 3.0.4 is released
1173
1174         Reviewed by Sam.
1175
1176         * FindSafari/FindSafari.cpp:
1177         (getWebViewCLSID): Use version-independent ProgID.
1178         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1179
1180 2007-11-14  Anders Carlsson  <andersca@apple.com>
1181
1182         Reviewed by Adam.
1183
1184         <rdar://problem/5309081>
1185         In DRT, "plugin.logDestroy = true" not working on Windows.
1186         
1187         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1188         (NPP_Destroy):
1189
1190 2007-11-14  Eric Seidel  <eric@webkit.org>
1191
1192         Reviewed by Sam.
1193
1194         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1195
1196 2007-11-14  Anders Carlsson  <andersca@apple.com>
1197
1198         Reviewed by Adam.
1199
1200         <rdar://problem/5141186>
1201         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1202         
1203         Implement setWindowIsKey.
1204         
1205         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1206         (LayoutTestController::setWindowIsKey):
1207
1208 2007-11-13  Sam Weinig  <sam@webkit.org>
1209
1210         Reviewed by Adam Roben.
1211
1212         Fix for <rdar://problem/5382579>
1213         http/tests/security/cross-frame-access-put.html reports large 
1214         negative numbers for screenLeft and screenTop (Mac reports "0")
1215
1216         * DumpRenderTree/win/UIDelegate.cpp:
1217         (UIDelegate::UIDelegate): Initialize the RECT.
1218         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1219         (UIDelegate::webViewFrame): ditto.
1220         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1221
1222 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1223
1224         Reviewed by Adam.
1225
1226         - Make Drosera show source, source URLs, and function stack on Windows,
1227         and some minor fixes.
1228
1229         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1230         (DebuggerDocument::updateFileSource):
1231         * Drosera/debugger.js: Force source to always update display.
1232         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1233         menu controls.
1234         (DebuggerClient::resume):
1235         (DebuggerClient::pause):
1236         (DebuggerClient::stepInto):
1237         (DebuggerClient::stepOver):
1238         (DebuggerClient::stepOut):
1239         (DebuggerClient::showConsole):
1240         (DebuggerClient::closeCurrentFile):
1241         * Drosera/win/DebuggerClient.h: Ditto.
1242         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1243         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1244         removed two bugs.  1) caller could be in a bad state when asked to
1245         assign into it. 2) BSTRs were not created correctly.
1246         (DebuggerDocument::getPlatformCurrentFunctionStack):
1247         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1248         (droseraWndProc):
1249         (handleCommand):
1250         (Drosera::resume):
1251         (Drosera::pause):
1252         (Drosera::stepInto):
1253         (Drosera::stepOver):
1254         (Drosera::stepOut):
1255         (Drosera::showConsole):
1256         (Drosera::closeCurrentFile):
1257         * Drosera/win/Drosera.h: Hook up the menu controls.
1258         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1259         functions, added a null check, and fixed another bug where caller could
1260         be in a bad state when asked to assign into it.
1261         (ServerConnection::didLoadMainResourceForDataSource):
1262         (ServerConnection::getCallerFrame):
1263         * Drosera/win/ServerConnection.h: Safety first.
1264
1265 2007-11-13  Dan Bernstein  <mitz@apple.com>
1266
1267         Reviewed by Darin Adler.
1268
1269         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1270           DumpRenderTree --pixel-tests renders each test twice
1271
1272         * DumpRenderTree/mac/DumpRenderTree.mm:
1273         (dumpRenderTree): Removed the --paint option because the painting code
1274         is always exercised as a result of
1275         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1276         calling -displayIfNeeded.
1277         (dump): Changed to always grab the image from the window since the view
1278         is always displayed.
1279         (runTest):
1280         (displayWebView):
1281         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1282         because it always paints.
1283
1284 2007-11-12  Antti Koivisto  <antti@apple.com>
1285
1286         Reviewed by Adele.
1287         
1288         Add support for http media tests
1289
1290         * Scripts/run-webkit-tests:
1291
1292 2007-11-12  Sam Weinig  <sam@webkit.org>
1293
1294         Reviewed by Adam Roben.
1295
1296         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1297
1298         * DumpRenderTree/win/DumpRenderTree.cpp:
1299         (runTest):
1300         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1301         (LayoutTestController::setPrivateBrowsingEnabled):
1302
1303 2007-11-12  Adam Roben  <aroben@apple.com>
1304
1305         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1306         mac and win subdirectories.
1307
1308 2007-11-11  Adam Roben  <aroben@apple.com>
1309
1310         Fix <rdar://5133816> keepWebHistory is not implemented
1311
1312         Fixes fast/history/clicked-link-is-visited.html.
1313
1314         Reviewed by Darin.
1315
1316         * DumpRenderTree/win/DumpRenderTree.cpp:
1317         (runTest): Clear the optionalSharedHistory.
1318         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1319         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1320
1321 2007-11-10  Sam Weinig  <sam@webkit.org>
1322
1323         Reviewed by Tim Hatcher.
1324
1325         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1326         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1327         is turned on)
1328
1329         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1330
1331         Added test: http/tests/security/cross-frame-access-private-browsing.html
1332
1333         * DumpRenderTree/LayoutTestController.cpp:
1334         (setPrivateBrowsingEnabledCallback):
1335         (LayoutTestController::staticFunctions):
1336         * DumpRenderTree/LayoutTestController.h:
1337         * DumpRenderTree/mac/DumpRenderTree.mm:
1338         (runTest): Default to private browsing disabled.
1339         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1340         (LayoutTestController::setPrivateBrowsingEnabled):
1341         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1342         (LayoutTestController::setPrivateBrowsingEnabled):
1343
1344 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1345
1346         Reviewed by Adam.
1347
1348         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1349         WebCore's!
1350
1351         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1352         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1353         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1354         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1355         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1356         * Drosera/win/Drosera.cpp:
1357         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1358
1359 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1360
1361         Reviewed by Sam.
1362
1363         - Use the new IWebFrame [local] function signature and get the shared
1364         server correctly.
1365
1366         * Drosera/win/DebuggerClient.cpp:
1367         (DebuggerClient::didFinishLoadForFrame):
1368         * Drosera/win/ServerConnection.cpp:
1369         (ServerConnection::attemptToCreateServerConnection):
1370
1371 2007-11-07  Dan Bernstein  <mitz@apple.com>
1372
1373         Reviewed by Darin Adler.
1374
1375         - add an option to run-webkit-tests to ignore pixel test failures where
1376           all pixels differ by no more than a specified threshold
1377
1378         * DumpRenderTree/mac/ImageDiff.m:
1379         (main):
1380         (compareImages):
1381         (computePercentageDifferent):
1382         * Scripts/run-webkit-tests:
1383
1384 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1385
1386         Reviewed by Lars.
1387
1388         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1389
1390         * DumpRenderTree/qt/DumpRenderTree.cpp:
1391
1392 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1393
1394         Reviewed by Lars.
1395
1396         Reworked the QWebSettings API.
1397         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1398
1399         * DumpRenderTree/qt/DumpRenderTree.cpp:
1400
1401 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1402
1403         Reviewed by Lars.
1404
1405         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1406
1407         * DumpRenderTree/qt/jsobjects.cpp:
1408
1409 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1410
1411         Reviewed by Lars Knoll <lars@trolltech.com>.
1412
1413         Add a QWebPage::frameCreated() signal and fix DRT
1414         
1415         The removal of createFrame in QWebPage broke the re-implementation
1416         in DumpRenderTree. Instead emit a frameCreated() signal and
1417         connect to it in DumpRenderTree.
1418         
1419
1420         * DumpRenderTree/qt/DumpRenderTree.cpp:
1421         (WebCore::WebPage::WebPage):
1422         (WebCore::DumpRenderTree::dump):
1423         (WebCore::DumpRenderTree::connectFrame):
1424         * DumpRenderTree/qt/DumpRenderTree.h:
1425
1426 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1427
1428         Reviewed by Lars Knoll <lars@trolltech.com>.
1429
1430         Moved all the event handlers from QWebFrame into QWebPage.
1431         
1432         This cleans up the public API and allows us to remove the
1433         HackWebFrame hack in DumpRenderTree.
1434         
1435
1436         * DumpRenderTree/qt/jsobjects.cpp:
1437         (EventSender::mouseDown):
1438         (EventSender::mouseUp):
1439         (EventSender::mouseMoveTo):
1440
1441 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1442
1443         Reviewed by Mark.
1444
1445         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1446         to prevent the default implementation from popping up messageboxes.
1447
1448         * DumpRenderTree/qt/DumpRenderTree.cpp:
1449         (WebCore::WebPage::javaScriptConfirm):
1450         (WebCore::WebPage::javaScriptPrompt):
1451
1452 2007-11-06  Eric Seidel  <eric@webkit.org>
1453
1454         * Scripts/build-testkjs: build fix... too many $$
1455
1456 2007-11-06  Eric Seidel  <eric@webkit.org>
1457
1458         Reviewed by Mark Rowe.
1459
1460         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1461
1462 2007-11-05  Adam Roben  <aroben@apple.com>
1463
1464         Add support on Windows for WEBKIT_TESTFONTS
1465
1466         This environment variable lets you specify where the fonts to be used
1467         by DumpRenderTree reside. The Qt port is already using this, so I'm
1468         just following their lead.
1469
1470         Reviewed by Darin.
1471
1472         * DumpRenderTree/win/DumpRenderTree.cpp:
1473         (exePath): Refactored code out of initialize().
1474         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1475         DumpRenderTree.resources.
1476         (initialize): Use the new fontsPath function.
1477         (main): Use the new exePath function.
1478         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1479         variable to DRT, like Qt does.
1480
1481 2007-11-05  Mark Rowe  <mrowe@apple.com>
1482
1483         Rubber-stamped by Alp Toker.
1484
1485         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1486
1487         * GtkLauncher/main.cpp:
1488         (goToURLBarText):
1489         (main):
1490
1491 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1492
1493         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1494         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1495
1496         Reviewed by Timothy.
1497
1498         Restrict the range of nightly builds used by the bisect-builds script
1499         based on the version of Safari and the version of Mac OS X being used.
1500
1501         Mac OS X 10.4: Safari 2.0: r11976 or newer
1502         Mac OS X 10.4: Safari 3.0: r19992 or newer
1503
1504         Mac OS X 10.5: Safari 2.0: r19594 or newer
1505         Mac OS X 10.5: Safari 3.0: r25124 or newer
1506
1507         * Scripts/bisect-builds:
1508         (findMacOSXVersion): Added.
1509         (makeNightlyList): Added argument to provide version of Mac OS X.
1510         Restrict range of nightly builds based on Safari and Mac OS X versions.
1511
1512 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1513
1514         Reviewed by Maciej.
1515
1516         - This patch involves several changes, all of them were noticed that
1517         they were needed by the work being done in WebKit to get Drosera and
1518         WebKit working together on Windows.
1519         - The changes are:
1520         1) Added a debugger console for output messages.
1521         2) Drosera now listens for the WebKit server (before, the server would
1522         have to be running before Drosera was started.)
1523         3) Fixed a bug where the WebView started out as 0x0 pixels.
1524         4) Fixed a bug when there is no scope.
1525         5) Added the HTML, JS, and CSS to the project file to make them easy to
1526         find.
1527         6) Made the ServerConnection functions virtual.
1528
1529         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1530         for the WebKit server.
1531         (DebuggerClient::DebuggerClient):
1532         (DebuggerClient::~DebuggerClient):
1533         (DebuggerClient::didFinishLoadForFrame):
1534         (DebuggerClient::serverConnected):
1535         (DebuggerClient::attemptToCreateServerConnection):
1536         * Drosera/win/DebuggerClient.h: Ditto.
1537         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1538         scope.
1539         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1540         (DebuggerDocument::platformValueForScopeVariableNamed):
1541         * Drosera/win/Drosera.cpp:
1542         (_tWinMain): Added a console in debug for output messages.
1543         (Drosera::Drosera): Listen for server.
1544         (Drosera::initUI): The server now Initializes COM.
1545         (Drosera::serverConnected): Part of the listening for the server.
1546         (Drosera::attemptToCreateServerConnection): Ditto.
1547         * Drosera/win/Drosera.h: New interface for listening for the server.
1548         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1549         files to the VS project.
1550         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1551         connection.
1552         (ServerConnection::ServerConnection):
1553         (ServerConnection::attemptToCreateServerConnection):
1554         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1555         methods.
1556         (ServerConnection::serverConnected):
1557
1558 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1559
1560         Reviewed by Maciej.
1561
1562         http://bugs.webkit.org/show_bug.cgi?id=15832
1563         fast/dom/gc-10.html crashes when run alone
1564
1565         Check for !done before using objects that can be already deallocated.
1566
1567         * DumpRenderTree/mac/EditingDelegate.mm:
1568         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1569         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1570         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1571         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1572         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1573         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1574         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1575         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1576         (-[EditingDelegate webViewDidBeginEditing:]):
1577         (-[EditingDelegate webViewDidChange:]):
1578         (-[EditingDelegate webViewDidEndEditing:]):
1579         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1580         (-[EditingDelegate webViewDidChangeSelection:]):
1581         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1582         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1583         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1584         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1585         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1586         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1587         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1588         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1589         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1590         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1591         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1592         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1593         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1594         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1595         (-[FrameLoadDelegate webView:willCloseFrame:]):
1596         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1597         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1598         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1599         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1600         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1601         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1602         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1603         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1604         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1605
1606 2007-11-04  Mark Rowe  <mrowe@apple.com>
1607
1608         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1609         warnings that would otherwise be suppressed due to it being a system header.
1610
1611         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1612
1613 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1614
1615         Rubber stamped by Adam.
1616         
1617         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1618
1619         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1620
1621 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1622
1623         Sort files(...); sections of Xcode project files.
1624
1625         Rubber-stamped by Darin.
1626
1627         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1628         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1629         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1630         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1631
1632 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1633
1634         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1635
1636         Reviewed by Darin.
1637
1638         * Scripts/sort-Xcode-project-file: Added.
1639
1640 2007-11-02  Darin Adler  <darin@apple.com>
1641
1642         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1643
1644 2007-11-02  Darin Adler  <darin@apple.com>
1645
1646         Reviewed by Maciej.
1647
1648         * Scripts/run-sunspider: Pass the "--base" option through.
1649
1650         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1651         the real script do that. Default configuration to Release to match run-sunspider
1652         so we don't end up building Debug just to compare results.
1653
1654 2007-11-01  Adam Roben  <aroben@apple.com>
1655
1656         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1657
1658         Reviewed by Sam.
1659
1660         * Scripts/commit-log-editor: Show all the directories beneath the
1661         source root, instead of just the last one.
1662
1663 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1664
1665         Reviewed by Adam Roben.
1666
1667         Print out an error message when the Windows build fails
1668         and provide guidance on how to find out what went wrong.
1669
1670         * Scripts/build-webkit:
1671         * Scripts/webkitdirs.pm:
1672
1673 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1674
1675         Rubber-stamped by Adam Roben.
1676
1677         Rolled out r27326 - debug CRT seems to cause no problems after all.
1678
1679         * DumpRenderTree/win/DumpRenderTree.vcproj:
1680
1681 2007-10-31  Adam Roben  <aroben@apple.com>
1682
1683         Switch the Debug configuration to using the non-debug CRT
1684
1685         This matches WebKit.
1686
1687         Reviewed by Steve.
1688
1689         * DumpRenderTree/win/DumpRenderTree.vcproj:
1690
1691 2007-10-31  Antti Koivisto  <antti@apple.com>
1692
1693         Reviewed by bdash.
1694         
1695         Disable media tests when doing leak checking on Tiger.
1696         They crash in QuickTime (rdar://problem/5537157).
1697
1698         * Scripts/run-webkit-tests:
1699
1700 2007-10-29  Antti Koivisto  <antti@apple.com>
1701
1702         Reviewed by Maciej.
1703         
1704         Build media support by default on OSX only.
1705
1706         * Scripts/build-webkit:
1707
1708 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1709
1710         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1711         get caught by the pre-commit hooks.
1712
1713 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1714
1715         Reviewed by Adam.
1716
1717         - This is a collection of relatively unrelated changes and cleanups
1718         to Drosera to prepare it for interacting with WebKit.  A lot of these
1719         changes are just correcting mistakes, for example removing included
1720         headers that are no longer needed.
1721
1722         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1723         this will be needed by the DebuggerClient.
1724         (DebuggerDocument::server):
1725         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1726         * Drosera/win/DebuggerClient.cpp: 
1727         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1728         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1729         (DebuggerClient::createWebViewWithRequest): Added comment about its
1730         purpose. 
1731         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1732         declarations.
1733         (DebuggerClient::webViewLoaded): Moved.
1734         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1735         file, since this was the only place it was used.
1736         (cfStringToBSTR):
1737         * Drosera/win/Drosera.h: Cleaned up the includes.
1738         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1739         * Drosera/win/HelperFunctions.h: Removed.
1740
1741 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1742
1743         Reviewed by Adam.
1744
1745         - Small cleanup in the ServerConnection class.
1746
1747         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1748         and added an include.
1749         (ServerConnection::currentFrame):
1750         (ServerConnection::getCallerFrame):
1751         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1752         made a pointer into a COMPtr, and cleaned up the includes.
1753
1754 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1755
1756         Reviewed by John Sullivan.
1757         
1758         - Place the Localizable.strings file in mac or win directories
1759           if that location exists.
1760         - Also look for UI_STRING in .c files.
1761
1762         * Scripts/extract-localizable-strings:
1763
1764 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1765
1766         Reviewed by Adam.
1767
1768         - Set the eol-style to native and made all the line endings the same
1769         so that I avoid messy diffs that show eol changes.
1770
1771         * Drosera/win/ServerConnection.cpp:
1772         (ServerConnection::didParseSource):
1773         (ServerConnection::didEnterCallFrame):
1774         (ServerConnection::willExecuteStatement):
1775         (ServerConnection::willLeaveCallFrame):
1776         (ServerConnection::exceptionWasRaised):
1777
1778 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1779
1780         Reviewed by Adam.
1781
1782         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1783         functionality that could not have existed previously without the new
1784         interfaces.
1785         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1786         from a BSTR to a JSValueRef.
1787         (DebuggerDocument::platformEvaluateScript): Implemented.
1788         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1789         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1790         Implemented.
1791         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1792         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1793         * Drosera/win/ServerConnection.cpp: Added a helper function.
1794         (ServerConnection::getCallerFrame):
1795         * Drosera/win/ServerConnection.h: Added a helper function.
1796
1797 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1798
1799         updated reviewers for my previous changelog.
1800
1801 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1802         Reviewed by Maciej and Adam and Geoff.
1803
1804         - Minor mac-side improvements including moving a function to a more
1805         appropriate location, fixing a warning, and correctly checking
1806         exceptions.
1807
1808         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1809         (DebuggerDocument::willExecuteStatement):
1810         (DebuggerDocument::didEnterCallFrame):
1811         (DebuggerDocument::willLeaveCallFrame):
1812         (DebuggerDocument::windowScriptObjectAvailable):
1813         (DebuggerDocument::callFunctionOnObject):
1814         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1815         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1816         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1817         because it doesn't require the ServerConnection at all.
1818         (NSStringCreateWithJSStringRef): Made an argument const.
1819         (JSValueRefCreateWithNSString): Made an argument const.
1820         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1821         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1822         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1823         * Drosera/mac/ServerConnection.mm: Ditto.
1824         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1825
1826 2007-10-29  Sam Weinig  <sam@webkit.org>
1827
1828         Reviewed by Adam Roben.
1829
1830         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1831
1832         * DumpRenderTree/LayoutTestController.cpp:
1833         (LayoutTestController::LayoutTestController):
1834         (getGlobalFlagCallback):
1835         (setGlobalFlagCallback):
1836         (LayoutTestController::getJSClass):
1837         (LayoutTestController::staticValues):
1838         * DumpRenderTree/LayoutTestController.h:
1839         (LayoutTestController::globalFlag):
1840         (LayoutTestController::setGlobalFlag):
1841
1842 2007-10-29  Darin Adler  <darin@apple.com>
1843
1844         Reviewed by Maciej.
1845
1846         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1847         resolution instead of its default.
1848
1849 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
1850
1851         Fixed showStatus() to print status for successfully resolved conflicts when using git.
1852
1853         Reviewed by Mark Rowe.
1854
1855         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1856         was successfully resolved, but this would not show any status because the change had
1857         already been cached in the index using "git add".  The solution is to add an optional
1858         second argument to showStatus() which adds the "--cached" switch to the command.
1859
1860         * Scripts/resolve-ChangeLogs:
1861         (showStatus):
1862
1863 2007-10-28  Eric Seidel  <eric@webkit.org>
1864
1865         Reviewed by Maciej and Geoff, in unison.
1866
1867         * Scripts/run-webkit-tests: remove broken --svg option
1868
1869 2007-10-28  Darin Adler  <darin@apple.com>
1870
1871         Reviewed by Adam.
1872
1873         * Scripts/run-sunspider: Default to "Release" configuration rather than
1874         defaulting to the last configuration used as other scripts do. This can
1875         still be overriden on the command line with "--debug" if there's some
1876         reason to do so. Also fix a typo.
1877
1878         * Scripts/sunspider-compare-results: Fix a typo.
1879
1880 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1881
1882         Reviewed by Adam.
1883
1884         - Implemented the WebScriptDebugListener functions now that the
1885         WebScriptDebugServer exists
1886
1887         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1888         functions.
1889         (ServerConnection::currentFrame):
1890         (ServerConnection::didLoadMainResourceForDataSource):
1891         (ServerConnection::didParseSource):
1892         (ServerConnection::failedToParseSource):
1893         (ServerConnection::didEnterCallFrame):
1894         (ServerConnection::willExecuteStatement):
1895         (ServerConnection::willLeaveCallFrame):
1896         (ServerConnection::exceptionWasRaised):
1897         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1898         members arguments list.
1899
1900 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1901
1902         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1903         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1904
1905         Reviewed by Darin.
1906
1907         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1908         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1909         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1910         file.  Note that it may also be used as a stand-alone script.
1911
1912         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1913         * Scripts/resolve-ChangeLogs: Added.
1914         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1915
1916 2007-10-26  Mark Rowe  <mrowe@apple.com>
1917
1918         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1919         to the Qt port on the assumption that it was an implementation of the cross-platform
1920         LayoutTestController class.  It is not, so it did not need to be changed.
1921
1922         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1923
1924 2007-10-25  Mark Rowe  <mrowe@apple.com>
1925
1926         Reviewed by Maciej.
1927
1928         Fix builds with code coverage enabled.
1929
1930         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1931
1932 2007-10-25  Darin Adler  <darin@apple.com>
1933
1934         Reviewed by Mark Rowe.
1935
1936         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1937         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1938
1939 2007-10-25  Stephanie  <slewis@apple.com>
1940
1941         build Fix
1942
1943         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1944
1945 2007-10-25  Stephanie  <slewis@apple.com>
1946
1947         Reviewed by Mark Rowe, Adam Roben.
1948
1949         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1950
1951         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1952
1953 2007-10-25  Alice Liu  <alice.liu@apple.com>
1954
1955         Reviewed by Adam.
1956
1957         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1958
1959         Moving destructor into platform-specific files
1960         * DumpRenderTree/LayoutTestController.cpp:
1961         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1962         (LayoutTestController::~LayoutTestController):
1963         * DumpRenderTree/qt/jsobjects.cpp:
1964         (LayoutTestController::~LayoutTestController):
1965
1966         LayoutTestController wasn't being destroyed
1967         * DumpRenderTree/win/DumpRenderTree.cpp:
1968         (runTest):
1969
1970         Added declspec
1971         * DumpRenderTree/win/EditingDelegate.h:
1972
1973         Reset certain values on the webview (or related delegate) that might 
1974         have changed while running a test
1975         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1976         (LayoutTestController::~LayoutTestController):
1977
1978 2007-10-25  Adam Roben  <aroben@apple.com>
1979
1980         Make sunspider-compare-results work with relative paths
1981
1982         Reviewed by Sam.
1983
1984         * Scripts/sunspider-compare-results: Convert arguments to absolute
1985         paths before we chdir.
1986
1987 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1988
1989         Reviewed by Sam.
1990
1991         - Implemented server calls now the WebScriptDebugServer exists.
1992         - Also removed no longer needed call to initialize CG.
1993
1994         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1995         automatically now.
1996         (_tWinMain):
1997         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1998         (ServerConnection::ServerConnection):
1999         (ServerConnection::~ServerConnection):
2000         (ServerConnection::pause):
2001         (ServerConnection::resume):
2002         (ServerConnection::stepInto):
2003         (ServerConnection::applicationTerminating):
2004         (ServerConnection::serverConnectionDidDie):
2005         * Drosera/win/ServerConnection.h: Now uses the COM class.
2006
2007 2007-10-24  George Staikos  <staikos@kde.org>
2008
2009         Unbreak Qt build.
2010
2011         * Scripts/build-webkit:
2012
2013 2007-10-24  Adam Roben  <aroben@apple.com>
2014
2015         Remove now-unnecessary call to InitializeCoreGraphics
2016
2017         WebKit takes care of this now.
2018
2019         Reviewed by Ada.
2020
2021         * DumpRenderTree/win/DumpRenderTree.cpp:
2022         (initialize):
2023
2024 2007-10-24  Adam Roben  <aroben@apple.com>
2025
2026         Use WebTextRenderer in DRT
2027
2028         Reviewed by Ada.
2029
2030         * DumpRenderTree/win/DumpRenderTree.cpp:
2031         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2032
2033 2007-10-24  Sven Herzberg  <sven@imendio.com>
2034
2035         Reviewed by Mark Rowe.
2036
2037         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2038         Bug 15614: [GTK] qmake based backends don't build on OS X
2039
2040         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2041         GTK backend on a Mac
2042         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2043         isDarwin() to make it reusable in other places (like the workaround-
2044         for-prebuilt-qmake in build-webkit)
2045
2046 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2047
2048         Refurbish update-webkit script.
2049
2050         Reviewed by Adam.
2051
2052         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2053         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2054         multi-argument version of system() for flexibility and security.  Check for existence
2055         of Internal directory using -d test instead of -x.
2056
2057 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2058
2059         Minor clean-up of prepare-ChangeLog script.
2060
2061         Reviewed by Adam.
2062
2063         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2064         of a string.  Use multi-argument versions of open() and system() for flexibility and
2065         security.
2066
2067 2007-10-24  Alice Liu  <alice.liu@apple.com>
2068
2069         Reviewed by Oliver.
2070
2071         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2072
2073         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2074         replay the saved events when we're still processing the mousedown that starts the drag
2075         * DumpRenderTree/win/EventSender.cpp:
2076         (doMouseMove):
2077         * DumpRenderTree/win/UIDelegate.cpp:
2078         (UIDelegate::doDragDrop):
2079
2080 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2081
2082         Reviewed by Sam, Steve and Darin.
2083
2084         - Stubbed out the WebScriptDebugListener functionality in the Server
2085         Connection class to prepare it for receiving those callbacks.
2086         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2087         and the ServerConnection to not need to be initialized with a server
2088         name, since that is not the way we connect to the WebKit server. 
2089
2090         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2091         no exception.  Now it only loggs when there is an exception
2092         (DebuggerDocument::willExecuteStatement):
2093         (DebuggerDocument::didEnterCallFrame):
2094         (DebuggerDocument::willLeaveCallFrame):
2095         (DebuggerDocument::windowScriptObjectAvailable):
2096         (DebuggerDocument::callFunctionOnObject):
2097         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2098         to be instantiated with a server's name.
2099         (DebuggerClient::DebuggerClient):
2100         (DebuggerClient::didFinishLoadForFrame):
2101         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2102         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2103         a server name.
2104         (Drosera::init):
2105         (Drosera::initServer):
2106         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2107         instantiated with a server's name.
2108         * Drosera/win/ServerConnection.cpp: 
2109         (ServerConnection::ServerConnection): No longer needs a server name
2110         (ServerConnection::~ServerConnection): Only release the global context
2111         if there is one.
2112         (ServerConnection::serverConnectionDidDie): Stub for
2113         IWebScriptDebugListener
2114         (ServerConnection::QueryInterface): ditto
2115         (ServerConnection::AddRef): ditto
2116         (ServerConnection::Release): ditto
2117         (ServerConnection::didLoadMainResourceForDataSource): ditto
2118         (ServerConnection::didParseSource): ditto
2119         (ServerConnection::failedToParseSource): ditto
2120         (ServerConnection::didEnterCallFrame): ditto
2121         (ServerConnection::willExecuteStatement): ditto
2122         (ServerConnection::willLeaveCallFrame): ditto
2123         (ServerConnection::exceptionWasRaised): ditto
2124         * Drosera/win/ServerConnection.h: Stubbed out the
2125         IWebScriptDebugListener functions, and this class no longer needs to be
2126         instantiated with a server name.
2127
2128 2007-10-24  Lars Knoll  <lars@trolltech.com>
2129
2130         Reviewed by Simon.
2131
2132         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2133
2134         * DumpRenderTree/qt/jsobjects.h:
2135
2136 2007-10-24  Lars Knoll  <lars@trolltech.com>
2137
2138         Reviewed by Simon.
2139
2140         add another command.
2141
2142         * DumpRenderTree/qt/jsobjects.cpp:
2143         (TextInputController::doCommand):
2144
2145 2007-10-24  Lars Knoll  <lars@trolltech.com>
2146
2147         Reviewed by Simon.
2148
2149         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2150
2151         * DumpRenderTree/qt/jsobjects.cpp:
2152         (EventSender::keyDown):
2153         * DumpRenderTree/qt/jsobjects.h:
2154
2155 2007-10-24  Lars Knoll  <lars@trolltech.com>
2156
2157         Reviewed by Simon.
2158
2159         implement eventSender.keyDown().
2160
2161         * DumpRenderTree/qt/jsobjects.cpp:
2162         (EventSender::keyDown):
2163
2164 2007-10-24  Lars Knoll  <lars@trolltech.com>
2165
2166         Reviewed by Simon.
2167
2168         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2169
2170         * DumpRenderTree/qt/DumpRenderTree.cpp:
2171         (WebCore::DumpRenderTree::DumpRenderTree):
2172         (WebCore::DumpRenderTree::initJSObjects):
2173         * DumpRenderTree/qt/jsobjects.cpp:
2174         (TextInputController::doCommand):
2175
2176 2007-10-24  Lars Knoll  <lars@trolltech.com>
2177
2178         Reviewed by Simon.
2179
2180         first bit of implementation for the textinputcontroller.
2181
2182         * DumpRenderTree/qt/DumpRenderTree.cpp:
2183         (WebCore::DumpRenderTree::DumpRenderTree):
2184         * DumpRenderTree/qt/DumpRenderTree.h:
2185         * DumpRenderTree/qt/jsobjects.cpp:
2186         (TextInputController::TextInputController):
2187         (TextInputController::doCommand):
2188         * DumpRenderTree/qt/jsobjects.h:
2189
2190 2007-10-24  Lars Knoll  <lars@trolltech.com>
2191
2192         Reviewed by Simon.
2193
2194         make the man webpage believe it has focus, so the editing tests work correctly.
2195
2196         * DumpRenderTree/qt/DumpRenderTree.cpp:
2197         (WebCore::DumpRenderTree::DumpRenderTree):
2198
2199 2007-10-24  Lars Knoll  <lars@trolltech.com>
2200
2201         Reviewed by Simon.
2202
2203         implement layoutTestController.dumpEditingCallbacks() correctly.
2204
2205         * DumpRenderTree/qt/DumpRenderTree.cpp:
2206         (WebCore::DumpRenderTree::DumpRenderTree):
2207         * DumpRenderTree/qt/jsobjects.cpp:
2208         (LayoutTestController::reset):
2209         (LayoutTestController::dumpEditingCallbacks):
2210
2211 2007-10-24  Lars Knoll  <lars@trolltech.com>
2212
2213         Reviewed by Simon.
2214
2215         Implement support for testing editing.
2216
2217         * DumpRenderTree/qt/DumpRenderTree.cpp:
2218         (WebCore::DumpRenderTree::DumpRenderTree):
2219
2220 2007-10-23  Sam Weinig  <sam@webkit.org>
2221
2222         Check for null BSTR that can be passed to the UIDelegate methods
2223         from javascript null and undefined.  Fixes a failing test case on
2224         Windows (fast/dom/Window/alert-undefined.html)
2225
2226         Reviewed by Eric Seidel.
2227
2228         * DumpRenderTree/win/UIDelegate.cpp:
2229         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2230         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2231         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2232         (UIDelegate::webViewAddMessageToConsole):
2233
2234 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2235
2236         Reviewed by Darin.
2237         
2238         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2239
2240         * Scripts/build-testkjs:
2241
2242 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2243
2244         Reviewed by Darin.
2245
2246         - add wrapper that finds the right copy of testkjs
2247         
2248         * Scripts/sunspider-compare-results: Added.
2249
2250 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2251
2252         Reviewed by Sam.
2253
2254         - After talking with Steve I now see that the WebKit server must be
2255         running for DCOM to create the distributed objects, which makes sense
2256         and currently WebKit only allows one instance to be running at a time
2257         which avoids accidentally connecting to the wrong server
2258         - In light of this I have removed the code for the attach box and
2259         NotificationServer and known server names, since they are all extranious
2260         now.
2261
2262         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2263         names.
2264         (_tWinMain): Uses init instead of initUI.
2265         (droseraWndProc): No longer creats an attach dialog box.
2266         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2267         it's not manditory to call init before doing COM stuff.
2268         (Drosera::init): calls initUI and will call attach when the
2269         functionality exists. 
2270         (Drosera::initUI): Has changed very little.
2271         (Drosera::attach): Changed the signature to reflect that we no longer
2272         need the dictionary of known server names.
2273         * Drosera/win/Drosera.h: Removed notification classes and known server
2274         names.  Also renamed and moved some functions.
2275         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2276         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2277         headers to the resources folder. 
2278         * Drosera/win/resource.h: Removed the Attach box.
2279
2280 2007-10-22  Adam Roben  <aroben@apple.com>
2281
2282         Windows build fix
2283
2284         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2285
2286 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2287
2288         - Removed a leak that was fixed.
2289
2290         * Scripts/run-webkit-tests:
2291
2292 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2293
2294         Reviewed by Darin.
2295
2296         - Changed the Client so that the DebuggerDocument now own the
2297         ServerConnection.  This simplifies ownership and cleanup. 
2298
2299         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2300         ServerConnection.
2301         (DebuggerClient::initWithServerName):
2302         (DebuggerClient::didFinishLoadForFrame):
2303         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2304         ServerConnection.
2305         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2306         until after we have a server which we are attached to.
2307         (Drosera::initUI):
2308         (Drosera::attach):
2309         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2310         out previously.
2311
2312 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2313
2314         Reviewed by Nikolas.
2315
2316         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2317
2318         * Scripts/run-javascriptcore-tests:
2319
2320 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2321
2322         Reviewed by Nikolas.
2323
2324         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2325
2326         * Scripts/build-drosera:
2327         * Scripts/build-dumprendertree:
2328         * Scripts/build-testkjs:
2329         * Scripts/build-webkit:
2330         * Scripts/run-javascriptcore-tests:
2331         * Scripts/run-sunspider:
2332         * Scripts/run-webkit-tests:
2333         * Scripts/webkitdirs.pm:
2334
2335 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2336
2337         Reviewed by Mark Rowe.
2338         
2339         Fix for local database support after r26879
2340         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2341
2342         * Scripts/build-webkit:
2343
2344 2007-10-22  Holger Freyther  <zecke@selfish.org>
2345
2346         Reviewed by Simon Hausmann <hausmann@kde.org>.
2347
2348         - Do not build testkjs as an application bundle. This is
2349         needed for run-javascriptcore-tests on OSX.
2350         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2351         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2352         as we do not have -rpath on OSX.
2353
2354         * DumpRenderTree/qt/DumpRenderTree.pro:
2355         * Scripts/run-webkit-tests:
2356
2357 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2358
2359         Reviewed by aroben.
2360
2361         Fix support for Signed-off-by detection in prepare-ChangeLog
2362         --git-commit. The Signed-off-by tag does not appear in the header
2363         but usually at the end.
2364
2365         * Scripts/prepare-ChangeLog:
2366
2367 2007-10-21  Mark Rowe  <mrowe@apple.com>
2368
2369         Reviewed by Eric.
2370
2371         Fix run-javascriptcore-tests for Gtk.
2372
2373         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2374
2375 2007-10-20  Eric Seidel  <eric@webkit.org>
2376
2377         Reviewed by aroben.
2378
2379         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2380
2381 2007-10-20  Eric Seidel  <eric@webkit.org>
2382
2383         Reviewed by darin.
2384         
2385         Add improved argument handling to run-sunspider, including
2386         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2387         Also re-factor code into subroutines
2388
2389         * Scripts/build-dumprendertree: removed bogus comments
2390         * Scripts/build-testkjs: Added.
2391         * Scripts/run-javascriptcore-tests: use build-testkjs
2392         * Scripts/run-sunspider: improved argument handling, abstraction
2393         * Scripts/run-webkit-tests: improved abstraction
2394
2395 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2396
2397         Not reviewed, Windows build fix.
2398
2399         * DumpRenderTree/win/EventSender.cpp:
2400         (keyDownCallback):
2401
2402 2007-10-20  Darin Adler  <darin@apple.com>
2403
2404         Reviewed by Tim Hatcher.
2405
2406         - http://bugs.webkit.org/show_bug.cgi?id=15544
2407           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2408           not rely on Apple-specific key codes
2409
2410         * DumpRenderTree/mac/EventSendingController.mm:
2411         (-[EventSendingController keyDown:withModifiers:]):
2412         Added named key "rightArrow". Later we could have a whole table of these.
2413         Also tweaked modifiers code a little.
2414
2415         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2416
2417 2007-10-19  Darin Adler  <darin@apple.com>
2418
2419         Reviewed by Eric.
2420
2421         - http://bugs.webkit.org/show_bug.cgi?id=15566
2422           possible fix for leak seen in DumpRenderTree
2423
2424         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2425         Delete the item if it's not put on the queue, since the caller has
2426         no way of knowing that. Would be better to have the parameter type
2427         be auto_ptr to express the fact that we take ownership.
2428
2429         - unrelated change
2430
2431         * Drosera/mac/main.m: Add missing include.
2432
2433 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2434
2435         Reviewed by Adam.
2436
2437         - This change should be identical but for some reason was not working
2438         on my machine.
2439
2440         * Scripts/prepare-ChangeLog:
2441
2442 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2443
2444         Reviewed by Oliver and Tim.
2445
2446         - Made use of RetainPtr to avoid retain and release issues and moved the
2447         log function to DebuggerDocumentPlatform, which seems to be a more
2448         logical place for it to live.
2449         - Also moved knownServers from the ServerConnection to
2450         DebuggerApplication to match the Windows code and because it makes sense
2451         that a connection knows its own server but not all of them.
2452
2453         * Drosera/mac/DebuggerClient.h: Moved the log function to
2454           DebuggerDocumentPlatform.
2455         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2456           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2457           call for the server name up from the ServerConnection class.
2458         (-[DebuggerClient dealloc]):
2459         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2460           for the server name up from the ServerConnection.
2461         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2462         (DebuggerDocument::platformPause):
2463         (DebuggerDocument::platformResume):
2464         (DebuggerDocument::platformStepInto):
2465         (DebuggerDocument::platformEvaluateScript):
2466         (DebuggerDocument::getPlatformCurrentFunctionStack):
2467         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2468         (DebuggerDocument::platformValueForScopeVariableNamed):
2469         (DebuggerDocument::platformLog): Log directly from here. No need to call
2470           DebuggerClient.
2471         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2472           way I see it, a ServerConnection should only know about its connection
2473           and the group of all possible servers should be kept by the
2474           application.
2475         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2476           currentServerName, it makes sense that the connection should know that
2477           name.
2478         (-[ServerConnection currentServerName]):
2479
2480 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2481
2482         Reviewed by Adam.
2483
2484         - Integrated changes from mac drosera.  Recently I've encapsulated
2485         out the server connection object from the rest of Drosera because
2486         it is very platform dependent right now and RPC is not implemented on
2487         windows.  This functionality, of communicating with the WebKit server
2488         is the next area I will be focusing on in Windows.
2489
2490         - Other changes and cleanup were made to organize the code and add notes
2491         on which parts still need work.  Also some mac code is added and
2492         commented out, to act as pseudocode for the logic of those parts.
2493
2494         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2495           pointer.
2496         * Drosera/config.h: Added whitespace.
2497         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2498           these files got moved into Drosera.h/cpp
2499         * Drosera/win/DebuggerApplication.h: Removed.
2500         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2501           happened here to better match the logic flow of the same code on the 
2502           mac side and to use the new ServerConnection class.
2503         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2504         (DebuggerClient::initWithServerName): Initializer that will set up the
2505           class to use a ServerConnection object.  This was necessary so I could
2506           create a DebuggerClient without having to initilaize it at
2507           construction.
2508         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2509           will be the UIDelegate and FrameLoadDelegate.
2510         (DebuggerClient::AddRef): For IUnknown.
2511         (DebuggerClient::Release): For IUnknown.
2512         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2513           this still needs to set the global context of the server, but
2514           IWebFrame does not have an accessor for the global context yet. 
2515         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2516           this is a pass through for the same function in the document.
2517         (DebuggerClient::didReceiveTitle): Unimplemented part of
2518           FrameLoadDelegate this would change the title of the window.
2519         (DebuggerClient::createWebViewWithRequest): Part of the
2520           FrameLoadDelegate.  This is about new windows via Window.open() and
2521           how their delegates are set.
2522         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2523           UIDelegate.  Just a debug function for printing messages.
2524         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2525           because the Client should be the UIDelegate and FrameLoadDelegate
2526           to match the delegates on mac.
2527         (DebuggerClient::webViewLoaded): Added accessor method.
2528         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2529           forgotten to add this file before.  This is where the platform
2530           dependent versions of the Documents functions live. Most of these are
2531           unimplemented because some piece of functionality does not exist on
2532           Windows yet.
2533         (DebuggerDocument::platformPause):
2534         (DebuggerDocument::platformResume):
2535         (DebuggerDocument::platformStepInto):
2536         (DebuggerDocument::platformEvaluateScript):
2537         (DebuggerDocument::getPlatformCurrentFunctionStack):
2538         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2539         (DebuggerDocument::platformValueForScopeVariableNamed):
2540         (DebuggerDocument::platformLog):
2541         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2542           responsibilities becaue they belong in the Client. Also I laid the
2543           groundwork for attaching Drosera to a WebKit process
2544         (attachWndProc): Now if a server is selected the Client becomes it's
2545           delegate.
2546         (Drosera::Drosera): Added the construction of the Client and dictionary
2547           of server names. 
2548         (Drosera::initUI): This is no longer the delegates, the Client is.
2549         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2550           state. 
2551         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2552           notification registration when it's possible to implement.
2553         (Drosera::serverLoaded): Ditto
2554         (Drosera::serverUnloaded): Ditto
2555         (Drosera::attach): Attach Drosera to the WebKit server.
2556         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2557         (Drosera::getInst): 
2558         (Drosera::setInst):
2559         (Drosera::knownServers):
2560         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2561           and added the ServerConnection.
2562         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2563         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2564           Most of the functions are completely unimlemented because they cannot
2565           connect with the WebKit server, because one does not exist on Windows
2566           yet.
2567         (ServerConnection::initWithServerName): 
2568         (ServerConnection::~ServerConnection):
2569         (ServerConnection::setGlobalContext):
2570         (ServerConnection::pause):
2571         (ServerConnection::resume):
2572         (ServerConnection::stepInto):
2573         (ServerConnection::switchToServerNamed):
2574         (ServerConnection::applicationTerminating):
2575         (ServerConnection::serverConnectionDidDie):
2576         (ServerConnection::currentFrame):
2577         * Drosera/win/ServerConnection.h: Added. Ditto.
2578         (ServerConnection::ServerConnection):
2579
2580 2007-10-19  Alice Liu  <alice.liu@apple.com>
2581
2582         Reviewed by Darin.
2583
2584         Fix for these broken layout tests on Windows:
2585         
2586         fast/forms/focus-selection-input.html
2587         fast/forms/focus-selection-textarea.html
2588         fast/forms/select-accesskey.html
2589         
2590         * DumpRenderTree/win/EventSender.cpp:
2591         (keyDownCallback):
2592         correct the VK code for alt key.
2593         
2594 2007-10-19  Eric Seidel  <eric@webkit.org>
2595
2596         Reviewed by Mark Rowe.
2597         
2598         Make the GtkLauncher code slightly more readable.
2599
2600         * GtkLauncher/main.cpp:
2601         (setupMainMenu): Added.
2602         (setupMainWindowUI): Added.
2603         (main):
2604
2605 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2606
2607         Rubber stamped by Adam.
2608         
2609         - don't delay-load WebKit in DumpRenderTree.
2610
2611         * DumpRenderTree/win/DumpRenderTree.vcproj:
2612
2613 2007-10-18  Dan Bernstein  <mitz@apple.com>
2614
2615         Reviewed by Adam Roben.
2616
2617         - fix <rdar://problem/5313523>
2618         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2619
2620         * DumpRenderTree/mac/DumpRenderTree.mm:
2621         (dump): Changed to use _responseMIMEType.
2622
2623 2007-10-17  Adam Roben  <aroben@apple.com>
2624
2625         Make it possible to have Windows-specific tests and results
2626
2627         When searching for tests to run and the Skipped file, we will only
2628         look in platform/win and the cross-platform directory. When looking
2629         for expected results, we will look in platform/win, then
2630         platform/mac-leopard, then platform/mac, then finally the
2631         cross-platform directory.
2632
2633         Reviewed by Sam.
2634
2635         * Scripts/run-webkit-tests:
2636         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2637         searching in the cross-platform directory.
2638         (sub buildPlatformHierarchy): Removed some unneeded calls to
2639         dirname/basename.
2640
2641 2007-10-17  Adam Roben  <aroben@apple.com>
2642
2643         Add back the call to register WebKit that we had before WebKitInitializer existed
2644
2645         This is needed to ensure that the right WebKit is used when
2646         instantiating COM objects.
2647
2648         Reviewed by Oliver.
2649
2650         * DumpRenderTree/win/debug_internal.vsprops: Define
2651         DEBUG_WEBKIT_HAS_SUFFIX.
2652         * DumpRenderTree/win/DumpRenderTree.cpp:
2653         (initialize):
2654
2655 2007-10-17  Adam Roben  <aroben@apple.com>
2656
2657         Import File::Basename in webkitdirs since we use it
2658
2659         * Scripts/webkitdirs.pm:
2660
2661 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2662
2663         - Updated the tiger leaks list to make the internal bots green.
2664
2665         * Scripts/run-webkit-tests:
2666
2667 2007-10-17  Adam Roben  <aroben@apple.com>
2668
2669         Build fix for VC++ Express
2670
2671         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2672         and ole32.lib.
2673
2674 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2675
2676         Reviewed by Sam.
2677
2678         - Minor mac improvements based on observations I made while implementing the
2679         Windows code.
2680
2681         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2682         then hand it to the Client who will retain it, it should just be the client who
2683         creates and owns the server.
2684         (-[DebuggerApplication attach:]):
2685         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2686         * Drosera/mac/DebuggerClient.mm: Creates the server.
2687         (-[DebuggerClient initWithServerName:]):
2688         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2689         can instead forward declare what it needs.
2690
2691 2007-10-16  Darin Adler  <darin@apple.com>
2692
2693         Reviewed by Geoff Garen.
2694
2695         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2696         want to turn failing tests into platform-specific test results. Also did a
2697         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2698         would take the type of results into account only some of the time.
2699
2700 2007-10-16  Adam Roben  <aroben@apple.com>
2701
2702         Add a new nightly launcher script for Windows
2703
2704         This new script is for versions of Safari that don't delay-load
2705         WebKit. I had to make FindSafari be able to print out the nightly
2706         launcher script on stdout because Windows shell scripts can't capture
2707         the output from a command into an environment variable.
2708
2709         Reviewed by Steve.
2710
2711         * FindSafari/FindSafari.cpp:
2712         (_tmain): Added /printSafariLauncher option.
2713         * Scripts/run-webkit-nightly.cmd: Added.
2714
2715 2007-10-16  Adam Roben  <aroben@apple.com>
2716
2717         Replace WebKitInitializer with FindSafari
2718
2719         We now rely on setting the PATH environment variable to tell Windows
2720         where to find WebKit and its dependencies (similar to
2721         DYLD_FRAMEWORK_PATH on Mac).
2722
2723         This change also make DumpRenderTree no longer delay-load WebKit.
2724
2725         Reviewed by Sam.
2726
2727         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2728         FindSafari.
2729         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2730         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2731         WebKitInitializer, don't delay-load WebKit.
2732         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2733         * Scripts/run-webkit-tests: Ditto.
2734         * Scripts/webkitdirs.pm:
2735         (sub setPathForRunningWebKitApp): Added.
2736         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2737         * WebKitInitializer/WebKitInitializer.h: Removed.
2738         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2739         * WebKitInitializer/debug.vsprops: Removed.
2740         * WebKitInitializer/debug_internal.vsprops: Removed.
2741         * WebKitInitializer/release.vsprops: Removed.
2742
2743 2007-10-16  Adam Roben  <aroben@apple.com>
2744
2745         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2746
2747         http://bugs.webkit.org/show_bug.cgi?id=15532
2748
2749         FindSafari simply prints the location of an installed Safari.exe on
2750         stdout.
2751
2752         Reviewed by Darin.
2753
2754         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2755         (getStringValue):
2756         (getWebViewCLSID):
2757         (getInstalledWebKitDirectory):
2758         (_tmain):
2759         * FindSafari/FindSafari.vcproj: Added.
2760         * Scripts/webkitdirs.pm:
2761         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2762
2763 2007-10-16  Adam Roben  <aroben@apple.com>
2764
2765         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2766
2767         Reviewed by Kevin McCullough.
2768
2769         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2770         when referring to WebKit.dll.
2771         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2772         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2773         * DumpRenderTree/win/release.vsprops: Ditto.
2774         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2775         never have a _debug suffix on WebKit.dll.
2776         * WebKitInitializer/WebKitInitializer.cpp:
2777         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2778         specified.
2779         * WebKitInitializer/debug_internal.vsprops: Added
2780         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2781
2782 2007-10-16  Darin Adler  <darin@apple.com>
2783
2784         Reviewed by Adele.
2785
2786         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2787         Remove now-unneeded control/alt key hack; the tests have been updated.
2788
2789 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2790
2791         - Updated leaks list because our internal bot upgraded it's version of leopard and 
2792         one of the leaks was fixed between that revision and the bot's previous version of
2793         leopard.
2794
2795         * Scripts/run-webkit-tests:
2796
2797 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
2798
2799         Reviewed by Tim.
2800
2801         - I encapsulated out the server connecton functionality because it is a specific part
2802         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2803         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
2804         Windows.  So the majority of this patch is moving preexisting functionality.
2805
2806         - Also I removed the prefix header and changed to use config.h because it is more
2807         standard on how we use config.h in windows and it didn't make much sense to keep
2808         the prefix header and the config.h
2809
2810         * Drosera/DebuggerDocument.cpp:
2811         (DebuggerDocument::DebuggerDocument):
2812         * Drosera/DebuggerDocument.h:
2813         * Drosera/config.h:
2814         * Drosera/mac/DebuggerApplication.mm:
2815         (-[DebuggerApplication attach:]):
2816         * Drosera/mac/DebuggerClient.h:
2817         * Drosera/mac/DebuggerClient.mm:
2818         (-[DebuggerClient initWithServerConnection:]):
2819         (-[DebuggerClient dealloc]):
2820         (-[DebuggerClient windowDidLoad]):
2821         (-[DebuggerClient windowWillClose:]):
2822         (-[DebuggerClient webView:didFinishLoadForFrame:]):
2823         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2824         * Drosera/mac/DebuggerDocumentPlatform.mm:
2825         (DebuggerDocument::platformPause):
2826         (DebuggerDocument::platformResume):
2827         (DebuggerDocument::platformStepInto):
2828         (DebuggerDocument::platformEvaluateScript):
2829         (DebuggerDocument::getPlatformCurrentFunctionStack):
2830         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2831         (DebuggerDocument::platformValueForScopeVariableNamed):
2832         (DebuggerDocument::platformLog):
2833         * Drosera/mac/Drosera.pch: Removed.
2834         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2835         * Drosera/mac/ServerConnection.h: Added.
2836         * Drosera/mac/ServerConnection.mm: Added.
2837         (-[ServerConnection initWithServerName:]):
2838         (-[ServerConnection dealloc]):
2839         (-[ServerConnection setGlobalContext:]):
2840         (-[ServerConnection pause]):
2841         (-[ServerConnection resume]):
2842         (-[ServerConnection stepInto]):
2843         (-[ServerConnection switchToServerNamed:]):
2844         (-[ServerConnection applicationTerminating:]):
2845         (-[ServerConnection serverConnectionDidDie:]):
2846         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2847         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2848         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2849         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2850         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2851         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2852         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2853         (-[ServerConnection currentFrame]):
2854         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2855         (-[ServerConnection knownServers]):
2856
2857 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
2858
2859         Reviewed by Eric.
2860
2861         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2862           Script to automatically search nightly builds for regressions (bisect-builds)
2863
2864         * Scripts/bisect-builds: Added.
2865
2866 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2867
2868         Reviewed by Darin.
2869
2870         - New JavaScript benchmark
2871         http://bugs.webkit.org/show_bug.cgi?id=15515
2872
2873         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2874         current development or release build of JavaScriptCore.
2875
2876 2007-10-15  Mark Rowe  <mrowe@apple.com>
2877
2878         Reviewed by Sam.
2879
2880         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2881
2882         * Scripts/webkitdirs.pm:
2883         - Change checkArgv to remove the options from @ARGV to prevent
2884         them from interfering with further option processing.
2885         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2886         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2887         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2888         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2889
2890 2007-10-15  Darin Adler  <darin@apple.com>
2891
2892         Reviewed by Sam.
2893
2894         - added logging of window.prompt and window.confirm
2895
2896         * DumpRenderTree/mac/UIDelegate.mm:
2897         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2898         Implement the recommended delegate rather than the deprecated one.
2899         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2900         Added.
2901         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2902         Added.
2903
2904         * DumpRenderTree/win/UIDelegate.h:
2905         * DumpRenderTree/win/UIDelegate.cpp:
2906         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2907         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2908         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2909         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2910
2911 2007-10-15  Alice Liu  <alice.liu@apple.com>
2912
2913         Reviewed by Sam Weinig.
2914
2915         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2916
2917         * DumpRenderTree/win/DumpRenderTree.cpp:
2918         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2919         (main): allocate the global policy delegate for DRT's custom use
2920         * DumpRenderTree/win/DumpRenderTree.vcproj:
2921         Adding files to project
2922         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2923         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2924         (LayoutTestController::setCustomPolicyDelegate):
2925         set the webview's policy delegate to DRT's custom one if the test requests it.
2926         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2927         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2928         (PolicyDelegate::PolicyDelegate):
2929         (PolicyDelegate::QueryInterface):
2930         (PolicyDelegate::AddRef):
2931         (PolicyDelegate::Release):
2932         (PolicyDelegate::decidePolicyForNavigationAction):
2933         * DumpRenderTree/win/PolicyDelegate.h: Added.
2934         (PolicyDelegate::decidePolicyForNewWindowAction):
2935         (PolicyDelegate::decidePolicyForMIMEType):
2936         (PolicyDelegate::unableToImplementPolicyWithError):
2937
2938 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2939
2940         Reviewed by Mark.
2941
2942         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2943         when querying for QMAKE_MKSPECS.
2944
2945 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2946
2947         Reviewed by Adam Roben.
2948         
2949         Fix run-webkit-tests is too greedy calculating platform hierarchy
2950         http://bugs.webkit.org/show_bug.cgi?id=15465
2951         
2952         Fix run-webkit-tests being too greedy in trying to split the platform name up
2953         causing it to try and find tests in every directory above the first "-" in the
2954         path to the LayoutTests
2955
2956         * Scripts/run-webkit-tests:
2957
2958 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2959
2960         Reviewed by Darin.
2961
2962         http://bugs.webkit.org/show_bug.cgi?id=15006
2963         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2964         to reduce code duplication.
2965
2966         * Scripts/build-webkit:
2967         * Scripts/webkitdirs.pm:
2968         buildQMakeProject() renamed to buildQMakeQtProject().
2969         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2970         unused $colorize has been removed.
2971
2972 === Start merge of feature-branch 2007-10-12 ===
2973
2974 2007-10-08  Eric Seidel  <eric@webkit.org>
2975
2976         Reviewed by Mark Rowe.
2977
2978         * Scripts/build-webkit: add --help, remove unused --color
2979
2980 2007-10-07  Eric Seidel  <eric@webkit.org>
2981
2982         Reviewed by darin.
2983
2984         * Drosera/mac/DebuggerDocumentPlatform.mm:
2985         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2986
2987 2007-10-03  Rob Buis  <buis@kde.org>
2988
2989         Reviewed by Olliej.
2990
2991         Adapt to changed location of Ahem font.
2992
2993         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2994
2995 2007-10-02  Eric Seidel  <eric@webkit.org>
2996
2997         Reviewed by Adam Roben.
2998         
2999         Make pixel tests more useful!
3000         Finally fix the image diff 0.00% mystery problem
3001         Highlight any image differences in the image diff.
3002         Add a link from image diffs back to original test file.
3003
3004         * DumpRenderTree/mac/ImageDiff.m:
3005         (compareImages): highlight any differences
3006         (computePercentageDifferent): round to two decimal places
3007         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3008
3009 2007-10-02  Eric Seidel  <eric@webkit.org>
3010
3011         Reviewed by Alexey Proskuryakov.
3012
3013         * Scripts/run-webkit-tests: print the % image difference on main results page
3014
3015 2007-10-02  Mark Rowe  <mrowe@apple.com>
3016
3017         Reviewed by Oliver.
3018
3019         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3020
3021         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3022         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3023
3024 2007-10-01  Mark Rowe  <mrowe@apple.com>
3025
3026         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3027
3028 2007-09-25  Eric Seidel  <eric@webkit.org>
3029
3030         Reviewed by Mark Rowe.
3031         
3032         DerivedSources.make was finding "ENABLE_SVG" in the string
3033         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3034         quite correctly.
3035
3036         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3037
3038 2007-09-25  Mark Rowe  <mrowe@apple.com>
3039
3040         Rubber-stamped by Eric.
3041
3042         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3043         This makes it possible to automate nightly builds for the feature-branch.
3044
3045 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3046
3047         Rubber stamped by Mark.
3048
3049         Enable svg experimental features as default here in feature-branch.
3050
3051         * Scripts/build-webkit:
3052
3053 2007-06-29  Antti Koivisto  <antti@apple.com>
3054
3055         Reviewed by Weinig.
3056         
3057         Add VIDEO flag for timed media features
3058
3059         * Scripts/build-webkit
3060         
3061 === End merge of feature-branch 2007-10-12 ===
3062
3063 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3064
3065         Reviewed by Darin.
3066
3067         - Updated rational for the leaks list to be more clear.
3068
3069         * Scripts/run-webkit-tests:
3070
3071 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3072
3073         Rubber Stamp by Sam.
3074
3075         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3076         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3077
3078         * Scripts/run-webkit-tests:
3079
3080 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3081
3082         Reviewed by Lars.
3083
3084         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3085         includes are needed for INT_MAX, std::auto_ptr and the like.
3086
3087         * DumpRenderTree/qt/main.cpp:
3088
3089 2007-10-09  Lars Knoll  <lars@trolltech.com>
3090
3091         Reviewed by Simon.
3092
3093         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3094
3095         * DumpRenderTree/qt/jsobjects.cpp:
3096         (LayoutTestController::encodeHostName):
3097         (LayoutTestController::decodeHostName):
3098         * DumpRenderTree/qt/jsobjects.h:
3099
3100 2007-10-09  Lars Knoll  <lars@trolltech.com>
3101
3102         Reviewed by Simon.
3103
3104         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3105
3106         * DumpRenderTree/qt/DumpRenderTree.cpp:
3107         (WebCore::WebPage::createFrame):
3108         (WebCore::DumpRenderTree::DumpRenderTree):
3109         (WebCore::DumpRenderTree::titleChanged):
3110         * DumpRenderTree/qt/DumpRenderTree.h:
3111         * DumpRenderTree/qt/jsobjects.cpp:
3112         (LayoutTestController::reset):
3113         * DumpRenderTree/qt/jsobjects.h:
3114
3115 2007-10-09  Lars Knoll  <lars@trolltech.com>
3116
3117         Reviewed by Simon.
3118
3119         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3120
3121         * DumpRenderTree/qt/DumpRenderTree.h:
3122         * DumpRenderTree/qt/jsobjects.cpp:
3123         (LayoutTestController::clearBackForwardList):
3124         * DumpRenderTree/qt/jsobjects.h:
3125
3126 2007-10-09  Lars Knoll  <lars@trolltech.com>
3127
3128         Reviewed by Simon.
3129
3130         make --git-reviewer work again.
3131
3132         * Scripts/prepare-ChangeLog:
3133
3134 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3135
3136         Rubber stamped by Eric.
3137
3138         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3139         show the current link inside the statusbar.
3140         This shows how to make use of this signal and allows to easily test
3141         http://bugs.webkit.org/show_bug.cgi?id=15299.
3142
3143         * GtkLauncher/main.cpp:
3144         (hoveringOverLink):
3145         (main):
3146
3147 2007-10-05  Lars Knoll  <lars@trolltech.com>
3148
3149         add proper error messages to the FrameLoaderClient.
3150         Implement ChromeClientQt::closeWindowSoon and
3151         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3152         Some fixes in DRT to make it work correctly with multiple windows.
3153
3154         Reviewed by Maciej.
3155
3156         * DumpRenderTree/qt/DumpRenderTree.cpp:
3157         (WebCore::DumpRenderTree::DumpRenderTree):
3158         (WebCore::DumpRenderTree::createWindow):
3159         (WebCore::DumpRenderTree::windowCount):
3160         * DumpRenderTree/qt/DumpRenderTree.h:
3161         * DumpRenderTree/qt/jsobjects.cpp:
3162         (LayoutTestController::maybeDump):
3163         (LayoutTestController::windowCount):
3164         * DumpRenderTree/qt/jsobjects.h:
3165
3166 2007-10-05  Lars Knoll  <lars@trolltech.com>
3167
3168         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3169         Add support for layoutTextController.setCanOpenWindows() to DRT
3170         fixing another 2 test cases in fast/dom/Window.
3171
3172         Reviewed by Maciej.
3173
3174         * DumpRenderTree/qt/DumpRenderTree.cpp:
3175         (WebCore::WebPage::WebPage):
3176         (WebCore::WebPage::createWindow):
3177         (WebCore::DumpRenderTree::resetJSObjects):
3178         (WebCore::DumpRenderTree::createWindow):
3179         * DumpRenderTree/qt/DumpRenderTree.h:
3180         * DumpRenderTree/qt/DumpRenderTree.pro:
3181         * DumpRenderTree/qt/jsobjects.cpp:
3182         (LayoutTestController::LayoutTestController):
3183         (LayoutTestController::reset):
3184         * DumpRenderTree/qt/jsobjects.h:
3185         * DumpRenderTree/qt/main.cpp:
3186         * DumpRenderTree/qt/testplugin.cpp: Added.
3187         * DumpRenderTree/qt/testplugin.h: Added.
3188
3189 2007-10-04  Sam Weinig  <sam@webkit.org>
3190
3191         Rubber stamped by Adam.
3192
3193         Remove empty directories.
3194
3195         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3196         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3197
3198 2007-10-03  Darin Adler  <darin@apple.com>
3199
3200         Reviewed by Adam.
3201
3202         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3203         we find the internal libraries in the libraries directory. This
3204         is helpful for Safari team engineers at Apple.
3205
3206 2007-10-03  Adam Roben  <aroben@apple.com>
3207
3208         Update the location of AHEM___.TTF after r25968
3209
3210         Reviewed by Sam.
3211
3212         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3213
3214 2007-10-03  Alp Toker  <alp@atoker.com>
3215
3216         Reviewed by Adam.
3217
3218         http://bugs.webkit.org/show_bug.cgi?id=14726
3219         [gtk] API design. Mapping the WebView delegates to signals.
3220
3221         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3222
3223         * GtkLauncher/main.cpp:
3224         (goToURLBarText):
3225         (titleChanged):
3226         (progressChanged):
3227         (menuMainBackCallback):
3228         (menuMainForwardCallback):
3229         (main):
3230
3231 2007-10-03  Lars Knoll  <lars@trolltech.com>
3232
3233         Reviewed by Rob.
3234
3235         This fixes --strict mode in run-webkit-tests again after
3236         the platform dependent test results have been moved.
3237
3238         * Scripts/run-webkit-tests:
3239
3240 2007-10-03  Lars Knoll  <lars@trolltech.com>
3241
3242         Reviewed by bdash.
3243
3244         remove the hack in run-webkit-tests that forced text only test
3245         to be taken from the platform independent dir. It was only left
3246         there from early days.
3247         
3248         Remove platform dependent results for tests that are text only nowadays,
3249         and add one platform dependent result for a text only test that requires it.
3250
3251         * Scripts/run-webkit-tests:
3252
3253 2007-10-03  Lars Knoll  <lars@trolltech.com>
3254
3255         Reviewed by olliej.
3256
3257         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3258
3259         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3260         (WebCore::WebFrame::WebFrame):
3261         (WebCore::WebPage::WebPage):
3262         (WebCore::WebPage::createFrame):
3263         (WebCore::WebPage::javaScriptAlert):
3264         (WebCore::WebPage::javaScriptConsoleMessage):
3265         (WebCore::DumpRenderTree::DumpRenderTree):
3266         (WebCore::DumpRenderTree::~DumpRenderTree):
3267         (WebCore::DumpRenderTree::open):
3268         (WebCore::DumpRenderTree::readStdin):
3269         (WebCore::DumpRenderTree::resetJSObjects):
3270         (WebCore::DumpRenderTree::initJSObjects):
3271         (WebCore::DumpRenderTree::dumpFramesAsText):
3272         (WebCore::DumpRenderTree::dump):
3273         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3274         (WebCore::DumpRenderTree::layoutTestController):
3275         (WebCore::DumpRenderTree::eventSender):
3276         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3277         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3278         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3279         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3280         (HackWebFrame::mousePressEvent):
3281         (HackWebFrame::mouseReleaseEvent):
3282         (HackWebFrame::mouseMoveEvent):
3283         (HackWebFrame::HackWebFrame):
3284         (HackWebFrame::~HackWebFrame):
3285         (LayoutTestController::LayoutTestController):
3286         (LayoutTestController::reset):
3287         (LayoutTestController::maybeDump):
3288         (LayoutTestController::waitUntilDone):
3289         (LayoutTestController::notifyDone):
3290         (LayoutTestController::dumpEditingCallbacks):
3291         (LayoutTestController::queueReload):
3292         (LayoutTestController::provisionalLoad):
3293         (LayoutTestController::timerEvent):
3294         (EventSender::EventSender):
3295         (EventSender::mouseDown):
3296         (EventSender::mouseUp):
3297         (EventSender::mouseMoveTo):
3298         (EventSender::leapForward):
3299         (EventSender::keyDown):
3300         (EventSender::frameUnderMouse):
3301         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3302         (LayoutTestController::isLoading):
3303         (LayoutTestController::setLoading):
3304         (LayoutTestController::shouldDumpAsText):
3305         (LayoutTestController::shouldDumpChildrenAsText):
3306         (LayoutTestController::shouldWaitUntilDone):
3307         (LayoutTestController::dumpAsText):
3308         (LayoutTestController::dumpChildFramesAsText):
3309         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3310         (messageHandler):
3311         (crashHandler):
3312         (main):
3313         * Scripts/run-webkit-tests:
3314
3315 2007-10-03  Mark Rowe  <mrowe@apple.com>
3316
3317         Reviewed by Alp Toker.
3318
3319         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3320         should take precedence over QTDIR when determining which port we are working with.
3321
3322         * Scripts/webkitdirs.pm: 
3323
3324 2007-10-02  Adam Roben  <aroben@apple.com>
3325
3326         Add keychain to the list of default packages to install
3327
3328         Rubberstamped by Sam.
3329
3330         * CygwinDownloader/cygwin-downloader.py:
3331         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3332
3333 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3334
3335         Reviewed by Adam.
3336
3337         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3338         Also makes WebCore regression test case logic work when using git.
3339
3340         * Scripts/prepare-ChangeLog:
3341         (reviewerAndDescriptionForGitCommit): Added.
3342
3343 2007-10-02  Lars Knoll  <lars@trolltech.com>
3344
3345         Reviewed by bdash.
3346
3347         Add API to retrieve the frame name from QWebFrame.
3348         Implement support for DRT::dumpChildrenAsText.
3349
3350         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3351         (WebCore::DumpRenderTree::dumpFramesAsText):
3352         (WebCore::DumpRenderTree::dump):
3353         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3354         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3355         (LayoutTestController::LayoutTestController):
3356         (LayoutTestController::reset):
3357         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3358
3359 2007-10-02  Lars Knoll  <lars@trolltech.com>
3360
3361         Reviewed by bdash.
3362
3363         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3364
3365         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3366         (WebCore::DumpRenderTree::readStdin):
3367
3368 2007-10-02  Mark Rowe  <mrowe@apple.com>
3369
3370         Reviewed by Oliver.
3371
3372         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3373
3374         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3375         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3376
3377 2007-10-02  Mark Rowe  <mrowe@apple.com>
3378
3379         Rubber-stamped by Maciej.
3380
3381         Configuration changes from build.webkit.org.  The major change is refactoring to work
3382         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3383         last few weeks.
3384
3385         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3386         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3387         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3388         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3389         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3390         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3391         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3392         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3393
3394 2007-10-02  Lars Knoll  <lars@trolltech.com>
3395
3396         Reviewed by Maciej.
3397
3398         Add support for eventSender.mouseMove to DRT.
3399         Fixes fast/css/hover-affects-child.html
3400
3401         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3402         (EventSender::mouseMoveTo):
3403
3404 2007-10-01  Mark Rowe  <mrowe@apple.com>
3405
3406         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3407
3408 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3409
3410         Reviewed by Hyatt.
3411
3412         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3413
3414         * Scripts/svn-apply:
3415         (gitdiff2svndiff): Ignore lines beginning with "new file".
3416         * Scripts/svn-unapply:
3417         (gitdiff2svndiff): Ditto.
3418
3419 2007-09-30  George Staikos  <staikos@kde.org>
3420
3421         Qt build fix (Mac OS X specific)
3422
3423         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3424
3425 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3426
3427         Reviewed by Mark.
3428
3429         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3430         Remove Bakefiles from svn.
3431
3432         * GtkLauncher/Bakefiles.bkgen: Removed.
3433         * GtkLauncher/ENV: Removed.
3434         * GtkLauncher/gdklauncher.bkl: Removed.
3435         * GtkLauncher/mk: Removed.
3436         * Scripts/regenerate-makefiles: Removed.
3437
3438 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3439
3440         Reviewed by John.
3441
3442         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3443
3444         * Scripts/run-webkit-tests:
3445
3446 2007-09-26  Adam Roben  <aroben@apple.com>
3447
3448         Make not finding an installed WebKit non-fatal
3449
3450         What really matters is that we are able to load WebKit and its
3451         dependencies, not whether we think we've found an installed WebKit.
3452
3453         Reviewed by Sam.
3454
3455         * WebKitInitializer/WebKitInitializer.cpp:
3456         (getWebViewCLSID): Use new LOG_WARNING macro.
3457         (getInstalledWebKitDirectory): Ditto.
3458         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3459         and use new macros.
3460         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3461
3462 2007-09-26  Adam Roben  <aroben@apple.com>
3463
3464         Committed this file before saving it
3465
3466         * WebKitInitializer/debug_internal.vsprops:
3467
3468 2007-09-26  Adam Roben  <aroben@apple.com>
3469
3470         Load WebKit and its dependencies manually so they come from DllDirectory
3471
3472         I had to change WebKitInitializer to use malloc/free instead of
3473         new/delete to avoid pulling in WebKit (and its dependencies) early
3474         through use of fastMalloc.
3475
3476         Reviewed by Oliver.
3477
3478         * WebKitInitializer/WebKitInitializer.cpp:
3479         (getStringValue): Changed to use malloc/free.
3480         (getInstalledWebKitDirectory): Ditto.
3481         (initializeWebKit): Call SetDllDirectory first, then load all of
3482         WebKit's dependencies manually, finally followed by WebKit itself.
3483         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3484         configuration to match our other projects.
3485         * WebKitInitializer/debug_internal.vsprops: Added.
3486
3487 2007-09-25  Adam Roben  <aroben@apple.com>
3488
3489         Actually define DEBUG/NDEBUG so that we load WebKit correctly
3490
3491         Rubberstamped by Sam.
3492
3493         * WebKitInitializer/WebKitInitializer.vcproj:
3494
3495 2007-09-25  Adam Roben  <aroben@apple.com>
3496
3497         Make DumpRenderTree delay-load its dependencies
3498
3499         This lets WebKitInitializer re-route the dependencies to be loaded out
3500         of the Safari installation directory.
3501
3502         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3503         same thing), since we can't import the kCFAllocatorDefault symbol when
3504         delay-loading CoreFoundation.dll.
3505
3506         Rubberstamped by Sam.
3507
3508         * DumpRenderTree/win/DumpRenderTree.cpp:
3509         (runTest):
3510         (javaScriptThreads):
3511         * DumpRenderTree/win/DumpRenderTree.vcproj:
3512         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3513         (LayoutTestController::setWaitToDump):
3514
3515 2007-09-25  Adam Roben  <aroben@apple.com>
3516
3517         Pull ole32.lib into WebKitInitializer
3518
3519         Rubberstamped by Sam.
3520
3521         * WebKitInitializer/WebKitInitializer.vcproj:
3522
3523 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3524
3525         Reviewed by Adam.
3526
3527         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3528           LGPL'ed files contain incorrect FSF address
3529
3530         * Drosera/config.h:
3531
3532 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3533
3534         Reviewed by Adam.
3535
3536         Make svn-apply and svn-unapply work with git-diff formatted patches.
3537
3538         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
3539         (gitdiff2svndiff): Added.
3540         * Scripts/svn-unapply: Ditto.
3541         (gitdiff2svndiff): Added.
3542
3543 2007-09-25  Adam Roben  <aroben@apple.com>
3544
3545         Pull advapi32.lib into WebKitInitializer
3546
3547         This is needed to get the registry functions we use.
3548
3549         Rubberstamped by Sam.
3550
3551         * WebKitInitializer/WebKitInitializer.vcproj:
3552
3553 2007-09-25  Adam Roben  <aroben@apple.com>
3554
3555         Add python and rsync to cygwin-downloader
3556
3557         Our build slaves need this, and it can't hurt for everyone else to
3558         have it, too.
3559
3560         Reviewed by Sam.
3561
3562         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
3563         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3564
3565 2007-09-25  Adam Roben  <aroben@apple.com>
3566
3567         Add WebKitInitializer and use it in DumpRenderTree
3568
3569         WebKitInitializer is a static library that has one function,
3570         initializeWebKit(). This registers WebKit and sets up the DLL search
3571         path so that WebKit's dependencies that are installed with Safari can
3572         be found.
3573
3574         Reviewed by Sam.
3575
3576         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
3577         DumpRenderTree depend on it.
3578         * DumpRenderTree/win/DumpRenderTree.cpp:
3579         (initialize): Call initializeWebKit.
3580         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
3581         WebKitInitializer.lib.
3582         * WebKitInitializer/WebKitInitializer.cpp: Added.
3583         (getStringValue):
3584         (getWebViewCLSID):
3585         (getInstalledWebKitDirectory):
3586         (initializeWebKit):
3587         * WebKitInitializer/WebKitInitializer.h: Added.
3588         * WebKitInitializer/WebKitInitializer.vcproj: Added.
3589         * WebKitInitializer/debug.vsprops: Added.
3590         * WebKitInitializer/release.vsprops: Added.
3591
3592 2007-09-25  Adam Roben  <aroben@apple.com>
3593
3594         Make run-webkit-tests respect set-webkit-configuration
3595
3596         Reviewed by Sam.
3597
3598         * Scripts/run-webkit-tests: Initialize $configuration to whatever
3599         set-webkit-configuration was last set to.
3600
3601 2007-09-25  Mark Rowe  <mrowe@apple.com>
3602
3603         Rubber-stamped by Eric.
3604
3605         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3606         This makes it possible to automate nightly builds for the feature-branch.
3607
3608 2007-09-25  Adam Roben  <aroben@apple.com>
3609
3610         A couple of fixes/enhancements to update-webkit-*-libs
3611
3612         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
3613         to tell update-webkit-support-libraries where it should find the
3614         WebKitSupportLibrary.zip file you downloaded.
3615
3616         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
3617         Windows-style path.
3618
3619         Reviewed by Sam.
3620
3621         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
3622         to $auxiliaryLibsURL and removed an irrelevant comment.
3623         * Scripts/update-webkit-support-libs:
3624
3625 2007-09-25  Adam Treat  <treat@kde.org>
3626
3627         Reviewed by Simon and Lars.
3628
3629         Refactors and cleans up Qt DRT member variable names, member variable
3630         initialization, style fixes and general code cleanup.
3631
3632         Adds queueReload slot to LayoutTestController that some tests require.
3633
3634         Subclasses QWebFrame to make sure that all frames have an associated
3635         LayoutTestController JS window object.
3636
3637         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
3638         aren't dumped twice.
3639
3640         EOF fixes.
3641
3642         Together, this patch fixes some 20+ layout tests in QtWebKit.
3643
3644         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3645         (WebCore::WebFrame::WebFrame):
3646         (WebCore::WebPage::WebPage):
3647         (WebCore::WebPage::createFrame):
3648         (WebCore::DumpRenderTree::DumpRenderTree):
3649         (WebCore::DumpRenderTree::open):
3650         (WebCore::DumpRenderTree::readStdin):
3651         (WebCore::DumpRenderTree::initJSObjects):
3652         (WebCore::DumpRenderTree::dump):
3653         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3654         (WebCore::DumpRenderTree::layoutTestController):
3655         (WebCore::DumpRenderTree::eventSender):
3656         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3657         (LayoutTestController::LayoutTestController):
3658         (LayoutTestController::reset):
3659         (LayoutTestController::maybeDump):
3660         (LayoutTestController::waitUntilDone):
3661         (LayoutTestController::notifyDone):
3662         (LayoutTestController::queueReload):
3663         (LayoutTestController::provisionalLoad):
3664         (EventSender::EventSender):
3665         (EventSender::mouseDown):
3666         (EventSender::mouseUp):
3667         (EventSender::mouseMoveTo):
3668         (EventSender::frameUnderMouse):
3669         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3670         (LayoutTestController::isLoading):
3671         (LayoutTestController::setLoading):
3672         (LayoutTestController::dumpAsText):
3673         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
3674         (main):
3675
3676 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3677
3678
3679         - Reverted an accidentally checked in file.
3680
3681         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3682
3683 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3684         Reviewed by Sam.
3685
3686         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
3687
3688         * DumpRenderTree/win/DumpRenderTree.vcproj:
3689         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3690
3691 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3692
3693         Rubber stamped by Adam.
3694
3695         * GdkLauncher: Removed.
3696         * GdkLauncher/Bakefiles.bkgen: Removed.
3697         * GdkLauncher/ENV: Removed.
3698         * GdkLauncher/GdkLauncher.pro: Removed.
3699         * GdkLauncher/gdklauncher.bkl: Removed.
3700         * GdkLauncher/main.cpp: Removed.
3701         * GdkLauncher/mk: Removed.
3702         * GdkLauncher/simple.svg: Removed.
3703         * GdkLauncher/text.html: Removed.
3704         * GtkLauncher: Added.
3705         * GtkLauncher/GdkLauncher.pro: Removed.
3706         * GtkLauncher/GtkLauncher.pro: Added.
3707         * GtkLauncher/main.cpp:
3708         (updateWindowTitle):
3709         (main):
3710         * Scripts/build-webkit:
3711         * Scripts/regenerate-makefiles:
3712         * Scripts/run-javascriptcore-tests:
3713         * Scripts/run-launcher:
3714         * Scripts/run-webkit-tests:
3715         * Scripts/webkitdirs.pm:
3716
3717 2007-09-21  Timothy Hatcher  <timothy@apple.com>
3718
3719         Reviewed by Darin.
3720
3721         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
3722
3723         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
3724         This is tested by plugins/root-object-premature-delete-crash.html.
3725
3726         * DumpRenderTree/mac/ObjCController.m:
3727         (-[ObjCController accessStoredWebScriptObject]):
3728
3729 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
3730
3731         Reviewed by Oliver.
3732
3733         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
3734
3735         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3736         (FrameLoadDelegate::FrameLoadDelegate):
3737
3738 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
3739
3740         Reviewed by Adam.
3741
3742         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
3743         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
3744
3745         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
3746         Now isQt() and isGdk() use global variables that are only set once.
3747
3748         An array of all the parameters is now given to build-dumprender which includes
3749         the platform on linux.
3750
3751         * Scripts/build-dumprendertree:
3752         * Scripts/run-webkit-tests:
3753         * Scripts/webkitdirs.pm:
3754
3755 2007-09-19  Adam Roben  <aroben@apple.com>
3756
3757         Rubberstamped by Hyatt.
3758
3759         * Spinneret: Removed.
3760
3761 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
3762
3763         Reviewed by David Kilzer.
3764
3765         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
3766
3767 2007-09-18  Sam Weinig  <sam@webkit.org>
3768
3769         Add JSRetainPtr.h #include to fix some builds.
3770
3771         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3772
3773 2007-09-18  Mike Hommey  <glandium@debian.org>
3774
3775         Reviewed by Adam.
3776
3777         * Scripts/prepare-ChangeLog:
3778         - Properly parse GECOS field.
3779         - Use git configuration for user name and email when appropriate.
3780
3781 2007-09-17  Sam Weinig  <sam@webkit.org>
3782
3783         Build fix.
3784
3785         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3786
3787 2007-09-17  Sam Weinig  <sam@webkit.org>
3788
3789         Reviewed by Adam Roben.
3790
3791         Share more code between mac and windows DRT.
3792             - GCController is now shared.
3793             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
3794
3795         * DumpRenderTree/GCController.cpp:
3796         * DumpRenderTree/win/DumpRenderTree.cpp:
3797         * DumpRenderTree/win/DumpRenderTree.vcproj:
3798         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
3799         (FrameLoadDelegate::FrameLoadDelegate):
3800         (FrameLoadDelegate::~FrameLoadDelegate):
3801         (FrameLoadDelegate::windowScriptObjectAvailable):
3802         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
3803         * DumpRenderTree/win/GCController.cpp: Removed.
3804         * DumpRenderTree/win/GCController.h: Removed.
3805         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
3806         (GCController::collect):
3807         (GCController::collectOnAlternateThread):
3808         (GCController::getJSObjectCount):
3809         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
3810         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
3811
3812 2007-09-17  Sam Weinig  <sam@webkit.org>
3813
3814         Reviewed by Adam Roben.
3815
3816         Begin sharing code between mac and windows DRT.
3817             - both now share LayoutTestController.h/cpp and implement platform dependant 
3818               operations in LayoutTestControllerMac/Win.
3819             - DumpRenderTree.h is now shared.
3820             - WorkQueue and WorkQueueItem are also shared.
3821
3822         * DumpRenderTree/DumpRenderTree.h:
3823         * DumpRenderTree/LayoutTestController.cpp:
3824         * DumpRenderTree/win/DumpRenderTree.cpp:
3825         (displayWebView):
3826         (dumpFrameScrollPosition):
3827         (dumpFramesAsText):
3828         (dump):
3829         (runTest):
3830         * DumpRenderTree/win/DumpRenderTree.h: Removed.
3831         * DumpRenderTree/win/DumpRenderTree.vcproj:
3832         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
3833         * DumpRenderTree/win/EditingDelegate.cpp:
3834         (EditingDelegate::shouldBeginEditingInDOMRange):
3835         (EditingDelegate::shouldEndEditingInDOMRange):
3836         (EditingDelegate::shouldInsertNode):
3837         (EditingDelegate::shouldInsertText):
3838         (EditingDelegate::shouldDeleteDOMRange):
3839         (EditingDelegate::shouldChangeSelectedDOMRange):
3840         (EditingDelegate::shouldApplyStyle):
3841         (EditingDelegate::shouldChangeTypingStyle):
3842         (EditingDelegate::doPlatformCommand):
3843         (EditingDelegate::webViewDidBeginEditing):
3844         (EditingDelegate::webViewDidChange):
3845         (EditingDelegate::webViewDidEndEditing):
3846         (EditingDelegate::webViewDidChangeTypingStyle):
3847         (EditingDelegate::webViewDidChangeSelection):
3848         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
3849         * DumpRenderTree/win/LayoutTestController.h: Removed.
3850         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
3851         (LayoutTestController::addDisallowedURL):
3852         (LayoutTestController::clearBackForwardList):
3853         (LayoutTestController::copyDecodedHostName):
3854         (LayoutTestController::copyEncodedHostName):
3855         (LayoutTestController::display):
3856         (LayoutTestController::keepWebHistory):
3857         (LayoutTestController::notifyDone):
3858         (LayoutTestController::queueBackNavigation):
3859         (LayoutTestController::queueForwardNavigation):
3860         (jsStringRefToWString):
3861         (LayoutTestController::queueLoad):
3862         (LayoutTestController::queueReload):
3863         (LayoutTestController::queueScript):
3864         (LayoutTestController::setAcceptsEditing):
3865         (LayoutTestController::setCustomPolicyDelegate):
3866         (LayoutTestController::setMainFrameIsFirstResponder):
3867         (LayoutTestController::setTabKeyCyclesThroughElements):
3868         (LayoutTestController::setUseDashboardCompatibilityMode):
3869         (LayoutTestController::setUserStyleSheetEnabled):
3870         (LayoutTestController::setUserStyleSheetLocation):
3871         (LayoutTestController::setWindowIsKey):
3872         (waitUntilDoneWatchdogFired):
3873         (LayoutTestController::setWaitToDump):
3874         (LayoutTestController::windowCount):
3875         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
3876         (FrameLoadDelegate::didReceiveTitle):
3877         (FrameLoadDelegate::processWork):
3878         (FrameLoadDelegate::locationChangeDone):
3879         (FrameLoadDelegate::windowScriptObjectAvailable):
3880         * DumpRenderTree/win/WorkQueue.cpp: Removed.
3881         * DumpRenderTree/win/WorkQueue.h: Removed.
3882         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
3883         * DumpRenderTree/win/WorkQueueItem.h: Removed.
3884         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
3885         (jsStringRefToWString):
3886         (LoadItem::invoke):
3887         (ScriptItem::invoke):
3888
3889 2007-09-17  Sam Weinig  <sam@webkit.org>
3890
3891         Reviewed by Adam Roben.
3892
3893         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
3894
3895         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
3896         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
3897         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
3898         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
3899         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
3900         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
3901         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
3902         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
3903         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
3904         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
3905         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
3906         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
3907         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
3908         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
3909         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
3910         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
3911         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
3912         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
3913         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
3914         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
3915         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
3916         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
3917         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
3918         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
3919         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
3920         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
3921         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
3922         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
3923         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
3924         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
3925         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
3926         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
3927         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
3928         * DumpRenderTree/win: Added.
3929         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
3930         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
3931         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
3932         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
3933         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
3934         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
3935         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
3936         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
3937         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
3938         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
3939         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
3940         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
3941         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
3942         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3943         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
3944         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
3945         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
3946         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
3947         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3948         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3949         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
3950         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3951         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
3952         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
3953         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
3954         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
3955
3956 2007-09-15  Mark Rowe  <mrowe@apple.com>
3957
3958         Build fix for DumpRenderTree.
3959
3960         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
3961
3962 2007-09-14  Sam Weinig  <sam@webkit.org>
3963
3964         Rubber stamped by Adam Roben.
3965
3966         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
3967           - The UIDelegate was put into a new file while the FrameLoadDelegate was
3968             kept in the WaitUntilDoneDelegate file for the time being.
3969
3970         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3971         (main):
3972         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
3973         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
3974         (UIDelegate::QueryInterface):
3975         (UIDelegate::AddRef):
3976         (UIDelegate::Release):
3977         (UIDelegate::hasCustomMenuImplementation):
3978         (UIDelegate::setFrame):
3979         (UIDelegate::webViewFrame):
3980         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3981         (UIDelegate::webViewAddMessageToConsole):
3982         (UIDelegate::doDragDrop):
3983         (UIDelegate::webViewGetDlgCode):
3984         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
3985         (UIDelegate::UIDelegate):
3986         (UIDelegate::createWebViewWithRequest):
3987         (UIDelegate::webViewShow):
3988         (UIDelegate::webViewClose):
3989         (UIDelegate::webViewFocus):
3990         (UIDelegate::webViewUnfocus):
3991         (UIDelegate::webViewFirstResponder):
3992         (UIDelegate::makeFirstResponder):
3993         (UIDelegate::setStatusText):
3994         (UIDelegate::webViewStatusText):
3995         (UIDelegate::webViewAreToolbarsVisible):
3996         (UIDelegate::setToolbarsVisible):
3997         (UIDelegate::webViewIsStatusBarVisible):
3998         (UIDelegate::setStatusBarVisible):
3999         (UIDelegate::webViewIsResizable):
4000         (UIDelegate::setResizable):
4001         (UIDelegate::setContentRect):
4002         (UIDelegate::webViewContentRect):
4003         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
4004         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
4005         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
4006         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
4007         (UIDelegate::mouseDidMoveOverElement):
4008         (UIDelegate::contextMenuItemsForElement):
4009         (UIDelegate::validateUserInterfaceItem):
4010         (UIDelegate::shouldPerformAction):
4011         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
4012         (UIDelegate::willPerformDragDestinationAction):
4013         (UIDelegate::dragSourceActionMaskForPoint):
4014         (UIDelegate::willPerformDragSourceAction):
4015         (UIDelegate::contextMenuItemSelected):
4016         (UIDelegate::trackCustomPopupMenu):
4017         (UIDelegate::measureCustomMenuItem):
4018         (UIDelegate::drawCustomMenuItem):
4019         (UIDelegate::addCustomMenuDrawingData):
4020         (UIDelegate::cleanUpCustomMenuDrawingData):
4021         (UIDelegate::canTakeFocus):
4022         (UIDelegate::takeFocus):
4023         (UIDelegate::registerUndoWithTarget):
4024         (UIDelegate::removeAllActionsWithTarget):
4025         (UIDelegate::setActionTitle):
4026         (UIDelegate::undo):
4027         (UIDelegate::redo):
4028         (UIDelegate::canUndo):
4029         (UIDelegate::canRedo):
4030         (UIDelegate::webViewResizerRect):
4031         (UIDelegate::webViewDrawResizer):
4032         (UIDelegate::webViewScrolled):
4033         (UIDelegate::webViewShouldInterruptJavaScript):
4034         (UIDelegate::webViewReceivedFocus):
4035         (UIDelegate::webViewLostFocus):
4036         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
4037         (FrameLoadDelegate::QueryInterface):
4038         (FrameLoadDelegate::AddRef):
4039         (FrameLoadDelegate::Release):
4040         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
4041         (FrameLoadDelegate::didCommitLoadForFrame):
4042         (FrameLoadDelegate::didReceiveTitle):
4043         (FrameLoadDelegate::processWork):
4044         (processWorkTimer):
4045         (FrameLoadDelegate::locationChangeDone):
4046         (FrameLoadDelegate::didFinishLoadForFrame):
4047         (FrameLoadDelegate::didFailLoadWithError):
4048         (FrameLoadDelegate::windowScriptObjectAvailable):
4049         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
4050         (FrameLoadDelegate::FrameLoadDelegate):
4051
4052 2007-09-14  Sam Weinig  <sam@webkit.org>
4053
4054         Reviewed by Kevin McCullough.
4055
4056         Move mac specific globals in to mac/DumpRenderTreeMac.h
4057
4058         * DumpRenderTree/DumpRenderTree.h:
4059         * DumpRenderTree/DumpRenderTree.mm: Removed.
4060         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4061         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
4062         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
4063
4064 2007-09-14  Brady Eidson  <beidson@apple.com>
4065
4066         Rubberstamped by Weinig
4067
4068         You know, Sam, some of us use case-sensitve filesystems...
4069
4070         * DumpRenderTree/DumpRenderTree.h:
4071         * DumpRenderTree/mac/UIDelegate.mm:
4072
4073 2007-09-14  Sam Weinig  <sam@webkit.org>
4074
4075         Rubber stamped by Adam Roben.
4076
4077         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
4078         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
4079
4080         * DumpRenderTree/AppleScriptController.h: Removed.
4081         * DumpRenderTree/AppleScriptController.m: Removed.
4082         * DumpRenderTree/DumpRenderTree.h:
4083         * DumpRenderTree/DumpRenderTree.mm:
4084         (startJavaScriptThreads):
4085         (stopJavaScriptThreads):
4086         (activateAhemFont):
4087         (setDefaultColorProfileToRGB):
4088         (makeLargeMallocFailSilently):
4089         (dumpFrameScrollPosition):
4090         (dumpFramesAsText):
4091         (dump):
4092         (runTest):
4093         (-[DumpRenderTreeWindow isKeyWindow]):
4094         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4095         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
4096         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
4097         * DumpRenderTree/EditingDelegate.h: Removed.
4098         * DumpRenderTree/EditingDelegate.m: Removed.
4099         * DumpRenderTree/EventSendingController.h: Removed.
4100         * DumpRenderTree/EventSendingController.m: Removed.
4101         * DumpRenderTree/FrameLoadDelegate.h: Removed.
4102         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
4103         * DumpRenderTree/GCController.mm: Removed.
4104         * DumpRenderTree/ImageDiff.m: Removed.
4105         * DumpRenderTree/LayoutTestController.cpp:
4106         (LayoutTestController::LayoutTestController):
4107         (dumpAsTextCallback):
4108         (dumpBackForwardListCallback):
4109         (dumpChildFramesAsTextCallback):
4110         (dumpChildFrameScrollPositionsCallback):
4111         (dumpDOMAsWebArchiveCallback):
4112         (dumpEditingCallbacksCallback):
4113         (dumpFrameLoadCallbacksCallback):
4114         (dumpResourceLoadCallbacksCallback):
4115         (dumpSelectionRectCallback):
4116         (dumpSourceAsWebArchiveCallback):
4117         (dumpTitleChangesCallback):
4118         (repaintSweepHorizontallyCallback):
4119         (setCallCloseOnWebViewsCallback):
4120         (setCanOpenWindowsCallback):
4121         (setCloseRemainingWindowsWhenCompleteCallback):
4122         (testRepaintCallback):
4123         (addFileToPasteboardOnDragCallback):
4124         (waitUntilDoneCallback):
4125         * DumpRenderTree/LayoutTestController.h:
4126         (LayoutTestController::dumpAsText):
4127         (LayoutTestController::setDumpAsText):
4128         (LayoutTestController::dumpBackForwardList):
4129         (LayoutTestController::setDumpBackForwardList):
4130         (LayoutTestController::dumpChildFrameScrollPositions):
4131         (LayoutTestController::setDumpChildFrameScrollPositions):
4132         (LayoutTestController::dumpChildFramesAsText):
4133         (LayoutTestController::setDumpChildFramesAsText):
4134         (LayoutTestController::dumpDOMAsWebArchive):
4135         (LayoutTestController::setDumpDOMAsWebArchive):
4136         (LayoutTestController::dumpSelectionRect):
4137         (LayoutTestController::setDumpSelectionRect):
4138         (LayoutTestController::dumpSourceAsWebArchive):
4139         (LayoutTestController::setDumpSourceAsWebArchive):
4140         (LayoutTestController::dumpTitleChanges):
4141         (LayoutTestController::setDumpTitleChanges):
4142         (LayoutTestController::dumpEditingCallbacks):
4143         (LayoutTestController::setDumpEditingCallbacks):
4144         (LayoutTestController::dumpResourceLoadCallbacks):
4145         (LayoutTestController::setDumpResourceLoadCallbacks):
4146         (LayoutTestController::dumpFrameLoadCallbacks):
4147         (LayoutTestController::setDumpFrameLoadCallbacks):
4148         (LayoutTestController::addFileToPasteboardOnDrag):
4149         (LayoutTestController::setAddFileToPasteboardOnDrag):
4150         (LayoutTestController::callCloseOnWebViews):
4151         (LayoutTestController::setCallCloseOnWebViews):
4152         (LayoutTestController::canOpenWindows):
4153         (LayoutTestController::setCanOpenWindows):
4154         (LayoutTestController::closeRemainingWindowsWhenComplete):
4155         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
4156         (LayoutTestController::testRepaint):
4157         (LayoutTestController::setTestRepaint):
4158         (LayoutTestController::testRepaintSweepHorizontally):
4159         (LayoutTestController::setTestRepaintSweepHorizontally):
4160         (LayoutTestController::waitToDump):
4161         (LayoutTestController::windowIsKey):
4162         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
4163         * DumpRenderTree/NavigationController.h: Removed.
4164         * DumpRenderTree/NavigationController.m: Removed.
4165         * DumpRenderTree/ObjCController.h: Removed.
4166         * DumpRenderTree/ObjCController.m: Removed.
4167         * DumpRenderTree/ObjCPlugin.h: Removed.
4168         * DumpRenderTree/ObjCPlugin.m: Removed.
4169         * DumpRenderTree/ObjCPluginFunction.h: Removed.
4170         * DumpRenderTree/ObjCPluginFunction.m: Removed.
4171         * DumpRenderTree/PolicyDelegate.h: Removed.
4172         * DumpRenderTree/PolicyDelegate.m: Removed.
4173         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
4174         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
4175         * DumpRenderTree/TextInputController.h: Removed.
4176         * DumpRenderTree/TextInputController.m: Removed.
4177         * DumpRenderTree/UIDelegate.h: Removed.
4178         * DumpRenderTree/UIDelegate.mm: Removed.
4179         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
4180         * DumpRenderTree/mac: Added.
4181         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
4182         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
4183         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
4184         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
4185         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
4186         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
4187         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
4188         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
4189         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
4190         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
4191         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
4192         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
4193         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
4194         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
4195         (-[EditingDelegate webViewDidBeginEditing:]):
4196         (-[EditingDelegate webViewDidChange:]):
4197         (-[EditingDelegate webViewDidEndEditing:]):
4198         (-[EditingDelegate webViewDidChangeTypingStyle:]):
4199         (-[EditingDelegate webViewDidChangeSelection:]):
4200         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
4201         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
4202         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
4203         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
4204         (-[FrameLoadDelegate init]):
4205         (-[FrameLoadDelegate dealloc]):
4206         (-[FrameLoadDelegate processWork:]):
4207         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
4208         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
4209         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
4210         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
4211         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
4212         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
4213         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
4214         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
4215         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
4216         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
4217         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
4218         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
4219         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
4220         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
4221         (-[FrameLoadDelegate webView:willCloseFrame:]):
4222         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
4223         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
4224     &