WebKitTools/ChangeLog

   1 2010-10-22  Brian Weinstein  <bweinstein@apple.com>
   2
   3         Windows build fix. Update the createNewPage callback to account for the new
   4         arguments.
   5
   6         * MiniBrowser/win/BrowserView.cpp:
   7         (createNewPage):
   8
   9 2010-10-22  Sam Weinig  <sam@webkit.org>
  10
  11         Reviewed by Anders Carlsson.
  12
  13         WebKit2 needs to pass the current event modifier flags when requesting a new window
  14         https://bugs.webkit.org/show_bug.cgi?id=48140
  15
  16         * MiniBrowser/mac/BrowserWindowController.m:
  17         (createNewPage):
  18         * WebKitTestRunner/TestController.cpp:
  19         (WTR::createOtherPage):
  20         Update for new signature for the WKPageCreateNewPageCallback.
  21
  22 2010-10-22  Eric Seidel  <eric@webkit.org>
  23
  24         Unreviewed.  Just adding a test case.
  25
  26         The style-queue was not recognizing new patches.  It turns
  27         out I had fixed this in an earlier change, but just not
  28         deployed to queues.webkit.org.  As part of investigating why it
  29         was broken, I wrote a test for my previous change which I'm now landing.
  30
  31         * QueueStatusServer/model/queues_unittest.py:
  32
  33 2010-10-22  Eric Seidel  <eric@webkit.org>
  34
  35         Reviewed by Adam Barth.
  36
  37         EWS does not need to process obsolete patches
  38         https://bugs.webkit.org/show_bug.cgi?id=48093
  39
  40         This was an easy change, but to test it I had to pipe
  41         real Attachment objects into the queue testing system.
  42         Doing so revealed a whole bunch of bugs in our unit tests,
  43         which I fixed as part of this patch.
  44
  45         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  46          - This is the actual code change.  This will not reduce the
  47            backlog in the EWS queues much, but it will make rejections
  48            much quicker for obsolete patches or closed bugs.
  49         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  50          - Test my new code.
  51          - Used a real attachment object and got rid of MockPatch
  52          - Shared code between the mac-ews and cr-mac-ews tests.
  53         * Scripts/webkitpy/tool/commands/queues_unittest.py:
  54          - Can't use MockPatch anymore.
  55          - Removing MockPatch found more bugs here!
  56         * Scripts/webkitpy/tool/commands/queuestest.py:
  57         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  58         * Scripts/webkitpy/tool/mocktool.py:
  59          - MockBugzilla should not be a "Mock" object.  Right now tool.bugs()
  60            is allowed, but wrong.  Making it not a Mock will make tool.bugs() correctly fail.
  61
  62 2010-10-22  Sheriff Bot  <webkit.review.bot@gmail.com>
  63
  64         Unreviewed, rolling out r70301.
  65         http://trac.webkit.org/changeset/70301
  66         https://bugs.webkit.org/show_bug.cgi?id=48126
  67
  68         "Lang attribute layout tests failing" (Requested by satish on
  69         #webkit).
  70
  71         * DumpRenderTree/LayoutTestController.cpp:
  72         (setMockSpeechInputResultCallback):
  73         * DumpRenderTree/LayoutTestController.h:
  74         * DumpRenderTree/chromium/LayoutTestController.cpp:
  75         (LayoutTestController::setMockSpeechInputResult):
  76         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  77         (LayoutTestController::setMockSpeechInputResult):
  78         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  79         (LayoutTestController::setMockSpeechInputResult):
  80         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  81         (LayoutTestController::setMockSpeechInputResult):
  82         * DumpRenderTree/qt/LayoutTestControllerQt.h:
  83         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  84         (LayoutTestController::setMockSpeechInputResult):
  85         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  86         (LayoutTestController::setMockSpeechInputResult):
  87
  88 2010-10-22  Leandro Gracia Gil  <leandrogracia@google.com>
  89
  90         Reviewed by Jeremy Orlow.
  91
  92         Added a second parameter to setMockSpeechInputResult for
  93         the language used in speech input.
  94         https://bugs.webkit.org/show_bug.cgi?id=47089
  95
  96         * DumpRenderTree/LayoutTestController.cpp:
  97         (setMockSpeechInputResultCallback):
  98         * DumpRenderTree/LayoutTestController.h:
  99         * DumpRenderTree/chromium/LayoutTestController.cpp:
 100         (LayoutTestController::setMockSpeechInputResult):
 101         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 102         (LayoutTestController::setMockSpeechInputResult):
 103         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 104         (LayoutTestController::setMockSpeechInputResult):
 105         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 106         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 107         (LayoutTestController::setMockSpeechInputResult):
 108         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 109         (LayoutTestController::setMockSpeechInputResult):
 110         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 111         (LayoutTestController::setMockSpeechInputResult):
 112
 113 2010-10-21  MORITA Hajime  <morrita@google.com>
 114
 115         Reviewed by Kent Tamura.
 116
 117         [Win][DRT] should have LayoutTestController.hasSpellingMarker()
 118         https://bugs.webkit.org/show_bug.cgi?id=47885
 119
 120         - Implemented LayoutTestController.hasSpellingMarker(),
 121         - Added fake spellcheck implementation.
 122
 123         * DumpRenderTree/win/DumpRenderTree.cpp:
 124         (main):
 125         * DumpRenderTree/win/EditingDelegate.cpp:
 126         (indexOfFirstWordCharacter):
 127         (wordLength):
 128         (EditingDelegate::checkSpellingOfString):
 129         * DumpRenderTree/win/EditingDelegate.h:
 130         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 131         (LayoutTestController::hasSpellingMarker):
 132
 133 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
 134
 135         Unreviewed. Re-enable test that was mistakenly disabled by r67974.
 136
 137         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
 138
 139 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
 140
 141         Unreviewed fix for rebaseline-chromium-webkit-tests.
 142
 143         Port.diff_image no longer has a tolerance parameter. Also, use
 144         get_option('tolerance') which is safer if the options object doesn't
 145         define a tolerance attribute (it doesn't for the one used in
 146         rebaseline_chromium_webkit_tests).
 147
 148         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 149         * Scripts/webkitpy/layout_tests/port/webkit.py:
 150         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 151
 152 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
 153
 154         Reviewed by Ojan Vafai.
 155
 156         Add support for --tolerance in NRWT
 157         https://bugs.webkit.org/show_bug.cgi?id=47959
 158
 159         Add support for the --tolerance flag in NRWT. The Port.diff_image
 160         signature shouldn't need a tolerance parameter (it's not set per test),
 161         just have ports that use it (currently only WebKitPort) read it from
 162         the options object.
 163
 164         * Scripts/webkitpy/layout_tests/port/chromium.py:
 165         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 166         * Scripts/webkitpy/layout_tests/port/test.py:
 167         * Scripts/webkitpy/layout_tests/port/webkit.py:
 168         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 169         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 170
 171 2010-10-21  Eric Seidel  <eric@webkit.org>
 172
 173         Reviewed by Adam Barth.
 174
 175         Add --suggest-reviewers option to upload to auto-suggest reviewers for your patch
 176         https://bugs.webkit.org/show_bug.cgi?id=48088
 177
 178         This is a first-pass.  Works, but we'll eventually
 179         turn this on by default, refine the suggestion algorithm
 180         and possibly move it to a different place in the upload step order.
 181
 182         * Scripts/webkitpy/common/checkout/api.py:
 183         * Scripts/webkitpy/tool/commands/download_unittest.py:
 184         * Scripts/webkitpy/tool/commands/upload.py:
 185         * Scripts/webkitpy/tool/commands/upload_unittest.py:
 186         * Scripts/webkitpy/tool/mocktool.py:
 187         * Scripts/webkitpy/tool/steps/__init__.py:
 188         * Scripts/webkitpy/tool/steps/options.py:
 189
 190 2010-10-21  Mario Sanchez Prada  <msanchez@igalia.com>
 191
 192         Reviewed by Chris Fleizach.
 193
 194         [GTK] Segfault while testing accessibility/iframe-bastardization.html
 195         https://bugs.webkit.org/show_bug.cgi?id=30123
 196
 197         Check m_element before actually using it to get the parent.
 198
 199         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 200         (AccessibilityUIElement::parentElement): Add an extra check to
 201         make sure m_element points to a valid value before actually using
 202         it to get the parent. Also, assert ATK_IS_OBJECT(m_element).
 203
 204 2010-10-21  Anders Carlsson  <andersca@apple.com>
 205
 206         Reviewed by Adam Roben.
 207
 208         Crash evaluating JavaScript string that throws an exception
 209         https://bugs.webkit.org/show_bug.cgi?id=48092
 210         <rdar://problem/8487657>
 211
 212         Add a test that evaluates a JavaScript string that throws an exception and check that
 213         the callback is called.
 214
 215         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 216         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Added.
 217         (TestWebKitAPI::didRunJavaScript):
 218         (TestWebKitAPI::WebKit2_EvaluateJavaScript):
 219         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
 220
 221 2010-10-21  Adam Roben  <aroben@apple.com>
 222
 223         Test that the plugin's HWND is invalidated when NPN_InvalidateRect is
 224         called
 225
 226         Test for <http://webkit.org/b/48086> <rdar://problem/8482944>
 227         Silverlight doesn't repaint in WebKit2
 228
 229         Reviewed by Anders Carlsson.
 230
 231         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
 232         (PluginTest::NPN_InvalidateRect): Added. Calls through to the browser.
 233         (executeScript): Added. Asks the browser to evaluate the script.
 234
 235         (PluginTest::waitUntilDone):
 236         (PluginTest::notifyDone):
 237         Added. Calls through to layoutTestController.
 238
 239         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added
 240         * NPN_InvalidateRect and waitUntilDone/notifyDone.
 241
 242         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp: Added.
 243         (TemporaryWindowMover::moveSucceeded):
 244         (TemporaryWindowMover::TemporaryWindowMover):
 245         (TemporaryWindowMover::~TemporaryWindowMover):
 246         This class moves a window on-screen and shows it, then moves it back and hides it.
 247
 248         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
 249         Initialize our members.
 250         (NPNInvalidateRectInvalidatesWindow::~NPNInvalidateRectInvalidatesWindow):
 251         Delete our window mover if it hasn't been deleted already.
 252         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Subclass the
 253         plugin HWND and move the test harness window on screen.
 254         (NPNInvalidateRectInvalidatesWindow::wndProc): Call through to onPaint
 255         when we get a WM_PAINT message.
 256         (NPNInvalidateRectInvalidatesWindow::onPaint): Do the test and tell
 257         LayoutTestController we're done.
 258         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect): Validate
 259         ourselves, invalidate our lower-right quadrant via NPN_InvalidateRect,
 260         then check that our HWND's invalid region is the rect that we
 261         invalidated.
 262
 263         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
 264         * Added NPNInvalidateRectInvalidatesWindow.
 265
 266 2010-10-21  Daniel Bates  <dbates@rim.com>
 267
 268         Add Git-support to do-file-rename
 269         https://bugs.webkit.org/show_bug.cgi?id=48015
 270
 271         Fix tools. Export function scmMoveOrRenameFile so that it can be called from
 272         do-file-rename and do-webcore-rename. I inadvertently left this out of the patch.
 273
 274         * Scripts/VCSUtils.pm:
 275
 276 2010-10-21  Eric Seidel  <eric@webkit.org>
 277
 278         Reviewed by Adam Barth.
 279
 280         mac-ews is not properly releasing patches
 281         https://bugs.webkit.org/show_bug.cgi?id=48076
 282
 283         mac-ews overrides process_work_item, so it was not calling
 284         release_work_item like the default process_work_item would.
 285         To fix this I made all the status-reporting methods just
 286         release the patch.  I expect we'll iterate on this design further.
 287
 288         * Scripts/webkitpy/common/net/statusserver.py:
 289         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
 290         * Scripts/webkitpy/tool/commands/queues.py:
 291         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 292
 293 2010-10-18  Martin Robinson  <mrobinson@igalia.com>
 294
 295         Reviewed by Gustavo Noronha Silva.
 296
 297         [GTK] mathml flaky tests after adding SystemFonts to the theme
 298         https://bugs.webkit.org/show_bug.cgi?id=47727
 299
 300         The Fontconfig setup in the GTK+ now specifically checks for and
 301         loads the STIX fonts for MathML tests.
 302
 303         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 304         (initializeFonts): Add hooks for loading the STIX fonts specifically.
 305
 306 2010-10-20  Adam Roben  <aroben@apple.com>
 307
 308         Test that the UI client gets notified when WKView receives a WM_CLOSE
 309         message
 310
 311         Test for <http://webkit.org/b/48044> <rdar://problem/8488446> Pressing
 312         Ctrl+W when viewing a full-page PDF destroys the WKView but doesn't
 313         close its parent window
 314
 315         Reviewed by Jon Honeycutt.
 316
 317         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Added.
 318         (TestWebKitAPI::close): Record that this function was called.
 319         (TestWebKitAPI::WebKit2_WMCloseCallsUIClientClose): Create a WKView,
 320         send it a WM_CLOSE message, and test that the UI client's close
 321         callback got called. Note that this will hang if the bug is
 322         reintroduced; <http://webkit.org/b/48043> covers making TestWebKitAPI
 323         able to handle hangs.
 324
 325         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test.
 326
 327 2010-10-20  Adam Roben  <aroben@apple.com>
 328
 329         Make prepare-ChangeLog much faster when using git
 330
 331         This change also seems to make it detect renames better in some cases.
 332
 333         Fixes <http://webkit.org/b/48040> prepare-ChangeLog is slow when using
 334         git
 335
 336         Reviewed by David Kilzer.
 337
 338         * Scripts/prepare-ChangeLog:
 339         (statusCommand):
 340         (createPatchCommand):
 341         Use "-M -C" instead of "-C -C -M" to tell git-diff to detect renames
 342         and copies. The two "-C"s were making it read many more files than were
 343         necessary.
 344
 345 2010-10-21  Sam Weinig  <sam@webkit.org>
 346
 347         Reviewed by Adam Roben.
 348
 349         Null frame passed when running alert from UserScript run at document start
 350         <rdar://problem/8573809>
 351         https://bugs.webkit.org/show_bug.cgi?id=48036
 352
 353         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 354         * TestWebKitAPI/InjectedBundleController.cpp:
 355         (TestWebKitAPI::InjectedBundleController::didReceiveMessage):
 356         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
 357         * TestWebKitAPI/InjectedBundleController.h:
 358         * TestWebKitAPI/InjectedBundleTest.h:
 359         (TestWebKitAPI::InjectedBundleTest::initialize):
 360         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 361         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: Added.
 362         (TestWebKitAPI::runJavaScriptAlert):
 363         (TestWebKitAPI::TEST):
 364         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: Added.
 365         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::DocumentStartUserScriptAlertCrashTest):
 366         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
 367         Add test for invoking an alert during a UserScript run at document start.
 368
 369 2010-10-21  Andreas Kling  <kling@webkit.org>
 370
 371         Reviewed by Adam Roben.
 372
 373         TestNetscapePlugIn: Actually call NPP_SetWindow on Unix
 374
 375         We were just returning NPERR_NO_ERROR previously.
 376
 377         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
 378         (webkit_test_plugin_set_window):
 379
 380 2010-10-21  David Kilzer  <ddkilzer@apple.com>
 381
 382         <http://webkit.org/b/48051> Move macros from DumpRenderTreeMac.h to config.h
 383
 384         Reviewed by Adam Roben.
 385
 386         * DumpRenderTree/config.h: Moved macros to here...
 387         * DumpRenderTree/mac/DumpRenderTreeMac.h: ...from here.
 388         Addresses a FIXME comment from r28419.
 389
 390 2010-10-21  David Kilzer  <ddkilzer@apple.com>
 391
 392         <http://webkit.org/b/48047> Fix warnings found by check-Xcode-source-file-types
 393
 394         Reviewed by Adam Roben.
 395
 396         Fixes the following warnings:
 397
 398             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'PixelDumpSupport.cpp'.
 399             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'LayoutTestController.cpp'.
 400             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'WorkQueue.cpp'.
 401             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'cg/PixelDumpSupportCG.cpp'.
 402             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'GCController.cpp'.
 403             5 issues found for WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj.
 404
 405         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 406         Removed explicit file type for *.cpp files above to make them
 407         match other C++ source files.  This exposed the fact that
 408         DumpRenderTreeMac.h was not safe to include in C++ source, which
 409         caused PixelDumpSupport.cpp and PixelDumpSupportCG.cpp to fail
 410         to build.
 411         * DumpRenderTree/PixelDumpSupport.cpp: Adjusted header order.
 412         * DumpRenderTree/mac/DumpRenderTreeMac.h: Made safe to include
 413         in C++ source files.  Included CoreFoundation/CoreFoundation.h
 414         to make sure all CF types were defined.  Removed CFStringRef
 415         typedef.
 416
 417 2010-10-21  Adam Roben  <aroben@apple.com>
 418
 419         Attempt to fix plugins/pass-different-npp-struct.html on GTK.
 420
 421         See <http://webkit.org/b/47690>.
 422
 423         * GNUmakefile.am: Added PassDifferentNPPStruct.cpp.
 424
 425 2010-10-21  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
 426
 427         Reviewed by Csaba Osztrogonác.
 428
 429         [NRWT] Set ImageDiff path on Qt port
 430         https://bugs.webkit.org/show_bug.cgi?id=48052
 431
 432         * Scripts/webkitpy/layout_tests/port/qt.py:
 433
 434 2010-10-21  Adam Barth  <abarth@webkit.org>
 435
 436         Reviewed by Eric Seidel.
 437
 438         Don't CC authors of flaky tests
 439         https://bugs.webkit.org/show_bug.cgi?id=48038
 440
 441         Some authors found this too annoying.  We'll look for another way to
 442         close the flaky test loop.
 443
 444         * Scripts/webkitpy/tool/commands/queues.py:
 445         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 446
 447 2010-10-21  Eric Seidel  <eric@webkit.org>
 448
 449         Reviewed by Adam Barth.
 450
 451         commit-queue should run run-webkit-tests with --no-new-test-results
 452         https://bugs.webkit.org/show_bug.cgi?id=47998
 453
 454         * Scripts/webkitpy/tool/steps/runtests.py:
 455         * Scripts/webkitpy/tool/steps/steps_unittest.py:
 456
 457 2010-10-21  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
 458
 459         Reviewed by Ojan Vafai.
 460
 461         [NRWT] Get child process number from an environment variable
 462         https://bugs.webkit.org/show_bug.cgi?id=47981
 463
 464         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 465
 466 2010-10-20  David Kilzer  <ddkilzer@apple.com>
 467
 468         <http://webkit.org/b/47754> New script to verify explicit source file types in Xcode project files
 469
 470         Reviewed by Darin Adler.
 471
 472         The script parses an Xcode project file and makes sure the file
 473         extension matches the explicit file type set for all source
 474         files.  Note that the majority of source files will have their
 475         type set by Xcode, so the script doesn't check them since there
 476         is no need to second-guess Xcode.
 477
 478         * Scripts/check-Xcode-source-file-types: Added.  Code borrowed
 479         heavily from sort-Xcode-project-file.
 480
 481 2010-10-20  Adam Roben  <aroben@apple.com>
 482
 483         Windows build fix
 484
 485         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added missing #include.
 486
 487 2010-10-20  Adam Roben  <aroben@apple.com>
 488
 489         Qt test fix
 490
 491         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Added
 492         PassDifferentNPPStruct.cpp.
 493
 494 2010-10-20  Sam Weinig  <sam@webkit.org>
 495
 496         Reviewed by Adam Roben.
 497
 498         Add ability to test injected bundle API using TestWebKitAPI
 499         https://bugs.webkit.org/show_bug.cgi?id=48027
 500
 501         * TestWebKitAPI/InjectedBundleController.cpp: Added.
 502         * TestWebKitAPI/InjectedBundleController.h: Added.
 503         Shared main object for bundle functionality.
 504
 505         * TestWebKitAPI/InjectedBundleMain.cpp: Added.
 506         Bundle entry point.
 507
 508         * TestWebKitAPI/InjectedBundleTest.h: Added.
 509         Base class for which the bundle portion of a test derives from.
 510
 511         * TestWebKitAPI/PlatformUtilities.h:
 512         * TestWebKitAPI/PlatformUtilities.cpp: Added.
 513         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
 514         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
 515         (TestWebKitAPI::Util::createInjectedBundlePath):
 516         (TestWebKitAPI::Util::createURLForResource):
 517         (TestWebKitAPI::Util::URLForNonExistentResource):
 518         Add helper to create a context with the shared injected bundle,
 519         and send the initial message to set up the test.
 520
 521         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Added.
 522         * TestWebKitAPI/InjectedBundle-Info.plist: Added.
 523         Add mac configuration files.
 524
 525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 526         Add the new files.
 527
 528         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: Added.
 529         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: Added.
 530         Add a simple initial bundle test.
 531
 532 2010-10-20  Eric Seidel  <eric@webkit.org>
 533
 534         Unreviewed.  Fixing /release-patch url used by the EWS bots.
 535
 536         EWS should test patches with r+
 537         https://bugs.webkit.org/show_bug.cgi?id=35460
 538
 539         * Scripts/webkitpy/common/net/statusserver.py:
 540          - I changed the URL during development, and 404s are
 541          intentionally silenced during release_patch.
 542
 543 2010-10-14  Adam Roben  <aroben@apple.com>
 544
 545         Test that passing a different NPP struct back to the browser doesn't
 546         cause an assertion failure
 547
 548         Test for <http://webkit.org/b/47690> <rdar://problem/8553020>
 549         Assertion failure in NetscapePlugin::fromNPP when using Shockwave in
 550         WebKit2
 551
 552         Reviewed by John Sullivan.
 553
 554         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp: Copied from WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp.
 555         (PassDifferentNPPStruct::PassDifferentNPPStruct): Initialize our
 556         members.
 557         (PassDifferentNPPStruct::NPP_SetWindow): Pass a different NPP to the
 558         browser than the one it gave us in NPP_New and see if it works.
 559
 560         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 561         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
 562         Added PassDifferentNPPStruct.
 563
 564 2010-10-19  Adam Roben  <aroben@apple.com>
 565
 566         Gently nudge old-run-webkit-tests toward working with Win32 Perl
 567
 568         This makes old-run-webkit-tests able to build DRT and find all the
 569         tests to run. It even invokes DRT and passes it the list of tests. But
 570         DRT ends up hung blocking on I/O.
 571
 572         Fixes <http://webkit.org/b/47961> Get old-run-webkit-tests mostly
 573         working with Win32 Perl
 574
 575         Reviewed by David Kilzer.
 576
 577         * Scripts/old-run-webkit-tests:
 578           - Use File::Spec instead of manually concatenating paths
 579           - Use dirname instead of manually stripping off the base name
 580           - Use isCygwin/isWindows/isAppleWinWebKit more judiciously
 581           - Explicitly invoke Perl when running Perl scripts
 582           - Quote paths when using them in regular expressions to allow them
 583             to include characters that have special meanings in regular
 584             expressions
 585
 586         * Scripts/run-webkit-tests: Use File::Spec instead of manually
 587         concatenating paths.
 588
 589         * Scripts/webkitdirs.pm:
 590           - Remove the unused $windowsTmpPath variable
 591           - Use isCygwin/isWindows/isAppleWinWebKit more judiciously
 592           - Only pass paths to cygpath when using Cygwin Perl
 593           - Only use pdevenv when using Cygwin Perl, for now
 594
 595 2010-10-20  Daniel Bates  <dbates@rim.com>
 596
 597         Reviewed by Martin Robinson.
 598
 599         Add Git-support to do-file-rename
 600         https://bugs.webkit.org/show_bug.cgi?id=48015
 601
 602         Also, abstracts the SCM move/rename functionality in do-file-rename and
 603         do-webcore-rename into a common function VCSUtils::scmMoveOrRenameFile().
 604
 605         Currently, do-file-rename is hard coded to assume the SCM is Subversion.
 606         Instead, we should abstract the rename logic to be SCM-independent. This
 607         will allow us to add Git support as well move such functionality into
 608         our SCM library VCSUtils, where it can be shared by do-webcore-rename.
 609
 610         * Scripts/VCSUtils.pm:
 611           - Added function scmMoveOrRenameFile.
 612         * Scripts/do-file-rename: Modified to call VCSUtils::scmMoveOrRenameFile().
 613         * Scripts/do-webcore-rename: Ditto.
 614
 615 2010-10-20  Adam Roben  <aroben@apple.com>
 616
 617         Fix old-run-webkit-tests when there's a space in the path to DRT
 618
 619         Reviewed by Jon Honeycutt.
 620
 621         * Scripts/old-run-webkit-tests: Quote the path to DRT before executing
 622         it.
 623
 624 2010-10-20  Kenneth Russell  <kbr@google.com>
 625
 626         Reviewed by Dimitri Glazkov.
 627
 628         Regression in chromium_gpu_unittests after r70175
 629         https://bugs.webkit.org/show_bug.cgi?id=48008
 630
 631         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
 632
 633 2010-10-20  Kenneth Russell  <kbr@google.com>
 634
 635         Reviewed by James Robinson.
 636
 637         chromium_gpu port of new-run-webkit-tests must do Linux -> Win expectations fallback
 638         https://bugs.webkit.org/show_bug.cgi?id=48005
 639
 640         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
 641
 642 2010-10-20  Adam Barth  <abarth@webkit.org>
 643
 644         Reviewed by Eric Seidel.
 645
 646         webkit-patch doesn't get along with git rm
 647         https://bugs.webkit.org/show_bug.cgi?id=47940
 648
 649         Turns out we need to pass "--" to tell git this is a path.
 650
 651         * Scripts/webkitpy/common/checkout/scm.py:
 652
 653 2010-10-20  Robert Hogan  <robert@webkit.org>
 654
 655         Reviewed by Antonio Gomes.
 656
 657         [Qt] Fix layoutTestController.getJsObjectCount
 658
 659         Qt Bridge doesn't know size_t so pass result as unsigned int.
 660
 661         Unskip fast/dom/gc-10.html
 662
 663         https://bugs.webkit.org/show_bug.cgi?id=47931
 664
 665         * DumpRenderTree/qt/GCControllerQt.cpp:
 666         (GCController::getJSObjectCount):
 667         * DumpRenderTree/qt/GCControllerQt.h:
 668
 669 2010-10-20  Sheriff Bot  <webkit.review.bot@gmail.com>
 670
 671         Unreviewed, rolling out r70149.
 672         http://trac.webkit.org/changeset/70149
 673         https://bugs.webkit.org/show_bug.cgi?id=47989
 674
 675         "Build breaks in mac and win" (Requested by satish on
 676         #webkit).
 677
 678         * DumpRenderTree/LayoutTestController.cpp:
 679         (setMockSpeechInputResultCallback):
 680         * DumpRenderTree/LayoutTestController.h:
 681         * DumpRenderTree/chromium/LayoutTestController.cpp:
 682         (LayoutTestController::setMockSpeechInputResult):
 683         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 684         (LayoutTestController::setMockSpeechInputResult):
 685
 686 2010-10-19  Adam Roben  <aroben@apple.com>
 687
 688         Teach update-webkit-support-libs about the new versioning of
 689         WebKitSupportLibrary
 690
 691         Fixes <http://webkit.org/b/47915> update-webkit-support-libs should
 692         check version numbers instead of modification times
 693
 694         Reviewed by Sam Weinig.
 695
 696         * Scripts/update-webkit-support-libs: Fetch the expected version
 697         number from developer.apple.com, then compare with the version number
 698         of the extracted library and of the zipped library to see if anything
 699         needs to be done. Removed code that tracked the modified timestamp of
 700         the library, as it is no longer needed.
 701
 702 2010-10-19  Eric Seidel  <eric@webkit.org>
 703
 704         Reviewed by Adam Barth.
 705
 706         EWS should test patches with r+
 707         https://bugs.webkit.org/show_bug.cgi?id=35460
 708
 709         * QueueStatusServer/handlers/submittoews.py:
 710         * QueueStatusServer/model/queues.py:
 711         * Scripts/webkitpy/tool/bot/patchcollection.py: Removed.
 712         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Removed.
 713         * Scripts/webkitpy/tool/commands/queues.py:
 714
 715 2010-10-19  Eric Seidel  <eric@webkit.org>
 716
 717         Reviewed by Adam Barth.
 718
 719         Teach feeder-queue how to feed the EWS bots
 720         https://bugs.webkit.org/show_bug.cgi?id=47943
 721
 722         queues.webkit.org already knew how to accept EWS submissions
 723         via /submit-to-ews.  This teaches the feeder queue how to post
 724         to that page with any new r? patches it sees.
 725
 726         * QueueStatusServer/model/activeworkitems_unitest.py: Added.
 727          - More unit testing is always a good thing.
 728         * Scripts/webkitpy/common/net/bugzilla.py:
 729         * Scripts/webkitpy/common/net/statusserver.py:
 730         * Scripts/webkitpy/tool/bot/feeders.py:
 731         * Scripts/webkitpy/tool/commands/queues.py:
 732         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 733         * Scripts/webkitpy/tool/mocktool.py:
 734
 735 2010-10-19  Eric Seidel  <eric@webkit.org>
 736
 737         Unreviewed, just fixing test-webkitpy.  I'm really on a roll today.
 738
 739         commit-queue gets stuck when release-patch returns 404
 740         https://bugs.webkit.org/show_bug.cgi?id=47935
 741
 742         Fix test-webkitpy and unittest NetworkTransaction.
 743
 744         * Scripts/webkitpy/common/net/networktransaction.py:
 745         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
 746
 747 2010-10-19  Eric Seidel  <eric@webkit.org>
 748
 749         Unreviewed.
 750
 751         commit-queue gets stuck when release-patch returns 404
 752         https://bugs.webkit.org/show_bug.cgi?id=47935
 753
 754         Turns out ClientForm gets upset if passed an int() instead of a string type.
 755         Yay for untestable code.
 756
 757         * Scripts/webkitpy/common/net/statusserver.py:
 758
 759 2010-10-19  Eric Seidel  <eric@webkit.org>
 760
 761         Unreviewed.  Will get Adam's commentary after his meeting
 762         for now this gets the commit-cluster back running.
 763
 764         commit-queue gets stuck when release-patch returns 404
 765         https://bugs.webkit.org/show_bug.cgi?id=47935
 766
 767         I taught NetworkTransaction the basics of 404 handling.
 768         We'll want to go back and teach it how to handle urllib2 404's too
 769         and then deploy it to the places that want it.
 770
 771         * QueueStatusServer/handlers/releasepatch.py:
 772         * Scripts/webkitpy/common/net/buildbot.py:
 773         * Scripts/webkitpy/common/net/networktransaction.py:
 774         * Scripts/webkitpy/common/net/statusserver.py:
 775
 776 2010-10-19  Eric Seidel  <eric@webkit.org>
 777
 778         Unreviewed.  Fixing typos in my previous commit.
 779
 780         Make patch release explicit and not a magic part of "retry" status
 781         https://bugs.webkit.org/show_bug.cgi?id=47909
 782
 783         All of these typos again due to our inability to unit
 784         test much of this code.  I added one unit test where
 785         possible.  activeworkitems_unittest.py will be in a separate patch.
 786
 787         * QueueStatusServer/handlers/releasepatch.py:
 788         * QueueStatusServer/main.py:
 789         * QueueStatusServer/model/activeworkitems.py:
 790         * QueueStatusServer/model/workitems.py:
 791         * QueueStatusServer/model/workitems_unittest.py:
 792         * QueueStatusServer/templates/releasepatch.html:
 793         * Scripts/webkitpy/common/net/statusserver.py:
 794
 795 2010-10-19  Tony Chang  <tony@chromium.org>
 796
 797         Reviewed by Kent Tamura.
 798
 799         [chromium] Use webkit's TestNetscapePlugIn in DRT mac
 800         https://bugs.webkit.org/show_bug.cgi?id=47850
 801
 802         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Added. Forked
 803             because we're going to name our plugin WebKitTestNetscapePlugIn
 804             temporarily until the chromium forked plugin goes away.
 805
 806 2010-10-19  Eric Seidel  <eric@webkit.org>
 807
 808         Reviewed by Adam Barth.
 809
 810         Make patch release explicit and not a magic part of "retry" status
 811         https://bugs.webkit.org/show_bug.cgi?id=47909
 812
 813         This moves us another step closer to running r+ patches on the EWS bots.
 814         Currently all bots just spam /update-work-items with their list of current
 815         work items.  queues.webkit.org uses that data for display.  As part of making
 816         the EWS run r+ patches, we're moving the official list of patches-to-process
 817         into the server, and feeding them out to bots one at a time.  We need to be
 818         able to remove patches from the queues one at a time instead of just spamming
 819         /update-work-items with a new complete list.  That's what this patch adds.
 820
 821         * QueueStatusServer/handlers/nextpatch.py:
 822         * QueueStatusServer/handlers/queuestatus.py:
 823         * QueueStatusServer/handlers/releasepatch.py: Added.
 824         * QueueStatusServer/handlers/statusbubble_unittest.py:
 825          - Fix a typo causing test failure.  This was not caught by the bots
 826            because they don't have AppEngineLauncher installed and thus don't run
 827            the QueueStatusServer tests.
 828         * QueueStatusServer/handlers/updatestatus.py:
 829         * QueueStatusServer/model/activeworkitems.py:
 830         * QueueStatusServer/templates/releasepatch.html: Added.
 831         * Scripts/webkitpy/common/net/statusserver.py:
 832         * Scripts/webkitpy/tool/commands/queues.py:
 833         * Scripts/webkitpy/tool/mocktool.py:
 834
 835 2010-10-19  Eric Seidel  <eric@webkit.org>
 836
 837         Reviewed by Adam Barth.
 838
 839         cr-mac bubble has caused status bubbles to wrap
 840         https://bugs.webkit.org/show_bug.cgi?id=47928
 841
 842         We now have too many EWSes to fit in the bugs.webkit.org
 843         status-bubble iframe when more than a couple EWS builds are pending.
 844         To fix this I've reduced the space taken up by queue position,
 845         and also moved cr-mac to the end of the list (since it's going to be
 846         triple-digits for a while).
 847
 848         * QueueStatusServer/model/queues.py:
 849         * QueueStatusServer/templates/statusbubble.html:
 850
 851 2010-10-19  Kenneth Russell  <kbr@google.com>
 852
 853         Reviewed by David Levin.
 854
 855         chromium_gpu port of new-run-webkit-tests must search chromium-gpu directory for expectations
 856         https://bugs.webkit.org/show_bug.cgi?id=47874
 857
 858         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
 859         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
 860
 861 2010-10-19  Tony Chang  <tony@chromium.org>
 862
 863         Reviewed by Kent Tamura.
 864
 865         [chromium] DumpRenderTree shouldn't put '.' in include path
 866         https://bugs.webkit.org/show_bug.cgi?id=47877
 867
 868         Fix include paths.
 869
 870         * DumpRenderTree/chromium/AccessibilityController.cpp:
 871         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
 872         * DumpRenderTree/chromium/AccessibilityUIElement.h:
 873         * DumpRenderTree/chromium/CppBoundClass.cpp:
 874         * DumpRenderTree/chromium/CppVariant.cpp:
 875         * DumpRenderTree/chromium/CppVariant.h:
 876         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
 877         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
 878         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
 879         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
 880         * DumpRenderTree/chromium/DRTDevToolsClient.h:
 881         * DumpRenderTree/chromium/EventSender.cpp:
 882         * DumpRenderTree/chromium/EventSender.h:
 883         * DumpRenderTree/chromium/LayoutTestController.cpp:
 884         * DumpRenderTree/chromium/LayoutTestController.h:
 885         * DumpRenderTree/chromium/MockSpellCheck.cpp:
 886         * DumpRenderTree/chromium/NotificationPresenter.cpp:
 887         * DumpRenderTree/chromium/NotificationPresenter.h:
 888         * DumpRenderTree/chromium/PlainTextController.cpp:
 889         * DumpRenderTree/chromium/Task.cpp:
 890         * DumpRenderTree/chromium/TestNavigationController.h:
 891         * DumpRenderTree/chromium/TestShell.cpp:
 892         * DumpRenderTree/chromium/TestWebWorker.h:
 893         * DumpRenderTree/chromium/TextInputController.cpp:
 894         * DumpRenderTree/chromium/WebPreferences.cpp:
 895         * DumpRenderTree/chromium/WebPreferences.h:
 896         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
 897         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
 898         * DumpRenderTree/chromium/WebViewHost.cpp:
 899         * DumpRenderTree/chromium/WebViewHost.h:
 900
 901 2010-10-19  Sam Weinig  <sam@webkit.org>
 902
 903         Reviewed by Dan Bernstein.
 904
 905         Need to include WKErrorRef in the WKPageDidFail... functions
 906         https://bugs.webkit.org/show_bug.cgi?id=47871
 907
 908         Update tools for new parameter in failure callbacks.
 909
 910         * MiniBrowser/mac/BrowserWindowController.m:
 911         (didFailProvisionalLoadWithErrorForFrame):
 912         (didFailLoadWithErrorForFrame):
 913         (-[BrowserWindowController updateProvisionalURLForFrame:]):
 914         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
 915         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
 916         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 917         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
 918         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
 919         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 920
 921 2010-10-19  Luiz Agostini  <luiz.agostini@openbossa.org>
 922
 923         Reviewed by Antti Koivisto.
 924
 925         [Qt] WebKit2 MacOS build fix
 926         https://bugs.webkit.org/show_bug.cgi?id=47897
 927
 928         Qt WebKit2 MacOS build fix.
 929
 930         * WebKitTestRunner/PlatformWebView.h:
 931         * WebKitTestRunner/qt/TestControllerQt.cpp:
 932
 933 2010-10-19  Adam Barth  <abarth@webkit.org>
 934
 935         Reviewed by Eric Seidel.
 936
 937         webkit-patch stats the filesystem too many times
 938         https://bugs.webkit.org/show_bug.cgi?id=47883
 939
 940         This patch attempts to cache the list of changed files more agressively
 941         and to use that list to compute the diff instead of stating the file
 942         system again.
 943
 944         * Scripts/webkitpy/common/checkout/api.py:
 945         * Scripts/webkitpy/common/checkout/scm.py:
 946         * Scripts/webkitpy/tool/mocktool.py:
 947         * Scripts/webkitpy/tool/steps/abstractstep.py:
 948         * Scripts/webkitpy/tool/steps/editchangelog.py:
 949         * Scripts/webkitpy/tool/steps/preparechangelog.py:
 950
 951 2010-10-19  David Kilzer  <ddkilzer@apple.com>
 952
 953         <http://webkit.org/b/47741> Make sort-Xcode-project-file a little more friendly
 954
 955         Reviewed by Darin Adler.
 956
 957         * Scripts/sort-Xcode-project-file:
 958         - Don't print an error message about missing arguments when
 959           -h|--help is used.
 960         - Allow Xcode project files to be specified as Project.xcodeproj
 961           instead of Project.xcodeproj/project.pbxproj.
 962
 963 2010-10-18  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
 964
 965         Reviewed by Andreas Kling.
 966
 967         [Qt] QtTestBrowser: Prevent calling load() directly from loadFinished() in robot mode.
 968         https://bugs.webkit.org/show_bug.cgi?id=47809
 969
 970         Connecting a call to load from the loadFinished signal can cause
 971         re-entrance crashes in WebCore. This patch uses a timer to do so,
 972         also giving some time to subsequent frames to finish loading.
 973
 974         * QtTestBrowser/urlloader.cpp:
 975         (UrlLoader::UrlLoader):
 976         (UrlLoader::loadNext):
 977         (UrlLoader::checkIfFinished):
 978         (UrlLoader::frameLoadStarted):
 979         (UrlLoader::frameLoadFinished):
 980         * QtTestBrowser/urlloader.h:
 981
 982 2010-10-19  Sergio Villar Senín  <svillar@igalia.com>
 983
 984         Reviewed by Xan Lopez.
 985
 986         [GTK] http/history tests are failing
 987         https://bugs.webkit.org/show_bug.cgi?id=36173
 988
 989         Clear the history each time a test is run. Return the actual
 990         history item count when calling
 991         LayoutTestController::webHistoryItemCount
 992
 993         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 994         (resetDefaultsToConsistentValues):
 995         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 996         (LayoutTestController::webHistoryItemCount):
 997
 998 2010-10-18  Eric Seidel  <eric@webkit.org>
 999
1000         Reviewed by Adam Barth.
1001
1002         Add Chromium Mac EWS to the list of queues at queues.webkit.org
1003         https://bugs.webkit.org/show_bug.cgi?id=47878
1004
1005         * QueueStatusServer/model/queues.py:
1006
1007 2010-10-18  Eric Seidel  <eric@webkit.org>
1008
1009         Reviewed by Adam Barth.
1010
1011         queues.webkit.org/next_patch is always 404
1012         https://bugs.webkit.org/show_bug.cgi?id=47881
1013
1014         With the addition of the Queue class, I changed most of the
1015         code to lookup WorkItems using get_or_insert with a key_name
1016         instead of WorkItems.all().filter(queue_name=).
1017         Because the new get_or_insert code uses an explicit key_name
1018         (which is obviously different from the previously autogenerated
1019         ones), there were new WorkItem records created for each queue.
1020         However, some parts of the code still use WorkItems.all().filter,
1021         thus some parts were getting the new record and some parts the old record.
1022
1023         The same basic bug was occurring with ActiveWorkItems, because I
1024         changed the key_name for that class as well.
1025
1026         To fix this I've moved more of the code over to using Queue.*work_items.
1027         I've also enabled the datastore_admin (new in GAE 1.3.8) so that
1028         we can go delete the old WorkItems records.
1029         I also changed remote_api to use the new builtin: syntax (also added in GAE 1.3.8).
1030
1031         * QueueStatusServer/app.yaml:
1032         * QueueStatusServer/handlers/queuestatus.py:
1033         * QueueStatusServer/handlers/recentstatus.py:
1034         * QueueStatusServer/handlers/updatestatus.py:
1035         * QueueStatusServer/handlers/updateworkitems.py:
1036
1037 2010-10-18  Eric Seidel  <eric@webkit.org>
1038
1039         Reviewed by Adam Barth.
1040
1041         Correct a bunch of typos in QueueStatusServer
1042         https://bugs.webkit.org/show_bug.cgi?id=47880
1043
1044         These are all due to our complete lack of unit testing in QueueStatusServer.
1045         I added a couple unit tests to cover a few of these fixes, but most of these
1046         are still only caught by actually running the application.
1047
1048         * QueueStatusServer/handlers/nextpatch.py:
1049         * QueueStatusServer/handlers/statusbubble.py:
1050         * QueueStatusServer/handlers/statusbubble_unittest.py: Added.
1051         * QueueStatusServer/handlers/updateworkitems.py:
1052         * QueueStatusServer/model/attachment.py:
1053         * QueueStatusServer/model/queuepropertymixin.py:
1054         * QueueStatusServer/model/queuepropertymixin_unittest.py:
1055         * QueueStatusServer/model/workitems.py:
1056         * QueueStatusServer/model/workitems_unittest.py: Added.
1057
1058 2010-10-18  Adam Barth  <abarth@webkit.org>
1059
1060         Disable this test because it's failing on the bots and the authors
1061         aren't around to fix it.
1062
1063         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1064
1065 2010-10-18  Adam Barth  <abarth@webkit.org>
1066
1067         Reviewed by Eric Seidel.
1068
1069         CC authors of flaky tests when the commit-queue hits a flaky test
1070         https://bugs.webkit.org/show_bug.cgi?id=47872
1071
1072         * Scripts/webkitpy/common/checkout/api.py:
1073         * Scripts/webkitpy/common/net/layouttestresults.py:
1074         * Scripts/webkitpy/tool/commands/queues.py:
1075         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1076         * Scripts/webkitpy/tool/mocktool.py:
1077
1078 2010-10-18  Eric Seidel  <eric@webkit.org>
1079
1080         Reviewed by Adam Barth.
1081
1082         Make it possible to run a chromium-mac-ews builder
1083         https://bugs.webkit.org/show_bug.cgi?id=47876
1084
1085         Since we can't run Mac OS X in a VM, we need to only run committer patches.
1086         There was a multiple inheritance problem which was holding this patch back,
1087         but I decided to just ignore the problem and go with a functional hack for now.
1088
1089         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1090         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1091
1092 2010-10-18  Kenneth Russell  <kbr@google.com>
1093
1094         Reviewed by Tony Chang.
1095
1096         Regression in run_webkit_tests_unittest from r70017
1097         https://bugs.webkit.org/show_bug.cgi?id=47875
1098
1099         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1100
1101 2010-10-18  Adam Barth  <abarth@webkit.org>
1102
1103         Reviewed by Eric Seidel.
1104
1105         Implement webkit-patch suggest-reviewers
1106         https://bugs.webkit.org/show_bug.cgi?id=47866
1107
1108         * Scripts/webkitpy/common/checkout/api.py:
1109             - The main logic.  We look at the last five changes to each
1110               modified (non-ChangeLog) file and collect up the reviewers of
1111               those changes as well as the authors of those changes who are
1112               reviewers.
1113         * Scripts/webkitpy/common/checkout/api_unittest.py:
1114             - Test the logic with some fun mocks.
1115         * Scripts/webkitpy/common/checkout/scm.py:
1116             - Fix a bug when you have local git commits.
1117         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1118             - Test that the bug is fixed.
1119         * Scripts/webkitpy/tool/commands/queries.py:
1120             - Add the query.
1121
1122 2010-10-18  Kenneth Russell  <kbr@google.com>
1123
1124         Reviewed by Eric Seidel.
1125
1126         new-run-webkit-tests produces corrupt PNG baselines on Windows
1127         https://bugs.webkit.org/show_bug.cgi?id=47867
1128
1129         * Scripts/webkitpy/layout_tests/port/base.py:
1130
1131 2010-10-18  Eric Seidel  <eric@webkit.org>
1132
1133         Reviewed by Adam Barth.
1134
1135         Make it possible to submit patches to the EWS bots
1136         https://bugs.webkit.org/show_bug.cgi?id=47869
1137
1138         * QueueStatusServer/handlers/nextpatch.py:
1139          - Move more logic into Queue, so that it can be shared with SubmitToEWS.
1140         * QueueStatusServer/handlers/queuestatus.py:
1141          - Fix two typos from a previous commit.
1142         * QueueStatusServer/handlers/submittoews.py: Added.
1143         * QueueStatusServer/handlers/updatestatus.py:
1144          - Use the new is_retry_request method to share this (hacky) code with SubmitToEWS
1145         * QueueStatusServer/main.py:
1146          - Add /submit-to-ews
1147         * QueueStatusServer/model/queuepropertymixin.py:
1148          - Fix circular imports caused by adding Queue.work_items()
1149         * QueueStatusServer/model/queues.py:
1150          - Add work_items() and active_work_items()
1151         * QueueStatusServer/model/queuestatus.py:
1152         * QueueStatusServer/model/workitems.py:
1153          - Add transaction-safe add/remove methods.
1154         * QueueStatusServer/templates/submittoews.html: Added.
1155
1156 2010-10-18  Eric Seidel  <eric@webkit.org>
1157
1158         Reviewed by Adam Barth.
1159
1160         Deploy Queue class in more places throughout QueueStatusServer
1161         https://bugs.webkit.org/show_bug.cgi?id=47855
1162
1163         I also caught two typos from the previous change.  Unfortunately
1164         I don't yet know how to unittest request handlers yet.
1165
1166         * QueueStatusServer/handlers/dashboard.py:
1167         * QueueStatusServer/handlers/statusbubble.py:
1168         * QueueStatusServer/handlers/updateworkitems.py:
1169         * QueueStatusServer/model/activeworkitems.py:
1170         * QueueStatusServer/model/attachment.py:
1171         * QueueStatusServer/model/queuepropertymixin.py: Added.
1172         * QueueStatusServer/model/queuepropertymixin_unittest.py: Added.
1173         * QueueStatusServer/model/queuestatus.py:
1174         * QueueStatusServer/model/workitems.py:
1175
1176 2010-10-18  Adam Barth  <abarth@webkit.org>
1177
1178         Reviewed by Eric Seidel.
1179
1180         scm.py should be able tell us what revisions made changes to a given file
1181         https://bugs.webkit.org/show_bug.cgi?id=47863
1182
1183         Look again, your SCM.py can now log files.
1184
1185         * Scripts/webkitpy/common/checkout/scm.py:
1186         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1187
1188 2010-10-18  Dirk Pranke  <dpranke@chromium.org>
1189
1190         Reviewed by Eric Siedel.
1191
1192         new-run-webkit-tests: clean up the options-parsing code in the port
1193         classes.
1194
1195         This change modifies the Port interface to have a get_option() and
1196         set_option_default() method for accessing the options argument
1197         passed to the constructor. If the constructor is not passed an
1198         options argument, we default to a MockOptions() argument from
1199         mocktool, which has the same semantics we want.
1200
1201         Note that there is a disadvantage to port.get_option('foo') over
1202         port._options.foo, which is that you lose some of the checking
1203         for whether 'foo' is set (typos result in the default value, not
1204         an exception being raised. This is desired in this case, since the
1205         Port class is not allowed to assume that options does have any
1206         particular values set, and so this change ensures that all of
1207         the subclasses are following the same, intended, logic.
1208
1209         Arguably this is the wrong semantics to have, and the Port
1210         classes should be able to assume a default set of
1211         attributes/arguments, but that change will need to wait for a
1212         different CL where we can modify new-run-webkit-tests to pull a
1213         list of arguments from the port factory routines.
1214
1215         Also, add unit tests for webkitpy.tool.mocktool.MockOptions .
1216
1217         https://bugs.webkit.org/show_bug.cgi?id=47510
1218
1219         * Scripts/webkitpy/layout_tests/port/base.py:
1220         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1221         * Scripts/webkitpy/layout_tests/port/chromium.py:
1222         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1223         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1224         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1225         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1226         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1227         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1228         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1229         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1230         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1231         * Scripts/webkitpy/layout_tests/port/test.py:
1232         * Scripts/webkitpy/layout_tests/port/webkit.py:
1233         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1234         * Scripts/webkitpy/tool/mocktool_unittest.py: Added.
1235
1236 2010-10-18  Dirk Pranke  <dpranke@chromium.org>
1237
1238         Reviewed by Eric Seidel.
1239
1240         Re-submit a revised version of r69638 - enabling new-run-webkit-tests
1241         under cygwin. The initial version had a bug in base:uri_to_test_name
1242         that was causing tests to fail. This version corrects that bug, but
1243         also makes the code safer by calling cygpath more reliably, and
1244         leaving a long-running cygpath process open.
1245
1246         This patch also corrects a couple of minor bugs in http_lock_unittest,
1247         chromium_unittest, and dedpulicate_tests_unittest that showed up
1248         while testing this.
1249
1250         https://bugs.webkit.org/show_bug.cgi?id=47220
1251
1252         * Scripts/webkitpy/common/system/path.py:
1253         * Scripts/webkitpy/common/system/path_unittest.py:
1254         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1255         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1256         * Scripts/webkitpy/layout_tests/port/base.py:
1257         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1258         * Scripts/webkitpy/layout_tests/port/chromium.py:
1259         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1260         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
1261         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1262
1263 2010-10-18  Eric Seidel  <eric@webkit.org>
1264
1265         Reviewed by Adam Barth.
1266
1267         Add Queue class and add minimal unittesting of QueueStatusServer code
1268         https://bugs.webkit.org/show_bug.cgi?id=47847
1269
1270         * QueueStatusServer/handlers/dashboard.py:
1271         * QueueStatusServer/handlers/queuestatus.py:
1272         * QueueStatusServer/handlers/recentstatus.py:
1273         * QueueStatusServer/handlers/statusbubble.py:
1274         * QueueStatusServer/handlers/updateworkitems.py:
1275         * QueueStatusServer/model/attachment.py:
1276         * QueueStatusServer/model/queues.py:
1277         * QueueStatusServer/model/queues_unittest.py: Added.
1278         * QueueStatusServer/model/svnrevision.py:
1279         * Scripts/test-webkitpy:
1280         * Scripts/webkitpy/test/main.py:
1281
1282 2010-10-18  Anders Carlsson  <andersca@apple.com>
1283
1284         Fix build.
1285
1286         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1287         (handleEventCarbon):
1288
1289 2010-10-18  Stuart Morgan  <stuartmorgan@chromium.org>
1290
1291         Reviewed by Eric Seidel.
1292
1293         Switch to using the new Carbon NPAPI event declarations, and remove
1294         the old ones.
1295
1296         https://bugs.webkit.org/show_bug.cgi?id=40784
1297
1298         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1299         (handleEventCarbon):
1300
1301 2010-10-18  David Levin  <levin@chromium.org>
1302
1303         Reviewed by Adam Barth.
1304
1305         check-webkit-style should treat the GObject binding directory like other GTK directories.
1306         https://bugs.webkit.org/show_bug.cgi?id=47796
1307
1308         * Scripts/webkitpy/style/checker.py: Added the GObject binding directory
1309         with the other gtk directories (and fixed typo).
1310
1311 2010-10-18  David Levin  <levin@chromium.org>
1312
1313         Reviewed by Oliver Hunt.
1314
1315         check-webkit-style needs to ignore underscores in opcode names and vm_throw
1316         https://bugs.webkit.org/show_bug.cgi?id=47789
1317
1318         * Scripts/webkitpy/style/checker.py: Added the exception for the assembler directory.
1319         * Scripts/webkitpy/style/checkers/cpp.py: Added special cased names.
1320         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests for the special cases.
1321
1322 2010-10-18  MORITA Hajime  <morrita@google.com>
1323
1324         Reviewed by Kent Tamura.
1325
1326         TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
1327         https://bugs.webkit.org/show_bug.cgi?id=47659
1328
1329         Moved hasSpellingMarkers() from TextInputController to
1330         LayoutTestController.  Currently the implementation is available
1331         only for Mac and for Chromium.
1332
1333         * DumpRenderTree/LayoutTestController.cpp:
1334         (hasSpellingMarkerCallback):
1335         (LayoutTestController::staticFunctions):
1336         * DumpRenderTree/LayoutTestController.h:
1337         * DumpRenderTree/chromium/LayoutTestController.cpp:
1338         (LayoutTestController::LayoutTestController):
1339         (LayoutTestController::hasSpellingMarker):
1340         * DumpRenderTree/chromium/LayoutTestController.h:
1341         * DumpRenderTree/chromium/TextInputController.cpp:
1342         (TextInputController::TextInputController):
1343         (TextInputController::makeAttributedString):
1344         * DumpRenderTree/chromium/TextInputController.h:
1345         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1346         (LayoutTestController::hasSpellingMarker):
1347         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1348         (LayoutTestController::hasSpellingMarker):
1349         * DumpRenderTree/mac/TextInputController.m:
1350         (+[TextInputController isSelectorExcludedFromWebScript:]):
1351         (+[TextInputController webScriptNameForSelector:]):
1352         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1353         (LayoutTestController::hasSpellingMarker):
1354         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1355         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1356         (LayoutTestController::hasSpellingMarker):
1357         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1358         (LayoutTestController::hasSpellingMarker):
1359
1360 2010-10-18  Adam Barth  <abarth@webkit.org>
1361
1362         Reviewed by David Levin.
1363
1364         commit-queue's flaky test notice is very Pythony
1365         https://bugs.webkit.org/show_bug.cgi?id=47790
1366
1367         This patch make the list of tests delimted by \n instead of just
1368         converting the array to a string.
1369
1370         * Scripts/webkitpy/tool/commands/queues.py:
1371         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1372
1373 2010-10-14  Antonio Gomes  <agomes@rim.com>
1374
1375         Reviewed by Martin Robinson and Xan Lopez.
1376
1377         [Gtk]: DRT does not support frame flattening testing
1378         https://bugs.webkit.org/show_bug.cgi?id=38650
1379
1380         Implement DRT's support for toggling on/off frame flattening
1381         support.
1382
1383         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1384         (resetDefaultsToConsistentValues):
1385         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1386         (LayoutTestController::setFrameFlatteningEnabled):
1387
1388 2010-10-15  Dirk Pranke  <dpranke@chromium.org>
1389
1390         Reviewed by Eric Siedel.
1391
1392         mocktool.MockOptions is inheriting from Mock, which has the side
1393         effect of defaulting any attribute to another MockObject. So,
1394         MockOptions().foo would always evaluate to true. This was
1395         covering over bugs in the unit tests, and is probably the wrong
1396         default behavior for anything attempting to mock out the options
1397         argument returned from optparse.parse_args().
1398
1399         This patch changes the default behavior. The new MockOptions()
1400         class takes an optional list of keyword parameters to set; this
1401         patch doesn't use that feature but the fix for bug 47510 will.
1402
1403         Also, this patch just fills in the default values necessary to
1404         get all of the tests to pass; I didn't stare at each test by
1405         hand to determine the "right" values. We can either fix that in
1406         subsequent patches or let me know if we want to do that now (and
1407         give me some guidance on what those values might want to be).
1408
1409         https://bugs.webkit.org/show_bug.cgi?id=47709
1410
1411         * Scripts/webkitpy/tool/commands/commandtest.py:
1412         * Scripts/webkitpy/tool/commands/download_unittest.py:
1413         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1414         * Scripts/webkitpy/tool/mocktool.py:
1415         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1416         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1417
1418 2010-10-15  Simon Fraser  <simon.fraser@apple.com>
1419
1420         Fix the build; need to add new slot to PageUIClient callbacks.
1421
1422         * MiniBrowser/mac/BrowserWindowController.m:
1423         (-[BrowserWindowController awakeFromNib]):
1424         * WebKitTestRunner/TestController.cpp:
1425         (WTR::createOtherPage):
1426         (WTR::TestController::initialize):
1427
1428 2010-10-15  Simon Fraser  <simon.fraser@apple.com>
1429
1430         Add Matt Delaney to committers.py.
1431
1432         * Scripts/webkitpy/common/config/committers.py:
1433
1434 2010-10-15  Tony Chang  <tony@chromium.org>
1435
1436         Reviewed by Kent Tamura.
1437
1438         [chromium] compile TestNetscapePlugIn on Chromium mac
1439         https://bugs.webkit.org/show_bug.cgi?id=47633
1440
1441         * DumpRenderTree/DumpRenderTree.gypi: files to compile
1442         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
1443         (NP_GetEntryPoints):
1444         (NPP_New):
1445         (NPP_Destroy):
1446         (NPP_HandleEvent):
1447         (NPP_GetValue):
1448         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
1449         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
1450         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
1451
1452 2010-10-15  Leandro Pereira  <leandro@profusion.mobi>
1453
1454         Reviewed by Gustavo Noronha Silva.
1455
1456         build-webkit: Should die when make fails when build a CMake project
1457         https://bugs.webkit.org/show_bug.cgi?id=47726
1458
1459         * Scripts/webkitdirs.pm: If make fails, die immediately.
1460
1461 2010-10-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1462
1463         Unreviewed, rolling out r69809.
1464         http://trac.webkit.org/changeset/69809
1465         https://bugs.webkit.org/show_bug.cgi?id=47725
1466
1467         Broke chromium mac compile (Requested by japhet on #webkit).
1468
1469         * DumpRenderTree/DumpRenderTree.gypi:
1470         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1471         (NP_GetEntryPoints):
1472         (NPP_New):
1473         (NPP_Destroy):
1474         (NPP_HandleEvent):
1475         (NPP_GetValue):
1476         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1477         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1478         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1479
1480 2010-10-15  Adam Barth  <abarth@webkit.org>
1481
1482         Reviewed by Adam Barth.
1483
1484         test-webkitpy fails on Linux
1485         https://bugs.webkit.org/show_bug.cgi?id=47713
1486
1487         The old code failed on Linux because the MacPort tries to read
1488         something out of platform that doesn't make sense on Linux.
1489
1490         * Scripts/webkitpy/tool/mocktool.py:
1491
1492 2010-10-14  Balazs Kelemen  <kbalazs@webkit.org>
1493
1494         Reviewed by Kenneth Rohde Christiansen.
1495
1496         [Qt] WTR is sloooow
1497         https://bugs.webkit.org/show_bug.cgi?id=47695
1498
1499         * WebKitTestRunner/qt/TestControllerQt.cpp:
1500         Change the timer interval of RunUntilConditionLoop from
1501         50 milliseconds to 1 to avoid wasting time after the
1502         test had been finished.
1503
1504 2010-10-14  Eric Seidel  <eric@webkit.org>
1505
1506         Unreviewed, just fixing an exception seen on the commit-queue.
1507
1508         I should have unit tested this function before.
1509
1510         * Scripts/webkitpy/tool/commands/queues.py:
1511         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1512
1513 2010-10-14  Eric Seidel  <eric@webkit.org>
1514
1515         Reviewed by Adam Barth.
1516
1517         commit-queue should not fail patches due to flaky tests
1518         https://bugs.webkit.org/show_bug.cgi?id=47647
1519
1520         This patch makes it so that the *same* flaky test has to fail
1521         twice in a row to have a false negative from a flaky test.
1522
1523         If different flaky tests fail (or if a test fails and then passes
1524         in a second run) then we will warn in the bug that we encountered
1525         a flaky test.
1526
1527         This patch grew to include moving port off of steps onto tool
1528         (which Adam wrote and then I integrated), as well as removing the
1529         use of tool from CommitQueueTask.
1530
1531         * Scripts/webkitpy/common/config/ports.py:
1532          - Added a layout_test_results_path method.  This covers old-run-webkit-tests
1533            but doesn't cover NRWT.  This is probably not the long term solution, but
1534            putting this knowledge on port makes more sense than in LayoutTestResults.
1535         * Scripts/webkitpy/common/net/buildbot.py:
1536          - LayoutTestResults shouldn't know how to fetch from the network, make
1537            the Build code do that instead.
1538         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1539          - Code style fix.
1540         * Scripts/webkitpy/common/net/layouttestresults.py:
1541          - Remove code for reading from the network.
1542         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1543          - Test the new entrypoint.
1544         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1545          - Make the delegate interface explicit.
1546          - Remove the _tool member, since using the delegate for
1547            everything is cleaner.
1548          - Teach the testing logic how to deal with flaky tests.
1549         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1550          - Update to match the CommitQueueTask changes.
1551         * Scripts/webkitpy/tool/commands/queues.py:
1552          - Use the new CommitQueueTaskDelegate interface.
1553         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1554          - Fix the SecondThoughtsCommitQueue test which was broken.
1555          - Add a new test to make sure the flaky test reporting works.
1556         * Scripts/webkitpy/tool/main.py:
1557          - Store the port on the tool object.
1558         * Scripts/webkitpy/tool/mocktool.py:
1559          - Add a port() accessor to MockTool
1560         * Scripts/webkitpy/tool/steps/abstractstep.py:
1561          - Move port() off of Step and onto Tool.
1562         * Scripts/webkitpy/tool/steps/build.py:
1563         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1564         * Scripts/webkitpy/tool/steps/runtests.py:
1565         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1566          - Two tests with the same name!  only the latter was being run.
1567         * Scripts/webkitpy/tool/steps/update.py:
1568
1569 2010-10-14  Dirk Pranke  <dpranke@chromium.org>
1570
1571         Reviewed by Eric Seidel.
1572
1573         new-run-webkit-tests will now handle missing Ruby installs (or
1574         missing PrettyPatch scripts) more cleanly - previously this
1575         would be detected when we actually tried to create the diff, and
1576         the error message was obscure. Now we'll log a warning up front
1577         and otherwise be silent.
1578
1579         This change also refactors some global variables to be class or
1580         instance variables to be slightly more testable and more
1581         modular. There are no cases where we create lots of port objects
1582         and can't afford to test for configurations repeatedly, so
1583         there's no performance concern here.
1584
1585         https://bugs.webkit.org/show_bug.cgi?id=47466
1586
1587         * Scripts/webkitpy/layout_tests/port/base.py:
1588         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1589         * Scripts/webkitpy/layout_tests/port/chromium.py:
1590
1591 2010-10-08  Martin Robinson  <mrobinson@igalia.com>
1592
1593         Reviewed by Xan Lopez.
1594
1595         [GTK] Form controls do not respect GTK+ font size
1596         https://bugs.webkit.org/show_bug.cgi?id=47134
1597
1598         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1599         (initializeGtkFontSettings): Initialize the font control size when running
1600         DumpRenderTree to a standard value.
1601
1602 2010-10-14  Tony Chang  <tony@chromium.org>
1603
1604         Reviewed by Kent Tamura.
1605
1606         [chromium] compile TestNetscapePlugIn on Chromium mac
1607         https://bugs.webkit.org/show_bug.cgi?id=47633
1608
1609         * DumpRenderTree/DumpRenderTree.gypi: files to compile
1610         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
1611         (NP_GetEntryPoints):
1612         (NPP_New):
1613         (NPP_Destroy):
1614         (NPP_HandleEvent):
1615         (NPP_GetValue):
1616         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
1617         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
1618         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
1619
1620 2010-10-14  Victor Wang  <victorw@chromium.org>
1621
1622         Reviewed by Nate Chapin.
1623
1624         [Chromium] Fix rebaseline_chromium_webkit_tests to use 0 tolerance image diff.
1625
1626         https://bugs.webkit.org/show_bug.cgi?id=47686
1627
1628         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1629
1630 2010-10-14  Eric Seidel  <eric@webkit.org>
1631
1632         Reviewed by Adam Barth.
1633
1634         test-webkitpy spews Delegate terminated queue messages
1635         https://bugs.webkit.org/show_bug.cgi?id=47678
1636
1637         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1638
1639 2010-10-14  Adam Roben  <aroben@apple.com>
1640
1641         Test that pressing the Alt key generates a WM_SYSCOMMAND message
1642
1643         Test for <http://webkit.org/b/47671> <rdar://problem/8435594> Pressing
1644         the Alt key when MiniBrowser's WKView is focused doesn't send focus to
1645         the menu bar
1646
1647         Reviewed by Steve Falkenburg.
1648
1649         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added
1650         TestWebKitAPI/win to the include path so that WindowMessageObserver
1651         can be found.
1652
1653         * TestWebKitAPI/PlatformWebView.h: Added simulateAltKeyPress and
1654         Windows-specific members.
1655         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver):
1656         Added this simple setter.
1657
1658         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Added.
1659         (TestWebKitAPI::WMSysCommandObserver::WMSysCommandObserver):
1660         Initialize our lone data member.
1661         (TestWebKitAPI::WMSysCommandObserver::windowDidReceiveWMSysCommand):
1662         Simple getter.
1663         (TestWebKitAPI::WMSysCommandObserver::windowReceivedMessage): Record
1664         when a WM_SYSCOMMAND message is received.
1665         (TestWebKitAPI::didNotHandleKeyEventCallback): Record when a
1666         WM_SYSKEYUP message is not handled.
1667         (TestWebKitAPI::WebKit2_AltKeyGeneratesWMSysCommand): Simulate
1668         pressing the Alt key and check that a WM_SYSCOMMAND message got sent
1669         to the WKView's parent window.
1670
1671         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1672         (TestWebKitAPI::PlatformWebView::registerWindowClass): Made this a
1673         member function so it could access PlatformWebView::wndProc. Use
1674         PlatformWebView::wndProc as the WNDPROC.
1675         (TestWebKitAPI::PlatformWebView::PlatformWebView): Initialize our new
1676         data member and pass the this pointer to CreateWindowEx so we can
1677         store it on the HWND.
1678         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Moved some
1679         constants from here to the top of the file.
1680         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress): Added. Sends
1681         the same messages that Notepad receives when you press the Alt key.
1682         (TestWebKitAPI::PlatformWebView::wndProc): Added.
1683           - When WM_CREATE is received, we set the PlatformWebView instance
1684             pointer as a property on the HWND so we can access it later.
1685           - For other messages, we try to get the PlatformWebView instance
1686             pointer from the HWND property.
1687           - When WM_NCDESTROY is received (which is the last message we will
1688             receive), we remove the PlatformWebView instance property.
1689           - Pass messages to the parent window's message observer, if there is
1690             one.
1691           - Pass all messages through to ::DefWindowProcW.
1692
1693         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added WindowMessageObserver
1694         and AltKeyGeneratesWMSysCommand.
1695
1696         * TestWebKitAPI/win/WindowMessageObserver.h: Added. This class can be
1697         used to observe messages sent to one or more windows.
1698
1699 2010-10-01  Martin Robinson  <mrobinson@igalia.com>
1700
1701         Reviewed by Holger Freyther.
1702
1703         [GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
1704         https://bugs.webkit.org/show_bug.cgi?id=47033
1705
1706         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1707         (initializeGtkFontSettings): Added this method which initializes XSettings
1708         font settings to consistent values before running a test. For the one test
1709         in which we need subpixel aliasing turned on, do that.
1710         (initializeFonts): Accepts a testURL parameter now and delegates to initializeGtkFontSettings.
1711         (runTest): Pass the testURL to initializeFonts.
1712
1713 2010-10-14  Adam Barth  <abarth@webkit.org>
1714
1715         Reviewed by Eric Seidel.
1716
1717         ChromiumXVFBPort.run_webkit_tests_command has infinite recursion
1718         https://bugs.webkit.org/show_bug.cgi?id=47655
1719
1720         * Scripts/webkitpy/common/config/ports.py:
1721         * Scripts/webkitpy/common/config/ports_unittest.py:
1722
1723 2010-10-13  Eric Seidel  <eric@webkit.org>
1724
1725         Reviewed by Adam Barth.
1726
1727         beat diff_parser with the ugly stick
1728         https://bugs.webkit.org/show_bug.cgi?id=47626
1729
1730         * Scripts/webkitpy/common/checkout/diff_parser.py:
1731         * Scripts/webkitpy/style/patchreader.py:
1732         * Scripts/webkitpy/style/patchreader_unittest.py:
1733
1734 2010-10-13  Eric Seidel  <eric@webkit.org>
1735
1736         Reviewed by Adam Barth.
1737
1738         Break LayoutTestResults out into its own file
1739         https://bugs.webkit.org/show_bug.cgi?id=47637
1740
1741         * Scripts/webkitpy/common/net/buildbot.py:
1742         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1743         * Scripts/webkitpy/common/net/layouttestresults.py: Added.
1744         * Scripts/webkitpy/common/net/layouttestresults_unittest.py: Added.
1745
1746 2010-10-13  Adam Barth  <abarth@webkit.org>
1747
1748         Unreviewed.
1749
1750         Chromium port can't run JavaScriptCore tests
1751         https://bugs.webkit.org/show_bug.cgi?id=47654
1752
1753         This lets webkit-patch build-and-test work on Chromium.
1754
1755         * Scripts/webkitpy/common/config/ports.py:
1756         * Scripts/webkitpy/tool/steps/runtests.py:
1757
1758 2010-10-13  Adam Barth  <abarth@webkit.org>
1759
1760         Reviewed by Eric Seidel.
1761
1762         Make --port a global option and pass the port information to the commit-queue subprocess
1763         https://bugs.webkit.org/show_bug.cgi?id=47650
1764
1765         This patch paves the way to run the commit-queue on a non-Mac port.
1766
1767         * Scripts/webkitpy/tool/commands/queues.py:
1768         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1769         * Scripts/webkitpy/tool/commands/queuestest.py:
1770         * Scripts/webkitpy/tool/main.py:
1771         * Scripts/webkitpy/tool/steps/options.py:
1772         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1773         * Scripts/webkitpy/tool/steps/runtests.py:
1774         * Scripts/webkitpy/tool/steps/update.py:
1775
1776 2010-10-13  Adam Barth  <abarth@webkit.org>
1777
1778         Reviewed by Eric Seidel.
1779
1780         Introduce the ChromiumXVFBPort for running commit-queue on EC2
1781         https://bugs.webkit.org/show_bug.cgi?id=47653
1782
1783         I'm not entirely sure this is the best way to do this, but we need to
1784         run the tests under XVFB on EC2 because the EC2 instances don't have a
1785         real monitor hooked up.  This patch adds a ChromiumXVFBPort that runs
1786         that way.  The idea is that XVFB is like a platform for the Chromium
1787         port, but we don't have a real notion of platform separate from port.
1788
1789         * Scripts/webkitpy/common/config/ports.py:
1790
1791 2010-10-13  Sergio Villar Senin  <svillar@igalia.com>
1792
1793         Reviewed by Martin Robinson.
1794
1795         [GTK] Add HTTP caching support
1796         https://bugs.webkit.org/show_bug.cgi?id=44261
1797
1798         Add include paths for the new soup HTTP cache code.
1799
1800         * GNUmakefile.am: Add paths for the new soup HTTP cache code.
1801
1802 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
1803
1804         Reviewed by Antonio Gomes.
1805
1806         [Qt] QtTestBrowser shows two Url input fields
1807         https://bugs.webkit.org/show_bug.cgi?id=47613
1808
1809         * QtTestBrowser/mainwindow.cpp:
1810         (MainWindow::MainWindow):
1811         (MainWindow::buildUI):
1812
1813 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
1814
1815         Reviewed by Tony Chang.
1816
1817         [gdb] Add pretty-print supports for UString, Identifier and JSString
1818         https://bugs.webkit.org/show_bug.cgi?id=47601
1819
1820         * gdb/webkit.py:
1821
1822 2010-10-13  Adam Barth  <abarth@webkit.org>
1823
1824         Reviewed by Eric Seidel.
1825
1826         Add list of Ubuntu packages needed by the EWS bots
1827         https://bugs.webkit.org/show_bug.cgi?id=47628
1828
1829         I've been copy/pasting this list between bots, but it's better to have
1830         this checked in.
1831
1832         * EWSTools/ubuntu-ews-packages: Added.
1833
1834 2010-10-13  Leandro Pereira  <leandro@profusion.mobi>
1835
1836         Reviewed by Csaba Osztrogonác.
1837
1838         [EFL] Adds a build slave.
1839         https://bugs.webkit.org/show_bug.cgi?id=47290
1840
1841         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1842         entry for a release build of the EFL port.
1843         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1844         flag to build the EFL port.
1845
1846 2010-10-13  Adam Barth  <abarth@webkit.org>
1847
1848         Reviewed by Csaba Osztrogonác.
1849
1850         webkit-patch build shouldn't need --build to actually build!
1851         https://bugs.webkit.org/show_bug.cgi?id=47438
1852
1853         Yeah, requiring --build for the build command is really dumb.  We did
1854         this originally because the build step is usually optional in other
1855         commands.  We don't have a good way of reversing the default for an
1856         option in one command.  This approach is slightly hacky since --build
1857         still shows up as an option on the help page, but at least it makes
1858         progress.  Passing --build is harmless, so the EWS bots shouldn't
1859         explode because of this change.
1860
1861         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1862         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1863         * Scripts/webkitpy/tool/commands/download.py:
1864         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1865         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1866
1867 2010-10-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1868
1869         Unreviewed, rolling out r69638.
1870         http://trac.webkit.org/changeset/69638
1871         https://bugs.webkit.org/show_bug.cgi?id=47595
1872
1873         "Broke win and chromium-win bots" (Requested by dglazkov on
1874         #webkit).
1875
1876         * Scripts/webkitpy/common/system/path.py:
1877         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1878         * Scripts/webkitpy/layout_tests/port/base.py:
1879         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1880         * Scripts/webkitpy/layout_tests/port/chromium.py:
1881         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1882
1883 2010-10-13  John Knottenbelt  <jknotten@chromium.org>
1884
1885         Reviewed by Steve Block.
1886
1887         First step towards client-based Geolocation in Chromium. Build
1888         fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
1889         https://bugs.webkit.org/show_bug.cgi?id=47586
1890
1891         * DumpRenderTree/chromium/WebViewHost.cpp:
1892         * DumpRenderTree/chromium/WebViewHost.h:
1893
1894 2010-10-13  Adam Roben  <aroben@apple.com>
1895
1896         Test that pressing the spacebar in a text field does not scroll the
1897         document
1898
1899         Test for <http://webkit.org/b/47544> <rdar://problem/8540645>
1900         REGRESSION: Pressing spacebar in a text field in WebKit2 does not
1901         insert a space, scrolls the page instead
1902
1903         Reviewed by Sam Weinig.
1904
1905         * TestWebKitAPI/PlatformUtilities.h: Added isKeyDown.
1906
1907         * TestWebKitAPI/PlatformWebView.h: Added simulateSpacebarKeyPress.
1908
1909         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1910         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1911         * TestWebKitAPI/win/copy-resources.cmd:
1912         Added new files.
1913
1914         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Added.
1915         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext):
1916         We use this to track what the result of calling into JavaScript was.
1917         (TestWebKitAPI::didFinishLoadForFrame): Records when the page
1918         finishes loading.
1919         (TestWebKitAPI::didNotHandleKeyEventCallback): Records when a key down
1920         event is not handled.
1921         (TestWebKitAPI::javaScriptCallback): Records that JavaScript finished
1922         executing and whether the result matched our expectation.
1923         (TestWebKitAPI::wk): Turns a UTF-8 C string into a WKStringRef.
1924         (TestWebKitAPI::runJSTest): Calls into JS, waits for the call to
1925         complete, and returns whether we got back the expected result.
1926         (TestWebKitAPI::WebKit2_SpacebarScrolling): Tests that pressing
1927         spacebar inside a text field does not scroll the document and that
1928         pressing it outside the text field does scroll the document.
1929
1930         * TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Added.
1931
1932         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1933         (TestWebKitAPI::Util::isKeyDown): Checks the event's type.
1934
1935         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1936         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Copied
1937         code from DRT's EventSendingController.
1938
1939         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1940         (TestWebKitAPI::Util::isKeyDown): Checks the message's type.
1941
1942         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1943         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Send the
1944         same messages that get sent when you press spacebar in Notepad.
1945
1946 2010-10-13  Adam Roben  <aroben@apple.com>
1947
1948         Fix a couple of issues with the TestWebKitAPI build
1949
1950         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops:
1951         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
1952         Fixed a typo.
1953
1954         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Use common.vsprops
1955         to set our output and intermediate directories so that we don't spew
1956         files into the source tree.
1957
1958 2010-10-13  Balazs Kelemen  <kbalazs@webkit.org>
1959
1960         Reviewed by Csaba Osztrogonác.
1961
1962         WTR should accept relative paths
1963         https://bugs.webkit.org/show_bug.cgi?id=47486
1964
1965         * WebKitTestRunner/StringFunctions.h:
1966         * WebKitTestRunner/TestInvocation.cpp:
1967         (WTR::createWKURL): Moved from StringFunctions.h since it is
1968         used only here. Extend relative paths to absolute.
1969
1970 2010-10-12  Adam Roben  <aroben@apple.com>
1971
1972         Make TestWebKitAPI work on Windows
1973
1974         Fixes <http://webkit.org/b/47552> <rdar://problem/8541708>.
1975
1976         Reviewed by Sam Weinig.
1977
1978         * Scripts/build-api-tests: Build TestWebKitAPI.sln on Windows.
1979
1980         * Scripts/run-api-tests: Fix the PATH so that TestWebKitAPI can be
1981         run on Windows.
1982         (runTest): Added code to run TestWebKitAPI.exe on Windows and to die
1983         on unsupported platforms.
1984         (populateTests): Added code to run TestWebKitAPI.exe on Windows and to
1985         die on other platforms. Extracted some formerly-Mac-specific code to
1986         be cross-platform and made it handle any style of line-endings.
1987
1988         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added.
1989         Links against CFLite.
1990
1991         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added.
1992         Contains most properties for the project.
1993
1994         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
1995         Added. Links against CoreFoundation.
1996
1997         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added a Windows-specific
1998         section and moved the cross-platform section after the
1999         platform-specific parts.
2000
2001         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
2002         (TestWebKitAPI::Util::run): Runs a normal message pump until we're
2003         done.
2004         (TestWebKitAPI::Util::cf): Turns a UTF-8 C string into a CFString.
2005         (TestWebKitAPI::Util::createURLForResource): Uses CFBundle to get the
2006         resource path.
2007         (TestWebKitAPI::Util::URLForNonExistentResource): Creates a bogus
2008         WKURL.
2009
2010         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
2011         (TestWebKitAPI::registerWindowClass):
2012         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2013         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2014         (TestWebKitAPI::PlatformWebView::page):
2015         This was mostly copied from WebKitTestRunner's PlatformWebView.
2016
2017         * TestWebKitAPI/win/TestWebKitAPI.sln: Added. Builds both
2018         TestWebKitAPI and TestWebKitAPIGeneratd. This is used by the
2019         build-api-tests script.
2020
2021         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added. Builds
2022         TestWebKitAPI.exe.
2023
2024         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added. Just calls
2025         through to copy-resources.cmd.
2026
2027         * TestWebKitAPI/win/copy-resources.cmd: Added. Copies resources into
2028         or deletes resources from TestWebKitAPI.resources.
2029
2030         * TestWebKitAPI/win/main.cpp: Added.
2031         (main): Calls through to TestsController.
2032
2033 2010-10-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2034
2035         Reviewed by Kenneth Rohde Christiansen.
2036
2037         [EFL] Support viewport configuration and add new arguments for WebKit EFL
2038         https://bugs.webkit.org/show_bug.cgi?id=47084
2039
2040         Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
2041         needs to be modified according to the changes.
2042
2043         * EWebLauncher/main.c:
2044         (on_viewport_changed):
2045
2046 2010-10-12  Dirk Pranke  <dpranke@chromium.org>
2047
2048         Reviewed by Eric Seidel.
2049
2050         This patch enables new-run-webkit-tests (in particular the
2051         chromium-win port) to run under Cygwin as well as Win32. Mostly
2052         this just required some conversions from cygwin paths to Win32
2053         paths when we spawn off Win32 binaries like test_shell.
2054
2055         https://bugs.webkit.org/show_bug.cgi?id=47220
2056
2057         * Scripts/webkitpy/common/system/path.py:
2058         - Expose the cygpath() function for path conversion
2059
2060         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2061         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2062         - shift filename->uri conversion in the TestInfo objects to the
2063           dump_render_tree thread
2064
2065         * Scripts/webkitpy/layout_tests/port/base.py:
2066         * Scripts/webkitpy/layout_tests/port/chromium.py:
2067         - use cygpath()
2068
2069 2010-10-12  Yuta Kitamura  <yutak@chromium.org>
2070
2071         Unreviewed. Add Yuta Kitamura (yutak) to the committers list.
2072
2073         * Scripts/webkitpy/common/config/committers.py:
2074
2075 2010-10-12  Sam Weinig  <sam@webkit.org>
2076
2077         Reviewed by Dan Bernstein.
2078
2079         When a provisional load fails, the provisional URL returned
2080         from WKFrameCopyProvisionalURL should be empty
2081         <rdar://problem/8540878>
2082         https://bugs.webkit.org/show_bug.cgi?id=47546
2083
2084         Add test.
2085
2086         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2087         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2088
2089 2010-10-12  Anders Carlsson  <andersca@apple.com>
2090
2091         Reviewed by Sam Weinig.
2092
2093         Start fleshing out find page overlays
2094         https://bugs.webkit.org/show_bug.cgi?id=47559
2095
2096         * MiniBrowser/mac/BrowserWindowController.m:
2097         (-[BrowserWindowController find:]):
2098         Pass kWKFindOptionsShowOverlay to WKPageFindString.
2099
2100 2010-10-12  Robert Hogan  <robert@webkit.org>
2101
2102         Reviewed by Antonio Gomes.
2103
2104         [Qt] editing/input/emacs-ctrl-o.html
2105
2106         ctrl-o is bound to a sequence of commands on Mac, namely:
2107         insertParagraphSeparator then moveLeft. In the DRT, we just interpret
2108         ctrl-o in EventSenderQt as '\n', i.e. insertParagraphSeparator. As a
2109         result we only issue one command, so don't generate the change in caret
2110         position that results in the extra editing delegate messages.
2111
2112         So for the sake of not managing suspicious-looking differences, just
2113         make DRT issue the appropriate edit commands to pass the test.
2114
2115         https://bugs.webkit.org/show_bug.cgi?id=47548
2116
2117         * DumpRenderTree/qt/EventSenderQt.cpp:
2118         (EventSender::keyDown):
2119
2120 2010-10-12  Anders Carlsson  <andersca@apple.com>
2121
2122         Reviewed by Sam Weinig.
2123
2124         Add a simple Find UI to MiniBrowser
2125         https://bugs.webkit.org/show_bug.cgi?id=47553
2126
2127         * MiniBrowser/mac/BrowserWindow.xib:
2128         Add Find panel.
2129
2130         * MiniBrowser/mac/BrowserWindowController.h:
2131         * MiniBrowser/mac/BrowserWindowController.m:
2132         (-[BrowserWindowController performFindPanelAction:]):
2133         Show the find panel.
2134
2135         (-[BrowserWindowController find:]):
2136         Tell the WKPageRef to find the given string.
2137
2138 2010-10-12  Tony Chang  <tony@chromium.org>
2139
2140         Unreviewed, fixing DRT compile on Windows after r69586.
2141
2142         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2143
2144 2010-10-12  Tony Chang  <tony@chromium.org>
2145
2146         Unreviewed, trying to fix NRWT on Windows.
2147
2148         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2149
2150 2010-10-12  Balazs Kelemen  <kbalazs@webkit.org>
2151
2152         Reviewed by Kenneth Rohde Christiansen.
2153
2154         [Qt][WTR] Checking the path of the injected bundle is bogus
2155         https://bugs.webkit.org/show_bug.cgi?id=47541
2156
2157         * WebKitTestRunner/qt/TestControllerQt.cpp:
2158         (WTR::isExistingLibrary): Added (static helper).
2159         Extend the path with the appropriate suffix(es) on the
2160         platform and check that the file exists.
2161         (WTR::TestController::initializeInjectedBundlePath):
2162         There were two bugs with the path checking:
2163             - the condition should have been inverted
2164             - QLibrary::fileName does not give back the filename
2165               with the library suffix so we cannot check
2166               that existance of the file this way.
2167
2168 2010-10-12  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2169
2170         Reviewed by Tony Chang.
2171
2172         Implement http locking in NRWT.
2173         https://bugs.webkit.org/show_bug.cgi?id=47072
2174
2175         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2176         * Scripts/webkitpy/layout_tests/port/base.py:
2177         * Scripts/webkitpy/layout_tests/port/http_lock.py: Added.
2178         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: Added.
2179         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2180
2181 2010-10-12  Mark Rowe  <mrowe@apple.com>
2182
2183         Fix the 32-bit WebKit2 build.
2184
2185         * MiniBrowser/mac/BrowserWindowController.m:
2186         (getWindowFrame): Use NSRect rather than CGRect since that's what -frame returns.
2187         (setWindowFrame): Use NSMakeRect rather than CGRectMake since that's what -setFrame:display: expects.
2188
2189 2010-10-11  Tony Chang  <tony@chromium.org>
2190
2191         Reviewed by Adam Barth.
2192
2193         change the order of mrobinson's email addresses so bugs.webkit.org suggests the right one
2194         https://bugs.webkit.org/show_bug.cgi?id=47513
2195
2196         bugs.webkit.org suggests mrobinson@igalia.com as an autocomplete,
2197         which doesn't actually work.
2198
2199         * Scripts/webkitpy/common/config/committers.py:
2200
2201 2010-10-11  Prasad Tammana  <prasadt@chromium.org>
2202
2203         Reviewed by Dmitry Titov.
2204
2205         Added support for showModalDialog on chromium port.
2206
2207         Implement showModalDialog for Layout tests for chromium port
2208         https://bugs.webkit.org/show_bug.cgi?id=46759
2209
2210         * DumpRenderTree/chromium/WebViewHost.cpp:
2211         (WebViewHost::closeWidgetSoon): Quit current message loop if in a modal loop.
2212         (WebViewHost::runModal):  Start a nested message loop and remember that.
2213         (WebViewHost::WebViewHost):  Initialize m_inModalLoop.
2214         * DumpRenderTree/chromium/WebViewHost.h:  Add m_inModalLoop.
2215
2216 2010-10-11  Martin Robinson  <mrobinson@igalia.com>
2217
2218         Reviewed by Gustavo Noronha Silva.
2219
2220         [GTK] Cleanup font selection code for the Freetype backend
2221         https://bugs.webkit.org/show_bug.cgi?id=47503
2222
2223         Update DRT to set values for the cursive and fantasy font families, so
2224         that we can generate consistent results for tests that use these families.
2225         Add some missing information to fonts.conf.
2226
2227         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2228         (resetDefaultsToConsistentValues): Always set the fantasy and cursive font
2229         family names.
2230         * DumpRenderTree/gtk/fonts/fonts.conf: Add aliases for cursive and fantasy fonts
2231         to our default serif font. Eventually we may want to import or require some "real"
2232         fonts, but this should at least ensure consistent rendering during test runs. Also
2233         add aliases for some other commonly used fonts in tests (Arial and Lucida Grande).
2234         Finally, add a missing oblique specification for DejaVu Serif, which was resulting
2235         in some incorrect baselines for the synthetic oblique test.
2236
2237 2010-10-11  Adam Barth  <abarth@webkit.org>
2238
2239         Unreviewed.
2240
2241         Fix sheriffbot not to crash when there are failing tests.  It turns out
2242         Python sets don't support the + operator.  We need to use union
2243         instead.  There's a more elegant way to do this in Python 2.6, but we
2244         need this code to work in 2.5.
2245
2246         * Scripts/webkitpy/common/net/failuremap.py:
2247         * Scripts/webkitpy/common/net/failuremap_unittest.py:
2248
2249 2010-10-10  Robert Hogan  <robert@webkit.org>
2250
2251         Unreviewed, fix failing test from r69468.
2252
2253         [Qt] Put all DRT-created pages in a page group
2254
2255         Fix on r69468.
2256
2257         Because we don't delete closed pages immediately in DRT we need
2258         to remove them from the page group explicitly instead.
2259
2260         Fixes failure of fast/events/popup-blocked-from-fake-user-gesture.html
2261
2262         https://bugs.webkit.org/show_bug.cgi?id=47469
2263
2264         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2265         (WebCore::DumpRenderTree::windowCloseRequested):
2266
2267 2010-10-10  Leandro Pereira  <leandro@profusion.mobi>
2268
2269         Reviewed by Adam Barth.
2270
2271         commit-queue: Add EFL-EWS status bubble to Bugzilla, now that the
2272         EFL-EWS bot is up and running.
2273         https://bugs.webkit.org/show_bug.cgi?id=47277
2274
2275         * QueueStatusServer/handlers/statusbubble.py:
2276
2277 2010-10-10  Robert Hogan  <robert@webkit.org>
2278
2279         Reviewed by Antonio Gomes.
2280
2281         [Qt] Put all DRT-created pages in a page group
2282
2283         https://bugs.webkit.org/show_bug.cgi?id=47469
2284
2285         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2286         (WebCore::DumpRenderTree::DumpRenderTree):
2287         (WebCore::DumpRenderTree::createWindow):
2288
2289 2010-10-09  Sam Weinig  <sam@webkit.org>
2290
2291         Reviewed by Dan Bernstein.
2292
2293         WKFrameGetFrameLoadState() returns kWKFrameLoadStateCommitted after the load has been stopped
2294         <rdar://problem/8173667>
2295         https://bugs.webkit.org/show_bug.cgi?id=47461
2296
2297         * TestWebKitAPI/PlatformUtilities.h:
2298         * TestWebKitAPI/Test.h:
2299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2300         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Added.
2301         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2302         (TestWebKitAPI::TEST):
2303         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2304         (TestWebKitAPI::Util::URLForNonExistentResource):
2305         Adds a test for the frame load state after a failed provisional load. I wanted to test
2306         the frame load state after a committed load failed, but I don't believe that is possible
2307         to do without hooking up the http server to serve a long loading page.
2308
2309 2010-10-09  Sam Weinig  <sam@webkit.org>
2310
2311         Reviewed by Dan Bernstein.
2312
2313         Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
2314         <rdar://problem/8447690>
2315         https://bugs.webkit.org/show_bug.cgi?id=47459
2316
2317         * MiniBrowser/mac/BrowserWindowController.m:
2318         (runBeforeUnloadConfirmPanel):
2319         (-[BrowserWindowController awakeFromNib]):
2320         * WebKitTestRunner/TestController.cpp:
2321         (WTR::createOtherPage):
2322         (WTR::TestController::initialize):
2323
2324 2010-10-09  Sam Weinig  <sam@webkit.org>
2325
2326         Reviewed by Dan Bernstein.
2327
2328         Need implementation of ChromeClient windowRect related functions.
2329         <rdar://problem/8469476>
2330         https://bugs.webkit.org/show_bug.cgi?id=47386
2331
2332         * MiniBrowser/mac/BrowserWindowController.m:
2333         (getWindowFrame):
2334         (setWindowFrame):
2335         (-[BrowserWindowController awakeFromNib]):
2336         * WebKitTestRunner/PlatformWebView.h:
2337         * WebKitTestRunner/TestController.cpp:
2338         (WTR::TestController::initialize):
2339         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2340         (WTR::PlatformWebView::windowFrame):
2341         (WTR::PlatformWebView::setWindowFrame):
2342         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2343         (WTR::PlatformWebView::windowFrame):
2344         (WTR::PlatformWebView::setWindowFrame):
2345         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2346         (WTR::PlatformWebView::windowFrame):
2347         (WTR::PlatformWebView::setWindowFrame):
2348
2349 2010-10-08  Adam Barth  <abarth@webkit.org>
2350
2351         Unreviewed (Eric is on vacation in this change is trivial).
2352
2353         Add a "clean" command to webkit-patch to clean the working directory
2354         https://bugs.webkit.org/show_bug.cgi?id=47436
2355
2356         This command is useful when using SVN because "svn revert" leaves
2357         unversioned files behind.
2358
2359         * Scripts/webkitpy/tool/commands/download.py:
2360
2361 2010-10-08  Andras Becsi  <abecsi@webkit.org>
2362
2363         Unreviewed build fix.
2364
2365         [Qt] Add missing limits.h include since the Qt version currently
2366         ran on the bot does need that.
2367
2368         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2369
2370 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
2371
2372         Reviewed by Csaba Osztrogonác.
2373
2374         [Qt] Turn on building WTR
2375         https://bugs.webkit.org/show_bug.cgi?id=47349
2376
2377         * Scripts/webkitdirs.pm:
2378
2379 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
2380
2381         Reviewed by Andreas Kling.
2382
2383         [Qt] TestController needs its platform dependent methods
2384         https://bugs.webkit.org/show_bug.cgi?id=47413
2385
2386         * WebKitTestRunner/qt/TestControllerQt.cpp:
2387         (WTR::TestController::initializeInjectedBundlePath):
2388         If the WTR_INJECTEDBUNDLE_PATH environmental variable is
2389         set then use that otherwise use the path where the bundle
2390         lives in a normal trunk build.
2391         (WTR::TestController::initializeTestPluginDirectory):
2392         Set the bundle's value. It is not used currently.
2393         (WTR::TestController::platformInitializeContext):
2394         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2395
2396 2010-10-08  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2397
2398         Reviewed by Kenneth Rohde Christiansen.
2399
2400         WTR: Prevent sending the Done message twice on test timeout.
2401         https://bugs.webkit.org/show_bug.cgi?id=47410
2402
2403         When InjectedBundle::done() calls stopLoading, this may trigger
2404         InjectedBundlePage::didFailLoadWithErrorForFrame which calls
2405         InjectedBundle::done() itself later in the stack.
2406         This would output the timeout failure message twice and confuse
2407         the run-webkit-tests script.
2408
2409         This patch adds a third state, Stopping, which prevents WebCore
2410         errors to trigger done() when testing is over.
2411
2412         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2413         (WTR::InjectedBundle::done):
2414         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2415
2416 2010-10-08  Andras Becsi  <abecsi@webkit.org>
2417
2418         Reviewed by Kenneth Rohde Christiansen.
2419
2420         [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
2421         Original code by Simon Hausmann.
2422         https://bugs.webkit.org/show_bug.cgi?id=47402
2423
2424         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Added.
2425         (WTR::activateFonts):
2426
2427 2010-10-08  Andras Becsi  <abecsi@webkit.org>
2428
2429         Reviewed by Csaba Osztrogonác.
2430
2431         [Qt] Add support for Qt's WebKitTestRunner to old-run-webkit-tests.
2432         https://bugs.webkit.org/show_bug.cgi?id=47401
2433
2434         * Scripts/build-webkittestrunner:
2435         * Scripts/old-run-webkit-tests:
2436
2437 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2438
2439         Reviewed by Kenneth Rohde Christiansen.
2440
2441         [Qt] WTR first compile: fix compile issues.
2442         https://bugs.webkit.org/show_bug.cgi?id=47343
2443
2444         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
2445         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2446         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2447         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2448         * WebKitTestRunner/TestController.cpp:
2449         * WebKitTestRunner/TestInvocation.cpp:
2450
2451 2010-10-07  Antonio Gomes  <agomes@rim.com>
2452
2453         Reviewed by Simon Fraser.
2454
2455         [Mac] [DRT] implement setSpatialNavigationEnabled
2456         https://bugs.webkit.org/show_bug.cgi?id=47291
2457
2458         Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT
2459         so it can track regression on the existing implementation and future improvements
2460         we are making.
2461
2462         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2463         (LayoutTestController::setSpatialNavigationEnabled):
2464
2465 2010-10-07  Dirk Pranke  <dpranke@chromium.org>
2466
2467         Reviewed by Adam Barth.
2468
2469         rebaseline-chromium-webkit-tests relied on the filename_to_uri()
2470         hook in the Port infrastructure to generate URIs for the files
2471         in its summary HTML report; however, that method is supposed to only
2472         be used for test files (and should really be renamed), so this would
2473         crash.
2474
2475         This change adds a new "path" module to the system package with a
2476         routine called abspath_to_uri() that handles converting paths to
2477         file: URIs independently of anything in the layout_tests package,
2478         and changes the code to use this. At some point in the near future
2479         the layout_tests/port/* code should use this as well.
2480
2481         This change also deletes a bunch of unused code and fixes some
2482         comments in rebaseline_chromium_webkit_tests.py.
2483
2484         https://bugs.webkit.org/show_bug.cgi?id=47319
2485
2486         * Scripts/webkitpy/common/system/path.py: Added.
2487         * Scripts/webkitpy/common/system/path_unittest.py: Added.
2488         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2489         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2490
2491 2010-10-07  Martin Robinson  <mrobinson@igalia.com>
2492
2493         Reviewed by Gustavo Noronha Silva.
2494
2495         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
2496         https://bugs.webkit.org/show_bug.cgi?id=46216
2497
2498         Fix my latest commit, as it contained some bad changes from a merge gone wrong.
2499
2500         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2501         (initializeFonts): Also initialize the DevaVu Sans font.
2502
2503 2010-10-07  Daniel Cheng  <dcheng@chromium.org>
2504
2505         Reviewed by Tony Chang.
2506
2507         [chromium] Minor naming cleanup in WebDragData, part 2
2508         https://bugs.webkit.org/show_bug.cgi?id=47227
2509
2510         Update DRT to use the renamed methods.
2511
2512         * DumpRenderTree/chromium/EventSender.cpp:
2513         (EventSender::beginDragWithFiles):
2514         * DumpRenderTree/chromium/WebViewHost.cpp:
2515         (addDRTFakeFileToDataObject):
2516
2517 2010-10-07  Anders Carlsson  <andersca@apple.com>
2518
2519         Reviewed by Sam Weinig.
2520
2521         Add a WKPageFindClient, hook up WKPageCountStringMatches
2522         https://bugs.webkit.org/show_bug.cgi?id=47373
2523
2524         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2525         Remove hard coded paths.
2526
2527         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2528         (TestWebKitAPI::TEST):
2529         Fix expected result.
2530
2531         * TestWebKitAPI/Tests/WebKit2/Find.cpp: Added.
2532         (TestWebKitAPI::didFinishLoadForFrame):
2533         (TestWebKitAPI::didCountStringMatches):
2534         (TestWebKitAPI::TEST):
2535         * TestWebKitAPI/Tests/WebKit2/find.html: Added.
2536         Add test for WKPageCountStringMatches.
2537
2538 2010-09-21  Martin Robinson  <mrobinson@igalia.com>
2539
2540         Reviewed by Chris Fleizach.
2541
2542         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
2543         https://bugs.webkit.org/show_bug.cgi?id=46216
2544
2545         * DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN
2546         for DejaVu Serif when there is no bold version available. This is necessary to
2547         properly test the property in layout tests.
2548
2549 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
2550
2551         Reviewed by Kenneth Rohde Christiansen.
2552
2553         [Qt] Add WTR's InjectedBundle build files.
2554         https://bugs.webkit.org/show_bug.cgi?id=47333
2555
2556         * Scripts/webkitdirs.pm:
2557         * WebKitTestRunner/DerivedSources.pro: Added.
2558         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
2559         * WebKitTestRunner/WebKitTestRunner.pro: Added.
2560         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
2561         Content merged in ../DerivedSources.pro
2562
2563 2010-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2564
2565         Unreviewed, rolling out r69315.
2566         http://trac.webkit.org/changeset/69315
2567         https://bugs.webkit.org/show_bug.cgi?id=47363
2568
2569         Forgot to add the new files (Requested by kbalazs on #webkit).
2570
2571         * Scripts/webkitdirs.pm:
2572         * WebKitTestRunner/qt/DerivedSources.pro: Added.
2573
2574 2010-10-07  Sam Weinig  <sam@webkit.org>
2575
2576         Reviewed by Anders Carlsson.
2577
2578         Change API tester to ask the executable for the list of all
2579         tests instead of relying on the directory structure.
2580         https://bugs.webkit.org/show_bug.cgi?id=47359
2581
2582         * Scripts/run-test-webkit-api: Added.
2583         * Scripts/webkitdirs.pm:
2584         Add additional script to just launch the api tester with the correct settings.
2585
2586         * Scripts/run-api-tests:
2587         Change to use the new --dump-tests options to build the list of tests and change
2588         output to reflect a (suite, testcase) tuple for each test. Also adds some color.
2589
2590         * TestWebKitAPI/Test.h:
2591         (TestWebKitAPI::Test::Register::Register):
2592         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2593         (TestWebKitAPI::TEST):
2594         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2595         (TestWebKitAPI::TEST):
2596         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2597         (TestWebKitAPI::TEST):
2598         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2599         (TestWebKitAPI::TEST):
2600         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2601         (TestWebKitAPI::TEST):
2602         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2603         (TestWebKitAPI::TEST):
2604         Give each test a suite name in addition to the test name.
2605
2606         * TestWebKitAPI/TestsController.cpp:
2607         (TestWebKitAPI::TestsController::dumpTestNames):
2608         (TestWebKitAPI::TestsController::runTestNamed):
2609         * TestWebKitAPI/TestsController.h:
2610         * TestWebKitAPI/mac/main.mm:
2611         (main):
2612         Add option to print all registered tests.
2613
2614 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
2615
2616         Reviewed by Kenneth Rohde Christiansen.
2617
2618         [Qt] Add WTR's InjectedBundle build files.
2619         https://bugs.webkit.org/show_bug.cgi?id=47333
2620
2621         * Scripts/webkitdirs.pm:
2622         * WebKitTestRunner/DerivedSources.pro: Added.
2623         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
2624         * WebKitTestRunner/WebKitTestRunner.pro: Added.
2625         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
2626         Content merged in ../DerivedSources.pro
2627
2628 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2629
2630         Unreviewed. Do a renaming that was recommended by the reviewer
2631         (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
2632
2633         * WebKitTestRunner/qt/TestControllerQt.cpp:
2634         (WTR::RunUntilConditionLoop::start):
2635         (WTR::RunUntilConditionLoop::RunUntilConditionLoop):
2636         (WTR::TestController::runUntil):
2637
2638 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2639
2640         Reviewed by Kenneth Rohde Christiansen.
2641
2642         [Qt] Watchdog timer implementation for WTR
2643         https://bugs.webkit.org/show_bug.cgi?id=47337
2644
2645         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
2646         the definition of the timer type to a typedef.
2647         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
2648         Timer implementation with QTimer and a helper QObject class.
2649         (WTR::WatchdogTimerHelper::instance):
2650         (WTR::WatchdogTimerHelper::timerFired):
2651         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
2652         (WTR::LayoutTestController::platformInitialize):
2653         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
2654         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
2655
2656 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2657
2658         Unreviewed buildfix for 69297 again
2659
2660         * WebKitTestRunner/TestController.cpp:
2661         (WTR::blankURL):
2662
2663 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
2664
2665         Unreviewed trivial build fix for r69297
2666
2667         * WebKitTestRunner/TestController.cpp:
2668         (WTR::blankURL):
2669
2670 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2671
2672         Reviewed by Kenneth Rohde Christiansen.
2673
2674         WebKitTestRunner should be portable
2675         https://bugs.webkit.org/show_bug.cgi?id=45393
2676
2677         Use only the WebKit API for working with urls.
2678         * WebKitTestRunner/StringFunctions.h:
2679         (WTR::createWKURL):
2680         * WebKitTestRunner/TestController.cpp:
2681         (WTR::blankURL):
2682         (WTR::TestController::resetStateToConsistentValues):
2683         (WTR::TestController::didFinishLoadForFrame):
2684
2685 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2686
2687         Reviewed by Xan Lopez.
2688
2689         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
2690         https://bugs.webkit.org/show_bug.cgi?id=47332
2691
2692         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2693         (createBitmapContextFromWebView):
2694
2695 2010-10-06  Chris Guillory  <chris.guillory@google.com>
2696
2697         Reviewed by Chris Fleizach.
2698
2699         Remove unused accessibility functions from webkit.
2700         https://bugs.webkit.org/attachment.cgi?bugid=46707
2701
2702         * DumpRenderTree/chromium/WebViewHost.cpp:
2703         (WebViewHost::postAccessibilityNotification):
2704         * DumpRenderTree/chromium/WebViewHost.h:
2705
2706 2010-10-06  Lucas Forschler  <lforschler@apple.com>
2707
2708         Reviewed by Adam Roben.
2709
2710         Fix the sunspider-compare-results to actually use the passed in value for $root.
2711
2712         * Scripts/sunspider-compare-results:
2713
2714 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
2715
2716         Reviewed by Kenneth Rohde Christiansen.
2717
2718         [Qt] Runloop implementation for WTR
2719         https://bugs.webkit.org/show_bug.cgi?id=47280
2720
2721         * WebKitTestRunner/qt/TestControllerQt.cpp:
2722         Implemented TestController::runUntil by a timerEvent
2723         and a QEventLoop. We step into the event loop from runUntil.
2724         While we are waiting in the loop a timerEvent is periodically
2725         checking the value of the condition. Once the condition has
2726         becoming true the timerEvent wakes us up.
2727         (WTR::RunUntilLoop::start):
2728         (WTR::RunUntilLoop::RunUntilLoop):
2729         (WTR::RunUntilLoop::run):
2730         (WTR::RunUntilLoop::timerEvent):
2731         (WTR::TestController::platformInitialize):
2732         (WTR::TestController::runUntil):
2733         * WebKitTestRunner/qt/main.cpp:
2734         Start the main event loop first and creating the TestController later.
2735         (Launcher::Launcher):
2736         (Launcher::~Launcher):
2737         (Launcher::launch): Creating the TestController.
2738         (main): Setting up a timer for calling Launcher::launch from
2739         the main event loop.
2740
2741 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
2742
2743         Reviewed by Kenneth Russell.
2744
2745         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
2746         enable 'accelerated-composting' instead of 'accelerated-compositing'.
2747
2748         https://bugs.webkit.org/show_bug.cgi?id=47312
2749
2750         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2751         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2752
2753 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
2754
2755         Reviewed by Kenneth Rohde Christiansen.
2756
2757         [Qt] PlatformWebView implementation for WebKitTestRunner
2758         https://bugs.webkit.org/show_bug.cgi?id=47276
2759
2760         The implementation follows the way how
2761         we use the API in MiniBrowser.
2762         * WebKitTestRunner/PlatformWebView.h:
2763         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2764         (WTR::WebView::wkView):
2765         (WTR::WebView::~WebView):
2766         (WTR::WebView::WebView):
2767         (WTR::PlatformWebView::PlatformWebView):
2768         (WTR::PlatformWebView::~PlatformWebView):
2769         (WTR::PlatformWebView::resizeTo):
2770         (WTR::PlatformWebView::page):
2771         (WTR::PlatformWebView::focus):
2772         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2773
2774 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
2775
2776         Reviewed by Kenneth Rohde Christiansen.
2777
2778         [Qt] Add WebKitTestRunner's build files
2779         https://bugs.webkit.org/show_bug.cgi?id=44155
2780
2781         Parts was taken by Zoltan Horvath's patch.
2782
2783         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
2784         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
2785         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
2786         PlatformWKView and PlatformWindow (void* for now).
2787         Buildfix the case when __APPLE__ is not defined.
2788         * WebKitTestRunner/qt/DerivedSources.pro: Added.
2789         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
2790         Empty stub implementation.
2791         (WTR::registerWindowClass):
2792         (WTR::PlatformWebView::PlatformWebView):
2793         (WTR::PlatformWebView::~PlatformWebView):
2794         (WTR::PlatformWebView::resizeTo):
2795         (WTR::PlatformWebView::page):
2796         (WTR::PlatformWebView::focus):
2797         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
2798         Empty stub implementation.
2799         (WTR::registerWindowClass):
2800         (WTR::TestController::runUntil):
2801         (WTR::TestController::platformInitialize):
2802         (WTR::TestController::initializeInjectedBundlePath):
2803         (WTR::TestController::initializeTestPluginDirectory):
2804         (WTR::TestController::platformInitializeContext):
2805         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
2806         * WebKitTestRunner/qt/main.cpp: Added.
2807         (main):
2808
2809 2010-10-06  Tony Chang  <tony@chromium.org>
2810
2811         Unreviewed, rolling out r69202.
2812         http://trac.webkit.org/changeset/69202
2813         https://bugs.webkit.org/show_bug.cgi?id=46937
2814
2815         Broke compile of test_shell
2816
2817         * DumpRenderTree/chromium/EventSender.cpp:
2818         (EventSender::beginDragWithFiles):
2819         * DumpRenderTree/chromium/WebViewHost.cpp:
2820         (addDRTFakeFileToDataObject):
2821
2822 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
2823
2824         Reviewed by Tony Chang.
2825
2826         [chromium] Minor naming cleanup in WebDragData, part 2
2827         https://bugs.webkit.org/show_bug.cgi?id=46937
2828
2829         Update DRT to use the renamed methods.
2830
2831         * DumpRenderTree/chromium/EventSender.cpp:
2832         (EventSender::beginDragWithFiles):
2833         * DumpRenderTree/chromium/WebViewHost.cpp:
2834         (addDRTFakeFileToDataObject):
2835
2836 2010-10-06  David Kilzer  <ddkilzer@apple.com>
2837
2838         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
2839
2840         Reviewed by Adam Roben.
2841
2842         This is the first step in making webarchive tests work on
2843         Windows.
2844
2845         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
2846         new files to the project.
2847         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
2848         to WebArchiveDumpSupport.mm.
2849         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
2850         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
2851         (serializeWebArchiveToXML):
2852
2853 2010-10-05  Daniel Bates  <dbates@rim.com>
2854
2855         Reviewed by David Kilzer.
2856
2857         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
2858         https://bugs.webkit.org/show_bug.cgi?id=46058
2859
2860         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
2861         structure so as to support returning additional information
2862         about a change log diff.
2863
2864         Currently, VCSUtils::fixChangeLogPatch() returns a string that
2865         represents the change log diff. Towards supporting the return
2866         of additional information, such as whether the change log diff
2867         inserts an entry at the top of the ChangeLog file, we need to
2868         make VCSUtils::fixChangeLogPatch() return a reference to hash
2869         structure.
2870
2871         * Scripts/VCSUtils.pm:
2872           - Modified fixChangeLogPatch() to return a reference to a
2873             hash structure.
2874           - Added documentation to fixChangeLogPatch().
2875           - Modified call site in mergeChangeLogs() as necessary.
2876         * Scripts/svn-apply:
2877           - Modified call site in patch() as necessary.
2878         * Scripts/svn-create-patch:
2879           - Modified call site in generateDiff() as necessary.
2880         * Scripts/svn-unapply:
2881           - Modified call site in patch() as necessary.
2882         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2883           - Modified the unit tests as necessary.
2884
2885 2010-10-05  Tony Chang  <tony@chromium.org>
2886
2887         Reviewed by Darin Adler.
2888
2889         fix the link to the expected image on windows
2890         https://bugs.webkit.org/show_bug.cgi?id=47228
2891
2892         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
2893             windows, the file must be opened in binary mode when writing
2894             binary data.
2895
2896 2010-10-05  Adam Barth  <abarth@webkit.org>
2897
2898         Update expected result of unittest to match Tony's change below.
2899
2900         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2901
2902 2010-10-05  Tony Chang  <tony@chromium.org>
2903
2904         Reviewed by Ojan Vafai (over the shoulder).
2905
2906         Paper over errors in image_diff so we don't crash the whole test run.
2907
2908         * Scripts/webkitpy/layout_tests/port/chromium.py:
2909
2910 2010-10-05  Tony Chang  <tony@chromium.org>
2911
2912         Unreviewed, make shutil.rmtree more resiliant to errors
2913         since windows was raising WindowsError: The process cannot access the file because it
2914         is being used by another process.
2915
2916         * Scripts/webkitpy/layout_tests/port/chromium.py:
2917
2918 2010-10-05  Tony Chang  <tony@chromium.org>
2919
2920         Reviewed by Ojan Vafai.
2921
2922         [chromium] fix image diffing in NRWT
2923         https://bugs.webkit.org/show_bug.cgi?id=47128
2924
2925         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
2926             NamedTemporaryFile since it doesn't work on Windows.
2927         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2928
2929 2010-10-05  Kenneth Russell  <kbr@google.com>
2930
2931         Reviewed by Tony Chang.
2932
2933         [chromium] Implement layerTreeAsText in DumpRenderTree
2934         https://bugs.webkit.org/show_bug.cgi?id=47216
2935
2936         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
2937         make it callable from DumpRenderTree.
2938
2939         No new tests; verified with existing compositor layout tests.
2940
2941         * DumpRenderTree/chromium/LayoutTestController.cpp:
2942         (LayoutTestController::LayoutTestController):
2943         (LayoutTestController::layerTreeAsText):
2944         * DumpRenderTree/chromium/LayoutTestController.h:
2945
2946 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
2947
2948         Unreviewed build correction.
2949
2950         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
2951         property sheet so proper libraries are linked.
2952
2953 2010-10-05  Robert Hogan  <robert@webkit.org>
2954
2955         Reviewed by Andreas Kling.
2956
2957         [Qt] Fix url conversion in QWebHistory
2958
2959         Converting from KURL to WFT::String to QUrl does not
2960         permit proper percent encoding later.
2961
2962         https://bugs.webkit.org/show_bug.cgi?id=47048
2963
2964         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2965         (WebCore::dumpHistoryItem):
2966
2967 2010-10-05  Anders Carlsson  <andersca@apple.com>
2968
2969         Reviewed by Sam Weinig.
2970
2971         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
2972         https://bugs.webkit.org/show_bug.cgi?id=47188
2973         <rdar://problem/8514104>
2974
2975         When constructing the std::string, use the real string length instead of the maximum buffer size.
2976
2977         * TestWebKitAPI/PlatformUtilities.h:
2978         (TestWebKitAPI::Util::toSTD):
2979         * WebKitTestRunner/StringFunctions.h:
2980         (WTR::toSTD):
2981
2982 2010-10-04  Sam Weinig  <sam@webkit.org>
2983
2984         Reviewed by Mark Rowe.
2985
2986         Add MIMEType accessor to WKFrame
2987         <rdar://problem/8347683>
2988         https://bugs.webkit.org/show_bug.cgi?id=47138
2989
2990         * TestWebKitAPI/PlatformUtilities.h:
2991         (TestWebKitAPI::Util::toSTD):
2992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2993         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
2994         (TestWebKitAPI::didStartProvisionalLoadForFrame):
2995         (TestWebKitAPI::didCommitLoadForFrame):
2996         (TestWebKitAPI::didFinishLoadForFrame):
2997         (TestWebKitAPI::TEST):
2998         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
2999         (TestWebKitAPI::didStartProvisionalLoadForFrame):
3000         (TestWebKitAPI::didCommitLoadForFrame):
3001         (TestWebKitAPI::didFinishLoadForFrame):
3002         (TestWebKitAPI::TEST):
3003         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3004         (TestWebKitAPI::TEST):
3005         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
3006         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
3007         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
3008         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3009         (TestWebKitAPI::Util::createURLForResource):
3010
3011 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3012
3013         Reviewed by Ojan Vafai.
3014
3015         [NRWT] Rename current_dir to current_group because it's not a directory
3016         https://bugs.webkit.org/show_bug.cgi?id=47169
3017
3018         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3019         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3020
3021 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3022
3023         Unreviewed, build fix.
3024
3025         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
3026         which can't always be done. This test uses tempfile.mkdtemp(), which
3027         should be safe.
3028
3029         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3030
3031 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3032
3033         Unreviewed, build fix.
3034
3035         Add missing "from __future__ import with_statement" that was
3036         breaking test-webkitpy on the Leopard bots (broke in r69040).
3037
3038         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3039
3040 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
3041
3042         Unreviewed, rolling out r69066.
3043         http://trac.webkit.org/changeset/69066
3044         https://bugs.webkit.org/show_bug.cgi?id=47163
3045
3046         Made NRWT reliability worse. (Requested by tkent on #webkit).
3047
3048         * Scripts/webkitpy/layout_tests/port/chromium.py:
3049         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3050
3051 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3052
3053         Reviewed by Tony Chang.
3054
3055         [NRWT] Reverse the http tests to alphabetical order.
3056         https://bugs.webkit.org/show_bug.cgi?id=47075
3057
3058         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3059
3060 2010-10-04  Robert Hogan  <robert@webkit.org>
3061
3062         Reviewed by Andreas Kling.
3063
3064         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
3065
3066         We need to queue back and forward navigations in the DRT from the
3067         LayoutTestController so that maybeDump() knows about them.
3068
3069         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3070         (LayoutTestController::queueBackNavigation):
3071         (LayoutTestController::queueForwardNavigation):
3072
3073 2010-10-04  Tony Chang  <tony@chromium.org>
3074
3075         Reviewed by Kent Tamura.
3076
3077         [chromium] fix image diffing in NRWT
3078         https://bugs.webkit.org/show_bug.cgi?id=47128
3079
3080         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
3081               temp file and check the image_diff error code more carefully
3082         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3083
3084 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3085
3086         Reviewed by Adam Barth.
3087
3088         aroben's change in r68792 actually broke new-run-webkit-tests when
3089         running the DRT code path. His change was intended to fix the
3090         way we were converting windows paths to URIs when running under
3091         Cygwin (the paths were getting one too many "/" on the front).
3092         However, the change ended up breaking the chromium_win port, which
3093         had slightly different logic.
3094
3095         This patch removes the port-specific code and adds tests to make
3096         sure we're getting the behavior we expect. The Port object no longer
3097         exposes a get_absolute_path() method that can be used outside of
3098         of converting test filenames, because it's unreliable otherwise
3099         (we don't have the right context to know which conversion is intended).
3100
3101         https://bugs.webkit.org/show_bug.cgi?id=47140
3102
3103         * Scripts/webkitpy/layout_tests/port/base.py:
3104         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3105         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3106         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3107         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3108
3109 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3110
3111         Unreviewed, build fix.
3112
3113         Handle crash introduced in r69040 if we are not running in a
3114         Chromium checkout.
3115
3116         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3117
3118 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3119
3120         Reviewed by Tony Chang.
3121
3122         Add a way for us to have test expectations that are specific to the
3123         official builds of Google Chrome (as opposed to Chromium). This change
3124         looks for an additional "test_expectations_chrome.txt" file in
3125         Chromium's repository (webkit/tools/layout_tests), and uses the
3126         concatenation of that file and the regular test_expectations.txt
3127         file for test overrides.
3128
3129         https://bugs.webkit.org/show_bug.cgi?id=46854
3130
3131         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3132         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3133
3134 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
3135
3136         Color tests in the list based on existing pass/fail result.
3137
3138         Fix the summary data to account for htmlOnly and nonHTML tests.
3139
3140         * CSSTestSuiteHarness/harness/harness.css:
3141         (#test-list > option.pass):
3142         (#test-list > option.fail):
3143         (#test-list > option.skipped):
3144         * CSSTestSuiteHarness/harness/harness.js:
3145         (Test):
3146         (Test.prototype.statusForFormat):
3147         (TestSuite.prototype.fillTestList):
3148         (TestSuite.prototype.updateTestList):
3149         (TestSuite.prototype.recordResult):
3150         (TestSuite.prototype.markTestCompleted):
3151         (TestSuite.prototype.countTestsWithFlag):
3152         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
3153         (TestSuite.prototype.queryDatabaseForSummary):
3154
3155 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
3156
3157         Reviewed by Beth Dakin.
3158
3159         AX: doAXRangeForLine does not work
3160         https://bugs.webkit.org/show_bug.cgi?id=47101
3161
3162         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
3163
3164         * DumpRenderTree/AccessibilityUIElement.cpp:
3165         (rangeForLineCallback):
3166         (AccessibilityUIElement::rangeForLine):
3167         (AccessibilityUIElement::getJSClass):
3168         * DumpRenderTree/AccessibilityUIElement.h:
3169         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3170         (AccessibilityUIElement::rangeForLine):
3171
3172 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
3173
3174         Unreviewed. Adding myself to the committers list.
3175
3176         * Scripts/webkitpy/common/config/committers.py:
3177
3178 2010-10-04  Sam Weinig  <sam@webkit.org>
3179
3180         Reviewed by Anders Carlsson.
3181
3182         Add ability to set the CacheModel in Webkit2
3183         https://bugs.webkit.org/show_bug.cgi?id=47066
3184
3185         * MiniBrowser/mac/AppDelegate.m:
3186         (-[BrowserAppDelegate init]): Opt minibrowser into
3187         a PrimaryWebBrowser cache model.
3188
3189 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
3190
3191         Make sure to enter all tests when creating the database
3192         for the first time.
3193
3194         When migrating to a new version of the suite, be sure to
3195         sync up the database and testinfo.data by removing old
3196         tests, and inserting new ones.
3197
3198         * CSSTestSuiteHarness/harness/harness.js:
3199         (TestSuite.prototype.openDatabase.creation):
3200         (TestSuite.prototype.databaseCreated):
3201         (TestSuite.prototype.populateDatabaseFromTestInfoData):
3202         (TestSuite.prototype.insertTest):
3203
3204 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
3205
3206         More work on treating HTML4 and XHTML1 independently; when
3207         changing the format, rebuild the test list, and update the
3208         numbers in the chapter popup.
3209
3210         * CSSTestSuiteHarness/harness/harness.js:
3211         (Test):
3212         (Test.prototype.runForFormat):
3213         (Test.prototype.completedForFormat):
3214         (ChapterSection):
3215         (ChapterSection.prototype.countTests):
3216         (Chapter):
3217         (Chapter.prototype.description):
3218         (Chapter.prototype.countTests):
3219         (Chapter.prototype.testCount):
3220         (Chapter.prototype.untestedCount):
3221         (TestSuite.prototype.buildChapters):
3222         (TestSuite.prototype.loadCurrentTest):
3223         (TestSuite.prototype.updateProgressLabel):
3224         (TestSuite.prototype.processFlags):
3225         (TestSuite.prototype.formatChanged):
3226
3227 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
3228
3229         Update test suite version 20101001.
3230
3231         Handle database migration, and delete tests from the db that are
3232         not present in testinfo.data.
3233
3234         Load about:blank into the test frame before the test url, to make
3235         missing tests more obvious.
3236
3237         * CSSTestSuiteHarness/harness/harness.js:
3238         (TestSuite.prototype.loadTest):
3239         (TestSuite.prototype.openDatabase.creation):
3240         (TestSuite.prototype.openDatabase.migration1_0To1_1):
3241         (TestSuite.prototype.openDatabase.if.return):
3242         (TestSuite.prototype.databaseReady):
3243         (TestSuite.prototype.populateDatabaseFromTestInfoData):
3244         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
3245         (TestSuite.prototype.syncDatabaseWithTestInfoData):
3246
3247 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
3248
3249         Add the ability to jump to a specific test.
3250
3251         * CSSTestSuiteHarness/harness/harness.html:
3252         * CSSTestSuiteHarness/harness/harness.js:
3253         (TestSuite.prototype.goToTestByName):
3254         (TestSuite.prototype.switchToFormat):
3255
3256 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
3257
3258         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
3259         as the test.
3260
3261         * CSSTestSuiteHarness/harness/harness.js:
3262         (TestSuite.prototype.loadRef):
3263
3264 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
3265
3266         Update the UI to reflect the fact that each test needs to be tested
3267         in both HTML4 and XHTML1 format.
3268
3269         * CSSTestSuiteHarness/harness/harness.js:
3270         (Test):
3271         (Chapter.prototype.description):
3272         (Chapter.prototype.untestedCount):
3273         (TestSuite.prototype.fillChapterPopup):
3274         (TestSuite.prototype.updateChapterPopup):
3275         (TestSuite.prototype.fillTestList):
3276         (TestSuite.prototype.updateTestList):
3277         (TestSuite.prototype.goToNextIncompleteTest):
3278         (TestSuite.prototype.firstIncompleteTestIndex):
3279         (TestSuite.prototype.recordResult):
3280         (TestSuite.prototype.formatChanged):
3281         (TestSuite.prototype.markTestCompleted):
3282         (TestSuite.prototype.resetTestStatus):
3283
3284 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
3285
3286         Add the ability to remove results for re-testing, and
3287         to import results.
3288
3289         * CSSTestSuiteHarness/harness/harness.css:
3290         (.custom button):
3291         (#overlay):
3292         (#overlay.visible):
3293         (.overlay-contents):
3294         (.overlay-contents textarea):
3295         (.overlay-contents .buttons):
3296         (.overlay-contents .note):
3297         (.overlay-contents .buttons button):
3298         * CSSTestSuiteHarness/harness/harness.html:
3299         * CSSTestSuiteHarness/harness/harness.js:
3300         (TestSuite.prototype.importResults):
3301         (TestSuite.prototype.clearResults):
3302         (TestSuite.prototype.markTestCompleted):
3303         (TestSuite.prototype.resetTestStatus):
3304         (TestSuite.prototype.storeTestResult):
3305         (TestSuite.prototype.importTestResults):
3306         (TestSuite.prototype.clearTestResults):
3307
3308 2010-10-01  Sam Weinig  <sam@webkit.org>
3309
3310         Reviewed by Jon Honeycutt.
3311
3312         Deploy the new WKString functions to remove most uses of CF from
3313         the WebKitTestRunner.
3314
3315         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3316         (WTR::InjectedBundle::didReceiveMessage):
3317         (WTR::InjectedBundle::done):
3318         * WebKitTestRunner/StringFunctions.h:
3319         (WTR::toWK):
3320         (WTR::toJS):
3321         (WTR::toSTD):
3322         (WTR::operator<<):
3323         (WTR::copyURLString):
3324         * WebKitTestRunner/TestController.cpp:
3325         (WTR::TestController::resetStateToConsistentValues):
3326         (WTR::TestController::didFinishLoadForFrame):
3327         * WebKitTestRunner/TestInvocation.cpp:
3328         (WTR::TestInvocation::invoke):
3329         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3330
3331 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
3332
3333         Unreviewed TestResultsServer change.
3334
3335         Add files introduced by http://crrev.com/61273 to the list of dashboard
3336         files to update.
3337
3338         * TestResultServer/handlers/dashboardhandler.py:
3339
3340 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
3341
3342         Build Fix for Windows.
3343
3344         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
3345             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
3346             ForwardingHeaders to the include path.
3347
3348 2010-10-01  Sam Weinig  <sam@webkit.org>
3349
3350         Reviewed by Anders Carlsson.
3351
3352         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
3353
3354         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3355         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3356         (TestWebKitAPI::TEST):
3357         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
3358         (TestWebKitAPI::TEST):
3359
3360 2010-10-01  Sam Weinig  <sam@webkit.org>
3361
3362         Reviewed by Kenneth Rohde Christiansen.
3363
3364         Add additional WKString API
3365         https://bugs.webkit.org/show_bug.cgi?id=46958
3366
3367         Add basic WKStringRef tests.
3368
3369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3370         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
3371
3372 2010-10-01  Sam Weinig  <sam@webkit.org>
3373
3374         Reviewed by Dan Bernstein.
3375
3376         Add makefile for TestWebKitAPI and call it from the base makefile.
3377
3378         * Makefile:
3379         * TestWebKitAPI/Makefile: Added.
3380
3381 2010-10-01  Sam Weinig  <sam@webkit.org>
3382
3383         Reviewed by Adam Roben.
3384
3385         Remove unnecessary ForwardingHeaders from test runners.
3386         https://bugs.webkit.org/show_bug.cgi?id=47010
3387
3388         * TestWebKitAPI/Configurations/Base.xcconfig:
3389         * TestWebKitAPI/ForwardingHeaders: Removed.
3390         * WebKitTestRunner/Configurations/Base.xcconfig:
3391         * WebKitTestRunner/ForwardingHeaders: Removed.
3392
3393 2010-09-30  Adam Barth  <abarth@webkit.org>
3394
3395         Reviewed by Eric Seidel.
3396
3397         WebSocket tests are flaky
3398         https://bugs.webkit.org/show_bug.cgi?id=46956
3399
3400         Update these tools to understand how to run the WebSocket tests off the
3401         Apache server.
3402
3403         * Scripts/old-run-webkit-tests:
3404         * Scripts/webkitpy/layout_tests/port/base.py:
3405         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3406         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3407
3408 2010-10-01  Adam Roben  <aroben@apple.com>
3409
3410         Encode Executive command arguments using UTF-8 on Cygwin
3411
3412         Cygwin's Python's os.execv doesn't support unicode command arguments.
3413         Cygwin's execv expects arguments to be encoded using the current code
3414         page. But code pages are limited in what characters they can handle,
3415         and our tests include characters that the English code page can't
3416         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
3417         which can handle all characters but might confuse some commands, for
3418         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
3419         good enough, but we can deal with that when the problem arises.
3420
3421         Reviewed by Adam Barth.
3422
3423         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
3424         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
3425         fails on Windows
3426
3427         * Scripts/webkitpy/common/system/executive.py:
3428         (Executive._run_command_with_teed_output):
3429         (Executive.run_command):
3430         On Cygwin, encode arguments using UTF-8.
3431
3432 2010-10-01  Sam Weinig  <sam@webkit.org>
3433
3434         Reviewed by Adam Roben.
3435
3436         Add simple API tester for WebKit2
3437         https://bugs.webkit.org/show_bug.cgi?id=46953
3438
3439         This adds a very simple testing infrastructure for testing APIs exposed
3440         through the WebKit project. It consists of two parts: 1) a project that
3441         builds the all the tests 2) a script that searches the tests directory and
3442         calls the tester once for each test.
3443
3444         This adds the infrastructure and two tests:
3445         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
3446         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
3447
3448         This currently only works on the mac, but is designed to be easily ported
3449         to any platform.
3450
3451         * Scripts/run-api-tests: Added.
3452         * Scripts/build-api-tests: Added.
3453         Scripts to build/run the tests.
3454
3455         * TestWebKitAPI: Added.
3456         * TestWebKitAPI/Configurations: Added.
3457         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
3458         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
3459         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
3460         * TestWebKitAPI/ForwardingHeaders: Added.
3461         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
3462         * TestWebKitAPI/PlatformUtilities.h: Added.
3463         * TestWebKitAPI/PlatformWebView.h: Added.
3464         (TestWebKitAPI::PlatformWebView::platformView):
3465         * TestWebKitAPI/StringFunctions.h: Added.
3466         * TestWebKitAPI/Test.h: Added.
3467         (TestWebKitAPI::Test::~Test):
3468         (TestWebKitAPI::Test::name):
3469         (TestWebKitAPI::Test::Register::Register):
3470         (TestWebKitAPI::Test::Register::create):
3471         (TestWebKitAPI::Test::Test):
3472         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
3473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
3474         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
3475         * TestWebKitAPI/TestsController.cpp: Added.
3476         (TestWebKitAPI::TestsController::shared):
3477         (TestWebKitAPI::TestsController::TestsController):
3478         (TestWebKitAPI::TestsController::runTestNamed):
3479         (TestWebKitAPI::TestsController::testFailed):
3480         (TestWebKitAPI::TestsController::registerCreateTestFunction):
3481         * TestWebKitAPI/TestsController.h: Added.
3482         * TestWebKitAPI/mac: Added.
3483         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
3484         (TestWebKitAPI::Util::run):
3485         (TestWebKitAPI::Util::createURLForResource):
3486         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
3487         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3488         (TestWebKitAPI::PlatformWebView::resizeTo):
3489         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3490         (TestWebKitAPI::PlatformWebView::page):
3491         (TestWebKitAPI::PlatformWebView::focus):
3492         * TestWebKitAPI/mac/main.mm: Added.
3493         Infrastructure.
3494
3495         * TestWebKitAPI/Tests: Added.
3496         * TestWebKitAPI/Tests/WTF: Added.
3497         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
3498         * TestWebKitAPI/Tests/WebKit2: Added.
3499         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
3500         (TestWebKitAPI::State::State):
3501         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
3502         Proof of concept tests.
3503
3504 2010-10-01  Adam Roben  <aroben@apple.com>
3505
3506         Don't assume AccessibleObjectFromEvent succeeds
3507
3508         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
3509         DumpRenderTree!notificationListenerProc when running
3510         plugins/access-after-page-destroyed.html
3511
3512         Reviewed by Sam Weinig.
3513
3514         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3515         (notificationListenerProc): Check both the return value of
3516         AccessibleObjectFromEvent and the object it returns, as MSDN
3517         recommends.
3518
3519 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3520
3521         Reviewed by Tony Chang.
3522
3523         [NRWT] Put the http and websocket tests first in the test list.
3524         https://bugs.webkit.org/show_bug.cgi?id=46453
3525
3526         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3527         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3528
3529 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
3530
3531         Unreviewed, adding myself to the committer list.
3532
3533         * Scripts/webkitpy/common/config/committers.py:
3534
3535 2010-10-01  Adam Roben  <aroben@apple.com>
3536
3537         Test NPN_GetValue(NPNVnetscapeWindow)
3538
3539         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
3540         Right-clicking on windowless Flash plugin in WebKit2 makes a context
3541         menu appear in the bottom-right corner of the screen
3542
3543         Reviewed by Anders Carlsson.
3544
3545         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3546         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
3547
3548         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
3549
3550         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
3551         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
3552         (GetValueNetscapeWindow::NPP_SetWindow): Test that
3553         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
3554         isn't our HWND.
3555
3556         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3557         Added GetValueNetscapeWindow.
3558
3559 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
3560
3561         Unreviewed, adding my webkit.org identity to reviewer list.
3562
3563         * Scripts/webkitpy/common/config/committers.py:
3564
3565 2010-09-30  Adam Barth  <abarth@webkit.org>
3566
3567         Reviewed by Eric Seidel.
3568
3569         The WebSocket server should flush its logs
3570         https://bugs.webkit.org/show_bug.cgi?id=46946
3571
3572         The WebSocket server logs are truncated because the driver just
3573         terminates the child.  It should run Python without buffering so we can
3574         see the end of the log.
3575
3576         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3577
3578 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
3579
3580         Add a button to jump to the next untested test.