d6faf4c088c1e015788b4b92a5b0531e5a056fb1
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-10-16  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Adam Barth.
4
5         commit-queue status bot should list which buildbot is blocking the queue
6         https://bugs.webkit.org/show_bug.cgi?id=30452
7
8         Add new methods and testing.
9
10         * Scripts/bugzilla-tool:
11         * Scripts/modules/buildbot.py:
12         * Scripts/modules/buildbot_unittest.py:
13
14 2009-10-16  Eric Seidel  <eric@webkit.org>
15
16         Reviewed by Adam Barth.
17
18         run-webkit-tests fails when CWD is not inside a WebKit checkout
19         https://bugs.webkit.org/show_bug.cgi?id=30451
20
21         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
22         * Scripts/modules/scm_unittest.py:
23           - Remove use of original_path (we don't need to restore the CWD).
24           - Don't use '.' to find the webkit checkout, use __file__ instead.
25
26 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
27
28         Reviewed by Adam Roben.
29
30         Add a Debug_All configuration to build entire stack as debug.
31         Change Debug_Internal to:
32         - stop using _debug suffix for all WebKit/Safari binaries
33         - not use _debug as a DLL naming suffix
34         - use non-debug C runtime lib.
35
36         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
37         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
38         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
39         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
40         Add missing debug.vsprops inherited property sheet.
41         Add Debug_All configuration.
42         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
43         * WinLauncher/WinLauncher.vcproj:
44         Removed extraneous definitions inherited from vsprops.
45         Add Debug_All configuration.
46
47 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
48
49         Reviewed by David Levin.
50
51         check-webkit-style is wrong about indent checking in namespaces
52         in header files and a few other things
53         https://bugs.webkit.org/show_bug.cgi?id=30362
54
55         The few other things include:
56         + check-webkit-style does not require spaces around the equal sign
57           inside 'if' statements and around binary operators that take 
58           numeric literals.
59         + check-webkit-style reports false errors for the / operator
60           when part of a filename in the #include directive.
61
62         * Scripts/modules/cpp_style.py:
63         Improved indentation checking and space checking around
64         binary operators. While the checks are still not perfect,
65         they are clearly better than before.
66         * Scripts/modules/cpp_style_unittest.py:
67         Added test cases for the newly supported checks and modified old
68         test cases to match the new guidelines
69
70 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
71
72         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
73
74         * wx/build/settings.py:
75
76 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
77
78         Reviewed by David Levin.
79
80         Add mod_pywebsocket to test Web Sockets.
81         http://code.google.com/p/pywebsocket/
82         https://bugs.webkit.org/show_bug.cgi?id=27490
83
84         * pywebsocket/COPYING: Added.
85         * pywebsocket/MANIFEST.in: Added.
86         * pywebsocket/README: Added.
87         * pywebsocket/example/echo_client.py: Added.
88         * pywebsocket/example/echo_wsh.py: Added.
89         * pywebsocket/mod_pywebsocket/__init__.py: Added.
90         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
91         * pywebsocket/mod_pywebsocket/handshake.py: Added.
92         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
93         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
94         * pywebsocket/mod_pywebsocket/standalone.py: Added.
95         * pywebsocket/mod_pywebsocket/util.py: Added.
96         * pywebsocket/setup.py: Added.
97         * pywebsocket/test/config.py: Added.
98         * pywebsocket/test/mock.py: Added.
99         * pywebsocket/test/run_all.py: Added.
100         * pywebsocket/test/test_dispatch.py: Added.
101         * pywebsocket/test/test_handshake.py: Added.
102         * pywebsocket/test/test_mock.py: Added.
103         * pywebsocket/test/test_msgutil.py: Added.
104         * pywebsocket/test/test_util.py: Added.
105         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
106         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
107         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
108         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
109         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
110         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
111         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
112         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
113
114 2009-10-15  James Robinson  <jamesr@google.com>
115
116         Reviewed by David Levin.
117
118         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
119
120         https://bugs.webkit.org/show_bug.cgi?id=30426
121
122         * Scripts/modules/cpp_style.py:
123         * Scripts/modules/cpp_style_unittest.py:
124
125 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
126
127         Reviewed by Adam Roben.
128
129         Fixes <http://webkit.org/b/30411>.
130         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
131         
132         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
133         building Chromium.
134
135         * Scripts/pdevenv:
136
137 2009-10-15  Robin Dunn  <robin@alldunn.com>
138
139         Reviewed by Kevin Ollivier.
140
141         Add Mac package building scripts for wx.
142         
143         https://bugs.webkit.org/show_bug.cgi?id=30405
144
145         * wx/build/build_utils.py:
146         * wx/build/settings.py:
147         * wx/packaging/build-mac-installer.py: Added.
148
149 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
150
151         Reviewed by Gustavo Noronha.
152
153         Enable Web Sockets support when running layout tests.
154
155         * DumpRenderTree/gtk/DumpRenderTree.cpp:
156         (resetDefaultsToConsistentValues):
157
158 2009-10-15  Xan Lopez  <xlopez@igalia.com>
159
160         Reviewed by Gustavo Noronha.
161
162         Need to initialize event.button.button, since in most cases a
163         button number is not passed as an argument.
164
165         * DumpRenderTree/gtk/EventSender.cpp:
166         (mouseDownCallback):
167         (mouseUpCallback):
168
169 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
170
171         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
172         the OS if none was explicitly set.
173
174         * wx/build/settings.py:
175
176 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
177
178         Reviewed by Timothy Hatcher.
179
180         Web Inspector: enable developers extras within inspector layout tests.
181
182         https://bugs.webkit.org/show_bug.cgi?id=30014
183
184         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
185         (LayoutTestController::showWebInspector):
186         (LayoutTestController::closeWebInspector):
187         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
188         (LayoutTestController::showWebInspector):
189         (LayoutTestController::closeWebInspector):
190
191 2009-10-14  José Millán Soto  <jmillan@igalia.com>
192
193         Reviewed by Jan Alonzo.
194
195         GtkLauncher is using a deprecated signal
196         https://bugs.webkit.org/show_bug.cgi?id=30364
197
198         Modified GtkLauncher to use notify::title signal instead of
199         deprecated title-changed signal
200
201         * GtkLauncher/main.c:
202         (notify_title_cb):
203         (create_browser):
204
205 2009-10-14  Brady Eidson  <beidson@apple.com>
206
207         Reviewed by Sam Weinig.
208
209         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
210         1 - Disables WebHistory
211         2 - Doesn't make sense in that context anyway.
212
213         * DumpRenderTree/win/DumpRenderTree.cpp:
214         (createWebViewAndOffscreenWindow):
215
216 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
217
218         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
219         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
220
221         * wx/build/settings.py:
222         * wx/install-unix-extras:
223
224 2009-10-14  Brady Eidson  <beidson@apple.com>
225
226         Reviewed by Sam Weinig.
227
228         WebKit Win API should provide a delegate interface for global history.
229         https://bugs.webkit.org/show_bug.cgi?id=29905
230
231         * DumpRenderTree/LayoutTestController.cpp:
232         (LayoutTestController::LayoutTestController):
233         * DumpRenderTree/LayoutTestController.h:
234         (LayoutTestController::dumpHistoryDelegateCallbacks):
235         (LayoutTestController::setDumpHistoryDelegateCallbacks):
236                 
237         * DumpRenderTree/win/DumpRenderTree.cpp:
238         (shouldLogHistoryDelegates):
239         (runTest):
240         (createWebViewAndOffscreenWindow):
241         (main):
242         * DumpRenderTree/win/DumpRenderTree.vcproj:
243         
244         Add the IWebHistoryDelegate to DRT Windows:
245         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
246         (wstringFromBSTR):
247         (HistoryDelegate::HistoryDelegate):
248         (HistoryDelegate::~HistoryDelegate):
249         (HistoryDelegate::QueryInterface):
250         (HistoryDelegate::AddRef):
251         (HistoryDelegate::Release):
252         (HistoryDelegate::didNavigateWithNavigationData):
253         (HistoryDelegate::didPerformClientRedirectFromURL):
254         (HistoryDelegate::didPerformServerRedirectFromURL):
255         (HistoryDelegate::updateHistoryTitle):
256         (HistoryDelegate::populateVisitedLinksForWebView):
257         * DumpRenderTree/win/HistoryDelegate.h: Added.
258
259         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
260         (LayoutTestController::removeAllVisitedLinks):
261
262 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
263
264         Reviewed by Simon Hausmann.
265
266         [Qt] Implement support for setPOSIXLocale on Qt.
267         https://bugs.webkit.org/show_bug.cgi?id=30268 
268  
269         * DumpRenderTree/qt/DumpRenderTree.cpp:
270         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
271         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
272         (LayoutTestController::setPOSIXLocale):
273         * DumpRenderTree/qt/LayoutTestControllerQt.h:
274
275 2009-10-13  Stephanie Lewis  <slewis@apple.com>
276
277         Unreviewed, adding myself to reviewers list.
278
279         * Scripts/modules/committers.py:
280
281 2009-10-13  Stephanie Lewis  <slewis@apple.com>
282
283         Reviewed by Mark Rowe.
284
285         Fix null assignment so root tests work again.
286
287         * Scripts/webkitdirs.pm:
288
289 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
290
291         Reviewed by Simon Hausmann.
292
293         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
294         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
295         This is done in preparation of implementing missing features in DRT.
296         No functionality changes made yet.
297
298         * DumpRenderTree/qt/DumpRenderTree.cpp:
299         * DumpRenderTree/qt/DumpRenderTree.pro:
300         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
301         (EventSender::EventSender):
302         (EventSender::mouseDown):
303         (EventSender::mouseUp):
304         (EventSender::mouseMoveTo):
305         (EventSender::leapForward):
306         (EventSender::keyDown):
307         (EventSender::contextClick):
308         (EventSender::scheduleAsynchronousClick):
309         (EventSender::frameUnderMouse):
310         * DumpRenderTree/qt/EventSenderQt.h: Added.
311         (EventSender::clearKillRing):
312         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
313         (LayoutTestController::LayoutTestController):
314         (LayoutTestController::reset):
315         (LayoutTestController::processWork):
316         (LayoutTestController::maybeDump):
317         (LayoutTestController::waitUntilDone):
318         (LayoutTestController::notifyDone):
319         (LayoutTestController::windowCount):
320         (LayoutTestController::clearBackForwardList):
321         (LayoutTestController::dumpEditingCallbacks):
322         (LayoutTestController::dumpResourceLoadCallbacks):
323         (LayoutTestController::queueBackNavigation):
324         (LayoutTestController::queueForwardNavigation):
325         (LayoutTestController::queueLoad):
326         (LayoutTestController::queueReload):
327         (LayoutTestController::queueScript):
328         (LayoutTestController::provisionalLoad):
329         (LayoutTestController::timerEvent):
330         (LayoutTestController::encodeHostName):
331         (LayoutTestController::decodeHostName):
332         (LayoutTestController::setJavaScriptProfilingEnabled):
333         (LayoutTestController::setFixedContentsSize):
334         (LayoutTestController::setPrivateBrowsingEnabled):
335         (LayoutTestController::setPopupBlockingEnabled):
336         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
337         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
338         (LayoutTestController::numberOfActiveAnimations):
339         (LayoutTestController::disableImageLoading):
340         (LayoutTestController::dispatchPendingLoadRequests):
341         (LayoutTestController::setDatabaseQuota):
342         (LayoutTestController::clearAllDatabases):
343         (LayoutTestController::whiteListAccessFromOrigin):
344         (LayoutTestController::waitForPolicyDelegate):
345         (LayoutTestController::overridePreference):
346         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
347         (LayoutTestController::isLoading):
348         (LayoutTestController::setLoading):
349         (LayoutTestController::shouldDumpAsText):
350         (LayoutTestController::shouldDumpBackForwardList):
351         (LayoutTestController::shouldDumpChildrenAsText):
352         (LayoutTestController::shouldDumpDatabaseCallbacks):
353         (LayoutTestController::shouldDumpStatusCallbacks):
354         (LayoutTestController::shouldWaitUntilDone):
355         (LayoutTestController::canOpenWindows):
356         (LayoutTestController::shouldDumpTitleChanges):
357         (LayoutTestController::waitForPolicy):
358         (LayoutTestController::dumpAsText):
359         (LayoutTestController::dumpChildFramesAsText):
360         (LayoutTestController::dumpDatabaseCallbacks):
361         (LayoutTestController::dumpStatusCallbacks):
362         (LayoutTestController::setCanOpenWindows):
363         (LayoutTestController::dumpBackForwardList):
364         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
365         (LayoutTestController::display):
366         (LayoutTestController::dumpTitleChanges):
367         (LayoutTestController::dumpSelectionRect):
368         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
369         (TextInputController::TextInputController):
370         (TextInputController::doCommand):
371         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
372         * DumpRenderTree/qt/WorkQueue.cpp:
373         * DumpRenderTree/qt/WorkQueue.h:
374         * DumpRenderTree/qt/WorkQueueItem.h:
375         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
376         (findFrameNamed):
377         (LoadItem::invoke):
378         (ReloadItem::invoke):
379         (ScriptItem::invoke):
380         (BackForwardItem::invoke):
381         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
382         * DumpRenderTree/qt/jsobjects.h:
383
384 2009-10-13  Dmitry Titov  <dimich@chromium.org>
385
386         Not reviewed, adding myself to the list of reviewers.
387
388         * Scripts/modules/committers.py:
389
390 2009-10-13  Anders Carlsson  <andersca@apple.com>
391
392         Reviewed by Sam Weinig.
393
394         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
395
396         Make the private browsing mode testable by the test plug-in.
397         
398         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
399         (pluginGetProperty):
400         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
401         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
402         (NPP_New):
403         (NPP_SetValue):
404
405 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
406
407         No review, just adding self to the list of reviewers.
408
409         * Scripts/modules/committers.py:
410
411 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
412
413         Reviewed by Adam Roben.
414
415         Web Inspector: Use proper web view in inspector layout
416         tests for windows.
417
418         https://bugs.webkit.org/show_bug.cgi?id=30298
419
420         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
421         (LayoutTestController::showWebInspector):
422         (LayoutTestController::closeWebInspector):
423         (LayoutTestController::evaluateInWebInspector):
424
425 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
426
427         Reviewed by Sam Weinig.
428
429         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
430         https://bugs.webkit.org/show_bug.cgi?id=29841
431
432         * DumpRenderTree/mac/DumpRenderTree.mm:
433         (resetDefaultsToConsistentValues):
434         * DumpRenderTree/win/DumpRenderTree.cpp:
435         (resetDefaultsToConsistentValues):
436
437 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
438
439         Reviewed by Dimitri Glazkov.
440
441         Chromium Port - Windows
442         https://bugs.webkit.org/show_bug.cgi?id=29969
443
444         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
445         * Scripts/webkitdirs.pm:
446
447 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
448
449         Reviewed by Darin Adler.
450
451         jsc scripts cleanup and Qt/GTK fix
452         https://bugs.webkit.org/show_bug.cgi?id=30288
453
454         Duplicated jscPath() moved to webkitdirs.pm.
455         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
456         Configuration added (release/debug) to path for Qt-port on Windows.
457
458         * Scripts/run-javascriptcore-tests:
459         * Scripts/run-jsc:
460         * Scripts/run-sunspider:
461         * Scripts/sunspider-compare-results:
462         * Scripts/webkitdirs.pm:
463
464 2009-10-11  Adam Barth  <abarth@webkit.org>
465
466         Unreviewed.  Add Collin to committers.py.
467
468         * Scripts/modules/committers.py:
469
470 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
471
472         wx build fix, add bindings to source/include dirs now that there are sources there.
473
474         * wx/build/settings.py:
475
476 2009-10-09  Mark Rowe  <mrowe@apple.com>
477
478         Reviewed by Brady Eidson.
479
480         Enable plug-in halting in DumpRenderTree.
481
482         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
483         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
484
485         * DumpRenderTree/mac/DumpRenderTree.mm:
486         (resetDefaultsToConsistentValues):
487         * DumpRenderTree/mac/UIDelegate.mm:
488         (-[UIDelegate webView:shouldHaltPlugin:]):
489
490 2009-10-08  Brady Eidson  <beidson@apple.com>
491
492         Reviewed by Dan Bernstein.
493
494         Ask the History Delegate to populate the visited links hash.
495         <rdar://problem/7285293> and https://webkit.org/b/29904
496
497         Add the ability for LayoutTestController to clear all visited links.
498         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
499
500         * DumpRenderTree/LayoutTestController.cpp:
501         (LayoutTestController::LayoutTestController):
502         (removeAllVisitedLinksCallback):
503         (LayoutTestController::staticFunctions):
504         * DumpRenderTree/LayoutTestController.h:
505         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
506         (LayoutTestController::removeAllVisitedLinks):
507
508         * DumpRenderTree/mac/HistoryDelegate.mm:
509         (-[HistoryDelegate populateVisitedLinksForWebView:]):
510
511         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
512         (LayoutTestController::removeAllVisitedLinks):
513         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
514         (LayoutTestController::removeAllVisitedLinks):
515         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
516         (LayoutTestController::removeAllVisitedLinks):
517
518
519 2009-10-08  Daniel Bates  <dbates@webkit.org>
520
521         Reviewed by Adam Roben.
522
523         https://bugs.webkit.org/show_bug.cgi?id=30175
524         
525         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
526         the OLE drag-and-drop return value like the function it emulates. Currently, 
527         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
528         whether the drag-and-drop operation was successful or was cancelled.
529         
530         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
531         return value according to whether the drop operation was successful or not.
532
533         * DumpRenderTree/win/EventSender.cpp:
534         (doMouseUp): Added parameter oleDragAndDropReturnValue.
535         (replaySavedEvents): Ditto.
536         * DumpRenderTree/win/EventSender.h:
537         * DumpRenderTree/win/UIDelegate.cpp:
538         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
539
540 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
541
542         Reviewed by Xan Lopez.
543
544         [GTK] Added support for a parameter setting the button that was
545         pressed in the mouseDown function.
546         https://bugs.webkit.org/show_bug.cgi?id=30220
547
548         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
549
550 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
551
552         Reviewed by Xan Lopez.
553
554         [GTK] Added a line to the bottom of the expected result to match
555         the output of the test.
556         https://bugs.webkit.org/show_bug.cgi?id=30220
557
558         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
559         expected.txt:
560
561 2009-10-08  Adam Roben  <aroben@apple.com>
562
563         Use QueryInterface to get IWebInspectorPrivate
564
565         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
566         accessed in a more standard way
567
568         Reviewed by John Sullivan and Tim Hatcher.
569
570         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
571         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
572         by calling IWebViewPrivate::inspector, then use QueryInterface to get
573         to the IWebInspectorPrivate interface.
574
575 2009-10-07  Adam Roben  <aroben@apple.com>
576
577         Implement DRT support for origin whitelisting
578
579         Fixes <http://webkit.org/b/30185>.
580
581         Reviewed by Eric Seidel.
582
583         * DumpRenderTree/win/DumpRenderTree.cpp:
584         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
585         whitelist, to match Mac DRT.
586         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
587         (LayoutTestController::whiteListAccessFromOrigin): Call through to
588         IWebViewPrivate::whiteListAccessFromOrigin.
589
590 2009-10-07  Brady Eidson  <beidson@apple.com>
591
592         Reviewed by Darin Adler.
593
594         Send title changes to the global history delegate.
595         <rdar://problem/7285293> and https://webkit.org/b/29904
596
597         * DumpRenderTree/mac/HistoryDelegate.mm:
598         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
599
600 2009-10-07  Adam Barth  <abarth@webkit.org>
601
602         Unreviewed.  Remove some folks from committers.py who were listed on
603         the WebKit Team wiki page but who weren't actually listed as commit+.
604         At some point, we should coorelate this list with the committers
605         mailing list.
606
607         * Scripts/modules/committers.py:
608
609 2009-10-07  Adam Barth  <abarth@webkit.org>
610
611         Unreviewed.  Import a bunch of committers from the WebKit Team page on
612         the wiki into committers.py.
613
614         * Scripts/modules/committers.py:
615
616 2009-10-07  Adam Barth  <abarth@webkit.org>
617
618         Unreviewed.  Added Aaron Boodman to committers.py.
619
620         * Scripts/modules/committers.py:
621
622 2009-10-07  Evan Martin  <evan@chromium.org>
623
624         Reviewed by Darin Adler.
625
626         Add API to LayoutTestController for re/setting the system locale.
627         https://bugs.webkit.org/show_bug.cgi?id=18994
628
629         * DumpRenderTree/LayoutTestController.cpp:
630         (setLocaleCallback):
631         (LayoutTestController::staticFunctions):
632         (LayoutTestController::setLocale):
633         * DumpRenderTree/LayoutTestController.h:
634
635 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
636
637         Reviewed by Jan Alonzo.
638
639         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
640         https://bugs.webkit.org/show_bug.cgi?id=29689
641
642         Build fix by adding -lfontconfig for DumpRenderTree.
643
644         * GNUmakefile.am:
645
646 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
647
648         Reviewed by Simon Hausmann.
649
650         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
651
652         * Scripts/run-webkit-tests:
653
654 2009-10-07  Xan Lopez  <xlopez@igalia.com>
655
656         Reviewed by Gustavo Noronha.
657
658         "delete" in EventSender is the backspace key, not the delete one.
659
660         * DumpRenderTree/gtk/EventSender.cpp:
661         (keyDownCallback):
662
663 2009-10-07  Xan Lopez  <xlopez@igalia.com>
664
665         Reviewed by Gustavo Noronha.
666
667         getChildrenWithRange expects as last parameter the end index, not
668         the length of the range. Correct this and clarify the variable
669         names to reflect how the code works.
670
671         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
672         (AccessibilityUIElement::getChildrenWithRange):
673         (AccessibilityUIElement::getChildAtIndex):
674
675 2009-10-06  Mark Rowe  <mrowe@apple.com>
676
677         Reviewed by Simon Fraser.
678
679         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
680
681         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
682         the fact we have already changed the working directory to the top of the open source tree.
683
684 2009-10-06  Julie Parent  <jparent@chromium.org>
685
686         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
687         rather than my committer email.
688
689         * Scripts/modules/committers.py:
690
691 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
692
693         Reviewed by Eric Seidel.
694
695         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
696
697         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
698         it after each layout test as it should do, making the DRT dump additional output
699         for all of the subsequent layout tests.
700
701         * DumpRenderTree/qt/jsobjects.cpp:
702         (LayoutTestController::reset):
703
704 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
705
706         Reviewed by Simon Hausmann.
707
708         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
709         fast/dom/assign-to-window-status.html test, which is passing as a result.
710
711         https://bugs.webkit.org/show_bug.cgi?id=30127
712
713         * DumpRenderTree/qt/DumpRenderTree.cpp:
714         (WebCore::DumpRenderTree::DumpRenderTree):
715         (WebCore::DumpRenderTree::statusBarMessage):
716         * DumpRenderTree/qt/DumpRenderTree.h:
717         * DumpRenderTree/qt/jsobjects.h:
718         (LayoutTestController::shouldDumpStatusCallbacks):
719         (LayoutTestController::dumpStatusCallbacks):
720
721 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
722
723         Reviewed by Simon Hausmann.
724
725         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
726         ignores the argument indicating which mouse button to trigger.
727         https://bugs.webkit.org/show_bug.cgi?id=30048
728
729         This affects the fast/events/mouse-click-events.html layout test.
730
731         * DumpRenderTree/qt/jsobjects.cpp:
732         (EventSender::mouseDown):
733         (EventSender::mouseUp):
734         * DumpRenderTree/qt/jsobjects.h:
735
736 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
737
738         Reviewed by Simon Hausmann.
739
740         [Qt] Fix the EventSender::keyDown() implementation
741         https://bugs.webkit.org/show_bug.cgi?id=30043
742
743         It should post both a key press event and a key release event,
744         just like other ports do.
745
746         * DumpRenderTree/qt/jsobjects.cpp:
747         (EventSender::keyDown):
748
749 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
750
751         wx build fix. Add jpeg to the list of libs to link against.
752
753         * wx/build/settings.py:
754
755 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
756
757         Reviewed by Simon Hausmann.
758
759         [Qt] EventSender::keyDown() cannot send function-key events.
760         https://bugs.webkit.org/show_bug.cgi?id=30044
761
762         This affects the fast/events/keydown-function-keys.html layout test.
763
764         * DumpRenderTree/qt/jsobjects.cpp:
765         (EventSender::keyDown):
766
767 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
768
769         Added --wx-compiler-prefix waf option to allow building wxWebKit with
770         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
771
772         * wx/build/settings.py:
773         * wx/build/wxpresets.py:
774
775 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
776
777         Reviewed by Timothy Hatcher.
778
779         Web Inspector: add testing harness for Web Inspector.
780
781         https://bugs.webkit.org/show_bug.cgi?id=30010
782
783         * DumpRenderTree/LayoutTestController.cpp:
784         (showWebInspectorCallback):
785         (closeWebInspectorCallback):
786         (evaluateInWebInspectorCallback):
787         (LayoutTestController::staticFunctions):
788         * DumpRenderTree/LayoutTestController.h:
789         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
790         (LayoutTestController::showWebInspector):
791         (LayoutTestController::closeWebInspector):
792         (LayoutTestController::evaluateInWebInspector):
793         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
794         (LayoutTestController::showWebInspector):
795         (LayoutTestController::closeWebInspector):
796         (LayoutTestController::evaluateInWebInspector):
797         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
798         (LayoutTestController::showWebInspector):
799         (LayoutTestController::closeWebInspector):
800         (LayoutTestController::evaluateInWebInspector):
801         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
802         (LayoutTestController::showWebInspector):
803         (LayoutTestController::closeWebInspector):
804         (LayoutTestController::evaluateInWebInspector):
805
806 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
807
808         Reviewed by Ariyha Hidayat.
809
810         Pass arguments to system() as a string instead of array
811
812         When passed as an array entries with a space fail to translate
813         to two arguments to the child process, so instead of manually
814         splitting all the entries in @buildArgs we pass the whole thing
815         as a string instead.
816
817         * Scripts/webkitdirs.pm:
818
819 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
820
821         Reviewed by David Levin.
822
823         check-webkit-style misses whitespace errors for operators:
824         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
825         https://bugs.webkit.org/show_bug.cgi?id=30021
826
827         * Scripts/modules/cpp_style.py:
828         Added the operators mentioned above to the same list as == and !=.
829
830 2009-10-02  Julie Parent  <jparent@chromium.org>
831
832         Unreviewed.
833
834         Adding myself and Ojan Vafai as committers, because we are committers.
835
836         * Scripts/modules/committers.py:
837
838 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
839
840         Reviewed by Adam Roben.
841
842         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
843         this will help the patch merging process when TryBots are used.
844
845         * Scripts/svn-create-patch:
846
847 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
848
849         Reviewed by Simon Hausmann.
850
851         [Qt] Implement layoutTestController.overridePreference().
852         https://bugs.webkit.org/show_bug.cgi?id=29970
853
854         * DumpRenderTree/qt/DumpRenderTree.cpp:
855         (WebCore::WebPage::WebPage):
856         (WebCore::WebPage::resetSettings):
857         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
858         * DumpRenderTree/qt/jsobjects.cpp:
859         (LayoutTestController::reset):
860         (LayoutTestController::setPrivateBrowsingEnabled):
861         (LayoutTestController::setPopupBlockingEnabled):
862         (LayoutTestController::overridePreference):
863         * DumpRenderTree/qt/jsobjects.h:
864
865 2009-10-01  Chris Marrin  <cmarrin@apple.com>
866
867         Reviewed by Oliver Hunt.
868
869         Turn on ENABLE_3D_CANVAS in TOT
870         https://bugs.webkit.org/show_bug.cgi?id=29906
871
872         * Scripts/build-webkit:
873
874 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
875
876         Rubberstamped by Simon Hausmann.
877
878         Enable HTTP tests for Qt
879
880         * Scripts/run-webkit-tests:
881
882 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
883
884         Reviewed by Dimitri Glazkov.
885
886         build-webkit --chromium now also works on cygwin.
887
888         https://bugs.webkit.org/show_bug.cgi?id=29973
889
890         * Scripts/webkitdirs.pm:
891
892 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
893
894         Reviewed by Simon Hausmann.
895
896         [Qt] Don't use TCmalloc in DumpRenderTree
897         https://bugs.webkit.org/show_bug.cgi?id=27029
898
899         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
900
901         * DumpRenderTree/qt/DumpRenderTree.pro:
902
903 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
904
905         Reviewed by Simon Hausmann.
906
907         [Qt] Implement eventSender.scheduleAsynchronousClick().
908
909         https://bugs.webkit.org/show_bug.cgi?id=29931
910
911         * DumpRenderTree/qt/jsobjects.cpp:
912         (EventSender::scheduleAsynchronousClick):
913         * DumpRenderTree/qt/jsobjects.h:
914
915 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
916
917         Reviewed by Simon Hausmann.
918
919         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
920         fast/events/open-window-from-another-frame.html from the Skipped list.
921
922         https://bugs.webkit.org/show_bug.cgi?id=29930
923
924         * DumpRenderTree/qt/jsobjects.cpp:
925         (LayoutTestController::setPopupBlockingEnabled):
926         * DumpRenderTree/qt/jsobjects.h:
927
928 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
929
930         Unreviewed.
931
932         Added myself to the list of committers.
933
934         * Scripts/modules/committers.py:
935
936 2009-09-30  Eric Seidel  <eric@webkit.org>
937
938         No review, just adding Geoff to the list of reviewers.
939
940         * Scripts/modules/committers.py:
941
942 2009-09-30  Dan Bernstein  <mitz@apple.com>
943
944         Reviewed by Sam Weinig.
945
946         Added the WebKit Layout Tests fonts that are referenced in
947         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
948
949         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
950         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
951
952 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
953
954         Reviewed by David Kilzer.
955
956         Make sunspider scripts work on Windows platform.
957         https://bugs.webkit.org/show_bug.cgi?id=29656
958
959         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
960         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
961         * Scripts/webkitdirs.pm: currentPerlPath() added.
962
963 2009-09-29  Brady Eidson  <beidson@apple.com>
964
965         Rubberstamped by Dan Bernstein.
966
967         Fix license and some sorting in new files.
968
969         * DumpRenderTree/mac/HistoryDelegate.h:
970         * DumpRenderTree/mac/HistoryDelegate.mm:
971
972 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
973
974         Reviewed by David Kilzer.
975
976         Fixed how error codes are handled.
977         https://bugs.webkit.org/show_bug.cgi?id=29898
978
979         * Scripts/update-webkit:
980         * Scripts/update-webkit-chromium:
981
982 2009-09-29  Brady Eidson  <beidson@apple.com>
983
984         Reviewed by John Sullivan.
985
986         Updated way-out-of-date sorting throughout the dump methods/flags.
987
988         * DumpRenderTree/LayoutTestController.cpp:
989         (LayoutTestController::LayoutTestController):
990         (dumpAsPDFCallback):
991         (dumpAsTextCallback):
992         (dumpFrameLoadCallbacksCallback):
993         (dumpResourceLoadCallbacksCallback):
994         (LayoutTestController::staticFunctions):
995
996         * DumpRenderTree/LayoutTestController.h:
997         (LayoutTestController::dumpAsText):
998         (LayoutTestController::setDumpAsText):
999         (LayoutTestController::dumpFrameLoadCallbacks):
1000         (LayoutTestController::setDumpFrameLoadCallbacks):
1001         (LayoutTestController::dumpSelectionRect):
1002         (LayoutTestController::setDumpSelectionRect):
1003         (LayoutTestController::dumpSourceAsWebArchive):
1004         (LayoutTestController::setDumpSourceAsWebArchive):
1005         (LayoutTestController::dumpStatusCallbacks):
1006         (LayoutTestController::setDumpStatusCallbacks):
1007         (LayoutTestController::dumpTitleChanges):
1008         (LayoutTestController::setDumpTitleChanges):
1009         (LayoutTestController::dumpWillCacheResponse):
1010         (LayoutTestController::setDumpWillCacheResponse):
1011
1012 2009-09-29  Brady Eidson  <beidson@apple.com>
1013
1014         Reviewed by John Sullivan.
1015
1016         WebKit Mac API should provide a delegate interface for global history.
1017         <rdar://problem/7042773> and https://webkit.org/b/29904
1018
1019         Adding the dumping of global history delegate callbacks.
1020
1021         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1022
1023         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
1024         * DumpRenderTree/mac/DumpRenderTree.mm:
1025         (createWebViewAndOffscreenWindow):
1026         (allocateGlobalControllers):
1027         (shouldLogFrameLoadDelegates):
1028         (shouldLogHistoryDelegates):
1029         (runTest):
1030
1031         Dump history delegate callbacks:
1032         * DumpRenderTree/mac/HistoryDelegate.h: Added.
1033         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
1034         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
1035         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
1036         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
1037
1038 2009-09-29  Daniel Bates  <dbates@webkit.org>
1039
1040         Reviewed by Adam Roben.
1041
1042         https://bugs.webkit.org/show_bug.cgi?id=28902
1043         
1044         Fixes an issue where the drop effect returned by Window Dump Render Tree 
1045         was always DROPEFFECT_NONE (since it was hard coded to do so).
1046         
1047         This patch corrects this issue by determining the actual drop effect 
1048         performed by the corresponding drag-and-drop operation so that we can 
1049         return it.
1050
1051         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
1052         (DraggingInfo::DraggingInfo):
1053         (DraggingInfo::performedDropEffect): Added method.
1054         (DraggingInfo::setPerformedDropEffect): Added method.
1055         * DumpRenderTree/win/EventSender.cpp:
1056         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
1057         Moved delete draggingInfo to UIDelegate::doDragDrop.
1058         * DumpRenderTree/win/UIDelegate.cpp:
1059         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
1060
1061 2009-09-29  Dan Bernstein  <mitz@apple.com>
1062
1063         Reviewed by Adam Roben.
1064
1065         Remove copying of unnecessary or nonexistent files from the ImageDiff
1066         post-build event.
1067
1068         * DumpRenderTree/win/ImageDiff.vcproj:
1069
1070 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1071
1072         Reviewed by David Kilzer.
1073
1074         [Qt] Make build-webkit script work on Windows
1075         https://bugs.webkit.org/show_bug.cgi?id=29802
1076
1077         * Scripts/run-webkit-tests:
1078         * Scripts/webkitdirs.pm:
1079          - Removed unnecessary -p switch for mkdir on Windows.
1080          - Use canonical path, which uses slashes or backslashes depends on platform.
1081          - isWindows() only test for Windows and not for Cyqwin.
1082
1083 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1084
1085         Reviewed by Simon Hausmann.
1086
1087         Fix time measurement in build-webkit after refactoring done in r48853.
1088
1089         * Scripts/build-webkit:
1090
1091 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1092
1093         Reviewed by Tor Arne Vestbø.
1094
1095         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
1096         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
1097
1098         * DumpRenderTree/qt/DumpRenderTree.cpp:
1099         (WebCore::WebPage::WebPage):
1100
1101 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
1102
1103         Reviewed by Simon Hausmann.
1104
1105         [Qt] Implement eventSender.contextClick().
1106         https://bugs.webkit.org/show_bug.cgi?id=29821
1107
1108         * DumpRenderTree/qt/jsobjects.cpp:
1109         (EventSender::contextClick):
1110         * DumpRenderTree/qt/jsobjects.h:
1111
1112 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1113
1114         Reviewed by Eric Seidel.
1115
1116         Add experimentalWebSocketsEnabled in WebPreferences.
1117         https://bugs.webkit.org/show_bug.cgi?id=28941
1118
1119         * DumpRenderTree/mac/DumpRenderTree.mm:
1120         (resetDefaultsToConsistentValues):
1121         * DumpRenderTree/win/DumpRenderTree.cpp:
1122         (resetDefaultsToConsistentValues):
1123
1124 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
1125
1126         Reviewed by David Kilzer.
1127
1128         Integrated chromium port building into webkit tools update-webkit and
1129         build-webkit.
1130
1131         https://bugs.webkit.org/show_bug.cgi?id=29749
1132
1133         * Scripts/build-webkit: When --chromium is specified, will build
1134           the chromium port (currently only Mac is supported).
1135         * Scripts/update-webkit: When --chromium is specified, delegates to
1136           update-webkit-chromium.
1137         * Scripts/webkitdirs.pm: Added chromium specific defs.
1138         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
1139           chromium port's dependencies and update its project files.
1140
1141 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1142
1143         Unreviewed.
1144
1145         Add myself to list of committers.
1146
1147         * Scripts/modules/committers.py:
1148
1149 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1150
1151         Reviewed by Darin Adler.
1152
1153         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
1154         https://bugs.webkit.org/show_bug.cgi?id=29771
1155
1156         * Scripts/run-webkit-tests:
1157
1158 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1159
1160         Reviewed by Simon Hausmann.
1161
1162         [Qt] Implement layoutTestController.waitForPolicyDelegate.
1163         https://bugs.webkit.org/show_bug.cgi?id=25037
1164
1165         * DumpRenderTree/qt/DumpRenderTree.cpp:
1166         (WebCore::WebPage::acceptNavigationRequest):
1167         * DumpRenderTree/qt/DumpRenderTree.pro:
1168         * DumpRenderTree/qt/jsobjects.cpp:
1169         (LayoutTestController::reset):
1170         (LayoutTestController::notifyDone):
1171         (LayoutTestController::waitForPolicyDelegate):
1172         * DumpRenderTree/qt/jsobjects.h:
1173         (LayoutTestController::waitForPolicy):
1174
1175 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1176
1177         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
1178
1179         Reviewed by Eric Seidel.
1180
1181         The -o|--open switch uses the open(1) command on Mac OS X to
1182         open the bug URL in the default web browser.  If there are
1183         similar mechanisms on other platforms, they may be added later.
1184
1185         * Scripts/mark-bug-fixed:
1186         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
1187         options.
1188         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
1189         code into main() and extracted prompting code into
1190         _prompt_user_for_correctness().
1191         (MarkBugFixed._open_bug_in_web_browser): Added.
1192         (MarkBugFixed._prompt_user_for_correctness): Added.
1193         (MarkBugFixed.main): Added logging code from
1194         _determine_bug_id_and_svn_revision().  Added code to call
1195         _open_bug_in_web_browser() if the switch is set.  Added code to
1196         call _prompt_user_for_correctness() when needed.
1197         * Scripts/modules/bugzilla.py:
1198         (Bugzilla.short_bug_url_for_bug_id): Added.
1199
1200 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1201
1202         svn-unapply and svn-apply don't work when used outside multiple svn working directories
1203
1204         <http://webkit.org/b/29744>
1205         <rdar://problem/7252905>
1206
1207         Reviewed by Eric Seidel.
1208
1209         Some users have a workflow where svn-create-patch, svn-apply and
1210         svn-unapply are used outside of multiple svn working
1211         directories.  Instead of aborting the scripts in these cases,
1212         print a warning and assume that Subversion is being used.
1213
1214         * Scripts/VCSUtils.pm:
1215         (determineVCSRoot): Call warn() instead of die() if both isGit()
1216         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
1217         to enforce the assumption about Subversion, then return
1218         determineSVNRoot().
1219         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
1220         VCSUtils.pm.  They both already cache their values and checking
1221         here is redundant since determineVCSRoot() is called later.
1222
1223 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
1224
1225         Reviewed by Gustavo Noronha.
1226
1227         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
1228         https://bugs.webkit.org/show_bug.cgi?id=29689
1229
1230         Load test fonts through FontConfig before each test.
1231         This ensures a more proper rendering of the tests.
1232
1233         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1234         (initializeFonts):
1235         (runTest):
1236         (main):
1237         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
1238         * GNUmakefile.am:
1239
1240 2009-09-25  David Kilzer  <ddkilzer@apple.com>
1241
1242         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
1243
1244         Reviewed by Eric Seidel.
1245
1246         * Scripts/mark-bug-fixed:
1247         (MarkBugFixed.__init__): Added -u|--update-only switch to list
1248         of parse options.
1249         (MarkBugFixed.main): When -u|--update-only is specified, add a
1250         comment to the bug without marking it Resolved/Fixed.
1251
1252 2009-09-25  Darin Adler  <darin@apple.com>
1253
1254         Reviewed by Geoffrey Garen.
1255
1256         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
1257         out, just as we do for the resources directory.
1258
1259 2009-09-25  Adam Barth  <abarth@webkit.org>
1260
1261         Unreviewed.  Added Tony to committers.py because he's a
1262         committer now.
1263
1264         * Scripts/modules/committers.py:
1265
1266 2009-09-25  Eric Seidel  <eric@webkit.org>
1267
1268         Reviewed by Simon Fraser.
1269
1270         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
1271         https://bugs.webkit.org/show_bug.cgi?id=28624
1272
1273         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
1274
1275         * DumpRenderTree/mac/DumpRenderTree.mm:
1276         (resetDefaultsToConsistentValues):
1277
1278 2009-09-25  Eric Seidel  <eric@webkit.org>
1279
1280         Reviewed by Adam Barth.
1281
1282         commit-queue should auto-retry patches which fail to commit due to out of date files
1283         https://bugs.webkit.org/show_bug.cgi?id=28316
1284
1285         * Scripts/bugzilla-tool:
1286          - Handle new CheckoutNeedsUpdate exception.
1287         * Scripts/modules/logging_unittest.py:
1288          - Call the ScriptError constructor correctly (this test had regressed).
1289         * Scripts/modules/scm.py:
1290          - Added the ability to define custom error handlers for run_command
1291            and added a commit_error_handler which throws CheckoutNeedsUpdate
1292            instead of ScriptError.
1293          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
1294         * Scripts/modules/scm_unittest.py:
1295          - Added tests of new error handlers.
1296
1297 2009-09-25  Eric Seidel  <eric@webkit.org>
1298
1299         Reviewed by Adam Barth.
1300
1301         commit-queue should give better feedback when failing a patch
1302         https://bugs.webkit.org/show_bug.cgi?id=29316
1303
1304         * Scripts/bugzilla-tool:
1305          - Update ScriptError uses to the new constructor format.
1306          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
1307            so that we can print to both stdout as well as an output buffer for error reporting.
1308          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
1309          - Use e.message_with_output() when failing a patch (this is the real fix here).
1310            I also removed use of "This patch will require manual commit." as that's not always true.
1311          - Add missing word "bug" from log message.
1312         * Scripts/modules/scm.py:
1313          - Make ScriptError save a bunch more data so that error messages can be nicer.
1314          - Update ScriptError callers.
1315
1316 2009-09-24  John Gregg  <johnnyg@google.com>
1317
1318         Reviewed by Eric Seidel.
1319
1320         Enable switch for notifications (experimental) in Page Settings
1321         https://bugs.webkit.org/show_bug.cgi?id=28930
1322
1323         Now that desktop notifications are controlled by run-time switch,
1324         set that switch to true for DumpRenderTree.
1325
1326         * DumpRenderTree/mac/DumpRenderTree.mm:
1327         (resetDefaultsToConsistentValues):
1328         * DumpRenderTree/win/DumpRenderTree.cpp:
1329         (resetDefaultsToConsistentValues):
1330         * DumpRenderTree/win/UIDelegate.cpp:
1331         (UIDelegate::QueryInterface):
1332
1333 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
1334
1335         wx build fix. SnowLeopard fixes for Mac dependencies.
1336
1337         * wx/build/build_utils.py:
1338         * wx/build/settings.py:
1339         * wx/install-unix-extras:
1340
1341 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1342
1343         Reviewed by Oliver Hunt.
1344
1345         Add support for DRT to send mouse wheel events.
1346
1347         https://bugs.webkit.org/show_bug.cgi?id=29348
1348         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
1349
1350         * DumpRenderTree/gtk/EventSender.cpp:
1351         (mouseWheelToCallback):
1352
1353 2009-09-17  Eric Seidel  <eric@webkit.org>
1354
1355         Reviewed by David Levin.
1356
1357         commit-queue needs web-based status reporting
1358         https://bugs.webkit.org/show_bug.cgi?id=29307
1359
1360         Add a first-pass web-based status for the commit-queue.
1361         The bot is currently reachable at:
1362         http://webkit-commit-queue.appspot.com/
1363
1364         * CommitQueueStatus/app.yaml: Added.
1365          - Application description file required by App Engine.
1366         * CommitQueueStatus/filters/__init__.py: Added.
1367          - Required by python to treat 'filters' as a module.
1368         * CommitQueueStatus/filters/webkit_extras.py: Added.
1369          - Support for turning 'bug 123' and 'patch 123' into links.
1370            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
1371         * CommitQueueStatus/index.html: Added.
1372         * CommitQueueStatus/index.yaml: Added.
1373          - Some auto-generated file from app engine.
1374         * CommitQueueStatus/queue_status.py: Added.
1375          - The core logic of this bot.  We could eventually split this file out into pieces.
1376         * CommitQueueStatus/stylesheets/main.css: Added.
1377          - Some basic lame-o CSS to make the page look less awful.
1378         * CommitQueueStatus/update_status.html: Added.
1379          - The form that the commit-queue (or a human) can use to update the status.
1380         * Scripts/bugzilla-tool:
1381          - Add some very basic update_status calls.
1382         * Scripts/modules/statusbot.py: Added.
1383          - Knows how to post to the CommitQueueStatus web application.
1384
1385 2009-09-24  David Kilzer  <ddkilzer@apple.com>
1386
1387         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
1388
1389         Reviewed by Adam Roben.
1390
1391         * Scripts/mark-bug-fixed:
1392         (MarkBugFixed.__init__): Added -m|--comment switch to list of
1393         parse options.
1394         (MarkBugFixed.main): When specified, prepend comment from
1395         -m|--comment command-line switch to the bug comment.
1396
1397 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1398
1399         Reviewed by Jan Alonzo.
1400
1401         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
1402         https://bugs.webkit.org/show_bug.cgi?id=29693
1403
1404         Show the window, to be able to synthesize events correctly.
1405
1406         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1407         (runTest):
1408         (main):
1409
1410 2009-09-24  Oliver Hunt  <oliver@apple.com>
1411
1412         Reviewed by NOBODY(rollout)
1413
1414         Roll out r48712 as it is incorrect.
1415
1416         * DumpRenderTree/mac/ObjCController.m:
1417         (+[ObjCController isSelectorExcludedFromWebScript:]):
1418         (+[ObjCController webScriptNameForSelector:]):
1419
1420 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
1421
1422         Reviewed by Eric Seidel.
1423
1424         https://bugs.webkit.org/show_bug.cgi?id=29005
1425         The indices of RuntimeArray should be enumerated like for a regular array.
1426
1427         * DumpRenderTree/mac/ObjCController.m:
1428         (+[ObjCController isSelectorExcludedFromWebScript:]):
1429         (+[ObjCController webScriptNameForSelector:]):
1430         (-[ObjCController arrayOfString]):
1431
1432 2009-09-23  David Kilzer  <ddkilzer@apple.com>
1433
1434         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
1435
1436         Reviewed by Darin Adler.
1437
1438         Also fixed a bug where specifying a revision on the command-line
1439         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
1440
1441         * Scripts/bugzilla-tool: Updated module import statements.
1442         (parse_bug_id): Removed.  Moved to bugzilla.py.
1443         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
1444         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
1445         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
1446         (BugzillaTool.__init__): Removed mark-fixed subcommand.
1447         * Scripts/mark-bug-fixed: Added.
1448         * Scripts/modules/bugzilla.py:
1449         (parse_bug_id): Added.  Moved from bugzilla-tool.
1450         * Scripts/modules/comments.py: Added.
1451         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
1452         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
1453
1454 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
1455
1456         Reviewed by Eric Seidel.
1457         
1458          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
1459          "false" in non-implemented stub for setAlwaysAcceptCookies.
1460          https://bugs.webkit.org/show_bug.cgi?id=29661
1461
1462         * DumpRenderTree/win/DumpRenderTree.vcproj:
1463         * DumpRenderTree/win/DumpRenderTree.cpp:
1464
1465 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1466
1467         Reviewed by Xan Lopez.
1468
1469         [GTK] need to dump number of pending unload handlers
1470         https://bugs.webkit.org/show_bug.cgi?id=29685
1471
1472         Implement dumping of the number of pending unload handlers.
1473
1474         The following tests will pass:
1475
1476           fast/loader/unload-form-about-blank.html
1477           fast/loader/unload-form-post-about-blank.html
1478           fast/loader/unload-form-post.html
1479           fast/loader/unload-form.html
1480           fast/loader/unload-hyperlink.html
1481           fast/loader/unload-javascript-url.html
1482           fast/loader/unload-reload.html
1483           fast/loader/unload-window-location.html
1484
1485         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1486         (getFrameNameSuitableForTestResult):
1487         (webViewLoadFinished):
1488
1489 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
1490
1491         Reviewed by Eric Seidel.
1492
1493         js tests should move into jstests subdirectory instead of resources/
1494         https://bugs.webkit.org/show_bug.cgi?id=25880
1495
1496         Remove support of resources directory.
1497
1498         * Scripts/make-script-test-wrappers:
1499
1500 2009-09-22  Eric Seidel  <eric@webkit.org>
1501
1502         No review, only fixing typo (missing space character).
1503
1504         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
1505
1506         * Scripts/run-webkit-tests:
1507
1508 2009-09-22  Eric Seidel  <eric@webkit.org>
1509
1510         Reviewed by Darin Adler.
1511
1512         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
1513         https://bugs.webkit.org/show_bug.cgi?id=29220
1514
1515         * Scripts/run-webkit-tests:
1516
1517 2009-09-22  Eric Seidel  <eric@webkit.org>
1518
1519         Reviewed by David Kilzer.
1520
1521         svn-apply can't handle single-line binary file additions
1522         https://bugs.webkit.org/show_bug.cgi?id=29100
1523
1524         Fixed the regexp and added a unit test.
1525
1526         * Scripts/modules/scm_unittest.py:
1527         * Scripts/svn-apply:
1528
1529 2009-09-11  Eric Seidel  <eric@webkit.org>
1530
1531         Reviewed by David Kilzer.
1532
1533         post-diff and post-commits should be able to find bug urls in ChangeLogs.
1534         https://bugs.webkit.org/show_bug.cgi?id=29206
1535
1536         * Scripts/bugzilla-tool:
1537          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
1538          - Rename --no-comment to --add-log-as-comment and reverse behavior.
1539            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
1540          - Split out code into helper functions to try and make execute() more legible.
1541          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
1542          - Fallback to bug urls in commit diffs, instead of just in commit messages,
1543            meaning post-commits will now find bug urls in ChangeLogs.
1544
1545 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1546
1547         Reviewed by Maciej Stachowiak.
1548
1549         --parse-only parameter wasn't passed to SunSpider/sunspider script.
1550         https://bugs.webkit.org/show_bug.cgi?id=29611
1551
1552         * Scripts/run-sunspider: Missing parameter passing added.
1553
1554 2009-09-20  David Kilzer  <ddkilzer@apple.com>
1555
1556         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
1557
1558         Reviewed by Mark Rowe.
1559
1560         The require statement is like the use statement, except that it
1561         is run during script execution instead of during the 'BEGIN'
1562         phase.  This makes it possible to change @INC before the require
1563         statement is run.  See 'require' and 'use' in the perlfunc(1)
1564         manpage and 'BEGIN' in perlmod(1) manpage.
1565
1566         * Scripts/run-webkit-tests: Replace eval statement with require
1567         statement.
1568
1569 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
1570
1571         wx build fixes. Fix the config name under git and allow users to specify
1572         their own waf install for experimenting with new versions.
1573
1574         * Scripts/webkitdirs.pm:
1575         * wx/build/settings.py:
1576
1577 2009-09-18  Alex Milowski  <alex@milowski.com>
1578
1579         Reviewed by Maciej Stachowiak.
1580
1581         Added checkWebCoreMathMLSupport and hasMathMLSupport to support 
1582         checking for whether MathML tests should be run
1583
1584         * Scripts/run-webkit-tests:
1585         * Scripts/webkitdirs.pm:
1586
1587 2009-08-28  Darin Adler  <darin@apple.com>
1588
1589         Reviewed by Mark Rowe.
1590
1591         Break more of run-webkit-tests into separate functions
1592         https://bugs.webkit.org/show_bug.cgi?id=29497
1593
1594         Some small steps toward improving run-webkit-tests. My goal is to
1595         refactor much more of the script into functions. Later we can add
1596         parallel test running to the tool. But better structure may help
1597         even if someone decides to translate this into another scripting
1598         language instead.
1599
1600         * Scripts/run-webkit-tests: Break more pieces of the script into
1601         seprate functions. Added readSkippedFiles, findTestsToRun, and
1602         printResults functions. Removed custom code to skip results.html
1603         and instead just put it into the ignoredFiles hash. Fixed some
1604         indentation. Sorted function declarations, global variables,
1605         and options at the top of the file alphabetically so they're not
1606         in a semi-random order.
1607
1608 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
1609
1610         wx build fix, add missing dependency.
1611
1612         * wx/browser/wscript:
1613
1614 2009-09-16  Mark Rowe  <mrowe@apple.com>
1615
1616         Split the SnowLeopard build across a few machines.
1617
1618         * BuildSlaveSupport/build.webkit.org-config/config.json:
1619
1620 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
1621
1622         wx build fix to support monolithic builds on Windows.
1623
1624         * wx/build/wxpresets.py:
1625
1626 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
1627
1628         wx build fix, improve debug support and 2.9 support on MSW.
1629
1630         * wx/build/settings.py:
1631         * wx/build/wxpresets.py:
1632
1633 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1634
1635         Blind try at fixing new test failure on Windows.
1636
1637         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1638         (FrameLoadDelegate::didReceiveTitle):
1639
1640 2009-09-15  Alex Milowski  <alex@milowski.com>
1641
1642         Reviewed by Tor Arne Vestbø.
1643
1644         Added mathml toggle
1645
1646         * Scripts/build-webkit:
1647
1648 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
1649
1650         wx build fix. Allow waf build to support Python < 2.6.
1651
1652         * wx/build/waf_extensions.py:
1653
1654 2009-09-14  Chris Marrin  <cmarrin@apple.com>
1655
1656         Reviewed by Oliver Hunt.
1657
1658         Add LayoutTests infrastructure to enable and disable webgl tests.
1659         https://bugs.webkit.org/show_bug.cgi?id=29254
1660
1661         * Scripts/run-webkit-tests:
1662         * Scripts/webkitdirs.pm:
1663
1664 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
1665
1666         Reviewed by Darin Adler.
1667         
1668         Add --iterations option to run-webkit-tests to repeat the tests N times
1669         https://bugs.webkit.org/show_bug.cgi?id=29263
1670
1671         When run with --iterations N, run-webkit-tests will repeat the tests N times.
1672
1673         * Scripts/run-webkit-tests:
1674
1675 2009-09-14  Brady Eidson  <beidson@apple.com>
1676
1677         Not reviewed, maybe should've been:
1678
1679         Cleaning up more Windows-specific fallout from the fix for:
1680         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
1681
1682         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1683         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter, 
1684           and call the correct method to get the Sender.
1685
1686 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
1687
1688         GTK build fix.
1689
1690         Unreviewed.
1691
1692         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1693         (AccessibilityController::setLogScrollingStartEvents):
1694
1695 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
1696
1697         DRT/test part of
1698         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
1699         jumping to a named anchor
1700
1701         https://bugs.webkit.org/show_bug.cgi?id=28899
1702
1703         Reviewed by Adam Roben.
1704
1705         * DumpRenderTree/AccessibilityController.cpp:
1706         (logScrollingStartEventsCallback):
1707         Turn on logging of scrolling start events.
1708         (AccessibilityController::getJSClass):
1709         Add a "logScrollingStartEvents" to the AccessibilityController's JS
1710         class definition.
1711         (AccessibilityController::resetToConsistentState):
1712         Turn off logging of scrolling start events.
1713
1714         * DumpRenderTree/AccessibilityController.h:
1715         Declare setLogScrollingStartEvents(). Add a member for the scrolling
1716         start event hook.
1717
1718         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
1719         (AccessibilityController::setLogScrollingStartEvents):
1720         Stubbed.
1721
1722         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1723         (AccessibilityController::AccessibilityController):
1724         Initialize the handle to 0.
1725         (logEventProc):
1726         Renamed from logFocusEventProc; now logs scrolling start events, too.
1727         Removed the assertion that the event is a focus event. Added a switch
1728         to print a message for focus, scrolling start, and other, unknown
1729         events.
1730         (AccessibilityController::setLogFocusEvents):
1731         Changed to use logEventProc.
1732         (AccessibilityController::setLogScrollingStartEvents):
1733         If turning logging off, unhook the scrolling start event hook, and clear
1734         the member holding the handle. If turning on, query for the root
1735         accessible, so that accessibility is enabled for the WebView, and call
1736         SetWinEventHook to setup an event hook using logEventProc as the
1737         callback function.
1738
1739 2009-09-14  Brady Eidson  <beidson@apple.com>
1740
1741         Windows build fix.
1742
1743         * DumpRenderTree/LayoutTestController.cpp:
1744         (setAuthenticationPasswordCallback):
1745         (setAuthenticationUsernameCallback):
1746         
1747         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1748         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1749
1750 2009-09-14  Brady Eidson  <beidson@apple.com>
1751
1752         Reviewed by Alexey Proskuryakov.
1753
1754         Safari 4 cannot be used to update firmware on Linksys routers.
1755         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
1756
1757         Add the ability for DRT to handle authentication challenges.
1758
1759         * DumpRenderTree/LayoutTestController.cpp:
1760         (setAuthenticationPasswordCallback):
1761         (setAuthenticationUsernameCallback):
1762         (setHandlesAuthenticationChallengesCallback):
1763         (LayoutTestController::staticFunctions):
1764
1765         * DumpRenderTree/LayoutTestController.h:
1766         (LayoutTestController::handlesAuthenticationChallenges):
1767         (LayoutTestController::setHandlesAuthenticationChallenges):
1768         (LayoutTestController::authenticationUsername):
1769         (LayoutTestController::setAuthenticationUsername):
1770         (LayoutTestController::authenticationPassword):
1771         (LayoutTestController::setAuthenticationPassword):
1772
1773         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1774         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1775
1776         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1777         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1778         * DumpRenderTree/win/ResourceLoadDelegate.h:
1779
1780 2009-09-12  Mark Rowe  <mrowe@apple.com>
1781
1782         Reviewed by Dan Bernstein.
1783
1784         Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
1785
1786         Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
1787         This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
1788
1789         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1790         (NPP_New):
1791
1792 2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>
1793
1794         wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
1795
1796         * wx/build/build_utils.py:
1797         * wx/build/settings.py:
1798
1799 2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1800
1801         Reviewed by Tor Arne Vestbø.
1802
1803         [Qt] Build fix for windows build.
1804
1805         * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
1806
1807 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
1808
1809         Fix typo accidently landed in last commit.
1810
1811         * wx/build/settings.py:
1812
1813 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
1814
1815         wx build fix, error out if using the wrong Python.
1816
1817         * wx/build/settings.py:
1818
1819 2009-09-13  Xan Lopez  <xlopez@igalia.com>
1820
1821         Build fix for GTK+ < 2.14.
1822
1823         Do not use gtk_widget_get_window, access the window directly
1824         through the struct.
1825
1826         * DumpRenderTree/gtk/EventSender.cpp:
1827         (contextClickCallback):
1828         (mouseDownCallback):
1829         (mouseUpCallback):
1830         (mouseMoveToCallback):
1831         (keyDownCallback):
1832
1833 2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>
1834
1835         Reviewed by Xan Lopez and Jan Alonzo.
1836
1837         [GTK] EventSender does not set 'window' property on synthesized GDK events
1838         https://bugs.webkit.org/show_bug.cgi?id=29169
1839
1840         Set the window property on synthesized GDK events in the GTK+ EventSender.
1841
1842         * DumpRenderTree/gtk/EventSender.cpp:
1843         (contextClickCallback):
1844         (mouseDownCallback):
1845         (mouseUpCallback):
1846         (mouseMoveToCallback):
1847         (keyDownCallback):
1848
1849 2009-09-12  Drew Wilson  <atwilson@google.com>
1850
1851         Reviewed by Mark Rowe.
1852
1853         run-webkit-tests has a timeout value that is too low
1854         https://bugs.webkit.org/show_bug.cgi?id=29223
1855
1856         * Scripts/run-webkit-tests:
1857         Changed timeout value to 20 seconds to avoid timing out too early.
1858
1859 2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>
1860
1861         wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
1862         architectures are supported for building wxWebKit.
1863
1864         * wx/build/settings.py:
1865
1866 2009-09-11  Eric Seidel  <eric@webkit.org>
1867
1868         Reviewed by David Levin.
1869
1870         bugzilla-tool rollout threw exception under svn
1871         https://bugs.webkit.org/show_bug.cgi?id=29211
1872
1873         * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
1874         * Scripts/modules/scm_unittest.py: add testing for this fix.
1875
1876 2009-09-11  Brian Weinstein  <bweinstein@apple.com>
1877
1878         Add myself to the committers list.
1879
1880         * Scripts/modules/committers.py:
1881
1882 2009-09-11  Eric Seidel  <eric@webkit.org>
1883
1884         Reviewed by Adam Barth.
1885
1886         bugzilla-tool land-patches should only fail-fast in --commit-queue mode
1887         https://bugs.webkit.org/show_bug.cgi?id=29201
1888
1889         * Scripts/bugzilla-tool:
1890
1891 2009-09-11  Adam Roben  <aroben@apple.com>
1892
1893         Make commit-log-editor move common prefixes to the top of the log
1894
1895         Fies <http://webkit.org/b/29190> commit-log-editor should move common
1896         prefixes to the top of the commit log
1897
1898         Reviewed by Darin Adler.
1899
1900         * Scripts/commit-log-editor: Find and remove the longest common prefix
1901         ending in a double newline from each ChangeLog entry, then put that
1902         common prefix at the top of the commit log.
1903         (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
1904         removes, and returns the longest common prefix ending in a double
1905         newline from a hash of strings
1906
1907 2009-09-11  Eric Seidel  <eric@webkit.org>
1908
1909         Fix obvious typo in previous commit, no review.
1910
1911         bugzilla-tool should automate rollouts
1912         https://bugs.webkit.org/show_bug.cgi?id=26715
1913
1914         * Scripts/bugzilla-tool: add back missing "scm" argument.
1915
1916 2009-09-11  Eric Seidel  <eric@webkit.org>
1917
1918         Reviewed by Adam Barth.
1919
1920         bugzilla-tool should automate rollouts
1921         https://bugs.webkit.org/show_bug.cgi?id=26715
1922
1923         bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
1924         The --complete-rollout option will automatically land and update the bug.
1925         Eventually --complete-rollout will be default, but that will require more testing.
1926
1927         This first pass is good enough for others to try and file bugs about.
1928
1929         * Scripts/bugzilla-tool:
1930          - Move modified_changelogs into scm.py.
1931          - Move svn_revision_from_commit_text logic into scm.py.
1932          - Add RolloutCommit command.
1933         * Scripts/modules/bugzilla.py:
1934          - Add reopen_bug command used by RolloutCommit.
1935         * Scripts/modules/scm.py:
1936          - Add functions to support RolloutCommit.
1937          - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
1938          - Add a str() call so that svn_commit_log can take a numeric argument.
1939          - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
1940          - Made dry_run commits return something that svn_revision_from_commit_text can parse.
1941         * Scripts/modules/scm_unittest.py:
1942          - Add read_from_path for easy file reading.
1943          - Put test4 on a new line to make reverts work w/o conflict.
1944          - Add an "svn update" call so that the checkout revision matches the server revision.
1945          - Add tests for svn_revision_from_commit_text.
1946          - Add a simple test for apply_reverse_diff.
1947          - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
1948          - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
1949
1950 2009-09-11  Adam Roben  <aroben@apple.com>
1951
1952         Get user script/stylesheet tests running on Windows
1953
1954         Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
1955         skipped on Windows
1956
1957         Reviewed by John Sullivan.
1958
1959         * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
1960         against comsuppw.lib so we can use _bstr_t.
1961
1962         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
1963         order, added #include of comutil.h for _bstr_t.
1964
1965         (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
1966         (LayoutTestController::addUserScript):
1967         (LayoutTestController::addUserStyleSheet):
1968         Implemented. Implementations were based on those in
1969         LayoutTestControllerMac.mm.
1970
1971 2009-09-10  David Kilzer  <ddkilzer@apple.com>
1972
1973         <http://webkit.org/b/29147> run-webkit-tests:  make -h show help 
1974
1975         Reviewed by Mark Rowe.
1976
1977         * Scripts/run-webkit-tests: Updated to make -h switch show help.
1978
1979 2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>
1980
1981         Reviewed by Alexey Proskuryakov.
1982
1983         Add WebCore/websockets directory in wx build system.
1984         https://bugs.webkit.org/show_bug.cgi?id=28038
1985
1986         * wx/build/settings.py:
1987
1988 2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>
1989
1990         [GTK] EventSender does not properly convert some keyDown strings
1991         https://bugs.webkit.org/show_bug.cgi?id=29119
1992
1993         Add more keyDown string to character code conversions for GTK+ EventSender.
1994
1995         * DumpRenderTree/gtk/EventSender.cpp:
1996         (keyDownCallback):
1997
1998 2009-09-09  Steve Block  <steveblock@google.com>
1999
2000         Reviewed by Maciej Stachowiak.
2001
2002         Geolocation Coordinates::toString() prints bogus values for unspecified properties.
2003         https://bugs.webkit.org/show_bug.cgi?id=29080
2004
2005         * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
2006
2007 2009-09-09  Eric Seidel  <eric@webkit.org>
2008
2009         Reviewed by Eric Carlson.
2010
2011         reviewer/committer lookups are backwards
2012         https://bugs.webkit.org/show_bug.cgi?id=29113
2013
2014         I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
2015
2016         * Scripts/modules/bugzilla.py:
2017         * Scripts/modules/committers.py:
2018
2019 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
2020
2021         Reviewed by Eric Seidel.
2022
2023         svn-unapply doesn't revert directories correctly
2024         https://bugs.webkit.org/show_bug.cgi?id=29065
2025
2026         * Scripts/svn-unapply: Make svnStatus consistently return status
2027         lines including a newline.
2028         * Scripts/svn-apply: Keep svnStatus in sync with the one in
2029         svn-unapply, in lieu of moving it to a common file.
2030
2031 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
2032
2033         Reviewed by Eric Seidel.
2034
2035         svn-apply doesn't handle changes to files copied to new directories properly
2036         https://bugs.webkit.org/show_bug.cgi?id=29059
2037
2038         * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
2039         additions if we know that we've just copied a file to this name.
2040
2041 2009-09-09  Eric Seidel  <eric@webkit.org>
2042
2043         Reviewed by David Levin.
2044
2045         commit-queue hangs if a builder has never built
2046         https://bugs.webkit.org/show_bug.cgi?id=29091
2047
2048         * Scripts/modules/buildbot.py:
2049         * Scripts/modules/buildbot_unittest.py:
2050
2051 2009-09-09  Zan Dobersek  <zandobersek@gmail.com>
2052
2053         Reviewed by Gustavo Noronha.
2054
2055         [GTK] DumpRenderTree needs eventSender object and implementation
2056         https://bugs.webkit.org/show_bug.cgi?id=25990
2057
2058         Implements most of the EventSender object's functionality for
2059         the DumpRenderTree tool. Implementation still lacks support
2060         for drag and drop tests and forward leaps.
2061
2062         Based on work by Holger Hans Peter Freyther.
2063
2064         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2065         (runTest): Focus on the view before loading a new test.
2066         (webViewWindowObjectCleared):
2067         * DumpRenderTree/gtk/EventSender.cpp: Added.
2068         (getDragModeCallback):
2069         (setDragModeCallback):
2070         (leapForwardCallback):
2071         (contextClickCallback):
2072         (updateClickCount):
2073         (mouseDownCallback):
2074         (mouseUpCallback):
2075         (mouseMoveToCallback):
2076         (beginDragWithFilesCallback):
2077         (replaySavedEvents):
2078         (keyDownCallback):
2079         (textZoomInCallback):
2080         (textZoomOutCallback):
2081         (zoomPageInCallback):
2082         (zoomPageOutCallback):
2083         (getClass):
2084         (makeEventSender):
2085         * DumpRenderTree/gtk/EventSender.h: Added.
2086         * GNUmakefile.am: Add build rules for EventSender.
2087
2088 2009-09-09  Daniel Bates  <dbates@webkit.org>
2089
2090         Reviewed by Adam Roben.
2091         
2092         https://bugs.webkit.org/show_bug.cgi?id=28953
2093
2094         Added pre- and post- build events so that on build failure, the file 
2095         buildfailed is written to the directory $(WebKitOutputDir).
2096
2097         * WinLauncher/WinLauncher.vcproj:
2098
2099 2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2100
2101         Unreviewed.
2102
2103         Add myself to list of committers.
2104
2105         * Scripts/modules/committers.py:
2106
2107 2009-09-08  Eric Seidel  <eric@webkit.org>
2108
2109         Reviewed by David Levin.
2110
2111         commit-queue gets stuck if a non-committer sets commit-queue+ or review+
2112         https://bugs.webkit.org/show_bug.cgi?id=28605
2113         https://bugs.webkit.org/show_bug.cgi?id=28916
2114
2115         * Scripts/bugzilla-tool:
2116          - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
2117            comment now that it's used for rejecting patches for invalid committers too.
2118          - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
2119          - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
2120         * Scripts/modules/bugzilla.py:
2121          - Make _parse_attachment_element not validate reviewer/committer.
2122          - Share flag parsing code in _parse_attachment_flag.
2123          - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
2124          - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
2125          - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
2126         * Scripts/modules/bugzilla_unittest.py:
2127          - Update this test to no longer expect committer/reviewer validation.
2128         * Scripts/modules/committers.py:
2129          - Return None on failed lookups instead of raising Exceptions.
2130         * Scripts/modules/committers_unittest.py:
2131          - Update tests to expect None returns instead of exceptions.
2132
2133 2009-09-09  David Kilzer  <ddkilzer@apple.com>
2134
2135         <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()
2136
2137         Reviewed by Mark Rowe.
2138
2139         No change to layout test results.
2140
2141         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2142         (AccessibilityUIElement::clickPointY): Changed to return y value
2143         instead of x value.
2144
2145 2009-09-08  Dimitri Glazkov  <dglazkov@chromium.org>
2146
2147         Reviewed by Mark Rowe.
2148
2149         Reduce dglazkov's boboiness by properly concatenating revision value.
2150
2151         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
2152             rather than "+".
2153
2154 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2155
2156         wxWebKit Python extension build fix - get swig.py if it doesn't exist.
2157
2158         * wx/build/build_utils.py:
2159
2160 2009-09-08  Mark Rowe  <mrowe@apple.com>
2161
2162         Fix an incorrect variable name in UpdateChromiumSource.
2163
2164         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2165
2166 2009-09-08  Mark Rowe  <mrowe@apple.com>
2167
2168         Don't check for leaks on the release SnowLeopard builder.
2169
2170         * BuildSlaveSupport/build.webkit.org-config/config.json:
2171
2172 2009-09-08  Mark Rowe  <mrowe@apple.com>
2173
2174         Add a SnowLeopard release builder.
2175
2176         * BuildSlaveSupport/build.webkit.org-config/config.json:
2177
2178 2009-09-08  David Levin  <levin@chromium.org>
2179
2180         Reviewed by Darin Adler.
2181
2182         Remove end of line whitespace check from check-webkit-style.
2183         https://bugs.webkit.org/show_bug.cgi?id=29053
2184
2185         * Scripts/modules/cpp_style.py:
2186
2187 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2188
2189         Reviewed by Darin Adler.
2190
2191         Fix DumpRenderTree build from clean tree on Tiger
2192         https://bugs.webkit.org/show_bug.cgi?id=28927
2193
2194         * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
2195         DerivedSources/DumpRenderTree directory exists when
2196         building on Tiger.
2197
2198 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2199
2200         wx build fix after introduction of platform/mock directory.
2201
2202         * wx/build/settings.py:
2203
2204 2009-09-08  Yael Aharon  <yael.aharon@nokia.com>
2205
2206         Unreviewed.
2207
2208         Add myself to list of committers.
2209
2210         * Scripts/modules/committers.py:
2211
2212 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2213
2214         Unreviewed.
2215
2216         Add myself to list of committers.
2217
2218         * Scripts/modules/committers.py:
2219
2220 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2221
2222         Reviewed by Darin Adler.
2223
2224         prepare-ChangeLog too chatty on file additions
2225         https://bugs.webkit.org/show_bug.cgi?id=29019
2226
2227         * Scripts/prepare-ChangeLog: Omit description of added properties
2228         on newly added files.
2229
2230 2009-09-08  Steve Block  <steveblock@google.com>
2231
2232         Reviewed by Adam Barth.
2233
2234         Adds a LayoutTestController method to set the permission state for Geolocation.
2235         This is required to use the mock Geolocation service for testing.
2236         https://bugs.webkit.org/show_bug.cgi?id=29027
2237
2238         * DumpRenderTree/LayoutTestController.cpp: Modified.
2239         (setDatabaseQuotaCallback): Modified. Style fix.
2240         (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
2241         (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
2242         * DumpRenderTree/LayoutTestController.h: Modified.
2243         (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
2244         (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
2245         (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
2246         * DumpRenderTree/mac/UIDelegate.mm: Modified.
2247         (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
2248
2249 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2250
2251         Reviewed by Simon Hausmann.
2252
2253         [Qt] QtWebKit single API to enable persistency
2254         https://bugs.webkit.org/show_bug.cgi?id=28682
2255
2256         Use the new enablePersistentStorage API instead 
2257         of enabling all persistent features one-by-one.
2258
2259         * DumpRenderTree/qt/DumpRenderTree.cpp:
2260         (WebCore::WebPage::WebPage):
2261         (WebCore::DumpRenderTree::DumpRenderTree):
2262
2263 2009-09-07  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2264
2265         Reviewed by Tor Arne Vestbø.
2266
2267         Refactor --strict switch to --ignore-metrics and correct the
2268         implementation to make the feature usable on all platforms.
2269         https://bugs.webkit.org/show_bug.cgi?id=28907
2270
2271         run-webkit-tests --ignore-metrics strips the font related metrics from
2272         the actual and expected data before comparing them.
2273         In this way the render trees can be checked for obvious differences but
2274         a successful test implies by no means that the layout is actually correct.
2275
2276         * Scripts/run-webkit-tests:
2277
2278 2009-09-07  Steve Block  <steveblock@google.com>
2279
2280         Reviewed by Adam Barth.
2281
2282         Adds a mock Geolocation service. This will be used to provide predictable behavior of the
2283         Geolocation API for use in LayoutTests. Later changes will integrate the the mock
2284         Geolocation service with DumpRenderTree.
2285         https://bugs.webkit.org/show_bug.cgi?id=28264
2286
2287         * DumpRenderTree/LayoutTestController.cpp: Modified.
2288         (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service.
2289         (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service.
2290         (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
2291         * DumpRenderTree/LayoutTestController.h: Modified.
2292         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified.
2293         (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service.
2294         (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
2295
2296 2009-09-07  Drew Wilson  <atwilson@google.com>
2297
2298         Reviewed by David Levin.
2299
2300         Enable SHARED_WORKERS by default
2301         https://bugs.webkit.org/show_bug.cgi?id=28959
2302
2303         * Scripts/build-webkit:
2304
2305 2009-09-07  Kevin Ollivier  <kevino@theolliviers.com>
2306
2307         wx build fixes for wx SVN trunk.
2308
2309         * wx/build/settings.py:
2310
2311 2009-09-04  Kevin Ollivier  <kevino@theolliviers.com>
2312
2313         wx build fix. Switch USE_ defines over to the compiler so that they can be
2314         checked by files not including config.h (like WebCorePrefix.h).
2315
2316         * wx/build/settings.py:
2317
2318 2009-09-04  Adam Barth  <abarth@webkit.org>
2319
2320         Unreviewed build fix.
2321
2322         Update declaration of FrameLoadDelegate to reflect that
2323         IWebFrameLoadDelegatePrivate2 inherits from
2324         IWebFrameLoadDelegatePrivate.
2325
2326         * DumpRenderTree/win/FrameLoadDelegate.h:
2327
2328 2009-09-04  Adam Barth  <abarth@webkit.org>
2329
2330         Reviewed by Eric Seidel.
2331
2332         https://bugs.webkit.org/show_bug.cgi?id=24696
2333
2334         Add testing instrumentation for mixed content.
2335
2336         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2337         (-[FrameLoadDelegate webView:]):
2338         (-[FrameLoadDelegate webView:didRunInsecureContent:]):
2339         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2340         (descriptionSuitableForTestResult):
2341         (FrameLoadDelegate::QueryInterface):
2342         (FrameLoadDelegate::didDisplayInsecureContent):
2343         (FrameLoadDelegate::didRunInsecureContent):
2344         * DumpRenderTree/win/FrameLoadDelegate.h:
2345
2346 2009-09-03  Kevin Watters  <kevinwatters@gmail.com>
2347
2348         Reviewed by Kevin Ollivier.
2349
2350         [wx] Frames support
2351         https://bugs.webkit.org/show_bug.cgi?id=19041
2352
2353         * wx/build-wxwebkit:
2354
2355 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2356
2357         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
2358
2359         Reviewed by Eric Seidel.
2360
2361         This fixes "svn-apply --force" and adds unit tests for the
2362         scm.apply_patch() method which uses this script.
2363
2364         * Scripts/svn-apply: Created $globalExitCode variable that
2365         defaults to 0.  Exit with a value of $globalExitCode when the
2366         script is finished.
2367         (applyPatch): Ignore a non-zero $exitCode if $force is true, but
2368         set $globalExitCode to $exitCode so that svn-apply exits with a
2369         non-zero status if any patches did not apply cleanly.  Also
2370         print out the actual patch command if $force was not true.
2371
2372         * Scripts/modules/scm.py:
2373         (scripts_directory): Added.  Extracted from script_path().
2374         (script_path): Extracted scripts_directory().
2375         * Scripts/modules/scm_unittest.py: Import urllib.
2376         (SVNTestRepository.setup): Save the original working directory
2377         in test_object since this represents the WebKit repository from
2378         where the unit tests are run.
2379         (SCMTest): Created new super class to hold utility methods.
2380         (SCMTest._create_patch): Creates a patch file on disk and a
2381         dictionary for use with scm.svn_apply().
2382         (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink
2383         back to WebKitTools/Scripts in the test repository so that
2384         scm.apply_patch() is able to find the svn-apply script.
2385         (SVNTest): Inherit from SCMTest instead of unittest.TestCase.
2386         (SVNTest.tearDown): Make sure to change directories back to the
2387         original_path before the next test.
2388         (SVNTest.test_apply_svn_patch): New test case for applying an
2389         svn patch with scm.apply_patch().
2390         (SVNTest.test_apply_svn_patch_force): New test case for applying
2391         an svn patch with scm.apply_patch() that conflicts.
2392         (GitTest): Inherit from SCMTest instead of unittest.TestCase.
2393         (GitTest.tearDown): Make sure to change directories back to the
2394         original_path before the next test.
2395         (GitTest.test_apply_git_patch): New test case for applying a git
2396         patch with scm.apply_patch().
2397         (GitTest.test_apply_git_patch_force): New test case for applying
2398         a git patch with scm.apply_patch() that conflicts.
2399
2400 2009-09-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2401
2402         Reviewed by Mark Rowe.
2403
2404         [Qt] Add support for platform-spesific layout-test results
2405
2406         For the Qt port we use the qt-[mac|linux|win] directories and then fall
2407         back to the generic qt directory for both test results and skipped list.
2408
2409         * Scripts/run-webkit-tests:
2410         * Scripts/webkitdirs.pm:
2411
2412 2009-09-02  Laurent Cerveau  <lcerveau@me.com>
2413
2414         Reviewed by David Kilzer.
2415
2416         <http://webkit.org/b/25517> build-webkit script should print build time at end
2417
2418         * Scripts/build-webkit:
2419         Added startTime and endTime variable so that the build time is computed and printed as
2420         part of the build message; display formatting has been separated in a dedicated subroutine.
2421
2422 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2423
2424         <http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root
2425
2426         Reviewed by Eric Seidel.
2427
2428         * Scripts/VCSUtils.pm:
2429         (determineSvnRoot): Added back check for repository root that
2430         was removed in r46134 when this code lived in svn-create-patch.
2431         It's necessary to check both the repository root and the
2432         repository UUID in case two different working directories are
2433         checked out from the same repository.
2434
2435 2009-09-02  Timothy Hatcher  <timothy@apple.com>
2436
2437         Use new 512x512 icons for nightly builds.
2438
2439         Rubber-stamped by Mark Rowe.
2440
2441         * WebKitLauncher/webkit.icns:
2442
2443 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
2444
2445         waf build fix. Remove local variable shadowing global.
2446
2447         * wx/build/settings.py:
2448
2449 2009-09-02  Zan Dobersek  <zandobersek@gmail.com>
2450
2451         Reviewed by David Kilzer.
2452
2453         Calls exitStatus function from the main package where it is also defined.
2454
2455         * Scripts/VCSUtils.pm:
2456
2457 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
2458
2459         waf build fixes for Windows/MSVC and Mac/Snow Leopard.
2460
2461         * wx/browser/wscript:
2462         * wx/build/build_utils.py:
2463         * wx/build/settings.py:
2464
2465 2009-08-10  Kevin Ollivier  <kevino@theolliviers.com>
2466
2467         Reviewed by Eric Seidel.
2468
2469         Changes needed for build-webkit to support the waf build system for the wx port.
2470         
2471         https://bugs.webkit.org/show_bug.cgi?id=27619
2472
2473         * Scripts/build-webkit:
2474         * Scripts/run-launcher:
2475         * Scripts/webkitdirs.pm:
2476
2477 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2478
2479         <http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts
2480
2481         Reviewed by Eric Seidel.
2482
2483         * Scripts/update-webkit: Added "--accept postpone" to
2484         @svnOptions when running with svn-1.6 or newer.
2485
2486 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2487
2488         Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()
2489
2490         Reviewed by Eric Seidel.
2491
2492         * Scripts/VCSUtils.pm:
2493         (@EXPORT): Added &isSVNVersion16OrNewer.
2494         (svnVersion): Added.  Internal method that gets the SVN version
2495         and caches it.
2496         (isSVNVersion16OrNewer): Added.  Method that does the SVN 1.6
2497         version check.
2498         * Scripts/prepare-ChangeLog: Switched to use new
2499         isSVNVersion16OrNewer() method.
2500         * Scripts/resolve-ChangeLogs: Ditto.
2501         * Scripts/svn-create-patch: Ditto.
2502
2503 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2504
2505         Clean up VCSUtils.pm
2506
2507         Reviewed by Eric Seidel.
2508
2509         * Scripts/VCSUtils.pm: Added proper package statement.  Fixed
2510         indentation of BEGIN block.  Listed each exported method on a
2511         line by itself.  Added methods to the export list after adding
2512         the package statement.  Sorted module variables.  Moved
2513         definiton of $gitRoot next to other module variables.
2514
2515 2009-09-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2516
2517         Rubber-stamped by Simon Hausmann.
2518
2519         [Qt] Fix layout-test plugins/plugin-javascript-access.html
2520
2521         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2522
2523 2009-09-02  Shinichiro Hamaji  <hamaji@chromium.org>
2524
2525         Reviewed by Eric Seidel.
2526
2527         js tests should move into jstests subdirectory instead of resources/
2528         https://bugs.webkit.org/show_bug.cgi?id=25880
2529
2530         make-script-wrappers supports both resources and script-tests directories.
2531         run-webkit-tests ignores files in script-tests.
2532         Move script tests of animations to check the new script is working.
2533
2534         * Scripts/make-script-test-wrappers:
2535         * Scripts/run-webkit-tests:
2536
2537 2009-09-02  Szabo Carol  <carol.szabo@nokia.com>
2538
2539         Reviewed by David Levin.
2540
2541         check-webkit-style uses python from /usr/bin instead of the PATH
2542         https://bugs.webkit.org/show_bug.cgi?id=28225
2543
2544         * Scripts/bugzilla-tool:
2545         * Scripts/check-webkit-style:
2546         * Scripts/run-webkit-unittests:
2547         * Scripts/update-sources-list.py:
2548           Changed the first line from
2549           #!/usr/bin/python
2550           to
2551           #!/usr/bin/env python
2552           which causes python to be invoked from the path location returned
2553           by "which python" when any of these scripts are launched.
2554           these are currently all the python scripts in WebKitTools/Scripts.
2555
2556 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2557
2558         <http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards
2559
2560         Reviewed by Adam Barth.
2561
2562         * Scripts/modules/scm.py:
2563         (Git.commit_ids_from_commitish_arguments): Reverse the list of
2564         commits returned from git-rev-list since we always want to post
2565         the oldest patches first to bugs.webkit.org.
2566         * Scripts/modules/scm_unittest.py:
2567         (run): Added return statement to return the output now that we
2568         want it sometimes.
2569         (SVNTestRepository._setup_test_commits): Added a fourth commit
2570         so the GitTest.test_commitish_order() test has more commits to
2571         work with.
2572         (GitTest.test_commitish_order): Added unit test for change to
2573         Git.commit_ids_from_commitish_arguments() in scm.py.
2574
2575 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2576
2577         <http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed
2578
2579         Reviewed by David Levin.
2580
2581         The mark-fixed subcommand is for those times when you don't use
2582         bugzilla-tool to commit a patch, but you want to use it to close
2583         the bug with a committed-revision message.
2584
2585         * Scripts/bugzilla-tool:
2586         (bug_comment_from_svn_revision): Added.  Extracted from
2587         bug_comment_from_commit_text().
2588         (bug_comment_from_commit_text): Extracted
2589         bug_comment_from_svn_revision() from this method.
2590         (MarkBugFixed.__init__): Added.
2591         (MarkBugFixed._fetch_commit_log): Added.  Retrieves the commit
2592         log from the last commit if no svn revision is specified, else
2593         the commit log for the specified svn revision.
2594         (MarkBugFixed._determine_bug_id_and_svn_revision): Added.
2595         Attempts to determine the bug id and svn revision if one or both
2596         were not defined on the command line.
2597         (MarkBugFixed.execute): Added.  Adds a comment about the
2598         revision that fixed the bug and closes the bug.
2599         (BugzillaTool.__init__): Added mark-fixed subcommand.
2600         * Scripts/modules/bugzilla.py:
2601         (Bugzilla.fetch_title_from_bug): Added.  Returns the title of a
2602         bug given a bug id.
2603         * Scripts/modules/scm.py:
2604         (SCM.strip_r_from_svn_revision): Added.  Utility method to strip
2605         the leading 'r' from an svn revision.
2606         (SCM.svn_commit_log): Added.  Subclasses must override.
2607         (SCM.last_svn_commit_log): Added.  Subclasses must override.
2608         (SVN.svn_commit_log): Added.  Returns svn log for a given
2609         revision.
2610         (SVN.last_svn_commit_log): Added.  Uses svnversion to find the
2611         last commit in an svn working directory and then runs svn log.
2612         (Git.svn_commit_log): Added.  Returns svn log for a given
2613         revision.
2614         (Git.last_svn_commit_log): Added.  Runs git-svn-log with a limit
2615         of one log message.
2616
2617 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2618
2619         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
2620
2621         Reviewed by Brady Eidson.
2622
2623         * Scripts/svn-apply:
2624         (applyPatch): Add "--force" to $options arrayref if $force is
2625         set.
2626
2627 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2628
2629         <http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch
2630
2631         Reviewed by Adam Roben.
2632
2633         When git-filter-branch has been invoked to rewrite ChangeLog
2634         files on series of git commits, it changes directories into
2635         .git-rewrite/t before re-running resolve-ChangeLogs.  This
2636         causes determineVCSRoot() in VCSUtils.pm to return
2637         ".git-rewrite/t", which causes that path to be prepended to all
2638         ChangeLog paths, which results in an error like this:
2639
2640             error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git.
2641             Died at WebKitTools/Scripts/resolve-ChangeLogs line 376.
2642
2643         The correct way to fix this is not to try to find the repository
2644         root when invoked by git-filter-branch.
2645
2646         * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true,
2647         set $relativePath to '.' instead of calling
2648         chdirReturningRelativePath(determineVCSRoot()).
2649         (isInGitFilterBranch): Added.  Checks for the existence of the
2650         MAPPED_PREVIOUS_COMMIT environment variable.
2651
2652 2009-09-01  Xan Lopez  <xlopez@igalia.com>
2653
2654         Reviewed by Gustavo Noronha.
2655
2656         Add support for Fedora distros in the http tests
2657         https://bugs.webkit.org/show_bug.cgi?id=28263
2658
2659         Add detection code for Fedora distribution, and use the proper
2660         httpd conf file when needed.
2661
2662         * Scripts/run-webkit-httpd:
2663         * Scripts/run-webkit-tests:
2664         * Scripts/webkitdirs.pm:
2665
2666 2009-09-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
2667
2668         Reviewed by Eric Seidel.
2669
2670         [Gtk] DRT needs implementation of overridePreference
2671         https://bugs.webkit.org/show_bug.cgi?id=28830
2672
2673         Implement overridePreference.
2674
2675         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2676         (resetDefaultsToConsistentValues):
2677         (setDefaultsToConsistentStateValuesForTesting):
2678         (runTest):
2679         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2680         (toWebSettingKey):
2681         (LayoutTestController::overridePreference):
2682
2683 2009-09-01  Joseph Pecoraro  <joepeck@webkit.org>
2684
2685         <http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying
2686
2687         Reviewed by Eric Seidel.
2688
2689         Jump back and forth between the repository root directory (to apply) and the
2690         directory the script was run from (to find the patch).
2691
2692         * Scripts/svn-apply:
2693         * Scripts/svn-unapply:
2694
2695 2009-08-31  Adam Roben  <aroben@apple.com>
2696
2697         Fall back to a Release version of Safari if a Debug one doesn't exist
2698
2699         <http://webkit.org/b/28849>
2700
2701         Reviewed by Sam Weinig.
2702
2703         * Scripts/webkitdirs.pm:
2704         (safariPath): If the user is working with a Debug build, but there's
2705         no Debug version of Safari present, fall back to using a Release
2706         version of Safari.
2707
2708 2009-08-31  Adam Roben  <aroben@apple.com>
2709
2710         Make safariPath() work for Debug builds of Safari on Windows
2711
2712         <http://webkit.org/b/28849>
2713
2714         Reviewed by Sam Weinig.
2715
2716         * Scripts/webkitdirs.pm:
2717         (safariPath): If the user is working with a Debug build, add the
2718         _debug suffix to Safari.exe.
2719
2720 2009-08-28  Eric Seidel  <eric@webkit.org>
2721
2722         Reviewed by Adam Barth.
2723
2724         commit-queue needs a master process
2725         https://bugs.webkit.org/show_bug.cgi?id=28040
2726
2727         Add a bugzilla-tool commit-queue command
2728         Keeps per-bug logs, but doesn't yet upload them anywhere.
2729
2730         * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
2731         * Scripts/modules/buildbot.py: remove noisy log message
2732         * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python
2733
2734 2009-08-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
2735
2736         Reviewed by Gustavo Noronha.
2737
2738         [GTK] Geolocation needs permission API before being enabled by default
2739
2740         Build the Gtk port with geolocation enabled. This option is only
2741         enabled for the buildbot. The autotools option will be enabled by
2742         default once the permissions API is implemented.
2743
2744         * Scripts/build-webkit:
2745
2746 2009-08-26  Cameron McCormack  <cam@mcc.id.au>
2747
2748         Reviewed by David Kilzer.
2749
2750         Make prepare-ChangeLog notice property changes
2751         https://bugs.webkit.org/show_bug.cgi?id=28675
2752
2753         Make the generated ChangeLog entry include a short description of
2754         property changes if there were such changes.  Also make
2755         prepare-ChangeLog not bail if the only changes are property changes.
2756
2757         * Scripts/prepare-ChangeLog:
2758
2759 2009-08-26  Adam Barth  <abarth@webkit.org>
2760
2761         Reviewed by Oliver Hunt.
2762
2763         Don't let local files access web URLs
2764         https://bugs.webkit.org/show_bug.cgi?id=28480
2765
2766         A bunch of our LayoutTests rely on our old behavior, so we explicitly
2767         grant local files universal access during testing.  Mainly, these tests
2768         involve making XMLHttpRequests for data URLs.
2769
2770         * DumpRenderTree/mac/DumpRenderTree.mm:
2771         (resetDefaultsToConsistentValues):
2772         * DumpRenderTree/qt/DumpRenderTree.cpp:
2773         (WebCore::WebPage::WebPage):
2774         * DumpRenderTree/win/DumpRenderTree.cpp:
2775         (resetDefaultsToConsistentValues):
2776
2777 2009-08-26  John Gregg  <johnnyg@google.com>
2778
2779         Reviewed by David Levin.
2780
2781         Minor style correction and include fix for notifications
2782         https://bugs.webkit.org/show_bug.cgi?id=28745
2783
2784         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2785           change to correct EnumStyle
2786         (DRTDesktopNotificationPresenter::checkNotificationPermission):
2787
2788 2009-08-26  David Levin  <levin@chromium.org>
2789
2790         Reviewed by Alexey Proskuryakov.
2791
2792         XMLHttpRequest.withCredentials=false shouldn't save cookies.
2793         https://bugs.webkit.org/show_bug.cgi?id=28743
2794
2795         Added the support to the layout test controller on OSX and
2796         Windows (for CFNETWORK) to allow for changing the accept cookie
2797         policy.
2798
2799         * DumpRenderTree/LayoutTestController.cpp:
2800         (LayoutTestController::LayoutTestController): Added a bool
2801         to track the state of accepting cookies.
2802         (setAlwaysAcceptCookiesCallback): Standard wrapper method
2803         to go from js to a C++ method.
2804         (LayoutTestController::staticFunctions): Added the
2805         setAlwaysAcceptCookies method to the js layoutTestController.
2806         * DumpRenderTree/LayoutTestController.h:
2807         (LayoutTestController::alwaysAcceptCookies): Returns the value.
2808         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2809         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2810         * DumpRenderTree/mac/DumpRenderTree.mm:
2811         (resetDefaultsToConsistentValues): Reset the accept cookie to
2812         its default.
2813         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2814         (LayoutTestController::setAlwaysAcceptCookies): Does the work for
2815         OSX to change the cookie accept policy.
2816         * DumpRenderTree/win/DumpRenderTree.cpp:
2817         (setAlwaysAcceptCookies): Method to handle all the calls necessary
2818         to change the accept cookie policy on Windows.
2819         (resetDefaultsToConsistentValues): Reset the accept cookie to
2820         its default.
2821         * DumpRenderTree/win/DumpRenderTreeWin.h:
2822         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2823         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2824         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2825         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2826
2827 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2828
2829         Unreviewed.
2830
2831         Remove accidentally left in clobber option.
2832         https://bugs.webkit.org/show_bug.cgi?id=28400
2833
2834         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.
2835
2836 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2837
2838         Reviewed by Mark Rowe.
2839
2840         Add canary-style Chromium WebKit build slave to the waterfall.
2841         https://bugs.webkit.org/show_bug.cgi?id=28400
2842
2843         * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
2844         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.
2845
2846 2009-08-25  Cameron McCormack  <cam@mcc.id.au>
2847
2848         Reviewed by Darin Adler.
2849
2850         make-script-test-wrappers should be executable
2851         https://bugs.webkit.org/show_bug.cgi?id=28669
2852
2853         Make make-script-test-wrappers and update-sources-list.py both be
2854         executable.
2855
2856         * Scripts/update-sources-list.py:
2857         * Scripts/make-script-test-wrappers:
2858
2859 2009-08-25  Brent Fulgham  <bfulgham@webkit.org>
2860
2861         Build fix
2862
2863         Revise Debug_Cairo targets to point inherit from the 
2864         debug_wincairo.vsprops property sheet so that they link
2865         against the proper libraries in Debug build.
2866
2867         * DumpRenderTree/win/DumpRenderTree.vcproj:
2868         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2869         * WinLauncher/WinLauncher.vcproj:
2870
2871 2009-08-25  David Levin  <levin@chromium.org>
2872
2873         Reviewed by Adam Roben.
2874
2875         PLATFORM(CFNETWORK) should be USE(CFNETWORK).
2876         https://bugs.webkit.org/show_bug.cgi?id=28713
2877
2878         * DumpRenderTree/win/DumpRenderTree.cpp:
2879         (main):
2880
2881 2009-08-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2882
2883         Reviewed by Ariya Hidayat.
2884
2885         [Qt/Mac] Use CONFIG+=build_all only when building libraries
2886
2887         If no configuration is specified when building WebKit we pass the
2888         debug_and_release option to QMake which results in Makefiles for
2889         both configurations being generated.
2890
2891         Previously we built both of these configurations by default, for
2892         all targets (both the QtWebKit framework/dyldlib and the various
2893         executables such as QtLauncher and tests). This makes sense for
2894         the libraries, which get the _debug suffix and can be loaded on
2895         demand by setting the DYLD_IMAGE_SUFFIX, but for executables we
2896         ended up building the same executable twice.
2897
2898         We now only build one instance of each executable, and since this
2899         is a developer build we build the debug-version. Passing either
2900         --debug or --release to build-webkit will override this, and
2901         even in the default case the release version can still be built
2902         by running 'make release' in the the build directory of each
2903         target.
2904
2905         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2906         * Scripts/webkitdirs.pm:
2907
2908 2009-08-24  Hironori Bono  <hbono@chromium.org>
2909
2910         Reviewed by Adam Barth.
2911
2912         Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
2913         <https://bugs.webkit.org/show_bug.cgi?id=27827>.
2914
2915         Because of the lack of mappings from GDK key-codes to WebKit key-codes,
2916         Chromium cannot send valid key-codes to JavaScript when a user types
2917         function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.
2918
2919         To write layout tests for this issue, added mappings from function-key
2920         names to platform-specific key-codes to EventSendingController objects
2921         so that eventSender.keyDown() can send function-key events without using
2922         platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
2923         is only for Mac. So this change adds this new test to Skipped tests for other
2924         platforms to prevent this change from crashing the build trees.)
2925
2926         * DumpRenderTree/mac/EventSendingController.mm:
2927         (-[EventSendingController keyDown:withModifiers:]):
2928
2929 2009-08-23  Jan Michael Alonzo  <jmalonzo@webkit.org>
2930
2931         Reviewed by Xan Lopez.
2932
2933         [Gtk] API for disabling local file access to web URLs
2934         https://bugs.webkit.org/show_bug.cgi?id=28663
2935
2936         Enable this setting for DRT.
2937
2938         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2939         (resetWebViewToConsistentStateBeforeTesting):
2940
2941 2009-08-22  Adam Barth  <abarth@webkit.org>
2942
2943         Revert 47684.  We're going to do this later once clients have had a
2944         chance to opt into the setting they like.
2945
2946         * DumpRenderTree/mac/DumpRenderTree.mm:
2947         (resetDefaultsToConsistentValues):
2948         * DumpRenderTree/qt/DumpRenderTree.cpp:
2949         (WebCore::WebPage::WebPage):
2950         * DumpRenderTree/win/DumpRenderTree.cpp:
2951         (resetDefaultsToConsistentValues):
2952
2953 2009-08-22  Adam Barth  <abarth@webkit.org>
2954
2955         Reviewed by Eric Seidel.
2956
2957         Don't let local files access web URLs
2958         https://bugs.webkit.org/show_bug.cgi?id=28480
2959
2960         A bunch of our LayoutTests rely on our old behavior, so we explicitly
2961         grant local files universal access during testing.  Mainly, these tests
2962         involve making XMLHttpRequests for data URLs.
2963
2964         * DumpRenderTree/mac/DumpRenderTree.mm:
2965         (resetDefaultsToConsistentValues):
2966         * DumpRenderTree/qt/DumpRenderTree.cpp:
2967         (WebCore::WebPage::WebPage):
2968         * DumpRenderTree/win/DumpRenderTree.cpp:
2969         (resetDefaultsToConsistentValues):
2970
2971 2009-08-22  Mark Rowe  <mrowe@apple.com>
2972
2973         Rubber-stamped by Anders Carlsson.
2974
2975         Bring signed updates to the Mac nightly builds.
2976
2977         * WebKitLauncher/Info.plist:
2978         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2979         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2980         (initializeSparkle):
2981         * WebKitLauncher/nightly.webkit.org.public.pem: Added.
2982
2983 2009-08-21  Jan Michael Alonzo  <jmalonzo@webkit.org>
2984
2985         Rubberstamped by Simon Fraser.
2986
2987         Remove GNOME keyring support in build-webkit. This dependency's
2988         already been removed in the Gtk port.
2989
2990         * Scripts/build-webkit:
2991
2992 2009-08-20  Brian Weinstein  <bweinstein@apple.com>
2993
2994         Reviewed by Adam Roben.
2995         Based on original patch by Stephanie Lewis.
2996
2997         Added support of the Windows malloc history format to parse-malloc history, so we can
2998         read and parse it.
2999
3000         * Scripts/parse-malloc-history:
3001
3002 2009-08-20  Chris Fleizach  <cfleizach@apple.com>
3003
3004         Reviewed by Darin Adler.
3005
3006         Enable various "grouping" ARIA roles
3007         https://bugs.webkit.org/show_bug.cgi?id=28486
3008
3009         Expose the ability to retrieve the subrole through accessibility for DRT.
3010
3011         * DumpRenderTree/AccessibilityUIElement.cpp:
3012         * DumpRenderTree/AccessibilityUIElement.h:
3013         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3014         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3015         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3016
3017 2009-08-20  Joseph Pecoraro  <joepeck@webkit.org>
3018
3019         Unreviewed.
3020
3021         Added myself as a committer.
3022
3023         * Scripts/modules/committers.py:
3024
3025 2009-08-20  Xan Lopez  <xlopez@igalia.com>
3026
3027         Reviewed by Gustavo Noronha.
3028
3029         Fix memory leaks.
3030
3031         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3032         (LayoutTestController::whiteListAccessFromOrigin):
3033         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3034         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3035
3036 2009-08-20  Eric Seidel  <eric@webkit.org>
3037
3038         Reviewed by Adam Barth.
3039
3040         bugzilla-tool post-diff can post partial diffs from SVN checkouts.
3041         https://bugs.webkit.org/show_bug.cgi?id=28445
3042
3043         Pass the checkout root as the cwd.  Also wrote a test to ensure this.
3044
3045         * Scripts/modules/scm.py:
3046         * Scripts/modules/scm_unittest.py:
3047
3048 2009-08-20  Mark Rowe  <mrowe@apple.com>
3049
3050         Reviewed by Adele Peterson.
3051
3052         Don't leak the JSStringRef returned by AccessibilityUIElement::attributeValue.
3053
3054         * DumpRenderTree/AccessibilityUIElement.cpp:
3055         (attributeValueCallback):
3056
3057 2009-08-20  Ariya Hidayat  <ariya.hidayat@nokia.com>
3058
3059         Unreviewed, build fix.
3060
3061         [Qt] The template-based qMax() compares two qreals.
3062
3063         * DumpRenderTree/qt/ImageDiff.cpp:
3064         (main):
3065
3066 2009-08-20  David Levin  <levin@chromium.org>
3067
3068         Reviewed by David Kilzer.
3069
3070         bugzilla-tool patch retrieval should handle 302 redirects.
3071         https://bugs.webkit.org/show_bug.cgi?id=28485
3072
3073         * Scripts/modules/scm.py: Pass the --location parameter to curl
3074         so that 302's are followed.
3075
3076 2009-08-20  Aaron Boodman  <aa@chromium.org>
3077
3078         One more speculative build for gtk.
3079
3080         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3081
3082 2009-08-20  Aaron Boodman  <aa@chromium.org>
3083
3084         Speculative build for gtk.
3085
3086         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3087         (LayoutTestController::whiteListAccessFromOrigin):
3088
3089 2009-08-20  Mark Rowe  <mrowe@apple.com>
3090
3091         Ignore some leaks that are known to originate from ImageIO.
3092
3093         * Scripts/run-webkit-tests:
3094
3095 2009-08-20  Aaron Boodman  <aa@chromium.org>
3096
3097         With David Levin.
3098
3099         Speculative build fix for qt.
3100
3101         * DumpRenderTree/qt/jsobjects.cpp:
3102         (LayoutTestController::whiteListAccessFromOrigin):
3103         * DumpRenderTree/qt/jsobjects.h:
3104
3105 2009-08-19  Mark Rowe  <mrowe@apple.com>
3106
3107         Reviewed by Dan Bernstein.
3108
3109         Fix <http://webkit.org/b/28484> Plug-in-related leaks seen on the build bot
3110
3111         Update check-for-global-initializers to accommodate the new uses of RefCountedLeakCounter in WebKit.
3112
3113         * Scripts/check-for-global-initializers:
3114
3115 2009-08-19  Aaron Boodman  <aa@chromium.org>
3116
3117         Reviewed by David Levin.
3118
3119         https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
3120         specify a more granular policy for cross-origin XHR access.
3121
3122         * DumpRenderTree/LayoutTestController.cpp: Expose whiteListAccessFromOrigin() to layout tests.
3123         (whiteListAccessFromOriginCallback): Ditto.
3124         (LayoutTestController::staticFunctions): Ditto.
3125         * DumpRenderTree/LayoutTestController.h: Ditto.
3126         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
3127         (LayoutTestController::whiteListAccessToOrigin): Ditto.
3128         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
3129         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
3130         * DumpRenderTree/qt/jsobjects.cpp: Ditto.
3131         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
3132         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Stub out whiteListAccessFromOrigin().
3133         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
3134         * DumpRenderTree/gtk/DumpRenderTree.cpp: Reset origin access lists before each test.
3135         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3136         * DumpRenderTree/mac/DumpRenderTree.mm: Ditto.
3137         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3138         * DumpRenderTree/qt/DumpRenderTree.cpp: Ditto.
3139         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Ditto.
3140
3141 2009-08-19  Mark Rowe  <mrowe@apple.com>
3142
3143         Rubber-stamped by Dan Bernstein.
3144
3145         Ignore some leaks that are known to originate from QTKit.
3146
3147         * Scripts/run-webkit-tests:
3148
3149 2009-08-19  Eric Seidel  <eric@webkit.org>
3150
3151         Reviewed by Adam Barth.
3152
3153         commit-queue/bugzilla-tool can get wedged if git is mid-rebase
3154         https://bugs.webkit.org/show_bug.cgi?id=28436
3155
3156         Make clean_working_directory cancel rebases too (even though that's a bit of a hack).
3157         This code will only ever be run when --force-clean is passed.
3158
3159         I also added a new unit test to make sure this code actually works. :)
3160
3161         * Scripts/modules/scm.py:
3162         * Scripts/modules/scm_unittest.py:
3163
3164 2009-08-19  Eric Seidel  <eric@webkit.org>
3165
3166         Reviewed by David Levin.
3167
3168         WebKit needs a changelogs.py to hold changelog-related code
3169         https://bugs.webkit.org/show_bug.cgi?id=28477
3170
3171         This is moving code and adding tests.  There was only one functional
3172         change (which was removing a trailing newline from the last_entry() result).
3173
3174         * Scripts/bugzilla-tool:
3175         * Scripts/modules/changelogs.py: Added.
3176         * Scripts/modules/changelogs_unittest.py: Added.
3177         * Scripts/run-webkit-unittests:
3178
3179 2009-08-20  Eric Seidel  <eric@webkit.org>
3180
3181         Reviewed by Adam Barth.
3182
3183         bugzilla-tool needs a way to ask build.webkit.org if the bots are passing
3184         https://bugs.webkit.org/show_bug.cgi?id=28222
3185
3186         Basic support for now.  This has been in testing for 24 hours now and worked great!
3187
3188         * Scripts/bugzilla-tool:
3189         * Scripts/modules/buildbot.py: Added.
3190         * Scripts/modules/buildbot_unittest.py: Added.
3191         * Scripts/run-webkit-unittests:
3192
3193 2009-08-19  Jan Michael Alonzo  <jmalonzo@webkit.org>
3194
3195         Reviewed by Gustavo Noronha.
3196
3197         [Gtk] Bump waitToDumpWatchdog interval to 15 seconds to match the
3198         default timeout used by run-webkit-tests. Mac and Win ports were
3199         recently bumped in http://trac.webkit.org/changeset/r47465.
3200
3201         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3202         (LayoutTestController::setWaitToDump):
3203
3204 2009-08-19  David D. Kilzer  <ddkilzer@webkit.org>
3205
3206         DumpRenderTreeSupport.pm: provide pre-generated swig source for Tiger
3207
3208         Reviewed by Mark Rowe.
3209
3210         Provide pre-generated swig source files for Tiger so it may
3211         benefit from the faster run-webkit-tests.
3212
3213         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm:
3214         Generated by swig.
3215         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c: Added.
3216         Generated by swig.
3217         (swig_type_info::SWIG_TypeNameComp):
3218         (swig_type_info::SWIG_TypeEquiv):
3219         (swig_type_info::SWIG_TypeRegisterTL):
3220         (swig_type_info::SWIG_TypeCheck):
3221         (swig_type_info::SWIG_TypeCast):
3222         (swig_type_info::SWIG_TypeDynamicCast):
3223         (swig_type_info::SWIG_TypeName):
3224         (swig_type_info::SWIG_TypePrettyName):
3225         (swig_type_info::SWIG_TypeQueryTL):
3226         (swig_type_info::SWIG_TypeClientDataTL):
3227         (swig_type_info::SWIG_PackData):
3228         (swig_type_info::SWIG_UnpackData):
3229         (swig_type_info::SWIG_PropagateClientDataTL):
3230         (swig_type_info::SWIG_PackVoidPtr):
3231         (swig_type_info::SWIG_UnpackVoidPtr):
3232         (swig_type_info::SWIG_PackDataName):
3233         (swig_type_info::SWIG_UnpackDataName):
3234         * DumpRenderTree/mac/PerlSupport/Makefile: Updated to build on
3235         Tiger using pre-generated files.
3236
3237 2009-08-18  Shinichiro Hamaji  <hamaji@chromium.org>
3238
3239         Reviewed by David Kilzer.
3240
3241         run-webkit-tests hangs when WebCore tries to log too much
3242         https://bugs.webkit.org/show_bug.cgi?id=15743
3243
3244         Read stdout and stderr in parallel.
3245
3246         * Scripts/run-webkit-tests:
3247
3248 2009-08-18  Mark Rowe  <mrowe@apple.com>
3249
3250         Rubber-stamped by Oliver Hunt.
3251
3252         Add a new build configuration that checks for leaks during the layout tests,
3253         and hook a new machine up to it.
3254
3255         * BuildSlaveSupport/build.webkit.org-config/config.json:
3256         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3257
3258 2009-08-18  Aaron Boodman  <aa@chromium.org>
3259
3260         Reviewed by Maciej Stachowiak.
3261
3262         https://bugs.webkit.org/show_bug.cgi?id=28412: Leak of WebCore::XMLHttpRequest object during layout tests.
3263
3264         No new tests: Already covered by existing tests.
3265
3266         * Scripts/check-for-global-initializers: Allow global initialization of WTF::RefCountedLeakCounter for XMLHttpRequest.
3267
3268 2009-08-18  Mark Rowe  <mrowe@apple.com>
3269
3270         Rubber-stamped by Geoff Garen.
3271
3272         Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests.
3273
3274         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3275         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3276
3277 2009-08-18  Brian Weinstein  <bweinstein@apple.com>
3278
3279         Rubber-stamped by Adam Roben.
3280
3281         Changed use of CComBSTR in exceededDatabaseQuota to BSTRs, and free them,
3282         and removed include to fix building on VC++ Express.
3283
3284         * DumpRenderTree/win/UIDelegate.cpp:
3285         (UIDelegate::exceededDatabaseQuota):
3286
3287 2009-08-18  Brian Weinstein  <bweinstein@apple.com>
3288
3289         Reviewed by Oliver Hunt.
3290
3291         Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support 
3292         LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
3293         
3294         Implemenent setDatabaseQuota and added a new function to the IWebDatabaseManager interface.
3295         Also added a console output on UIDelegate::exceededDatabaseQuota to match the mac.
3296
3297         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3298         (LayoutTestController::setDatabaseQuota):
3299         * DumpRenderTree/win/UIDelegate.cpp:
3300         (UIDelegate::exceededDatabaseQuota):
3301
3302 2009-08-18  Peter Kasting  <pkasting@google.com>
3303
3304         Reviewed by Eric Seidel.
3305
3306         https://bugs.webkit.org/show_bug.cgi?id=28415
3307         Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
3308         have it.
3309
3310         * record-memory-win/record-memory-win.vcproj:
3311         * WinLauncher/WinLauncher.vcproj:
3312         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3313         * DumpRenderTree/win/ImageDiff.vcproj:
3314         * FindSafari/FindSafari.vcproj:
3315
3316 2009-08-18  Drew Wilson  <atwilson@google.com>
3317
3318         Reviewed by Eric Seidel.
3319
3320         Need to extend DumpRenderTree to expose number of worker threads
3321         https://bugs.webkit.org/show_bug.cgi?id=28292
3322
3323         Added layoutTestController.workerThreadCount, and implementations on various platforms that call into WebKit.
3324
3325         * DumpRenderTree/LayoutTestController.cpp:
3326         (getWorkerThreadCountCallback):
3327         (LayoutTestController::staticValues):
3328         * DumpRenderTree/LayoutTestController.h:
3329         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3330         (LayoutTestController::workerThreadCount):
3331         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3332         (LayoutTestController::workerThreadCount):
3333         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3334         (LayoutTestController::workerThreadCount):
3335         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3336         (LayoutTestController::workerThreadCount):
3337
3338 2009-08-18  Xan Lopez  <xlopez@igalia.com>
3339
3340         Reviewed by Jan Alonzo.
3341
3342         Initialize x and y in the GtkAllocation structure to shut up
3343         valgrind.
3344
3345         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3346         (runTest):
3347
3348 2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>
3349
3350         Reviewed by Darin Adler.
3351
3352         Some HTMLs are modified by make-script-test-wrappers
3353         https://bugs.webkit.org/show_bug.cgi?id=28213
3354
3355         Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
3356         the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
3357         re-generated wml/* and Geolocation/* .
3358
3359         * Scripts/make-script-test-wrappers:
3360
3361 2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>
3362
3363         Reviewed by Eric Seidel.
3364
3365         -webkit-box-orient:horizontal doesn't work on <button> tag
3366         https://bugs.webkit.org/show_bug.cgi?id=34445
3367
3368         Make a flexible button's anonymous child flexible and pass the
3369         parent's box-orient to the anonymous child.
3370
3371         Also, added a renderName for anonymous flexible boxes.
3372
3373         * Scripts/make-script-test-wrappers:
3374
3375 2009-08-17  Eric Seidel  <eric@webkit.org>
3376
3377         Reviewed by Darin Adler.
3378
3379         Can no longer --reset-results of a layout test directory
3380         https://bugs.webkit.org/show_bug.cgi?id=28336
3381
3382         --reset-results and --exit-after-n-failures are incompatible.
3383
3384         * Scripts/run-webkit-tests:
3385
3386 2009-08-17  David Kilzer  <ddkilzer@apple.com>
3387
3388         <http://webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit comment from git
3389
3390         Reviewed by Adam Roben.
3391
3392         New commit message:
3393             Committed r12345: <http://trac.webkit.org/changeset/12345>
3394
3395         * Scripts/bugzilla-tool:
3396         (bug_comment_from_commit_text): Print out a compact,
3397         standardized commit message for both git and svn.
3398
3399 2009-08-17  Peter Kasting  <pkasting@google.com>
3400
3401         Reviewed by Steve Falkenburg.
3402
3403         https://bugs.webkit.org/show_bug.cgi?id=27323
3404         Only add Cygwin to the path when it isn't already there.  This avoids
3405         causing problems for people who purposefully have non-Cygwin versions of
3406         executables like svn in front of the Cygwin ones in their paths.
3407
3408         * DumpRenderTree/win/DumpRenderTree.vcproj:
3409         * DumpRenderTree/win/ImageDiff.vcproj:
3410         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3411
3412 2009-08-17  David Kilzer  <ddkilzer@apple.com>
3413
3414         <http://webkit.org/b/28393> check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()
3415
3416         Reviewed by David Levin.
3417
3418         * Scripts/modules/cpp_style.py:
3419         (_ERROR_CATEGORIES): Added 'runtime/max_min_macros'.
3420         (check_max_min_macros): Added.  Returns level 4 error when MAX()
3421         and MIN() macros are used in header files and C++ source files.
3422         (check_style): Added call to check_max_min_macros().
3423         * Scripts/modules/cpp_style_unittest.py: Added unit tests.
3424         (test_max_macro): Added.
3425         (test_min_macro): Added.
3426
3427 2009-08-13  Mike Fenton  <mike.fenton@torchmobile.com>
3428
3429         Reviewed by Eric Seidel.
3430
3431         Move adjustLineToPixelBoundaries overlapping function to GraphicsContext.cpp
3432         and remove from GraphicsContextCairo.cpp and GraphicsContextQt.cpp.
3433
3434         https://bugs.webkit.org/show_bug.cgi?id=28268
3435
3436         * platform/graphics/GraphicsContext.cpp:
3437         (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
3438         * platform/graphics/GraphicsContext.h:
3439         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3440         * platform/graphics/qt/GraphicsContextQt.cpp:
3441
3442 2009-08-10  Mike Fenton  <mike.fenton@torchmobile.com>
3443
3444         Reviewed by Adam Treat.
3445
3446         Style fixes for DumpRenderTree/qt/jsobjects.cpp based on cpp_style.py and
3447         WebKit style guide.
3448
3449         https://bugs.webkit.org/show_bug.cgi?id=28161
3450
3451         * DumpRenderTree/qt/jsobjects.cpp:
3452         (findFrameNamed):
3453         (LoadItem::invoke):
3454         (LayoutTestController::provisionalLoad):
3455         (LayoutTestController::timerEvent):
3456         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3457         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3458         (LayoutTestController::numberOfActiveAnimations):
3459         (EventSender::keyDown):
3460         (EventSender::frameUnderMouse):
3461         (TextInputController::doCommand):
3462
3463 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3464
3465         <http://webkit.org/b/28370> check-webkit-style: add check for 'using std::foo;' statements
3466
3467         Reviewed by David Levin.
3468
3469         In <http://webkit.org/b/28355#c1>, it was noted that new source
3470         files use 'using namespace std;' instead of individual
3471         'using std::foo;' statements.  This adds a level 4 check for
3472         such statements.
3473
3474         * Scripts/modules/cpp_style.py:
3475         (_ERROR_CATEGORIES): Added 'build/using_std'.
3476         (check_using_std): Added.
3477         (check_style): Added call to check_using_std().
3478         * Scripts/modules/cpp_style_unittest.py:
3479         (WebKitStyleTest.test_using_std): Added unit test.
3480
3481 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3482
3483         Backed out r47343 which was mistakenly committed
3484
3485         * Scripts/bugzilla-tool:
3486         * Scripts/modules/scm.py:
3487
3488 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3489
3490         <http://webkit.org/b/28367> bugzilla.py: replace ScriptError class with BugzillaError class
3491
3492         Reviewed by David Levin.
3493
3494         The ScriptError class doesn't exist in bugzilla.py, so any
3495         errors print error messages about ScriptError instead of the
3496         actual error:
3497
3498             NameError: global name 'ScriptError' is not defined
3499
3500         * Scripts/modules/bugzilla.py:
3501         (BugzillaError): Added class.  Modeled after ScriptError class
3502         in scm.py.
3503         (Bugzilla.authenticate): Changed to use BugzillaError instead of
3504         ScriptError.
3505         (Bugzilla._check_create_bug_response): Ditto.
3506
3507 2009-08-14  Adam Bergkvist  <adam.bergkvist@ericsson.com>
3508
3509         Reviewed by Sam Weinig.
3510
3511         Added EventSource to the build script (default on).
3512         https://bugs.webkit.org/show_bug.cgi?id=14997 
3513
3514         * Scripts/build-webkit:
3515
3516 2009-08-15  Ryosuke Niwa  <rniwa@webkit.org>
3517
3518         Unreviewed.
3519
3520         Add myself to list of committers.
3521
3522         * Scripts/modules/committers.py:
3523
3524 2009-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
3525
3526         Fix layout test failures after r47312.
3527
3528         Reviewed by Cameron Zwarich.
3529
3530         * DumpRenderTree/AccessibilityController.h:
3531         Replaced logFocusEvents() with setLogFocusEvents(), which takes a
3532         boolean argument to turn logging of focus events on or off.
3533         Added a function to reset the AccessibilityController to a consistent
3534         state.
3535
3536         * DumpRenderTree/AccessibilityController.cpp:
3537         (logFocusEventsCallback):
3538         Call setLogFocusEvents() to enable logging.
3539         (AccessibilityController::resetToConsistentState):
3540         Call setLogFocusEvents() to disable logging.
3541
3542         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3543         (AccessibilityController::setLogFocusEvents):
3544         Update stub.
3545
3546         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3547         (AccessibilityController::setLogFocusEvents):
3548         Update stub.
3549
3550         * DumpRenderTree/mac/DumpRenderTree.mm:
3551         (resetWebViewToConsistentStateBeforeTesting):
3552         Call the FrameLoadDelegate's resetToConsistentState method.
3553
3554         * DumpRenderTree/mac/FrameLoadDelegate.h:
3555         Declare the resetToConsistentState method.
3556
3557         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3558         (-[FrameLoadDelegate resetToConsistentState]):
3559         Call the AccessibilityController's resetToConsistentState() function.
3560
3561         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3562         (AccessibilityController::~AccessibilityController):
3563         Turn off focus event logging when the controller is destroyed.
3564         (AccessibilityController::setLogFocusEvents):
3565         If the caller passes false, unhook the focus event, and clear
3566         m_focusEventHook.
3567
3568         * DumpRenderTree/win/DumpRenderTree.cpp:
3569         (resetWebViewToConsistentStateBeforeTesting):
3570         Call the FrameLoadDelegate's resetToConsistentState function.
3571
3572         * DumpRenderTree/win/FrameLoadDelegate.h:
3573         Declare the resetToConsistentState() function.
3574
3575         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3576         (FrameLoadDelegate::resetToConsistentState):
3577         Call the AccessibilityController's resetToConsistentState() function.
3578
3579
3580 2009-08-14  Jon Honeycutt  <jhoneycutt@apple.com>
3581
3582         Add a mechanism for logging MSAA focus events.
3583
3584         Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
3585         nightly (20866)
3586
3587         https://bugs.webkit.org/show_bug.cgi?id=20866
3588
3589         Reviewed by Oliver Hunt.
3590
3591         * DumpRenderTree/AccessibilityController.cpp:
3592         (logFocusEventsCallback):
3593         Call the AccessibilityController's logFocusEvents() function.
3594         (AccessibilityController::getJSClass):
3595         Add a "logFocusEvents" function to the AccessibilityController's JS
3596         class definition.
3597
3598         * DumpRenderTree/AccessibilityController.h:
3599         On Windows, include windows.h, and add a member variable to hold the
3600         handle to the event hook for focus events. Add a declaration for a
3601         function that enables logging of focus events.
3602
3603         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3604         (AccessibilityController::logFocusEvents):
3605         Stubbed.
3606
3607         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3608         (AccessibilityController::logFocusEvents):
3609         Stubbed.
3610
3611         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3612         (AccessibilityController::AccessibilityController):
3613         (AccessibilityController::~AccessibilityController):
3614         If we hooked the focus event, unhook it.
3615         (logFocusEventProc):
3616         When we receive a focus event, get the accessible object for the event,
3617         and log its name to stdout.
3618         (AccessibilityController::logFocusEvents):
3619         Setup the focus event hook to listen for events in the current process.
3620
3621 2009-08-14  Eric Seidel  <eric@webkit.org>
3622
3623         No review.  Fix 5-space indent to be 4-spaces.
3624
3625         * Scripts/bugzilla-tool:
3626
3627 2009-08-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3628
3629         Reviewed by Simon Hausmann.
3630
3631         [Qt] Public API to configure the storage path for HTML5 localStorage
3632         https://bugs.webkit.org/show_bug.cgi?id=28036
3633
3634         Turn on LocalStorage support for Qt DumpRenderTree since
3635         LocalStorage is now disabled by defult for QtWebkit.
3636
3637         * DumpRenderTree/qt/DumpRenderTree.cpp: 
3638         (WebCore::WebPage::WebPage):
3639
3640 2009-08-14  Xan Lopez  <xlopez@igalia.com>
3641
3642         Reviewed by Jan Alonzo.
3643
3644         Do not unref the main webview, it's owned by its parent
3645         container. Instead destroy the container, which should take care
3646         of everything (not terribly important since we exit right after
3647         that, but still).
3648
3649         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3650         (main):
3651
3652 2009-08-13  Eric Seidel  <eric@webkit.org>
3653
3654         No review, correcting obvious python error seen in the commit queue.
3655
3656         args can be a string or an array.  Assuming args is always an array results in
3657         double-spaced text in error logs.
3658
3659         * Scripts/bugzilla-tool:
3660
3661 2009-08-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3662
3663         Unreviewed build fix. Include stdio.h for using stdout, stderr,
3664         and fprintf.
3665
3666         * DumpRenderTree/LayoutTestController.cpp:
3667
3668 2009-08-13  Shinichiro Hamaji  <hamaji@chromium.org>
3669
3670         Reviewed by Eric Seidel.
3671
3672         rename make-js-test-wrappers to make-script-test-wrappers
3673         https://bugs.webkit.org/show_bug.cgi?id=28212
3674
3675         * Scripts/make-script-test-wrappers: Renamed from WebKitTools/Scripts/make-js-test-wrappers.
3676
3677 2009-08-13  Drew Wilson <atwilson@chromium.org>
3678
3679         Unreviewed.
3680
3681         Add myself to list of committers.
3682
3683         * Scripts/modules/committers.py:
3684
3685 2009-08-13  John Sullivan  <sullivan@apple.com>
3686
3687         Unreviewed.
3688
3689         Add myself to list of committers.
3690
3691         * Scripts/modules/committers.py:
3692
3693 2009-08-13  Eric Seidel  <eric@webkit.org>
3694
3695         Correct spelling error in file name.  No review.
3696
3697         * Scripts/modules/committers_unittest.py: Renamed from WebKitTools/Scripts/modules/commiters_unittest.py.
3698         * Scripts/run-webkit-unittests:
3699
3700 2009-08-13  Eric Seidel  <eric@webkit.org>
3701
3702         Reviewed by Simon Fraser.
3703
3704         REGRESSION(r47175): error running run-webkit-tests
3705         https://bugs.webkit.org/show_bug.cgi?id=28261
3706
3707         Fix "Use of uninitialized value in concatenation (.) or string at
3708         WebKitTools/Scripts/run-webkit-tests line 191." by setting
3709         $testsPerDumpTool to 1000 by default.
3710
3711         * Scripts/run-webkit-tests:
3712
3713 2009-08-13  Nate Chapin  <japhet@chromium.org>
3714
3715         Unreviewed.
3716
3717         Add myself to list of committers.
3718
3719         * Scripts/modules/committers.py:
3720
3721 2009-08-13  Brent Fulgham  <bfulgham@webkit.org>
3722
3723         Unreviewed.
3724
3725         Add 'Brent Fulgham' to the committers list.
3726
3727         * Scripts/modules/committers.py:
3728
3729 2009-08-13  Adam Langley  <agl@chromium.org>
3730
3731         Review not required.
3732
3733         * Scripts/modules/committers.py:
3734           Adding myself to this list because Eric told me to.
3735
3736 2009-08-13  Greg Bolsinga  <bolsinga@apple.com>
3737
3738         Unreviewed.
3739
3740         Add 'Greg Bolsinga' to the committers list.
3741
3742         * Scripts/modules/committers.py:
3743
3744 2009-08-13  Adam Roben  <aroben@apple.com>
3745
3746         Fix off-by-one result comparisons in media tests on Windows Debug
3747         builds
3748
3749         media/video-played.html seems always to time out in Windows Debug
3750         builds. A race condition between media/video-test.js's "hang" timer and
3751         DumpRenderTree's built-in "watchdog" timer was causing results for
3752         media/video-played.html to be printed twice, causing all future media
3753         tests to be compared to the previous test's results.
3754
3755         The fix is to make the watchdog timer got through the same code path
3756         as calling notifyDone manually, so that the results will only get
3757         printed once. A subsequent patch will remove video-test.js's hang
3758         timer entirely, since it is redundant.
3759
3760         Fixes <http://webkit.org/b/28265>.
3761
3762         Reviewed by Mark Rowe.
3763
3764         * DumpRenderTree/LayoutTestController.cpp:
3765         (LayoutTestController::waitToDumpWatchdogTimerFired): Added. Code came
3766         from Gtk/Mac/Win's watchdog timer handlers, but we now call
3767         notifyDone() instead of dump() so that a subsequent call to
3768         notifyDone() won't print the results out again.
3769
3770         * DumpRenderTree/LayoutTestController.h: Added
3771         waitToDumpWatchdogTimerFired.
3772
3773         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3774         (waitToDumpWatchdogFired):
3775         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3776         (waitUntilDoneWatchdogFired):
3777         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3778         (waitUntilDoneWatchdogFired):
3779         Changed to call waitToDumpWatchdogTimerFired.
3780
3781 2009-08-13  Eric Carlson  <eric.carlson@apple.com>
3782
3783         Unreviewed.
3784
3785         Added 'Eric Carlson' to the committers list.
3786
3787         * Scripts/modules/committers.py:
3788
3789 2009-08-13  Dirk Schulze  <krit@webkit.org>
3790
3791         Unreviewed.
3792         Added 'Dirk Schulze' to the committers list.
3793
3794         * Scripts/modules/committers.py:
3795
3796 2009-08-13  Adam Roben  <aroben@apple.com>
3797
3798         Enable running testapi in run-javascriptcore-tests on Windows
3799
3800         Fixes <http://webkit.org/b/24856> run-javascriptcore-tests should run
3801         testapi on Windows
3802
3803         Reviewed by Mark Rowe.
3804
3805         * Scripts/run-javascriptcore-tests: Allow testapi to run if we're in
3806         the AppleWinWebKit configuration.
3807
3808 2009-08-13  Adam Roben  <aroben@apple.com>
3809
3810         Re-enable testapi in run-javascriptcore-tests on Mac
3811
3812         This seems to have been mistakenly disabled in r47089.
3813
3814         Rubber-stamped by Mark Rowe.
3815
3816         * Scripts/run-javascriptcore-tests: Removed comment markers that were
3817         preventing running testapi.
3818
3819 2009-08-12  George Staikos  <george.staikos@torchmobile.com>
3820
3821         Reviewed by Adam Treat.
3822
3823         Enable WCSS and XHTML-MP flags for build-webkit.
3824
3825         * Scripts/build-webkit:
3826
3827 2009-08-12  David Kilzer  <ddkilzer@apple.com>
3828
3829         run-webkit-tests: document --nthly flag in help message
3830
3831         Reviewed by Simon Fraser.
3832
3833         * Scripts/run-webkit-tests: Added --nthly flag to $usage string.
3834         Also noted that -1|--singly implies --nthly 1.
3835
3836 2009-08-12  Eric Seidel  <eric@webkit.org>
3837
3838         No review, just fixing mismerged ChangeLogs.
3839
3840 2009-08-12  Eric Seidel  <eric@webkit.org>
3841
3842         Reviewed by Mark Rowe.
3843
3844         run-webkit-tests needs a --exit-after-failures=N option
3845         https://bugs.webkit.org/show_bug.cgi?id=28192
3846
3847         Added the option and deployed it to bugzilla-tool.
3848
3849         * Scripts/bugzilla-tool:
3850         * Scripts/run-webkit-tests:
3851
3852 2009-08-11  Eric Seidel  <eric@webkit.org>
3853
3854         Reviewed by Mark Rowe.
3855
3856         bugzilla-tool : various improvements for running the commit-queue
3857         https://bugs.webkit.org/show_bug.cgi?id=28199
3858
3859         Make run_and_throw_if_fail silence STDERR as well as STDIN.
3860         I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the output (per abarth's suggestion).
3861         Change a few "print" statements to "log" so they appear in the output.
3862         Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non-string objects).
3863         Added a little more logging so that --quiet mode is easier to understand.
3864         Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
3865         Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
3866         Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
3867         Made curl call (downloading patch files) quieter.
3868
3869         * Scripts/bugzilla-tool:
3870         * Scripts/modules/bugzilla.py:
3871         * Scripts/modules/scm.py:
3872
3873 2009-08-12  Peter Kasting  <pkasting@google.com>
3874
3875         Reviewed by Darin Adler.
3876
3877         https://bugs.webkit.org/show_bug.cgi?id=27323
3878         Change pattern that strips all trailing whitespace to just remove EOL
3879         chars (\r, \n), to make it clear that varying EOL chars is the primary
3880         problem being solved.
3881
3882         * Scripts/prepare-ChangeLog:
3883         * Scripts/resolve-ChangeLogs:
3884         * Scripts/svn-create-patch:
3885         * Scripts/update-webkit:
3886
3887 2009-08-12  Kevin Ollivier  <kevino@theolliviers.com>
3888
3889         wx waf build fix, add new directories to the build.
3890
3891         * wx/build/settings.py:
3892
3893 2009-08-11  Adam Roben  <aroben@apple.com>
3894
3895         Update DumpRenderTree for IWebUIDelegatePrivate changes
3896
3897         Reviewed by Dave Hyatt.
3898
3899         * DumpRenderTree/win/UIDelegate.h: Updated to match
3900         IWebUIDelegatePrivate.
3901
3902 2009-08-12  Adam Roben  <aroben@apple.com>
3903
3904         Don't try to seek to the end of stdin on Cygwin
3905
3906         Doing so seems to always cause an exception (for unknown reasons).
3907
3908         Fixes <http://webkit.org/b/28159> create-bug throws an exception in
3909         Cygwin
3910
3911         Reviewed by Dave Kilzer.
3912
3913         * Scripts/bugzilla-tool:
3914         (CreateBug.prompt_for_bug_title_and_comments): Ignore IOErrors
3915         generated by calling sys.stdin.seek, since these seem to be generated
3916         for no good reason on Cygwin.
3917
3918 2009-08-12  Adam Roben  <aroben@apple.com>
3919
3920         Don't raise an exception when --cc is not passed to create-bug
3921
3922         Fixes <http://webkit.org/b/28158> create-bug throws an exception if
3923         --cc is not specified
3924
3925         Reviewed by Dave Kilzer.
3926
3927         * Scripts/modules/bugzilla.py:
3928         (Bugzilla.create_bug_with_patch): Only set the "cc" field if a CC
3929         string was specified. Otherwise we'll generate an exception about the
3930         "cc" variable not being a string.
3931
3932 2009-08-11  Eric Seidel  <eric@webkit.org>
3933
3934         Reviewed by Adam Barth.
3935
3936         bugzilla-tool : various improvements for running the commit-queue
3937         https://bugs.webkit.org/show_bug.cgi?id=28199
3938
3939         Make run_and_throw_if_fail silence STDERR as well as STDIN.
3940         I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the out
3941         Change a few "print" statements to "log" so they appear in the output.
3942         Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non
3943         Added a little more logging so that --quiet mode is easier to understand.
3944         Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
3945         Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
3946         Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
3947         Made curl call (downloading patch files) quieter.
3948
3949         * Scripts/bugzilla-tool:
3950         * Scripts/modules/bugzilla.py:
3951         * Scripts/modules/scm.py:
3952
3953 2009-08-11  Eric Seidel  <eric@webkit.org>
3954
3955         No review, script regression fix only.
3956
3957         run-webkit-tests --quiet hangs
3958         https://bugs.webkit.org/show_bug.cgi?id=28202
3959
3960         Do a huge dance to get open3 to pipe to /dev/null w/o blocking.
3961         This was what I came up with after discussions in #perl.
3962
3963         * Scripts/run-webkit-tests:
3964
3965 2009-08-11  John Gregg  <johnnyg@google.com>
3966
3967         Reviewed by Maciej Stachowiak.
3968
3969         Switch DumpRenderTree to contain a WebUIDelegate2, which extends
3970         WebUIDelegate, so that the notifications tests will still work.
3971         https://bugs.webkit.org/show_bug.cgi?id=28198
3972
3973         * DumpRenderTree/win/UIDelegate.h:
3974
3975 2009-08-11  Darin Adler  <darin@apple.com>
3976
3977         Try to fix GTK build.
3978
3979         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3980         (AccessibilityUIElement::stringForRange): Added.
3981
3982 2009-08-10  Mike Fenton  <mike.fenton@torchmobile.com>
3983
3984         Reviewed by Adam Treat.
3985
3986         Add processing for string constants used by the tests to trigger
3987         common actions like up, down, left, right, etc. for the Qt
3988         implementation of DumpRenderTree.
3989
3990         Note this allows fast/forms/textarea-arrow-navigation.html to pass
3991         correctly.
3992
3993         https://bugs.webkit.org/show_bug.cgi?id=28161
3994
3995         * DumpRenderTree/qt/jsobjects.cpp:
3996         (EventSender::keyDown):
3997
3998 2009-08-11  Chris Fleizach  <cfleizach@apple.com>
3999
4000         Reviewed by Darin Adler.
4001
4002         Bug 28200 - ListMarker should be included as part of the text value to parse
4003         https://bugs.webkit.org/show_bug.cgi?id=28200
4004
4005         Add the ability to retrieve a string given a plain NSRange.
4006
4007         * DumpRenderTree/AccessibilityUIElement.cpp:
4008         (stringForRangeCallback):
4009         (AccessibilityUIElement::getJSClass):
4010         * DumpRenderTree/AccessibilityUIElement.h:
4011         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4012         (AccessibilityUIElement::valueDescription):
4013         (AccessibilityUIElement::stringForRange):
4014         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4015         (AccessibilityUIElement::stringForRange):
4016
4017 2009-08-11  Dmitry Titov  <dimich@chromium.org>
4018
4019         Reviewed by NOBODY (Speculative fix for the layout test failure).
4020
4021         Fix fast/dom/prototype-inheritance.html
4022         and fast/dom/prototype-inheritance-2.html
4023         broken on Windows by http://trac.webkit.org/changeset/47018
4024
4025         * DumpRenderTree/win/DumpRenderTree.cpp:
4026         (resetDefaultsToConsistentValues): enable app cache in Windows DRT.
4027
4028 2009-08-11  Eric Seidel  <eric@webkit.org>
4029
4030         Reviewed by Adam Barth.
4031
4032         bugzilla-tool: Re-factor shared landing logic into helper class to share more code
4033         https://bugs.webkit.org/show_bug.cgi?id=28193
4034
4035         Added new WebKitLandingScripts class to hold this shared logic.
4036         Also added a view_source_url function to move more webkit-specific urls out of bugzilla-tool core.
4037
4038         * Scripts/bugzilla-tool:
4039
4040 2009-08-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4041
4042         Reviewed by Adam Treat.
4043
4044         Fix the current failures on the buildbot.
4045
4046         As Qt hooks up the maybeDump to loadFinished, we need to make
4047         sure that calling dump() will not call maybeDump on loadFinished.
4048
4049         As dump is called my emitting done() which calls dump() and then
4050         setting m_isLoading to false. So in the case m_isLoading is false,
4051         do not dump again.
4052
4053         The current code is confusing, and should be made more clear
4054         in another commit.
4055
4056         * DumpRenderTree/qt/jsobjects.cpp:
4057         (LayoutTestController::maybeDump):
4058         (LayoutTestController::notifyDone):
4059
4060 2009-08-11  John Gregg  <johnnyg@google.com>
4061
4062         Reviewed by Maciej Stachowiak.
4063
4064         Add support for desktop notifications API to DumpRenderTree,
4065         and support for ENABLE_NOTIFICATIONS flag to build-webkit.
4066
4067         * DumpRenderTree/LayoutTestController.cpp:
4068         (grantDesktopNotificationPermissionCallback):
4069         (LayoutTestController::staticFunctions):
4070         (LayoutTestController::grantDesktopNotificationPermission):
4071         (LayoutTestController::checkDesktopNotificationPermission):
4072         * DumpRenderTree/LayoutTestController.h:
4073         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: Added.
4074         (DRTDesktopNotificationPresenter::DRTDesktopNotificationPresenter):
4075         (DRTDesktopNotificationPresenter::QueryInterface):
4076         (DRTDesktopNotificationPresenter::AddRef):
4077         (DRTDesktopNotificationPresenter::Release):
4078         (DRTDesktopNotificationPresenter::showDesktopNotification):
4079         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
4080         (DRTDesktopNotificationPresenter::notificationDestroyed):
4081         (DRTDesktopNotificationPresenter::checkNotificationPermission):
4082         (DRTDesktopNotificationPresenter::requestNotificationPermission):
4083         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h: Added.
4084         * DumpRenderTree/win/DumpRenderTree.vcproj:
4085         * DumpRenderTree/win/UIDelegate.cpp:
4086         (UIDelegate::UIDelegate):
4087         (UIDelegate::desktopNotificationsDelegate):
4088         * DumpRenderTree/win/UIDelegate.h:
4089         * Scripts/build-webkit:
4090
4091 2009-08-11  Peter Kasting  <pkasting@google.com>
4092
4093         Reviewed by Darin Adler.
4094
4095         https://bugs.webkit.org/show_bug.cgi?id=27323
4096         Handle arbitrary line endings when manufacturing patches for additions
4097         with history.
4098
4099         * Scripts/svn-create-patch:
4100
4101 2009-08-11  Peter Kasting  <pkasting@google.com>
4102
4103         Reviewed by Darin Adler.
4104
4105         https://bugs.webkit.org/show_bug.cgi?id=28183
4106         Support VS2008 as well as VS2005 in a few scripts.
4107
4108         * Scripts/pdevenv: Check both $VS80COMNTOOLS and $VS90COMNTOOLS.
4109         * Scripts/webkitdirs.pm: Use $VSINSTALLDIR if available instead of hardcoding the VS2005 dir.
4110
4111 2009-08-11  Eric Seidel  <eric@webkit.org>
4112
4113         Reviewed by Adam Barth.
4114
4115         run-webkit-tests --quiet should not output build-dumprendertree output
4116         https://bugs.webkit.org/show_bug.cgi?id=28189
4117
4118         * Scripts/run-webkit-tests:
4119
4120 2009-08-11  Eric Seidel  <eric@webkit.org>
4121
4122         Reviewed by Darin Adler.
4123
4124         Exception in land-patches
4125         https://bugs.webkit.org/show_bug.cgi?id=27962
4126
4127         Use ("%s" % object) instead of ("" + object).
4128         Added unit tests for logging.py.
4129
4130         * Scripts/modules/logging.py:
4131         * Scripts/modules/logging_unittest.py: Added.
4132         * Scripts/run-webkit-unittests:
4133
4134 2009-08-11  Dmitry Titov  <dimich@chromium.org>
4135
4136         Reviewed by NOBODY (Windows layout tests fix).
4137
4138         Fix for layout tests failures. Need to initialize some preferences early
4139         because WebView on Windows uses them during create time.
4140
4141         * DumpRenderTree/win/DumpRenderTree.cpp:
4142         (main):
4143
4144 2009-08-11  Dmitry Titov  <dimich@chromium.org>
4145
4146         Reviewed by Adam Roben.
4147
4148         Originally implemented by Glenn Wilson  <gwilson@chromium.org>.
4149
4150         Added support for overriding default preferences per-test.
4151         See https://bugs.webkit.org/show_bug.cgi?id=20534
4152
4153         * DumpRenderTree/LayoutTestController.cpp:
4154         (overridePreferenceCallback): add wiring for layoutTestController.overridePreference.
4155         (LayoutTestController::staticFunctions): same.
4156         * DumpRenderTree/LayoutTestController.h: same.
4157         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4158         (LayoutTestController::overridePreference): added empty overridePreference method.
4159         * DumpRenderTree/mac/DumpRenderTree.mm: implemented preference override.
4160         (resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
4161         (setDefaultsToConsistentValuesForTesting): new method, sets other details of testing environment, every time  DRT starts.
4162         (resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().
4163         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4164         (LayoutTestController::overridePreference):
4165         * DumpRenderTree/win/DumpRenderTree.cpp:
4166         (resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
4167         (resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().
4168         (createWebViewAndOffscreenWindow): same.
4169         (main): same.
4170         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4171         (LayoutTestController::overridePreference):
4172         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4173         (LayoutTestController::overridePreference):
4174
4175 2009-08-11  Brian Weinstein  <bweinstein@apple.com>
4176
4177         Reviewed by Sam Weinig.
4178
4179         Added support for DRT to support arguments for eventSender.mouseDown and eventSender.mouseUp for Windows.
4180         https://bugs.webkit.org/show_bug.cgi?id=28166.
4181         
4182         This is a step towards fixing fast/events/mouse-click-events.html on Windows.
4183
4184         * DumpRenderTree/win/EventSender.cpp:
4185         (mouseDownCallback):
4186         (mouseUpCallback):
4187         (replaySavedEvents):
4188
4189 2009-08-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4190
4191         Reviewed by Simon Hausmann.
4192
4193         Build the TestNetscapePlugin on Qt/Mac
4194
4195         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4196
4197 2009-08-11  Dmitry Titov  <dimich@chromium.org>
4198
4199         Reviewed by NOBODY (build fix).
4200
4201         Attempt to fix the Windows test bot. Reverted r47015 caused one of the Windows
4202         bots that runs Layout Tests to save "JS disabled" and "default font 24pt"
4203         preferences permanently. Since these preferences are not initialized explicitly in DRT,
4204         almost all Layout tests are failing. Attempt to fix by explicit
4205         initialization of these into defaults (enabled, 16pt) at the beginning of the DRT.
4206
4207         * DumpRenderTree/win/DumpRenderTree.cpp:
4208         (main):  see above.
4209
4210 2009-08-10  Steve Falkenburg  <sfalken@apple.com>
4211
4212         Windows nightly fix.
4213
4214         Reviewed by Ada Chan.
4215
4216         * FindSafari/FindSafari.cpp:
4217         (_tmain): Copy Safari.dll if it exists.
4218
4219 2009-08-10  David Levin  <levin@chromium.org>
4220
4221         Reviewed by David Kilzer.
4222
4223         check-webkit-style doesn't catch braces around single line statements when followed by else.
4224         https://bugs.webkit.org/show_bug.cgi?id=28164
4225
4226         * Scripts/modules/cpp_style.py: Added else to the regex that finds ending }'s when
4227           checking the no braces for "single lines" rule.
4228         * Scripts/modules/cpp_style_unittest.py: Added test case.
4229
4230 2009-08-10  David Kilzer  <ddkilzer@apple.com>
4231
4232         <http://webkit.org/b/28163> bugzilla-tool: scm module should not import bugzilla module
4233
4234         Reviewed by David Levin.
4235
4236         * Scripts/bugzilla-tool:
4237         (parse_bug_id): Added.  Moved from CommitMessage.parse_bug_id()
4238         in scm module.
4239         * Scripts/modules/scm.py: Removed import of bugzilla module.
4240         (CommitMessage.parse_bug_id): Deleted.
4241
4242 2009-08-10  Peter Kasting  <pkasting@google.com>
4243
4244         Reviewed by David Kilzer.
4245
4246         https://bugs.webkit.org/show_bug.cgi?id=18599
4247         Work around apparent bug in abs2rel() with symlinked directories.
4248
4249         * Scripts/resolve-ChangeLogs:
4250
4251 2009-08-10  Dan Bernstein  <mitz@apple.com>
4252
4253         Build fix
4254
4255         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
4256         (NPP_New):
4257
4258 2009-08-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4259
4260         Reviewed by Simon Hausmann.
4261
4262         Fix a bunch of build warnings in TestNetscapePlugin
4263         
4264         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
4265         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
4266
4267 2009-08-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4268
4269         Reviewed by Adam Roben.
4270         
4271         Allow TestNetscapePlugIn to fall back to the Carbon event model
4272         
4273         Previously the plugin would fail, even though the Carbon event
4274         model was available. The only way to get the Carbon event model
4275         was to pass the "forcecarbon" argument in the test markup, but no
4276         tests were using this.
4277         
4278         Now the plugin uses carbon either if it's forced, or if the Cocoa
4279         event model is not supported.
4280         
4281         This helps us run most of the plugin tests on Qt/Mac, which still
4282         does not support the Cocoa event model.
4283         
4284         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
4285         (NPP_New):
4286
4287 2009-08-08  Adam Barth  <abarth@webkit.org>
4288
4289         Reviewed by Eric Seidel.
4290
4291         bugzilla-tool needs a --quiet option
4292         https://bugs.webkit.org/show_bug.cgi?id=28060
4293
4294         A first pass at a --quiet option.  This doesn't do all the excting
4295         things we might want, but it addresses 80% of the use case.
4296
4297         * Scripts/bugzilla-tool:
4298
4299 2009-08-08  Jan Michael Alonzo  <jmalonzo@webkit.org>
4300
4301         Reviewed by Xan Lopez.
4302
4303         [Gtk] Enable accessibility in Gtk DRT