d192dac032a60a94db9b0964ce63469258586645
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-11-14  Adam Roben  <aroben@apple.com>
2
3         Updates to Safari launching now that 3.0.4 is released
4
5         Reviewed by Sam.
6
7         * FindSafari/FindSafari.cpp:
8         (getWebViewCLSID): Use version-independent ProgID.
9         * Scripts/run-safari: Use run-webkit-nightly.cmd.
10
11 2007-11-14  Anders Carlsson  <andersca@apple.com>
12
13         Reviewed by Adam.
14
15         <rdar://problem/5309081>
16         In DRT, "plugin.logDestroy = true" not working on Windows.
17         
18         * DumpRenderTree/win/TestNetscapePlugin/main.c:
19         (NPP_Destroy):
20
21 2007-11-14  Eric Seidel  <eric@webkit.org>
22
23         Reviewed by Sam.
24
25         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
26
27 2007-11-14  Anders Carlsson  <andersca@apple.com>
28
29         Reviewed by Adam.
30
31         <rdar://problem/5141186>
32         window.layoutTestController.setWindowIsKey is not implemented in DRT.
33         
34         Implement setWindowIsKey.
35         
36         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
37         (LayoutTestController::setWindowIsKey):
38
39 2007-11-13  Sam Weinig  <sam@webkit.org>
40
41         Reviewed by Adam Roben.
42
43         Fix for <rdar://problem/5382579>
44         http/tests/security/cross-frame-access-put.html reports large 
45         negative numbers for screenLeft and screenTop (Mac reports "0")
46
47         * DumpRenderTree/win/UIDelegate.cpp:
48         (UIDelegate::UIDelegate): Initialize the RECT.
49         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
50         (UIDelegate::webViewFrame): ditto.
51         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
52
53 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
54
55         Reviewed by Adam.
56
57         - Make Drosera show source, source URLs, and function stack on Windows,
58         and some minor fixes.
59
60         * Drosera/DebuggerDocument.cpp: Force source to always update display.
61         (DebuggerDocument::updateFileSource):
62         * Drosera/debugger.js: Force source to always update display.
63         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
64         menu controls.
65         (DebuggerClient::resume):
66         (DebuggerClient::pause):
67         (DebuggerClient::stepInto):
68         (DebuggerClient::stepOver):
69         (DebuggerClient::stepOut):
70         (DebuggerClient::showConsole):
71         (DebuggerClient::closeCurrentFile):
72         * Drosera/win/DebuggerClient.h: Ditto.
73         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
74         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
75         removed two bugs.  1) caller could be in a bad state when asked to
76         assign into it. 2) BSTRs were not created correctly.
77         (DebuggerDocument::getPlatformCurrentFunctionStack):
78         * Drosera/win/Drosera.cpp: Hook up the menu controls.
79         (droseraWndProc):
80         (handleCommand):
81         (Drosera::resume):
82         (Drosera::pause):
83         (Drosera::stepInto):
84         (Drosera::stepOver):
85         (Drosera::stepOut):
86         (Drosera::showConsole):
87         (Drosera::closeCurrentFile):
88         * Drosera/win/Drosera.h: Hook up the menu controls.
89         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
90         functions, added a null check, and fixed another bug where caller could
91         be in a bad state when asked to assign into it.
92         (ServerConnection::didLoadMainResourceForDataSource):
93         (ServerConnection::getCallerFrame):
94         * Drosera/win/ServerConnection.h: Safety first.
95
96 2007-11-13  Dan Bernstein  <mitz@apple.com>
97
98         Reviewed by Darin Adler.
99
100         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
101           DumpRenderTree --pixel-tests renders each test twice
102
103         * DumpRenderTree/mac/DumpRenderTree.mm:
104         (dumpRenderTree): Removed the --paint option because the painting code
105         is always exercised as a result of
106         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
107         calling -displayIfNeeded.
108         (dump): Changed to always grab the image from the window since the view
109         is always displayed.
110         (runTest):
111         (displayWebView):
112         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
113         because it always paints.
114
115 2007-11-12  Antti Koivisto  <antti@apple.com>
116
117         Reviewed by Adele.
118         
119         Add support for http media tests
120
121         * Scripts/run-webkit-tests:
122
123 2007-11-12  Sam Weinig  <sam@webkit.org>
124
125         Reviewed by Adam Roben.
126
127         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
128
129         * DumpRenderTree/win/DumpRenderTree.cpp:
130         (runTest):
131         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
132         (LayoutTestController::setPrivateBrowsingEnabled):
133
134 2007-11-12  Adam Roben  <aroben@apple.com>
135
136         * Scripts/update-webkit-localizable-strings: Changed to only scan the
137         mac and win subdirectories.
138
139 2007-11-11  Adam Roben  <aroben@apple.com>
140
141         Fix <rdar://5133816> keepWebHistory is not implemented
142
143         Fixes fast/history/clicked-link-is-visited.html.
144
145         Reviewed by Darin.
146
147         * DumpRenderTree/win/DumpRenderTree.cpp:
148         (runTest): Clear the optionalSharedHistory.
149         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
150         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
151
152 2007-11-10  Sam Weinig  <sam@webkit.org>
153
154         Reviewed by Tim Hatcher.
155
156         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
157         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
158         is turned on)
159
160         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
161
162         Added test: http/tests/security/cross-frame-access-private-browsing.html
163
164         * DumpRenderTree/LayoutTestController.cpp:
165         (setPrivateBrowsingEnabledCallback):
166         (LayoutTestController::staticFunctions):
167         * DumpRenderTree/LayoutTestController.h:
168         * DumpRenderTree/mac/DumpRenderTree.mm:
169         (runTest): Default to private browsing disabled.
170         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
171         (LayoutTestController::setPrivateBrowsingEnabled):
172         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
173         (LayoutTestController::setPrivateBrowsingEnabled):
174
175 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
176
177         Reviewed by Adam.
178
179         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
180         WebCore's!
181
182         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
183         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
184         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
185         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
186         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
187         * Drosera/win/Drosera.cpp:
188         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
189
190 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
191
192         Reviewed by Sam.
193
194         - Use the new IWebFrame [local] function signature and get the shared
195         server correctly.
196
197         * Drosera/win/DebuggerClient.cpp:
198         (DebuggerClient::didFinishLoadForFrame):
199         * Drosera/win/ServerConnection.cpp:
200         (ServerConnection::attemptToCreateServerConnection):
201
202 2007-11-07  Dan Bernstein  <mitz@apple.com>
203
204         Reviewed by Darin Adler.
205
206         - add an option to run-webkit-tests to ignore pixel test failures where
207           all pixels differ by no more than a specified threshold
208
209         * DumpRenderTree/mac/ImageDiff.m:
210         (main):
211         (compareImages):
212         (computePercentageDifferent):
213         * Scripts/run-webkit-tests:
214
215 2007-11-07  Simon Hausmann  <hausmann@kde.org>
216
217         Reviewed by Lars.
218
219         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
220
221         * DumpRenderTree/qt/DumpRenderTree.cpp:
222
223 2007-11-07  Simon Hausmann  <hausmann@kde.org>
224
225         Reviewed by Lars.
226
227         Reworked the QWebSettings API.
228         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
229
230         * DumpRenderTree/qt/DumpRenderTree.cpp:
231
232 2007-11-07  Simon Hausmann  <hausmann@kde.org>
233
234         Reviewed by Lars.
235
236         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
237
238         * DumpRenderTree/qt/jsobjects.cpp:
239
240 2007-11-07  Simon Hausmann  <hausmann@kde.org>
241
242         Reviewed by Lars Knoll <lars@trolltech.com>.
243
244         Add a QWebPage::frameCreated() signal and fix DRT
245         
246         The removal of createFrame in QWebPage broke the re-implementation
247         in DumpRenderTree. Instead emit a frameCreated() signal and
248         connect to it in DumpRenderTree.
249         
250
251         * DumpRenderTree/qt/DumpRenderTree.cpp:
252         (WebCore::WebPage::WebPage):
253         (WebCore::DumpRenderTree::dump):
254         (WebCore::DumpRenderTree::connectFrame):
255         * DumpRenderTree/qt/DumpRenderTree.h:
256
257 2007-11-07  Simon Hausmann  <hausmann@kde.org>
258
259         Reviewed by Lars Knoll <lars@trolltech.com>.
260
261         Moved all the event handlers from QWebFrame into QWebPage.
262         
263         This cleans up the public API and allows us to remove the
264         HackWebFrame hack in DumpRenderTree.
265         
266
267         * DumpRenderTree/qt/jsobjects.cpp:
268         (EventSender::mouseDown):
269         (EventSender::mouseUp):
270         (EventSender::mouseMoveTo):
271
272 2007-11-07  Simon Hausmann  <hausmann@kde.org>
273
274         Reviewed by Mark.
275
276         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
277         to prevent the default implementation from popping up messageboxes.
278
279         * DumpRenderTree/qt/DumpRenderTree.cpp:
280         (WebCore::WebPage::javaScriptConfirm):
281         (WebCore::WebPage::javaScriptPrompt):
282
283 2007-11-06  Eric Seidel  <eric@webkit.org>
284
285         * Scripts/build-testkjs: build fix... too many $$
286
287 2007-11-06  Eric Seidel  <eric@webkit.org>
288
289         Reviewed by Mark Rowe.
290
291         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
292
293 2007-11-05  Adam Roben  <aroben@apple.com>
294
295         Add support on Windows for WEBKIT_TESTFONTS
296
297         This environment variable lets you specify where the fonts to be used
298         by DumpRenderTree reside. The Qt port is already using this, so I'm
299         just following their lead.
300
301         Reviewed by Darin.
302
303         * DumpRenderTree/win/DumpRenderTree.cpp:
304         (exePath): Refactored code out of initialize().
305         (fontsPath): Returns either $WEBKIT_TESTFONTS or
306         DumpRenderTree.resources.
307         (initialize): Use the new fontsPath function.
308         (main): Use the new exePath function.
309         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
310         variable to DRT, like Qt does.
311
312 2007-11-05  Mark Rowe  <mrowe@apple.com>
313
314         Rubber-stamped by Alp Toker.
315
316         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
317
318         * GtkLauncher/main.cpp:
319         (goToURLBarText):
320         (main):
321
322 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
323
324         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
325         <http://bugs.webkit.org/show_bug.cgi?id=15830>
326
327         Reviewed by Timothy.
328
329         Restrict the range of nightly builds used by the bisect-builds script
330         based on the version of Safari and the version of Mac OS X being used.
331
332         Mac OS X 10.4: Safari 2.0: r11976 or newer
333         Mac OS X 10.4: Safari 3.0: r19992 or newer
334
335         Mac OS X 10.5: Safari 2.0: r19594 or newer
336         Mac OS X 10.5: Safari 3.0: r25124 or newer
337
338         * Scripts/bisect-builds:
339         (findMacOSXVersion): Added.
340         (makeNightlyList): Added argument to provide version of Mac OS X.
341         Restrict range of nightly builds based on Safari and Mac OS X versions.
342
343 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
344
345         Reviewed by Maciej.
346
347         - This patch involves several changes, all of them were noticed that
348         they were needed by the work being done in WebKit to get Drosera and
349         WebKit working together on Windows.
350         - The changes are:
351         1) Added a debugger console for output messages.
352         2) Drosera now listens for the WebKit server (before, the server would
353         have to be running before Drosera was started.)
354         3) Fixed a bug where the WebView started out as 0x0 pixels.
355         4) Fixed a bug when there is no scope.
356         5) Added the HTML, JS, and CSS to the project file to make them easy to
357         find.
358         6) Made the ServerConnection functions virtual.
359
360         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
361         for the WebKit server.
362         (DebuggerClient::DebuggerClient):
363         (DebuggerClient::~DebuggerClient):
364         (DebuggerClient::didFinishLoadForFrame):
365         (DebuggerClient::serverConnected):
366         (DebuggerClient::attemptToCreateServerConnection):
367         * Drosera/win/DebuggerClient.h: Ditto.
368         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
369         scope.
370         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
371         (DebuggerDocument::platformValueForScopeVariableNamed):
372         * Drosera/win/Drosera.cpp:
373         (_tWinMain): Added a console in debug for output messages.
374         (Drosera::Drosera): Listen for server.
375         (Drosera::initUI): The server now Initializes COM.
376         (Drosera::serverConnected): Part of the listening for the server.
377         (Drosera::attemptToCreateServerConnection): Ditto.
378         * Drosera/win/Drosera.h: New interface for listening for the server.
379         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
380         files to the VS project.
381         * Drosera/win/ServerConnection.cpp: Part of listening for the server
382         connection.
383         (ServerConnection::ServerConnection):
384         (ServerConnection::attemptToCreateServerConnection):
385         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
386         methods.
387         (ServerConnection::serverConnected):
388
389 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
390
391         Reviewed by Maciej.
392
393         http://bugs.webkit.org/show_bug.cgi?id=15832
394         fast/dom/gc-10.html crashes when run alone
395
396         Check for !done before using objects that can be already deallocated.
397
398         * DumpRenderTree/mac/EditingDelegate.mm:
399         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
400         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
401         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
402         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
403         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
404         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
405         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
406         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
407         (-[EditingDelegate webViewDidBeginEditing:]):
408         (-[EditingDelegate webViewDidChange:]):
409         (-[EditingDelegate webViewDidEndEditing:]):
410         (-[EditingDelegate webViewDidChangeTypingStyle:]):
411         (-[EditingDelegate webViewDidChangeSelection:]):
412         * DumpRenderTree/mac/FrameLoadDelegate.mm:
413         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
414         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
415         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
416         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
417         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
418         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
419         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
420         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
421         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
422         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
423         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
424         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
425         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
426         (-[FrameLoadDelegate webView:willCloseFrame:]):
427         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
428         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
429         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
430         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
431         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
432         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
433         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
434         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
435         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
436
437 2007-11-04  Mark Rowe  <mrowe@apple.com>
438
439         Build fix.  Don't use Carbon.h as the prefix header as it triggers
440         warnings that would otherwise be suppressed due to it being a system header.
441
442         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
443
444 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
445
446         Rubber stamped by Adam.
447         
448         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
449
450         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
451
452 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
453
454         Sort files(...); sections of Xcode project files.
455
456         Rubber-stamped by Darin.
457
458         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
459         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
460         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
461         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
462
463 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
464
465         Script to sort "files(...);" sections in Xcode project.pbxproj files.
466
467         Reviewed by Darin.
468
469         * Scripts/sort-Xcode-project-file: Added.
470
471 2007-11-02  Darin Adler  <darin@apple.com>
472
473         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
474
475 2007-11-02  Darin Adler  <darin@apple.com>
476
477         Reviewed by Maciej.
478
479         * Scripts/run-sunspider: Pass the "--base" option through.
480
481         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
482         the real script do that. Default configuration to Release to match run-sunspider
483         so we don't end up building Debug just to compare results.
484
485 2007-11-01  Adam Roben  <aroben@apple.com>
486
487         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
488
489         Reviewed by Sam.
490
491         * Scripts/commit-log-editor: Show all the directories beneath the
492         source root, instead of just the last one.
493
494 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
495
496         Reviewed by Adam Roben.
497
498         Print out an error message when the Windows build fails
499         and provide guidance on how to find out what went wrong.
500
501         * Scripts/build-webkit:
502         * Scripts/webkitdirs.pm:
503
504 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
505
506         Rubber-stamped by Adam Roben.
507
508         Rolled out r27326 - debug CRT seems to cause no problems after all.
509
510         * DumpRenderTree/win/DumpRenderTree.vcproj:
511
512 2007-10-31  Adam Roben  <aroben@apple.com>
513
514         Switch the Debug configuration to using the non-debug CRT
515
516         This matches WebKit.
517
518         Reviewed by Steve.
519
520         * DumpRenderTree/win/DumpRenderTree.vcproj:
521
522 2007-10-31  Antti Koivisto  <antti@apple.com>
523
524         Reviewed by bdash.
525         
526         Disable media tests when doing leak checking on Tiger.
527         They crash in QuickTime (rdar://problem/5537157).
528
529         * Scripts/run-webkit-tests:
530
531 2007-10-29  Antti Koivisto  <antti@apple.com>
532
533         Reviewed by Maciej.
534         
535         Build media support by default on OSX only.
536
537         * Scripts/build-webkit:
538
539 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
540
541         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
542         get caught by the pre-commit hooks.
543
544 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
545
546         Reviewed by Adam.
547
548         - This is a collection of relatively unrelated changes and cleanups
549         to Drosera to prepare it for interacting with WebKit.  A lot of these
550         changes are just correcting mistakes, for example removing included
551         headers that are no longer needed.
552
553         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
554         this will be needed by the DebuggerClient.
555         (DebuggerDocument::server):
556         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
557         * Drosera/win/DebuggerClient.cpp: 
558         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
559         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
560         (DebuggerClient::createWebViewWithRequest): Added comment about its
561         purpose. 
562         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
563         declarations.
564         (DebuggerClient::webViewLoaded): Moved.
565         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
566         file, since this was the only place it was used.
567         (cfStringToBSTR):
568         * Drosera/win/Drosera.h: Cleaned up the includes.
569         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
570         * Drosera/win/HelperFunctions.h: Removed.
571
572 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
573
574         Reviewed by Adam.
575
576         - Small cleanup in the ServerConnection class.
577
578         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
579         and added an include.
580         (ServerConnection::currentFrame):
581         (ServerConnection::getCallerFrame):
582         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
583         made a pointer into a COMPtr, and cleaned up the includes.
584
585 2007-10-29  Timothy Hatcher  <timothy@apple.com>
586
587         Reviewed by John Sullivan.
588         
589         - Place the Localizable.strings file in mac or win directories
590           if that location exists.
591         - Also look for UI_STRING in .c files.
592
593         * Scripts/extract-localizable-strings:
594
595 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
596
597         Reviewed by Adam.
598
599         - Set the eol-style to native and made all the line endings the same
600         so that I avoid messy diffs that show eol changes.
601
602         * Drosera/win/ServerConnection.cpp:
603         (ServerConnection::didParseSource):
604         (ServerConnection::didEnterCallFrame):
605         (ServerConnection::willExecuteStatement):
606         (ServerConnection::willLeaveCallFrame):
607         (ServerConnection::exceptionWasRaised):
608
609 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
610
611         Reviewed by Adam.
612
613         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
614         functionality that could not have existed previously without the new
615         interfaces.
616         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
617         from a BSTR to a JSValueRef.
618         (DebuggerDocument::platformEvaluateScript): Implemented.
619         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
620         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
621         Implemented.
622         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
623         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
624         * Drosera/win/ServerConnection.cpp: Added a helper function.
625         (ServerConnection::getCallerFrame):
626         * Drosera/win/ServerConnection.h: Added a helper function.
627
628 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
629
630         updated reviewers for my previous changelog.
631
632 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
633         Reviewed by Maciej and Adam and Geoff.
634
635         - Minor mac-side improvements including moving a function to a more
636         appropriate location, fixing a warning, and correctly checking
637         exceptions.
638
639         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
640         (DebuggerDocument::willExecuteStatement):
641         (DebuggerDocument::didEnterCallFrame):
642         (DebuggerDocument::willLeaveCallFrame):
643         (DebuggerDocument::windowScriptObjectAvailable):
644         (DebuggerDocument::callFunctionOnObject):
645         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
646         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
647         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
648         because it doesn't require the ServerConnection at all.
649         (NSStringCreateWithJSStringRef): Made an argument const.
650         (JSValueRefCreateWithNSString): Made an argument const.
651         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
652         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
653         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
654         * Drosera/mac/ServerConnection.mm: Ditto.
655         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
656
657 2007-10-29  Sam Weinig  <sam@webkit.org>
658
659         Reviewed by Adam Roben.
660
661         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
662
663         * DumpRenderTree/LayoutTestController.cpp:
664         (LayoutTestController::LayoutTestController):
665         (getGlobalFlagCallback):
666         (setGlobalFlagCallback):
667         (LayoutTestController::getJSClass):
668         (LayoutTestController::staticValues):
669         * DumpRenderTree/LayoutTestController.h:
670         (LayoutTestController::globalFlag):
671         (LayoutTestController::setGlobalFlag):
672
673 2007-10-29  Darin Adler  <darin@apple.com>
674
675         Reviewed by Maciej.
676
677         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
678         resolution instead of its default.
679
680 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
681
682         Fixed showStatus() to print status for successfully resolved conflicts when using git.
683
684         Reviewed by Mark Rowe.
685
686         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
687         was successfully resolved, but this would not show any status because the change had
688         already been cached in the index using "git add".  The solution is to add an optional
689         second argument to showStatus() which adds the "--cached" switch to the command.
690
691         * Scripts/resolve-ChangeLogs:
692         (showStatus):
693
694 2007-10-28  Eric Seidel  <eric@webkit.org>
695
696         Reviewed by Maciej and Geoff, in unison.
697
698         * Scripts/run-webkit-tests: remove broken --svg option
699
700 2007-10-28  Darin Adler  <darin@apple.com>
701
702         Reviewed by Adam.
703
704         * Scripts/run-sunspider: Default to "Release" configuration rather than
705         defaulting to the last configuration used as other scripts do. This can
706         still be overriden on the command line with "--debug" if there's some
707         reason to do so. Also fix a typo.
708
709         * Scripts/sunspider-compare-results: Fix a typo.
710
711 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
712
713         Reviewed by Adam.
714
715         - Implemented the WebScriptDebugListener functions now that the
716         WebScriptDebugServer exists
717
718         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
719         functions.
720         (ServerConnection::currentFrame):
721         (ServerConnection::didLoadMainResourceForDataSource):
722         (ServerConnection::didParseSource):
723         (ServerConnection::failedToParseSource):
724         (ServerConnection::didEnterCallFrame):
725         (ServerConnection::willExecuteStatement):
726         (ServerConnection::willLeaveCallFrame):
727         (ServerConnection::exceptionWasRaised):
728         * Drosera/win/ServerConnection.h: Removed unused arguments from the
729         members arguments list.
730
731 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
732
733         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
734         <http://bugs.webkit.org/show_bug.cgi?id=15600>
735
736         Reviewed by Darin.
737
738         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
739         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
740         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
741         file.  Note that it may also be used as a stand-alone script.
742
743         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
744         * Scripts/resolve-ChangeLogs: Added.
745         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
746
747 2007-10-26  Mark Rowe  <mrowe@apple.com>
748
749         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
750         to the Qt port on the assumption that it was an implementation of the cross-platform
751         LayoutTestController class.  It is not, so it did not need to be changed.
752
753         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
754
755 2007-10-25  Mark Rowe  <mrowe@apple.com>
756
757         Reviewed by Maciej.
758
759         Fix builds with code coverage enabled.
760
761         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
762
763 2007-10-25  Darin Adler  <darin@apple.com>
764
765         Reviewed by Mark Rowe.
766
767         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
768         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
769
770 2007-10-25  Stephanie  <slewis@apple.com>
771
772         build Fix
773
774         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
775
776 2007-10-25  Stephanie  <slewis@apple.com>
777
778         Reviewed by Mark Rowe, Adam Roben.
779
780         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
781
782         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
783
784 2007-10-25  Alice Liu  <alice.liu@apple.com>
785
786         Reviewed by Adam.
787
788         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
789
790         Moving destructor into platform-specific files
791         * DumpRenderTree/LayoutTestController.cpp:
792         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
793         (LayoutTestController::~LayoutTestController):
794         * DumpRenderTree/qt/jsobjects.cpp:
795         (LayoutTestController::~LayoutTestController):
796
797         LayoutTestController wasn't being destroyed
798         * DumpRenderTree/win/DumpRenderTree.cpp:
799         (runTest):
800
801         Added declspec
802         * DumpRenderTree/win/EditingDelegate.h:
803
804         Reset certain values on the webview (or related delegate) that might 
805         have changed while running a test
806         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
807         (LayoutTestController::~LayoutTestController):
808
809 2007-10-25  Adam Roben  <aroben@apple.com>
810
811         Make sunspider-compare-results work with relative paths
812
813         Reviewed by Sam.
814
815         * Scripts/sunspider-compare-results: Convert arguments to absolute
816         paths before we chdir.
817
818 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
819
820         Reviewed by Sam.
821
822         - Implemented server calls now the WebScriptDebugServer exists.
823         - Also removed no longer needed call to initialize CG.
824
825         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
826         automatically now.
827         (_tWinMain):
828         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
829         (ServerConnection::ServerConnection):
830         (ServerConnection::~ServerConnection):
831         (ServerConnection::pause):
832         (ServerConnection::resume):
833         (ServerConnection::stepInto):
834         (ServerConnection::applicationTerminating):
835         (ServerConnection::serverConnectionDidDie):
836         * Drosera/win/ServerConnection.h: Now uses the COM class.
837
838 2007-10-24  George Staikos  <staikos@kde.org>
839
840         Unbreak Qt build.
841
842         * Scripts/build-webkit:
843
844 2007-10-24  Adam Roben  <aroben@apple.com>
845
846         Remove now-unnecessary call to InitializeCoreGraphics
847
848         WebKit takes care of this now.
849
850         Reviewed by Ada.
851
852         * DumpRenderTree/win/DumpRenderTree.cpp:
853         (initialize):
854
855 2007-10-24  Adam Roben  <aroben@apple.com>
856
857         Use WebTextRenderer in DRT
858
859         Reviewed by Ada.
860
861         * DumpRenderTree/win/DumpRenderTree.cpp:
862         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
863
864 2007-10-24  Sven Herzberg  <sven@imendio.com>
865
866         Reviewed by Mark Rowe.
867
868         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
869         Bug 15614: [GTK] qmake based backends don't build on OS X
870
871         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
872         GTK backend on a Mac
873         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
874         isDarwin() to make it reusable in other places (like the workaround-
875         for-prebuilt-qmake in build-webkit)
876
877 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
878
879         Refurbish update-webkit script.
880
881         Reviewed by Adam.
882
883         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
884         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
885         multi-argument version of system() for flexibility and security.  Check for existence
886         of Internal directory using -d test instead of -x.
887
888 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
889
890         Minor clean-up of prepare-ChangeLog script.
891
892         Reviewed by Adam.
893
894         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
895         of a string.  Use multi-argument versions of open() and system() for flexibility and
896         security.
897
898 2007-10-24  Alice Liu  <alice.liu@apple.com>
899
900         Reviewed by Oliver.
901
902         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
903
904         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
905         replay the saved events when we're still processing the mousedown that starts the drag
906         * DumpRenderTree/win/EventSender.cpp:
907         (doMouseMove):
908         * DumpRenderTree/win/UIDelegate.cpp:
909         (UIDelegate::doDragDrop):
910
911 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
912
913         Reviewed by Sam, Steve and Darin.
914
915         - Stubbed out the WebScriptDebugListener functionality in the Server
916         Connection class to prepare it for receiving those callbacks.
917         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
918         and the ServerConnection to not need to be initialized with a server
919         name, since that is not the way we connect to the WebKit server. 
920
921         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
922         no exception.  Now it only loggs when there is an exception
923         (DebuggerDocument::willExecuteStatement):
924         (DebuggerDocument::didEnterCallFrame):
925         (DebuggerDocument::willLeaveCallFrame):
926         (DebuggerDocument::windowScriptObjectAvailable):
927         (DebuggerDocument::callFunctionOnObject):
928         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
929         to be instantiated with a server's name.
930         (DebuggerClient::DebuggerClient):
931         (DebuggerClient::didFinishLoadForFrame):
932         * Drosera/win/DebuggerClient.h: Removed unsued variable.
933         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
934         a server name.
935         (Drosera::init):
936         (Drosera::initServer):
937         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
938         instantiated with a server's name.
939         * Drosera/win/ServerConnection.cpp: 
940         (ServerConnection::ServerConnection): No longer needs a server name
941         (ServerConnection::~ServerConnection): Only release the global context
942         if there is one.
943         (ServerConnection::serverConnectionDidDie): Stub for
944         IWebScriptDebugListener
945         (ServerConnection::QueryInterface): ditto
946         (ServerConnection::AddRef): ditto
947         (ServerConnection::Release): ditto
948         (ServerConnection::didLoadMainResourceForDataSource): ditto
949         (ServerConnection::didParseSource): ditto
950         (ServerConnection::failedToParseSource): ditto
951         (ServerConnection::didEnterCallFrame): ditto
952         (ServerConnection::willExecuteStatement): ditto
953         (ServerConnection::willLeaveCallFrame): ditto
954         (ServerConnection::exceptionWasRaised): ditto
955         * Drosera/win/ServerConnection.h: Stubbed out the
956         IWebScriptDebugListener functions, and this class no longer needs to be
957         instantiated with a server name.
958
959 2007-10-24  Lars Knoll  <lars@trolltech.com>
960
961         Reviewed by Simon.
962
963         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
964
965         * DumpRenderTree/qt/jsobjects.h:
966
967 2007-10-24  Lars Knoll  <lars@trolltech.com>
968
969         Reviewed by Simon.
970
971         add another command.
972
973         * DumpRenderTree/qt/jsobjects.cpp:
974         (TextInputController::doCommand):
975
976 2007-10-24  Lars Knoll  <lars@trolltech.com>
977
978         Reviewed by Simon.
979
980         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
981
982         * DumpRenderTree/qt/jsobjects.cpp:
983         (EventSender::keyDown):
984         * DumpRenderTree/qt/jsobjects.h:
985
986 2007-10-24  Lars Knoll  <lars@trolltech.com>
987
988         Reviewed by Simon.
989
990         implement eventSender.keyDown().
991
992         * DumpRenderTree/qt/jsobjects.cpp:
993         (EventSender::keyDown):
994
995 2007-10-24  Lars Knoll  <lars@trolltech.com>
996
997         Reviewed by Simon.
998
999         some smaller fixes to the editing support in DRT. Makes another few tests pass.
1000
1001         * DumpRenderTree/qt/DumpRenderTree.cpp:
1002         (WebCore::DumpRenderTree::DumpRenderTree):
1003         (WebCore::DumpRenderTree::initJSObjects):
1004         * DumpRenderTree/qt/jsobjects.cpp:
1005         (TextInputController::doCommand):
1006
1007 2007-10-24  Lars Knoll  <lars@trolltech.com>
1008
1009         Reviewed by Simon.
1010
1011         first bit of implementation for the textinputcontroller.
1012
1013         * DumpRenderTree/qt/DumpRenderTree.cpp:
1014         (WebCore::DumpRenderTree::DumpRenderTree):
1015         * DumpRenderTree/qt/DumpRenderTree.h:
1016         * DumpRenderTree/qt/jsobjects.cpp:
1017         (TextInputController::TextInputController):
1018         (TextInputController::doCommand):
1019         * DumpRenderTree/qt/jsobjects.h:
1020
1021 2007-10-24  Lars Knoll  <lars@trolltech.com>
1022
1023         Reviewed by Simon.
1024
1025         make the man webpage believe it has focus, so the editing tests work correctly.
1026
1027         * DumpRenderTree/qt/DumpRenderTree.cpp:
1028         (WebCore::DumpRenderTree::DumpRenderTree):
1029
1030 2007-10-24  Lars Knoll  <lars@trolltech.com>
1031
1032         Reviewed by Simon.
1033
1034         implement layoutTestController.dumpEditingCallbacks() correctly.
1035
1036         * DumpRenderTree/qt/DumpRenderTree.cpp:
1037         (WebCore::DumpRenderTree::DumpRenderTree):
1038         * DumpRenderTree/qt/jsobjects.cpp:
1039         (LayoutTestController::reset):
1040         (LayoutTestController::dumpEditingCallbacks):
1041
1042 2007-10-24  Lars Knoll  <lars@trolltech.com>
1043
1044         Reviewed by Simon.
1045
1046         Implement support for testing editing.
1047
1048         * DumpRenderTree/qt/DumpRenderTree.cpp:
1049         (WebCore::DumpRenderTree::DumpRenderTree):
1050
1051 2007-10-23  Sam Weinig  <sam@webkit.org>
1052
1053         Check for null BSTR that can be passed to the UIDelegate methods
1054         from javascript null and undefined.  Fixes a failing test case on
1055         Windows (fast/dom/Window/alert-undefined.html)
1056
1057         Reviewed by Eric Seidel.
1058
1059         * DumpRenderTree/win/UIDelegate.cpp:
1060         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1061         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1062         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1063         (UIDelegate::webViewAddMessageToConsole):
1064
1065 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1066
1067         Reviewed by Darin.
1068         
1069         Don't print a massive pile of setenvs from tools that automatically build testkjs.
1070
1071         * Scripts/build-testkjs:
1072
1073 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1074
1075         Reviewed by Darin.
1076
1077         - add wrapper that finds the right copy of testkjs
1078         
1079         * Scripts/sunspider-compare-results: Added.
1080
1081 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
1082
1083         Reviewed by Sam.
1084
1085         - After talking with Steve I now see that the WebKit server must be
1086         running for DCOM to create the distributed objects, which makes sense
1087         and currently WebKit only allows one instance to be running at a time
1088         which avoids accidentally connecting to the wrong server
1089         - In light of this I have removed the code for the attach box and
1090         NotificationServer and known server names, since they are all extranious
1091         now.
1092
1093         * Drosera/win/Drosera.cpp: Removed notification classes and known server
1094         names.
1095         (_tWinMain): Uses init instead of initUI.
1096         (droseraWndProc): No longer creats an attach dialog box.
1097         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
1098         it's not manditory to call init before doing COM stuff.
1099         (Drosera::init): calls initUI and will call attach when the
1100         functionality exists. 
1101         (Drosera::initUI): Has changed very little.
1102         (Drosera::attach): Changed the signature to reflect that we no longer
1103         need the dictionary of known server names.
1104         * Drosera/win/Drosera.h: Removed notification classes and known server
1105         names.  Also renamed and moved some functions.
1106         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
1107         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
1108         headers to the resources folder. 
1109         * Drosera/win/resource.h: Removed the Attach box.
1110
1111 2007-10-22  Adam Roben  <aroben@apple.com>
1112
1113         Windows build fix
1114
1115         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
1116
1117 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
1118
1119         - Removed a leak that was fixed.
1120
1121         * Scripts/run-webkit-tests:
1122
1123 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1124
1125         Reviewed by Darin.
1126
1127         - Changed the Client so that the DebuggerDocument now own the
1128         ServerConnection.  This simplifies ownership and cleanup. 
1129
1130         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
1131         ServerConnection.
1132         (DebuggerClient::initWithServerName):
1133         (DebuggerClient::didFinishLoadForFrame):
1134         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
1135         ServerConnection.
1136         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
1137         until after we have a server which we are attached to.
1138         (Drosera::initUI):
1139         (Drosera::attach):
1140         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
1141         out previously.
1142
1143 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1144
1145         Reviewed by Nikolas.
1146
1147         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
1148
1149         * Scripts/run-javascriptcore-tests:
1150
1151 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1152
1153         Reviewed by Nikolas.
1154
1155         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
1156
1157         * Scripts/build-drosera:
1158         * Scripts/build-dumprendertree:
1159         * Scripts/build-testkjs:
1160         * Scripts/build-webkit:
1161         * Scripts/run-javascriptcore-tests:
1162         * Scripts/run-sunspider:
1163         * Scripts/run-webkit-tests:
1164         * Scripts/webkitdirs.pm:
1165
1166 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
1167
1168         Reviewed by Mark Rowe.
1169         
1170         Fix for local database support after r26879
1171         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1172
1173         * Scripts/build-webkit:
1174
1175 2007-10-22  Holger Freyther  <zecke@selfish.org>
1176
1177         Reviewed by Simon Hausmann <hausmann@kde.org>.
1178
1179         - Do not build testkjs as an application bundle. This is
1180         needed for run-javascriptcore-tests on OSX.
1181         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
1182         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
1183         as we do not have -rpath on OSX.
1184
1185         * DumpRenderTree/qt/DumpRenderTree.pro:
1186         * Scripts/run-webkit-tests:
1187
1188 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1189
1190         Reviewed by aroben.
1191
1192         Fix support for Signed-off-by detection in prepare-ChangeLog
1193         --git-commit. The Signed-off-by tag does not appear in the header
1194         but usually at the end.
1195
1196         * Scripts/prepare-ChangeLog:
1197
1198 2007-10-21  Mark Rowe  <mrowe@apple.com>
1199
1200         Reviewed by Eric.
1201
1202         Fix run-javascriptcore-tests for Gtk.
1203
1204         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
1205
1206 2007-10-20  Eric Seidel  <eric@webkit.org>
1207
1208         Reviewed by aroben.
1209
1210         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
1211
1212 2007-10-20  Eric Seidel  <eric@webkit.org>
1213
1214         Reviewed by darin.
1215         
1216         Add improved argument handling to run-sunspider, including
1217         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
1218         Also re-factor code into subroutines
1219
1220         * Scripts/build-dumprendertree: removed bogus comments
1221         * Scripts/build-testkjs: Added.
1222         * Scripts/run-javascriptcore-tests: use build-testkjs
1223         * Scripts/run-sunspider: improved argument handling, abstraction
1224         * Scripts/run-webkit-tests: improved abstraction
1225
1226 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
1227
1228         Not reviewed, Windows build fix.
1229
1230         * DumpRenderTree/win/EventSender.cpp:
1231         (keyDownCallback):
1232
1233 2007-10-20  Darin Adler  <darin@apple.com>
1234
1235         Reviewed by Tim Hatcher.
1236
1237         - http://bugs.webkit.org/show_bug.cgi?id=15544
1238           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
1239           not rely on Apple-specific key codes
1240
1241         * DumpRenderTree/mac/EventSendingController.mm:
1242         (-[EventSendingController keyDown:withModifiers:]):
1243         Added named key "rightArrow". Later we could have a whole table of these.
1244         Also tweaked modifiers code a little.
1245
1246         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
1247
1248 2007-10-19  Darin Adler  <darin@apple.com>
1249
1250         Reviewed by Eric.
1251
1252         - http://bugs.webkit.org/show_bug.cgi?id=15566
1253           possible fix for leak seen in DumpRenderTree
1254
1255         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
1256         Delete the item if it's not put on the queue, since the caller has
1257         no way of knowing that. Would be better to have the parameter type
1258         be auto_ptr to express the fact that we take ownership.
1259
1260         - unrelated change
1261
1262         * Drosera/mac/main.m: Add missing include.
1263
1264 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1265
1266         Reviewed by Adam.
1267
1268         - This change should be identical but for some reason was not working
1269         on my machine.
1270
1271         * Scripts/prepare-ChangeLog:
1272
1273 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1274
1275         Reviewed by Oliver and Tim.
1276
1277         - Made use of RetainPtr to avoid retain and release issues and moved the
1278         log function to DebuggerDocumentPlatform, which seems to be a more
1279         logical place for it to live.
1280         - Also moved knownServers from the ServerConnection to
1281         DebuggerApplication to match the Windows code and because it makes sense
1282         that a connection knows its own server but not all of them.
1283
1284         * Drosera/mac/DebuggerClient.h: Moved the log function to
1285           DebuggerDocumentPlatform.
1286         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
1287           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
1288           call for the server name up from the ServerConnection class.
1289         (-[DebuggerClient dealloc]):
1290         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
1291           for the server name up from the ServerConnection.
1292         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
1293         (DebuggerDocument::platformPause):
1294         (DebuggerDocument::platformResume):
1295         (DebuggerDocument::platformStepInto):
1296         (DebuggerDocument::platformEvaluateScript):
1297         (DebuggerDocument::getPlatformCurrentFunctionStack):
1298         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1299         (DebuggerDocument::platformValueForScopeVariableNamed):
1300         (DebuggerDocument::platformLog): Log directly from here. No need to call
1301           DebuggerClient.
1302         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
1303           way I see it, a ServerConnection should only know about its connection
1304           and the group of all possible servers should be kept by the
1305           application.
1306         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
1307           currentServerName, it makes sense that the connection should know that
1308           name.
1309         (-[ServerConnection currentServerName]):
1310
1311 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1312
1313         Reviewed by Adam.
1314
1315         - Integrated changes from mac drosera.  Recently I've encapsulated
1316         out the server connection object from the rest of Drosera because
1317         it is very platform dependent right now and RPC is not implemented on
1318         windows.  This functionality, of communicating with the WebKit server
1319         is the next area I will be focusing on in Windows.
1320
1321         - Other changes and cleanup were made to organize the code and add notes
1322         on which parts still need work.  Also some mac code is added and
1323         commented out, to act as pseudocode for the logic of those parts.
1324
1325         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
1326           pointer.
1327         * Drosera/config.h: Added whitespace.
1328         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
1329           these files got moved into Drosera.h/cpp
1330         * Drosera/win/DebuggerApplication.h: Removed.
1331         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
1332           happened here to better match the logic flow of the same code on the 
1333           mac side and to use the new ServerConnection class.
1334         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
1335         (DebuggerClient::initWithServerName): Initializer that will set up the
1336           class to use a ServerConnection object.  This was necessary so I could
1337           create a DebuggerClient without having to initilaize it at
1338           construction.
1339         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
1340           will be the UIDelegate and FrameLoadDelegate.
1341         (DebuggerClient::AddRef): For IUnknown.
1342         (DebuggerClient::Release): For IUnknown.
1343         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
1344           this still needs to set the global context of the server, but
1345           IWebFrame does not have an accessor for the global context yet. 
1346         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
1347           this is a pass through for the same function in the document.
1348         (DebuggerClient::didReceiveTitle): Unimplemented part of
1349           FrameLoadDelegate this would change the title of the window.
1350         (DebuggerClient::createWebViewWithRequest): Part of the
1351           FrameLoadDelegate.  This is about new windows via Window.open() and
1352           how their delegates are set.
1353         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
1354           UIDelegate.  Just a debug function for printing messages.
1355         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
1356           because the Client should be the UIDelegate and FrameLoadDelegate
1357           to match the delegates on mac.
1358         (DebuggerClient::webViewLoaded): Added accessor method.
1359         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
1360           forgotten to add this file before.  This is where the platform
1361           dependent versions of the Documents functions live. Most of these are
1362           unimplemented because some piece of functionality does not exist on
1363           Windows yet.
1364         (DebuggerDocument::platformPause):
1365         (DebuggerDocument::platformResume):
1366         (DebuggerDocument::platformStepInto):
1367         (DebuggerDocument::platformEvaluateScript):
1368         (DebuggerDocument::getPlatformCurrentFunctionStack):
1369         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1370         (DebuggerDocument::platformValueForScopeVariableNamed):
1371         (DebuggerDocument::platformLog):
1372         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
1373           responsibilities becaue they belong in the Client. Also I laid the
1374           groundwork for attaching Drosera to a WebKit process
1375         (attachWndProc): Now if a server is selected the Client becomes it's
1376           delegate.
1377         (Drosera::Drosera): Added the construction of the Client and dictionary
1378           of server names. 
1379         (Drosera::initUI): This is no longer the delegates, the Client is.
1380         (Drosera::webViewLoaded): Now asks the Client instead of holding local
1381           state. 
1382         (Drosera::applicationDidFinishLaunching): Placeholder for needed
1383           notification registration when it's possible to implement.
1384         (Drosera::serverLoaded): Ditto
1385         (Drosera::serverUnloaded): Ditto
1386         (Drosera::attach): Attach Drosera to the WebKit server.
1387         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
1388         (Drosera::getInst): 
1389         (Drosera::setInst):
1390         (Drosera::knownServers):
1391         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
1392           and added the ServerConnection.
1393         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
1394         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
1395           Most of the functions are completely unimlemented because they cannot
1396           connect with the WebKit server, because one does not exist on Windows
1397           yet.
1398         (ServerConnection::initWithServerName): 
1399         (ServerConnection::~ServerConnection):
1400         (ServerConnection::setGlobalContext):
1401         (ServerConnection::pause):
1402         (ServerConnection::resume):
1403         (ServerConnection::stepInto):
1404         (ServerConnection::switchToServerNamed):
1405         (ServerConnection::applicationTerminating):
1406         (ServerConnection::serverConnectionDidDie):
1407         (ServerConnection::currentFrame):
1408         * Drosera/win/ServerConnection.h: Added. Ditto.
1409         (ServerConnection::ServerConnection):
1410
1411 2007-10-19  Alice Liu  <alice.liu@apple.com>
1412
1413         Reviewed by Darin.
1414
1415         Fix for these broken layout tests on Windows:
1416         
1417         fast/forms/focus-selection-input.html
1418         fast/forms/focus-selection-textarea.html
1419         fast/forms/select-accesskey.html
1420         
1421         * DumpRenderTree/win/EventSender.cpp:
1422         (keyDownCallback):
1423         correct the VK code for alt key.
1424         
1425 2007-10-19  Eric Seidel  <eric@webkit.org>
1426
1427         Reviewed by Mark Rowe.
1428         
1429         Make the GtkLauncher code slightly more readable.
1430
1431         * GtkLauncher/main.cpp:
1432         (setupMainMenu): Added.
1433         (setupMainWindowUI): Added.
1434         (main):
1435
1436 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
1437
1438         Rubber stamped by Adam.
1439         
1440         - don't delay-load WebKit in DumpRenderTree.
1441
1442         * DumpRenderTree/win/DumpRenderTree.vcproj:
1443
1444 2007-10-18  Dan Bernstein  <mitz@apple.com>
1445
1446         Reviewed by Adam Roben.
1447
1448         - fix <rdar://problem/5313523>
1449         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
1450
1451         * DumpRenderTree/mac/DumpRenderTree.mm:
1452         (dump): Changed to use _responseMIMEType.
1453
1454 2007-10-17  Adam Roben  <aroben@apple.com>
1455
1456         Make it possible to have Windows-specific tests and results
1457
1458         When searching for tests to run and the Skipped file, we will only
1459         look in platform/win and the cross-platform directory. When looking
1460         for expected results, we will look in platform/win, then
1461         platform/mac-leopard, then platform/mac, then finally the
1462         cross-platform directory.
1463
1464         Reviewed by Sam.
1465
1466         * Scripts/run-webkit-tests:
1467         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
1468         searching in the cross-platform directory.
1469         (sub buildPlatformHierarchy): Removed some unneeded calls to
1470         dirname/basename.
1471
1472 2007-10-17  Adam Roben  <aroben@apple.com>
1473
1474         Add back the call to register WebKit that we had before WebKitInitializer existed
1475
1476         This is needed to ensure that the right WebKit is used when
1477         instantiating COM objects.
1478
1479         Reviewed by Oliver.
1480
1481         * DumpRenderTree/win/debug_internal.vsprops: Define
1482         DEBUG_WEBKIT_HAS_SUFFIX.
1483         * DumpRenderTree/win/DumpRenderTree.cpp:
1484         (initialize):
1485
1486 2007-10-17  Adam Roben  <aroben@apple.com>
1487
1488         Import File::Basename in webkitdirs since we use it
1489
1490         * Scripts/webkitdirs.pm:
1491
1492 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
1493
1494         - Updated the tiger leaks list to make the internal bots green.
1495
1496         * Scripts/run-webkit-tests:
1497
1498 2007-10-17  Adam Roben  <aroben@apple.com>
1499
1500         Build fix for VC++ Express
1501
1502         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
1503         and ole32.lib.
1504
1505 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1506
1507         Reviewed by Sam.
1508
1509         - Minor mac improvements based on observations I made while implementing the
1510         Windows code.
1511
1512         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
1513         then hand it to the Client who will retain it, it should just be the client who
1514         creates and owns the server.
1515         (-[DebuggerApplication attach:]):
1516         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
1517         * Drosera/mac/DebuggerClient.mm: Creates the server.
1518         (-[DebuggerClient initWithServerName:]):
1519         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
1520         can instead forward declare what it needs.
1521
1522 2007-10-16  Darin Adler  <darin@apple.com>
1523
1524         Reviewed by Geoff Garen.
1525
1526         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
1527         want to turn failing tests into platform-specific test results. Also did a
1528         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
1529         would take the type of results into account only some of the time.
1530
1531 2007-10-16  Adam Roben  <aroben@apple.com>
1532
1533         Add a new nightly launcher script for Windows
1534
1535         This new script is for versions of Safari that don't delay-load
1536         WebKit. I had to make FindSafari be able to print out the nightly
1537         launcher script on stdout because Windows shell scripts can't capture
1538         the output from a command into an environment variable.
1539
1540         Reviewed by Steve.
1541
1542         * FindSafari/FindSafari.cpp:
1543         (_tmain): Added /printSafariLauncher option.
1544         * Scripts/run-webkit-nightly.cmd: Added.
1545
1546 2007-10-16  Adam Roben  <aroben@apple.com>
1547
1548         Replace WebKitInitializer with FindSafari
1549
1550         We now rely on setting the PATH environment variable to tell Windows
1551         where to find WebKit and its dependencies (similar to
1552         DYLD_FRAMEWORK_PATH on Mac).
1553
1554         This change also make DumpRenderTree no longer delay-load WebKit.
1555
1556         Reviewed by Sam.
1557
1558         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
1559         FindSafari.
1560         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
1561         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
1562         WebKitInitializer, don't delay-load WebKit.
1563         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
1564         * Scripts/run-webkit-tests: Ditto.
1565         * Scripts/webkitdirs.pm:
1566         (sub setPathForRunningWebKitApp): Added.
1567         * WebKitInitializer/WebKitInitializer.cpp: Removed.
1568         * WebKitInitializer/WebKitInitializer.h: Removed.
1569         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
1570         * WebKitInitializer/debug.vsprops: Removed.
1571         * WebKitInitializer/debug_internal.vsprops: Removed.
1572         * WebKitInitializer/release.vsprops: Removed.
1573
1574 2007-10-16  Adam Roben  <aroben@apple.com>
1575
1576         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
1577
1578         http://bugs.webkit.org/show_bug.cgi?id=15532
1579
1580         FindSafari simply prints the location of an installed Safari.exe on
1581         stdout.
1582
1583         Reviewed by Darin.
1584
1585         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
1586         (getStringValue):
1587         (getWebViewCLSID):
1588         (getInstalledWebKitDirectory):
1589         (_tmain):
1590         * FindSafari/FindSafari.vcproj: Added.
1591         * Scripts/webkitdirs.pm:
1592         (sub installedSafariPath): Added. Calls FindSafari on Windows.
1593
1594 2007-10-16  Adam Roben  <aroben@apple.com>
1595
1596         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
1597
1598         Reviewed by Kevin McCullough.
1599
1600         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
1601         when referring to WebKit.dll.
1602         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
1603         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
1604         * DumpRenderTree/win/release.vsprops: Ditto.
1605         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
1606         never have a _debug suffix on WebKit.dll.
1607         * WebKitInitializer/WebKitInitializer.cpp:
1608         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
1609         specified.
1610         * WebKitInitializer/debug_internal.vsprops: Added
1611         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
1612
1613 2007-10-16  Darin Adler  <darin@apple.com>
1614
1615         Reviewed by Adele.
1616
1617         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
1618         Remove now-unneeded control/alt key hack; the tests have been updated.
1619
1620 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1621
1622         - Updated leaks list because our internal bot upgraded it's version of leopard and 
1623         one of the leaks was fixed between that revision and the bot's previous version of
1624         leopard.
1625
1626         * Scripts/run-webkit-tests:
1627
1628 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
1629
1630         Reviewed by Tim.
1631
1632         - I encapsulated out the server connecton functionality because it is a specific part
1633         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
1634         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
1635         Windows.  So the majority of this patch is moving preexisting functionality.
1636
1637         - Also I removed the prefix header and changed to use config.h because it is more
1638         standard on how we use config.h in windows and it didn't make much sense to keep
1639         the prefix header and the config.h
1640
1641         * Drosera/DebuggerDocument.cpp:
1642         (DebuggerDocument::DebuggerDocument):
1643         * Drosera/DebuggerDocument.h:
1644         * Drosera/config.h:
1645         * Drosera/mac/DebuggerApplication.mm:
1646         (-[DebuggerApplication attach:]):
1647         * Drosera/mac/DebuggerClient.h:
1648         * Drosera/mac/DebuggerClient.mm:
1649         (-[DebuggerClient initWithServerConnection:]):
1650         (-[DebuggerClient dealloc]):
1651         (-[DebuggerClient windowDidLoad]):
1652         (-[DebuggerClient windowWillClose:]):
1653         (-[DebuggerClient webView:didFinishLoadForFrame:]):
1654         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
1655         * Drosera/mac/DebuggerDocumentPlatform.mm:
1656         (DebuggerDocument::platformPause):
1657         (DebuggerDocument::platformResume):
1658         (DebuggerDocument::platformStepInto):
1659         (DebuggerDocument::platformEvaluateScript):
1660         (DebuggerDocument::getPlatformCurrentFunctionStack):
1661         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1662         (DebuggerDocument::platformValueForScopeVariableNamed):
1663         (DebuggerDocument::platformLog):
1664         * Drosera/mac/Drosera.pch: Removed.
1665         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1666         * Drosera/mac/ServerConnection.h: Added.
1667         * Drosera/mac/ServerConnection.mm: Added.
1668         (-[ServerConnection initWithServerName:]):
1669         (-[ServerConnection dealloc]):
1670         (-[ServerConnection setGlobalContext:]):
1671         (-[ServerConnection pause]):
1672         (-[ServerConnection resume]):
1673         (-[ServerConnection stepInto]):
1674         (-[ServerConnection switchToServerNamed:]):
1675         (-[ServerConnection applicationTerminating:]):
1676         (-[ServerConnection serverConnectionDidDie:]):
1677         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1678         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1679         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1680         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1681         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1682         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1683         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1684         (-[ServerConnection currentFrame]):
1685         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
1686         (-[ServerConnection knownServers]):
1687
1688 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
1689
1690         Reviewed by Eric.
1691
1692         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
1693           Script to automatically search nightly builds for regressions (bisect-builds)
1694
1695         * Scripts/bisect-builds: Added.
1696
1697 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
1698
1699         Reviewed by Darin.
1700
1701         - New JavaScript benchmark
1702         http://bugs.webkit.org/show_bug.cgi?id=15515
1703
1704         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1705         current development or release build of JavaScriptCore.
1706
1707 2007-10-15  Mark Rowe  <mrowe@apple.com>
1708
1709         Reviewed by Sam.
1710
1711         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1712
1713         * Scripts/webkitdirs.pm:
1714         - Change checkArgv to remove the options from @ARGV to prevent
1715         them from interfering with further option processing.
1716         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1717         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1718         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1719         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1720
1721 2007-10-15  Darin Adler  <darin@apple.com>
1722
1723         Reviewed by Sam.
1724
1725         - added logging of window.prompt and window.confirm
1726
1727         * DumpRenderTree/mac/UIDelegate.mm:
1728         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1729         Implement the recommended delegate rather than the deprecated one.
1730         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
1731         Added.
1732         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1733         Added.
1734
1735         * DumpRenderTree/win/UIDelegate.h:
1736         * DumpRenderTree/win/UIDelegate.cpp:
1737         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
1738         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1739         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
1740         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
1741
1742 2007-10-15  Alice Liu  <alice.liu@apple.com>
1743
1744         Reviewed by Sam Weinig.
1745
1746         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
1747
1748         * DumpRenderTree/win/DumpRenderTree.cpp:
1749         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
1750         (main): allocate the global policy delegate for DRT's custom use
1751         * DumpRenderTree/win/DumpRenderTree.vcproj:
1752         Adding files to project
1753         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
1754         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1755         (LayoutTestController::setCustomPolicyDelegate):
1756         set the webview's policy delegate to DRT's custom one if the test requests it.
1757         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
1758         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
1759         (PolicyDelegate::PolicyDelegate):
1760         (PolicyDelegate::QueryInterface):
1761         (PolicyDelegate::AddRef):
1762         (PolicyDelegate::Release):
1763         (PolicyDelegate::decidePolicyForNavigationAction):
1764         * DumpRenderTree/win/PolicyDelegate.h: Added.
1765         (PolicyDelegate::decidePolicyForNewWindowAction):
1766         (PolicyDelegate::decidePolicyForMIMEType):
1767         (PolicyDelegate::unableToImplementPolicyWithError):
1768
1769 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1770
1771         Reviewed by Mark.
1772
1773         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
1774         when querying for QMAKE_MKSPECS.
1775
1776 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
1777
1778         Reviewed by Adam Roben.
1779         
1780         Fix run-webkit-tests is too greedy calculating platform hierarchy
1781         http://bugs.webkit.org/show_bug.cgi?id=15465
1782         
1783         Fix run-webkit-tests being too greedy in trying to split the platform name up
1784         causing it to try and find tests in every directory above the first "-" in the
1785         path to the LayoutTests
1786
1787         * Scripts/run-webkit-tests:
1788
1789 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
1790
1791         Reviewed by Darin.
1792
1793         http://bugs.webkit.org/show_bug.cgi?id=15006
1794         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
1795         to reduce code duplication.
1796
1797         * Scripts/build-webkit:
1798         * Scripts/webkitdirs.pm:
1799         buildQMakeProject() renamed to buildQMakeQtProject().
1800         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
1801         unused $colorize has been removed.
1802
1803 === Start merge of feature-branch 2007-10-12 ===
1804
1805 2007-10-08  Eric Seidel  <eric@webkit.org>
1806
1807         Reviewed by Mark Rowe.
1808
1809         * Scripts/build-webkit: add --help, remove unused --color
1810
1811 2007-10-07  Eric Seidel  <eric@webkit.org>
1812
1813         Reviewed by darin.
1814
1815         * Drosera/mac/DebuggerDocumentPlatform.mm:
1816         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
1817
1818 2007-10-03  Rob Buis  <buis@kde.org>
1819
1820         Reviewed by Olliej.
1821
1822         Adapt to changed location of Ahem font.
1823
1824         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1825
1826 2007-10-02  Eric Seidel  <eric@webkit.org>
1827
1828         Reviewed by Adam Roben.
1829         
1830         Make pixel tests more useful!
1831         Finally fix the image diff 0.00% mystery problem
1832         Highlight any image differences in the image diff.
1833         Add a link from image diffs back to original test file.
1834
1835         * DumpRenderTree/mac/ImageDiff.m:
1836         (compareImages): highlight any differences
1837         (computePercentageDifferent): round to two decimal places
1838         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
1839
1840 2007-10-02  Eric Seidel  <eric@webkit.org>
1841
1842         Reviewed by Alexey Proskuryakov.
1843
1844         * Scripts/run-webkit-tests: print the % image difference on main results page
1845
1846 2007-10-02  Mark Rowe  <mrowe@apple.com>
1847
1848         Reviewed by Oliver.
1849
1850         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1851
1852         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1853         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1854
1855 2007-10-01  Mark Rowe  <mrowe@apple.com>
1856
1857         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1858
1859 2007-09-25  Eric Seidel  <eric@webkit.org>
1860
1861         Reviewed by Mark Rowe.
1862         
1863         DerivedSources.make was finding "ENABLE_SVG" in the string
1864         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
1865         quite correctly.
1866
1867         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
1868
1869 2007-09-25  Mark Rowe  <mrowe@apple.com>
1870
1871         Rubber-stamped by Eric.
1872
1873         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1874         This makes it possible to automate nightly builds for the feature-branch.
1875
1876 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
1877
1878         Rubber stamped by Mark.
1879
1880         Enable svg experimental features as default here in feature-branch.
1881
1882         * Scripts/build-webkit:
1883
1884 2007-06-29  Antti Koivisto  <antti@apple.com>
1885
1886         Reviewed by Weinig.
1887         
1888         Add VIDEO flag for timed media features
1889
1890         * Scripts/build-webkit
1891         
1892 === End merge of feature-branch 2007-10-12 ===
1893
1894 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1895
1896         Reviewed by Darin.
1897
1898         - Updated rational for the leaks list to be more clear.
1899
1900         * Scripts/run-webkit-tests:
1901
1902 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1903
1904         Rubber Stamp by Sam.
1905
1906         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
1907         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
1908
1909         * Scripts/run-webkit-tests:
1910
1911 2007-10-10  Simon Hausmann  <hausmann@kde.org>
1912
1913         Reviewed by Lars.
1914
1915         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
1916         includes are needed for INT_MAX, std::auto_ptr and the like.
1917
1918         * DumpRenderTree/qt/main.cpp:
1919
1920 2007-10-09  Lars Knoll  <lars@trolltech.com>
1921
1922         Reviewed by Simon.
1923
1924         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
1925
1926         * DumpRenderTree/qt/jsobjects.cpp:
1927         (LayoutTestController::encodeHostName):
1928         (LayoutTestController::decodeHostName):
1929         * DumpRenderTree/qt/jsobjects.h:
1930
1931 2007-10-09  Lars Knoll  <lars@trolltech.com>
1932
1933         Reviewed by Simon.
1934
1935         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
1936
1937         * DumpRenderTree/qt/DumpRenderTree.cpp:
1938         (WebCore::WebPage::createFrame):
1939         (WebCore::DumpRenderTree::DumpRenderTree):
1940         (WebCore::DumpRenderTree::titleChanged):
1941         * DumpRenderTree/qt/DumpRenderTree.h:
1942         * DumpRenderTree/qt/jsobjects.cpp:
1943         (LayoutTestController::reset):
1944         * DumpRenderTree/qt/jsobjects.h:
1945
1946 2007-10-09  Lars Knoll  <lars@trolltech.com>
1947
1948         Reviewed by Simon.
1949
1950         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
1951
1952         * DumpRenderTree/qt/DumpRenderTree.h:
1953         * DumpRenderTree/qt/jsobjects.cpp:
1954         (LayoutTestController::clearBackForwardList):
1955         * DumpRenderTree/qt/jsobjects.h:
1956
1957 2007-10-09  Lars Knoll  <lars@trolltech.com>
1958
1959         Reviewed by Simon.
1960
1961         make --git-reviewer work again.
1962
1963         * Scripts/prepare-ChangeLog:
1964
1965 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
1966
1967         Rubber stamped by Eric.
1968
1969         Connect to the "hovering-over-link" signal emitted by WebKitPage and
1970         show the current link inside the statusbar.
1971         This shows how to make use of this signal and allows to easily test
1972         http://bugs.webkit.org/show_bug.cgi?id=15299.
1973
1974         * GtkLauncher/main.cpp:
1975         (hoveringOverLink):
1976         (main):
1977
1978 2007-10-05  Lars Knoll  <lars@trolltech.com>
1979
1980         add proper error messages to the FrameLoaderClient.
1981         Implement ChromeClientQt::closeWindowSoon and
1982         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
1983         Some fixes in DRT to make it work correctly with multiple windows.
1984
1985         Reviewed by Maciej.
1986
1987         * DumpRenderTree/qt/DumpRenderTree.cpp:
1988         (WebCore::DumpRenderTree::DumpRenderTree):
1989         (WebCore::DumpRenderTree::createWindow):
1990         (WebCore::DumpRenderTree::windowCount):
1991         * DumpRenderTree/qt/DumpRenderTree.h:
1992         * DumpRenderTree/qt/jsobjects.cpp:
1993         (LayoutTestController::maybeDump):
1994         (LayoutTestController::windowCount):
1995         * DumpRenderTree/qt/jsobjects.h:
1996
1997 2007-10-05  Lars Knoll  <lars@trolltech.com>
1998
1999         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
2000         Add support for layoutTextController.setCanOpenWindows() to DRT
2001         fixing another 2 test cases in fast/dom/Window.
2002
2003         Reviewed by Maciej.
2004
2005         * DumpRenderTree/qt/DumpRenderTree.cpp:
2006         (WebCore::WebPage::WebPage):
2007         (WebCore::WebPage::createWindow):
2008         (WebCore::DumpRenderTree::resetJSObjects):
2009         (WebCore::DumpRenderTree::createWindow):
2010         * DumpRenderTree/qt/DumpRenderTree.h:
2011         * DumpRenderTree/qt/DumpRenderTree.pro:
2012         * DumpRenderTree/qt/jsobjects.cpp:
2013         (LayoutTestController::LayoutTestController):
2014         (LayoutTestController::reset):
2015         * DumpRenderTree/qt/jsobjects.h:
2016         * DumpRenderTree/qt/main.cpp:
2017         * DumpRenderTree/qt/testplugin.cpp: Added.
2018         * DumpRenderTree/qt/testplugin.h: Added.
2019
2020 2007-10-04  Sam Weinig  <sam@webkit.org>
2021
2022         Rubber stamped by Adam.
2023
2024         Remove empty directories.
2025
2026         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2027         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2028
2029 2007-10-03  Darin Adler  <darin@apple.com>
2030
2031         Reviewed by Adam.
2032
2033         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2034         we find the internal libraries in the libraries directory. This
2035         is helpful for Safari team engineers at Apple.
2036
2037 2007-10-03  Adam Roben  <aroben@apple.com>
2038
2039         Update the location of AHEM___.TTF after r25968
2040
2041         Reviewed by Sam.
2042
2043         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2044
2045 2007-10-03  Alp Toker  <alp@atoker.com>
2046
2047         Reviewed by Adam.
2048
2049         http://bugs.webkit.org/show_bug.cgi?id=14726
2050         [gtk] API design. Mapping the WebView delegates to signals.
2051
2052         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2053
2054         * GtkLauncher/main.cpp:
2055         (goToURLBarText):
2056         (titleChanged):
2057         (progressChanged):
2058         (menuMainBackCallback):
2059         (menuMainForwardCallback):
2060         (main):
2061
2062 2007-10-03  Lars Knoll  <lars@trolltech.com>
2063
2064         Reviewed by Rob.
2065
2066         This fixes --strict mode in run-webkit-tests again after
2067         the platform dependent test results have been moved.
2068
2069         * Scripts/run-webkit-tests:
2070
2071 2007-10-03  Lars Knoll  <lars@trolltech.com>
2072
2073         Reviewed by bdash.
2074
2075         remove the hack in run-webkit-tests that forced text only test
2076         to be taken from the platform independent dir. It was only left
2077         there from early days.
2078         
2079         Remove platform dependent results for tests that are text only nowadays,
2080         and add one platform dependent result for a text only test that requires it.
2081
2082         * Scripts/run-webkit-tests:
2083
2084 2007-10-03  Lars Knoll  <lars@trolltech.com>
2085
2086         Reviewed by olliej.
2087
2088         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
2089
2090         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
2091         (WebCore::WebFrame::WebFrame):
2092         (WebCore::WebPage::WebPage):
2093         (WebCore::WebPage::createFrame):
2094         (WebCore::WebPage::javaScriptAlert):
2095         (WebCore::WebPage::javaScriptConsoleMessage):
2096         (WebCore::DumpRenderTree::DumpRenderTree):
2097         (WebCore::DumpRenderTree::~DumpRenderTree):
2098         (WebCore::DumpRenderTree::open):
2099         (WebCore::DumpRenderTree::readStdin):
2100         (WebCore::DumpRenderTree::resetJSObjects):
2101         (WebCore::DumpRenderTree::initJSObjects):
2102         (WebCore::DumpRenderTree::dumpFramesAsText):
2103         (WebCore::DumpRenderTree::dump):
2104         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
2105         (WebCore::DumpRenderTree::layoutTestController):
2106         (WebCore::DumpRenderTree::eventSender):
2107         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
2108         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
2109         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
2110         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
2111         (HackWebFrame::mousePressEvent):
2112         (HackWebFrame::mouseReleaseEvent):
2113         (HackWebFrame::mouseMoveEvent):
2114         (HackWebFrame::HackWebFrame):
2115         (HackWebFrame::~HackWebFrame):
2116         (LayoutTestController::LayoutTestController):
2117         (LayoutTestController::reset):
2118         (LayoutTestController::maybeDump):
2119         (LayoutTestController::waitUntilDone):
2120         (LayoutTestController::notifyDone):
2121         (LayoutTestController::dumpEditingCallbacks):
2122         (LayoutTestController::queueReload):
2123         (LayoutTestController::provisionalLoad):
2124         (LayoutTestController::timerEvent):
2125         (EventSender::EventSender):
2126         (EventSender::mouseDown):
2127         (EventSender::mouseUp):
2128         (EventSender::mouseMoveTo):
2129         (EventSender::leapForward):
2130         (EventSender::keyDown):
2131         (EventSender::frameUnderMouse):
2132         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
2133         (LayoutTestController::isLoading):
2134         (LayoutTestController::setLoading):
2135         (LayoutTestController::shouldDumpAsText):
2136         (LayoutTestController::shouldDumpChildrenAsText):
2137         (LayoutTestController::shouldWaitUntilDone):
2138         (LayoutTestController::dumpAsText):
2139         (LayoutTestController::dumpChildFramesAsText):
2140         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
2141         (messageHandler):
2142         (crashHandler):
2143         (main):
2144         * Scripts/run-webkit-tests:
2145
2146 2007-10-03  Mark Rowe  <mrowe@apple.com>
2147
2148         Reviewed by Alp Toker.
2149
2150         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
2151         should take precedence over QTDIR when determining which port we are working with.
2152
2153         * Scripts/webkitdirs.pm: 
2154
2155 2007-10-02  Adam Roben  <aroben@apple.com>
2156
2157         Add keychain to the list of default packages to install
2158
2159         Rubberstamped by Sam.
2160
2161         * CygwinDownloader/cygwin-downloader.py:
2162         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2163
2164 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
2165
2166         Reviewed by Adam.
2167
2168         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
2169         Also makes WebCore regression test case logic work when using git.
2170
2171         * Scripts/prepare-ChangeLog:
2172         (reviewerAndDescriptionForGitCommit): Added.
2173
2174 2007-10-02  Lars Knoll  <lars@trolltech.com>
2175
2176         Reviewed by bdash.
2177
2178         Add API to retrieve the frame name from QWebFrame.
2179         Implement support for DRT::dumpChildrenAsText.
2180
2181         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2182         (WebCore::DumpRenderTree::dumpFramesAsText):
2183         (WebCore::DumpRenderTree::dump):
2184         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2185         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2186         (LayoutTestController::LayoutTestController):
2187         (LayoutTestController::reset):
2188         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2189
2190 2007-10-02  Lars Knoll  <lars@trolltech.com>
2191
2192         Reviewed by bdash.
2193
2194         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
2195
2196         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2197         (WebCore::DumpRenderTree::readStdin):
2198
2199 2007-10-02  Mark Rowe  <mrowe@apple.com>
2200
2201         Reviewed by Oliver.
2202
2203         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2204
2205         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2206         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2207
2208 2007-10-02  Mark Rowe  <mrowe@apple.com>
2209
2210         Rubber-stamped by Maciej.
2211
2212         Configuration changes from build.webkit.org.  The major change is refactoring to work
2213         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
2214         last few weeks.
2215
2216         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2217         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
2218         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
2219         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
2220         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
2221         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
2222         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
2223         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
2224
2225 2007-10-02  Lars Knoll  <lars@trolltech.com>
2226
2227         Reviewed by Maciej.
2228
2229         Add support for eventSender.mouseMove to DRT.
2230         Fixes fast/css/hover-affects-child.html
2231
2232         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2233         (EventSender::mouseMoveTo):
2234
2235 2007-10-01  Mark Rowe  <mrowe@apple.com>
2236
2237         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2238
2239 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
2240
2241         Reviewed by Hyatt.
2242
2243         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
2244
2245         * Scripts/svn-apply:
2246         (gitdiff2svndiff): Ignore lines beginning with "new file".
2247         * Scripts/svn-unapply:
2248         (gitdiff2svndiff): Ditto.
2249
2250 2007-09-30  George Staikos  <staikos@kde.org>
2251
2252         Qt build fix (Mac OS X specific)
2253
2254         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2255
2256 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2257
2258         Reviewed by Mark.
2259
2260         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
2261         Remove Bakefiles from svn.
2262
2263         * GtkLauncher/Bakefiles.bkgen: Removed.
2264         * GtkLauncher/ENV: Removed.
2265         * GtkLauncher/gdklauncher.bkl: Removed.
2266         * GtkLauncher/mk: Removed.
2267         * Scripts/regenerate-makefiles: Removed.
2268
2269 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
2270
2271         Reviewed by John.
2272
2273         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
2274
2275         * Scripts/run-webkit-tests:
2276
2277 2007-09-26  Adam Roben  <aroben@apple.com>
2278
2279         Make not finding an installed WebKit non-fatal
2280
2281         What really matters is that we are able to load WebKit and its
2282         dependencies, not whether we think we've found an installed WebKit.
2283
2284         Reviewed by Sam.
2285
2286         * WebKitInitializer/WebKitInitializer.cpp:
2287         (getWebViewCLSID): Use new LOG_WARNING macro.
2288         (getInstalledWebKitDirectory): Ditto.
2289         (initializeWebKit): Don't die if we didn't find an installed WebKit,
2290         and use new macros.
2291         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
2292
2293 2007-09-26  Adam Roben  <aroben@apple.com>
2294
2295         Committed this file before saving it
2296
2297         * WebKitInitializer/debug_internal.vsprops:
2298
2299 2007-09-26  Adam Roben  <aroben@apple.com>
2300
2301         Load WebKit and its dependencies manually so they come from DllDirectory
2302
2303         I had to change WebKitInitializer to use malloc/free instead of
2304         new/delete to avoid pulling in WebKit (and its dependencies) early
2305         through use of fastMalloc.
2306
2307         Reviewed by Oliver.
2308
2309         * WebKitInitializer/WebKitInitializer.cpp:
2310         (getStringValue): Changed to use malloc/free.
2311         (getInstalledWebKitDirectory): Ditto.
2312         (initializeWebKit): Call SetDllDirectory first, then load all of
2313         WebKit's dependencies manually, finally followed by WebKit itself.
2314         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
2315         configuration to match our other projects.
2316         * WebKitInitializer/debug_internal.vsprops: Added.
2317
2318 2007-09-25  Adam Roben  <aroben@apple.com>
2319
2320         Actually define DEBUG/NDEBUG so that we load WebKit correctly
2321
2322         Rubberstamped by Sam.
2323
2324         * WebKitInitializer/WebKitInitializer.vcproj:
2325
2326 2007-09-25  Adam Roben  <aroben@apple.com>
2327
2328         Make DumpRenderTree delay-load its dependencies
2329
2330         This lets WebKitInitializer re-route the dependencies to be loaded out
2331         of the Safari installation directory.
2332
2333         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
2334         same thing), since we can't import the kCFAllocatorDefault symbol when
2335         delay-loading CoreFoundation.dll.
2336
2337         Rubberstamped by Sam.
2338
2339         * DumpRenderTree/win/DumpRenderTree.cpp:
2340         (runTest):
2341         (javaScriptThreads):
2342         * DumpRenderTree/win/DumpRenderTree.vcproj:
2343         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2344         (LayoutTestController::setWaitToDump):
2345
2346 2007-09-25  Adam Roben  <aroben@apple.com>
2347
2348         Pull ole32.lib into WebKitInitializer
2349
2350         Rubberstamped by Sam.
2351
2352         * WebKitInitializer/WebKitInitializer.vcproj:
2353
2354 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2355
2356         Reviewed by Adam.
2357
2358         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
2359           LGPL'ed files contain incorrect FSF address
2360
2361         * Drosera/config.h:
2362
2363 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2364
2365         Reviewed by Adam.
2366
2367         Make svn-apply and svn-unapply work with git-diff formatted patches.
2368
2369         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
2370         (gitdiff2svndiff): Added.
2371         * Scripts/svn-unapply: Ditto.
2372         (gitdiff2svndiff): Added.
2373
2374 2007-09-25  Adam Roben  <aroben@apple.com>
2375
2376         Pull advapi32.lib into WebKitInitializer
2377
2378         This is needed to get the registry functions we use.
2379
2380         Rubberstamped by Sam.
2381
2382         * WebKitInitializer/WebKitInitializer.vcproj:
2383
2384 2007-09-25  Adam Roben  <aroben@apple.com>
2385
2386         Add python and rsync to cygwin-downloader
2387
2388         Our build slaves need this, and it can't hurt for everyone else to
2389         have it, too.
2390
2391         Reviewed by Sam.
2392
2393         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
2394         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2395
2396 2007-09-25  Adam Roben  <aroben@apple.com>
2397
2398         Add WebKitInitializer and use it in DumpRenderTree
2399
2400         WebKitInitializer is a static library that has one function,
2401         initializeWebKit(). This registers WebKit and sets up the DLL search
2402         path so that WebKit's dependencies that are installed with Safari can
2403         be found.
2404
2405         Reviewed by Sam.
2406
2407         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
2408         DumpRenderTree depend on it.
2409         * DumpRenderTree/win/DumpRenderTree.cpp:
2410         (initialize): Call initializeWebKit.
2411         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
2412         WebKitInitializer.lib.
2413         * WebKitInitializer/WebKitInitializer.cpp: Added.
2414         (getStringValue):
2415         (getWebViewCLSID):
2416         (getInstalledWebKitDirectory):
2417         (initializeWebKit):
2418         * WebKitInitializer/WebKitInitializer.h: Added.
2419         * WebKitInitializer/WebKitInitializer.vcproj: Added.
2420         * WebKitInitializer/debug.vsprops: Added.
2421         * WebKitInitializer/release.vsprops: Added.
2422
2423 2007-09-25  Adam Roben  <aroben@apple.com>
2424
2425         Make run-webkit-tests respect set-webkit-configuration
2426
2427         Reviewed by Sam.
2428
2429         * Scripts/run-webkit-tests: Initialize $configuration to whatever
2430         set-webkit-configuration was last set to.
2431
2432 2007-09-25  Mark Rowe  <mrowe@apple.com>
2433
2434         Rubber-stamped by Eric.
2435
2436         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2437         This makes it possible to automate nightly builds for the feature-branch.
2438
2439 2007-09-25  Adam Roben  <aroben@apple.com>
2440
2441         A couple of fixes/enhancements to update-webkit-*-libs
2442
2443         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
2444         to tell update-webkit-support-libraries where it should find the
2445         WebKitSupportLibrary.zip file you downloaded.
2446
2447         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
2448         Windows-style path.
2449
2450         Reviewed by Sam.
2451
2452         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
2453         to $auxiliaryLibsURL and removed an irrelevant comment.
2454         * Scripts/update-webkit-support-libs:
2455
2456 2007-09-25  Adam Treat  <treat@kde.org>
2457
2458         Reviewed by Simon and Lars.
2459
2460         Refactors and cleans up Qt DRT member variable names, member variable
2461         initialization, style fixes and general code cleanup.
2462
2463         Adds queueReload slot to LayoutTestController that some tests require.
2464
2465         Subclasses QWebFrame to make sure that all frames have an associated
2466         LayoutTestController JS window object.
2467
2468         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
2469         aren't dumped twice.
2470
2471         EOF fixes.
2472
2473         Together, this patch fixes some 20+ layout tests in QtWebKit.
2474
2475         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2476         (WebCore::WebFrame::WebFrame):
2477         (WebCore::WebPage::WebPage):
2478         (WebCore::WebPage::createFrame):
2479         (WebCore::DumpRenderTree::DumpRenderTree):
2480         (WebCore::DumpRenderTree::open):
2481         (WebCore::DumpRenderTree::readStdin):
2482         (WebCore::DumpRenderTree::initJSObjects):
2483         (WebCore::DumpRenderTree::dump):
2484         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2485         (WebCore::DumpRenderTree::layoutTestController):
2486         (WebCore::DumpRenderTree::eventSender):
2487         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2488         (LayoutTestController::LayoutTestController):
2489         (LayoutTestController::reset):
2490         (LayoutTestController::maybeDump):
2491         (LayoutTestController::waitUntilDone):
2492         (LayoutTestController::notifyDone):
2493         (LayoutTestController::queueReload):
2494         (LayoutTestController::provisionalLoad):
2495         (EventSender::EventSender):
2496         (EventSender::mouseDown):
2497         (EventSender::mouseUp):
2498         (EventSender::mouseMoveTo):
2499         (EventSender::frameUnderMouse):
2500         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2501         (LayoutTestController::isLoading):
2502         (LayoutTestController::setLoading):
2503         (LayoutTestController::dumpAsText):
2504         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2505         (main):
2506
2507 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2508
2509
2510         - Reverted an accidentally checked in file.
2511
2512         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
2513
2514 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2515         Reviewed by Sam.
2516
2517         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
2518
2519         * DumpRenderTree/win/DumpRenderTree.vcproj:
2520         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2521
2522 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
2523
2524         Rubber stamped by Adam.
2525
2526         * GdkLauncher: Removed.
2527         * GdkLauncher/Bakefiles.bkgen: Removed.
2528         * GdkLauncher/ENV: Removed.
2529         * GdkLauncher/GdkLauncher.pro: Removed.
2530         * GdkLauncher/gdklauncher.bkl: Removed.
2531         * GdkLauncher/main.cpp: Removed.
2532         * GdkLauncher/mk: Removed.
2533         * GdkLauncher/simple.svg: Removed.
2534         * GdkLauncher/text.html: Removed.
2535         * GtkLauncher: Added.
2536         * GtkLauncher/GdkLauncher.pro: Removed.
2537         * GtkLauncher/GtkLauncher.pro: Added.
2538         * GtkLauncher/main.cpp:
2539         (updateWindowTitle):
2540         (main):
2541         * Scripts/build-webkit:
2542         * Scripts/regenerate-makefiles:
2543         * Scripts/run-javascriptcore-tests:
2544         * Scripts/run-launcher:
2545         * Scripts/run-webkit-tests:
2546         * Scripts/webkitdirs.pm:
2547
2548 2007-09-21  Timothy Hatcher  <timothy@apple.com>
2549
2550         Reviewed by Darin.
2551
2552         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
2553
2554         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
2555         This is tested by plugins/root-object-premature-delete-crash.html.
2556
2557         * DumpRenderTree/mac/ObjCController.m:
2558         (-[ObjCController accessStoredWebScriptObject]):
2559
2560 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
2561
2562         Reviewed by Oliver.
2563
2564         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
2565
2566         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2567         (FrameLoadDelegate::FrameLoadDelegate):
2568
2569 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
2570
2571         Reviewed by Adam.
2572
2573         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
2574         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
2575
2576         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
2577         Now isQt() and isGdk() use global variables that are only set once.
2578
2579         An array of all the parameters is now given to build-dumprender which includes
2580         the platform on linux.
2581
2582         * Scripts/build-dumprendertree:
2583         * Scripts/run-webkit-tests:
2584         * Scripts/webkitdirs.pm:
2585
2586 2007-09-19  Adam Roben  <aroben@apple.com>
2587
2588         Rubberstamped by Hyatt.
2589
2590         * Spinneret: Removed.
2591
2592 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
2593
2594         Reviewed by David Kilzer.
2595
2596         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
2597
2598 2007-09-18  Sam Weinig  <sam@webkit.org>
2599
2600         Add JSRetainPtr.h #include to fix some builds.
2601
2602         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2603
2604 2007-09-18  Mike Hommey  <glandium@debian.org>
2605
2606         Reviewed by Adam.
2607
2608         * Scripts/prepare-ChangeLog:
2609         - Properly parse GECOS field.
2610         - Use git configuration for user name and email when appropriate.
2611
2612 2007-09-17  Sam Weinig  <sam@webkit.org>
2613
2614         Build fix.
2615
2616         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2617
2618 2007-09-17  Sam Weinig  <sam@webkit.org>
2619
2620         Reviewed by Adam Roben.
2621
2622         Share more code between mac and windows DRT.
2623             - GCController is now shared.
2624             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
2625
2626         * DumpRenderTree/GCController.cpp:
2627         * DumpRenderTree/win/DumpRenderTree.cpp:
2628         * DumpRenderTree/win/DumpRenderTree.vcproj:
2629         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
2630         (FrameLoadDelegate::FrameLoadDelegate):
2631         (FrameLoadDelegate::~FrameLoadDelegate):
2632         (FrameLoadDelegate::windowScriptObjectAvailable):
2633         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
2634         * DumpRenderTree/win/GCController.cpp: Removed.
2635         * DumpRenderTree/win/GCController.h: Removed.
2636         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
2637         (GCController::collect):
2638         (GCController::collectOnAlternateThread):
2639         (GCController::getJSObjectCount):
2640         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
2641         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
2642
2643 2007-09-17  Sam Weinig  <sam@webkit.org>
2644
2645         Reviewed by Adam Roben.
2646
2647         Begin sharing code between mac and windows DRT.
2648             - both now share LayoutTestController.h/cpp and implement platform dependant 
2649               operations in LayoutTestControllerMac/Win.
2650             - DumpRenderTree.h is now shared.
2651             - WorkQueue and WorkQueueItem are also shared.
2652
2653         * DumpRenderTree/DumpRenderTree.h:
2654         * DumpRenderTree/LayoutTestController.cpp:
2655         * DumpRenderTree/win/DumpRenderTree.cpp:
2656         (displayWebView):
2657         (dumpFrameScrollPosition):
2658         (dumpFramesAsText):
2659         (dump):
2660         (runTest):
2661         * DumpRenderTree/win/DumpRenderTree.h: Removed.
2662         * DumpRenderTree/win/DumpRenderTree.vcproj:
2663         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
2664         * DumpRenderTree/win/EditingDelegate.cpp:
2665         (EditingDelegate::shouldBeginEditingInDOMRange):
2666         (EditingDelegate::shouldEndEditingInDOMRange):
2667         (EditingDelegate::shouldInsertNode):
2668         (EditingDelegate::shouldInsertText):
2669         (EditingDelegate::shouldDeleteDOMRange):
2670         (EditingDelegate::shouldChangeSelectedDOMRange):
2671         (EditingDelegate::shouldApplyStyle):
2672         (EditingDelegate::shouldChangeTypingStyle):
2673         (EditingDelegate::doPlatformCommand):
2674         (EditingDelegate::webViewDidBeginEditing):
2675         (EditingDelegate::webViewDidChange):
2676         (EditingDelegate::webViewDidEndEditing):
2677         (EditingDelegate::webViewDidChangeTypingStyle):
2678         (EditingDelegate::webViewDidChangeSelection):
2679         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
2680         * DumpRenderTree/win/LayoutTestController.h: Removed.
2681         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
2682         (LayoutTestController::addDisallowedURL):
2683         (LayoutTestController::clearBackForwardList):
2684         (LayoutTestController::copyDecodedHostName):
2685         (LayoutTestController::copyEncodedHostName):
2686         (LayoutTestController::display):
2687         (LayoutTestController::keepWebHistory):
2688         (LayoutTestController::notifyDone):
2689         (LayoutTestController::queueBackNavigation):
2690         (LayoutTestController::queueForwardNavigation):
2691         (jsStringRefToWString):
2692         (LayoutTestController::queueLoad):
2693         (LayoutTestController::queueReload):
2694         (LayoutTestController::queueScript):
2695         (LayoutTestController::setAcceptsEditing):
2696         (LayoutTestController::setCustomPolicyDelegate):
2697         (LayoutTestController::setMainFrameIsFirstResponder):
2698         (LayoutTestController::setTabKeyCyclesThroughElements):
2699         (LayoutTestController::setUseDashboardCompatibilityMode):
2700         (LayoutTestController::setUserStyleSheetEnabled):
2701         (LayoutTestController::setUserStyleSheetLocation):
2702         (LayoutTestController::setWindowIsKey):
2703         (waitUntilDoneWatchdogFired):
2704         (LayoutTestController::setWaitToDump):
2705         (LayoutTestController::windowCount):
2706         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2707         (FrameLoadDelegate::didReceiveTitle):
2708         (FrameLoadDelegate::processWork):
2709         (FrameLoadDelegate::locationChangeDone):
2710         (FrameLoadDelegate::windowScriptObjectAvailable):
2711         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2712         * DumpRenderTree/win/WorkQueue.h: Removed.
2713         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2714         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2715         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2716         (jsStringRefToWString):
2717         (LoadItem::invoke):
2718         (ScriptItem::invoke):
2719
2720 2007-09-17  Sam Weinig  <sam@webkit.org>
2721
2722         Reviewed by Adam Roben.
2723
2724         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2725
2726         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
2727         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
2728         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
2729         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
2730         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
2731         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
2732         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
2733         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
2734         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
2735         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
2736         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
2737         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
2738         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
2739         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
2740         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
2741         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
2742         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
2743         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
2744         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
2745         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
2746         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
2747         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
2748         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
2749         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
2750         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
2751         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
2752         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
2753         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
2754         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
2755         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
2756         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
2757         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
2758         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
2759         * DumpRenderTree/win: Added.
2760         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
2761         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
2762         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
2763         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
2764         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
2765         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
2766         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
2767         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
2768         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
2769         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
2770         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
2771         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
2772         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
2773         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2774         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
2775         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
2776         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
2777         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
2778         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2779         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2780         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
2781         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2782         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
2783         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
2784         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
2785         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
2786
2787 2007-09-15  Mark Rowe  <mrowe@apple.com>
2788
2789         Build fix for DumpRenderTree.
2790
2791         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
2792
2793 2007-09-14  Sam Weinig  <sam@webkit.org>
2794
2795         Rubber stamped by Adam Roben.
2796
2797         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
2798           - The UIDelegate was put into a new file while the FrameLoadDelegate was
2799             kept in the WaitUntilDoneDelegate file for the time being.
2800
2801         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2802         (main):
2803         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
2804         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
2805         (UIDelegate::QueryInterface):
2806         (UIDelegate::AddRef):
2807         (UIDelegate::Release):
2808         (UIDelegate::hasCustomMenuImplementation):
2809         (UIDelegate::setFrame):
2810         (UIDelegate::webViewFrame):
2811         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2812         (UIDelegate::webViewAddMessageToConsole):
2813         (UIDelegate::doDragDrop):
2814         (UIDelegate::webViewGetDlgCode):
2815         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
2816         (UIDelegate::UIDelegate):
2817         (UIDelegate::createWebViewWithRequest):
2818         (UIDelegate::webViewShow):
2819         (UIDelegate::webViewClose):
2820         (UIDelegate::webViewFocus):
2821         (UIDelegate::webViewUnfocus):
2822         (UIDelegate::webViewFirstResponder):
2823         (UIDelegate::makeFirstResponder):
2824         (UIDelegate::setStatusText):
2825         (UIDelegate::webViewStatusText):
2826         (UIDelegate::webViewAreToolbarsVisible):
2827         (UIDelegate::setToolbarsVisible):
2828         (UIDelegate::webViewIsStatusBarVisible):
2829         (UIDelegate::setStatusBarVisible):
2830         (UIDelegate::webViewIsResizable):
2831         (UIDelegate::setResizable):
2832         (UIDelegate::setContentRect):
2833         (UIDelegate::webViewContentRect):
2834         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2835         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2836         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2837         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
2838         (UIDelegate::mouseDidMoveOverElement):
2839         (UIDelegate::contextMenuItemsForElement):
2840         (UIDelegate::validateUserInterfaceItem):
2841         (UIDelegate::shouldPerformAction):
2842         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
2843         (UIDelegate::willPerformDragDestinationAction):
2844         (UIDelegate::dragSourceActionMaskForPoint):
2845         (UIDelegate::willPerformDragSourceAction):
2846         (UIDelegate::contextMenuItemSelected):
2847         (UIDelegate::trackCustomPopupMenu):
2848         (UIDelegate::measureCustomMenuItem):
2849         (UIDelegate::drawCustomMenuItem):
2850         (UIDelegate::addCustomMenuDrawingData):
2851         (UIDelegate::cleanUpCustomMenuDrawingData):
2852         (UIDelegate::canTakeFocus):
2853         (UIDelegate::takeFocus):
2854         (UIDelegate::registerUndoWithTarget):
2855         (UIDelegate::removeAllActionsWithTarget):
2856         (UIDelegate::setActionTitle):
2857         (UIDelegate::undo):
2858         (UIDelegate::redo):
2859         (UIDelegate::canUndo):
2860         (UIDelegate::canRedo):
2861         (UIDelegate::webViewResizerRect):
2862         (UIDelegate::webViewDrawResizer):
2863         (UIDelegate::webViewScrolled):
2864         (UIDelegate::webViewShouldInterruptJavaScript):
2865         (UIDelegate::webViewReceivedFocus):
2866         (UIDelegate::webViewLostFocus):
2867         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
2868         (FrameLoadDelegate::QueryInterface):
2869         (FrameLoadDelegate::AddRef):
2870         (FrameLoadDelegate::Release):
2871         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2872         (FrameLoadDelegate::didCommitLoadForFrame):
2873         (FrameLoadDelegate::didReceiveTitle):
2874         (FrameLoadDelegate::processWork):
2875         (processWorkTimer):
2876         (FrameLoadDelegate::locationChangeDone):
2877         (FrameLoadDelegate::didFinishLoadForFrame):
2878         (FrameLoadDelegate::didFailLoadWithError):
2879         (FrameLoadDelegate::windowScriptObjectAvailable):
2880         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
2881         (FrameLoadDelegate::FrameLoadDelegate):
2882
2883 2007-09-14  Sam Weinig  <sam@webkit.org>
2884
2885         Reviewed by Kevin McCullough.
2886
2887         Move mac specific globals in to mac/DumpRenderTreeMac.h
2888
2889         * DumpRenderTree/DumpRenderTree.h:
2890         * DumpRenderTree/DumpRenderTree.mm: Removed.
2891         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2892         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
2893         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
2894
2895 2007-09-14  Brady Eidson  <beidson@apple.com>
2896
2897         Rubberstamped by Weinig
2898
2899         You know, Sam, some of us use case-sensitve filesystems...
2900
2901         * DumpRenderTree/DumpRenderTree.h:
2902         * DumpRenderTree/mac/UIDelegate.mm:
2903
2904 2007-09-14  Sam Weinig  <sam@webkit.org>
2905
2906         Rubber stamped by Adam Roben.
2907
2908         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
2909         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
2910
2911         * DumpRenderTree/AppleScriptController.h: Removed.
2912         * DumpRenderTree/AppleScriptController.m: Removed.
2913         * DumpRenderTree/DumpRenderTree.h:
2914         * DumpRenderTree/DumpRenderTree.mm:
2915         (startJavaScriptThreads):
2916         (stopJavaScriptThreads):
2917         (activateAhemFont):
2918         (setDefaultColorProfileToRGB):
2919         (makeLargeMallocFailSilently):
2920         (dumpFrameScrollPosition):
2921         (dumpFramesAsText):
2922         (dump):
2923         (runTest):
2924         (-[DumpRenderTreeWindow isKeyWindow]):
2925         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2926         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
2927         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
2928         * DumpRenderTree/EditingDelegate.h: Removed.
2929         * DumpRenderTree/EditingDelegate.m: Removed.
2930         * DumpRenderTree/EventSendingController.h: Removed.
2931         * DumpRenderTree/EventSendingController.m: Removed.
2932         * DumpRenderTree/FrameLoadDelegate.h: Removed.
2933         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
2934         * DumpRenderTree/GCController.mm: Removed.
2935         * DumpRenderTree/ImageDiff.m: Removed.
2936         * DumpRenderTree/LayoutTestController.cpp:
2937         (LayoutTestController::LayoutTestController):
2938         (dumpAsTextCallback):
2939         (dumpBackForwardListCallback):
2940         (dumpChildFramesAsTextCallback):
2941         (dumpChildFrameScrollPositionsCallback):
2942         (dumpDOMAsWebArchiveCallback):
2943         (dumpEditingCallbacksCallback):
2944         (dumpFrameLoadCallbacksCallback):
2945         (dumpResourceLoadCallbacksCallback):
2946         (dumpSelectionRectCallback):
2947         (dumpSourceAsWebArchiveCallback):
2948         (dumpTitleChangesCallback):
2949         (repaintSweepHorizontallyCallback):
2950         (setCallCloseOnWebViewsCallback):
2951         (setCanOpenWindowsCallback):
2952         (setCloseRemainingWindowsWhenCompleteCallback):
2953         (testRepaintCallback):
2954         (addFileToPasteboardOnDragCallback):
2955         (waitUntilDoneCallback):
2956         * DumpRenderTree/LayoutTestController.h:
2957         (LayoutTestController::dumpAsText):
2958         (LayoutTestController::setDumpAsText):
2959         (LayoutTestController::dumpBackForwardList):
2960         (LayoutTestController::setDumpBackForwardList):
2961         (LayoutTestController::dumpChildFrameScrollPositions):
2962         (LayoutTestController::setDumpChildFrameScrollPositions):
2963         (LayoutTestController::dumpChildFramesAsText):
2964         (LayoutTestController::setDumpChildFramesAsText):
2965         (LayoutTestController::dumpDOMAsWebArchive):
2966         (LayoutTestController::setDumpDOMAsWebArchive):
2967         (LayoutTestController::dumpSelectionRect):
2968         (LayoutTestController::setDumpSelectionRect):
2969         (LayoutTestController::dumpSourceAsWebArchive):
2970         (LayoutTestController::setDumpSourceAsWebArchive):
2971         (LayoutTestController::dumpTitleChanges):
2972         (LayoutTestController::setDumpTitleChanges):
2973         (LayoutTestController::dumpEditingCallbacks):
2974         (LayoutTestController::setDumpEditingCallbacks):
2975         (LayoutTestController::dumpResourceLoadCallbacks):
2976         (LayoutTestController::setDumpResourceLoadCallbacks):
2977         (LayoutTestController::dumpFrameLoadCallbacks):
2978         (LayoutTestController::setDumpFrameLoadCallbacks):
2979         (LayoutTestController::addFileToPasteboardOnDrag):
2980         (LayoutTestController::setAddFileToPasteboardOnDrag):
2981         (LayoutTestController::callCloseOnWebViews):
2982         (LayoutTestController::setCallCloseOnWebViews):
2983         (LayoutTestController::canOpenWindows):
2984         (LayoutTestController::setCanOpenWindows):
2985         (LayoutTestController::closeRemainingWindowsWhenComplete):
2986         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2987         (LayoutTestController::testRepaint):
2988         (LayoutTestController::setTestRepaint):
2989         (LayoutTestController::testRepaintSweepHorizontally):
2990         (LayoutTestController::setTestRepaintSweepHorizontally):
2991         (LayoutTestController::waitToDump):
2992         (LayoutTestController::windowIsKey):
2993         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
2994         * DumpRenderTree/NavigationController.h: Removed.
2995         * DumpRenderTree/NavigationController.m: Removed.
2996         * DumpRenderTree/ObjCController.h: Removed.
2997         * DumpRenderTree/ObjCController.m: Removed.
2998         * DumpRenderTree/ObjCPlugin.h: Removed.
2999         * DumpRenderTree/ObjCPlugin.m: Removed.
3000         * DumpRenderTree/ObjCPluginFunction.h: Removed.
3001         * DumpRenderTree/ObjCPluginFunction.m: Removed.
3002         * DumpRenderTree/PolicyDelegate.h: Removed.
3003         * DumpRenderTree/PolicyDelegate.m: Removed.
3004         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
3005         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
3006         * DumpRenderTree/TextInputController.h: Removed.
3007         * DumpRenderTree/TextInputController.m: Removed.
3008         * DumpRenderTree/UIDelegate.h: Removed.
3009         * DumpRenderTree/UIDelegate.mm: Removed.
3010         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
3011         * DumpRenderTree/mac: Added.
3012         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
3013         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
3014         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
3015         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
3016         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
3017         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
3018         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3019         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3020         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3021         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3022         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3023         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3024         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3025         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3026         (-[EditingDelegate webViewDidBeginEditing:]):
3027         (-[EditingDelegate webViewDidChange:]):
3028         (-[EditingDelegate webViewDidEndEditing:]):
3029         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3030         (-[EditingDelegate webViewDidChangeSelection:]):
3031         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
3032         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
3033         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
3034         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
3035         (-[FrameLoadDelegate init]):
3036         (-[FrameLoadDelegate dealloc]):
3037         (-[FrameLoadDelegate processWork:]):
3038         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3039         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3040         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3041         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3042         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3043         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3044         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3045         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3046         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3047         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3048         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3049         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3050         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3051         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3052         (-[FrameLoadDelegate webView:willCloseFrame:]):
3053         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3054         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3055         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
3056         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
3057         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
3058         (LayoutTestController::notifyDone):
3059         (LayoutTestController::setWindowIsKey):
3060         (LayoutTestController::setWaitToDump):
3061         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
3062         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
3063         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
3064         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
3065         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
3066         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
3067         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
3068         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
3069         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
3070         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
3071         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
3072         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
3073         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3074         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3075         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3076         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3077         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3078         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3079         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
3080         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
3081         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
3082         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
3083         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
3084         (-[UIDelegate webViewFocus:]):
3085         (-[UIDelegate webView:createWebViewWithRequest:]):
3086         (-[UIDelegate webViewClose:]):
3087         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
3088
3089 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
3090
3091         Reviewed by Adam.
3092
3093         - Changing Win version of Drosera work with recent changes.
3094
3095         * Drosera/DebuggerDocument.cpp:
3096         * Drosera/DebuggerDocument.h:
3097         * Drosera/mac/DebuggerDocumentPlatform.mm:
3098         (NSStringCreateWithJSStringRef):
3099         (JSValueRefCreateWithNSString):
3100         * Drosera/win/DebuggerClient.cpp:
3101         (DebuggerClient::stepInto):
3102         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3103
3104 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
3105
3106         Reviewed by Tim.
3107
3108         - Moved isPaused into the JS for efficiency and simplicity.
3109
3110         * Drosera/DebuggerDocument.cpp:
3111         (DebuggerDocument::DebuggerDocument):
3112         (DebuggerDocument::pauseCallback):
3113         (DebuggerDocument::resumeCallback):
3114         (DebuggerDocument::isPaused):
3115         (DebuggerDocument::staticFunctions):
3116         * Drosera/DebuggerDocument.h:
3117         * Drosera/console.js:
3118         * Drosera/debugger.js:
3119         * Drosera/mac/DebuggerClient.mm:
3120         (-[DebuggerClient validateUserInterfaceItem:]):
3121
3122 2007-09-13  Sam Weinig  <sam@webkit.org>
3123
3124         Rubber stamped by Darin.
3125
3126         Make DumpRenderTree more cross platform ready.
3127         - Convert GCController to use the JSCore API instead of the WebScriptObject.
3128         - Use CF types instead of NS objects.
3129         - General cleanup.
3130
3131         * DumpRenderTree/DumpRenderTree.h:
3132         * DumpRenderTree/DumpRenderTree.mm:
3133         (dumpRenderTree):
3134         (dump):
3135         (runTest):
3136         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3137         * DumpRenderTree/EditingDelegate.m:
3138         * DumpRenderTree/FrameLoadDelegate.h:
3139         * DumpRenderTree/FrameLoadDelegate.mm:
3140         (-[FrameLoadDelegate init]):
3141         (-[FrameLoadDelegate dealloc]):
3142         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3143         * DumpRenderTree/GCController.cpp: Added.
3144         (GCController::GCController):
3145         (GCController::~GCController):
3146         (collectCallback):
3147         (collectOnAlternateThreadCallback):
3148         (getJSObjectCountCallback):
3149         (GCController::makeWindowObject):
3150         (GCController::getJSClass):
3151         (GCController::staticFunctions):
3152         * DumpRenderTree/GCController.h:
3153         * DumpRenderTree/GCController.mm:
3154         (GCController::collect):
3155         (GCController::collectOnAlternateThread):
3156         (GCController::getJSObjectCount):
3157         * DumpRenderTree/LayoutTestController.cpp:
3158         (LayoutTestController::makeWindowObject):
3159         (LayoutTestController::getJSClass):
3160         * DumpRenderTree/LayoutTestController.h:
3161         * DumpRenderTree/LayoutTestControllerMac.mm:
3162         (LayoutTestController::addDisallowedURL):
3163         (waitUntilDoneWatchdogFired):
3164         (LayoutTestController::waitUntilDone):
3165         * DumpRenderTree/ResourceLoadDelegate.m:
3166         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3167
3168 2007-09-12  Sam Weinig  <sam@webkit.org>
3169
3170         Reviewed by Stephanie.
3171
3172         Fix leaks in mac DumpRenderTree.
3173
3174         * DumpRenderTree/FrameLoadDelegate.mm:
3175         (-[FrameLoadDelegate init]): Initalize in the correct order.
3176         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
3177         * DumpRenderTree/LayoutTestController.cpp:
3178         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
3179         (encodeHostNameCallback): ditto.
3180         * DumpRenderTree/LayoutTestController.h:
3181         * DumpRenderTree/LayoutTestControllerMac.mm:
3182         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
3183         (LayoutTestController::copyEncodedHostName): ditto
3184         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
3185
3186 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3187
3188         Reviewed by Geof.
3189
3190         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
3191
3192         * Scripts/run-webkit-tests:
3193
3194 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3195
3196         Reviewed by Darin.
3197
3198         - Simplified code paths and extracted out functions to increase encapsulation.
3199
3200         * Drosera/DebuggerDocument.cpp:
3201         (DebuggerDocument::breakpointEditorHTMLCallback):
3202         (DebuggerDocument::isPausedCallback):
3203         (DebuggerDocument::pauseCallback):
3204         (DebuggerDocument::resumeCallback):
3205         (DebuggerDocument::stepIntoCallback):
3206         (DebuggerDocument::evaluateScriptCallback):
3207         (DebuggerDocument::currentFunctionStackCallback):
3208         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3209         (DebuggerDocument::valueForScopeVariableNamedCallback):
3210         (DebuggerDocument::logCallback):
3211         * Drosera/DebuggerDocument.h:
3212         (DebuggerDocument::getPaused):
3213         * Drosera/mac/DebuggerClient.mm:
3214         (-[DebuggerClient pause:]):
3215         (-[DebuggerClient resume:]):
3216         (-[DebuggerClient stepInto:]):
3217         (-[DebuggerClient stepOver:]):
3218         (-[DebuggerClient stepOut:]):
3219         (-[DebuggerClient showConsole:]):
3220         (-[DebuggerClient closeCurrentFile:]):
3221         (-[DebuggerClient validateUserInterfaceItem:]):
3222         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
3223         (+[NSString stringOrNilFromWebScriptResult:]):
3224         (DebuggerDocument::platformPause):
3225         (DebuggerDocument::platformResume):
3226         (DebuggerDocument::platformStepInto):
3227         (DebuggerDocument::platformEvaluateScript):
3228         (DebuggerDocument::getPlatformCurrentFunctionStack):
3229         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3230         (DebuggerDocument::platformValueForScopeVariableNamed):
3231         (DebuggerDocument::platformLog):
3232         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3233
3234 2007-09-12  Sam Weinig  <sam@webkit.org>
3235
3236         Build fix for Buildbot.
3237
3238         * DumpRenderTree/DumpRenderTree.mm:
3239         (dump):
3240
3241 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3242
3243         Reviewed by Geoff.
3244
3245         - Updated the leaks list for leopard to help identify regressions.
3246
3247         * Scripts/run-webkit-tests:
3248
3249 2007-09-12  Sam Weinig  <sam@webkit.org>
3250
3251         Rubber stamped by Darin.
3252
3253         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
3254
3255         * DumpRenderTree/DumpRenderTree.h: Re-order variables. 
3256         * DumpRenderTree/DumpRenderTree.m: Removed.
3257         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
3258         (stopJavaScriptThreads): Fix initialization.
3259         (setDefaultColorProfileToRGB): Add explicit cast from void*.
3260         (dumpRenderTree): Ditto.
3261         (runTest):
3262         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
3263
3264         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3265         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
3266         * DumpRenderTree/FrameLoadDelegate.m: Removed.
3267         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
3268         (-[FrameLoadDelegate init]):
3269         (-[FrameLoadDelegate dealloc]):
3270         (-[FrameLoadDelegate processWork:]):
3271         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3272         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3273         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
3274         
3275         * DumpRenderTree/LayoutTestController.cpp: Added.
3276         (LayoutTestController::LayoutTestController):
3277         (LayoutTestController::~LayoutTestController):
3278         (dumpAsTextCallback):
3279         (dumpBackForwardListCallback):
3280         (dumpChildFramesAsTextCallback):
3281         (dumpChildFrameScrollPositionsCallback):
3282         (dumpDOMAsWebArchiveCallback):
3283         (dumpEditingCallbacksCallback):
3284         (dumpFrameLoadCallbacksCallback):
3285         (dumpResourceLoadCallbacksCallback):
3286         (dumpSelectionRectCallback):
3287         (dumpSourceAsWebArchiveCallback):
3288         (dumpTitleChangesCallback):
3289         (repaintSweepHorizontallyCallback):
3290         (setCallCloseOnWebViewsCallback):
3291         (setCanOpenWindowsCallback):
3292         (setCloseRemainingWindowsWhenCompleteCallback):
3293         (testRepaintCallback):
3294         (addFileToPasteboardOnDragCallback):
3295         (addDisallowedURLCallback):
3296         (clearBackForwardListCallback):
3297         (decodeHostNameCallback):
3298         (displayCallback):
3299         (encodeHostNameCallback):
3300         (keepWebHistoryCallback):
3301         (notifyDoneCallback):
3302         (queueBackNavigationCallback):
3303         (queueForwardNavigationCallback):
3304         (queueLoadCallback):
3305         (queueReloadCallback):
3306         (queueScriptCallback):
3307         (setAcceptsEditingCallback):
3308         (setCustomPolicyDelegateCallback):
3309         (setMainFrameIsFirstResponderCallback):
3310         (setTabKeyCyclesThroughElementsCallback):
3311         (setUseDashboardCompatibilityModeCallback):
3312         (setUserStyleSheetEnabledCallback):
3313         (setUserStyleSheetLocationCallback):
3314         (setWindowIsKeyCallback):
3315         (waitUntilDoneCallback):
3316         (windowCountCallback):
3317         (LayoutTestController::makeWindowObject):
3318         (LayoutTestController::getLayoutTestControllerJSClass):
3319         (LayoutTestController::staticFunctions):
3320         * DumpRenderTree/LayoutTestController.h: Replaced.
3321         * DumpRenderTree/LayoutTestController.m: Removed.
3322         * DumpRenderTree/LayoutTestControllerMac.mm: Added.
3323         (LayoutTestController::dumpAsText):
3324         (LayoutTestController::dumpBackForwardList):
3325         (LayoutTestController::dumpChildFramesAsText):
3326         (LayoutTestController::dumpChildFrameScrollPositions):
3327         (LayoutTestController::dumpDOMAsWebArchive):
3328         (LayoutTestController::dumpEditingCallbacks):
3329         (LayoutTestController::dumpFrameLoadCallbacks):
3330         (LayoutTestController::dumpResourceLoadCallbacks):
3331         (LayoutTestController::dumpSelectionRect):
3332         (LayoutTestController::dumpSourceAsWebArchive):
3333         (LayoutTestController::dumpTitleChanges):
3334         (LayoutTestController::repaintSweepHorizontally):
3335         (LayoutTestController::setCallCloseOnWebViews):
3336         (LayoutTestController::setCanOpenWindows):
3337         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3338         (LayoutTestController::testRepaint):
3339         (LayoutTestController::addFileToPasteboardOnDrag):
3340         (LayoutTestController::addDisallowedURL):
3341         (LayoutTestController::clearBackForwardList):
3342         (LayoutTestController::decodeHostName):
3343         (LayoutTestController::encodeHostName):
3344         (LayoutTestController::display):
3345         (LayoutTestController::keepWebHistory):
3346         (LayoutTestController::notifyDone):
3347         (LayoutTestController::queueBackNavigation):
3348         (LayoutTestController::queueForwardNavigation):
3349         (LayoutTestController::queueLoad):
3350         (LayoutTestController::queueReload):
3351         (LayoutTestController::queueScript):
3352         (LayoutTestController::setAcceptsEditing):
3353         (LayoutTestController::setCustomPolicyDelegate):
3354         (LayoutTestController::setMainFrameIsFirstResponder):
3355         (LayoutTestController::setTabKeyCyclesThroughElements):
3356         (LayoutTestController::setUseDashboardCompatibilityMode):
3357         (LayoutTestController::setUserStyleSheetEnabled):
3358         (LayoutTestController::setUserStyleSheetLocation):
3359         (LayoutTestController::setWindowIsKey):
3360         (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]):
3361         (LayoutTestController::waitUntilDone):
3362         (LayoutTestController::windowCount):
3363         Use the JSCore API to implement the LayoutTestController.
3364
3365         * DumpRenderTree/ObjCController.h:
3366         * DumpRenderTree/ObjCController.m:
3367         (+[ObjCController isSelectorExcludedFromWebScript:]):
3368         (+[ObjCController webScriptNameForSelector:]):
3369         (-[ObjCController accessStoredWebScriptObject]):
3370         (-[ObjCController storeWebScriptObject:]):
3371         (-[ObjCController dealloc]):
3372         (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]):
3373         Move WebScriptObject tests to ObjCController.
3374
3375         * DumpRenderTree/UIDelegate.m: Removed.
3376         * DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.
3377
3378         * DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3379         * DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3380         * DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3381         (WorkQueueItem::~WorkQueueItem):
3382         (LoadItem::LoadItem):
3383         (LoadItem::url):
3384         (LoadItem::target):
3385         (ScriptItem::ScriptItem):
3386         (ScriptItem::script):
3387         * DumpRenderTree/WorkQueueItemMac.mm: Added.
3388         (LoadItem::invoke):
3389         (ReloadItem::invoke):
3390         (ScriptItem::invoke):
3391         (BackForwardItem::invoke):
3392         Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings
3393         to avoid conversion until the last possible moment.  These changes will be merged with the windows DRT when we start
3394         sharing code.
3395
3396 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
3397
3398         Reviewed by Maciej.
3399
3400         - Updated Win side to take advantage of the platform separating changes.
3401
3402         * Drosera/DebuggerDocument.cpp:
3403         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3404         * Drosera/DebuggerDocument.h:
3405         * Drosera/win/DebuggerClient.cpp:
3406         (DebuggerClient::pause):
3407         (DebuggerClient::resume):
3408         (DebuggerClient::stepInto):
3409         (DebuggerDocument::platformPause):
3410         (DebuggerDocument::platformResume):
3411         (DebuggerDocument::platformStepInto):
3412         (DebuggerDocument::platformEvaluateScript):
3413         (DebuggerDocument::getPlatformCurrentFunctionStack):
3414         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3415         (DebuggerDocument::platformValueForScopeVariableNamed):
3416         (DebuggerDocument::platformLog):
3417         * Drosera/win/DebuggerClient.h:
3418         * Drosera/win/Drosera.cpp:
3419         (Drosera::Drosera):
3420         (Drosera::windowScriptObjectAvailable):
3421         (Drosera::initWithServerName):
3422         (Drosera::switchToServerNamed):
3423         * Drosera/win/Drosera.h:
3424         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3425
3426 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
3427
3428         Reviewed by Adam.
3429
3430         - Just doing the moves in a separate patch so the changes are easier to see.
3431
3432         * Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
3433         * Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
3434         * Drosera/win/DebuggerDocumentWin.cpp: Removed.
3435         * Drosera/win/DebuggerDocumentWin.h: Removed.
3436         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3437
3438 2007-09-11  Sven Herzberg  <sven@imendio.com>
3439
3440         Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
3441         http://bugs.webkit.org/show_bug.cgi?id=15176
3442
3443         * Scripts/run-launcher: don't replace LD_LIBRARY_PATH with
3444         $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve
3445         other paths eg. from jhbuild)
3446
3447 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
3448
3449         Reviewed by Adam.
3450
3451         - Made an order-of-deletion mistake.
3452
3453         * Drosera/DebuggerDocument.h:
3454         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
3455         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
3456         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
3457         * Drosera/mac/DebuggerClient.mm:
3458         (DebuggerDocument::platformPause):
3459         (DebuggerDocument::platformResume):
3460         (DebuggerDocument::platformStepInto):
3461         (DebuggerDocument::platformEvaluateScript):
3462         (DebuggerDocument::getPlatformCurrentFunctionStack):
3463         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3464         (DebuggerDocument::platformValueForScopeVariableNamed):
3465         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3466
3467 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
3468
3469         Reviewed by Darin.
3470
3471         - Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
3472
3473         * Drosera/DebuggerDocument.cpp:
3474         (DebuggerDocument::DebuggerDocument):
3475         * Drosera/DebuggerDocument.h:
3476         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3477         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3478         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3479         * Drosera/mac/DebuggerApplication.mm:
3480         (-[DebuggerApplication attach:]):
3481         * Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
3482         * Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm.
3483         (DebuggerDocument::platformPause):
3484         (DebuggerDocument::platformResume):
3485         (DebuggerDocument::platformStepInto):
3486         (DebuggerDocument::platformEvaluateScript):
3487         (DebuggerDocument::getPlatformCurrentFunctionStack):
3488         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3489         (DebuggerDocument::platformValueForScopeVariableNamed):
3490         (DebuggerDocument::platformLog):
3491         * Drosera/mac/DebuggerDocumentMac.h: Removed.
3492         * Drosera/mac/DebuggerDocumentMac.mm: Removed.
3493         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3494
3495 2007-09-09  Sam Weinig  <sam@webkit.org>
3496
3497         Reviewed by Mark Rowe.
3498
3499         Remove 'objC' prefix from methods now in the ObjCController. 
3500
3501         * DumpRenderTree/ObjCController.m:
3502         (+[ObjCController isSelectorExcludedFromWebScript:]):
3503         (+[ObjCController webScriptNameForSelector:]):
3504         (-[ObjCController classNameOf:]):
3505         (-[ObjCController objectOfClass:]):
3506         (-[ObjCController identityIsEqual::]):
3507         (-[ObjCController longLongRoundTrip:]):
3508         (-[ObjCController unsignedLongLongRoundTrip:]):
3509
3510 2007-09-09  Sam Weinig  <sam@webkit.org>
3511
3512         Reviewed by Oliver.
3513
3514         Initial refactor of DumpRenderTree in preparation of making it more platform independent. 
3515         - Move LayoutTestController into its own file.
3516         - Move Objective-C only functions on LayoutTestController into a new controller called the
3517           ObjCController. 
3518
3519         * DumpRenderTree/DumpRenderTree.h:
3520         * DumpRenderTree/DumpRenderTree.m:
3521         (displayWebView):
3522         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3523         * DumpRenderTree/FrameLoadDelegate.m:
3524         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3525         * DumpRenderTree/LayoutTestController.h: Added.
3526         * DumpRenderTree/LayoutTestController.m: Added.
3527         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3528         (+[LayoutTestController webScriptNameForSelector:]):
3529         (-[LayoutTestController clearBackForwardList]):
3530         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
3531         (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
3532         (-[LayoutTestController setCustomPolicyDelegate:]):
3533         (-[LayoutTestController keepWebHistory]):
3534         (-[LayoutTestController setCallCloseOnWebViews:]):
3535         (-[LayoutTestController setCanOpenWindows]):
3536         (-[LayoutTestController waitUntilDone]):
3537         (-[LayoutTestController waitUntilDoneWatchdogFired]):
3538         (-[LayoutTestController notifyDone]):
3539         (-[LayoutTestController dumpAsText]):
3540         (-[LayoutTestController addFileToPasteboardOnDrag]):
3541         (-[LayoutTestController addDisallowedURL:]):
3542         (-[LayoutTestController setUserStyleSheetLocation:]):
3543         (-[LayoutTestController setUserStyleSheetEnabled:]):
3544         (-[LayoutTestController dumpDOMAsWebArchive]):
3545         (-[LayoutTestController dumpSourceAsWebArchive]):
3546         (-[LayoutTestController dumpSelectionRect]):
3547         (-[LayoutTestController dumpTitleChanges]):
3548         (-[LayoutTestController dumpBackForwardList]):
3549         (-[LayoutTestController windowCount]):
3550         (-[LayoutTestController dumpChildFrameScrollPositions]):
3551         (-[LayoutTestController dumpChildFramesAsText]):
3552         (-[LayoutTestController dumpEditingCallbacks]):
3553         (-[LayoutTestController dumpResourceLoadCallbacks]):
3554         (-[LayoutTestController dumpFrameLoadCallbacks]):
3555         (-[LayoutTestController setWindowIsKey:]):
3556         (-[LayoutTestController setMainFrameIsFirstResponder:]):
3557         (-[LayoutTestController display]):
3558         (-[LayoutTestController testRepaint]):
3559         (-[LayoutTestController repaintSweepHorizontally]):
3560         (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
3561         (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
3562         (-[LayoutTestController _doLoad:target:]):
3563         (-[LayoutTestController _doBackOrForwardNavigation:]):
3564         (-[LayoutTestController queueBackNavigation:]):
3565         (-[LayoutTestController queueForwardNavigation:]):
3566         (-[LayoutTestController queueReload]):
3567         (-[LayoutTestController queueScript:]):
3568         (-[LayoutTestController queueLoad:target:]):
3569         (-[LayoutTestController setAcceptsEditing:]):
3570         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
3571         (-[LayoutTestController storeWebScriptObject:]):
3572         (-[LayoutTestController accessStoredWebScriptObject]):
3573         (-[LayoutTestController dealloc]):
3574         (-[LayoutTestController decodeHostName:]):
3575         (-[LayoutTestController encodeHostName:]):
3576         * DumpRenderTree/ObjCController.h: Added.
3577         * DumpRenderTree/ObjCController.m: Added.
3578         (+[ObjCController isSelectorExcludedFromWebScript:]):
3579         (+[ObjCController webScriptNameForSelector:]):
3580         (-[ObjCController objCClassNameOf:]):
3581         (-[ObjCController objCObjectOfClass:]):
3582         (-[ObjCController objCIdentityIsEqual::]):
3583         (-[ObjCController objCLongLongRoundTrip:]):
3584         (-[ObjCController objCUnsignedLongLongRoundTrip:]):
3585         (-[ObjCController testWrapperRoundTripping:]):
3586
3587 2007-09-07  Sam Weinig  <sam@webkit.org>
3588
3589         Reviewed by Alice.
3590
3591         Strip trailing and leading space/newline characters from skiplist file names.
3592
3593         * Scripts/run-webkit-tests:
3594
3595 2007-09-06  Kevin McCullough  <kmccullough@apple.com>
3596
3597         Reviewed by Maciej.
3598
3599         - Changed Drosera to take advantage of the JSRetainPtr changes.
3600
3601         * Drosera/DebuggerDocument.cpp:
3602         (DebuggerDocument::breakpointEditorHTML):
3603         (DebuggerDocument::evaluateScript):
3604         (DebuggerDocument::valueForScopeVariableNamed):
3605         (DebuggerDocument::log):
3606         (DebuggerDocument::windowScriptObjectAvailable):
3607         (DebuggerDocument::toJSArray):
3608         (DebuggerDocument::callFunctionOnObject):
3609         (DebuggerDocument::logException):
3610         * Drosera/mac/DebuggerDocumentMac.mm:
3611         (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]):
3612         (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3613         (DebuggerDocument::platformEvaluateScript):
3614         (DebuggerDocument::getPlatformCurrentFunctionStack):
3615         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3616         (DebuggerDocument::platformValueForScopeVariableNamed):
3617
3618 2007-09-05  Kevin McCullough  <kmccullough@apple.com>
3619
3620         Reviewed by Adam, Sam, Darin.
3621
3622         - Separated what is platform dependant from what is not.  Creating the structure needed for Drosera for Win.
3623
3624         * Drosera/Debugger.h: Added.
3625         * Drosera/DebuggerDocument.cpp:
3626         (DebuggerDocument::breakpointEditorHTMLCallback):
3627         (DebuggerDocument::isPausedCallback):
3628         (DebuggerDocument::pauseCallback):
3629         (DebuggerDocument::resumeCallback):
3630         (DebuggerDocument::stepIntoCallback):
3631         (DebuggerDocument::evaluateScriptCallback):
3632         (DebuggerDocument::currentFunctionStackCallback):
3633         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3634         (DebuggerDocument::valueForScopeVariableNamedCallback):
3635         (DebuggerDocument::logCallback):
3636         (DebuggerDocument::breakpointEditorHTML):
3637         (DebuggerDocument::isPaused):
3638         (DebuggerDocument::pause):
3639         (DebuggerDocument::resume):
3640         (DebuggerDocument::stepInto):
3641         (DebuggerDocument::evaluateScript):
3642         (DebuggerDocument::currentFunctionStack):
3643         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3644         (DebuggerDocument::valueForScopeVariableNamed):
3645         (DebuggerDocument::log):
3646         (DebuggerDocument::toolbarPause):
3647         (DebuggerDocument::toolbarResume):
3648         (DebuggerDocument::toolbarStepInto):
3649         (DebuggerDocument::toolbarStepOver):
3650         (DebuggerDocument::toolbarStepOut):
3651         (DebuggerDocument::toolbarShowConsole):
3652         (DebuggerDocument::toolbarCloseCurrentFile):
3653         (DebuggerDocument::updateFileSource):
3654         (DebuggerDocument::didParseScript):
3655         (DebuggerDocument::willExecuteStatement):
3656         (DebuggerDocument::didEnterCallFrame):
3657         (DebuggerDocument::willLeaveCallFrame):
3658         (DebuggerDocument::exceptionWasRaised):
3659         (DebuggerDocument::windowScriptObjectAvailable):
3660         (DebuggerDocument::toJSArray):
3661         (DebuggerDocument::callGlobalFunction):
3662         (DebuggerDocument::callFunctionOnObject):
3663         (DebuggerDocument::getDroseraJSClass):
3664         (DebuggerDocument::staticFunctions):
3665         (DebuggerDocument::logException):
3666         * Drosera/DebuggerDocument.h:
3667         (DebuggerDocument::DebuggerDocument):
3668         * Drosera/ForwardingHeaders: Added.
3669         * Drosera/ForwardingHeaders/wtf: Added.
3670         * Drosera/ForwardingHeaders/wtf/Platform.h: Added.
3671         * Drosera/config.h:
3672         * Drosera/console.html:
3673         * Drosera/console.js:
3674         * Drosera/debugger.js:
3675         * Drosera/mac/DebuggerApplication.mm:
3676         (-[DebuggerApplication attach:]):
3677         * Drosera/mac/DebuggerDocumentMac.h:
3678         * Drosera/mac/DebuggerDocumentMac.mm:
3679         (+[NSString stringOrNilFromWebScriptResult:]):
3680         (+[DebuggerClientMac log:]):
3681         (-[DebuggerClientMac initWithServerName:]):
3682         (-[DebuggerClientMac dealloc]):
3683         (-[DebuggerClientMac pause]):
3684         (-[DebuggerClientMac resume]):
3685         (-[DebuggerClientMac pause:]):
3686         (-[DebuggerClientMac resume:]):
3687         (-[DebuggerClientMac stepInto:]):
3688         (-[DebuggerClientMac stepOver:]):
3689         (-[DebuggerClientMac stepOut:]):
3690         (-[DebuggerClientMac showConsole:]):
3691         (-[DebuggerClientMac closeCurrentFile:]):
3692         (-[DebuggerClientMac validateUserInterfaceItem:]):
3693         (-[DebuggerClientMac webView:windowScriptObjectAvailable:]):
3694         (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3695         (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3696         (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3697         (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3698         (DebuggerDocument::platformPause):
3699         (DebuggerDocument::platformResume):
3700         (DebuggerDocument::platformStepInto):
3701         (DebuggerDocument::platformEvaluateScript):
3702         (DebuggerDocument::platformCurrentFunctionStack):
3703         (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame):
3704         (DebuggerDocument::platformValueForScopeVariableNamed):
3705         (DebuggerDocument::platformLog):
3706         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3707
3708 2007-09-06  Sam Weinig  <sam@webkit.org>
3709
3710         Reviewed by Adam Roben.
3711
3712         Register the WebKit DLL on initialization of the DumpRenderTree.
3713
3714         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3715         (initialize):
3716
3717 2007-09-05  Sam Weinig  <sam@webkit.org>
3718
3719         Reviewed by Oliver.
3720
3721         Fix many layout test failures caused by r25364.
3722         Set text size to standand size at the begining of each test matching the mac.
3723
3724         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3725         (runTest):
3726
3727 2007-09-04  Sam Weinig  <sam@webkit.org>
3728
3729         Reviewed by Adam.
3730
3731         Fix for <rdar://problem/5382277>
3732         Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.
3733
3734         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
3735         (textZoomInCallback):
3736         (textZoomOutCallback):
3737
3738 2007-08-29  David Kilzer  <ddkilzer@apple.com>
3739
3740         Reviewed by Adam.
3741
3742         Added case-insensitivity to checks for adding regression tests.
3743
3744         * Scripts/prepare-ChangeLog:
3745         (generateFileList):
3746
3747 2007-08-28  David Kilzer  <ddkilzer@apple.com>
3748
3749         Reviewed by Maciej.
3750
3751         Ignore files in /resources/ subdirectories when creating a list of added tests.
3752
3753         * Scripts/prepare-ChangeLog:
3754         (generateFileList):
3755
3756 2007-08-27  Kevin McCullough  <kmccullough@apple.com>
3757
3758         Reviewed by John.
3759
3760         - Removed Leopard leaks list since all of those radars were fixed.
3761
3762         * Scripts/run-webkit-tests:
3763
3764 2007-08-27  Adam Roben  <aroben@apple.com>
3765
3766         Rubberstamped by Mark.
3767
3768         * Scripts/pdevenv: Pass arguments along to devenv.com.
3769
3770 2007-08-26  David Kilzer  <ddkilzer@webkit.org>
3771
3772         Reviewed by Mark Rowe.
3773
3774         Update prepare-ChangeLog to generate the datestamp in the correct timezone.
3775
3776         * Scripts/prepare-ChangeLog:
3777         (changeLogDate): Added.
3778
3779 2007-08-24  Sam Weinig  <sam@webkit.org>
3780
3781         Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.
3782
3783 2007-08-24  Sam Weinig  <sam@webkit.org>
3784
3785         Rubber-stamped by Adam Roben.
3786
3787         <rdar://problem/5434593> Deprecate current manually written COM DOM bindings in anticipation of autogeneration
3788
3789         Rename COM DOM bindings to use Deprecated prefix.
3790
3791         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3792         (dumpFramesAsText):
3793         (dump):
3794         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp:
3795         (dumpPath):
3796         (dump):
3797         (EditingDelegate::shouldBeginEditingInDOMRange):
3798         (EditingDelegate::shouldEndEditingInDOMRange):
3799         (EditingDelegate::shouldInsertNode):
3800         (EditingDelegate::shouldInsertText):
3801         (EditingDelegate::shouldDeleteDOMRange):
3802         (EditingDelegate::shouldChangeSelectedDOMRange):
3803         (EditingDelegate::shouldApplyStyle):
3804         (EditingDelegate::shouldChangeTypingStyle):
3805         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h:
3806
3807 2007-08-24  Oliver Hunt  <oliver@apple.com>
3808
3809         Reviewed by John H.
3810
3811         WebDataSource::response can legitimately have a null response, so we
3812         must check that case.
3813
3814         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3815         (queueLoadCallback):
3816
3817 2007-08-23  Mitz Pettel  <mitz@webkit.org>
3818
3819         Reviewed by Darin and Adam.
3820
3821         - DumpRenderTree changes to allow testing for
3822           http://bugs.webkit.org/show_bug.cgi?id=11756
3823           REGRESSION: link targeting a frame in another window does not work
3824           <rdar://problem/5286420>
3825
3826         Use a frame group name for all WebViews created by DumpRenderTree to
3827         allow testing of cross-page frame lookup.
3828
3829         * DumpRenderTree/DumpRenderTree.m:
3830         (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
3831         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3832         (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).
3833
3834 2007-08-23  David Kilzer  <ddkilzer@webkit.org>
3835
3836         Reviewed by Adam.
3837
3838         Quote the $sslCertificate path in case it contains a space.
3839
3840         * Scripts/run-webkit-httpd:
3841         * Scripts/run-webkit-tests:
3842
3843 2007-08-22  Oliver Hunt  <oliver@apple.com>
3844
3845         Reviewed by John and Adam.
3846         
3847         WebDataSource::response can legitimately have a null response, so we
3848         must check that case.
3849
3850         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3851         (dump):
3852
3853 2007-08-21  Kevin McCullough  <kmccullough@apple.com>
3854
3855         Reviewed by Geof.
3856
3857         - Changing the usage to be more clear.
3858
3859         * Scripts/run-testkjs:
3860
3861 2007-08-20  John Sullivan  <sullivan@apple.com>
3862
3863         Reviewed by Adam Roben
3864
3865         * DumpRenderTree/DumpRenderTree.m:
3866         (runTest):
3867         call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors
3868         in layout tests on Tiger and Leopard
3869
3870 2007-08-20  Adam Roben  <aroben@apple.com>
3871
3872         Put LayoutTests after all other ChangeLogs in commit logs
3873
3874         We use "~" to sort LayoutTests after all the other ChangeLogs because
3875         "~" is the last ASCII character (other than "DEL").
3876
3877         Reviewed by Sam.
3878
3879         * Scripts/commit-log-editor:
3880
3881 2007-08-20  Adam Roben  <aroben@apple.com>
3882
3883         Detect that DRT crashed even if a crash dialog is running
3884
3885         On Windows, when DRT crashes a crash dialog commonly appears. The DRT
3886         process is still running at this point, so run-webkit-tests wouldn't
3887         detect that DRT had crashed. We now record the crash in our SIGPIPE
3888         handler so that we know if DRT crashed even if the crash dialog is up.
3889
3890         Reviewed by Sam.
3891
3892         * Scripts/run-webkit-tests:
3893         (sub catch_pipe): Set the crashed bit.
3894         (sub openDumpTool): Reset the crashed bit.
3895         (sub dumpToolDidCrash): Check the crashed bit.
3896
3897 2007-08-20  Adam Roben  <aroben@apple.com>
3898
3899         Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog
3900
3901         http://bugs.webkit.org/show_bug.cgi?id=15026
3902
3903         Reviewed by David Kilzer and Darin Adler.
3904
3905         * Scripts/prepare-ChangeLog:
3906         (sub isModifiedStatus): Split out from isModifiedOrAddedStatus.
3907         (sub isAddedStatus): Ditto.
3908         (sub testListForChangeLog): Added.
3909
3910 2007-08-19  Oleg Sukhodolsky  <son.two@gmail.com>
3911
3912         Reviewed by Mark.
3913
3914         -fixes http://bugs.webkit.org/show_bug.cgi?id=14632
3915
3916         * Scripts/webkitdirs.pm:
3917         qt and gtk ports now explicitly pass debug (or release) mode to qmake.
3918
3919 2007-08-17  Darin Adler  <darin@apple.com>
3920
3921         Reviewed by Oliver Hunt.
3922
3923         - don't look for Apple-style localizable strings in the GTK version of WebKit
3924
3925         * Scripts/extract-localizable-strings: Add a feature where you can pass in the
3926         name of subdirectories to skip.
3927         * Scripts/update-webkit-localizable-strings: Pass WebKit/gtk as a subdirectory
3928         to skip.
3929
3930 2007-08-17  Anders Carlsson  <andersca@apple.com>
3931
3932         Build fix.
3933         
3934         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3935         (NPP_SetWindow):
3936
3937 2007-08-17  Anders Carlsson  <andersca@apple.com>
3938
3939         Reviewed by Dave Hyatt.
3940
3941         <rdar://problem/5379040>
3942         REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes
3943
3944         Add a way for the plug-in to dump the width and height when it gets its  NPP_SetWindow call.
3945         
3946         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
3947         (pluginAllocate):
3948         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3949         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3950         (NPP_New):
3951         (NPP_SetWindow):
3952
3953 2007-08-16  Alice Liu  <alice.liu@apple.com>
3954
3955         Reviewed by Maciej.
3956
3957         Fix <rdar://problem/5360135> REGRESSION (Leopard only): editing/selection/5354455-1.html is causing subsequent tests to fail
3958
3959         * DumpRenderTree/DumpRenderTree.m:
3960         (createWebView):
3961         Create a DumpRenderTreeWindow instead of a NSWindow, now that a DumpRenderTreeWindow no longer poses as a NSWindow.
3962         (dumpRenderTree):
3963         Don't pose as a NSWindow, since when the spelling panel gets created, it creates an NSWindow which ends up creating a DumpRenderTreeWindow. 
3964
3965 2007-08-16  Kevin McCullough  <kmccullough@apple.com>
3966
3967         Reviewed by Adam.
3968
3969         - Added tests for regressions in other components.  In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
3970
3971         * Scripts/run-webkit-tests:
3972
3973 2007-08-15  Timothy Hatcher  <timothy@apple.com>
3974
3975         Look for the new Xcode 3 preference key (PBXApplicationwideBuildSettings) for the global build locations.
3976         The value of PBXApplicationwideBuildSettings is a dictionary, so we have to pull the SYMROOT out of it.
3977
3978         Also pass xcodebuild OBJROOT with the same value as SYMROOT if we fallback to the default WebKitBuild,
3979         this prevents making "build" directories in each project folder.
3980
3981         * Scripts/webkitdirs.pm:
3982
3983 2007-08-14  Geoffrey Garen  <ggaren@apple.com>
3984
3985         Reviewed by Kevin Mccullough.
3986         
3987         Removed special case that didn't belong. (It would allow a global 
3988         initializer to sneak into production builds, which would cause a 
3989         system-wide performance regression on Mac OS X.)
3990
3991         * Scripts/check-for-global-initializers:
3992
3993 2007-08-14  Justin Garcia  <justin.garcia@apple.com>
3994
3995         Reviewed by Tim.
3996         
3997         <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
3998
3999         * DumpRenderTree/EditingDelegate.m:
4000         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES
4001         only for elements with the class needsDeletionUI.
4002
4003 2007-08-14  David Kilzer  <ddkilzer@webkit.org>
4004
4005         Reviewed by Darin.
4006
4007         - fix http://bugs.webkit.org/show_bug.cgi?id=14965
4008           svn-create-patch uses deprecated tail switch
4009
4010         * Scripts/svn-create-patch: Use 'tail -n +3' instead of 'tail +3'.
4011
4012 2007-08-13  Sam Weinig  <sam@webkit.org>
4013
4014         Reviewed by Adam Roben.
4015
4016         Use the cygwin specific Apache config file under cygwin.
4017
4018         * Scripts/run-webkit-httpd:
4019
4020 2007-08-12  Adam Roben  <aroben@apple.com>
4021
4022         Generate results for new tests in a more logical location
4023
4024         New platform-specific tests always have their results generated right
4025         next to the test. New cross-platform tests will have their results
4026         generated a) in the cross-platform directory, if they are text-only,
4027         or b) in the least-specific platform directory, if they are render
4028         tree dumps.
4029
4030         Reviewed by Lars.
4031
4032         * Scripts/run-webkit-tests:
4033
4034 2007-08-12  Adam Roben  <aroben@apple.com>
4035
4036         Print the actual directory where new results are generated.
4037
4038         Before, we were printing an unpredictable, context-specific substring
4039         of the directory.
4040
4041         Reviewed by Lars.
4042
4043         * Scripts/run-webkit-tests:
4044
4045 2007-08-12  Adam Roben  <aroben@apple.com>
4046
4047         Factor some common code into a stripExtension() subroutine.
4048
4049         Reviewed by Lars.
4050
4051         * Scripts/run-webkit-tests: Also removed some debugging output.
4052
4053 2007-08-11  Matt Lilek  <pewtermoose@gmail.com>
4054
4055         Reviewed over and over and over by Adam Roben.
4056
4057         Bug 14740: Hierarchical layout tests and platform organization
4058         http://bugs.webkit.org/show_bug.cgi?id=14740
4059
4060         Add support for platform-specific layout tests and results.
4061
4062         * Scripts/run-webkit-tests:
4063
4064 2007-08-11  David Kilzer  <ddkilzer@webkit.org>
4065
4066         Reviewed by Adam.
4067
4068         Refactored svn-create-path to use a hash-of-hashes data structure to keep
4069         track of changed files.  In the top level hash, keys are paths to files and
4070         values are 'fileData' hashes with the following keys and values:
4071
4072         - isBinary: boolean value (set to true for non-text files like images, etc.)
4073         - isTestFile: boolean value (set to true if file exists within a known test
4074           directory)
4075         - modificationType: string equal to one of 'addition', 'additionWithHistory',
4076           'modification' or 'deletion'
4077         - path: string equal to the path to the file (this may seem redundant, but it
4078           is required to use the second-level 'fileData' hash independent of the
4079           top-level hash)
4080         - sourceFile: [optional] string equal to the path of the original file that was
4081           copied or moved
4082         - sourceRevision: [optional] string equal to the revision of the original file
4083           that was copied or moved
4084
4085         * Scripts/svn-create-patch: Moved call to GetOptions() to its own statement
4086         that saves the return value in $result, then checks it before printing help.
4087         Combined sourceFiles, %testFiles, and %binaryFiles into single %diffFiles hash
4088         and eliminated two for() loops.
4089         (binarycmp): Added.  Used with sort() to order non-binary files before binary
4090         files.
4091         (findBaseUrl): Added.  Extracted from findSourceFileAndRevision().
4092         (findMimeType): Added optional second argument that takes a revision number.
4093         (generateDiff): Updated to take one fileData argument instead of three ($file,
4094         $modificationType, $isBinary).
4095         (generateFileList): Updated to take one hash ref argument (%diffFiles)
4096         instead of three (%sourceFiles, %testFiles, %binaryFiles).  Populates
4097         %diffFiles using paths for keys and fileData hashes for values.
4098         (manufacturePatchForAdditionWithHistory): Updated to take one fileData
4099         argument.
4100         (pathcmp): Updated to take two fileData arguments instead of two strings.
4101         (testfilecmp): Added.  Used with sort() to order non-test files before test
4102         files.
4103
4104 2007-08-11  Darin Adler  <darin@apple.com>
4105
4106         * Scripts/run-webkit-tests: Give a different message when only the pixel test failed.
4107
4108 2007-08-06  Nigel Tao  <nigeltao@gnome.org>
4109
4110         Reviewed by David Kilzer.
4111
4112         Fix bug 14745: WebKitTools/Scripts/run-launcher doesn't speak --gdk
4113         http://bugs.webkit.org/show_bug.cgi?id=14745
4114
4115         * Scripts/run-launcher:
4116         Scrub the "--gdk" out of the command line args, if given, so that
4117         GdkLauncher doesn't try to interpret it as a URL.
4118
4119 2007-08-03  Adam Roben  <aroben@apple.com>
4120
4121         Catch SIGPIPE on Windows so that run-webkit-tests doesn't quit when DRT crashes
4122
4123         Reviewed by Sam.
4124
4125         * Scripts/run-webkit-tests: Also close ERROR when we finish running the tests.
4126
4127 2007-08-03  Sam Weinig  <sam@webkit.org>
4128
4129         Reviewed by Darin.
4130
4131         Recursively dump all frames as text using new
4132         layoutTestController.dumpChildFramesAsText() function.
4133
4134         * DumpRenderTree/DumpRenderTree.m:
4135         (dumpFramesAsText):
4136         (dump):
4137         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
4138         (-[LayoutTestController dumpChildFramesAsText]):
4139         (runTest):
4140         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
4141         (dumpFramesAsText):
4142         (dump):
4143         (runTest):
4144         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
4145         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
4146         (dumpChildFramesAsTextCallback):
4147         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4148
4149 2007-08-02  Adam Roben  <aroben@apple.com>
4150
4151         Fix fast/dom/Window/alert-undefined.html
4152
4153         Reviewed by Sam.
4154
4155         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
4156         (WaitUntilDoneDelegate::runJavaScriptAlertPanelWithMessage): Don't let
4157         Windows translate a null BSTR into "(null)"
4158
4159 2007-08-02  Kevin McCullough  <kmccullough@apple.com>
4160
4161         Reviewed by Tim. 
4162
4163         - It would help if I actually called the right function.
4164
4165         * Drosera/DebuggerDocument.cpp:
4166         (DebuggerDocument::showConsole):
4167
4168 2007-08-02  Adam Roben  <aroben@apple.com>
4169
4170         Don't delete the stderr file right after creating it
4171
4172         * Scripts/run-webkit-tests:
4173
4174 2007-08-01  Adam Roben  <aroben@apple.com>
4175
4176         When DRT crashes, record stderr and restart DRT
4177
4178         This prevents a DRT crash from causing the next few hundred tests to
4179         "fail" because DRT is no longer running. 
4180
4181         I also changed the terminology that run-webkit-tests uses in its
4182         output a bit, so that crashing tests are referred to as "