2010-01-14 Yuzo Fujishima <yuzo@google.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-01-14  Yuzo Fujishima  <yuzo@google.com>
2
3         Reviewed by Alexey Proskuryakov.
4
5         Update pywebsocket to 0.4.6
6         https://bugs.webkit.org/show_bug.cgi?id=32299
7         The newer pywebsocket can handle more simultaneous connections.
8
9         * pywebsocket/mod_pywebsocket/handshake.py:
10         * pywebsocket/mod_pywebsocket/standalone.py:
11         * pywebsocket/setup.py:
12         * pywebsocket/test/test_handshake.py:
13
14 2010-01-14  Eric Seidel  <eric@webkit.org>
15
16         Reviewed by Adam Barth.
17
18         REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs
19         https://bugs.webkit.org/show_bug.cgi?id=33638
20
21         * Scripts/webkitpy/bugzilla.py:
22          - Add Bug.id() to match Attachment.id()
23          - Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers.
24          - Add back a missing variable to _validate_setter_email found by the new unit tests!
25         * Scripts/webkitpy/commands/queries.py:
26          - Add FIXMEs about the commands being confusingly named.
27         * Scripts/webkitpy/commands/queries_unittest.py:
28          - Update results to reflect the newly restructured mock bug cache.
29         * Scripts/webkitpy/commands/queues.py:
30          - Add a new _validate_patches_in_commit_queue method (this is what fixes the regression).
31          - Add a FIXME about eventually sorting the patches into some order.
32         * Scripts/webkitpy/commands/queues_unittest.py:
33          - Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer.
34         * Scripts/webkitpy/commands/upload_unittest.py:
35          - Update results to match the newly restructured mock bug cache.
36         * Scripts/webkitpy/mock_bugzillatool.py:
37          - Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs.
38          - Add a few more attachments and bug dictionaries for use by the tests.
39
40 2010-01-13  Diego Gonzalez  <diego.gonzalez@openbossa.org>
41
42         Reviewed by Kenneth Christiansen.
43
44         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
45         https://bugs.webkit.org/show_bug.cgi?id=33617
46
47         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
48         (WebCore::WebPage::resetSettings):
49         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
50         (LayoutTestController::setUserStyleSheetLocation):
51         (LayoutTestController::setUserStyleSheetEnabled):
52         * DumpRenderTree/qt/LayoutTestControllerQt.h:
53
54 2010-01-14  Adam Roben  <aroben@apple.com>
55
56         Add LayoutTestController API to force
57         -webView:resource:willSendRequest:: to return null
58
59         Enables tests for <rdar://problem/7533333> <http://webkit.org/b/33533>
60         window.onload never fires if page contains an <iframe> with a bad
61         scheme or whose load is cancelled by returning null from resource load
62         delegate's willSendRequest
63
64         Reviewed by Brady Eidson.
65
66         * DumpRenderTree/LayoutTestController.cpp:
67         (LayoutTestController::LayoutTestController): Initialize new member.
68         (setWillSendRequestReturnsNullCallback): Call through to
69         LayoutTestController.
70         (LayoutTestController::staticFunctions): Added new function.
71
72         * DumpRenderTree/LayoutTestController.h: Added
73         m_willSendRequestReturnsNull.
74         (LayoutTestController::willSendRequestReturnsNull):
75         (LayoutTestController::setWillSendRequestReturnsNull):
76         Added standard accessors.
77
78         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
79         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
80         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
81         (ResourceLoadDelegate::willSendRequest):
82         Return null if LayoutTestController says to.
83
84 2010-01-14  Kevin Ollivier  <kevino@theolliviers.com>
85
86         [wx] Build fix after removal of XBM support.
87
88         * wx/build/settings.py:
89
90 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
91
92         Reviewed by Simon Hausmann.
93
94         Add support for partial building on Symbian.
95
96         The build happens in the source directory as out of source builds are
97         not supported by qmake for Symbian.
98
99         Also the actual build isn't started but it is left to the developer
100         to choose the architecture/configuration.
101
102         * Scripts/webkitdirs.pm:
103
104 2010-01-14  Simon Hausmann  <simon.hausmann@nokia.com>
105
106         Reviewed by Kenneth Rohde Christiansen.
107
108         Add support for "detecting" Symbian environments by either
109         looking for the EPOCROOT environment variable or via --symbian
110         being passed on the commandline.
111
112         * Scripts/webkitdirs.pm:
113
114 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
115
116         Unreviewed.
117
118         [Qt] Use a different Makefile names for sources generation and compilation.
119         This prevents Makefile overwriting when running build-webkit twice.
120
121         * Scripts/webkitdirs.pm:
122
123 2010-01-14  Andreas Kling  <andreas.kling@nokia.com>
124
125         Reviewed by Kenneth Rohde Christiansen.
126
127         [Qt] Add an "alien_QLabel" classId for manual testing of alien widgets.
128
129         https://bugs.webkit.org/show_bug.cgi?id=33373
130
131         * QtLauncher/main.cpp:
132         (WebPage::createPlugin):
133
134 2010-01-14  Eric Seidel  <eric@webkit.org>
135
136         No review, rolling out r53249.
137         http://trac.webkit.org/changeset/53249
138         https://bugs.webkit.org/show_bug.cgi?id=33617
139
140         This caused http/tests/security/local-user-CSS-from-
141         remote.html to fail on the Qt Release Build Bot.
142
143         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
144         (WebCore::WebPage::resetSettings):
145         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
146         (LayoutTestController::overridePreference):
147         * DumpRenderTree/qt/LayoutTestControllerQt.h:
148
149 2010-01-14  Chris Jerdonek  <chris.jerdonek@gmail.com>
150
151         Reviewed by Shinichiro Hamaji.
152
153         Moved error() from cpp_style.py to checker.py.
154
155         https://bugs.webkit.org/show_bug.cgi?id=33620
156
157         * Scripts/check-webkit-style:
158           - Addressed FIXME to not set global state.
159
160         * Scripts/webkitpy/style/checker.py:
161           - Added argument validation to ProcessorOptions constructor.
162           - Added should_report_error() to ProcessorOptions class.
163           - Removed set_options().
164           - Added StyleChecker class.
165
166         * Scripts/webkitpy/style/checker_unittest.py:
167           - Added unit test class for ProcessorOptions class.
168           - Added unit test to check that parse() strips white space.
169
170         * Scripts/webkitpy/style/cpp_style.py:
171           - Removed "filter" and "output_format" methods.
172           - Removed should_print_error() and error() functions.
173           - Removed default parameter value from process_file().
174
175         * Scripts/webkitpy/style/cpp_style_unittest.py:
176           - Removed call to cpp_style._should_print_error().
177           - Removed test_filter() and test_filter_appending().
178
179         * Scripts/webkitpy/style/text_style.py:
180           - Removed default parameter value from process_file().
181
182 2010-01-14  Diego Gonzalez  <diego.gonzalez@openbossa.org>
183
184         Reviewed by Kenneth Rohde Christiansen.
185
186         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
187         https://bugs.webkit.org/show_bug.cgi?id=33617
188
189         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
190         (WebCore::WebPage::resetSettings):
191         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
192         (LayoutTestController::setUserStyleSheetLocation):
193         (LayoutTestController::setUserStyleSheetEnabled):
194         * DumpRenderTree/qt/LayoutTestControllerQt.h:
195
196 2010-01-13  Adam Barth  <abarth@webkit.org>
197
198         Reviewed by Eric Seidel.
199
200         Fix CloseBugForLandDiff unittest to actually run
201         https://bugs.webkit.org/show_bug.cgi?id=33640
202
203         * Scripts/webkitpy/mock_bugzillatool.py:
204         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
205
206 2010-01-12  Jon Honeycutt  <jhoneycutt@apple.com>
207
208         MSAA: selected, selectable, extended selectable, and multiple
209         selectable states are not reported
210
211         https://bugs.webkit.org/show_bug.cgi?id=33574
212         <rdar://problem/7536826>
213
214         Reviewed by Darin Adler.
215
216         * DumpRenderTree/AccessibilityUIElement.cpp:
217         (getIsSelectableCallback):
218         Return the result of calling isSelectable().
219         (getIsMultiSelectableCallback):
220         Return the result of calling isMultiSelectable().
221         (AccessibilityUIElement::getJSClass):
222         Add isSelected and isMultiSelectable properties to the JSClass
223         definition.
224
225         * DumpRenderTree/AccessibilityUIElement.h:
226         Declare isSelectable() and isMultiSelectable().
227
228         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
229         (AccessibilityUIElement::isSelectable):
230         Stubbed.
231         (AccessibilityUIElement::isMultiSelectable):
232         Stubbed.
233
234         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
235         (AccessibilityUIElement::isSelectable):
236         Stubbed.
237         (AccessibilityUIElement::isMultiSelectable):
238         Stubbed.
239
240         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
241         (accessibilityState):
242         Get the object's state, and return it.
243         (AccessibilityUIElement::isSelected):
244         Check the object's selected state.
245         (AccessibilityUIElement::isSelectable):
246         Check the object's selectable state.
247         (AccessibilityUIElement::isMultiSelectable):
248         Check the object's extended/multiple selectable state.
249
250 2010-01-13  Adam Barth  <abarth@webkit.org>
251
252         Unreviewed.  Repeat the below for CloseBugForLandDiff.
253
254         * Scripts/test-webkitpy:
255         * Scripts/webkitpy/steps/closebugforlanddiff.py:
256         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added.
257
258 2010-01-13  Adam Barth  <abarth@webkit.org>
259
260         Unreviewed.  Turn the mac-ews status bubbles back on now that this bot
261         is running again.
262
263         * QueueStatusServer/templates/statusbubble.html:
264
265 2010-01-13  Adam Barth  <abarth@webkit.org>
266
267         Reviewed by Darin Adler.
268
269         REGRESSION(53133): webkit-patch land dies if it can't find a bug id.
270         https://bugs.webkit.org/show_bug.cgi?id=33634
271
272         Deal with the case of no bug patch object in the state.
273
274         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
275         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py:
276
277 2010-01-13  Kenneth Russell  <kbr@google.com>
278
279         Unreviewed; added myself to the committers list.
280
281         * Scripts/webkitpy/committers.py:
282
283 2010-01-13  Darin Adler  <darin@apple.com>
284
285         Ignore compiled Python in more of webkitpy.
286
287         * Scripts/webkitpy/commands: Added property svn:ignore.
288         * Scripts/webkitpy/steps: Added property svn:ignore.
289         * Scripts/webkitpy/style: Added property svn:ignore.
290
291 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
292
293         Reviewed by Simon Hausmann.
294
295         [Qt] Fix build problem related to the pushd command
296
297         * Scripts/webkitdirs.pm:
298
299 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
300
301         Reviewed by Simon Hausmann.
302
303         [Qt] Split the build process in two different .pro files.
304         This allows qmake to be run once all source files are available.
305
306         * Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC.
307
308 2010-01-13  Shinichiro Hamaji  <hamaji@chromium.org>
309
310         Unreviewed tiny typo fix in docstrings.
311
312         * Scripts/webkitpy/style/checker_unittest.py:
313
314 2010-01-13  Chris Jerdonek  <chris.jerdonek@gmail.com>
315
316         Reviewed by Shinichiro Hamaji.
317
318         Created a CategoryFilter class to encapsulate the logic of
319         filter rules.
320
321         https://bugs.webkit.org/show_bug.cgi?id=33454
322
323         * Scripts/webkitpy/style/checker.py:
324           - Added CategoryFilter class.
325
326         * Scripts/webkitpy/style/checker_unittest.py:
327           - Added CategoryFilter unit tests.
328
329         * Scripts/webkitpy/style/cpp_style.py:
330           - Updated filter methods to use CategoryFilter.
331
332         * Scripts/webkitpy/style/cpp_style_unittest.py:
333           - Updated references to filters.
334
335 2010-01-12  Shinichiro Hamaji  <hamaji@chromium.org>
336
337         Unreviewed. Now I can review :)
338
339         * Scripts/webkitpy/committers.py:
340
341 2010-01-12  Brent Fulgham  <bfulgham@webkit.org>
342
343         Reviewed by Darin Adler.
344
345         Extend WinLauncher example with better printing features.
346
347         * WinLauncher/PrintWebUIDelegate.cpp:
348         (PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly
349          larger margins.
350         (PrintWebUIDelegate::webViewHeaderHeight): Compute header height based
351          on text metrics.
352         (PrintWebUIDelegate::webViewFooterHeight): Compute footer height based
353          on text metrics.
354         (PrintWebUIDelegate::drawHeaderInRect): Write useful header, along
355          with separating line.
356         (PrintWebUIDelegate::drawFooterInRect):
357         * WinLauncher/PrintWebUIDelegate.h: Remove stubs.
358         * WinLauncher/WinLauncher.cpp:
359         (PrintView): Correct loop used to print individual pages.
360          Previously it started at 0, which is a wild-card to print all
361          pages at once.
362
363 2010-01-12  Alexey Proskuryakov  <ap@apple.com>
364
365         Reviewed by Darin Adler.
366
367         https://bugs.webkit.org/show_bug.cgi?id=33540
368         Make it possible to build in debug mode with assertions disabled
369
370         * DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]):
371
372 2010-01-11  Darin Fisher  <darin@chromium.org>
373
374         Reviewed by Dimitri Glazkov.
375
376         [Chromium] "build-webkit --chromium" should run "make all" on Linux
377         https://bugs.webkit.org/show_bug.cgi?id=33500
378
379         * Scripts/webkitdirs.pm:
380
381 2010-01-12  Eric Seidel  <eric@webkit.org>
382
383         Reviewed by Adam Barth.
384
385         AssignToCommitter does not need to fetch bugs twice
386         https://bugs.webkit.org/show_bug.cgi?id=33530
387
388         This is a no-brainer patch now that we've added Bug.reviewed_patches
389
390         * Scripts/webkitpy/commands/upload.py:
391
392 2010-01-12  Eric Seidel  <eric@webkit.org>
393
394         Reviewed by Adam Barth.
395
396         bugzilla.py should have an Attachment object instead of passing around dictionaries
397         https://bugs.webkit.org/show_bug.cgi?id=31594
398
399         * Scripts/webkitpy/bugzilla.py:
400          - Add a new Attachment class, with accessor methods for all the necessary properties.
401          - Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url())
402          - Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug
403          - Move committer validation logic into its own class.
404          - Committer rejection is only used in one place.  Make the new Bug reviewed_patches and commit_queued_patches
405            handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle
406            the case where we want to reject patches in bugzilla.
407          - Simplify fetch_patches_from_commit_queue now that committer validation is simpler.
408          - Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug.
409          - Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it.
410          - Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class.
411         * Scripts/webkitpy/bugzilla_unittest.py:
412          - Move test_flag_permission_rejection_message into a new CommitterValidationTest class.
413         * Scripts/webkitpy/commands/download.py:
414          - Store "bug_id" in state instead of making a fake patch object.
415          - Update to use Attachment and Bug objects.
416         * Scripts/webkitpy/commands/download_unittest.py:
417          - Update expected results now that our testing framework covers more code.
418         * Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class.
419         * Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class.
420         * Scripts/webkitpy/commands/queries_unittest.py: ditto.
421         * Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes.
422         * Scripts/webkitpy/commands/queuestest.py: ditto.
423         * Scripts/webkitpy/commands/upload.py: ditto.
424         * Scripts/webkitpy/mock_bugzillatool.py:
425          - Now that more logic has moved into Attachment and Bug, we have to actually
426            provide real reviewer emails as well as real reviewer flags.
427          - Update mock methods to return Attachment objects.
428         * Scripts/webkitpy/scm.py: Update to use Attachment class.
429         * Scripts/webkitpy/scm_unittest.py: Update to use Attachment class.
430         * Scripts/webkitpy/statusserver.py: ditto.
431         * Scripts/webkitpy/steps/applypatch.py: ditto.
432         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto.
433         * Scripts/webkitpy/steps/closebug.py: ditto.
434         * Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either state["bug_id"] or state["patch"].bug_id()
435         * Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class.
436         * Scripts/webkitpy/steps/obsoletepatches.py: ditto.
437         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto.
438
439 2010-01-12  Adam Barth  <abarth@webkit.org>
440
441         Unreviewed typo fix.  :(
442
443         * Scripts/webkitpy/commands/early_warning_system.py:
444         * Scripts/webkitpy/commands/queues.py:
445
446 2010-01-12  Adam Barth  <abarth@webkit.org>
447
448         Unreviewed.  Add "error" to the right part of the message.
449
450         * Scripts/webkitpy/commands/queues.py:
451
452 2010-01-12  Adam Barth  <abarth@webkit.org>
453
454         Reviewed by Eric Seidel.
455
456         EWS should show purple when svn-apply fails
457         https://bugs.webkit.org/show_bug.cgi?id=33527
458
459         * Scripts/webkitpy/commands/early_warning_system.py:
460         * Scripts/webkitpy/commands/queues.py:
461
462 2010-01-12  Adam Barth  <abarth@webkit.org>
463
464         Reviewed by Eric Seidel.
465
466         Remove copy/paste code from subclasses of AbstractReviewQueue
467         https://bugs.webkit.org/show_bug.cgi?id=33525
468
469         * Scripts/webkitpy/commands/early_warning_system.py:
470         * Scripts/webkitpy/commands/queues.py:
471
472 2010-01-12  Adam Barth  <abarth@webkit.org>
473
474         Reviewed by Eric Seidel.
475
476         Add Gustavo and Xan as gtk-ews watchers
477         https://bugs.webkit.org/show_bug.cgi?id=33519
478
479         * Scripts/webkitpy/commands/early_warning_system.py:
480
481 2010-01-12  Adam Barth  <abarth@webkit.org>
482
483         Reviewed by Eric Seidel.
484
485         webkit-patch shouldn't waste my time for with a component prompt
486         https://bugs.webkit.org/show_bug.cgi?id=33521
487
488         The component field isn't very useful for bugs created with
489         webkit-patch because they're likely to be resolved quickly.  Instead of
490         always prompting for a component, we should just default to the "New
491         Bugs" component.  If the bug stays around for more than five minutes,
492         we can assign it a proper component.
493
494         * Scripts/webkitpy/bugzilla.py:
495
496 2010-01-12  Adam Barth  <abarth@webkit.org>
497
498         Reviewed by Eric Seidel.
499
500         Add experimental "land-safely" command to webkit-patch
501         https://bugs.webkit.org/show_bug.cgi?id=33518
502
503         * Scripts/webkitpy/commands/upload.py:
504         * Scripts/webkitpy/commands/upload_unittest.py:
505         * Scripts/webkitpy/steps/__init__.py:
506         * Scripts/webkitpy/steps/postdiffforcommit.py: Added.
507
508 2010-01-11  Kevin Ollivier  <kevino@theolliviers.com>
509
510         [wx] Build fix after introduction of JS_NO_EXPORT
511         
512         * wx/build/settings.py:
513
514 2010-01-11  Eric Seidel  <eric@webkit.org>
515
516         No review, rolling out r53079.
517         http://trac.webkit.org/changeset/53079
518         https://bugs.webkit.org/show_bug.cgi?id=33197
519
520         Adam doens't think this actually works, and believe it caused
521         a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so
522         rolling this out.
523
524         * Scripts/test-webkitpy:
525         * Scripts/webkitpy/commands/abstractdiffcommand.py: Removed.
526         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed.
527         * Scripts/webkitpy/commands/download.py:
528         * Scripts/webkitpy/commands/upload.py:
529         * Scripts/webkitpy/mock_bugzillatool.py:
530
531 2010-01-10  Adam Barth  <abarth@webkit.org>
532
533         Reviewed by David Kilzer.
534
535         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
536         https://bugs.webkit.org/show_bug.cgi?id=33197
537
538         We should just search for bug numbers in the ChangeLogs instead of in
539         the whole diff.
540  
541         * Scripts/test-webkitpy:
542         * Scripts/webkitpy/commands/abstractdiffcommand.py: Added.
543         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added.
544         * Scripts/webkitpy/commands/download.py:
545         * Scripts/webkitpy/commands/upload.py:
546         * Scripts/webkitpy/mock_bugzillatool.py:
547
548 2010-01-11  Chris Jerdonek  <chris.jerdonek@gmail.com>
549
550         Reviewed by David Kilzer.
551
552         Created a unit-tested function to parse the header block of
553         a Git or SVN diff -- for future refactoring of svn-apply and
554         svn-unapply.
555
556         https://bugs.webkit.org/show_bug.cgi?id=33447
557
558         * Scripts/VCSUtils.pm:
559           - Added parseDiffHeader().
560           - Removed irrelevant comment from gitdiff2svndiff().
561
562         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added.
563           - Added 48 unit tests for parseDiffHeader().
564
565 2010-01-10  Adam Barth  <abarth@webkit.org>
566
567         Rubber stamped by David Kilzer.
568
569         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
570         https://bugs.webkit.org/show_bug.cgi?id=33197
571
572         Fix a typo: Commmand -> Command.
573
574         * Scripts/webkitpy/commands/abstractsequencedcommand.py:
575         * Scripts/webkitpy/commands/download.py:
576         * Scripts/webkitpy/commands/queries.py:
577         * Scripts/webkitpy/commands/upload.py:
578         * Scripts/webkitpy/multicommandtool.py:
579
580 2010-01-10  Adam Barth  <abarth@webkit.org>
581
582         Reviewed by Darin Adler.
583
584         Let webkit-patch work with options in $EDITOR
585         https://bugs.webkit.org/show_bug.cgi?id=33414
586
587         The $EDITOR evironment variable might have command line options like
588         bbedit -w.  This patch lets us run those $EDITORs.
589
590         * Scripts/webkitpy/user.py:
591
592 2010-01-10  Robert Hogan  <robert@roberthogan.net>
593
594         Reviewed by Adam Barth.
595
596         [Qt] Add enableXSSAuditor support to QWebSettings and DRT.
597
598         https://bugs.webkit.org/show_bug.cgi?id=33419
599
600         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
601         (WebCore::WebPage::WebPage):
602         (WebCore::WebPage::resetSettings):
603         (WebCore::DumpRenderTree::createWindow):
604         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
605         (LayoutTestController::setXSSAuditorEnabled):
606         * DumpRenderTree/qt/LayoutTestControllerQt.h:
607
608 2010-01-10  Adam Barth  <abarth@webkit.org>
609
610         Unreviewed cosmetic change.  Remove the status bubble for mac-ews
611         because we don't have hardware for it at the moment.
612
613         * QueueStatusServer/templates/statusbubble.html:
614
615 2010-01-09  Daniel Bates  <dbates@webkit.org>
616
617         No review, rolling out r53044.
618         http://trac.webkit.org/changeset/53044
619         https://bugs.webkit.org/show_bug.cgi?id=33419
620         
621         We need to look into this some more because the Qt
622         bot is failing the XSSAuditor tests. See bug #33419
623         for more details.
624
625         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
626         (WebCore::WebPage::WebPage):
627         (WebCore::WebPage::resetSettings):
628         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
629         * DumpRenderTree/qt/LayoutTestControllerQt.h:
630
631 2010-01-09  Daniel Bates  <dbates@webkit.org>
632
633         Reviewed by Adam Barth.
634
635         https://bugs.webkit.org/show_bug.cgi?id=33419
636
637         Adds support for the XSSAuditor to the Qt DRT.
638
639         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
640         (WebCore::WebPage::WebPage):
641         (WebCore::WebPage::resetSettings):
642         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
643         (LayoutTestController::setXSSAuditorEnabled):
644         * DumpRenderTree/qt/LayoutTestControllerQt.h:
645
646 2010-01-09  Adam Barth  <abarth@webkit.org>
647
648         Reviewed by Eric Seidel.
649
650         Retry writes to QueueStatusServer when we get 500 errors
651         https://bugs.webkit.org/show_bug.cgi?id=33412
652
653         This prevents the queues from failing to mark a patch as "pass" or
654         "fail" when AppEngine throws 500 errors.
655
656         * Scripts/test-webkitpy:
657         * Scripts/webkitpy/networktransaction.py: Added.
658         * Scripts/webkitpy/networktransaction_unittest.py: Added.
659         * Scripts/webkitpy/statusserver.py:
660         * Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added.
661         * Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added.
662         * Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added.
663
664 2010-01-09  David Kilzer  <ddkilzer@apple.com>
665
666         <http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers
667
668         Reviewed by Eric Seidel.
669
670         * QueueStatusServer/templates/statusbubble.html: Added
671         -moz-border-radius and -webkit-border-radius to provide rounded
672         borders in older Firefox and Safari browsers.
673
674 2010-01-09  Chris Jerdonek  <chris.jerdonek@gmail.com>
675
676         Reviewed by David Kilzer.
677
678         Modified VCSUtils::gitdiff2svndiff() to accept strings that
679         end in vertical white space.
680
681         https://bugs.webkit.org/show_bug.cgi?id=33415
682
683         * Scripts/VCSUtils.pm:
684         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
685
686 2010-01-08  Eric Seidel  <eric@webkit.org>
687
688         Reviewed by Adam Barth.
689
690         run-javascriptcore-tests needs a --quiet flag
691         https://bugs.webkit.org/show_bug.cgi?id=33399
692
693         Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch.
694
695         * Scripts/webkitpy/steps/runtests.py:
696
697 2010-01-08  Andras Becsi  <abecsi@inf.u-szeged.hu>
698
699         Reviewed by Alexey Proskuryakov.
700
701         Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order.
702
703         To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize
704         the time when Apache and WebSocketServer is locked by tests.
705         Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing,
706         we need to run http and websocket tests after all other tests.
707         If one however explicitly specifies the tests to run in the argument list of run-webkit-tests
708         we need to preserve the given order.
709
710         * Scripts/run-webkit-tests:
711
712 2010-01-08  Adam Barth  <abarth@webkit.org>
713
714         Reviewed by Eric Seidel.
715
716         Don't post style-queue pass messages to bugs
717         https://bugs.webkit.org/show_bug.cgi?id=33404
718
719         These messages aren't needed any more now that we have the status
720         bubble reporting pass events passively.
721
722         * Scripts/webkitpy/commands/queues.py:
723
724 2010-01-08  Adam Barth  <abarth@webkit.org>
725
726         Reviewed by Eric Seidel.
727
728         Optimize the number of CPUs used for building Qt and Gtk
729         https://bugs.webkit.org/show_bug.cgi?id=33394
730
731         Instead of hardcoding the number 8, we should read the number of CPUs
732         from the environment.
733
734         * Scripts/webkitpy/executive.py:
735         * Scripts/webkitpy/webkitport.py:
736         * Scripts/webkitpy/webkitport_unittest.py:
737
738 2010-01-08  Chris Fleizach  <cfleizach@apple.com>
739
740         Reviewed by Eric Seidel.
741
742         REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
743         https://bugs.webkit.org/show_bug.cgi?id=33300
744
745         * DumpRenderTree/AccessibilityUIElement.h:
746         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
747         (AccessibilityUIElement::AccessibilityUIElement):
748         (AccessibilityUIElement::~AccessibilityUIElement):
749         (_accessibilityNotificationCallback):
750         (AccessibilityUIElement::addNotificationListener):
751
752 2010-01-08  Eric Seidel  <eric@webkit.org>
753
754         Reviewed by Simon Hausmann.
755
756         commit-queue should run run-javascriptcore-tests
757         https://bugs.webkit.org/show_bug.cgi?id=33376
758
759         I also made it run the python and perl unit tests.
760
761         * Scripts/webkitpy/steps/runtests.py:
762         * Scripts/webkitpy/webkitport.py:
763
764 2010-01-07  Andras Becsi  <abecsi@inf.u-szeged.hu>
765
766         Reviewed by Darin Adler.
767
768         Run the http and websocket tests after all other tests.
769         https://bugs.webkit.org/show_bug.cgi?id=33153
770
771         * Scripts/run-webkit-tests:
772
773 2010-01-07  Adam Barth  <abarth@webkit.org>
774
775         Reviewed by Eric Seidel.
776
777         Fix some test-webkitpy expectations
778         https://bugs.webkit.org/show_bug.cgi?id=33345
779
780         I forgot to change these when I added the CheckStyle step.
781
782         * Scripts/webkitpy/commands/upload_unittest.py:
783
784 2010-01-07  Adam Barth  <abarth@webkit.org>
785
786         Reviewed by Eric Seidel.
787
788         webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
789         https://bugs.webkit.org/show_bug.cgi?id=33341
790
791         Fix this by moving to the root directory before editing ChangeLogs.
792         There is a related bug with CheckStyle.
793
794         * Scripts/webkitpy/steps/checkstyle.py:
795         * Scripts/webkitpy/steps/editchangelog.py:
796
797 2010-01-07  Eric Seidel  <eric@webkit.org>
798
799         Reviewed by Nikolas Zimmermann.
800
801         media/unsupported-tracks.html is failing on Snow Leopard Release bot
802         https://bugs.webkit.org/show_bug.cgi?id=32339
803
804         This is a speculative fix.  I do not have a Snow Leopard machine to test on
805         and I've not seen mention of someone being able to reproduce this locally.
806
807         Prevent watchdog timer from firing after a test completes but before
808         the next one starts, causing the error to appear in the next test.
809
810         * DumpRenderTree/mac/DumpRenderTree.mm:
811         (dump): Stop the watchdog before printing #EOF for the test content.
812         We only need to care about the JavaScript of the test running too long
813         or some hang in WebCore.  Any other failures will be covered by the calling
814         script's own watchdog timer.
815
816 2010-01-07  Eric Seidel  <eric@webkit.org>
817
818         Reviewed by Adam Barth.
819
820         commit-queue is stuck spinning due to exception
821         https://bugs.webkit.org/show_bug.cgi?id=33358
822
823         * Scripts/webkitpy/commands/queues.py:
824          - Don't try to stringify the exception.
825
826 2010-01-07  Mark Rowe  <mrowe@apple.com>
827
828         Reviewed by Jon Honeycutt.
829
830         Don't leak a JSStringRef within _accessibilityNotificationCallback.
831
832         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
833         (_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up
834         when it goes out of scope.
835
836 2010-01-07  Simon Fraser  <simon.fraser@apple.com>
837
838         Reviewed by Darin Adler.
839
840         Add proposed rename of HTMLPlugInImageElement to HTMLEmbeddedObjectElement.
841
842         * Scripts/do-webcore-rename:
843
844 2010-01-07  Kim Grönholm  <kim.gronholm@nomovok.com>
845
846         Reviewed by Antti Koivisto.
847
848         Wrong state and TouchLists in TouchEvents
849         https://bugs.webkit.org/show_bug.cgi?id=32878
850
851         * DumpRenderTree/qt/EventSenderQt.cpp:
852         (EventSender::touchStart):
853         (EventSender::touchEnd):
854         (EventSender::clearTouchPoints):
855         * DumpRenderTree/qt/EventSenderQt.h:
856
857 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
858
859         Reviewed by Adam Barth.
860
861         Created a module that runs the style package unit tests.
862
863         https://bugs.webkit.org/show_bug.cgi?id=32973
864
865         * Scripts/test-webkitpy:
866         * Scripts/webkitpy/style/unittests.py: Added.
867
868 2010-01-07  Adam Barth  <abarth@webkit.org>
869
870         Reviewed by Maciej Stachowiak.
871
872         Don't print a redundant message when confirming a diff
873         https://bugs.webkit.org/show_bug.cgi?id=33315
874
875         Instead of saying "ERROR: User declined" we should just exit because
876         the use knows they just declined!
877
878         * Scripts/webkitpy/steps/confirmdiff.py:
879
880 2010-01-07  Adam Barth  <abarth@webkit.org>
881
882         Reviewed by Maciej Stachowiak.
883
884         Check style before uploading a patch
885         https://bugs.webkit.org/show_bug.cgi?id=33314
886
887         * Scripts/webkitpy/commands/upload.py:
888         * Scripts/webkitpy/steps/checkstyle.py:
889         * Scripts/webkitpy/steps/options.py:
890
891 2010-01-07  Adam Barth  <abarth@webkit.org>
892
893         Reviewed by Maciej Stachowiak.
894
895         Add prepare and post to webkit-patch main help
896         https://bugs.webkit.org/show_bug.cgi?id=33313
897
898         * Scripts/webkitpy/commands/upload.py:
899
900 2010-01-07  Eric Seidel  <eric@webkit.org>
901
902         Reviewed by Adam Barth.
903
904         Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
905         https://bugs.webkit.org/show_bug.cgi?id=33290
906
907         Add the Chromium builders to our list of core builders and test that our regexps work.
908         I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.
909
910         * Scripts/webkitpy/buildbot.py:
911         * Scripts/webkitpy/buildbot_unittest.py:
912
913 2010-01-07  Adam Barth  <abarth@webkit.org>
914
915         Reviewed by Eric Seidel.
916
917         bugzilla-tool needs a new name
918         https://bugs.webkit.org/show_bug.cgi?id=28459
919
920         Rename bugzilla-tool to webkit-patch.  Also, rename some commands to
921         make more sense with the new name.
922
923         * Scripts/bugzilla-tool: Removed.
924         * Scripts/webkit-patch: Added.
925         * Scripts/webkit-tools-completion.sh:
926         * Scripts/webkitpy/bugzilla_unittest.py:
927         * Scripts/webkitpy/commands/download.py:
928         * Scripts/webkitpy/commands/download_unittest.py:
929         * Scripts/webkitpy/commands/early_warning_system.py:
930         * Scripts/webkitpy/commands/queries.py:
931         * Scripts/webkitpy/commands/queues.py:
932         * Scripts/webkitpy/commands/queues_unittest.py:
933         * Scripts/webkitpy/commands/upload.py:
934         * Scripts/webkitpy/commands/upload_unittest.py:
935         * Scripts/webkitpy/queueengine.py:
936         * Scripts/webkitpy/steps/completerollout.py:
937
938 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
939
940         Reviewed by Eric Seidel.
941
942         Moved style-related modules to webkitpy.style sub-package.
943
944         https://bugs.webkit.org/show_bug.cgi?id=32971
945
946         * Scripts/check-webkit-style:
947           - Updated import statement.
948
949         * Scripts/test-webkitpy:
950           - Updated import statements.
951
952         * Scripts/webkitpy/cpp_style.py: Removed.
953           - Moved to webkitpy/style.
954
955         * Scripts/webkitpy/cpp_style_unittest.py: Removed.
956           - Moved to webkitpy/style.
957
958         * Scripts/webkitpy/style.py: Removed.
959           - Moved to webkitpy/style/checker.py.
960
961         * Scripts/webkitpy/style/__init__.py: Added.
962           - Added containing webkitpy directory to package search path.
963
964         * Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
965         * Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
966           - Updated import statement.
967
968         * Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
969         * Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
970           - Update import statement.
971
972         * Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
973         * Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
974         * Scripts/webkitpy/style_unittest.py: Removed.
975           - Moved to webkitpy/style/checker_unittest.py.
976
977         * Scripts/webkitpy/text_style.py: Removed.
978           - Moved to webkitpy/style.
979
980         * Scripts/webkitpy/text_style_unittest.py: Removed.
981           - Moved to webkitpy/style.
982
983 2010-01-06  Kinuko Yasuda  <kinuko@chromium.org>
984
985         Reviewed by Eric Seidel.
986
987         [Qt] Support the 3rd argument of EventSender.keyDown that
988         has been recently added to report keyLocation
989         (see also: https://bugs.webkit.org/show_bug.cgi?id=28247).
990         https://bugs.webkit.org/show_bug.cgi?id=33250
991
992         Test: fast/events/keydown-numpad-keys.html
993
994         * DumpRenderTree/qt/EventSenderQt.cpp:
995         (EventSender::keyDown):
996         * DumpRenderTree/qt/EventSenderQt.h:
997
998 2010-01-06  Eric Seidel  <eric@webkit.org>
999
1000         Reviewed by Adam Barth.
1001
1002         Add long_help for all common commands.
1003         https://bugs.webkit.org/show_bug.cgi?id=33261
1004
1005         For now these long_helps are pretty basic.
1006         These were all written to just explain the steps
1007         that each command runs.  This style long_help could
1008         be made easier by using:
1009         https://bugs.webkit.org/show_bug.cgi?id=33257
1010
1011         * Scripts/webkitpy/commands/download.py:
1012         * Scripts/webkitpy/commands/queries.py:
1013
1014 2010-01-06  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1015
1016         Reviewed by Kenneth Christiansen.
1017
1018         [Qt] Add page zooming support to Qt DumpRenderTree
1019         https://bugs.webkit.org/show_bug.cgi?id=32898
1020
1021         Patch by Kim Grönholm  <kim.gronholm@nomovok.com>,
1022                  Diego Gonzalez <diego.gonzalez@openbossa.org> and
1023                  Afonso Costa <afonso.costa@openbossa.org>
1024
1025         * DumpRenderTree/qt/EventSenderQt.cpp:
1026         (EventSender::zoomPageIn):
1027         (EventSender::zoomPageOut):
1028         * DumpRenderTree/qt/EventSenderQt.h:
1029
1030 2010-01-06  Eric Seidel  <eric@webkit.org>
1031
1032         No review, just adding Mike Belshe's new bugzilla email at his request.
1033
1034         * Scripts/webkitpy/committers.py:
1035
1036 2010-01-06  Eric Seidel  <eric@webkit.org>
1037
1038         Unreviewed.  Rolling out r52869 and r52853 due to bot
1039         and local run-webkit-test failures
1040
1041         REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
1042         https://bugs.webkit.org/show_bug.cgi?id=33256
1043
1044         The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153
1045
1046         * Scripts/run-webkit-tests:
1047
1048 2010-01-06  Eric Seidel  <eric@webkit.org>
1049
1050         Unreviewed "build" fix.  Just adding missing include.
1051
1052         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
1053         https://bugs.webkit.org/show_bug.cgi?id=29212
1054
1055         * Scripts/webkitpy/steps/completerollout.py:
1056
1057 2010-01-06  Eric Seidel  <eric@webkit.org>
1058
1059         Reviewed by Adam Barth.
1060
1061         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
1062         https://bugs.webkit.org/show_bug.cgi?id=29212
1063
1064         * Scripts/webkitpy/bugzilla.py:
1065          - Make reopen_bug robust against the bug already being open.
1066         * Scripts/webkitpy/commands/download.py:
1067          - Remove dead code from Rollout.
1068         * Scripts/webkitpy/steps/completerollout.py:
1069          - Improve the rollout comment.
1070
1071 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
1072
1073         Reviewed by Darin Adler.
1074
1075         Set isHttpdOpen to 0 if pidfile does not exist for some reason.
1076         Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256.
1077
1078         * Scripts/run-webkit-tests:
1079
1080 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
1081
1082         Reviewed by Darin Adler.
1083
1084         Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(),
1085         and remove the httpd's pidfile directory if httpd terminated.
1086
1087         * Scripts/run-webkit-tests:
1088
1089 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
1090
1091         Reviewed by David Levin.
1092
1093         Refactored check-webkit-style's argument parser to not rely
1094         on global state, and improved its error handling and unit
1095         test coverage.
1096
1097         https://bugs.webkit.org/show_bug.cgi?id=32966
1098
1099         * Scripts/check-webkit-style:
1100           - Adjusted to use new argument parser.
1101
1102         * Scripts/webkitpy/cpp_style.py:
1103           - Changed _CppStyleState to accept an array of filter rules
1104             instead of a comma-delimited string.
1105           - Eliminated cpp_style._DEFAULT_FILTER_RULES.
1106           - Eliminated cpp_style._USAGE.
1107
1108         * Scripts/webkitpy/cpp_style_unittest.py:
1109           - Updated test_filter() and test_default_filter().
1110
1111         * Scripts/webkitpy/style.py:
1112           - Converted style._USAGE to create_usage().
1113           - Corrected usage instructions by removing 0 as a valid
1114             --verbose flag value.
1115           - Removed use_webkit_styles().
1116           - Added ProcessorOptions class.
1117           - Added ArgumentDefaults class.
1118           - Added ArgumentPrinter class.
1119           - Removed parse_arguments and added ArgumentParser class.
1120           - Moved exit_with_usage() and exit_with_categories() into
1121             ArgumentParser.
1122           - Refactored parse_arguments() as ArgumentParser.parse().
1123           - Improved parser error handling.
1124
1125         * Scripts/webkitpy/style_unittest.py:
1126           - Added DefaultArgumentsTest class.
1127           - Addressed FIXME to check style.WEBKIT_FILTER_RULES
1128             against style.STYLE_CATEGORIES.
1129           - Added ArgumentPrinterTest class.
1130           - Added ArgumentParserTest class and rewrote parser unit tests.
1131
1132 2010-01-05  Adam Roben  <aroben@apple.com>
1133
1134         Test that it's safe to call IWebView::close when
1135         IWebView::initWithFrame hasn't been called
1136
1137         Part of <http://webkit.org/b/32827> Crash when calling
1138         IWebView::close, then releasing the WebView, without calling
1139         DestroyWindow
1140
1141         Reviewed by Steve Falkenburg.
1142
1143         * WebKitAPITest/tests/WebViewDestruction.cpp:
1144         (WebKitAPITest::CloseWithoutInitWithFrame): Calls IWebView::close
1145         without ever calling IWebView::initWithFrame and tests that we don't
1146         crash or leak.
1147
1148 2010-01-05  Adam Roben  <aroben@apple.com>
1149
1150         Add more WebViewDestruction tests
1151
1152         Fixes <http://webkit.org/b/33216>.
1153
1154         Reviewed by Eric Seidel.
1155
1156         * WebKitAPITest/tests/WebViewDestruction.cpp:
1157         (WebKitAPITest::NoInitWithFrame):
1158         (WebKitAPITest::CloseThenDestroyViewWindow):
1159         (WebKitAPITest::DestroyViewWindowThenClose):
1160         (WebKitAPITest::DestroyHostWindow):
1161         (WebKitAPITest::DestroyHostWindowThenClose):
1162         (WebKitAPITest::CloseThenDestroyHostWindow):
1163         Added these tests that exercise tearing down a WebView in various
1164         ways, all of which we eventually want to have work. Some of them
1165         currently crash or leak.
1166
1167 2010-01-05  Robert Hogan  <robert@roberthogan.net>
1168
1169         Reviewed by Eric Seidel.
1170
1171         [Qt] fix DRT link failures on --no-svg builds when only making changes to DRT
1172         
1173         If you're working from a --minimal or --no-svg build and make changes to the
1174         DRT, then recompile, the build will fail.
1175         
1176         This is because the current behavior at build time is to assume that the
1177         previous Qt build supported SVG and consequently delete libQtWebKit.so.
1178         Unfortunately, just deleting libQtWebKit.so will not cause the library to
1179         re-link. Instead the build will see libQtWebKit.so.4 and co., pass over the
1180         linking phase, and attempt to link the DRT with libQtWebKit.so absent. This
1181         results in a link failure on the DRT.
1182         
1183         Since re-linking libQtWebKit can take up to ten minutes and should be avoided
1184         in cases where not actually required, remove the assumption that
1185         the previous Qt build supported SVG, and amend the symbol detection to look for
1186         a symbol name that is not present in SVG builds. Currently webkitdirs.pm looks
1187         for 'SVGElement' but even non-SVG builds contain the symbol 'isSVGElement'.
1188         
1189         https://bugs.webkit.org/show_bug.cgi?id=32992
1190
1191         * Scripts/webkitdirs.pm:
1192
1193 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
1194
1195         Reviewed by David Kilzer.
1196
1197         Switched to generating list of Perl unit test files dynamically,
1198         instead of explicitly.
1199
1200         https://bugs.webkit.org/show_bug.cgi?id=33200
1201
1202         * Scripts/test-webkitperl:
1203
1204 2010-01-05  Yael Aharon  <yael.aharon@nokia.com>
1205
1206         Reviewed by Kenneth Rohde Christiansen.
1207
1208         [Qt] Reimplement EventSender::leapForward
1209         https://bugs.webkit.org/show_bug.cgi?id=33114
1210
1211         Follow Windows implementation of leapForward. When leapForward is called, 
1212         messages are queued and posted after the timeout. A new event loop is created to
1213         handle those messages and the additional messages that are created as a result.
1214
1215         * DumpRenderTree/qt/DumpRenderTree.pro:
1216         * DumpRenderTree/qt/EventSenderQt.cpp:
1217         (EventSender::EventSender):
1218         (EventSender::mouseDown):
1219         (EventSender::mouseUp):
1220         (EventSender::mouseMoveTo):
1221         (EventSender::leapForward):
1222         (EventSender::sendOrQueueEvent):
1223         (EventSender::replaySavedEvents):
1224         (EventSender::eventFilter):
1225         * DumpRenderTree/qt/EventSenderQt.h:
1226
1227 2010-01-05  Adam Barth  <abarth@webkit.org>
1228
1229         Reviewed by Darin Adler.
1230
1231         Fix obscure queue crash in queueengine
1232         https://bugs.webkit.org/show_bug.cgi?id=33196
1233
1234         Sometimes we get an exception that can't be stringified.  For example:
1235
1236         AttributeError: 'ParseError' object has no attribute 'msg'
1237
1238         In these cases, the whole queue dies because we're in the global
1239         exception handler.  Instead of dieing here, we should just print a less
1240         informative message to the console.  We're already printing the whole
1241         backtrace anyway, so there's not much point to stringifying the
1242         exception anyway.
1243
1244         * Scripts/webkitpy/queueengine.py:
1245
1246 2010-01-05  Dominic Mazzoni  <dmazzoni@google.com>
1247
1248         Reviewed by Darin Adler.
1249
1250         https://bugs.webkit.org/show_bug.cgi?id=32571
1251
1252         For an object with an aria role of "checkbox" or "radiobutton",
1253         use the "aria-checked" attribute to determine if it's checked.
1254         These changes add an isChecked() method to AccessibilityUIElement
1255         so that we can check for this property from a layout test.
1256
1257         * DumpRenderTree/AccessibilityUIElement.cpp:
1258         (getIsCheckedCallback):
1259         (AccessibilityUIElement::getJSClass):
1260         * DumpRenderTree/AccessibilityUIElement.h:
1261         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1262         (AccessibilityUIElement::isChecked):
1263         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1264         (AccessibilityUIElement::isChecked):
1265         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1266         (AccessibilityUIElement::isChecked):
1267
1268 2010-01-05  David Levin  <levin@chromium.org>
1269
1270         Reviewed by Darin Adler.
1271
1272         Having a comment for the #endif for a header guard is not required WebKit style.
1273         https://bugs.webkit.org/show_bug.cgi?id=33214
1274
1275         * Scripts/webkitpy/cpp_style.py: removed the check and made the loop exit
1276           early when it has all the needed information to continue.
1277         * Scripts/webkitpy/cpp_style_unittest.py: removed the corresponding tests.
1278
1279 2010-01-05  Adam Roben  <aroben@apple.com>
1280
1281         Share more code in the WebViewDestruction tests
1282
1283         Part of <http://webkit.org/b/33212> Small fixes/improvements to
1284         WebKitAPITest
1285
1286         Reviewed by Sam Weinig.
1287
1288         * WebKitAPITest/tests/WebViewDestruction.cpp:
1289         (WebKitAPITest::createAndInitializeWebView): Renamed from
1290         createWebView. Now initializes the HostWindow and returns the
1291         WebView's HWND via an out-parameter.
1292         (WebKitAPITest::finishWebViewDestructionTest): Added. Code came from
1293         the CloseWithoutDestroyWindow test.
1294         (WebKitAPITest::CloseWithoutDestroyViewWindow): Renamed from
1295         CloseWithoutDestroyWindow and changed to use the new functions.
1296         (WebKitAPITest::MainFrameAfterClose): Changed to use the new
1297         functions.
1298         (WebKitAPITest::NoCloseOrDestroyViewWindow): Renamed from
1299         NoCloseOrDestroyWindow and changed to use the new functions.
1300
1301 2010-01-05  Adam Roben  <aroben@apple.com>
1302
1303         Don't show HostWindows by default
1304
1305         This was making WebKitAPITest very flashy as windows appeared and
1306         disappeared.
1307
1308         Part of <http://webkit.org/b/33212> Small fixes/improvements to
1309         WebKitAPITest
1310
1311         Reviewed by Sam Weinig.
1312
1313         * WebKitAPITest/HostWindow.cpp:
1314         (WebKitAPITest::HostWindow::initialize): Removed the WS_VISIBLE style
1315         from the window.
1316
1317 2010-01-05  Adam Roben  <aroben@apple.com>
1318
1319         Don't hang in WebKitAPITest if no messages have been posted
1320
1321         Part of <http://webkit.org/b/33212> Small fixes/improvements to
1322         WebKitAPITest
1323
1324         Reviewed by Sam Weinig.
1325
1326         * WebKitAPITest/tests/WebViewDestruction.cpp:
1327         (WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage
1328         to avoid hanging if no messages have been posted.
1329
1330 2010-01-05  Adam Roben  <aroben@apple.com>
1331
1332         Fix WebKitCreateInstance helper
1333
1334         Part of <http://webkit.org/b/33212> Small fixes/improvements to
1335         WebKitAPITest
1336
1337         Reviewed by Sam Weinig.
1338
1339         * WebKitAPITest/tests/WebViewDestruction.cpp:
1340         (WebKitAPITest::WebKitCreateInstance): Pass the pointer straight
1341         through, instead of taking its address.
1342
1343 2010-01-04  Maciej Stachowiak  <mjs@apple.com>
1344
1345         Reviewed by Darin Fisher.
1346
1347         Reorganize, document and rename OS() platform macros.
1348         https://bugs.webkit.org/show_bug.cgi?id=33198
1349
1350         Adapt to name changes.
1351         
1352         * DumpRenderTree/DumpRenderTree.h:
1353         * DumpRenderTree/config.h:
1354
1355 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
1356
1357         Reviewed by Eric Seidel.
1358
1359         Minor improvements to test-webkit-scripts, as suggested
1360         by an earlier review.
1361
1362         https://bugs.webkit.org/show_bug.cgi?id=33125
1363
1364         * Scripts/test-webkit-scripts:
1365           - Used OptionParser class instead of getopt.getopt().
1366           - Created main() method for __main__ block.
1367           - Enclosed functions in a class.
1368
1369 2010-01-05  Chris Fleizach  <cfleizach@apple.com>
1370
1371         No review. Fix DRT breakage on Tiger/Leopard.
1372
1373         Add ARIA "Live Region" support
1374         https://bugs.webkit.org/show_bug.cgi?id=33117
1375
1376         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1377
1378 2010-01-04  Chris Fleizach  <cfleizach@apple.com>
1379
1380         Reviewed by Darin Adler.
1381
1382         Add ARIA "Live Region" support
1383         https://bugs.webkit.org/show_bug.cgi?id=33117
1384
1385         * DumpRenderTree/AccessibilityUIElement.cpp:
1386         (indexOfChildCallback):
1387         (boolAttributeValueCallback):
1388         (stringAttributeValueCallback):
1389         (addNotificationListenerCallback):
1390         (AccessibilityUIElement::getJSClass):
1391         * DumpRenderTree/AccessibilityUIElement.h:
1392         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1393         (AccessibilityUIElement::indexOfChild):
1394         (AccessibilityUIElement::stringAttributeValue):
1395         (AccessibilityUIElement::boolAttributeValue):
1396         (AccessibilityUIElement::addNotificationListener):
1397         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1398         (AccessibilityUIElement::indexOfChild):
1399         (AccessibilityUIElement::stringAttributeValue):
1400         (AccessibilityUIElement::boolAttributeValue):
1401         (_accessibilityNotificationCallback):
1402         (AccessibilityUIElement::addNotificationListener):
1403         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1404         (AccessibilityUIElement::indexOfChild):
1405         (AccessibilityUIElement::stringAttributeValue):
1406         (AccessibilityUIElement::boolAttributeValue):
1407         (AccessibilityUIElement::addNotificationListener):
1408
1409 2010-01-04  Eric Seidel  <eric@webkit.org>
1410
1411         Reviewed by Adam Barth.
1412
1413         bugzilla-tool rollout should require a reason
1414         https://bugs.webkit.org/show_bug.cgi?id=30810
1415
1416         * Scripts/webkitpy/changelogs.py: Add support for a reason, add auto-wrapping logic.
1417         * Scripts/webkitpy/changelogs_unittest.py: Test reason support.
1418         * Scripts/webkitpy/commands/download.py: rollout now requires a reason, remove unused BUGID argument
1419         * Scripts/webkitpy/commands/download_unittest.py: pass required reason
1420         * Scripts/webkitpy/steps/preparechangelogforrevert.py: pass reason to update_for_revert
1421
1422 2010-01-04  Jon Honeycutt  <jhoneycutt@apple.com>
1423
1424         MSAA: <select> elements should broadcast value change events
1425
1426         https://bugs.webkit.org/show_bug.cgi?id=33088
1427
1428         <rdar://problem/7332364>
1429
1430         Reviewed by Darin Adler.
1431
1432         * DumpRenderTree/AccessibilityController.cpp:
1433         (logValueChangeEventsCallback):
1434         Start logging value change events.
1435         (AccessibilityController::getJSClass):
1436         Add a "logValueChangeEvents" to the AccessibilityController's JS class
1437         definition.
1438         (AccessibilityController::resetToConsistentState):
1439         Disable logging of value change events.
1440
1441         * DumpRenderTree/AccessibilityController.h:
1442         Declare setLogValueChangeEvents(), and add a member variable for the
1443         value change event hook.
1444
1445         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1446         (AccessibilityController::setLogValueChangeEvents):
1447         Stubbed.
1448
1449         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1450         (AccessibilityController::setLogValueChangeEvents):
1451         Stubbed.
1452
1453         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1454         (AccessibilityController::AccessibilityController):
1455         Initialize new member var.
1456         (AccessibilityController::~AccessibilityController):
1457         Disable logging of value change events.
1458         (logEventProc):
1459         When we receive an EVENT_OBJECT_VALUECHANGE, log the name of the object
1460         and its value.
1461         (AccessibilityController::setLogValueChangeEvents):
1462         If disabling logging, unhook the event, and clear the event hook
1463         member var. Otherwise, query for the root element to enable
1464         accessibility, and hook EVENT_OBJECT_VALUECHANGE.
1465
1466 2010-01-04  Adam Barth  <abarth@webkit.org>
1467
1468         Reviewed by Eric Seidel.
1469
1470         long_help for submit-patch
1471         https://bugs.webkit.org/show_bug.cgi?id=33184
1472
1473         * Scripts/webkitpy/commands/upload.py:
1474
1475 2010-01-04  Adam Barth  <abarth@webkit.org>
1476
1477         Reviewed by Eric Seidel.
1478
1479         commit-queue can wrongly reject patches if the buildbots are behind
1480         https://bugs.webkit.org/show_bug.cgi?id=30098
1481
1482         Check to make sure we can currently build and test before trying to
1483         land a patch.
1484
1485         * Scripts/webkitpy/commands/queues.py:
1486
1487 2010-01-04  Adam Roben  <aroben@apple.com>
1488
1489         Add a test harness for the Windows WebKit API, and a few tests
1490
1491         We currently only have tests for a handful of bugs regarding WebView
1492         destruction, but more tests can easily be added later. Eventually
1493         we'll run these tests as part of run-webkit-tests.
1494
1495         Fixes <http://webkit.org/b/33167>.
1496
1497         Reviewed by Sam Weinig.
1498
1499         * WebKitAPITest/HostWindow.cpp: Added.
1500         (WebKitAPITest::HostWindow::HostWindow): Initialize m_window.
1501         (WebKitAPITest::HostWindow::~HostWindow): Destroy our window if
1502         needed.
1503         (WebKitAPITest::HostWindow::initialize): Create our window.
1504         (WebKitAPITest::HostWindow::clientRect): Return our window's client
1505         rect.
1506         (WebKitAPITest::HostWindow::registerWindowClass): Does what it says.
1507         (WebKitAPITest::HostWindow::wndProc): Just call through to
1508         DefWindowProcW.
1509
1510         * WebKitAPITest/HostWindow.h: Added.
1511         (WebKitAPITest::HostWindow::window): Simple getter.
1512
1513         * WebKitAPITest/Test.h: Added. This file defines some macros useful
1514         for writing tests.
1515
1516         * WebKitAPITest/TestsController.cpp: Added.
1517         (WebKitAPITest::TestsController::TestsController): Initialize our
1518         members.
1519         (WebKitAPITest::TestsController::shared): Return the shared instance.
1520         (WebKitAPITest::TestsController::runAllTests): Run a message pump
1521         until a WM_QUIT message is received, then return whether all tests
1522         succeeded.
1523         (WebKitAPITest::TestsController::addTest): Add the test to m_tests and
1524         start running tests soon.
1525         (WebKitAPITest::TestsController::testFailed): Record the failure and
1526         print a message about it to stdout.
1527         (WebKitAPITest::TestsController::runNextTest): If we don't have any
1528         tests to run, post a WM_QUIT message to stop the message pump.
1529         Otherwise, run the test and print whether it passed, then schedule the
1530         next test.
1531         (WebKitAPITest::TestsController::runNextTestSoon): Set a 0-delay timer
1532         to run the next test.
1533         (WebKitAPITest::TestsController::registerWindowClass): Does what it
1534         says.
1535         (WebKitAPITest::TestsController::wndProc): If the runNextTestTimer
1536         fired, call runNextTest(). Pass everything else through to
1537         DefWindowProcW.
1538
1539         * WebKitAPITest/TestsController.h: Added.
1540
1541         * WebKitAPITest/WebKitAPITest.vcproj: Added.
1542
1543         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added.
1544
1545         * WebKitAPITest/main.cpp: Added.
1546         (main): (Mostly) just calls TestsController::runAllTests.
1547
1548         * WebKitAPITest/tests/WebViewDestruction.cpp: Added.
1549         (WebKitAPITest::WebKitCreateInstance): Helper function template to
1550         call through to the real WebKitCreateInstance.
1551         (WebKitAPITest::webViewCount): Helper function to call through to
1552         IWebKitStatistics::webViewCount.
1553         (WebKitAPITest::createWebView): Helper function to create a WebView
1554         and put it inside a HostWindow.
1555         (WebKitAPITest::runMessagePump): Helper function to run a message pump
1556         for a specified number of milliseconds, or until a WM_QUIT message is
1557         received.
1558         (WebKitAPITest::CloseWithoutDestroyWindow): Test for
1559         <http://webkit.org/b/32827>.
1560         (WebKitAPITest::MainFrameAfterClose): Test for
1561         <http://webkit.org/b/32868>.
1562         (WebKitAPITest::NoCloseOrDestroyWindow): Test for
1563         <http://webkit.org/b/33162>.
1564
1565 2010-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1566
1567         Reviewed by David Kilzer.
1568
1569         Add support for Git's "diff.mnemonicprefix" config option to WebKitTools
1570
1571         https://bugs.webkit.org/show_bug.cgi?id=32820
1572
1573         * Scripts/VCSUtils.pm:
1574         * Scripts/svn-apply:
1575         * Scripts/svn-unapply:
1576         * Scripts/test-webkitperl: Run gitdiff2svndiff test
1577         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Added.
1578         * Scripts/webkitpy/diff_parser.py:
1579         * Scripts/webkitpy/diff_parser_unittest.py:
1580
1581 2010-01-04  Chris Jerdonek  <chris.jerdonek@gmail.com>
1582
1583         Reviewed by David Kilzer.
1584
1585         Divided the Perl unit tests into separate files and put
1586         them in a separate directory, and renamed test-webkit-perl
1587         to test-webkitperl.
1588
1589         https://bugs.webkit.org/show_bug.cgi?id=33124
1590
1591         * Scripts/VCSUtils.pm:
1592           - Renamed generateRunPatchCommand() to generatePatchCommand().
1593
1594         * Scripts/VCSUtils_unittest.pl: Removed.
1595           - Divided into three files in Scripts/webkitperl/VCSUtils_unittest.
1596
1597         * Scripts/test-webkit-perl: Removed.
1598           - Renamed to test-webkitperl.
1599
1600         * Scripts/test-webkit-scripts:
1601           - Updated paths to test-webkitpy and test-webkitperl.
1602
1603         * Scripts/test-webkitperl: Copied from Scripts/test-webkit-perl.
1604           - Added paths to new test files.
1605
1606         * Scripts/webkitperl: Added.
1607         * Scripts/webkitperl/VCSUtils_unittest: Added.
1608         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added.
1609         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl: Added.
1610         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Copied from Scripts/VCSUtils_unittest.pl.
1611
1612 2010-01-04  Eric Seidel  <eric@webkit.org>
1613
1614         Reviewed by Adam Barth.
1615
1616         Make bugzilla-tool rollout include a bug link in the ChangeLog entry
1617         https://bugs.webkit.org/show_bug.cgi?id=33146
1618
1619         One more step towards better rollouts.
1620
1621         * Scripts/webkitpy/changelogs.py:
1622         * Scripts/webkitpy/changelogs_unittest.py:
1623         * Scripts/webkitpy/steps/preparechangelogforrevert.py:
1624
1625 2010-01-04  Adam Barth  <abarth@webkit.org>
1626
1627         Reviewed by Eric Seidel.
1628
1629         Sort the step options
1630         https://bugs.webkit.org/show_bug.cgi?id=33144
1631
1632         * Scripts/webkitpy/steps/options.py:
1633
1634 2010-01-04  Eric Seidel  <eric@webkit.org>
1635
1636         Reviewed by Adam Barth.
1637
1638         Need support for longer text in per-command help
1639         https://bugs.webkit.org/show_bug.cgi?id=33143
1640
1641         Add some minimal additional help to land-diff and
1642         pave the way for adding better help to all commands.
1643
1644         * Scripts/webkitpy/commands/download.py: Add small amount of additional help to land-diff
1645         * Scripts/webkitpy/multicommandtool.py: support long_help
1646         * Scripts/webkitpy/multicommandtool_unittest.py: test long_help
1647
1648 2010-01-04  Adam Barth  <abarth@webkit.org>
1649
1650         Reviewed by Eric Seidel.
1651
1652         Add unit test for MarkBugFixed
1653         https://bugs.webkit.org/show_bug.cgi?id=33142
1654
1655         MarkBugFixed is way behind in command technology, but it still needs a
1656         unit test, as the FIXME commands.
1657
1658         Also, remove mark-bug-fixed and create-bug from main help since we have
1659         more modern commands to replace them.
1660
1661         * Scripts/webkitpy/commands/upload.py:
1662         * Scripts/webkitpy/commands/upload_unittest.py:
1663         * Scripts/webkitpy/mock_bugzillatool.py:
1664
1665 2010-01-04  Adam Barth  <abarth@webkit.org>
1666
1667         Reviewed by Eric Seidel.
1668
1669         Add missing unit test for CommitMessageForCurrentDiff
1670         https://bugs.webkit.org/show_bug.cgi?id=33141
1671
1672         * Scripts/webkitpy/commands/upload.py:
1673         * Scripts/webkitpy/commands/upload_unittest.py:
1674
1675 2010-01-04  Adam Barth  <abarth@webkit.org>
1676
1677         Reviewed by Eric Seidel.
1678
1679         Remove raw_input from queues in favor of user.prompt
1680         https://bugs.webkit.org/show_bug.cgi?id=33140
1681
1682         This lets up properly mock out the user interaction instead of hacking
1683         around it with the options.
1684
1685         * Scripts/webkitpy/commands/queues.py:
1686         * Scripts/webkitpy/commands/queuestest.py:
1687
1688 2010-01-04  Eric Seidel  <eric@webkit.org>
1689
1690         Reviewed by Adam Barth.
1691
1692         bugzilla-tool should not require users to install mechanize
1693         https://bugs.webkit.org/show_bug.cgi?id=32635
1694
1695         * Scripts/webkitpy/__init__.py: Add missing declaration for ClientForm (which mechanize requires).
1696
1697 2010-01-04  Eric Seidel  <eric@webkit.org>
1698
1699         Reviewed by Adam Barth.
1700
1701         bugzilla-tool should not require users to install mechanize
1702         https://bugs.webkit.org/show_bug.cgi?id=32635
1703
1704         Use the nifty "autoinstall" module from Daniel Krech:
1705         http://pypi.python.org/pypi/autoinstall/0.2
1706         http://code.google.com/p/pyautoinstall/
1707         It's available under a WebKit-compatible BSD license.
1708
1709         * Scripts/webkitpy/__init__.py:
1710          - bind "mechanize" to an autoinstall importer which will
1711            auto-download mechanize if necessary.
1712         * Scripts/webkitpy/autoinstall.py: Added.
1713         * Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize
1714         * Scripts/webkitpy/statusbot.py: ditto.
1715         * Scripts/webkitpy/webkit_mechanize.py: Removed.
1716
1717 2010-01-04  Adam Barth  <abarth@webkit.org>
1718
1719         Reviewed by Eric Seidel.
1720
1721         [bzt] Move AbstractSequencedCommand to a more general location
1722         https://bugs.webkit.org/show_bug.cgi?id=33137
1723
1724         I do what the FIXME tell me to do.
1725
1726         * Scripts/webkitpy/commands/abstractsequencedcommand.py: Added.
1727         * Scripts/webkitpy/commands/download.py:
1728         * Scripts/webkitpy/commands/upload.py:
1729
1730 2010-01-04  Adam Barth  <abarth@webkit.org>
1731
1732         Reviewed by Eric Seidel.
1733
1734         Rename StatusBot to StatusServer
1735         https://bugs.webkit.org/show_bug.cgi?id=33139
1736
1737         It's not a bot.  It's a server.
1738
1739         * Scripts/bugzilla-tool:
1740         * Scripts/webkitpy/bugzilla.py:
1741         * Scripts/webkitpy/commands/early_warning_system.py:
1742         * Scripts/webkitpy/commands/queues.py:
1743         * Scripts/webkitpy/mock_bugzillatool.py:
1744         * Scripts/webkitpy/queueengine.py:
1745         * Scripts/webkitpy/statusbot.py: Removed.
1746
1747 2010-01-04  Adam Barth  <abarth@webkit.org>
1748
1749         Reviewed by Eric Seidel.
1750
1751         [bzt] submit-pach should have a -o/--open option to open the bug after submit
1752         https://bugs.webkit.org/show_bug.cgi?id=33136
1753
1754         Python makes this very easy.
1755
1756         * Scripts/webkitpy/mock_bugzillatool.py:
1757         * Scripts/webkitpy/steps/options.py:
1758         * Scripts/webkitpy/steps/postdiff.py:
1759         * Scripts/webkitpy/user.py:
1760
1761 2010-01-04  Adam Barth  <abarth@webkit.org>
1762
1763         Reviewed by Eric Seidel.
1764
1765         [bzt] Move steps to a submodule
1766         https://bugs.webkit.org/show_bug.cgi?id=33135
1767
1768         For great victory.  This will probably introduce some regressions
1769         because our test coverage isn't perfect, but I've tried to be careful.
1770
1771         * Scripts/test-webkitpy:
1772         * Scripts/webkitpy/buildsteps.py: Removed.
1773         * Scripts/webkitpy/buildsteps_unittest.py: Removed.
1774         * Scripts/webkitpy/commands/download.py:
1775         * Scripts/webkitpy/commands/upload.py:
1776         * Scripts/webkitpy/steps/__init__.py: Added.
1777         * Scripts/webkitpy/steps/abstractstep.py: Added.
1778         * Scripts/webkitpy/steps/applypatch.py: Added.
1779         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Added.
1780         * Scripts/webkitpy/steps/build.py: Added.
1781         * Scripts/webkitpy/steps/checkstyle.py: Added.
1782         * Scripts/webkitpy/steps/cleanworkingdirectory.py: Added.
1783         * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Added.
1784         * Scripts/webkitpy/steps/closebug.py: Added.
1785         * Scripts/webkitpy/steps/closebugforlanddiff.py: Added.
1786         * Scripts/webkitpy/steps/closepatch.py: Added.
1787         * Scripts/webkitpy/steps/commit.py: Added.
1788         * Scripts/webkitpy/steps/completerollout.py: Added.
1789         * Scripts/webkitpy/steps/confirmdiff.py: Added.
1790         * Scripts/webkitpy/steps/createbug.py: Added.
1791         * Scripts/webkitpy/steps/editchangelog.py: Added.
1792         * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Added.
1793         * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Added.
1794         * Scripts/webkitpy/steps/metastep.py: Added.
1795         * Scripts/webkitpy/steps/obsoletepatches.py: Added.
1796         * Scripts/webkitpy/steps/options.py: Added.
1797         * Scripts/webkitpy/steps/postdiff.py: Added.
1798         * Scripts/webkitpy/steps/preparechangelog.py: Added.
1799         * Scripts/webkitpy/steps/preparechangelogforrevert.py: Added.
1800         * Scripts/webkitpy/steps/promptforbugortitle.py: Added.
1801         * Scripts/webkitpy/steps/revertrevision.py: Added.
1802         * Scripts/webkitpy/steps/runtests.py: Added.
1803         * Scripts/webkitpy/steps/steps_unittest.py: Added.
1804         * Scripts/webkitpy/steps/update.py: Added.
1805         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Added.
1806         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Added.
1807         * Scripts/webkitpy/stepsequence.py:
1808
1809 2010-01-04  Daniel Bates  <dbates@webkit.org>
1810
1811         Reviewed by Eric Seidel.
1812
1813         https://bugs.webkit.org/show_bug.cgi?id=33097
1814
1815         Cleans up the File menu to better conform to the File menu in Safari
1816         both in terms of options and keyboard shortcuts. Adds a "Quit" menu
1817         options to close all open windows. Also, renames the Tools menu to
1818         Develop.
1819
1820         * QtLauncher/main.cpp:
1821         (MainWindow::setupUI):
1822
1823 2010-01-04  Daniel Bates  <dbates@webkit.org>
1824
1825         https://bugs.webkit.org/show_bug.cgi?id=33039
1826         
1827         Unreviewed fix.
1828
1829         * Scripts/webkitpy/credentials.py:
1830         * Scripts/webkitpy/credentials_unittest.py:
1831
1832 2010-01-04  Daniel Bates  <dbates@webkit.org>
1833
1834         Reviewed by Eric Seidel.
1835
1836         https://bugs.webkit.org/show_bug.cgi?id=33039
1837
1838         [bzt] Second attempt to fix an issue where bugzilla-tool dies
1839         when the keychain lookup fails to find an entry for bugs.webkit.org.
1840
1841         * Scripts/webkitpy/credentials.py:
1842         * Scripts/webkitpy/credentials_unittest.py:
1843
1844 2010-01-04  Eric Seidel  <eric@webkit.org>
1845
1846         Reviewed by Adam Barth.
1847
1848         Make Rollout an AbstractSequencedCommmand
1849         https://bugs.webkit.org/show_bug.cgi?id=33133
1850
1851         As suggested by Adam in:
1852         https://bugs.webkit.org/show_bug.cgi?id=33131#c2
1853
1854         * Scripts/webkitpy/commands/download.py:
1855
1856 2010-01-04  Eric Seidel  <eric@webkit.org>
1857
1858         Reviewed by Adam Barth.
1859
1860         Make all commands AbstractDeclarativeCommmands instead of direct Command subclasses
1861         https://bugs.webkit.org/show_bug.cgi?id=33131
1862
1863         Evenetually we'll probably roll AbstractDeclarativeCommmand directly into Command
1864         but for now we just deploy it everywhere and don't try to fix up the few valid uses
1865         of Command.
1866
1867         * Scripts/webkitpy/commands/download.py:
1868         * Scripts/webkitpy/commands/queries.py:
1869         * Scripts/webkitpy/commands/upload.py:
1870         * Scripts/webkitpy/multicommandtool.py:
1871
1872 2010-01-03  Adam Barth  <abarth@webkit.org>
1873
1874         Unreviewed "build" fix.  Need to import ScriptError.
1875
1876         * Scripts/webkitpy/buildsteps.py:
1877
1878 2010-01-03  Adam Barth  <abarth@webkit.org>
1879
1880         Reviewed by Eric Seidel.
1881
1882         [bzt] Make it easier to run submit-patch when previous run cancelled
1883         https://bugs.webkit.org/show_bug.cgi?id=33070
1884
1885         This patch renames create-review to submit-patch (as requested by
1886         Maciej).
1887
1888         This patch makes it easier to run submit-patch after the user has
1889         already cancelled a previous run of submit-patch by detecting when we
1890         already have ChangeLogs and reading the bug number from them (and not
1891         attempting to recreate them).  Aside from performance and the extra
1892         edit step, this command should not subsume post-dif.
1893
1894         Also, added a --email command line argument so that the output of
1895         prepare-ChangeLog makes sense when it can't find the user's email
1896         address.
1897
1898         * Scripts/webkitpy/bugzilla.py:
1899         * Scripts/webkitpy/buildsteps.py:
1900         * Scripts/webkitpy/commands/upload.py:
1901         * Scripts/webkitpy/commands/upload_unittest.py:
1902         * Scripts/webkitpy/mock_bugzillatool.py:
1903         * Scripts/webkitpy/user.py:
1904
1905 2010-01-03  Eric Seidel  <eric@webkit.org>
1906
1907         Reviewed by Adam Barth.
1908
1909         Rename Scripts/modules to Scripts/webkitpy
1910         https://bugs.webkit.org/show_bug.cgi?id=33128
1911
1912         Just search-replace and svn mv commands.
1913
1914         * Scripts/bugzilla-tool:
1915         * Scripts/check-webkit-style:
1916         * Scripts/modules: Removed.
1917         * Scripts/modules/BeautifulSoup.py: Removed.
1918         * Scripts/modules/__init__.py: Removed.
1919         * Scripts/modules/bugzilla.py: Removed.
1920         * Scripts/modules/bugzilla_unittest.py: Removed.
1921         * Scripts/modules/buildbot.py: Removed.
1922         * Scripts/modules/buildbot_unittest.py: Removed.
1923         * Scripts/modules/buildsteps.py: Removed.
1924         * Scripts/modules/buildsteps_unittest.py: Removed.
1925         * Scripts/modules/changelogs.py: Removed.
1926         * Scripts/modules/changelogs_unittest.py: Removed.
1927         * Scripts/modules/commands: Removed.
1928         * Scripts/modules/commands/__init__.py: Removed.
1929         * Scripts/modules/commands/commandtest.py: Removed.
1930         * Scripts/modules/commands/download.py: Removed.
1931         * Scripts/modules/commands/download_unittest.py: Removed.
1932         * Scripts/modules/commands/early_warning_system.py: Removed.
1933         * Scripts/modules/commands/early_warning_system_unittest.py: Removed.
1934         * Scripts/modules/commands/queries.py: Removed.
1935         * Scripts/modules/commands/queries_unittest.py: Removed.
1936         * Scripts/modules/commands/queues.py: Removed.
1937         * Scripts/modules/commands/queues_unittest.py: Removed.
1938         * Scripts/modules/commands/queuestest.py: Removed.
1939         * Scripts/modules/commands/upload.py: Removed.
1940         * Scripts/modules/commands/upload_unittest.py: Removed.
1941         * Scripts/modules/comments.py: Removed.
1942         * Scripts/modules/committers.py: Removed.
1943         * Scripts/modules/committers_unittest.py: Removed.
1944         * Scripts/modules/cpp_style.py: Removed.
1945         * Scripts/modules/cpp_style_unittest.py: Removed.
1946         * Scripts/modules/credentials.py: Removed.
1947         * Scripts/modules/credentials_unittest.py: Removed.
1948         * Scripts/modules/diff_parser.py: Removed.
1949         * Scripts/modules/diff_parser_unittest.py: Removed.
1950         * Scripts/modules/executive.py: Removed.
1951         * Scripts/modules/executive_unittest.py: Removed.
1952         * Scripts/modules/grammar.py: Removed.
1953         * Scripts/modules/mock.py: Removed.
1954         * Scripts/modules/mock_bugzillatool.py: Removed.
1955         * Scripts/modules/multicommandtool.py: Removed.
1956         * Scripts/modules/multicommandtool_unittest.py: Removed.
1957         * Scripts/modules/outputcapture.py: Removed.
1958         * Scripts/modules/patchcollection.py: Removed.
1959         * Scripts/modules/queueengine.py: Removed.
1960         * Scripts/modules/queueengine_unittest.py: Removed.
1961         * Scripts/modules/scm.py: Removed.
1962         * Scripts/modules/scm_unittest.py: Removed.
1963         * Scripts/modules/statusbot.py: Removed.
1964         * Scripts/modules/stepsequence.py: Removed.
1965         * Scripts/modules/style: Removed.
1966         * Scripts/modules/style.py: Removed.
1967         * Scripts/modules/style_unittest.py: Removed.
1968         * Scripts/modules/text_style.py: Removed.
1969         * Scripts/modules/text_style_unittest.py: Removed.
1970         * Scripts/modules/user.py: Removed.
1971         * Scripts/modules/webkit_logging.py: Removed.
1972         * Scripts/modules/webkit_logging_unittest.py: Removed.
1973         * Scripts/modules/webkit_mechanize.py: Removed.
1974         * Scripts/modules/webkitport.py: Removed.
1975         * Scripts/modules/webkitport_unittest.py: Removed.
1976         * Scripts/test-webkit-python: Removed.
1977         * Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python.
1978         * Scripts/validate-committer-lists:
1979         * Scripts/webkitpy: Copied from WebKitTools/Scripts/modules.
1980         * Scripts/webkitpy/bugzilla.py:
1981         * Scripts/webkitpy/bugzilla_unittest.py:
1982         * Scripts/webkitpy/buildbot.py:
1983         * Scripts/webkitpy/buildbot_unittest.py:
1984         * Scripts/webkitpy/buildsteps.py:
1985         * Scripts/webkitpy/buildsteps_unittest.py:
1986         * Scripts/webkitpy/commands/commandtest.py:
1987         * Scripts/webkitpy/commands/download.py:
1988         * Scripts/webkitpy/commands/download_unittest.py:
1989         * Scripts/webkitpy/commands/early_warning_system.py:
1990         * Scripts/webkitpy/commands/early_warning_system_unittest.py:
1991         * Scripts/webkitpy/commands/queries.py:
1992         * Scripts/webkitpy/commands/queries_unittest.py:
1993         * Scripts/webkitpy/commands/queues.py:
1994         * Scripts/webkitpy/commands/queues_unittest.py:
1995         * Scripts/webkitpy/commands/queuestest.py:
1996         * Scripts/webkitpy/commands/upload.py:
1997         * Scripts/webkitpy/commands/upload_unittest.py:
1998         * Scripts/webkitpy/comments.py:
1999         * Scripts/webkitpy/credentials.py:
2000         * Scripts/webkitpy/credentials_unittest.py:
2001         * Scripts/webkitpy/executive.py:
2002         * Scripts/webkitpy/executive_unittest.py:
2003         * Scripts/webkitpy/mock_bugzillatool.py:
2004         * Scripts/webkitpy/multicommandtool.py:
2005         * Scripts/webkitpy/multicommandtool_unittest.py:
2006         * Scripts/webkitpy/queueengine.py:
2007         * Scripts/webkitpy/queueengine_unittest.py:
2008         * Scripts/webkitpy/scm.py:
2009         * Scripts/webkitpy/scm_unittest.py:
2010         * Scripts/webkitpy/statusbot.py:
2011         * Scripts/webkitpy/stepsequence.py:
2012         * Scripts/webkitpy/webkit_logging_unittest.py:
2013         * Scripts/webkitpy/webkitport_unittest.py:
2014
2015 2010-01-03  Chris Jerdonek  <chris.jerdonek@gmail.com>
2016
2017         Reviewed by Eric Seidel.
2018
2019         Added script to test both Perl and Python, and renamed
2020         run-webkit-unittests to test-webkit-python.
2021
2022         https://bugs.webkit.org/show_bug.cgi?id=33045
2023
2024         * Scripts/VCSUtils_unittest.pl:
2025           - Tweaked so it can be run from outside Scripts directory.
2026
2027         * Scripts/run-webkit-unittests: Removed.
2028           - Renamed to test-webkit-python.
2029
2030         * Scripts/test-webkit-perl:
2031           - Tweaked so it can be run from outside Scripts directory.
2032
2033         * Scripts/test-webkit-python: Copied from Scripts/run-webkit-unittests.
2034
2035         * Scripts/test-webkit-scripts: Added.
2036           - Runs both test-webkit-perl and test-webkit-python.
2037
2038 2010-01-03  Adam Barth  <abarth@webkit.org>
2039
2040         Reviewed by Eric Seidel.
2041
2042         commit-queue/bugzilla-tool should build both Debug and Release
2043         https://bugs.webkit.org/show_bug.cgi?id=28450
2044
2045         Add a --build-style command that lets the master process tell the child
2046         process to build both debug and release.  Eventually we want to teach
2047         the test step to understand this option too, but that's a patch for
2048         another day.
2049
2050         * Scripts/modules/buildsteps.py:
2051         * Scripts/modules/commands/queues.py:
2052         * Scripts/modules/webkitport.py:
2053         * Scripts/modules/webkitport_unittest.py:
2054
2055 2010-01-03  Jakub Wieczorek  <faw217@gmail.com>
2056
2057         Reviewed by Eric Seidel.
2058
2059         [Qt] EventSender: add support for Enter key events
2060         https://bugs.webkit.org/show_bug.cgi?id=33064
2061
2062         Unskip 5 tests that are fixed now.
2063
2064         * DumpRenderTree/qt/EventSenderQt.cpp:
2065         (EventSender::keyDown):
2066
2067 2010-01-03  Adam Barth  <abarth@webkit.org>
2068
2069         Reviewed by Eric Seidel.
2070
2071         [bzt] Add test for previous typo fix
2072         https://bugs.webkit.org/show_bug.cgi?id=33083
2073
2074         A trivial test for a trivial fix, as requested by Eric.
2075
2076         * Scripts/modules/bugzilla_unittest.py:
2077
2078 2010-01-03  Adam Barth  <abarth@webkit.org>
2079
2080         Reviewed by Eric Seidel.
2081
2082         Implement mac-ews
2083         https://bugs.webkit.org/show_bug.cgi?id=33072
2084
2085         The mac-ews is slightly different than the other early warning systems
2086         because we can't run Mac OS X inside a VM.  For that reason, we only
2087         process patches that were uploaded by committers.  This isn't as much
2088         coverage as the other EWS bots, but it's better than nothing.
2089
2090         * Scripts/modules/commands/early_warning_system.py:
2091         * Scripts/modules/commands/early_warning_system_unittest.py:
2092         * Scripts/modules/commands/queues.py:
2093         * Scripts/modules/commands/queuestest.py:
2094         * Scripts/modules/mock_bugzillatool.py:
2095
2096 2010-01-03  Chris Jerdonek  <chris.jerdonek@gmail.com>
2097
2098         Reviewed by David Kilzer.
2099
2100         Refactored svn-apply and svn-unapply to use a common "patch"
2101         command method, and added unit tests for this new method.
2102
2103         https://bugs.webkit.org/show_bug.cgi?id=33098
2104
2105         * Scripts/VCSUtils.pm:
2106           - Added generateRunPatchCommand().
2107           - Added runPatchCommand().
2108           - Added exitStatus() from webkitdirs.pm to address FIXME.
2109
2110         * Scripts/VCSUtils_unittest.pl:
2111           - Added 10 unit tests for generateRunPatchCommand().
2112           - Added 4 unit tests for runPatchCommand().
2113           - Added callSilently() method.
2114
2115         * Scripts/svn-apply:
2116           - Refactored applyPatch().
2117           - Removed $pathScriptWasRunFrom global variable.
2118           - Addressed issue where "--force" option was getting added twice.
2119
2120         * Scripts/svn-unapply:
2121           - Refactored applyPatch().
2122           - Removed $pathScriptWasRunFrom global variable.
2123           - Added support for --force option.
2124           - Enhanced to return meaningful exit status.
2125
2126         * Scripts/webkitdirs.pm:
2127           - Moved exitStatus() implementation to VCSUtils.pm.
2128
2129 2009-12-31  Adam Barth  <abarth@webkit.org>
2130
2131         Reviewed by Eric Seidel.
2132
2133         [bzt] Implement build-and-test
2134         https://bugs.webkit.org/show_bug.cgi?id=33073
2135
2136         Some of the early warning system bots want to use build-and-test so
2137         they can cover LayoutTests in addition to just compilation.
2138
2139         * Scripts/modules/commands/download.py:
2140         * Scripts/modules/commands/download_unittest.py:
2141
2142 2009-12-31  Adam Barth  <abarth@webkit.org>
2143
2144         Reviewed by Eric Seidel.
2145
2146         Show mac-ews status on QueueStatusServer
2147         https://bugs.webkit.org/show_bug.cgi?id=33076
2148
2149         Also make error status purple.
2150
2151         * QueueStatusServer/model/attachment.py:
2152         * QueueStatusServer/model/queues.py:
2153         * QueueStatusServer/templates/dashboard.html:
2154         * QueueStatusServer/templates/statusbubble.html:
2155
2156 2009-12-31  Adam Barth  <abarth@webkit.org>
2157
2158         Unreviewed.
2159
2160         [bzt] REGRESSION: Bugzila is a typo
2161         https://bugs.webkit.org/show_bug.cgi?id=33074
2162
2163         Eric should test his code before landing!  :)
2164
2165         * Scripts/modules/bugzilla.py:
2166
2167 2009-12-31  Adam Barth  <abarth@webkit.org>
2168
2169         Unreviewed.  Fix the unit tests!
2170
2171         * Scripts/run-webkit-unittests:
2172
2173 2009-12-30  Kevin Watters  <kevinwatters@gmail.com>
2174
2175         Reviewed by Kevin Ollivier.
2176
2177         [wx] Alter a couple of default settings in the test app.
2178         
2179         https://bugs.webkit.org/show_bug.cgi?id=32956
2180
2181         * wx/browser/browser.cpp:
2182         (MyApp::OnInit):
2183
2184 2009-12-30  Eric Seidel  <eric@webkit.org>
2185
2186         Reviewed by Adam Barth.
2187
2188         logging.py should be renamed to webkit_logging.py and eventually die
2189         https://bugs.webkit.org/show_bug.cgi?id=33058
2190
2191         Change all imports of "logging" to webkit_logging,
2192         except the ones which came from Google's cpp_lint.py and diff_parser.py
2193         which clearly are assuming python's logging.py.
2194
2195         * Scripts/modules/bugzilla.py:
2196         * Scripts/modules/buildbot.py:
2197         * Scripts/modules/buildsteps.py:
2198         * Scripts/modules/commands/download.py:
2199         * Scripts/modules/commands/queries.py:
2200         * Scripts/modules/commands/queues.py:
2201         * Scripts/modules/commands/upload.py:
2202         * Scripts/modules/credentials.py:
2203         * Scripts/modules/executive.py:
2204         * Scripts/modules/multicommandtool.py:
2205         * Scripts/modules/queueengine.py:
2206         * Scripts/modules/scm.py:
2207         * Scripts/modules/statusbot.py:
2208         * Scripts/modules/stepsequence.py:
2209         * Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py.
2210         * Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py.
2211
2212 2009-12-30  Jakub Wieczorek  <faw217@gmail.com>
2213
2214         Reviewed by Simon Hausmann.
2215
2216         [Qt] layoutTestController.pathToLocalResource() should return a path, not an URL
2217         https://bugs.webkit.org/show_bug.cgi?id=33051
2218
2219         Moreover, its primary function is to normalize the path in regard of platform
2220         specific directory separators. Therefore, it can simply make use of the
2221         QDir::toNativeSeparators function.
2222
2223         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2224         (LayoutTestController::pathToLocalResource):
2225
2226 2009-12-30  David D. Kilzer  <ddkilzer@webkit.org>
2227
2228         Fix executable bits for r52646
2229
2230         * Scripts/VCSUtils_unittest.pl: Added property svn:executable.
2231         * Scripts/test-webkit-perl: Ditto.
2232
2233 2009-12-29  Chris Jerdonek  <chris.jerdonek@gmail.com>
2234
2235         Reviewed by David Kilzer.
2236
2237         Fixed a bug in fixChangeLogPatch, made it work correctly in
2238         more circumstances, and added unit tests.
2239
2240         https://bugs.webkit.org/show_bug.cgi?id=32919
2241
2242         * Scripts/VCSUtils.pm:
2243           Rewrote fixChangeLogPatch.
2244           
2245         * Scripts/VCSUtils_unittest.pl: Added.
2246           Added 7 unit tests for fixChangeLogPatch.
2247
2248         * Scripts/test-webkit-perl: Added.
2249           Added test harness for unit tests of Perl code.
2250
2251 2009-12-29  Eric Seidel  <eric@webkit.org>
2252
2253         Reviewed by Adam Barth.
2254
2255         Split out BugzillaQueries class from Bugzilla
2256         https://bugs.webkit.org/show_bug.cgi?id=33042
2257
2258         * Scripts/modules/bugzilla.py:
2259          - Split out BugzillaQueries from Bugzilla.
2260          - Try to isolate self.bugzilla usage into helper functions whenever possible.
2261          - Add a bunch of FIXMEs.
2262          - Rename fetch_bug_ids_from_needs_commit_list to fetch_bug_ids_from_pending_commit_list
2263         * Scripts/modules/bugzilla_unittest.py:
2264          - Create a new BugzillaQueriesTest testcase and move logic there.
2265         * Scripts/modules/buildsteps_unittest.py:
2266          - Use Bug 75 instead of 1 since bug 1 doesn't actually exist.
2267         * Scripts/modules/commands/queries.py:
2268          - Update to use bugzilla.queries
2269         * Scripts/modules/commands/queues.py:
2270          - Ditto.
2271         * Scripts/modules/commands/upload.py:
2272          - Ditto.
2273         * Scripts/modules/mock_bugzillatool.py:
2274          - Add a MockBugzillaQueries.
2275          - Make patches and bugs global privates.
2276          - Let _id_to_object_dictionary take a variable argument list instead of an array.
2277
2278 2009-12-29  Daniel Bates  <dbates@webkit.org>
2279
2280         Reviewed by Eric Seidel.
2281
2282         https://bugs.webkit.org/show_bug.cgi?id=33041
2283
2284         Speed up the test method test_read_credentials_with_SVN by not actually
2285         creating an SVN repository to test against (by default). Instead, it is
2286         sufficient to create a temporary directory that does not contain a Git
2287         repository.
2288
2289         Also, renamed method test_read_credentials_with_SVN to
2290         test_read_credentials_without_git_repo, to better reflect what it is
2291         testing.
2292
2293         * Scripts/modules/credentials_unittest.py:
2294
2295 2009-12-29  Daniel Bates  <dbates@webkit.org>
2296
2297         Reviewed by Adam Barth.
2298
2299         https://bugs.webkit.org/show_bug.cgi?id=33039
2300
2301         [bzt] Fixes an issue where bugzilla-tool dies when the keychain lookup
2302         fails to find an entry for bugs.webkit.org.
2303         
2304         Under Mac OS X, bugzilla-tool tries to query the keychain and Security
2305         framework (via /usr/sbin/security) for an internet-password entry for
2306         bugs.webkit.org so that it can use it to login to bugs.webkit.org.
2307         However, if no such entry exists then bugzilla-tool dies with an error.
2308
2309         * Scripts/modules/credentials.py: Modified method _parse_security_tool_output to return
2310         [None, None] if /usr/sbin/security cannot find keychain entry for bugs.webkit.org.
2311         * Scripts/modules/credentials_unittest.py: Added method test_security_output_parse_entry_not_found.
2312
2313 2009-12-29  Eric Seidel  <eric@webkit.org>
2314
2315         Rubber-stamped by Adam Barth.
2316
2317         Remove unused BugzillaException.
2318
2319         * Scripts/modules/bugzilla.py:
2320
2321 2009-12-29  Eric Seidel  <eric@webkit.org>
2322
2323         Reviewed by Adam Barth.
2324
2325         Need a script to assign bugs with r+ patches to committers for landing
2326         https://bugs.webkit.org/show_bug.cgi?id=33009
2327
2328         This is just one more small tool to help in the fight against our
2329         ever-growing list of to-be-committed patches.
2330
2331         * Scripts/modules/bugzilla.py:
2332          - Rename assign_to_email to assigned_to_email (typo).
2333          - Add assigned_to_email() method on Bug.
2334          - Add reassign_bug method.
2335          - Add Bugzilla.unassigned_email, eventually should move to some webkit_config.py module.
2336         * Scripts/modules/bugzilla_unittest.py:
2337          - Update test after assigned_to_email rename.
2338         * Scripts/modules/commands/commandtest.py:
2339          - Call bind_to_tool to that self.tool works in Command testing.
2340         * Scripts/modules/commands/download.py:
2341          - Move AbstractDeclarativeCommmand multicommandtool.py, it should be part of Command.
2342         * Scripts/modules/commands/queries_unittest.py:
2343          - One of the test patches is now posted by "eric@webkit.org" which is a committer.
2344          - Eventually we'll mock out CommitterList and be able to better control what's a committer and what's not.
2345         * Scripts/modules/commands/upload.py:
2346          - Add new assign-to-committer command.
2347         * Scripts/modules/commands/upload_unittest.py:
2348          - Add basic assign-to-committer test.
2349         * Scripts/modules/committers.py:
2350          - Add bugzilla_email() accessor.
2351         * Scripts/modules/committers_unittest.py:
2352          - Test our assumption that bugzilla_email is the first email.
2353         * Scripts/modules/mock_bugzillatool.py:
2354          - Add _id_to_object_dictionary for generating bug_cache from list of bugs.
2355          - Remove unused fetch_attachments_from_bug.
2356          - Add fetch_bug support and a bug_cache.
2357         * Scripts/modules/multicommandtool.py:
2358          - Move AbstractDeclarativeCommmand here from download.py
2359
2360 2009-12-29  Adam Barth  <abarth@webkit.org>
2361
2362         Reviewed by Eric Seidel.
2363
2364         [bzt] Don't crash if user types a number during PromptForBugOrTitleStep
2365         https://bugs.webkit.org/show_bug.cgi?id=33038
2366
2367         Simple fix with test.
2368
2369         * Scripts/modules/buildsteps.py:
2370         * Scripts/modules/buildsteps_unittest.py:
2371
2372 2009-12-29  Adam Barth  <abarth@webkit.org>
2373
2374         Reviewed by Eric Seidel.
2375
2376         [bzt] post-diff requires reading to the end
2377         https://bugs.webkit.org/show_bug.cgi?id=33036
2378
2379         Catch the IOError caused by not reading to the end of the diff.  We
2380         don't have a good way to test this currently.
2381
2382         * Scripts/modules/user.py:
2383
2384 2009-12-29  Chang Shu  <Chang.Shu@nokia.com>
2385
2386         Reviewed by Adam Barth.
2387
2388         [Qt] Move logic that handles Qt headers before primary headers
2389         so that Qt headers won't be treated as primary headers by mistake.
2390         https://bugs.webkit.org/show_bug.cgi?id=32991
2391
2392         * Scripts/modules/cpp_style.py:
2393         * Scripts/modules/cpp_style_unittest.py:
2394
2395 2009-12-29  Eric Seidel  <eric@webkit.org>
2396
2397         Reviewed by Adam Barth.
2398
2399         Add the start of a Bug object for bugzilla.py
2400         https://bugs.webkit.org/show_bug.cgi?id=32995
2401
2402         This allowed us to get rid of some duplicated "is_obsolete" checks.
2403
2404         * Scripts/modules/bugzilla.py:
2405          - Add a new Bug class, and move patches/unreviewed_patches filtering logic there.
2406          - Add _fetch_bug_page for possible future mocking.
2407            (I did not try to test fetch_*_from_bug now due to difficulties with our current validate_reviewer logic.)
2408          - Rename fetch_bug to fetch_bug_dictionary and add a new fetch_bug which returns a Bug object.
2409          - Use fetch_bug and attachments(), patches(), etc. instead of custom fetch_*_from_bug methods.
2410          - Reduce code in fetch_patches_from_pending_commit_list and fetch_patches_from_review_queue
2411            using list comprehensions. Use a sum(list, []) trick to flatten a list of lists into a single list.
2412         * Scripts/modules/bugzilla_unittest.py:
2413          - Remove an unneeded unicode string marker.
2414         * Scripts/modules/buildsteps.py:
2415          - define __all__ to include just the BuildSteps
2416         * Scripts/modules/commands/download.py:
2417          - import * now that we have an __all__ defined.
2418         * Scripts/modules/commands/upload.py:
2419          - Use fetch_bug_dictionary instead of fetch_bug.
2420
2421 2009-12-29  Daniel Bates  <dbates@webkit.org>
2422
2423         Reviewed by Ariya Hidayat.
2424
2425         https://bugs.webkit.org/show_bug.cgi?id=32925
2426
2427         Adds an Open File dialog to make it convenient to open a file
2428         to view in the browser.
2429
2430         Currently a person must either specify the path to a file as a
2431         command-line argument or type a file URL. Instead, we should
2432         have a file dialog to allow a person to open a file without
2433         memorizing its path.
2434
2435         * QtLauncher/main.cpp:
2436         (MainWindow::MainWindow): Changed urlEdit->setText(qurl.toEncoded())
2437         to urlEdit->setText(qurl.toString()). 
2438         (MainWindow::openFile): Added.
2439         (MainWindow::changeLocation): Moved code to load URL into method
2440         MainWindow::loadURL.
2441         (MainWindow::loadURL): Added.
2442         (MainWindow::setupUI): Added menu item Open File.
2443
2444 2009-12-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2445
2446         Reviewed by Holger Freyther.
2447
2448         [GTK] fails fast/harness/use-page-cache.html
2449         https://bugs.webkit.org/show_bug.cgi?id=33013
2450
2451         Make sure settings are forwarded to child WebViews.
2452
2453         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2454         (createWebView):
2455
2456 2009-12-29  Daniel Bates  <dbates@webkit.org>
2457
2458         Reviewed by Eric Seidel.
2459
2460         https://bugs.webkit.org/show_bug.cgi?id=32778
2461
2462         Changes $diffPercentage to be a number to resolve Perl
2463         warning about comparing a string to a number.
2464
2465         * Scripts/run-webkit-tests:
2466
2467 2009-12-29  Jakub Wieczorek  <faw217@gmail.com>
2468
2469         Reviewed by Eric Seidel.
2470
2471         [Qt] DRT: Frame loader callbacks differ from the Mac port
2472         https://bugs.webkit.org/show_bug.cgi?id=32989
2473
2474         Remove messages from the callbacks that should not dump them to match
2475         the expected results for the http/loading tests.
2476
2477         Unskip some http/loading tests which succeed now.
2478
2479         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2480         (WebCore::DumpRenderTree::dump):
2481
2482 2009-12-29  Robert Hogan  <robert@roberthogan.net>
2483
2484         Reviewed by Eric Seidel.
2485
2486         [Qt] fix fast/dom/Window/window-onFocus.html
2487         
2488         Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
2489         window.onblur was getting dispatched twice from QtWebKit.
2490         
2491         https://bugs.webkit.org/show_bug.cgi?id=32990
2492
2493         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2494         (WebCore::DumpRenderTree::DumpRenderTree):
2495         (WebCore::DumpRenderTree::switchFocus):
2496         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2497         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2498         (LayoutTestController::setWindowIsKey):
2499         (LayoutTestController::setMainFrameIsFirstResponder):
2500         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2501
2502 2009-12-28  Kinuko Yasuda  <kinuko@chromium.org>
2503
2504         Reviewed by Maciej Stachowiak.
2505
2506         Extended EventSender.keyDown method to take another (3rd) argument
2507         for indicating the keyLocation to make numeric pad key events testable.
2508         Expected values for the argument is one of the KeyLocationCode
2509         specified in DOM Level 3
2510         (http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents).
2511         https://bugs.webkit.org/show_bug.cgi?id=28247
2512
2513         Test: fast/events/keydown-numpad-keys.html
2514
2515         * DumpRenderTree/mac/EventSendingController.mm:
2516         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2517         (+[EventSendingController webScriptNameForSelector:]):
2518         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2519
2520 2009-12-28  Ariya Hidayat  <ariya.hidayat@gmail.com>
2521
2522         Unreviewed, update my email address.
2523
2524         * Scripts/modules/committers.py:
2525
2526 2009-12-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2527
2528         Reviewed by Adam Barth.
2529
2530         [Qt] Fix build break for Qt 4.4
2531         https://bugs.webkit.org/show_bug.cgi?id=30327
2532
2533         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Include QLocale
2534         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Ditto.
2535         * QtLauncher/main.cpp:
2536         (MainWindow::MainWindow): Qt::WA_TranslucentBackground was
2537         introduced in Qt version 4.5
2538
2539 2009-12-28  Adam Barth  <abarth@webkit.org>
2540
2541         Reviewed by Eric Seidel.
2542
2543         [bzt] Add an edit-changelog command
2544         https://bugs.webkit.org/show_bug.cgi?id=32986
2545
2546         This command makes it easier to edit ChangeLogs.  It's similar to
2547         prepare-ChangeLog -o, except it works with already existing ChangeLogs.
2548
2549         * Scripts/modules/commands/upload.py:
2550         * Scripts/modules/commands/upload_unittest.py:
2551
2552 2009-12-28  Adam Barth  <abarth@webkit.org>
2553
2554         Reviewed by Eric Seidel.
2555
2556         [bzt] Create an ASAD command for uploading a patch
2557         https://bugs.webkit.org/show_bug.cgi?id=32979
2558
2559         The create-review command goes through the whole process of preparing a
2560         code review, including creating a bug, editing the ChangeLogs, and
2561         uploading the patch.  It is indeed the All Sing, All Dance upload
2562         command.
2563
2564         * Scripts/modules/buildsteps.py:
2565         * Scripts/modules/commands/upload.py:
2566         * Scripts/modules/commands/upload_unittest.py:
2567         * Scripts/modules/mock_bugzillatool.py:
2568         * Scripts/modules/user.py:
2569
2570 2009-12-28  Adam Barth  <abarth@webkit.org>
2571
2572         Unreviewed "build" fix (with test!).
2573
2574         * Scripts/modules/bugzilla.py:
2575         * Scripts/modules/bugzilla_unittest.py:
2576
2577 2009-12-27  Eric Seidel  <eric@webkit.org>
2578
2579         Reviewed by Adam Barth.
2580
2581         Add more awesome bug-parsing logic to bugzilla.py in preparation for assign-to-committer command
2582         https://bugs.webkit.org/show_bug.cgi?id=32980
2583
2584         * Scripts/modules/bugzilla.py:
2585          - Add a new _parse_bug_page function and use it in fetch_attachments_from_bug
2586          - Replace fetch_title_from_bug with a new fetch_bug call instead.
2587          - Use list comprehensions where possible to reduce code duplication.
2588         * Scripts/modules/bugzilla_unittest.py:
2589          - Add a minimal bug parsing test.
2590          - Share code between bug parsing and attachment parsing tests with _assert_dictionaries_equal
2591         * Scripts/modules/commands/upload.py:
2592          - Use fetch_bug(bug_id)["title"] instead of fetch_title_from_bug
2593
2594 2009-12-27  Adam Barth  <abarth@webkit.org>
2595
2596         Reviewed by Eric Seidel.
2597
2598         Status bubble shouldn't be transparent for bots that haven't run yet
2599         https://bugs.webkit.org/show_bug.cgi?id=32977
2600
2601         * QueueStatusServer/templates/statusbubble.html:
2602
2603 2009-12-27  Adam Barth  <abarth@webkit.org>
2604
2605         Reviewed by Eric Seidel.
2606
2607         [QueueStatusServer] Run gc cron job less often
2608         https://bugs.webkit.org/show_bug.cgi?id=32958
2609
2610         Now that we've cleaned out the backlog of idle messages, we don't need
2611         to run the gc job every half hour.  We could also stop logging the idle
2612         messages, but this seems easier for the time being.
2613
2614         * QueueStatusServer/cron.yaml:
2615
2616 2009-12-27  Daniel Bates  <dbates@webkit.org>
2617
2618         Reviewed by Adam Barth.
2619
2620         https://bugs.webkit.org/show_bug.cgi?id=32896
2621
2622         Fixes an issue where bugzilla-tool tries to read the username and password from
2623         Git regardless of whether Git is installed. In particular, if Git is not
2624         installed then bugzilla-tool dies (with a trace) when it attempts to query Git
2625         for the authentication credentials to log into bugs.webkit.org.
2626
2627         Moreover, modifies Executive.run_command to catch and pass OSError exceptions to
2628         the specified error handler. For instance, the specified error handler will now
2629         be called when the command does not exist (i.e. OSError errno 2).
2630
2631         * Scripts/modules/credentials.py: Added check for Git.
2632         * Scripts/modules/credentials_unittest.py: Added test method
2633         test_read_credentials_with_SVN.
2634         * Scripts/modules/executive.py: Modified method run_command to catch
2635         OSError exceptions (i.e [Errno 2] No such file or directory) and call
2636         the specified error handler.
2637         * Scripts/modules/executive_unittest.py: Added.
2638         * Scripts/run-webkit-unittests: Added import executive_unittest.py.
2639
2640 2009-12-27  Daniel Bates  <dbates@webkit.org>
2641
2642         Unreviewed. Added missing file style_unittest.py that wasn't committed
2643         in change set 52541 (http://trac.webkit.org/changeset/52541) as part of
2644         the patch for bug #32592.
2645
2646         * Scripts/modules/style_unittest.py: Added.
2647
2648 2009-12-27  Daniel Bates  <dbates@webkit.org>
2649
2650         Reviewed by Eric Seidel.
2651
2652         https://bugs.webkit.org/show_bug.cgi?id=32964
2653
2654         [bzt] Updated the unit test based on the change made in bug #32951.
2655
2656         The change made in bug #32951 added the command-line argument:
2657         --makeargs="-j8" to the build-webkit command. However, the associated
2658         unit test was not updated.
2659
2660         * Scripts/modules/webkitport_unittest.py:
2661
2662 2009-12-27  Yael Aharon  <yael.aharon@nokia.com>
2663
2664         Reviewed by Darin Adler.
2665
2666         check-webkit-style should not mark moc files inclusion as errors
2667         https://bugs.webkit.org/show_bug.cgi?id=32669
2668
2669         Add a new header type for moc files, and skip them when checking the order of header files.
2670
2671         * Scripts/modules/cpp_style.py:
2672
2673 2009-12-26  Adam Barth  <abarth@webkit.org>
2674
2675         Reviewed by Eric Seidel.
2676
2677         [bzt] Make the qt build go fast
2678         https://bugs.webkit.org/show_bug.cgi?id=32951
2679
2680         Make use of multiple cores, if available.
2681
2682         * Scripts/modules/webkitport.py:
2683
2684 2009-12-25  Daniel Bates  <dbates@rim.com>
2685
2686         Reviewed by Eric Seidel.
2687
2688         https://bugs.webkit.org/show_bug.cgi?id=32682
2689
2690         Fixes an issue where checkFrameworks always dies with an error under Windows
2691         since the clause "unless (-x $path)" is always satisfied because files under
2692         Windows do not have an explict executable bit.
2693
2694         * Scripts/webkitdirs.pm:
2695
2696 2009-12-23  Eric Seidel  <eric@webkit.org>
2697
2698         Reviewed by Adam Barth.
2699
2700         bugzilla-tool should accept global options anywhere
2701         https://bugs.webkit.org/show_bug.cgi?id=26912
2702
2703         * Scripts/bugzilla-tool:
2704          - Use the new global_options class property.
2705          - Add a handle_global_options callback to avoid needing callbacks for each global option.
2706         * Scripts/modules/multicommandtool.py:
2707          - Make the code use one combined option parser.
2708            This allows us to accept global options anywhere and
2709            individual command options before commands.
2710          - Add a handle_global_options callback to avoid needing callbacks for each global option.
2711          - Make the Command hold the option parser, but allow the tool to override it.
2712          - The default option parser is used for help printing and when Commands are run stand alone,
2713            but are otherwise not used.
2714          - Add Command.main to codify the idea that Commands should support being run stand-alone.
2715          - Change _split_args to _split_command_name_from_args now that args are unified.
2716         * Scripts/modules/multicommandtool_unittest.py:
2717          - Test that "tool" and "tool help" show the same help.
2718          - Test that args are accepted before commands
2719
2720 2009-12-20  Chris Jerdonek  <chris.jerdonek@gmail.com>
2721
2722         Reviewed by David Levin.
2723
2724         Moved some sections of code in preparation to refactor
2725         check-webkit-style's argument parser to avoid setting
2726         global variables.
2727
2728         https://bugs.webkit.org/show_bug.cgi?id=32592
2729
2730         * Scripts/check-webkit-style:
2731           - Moved _USAGE string to style.py.
2732           - Addressed FIXME by eliminating dependencies on cpp_style.py.
2733
2734         * Scripts/modules/cpp_style.py:
2735           - Moved default arguments and style categories to style.py.
2736           - Moved exit_with_usage(), exit_with_categories(), and
2737             parse_arguments() to style.py.
2738           - Removed references in _CppStyleState to the global
2739             variables now in style.py.
2740
2741         * Scripts/modules/cpp_style_unittest.py:
2742           - Moved parse_arguments() unit tests to style_unittest.py.
2743
2744         * Scripts/modules/style.py:
2745           - Added _USAGE string from check-webkit-style.
2746           - Added default arguments and style categories from cpp_style.py.
2747           - Added exit_with_usage(), exit_with_categories(), and
2748             parse_arguments() from cpp_sstyle.py.
2749
2750         * Scripts/modules/style_unittest.py: Added.
2751           - Added parse_arguments() unit tests from cpp_style_unittest.py.
2752
2753         * Scripts/run-webkit-unittests:
2754           - Added unit tests from style_unittest.py.
2755
2756 2009-12-23  Eric Seidel  <eric@webkit.org>
2757
2758         Reviewed by Adam Barth.
2759
2760         commit-queue should mention bug 30084 when rejecting patches until it can be fixed
2761         https://bugs.webkit.org/show_bug.cgi?id=32911
2762
2763         * Scripts/modules/bugzilla.py: Make the message even more fancy.
2764         * Scripts/modules/bugzilla_unittest.py: Test our new fancy message.
2765
2766 2009-12-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2767
2768         Not reviewed, adding myself to the reviewers list.
2769
2770         * Scripts/modules/committers.py:
2771
2772 2009-12-23  Adam Barth  <abarth@webkit.org>
2773
2774         Reviewed by Eric Seidel.
2775
2776         [bzt] Create a prepare-diff command that creates a bug and a ChangeLog
2777         https://bugs.webkit.org/show_bug.cgi?id=32895
2778
2779         The workflow Maciej and I discussed is as follows:
2780
2781         1) Write code.
2782         2) bugzilla-tool prepare-diff
2783         3) Edit ChangeLogs
2784         4) bugzilla-tool post-diff
2785
2786         We might want to experimenting with combining 2-4 into a single
2787         command, but that might be stressful to edit the ChangeLogs modally.
2788
2789         Removed submit-patch since it has the modal ChangeLog editing but none
2790         oof the bug creating fun.
2791
2792         * Scripts/modules/bugzilla.py:
2793         * Scripts/modules/buildsteps.py:
2794         * Scripts/modules/commands/upload.py:
2795         * Scripts/modules/commands/upload_unittest.py:
2796
2797 2009-12-23  Gabor Loki  <loki@webkit.org>
2798
2799         Unreviewed; added myself to the committers list.
2800
2801         * Scripts/modules/committers.py:
2802
2803 2009-12-22  Adam Barth  <abarth@webkit.org>
2804
2805         Reviewed by Maciej Stachowiak.
2806
2807         [bzt] Don't call create-patch twice during post-diff
2808         https://bugs.webkit.org/show_bug.cgi?id=32893
2809
2810         If we call create-patch to get the bug number, cache the diff in the
2811         state so we don't need to call it again.
2812
2813         * Scripts/modules/buildsteps.py:
2814         * Scripts/modules/commands/upload.py:
2815
2816 2009-12-22  Daniel Bates  <dbates@rim.com>
2817
2818         Reviewed by Eric Seidel.
2819
2820         https://bugs.webkit.org/show_bug.cgi?id=32680
2821
2822         Fixes an issue in builtDylibPathForName so that it returns the correct
2823         path to the built QtWebKit library on the Qt Windows port. Currently,
2824         it returns the path to the file named QtWebKit.dll but this file does
2825         not exist on the Qt Windows build. Instead, the file is named
2826         QtWebKit4.dll.
2827
2828         * Scripts/webkitdirs.pm:
2829
2830 2009-12-22  Marc-Antoine Ruel  <maruel@chromium.org>
2831
2832         Reviewed by Adam Roben.
2833
2834         Remove the only dependency on perl-libwin32 in cygwin
2835
2836         * Scripts/num-cpus:
2837
2838 2009-12-22  Darin Adler  <darin@apple.com>
2839
2840         * pywebsocket/mod_pywebsocket: Added property svn:ignore to ignore
2841         generated ".pyc" files.
2842
2843 2009-12-22  Darin Adler  <darin@apple.com>
2844
2845         Reviewed by Mark Rowe.
2846
2847         Turn off datagrid by default, at least for all platforms Apple ships.
2848         The datagrid implementation isn't ready for general web use yet.
2849
2850         * Scripts/build-webkit: Turn off datagrid by default.
2851
2852 2009-12-22  Eric Seidel  <eric@webkit.org>
2853
2854         Reviewed by Darin Adler.
2855
2856         validate-committer-lists fails when run from an SVN checkout
2857         https://bugs.webkit.org/show_bug.cgi?id=31974
2858
2859         * Scripts/validate-committer-lists:
2860          - Make it print a warning message instead of throwing
2861            an exception when running from an SVN checkout.
2862
2863 2009-12-22  Philippe Normand  <pnormand@igalia.com>
2864
2865         Reviewed by Adam Barth.
2866
2867         check-webkit-style should not warn about NULL usage in g_object_{get,set}
2868         https://bugs.webkit.org/show_bug.cgi?id=32858
2869
2870         * Scripts/modules/cpp_style.py:
2871         * Scripts/modules/cpp_style_unittest.py:
2872
2873 2009-12-22  Simon Hausmann  <simon.hausmann@nokia.com>
2874
2875         Rubber-stamped by Holger Freyther.
2876
2877         Moved QtLauncher from WebKit/qt.
2878
2879         * QtLauncher: Copied from WebKit/qt/QtLauncher.
2880         * QtLauncher/QtLauncher.pro:
2881
2882 2009-12-21  Adam Barth  <abarth@webkit.org>
2883
2884         Reviewed by Eric Seidel.
2885
2886         [bzt] Automate the process of calling prepare-ChangeLog
2887         https://bugs.webkit.org/show_bug.cgi?id=32816
2888
2889         This patch automates the process of creating a bug and patch and
2890         uploading it to bugzilla.  The first cut just calls
2891         prepare-ChangeLog.
2892
2893         This patch required some refactoring of upload.py to the Step
2894         model, but that's worth doing anyway.
2895
2896         * Scripts/bugzilla-tool:
2897         * Scripts/modules/buildsteps.py:
2898         * Scripts/modules/commands/download.py:
2899         * Scripts/modules/commands/upload.py:
2900         * Scripts/modules/commands/upload_unittest.py:
2901         * Scripts/modules/mock_bugzillatool.py:
2902
2903 2009-12-21  Darin Adler  <darin@apple.com>
2904
2905         * Scripts/do-webcore-rename: Did a rename, so checking in the
2906         version of the script I used.
2907
2908 2009-12-21  Adam Barth  <abarth@webkit.org>
2909
2910         Reviewed by Eric Seidel.
2911
2912         Update status-bubble to show all the queues
2913         https://bugs.webkit.org/show_bug.cgi?id=32838
2914
2915         Also, move statusbubble over to use memcache.
2916
2917         * QueueStatusServer/handlers/statusbubble.py:
2918         * QueueStatusServer/templates/statusbubble.html:
2919
2920 2009-12-21  Adam Barth  <abarth@webkit.org>
2921
2922         Reviewed by Eric Seidel.
2923
2924         Delete the boring "Empty queue" status messages in QueueStatusServer
2925         https://bugs.webkit.org/show_bug.cgi?id=32818
2926
2927         * QueueStatusServer/app.yaml:
2928         * QueueStatusServer/cron.yaml:
2929         * QueueStatusServer/handlers/gc.py:
2930         * QueueStatusServer/main.py:
2931
2932 2009-12-21  Adam Barth  <abarth@webkit.org>
2933
2934         Reviewed by Eric Seidel.
2935
2936         Exception on queue status server
2937         https://bugs.webkit.org/show_bug.cgi?id=32812
2938
2939         Turns out we need to pass the id to the filter.
2940
2941         * QueueStatusServer/filters/webkit_extras.py:
2942         * QueueStatusServer/templates/patch.html:
2943         * QueueStatusServer/templates/recentstatus.html:
2944
2945 2009-12-20  Chris Jerdonek  <chris.jerdonek@gmail.com>
2946
2947         Reviewed by Eric Seidel.
2948
2949         Created "style" folder for code supporting check-webkit-style.
2950
2951         * Scripts/modules/style: Added.
2952
2953 2009-12-20  Adam Barth  <abarth@webkit.org>
2954
2955         Reviewed by Eric Seidel.
2956
2957         REGRESSION: error when running commit-queue
2958         https://bugs.webkit.org/show_bug.cgi?id=32806
2959
2960         Fix typo and add test!
2961
2962         * Scripts/modules/bugzilla.py:
2963         * Scripts/modules/bugzilla_unittest.py:
2964
2965 2009-12-20  Adam Barth  <abarth@webkit.org>
2966
2967         [bzt] Optimize status updates for new dashboard
2968         https://bugs.webkit.org/show_bug.cgi?id=32797
2969
2970         This patch makes the queues slightly more chatty with the web service.
2971         Also, this patch introduces some testing for the queues!
2972
2973         * Scripts/modules/commands/early_warning_system.py:
2974         * Scripts/modules/commands/early_warning_system_unittest.py: Added.
2975         * Scripts/modules/commands/queues.py:
2976         * Scripts/modules/commands/queues_unittest.py:
2977         * Scripts/modules/commands/queuestest.py: Added.
2978         * Scripts/modules/mock_bugzillatool.py:
2979         * Scripts/modules/patchcollection.py:
2980         * Scripts/modules/queueengine.py:
2981         * Scripts/run-webkit-unittests:
2982
2983 2009-12-20  Adam Barth  <abarth@webkit.org>
2984
2985         Reviewed by Eric Seidel.
2986
2987         Prepare QueueStatusServer for new status messages
2988         https://bugs.webkit.org/show_bug.cgi?id=32805
2989
2990         * QueueStatusServer/handlers/recentstatus.py:
2991         * QueueStatusServer/index.html: Removed.
2992         * QueueStatusServer/model/attachment.py:
2993         * QueueStatusServer/model/queues.py: Added.
2994         * QueueStatusServer/templates/recentstatus.html: Added.
2995
2996 2009-12-20  Shinichiro Hamaji  <hamaji@chromium.org>
2997
2998         Reviewed by Adam Barth.
2999
3000         [check-webkit-style] static_cast is not misnamed!
3001         https://bugs.webkit.org/show_bug.cgi?id=32796
3002
3003         * Scripts/modules/cpp_style.py:
3004         * Scripts/modules/cpp_style_unittest.py:
3005
3006 2009-12-20  Alejandro G. Castro  <alex@igalia.com>
3007
3008         Reviewed by Gustavo Noronha Silva.
3009
3010         [GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
3011         https://bugs.webkit.org/show_bug.cgi?id=32788
3012
3013         Do not increase the click count if we are using a different button.
3014
3015         * DumpRenderTree/gtk/EventSender.cpp:
3016
3017 2009-12-20  Adam Barth  <abarth@webkit.org>
3018
3019         Reviewed by Eric Seidel.
3020
3021         [QueueStatusServer] Add a per-patch details page
3022         https://bugs.webkit.org/show_bug.cgi?id=32784
3023
3024         This is a first cut at a per-patch details page.  I'm sure we'll have
3025         to iterate.
3026
3027         * QueueStatusServer/filters/webkit_extras.py:
3028         * QueueStatusServer/handlers/patch.py: Added.
3029         * QueueStatusServer/index.yaml:
3030         * QueueStatusServer/main.py:
3031         * QueueStatusServer/model/attachment.py:
3032         * QueueStatusServer/stylesheets/dashboard.css:
3033         * QueueStatusServer/templates/dashboard.html:
3034         * QueueStatusServer/templates/patch.html: Added.
3035
3036 2009-12-20  Adam Barth  <abarth@webkit.org>
3037
3038         Reviewed by Eric Seidel.
3039
3040         Use memcache to make dashboard to fast
3041         https://bugs.webkit.org/show_bug.cgi?id=32780
3042
3043         * QueueStatusServer/app.yaml:
3044         * QueueStatusServer/handlers/dashboard.py:
3045         * QueueStatusServer/handlers/updatestatus.py:
3046         * QueueStatusServer/model/attachment.py: Added.
3047
3048 2009-12-19  Brent Fulgham  <bfulgham@webkit.org>
3049
3050         Reviewed by Adam Roben.
3051
3052         Provide an example implementation for printing under Windows.
3053         http://bugs.webkit.org/show_bug.cgi?id=32504.`
3054
3055         * WinLauncher/PrintWebUIDelegate.cpp: Added.
3056         (PrintWebUIDelegate::QueryInterface):
3057         (PrintWebUIDelegate::AddRef):
3058         (PrintWebUIDelegate::Release):
3059         (PrintWebUIDelegate::webViewPrintingMarginRect):
3060         * WinLauncher/PrintWebUIDelegate.h: Added.
3061         (PrintWebUIDelegate::PrintWebUIDelegate):
3062         (PrintWebUIDelegate::createWebViewWithRequest):
3063         (PrintWebUIDelegate::webViewShow):
3064         (PrintWebUIDelegate::webViewClose):
3065         (PrintWebUIDelegate::webViewFocus):
3066         (PrintWebUIDelegate::webViewUnfocus):
3067         (PrintWebUIDelegate::webViewFirstResponder):
3068         (PrintWebUIDelegate::makeFirstResponder):
3069         (PrintWebUIDelegate::setStatusText):
3070         (PrintWebUIDelegate::webViewStatusText):
3071         (PrintWebUIDelegate::webViewAreToolbarsVisible):
3072         (PrintWebUIDelegate::setToolbarsVisible):
3073         (PrintWebUIDelegate::webViewIsStatusBarVisible):
3074         (PrintWebUIDelegate::setStatusBarVisible):
3075         (PrintWebUIDelegate::webViewIsResizable):
3076         (PrintWebUIDelegate::setResizable):
3077         (PrintWebUIDelegate::setFrame):
3078         (PrintWebUIDelegate::webViewFrame):
3079         (PrintWebUIDelegate::setContentRect):
3080         (PrintWebUIDelegate::webViewContentRect):
3081         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage):
3082         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage):
3083         (PrintWebUIDelegate::runJavaScriptTextInputPanelWithPrompt):
3084         (PrintWebUIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3085         (PrintWebUIDelegate::runOpenPanelForFileButtonWithResultListener):
3086         (PrintWebUIDelegate::mouseDidMoveOverElement):
3087         (PrintWebUIDelegate::contextMenuItemsForElement):
3088         (PrintWebUIDelegate::validateUserInterfaceItem):
3089         (PrintWebUIDelegate::shouldPerformAction):
3090         (PrintWebUIDelegate::dragDestinationActionMaskForDraggingInfo):
3091         (PrintWebUIDelegate::willPerformDragDestinationAction):
3092         (PrintWebUIDelegate::dragSourceActionMaskForPoint):
3093         (PrintWebUIDelegate::willPerformDragSourceAction):
3094         (PrintWebUIDelegate::contextMenuItemSelected):
3095         (PrintWebUIDelegate::hasCustomMenuImplementation):
3096         (PrintWebUIDelegate::trackCustomPopupMenu):
3097         (PrintWebUIDelegate::measureCustomMenuItem):
3098         (PrintWebUIDelegate::drawCustomMenuItem):
3099         (PrintWebUIDelegate::addCustomMenuDrawingData):
3100         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
3101         (PrintWebUIDelegate::canTakeFocus):
3102         (PrintWebUIDelegate::takeFocus):
3103         (PrintWebUIDelegate::registerUndoWithTarget):
3104         (PrintWebUIDelegate::removeAllActionsWithTarget):
3105         (PrintWebUIDelegate::setActionTitle):
3106         (PrintWebUIDelegate::undo):
3107         (PrintWebUIDelegate::redo):
3108         (PrintWebUIDelegate::canUndo):
3109         (PrintWebUIDelegate::canRedo):
3110         (PrintWebUIDelegate::printFrame):
3111         (PrintWebUIDelegate::ftpDirectoryTemplatePath):
3112         (PrintWebUIDelegate::webViewHeaderHeight):
3113         (PrintWebUIDelegate::webViewFooterHeight):
3114         (PrintWebUIDelegate::drawHeaderInRect):
3115         (PrintWebUIDelegate::drawFooterInRect):
3116         (PrintWebUIDelegate::canRunModal):
3117         (PrintWebUIDelegate::createModalDialog):
3118         (PrintWebUIDelegate::runModal):
3119         (PrintWebUIDelegate::isMenuBarVisible):
3120         (PrintWebUIDelegate::setMenuBarVisible):
3121         (PrintWebUIDelegate::runDatabaseSizeLimitPrompt):
3122         (PrintWebUIDelegate::paintCustomScrollbar):
3123         (PrintWebUIDelegate::paintCustomScrollCorner):
3124         * WinLauncher/WinLauncher.cpp: Add new UI delegate for print support.
3125         (WinLauncherWebHost::updateAddressBar): check-webkit-style fixes.
3126         (WinLauncherWebHost::QueryInterface): check-webkit-style fixes.
3127         (WinLauncherWebHost::AddRef): check-webkit-style fixes.
3128         (WinLauncherWebHost::Release): check-webkit-style fixes.
3129         (resizeSubViews): check-webkit-style fixes.
3130         (_tWinMain): check-webkit-style fixes.
3131         (MyRegisterClass): check-webkit-style fixes.
3132         (InitInstance): check-webkit-style fixes.
3133         (AbortProc): New print support function.
3134         (getPrinterDC): New print support function.
3135         (initDocStruct): New print support function.
3136         (PrintView): New printing implementation.
3137         (WndProc): Add support for printing.
3138         (MyEditProc): check-webkit-style fixes.
3139         (About): check-webkit-style fixes.
3140         (loadURL): check-webkit-style fixes.
3141         * WinLauncher/WinLauncher.h:
3142         (WinLauncherWebHost::WinLauncherWebHost):
3143         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
3144         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
3145         (WinLauncherWebHost::didFailProvisionalLoadWithError):
3146         (WinLauncherWebHost::didCommitLoadForFrame):
3147         (WinLauncherWebHost::didReceiveTitle):
3148         (WinLauncherWebHost::didReceiveIcon):
3149         (WinLauncherWebHost::didFinishLoadForFrame):
3150         (WinLauncherWebHost::didFailLoadWithError):
3151         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
3152         (WinLauncherWebHost::willPerformClientRedirectToURL):
3153         (WinLauncherWebHost::didCancelClientRedirectForFrame):
3154         (WinLauncherWebHost::willCloseFrame):
3155         (WinLauncherWebHost::windowScriptObjectAvailable):
3156         * WinLauncher/WinLauncher.rc: Add menu entry for printing.
3157         * WinLauncher/WinLauncher.vcproj: Add new files.
3158         * WinLauncher/resource.h: Add menu entry for printing.
3159
3160 2009-12-19  Adam Barth  <abarth@webkit.org>
3161
3162         Unreviewed.  Tweak the CSS to make the dashboard prettier.
3163
3164         * QueueStatusServer/stylesheets/dashboard.css:
3165         * QueueStatusServer/templates/dashboard.html:
3166
3167 2009-12-19  Adam Barth  <abarth@webkit.org>
3168
3169         Reviewed by Eric Seidel.
3170
3171         QueueStatusServer needs a human readable dashboard
3172         https://bugs.webkit.org/show_bug.cgi?id=32769
3173
3174         Here is a first cut at the dashboard.  There's a lot left to do.
3175
3176         * QueueStatusServer/filters/webkit_extras.py:
3177         * QueueStatusServer/handlers/dashboard.py: Added.
3178         * QueueStatusServer/handlers/patchstatus.py:
3179         * QueueStatusServer/handlers/recentstatus.py:
3180         * QueueStatusServer/handlers/showresults.py:
3181         * QueueStatusServer/handlers/statusbubble.py:
3182         * QueueStatusServer/handlers/updatestatus.py:
3183         * QueueStatusServer/main.py:
3184         * QueueStatusServer/model/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
3185         * QueueStatusServer/model/queuestatus.py: Renamed from WebKitTools/QueueStatusServer/model.py.
3186         * QueueStatusServer/stylesheets/dashboard.css: Added.
3187         * QueueStatusServer/templates/dashboard.html: Added.
3188         * QueueStatusServer/templates/statusbubble.html: Renamed from WebKitTools/QueueStatusServer/status_bubble.html.
3189         * QueueStatusServer/templates/updatestatus.html: Renamed from WebKitTools/QueueStatusServer/update_status.html.
3190
3191 2009-12-19  Daniel Bates  <dbates@webkit.org>
3192
3193         Reviewed by Timothy Hatcher.
3194
3195         https://bugs.webkit.org/show_bug.cgi?id=32462
3196
3197         Added --inspector-frontend flag to build-webkit to copy any changes
3198         to the inspector front-end files to the built WebCore framework. This
3199         will make inspector development more consistent with the rest of
3200         WebKit development.
3201
3202         * Scripts/build-webkit:
3203         * Scripts/webkitdirs.pm:
3204
3205 2009-12-19  Adam Barth  <abarth@webkit.org>
3206
3207         Unreviewed fixes for me being terrible at python.
3208
3209         * Scripts/modules/bugzilla.py:
3210         * Scripts/run-webkit-unittests:
3211
3212 2009-12-18  Adam Barth  <abarth@webkit.org>
3213
3214         Reviewed by Eric Seidel.
3215
3216         Split QueueStatus server into modules
3217         https://bugs.webkit.org/show_bug.cgi?id=32768
3218
3219         One monolithic file is no good.
3220
3221         * QueueStatusServer/app.yaml:
3222         * QueueStatusServer/handlers/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
3223         * QueueStatusServer/handlers/patchstatus.py: Added.
3224         * QueueStatusServer/handlers/recentstatus.py: Added.
3225         * QueueStatusServer/handlers/showresults.py: Added.
3226         * QueueStatusServer/handlers/statusbubble.py: Added.
3227         * QueueStatusServer/handlers/updatestatus.py: Added.
3228         * QueueStatusServer/main.py: Added.
3229         * QueueStatusServer/model.py: Added.
3230         * QueueStatusServer/queue_status.py: Removed.
3231
3232 2009-12-18  Adam Barth  <abarth@webkit.org>
3233
3234         Rubber stamped by Eric Seidel.
3235
3236         Renamed WorkQueue to QueueEngine.  WorkQueue is not a queue.
3237
3238         * Scripts/modules/commands/queues.py:
3239         * Scripts/modules/queueengine.py: Added.
3240         * Scripts/modules/queueengine_unittest.py: Added.
3241         * Scripts/modules/stepsequence.py:
3242         * Scripts/modules/workqueue.py: Removed.
3243         * Scripts/modules/workqueue_unittest.py: Removed.
3244
3245 2009-12-18  Adam Barth  <abarth@webkit.org>
3246
3247         Reviewed by Eric Seidel.
3248
3249         Add watches for EWS
3250         https://bugs.webkit.org/show_bug.cgi?id=32767
3251
3252         dglazkov wanted to be added.
3253
3254         * Scripts/modules/bugzilla.py:
3255         * Scripts/modules/commands/early_warning_system.py:
3256         * Scripts/modules/commands/queues.py:
3257
3258 2009-12-18  Eric Seidel  <eric@webkit.org>
3259
3260         Reviewed by David Levin.
3261
3262         move bugzilla.py off of urllib2
3263         https://bugs.webkit.org/show_bug.cgi?id=32729
3264
3265         * Scripts/modules/bugzilla.py: use mechanize for all url fetching.
3266
3267 2009-12-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3268
3269         Rubber-stamped by Xan Lopez.
3270
3271         [GTK] New events (pageshow and pagehide) tests failing
3272         https://bugs.webkit.org/show_bug.cgi?id=28823
3273
3274         Original patch by Jan Michael Alonzo.
3275
3276         Disable page cache for tests.
3277
3278         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3279         (resetDefaultsToConsistentValues):
3280         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3281         (copyWebSettingKey):
3282         (LayoutTestController::overridePreference):
3283
3284 2009-12-18  Fumitoshi Ukai  <ukai@chromium.org>
3285
3286         Reviewed by David Levin.
3287
3288         Check one space before end of line comments.
3289         https://bugs.webkit.org/show_bug.cgi?id=32597
3290         
3291         Fix to check one space before end of line comments in whitespace and build/header_guard.
3292         Also fix build/header_guard to use WebKit header guard defines.
3293
3294         * Scripts/modules/cpp_style.py:
3295         * Scripts/modules/cpp_style_unittest.py:
3296
3297 2009-12-17  Sam Weinig  <sam@webkit.org>
3298
3299         Reviewed by Mark Rowe.
3300
3301         Add BUILDING_ON_SNOW_LEOPARD #define.
3302
3303         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3304
3305 2009-12-17  Yuzo Fujishima  <yuzo@google.com>
3306
3307         Reviewed by Alexey Proskuryakov.
3308
3309         Update pywebsocket to 0.4.5 and make handshake checking stricter
3310         https://bugs.webkit.org/show_bug.cgi?id=32249
3311
3312         * Scripts/run-webkit-tests:
3313         * pywebsocket/mod_pywebsocket/handshake.py:
3314         * pywebsocket/mod_pywebsocket/memorizingfile.py: Added.
3315         * pywebsocket/mod_pywebsocket/standalone.py:
3316         * pywebsocket/setup.py:
3317         * pywebsocket/test/test_handshake.py:
3318         * pywebsocket/test/test_memorizingfile.py: Added.
3319
3320 2009-12-17  Eric Seidel  <eric@webkit.org>
3321
3322         Reviewed by Adam Barth.
3323
3324         Command.show_in_main_help should default to False
3325         https://bugs.webkit.org/show_bug.cgi?id=32686
3326
3327         * Scripts/modules/commands/download.py:
3328         * Scripts/modules/commands/queries.py:
3329         * Scripts/modules/commands/queues.py:
3330         * Scripts/modules/commands/upload.py:
3331         * Scripts/modules/multicommandtool.py:
3332
3333 2009-12-17  Alejandro G. Castro  <alex@igalia.com>
3334
3335         Reviewed by Eric Seidel.
3336
3337         Added the key WebKitEnableCaretBrowsing to the
3338         layoutTestController.overridePreference in order to activate caret
3339         browsing.
3340         https://bugs.webkit.org/show_bug.cgi?id=32612
3341
3342         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added the reset value of
3343         the setting.
3344         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Inserted the new
3345         key in the keytable.
3346
3347 2009-12-17  Chris Fleizach  <cfleizach@apple.com>
3348
3349         Reviewed by David Kilzer.
3350
3351         AX: DRT needs to support URL for accessibility
3352         https://bugs.webkit.org/show_bug.cgi?id=32666
3353
3354         * DumpRenderTree/AccessibilityUIElement.cpp:
3355         (getURLCallback):
3356         (AccessibilityUIElement::getJSClass):
3357         * DumpRenderTree/AccessibilityUIElement.h:
3358         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3359         (AccessibilityUIElement::url):
3360         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3361         (AccessibilityUIElement::url):
3362         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3363         (AccessibilityUIElement::url):
3364
3365 2009-12-17  Philippe Normand  <pnormand@igalia.com>
3366
3367         Unreviewed; added myself to committers
3368
3369         * Scripts/modules/committers.py:
3370
3371 2009-12-17  Benjamin Otte  <otte@gnome.org>
3372
3373         Unreviewed; added myself to committers
3374
3375         * Scripts/modules/committers.py:
3376
3377 2009-12-17  Adam Barth  <abarth@webkit.org>
3378
3379         Rubber stamp by Seidel.
3380
3381         Clean up exception handling in WorkQueue.  Basically, a bunch of the
3382         delegate messages can throw exceptions because of network errors.  We
3383         want the queues to keep on ticking instead of erroring out.  That means
3384         we want to catch generic exceptions and continue looping.
3385
3386         Also, cleaned up the exception handling in the EWS to properly log
3387         failures.
3388
3389         * Scripts/modules/commands/early_warning_system.py:
3390         * Scripts/modules/commands/queues.py:
3391         * Scripts/modules/workqueue.py:
3392
3393 2009-12-16  Adam Barth  <abarth@webkit.org>
3394
3395         Reviewed by Eric Seidel.
3396
3397         [bzt] Make UpdateStep quiet
3398         https://bugs.webkit.org/show_bug.cgi?id=32599
3399
3400         * Scripts/modules/buildsteps.py:
3401         * Scripts/modules/buildsteps_unittest.py:
3402
3403 2009-12-16  Evan Martin  <evan@chromium.org>
3404
3405         Reviewed by Adam Barth.
3406
3407         Add Gtk to the early warning system WebKit port list.
3408
3409         https://bugs.webkit.org/show_bug.cgi?id=32629
3410
3411         * Scripts/modules/commands/early_warning_system.py:
3412         * Scripts/modules/webkitport.py:
3413         * Scripts/modules/webkitport_unittest.py:
3414
3415 2009-12-16  Eric Seidel  <eric@webkit.org>
3416
3417         Reviewed by Adam Barth.
3418
3419         post-diff is failing with exception under guess_reviewer_from_bug
3420         https://bugs.webkit.org/show_bug.cgi?id=32642
3421
3422         Also refactor output capturing code into
3423         OutputCapture.assert_outputs to share more code between tests.
3424
3425         * Scripts/modules/buildsteps.py:
3426          - Add the missing include.
3427          - Give guess_reviewer_from_bug a private underscore.
3428         * Scripts/modules/buildsteps_unittest.py: Added.
3429          - Test to make sure _guess_reviewer_from_bug works as expected.
3430         * Scripts/modules/commands/commandtest.py:
3431          - Custom code is now obsoleted by OutputCapture.assert_outputs
3432         * Scripts/modules/commands/queues_unittest.py:
3433          - ditto
3434         * Scripts/modules/credentials_unittest.py:
3435          - ditto
3436         * Scripts/modules/mock_bugzillatool.py:
3437          - fetch_reviewed_patches_from_bug can never return None
3438         * Scripts/modules/multicommandtool_unittest.py:
3439          - Custom code is now obsoleted by OutputCapture.assert_outputs
3440         * Scripts/modules/outputcapture.py:
3441          - Add assert_outputs to share more code between tests.
3442         * Scripts/run-webkit-unittests:
3443          - Add buildsteps_unittest.py
3444
3445 2009-12-16  Adam Barth  <abarth@webkit.org>
3446
3447         Unreviewed.  Added a default argument to _update_status so that callers
3448         don't have to explictly pass None when they don't have a patch object.
3449
3450         * Scripts/modules/commands/queues.py:
3451
3452 2009-12-16  Kent Tamura  <tkent@chromium.org>
3453
3454         Reviewed by David Levin.
3455
3456         check-webkit-style supports for TAB check against text files.
3457         https://bugs.webkit.org/show_bug.cgi?id=32538
3458
3459         * Scripts/check-webkit-style:
3460           Move process_patch() to style.py.
3461         * Scripts/modules/cpp_style.py:
3462           Add can_handle().
3463         * Scripts/modules/cpp_style_unittest.py:
3464           Add tests for can_handle().
3465         * Scripts/modules/style.py:
3466           Added. This is a front-end of cpp_style and text_style. It dispatches
3467           files to an appropriate linter.
3468         * Scripts/modules/text_style.py:
3469           Added. This is a linter module for generic text files. It supports
3470           only for TAB checking at this moment.
3471         * Scripts/modules/text_style_unittest.py:
3472           Added. Tests for text_style.py.
3473         * Scripts/run-webkit-unittests:
3474           Add text_style_unittest.
3475
3476 2009-12-16  Eric Seidel  <eric@webkit.org>
3477
3478         Reviewed by David Levin.
3479
3480         bugzilla-tool should not require users to install mechanize
3481         https://bugs.webkit.org/show_bug.cgi?id=32635
3482
3483         Centralize our import logic.
3484
3485         * Scripts/modules/bugzilla.py: use webkit_mechanize
3486         * Scripts/modules/statusbot.py: use webkit_mechanize
3487         * Scripts/modules/webkit_mechanize.py: Added.
3488
3489 2009-12-16  Eric Seidel  <eric@webkit.org>
3490
3491         Reviewed by Adam Barth.
3492
3493         Generalize commit-queue recent status page for all queues
3494         https://bugs.webkit.org/show_bug.cgi?id=32633
3495
3496         * QueueStatusServer/index.html:
3497          - Generalize to support other queues.
3498         * QueueStatusServer/queue_status.py:
3499          - Generalize MainPage to support other queues.
3500
3501 2009-12-16  Evan Martin  <evan@chromium.org>
3502
3503         Reviewed by Adam Barth.
3504
3505         Early warning system server should display output as UTF-8.
3506
3507         https://bugs.webkit.org/show_bug.cgi?id=32625
3508
3509         * QueueStatusServer/queue_status.py:
3510
3511 2009-12-16  Adam Barth  <abarth@webkit.org>
3512
3513         Reviewed by Eric Seidel.
3514
3515         [bzt] Add error handling to the early warning system
3516         https://bugs.webkit.org/show_bug.cgi?id=32594
3517
3518         This should be the last step in making the EWS operational.  When we
3519         have a build error, we post the log to QueueStatusServer and add a link
3520         to the bug.
3521
3522         * Scripts/modules/commands/early_warning_system.py:
3523         * Scripts/modules/commands/queues.py:
3524         * Scripts/modules/executive.py:
3525
3526 2009-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
3527
3528         Reviewed by Holger Freyther.
3529
3530         Fix crash with tests that use custom font faces.
3531
3532         https://bugs.webkit.org/show_bug.cgi?id=32600
3533
3534         In the DRT we call QApplication::removeAllApplicationFonts(), to make sure
3535         that custom font faces between tests don't influence each other. Calling this
3536         function in Qt however also invalidates all existing handles with QFontDatabase.
3537
3538         In order to make sure that WebCore also drops these handles we call QWebSettings::clearMemoryCaches(),
3539         which implies a call to WebCore::FontCache::fontCache()->invalidate().
3540
3541         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3542         (WebCore::DumpRenderTree::open):
3543
3544 2009-12-16  Andreas Kling  <andreas.kling@nokia.com>
3545
3546         Reviewed by Simon Hausmann.
3547
3548         [Qt] Maintain button state between mouse events.
3549
3550         This allows eventSender to generate drag events.
3551
3552         https://bugs.webkit.org/show_bug.cgi?id=32601
3553
3554         * DumpRenderTree/qt/EventSenderQt.cpp:
3555         (EventSender::mouseDown):
3556         (EventSender::mouseUp):
3557         (EventSender::mouseMoveTo):
3558         * DumpRenderTree/qt/EventSenderQt.h:
3559
3560 2009-12-15  Chris Jerdonek  <chris.jerdonek@gmail.com>
3561
3562         Reviewed by David Levin.
3563
3564         Code clean-up in check-webkit-style as described below.
3565         The only functional changes are minor improvements to the
3566         script's help output.
3567         
3568         https://bugs.webkit.org/show_bug.cgi?id=32487
3569
3570         * Scripts/check-webkit-style:
3571           - Added the module docstring from cpp_style.py.
3572           - Improved wording of the --help output and added some of the
3573             default values as substitution strings.
3574           - Called cpp_style.exit_with_usage instead of sys.stderr.write
3575             in main function.
3576           - Made changes caused by changes to cpp_style.py.
3577
3578         * Scripts/modules/cpp_style.py:
3579           - Removed module docstring, as well as redundant _USAGE string
3580             and main() function obsoleted by check-webkit-style.
3581           - Moved specification of default script values from within a
3582             function definition to global variables.
3583           - Moved the default webkit filter rules to be near the other
3584             global variables.
3585           - Renamed "FILTER" global variables to "FILTER_RULES" to
3586             establish unambiguous terminology.
3587           - Renamed _ERROR_CATEGORIES to _STYLE_CATEGORIES.
3588           - Changed _STYLE_CATEGORIES from a string to a list.
3589           - Added default webkit filter rules to --filter= output.
3590           - Renamed "print_" methods to "exit_with_" since they exist
3591             and added a temporary display_help parameter.
3592           - Added a temporary display_help parameter to parse_arguments.
3593
3594         * Scripts/modules/cpp_style_unittest.py:
3595           - Made changes caused by changes to cpp_style.py.
3596           - Lower-cased ErrorCollector's ERROR_CATEGORIES instance 
3597             variables since they are not global.
3598
3599 2009-12-15  Adam Barth  <abarth@webkit.org>
3600
3601         Unreviewed fix for the style-queue.
3602         Typo: _updates_status -> _update_status
3603
3604         We need to improve our testing infrastructure for the queues.
3605
3606         * Scripts/modules/commands/queues.py:
3607
3608 2009-12-15  Adam Barth  <abarth@webkit.org>
3609