[wx] Build fixes for recent changes.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
2
3         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
4         it causes the process to hang on the gitorious repo.
5
6         * wx/packaging/build-mac-installer.py:
7         * wx/packaging/build-win-installer.py:
8
9 2010-09-28  Adam Roben  <aroben@apple.com>
10
11         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
12         called
13
14         Reviewed by Anders Carlsson.
15
16         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
17         Full-page Adobe Reader does not paint until window is resized
18
19         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
20         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
21         this level.
22
23         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
24         NPP_SetWindow.
25
26         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
27         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
28         the plugin's HWND has a non-zero size and that its size/position
29         matches that specified in the NPWindow.
30
31         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
32         (NPP_SetWindow): Call through to the PluginTest.
33
34         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
35         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
36         the files as it saw fit.
37
38 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
39
40         Reviewed by Andreas Kling.
41
42         [Qt] Remove support for Qt 4.5
43         https://bugs.webkit.org/show_bug.cgi?id=46718
44
45         Remove the code for versions of Qt prior to 4.6.
46
47         * DumpRenderTree/qt/EventSenderQt.cpp:
48         (EventSender::addTouchPoint):
49         (EventSender::updateTouchPoint):
50         (EventSender::setTouchModifier):
51         (EventSender::touchStart):
52         (EventSender::touchMove):
53         (EventSender::touchEnd):
54         (EventSender::clearTouchPoints):
55         (EventSender::releaseTouchPoint):
56         (EventSender::sendTouchEvent):
57         * DumpRenderTree/qt/EventSenderQt.h:
58         * DumpRenderTree/qt/TextInputControllerQt.cpp:
59         (TextInputController::setMarkedText):
60         * QtTestBrowser/launcherwindow.cpp:
61         (LauncherWindow::LauncherWindow):
62         (LauncherWindow::initializeView):
63         (LauncherWindow::createChrome):
64         (LauncherWindow::sendTouchEvent):
65         (LauncherWindow::eventFilter):
66         (LauncherWindow::applyZoom):
67         (LauncherWindow::setTouchMocking):
68         * QtTestBrowser/launcherwindow.h:
69         * QtTestBrowser/utils.cpp:
70         (urlFromUserInput):
71         * QtTestBrowser/webview.cpp:
72         (WebViewGraphicsBased::animatedFlip):
73         (WebViewGraphicsBased::animatedYFlip):
74         * QtTestBrowser/webview.h:
75         (WebViewGraphicsBased::setYRotation):
76
77 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
78
79         Reviewed by Andreas Kling.
80
81         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
82         which should point to wcecompat installation. Needs wcecompat
83         library from http://github.com/mauricek/wcecompat .
84
85         * DumpRenderTree/qt/DumpRenderTree.pro:
86         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
87         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
88
89 2010-09-28  Daniel Bates  <dbates@rim.com>
90
91         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
92         <https://bugs.webkit.org/show_bug.cgi?id=39136>
93
94         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
95         In particular, this change caused Sheriffbot to raise an exception when
96         trying to parse the bug id on a bug page. We need to look into this
97         some more.
98
99         * Scripts/webkitpy/common/net/bugzilla.py:
100         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
101         * Scripts/webkitpy/tool/bot/sheriff.py:
102         * Scripts/webkitpy/tool/commands/download.py:
103         * Scripts/webkitpy/tool/commands/queues.py:
104         * Scripts/webkitpy/tool/commands/upload.py:
105         * Scripts/webkitpy/tool/steps/closebug.py:
106         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
107         * Scripts/webkitpy/tool/steps/preparechangelog.py:
108         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
109
110 2010-09-28  Adam Barth  <abarth@webkit.org>
111
112         Reviewed by Eric Seidel.
113
114         Move RegressionWindow further up the dependency chain
115         https://bugs.webkit.org/show_bug.cgi?id=46698
116
117         Baby steps towards pushing this information into bug posts.
118
119         * Scripts/webkitpy/common/net/buildbot.py:
120         * Scripts/webkitpy/common/net/buildbot_unittest.py:
121         * Scripts/webkitpy/common/net/regressionwindow.py:
122         * Scripts/webkitpy/tool/commands/queries.py:
123
124 2010-09-27  Daniel Bates  <dbates@rim.com>
125
126         Reviewed by Adam Barth.
127
128         sheriffbot can't roll out security patches
129         https://bugs.webkit.org/show_bug.cgi?id=39136
130
131         Make SheriffBot determine if it's authorized to view a bug
132         whose change it wants to rollout before it tries to rollout
133         the change.
134
135         Moreover, make both webkit-patch and Sheriffbot provide human-
136         readable error messages when they are not authorized to view
137         a bug and when a bug number is invalid.
138
139         Currently, Sheriffbot does not parse Bugzilla bugs for
140         <bug error="...">, which indicates an error when retrieving
141         a bug. In particular, error="NotPermitted" if a person (or bot)
142         is not authorized to view a bug. For such error="NotPermitted" bugs,
143         Sheriffbot raises an exception when parsing the bug report and
144         this exception does not explicitly indicate Sheriffbot's lack
145         of authorization. Instead, Sheriffbot should explicitly check
146         for the presence <bug error="..."> before operating on a bug
147         and error with a human-readable message if it's not permitted
148         to view it.
149
150         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
151         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
152           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
153           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
154           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
155         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
156         * Scripts/webkitpy/tool/commands/download.py: Ditto.
157         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
158         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
159         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
160         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
161         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
162         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
163
164 2010-09-27  Adam Barth  <abarth@webkit.org>
165
166         Reviewed by Eric Seidel.
167
168         Expose more more failure information from Buildbot to SheriffBot
169         https://bugs.webkit.org/show_bug.cgi?id=46697
170
171         This patch moves the information about what tests failured closer to
172         SheriffBot.  There are still a couple more patches to go before
173         SheriffBot can post this information to bugs, but this is a step in
174         that direction.  Yay for unit tests, which caught some bugs in earlier
175         versions of this patch.
176
177         * Scripts/webkitpy/common/net/buildbot.py:
178         * Scripts/webkitpy/common/net/buildbot_unittest.py:
179         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
180         * Scripts/webkitpy/tool/commands/queries.py:
181
182 2010-09-27  Eric Seidel  <eric@webkit.org>
183
184         Unreviewed.  Fixing 500 error seen in the status server.
185
186         It turns out that a = b = []; b.append(1); then a[0] will be 1!
187         This should have been obvious to me, I guess, but it was not what I was expecting.
188
189         * QueueStatusServer/model/activeworkitems.py:
190
191 2010-09-27  Adam Barth  <abarth@webkit.org>
192
193         Reviewed by Eric Seidel.
194
195         commit-queue should reject patches that fail to land
196         https://bugs.webkit.org/show_bug.cgi?id=46694
197
198         This can happen, for example, if there's no reviewer.  Without this
199         patch, we'll keep retrying the patch.
200
201         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
202         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
203
204 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
205
206         Rubber-stamped by Adele Peterson.
207
208         Add a harness for running the CSS 2.1 test suite.
209         
210         This harness assumes that you've got a local a copy of the suite
211         adjacent to the 'harness' directory.
212         
213         The harness lets you go through the tests in chapter order,
214         denoting pass/fail/skipped for each test.
215         
216         It uses a client-side database to store the results of testing.
217
218         * CSSTestSuiteHarness/harness/harness.css: Added.
219         * CSSTestSuiteHarness/harness/harness.html: Added.
220         * CSSTestSuiteHarness/harness/harness.js: Added.
221
222 2010-09-27  Eric Seidel  <eric@webkit.org>
223
224         Reviewed by Adam Barth.
225
226         Patch locks should expire if a patch is marked for retry
227         https://bugs.webkit.org/show_bug.cgi?id=46682
228
229         This was part Adam's original CommitQueueTask design,
230         but support for it was missing from the server.
231         I added the support, but triggering lock-release based on this
232         special "retry" status feels a bit strange so I added a FIXME.
233
234         I also changed the text in queuestatus.html to say "Lock Acquired"
235         since "Last Activity" isn't really true.  We only update the lock
236         date when the patch is started, not on every status update.
237
238         I also noticed an exception in next-patch, which I fixed by re-writing
239         the unzip logic in activeworkitems.py again.
240
241         * QueueStatusServer/handlers/updatestatus.py:
242         * QueueStatusServer/model/activeworkitems.py:
243         * QueueStatusServer/templates/queuestatus.html:
244
245 2010-09-27  Tony Chang  <tony@chromium.org>
246
247         Reviewed by David Levin.
248
249         [chromium] fix a warning when compiling DRT on 32-bit linux
250         https://bugs.webkit.org/show_bug.cgi?id=46641
251
252         * DumpRenderTree/chromium/TestEventPrinter.cpp:
253         (DRTPrinter::handleImage):
254
255 2010-09-27  Eric Seidel  <eric@webkit.org>
256
257         Reviewed by Adam Barth.
258
259         queue-status should report when the patch was last locked to a queue
260         https://bugs.webkit.org/show_bug.cgi?id=46674
261
262         This isn't necessarily the best way to expose this information
263         but having this accessible via the web interface is very
264         useful until we come up with a nicer way to display this.
265
266         I also cleaned up the code in activeworkitems.py a little
267         to use list comprehensions and to have the code work with
268         pairs instead of two lists at once.  Eventually I think those
269         item/time pairs need to be their own little helper class.
270
271         * QueueStatusServer/handlers/queuestatus.py:
272         * QueueStatusServer/model/activeworkitems.py:
273         * QueueStatusServer/templates/queuestatus.html:
274
275 2010-09-27  Tony Chang  <tony@chromium.org>
276
277         Reviewed by David Levin.
278
279         [chromium] fix detection of missing fonts on DRT
280         https://bugs.webkit.org/show_bug.cgi?id=46651
281
282         * DumpRenderTree/chromium/TestShellGtk.cpp:
283         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
284
285 2010-09-27  Tony Chang  <tony@chromium.org>
286
287         Reviewed by Dimitri Glazkov.
288
289         add webkit unit tests to the chromium testers
290         https://bugs.webkit.org/show_bug.cgi?id=46669
291
292         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
293         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
294
295 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
296
297         Unreviewed.
298
299         Adding myself to the committers list.
300
301         * Scripts/webkitpy/common/config/committers.py:
302
303 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
304
305         Reviewed by Eric Seidel.
306
307         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
308         https://bugs.webkit.org/show_bug.cgi?id=46634
309         
310         Use OutputCapture to prevent console spam (and also check for expected
311         output).
312
313         * Scripts/webkitpy/common/system/user_unittest.py:
314
315 2010-09-27  Eric Seidel  <eric@webkit.org>
316
317         Reviewed by James Robinson.
318
319         start-commit-queue should abort any rebases in progress
320         https://bugs.webkit.org/show_bug.cgi?id=46640
321
322         webkit-patch commit-queue would do this itself, but this just
323         helps ensure that the commit-queue script is properly updated
324         before we run it (in the case where a previous rebase is in
325         progress the git svn rebase would not work before we run the
326         commit-queue).
327
328         * EWSTools/start-commit-queue.sh:
329
330 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
331
332         Reviewed by Gustavo Noronha Silva.
333
334         [GTK] Clean up the DRT fonts.conf and switch to Liberation
335         https://bugs.webkit.org/show_bug.cgi?id=46038
336
337         Switch to Liberation fonts for GTK+ layout tests. This will make our
338         test results metric-compatible with many Windows/Chromium results. It
339         also simplifies the fonts.conf that we load and prepares the way for
340         fixing many font bugs.
341
342         * DumpRenderTree/gtk/DumpRenderTree.cpp:
343         (initializeFonts): Initialize a known list of fonts instead of loading
344         every font in the WEBKIT_TESTFONTS directory.
345         * DumpRenderTree/gtk/fonts.conf: Removed.
346         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
347         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
348         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
349         we can load both fonts.conf and AHEM____.TTF from this location.
350         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
351         it is no longer used.
352
353 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
354
355         Reviewed by Ojan Vafai.
356
357         new-run-webkit-httpd fails if Perl is not installed
358         https://bugs.webkit.org/show_bug.cgi?id=46602
359         
360         Make Port._read_configuration catch all exceptions, since trying to run
361         perl (because of _webkit_build_directory) when it's not installed throws
362         a WindowsError or OSError, not an IOError (this became an issue after 
363         r68268, since ChromiumPort ends up calling Port.default_configuration in
364         its constructor, which means that we're ending up on this codepath in
365         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
366         new-run-webkit-httpd).
367
368         * Scripts/webkitpy/layout_tests/port/base.py:
369         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
370
371 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
372
373         Reviewed by Antonio Gomes.
374
375         [EFL] Add setting API to set a local storage database path.
376         https://bugs.webkit.org/show_bug.cgi?id=45446
377
378         Add a setting API to set local storage database path.
379
380         * EWebLauncher/main.c:
381         (on_key_down):
382         (browserCreate):
383         (main):
384
385 2010-09-26  Sam Weinig  <sam@webkit.org>
386
387         Reviewed by Anders Carlsson.
388
389         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
390         https://bugs.webkit.org/show_bug.cgi?id=46587
391
392         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
393
394 2010-09-26  Antonio Gomes  <agomes@rim.com>
395
396         Reviewed by Kenneth Rohde Christiansen.
397
398         DRT/Mac nodesFromRect support
399
400         [Mac][DRT] Implement LayoutTestController::nodesFromRect
401         https://bugs.webkit.org/show_bug.cgi?id=46580
402
403         Implements LayoutTestController::nodesFromRect for Mac DRT, and
404         adding stubs for GTK+ and Windows.
405
406         * DumpRenderTree/LayoutTestController.cpp:
407         (nodesFromRectCallback):
408         (LayoutTestController::staticFunctions):
409         * DumpRenderTree/LayoutTestController.h:
410         (LayoutTestController::LayoutTestController::nodesFromRect):
411         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
412         (LayoutTestController::nodesFromRect):
413
414 2010-09-25  Nicolas Weber  <thakis@chromium.org>
415
416         Reviewed by Adam Barth.
417
418         https://bugs.webkit.org/show_bug.cgi?id=46555
419         Fix typo in prepare-ChangeLog's help output.
420
421         * Scripts/prepare-ChangeLog:
422
423 2010-09-24  Sam Weinig  <sam@webkit.org>
424
425         Reviewed by Darin Adler.
426
427         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
428         <rdar://problem/8359279>
429         https://bugs.webkit.org/show_bug.cgi?id=46546
430
431         * MiniBrowser/mac/BrowserWindowController.m:
432         (mouseDidMoveOverElement):
433         (-[BrowserWindowController awakeFromNib]):
434         * MiniBrowser/win/BrowserView.cpp:
435         (mouseDidMoveOverElement):
436         (BrowserView::create):
437         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
438         (WTR::InjectedBundlePage::InjectedBundlePage):
439         * WebKitTestRunner/TestController.cpp:
440         (WTR::createOtherPage):
441         (WTR::TestController::initialize):
442
443 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
444
445         Reviewed by Adam Barth.
446
447         Allow rebaselines for webkit-patch rebaseline to be chosen
448         https://bugs.webkit.org/show_bug.cgi?id=46407
449         
450         Instead of always rebaselining all failing tests, allow a subset to be
451         chosen.
452
453         * Scripts/webkitpy/common/system/user.py:
454         * Scripts/webkitpy/tool/commands/rebaseline.py:
455
456 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
457
458         Reviewed by Tony Chang.
459
460         [chromium] Implement TextInputController::firstRectForCharacterRange
461         https://bugs.webkit.org/show_bug.cgi?id=38100
462
463         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
464         No new tests are added since we need to implement the same feature in chromium side
465         in order to enable any tests that uses this function.
466
467         * DumpRenderTree/chromium/TextInputController.cpp:
468         (TextInputController::firstRectForCharacterRange): Added.
469
470 2010-09-24  Adam Barth  <abarth@webkit.org>
471
472         Reviewed by Eric Seidel.
473
474         commit-queue reports land failures as "PASS"
475         https://bugs.webkit.org/show_bug.cgi?id=46530
476
477         We were ignoring the return value of land instead of passing it back to
478         CommitQueue.  Of course, this was the one case I forgot to test!
479
480         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
481         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
482
483 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
484
485         Reviewed by Eric Seidel.
486
487         new-run-webkit-tests prints out nothing when build-dumprendertree fails
488         https://bugs.webkit.org/show_bug.cgi?id=37563
489
490         Print error message when build-dumprendertree fails.
491
492         * Scripts/webkitpy/layout_tests/port/webkit.py:
493         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
494
495 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
496
497         Reviewed by Tony Chang.
498
499         NRWT doesn't respect config set with set-webkit-configuration
500         https://bugs.webkit.org/show_bug.cgi?id=46278
501         
502         Use Port.default_configuration() instead of hardcoding Release in
503         ChromiumPort configuration initialization, so that we still inherit the
504         configuration set by set-webkit-configuration.
505
506         * Scripts/webkitpy/layout_tests/port/chromium.py:
507         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
508
509 2010-09-24  Chang Shu  <chang.shu@nokia.com>
510
511         Reviewed by Csaba Osztrogonác.
512
513         [Qt] Fix the code to check file existence.
514         https://bugs.webkit.org/show_bug.cgi?id=46465
515
516         * QtTestBrowser/main.cpp:
517         (main):
518
519 2010-09-23  Tony Chang  <tony@chromium.org>
520
521         Unreviewed, rolling out r68232.
522         http://trac.webkit.org/changeset/68232
523
524         Broken NRWT on the canary bots.
525
526         * Scripts/webkitpy/layout_tests/port/chromium.py:
527
528 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
529
530         Unreviewed, build fix.
531
532         r68008 broke new-run-webkit-tests in that the chromium ports no
533         longer respect set-webkit-configuration. The correct fix for this
534         is being pursued in bug 46278 (along with a bunch of unit tests),
535         but in the meantime I'm reverting the particular lines that broke
536         things. This was tested by hand.
537
538         * Scripts/webkitpy/layout_tests/port/chromium.py:
539
540 2010-09-23  Sam Weinig  <sam@webkit.org>
541
542         Reviewed by Anders Carlsson.
543
544         WebKit2 API: Need way to know when a frame is removed from the hierarchy
545         <rdar://problem/8414062>
546         https://bugs.webkit.org/show_bug.cgi?id=46432
547
548         * MiniBrowser/mac/BrowserWindowController.m:
549         (didRemoveFrameFromHierarchy):
550         (-[BrowserWindowController awakeFromNib]):
551         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
552         (WTR::InjectedBundlePage::InjectedBundlePage):
553         * WebKitTestRunner/TestController.cpp:
554         (WTR::TestController::initialize):
555
556 2010-09-23  Tony Chang  <tony@chromium.org>
557
558         Reviewed by Dimitri Glazkov.
559
560         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
561         https://bugs.webkit.org/show_bug.cgi?id=46426
562
563         * DumpRenderTree/chromium/LayoutTestController.cpp:
564         (LayoutTestController::LayoutTestController):
565         (LayoutTestController::sampleSVGAnimationForElementAtTime):
566         * DumpRenderTree/chromium/LayoutTestController.h:
567
568 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
569
570         Reviewed by Nate Chapin.
571
572         [GTK] r68199 introduced two test failures
573         https://bugs.webkit.org/show_bug.cgi?id=46424
574
575         Fix a regression handling preference overrides that are attached to boolean properties.
576
577         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
578         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
579         so we must check for that when converting a string to a boolean.
580
581 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
582
583         Reviewed by David Levin.
584
585         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
586         https://bugs.webkit.org/show_bug.cgi?id=46406
587
588         This breaks when the method is called with specified size of data (image data), and the
589         buffer hasn't yet reached this size.
590
591         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
592           index larger than 0.
593
594 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
595
596         Reviewed by Nate Chapin.
597
598         [GTK] Some tests from r68174 fail on the GTK+ bots
599         https://bugs.webkit.org/show_bug.cgi?id=46396
600
601         Simplify LayoutTestController::overridePreference to make it easier for
602         people unfamiliar with the code to keep the list of preferences up to date.
603         Add the conversion for enable-hyperlink-auditing.
604
605         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
606         (LayoutTestController::overridePreference): Use a simple if-else block to determine
607         out the property name for overrridePreference. Also simplify the logic for setting
608         string properties. Add the conversion for enable-hyperlink-auditing.
609
610 2010-09-23  Tony Chang  <tony@chromium.org>
611
612         Reviewed by David Levin.
613
614         [chromium] add caretBrowsingEnabled to WebSettings and DRT
615         https://bugs.webkit.org/show_bug.cgi?id=46388
616
617         * DumpRenderTree/chromium/LayoutTestController.cpp:
618         (LayoutTestController::overridePreference):
619         * DumpRenderTree/chromium/WebPreferences.cpp:
620         (WebPreferences::reset):
621         (WebPreferences::applyTo):
622         * DumpRenderTree/chromium/WebPreferences.h:
623
624 2010-09-23  Nate Chapin  <japhet@chromium.org>
625
626         Reviewed by Darin Fisher.
627
628         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
629         https://bugs.webkit.org/show_bug.cgi?id=30458
630
631         * DumpRenderTree/chromium/LayoutTestController.cpp:
632         (LayoutTestController::overridePreference):
633         * DumpRenderTree/chromium/WebPreferences.cpp:
634         (WebPreferences::reset):
635         (WebPreferences::applyTo):
636         * DumpRenderTree/chromium/WebPreferences.h:
637         * DumpRenderTree/gtk/DumpRenderTree.cpp:
638         (resetDefaultsToConsistentValues):
639         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
640         (LayoutTestController::overridePreference):
641
642 2010-09-21  Stephen White  <senorblanco@chromium.org>
643
644         Reviewed by David Levin.
645
646         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
647         https://bugs.webkit.org/show_bug.cgi?id=46208
648
649         This flag allows the layout tests to be run with or without accelerated
650         2D canvas rendering.
651
652         * DumpRenderTree/chromium/DumpRenderTree.cpp:
653         (main):
654         Declare the new flag string, and check for it on startup.
655         * DumpRenderTree/chromium/TestShell.cpp:
656         (TestShell::TestShell):
657         Add a boolean for the new flag, in order to preserve its value over
658         preferences reset.
659         (TestShell::resetWebSettings):
660         Set the new flag to the stored value on reset.
661         * DumpRenderTree/chromium/TestShell.h:
662         (TestShell::setAccelerated2dCanvasEnabled):
663         Add an accessor for the new flag.
664         * DumpRenderTree/chromium/WebPreferences.cpp:
665         (WebPreferences::reset):
666         Initialize the new flag to false.
667         (WebPreferences::applyTo):
668         Copy the flag's value to the WebSettings.
669         * DumpRenderTree/chromium/WebPreferences.h:
670         Add the new flag.
671
672 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
673
674         Reviewed by Simon Hausmann.
675
676         [Qt] Refactor QtWebKitPlatformPlugin interface
677
678         Make it easier to keep source-compability for the
679         QtWebKitPlatformPlugin interface, and run qmake
680         on the example (but not build) for convenience. 
681
682         https://bugs.webkit.org/show_bug.cgi?id=46345
683
684         * Scripts/webkitdirs.pm:
685
686 2010-09-23  Adam Barth  <abarth@webkit.org>
687
688         Reviewed by Eric Seidel.
689
690         Tweak some status messages that Eric thought were confusing
691         https://bugs.webkit.org/show_bug.cgi?id=46342
692
693         * Scripts/webkitpy/tool/commands/queues.py:
694         * Scripts/webkitpy/tool/commands/queues_unittest.py:
695
696 2010-09-22  Adam Barth  <abarth@webkit.org>
697
698         Reviewed by Eric Seidel.
699
700         Fix comm-queue typo
701         https://bugs.webkit.org/show_bug.cgi?id=46339
702
703         We were missing a "self".  The real problem is that we didn't have an
704         integration test for the failure case.
705
706         * Scripts/webkitpy/tool/commands/queues.py:
707         * Scripts/webkitpy/tool/commands/queues_unittest.py:
708
709 2010-09-22  Adam Barth  <abarth@webkit.org>
710
711         Reviewed by Eric Seidel.
712
713         commit-queue should log more detailed messages to the QueueStatusServer
714         https://bugs.webkit.org/show_bug.cgi?id=46333
715
716         When I created CommitQueueTask, I removed most of the previous logging.
717         This patch adds back more detailed logging so folks can see their patch
718         progress through the queue.
719
720         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
721         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
722         * Scripts/webkitpy/tool/commands/queues.py:
723         * Scripts/webkitpy/tool/commands/queues_unittest.py:
724
725 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
726
727         Reviewed by Darin Fisher.
728
729         [Chromium] User style layout tests don't pass on Chromium
730         https://bugs.webkit.org/show_bug.cgi?id=46069
731
732         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
733         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
734         behavior from other ports.
735
736         * DumpRenderTree/chromium/LayoutTestController.cpp:
737         (LayoutTestController::addUserStyleSheet):
738
739 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
740
741         Reviewed by Martin Robinson.
742
743         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
744         https://bugs.webkit.org/show_bug.cgi?id=46303.
745
746         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
747         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
748         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
749         property sheet.
750         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
751         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
752         appropriate property sheet for the build types.
753         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
754         configuration to use appropriate property sheet for CoreFoundation
755         and CFLite-style builds.
756
757 2010-09-22  Adam Barth  <abarth@webkit.org>
758
759         Reviewed by Eric Seidel.
760
761         Optimize commit-queue performance for green trees
762         https://bugs.webkit.org/show_bug.cgi?id=46254
763
764         This patch redesigns the controller logic for the commit-queue.  In the
765         new design, the controller exercises much finer-grained control over
766         the landing process.  In particular:
767
768         - Patches that fail to apply now get rejected almost immediately.
769         - Patches that fail to build get rejects after two builds (instead of
770           three builds and one test run).
771         - Patches that run into a flaky test now get accepted after one build
772           and two test runs instead of three full build-and-test runs.
773
774         The main cost of these optimizations is that we don't find out the tree
775         has a failing test until the very end of the process, but if the tree
776         has a busted test, there's not much we can do anyway.  We might as well
777         burn commit-queue resources spinning optimisticly.
778
779         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
780         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
781         * Scripts/webkitpy/tool/commands/queues.py:
782
783 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
784
785         Reviewed by Martin Robinson.
786
787         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
788         https://bugs.webkit.org/show_bug.cgi?id=46303.
789
790         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
791         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
792         WinCairo build.
793         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
794         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
795         build targets that use the new InjectedBundleCFLite.vsprops file.
796
797 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
798
799         Unreviewed, build fix.
800
801         Fix bustage of rebaseline-chromium-webkit-tests resulting from
802         r67974. Really need better unit tests for this tool :(
803
804         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
805
806 2010-09-22  Adam Roben  <aroben@apple.com>
807
808         Unbreak test-webkitpy
809
810         * Scripts/webkitpy/test/main.py:
811         (Tester.run_tests): Add a line that mysteriously got deleted.
812
813 2010-09-22  Adam Roben  <aroben@apple.com>
814
815         Make test-webkitpy test WebKit2's scripts
816
817         These scripts can't be in WebKitTools due to limitations of Apple's
818         build process. But that doesn't mean we can't test them!
819
820         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
821         WebKit2/Scripts
822
823         Reviewed by Adam Barth.
824
825         * Scripts/test-webkitpy:
826         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
827         Now takes an external_package_paths parameter and cleans both webkitpy
828         and any external packages.
829         (init): Added an external_package_paths parameter which we pass along
830         to _clean_packages_with_test.
831         (top level): Add WebKit2/Scripts/webkit2 as our only external package
832         and pass it along to init and Tester.run_tests.
833
834         * Scripts/webkitpy/test/main.py:
835         (Tester.run_tests): Added an optional external_package_paths
836         parameter. We modify sys.path so that the external packages can be
837         imported, and search for unittest files inside all external packages
838         in addition to inside webkitpy.
839
840 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
841
842         Reviewed by Tony Chang.
843
844         new-run-webkit-tests: r68063 broke linux python tests
845
846         Add a missing "from __future__ import with_statement" to this
847         new file; the perils of testing only on the Mac and by review :(
848
849         https://bugs.webkit.org/show_bug.cgi?id=46293
850
851         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
852
853 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
854
855         Reviewed by Tony Chang.
856
857         Add a 'chromium-gpu' set of ports that will test the accelerated
858         GPU paths. This patch adds:
859
860         - support for the '--accelerated-compositing' and
861           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
862           'no-' flags)
863         - adds a new set of Ports that will look under
864           platform/chromium-gpu-$OS/ for baselines before looking in the
865           regular chromium search path
866         - adds a new test_expectations.txt file in platform/chromium-gpu
867           that skips all but the tests we actually want to run with
868           acceleration.
869
870         This patch will allow us to run both with and without acceleration
871         and to change the defaults for both the regular and -gpu options
872         as the code evolves.
873
874         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
875         each test bot.
876
877         https://bugs.webkit.org/show_bug.cgi?id=46225
878
879         * Scripts/webkitpy/layout_tests/port/chromium.py:
880         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
881         * Scripts/webkitpy/layout_tests/port/factory.py:
882         * Scripts/webkitpy/layout_tests/port/webkit.py:
883
884 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
885
886         Reviewed by Kenneth Rohde Christiansen.
887
888         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
889         https://bugs.webkit.org/show_bug.cgi?id=43988
890
891         Runs a web debug server on port specified by QtTestBrowser
892         argument -remote-inspector-port. Property
893         _q_webInspectorServerPort of the QWebPage instance will be set
894         according to the argument. All pages with that property set will
895         be remotely inspectable.
896
897         URL for remote inspection of first QWebPage is
898             http://localhost:9222/webkit/inspector/inspector.html?page=1
899         where 1 is the number of the QWebPage instance.
900
901         The base URL yields an index page with links to the individual inspectors:
902             http://localhost:9222/
903
904         * QtTestBrowser/launcherwindow.cpp:
905         (LauncherWindow::init):
906         * QtTestBrowser/launcherwindow.h:
907         * QtTestBrowser/main.cpp:
908         (LauncherApplication::handleUserOptions):
909
910 2010-09-22  Adam Roben  <aroben@apple.com>
911
912         Fix webkit-patch failure-reason now that build.webkit.org has been
913         updated
914
915         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
916         every time
917
918         Reviewed by Eric Seidel.
919
920         * Scripts/webkitpy/common/net/buildbot.py:
921         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
922         looking for an element that contains text, then returns it.
923         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
924         text out of the cells. This way it doesn't matter whether the cells
925         have <b> children (as for cells in directory rows) or not (as for
926         cells in file rows)
927         (BuildBot._parse_twisted_directory_listing): Look for rows that have
928         the "directory" or "file" class, rather than rows with any class,
929         since header rows now have a class attribute.
930
931         * Scripts/webkitpy/common/net/buildbot_unittest.py:
932         (BuildBotTest._example_directory_listing): Updated to more closely
933         match the markup that build.webkit.org is producing now.
934
935 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
936
937         Unreviewed, build fix.
938
939         new-run-webkit-tests: fix bug introduced in r68008 where if you
940         specify --chromium and no --platform, and you're running on
941         windows, you use the 'chromium-win' port by default instead of the
942         version-specific port. This breaks the buildbots.
943
944         It will be good for this refactoring to settle down so I can
945         rewrite the logic for default ports and the unit tests to be
946         clearer (and the testing more comprehensive).
947
948         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
949
950 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
951
952         Reviewed by Adam Barth.
953
954         Modify the Port interface to take only a series of keyword arguments
955         in the constructor, and modify Port/factory.get() to accomodate that,
956         and to accept user=XXX as an argument so we can pass
957         webkitpy.common.system.user.User objects in.
958
959         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
960         to use the common routine in webkitpy.common.system.user.open_url()
961         to display HTML files.
962
963         There was a routine in the Port interface to do the same thing,
964         but I see no need for a port-specific hook for this, since it is
965         something that will always be executed by the host environment
966         and displaying web pages has nothing to do with running layout tests.
967
968         Note that new-run-webkit-tests used to use test_shell to display
969         the page; this is potentially useful so that you can actually click
970         from a result to the broken page; however, since DumpRenderTree
971         doesn't support this functionality, it will be going away eventually.
972
973         https://bugs.webkit.org/show_bug.cgi?id=46128
974
975         * Scripts/webkitpy/layout_tests/port/base.py:
976         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
977         * Scripts/webkitpy/layout_tests/port/chromium.py:
978         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
979         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
980         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
981         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
982         * Scripts/webkitpy/layout_tests/port/dryrun.py:
983         * Scripts/webkitpy/layout_tests/port/factory.py:
984         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
985         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
986         * Scripts/webkitpy/layout_tests/port/gtk.py:
987         * Scripts/webkitpy/layout_tests/port/mac.py:
988         * Scripts/webkitpy/layout_tests/port/qt.py:
989         * Scripts/webkitpy/layout_tests/port/test.py:
990         * Scripts/webkitpy/layout_tests/port/webkit.py:
991         * Scripts/webkitpy/layout_tests/port/win.py:
992         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
993         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
994         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
995
996 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
997
998         Reviewed by Kenneth Rohde Christiansen.
999
1000         [EFL] Get fresh theme when running EWebLauncher
1001         https://bugs.webkit.org/show_bug.cgi?id=46210
1002
1003         If user tried to run EWebLauncher outside of the build tree, it would
1004         not find the theme and fallback to the installed one. However, since
1005         EWebLauncher is not installed, we always want to take the theme from
1006         the just compiled source code. If user had never installed WebKit's
1007         EFL port it could even receive a segv since no theme would be found.
1008
1009         Now EWebLauncher does not fallback to the installed theme and CMake
1010         gives as DATA_DIR the directory of the theme it has just built.
1011
1012         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
1013         EWebLauncher.
1014         * EWebLauncher/main.c: Use only the theme from build director. Do not
1015         fallback to others as this could hide real bugs.
1016         (quit):
1017         (browserCreate):
1018         (findThemePath):
1019         (main):
1020
1021 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1022
1023         Unreviewed, build fix.
1024
1025         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
1026         it just confuses it.
1027
1028         https://bugs.webkit.org/show_bug.cgi?id=46230
1029
1030         * Scripts/webkitpy/layout_tests/port/webkit.py:
1031
1032 2010-09-21  Lucas Forschler  <lforschler@apple.com>
1033
1034         Reviewed by Stephanie Lewis.
1035
1036         Make a new buildbot for Leopard Debug Test
1037
1038         * BuildSlaveSupport/build.webkit.org-config/config.json:
1039
1040 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1041
1042         Unreviewed, build fix.
1043
1044         Fix breakage of Chromium Mac DRT port caused by r67905.
1045
1046         https://bugs.webkit.org/show_bug.cgi?id=46230
1047
1048         * Scripts/webkitpy/layout_tests/port/webkit.py:
1049
1050 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1051
1052         Unreviewed, build fix.
1053
1054         Add missing import of 'tempfile'.
1055
1056         * Scripts/webkitpy/layout_tests/port/chromium.py:
1057
1058 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
1059
1060         Reviewed by Ojan Vafai.
1061
1062         new-run-webkit-tests: pull the list of tests from the Port, and
1063            make it possible to run with no actual test files in the filesystem.
1064
1065         This set of changes allows us to delete the special
1066         webkitpy/layout_tests/data directory and test the generic code without
1067         touching the filesystem (except to write results). This speeds up
1068         test-webkitpy substantially.
1069
1070         This also cleans up and removes several code paths in the generic
1071         code and fixes some minor bugs, notably in the test_expectations
1072         parsing, which was previously fragile if the tests weren't present.
1073
1074         We also change the way we diff image results to be able to do so
1075         in memory, without relying on files. This slows down chromium
1076         test_shell, which always writes images to files, but should speed
1077         up DRT and ImageDiff-based implementations slightly.
1078
1079         Note that pulling the list of tests to run from the Port will allow
1080         ports to specify what tests to run as an inclusive list; previously
1081         you could only do this as an exclusive list by using a 
1082         test_expectations file or Skipped files; nothing actually uses this
1083         feature yet and it's unclear if it should be used.
1084
1085         Note that there are no functional changes -- apart from now 
1086         always printing out the location of the checksum file when we are
1087         tracing test runs -- and the total number of lines of non-test code
1088         actually drops by two.
1089
1090         There is some more cleanup that can be done in the Port/Driver 
1091         interface and in some handling of filenames, but I'll save that
1092         for another change.
1093
1094         https://bugs.webkit.org/show_bug.cgi?id=45801
1095
1096         * Scripts/webkitpy/layout_tests/data/*: Removed.
1097             - no longer need special mock layout_tests_directory in the
1098               repository.
1099         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1100             - add code to display missing text files, checksums when tracing
1101             - update to not look at the filesystem directly.
1102         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1103             - add more unit tests
1104         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1105             - remove tests_are_present flag
1106             - update with changes in Port interface - no longer access
1107               the filesystem directly, although we still use os.path for
1108               filename manipulation.
1109         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1110             - add more unit tests
1111         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
1112             - renamed to port/test_files.py
1113         * Scripts/webkitpy/layout_tests/port/base.py:
1114             - change diff_image() to expect actual image data, not filenames
1115             - add expected_checksum(), expected_image(), expected_text() to
1116               return the content of the files so that we don't need a filesystem
1117             - add path_exists(), path_isdir() for filesystem-like access.
1118             - add test_dirs() to keep clobber-test-results from needing to
1119               actually look at a real layout tests dir
1120             - add tests() to return the list of tests to run on the port
1121               (calls port/test_files to do the work).
1122             - add update_baseline() to be able to save new baselines
1123             - add uri_to_test_name() from port/dryrun.py so we can easily check
1124               filename_to_uri()
1125         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1126             - add more unit tests
1127         * Scripts/webkitpy/layout_tests/port/chromium.py:
1128             - change diff_image() to accept image content, not filenames.
1129               This will be slower for test_shell/image_diff, but faster
1130               for DRT/ImageDiff.
1131         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1132             - add more unit tests
1133         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1134             - simplify greatly
1135         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1136             - add more unit tests
1137         * Scripts/webkitpy/layout_tests/port/test.py:
1138             - massive rewrite to use in-script list of tests and expectations
1139         * Scripts/webkitpy/layout_tests/port/test_files.py:
1140             - rename from layout_package/test_files.
1141         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1142             - add unit tests
1143         * Scripts/webkitpy/layout_tests/port/webkit.py:
1144             - update diff_image() to take image contents, not files. Should
1145               make things slightly faster.
1146         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1147             - update with changes to diff_image()
1148         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1149             - update with changes to diff_image()
1150         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1151             - remove tests_are_present from test_expectations
1152             - pull the list of tests from port.tests() instead
1153               of calling test_files.py directly.
1154         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1155             - update unit tests
1156         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1157             - update with changes to 
1158         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1159             - update with change in Port interface
1160         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1161             - update with change in Port interface
1162         * Scripts/webkitpy/style/checkers/test_expectations.py:
1163             - remove the tests_are_present flag
1164
1165 2010-09-21  Anders Carlsson  <andersca@apple.com>
1166
1167         Disable logging.
1168
1169         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1170
1171 2010-09-21  Tony Chang  <tony@chromium.org>
1172
1173         Reviewed by Kent Tamura.
1174
1175         add a script for running webkit_unit_tests
1176         https://bugs.webkit.org/show_bug.cgi?id=46014
1177
1178         * Scripts/run-chromium-webkit-unit-tests: Added.
1179
1180 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
1181
1182         Reviewed by Martin Robinson.
1183
1184         Fix linking problems on Windows.
1185         https://bugs.webkit.org/show_bug.cgi?id=45844
1186
1187         * GNUmakefile.am: link the executables with winmm.dll
1188
1189 2010-09-21  Adam Barth  <abarth@webkit.org>
1190
1191         Reviewed by Eric Seidel.
1192
1193         feeder-queue svn updates more often than needed
1194         https://bugs.webkit.org/show_bug.cgi?id=46171
1195
1196         We don't need to poll SVN every time we feed the feeders.  Rather, we
1197         can count on the wrapper shell script to auto-update the queue.
1198
1199         * Scripts/webkitpy/tool/commands/queues.py:
1200         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1201
1202 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1203
1204         Reviewed by Andreas Kling.
1205
1206         [Qt] Add robot loader timeout and extra time options.
1207         https://bugs.webkit.org/show_bug.cgi?id=46172
1208
1209         [-robot-timeout <s>]: Load the next page after s seconds if the current
1210         page didn't finish loading.
1211         [-robot-extra-time <s>]: Wait s seconds after the current page finished
1212         loading before loading the next one. This should allow some time for the
1213         page's JavaScript to execute.
1214
1215         * QtTestBrowser/launcherwindow.cpp:
1216         (LauncherWindow::applyPrefs):
1217         * QtTestBrowser/main.cpp:
1218         (LauncherApplication::robotTimeout):
1219         (LauncherApplication::robotExtraTime):
1220         (LauncherApplication::LauncherApplication):
1221         (LauncherApplication::handleUserOptions):
1222         (main):
1223         * QtTestBrowser/urlloader.cpp:
1224         (UrlLoader::UrlLoader):
1225         (UrlLoader::loadNext):
1226         (UrlLoader::loadUrlList):
1227         * QtTestBrowser/urlloader.h:
1228
1229 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
1230
1231         Unreviewed.
1232
1233         Adding myself to the committers list.
1234
1235         * Scripts/webkitpy/common/config/committers.py:
1236
1237 2010-09-20  Philippe Normand  <pnormand@igalia.com>
1238
1239         Reviewed by Eric Carlson.
1240
1241         [GTK] enhanced context menu for media elements
1242         https://bugs.webkit.org/show_bug.cgi?id=45021
1243
1244         EventSender::contextClick() now returns an array of js
1245         objects. Each object has a title property and a click() method.
1246
1247         * DumpRenderTree/gtk/EventSender.cpp:
1248         (getMenuItemTitleCallback):
1249         (setMenuItemTitleCallback):
1250         (menuItemClickCallback):
1251         (getMenuItemClass):
1252         (contextClickCallback):
1253
1254 2010-09-20  Hayato Ito  <hayato@chromium.org>
1255
1256         Unreviewed.
1257         Adding myself to the committers list.
1258
1259         * Scripts/webkitpy/common/config/committers.py:
1260
1261 2010-09-20  Adam Barth  <abarth@webkit.org>
1262
1263         Reviewed by Eric Seidel.
1264
1265         The tool member variable should be called _tool
1266         https://bugs.webkit.org/show_bug.cgi?id=46160
1267
1268         Created by find-and-replace.
1269
1270         * Scripts/webkitpy/tool/commands/download.py:
1271         * Scripts/webkitpy/tool/commands/openbugs.py:
1272         * Scripts/webkitpy/tool/commands/queries.py:
1273         * Scripts/webkitpy/tool/commands/queues.py:
1274         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1275         * Scripts/webkitpy/tool/commands/rebaseline.py:
1276         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1277         * Scripts/webkitpy/tool/commands/upload.py:
1278         * Scripts/webkitpy/tool/multicommandtool.py:
1279
1280 2010-09-20  Adam Barth  <abarth@webkit.org>
1281
1282         I ran the tests before landing but ignored the fact that they failed.  :(
1283
1284         * Scripts/webkitpy/tool/commands/queues.py:
1285
1286 2010-09-20  Adam Barth  <abarth@webkit.org>
1287
1288         Reviewed by Eric Seidel.
1289
1290         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
1291         https://bugs.webkit.org/show_bug.cgi?id=46141
1292
1293         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
1294         list of work items on the status server.  The individual commit-cluster
1295         nodes then grab the patches from the server and process them.
1296
1297         * Scripts/webkitpy/tool/bot/feeders.py: Added.
1298         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
1299         * Scripts/webkitpy/tool/commands/queues.py:
1300         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1301         * Scripts/webkitpy/tool/commands/queuestest.py:
1302
1303 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
1304
1305         Reviewed by Darin Adler.
1306
1307         build-webkit: Add support for CMake build system
1308         https://bugs.webkit.org/show_bug.cgi?id=44979
1309
1310         * Scripts/build-webkit: Add "--efl" command-line option to build the
1311         EFL port of WebKit.
1312         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
1313         buildEflCMakeProject() subroutines.
1314
1315 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
1316
1317         Reviewed by Ojan Vafai.
1318
1319         new-run-webkit-tests: refactor command line args getting passed to DRT
1320
1321         This change cleans up some argument parsing between functions to get
1322         rid of some overlapping data structures. There should be no functional
1323         changes in this patch; it is pure refactoring in preparation for
1324         landing the Chrome GPU port and adding a generic way to pass
1325         args to DRT/TestShell.
1326
1327         https://bugs.webkit.org/show_bug.cgi?id=46135
1328
1329         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1330           - pass the options argument explicitly to the threads and drivers,
1331             also consolidate the passing of options to the driver.
1332           - pass options directly to process_output() to remove a couple
1333             parameters (minor cleanup).
1334         * Scripts/webkitpy/layout_tests/port/base.py:
1335           - pass the options argument to Port.create_driver().
1336         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1337           - update Port.create_driver() test
1338         * Scripts/webkitpy/layout_tests/port/chromium.py:
1339           - pass the options argument to Port.create_driver(), and clean up
1340             building of the cmd line for DRT.
1341         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1342           - pass the options argument to Port.create_driver()
1343         * Scripts/webkitpy/layout_tests/port/test.py:
1344           - pass the options argument to Port.create_driver()
1345         * Scripts/webkitpy/layout_tests/port/webkit.py:
1346           - pass the options argument to Port.create_driver(), and clean up
1347             building of the cmd line for DRT.
1348         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1349           - consolidate args in _get_dump_render_tree_args and rename to
1350             _get_test_args(); move all of the command-line args to the
1351             Port implementations.
1352
1353 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
1354
1355         Revert change which was accidentally committed along with some expectation changes.
1356
1357         * Scripts/webkitpy/layout_tests/port/base.py:
1358
1359 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
1360
1361         Reviewed by Adam Barth.
1362
1363         Add explicit --force-patch flag to webkitpy tools
1364         https://bugs.webkit.org/show_bug.cgi?id=46103
1365         
1366         It wasn't obvious until I read the applypatch.py source code that
1367         --non-interfactive implies passing --force to patch. Add --force-patch
1368         as an alias to the flag, so that this behavior is more discoverable.
1369
1370         * Scripts/webkitpy/tool/steps/applypatch.py:
1371         * Scripts/webkitpy/tool/steps/options.py:
1372
1373 2010-09-20  Eric Seidel  <eric@webkit.org>
1374
1375         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
1376
1377         commit-queue can't land patches
1378         https://bugs.webkit.org/show_bug.cgi?id=46138
1379
1380         Add a line of code I forgot in my last commit.
1381
1382         * Scripts/webkitpy/common/net/bugzilla.py:
1383         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1384
1385 2010-09-20  Adam Barth  <abarth@webkit.org>
1386
1387         Reviewed by Eric Seidel.
1388
1389         The commit-cluster bots still race to lock patch_ids
1390         https://bugs.webkit.org/show_bug.cgi?id=46130
1391
1392         It turns out we need to use a transaction object to make the
1393         read/modify/write lock operation atomic.  From reading the AppEngine
1394         documentation, I think this patch should do what we want.  It's hard to
1395         test locally because the test instance isn't distributed in the same
1396         way the production instance is.
1397
1398         * QueueStatusServer/handlers/nextpatch.py:
1399         * QueueStatusServer/model/activeworkitems.py: Added.
1400
1401 2010-09-20  Andy Estes  <aestes@apple.com>
1402
1403         Reviewed by Adam Barth.
1404
1405         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
1406         https://bugs.webkit.org/show_bug.cgi?id=40961
1407
1408         Implement WebKitUsePreHTML5ParserQuirks preference.
1409
1410         * DumpRenderTree/mac/DumpRenderTree.mm:
1411         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
1412         to false after a test finishes.
1413
1414 2010-09-20  Adam Roben  <aroben@apple.com>
1415
1416         Windows build fix
1417
1418         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
1419         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
1420         we'll pick up the most recent versions of the headers.
1421
1422 2010-09-20  Eric Seidel  <eric@webkit.org>
1423
1424         Reviewed by Adam Barth.
1425
1426         commit-queue should check commit-queue+ again just before committing
1427         https://bugs.webkit.org/show_bug.cgi?id=32679
1428
1429         Added a _revalidate_patch check, right before landing.
1430
1431         Since _revalidate_patch passes the patch_id from the work item
1432         back to bugzilla, I had to fix all of the previous queue tests to
1433         use valid attachment ids (that's the majority of this change).
1434
1435         In order to validate that the bug was still open, I had to teach
1436         bugzilla.Bug about open/closed states.
1437
1438         * Scripts/webkitpy/common/net/bugzilla.py:
1439         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1440         * Scripts/webkitpy/tool/commands/queues.py:
1441         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1442         * Scripts/webkitpy/tool/commands/queuestest.py:
1443         * Scripts/webkitpy/tool/mocktool.py:
1444
1445 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
1446
1447         Unreviewed.
1448
1449         Adding myself as a comitter.
1450
1451         * Scripts/webkitpy/common/config/committers.py:
1452
1453 2010-09-20  Adam Barth  <abarth@webkit.org>
1454
1455         Reviewed by Eric Seidel.
1456
1457         Two instances of commit-queue try to process the same patch
1458         https://bugs.webkit.org/show_bug.cgi?id=46113
1459
1460         This patch makes next-patch atomic so that the server won't vend the
1461         same patch twice in the same hour.
1462
1463         * QueueStatusServer/handlers/nextpatch.py:
1464
1465 2010-09-20  Adam Roben  <aroben@apple.com>
1466
1467         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
1468
1469         We were previously trying to use a CFRunLoopTimer, but since Windows
1470         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
1471         Windows-style timer on Windows.
1472
1473         I also replaced all uses of "watchdog" with "watchdog timer".
1474
1475         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
1476         watchdog timer doesn't work on Windows
1477
1478         Reviewed by Anders Carlsson.
1479
1480         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1481         (WTR::InjectedBundlePage::dump): Updated for rename.
1482
1483         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
1484         platform-specific functions.
1485         (WTR::LayoutTestController::LayoutTestController): Added call to
1486         platformInitialize.
1487         (WTR::LayoutTestController::waitUntilDone): Changed to call
1488         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
1489         right in this function.
1490         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
1491         rename.
1492
1493         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
1494         members needed to support the watchdog timer abstraction. Replaced
1495         some "watchdog"s with "watchdog timer".
1496
1497         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
1498         Added.
1499         (WTR::LayoutTestController::platformInitialize): Does nothing on this
1500         platform.
1501         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
1502         from LayoutTestController.cpp and changed to use an early return.
1503         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
1504         LayoutTestController.cpp.
1505         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
1506         Moved code here from LayoutTestController::waitUntilDone and changed
1507         to use an early return.
1508
1509         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1510         Added.
1511         (WTR::LayoutTestController::platformInitialize): Initialize our
1512         watchdog timer.
1513         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
1514         Kills and clears the watchdog timer.
1515         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
1516         LayoutTestController member function of the same name.
1517         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
1518         Added. Sets up the timer if it isn't already set.
1519
1520         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
1521         LayoutTestControllerMac.mm.
1522
1523         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
1524         LayoutTestControllerWin.cpp.
1525
1526 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
1527
1528         Reviewed by Daniel Bates.
1529
1530         [GTK] fast/forms/listbox-selection.html fails
1531         https://bugs.webkit.org/show_bug.cgi?id=45942
1532
1533         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
1534         strings in keyDownCallback.
1535
1536         * DumpRenderTree/gtk/EventSender.cpp:
1537         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
1538         modifier parsing logic.
1539
1540 2010-09-19  Sam Weinig  <sam@webkit.org>
1541
1542         Reviewed by Anders Carlsson.
1543
1544         WebKit2 decidePolicyForNavigationAction should include mouse button information
1545         <rdar://problem/8413165>
1546         https://bugs.webkit.org/show_bug.cgi?id=46060
1547
1548         * MiniBrowser/mac/BrowserWindowController.m:
1549         (decidePolicyForNavigationAction):
1550         (decidePolicyForNewWindowAction):
1551
1552 2010-09-19  Daniel Bates  <dbates@rim.com>
1553
1554         Reviewed by Martin Robinson.
1555
1556         Add unit tests for diffs that delete or modify a change log entry
1557         or describe changes that are far apart
1558         https://bugs.webkit.org/show_bug.cgi?id=46046
1559
1560         Add additional unit tests to test change log diffs that contain
1561         deletions or changes that are far apart from each other in the
1562         ChangeLog file.
1563
1564         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1565           - Added the following unit tests:
1566           "fixChangeLogPatch: [no change] In-place change."
1567           "fixChangeLogPatch: [no change] Remove first entry."
1568           "fixChangeLogPatch: [no change] Remove entry in the middle."
1569           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
1570
1571 2010-09-19  Sam Weinig  <sam@webkit.org>
1572
1573         Reviewed by Anders Carlsson.
1574
1575         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
1576         https://bugs.webkit.org/show_bug.cgi?id=46054
1577
1578         The new one acts like WKBundleNodeHandleRef and allows for getting a
1579         wrapper in a specific world for the handle.
1580
1581         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1582         (WTR::propertyValue):
1583         (WTR::propertyValueDouble):
1584         (WTR::propertyValueInt):
1585         (WTR::numericWindowPropertyValue):
1586         (WTR::toStr):
1587         (WTR::InjectedBundlePage::shouldBeginEditing):
1588         (WTR::InjectedBundlePage::shouldEndEditing):
1589         (WTR::InjectedBundlePage::shouldInsertNode):
1590         (WTR::InjectedBundlePage::shouldInsertText):
1591         (WTR::InjectedBundlePage::shouldDeleteRange):
1592         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1593         (WTR::InjectedBundlePage::shouldApplyStyle):
1594         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1595
1596 2010-09-19  Kent Tamura  <tkent@chromium.org>
1597
1598         Unreviewed. Fix WebGL test regressions by r67809.
1599
1600         * DumpRenderTree/chromium/WebPreferences.cpp:
1601         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
1602
1603 2010-09-19  Kent Tamura  <tkent@chromium.org>
1604
1605         Reviewed by Adam Barth.
1606
1607         [DRT/Chromium] Fix a WebSettings handling bug
1608         https://bugs.webkit.org/show_bug.cgi?id=45945
1609
1610         Before this change, Chromium DRT reset WebSettings for every new
1611         window. It was wrong.
1612         If new window is not the first one, we have to apply the same
1613         settings as the first window.  So, we introduce WebPreference to
1614         store the current settings, and apply it to new windows. It's same
1615         as test_shell's behavior.
1616
1617         * DumpRenderTree/DumpRenderTree.gypi:
1618         * DumpRenderTree/chromium/LayoutTestController.cpp:
1619           Use WebPreferences instead of WebSettings.
1620         (LayoutTestController::setUserStyleSheetEnabled):
1621         (LayoutTestController::setUserStyleSheetLocation):
1622         (LayoutTestController::setAuthorAndUserStylesEnabled):
1623         (LayoutTestController::setPopupBlockingEnabled):
1624         (LayoutTestController::disableImageLoading):
1625         (LayoutTestController::setJavaScriptCanAccessClipboard):
1626         (LayoutTestController::setXSSAuditorEnabled):
1627         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1628         (LayoutTestController::setAllowFileAccessFromFileURLs):
1629         (LayoutTestController::overridePreference):
1630         (LayoutTestController::setEditingBehavior):
1631         * DumpRenderTree/chromium/TestShell.cpp:
1632         (TestShell::resetWebSettings): Use WebPreferences.
1633         (TestShell::runFileTest): ditto.
1634         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
1635         * DumpRenderTree/chromium/TestShell.h:
1636         (TestShell::preferences):
1637         (TestShell::applyPreferences):
1638         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
1639         * DumpRenderTree/chromium/WebPreferences.h: Added.
1640
1641 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
1642
1643         Reviewed by David Levin.
1644
1645         update-webkit --chromium spitting out a spurious error
1646         https://bugs.webkit.org/show_bug.cgi?id=45868
1647
1648         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
1649
1650 2010-09-18  Sam Weinig  <sam@webkit.org>
1651
1652         Reviewed by Dan Bernstein.
1653
1654         Improve/unify the PageLoadClient interfaces
1655         https://bugs.webkit.org/show_bug.cgi?id=46043
1656
1657         * MiniBrowser/mac/BrowserWindowController.m:
1658         (didStartProvisionalLoadForFrame):
1659         (didReceiveServerRedirectForProvisionalLoadForFrame):
1660         (didFailProvisionalLoadWithErrorForFrame):
1661         (didCommitLoadForFrame):
1662         (didFinishDocumentLoadForFrame):
1663         (didFinishLoadForFrame):
1664         (didFailLoadWithErrorForFrame):
1665         (didReceiveTitleForFrame):
1666         (didFirstLayoutForFrame):
1667         (didFirstVisuallyNonEmptyLayoutForFrame):
1668         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1669         (WTR::InjectedBundlePage::InjectedBundlePage):
1670         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1671         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1672         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1673         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1674         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1675         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1676         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1677         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1678         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1679         * WebKitTestRunner/TestController.cpp:
1680         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1681         (WTR::TestController::didFinishLoadForFrame):
1682         * WebKitTestRunner/TestController.h:
1683
1684 2010-09-17  Eric Seidel  <eric@webkit.org>
1685
1686         Unreviewed.  Adding a shell script I use to run the
1687         commit-queue. Now that multiple machines run the cq,
1688         it makes sense to share the script between them.
1689
1690         * EWSTools/start-commit-queue.sh: Added.
1691
1692 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
1693
1694         Reviewed by Jon Honeycutt.
1695
1696         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
1697         slightly harder to read, so this reverts the previous background colors for various
1698         states, making it easier to read.
1699
1700         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1701         (.success):
1702         (.failure):
1703         (.warnings):
1704         (.exception):
1705         (.start,.running,td.building):
1706         (.offline,td.offline):
1707
1708 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
1709
1710         Unreviewed, rolling out r67692.
1711         http://trac.webkit.org/changeset/67692
1712         https://bugs.webkit.org/show_bug.cgi?id=46011
1713
1714         broke layout test dashboard (Requested by johnny_g on
1715         #webkit).
1716
1717         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1718         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1719         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1720
1721 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
1722
1723         Reviewed by Oliver Hunt.
1724
1725         Style bot complains about cairo forward declaration naming
1726         https://bugs.webkit.org/show_bug.cgi?id=45867
1727
1728         Exclude Cairo forward declarations from indentifiers with underscores checks.
1729
1730         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
1731         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
1732
1733 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
1734
1735         Reviewed by Ojan Vafai.
1736
1737         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
1738         https://bugs.webkit.org/show_bug.cgi?id=45408
1739
1740         This change also tries to remove duplicated upload_results_json methods
1741         in run_webkit_tests.py and json_results_generator.py.
1742
1743         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1744         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1745         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1746
1747 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
1748
1749         Reviewed by Andreas Kling.
1750
1751         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
1752
1753         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
1754         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
1755         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
1756         all page specific stuff to the UI.
1757
1758         * QtTestBrowser/launcherwindow.cpp:
1759         (LauncherWindow::initializeView):
1760         * QtTestBrowser/mainwindow.cpp:
1761         (MainWindow::MainWindow):
1762         (MainWindow::buildUI):
1763         (MainWindow::setPage):
1764         * QtTestBrowser/mainwindow.h:
1765
1766 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
1767
1768         Reviewed by Andreas Kling.
1769
1770         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
1771
1772         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
1773         object will move to the qgraphicsscene instead of the qgraphicsview.
1774
1775         * QtTestBrowser/webview.cpp:
1776         (WebViewGraphicsBased::setPage):
1777         (WebViewGraphicsBased::setResizesToContents):
1778         (WebViewGraphicsBased::resizeEvent):
1779         (WebViewGraphicsBased::animatedFlip):
1780         * QtTestBrowser/webview.h:
1781         (WebViewGraphicsBased::setItemCacheMode):
1782         (WebViewGraphicsBased::itemCacheMode):
1783
1784 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
1785
1786         Reviewed by Andreas Kling.
1787
1788         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
1789
1790         We usually separate methods whose body are larger than a few lines from the class definition.
1791
1792         * QtTestBrowser/webview.h:
1793         (WebViewGraphicsBased::yRotation):
1794         (WebViewGraphicsBased::setYRotation):
1795
1796 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
1797
1798         Reviewed by Andreas Kling.
1799
1800         Make initializeView method of LauncherWindow private.
1801
1802         No one else needs to be able to call it but LauncherWindow.
1803         Also moving the declation of isGraphicsBased method down in the same file, in order
1804         to better group related methods.
1805
1806         * QtTestBrowser/launcherwindow.h:
1807
1808 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
1809
1810         Reviewed by Andreas Kling.
1811
1812         Make the getter 'page' method of MainWindow const.
1813
1814         * QtTestBrowser/mainwindow.cpp:
1815         (MainWindow::page):
1816         * QtTestBrowser/mainwindow.h:
1817
1818 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
1819
1820         Reviewed by Andreas Kling.
1821
1822         Remove useless parameter from MainWindow class' constructor.
1823
1824         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
1825         not referred in the constructor body and does not make much sense.
1826
1827         * QtTestBrowser/mainwindow.cpp:
1828         (MainWindow::MainWindow):
1829         * QtTestBrowser/mainwindow.h:
1830
1831 2010-09-15  Tony Chang  <tony@chromium.org>
1832
1833         Reviewed by Kent Tamura.
1834
1835         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
1836         https://bugs.webkit.org/show_bug.cgi?id=42151
1837
1838         * DumpRenderTree/chromium/LayoutTestController.cpp:
1839         (LayoutTestController::LayoutTestController):
1840         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1841         (WorkItemLoadHTMLString::run):
1842         (LayoutTestController::queueLoadHTMLString):
1843         (LayoutTestController::reset):
1844         (LayoutTestController::setDeferMainResourceDataLoad):
1845         * DumpRenderTree/chromium/LayoutTestController.h:
1846         (LayoutTestController::deferMainResourceDataLoad):
1847         * DumpRenderTree/chromium/WebViewHost.cpp:
1848         (WebViewHost::didCreateDataSource):
1849
1850 2010-09-16  Adrienne Walker  <enne@google.com>
1851
1852         Reviewed by Kenneth Russell.
1853
1854         Add script to synchronize WebKit and Khronos WebGL tests
1855         https://bugs.webkit.org/show_bug.cgi?id=42336
1856
1857         * Scripts/update-webgl-conformance-tests: Added.
1858         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
1859         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
1860
1861 2010-09-16  Sam Weinig  <sam@webkit.org>
1862
1863         Reviewed by Anders Carlsson.
1864
1865         Add support for sending synchronous messages from the InjectedBundle to the WKContext
1866         <rdar://problem/8365320>
1867         https://bugs.webkit.org/show_bug.cgi?id=44785
1868
1869         * MiniBrowser/mac/AppDelegate.m:
1870         (didReceiveSynchronousMessageFromInjectedBundle):
1871         (-[BrowserAppDelegate init]):
1872         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1873         (didCreatePage):
1874         * WebKitTestRunner/TestController.cpp:
1875         (WTR::TestController::initialize):
1876
1877 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
1878
1879         Reviewed by Andreas Kling.
1880
1881         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
1882         https://bugs.webkit.org/show_bug.cgi?id=45885
1883
1884         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
1885
1886         * QtTestBrowser/launcherwindow.cpp:
1887         (LauncherWindow::screenshot):
1888
1889 2010-09-16  Anders Carlsson  <andersca@apple.com>
1890
1891         Fix clang++ build.
1892
1893         * MiniBrowser/mac/BrowserWindowController.m:
1894         (-[BrowserWindowController zoomIn:]):
1895         (-[BrowserWindowController zoomOut:]):
1896         (-[BrowserWindowController resetZoom:]):
1897         Remove trailing semicolons.
1898
1899 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1900
1901         Unreviewed, rolling out r67628.
1902         http://trac.webkit.org/changeset/67628
1903         https://bugs.webkit.org/show_bug.cgi?id=45904
1904
1905         broke the build (Requested by eric_carlson on #webkit).
1906
1907         * DumpRenderTree/gtk/EventSender.cpp:
1908         (contextClickCallback):
1909
1910 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
1911
1912         Unreviewed.
1913
1914         Adding myself as a comitter.
1915
1916         * Scripts/webkitpy/common/config/committers.py:
1917
1918 2010-09-15  Philippe Normand  <pnormand@igalia.com>
1919
1920         Reviewed by Eric Carlson.
1921
1922         [GTK] enhanced context menu for media elements
1923         https://bugs.webkit.org/show_bug.cgi?id=45021
1924
1925         EventSender::contextClick() now returns an array of js
1926         objects. Each object has a title property and a click() method.
1927
1928         * DumpRenderTree/gtk/EventSender.cpp:
1929         (getMenuItemTitleCallback):
1930         (setMenuItemTitleCallback):
1931         (menuItemClickCallback):
1932         (getMenuItemClass):
1933         (contextClickCallback):
1934
1935 2010-09-14  Philippe Normand  <pnormand@igalia.com>
1936
1937         Reviewed by Eric Carlson and Martin Robinson.
1938
1939         [GTK] eventSender.contextClick() should return the contents of the context menu
1940         https://bugs.webkit.org/show_bug.cgi?id=39102
1941
1942         Make the eventSender use the new private WebKitGtk+ API to
1943         retrieve the context-menu item titles and store them in an array.
1944
1945         * DumpRenderTree/gtk/EventSender.cpp:
1946         (contextClickCallback):
1947
1948 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
1949
1950         Reviewed by Jian Li.
1951
1952         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
1953         https://bugs.webkit.org/show_bug.cgi?id=45798
1954
1955         * Scripts/build-webkit:
1956
1957 2010-09-16  Robert Hogan  <robert@webkit.org>
1958
1959         Reviewed by Antonio Gomes.
1960
1961         [Qt] Support globalhistory tests
1962         https://bugs.webkit.org/show_bug.cgi?id=45774
1963
1964         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1965         (WebCore::isGlobalHistoryTest):
1966         (WebCore::DumpRenderTree::open):
1967         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1968         (LayoutTestController::reset):
1969         (LayoutTestController::dumpHistoryCallbacks):
1970         (LayoutTestController::removeAllVisitedLinks):
1971         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1972
1973 2010-09-10  Tony Chang  <tony@chromium.org>
1974
1975         Reviewed by Eric Seidel.
1976
1977         deduplicate-tests should be runnable from any WebKit directory
1978         https://bugs.webkit.org/show_bug.cgi?id=44709
1979
1980         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1981         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1982
1983 2010-09-15  Tony Chang  <tony@chromium.org>
1984
1985         Reviewed by Kent Tamura.
1986
1987         [chromium] sort testing methods in DRT
1988         https://bugs.webkit.org/show_bug.cgi?id=45850
1989
1990         * DumpRenderTree/chromium/EventSender.cpp:
1991         (EventSender::EventSender):
1992         * DumpRenderTree/chromium/LayoutTestController.cpp:
1993         (LayoutTestController::LayoutTestController):
1994         * DumpRenderTree/chromium/TextInputController.cpp:
1995         (TextInputController::TextInputController):
1996
1997 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
1998
1999         Reviewed by Adam Barth.
2000
2001         CQ status shows items out of order
2002         https://bugs.webkit.org/show_bug.cgi?id=45846
2003         
2004         Only group consecutive status items with the same patch ID into the same
2005         group, so that overall item ordering is preserved.
2006         
2007         Also don't indent status items that only have a single item in their
2008         group.
2009
2010         * QueueStatusServer/handlers/queuestatus.py:
2011         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
2012         * QueueStatusServer/templates/queuestatus.html:
2013
2014 2010-09-15  Eric Seidel  <eric@webkit.org>
2015
2016         Reviewed by Adam Barth.
2017
2018         Add queue start/stop messages
2019         https://bugs.webkit.org/show_bug.cgi?id=45853
2020
2021         I ended up needing to clean up a bunch of our unit testing
2022         in order to test this new code path nicely.
2023
2024         There are also a few PEP8 changes needed to pass check-webkit-style.
2025
2026         * Scripts/webkitpy/tool/bot/queueengine.py:
2027         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2028         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2029         * Scripts/webkitpy/tool/commands/queues.py:
2030         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2031         * Scripts/webkitpy/tool/commands/queuestest.py:
2032         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2033
2034 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
2035
2036         https://bugs.webkit.org/show_bug.cgi?id=45849
2037         WKURLCreateWithCFURL crashes with null url
2038         
2039         Fix MiniBrowser crash when the url is not parseable.
2040
2041         * MiniBrowser/mac/BrowserWindowController.m:
2042         (-[BrowserWindowController fetch:]):
2043
2044 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
2045
2046         Unreviewed.
2047
2048         Adding myself to the committers list.
2049
2050         * Scripts/webkitpy/common/config/committers.py:
2051
2052 2010-09-14  Eric Seidel  <eric@webkit.org>
2053
2054         Reviewed by Adam Barth.
2055
2056         Make it possible to run more than one commit-queue instance
2057         https://bugs.webkit.org/show_bug.cgi?id=45786
2058
2059         Mostly we need to make sure the two (or more) instances get
2060         different patches to work on.  To do this, I re-worked
2061         the code responsible for getting the next work item to
2062         round trip through the status server.  The status server only
2063         vends patches from the work items list, only if those patches
2064         have not had status reported for them in the last hour.
2065
2066         This is another step towards making all queues go through the
2067         status server, thus making it possible to run more than one
2068         instance of various EWS bots (as requested in bug 44292).
2069
2070         The webkitpy changes are already covered by existing unit tests.
2071         The QueueStatusSever sadly has no testing infrastructure yet. :(
2072
2073         * QueueStatusServer/handlers/nextpatch.py: Added.
2074         * QueueStatusServer/index.yaml:
2075         * QueueStatusServer/main.py:
2076         * Scripts/webkitpy/tool/commands/queues.py:
2077
2078 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
2079
2080         Reviewed by Tony Chang.
2081
2082         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
2083         https://bugs.webkit.org/show_bug.cgi?id=45791
2084
2085         Force filenames to be raw bytes before running difflib.unified_diff.
2086
2087         * Scripts/webkitpy/layout_tests/port/base.py:
2088         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2089
2090 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
2091
2092         Reviewed by Tor Arne Vestbø.
2093
2094         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
2095         https://bugs.webkit.org/show_bug.cgi?id=35247
2096
2097         The main issue when changing the views is that the plugins and any other components that
2098         depend on view specific attributes such as the native window id are not teared down.
2099         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
2100         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
2101         we decided to work around this in QtTestBrowser by making toggling between QWebView
2102         and QGraphicsWebView also re-create the page.
2103
2104         * QtTestBrowser/launcherwindow.cpp:
2105         (LauncherWindow::initializeView):
2106         * QtTestBrowser/mainwindow.h:
2107
2108 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
2109
2110         Reviewed by Adam Barth.
2111
2112         Send webkit accessibility notifications to Chromium
2113         https://bugs.webkit.org/show_bug.cgi?id=45156
2114
2115         Move printf inside shouldDumpAccessibilityNotifications check.
2116
2117         * DumpRenderTree/chromium/WebViewHost.cpp:
2118         (WebViewHost::postAccessibilityNotification):
2119
2120 2010-09-14  Tony Chang  <tony@chromium.org>
2121
2122         Reviewed by Kent Tamura.
2123
2124         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
2125         https://bugs.webkit.org/show_bug.cgi?id=45788
2126
2127         * DumpRenderTree/chromium/LayoutTestController.cpp:
2128         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
2129
2130 2010-09-14  Tony Chang  <tony@chromium.org>
2131
2132         Reviewed by Ojan Vafai.
2133
2134         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
2135         https://bugs.webkit.org/show_bug.cgi?id=45768
2136
2137         * DumpRenderTree/chromium/TestShell.cpp:
2138         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
2139
2140 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
2141
2142         [wx] Build fix, add newly added directories to the directory list.
2143
2144         * wx/build/settings.py:
2145
2146 2010-09-14  Sam Weinig  <sam@webkit.org>
2147
2148         Reviewed by Anders Carlsson.
2149
2150         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
2151         https://bugs.webkit.org/show_bug.cgi?id=45785
2152
2153         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2154         (WTR::propertyValue):
2155         (WTR::numericWindowPropertyValue):
2156         (WTR::dumpPath):
2157         (WTR::toStr):
2158         (WTR::operator<<):
2159         (WTR::InjectedBundlePage::InjectedBundlePage):
2160         (WTR::InjectedBundlePage::shouldInsertNode):
2161         (WTR::InjectedBundlePage::shouldBeginEditing):
2162         (WTR::InjectedBundlePage::shouldEndEditing):
2163         (WTR::InjectedBundlePage::shouldInsertText):
2164         (WTR::InjectedBundlePage::shouldDeleteRange):
2165         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2166         (WTR::InjectedBundlePage::shouldApplyStyle):
2167         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2168
2169 2010-09-14  Adam Barth  <abarth@webkit.org>
2170
2171         Fix two typos in commit-queue.  The first is harmless.  The second
2172         causes the queue to reject patches when the build is broken.  :(
2173
2174         * Scripts/webkitpy/tool/commands/queues.py:
2175         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2176
2177 2010-09-14  Chris Guillory   <chris.guillory@google.com>
2178
2179         Reviewed by Chris Fleizach.
2180
2181         Send all accessibility notifications to Chromium.
2182         https://bugs.webkit.org/show_bug.cgi?id=45156
2183
2184         * DumpRenderTree/chromium/WebViewHost.cpp:
2185         (WebViewHost::postAccessibilityNotification):
2186         * DumpRenderTree/chromium/WebViewHost.h:
2187
2188 2010-09-14  Adam Barth  <abarth@webkit.org>
2189
2190         Reviewed by Eric Seidel.
2191
2192         commit-queue is slow during the day
2193         https://bugs.webkit.org/show_bug.cgi?id=45780
2194
2195         Thanks to the new logging, we've noticed that checkout-is-out-of-date
2196         errors in the first pass of landing don't retry the land.  Instead,
2197         they're treated as failures and cause the commit-queue to do two more
2198         builds before really trying to land the patch.  Worse, in the second
2199         build, we can get bitten by a flaky test.
2200
2201         This patch takes a slightly different approach to the commit-queue's
2202         main control logic.  We now use a separate subprocess for building and
2203         testing and for landing.  This means we should very rarely see the
2204         checkout-is-out-of-date error, and when we do see it, we should retry
2205         more quickly.  If my understanding is correct, this should be a big
2206         speed win for the commit-queue.
2207
2208         * Scripts/webkitpy/tool/commands/download.py:
2209         * Scripts/webkitpy/tool/commands/queues.py:
2210         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2211
2212 2010-09-14  Tony Chang  <tony@chromium.org>
2213
2214         Reviewed by Dimitri Glazkov.
2215
2216         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
2217         https://bugs.webkit.org/show_bug.cgi?id=45762
2218
2219         * DumpRenderTree/chromium/LayoutTestController.cpp:
2220         (LayoutTestController::LayoutTestController):
2221         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2222         * DumpRenderTree/chromium/LayoutTestController.h:
2223
2224 2010-09-14  Csaba Osztrogonác  <ossy@webkit.org>
2225
2226         Adding myself as a reviewer.
2227
2228         * Scripts/webkitpy/common/config/committers.py:
2229
2230 2010-09-14  Zoltan Horvath  <zoltan@webkit.org>
2231
2232         Reviewed by Kenneth Rohde Christiansen.
2233
2234         [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
2235         https://bugs.webkit.org/show_bug.cgi?id=45736
2236
2237         Build-webkit has showed a warning when WebKitBuild didn't exist, add
2238         an additional condition to avoid it.
2239
2240         * Scripts/build-webkit:
2241
2242 2010-09-13  Eric Seidel  <eric@webkit.org>
2243
2244         Reviewed by Adam Barth.
2245
2246         commit-queue should log when it's retrying due to checkout out of date error
2247         https://bugs.webkit.org/show_bug.cgi?id=45725
2248
2249         This will allow us to better track how often we see these errors
2250         and how long it takes the queue to recover from them.
2251
2252         In order to pass the tests, I had to correct an error
2253         from a previous change.  The UnitTestPort should not have
2254         ever been using the base port method as that will read
2255         a file from disk.  If the unit tests haven't passed the contents
2256         it should raise an IOError as though the file doesn't exist.
2257
2258         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2259         * Scripts/webkitpy/tool/commands/queues.py:
2260         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2261
2262 2010-09-13  Mihai Parparita  <mihaip@chromium.org>
2263
2264         Reviewed by Adam Barth.
2265
2266         Upload results when cq patch landing fails
2267         https://bugs.webkit.org/show_bug.cgi?id=45683
2268         
2269         Include script errors when CommitQueue._land fails.
2270
2271         * Scripts/webkitpy/tool/commands/queues.py:
2272
2273 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
2274
2275         Reviewed by David Kilzer.
2276
2277         AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
2278         https://bugs.webkit.org/show_bug.cgi?id=45548
2279
2280         * DumpRenderTree/AccessibilityUIElement.cpp:
2281         (isIgnoredCallback):
2282         (AccessibilityUIElement::getJSClass):
2283         * DumpRenderTree/AccessibilityUIElement.h:
2284         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2285         (AccessibilityUIElement::isIgnored):
2286         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2287         (AccessibilityUIElement::isIgnored):
2288         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2289         (AccessibilityUIElement::isIgnored):
2290
2291 2010-09-13  Csaba Osztrogonác  <ossy@webkit.org>
2292
2293         Reviewed by Andreas Kling.
2294
2295         jscPath() is incorrect in Windows' cmd.exe shell
2296         https://bugs.webkit.org/show_bug.cgi?id=45651
2297
2298         * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
2299
2300 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
2301
2302         Reviewed by Darin Adler.
2303
2304         REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
2305         https://bugs.webkit.org/show_bug.cgi?id=43807
2306
2307         * DumpRenderTree/AccessibilityUIElement.cpp:
2308         (textMarkerForPointCallback):
2309         (AccessibilityUIElement::textMarkerForPoint):
2310         (AccessibilityUIElement::getJSClass):
2311         * DumpRenderTree/AccessibilityUIElement.h:
2312         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2313         (AccessibilityUIElement::textMarkerForPoint):
2314
2315 2010-09-13  Andreas Kling  <andreas.kling@nokia.com>
2316
2317         Reviewed by Kenneth Rohde Christiansen.
2318
2319         [Qt] build-webkit: Add --v8 option to build against V8
2320
2321         Note that V8 is picked up from QtScript, so this currently requires building
2322         against the experimental qt-script-v8 branch.
2323
2324         * Scripts/build-webkit:
2325
2326 2010-09-13  Hans Wennborg  <hans@chromium.org>
2327
2328         Reviewed by Jeremy Orlow.
2329
2330         Add WebDeviceOrientationClientMock::create() and use it from DRT.
2331         https://bugs.webkit.org/show_bug.cgi?id=45650
2332
2333         Do not use the WebDeviceOrientationClientMock constructor directly,
2334         but use the create() member function.
2335
2336         This should fix the linker errors for the multi-DLL Chromium DRT build.
2337
2338         * DumpRenderTree/chromium/LayoutTestController.cpp:
2339         (LayoutTestController::setMockDeviceOrientation):
2340         (LayoutTestController::deviceOrientationClient):
2341
2342 2010-08-27  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
2343
2344         Reviewed by Antti Koivisto.
2345
2346         Add support for testing the viewport meta tag algorithm,
2347         based on the following draft spec:
2348
2349         http://people.opera.com/rune/TR/ED-css-viewport-20100806/
2350
2351         Add common handling of viewport meta tag based on new Opera spec
2352         https://bugs.webkit.org/show_bug.cgi?id=44201
2353
2354         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2355         (LayoutTestController::dumpConfigurationForViewport):
2356         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2357
2358 2010-09-12  Kent Tamura  <tkent@chromium.org>
2359
2360         Reviewed by Tony Chang.
2361
2362         [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
2363         https://bugs.webkit.org/show_bug.cgi?id=45517
2364
2365         Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
2366
2367         * DumpRenderTree/chromium/ImageDiff.cpp:
2368         (Image::craeteFromStdin):
2369         (Image::createFromFilename):
2370         (diffImages):
2371         * DumpRenderTree/chromium/TestShell.cpp:
2372         (TestShell::dumpImage):
2373
2374 2010-09-10  MORITA Hajime  <morrita@google.com>
2375
2376         Reviewed by Tony Chang.
2377
2378         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
2379         https://bugs.webkit.org/show_bug.cgi?id=45441
2380
2381         Added TextInputController::hasSpellingMarker().
2382         
2383         * DumpRenderTree/chromium/TextInputController.cpp:
2384         (TextInputController::TextInputController):
2385         (TextInputController::hasSpellingMarker):
2386         * DumpRenderTree/chromium/TextInputController.h:
2387
2388 2010-09-12  Dirk Pranke  <dpranke@chromium.org>
2389
2390         Unreviewed, build fix.
2391
2392         My last change accidentally contained a local change to the
2393         rebaselinig script; webkit-patch land picked it up without telling
2394         me and committed it :(
2395
2396         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2397
2398 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
2399
2400         Reviewed by Anders Carlsson.
2401
2402         Attempt to fix Windows MiniBrowser build (untested)
2403         https://bugs.webkit.org/show_bug.cgi?id=45609
2404
2405         * MiniBrowser/win/BrowserView.cpp:
2406         (runJavaScriptConfirm):
2407         (runJavaScriptPrompt):
2408
2409 2010-09-11  Sam Weinig  <sam@webkit.org>
2410
2411         Reviewed by Maciej Stachowiak.
2412
2413         Fix zoom related tests when testing WebKit2.
2414
2415         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2416         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
2417
2418 2010-09-11  Sam Weinig  <sam@webkit.org>
2419
2420         Reviewed by Dan Bernstein.
2421
2422         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
2423         <rdar://problem/8359252>
2424         https://bugs.webkit.org/show_bug.cgi?id=45605
2425
2426         * MiniBrowser/mac/BrowserWindowController.m:
2427         (setStatusText):
2428         (contentsSizeChanged):
2429         (-[BrowserWindowController awakeFromNib]):
2430         * MiniBrowser/win/BrowserView.cpp:
2431         (runJavaScriptConfirm):
2432         (runJavaScriptPrompt):
2433         (setStatusText):
2434         (contentsSizeChanged):
2435         (BrowserView::create):
2436         * WebKitTestRunner/TestController.cpp:
2437         (WTR::createOtherPage):
2438         (WTR::TestController::initialize):
2439
2440 2010-09-11  Sam Weinig  <sam@webkit.org>
2441
2442         Reviewed by Dan Bernstein.
2443
2444         Add callback mechanism for the getting the source of a frame
2445         <rdar://problem/8364681>
2446         https://bugs.webkit.org/show_bug.cgi?id=45604
2447
2448         Add ability to dump the main frame's source to the console.
2449
2450         * MiniBrowser/mac/BrowserWindowController.h:
2451         * MiniBrowser/mac/BrowserWindowController.m:
2452         (-[BrowserWindowController dumpSourceToConsole:]):
2453         * MiniBrowser/mac/MainMenu.xib:
2454
2455 2010-09-11  Eric Seidel  <eric@webkit.org>
2456
2457         Reviewed by Adam Barth.
2458
2459         Remove unneeded Empty Queue messages
2460         https://bugs.webkit.org/show_bug.cgi?id=45602
2461
2462         We already have a /gc job to delete these.
2463         recentstatus.py is already smart enough to use the
2464         most recent of the workitems last update or the most recent status,
2465         so removing these should not change the _last_status_date() return
2466         value more than a few milliseconds.
2467
2468         These messages just spam the recent status log.
2469
2470         * Scripts/webkitpy/tool/commands/queues.py:
2471
2472 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
2473
2474         Reviewed by Adam Barth.
2475
2476         Fix Python exception when generating synthetic patch IDs
2477         https://bugs.webkit.org/show_bug.cgi?id=45592
2478
2479         Can't concatenate strings and numbers directly.
2480
2481         * QueueStatusServer/handlers/queuestatus.py:
2482
2483 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
2484
2485         Reviewed by Adam Barth.
2486
2487         Group statuses in queue status by patch ID
2488         https://bugs.webkit.org/show_bug.cgi?id=45588
2489
2490         Group statuses by patch ID so that the status page is easier
2491         to scan.
2492
2493         * QueueStatusServer/handlers/queuestatus.py:
2494         * QueueStatusServer/stylesheets/dashboard.css:
2495         (.status-group):
2496         (.status-bug):
2497         (.status-group ul):
2498         (.status-group ul li):
2499         (.status-group ul li:hover):
2500         (.status-cell):
2501         (.status-cell:hover):
2502         (.status-cell.pass):
2503         (.status-cell.fail):
2504         (.status-cell.pending):
2505         (.status-cell.error):
2506         * QueueStatusServer/templates/dashboard.html:
2507         * QueueStatusServer/templates/queuestatus.html:
2508
2509 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
2510
2511         Reviewed by Tony Chang.
2512
2513         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
2514         https://bugs.webkit.org/show_bug.cgi?id=45479
2515
2516         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
2517         implementation in ResourceLoadDelegate in the Mac port).
2518
2519         * DumpRenderTree/chromium/LayoutTestController.cpp:
2520         (LayoutTestController::LayoutTestController):
2521         (LayoutTestController::dumpResourceResponseMIMETypes):
2522         (LayoutTestController::reset):
2523         * DumpRenderTree/chromium/LayoutTestController.h:
2524         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
2525         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
2526         * DumpRenderTree/chromium/TestShell.h:
2527         (TestShell::shouldDumpResourceResponseMIMETypes):
2528         * DumpRenderTree/chromium/WebViewHost.cpp:
2529         (WebViewHost::didReceiveResponse):
2530
2531 2010-09-11  Eric Seidel  <eric@webkit.org>
2532
2533         Reviewed by Adam Barth.
2534
2535         queues.webkit.org should expose /remote_api for data upload/download
2536         https://bugs.webkit.org/show_bug.cgi?id=45559
2537
2538         * QueueStatusServer/app.yaml:
2539          - /remote_api is a standard app-engine service which allows use of
2540            the bulk uploader for data upload/download.  Exposing this
2541            (for admin access only) allows us to use 
2542
2543 2010-09-10  Sam Weinig  <sam@webkit.org>
2544
2545         Reviewed by Dan Bernstein.
2546
2547         Add zoom support to WebKit2 API
2548         <rdar://problem/7660657>
2549         https://bugs.webkit.org/show_bug.cgi?id=45585
2550
2551         - Add zoom options to MiniBrowser that mimic Safari's options using
2552           the new WebKit2 zoom APIs.
2553         - Switch uses of float for the zoom APIs to use double.
2554
2555         * MiniBrowser/mac/BrowserWindowController.h:
2556         * MiniBrowser/mac/BrowserWindowController.m:
2557         (-[BrowserWindowController initWithPageNamespace:]):
2558         (-[BrowserWindowController validateMenuItem:]):
2559         (-[BrowserWindowController validateUserInterfaceItem:]):
2560         (-[BrowserWindowController currentZoomFactor]):
2561         (-[BrowserWindowController setCurrentZoomFactor:]):
2562         (-[BrowserWindowController canZoomIn]):
2563         (-[BrowserWindowController zoomIn:]):
2564         (-[BrowserWindowController canZoomOut]):
2565         (-[BrowserWindowController zoomOut:]):
2566         (-[BrowserWindowController canResetZoom]):
2567         (-[BrowserWindowController resetZoom:]):
2568         (-[BrowserWindowController toggleZoomMode:]):
2569         * MiniBrowser/mac/MainMenu.xib:
2570         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2571         (WTR::EventSendingController::textZoomIn):
2572         (WTR::EventSendingController::textZoomOut):
2573         (WTR::EventSendingController::zoomPageIn):
2574         (WTR::EventSendingController::zoomPageOut):
2575
2576 2010-09-10  Robert Hogan  <robert@webkit.org>
2577
2578         Reviewed by Andreas Kling.
2579
2580         [Qt] Fix crash in DRT in standalone mode
2581
2582         https://bugs.webkit.org/show_bug.cgi?id=45454
2583
2584         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2585         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
2586
2587 2010-09-10  Sam Weinig  <sam@webkit.org>
2588
2589         Reviewed by Darin Adler.
2590
2591         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
2592         Precursor to <rdar://problem/7660657>
2593         https://bugs.webkit.org/show_bug.cgi?id=45522
2594
2595         Update for changes to the Bundle API to allow separate control of page and text zoom
2596         levels.
2597
2598         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2599         (WTR::EventSendingController::textZoomIn):
2600         (WTR::EventSendingController::textZoomOut):
2601         (WTR::EventSendingController::zoomPageIn):
2602         (WTR::EventSendingController::zoomPageOut):
2603         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2604         (WTR::InjectedBundlePage::reset):
2605
2606 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
2607
2608         Reviewed by Andreas Kling.
2609
2610         [Qt] Support click event for notifications
2611         https://bugs.webkit.org/show_bug.cgi?id=44836
2612
2613         Add support for simulateDesktopNotificationClick by calling
2614         back to DumpRenderTreeSupportQt.cpp.
2615
2616         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2617         (LayoutTestController::simulateDesktopNotificationClick):
2618         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2619
2620 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
2621
2622         Reviewed by Eric Seidel.
2623
2624         Update queue status when patches fail their first land attempt
2625         https://bugs.webkit.org/show_bug.cgi?id=45583
2626
2627         Add a few more _update_status calls to make it more obvious if a patch is 
2628         being retried because tests failed.
2629
2630         * Scripts/webkitpy/tool/commands/queues.py:
2631
2632 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
2633
2634         Reviewed by Andreas Kling.
2635
2636         [Qt] MiniBrowser crashes with multiply windows when closing one of them
2637         https://bugs.webkit.org/show_bug.cgi?id=45536
2638
2639         * MiniBrowser/qt/BrowserView.cpp:
2640         (BrowserView::BrowserView): Reference the context instead of adopting it
2641         because it can be shared across different views.
2642
2643 2010-09-10  Tony Chang  <tony@chromium.org>
2644
2645         Unreviewed, rolling out r67241.
2646         http://trac.webkit.org/changeset/67241
2647         https://bugs.webkit.org/show_bug.cgi?id=44709
2648
2649         Accidentally committed.
2650
2651         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2652         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2653
2654 2010-09-10  Tony Chang  <tony@chromium.org>
2655
2656         Reviewed by Ojan Vafai.
2657
2658         deduplicate-tests should be runnable from any WebKit directory
2659         https://bugs.webkit.org/show_bug.cgi?id=44709
2660
2661         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2662         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2663
2664 2010-09-10  Tony Chang  <tony@chromium.org>
2665
2666         Unreviewed, rolling out r67216.
2667         http://trac.webkit.org/changeset/67216
2668         https://bugs.webkit.org/show_bug.cgi?id=44709
2669
2670         Broke
2671
2672         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2673         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2674
2675 2010-09-10  Tony Chang  <tony@chromium.org>
2676
2677         Reviewed by Ojan Vafai.
2678
2679         deduplicate-tests should be runnable from any WebKit directory
2680         https://bugs.webkit.org/show_bug.cgi?id=44709
2681
2682         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2683         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2684
2685 2010-09-09  Hans Wennborg  <hans@chromium.org>
2686
2687         Reviewed by Jeremy Orlow.
2688
2689         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
2690         https://bugs.webkit.org/show_bug.cgi?id=45460
2691
2692         This enables DumpRenderTree to run layout tests for DeviceOrientation.
2693
2694         Also declare the LayoutTestController destructor out-of-line.
2695         Otherwise the implicit destructor would cause compiler errors because
2696         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
2697
2698         * DumpRenderTree/chromium/LayoutTestController.cpp:
2699         (LayoutTestController::~LayoutTestController):
2700         (LayoutTestController::setMockDeviceOrientation):
2701         (LayoutTestController::deviceOrientationClient):
2702         * DumpRenderTree/chromium/LayoutTestController.h:
2703         * DumpRenderTree/chromium/WebViewHost.cpp:
2704         (WebViewHost::deviceOrientationClient):
2705         * DumpRenderTree/chromium/WebViewHost.h:
2706
2707 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2708
2709         Unreviewed, rolling out r67119.
2710         http://trac.webkit.org/changeset/67119
2711         https://bugs.webkit.org/show_bug.cgi?id=45505
2712
2713         Extra newlines in results (Requested by tony^work on #webkit).
2714
2715         * DumpRenderTree/chromium/LayoutTestController.cpp:
2716         (LayoutTestController::LayoutTestController):
2717         (LayoutTestController::reset):
2718         * DumpRenderTree/chromium/LayoutTestController.h:
2719         * DumpRenderTree/chromium/TestShell.h:
2720         * DumpRenderTree/chromium/WebViewHost.cpp:
2721         (printResponseDescription):
2722         (printNodeDescription):
2723         (printRangeDescription):
2724         (WebViewHost::shouldBeginEditing):
2725         (WebViewHost::shouldEndEditing):
2726         (WebViewHost::shouldInsertNode):
2727         (WebViewHost::shouldChangeSelectedRange):
2728         (WebViewHost::shouldDeleteRange):
2729         (WebViewHost::shouldApplyStyle):
2730         (WebViewHost::didBeginEditing):
2731         (WebViewHost::didChangeSelection):
2732         (WebViewHost::didChangeContents):
2733         (WebViewHost::didEndEditing):
2734         (WebViewHost::decidePolicyForNavigation):
2735         (WebViewHost::didCancelClientRedirect):
2736         (WebViewHost::didStartProvisionalLoad):
2737         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
2738         (WebViewHost::didFailProvisionalLoad):
2739         (WebViewHost::didCommitProvisionalLoad):
2740         (WebViewHost::didFinishDocumentLoad):
2741         (WebViewHost::didHandleOnloadEvents):
2742         (WebViewHost::didFailLoad):
2743         (WebViewHost::didFinishLoad):
2744         (WebViewHost::didChangeLocationWithinPage):
2745         (WebViewHost::willSendRequest):
2746         (WebViewHost::didReceiveResponse):
2747         (WebViewHost::didFinishResourceLoad):
2748         (WebViewHost::didFailResourceLoad):
2749         (WebViewHost::didDisplayInsecureContent):
2750         (WebViewHost::didRunInsecureContent):
2751         (WebViewHost::printFrameDescription):
2752
2753 2010-09-09  Michael Saboff  <msaboff@apple.com>
2754
2755         Unreviewed, adding myself to committers list.
2756
2757         * Scripts/webkitpy/common/config/committers.py:
2758
2759 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
2760
2761         Reviewed by Tony Chang.
2762
2763         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
2764         https://bugs.webkit.org/show_bug.cgi?id=45479
2765
2766         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
2767         implementation in ResourceLoadDelegate in the Mac port).
2768
2769         * DumpRenderTree/chromium/LayoutTestController.cpp:
2770         (LayoutTestController::LayoutTestController):
2771         (LayoutTestController::dumpResourceResponseMIMETypes):
2772         (LayoutTestController::reset):
2773         * DumpRenderTree/chromium/LayoutTestController.h:
2774         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
2775         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
2776         * DumpRenderTree/chromium/TestShell.h:
2777         (TestShell::shouldDumpResourceResponseMIMETypes):
2778         * DumpRenderTree/chromium/WebViewHost.cpp:
2779         (WebViewHost::didReceiveResponse):
2780
2781 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
2782
2783         Reviewed by Daniel Bates.
2784
2785         svn-apply tries to delete directories it shouldn't
2786         https://bugs.webkit.org/show_bug.cgi?id=45424
2787
2788         isDirectoryEmptyForRemoval had the wrong check. If an item in the
2789         directory is itself a directory, then the directory is definitely
2790         not empty.
2791
2792         * Scripts/svn-apply:
2793
2794 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
2795
2796         Fixing GTK and windows build failure.
2797
2798         AX: Support AccessibilityTextMarkers in DRT
2799         https://bugs.webkit.org/show_bug.cgi?id=44778
2800
2801         * DumpRenderTree/AccessibilityTextMarker.h:
2802         (AccessibilityTextMarker::platformTextMarker):
2803         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2804         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2805         (AccessibilityTextMarker::platformTextMarker):
2806         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2807
2808 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
2809
2810         Reviewed by David Kilzer.
2811
2812         AX: Support AccessibilityTextMarkers in DRT
2813         https://bugs.webkit.org/show_bug.cgi?id=44778
2814
2815         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 
2816         that WebCore uses when vending information about its VisiblePositions through AX.
2817
2818         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
2819         methods for encapsulating and checking equality.
2820
2821         This will allow future bug fixes in the text marker system to be adequately tested.
2822
2823         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
2824         (toTextMarker):
2825         (isMarkerEqualCallback):
2826         (markerFinalize):
2827         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
2828         (AccessibilityTextMarker::getJSClass):
2829         (toTextMarkerRange):
2830         (isMarkerRangeEqualCallback):
2831         (markerRangeFinalize):
2832         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
2833         (AccessibilityTextMarkerRange::getJSClass):
2834         * DumpRenderTree/AccessibilityTextMarker.h: Added.
2835         (AccessibilityTextMarker::platformTextMarker):
2836         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2837         (AccessibilityTextMarker::AccessibilityTextMarker):
2838         (AccessibilityTextMarker::~AccessibilityTextMarker):
2839         (AccessibilityTextMarker::isEqual):
2840         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2841         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
2842         (AccessibilityTextMarkerRange::isEqual):
2843         * DumpRenderTree/AccessibilityUIElement.cpp:
2844         (textMarkerRangeForElementCallback):
2845         (textMarkerRangeLengthCallback):
2846         (textMarkerRangeForMarkersCallback):
2847         (startTextMarkerForTextMarkerRangeCallback):
2848         (endTextMarkerForTextMarkerRangeCallback):
2849         (accessibilityElementForTextMarkerCallback):
2850         (AccessibilityUIElement::textMarkerRangeForElement):
2851         (AccessibilityUIElement::textMarkerRangeLength):
2852         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2853         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2854         (AccessibilityUIElement::accessibilityElementForTextMarker):
2855         (AccessibilityUIElement::getJSClass):
2856         * DumpRenderTree/AccessibilityUIElement.h:
2857         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2858         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
2859         (AccessibilityTextMarker::AccessibilityTextMarker):
2860         (AccessibilityTextMarker::~AccessibilityTextMarker):
2861         (AccessibilityTextMarker::isEqual):
2862         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2863         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
2864         (AccessibilityTextMarkerRange::isEqual):
2865         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2866         (AccessibilityUIElement::textMarkerRangeForElement):
2867         (AccessibilityUIElement::textMarkerRangeLength):
2868         (AccessibilityUIElement::textMarkerRangeForMarkers):
2869         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2870         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2871         (AccessibilityUIElement::accessibilityElementForTextMarker):
2872         * DumpRenderTree/win/DumpRenderTree.vcproj:
2873
2874 2010-08-25  Tony Chang  <tony@chromium.org>
2875
2876         Reviewed by Ojan Vafai.
2877
2878         don't delete duplicates needed because of intermediate results
2879         https://bugs.webkit.org/show_bug.cgi?id=44653
2880
2881         Also, output the full path so we can pipe the output to rm.
2882
2883         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2884         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2885
2886 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
2887
2888         Reviewed by Andreas Kling.
2889
2890         [Qt] MiniBrowser does not starts properly
2891         https://bugs.webkit.org/show_bug.cgi?id=45459
2892
2893         Do not try set up the first window by calling newWindow on a
2894         newly created BrowserWindow since it creates a new object.
2895         * MiniBrowser/qt/BrowserWindow.cpp:
2896         (BrowserWindow::BrowserWindow):
2897         * MiniBrowser/qt/main.cpp:
2898         (main):
2899
2900 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
2901
2902         Reviewed by Xan Lopez.
2903
2904         [GTK] Get ImageDiff building on Win32
2905         https://bugs.webkit.org/show_bug.cgi?id=45353
2906
2907         * DumpRenderTree/gtk/ImageDiff.cpp:
2908         (main): Switch from using strtok to g_strsplit.
2909
2910 2010-09-09  Zoltan Horvath  <zoltan@webkit.org>
2911
2912         Reviewed by Andreas Kling.
2913
2914         [Qt] Modify load method of MiniBrowser's BrowserView class
2915         https://bugs.webkit.org/show_bug.cgi?id=45442
2916
2917         Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
2918
2919         * MiniBrowser/qt/BrowserView.cpp:
2920         (BrowserView::load):
2921         * MiniBrowser/qt/BrowserView.h:
2922         * MiniBrowser/qt/BrowserWindow.cpp:
2923         (BrowserWindow::load):
2924
2925 2010-09-09  Tony Chang  <tony@chromium.org>
2926
2927         Reviewed by Ojan Vafai.
2928
2929         fix show_results in new-run-webkit-tests
2930         https://bugs.webkit.org/show_bug.cgi?id=45413
2931
2932         * Scripts/webkitpy/layout_tests/port/chromium.py:
2933
2934 2010-09-08  Victor Wang  <victorw@chromium.org>
2935
2936         Reviewed by Ojan Vafai.
2937
2938         [Chromium] Fix test results server to make sure
2939         it does not have corrupted data.
2940
2941         results.json file size coulbe be >1M and we split
2942         the data into multiple data store entries in this
2943         case. This patch fixes the issue that the data may
2944         be corrupted if data store error happens in the middle
2945         of saving multiple entries.
2946
2947         https://bugs.webkit.org/show_bug.cgi?id=45063
2948
2949         * TestResultServer/model/datastorefile.py:
2950
2951 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
2952
2953         Reviewed by Kenneth Rohde Christiansen.
2954
2955         Fix ignoring return value warning in case of gcc 4.4.4
2956         https://bugs.webkit.org/show_bug.cgi?id=45384
2957
2958         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2959         (testPostURLFile):
2960         If fwrite have written zero byte then the testPostURLFile function
2961         returns with false as tempFile can't be opened.
2962         * DumpRenderTree/qt/ImageDiff.cpp:
2963         (main):
2964         Put fwrite function into an if condition without body to avoid
2965         warning. It is safe because this function writes to the stdout.
2966
2967 2010-09-08  Satish Sampath  <satish@chromium.org>
2968
2969         Unreviewed, adding myself to committers list.
2970
2971         * Scripts/webkitpy/common/config/committers.py:
2972
2973 2010-09-08  Hans Wennborg  <hans@chromium.org>
2974
2975         Unreviewed.
2976
2977         Adding myself as a committer in committers.py.
2978
2979         * Scripts/webkitpy/common/config/committers.py:
2980
2981 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
2982
2983         Reviewed by Simon Hausmann.
2984
2985         [Qt] Refactor MiniBrowser 
2986         https://bugs.webkit.org/show_bug.cgi?id=45173
2987
2988         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
2989
2990         * MiniBrowser/qt/BrowserView.cpp: Added.
2991         (createNewPage):
2992         (BrowserView::BrowserView):
2993         (BrowserView::resizeEvent):
2994         (BrowserView::load):
2995         (BrowserView::view):
2996         * MiniBrowser/qt/BrowserView.h: Added.
2997         (BrowserView::~BrowserView):
2998         * MiniBrowser/qt/BrowserWindow.cpp:
2999         * MiniBrowser/qt/BrowserWindow.h:
3000         * MiniBrowser/qt/MiniBrowser.pro:
3001
3002 2010-09-08  Adam Barth  <abarth@webkit.org>
3003
3004         Rubber-stamped by Eric Seidel.
3005
3006         Rename DocLoader to CachedResourceLoader because that's what it does.
3007
3008         * Scripts/do-webcore-rename:
3009
3010 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
3011
3012         Reviewed by Ojan Vafai.
3013
3014         Enable incremental results.json generation for non-layout tests.
3015         https://bugs.webkit.org/show_bug.cgi?id=45315
3016
3017         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
3018
3019         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
3020
3021
3022 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
3023
3024         Unreviewed, build fix
3025
3026         Missed one test in mac_unittest.py in previous change; for some
3027         reason the method is listed twice. I will fix both for now, but will
3028         figure this out in a later, not-time-sensitive patch.
3029
3030         https://bugs.webkit.org/show_bug.cgi?id=45357
3031
3032         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3033
3034 2010-09-07  Kent Tamura  <tkent@chromium.org>
3035
3036         Reviewed by Tony Chang.
3037
3038         test-webkitpy: Fix load error of
3039         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
3040         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
3041
3042         * Scripts/webkitpy/layout_tests/port/server_process.py:
3043           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
3044           and we don't use server_process.py on Win32 Python. However
3045           unittest.py tries to load everything in a module.
3046
3047 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
3048
3049         Reviewed by Kent Tamura.
3050
3051         Fix regression introduced in previous change to new-run-webkit-tests
3052         (bug 45090) to not try to run unittests for the Mac implementation
3053         of the Port interface if we aren't running on a Mac.
3054
3055         Also fix the overrides implementation mock in the chromium unittests
3056         to fix the case where there are overrides checked in that cause
3057         problems.
3058
3059         https://bugs.webkit.org/show_bug.cgi?id=45357
3060
3061         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3062         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3063         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3064
3065 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
3066
3067         Reviewed by Ojan Vafai.
3068
3069         new-run-webkit-tests: still more unit tests
3070
3071         Clean up and remove unnecessary code. Biggest notable change is
3072         moving the chromium-specific imagediff code from port/base to
3073         port/chromium.
3074
3075         Add more unit tests for run_webkit_tests.py, port/base.py,
3076         port/factory.py, port/dryrun.py, and
3077         layout_package/dump_render_tree_thread.py
3078
3079         This covers almost all of the generic and test code paths except for
3080         a few error paths involving invalid or port-specific command line
3081         arguments, and the code path for uploading results files to the
3082         buildbots.
3083         
3084         https://bugs.webkit.org/show_bug.cgi?id=45090
3085
3086         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
3087         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
3088         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
3089         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
3090         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
3091         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
3092         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
3093         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
3094         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3095         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
3096         * Scripts/webkitpy/layout_tests/port/base.py:
3097         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3098         * Scripts/webkitpy/layout_tests/port/chromium.py:
3099         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3100         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3101         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3102         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
3103         * Scripts/webkitpy/layout_tests/port/server_process.py:
3104         * Scripts/webkitpy/layout_tests/port/test.py:
3105         * Scripts/webkitpy/layout_tests/port/webkit.py:
3106         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3107         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3108
3109 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
3110
3111         Reviewed by Darin Adler.
3112
3113         Provide a way to trigger a <select multiple> onchange event on changes
3114         https://bugs.webkit.org/show_bug.cgi?id=45192
3115
3116         Adds a selector on ObjCController for testing
3117         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
3118         its different uses.
3119
3120         * DumpRenderTree/mac/ObjCController.m:
3121         (+[ObjCController isSelectorExcludedFromWebScript:]):
3122         (+[ObjCController webScriptNameForSelector:]):
3123         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
3124
3125 2010-09-07  James Robinson  <jamesr@chromium.org>
3126
3127         Rubber-stamped by Dimitri Glazkov.
3128
3129         Move myself from the committer to the reviewer list.
3130
3131         * Scripts/webkitpy/common/config/committers.py:
3132
3133 2010-09-07  Tony Chang  <tony@chromium.org>
3134
3135         Reviewed by Darin Fisher.
3136
3137         [chromium] Make a public flag for how DRT generates bitmaps on Linux
3138         https://bugs.webkit.org/show_bug.cgi?id=45133
3139
3140         * DumpRenderTree/chromium/TestShell.cpp:
3141         (TestShell::dumpImage):
3142
3143 2010-09-07  Kent Tamura  <tkent@chromium.org>
3144
3145         Reviewed by Dimitri Glazkov.
3146
3147         [DRT/Chromium] Implement --check-layout-test-sys-deps
3148         https://bugs.webkit.org/show_bug.cgi?id=45283
3149
3150         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3151         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
3152         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
3153         * DumpRenderTree/chromium/TestShellGtk.cpp:
3154         (checkLayoutTestSystemDependencies): Add an empty implementation.
3155         * DumpRenderTree/chromium/TestShellMac.mm:
3156         (checkLayoutTestSystemDependencies): Add an empty implementation.
3157         * DumpRenderTree/chromium/TestShellWin.cpp:
3158         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
3159
3160 2010-09-07  Jessie Berlin  <jberlin@apple.com>
3161
3162         Unreviewed. Mac build fix.
3163
3164         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3165         (didClearWindowObjectForFrame):
3166
3167 2010-09-07  Jessie Berlin  <jberlin@apple.com>
3168
3169         Reviewed by Darin Adler.
3170
3171         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
3172         https://bugs.webkit.org/show_bug.cgi?id=45217
3173         
3174         Make WebKitTestRunner work with this change.
3175
3176         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3177         (WTR::InjectedBundlePage::didClearWindowForFrame):
3178         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
3179         WebFrameLoaderClient.
3180         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3181
3182 2010-09-07  Philippe Normand  <pnormand@igalia.com>
3183
3184         Unreviewed, build fix.
3185
3186         webkit-patch command to find the ports covering a specific layout test
3187         https://bugs.webkit.org/show_bug.cgi?id=42832
3188
3189         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
3190         tests are present when building the expectations. This is needed
3191         for the unittests.
3192
3193 2010-09-06  Philippe Normand  <pnormand@igalia.com>
3194
3195         Reviewed by Adam Barth.
3196
3197         webkit-patch command to find the ports covering a specific layout test
3198         https://bugs.webkit.org/show_bug.cgi?id=42832
3199
3200         To use it: webkit-patch skipped-ports some/layout/test.html
3201
3202         * Scripts/webkitpy/layout_tests/port/base.py:
3203         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3204         * Scripts/webkitpy/layout_tests/port/chromium.py:
3205         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3206         * Scripts/webkitpy/layout_tests/port/factory.py:
3207         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3208         * Scripts/webkitpy/layout_tests/port/test.py:
3209         * Scripts/webkitpy/layout_tests/port/webkit.py:
3210         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3211         * Scripts/webkitpy/tool/commands/queries.py:
3212         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3213         * Scripts/webkitpy/tool/main.py:
3214         * Scripts/webkitpy/tool/mocktool.py:
3215
3216 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3217
3218         Reviewed by Eric Seidel.
3219
3220         [NRWT] Add temp directory to all running drivers.
3221         https://bugs.webkit.org/show_bug.cgi?id=45261
3222
3223         * Scripts/webkitpy/layout_tests/port/webkit.py:
3224
3225 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
3226
3227         Reviewed by Kent Tamura.
3228
3229         [Chromium/DRT] Empty out user stylesheet after each test run.
3230         https://bugs.webkit.org/show_bug.cgi?id=45282
3231
3232         This should significantly cut down on the number of the mysterious flaky tests
3233         whose diffs looked like the page was blown up to a very lage size. This
3234         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
3235         which set the base body font to 100px.
3236
3237         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
3238         the same thread failed.
3239
3240         * DumpRenderTree/chromium/TestShell.cpp:
3241         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
3242
3243 2010-09-06  Kent Tamura  <tkent@chromium.org>
3244
3245         Reviewed by Dimitri Glazkov.
3246
3247         [DRT/Chromium] Do not generate pixel results for text/plain resources
3248         https://bugs.webkit.org/show_bug.cgi?id=45253
3249
3250         * DumpRenderTree/chromium/TestShell.cpp:
3251         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
3252
3253 2010-09-06  Ojan Vafai  <ojan@chromium.org>
3254
3255         Reviewed by Kent Tamura.
3256
3257         print out correct error when a DRT thread dies in NRWT
3258         https://bugs.webkit.org/show_bug.cgi?id=45281
3259
3260         Not sure why, but with the parens, python 2.6.5 on Linux
3261         gives an error that raise takes 5 arguments and 0 were given.
3262         Didn't test other platforms or python versions, but putting it
3263         all on one line fixes it and correctly prints the exception
3264         from the DRT thread.
3265
3266         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3267
3268 2010-09-06  Eric Seidel  <eric@webkit.org>
3269
3270         Unreviewed, just adding some emails from lists.webkit.org.
3271
3272         Update committers.py to include emails from lists.webkit.org
3273         as found by the validate-committer-lists script.
3274
3275         * Scripts/webkitpy/common/config/committers.py:
3276
3277 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
3278
3279         Reviewed by Xan Lopez.
3280
3281         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
3282         https://bugs.webkit.org/show_bug.cgi?id=45213
3283
3284         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3285         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
3286         have to surround the invocation with #ifdefs.
3287         (useLongRunningServerMode): Added.
3288         (runTestingServerLoop): Added.
3289         (initializeGlobalsFromCommandLineOptions): Added.
3290         (runTest): Removed ifdefs.
3291         (main): Use new helper functions.
3292
3293 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
3294
3295         Reviewed by Xan Lopez.
3296
3297         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
3298         https://bugs.webkit.org/show_bug.cgi?id=45235
3299
3300         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
3301         methods of the EventSender.
3302
3303         * DumpRenderTree/gtk/EventSender.cpp:
3304         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
3305         with the current modifiers.
3306         (contextClickCallback): Always send no modifiers when preparing the mouse event.
3307         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
3308         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
3309         (mouseUpCallback): Ditto.
3310
3311 2010-09-05  Peter Kasting  <pkasting@google.com>
3312
3313         Reviewed by Adam Barth.
3314
3315         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
3316         https://bugs.webkit.org/show_bug.cgi?id=45155
3317
3318         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
3319         (EventSender::handleMouseWheel):
3320
3321 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
3322
3323         Reviewed by Joseph Pecoraro.
3324
3325         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
3326         https://bugs.webkit.org/show_bug.cgi?id=45179
3327
3328         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3329         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3330
3331 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
3332
3333         Rubber-stamped by Daniel Bates.
3334
3335         Adding myself as reviewer.
3336
3337         * Scripts/webkitpy/common/config/committers.py:
3338
3339 2010-09-04  Daniel Bates  <dbates@rim.com>
3340
3341         Reviewed by Martin Robinson.
3342
3343         Teach svn-apply/unapply about svn:mergeinfo
3344         https://bugs.webkit.org/show_bug.cgi?id=45236
3345
3346         Recognize the svn:mergeinfo property and ignore it for now.
3347
3348         Currently, svn-apply/unapply recognize only '+' and '-'
3349         property changes within a diff. We should add support
3350         to recognize "Merged" and "Reverse-merged" changes as well.
3351         Because svn:mergeinfo is metadata that is used only by SVN
3352         and tends to be error-prone and/or nuisance (*), we will ignore
3353         it for now.
3354         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
3355
3356         * Scripts/VCSUtils.pm:
3357           - Modified parseSvnProperty() to recognize "Merged" and
3358             "Reverse-merged" as the start of a property value.
3359         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3360           - Added the following unit tests:
3361             "simple: add svn:mergeinfo"
3362             "simple: delete svn:mergeinfo"
3363             "simple: modified svn:mergeinfo"
3364         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3365           - Added the following unit tests:
3366             "simple: add svn:mergeinfo"
3367             "simple: delete svn:mergeinfo"
3368             "simple: modified svn:mergeinfo"
3369             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
3370             "'Merged' change followed by 'Merged' change"
3371             "'Reverse-merged' change followed by 'Reverse-merged' change"
3372         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3373           - Added the following unit tests:
3374             "'Merged' change"
3375             "'Reverse-merged' change"
3376             "'Reverse-merged' change followed by 'Merge' change"
3377             "'Merged' change followed by 'Merge' change"
3378             "'Reverse-merged' change followed by 'Reverse-merged' change"
3379             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
3380
3381 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3382
3383         Reviewed by Kenneth Rohde Christiansen.
3384
3385         [EFL] Move test browser to WebKitTools directory
3386         https://bugs.webkit.org/show_bug.cgi?id=45212
3387
3388         Follow other ports like QT and GTK which moved the test browser to
3389         WebKitTools directory.
3390
3391         * CMakeListsEfl.txt: Added.
3392         * EWebLauncher/main.c: Added.
3393         (print_history):
3394         (zoom_level_set):
3395         (on_ecore_evas_resize):
3396         (title_set):
3397         (viewport_set):
3398         (on_title_changed):
3399         (on_progress):
3400         (on_load_finished):
3401         (on_toolbars_visible_set):
3402         (on_toolbars_visible_get):
3403         (on_statusbar_visible_set):
3404         (on_statusbar_visible_get):
3405         (on_scrollbars_visible_set):
3406         (on_scrollbars_visible_get):
3407         (on_menubar_visible_set):
3408         (on_menubar_visible_get):
3409         (on_tooltip_text_set):
3410         (on_inputmethod_changed):
3411         (on_viewport_changed):
3412         (on_mouse_down):
3413         (on_focus_out):
3414         (on_focus_in):
3415         (on_resized):
3416         (on_key_down):
3417         (on_browser_del):
3418         (on_closeWindow):
3419         (quit):
3420         (browserCreate):
3421         (browserDestroy):
3422         (closeWindow):
3423         (main_signal_exit):
3424         (findThemePath):
3425         (main):
3426
3427 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
3428
3429         Reviewed by Adam Roben.
3430
3431         Set project dependencies so that they build serially. This fixes
3432         issues when running run-webkit-tests if DRT is not built yet.
3433
3434         * DumpRenderTree/DumpRenderTree.sln:
3435
3436 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
3437
3438         Reviewed by Adam Barth.
3439
3440         Fix reading configuraiton in NWRT to work on Windows.
3441         https://bugs.webkit.org/show_bug.cgi?id=45180
3442
3443         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
3444             with the file otherwise.
3445
3446 2010-09-03  Chris Rogers  <crogers@google.com>
3447
3448         Unreviewed
3449
3450         Add myself to the committers list
3451         https://bugs.webkit.org/show_bug.cgi?id=45189
3452
3453         * Scripts/webkitpy/common/config/committers.py:
3454
3455 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
3456
3457         Reviewed by Yury Semikhatsky.
3458
3459         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
3460         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
3461         https://bugs.webkit.org/show_bug.cgi?id=45137
3462
3463         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
3464
3465 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3466
3467         Reviewed by Eric Seidel.
3468
3469         Add feature detection support to NRWT.
3470         https://bugs.webkit.org/show_bug.cgi?id=41842
3471
3472         * Scripts/webkitpy/layout_tests/port/base.py:
3473         * Scripts/webkitpy/layout_tests/port/qt.py:
3474         * Scripts/webkitpy/layout_tests/port/webkit.py:
3475         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
3476
3477 2010-09-03  Hironori Bono  <hbono@chromium.org>
3478
3479         Reviewed by Kent Tamura.
3480
3481         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
3482         and implements it for Mac.
3483         https://bugs.webkit.org/show_bug.cgi?id=41832
3484
3485         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
3486         and bind it so we can call it from JavaScript.
3487         (+[TextInputController isSelectorExcludedFromWebScript:]):
3488         (+[TextInputController webScriptNameForSelector:]):
3489         (-[TextInputController hasSpellingMarker:length:]):
3490
3491 2010-09-02  Eric Seidel  <eric@webkit.org>
3492
3493         Reviewed by Adam Barth.
3494
3495         Add a unit test for commit-queue retries
3496         https://bugs.webkit.org/show_bug.cgi?id=45162
3497
3498         I think commit-queue retries are not correctly avoiding
3499         build and test on retries.  So I started testing the code.
3500         Unfortunately this test did not find the bug.  But now
3501         that we have the test we might as well keep it.
3502         I also fixed a broken import in validate-committer-lists.
3503
3504         * Scripts/validate-committer-lists:
3505         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3506
3507 2010-09-02  Kent Tamura  <tkent@chromium.org>
3508
3509         Reviewed by Dimitri Glazkov.
3510
3511         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
3512         https://bugs.webkit.org/show_bug.cgi?id=45091
3513
3514         Task.{cpp,h} introduces a simpler version of Chromium
3515         base/task.h. It doesn't have TupleN and Method.
3516
3517         * DumpRenderTree/DumpRenderTree.gypi:
3518          Add Task.cpp and Task.h
3519         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3520         (DRTDevToolsAgent::DRTDevToolsAgent):
3521         (DRTDevToolsAgent::reset):
3522         (DRTDevToolsAgent::asyncCall):
3523         (DRTDevToolsAgent::frontendLoaded):
3524         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3525         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
3526         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3527         (DRTDevToolsClient::DRTDevToolsClient):
3528         (DRTDevToolsClient::~DRTDevToolsClient):
3529         (DRTDevToolsClient::reset):
3530         (DRTDevToolsClient::asyncCall):
3531         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3532         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
3533         * DumpRenderTree/chromium/EventSender.cpp:
3534         (EventSender::EventSender):
3535         (EventSender::reset):
3536         (EventSender::scheduleAsynchronousClick):
3537         * DumpRenderTree/chromium/EventSender.h:
3538         (EventSender::taskList): Added to use MethodTask<T>.
3539         * DumpRenderTree/chromium/LayoutTestController.cpp:
3540         (LayoutTestController::LayoutTestController):
3541         (LayoutTestController::WorkQueue::processWorkSoon):
3542         (LayoutTestController::waitUntilDone):
3543         (LayoutTestController::notifyDone):
3544         (LayoutTestController::reset):
3545         * DumpRenderTree/chromium/LayoutTestController.h:
3546         (LayoutTestController::taskList): Added to use MethodTask<T>.
3547         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
3548         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3549         (deferredDisplayDispatch):
3550         (NotificationPresenter::show):
3551         * DumpRenderTree/chromium/Task.cpp: Added.
3552         * DumpRenderTree/chromium/Task.h: Added.
3553
3554 2010-09-02  Steve Block  <steveblock@google.com>
3555
3556         Reviewed by Adam Barth.
3557
3558         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
3559         https://bugs.webkit.org/show_bug.cgi?id=43181
3560
3561         * DumpRenderTree/mac/DumpRenderTree.mm:
3562         (createWebViewAndOffscreenWindow):
3563         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3564         (LayoutTestController::setMockDeviceOrientation):
3565
3566 2010-08-31  Adam Roben  <aroben@apple.com>
3567
3568         Fix flashiness when resizing the browser window on Windows
3569
3570         Reviewed by Sam Weinig.
3571
3572         * MiniBrowser/win/BrowserWindow.cpp:
3573         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
3574         periodically fill the window with white.
3575
3576 2010-09-02  Peter Kasting  <pkasting@google.com>
3577
3578         Reviewed by Dimitri Glazkov.
3579
3580         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
3581         https://bugs.webkit.org/show_bug.cgi?id=45073
3582
3583         * DumpRenderTree/chromium/EventSender.cpp:
3584         (EventSender::EventSender):
3585         (EventSender::mouseScrollBy):